[webkit-changes] [114013] trunk
Title: [114013] trunk
Revision 114013
Author dslo...@google.com
Date 2012-04-12 12:16:49 -0700 (Thu, 12 Apr 2012)
Log Message
Source/WebCore: REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=83427.
Due to incorrect merge by me when landing r113233, call to find got replaces with call to add in
checking for duplicates in ObjectPool when serializing.
Reviewed by Dean Jackson.
Covered by existing tests.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::checkForDuplicate):
LayoutTests: REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=83427.
Bug fixed, unskipping tests.
Reviewed by Dean Jackson.
* platform/mac/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (114012 => 114013)
--- trunk/LayoutTests/ChangeLog 2012-04-12 19:07:07 UTC (rev 114012)
+++ trunk/LayoutTests/ChangeLog 2012-04-12 19:16:49 UTC (rev 114013)
@@ -1,3 +1,13 @@
+2012-04-12 Dmitry Lomov dslo...@google.com
+
+REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
+https://bugs.webkit.org/show_bug.cgi?id=83427.
+Bug fixed, unskipping tests.
+
+Reviewed by Dean Jackson.
+
+* platform/mac/Skipped:
+
2012-04-12 David Barton dbar...@mathscribe.com
Don't modify shared style objects in RenderMathMLRoot.cpp
Modified: trunk/LayoutTests/platform/mac/Skipped (114012 => 114013)
--- trunk/LayoutTests/platform/mac/Skipped 2012-04-12 19:07:07 UTC (rev 114012)
+++ trunk/LayoutTests/platform/mac/Skipped 2012-04-12 19:16:49 UTC (rev 114013)
@@ -789,9 +789,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=83239
fast/animation/request-animation-frame-during-modal.html
-# https://bugs.webkit.org/show_bug.cgi?id=83427
-fast/canvas/webgl/array-message-passing.html
-
# https://bugs.webkit.org/show_bug.cgi?id=77754
# https://bugs.webkit.org/show_bug.cgi?id=83489
# window.resizeTo() does not seem to work as expected in Mac DRT. The outerWidth changes after a resizeTo()
Modified: trunk/Source/WebCore/ChangeLog (114012 => 114013)
--- trunk/Source/WebCore/ChangeLog 2012-04-12 19:07:07 UTC (rev 114012)
+++ trunk/Source/WebCore/ChangeLog 2012-04-12 19:16:49 UTC (rev 114013)
@@ -1,3 +1,17 @@
+2012-04-12 Dmitry Lomov dslo...@google.com
+
+REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
+https://bugs.webkit.org/show_bug.cgi?id=83427.
+Due to incorrect merge by me when landing r113233, call to find got replaces with call to add in
+checking for duplicates in ObjectPool when serializing.
+
+Reviewed by Dean Jackson.
+
+Covered by existing tests.
+
+* bindings/js/SerializedScriptValue.cpp:
+(WebCore::CloneSerializer::checkForDuplicate):
+
2012-04-12 David Barton dbar...@mathscribe.com
Don't modify shared style objects in RenderMathMLRoot.cpp
Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (114012 => 114013)
--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2012-04-12 19:07:07 UTC (rev 114012)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2012-04-12 19:16:49 UTC (rev 114013)
@@ -392,13 +392,13 @@
bool checkForDuplicate(JSObject* object)
{
// Record object for graph reconstruction
-ObjectPool::AddResult addResult = m_objectPool.add(object, m_objectPool.size());
+ObjectPool::const_iterator found = m_objectPool.find(object);
// Handle duplicate references
-if (!addResult.isNewEntry) {
+if (found != m_objectPool.end()) {
write(ObjectReferenceTag);
-ASSERT(static_castint32_t(addResult.iterator-second) m_objectPool.size());
-writeObjectIndex(addResult.iterator-second);
+ASSERT(static_castint32_t(found-second) m_objectPool.size());
+writeObjectIndex(found-second);
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [113233] trunk
Title: [113233] trunk Revision 113233 Author dslo...@google.com Date 2012-04-04 13:43:31 -0700 (Wed, 04 Apr 2012) Log Message Source/WebCore: [JSC] ArrayBufferView and its ArrayBuffer are appended to object pool in wrong order https://bugs.webkit.org/show_bug.cgi?id=82090 The implementation of structured cloning algorithm (http://www.w3.org/TR/html5/common-dom-interfaces.html#internal-structured-cloning-algorithm) in SerializedScriptValue.cpp assigns numerical identifiers to encontered objects as it traverses the cloned object during serialization. When the cloning encounters an already seen object, it transfers the assigned numerical id instead of cloning the object again. Deserialization process then repeats the process in the mirror fashion, i.e. on deserializing the object it assigns deserialized object a numeric id and if it deserializes the id it substitutes the perviously deserialized objects. It is critical that serialization and deserialization assigns numeric ids in the same order. The bug (discovered by Yong Li) is that when serializing ArrayBufferView, the ids were assigned first to the ArrayBufferView and then to underlying ArrayBuffer; however on deserialization the ids were assigned another way round. This patch fixes that by assigning the id first to ArrayBuffer and then to ArrayBufferView, and adds corresponding test cases. Reviewed by Kenneth Russell. New test cases added to fast/canvas/web-gl/array-message-passing.html. * bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::checkForDuplicate): (CloneSerializer): (WebCore::CloneSerializer::recordObject): (WebCore::CloneSerializer::startObjectInternal): (WebCore::CloneSerializer::dumpIfTerminal): LayoutTests: [JSC] ArrayBufferView and its ArrayBuffer are appended to object pool in wrong order https://bugs.webkit.org/show_bug.cgi?id=82090 Adds tests that cover more than one view of the same ArrayBuffer being cloned. Reviewed by Kenneth Russell. * fast/canvas/webgl/array-message-passing-expected.txt: * fast/canvas/webgl/script-tests/array-message-passing.js: (typedArrayCompare): (dataViewCompare): (dataViewCompare2): (dataViewCompare3): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/canvas/webgl/array-message-passing-expected.txt trunk/LayoutTests/fast/canvas/webgl/script-tests/array-message-passing.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp Diff Modified: trunk/LayoutTests/ChangeLog (113232 => 113233) --- trunk/LayoutTests/ChangeLog 2012-04-04 20:31:24 UTC (rev 113232) +++ trunk/LayoutTests/ChangeLog 2012-04-04 20:43:31 UTC (rev 113233) @@ -1,3 +1,18 @@ +2012-04-04 Dmitry Lomov dslo...@google.com + +[JSC] ArrayBufferView and its ArrayBuffer are appended to object pool in wrong order +https://bugs.webkit.org/show_bug.cgi?id=82090 +Adds tests that cover more than one view of the same ArrayBuffer being cloned. + +Reviewed by Kenneth Russell. + +* fast/canvas/webgl/array-message-passing-expected.txt: +* fast/canvas/webgl/script-tests/array-message-passing.js: +(typedArrayCompare): +(dataViewCompare): +(dataViewCompare2): +(dataViewCompare3): + 2012-04-04 Adam Klein ad...@chromium.org Web Inspector: break on DOM node insertion only once per operation, not once per inserted node Modified: trunk/LayoutTests/fast/canvas/webgl/array-message-passing-expected.txt (113232 => 113233) --- trunk/LayoutTests/fast/canvas/webgl/array-message-passing-expected.txt 2012-04-04 20:31:24 UTC (rev 113232) +++ trunk/LayoutTests/fast/canvas/webgl/array-message-passing-expected.txt 2012-04-04 20:43:31 UTC (rev 113233) @@ -23,6 +23,30 @@ PASS DataView1: buffers have the same contents PASS DataView1: offset is 0 PASS DataView1: length is 1 +PASS DataView1-dup: classes are [object DataView] +PASS DataView1-dup: classes are [object ArrayBuffer] +PASS DataView1-dup: buffer lengths are 1 +PASS DataView1-dup: buffers have the same contents +PASS DataView1-dup: offset is 0 +PASS DataView1-dup: length is 1 +PASS DataView1-dup: classes are [object DataView] +PASS DataView1-dup: classes are [object ArrayBuffer] +PASS DataView1-dup: buffer lengths are 1 +PASS DataView1-dup: buffers have the same contents +PASS DataView1-dup: offset is 0 +PASS DataView1-dup: length is 1 +PASS DataView1-dup2: classes are [object DataView] +PASS DataView1-dup2: classes are [object ArrayBuffer] +PASS DataView1-dup2: buffer lengths are 1 +PASS DataView1-dup2: buffers have the same contents +PASS DataView1-dup2: offset is 0 +PASS DataView1-dup2: length is 1 +PASS DataView1-dup2: classes are [object DataView] +PASS DataView1-dup2: classes are [object ArrayBuffer] +PASS DataView1-dup2: buffer lengths are 1 +PASS DataView1-dup2: buffers have the same contents +PASS DataView1-dup2: offset is 0 +PASS DataView1-dup2: length is 1 PASS DataView128: classes are [object DataView] PASS DataView128:
[webkit-changes] [113291] trunk/Source/WebCore
Title: [113291] trunk/Source/WebCore
Revision 113291
Author dslo...@google.com
Date 2012-04-04 22:15:10 -0700 (Wed, 04 Apr 2012)
Log Message
WorkerEventQueue::close might access deleted WorkerEventQueue::EventDispatcherTask.
https://bugs.webkit.org/show_bug.cgi?id=83202
On closing the event queue, WorkerEventQueue cancels all the tasks associated with events.
The tasks in their turn delete themselves from the map whenever task gets executed.
However if shutdown occurs when task is in queue but before task gets executed, the task will be deleted without execution.
This patch makes sure that no deleted tasks stay in WorkerEventQueue, by task removing itself in destructor.
Reviewed by David Levin.
Covered by existing tests.
* workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::EventDispatcherTask::~EventDispatcherTask):
(WorkerEventQueue::EventDispatcherTask):
(WebCore::WorkerEventQueue::EventDispatcherTask::performTask):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerEventQueue.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (113290 => 113291)
--- trunk/Source/WebCore/ChangeLog 2012-04-05 05:13:09 UTC (rev 113290)
+++ trunk/Source/WebCore/ChangeLog 2012-04-05 05:15:10 UTC (rev 113291)
@@ -1,3 +1,22 @@
+2012-04-04 Dmitry Lomov dslo...@google.com
+
+WorkerEventQueue::close might access deleted WorkerEventQueue::EventDispatcherTask.
+https://bugs.webkit.org/show_bug.cgi?id=83202
+
+On closing the event queue, WorkerEventQueue cancels all the tasks associated with events.
+The tasks in their turn delete themselves from the map whenever task gets executed.
+However if shutdown occurs when task is in queue but before task gets executed, the task will be deleted without execution.
+This patch makes sure that no deleted tasks stay in WorkerEventQueue, by task removing itself in destructor.
+
+Reviewed by David Levin.
+
+Covered by existing tests.
+
+* workers/WorkerEventQueue.cpp:
+(WebCore::WorkerEventQueue::EventDispatcherTask::~EventDispatcherTask):
+(WorkerEventQueue::EventDispatcherTask):
+(WebCore::WorkerEventQueue::EventDispatcherTask::performTask):
+
2012-04-04 Julien Chaffraix jchaffr...@webkit.org
RenderLayer scrollbars' updates should be split between layout induced and style change induced
Modified: trunk/Source/WebCore/workers/WorkerEventQueue.cpp (113290 => 113291)
--- trunk/Source/WebCore/workers/WorkerEventQueue.cpp 2012-04-05 05:13:09 UTC (rev 113290)
+++ trunk/Source/WebCore/workers/WorkerEventQueue.cpp 2012-04-05 05:15:10 UTC (rev 113291)
@@ -58,6 +58,12 @@
return adoptPtr(new EventDispatcherTask(event, eventQueue));
}
+virtual ~EventDispatcherTask()
+{
+if (m_event)
+m_eventQueue-removeEvent(m_event.get());
+}
+
void dispatchEvent(ScriptExecutionContext*, PassRefPtrEvent event)
{
event-target()-dispatchEvent(event);
@@ -69,6 +75,7 @@
return;
m_eventQueue-removeEvent(m_event.get());
dispatchEvent(context, m_event);
+m_event.clear();
}
void cancel()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [112576] trunk/Source/WebKit/chromium
Title: [112576] trunk/Source/WebKit/chromium
Revision 112576
Author dslo...@google.com
Date 2012-03-29 14:20:11 -0700 (Thu, 29 Mar 2012)
Log Message
[Chromium] WorkerFileSystemContextObserver can reference a deleted WorkerFileSystemCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=82565
WorkerFileSystemCallbacksBridge relies on a cleanUpAfterCallback being called
prior to the disposal of the bridge to ensure that WorkerFileSystemContextObserver
is unsubscribed and deleted. However cleanUpAfterCallback will only execute if the bridge's
callback has executed on the worker thread, and this might not be the case if the worker
terminates.
This patch fixes this by maintaining a RefPtr from WorkerFileSystemContextObserver to
WorkerFileSystemCallbacksBridge. This ensures that bridge is not deleted while observer is alive.
Reviewed by David Levin.
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemContextObserver::create):
(WebKit::WorkerFileSystemContextObserver::WorkerFileSystemContextObserver):
(WorkerFileSystemContextObserver):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (112575 => 112576)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-29 21:16:23 UTC (rev 112575)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-29 21:20:11 UTC (rev 112576)
@@ -1,3 +1,24 @@
+2012-03-29 Dmitry Lomov dslo...@google.com
+
+[Chromium] WorkerFileSystemContextObserver can reference a deleted WorkerFileSystemCallbacksBridge.
+https://bugs.webkit.org/show_bug.cgi?id=82565
+
+WorkerFileSystemCallbacksBridge relies on a cleanUpAfterCallback being called
+prior to the disposal of the bridge to ensure that WorkerFileSystemContextObserver
+is unsubscribed and deleted. However cleanUpAfterCallback will only execute if the bridge's
+callback has executed on the worker thread, and this might not be the case if the worker
+terminates.
+
+This patch fixes this by maintaining a RefPtr from WorkerFileSystemContextObserver to
+WorkerFileSystemCallbacksBridge. This ensures that bridge is not deleted while observer is alive.
+
+Reviewed by David Levin.
+
+* src/WorkerFileSystemCallbacksBridge.cpp:
+(WebKit::WorkerFileSystemContextObserver::create):
+(WebKit::WorkerFileSystemContextObserver::WorkerFileSystemContextObserver):
+(WorkerFileSystemContextObserver):
+
2012-03-29 Adam Barth aba...@webkit.org
Move CPP files related to ResourceHandle to WebCore/platform
Modified: trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp (112575 => 112576)
--- trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp 2012-03-29 21:16:23 UTC (rev 112575)
+++ trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp 2012-03-29 21:20:11 UTC (rev 112576)
@@ -146,7 +146,7 @@
// that it only gets deleted on the worker context thread which is verified by ~Observer.
class WorkerFileSystemContextObserver : public WebCore::WorkerContext::Observer {
public:
-static PassOwnPtrWorkerFileSystemContextObserver create(WorkerContext* context, WorkerFileSystemCallbacksBridge* bridge)
+static PassOwnPtrWorkerFileSystemContextObserver create(WorkerContext* context, PassRefPtrWorkerFileSystemCallbacksBridge bridge)
{
return adoptPtr(new WorkerFileSystemContextObserver(context, bridge));
}
@@ -158,15 +158,13 @@
}
private:
-WorkerFileSystemContextObserver(WorkerContext* context, WorkerFileSystemCallbacksBridge* bridge)
+WorkerFileSystemContextObserver(WorkerContext* context, PassRefPtrWorkerFileSystemCallbacksBridge bridge)
: WebCore::WorkerContext::Observer(context)
, m_bridge(bridge)
{
}
-// Since WorkerFileSystemCallbacksBridge manages the lifetime of this class,
-// m_bridge will be valid throughout its lifetime.
-WorkerFileSystemCallbacksBridge* m_bridge;
+RefPtrWorkerFileSystemCallbacksBridge m_bridge;
};
void WorkerFileSystemCallbacksBridge::stop()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111089] trunk/Source/WebCore
Title: [111089] trunk/Source/WebCore
Revision 111089
Author dslo...@google.com
Date 2012-03-16 16:49:29 -0700 (Fri, 16 Mar 2012)
Log Message
REGRESSION: DOMURL::revokeObjectURL accesses memoryCache on worker thread.
https://bugs.webkit.org/show_bug.cgi?id=80889
On worker threads, post a task to main thread to evict from cache.
ASSERT that MemoryCache is only accessed from main thread.
Reviewed by David Levin.
* html/DOMURL.cpp:
(WebCore::DOMURL::revokeObjectURL):
* loader/cache/MemoryCache.cpp:
(WebCore::memoryCache):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationFailed):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::evict):
(WebCore):
(WebCore::MemoryCache::removeUrlFromCache):
(WebCore::MemoryCache::removeUrlFromCacheImpl):
* loader/cache/MemoryCache.h:
(WebCore):
(MemoryCache):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/DOMURL.cpp
trunk/Source/WebCore/loader/cache/MemoryCache.cpp
trunk/Source/WebCore/loader/cache/MemoryCache.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (111088 => 111089)
--- trunk/Source/WebCore/ChangeLog 2012-03-16 23:47:05 UTC (rev 111088)
+++ trunk/Source/WebCore/ChangeLog 2012-03-16 23:49:29 UTC (rev 111089)
@@ -1,3 +1,27 @@
+2012-03-16 Dmitry Lomov dslo...@google.com
+
+REGRESSION: DOMURL::revokeObjectURL accesses memoryCache on worker thread.
+https://bugs.webkit.org/show_bug.cgi?id=80889
+On worker threads, post a task to main thread to evict from cache.
+ASSERT that MemoryCache is only accessed from main thread.
+
+Reviewed by David Levin.
+
+* html/DOMURL.cpp:
+(WebCore::DOMURL::revokeObjectURL):
+* loader/cache/MemoryCache.cpp:
+(WebCore::memoryCache):
+(WebCore::MemoryCache::add):
+(WebCore::MemoryCache::revalidationFailed):
+(WebCore::MemoryCache::resourceForURL):
+(WebCore::MemoryCache::evict):
+(WebCore):
+(WebCore::MemoryCache::removeUrlFromCache):
+(WebCore::MemoryCache::removeUrlFromCacheImpl):
+* loader/cache/MemoryCache.h:
+(WebCore):
+(MemoryCache):
+
2012-03-16 Jacky Jiang zhaji...@rim.com
[BlackBerry] Upstream ScriptControllerBlackBerry.cpp
Modified: trunk/Source/WebCore/html/DOMURL.cpp (111088 => 111089)
--- trunk/Source/WebCore/html/DOMURL.cpp 2012-03-16 23:47:05 UTC (rev 111088)
+++ trunk/Source/WebCore/html/DOMURL.cpp 2012-03-16 23:49:29 UTC (rev 111089)
@@ -89,10 +89,9 @@
if (!scriptExecutionContext)
return;
-KURL url(KURL(), urlString);
-if (CachedResource* resource = memoryCache()-resourceForURL(url))
-memoryCache()-remove(resource);
+MemoryCache::removeUrlFromCache(scriptExecutionContext, urlString);
+KURL url(KURL(), urlString);
HashSetString blobURLs = scriptExecutionContext-publicURLManager().blobURLs();
if (blobURLs.contains(url.string())) {
ThreadableBlobRegistry::unregisterBlobURL(url);
Modified: trunk/Source/WebCore/loader/cache/MemoryCache.cpp (111088 => 111089)
--- trunk/Source/WebCore/loader/cache/MemoryCache.cpp 2012-03-16 23:47:05 UTC (rev 111088)
+++ trunk/Source/WebCore/loader/cache/MemoryCache.cpp 2012-03-16 23:49:29 UTC (rev 111089)
@@ -29,6 +29,7 @@
#include CachedScript.h
#include CachedXSLStyleSheet.h
#include CachedResourceLoader.h
+#include CrossThreadTask.h
#include Document.h
#include FrameLoader.h
#include FrameLoaderTypes.h
@@ -38,6 +39,9 @@
#include ResourceHandle.h
#include SecurityOrigin.h
#include SecurityOriginHash.h
+#include WorkerContext.h
+#include WorkerLoaderProxy.h
+#include WorkerThread.h
#include stdio.h
#include wtf/CurrentTime.h
#include wtf/text/CString.h
@@ -54,6 +58,7 @@
MemoryCache* memoryCache()
{
static MemoryCache* staticCache = new MemoryCache;
+ASSERT(WTF::isMainThread());
return staticCache;
}
@@ -88,6 +93,7 @@
{
if (disabled())
return false;
+ASSERT(WTF::isMainThread());
m_resources.set(resource-url(), resource);
resource-setInCache(true);
@@ -132,6 +138,7 @@
void MemoryCache::revalidationFailed(CachedResource* revalidatingResource)
{
+ASSERT(WTF::isMainThread());
LOG(ResourceLoading, Revalidation failed for %p, revalidatingResource);
ASSERT(revalidatingResource-resourceToRevalidate());
revalidatingResource-clearResourceToRevalidate();
@@ -139,6 +146,7 @@
CachedResource* MemoryCache::resourceForURL(const KURL resourceURL)
{
+ASSERT(WTF::isMainThread());
KURL url = ""
CachedResource* resource = m_resources.get(url);
bool wasPurgeable = MemoryCache::shouldMakeResourcePurgeableOnEviction() resource resource-isPurgeable();
@@ -369,6 +377,7 @@
void MemoryCache::evict(CachedResource* resource)
{
+ASSERT(WTF::isMainThread());
LOG(ResourceLoading, Evicting resource %p for '%s' from cache, resource, resource-url().string().latin1().data());
// The resource may have
[webkit-changes] [109233] trunk/LayoutTests
Title: [109233] trunk/LayoutTests
Revision 109233
Author dslo...@google.com
Date 2012-02-29 11:08:24 -0800 (Wed, 29 Feb 2012)
Log Message
Unreviewed: updating expectations for chromium (error messages)
* platform/chromium/fast/events/message-port-multi-expected.txt: Added.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Added Paths
trunk/LayoutTests/platform/chromium/fast/events/message-port-multi-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (109232 => 109233)
--- trunk/LayoutTests/ChangeLog 2012-02-29 18:56:11 UTC (rev 109232)
+++ trunk/LayoutTests/ChangeLog 2012-02-29 19:08:24 UTC (rev 109233)
@@ -1,3 +1,10 @@
+2012-02-29 Dmitry Lomov dslo...@google.com
+
+Unreviewed: updating expectations for chrmium (error messages)
+
+* platform/chromium/fast/events/message-port-multi-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
2012-02-29 Parag Radke pa...@motorola.com
Crash in WebCore::CompositeEditCommand::insertNodeAt
Added: trunk/LayoutTests/platform/chromium/fast/events/message-port-multi-expected.txt (0 => 109233)
--- trunk/LayoutTests/platform/chromium/fast/events/message-port-multi-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/message-port-multi-expected.txt 2012-02-29 19:08:24 UTC (rev 109233)
@@ -0,0 +1,23 @@
+This test checks the various use cases around sending multiple ports through MessagePort.postMessage
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS channel.port1.postMessage(same port, [channel.port1]) threw exception Error: DATA_CLONE_ERR: DOM Exception 25.
+PASS channel.port1.postMessage(entangled port, [channel.port2]) threw exception Error: DATA_CLONE_ERR: DOM Exception 25.
+PASS channel.port1.postMessage(null port, [channel3.port1, null, channel3.port2]) threw exception Error: DATA_CLONE_ERR: DOM Exception 25.
+PASS channel.port1.postMessage(notAPort, [channel3.port1, {}, channel3.port2]) threw exception TypeError: TransferArray argument must contain only Transferables.
+PASS channel.port1.postMessage(notAnArray, channel3.port1) threw exception TypeError: TransferArray argument has no length attribute.
+PASS channel.port1.postMessage(notASequence, [{length: 3}]) threw exception TypeError: TransferArray argument must contain only Transferables.
+PASS channel.port1.postMessage(largeSequence, largePortArray) threw exception Error: DATA_CLONE_ERR: DOM Exception 25.
+PASS event.ports is non-null and zero length when no port sent
+PASS event.ports is non-null and zero length when empty array sent
+PASS event.ports contains two ports when two ports sent
+PASS event.ports contains two ports when two ports re-sent after error
+PASS Sending host object has thrown Error: DATA_CLONE_ERR: DOM Exception 25
+PASS send-port: transferred one port
+PASS send-port-twice: transferred one port twice
+PASS send-two-ports: transferred two ports
+
+TEST COMPLETE
+
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109232 => 109233)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 18:56:11 UTC (rev 109232)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 19:08:24 UTC (rev 109233)
@@ -237,7 +237,6 @@
WONTFIX SKIP : fast/events/message-port-inactive-document.html = FAIL
WONTFIX SKIP : fast/events/message-port-no-wrapper.html = FAIL
WONTFIX SKIP : fast/events/message-port.html = FAIL
-WONTFIX SKIP : fast/events/message-port-multi.html = FAIL
WONTFIX SKIP : http/tests/security/MessagePort/event-listener-context.html = FAIL
// Chrome does not support Java LiveConnect.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108613] trunk
Title: [108613] trunk Revision 108613 Author dslo...@google.com Date 2012-02-22 23:04:54 -0800 (Wed, 22 Feb 2012) Log Message [Chromium][V8] Support Uint8ClampedArray in postMessage https://bugs.webkit.org/show_bug.cgi?id=79291. Reviewed by Kenneth Russell. Source/WebCore: Covered by existing tests. * bindings/v8/SerializedScriptValue.cpp: LayoutTests: * platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp Removed Paths trunk/LayoutTests/platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (108612 => 108613) --- trunk/LayoutTests/ChangeLog 2012-02-23 06:50:04 UTC (rev 108612) +++ trunk/LayoutTests/ChangeLog 2012-02-23 07:04:54 UTC (rev 108613) @@ -1,3 +1,12 @@ +2012-02-22 Dmitry Lomov dslo...@google.com + +[Chromium][V8] Support Uint8ClampedArray in postMessage +https://bugs.webkit.org/show_bug.cgi?id=79291. + +Reviewed by Kenneth Russell. + +* platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Removed. + 2012-02-22 Kent Tamura tk...@chromium.org Move input type=radio tests to fast/forms/radio/ Deleted: trunk/LayoutTests/platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt (108612 => 108613) --- trunk/LayoutTests/platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt 2012-02-23 06:50:04 UTC (rev 108612) +++ trunk/LayoutTests/platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt 2012-02-23 07:04:54 UTC (rev 108613) @@ -1,610 +0,0 @@ -Test passing ArrayBuffers and ArrayBufferViews in messages. - -On success, you will see a series of PASS messages, followed by TEST COMPLETE. - -PASS ArrayBuffer0: classes are [object ArrayBuffer] -PASS ArrayBuffer0: buffer lengths are 0 -PASS ArrayBuffer0: buffers have the same contents -PASS ArrayBuffer1: classes are [object ArrayBuffer] -PASS ArrayBuffer1: buffer lengths are 1 -PASS ArrayBuffer1: buffers have the same contents -PASS ArrayBuffer128: classes are [object ArrayBuffer] -PASS ArrayBuffer128: buffer lengths are 128 -PASS ArrayBuffer128: buffers have the same contents -PASS DataView0: classes are [object DataView] -PASS DataView0: classes are [object ArrayBuffer] -PASS DataView0: buffer lengths are 0 -PASS DataView0: buffers have the same contents -PASS DataView0: offset is 0 -PASS DataView0: length is 0 -PASS DataView1: classes are [object DataView] -PASS DataView1: classes are [object ArrayBuffer] -PASS DataView1: buffer lengths are 1 -PASS DataView1: buffers have the same contents -PASS DataView1: offset is 0 -PASS DataView1: length is 1 -PASS DataView128: classes are [object DataView] -PASS DataView128: classes are [object ArrayBuffer] -PASS DataView128: buffer lengths are 128 -PASS DataView128: buffers have the same contents -PASS DataView128: offset is 0 -PASS DataView128: length is 128 -PASS DataView1_offset_at_end: classes are [object DataView] -PASS DataView1_offset_at_end: classes are [object ArrayBuffer] -PASS DataView1_offset_at_end: buffer lengths are 1 -PASS DataView1_offset_at_end: buffers have the same contents -PASS DataView1_offset_at_end: offset is 1 -PASS DataView1_offset_at_end: length is 0 -PASS DataView128_offset_at_end: classes are [object DataView] -PASS DataView128_offset_at_end: classes are [object ArrayBuffer] -PASS DataView128_offset_at_end: buffer lengths are 128 -PASS DataView128_offset_at_end: buffers have the same contents -PASS DataView128_offset_at_end: offset is 128 -PASS DataView128_offset_at_end: length is 0 -PASS DataView128_offset_slice_length_0: classes are [object DataView] -PASS DataView128_offset_slice_length_0: classes are [object ArrayBuffer] -PASS DataView128_offset_slice_length_0: buffer lengths are 128 -PASS DataView128_offset_slice_length_0: buffers have the same contents -PASS DataView128_offset_slice_length_0: offset is 64 -PASS DataView128_offset_slice_length_0: length is 0 -PASS DataView128_offset_slice_length_1: classes are [object DataView] -PASS DataView128_offset_slice_length_1: classes are [object ArrayBuffer] -PASS DataView128_offset_slice_length_1: buffer lengths are 128 -PASS DataView128_offset_slice_length_1: buffers have the same contents -PASS DataView128_offset_slice_length_1: offset is 64 -PASS DataView128_offset_slice_length_1: length is 1 -PASS DataView128_offset_slice_length_16: classes are [object DataView] -PASS DataView128_offset_slice_length_16: classes are [object ArrayBuffer] -PASS DataView128_offset_slice_length_16: buffer lengths are 128 -PASS DataView128_offset_slice_length_16: buffers have the same contents -PASS DataView128_offset_slice_length_16: offset is 64 -PASS DataView128_offset_slice_length_16: length is 16 -PASS DataView128_offset_slice_unaligned: classes are [object DataView] -PASS
[webkit-changes] [106821] branches/chromium/1025/Source/WebCore/bindings/v8/V8Helpers.cpp
Title: [106821] branches/chromium/1025/Source/WebCore/bindings/v8/V8Helpers.cpp
Revision 106821
Author dslo...@google.com
Date 2012-02-06 11:13:27 -0800 (Mon, 06 Feb 2012)
Log Message
Merge 106722 - [Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
https://bugs.webkit.org/show_bug.cgi?id=77686.
Reviewed by Adam Barth.
* bindings/v8/V8Helpers.cpp:
(WebCore::toV8Context):
TBR=dslo...@google.com
Review URL: https://chromiumcodereview.appspot.com/9334005
Modified Paths
branches/chromium/1025/Source/WebCore/bindings/v8/V8Helpers.cpp
Diff
Modified: branches/chromium/1025/Source/WebCore/bindings/v8/V8Helpers.cpp (106820 => 106821)
--- branches/chromium/1025/Source/WebCore/bindings/v8/V8Helpers.cpp 2012-02-06 19:01:11 UTC (rev 106820)
+++ branches/chromium/1025/Source/WebCore/bindings/v8/V8Helpers.cpp 2012-02-06 19:13:27 UTC (rev 106821)
@@ -42,7 +42,7 @@
{
V8NPObject* object = reinterpret_castV8NPObject*(npObject);
DOMWindow* domWindow = object-rootObject;
-if (!domWindow || domWindow != domWindow-frame()-domWindow())
+if (!domWindow || !domWindow-frame() || domWindow != domWindow-frame()-domWindow())
return v8::Localv8::Context();
return V8Proxy::mainWorldContext(object-rootObject-frame());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [106722] trunk/Source/WebCore
Title: [106722] trunk/Source/WebCore
Revision 106722
Author dslo...@google.com
Date 2012-02-03 17:45:14 -0800 (Fri, 03 Feb 2012)
Log Message
[Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
https://bugs.webkit.org/show_bug.cgi?id=77686.
Reviewed by Adam Barth.
* bindings/v8/V8Helpers.cpp:
(WebCore::toV8Context):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Helpers.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (106721 => 106722)
--- trunk/Source/WebCore/ChangeLog 2012-02-04 01:41:14 UTC (rev 106721)
+++ trunk/Source/WebCore/ChangeLog 2012-02-04 01:45:14 UTC (rev 106722)
@@ -1,3 +1,13 @@
+2012-02-03 Dmitry Lomov dslo...@google.com
+
+[Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
+https://bugs.webkit.org/show_bug.cgi?id=77686.
+
+Reviewed by Adam Barth.
+
+* bindings/v8/V8Helpers.cpp:
+(WebCore::toV8Context):
+
2012-02-03 Anders Carlsson ander...@apple.com
The scrolling tree should be able to handle wheel events
Modified: trunk/Source/WebCore/bindings/v8/V8Helpers.cpp (106721 => 106722)
--- trunk/Source/WebCore/bindings/v8/V8Helpers.cpp 2012-02-04 01:41:14 UTC (rev 106721)
+++ trunk/Source/WebCore/bindings/v8/V8Helpers.cpp 2012-02-04 01:45:14 UTC (rev 106722)
@@ -42,7 +42,7 @@
{
V8NPObject* object = reinterpret_castV8NPObject*(npObject);
DOMWindow* domWindow = object-rootObject;
-if (!domWindow || domWindow != domWindow-frame()-domWindow())
+if (!domWindow || !domWindow-frame() || domWindow != domWindow-frame()-domWindow())
return v8::Localv8::Context();
return V8Proxy::mainWorldContext(object-rootObject-frame());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105794] trunk/Source/WebKit/chromium
Title: [105794] trunk/Source/WebKit/chromium Revision 105794 Author dslo...@google.com Date 2012-01-24 13:22:07 -0800 (Tue, 24 Jan 2012) Log Message Unreviewed: removing WebWorker.h again after r105684. * WebKit.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (105793 => 105794) --- trunk/Source/WebKit/chromium/ChangeLog 2012-01-24 21:20:47 UTC (rev 105793) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-24 21:22:07 UTC (rev 105794) @@ -1,3 +1,9 @@ +2012-01-24 Dmitry Lomov dslo...@google.com + +Unreviewed: removing WebWorker.h again after r105684. + +* WebKit.gyp: + 2012-01-24 Tommy Widenflycht tom...@google.com MediaStream API: Split the MediaStream track list into audio/video specific ones. Modified: trunk/Source/WebKit/chromium/WebKit.gyp (105793 => 105794) --- trunk/Source/WebKit/chromium/WebKit.gyp 2012-01-24 21:20:47 UTC (rev 105793) +++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-01-24 21:22:07 UTC (rev 105794) @@ -268,7 +268,6 @@ 'public/WebViewClient.h', 'public/WebWidget.h', 'public/WebWidgetClient.h', -'public/WebWorker.h', 'public/WebWorkerInfo.h', 'public/WebWorkerRunLoop.h', 'public/android/WebInputEventFactory.h', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105815] trunk/Source/WebCore
Title: [105815] trunk/Source/WebCore
Revision 105815
Author dslo...@google.com
Date 2012-01-24 14:52:24 -0800 (Tue, 24 Jan 2012)
Log Message
[Chromium][V8] DOMWindow::postMessage crashes if window disassociated with frame.
https://bugs.webkit.org/show_bug.cgi?id=76944.
Reviewed by David Levin.
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::retrieveWindowForCallingContext):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp
trunk/Source/WebCore/bindings/v8/V8Proxy.h
trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (105814 => 105815)
--- trunk/Source/WebCore/ChangeLog 2012-01-24 22:39:21 UTC (rev 105814)
+++ trunk/Source/WebCore/ChangeLog 2012-01-24 22:52:24 UTC (rev 105815)
@@ -1,3 +1,16 @@
+2012-01-24 Dmitry Lomov dslo...@google.com
+
+[Chromium][V8] DOMWindow::postMessage crashes if window disassociated with frame.
+https://bugs.webkit.org/show_bug.cgi?id=76944.
+
+Reviewed by David Levin.
+
+* bindings/v8/V8Proxy.cpp:
+(WebCore::V8Proxy::retrieveWindowForCallingContext):
+* bindings/v8/V8Proxy.h:
+* bindings/v8/custom/V8DOMWindowCustom.cpp:
+(WebCore::handlePostMessageCallback):
+
2012-01-24 Geoffrey Garen gga...@apple.com
Updated bindings test expectations after my last patch.
Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.cpp (105814 => 105815)
--- trunk/Source/WebCore/bindings/v8/V8Proxy.cpp 2012-01-24 22:39:21 UTC (rev 105814)
+++ trunk/Source/WebCore/bindings/v8/V8Proxy.cpp 2012-01-24 22:52:24 UTC (rev 105815)
@@ -492,6 +492,14 @@
return retrieveFrame(context);
}
+DOMWindow* V8Proxy::retrieveWindowForCallingContext()
+{
+v8::Handlev8::Context context = v8::Context::GetCalling();
+if (context.IsEmpty())
+return 0;
+return retrieveWindow(context);
+}
+
Frame* V8Proxy::retrieveFrameForCallingContext()
{
v8::Handlev8::Context context = v8::Context::GetCalling();
Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.h (105814 => 105815)
--- trunk/Source/WebCore/bindings/v8/V8Proxy.h 2012-01-24 22:39:21 UTC (rev 105814)
+++ trunk/Source/WebCore/bindings/v8/V8Proxy.h 2012-01-24 22:52:24 UTC (rev 105815)
@@ -169,6 +169,9 @@
// Returns the window object associated with a context.
static DOMWindow* retrieveWindow(v8::Handlev8::Context);
+
+static DOMWindow* retriveWindowForCallingCOntext();
+
// Returns V8Proxy object of the currently executing context.
static V8Proxy* retrieve();
// Returns V8Proxy object associated with a frame.
@@ -211,6 +214,7 @@
// linking time.
static Frame* retrieveFrameForEnteredContext();
static Frame* retrieveFrameForCurrentContext();
+static DOMWindow* retrieveWindowForCallingContext();
static Frame* retrieveFrameForCallingContext();
// Returns V8 Context of a frame. If none exists, creates
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp (105814 => 105815)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2012-01-24 22:39:21 UTC (rev 105814)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2012-01-24 22:52:24 UTC (rev 105815)
@@ -296,11 +296,11 @@
static v8::Handlev8::Value handlePostMessageCallback(const v8::Arguments args, bool extendedTransfer)
{
+// None of these need to be RefPtr because args and context are guaranteed
+// to hold on to them.
DOMWindow* window = V8DOMWindow::toNative(args.Holder());
+DOMWindow* source = V8Proxy::retrieveWindowForCallingContext();
-DOMWindow* source = V8Proxy::retrieveFrameForCallingContext()-domWindow();
-ASSERT(source-frame());
-
// This function has variable arguments and can be:
// Per current spec:
// postMessage(message, targetOrigin)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105684] trunk
Title: [105684] trunk Revision 105684 Author dslo...@google.com Date 2012-01-23 20:07:56 -0800 (Mon, 23 Jan 2012) Log Message Source/WebKit/chromium: [Chromium] Implement layoutTestController.workerThreadCount in DRT https://bugs.webkit.org/show_bug.cgi?id=74653. Expose WebCore::WorkerThread::workerThreadCount() in API layer for DumpRenderTree. Reviewed by Darin Fisher. * WebKit.gyp: * public/WebWorkerInfo.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h. * src/WebWorkerInfo.cpp: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h. (WebKit::WebWorkerInfo::dedicatedWorkerCount): Tools: [Chromium] Implement layoutTestController.workerThreadCount in DRT https://bugs.webkit.org/show_bug.cgi?id=74653. Reviewed by Darin Fisher. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::workerThreadCount): * DumpRenderTree/chromium/LayoutTestController.h: LayoutTests: [Chromium] Implement layoutTestController.workerThreadCount in DRT https://bugs.webkit.org/show_bug.cgi?id=74653. Reviewed by Darin Fisher. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h Added Paths trunk/Source/WebKit/chromium/public/WebWorkerInfo.h trunk/Source/WebKit/chromium/src/WebWorkerInfo.cpp Diff Modified: trunk/LayoutTests/ChangeLog (105683 => 105684) --- trunk/LayoutTests/ChangeLog 2012-01-24 03:59:55 UTC (rev 105683) +++ trunk/LayoutTests/ChangeLog 2012-01-24 04:07:56 UTC (rev 105684) @@ -1,3 +1,12 @@ +2012-01-23 Dmitry Lomov dslo...@google.com + +[Chromium] Implement layoutTestController.workerThreadCount in DRT +https://bugs.webkit.org/show_bug.cgi?id=74653. + +Reviewed by Darin Fisher. + +* platform/chromium/test_expectations.txt: + 2012-01-23 Emil A Eklund e...@chromium.org Unreviewed test expectations fixes for a couple of window/frame tests. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (105683 => 105684) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-24 03:59:55 UTC (rev 105683) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-24 04:07:56 UTC (rev 105684) @@ -193,16 +193,6 @@ BUGWK74459 SKIP : fast/workers/worker-messageport.html = CRASH BUGWK74459 SKIP : fast/workers/worker-multi-port.html = CRASH -BUGWK74449 SKIP : fast/workers/dedicated-worker-lifecycle.html = TIMEOUT -BUGWK74449 SKIP : fast/workers/worker-close-more.html = TIMEOUT -BUGWK74449 SKIP : fast/workers/worker-lifecycle.html = TIMEOUT - - -// Tests timing out because layoutTestController.workerThreadCount is not implemented in DRT -BUGWK74653 SKIP : http/tests/xmlhttprequest/workers/abort-exception-assert.html = TIMEOUT -BUGWK74653 SKIP : http/tests/workers/terminate-during-sync-operation.html = TIMEOUT -BUGWK74653 SKIP : fast/workers/storage/interrupt-database.html = TIMEOUT - BUGWK71968 : fast/files/workers/worker-apply-blob-url-to-xhr.html = TEXT BUGCR108798 LINUX : fast/filesystem/workers/file-writer-events.html = CRASH PASS Modified: trunk/Source/WebKit/chromium/ChangeLog (105683 => 105684) --- trunk/Source/WebKit/chromium/ChangeLog 2012-01-24 03:59:55 UTC (rev 105683) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-24 04:07:56 UTC (rev 105684) @@ -1,3 +1,17 @@ +2012-01-23 Dmitry Lomov dslo...@google.com + +[Chromium] Implement layoutTestController.workerThreadCount in DRT +https://bugs.webkit.org/show_bug.cgi?id=74653. +Expose WebCore::WorkerThread::workerThreadCount() in API layer +for DumpRenderTree. + +Reviewed by Darin Fisher. + +* WebKit.gyp: +* public/WebWorkerInfo.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h. +* src/WebWorkerInfo.cpp: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h. +(WebKit::WebWorkerInfo::dedicatedWorkerCount): + 2012-01-23 Greg Billock gbill...@google.com Fine tune Web Intents Chromium API Modified: trunk/Source/WebKit/chromium/WebKit.gyp (105683 => 105684) --- trunk/Source/WebKit/chromium/WebKit.gyp 2012-01-24 03:59:55 UTC (rev 105683) +++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-01-24 04:07:56 UTC (rev 105684) @@ -268,6 +268,8 @@ 'public/WebViewClient.h', 'public/WebWidget.h', 'public/WebWidgetClient.h', +'public/WebWorker.h', +'public/WebWorkerInfo.h', 'public/WebWorkerRunLoop.h', 'public/android/WebInputEventFactory.h', 'public/android/WebSandboxSupport.h', @@ -668,6 +670,7 @@
[webkit-changes] [105020] trunk/Source/WebKit/chromium
Title: [105020] trunk/Source/WebKit/chromium
Revision 105020
Author dslo...@google.com
Date 2012-01-14 11:11:21 -0800 (Sat, 14 Jan 2012)
Log Message
[Chromium] Remove WebKit::WebWorker class.
https://bugs.webkit.org/show_bug.cgi?id=76327
Reviewed by Darin Fisher.
* public/WebWorker.h: Removed.
* src/WebWorkerClientImpl.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp
Removed Paths
trunk/Source/WebKit/chromium/public/WebWorker.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (105019 => 105020)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-14 15:51:35 UTC (rev 105019)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-14 19:11:21 UTC (rev 105020)
@@ -1,3 +1,13 @@
+2012-01-14 Dmitry Lomov dslo...@google.com
+
+[Chromium] Remove WebKit::WebWorker class.
+https://bugs.webkit.org/show_bug.cgi?id=76327
+
+Reviewed by Darin Fisher.
+
+* public/WebWorker.h: Removed.
+* src/WebWorkerClientImpl.cpp:
+
2012-01-13 David Levin le...@chromium.org
HWndDC is a better name than HwndDC.
Deleted: trunk/Source/WebKit/chromium/public/WebWorker.h (105019 => 105020)
--- trunk/Source/WebKit/chromium/public/WebWorker.h 2012-01-14 15:51:35 UTC (rev 105019)
+++ trunk/Source/WebKit/chromium/public/WebWorker.h 2012-01-14 19:11:21 UTC (rev 105020)
@@ -1,62 +0,0 @@
-/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef WebWorker_h
-#define WebWorker_h
-
-#include WebMessagePortChannel.h
-
-namespace WebKit {
-
-class WebString;
-class WebURL;
-class WebWorkerClient;
-
-// Provides an interface to the script execution context for a worker.
-class WebWorker {
-public:
-// Instantiates a built-in WebWorker.
-WEBKIT_EXPORT static WebWorker* create(WebWorkerClient*);
-
-virtual ~WebWorker() { }
-virtual void startWorkerContext(const WebURL scriptURL,
-const WebString userAgent,
-const WebString sourceCode) = 0;
-virtual void terminateWorkerContext() = 0;
-virtual void postMessageToWorkerContext(
-const WebString,
-const WebMessagePortChannelArray) = 0;
-virtual void workerObjectDestroyed() = 0;
-virtual void clientDestroyed() = 0;
-};
-
-} // namespace WebKit
-
-#endif
Modified: trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp (105019 => 105020)
--- trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp 2012-01-14 15:51:35 UTC (rev 105019)
+++ trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp 2012-01-14 19:11:21 UTC (rev 105020)
@@ -62,7 +62,6 @@
#include platform/WebString.h
#include platform/WebURL.h
#include WebViewImpl.h
-#include WebWorker.h
using namespace WebCore;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104717] trunk
Title: [104717] trunk
Revision 104717
Author dslo...@google.com
Date 2012-01-11 09:40:58 -0800 (Wed, 11 Jan 2012)
Log Message
[Chromium] Remove obsolete references to WebWorker class.
https://bugs.webkit.org/show_bug.cgi?id=76020
Reviewed by David Levin.
Source/WebKit/chromium:
* public/WebFrameClient.h:
* public/WebSharedWorkerClient.h:
Tools:
* DumpRenderTree/chromium/TestWebWorker.h: Removed.
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebFrameClient.h
trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h
Removed Paths
trunk/Tools/DumpRenderTree/chromium/TestWebWorker.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (104716 => 104717)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-11 17:36:20 UTC (rev 104716)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-11 17:40:58 UTC (rev 104717)
@@ -1,3 +1,13 @@
+2012-01-10 Dmitry Lomov dslo...@google.com
+
+[Chromium] Remove obsolete references to WebWorker class.
+https://bugs.webkit.org/show_bug.cgi?id=76020
+
+Reviewed by David Levin.
+
+* public/WebFrameClient.h:
+* public/WebSharedWorkerClient.h:
+
2012-01-11 Jochen Eisinger joc...@chromium.org
Move the check for canExecuteScripts out of V8Proxy::retrieve
Modified: trunk/Source/WebKit/chromium/public/WebFrameClient.h (104716 => 104717)
--- trunk/Source/WebKit/chromium/public/WebFrameClient.h 2012-01-11 17:36:20 UTC (rev 104716)
+++ trunk/Source/WebKit/chromium/public/WebFrameClient.h 2012-01-11 17:40:58 UTC (rev 104717)
@@ -83,9 +83,6 @@
virtual WebPlugin* createPlugin(WebFrame*, const WebPluginParams) { return 0; }
// May return null.
-virtual WebWorker* createWorker(WebFrame*, WebSharedWorkerClient*) { return 0; }
-
-// May return null.
virtual WebSharedWorker* createSharedWorker(WebFrame*, const WebURL, const WebString, unsigned long long) { return 0; }
// May return null.
Modified: trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h (104716 => 104717)
--- trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h 2012-01-11 17:36:20 UTC (rev 104716)
+++ trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h 2012-01-11 17:40:58 UTC (rev 104717)
@@ -76,11 +76,6 @@
// is owned by the object implementing WebCommonWorkerClient.
virtual WebNotificationPresenter* notificationPresenter() = 0;
-// This can be called on any thread to create a nested WebWorker.
-// WebSharedWorkers are not instantiated via this API - instead
-// they are created via the WebSharedWorkerRepository.
-virtual WebWorker* createWorker(WebSharedWorkerClient*) = 0;
-
// Called on the main webkit thread in the worker process during initialization.
virtual WebApplicationCacheHost* createApplicationCacheHost(WebApplicationCacheHostClient*) = 0;
Modified: trunk/Tools/ChangeLog (104716 => 104717)
--- trunk/Tools/ChangeLog 2012-01-11 17:36:20 UTC (rev 104716)
+++ trunk/Tools/ChangeLog 2012-01-11 17:40:58 UTC (rev 104717)
@@ -1,3 +1,14 @@
+2012-01-10 Dmitry Lomov dslo...@google.com
+
+[Chromium] Remove obsolete references to WebWorker class.
+https://bugs.webkit.org/show_bug.cgi?id=76020
+
+Reviewed by David Levin.
+
+* DumpRenderTree/chromium/TestWebWorker.h: Removed.
+* DumpRenderTree/chromium/WebViewHost.cpp:
+* DumpRenderTree/chromium/WebViewHost.h:
+
2012-01-11 Csaba Osztrogonác o...@webkit.org
[Qt] Some css3 filter tests are failing after r104698
Deleted: trunk/Tools/DumpRenderTree/chromium/TestWebWorker.h (104716 => 104717)
--- trunk/Tools/DumpRenderTree/chromium/TestWebWorker.h 2012-01-11 17:36:20 UTC (rev 104716)
+++ trunk/Tools/DumpRenderTree/chromium/TestWebWorker.h 2012-01-11 17:40:58 UTC (rev 104717)
@@ -1,93 +0,0 @@
-/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT
[webkit-changes] [104389] trunk/Source/WebKit/chromium
Title: [104389] trunk/Source/WebKit/chromium
Revision 104389
Author dslo...@google.com
Date 2012-01-07 13:50:37 -0800 (Sat, 07 Jan 2012)
Log Message
Unreviewed: disabled CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
and filed https://bugs.webkit.org/show_bug.cgi?id=75783.
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (104388 => 104389)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-07 18:43:49 UTC (rev 104388)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-07 21:50:37 UTC (rev 104389)
@@ -1,3 +1,11 @@
+2012-01-07 Dmitry Lomov dslo...@google.com
+
+Unreviewed: disabled CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
+and filed https://bugs.webkit.org/show_bug.cgi?id=75783.
+
+* tests/CCLayerTreeHostImplTest.cpp:
+(WebKit::TEST_F):
+
2012-01-06 W. James MacLean wjmacl...@chromium.org
[Chromium] Cull occluded tiles in tiled layers
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (104388 => 104389)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2012-01-07 18:43:49 UTC (rev 104388)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2012-01-07 21:50:37 UTC (rev 104389)
@@ -217,7 +217,8 @@
bool m_drawn;
};
-TEST_F(CCLayerTreeHostImplTest, blendingOffWhenDrawingOpaqueLayers)
+// https://bugs.webkit.org/show_bug.cgi?id=75783
+TEST_F(CCLayerTreeHostImplTest, FAILS_blendingOffWhenDrawingOpaqueLayers)
{
GraphicsContext3D::Attributes attrs;
RefPtrGraphicsContext3D context = GraphicsContext3DPrivate::createGraphicsContextFromWebContext(adoptPtr(new BlendStateTrackerContext()), attrs, 0, GraphicsContext3D::RenderDirectlyToHostWindow, GraphicsContext3DPrivate::ForUseOnThisThread);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104390] trunk/LayoutTests
Title: [104390] trunk/LayoutTests Revision 104390 Author dslo...@google.com Date 2012-01-07 14:12:46 -0800 (Sat, 07 Jan 2012) Log Message Unreviewed: test expectations and filed WK75784. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104389 => 104390) --- trunk/LayoutTests/ChangeLog 2012-01-07 21:50:37 UTC (rev 104389) +++ trunk/LayoutTests/ChangeLog 2012-01-07 22:12:46 UTC (rev 104390) @@ -1,3 +1,9 @@ +2012-01-07 Dmitry Lomov dslo...@google.com + +Unreviewed: test expectations and filed WK75784. + +* platform/chromium/test_expectations.txt: + 2012-01-07 Zan Dobersek zandober...@gmail.com [GTK] Enable requestAnimationFrame in build-webkit Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104389 => 104390) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-07 21:50:37 UTC (rev 104389) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-07 22:12:46 UTC (rev 104390) @@ -3885,3 +3885,7 @@ BUGWK75742 MAC : fast/forms/input-disabled-color.html = IMAGE +BUGWK75784 : fast/canvas/webgl/invalid-passed-params.html = TEXT + + + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104392] trunk/LayoutTests
Title: [104392] trunk/LayoutTests Revision 104392 Author dslo...@google.com Date 2012-01-07 15:51:35 -0800 (Sat, 07 Jan 2012) Log Message Unreviewed: updating expectations and rebaslining. svg/custom/pattern-userSpaceOnUse-userToBaseTransform rebaselined due to http://trac.webkit.org/changeset/104356/. * platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. * platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. * platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. * platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added. * platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104391 => 104392) --- trunk/LayoutTests/ChangeLog 2012-01-07 22:39:04 UTC (rev 104391) +++ trunk/LayoutTests/ChangeLog 2012-01-07 23:51:35 UTC (rev 104392) @@ -1,3 +1,15 @@ +2012-01-07 Dmitry Lomov dslo...@google.com + +Unreviewed: updating expectations and rebaslining. +svg/custom/pattern-userSpaceOnUse-userToBaseTransform rebaselined due to http://trac.webkit.org/changeset/104356/. + +* platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. +* platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. +* platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. +* platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added. +* platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. +* platform/chromium/test_expectations.txt: + 2012-01-07 Philippe Normand pnorm...@igalia.com Unreviewed, GTK rebaseline after r104386 and r104208. Added: trunk/LayoutTests/platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png ___ Added: svn:mime-type Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104391 => 104392) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-07 22:39:04 UTC (rev 104391) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-07 23:51:35 UTC (rev 104392) @@ -1333,7 +1333,7 @@ BUGCR23476 MAC : fast/frames/inline-object-inside-frameset.html = IMAGE BUGCR23476 MAC : fast/text/font-initial.html = IMAGE // Expectation changed at r99653 (IMAGE - IMAGE+TEXT). -BUGCR23476 BUGWK70765 MAC : fast/forms/listbox-clip.html = IMAGE+TEXT +BUGCR23476 BUGWK70765 MAC : fast/forms/listbox-clip.html = IMAGE IMAGE+TEXT // Disagreeing XML parsing error messages BUGCR88911 LEOPARD : fast/parser/xhtml-alternate-entities.xml = IMAGE+TEXT @@ -1986,7 +1986,7 @@ BUGCR42875 SKIP WONTFIX : sputnik = TEXT // Need rebaseline -BUGWK70765 WIN : fast/forms/listbox-clip.html = IMAGE+TEXT +BUGWK70765 WIN : fast/forms/listbox-clip.html = IMAGE IMAGE+TEXT BUGWK38705 : http/tests/security/sandbox-inherit-to-initial-document-2.html = TEXT @@ -3887,5 +3887,5 @@ BUGWK75784 : fast/canvas/webgl/invalid-passed-params.html = TEXT +BUGWK75786 SKIP : compositing/tiled-layers-hidpi.html = TIMEOUT - Added: trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png ___ Added: svn:mime-type
[webkit-changes] [104393] trunk/LayoutTests
Title: [104393] trunk/LayoutTests Revision 104393 Author dslo...@google.com Date 2012-01-07 16:09:12 -0800 (Sat, 07 Jan 2012) Log Message Unreviewed: updating expectations and rebaselining. svg/custom/inline-svg-in-xhtml rebaselined due to http://trac.webkit.org/changeset/104240/. * platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png: * platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added. * platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed. * platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png: * platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added. * platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png Added Paths trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png Removed Paths trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png trunk/LayoutTests/platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (104392 => 104393) --- trunk/LayoutTests/ChangeLog 2012-01-07 23:51:35 UTC (rev 104392) +++ trunk/LayoutTests/ChangeLog 2012-01-08 00:09:12 UTC (rev 104393) @@ -1,5 +1,18 @@ 2012-01-07 Dmitry Lomov dslo...@google.com +Unreviewed: updating expectations and rebaselining. +svg/custom/inline-svg-in-xhtml rebaselined due to http://trac.webkit.org/changeset/104240/. + +* platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png: +* platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added. +* platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed. +* platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png: +* platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added. +* platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed. +* platform/chromium/test_expectations.txt: + +2012-01-07 Dmitry Lomov dslo...@google.com + Unreviewed: updating expectations and rebaslining. svg/custom/pattern-userSpaceOnUse-userToBaseTransform rebaselined due to http://trac.webkit.org/changeset/104356/. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104392 => 104393) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-07 23:51:35 UTC (rev 104392) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-08 00:09:12 UTC (rev 104393) @@ -3889,3 +3889,5 @@ BUGWK75786 SKIP : compositing/tiled-layers-hidpi.html = TIMEOUT +BUGWK75787 MAC LINUX : fast/text/international/spaces-combined-in-vertical-text.html = TIMEOUT TEXT + Deleted: trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Added: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png ___ Added: svn:mime-type Deleted: trunk/LayoutTests/platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104394] trunk/LayoutTests
Title: [104394] trunk/LayoutTests Revision 104394 Author dslo...@google.com Date 2012-01-07 16:45:55 -0800 (Sat, 07 Jan 2012) Log Message Unreviewed; chromium tests rebaselined after r104240. * platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png: * platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png: * platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png: * platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png: * platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png: * platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png: * platform/chromium-mac-leopard/fast/html/details-open2-expected.png: * platform/chromium-mac-leopard/fast/html/details-open4-expected.png: * platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png: * platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added. * platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added. * platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added. * platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png: * platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added. * platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png. * platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png. * platform/chromium-mac/fast/forms/input-text-double-click-expected.png: Removed. * platform/chromium-mac/fast/forms/input-text-drag-down-expected.png: Removed. * platform/chromium-mac/fast/forms/input-text-option-delete-expected.png: Removed. * platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/html/details-open2-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/html/details-open4-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png Removed Paths trunk/LayoutTests/platform/chromium-mac/fast/forms/input-text-double-click-expected.png trunk/LayoutTests/platform/chromium-mac/fast/forms/input-text-drag-down-expected.png trunk/LayoutTests/platform/chromium-mac/fast/forms/input-text-option-delete-expected.png trunk/LayoutTests/platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png trunk/LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png trunk/LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (104393 => 104394) --- trunk/LayoutTests/ChangeLog 2012-01-08 00:09:12 UTC (rev 104393) +++ trunk/LayoutTests/ChangeLog 2012-01-08 00:45:55 UTC (rev 104394) @@ -1,5 +1,30 @@ 2012-01-07 Dmitry Lomov dslo...@google.com +Unreviewed; chromium tests rebaselined after r104240. + +* platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png: +* platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png: +* platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png: +* platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png: +* platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png: +*
[webkit-changes] [104316] trunk/LayoutTests
Title: [104316] trunk/LayoutTests Revision 104316 Author dslo...@google.com Date 2012-01-06 12:12:50 -0800 (Fri, 06 Jan 2012) Log Message Unreviewed; fixing expectation error. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104315 => 104316) --- trunk/LayoutTests/ChangeLog 2012-01-06 20:09:26 UTC (rev 104315) +++ trunk/LayoutTests/ChangeLog 2012-01-06 20:12:50 UTC (rev 104316) @@ -1,3 +1,9 @@ +2012-01-06 Dmitry Lomov dslo...@google.com + +Unreviewed; fixing expectation error. + +* platform/chromium/test_expectations.txt: + 2012-01-06 Hans Muller hmul...@adobe.com Convert overflow-in-uniform-regions to a reftest Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104315 => 104316) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-06 20:09:26 UTC (rev 104315) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-06 20:12:50 UTC (rev 104316) @@ -2704,8 +2704,10 @@ // Accelerated 2d for mac isn't supported yet, so SKIP this test for now. BUGCR74979 SKIP MAC GPU GPU-CG : media/video-canvas-alpha.html = IMAGE -BUGWK67760 GPU : media/media-document-audio-repaint.html = IMAGE PASS +// Needs rebaseline after BUGWK74123 goes in. +BUGWK67760 BUGWK75505: media/media-document-audio-repaint.html = IMAGE PASS + BUGWK55968 MAC : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE IMAGE+TEXT BUGWK55968 WIN DEBUG : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE @@ -3875,9 +3877,6 @@ BUGWK75633 : fast/media/viewport-media-query.html = PASS IMAGE+TEXT -// Needs rebaseline after BUGWK74123 goes in. -BUGWK75505 : media/media-document-audio-repaint.html = IMAGE - BUGWK75696 MAC LINUX DEBUG: svg/text/text-style-recalc-crash.html = PASS TIMEOUT BUGWK75716 : fullscreen/video-controls-drag.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104336] trunk/LayoutTests
Title: [104336] trunk/LayoutTests Revision 104336 Author dslo...@google.com Date 2012-01-06 14:13:51 -0800 (Fri, 06 Jan 2012) Log Message Unreviewed: filed https://bugs.webkit.org/show_bug.cgi?id=75742 and updated chromium-mac expectations for fast/forms/input-disabled-color.html. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104335 => 104336) --- trunk/LayoutTests/ChangeLog 2012-01-06 22:08:13 UTC (rev 104335) +++ trunk/LayoutTests/ChangeLog 2012-01-06 22:13:51 UTC (rev 104336) @@ -1,3 +1,10 @@ +2012-01-06 Dmitry Lomov dslo...@google.com + +Unreviewed: filed https://bugs.webkit.org/show_bug.cgi?id=75742 +and updated chromium-mac expectations for fast/forms/input-disabled-color.html. + +* platform/chromium/test_expectations.txt: + 2012-01-06 Tom Sepez tse...@chromium.org Pass Content-Security-Policy directives to worker threads. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104335 => 104336) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-06 22:08:13 UTC (rev 104335) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-06 22:13:51 UTC (rev 104336) @@ -3882,3 +3882,5 @@ BUGWK75696 MAC LINUX DEBUG: svg/text/text-style-recalc-crash.html = PASS TIMEOUT BUGWK75716 : fullscreen/video-controls-drag.html = TEXT + +BUGWK75742 MAC : fast/forms/input-disabled-color.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104172] trunk/LayoutTests
Title: [104172] trunk/LayoutTests Revision 104172 Author dslo...@google.com Date 2012-01-05 09:52:42 -0800 (Thu, 05 Jan 2012) Log Message Unreviewed: Chromium expectations update. Filed http://crbug.com/109276 and ignored appcache failure on Linux. Failures seem intermittent in appcache so might need to ignore more tests. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104171 => 104172) --- trunk/LayoutTests/ChangeLog 2012-01-05 17:49:06 UTC (rev 104171) +++ trunk/LayoutTests/ChangeLog 2012-01-05 17:52:42 UTC (rev 104172) @@ -1,3 +1,11 @@ +2012-01-05 Dmitry Lomov dslo...@google.com + +Unreviewed: Chromium expectations update. +Filed http://crbug.com/109276 and ignored appcache failure on Linux. +Failures seem intermittent in appcache so might need to ignore more tests. + +* platform/chromium/test_expectations.txt: + 2012-01-05 Stephen Chenney schen...@chromium.org [Chromium] Expectations for svg/carto.net/button.svg can be updated Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104171 => 104172) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-05 17:49:06 UTC (rev 104171) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-05 17:52:42 UTC (rev 104172) @@ -3874,3 +3874,6 @@ BUGWK75430 MAC : plugins/iframe-plugin-bgcolor.html = TEXT TIMEOUT BUGWK75468 : fast/js/kde/GlobalObject.html = TEXT BUGWK75083 : perf/nested-combined-selectors.html = MISSING + +BUGCR109276 LINUX : http/tests/appcache/simple.html = PASS CRASH +BUGCR109276 LINUX : http/tests/appcache/resource-redirect.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104182] trunk/LayoutTests
Title: [104182] trunk/LayoutTests Revision 104182 Author dslo...@google.com Date 2012-01-05 11:15:28 -0800 (Thu, 05 Jan 2012) Log Message Unreviewed: filed WK75633 and updated expectations * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104181 => 104182) --- trunk/LayoutTests/ChangeLog 2012-01-05 19:03:26 UTC (rev 104181) +++ trunk/LayoutTests/ChangeLog 2012-01-05 19:15:28 UTC (rev 104182) @@ -1,3 +1,9 @@ +2012-01-05 Dmitry Lomov dslo...@google.com + +Unreviewed: filed WK75633 and updated expectations + +* platform/chromium/test_expectations.txt: + 2012-01-05 Jian Li jia...@chromium.org FileReader needs addEventListener Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104181 => 104182) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-05 19:03:26 UTC (rev 104181) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-05 19:15:28 UTC (rev 104182) @@ -3877,3 +3877,5 @@ BUGCR109276 LINUX : http/tests/appcache/simple.html = PASS CRASH BUGCR109276 LINUX : http/tests/appcache/resource-redirect.html = PASS CRASH + +BUGWK75633 : fast/media/viewport-media-query.html = PASS IMAGE TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104218] trunk/LayoutTests
Title: [104218] trunk/LayoutTests Revision 104218 Author dslo...@google.com Date 2012-01-05 14:29:07 -0800 (Thu, 05 Jan 2012) Log Message Unreviewed: Updating expecxtations for fast/media/viewport-media-query. My understanding of the semantics was a bit off. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104217 => 104218) --- trunk/LayoutTests/ChangeLog 2012-01-05 22:04:30 UTC (rev 104217) +++ trunk/LayoutTests/ChangeLog 2012-01-05 22:29:07 UTC (rev 104218) @@ -1,3 +1,10 @@ +2012-01-05 Dmitry Lomov dslo...@google.com + +Unreviewed: Updating expecxtations for fast/media/viewport-media-query. +My understanding of the semantics was a bit off. + +* platform/chromium/test_expectations.txt: + 2012-01-05 Gavin Barraclough barraclo...@apple.com Literal tab in JSONString fails Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104217 => 104218) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-05 22:04:30 UTC (rev 104217) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-05 22:29:07 UTC (rev 104218) @@ -3878,4 +3878,4 @@ BUGCR109276 LINUX : http/tests/appcache/simple.html = PASS CRASH BUGCR109276 LINUX : http/tests/appcache/resource-redirect.html = PASS CRASH -BUGWK75633 : fast/media/viewport-media-query.html = PASS IMAGE TEXT +BUGWK75633 : fast/media/viewport-media-query.html = PASS IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104064] trunk/Source/WebKit/chromium
Title: [104064] trunk/Source/WebKit/chromium
Revision 104064
Author dslo...@google.com
Date 2012-01-04 13:40:38 -0800 (Wed, 04 Jan 2012)
Log Message
Unreviewed:[Chromium]Disable WebPageNewSerializeTest.CSSResources and WebPageNewSerializeTest.TestMHTMLEncoding.
https://bugs.webkit.org/show_bug.cgi?id=75567
* tests/WebPageNewSerializerTest.cpp:
(WebKit::TEST_F):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (104063 => 104064)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-04 20:43:45 UTC (rev 104063)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-04 21:40:38 UTC (rev 104064)
@@ -1,3 +1,11 @@
+2012-01-04 Dmitry Lomov dslo...@google.com
+
+Unreviewed:[Chromium]Disable WebPageNewSerializeTest.CSSResources and WebPageNewSerializeTest.TestMHTMLEncoding.
+https://bugs.webkit.org/show_bug.cgi?id=75567
+
+* tests/WebPageNewSerializerTest.cpp:
+(WebKit::TEST_F):
+
2012-01-04 Adrienne Walker e...@google.com
[chromium] Create unit tests for CCTiledLayerImpl
Modified: trunk/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp (104063 => 104064)
--- trunk/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp 2012-01-04 20:43:45 UTC (rev 104063)
+++ trunk/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp 2012-01-04 21:40:38 UTC (rev 104064)
@@ -215,7 +215,7 @@
// Test that when serializing a page, all CSS resources are reported, including url()'s
// and imports and links. Note that we don't test the resources contents, we only make sure
// they are all reported with the right mime type and that they contain some data.
-TEST_F(WebPageNewSerializeTest, CSSResources)
+TEST_F(WebPageNewSerializeTest, FAILS_CSSResources)
{
// Register the mocked frame and load it.
WebURL topFrameURL = setUpCSSTestPage();
@@ -300,7 +300,7 @@
ASSERT_TRUE(pos == std::string::npos);
}
-TEST_F(WebPageNewSerializeTest, TestMHTMLEncoding)
+TEST_F(WebPageNewSerializeTest, FAILS_TestMHTMLEncoding)
{
// Load a page with some CSS and some images.
WebURL topFrameURL = setUpCSSTestPage();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103986] trunk/LayoutTests
Title: [103986] trunk/LayoutTests Revision 103986 Author dslo...@google.com Date 2012-01-03 16:25:44 -0800 (Tue, 03 Jan 2012) Log Message Unreviewed: files bug CR109068 for appcache/interrupted-update.html crash. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103985 => 103986) --- trunk/LayoutTests/ChangeLog 2012-01-04 00:23:55 UTC (rev 103985) +++ trunk/LayoutTests/ChangeLog 2012-01-04 00:25:44 UTC (rev 103986) @@ -1,3 +1,9 @@ +2012-01-03 Dmitry Lomov dslo...@google.com + +Unreviewed: files bug CR109068 for appcache/interrupted-update.html crash. + +* platform/chromium/test_expectations.txt: + 2012-01-03 Filip Pizlo fpi...@apple.com REGRESSION (r98196-98236): Incorrect layout of iGoogle with RSS feeds Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103985 => 103986) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-04 00:23:55 UTC (rev 103985) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-04 00:25:44 UTC (rev 103986) @@ -3120,7 +3120,7 @@ BUGWK60822 : plugins/get-url-notify-with-url-that-fails-to-load.html = PASS CRASH TIMEOUT // Flaky since added by r86478 -BUGCR82881 LINUX MAC VISTA XP : http/tests/appcache/interrupted-update.html = PASS TEXT +BUGCR82881 BUGCR109068 LINUX MAC VISTA XP : http/tests/appcache/interrupted-update.html = PASS TEXT CRASH // Fails on windows - added in r86693 BUGCR82950 WIN : http/tests/navigation/post-301-response.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103995] trunk/LayoutTests
Title: [103995] trunk/LayoutTests Revision 103995 Author dslo...@google.com Date 2012-01-03 17:45:00 -0800 (Tue, 03 Jan 2012) Log Message Unreviewed: filed CR109077 and updated expectations for http/tests/inspector/appcache/appcache-swap.html. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (103994 => 103995) --- trunk/LayoutTests/ChangeLog 2012-01-04 01:28:26 UTC (rev 103994) +++ trunk/LayoutTests/ChangeLog 2012-01-04 01:45:00 UTC (rev 103995) @@ -1,3 +1,9 @@ +2012-01-03 Dmitry Lomov dslo...@google.com + +Unreviewed: filed CR109077 and updated expectations for http/tests/inspector/appcache/appcache-swap.html. + +* platform/chromium/test_expectations.txt: + 2012-01-03 Jochen Eisinger joc...@chromium.org Clear localStorage before making assumption about its contents Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103994 => 103995) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-04 01:28:26 UTC (rev 103994) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-04 01:45:00 UTC (rev 103995) @@ -3126,6 +3126,7 @@ // Flaky since added by r86478 BUGCR82881 BUGCR109068 LINUX MAC VISTA XP : http/tests/appcache/interrupted-update.html = PASS TEXT CRASH +BUGCR109077 LINUX : http/tests/inspector/appcache/appcache-swap.html = CRASH // Fails on windows - added in r86693 BUGCR82950 WIN : http/tests/navigation/post-301-response.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103837] trunk/Source/WebKit/chromium
Title: [103837] trunk/Source/WebKit/chromium Revision 103837 Author dslo...@google.com Date 2011-12-30 00:43:46 -0800 (Fri, 30 Dec 2011) Log Message https://bugs.webkit.org/show_bug.cgi?id=75373 [Chromium] Remove WebWorkerClient.h After coordinated patch in chromium, WebWorkerClient alias for WebSharedWorkerClient is no longer needed. Reviewed by Adam Barth. * WebKit.gyp: * public/WebFrameClient.h: * public/WebWorkerClient.h: Removed. * src/WebSharedWorkerImpl.h: * src/WebWorkerBase.cpp: * src/WebWorkerClientImpl.h: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Source/WebKit/chromium/public/WebFrameClient.h trunk/Source/WebKit/chromium/src/WebSharedWorkerImpl.h trunk/Source/WebKit/chromium/src/WebWorkerBase.cpp trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.h Removed Paths trunk/Source/WebKit/chromium/public/WebWorkerClient.h Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (103836 => 103837) --- trunk/Source/WebKit/chromium/ChangeLog 2011-12-30 06:24:22 UTC (rev 103836) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-30 08:43:46 UTC (rev 103837) @@ -1,3 +1,18 @@ +2011-12-30 Dmitry Lomov dslo...@google.com + +https://bugs.webkit.org/show_bug.cgi?id=75373 +[Chromium] Remove WebWorkerClient.h +After coordinated patch in chromium, WebWorkerClient alias for WebSharedWorkerClient is no longer needed. + +Reviewed by Adam Barth. + +* WebKit.gyp: +* public/WebFrameClient.h: +* public/WebWorkerClient.h: Removed. +* src/WebSharedWorkerImpl.h: +* src/WebWorkerBase.cpp: +* src/WebWorkerClientImpl.h: + 2011-12-29 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r103831. Modified: trunk/Source/WebKit/chromium/WebKit.gyp (103836 => 103837) --- trunk/Source/WebKit/chromium/WebKit.gyp 2011-12-30 06:24:22 UTC (rev 103836) +++ trunk/Source/WebKit/chromium/WebKit.gyp 2011-12-30 08:43:46 UTC (rev 103837) @@ -265,7 +265,6 @@ 'public/WebWidget.h', 'public/WebWidgetClient.h', 'public/WebWorker.h', -'public/WebWorkerClient.h', 'public/WebWorkerRunLoop.h', 'public/android/WebInputEventFactory.h', 'public/android/WebSandboxSupport.h', Modified: trunk/Source/WebKit/chromium/public/WebFrameClient.h (103836 => 103837) --- trunk/Source/WebKit/chromium/public/WebFrameClient.h 2011-12-30 06:24:22 UTC (rev 103836) +++ trunk/Source/WebKit/chromium/public/WebFrameClient.h 2011-12-30 08:43:46 UTC (rev 103837) @@ -36,7 +36,6 @@ #include WebNavigationType.h #include WebStorageQuotaType.h #include WebTextDirection.h -#include WebWorkerClient.h #include platform/WebCommon.h #include platform/WebFileSystem.h #include platform/WebURLError.h Deleted: trunk/Source/WebKit/chromium/public/WebWorkerClient.h (103836 => 103837) --- trunk/Source/WebKit/chromium/public/WebWorkerClient.h 2011-12-30 06:24:22 UTC (rev 103836) +++ trunk/Source/WebKit/chromium/public/WebWorkerClient.h 2011-12-30 08:43:46 UTC (rev 103837) @@ -1,38 +0,0 @@ -/* - * Copyright (C) 2009 Google Inc. All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are - * met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above - * copyright notice, this list of conditions and the following disclaimer - * in the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Google Inc. nor the names of its - * contributors may be used to endorse or promote products derived from - * this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - */ - -#ifndef WebWorkerClient_h -#define WebWorkerClient_h - -#include WebSharedWorkerClient.h - -#define WebWorkerClient WebSharedWorkerClient - -#endif Modified: trunk/Source/WebKit/chromium/src/WebSharedWorkerImpl.h (103836 => 103837)
[webkit-changes] [103831] trunk/Source/WebKit/chromium
Title: [103831] trunk/Source/WebKit/chromium Revision 103831 Author dslo...@google.com Date 2011-12-29 18:13:12 -0800 (Thu, 29 Dec 2011) Log Message https://bugs.webkit.org/show_bug.cgi?id=75373 [Chromium] Remove WebWorkerClient.h After coordinated patch in chromium, WebWorkerClient alias for WebSharedWorkerClient is no longer needed. Reviewed by Adam Barth. * WebKit.gyp: * public/WebFrameClient.h: * public/WebWorkerClient.h: Removed. * src/WebSharedWorkerImpl.h: * src/WebWorkerBase.cpp: * src/WebWorkerClientImpl.h: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Source/WebKit/chromium/public/WebFrameClient.h trunk/Source/WebKit/chromium/src/WebSharedWorkerImpl.h trunk/Source/WebKit/chromium/src/WebWorkerBase.cpp trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.h Removed Paths trunk/Source/WebKit/chromium/public/WebWorkerClient.h Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (103830 => 103831) --- trunk/Source/WebKit/chromium/ChangeLog 2011-12-29 23:49:52 UTC (rev 103830) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-30 02:13:12 UTC (rev 103831) @@ -1,3 +1,18 @@ +2011-12-29 Dmitry Lomov dslo...@google.com + +https://bugs.webkit.org/show_bug.cgi?id=75373 +[Chromium] Remove WebWorkerClient.h +After coordinated patch in chromium, WebWorkerClient alias for WebSharedWorkerClient is no longer needed. + +Reviewed by Adam Barth. + +* WebKit.gyp: +* public/WebFrameClient.h: +* public/WebWorkerClient.h: Removed. +* src/WebSharedWorkerImpl.h: +* src/WebWorkerBase.cpp: +* src/WebWorkerClientImpl.h: + 2011-12-29 Pavel Feldman pfeld...@google.com Web Inspector: [chromium] pass dock to side request to the embedder. Modified: trunk/Source/WebKit/chromium/WebKit.gyp (103830 => 103831) --- trunk/Source/WebKit/chromium/WebKit.gyp 2011-12-29 23:49:52 UTC (rev 103830) +++ trunk/Source/WebKit/chromium/WebKit.gyp 2011-12-30 02:13:12 UTC (rev 103831) @@ -265,7 +265,6 @@ 'public/WebWidget.h', 'public/WebWidgetClient.h', 'public/WebWorker.h', -'public/WebWorkerClient.h', 'public/WebWorkerRunLoop.h', 'public/android/WebInputEventFactory.h', 'public/android/WebSandboxSupport.h', Modified: trunk/Source/WebKit/chromium/public/WebFrameClient.h (103830 => 103831) --- trunk/Source/WebKit/chromium/public/WebFrameClient.h 2011-12-29 23:49:52 UTC (rev 103830) +++ trunk/Source/WebKit/chromium/public/WebFrameClient.h 2011-12-30 02:13:12 UTC (rev 103831) @@ -36,7 +36,6 @@ #include WebNavigationType.h #include WebStorageQuotaType.h #include WebTextDirection.h -#include WebWorkerClient.h #include platform/WebCommon.h #include platform/WebFileSystem.h #include platform/WebURLError.h Deleted: trunk/Source/WebKit/chromium/public/WebWorkerClient.h (103830 => 103831) --- trunk/Source/WebKit/chromium/public/WebWorkerClient.h 2011-12-29 23:49:52 UTC (rev 103830) +++ trunk/Source/WebKit/chromium/public/WebWorkerClient.h 2011-12-30 02:13:12 UTC (rev 103831) @@ -1,38 +0,0 @@ -/* - * Copyright (C) 2009 Google Inc. All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are - * met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above - * copyright notice, this list of conditions and the following disclaimer - * in the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Google Inc. nor the names of its - * contributors may be used to endorse or promote products derived from - * this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - */ - -#ifndef WebWorkerClient_h -#define WebWorkerClient_h - -#include WebSharedWorkerClient.h - -#define WebWorkerClient WebSharedWorkerClient - -#endif Modified:
[webkit-changes] [103429] trunk
Title: [103429] trunk
Revision 103429
Author dslo...@google.com
Date 2011-12-21 12:27:37 -0800 (Wed, 21 Dec 2011)
Log Message
Source/WebCore: [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread
https://bugs.webkit.org/show_bug.cgi?id=74554
Reviewed by David Levin.
Covered by existing tests in fast/workers/storage.
* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::NotifyDatabaseObserverOnCloseTask::create):
(WebCore::NotifyDatabaseObserverOnCloseTask::performTask):
(WebCore::NotifyDatabaseObserverOnCloseTask::isCleanupTask):
(WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
LayoutTests: [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread.
https://bugs.webkit.org/show_bug.cgi?id=74554
Reviewed by David Levin.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/AbstractDatabase.cpp
trunk/Source/WebCore/storage/chromium/DatabaseTrackerChromium.cpp
Property Changed
trunk/LayoutTests/ChangeLog
Diff
Modified: trunk/LayoutTests/ChangeLog (103428 => 103429)
--- trunk/LayoutTests/ChangeLog 2011-12-21 20:09:54 UTC (rev 103428)
+++ trunk/LayoutTests/ChangeLog 2011-12-21 20:27:37 UTC (rev 103429)
@@ -1,3 +1,12 @@
+2011-12-20 Dmitry Lomov dslo...@google.com
+
+[Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread.
+https://bugs.webkit.org/show_bug.cgi?id=74554
+
+Reviewed by David Levin.
+
+* platform/chromium/test_expectations.txt:
+
2011-12-21 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Rebaseline pixel test results, which have 0.011 diffs on my 64bit SL machine.
Property changes on: trunk/LayoutTests/ChangeLog
___
Deleted: svn:executable
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103428 => 103429)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-21 20:09:54 UTC (rev 103428)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-21 20:27:37 UTC (rev 103429)
@@ -181,15 +181,16 @@
BUGWK74459 SKIP : fast/workers/worker-messageport.html = CRASH
BUGWK74459 SKIP : fast/workers/worker-multi-port.html = CRASH
-BUGWK74554 SKIP : fast/workers/storage = CRASH TIMEOUT
-
BUGWK74449 SKIP : fast/workers/dedicated-worker-lifecycle.html = TIMEOUT
BUGWK74449 SKIP : fast/workers/worker-close-more.html = TIMEOUT
BUGWK74449 SKIP : fast/workers/worker-lifecycle.html = TIMEOUT
BUGWK74466 : fast/workers/worker-script-error.html = PASS TIMEOUT FAIL
+// Tests timing out because layoutTestController.workerThreadCount is not implemented in DRT
BUGWK74653 SKIP : http/tests/xmlhttprequest/workers/abort-exception-assert.html = TIMEOUT
+BUGWK74653 SKIP : http/tests/workers/interrupt-database-sync-open-crash.html = TIMEOUT
+BUGWK74653 SKIP : fast/workers/storage/interrupt-database.html = TIMEOUT
BUGWK71968 : fast/files/workers/worker-apply-blob-url-to-xhr.html = TEXT
Modified: trunk/Source/WebCore/ChangeLog (103428 => 103429)
--- trunk/Source/WebCore/ChangeLog 2011-12-21 20:09:54 UTC (rev 103428)
+++ trunk/Source/WebCore/ChangeLog 2011-12-21 20:27:37 UTC (rev 103429)
@@ -1,3 +1,19 @@
+2011-12-20 Dmitry Lomov dslo...@google.com
+
+[Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread
+https://bugs.webkit.org/show_bug.cgi?id=74554
+
+Reviewed by David Levin.
+
+Covered by existing tests in fast/workers/storage.
+
+* storage/chromium/DatabaseTrackerChromium.cpp:
+(WebCore::NotifyDatabaseObserverOnCloseTask::create):
+(WebCore::NotifyDatabaseObserverOnCloseTask::performTask):
+(WebCore::NotifyDatabaseObserverOnCloseTask::isCleanupTask):
+(WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask):
+(WebCore::DatabaseTracker::removeOpenDatabase):
+
2011-12-21 Eric Carlson eric.carl...@apple.com
HTMLMediaElement::configureTextTrackDisplay is unnecessary
Modified: trunk/Source/WebCore/storage/AbstractDatabase.cpp (103428 => 103429)
--- trunk/Source/WebCore/storage/AbstractDatabase.cpp 2011-12-21 20:09:54 UTC (rev 103428)
+++ trunk/Source/WebCore/storage/AbstractDatabase.cpp 2011-12-21 20:27:37 UTC (rev 103429)
@@ -223,6 +223,7 @@
AbstractDatabase::~AbstractDatabase()
{
+ASSERT(!m_opened);
}
void AbstractDatabase::closeDatabase()
Modified: trunk/Source/WebCore/storage/chromium/DatabaseTrackerChromium.cpp (103428 => 103429)
--- trunk/Source/WebCore/storage/chromium/DatabaseTrackerChromium.cpp 2011-12-21 20:09:54 UTC (rev 103428)
+++
[webkit-changes] [102722] trunk
Title: [102722] trunk
Revision 102722
Author dslo...@google.com
Date 2011-12-13 17:17:41 -0800 (Tue, 13 Dec 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=73691
[JSC] Implement correct order of window.postMessage arguments.
This change supports a new signature of windowPostMessage:
postMessage(message, targetOrigin[, transferrables])
as well as the legacy webkit-proprietary:
postMessage(message, [transferrables,] targetOrigin)
The latter is only supported for cases when targetOrigin is a String.
Reviewed by David Levin.
Source/WebCore:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::handlePostMessage):
* page/DOMWindow.idl:
LayoutTests:
* fast/dom/Window/window-postmessage-args-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/page/DOMWindow.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (102721 => 102722)
--- trunk/LayoutTests/ChangeLog 2011-12-14 01:03:01 UTC (rev 102721)
+++ trunk/LayoutTests/ChangeLog 2011-12-14 01:17:41 UTC (rev 102722)
@@ -1,3 +1,17 @@
+2011-12-13 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=73691
+[JSC] Implement correct order of window.postMessage arguments.
+This change supports a new signature of windowPostMessage:
+ postMessage(message, targetOrigin[, transferrables])
+as well as the legacy webkit-proprietary:
+ postMessage(message, [transferrables,] targetOrigin)
+The latter is only supported for cases when targetOrigin is a String.
+
+Reviewed by David Levin.
+
+* fast/dom/Window/window-postmessage-args-expected.txt:
+
2011-12-13 Tony Chang t...@chromium.org
Rolling out r102461, a change to a layout test to try to remove flakiness on Chromium.
Modified: trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt (102721 => 102722)
--- trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-14 01:03:01 UTC (rev 102721)
+++ trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-14 01:17:41 UTC (rev 102722)
@@ -6,34 +6,41 @@
PASS: Posting message ('2', c): threw exception TypeError: Type error
PASS: Posting message ('3', [object Object]): threw exception TypeError: Type error
PASS: Posting message ('3', [object Object]): threw exception TypeError: Type error
-FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
-FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
+PASS: Posting message ('4', [object DOMWindow]) did not throw an exception
+PASS: Posting message ('4', [object DOMWindow]) did not throw an exception
PASS: Posting message ('4a', *) did not throw an exception
PASS: Posting message ('4a', *) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
-FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
PASS: Posting message ('7a', *) did not throw an exception
-FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
PASS: Posting message ('2147483648', null) did not throw an exception
PASS: Posting message ('2147483648', null) did not throw an exception
-FAIL: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
-FAIL: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
-FAIL: Posting message ('[object MessagePort],[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+PASS: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
+PASS: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
+PASS: Posting message ('[object MessagePort],[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
FAIL: Posting message ('[object ArrayBuffer]', [object ArrayBuffer]): threw exception TypeError: Type error
FAIL: arrayBuffer not neutered; byteLength = 30
FAIL: view was not neutered; length = 10
PASS: Posting message ('done', undefined) did not throw an exception
+Received message '4' with 0 ports.
+Received message '4' with 0 ports.
Received
[webkit-changes] [102729] trunk/LayoutTests
Title: [102729] trunk/LayoutTests
Revision 102729
Author dslo...@google.com
Date 2011-12-13 18:56:11 -0800 (Tue, 13 Dec 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=74456
[V8][Chromium] Reenable dedicated worker layout tests.
Chromium-specific results are caused by exception message text differences between JSC and V8.
Reviewed by David Levin.
* platform/chromium/fast/workers/use-machine-stack-expected.txt: Added.
* platform/chromium/fast/workers/worker-constructor-expected.txt: Added.
* platform/chromium/fast/workers/worker-location-expected.txt: Added.
* platform/chromium/fast/workers/worker-script-error-expected.txt: Added.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Added Paths
trunk/LayoutTests/platform/chromium/fast/workers/use-machine-stack-expected.txt
trunk/LayoutTests/platform/chromium/fast/workers/worker-constructor-expected.txt
trunk/LayoutTests/platform/chromium/fast/workers/worker-location-expected.txt
trunk/LayoutTests/platform/chromium/fast/workers/worker-script-error-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (102728 => 102729)
--- trunk/LayoutTests/ChangeLog 2011-12-14 02:55:02 UTC (rev 102728)
+++ trunk/LayoutTests/ChangeLog 2011-12-14 02:56:11 UTC (rev 102729)
@@ -1,3 +1,18 @@
+2011-12-13 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=74456
+[V8][Chromium] Reenable dedicated worker layout tests.
+
+Chromium-specific results are caused by exception message text differences between JSC and V8.
+
+Reviewed by David Levin.
+
+* platform/chromium/fast/workers/use-machine-stack-expected.txt: Added.
+* platform/chromium/fast/workers/worker-constructor-expected.txt: Added.
+* platform/chromium/fast/workers/worker-location-expected.txt: Added.
+* platform/chromium/fast/workers/worker-script-error-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
2011-12-13 Filip Pizlo fpi...@apple.com
DFG OSR exit for UInt32ToNumber should roll forward, not roll backward
Added: trunk/LayoutTests/platform/chromium/fast/workers/use-machine-stack-expected.txt (0 => 102729)
--- trunk/LayoutTests/platform/chromium/fast/workers/use-machine-stack-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/workers/use-machine-stack-expected.txt 2011-12-14 02:56:11 UTC (rev 102729)
@@ -0,0 +1,4 @@
+Test worker thread stack usage. Should not crash.
+
+PASS (RangeError: Maximum call stack size exceeded)
+
Added: trunk/LayoutTests/platform/chromium/fast/workers/worker-constructor-expected.txt (0 => 102729)
--- trunk/LayoutTests/platform/chromium/fast/workers/worker-constructor-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/workers/worker-constructor-expected.txt 2011-12-14 02:56:11 UTC (rev 102729)
@@ -0,0 +1,11 @@
+Test Worker constructor functionality. Should print a series of PASS messages, followed with DONE.
+
+PASS: toString exception propagated correctly.
+PASS: trying to create workers recursively resulted in an exception (RangeError: Maximum call stack size exceeded)
+PASS: invoking Worker constructor without arguments resulted in an exception (TypeError: Not enough arguments)
+PASS: invoking Worker constructor with empty script URL resulted in an exception (Error: SYNTAX_ERR: DOM Exception 12)
+PASS: invoking Worker constructor with invalid script URL resulted in an exception (Error: SYNTAX_ERR: DOM Exception 12)
+PASS: onerror invoked for a script that could not be loaded.
+PASS: Successfully created worker.
+DONE
+
Added: trunk/LayoutTests/platform/chromium/fast/workers/worker-location-expected.txt (0 => 102729)
--- trunk/LayoutTests/platform/chromium/fast/workers/worker-location-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/workers/worker-location-expected.txt 2011-12-14 02:56:11 UTC (rev 102729)
@@ -0,0 +1,15 @@
+Test WorkerLocation properties.
+
+WorkerLocation: function WorkerLocation() { [native code] }
+typeof location: object
+location: file:.../fast/workers/resources/worker-common.js
+location.href: file:.../fast/workers/resources/worker-common.js
+location.protocol: file:
+location.host:
+location.hostname:
+location.port:
+location.pathname: .../fast/workers/resources/worker-common.js
+location.search:
+location.hash:
+DONE
+
Added: trunk/LayoutTests/platform/chromium/fast/workers/worker-script-error-expected.txt (0 => 102729)
--- trunk/LayoutTests/platform/chromium/fast/workers/worker-script-error-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/workers/worker-script-error-expected.txt 2011-12-14 02:56:11 UTC (rev 102729)
@@ -0,0 +1,15 @@
+CONSOLE MESSAGE: line 10: Uncaught ReferenceError: foo is not defined
+Test Worker script error handling
[webkit-changes] [102386] branches/chromium/963
Title: [102386] branches/chromium/963
Revision 102386
Author dslo...@google.com
Date 2011-12-08 14:38:12 -0800 (Thu, 08 Dec 2011)
Log Message
Merge 102317 - https://bugs.webkit.org/show_bug.cgi?id=74038
[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.
Reviewed by David Levin.
Source/WebCore:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::isLegacyTargetOriginDesignation):
(WebCore::handlePostMessageCallback):
LayoutTests:
* fast/dom/Window/window-postmessage-args-expected.txt:
* fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
TBR=ca...@chromium.org
ISSUE=http://code.google.com/p/chromium/issues/detail?id=106797
Review URL: http://codereview.chromium.org/8883032
Modified Paths
branches/chromium/963/LayoutTests/ChangeLog
branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt
branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args.html
branches/chromium/963/LayoutTests/platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt
branches/chromium/963/Source/WebCore/ChangeLog
branches/chromium/963/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
Diff
Modified: branches/chromium/963/LayoutTests/ChangeLog (102385 => 102386)
--- branches/chromium/963/LayoutTests/ChangeLog 2011-12-08 22:29:39 UTC (rev 102385)
+++ branches/chromium/963/LayoutTests/ChangeLog 2011-12-08 22:38:12 UTC (rev 102386)
@@ -1,3 +1,14 @@
+2011-12-07 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=74038
+[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.
+
+Reviewed by David Levin.
+
+* fast/dom/Window/window-postmessage-args-expected.txt:
+* fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
+* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
+
2011-12-02 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r101731.
Modified: branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt (102385 => 102386)
--- branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-08 22:29:39 UTC (rev 102385)
+++ branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-08 22:38:12 UTC (rev 102386)
@@ -8,11 +8,14 @@
PASS: Posting message ('3', [object Object]): threw exception TypeError: Type error
FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
+PASS: Posting message ('4a', *) did not throw an exception
+PASS: Posting message ('4a', *) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+PASS: Posting message ('7a', *) did not throw an exception
FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
PASS: Posting message ('2147483648', null) did not throw an exception
PASS: Posting message ('2147483648', null) did not throw an exception
@@ -23,10 +26,13 @@
FAIL: arrayBuffer not neutered; byteLength = 30
FAIL: view was not neutered; length = 10
PASS: Posting message ('done', undefined) did not throw an exception
+Received message '4a' with 0 ports.
+Received message '4a' with 0 ports.
Received message '5' with 0 ports.
Received message '5' with 0 ports.
Received message '6' with 0 ports.
Received message '6' with 0 ports.
+Received message '7a' with 2 ports.
Received message '2147483648' with 0 ports.
Received message '2147483648' with 0 ports.
Received message 'done' with 0 ports.
Modified: branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args.html (102385 => 102386)
--- branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args.html 2011-12-08 22:29:39 UTC (rev 102385)
+++ branches/chromium/963/LayoutTests/fast/dom/Window/window-postmessage-args.html 2011-12-08 22:38:12 UTC (rev 102386)
@@ -46,10 +46,13 @@
tryPostMessage('2', '*', 'c', true);
tryPostMessage('3', '*', { x: 1 }, true);
tryPostMessage('4', '*', window); // Passes because window has a length attribute of value '0', so it looks like an array
+tryPostMessage('4a', window, '*'); // Legacy argument order.
tryPostMessage('5', '*', null);
tryPostMessage('6', '*', void 0);
var channel1 = new MessageChannel;
tryPostMessageFunction(window.postMessage, '7', '*', [channel1.port1,
[webkit-changes] [102317] trunk
Title: [102317] trunk
Revision 102317
Author dslo...@google.com
Date 2011-12-07 22:59:10 -0800 (Wed, 07 Dec 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=74038
[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.
Reviewed by David Levin.
Source/WebCore:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::isLegacyTargetOriginDesignation):
(WebCore::handlePostMessageCallback):
LayoutTests:
* fast/dom/Window/window-postmessage-args-expected.txt:
* fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt
trunk/LayoutTests/fast/dom/Window/window-postmessage-args.html
trunk/LayoutTests/platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (102316 => 102317)
--- trunk/LayoutTests/ChangeLog 2011-12-08 06:50:01 UTC (rev 102316)
+++ trunk/LayoutTests/ChangeLog 2011-12-08 06:59:10 UTC (rev 102317)
@@ -1,3 +1,14 @@
+2011-12-07 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=74038
+[V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.
+
+Reviewed by David Levin.
+
+* fast/dom/Window/window-postmessage-args-expected.txt:
+* fast/dom/Window/window-postmessage-args.html: New tests for legacy argument order.
+* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
+
2011-12-07 Kenichi Ishibashi ba...@chromium.org
Unreviewed, rebaseline media/controls-layout-direction.html
Modified: trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt (102316 => 102317)
--- trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-08 06:50:01 UTC (rev 102316)
+++ trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-08 06:59:10 UTC (rev 102317)
@@ -8,11 +8,14 @@
PASS: Posting message ('3', [object Object]): threw exception TypeError: Type error
FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
+PASS: Posting message ('4a', *) did not throw an exception
+PASS: Posting message ('4a', *) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+PASS: Posting message ('7a', *) did not throw an exception
FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
PASS: Posting message ('2147483648', null) did not throw an exception
PASS: Posting message ('2147483648', null) did not throw an exception
@@ -23,10 +26,13 @@
FAIL: arrayBuffer not neutered; byteLength = 30
FAIL: view was not neutered; length = 10
PASS: Posting message ('done', undefined) did not throw an exception
+Received message '4a' with 0 ports.
+Received message '4a' with 0 ports.
Received message '5' with 0 ports.
Received message '5' with 0 ports.
Received message '6' with 0 ports.
Received message '6' with 0 ports.
+Received message '7a' with 2 ports.
Received message '2147483648' with 0 ports.
Received message '2147483648' with 0 ports.
Received message 'done' with 0 ports.
Modified: trunk/LayoutTests/fast/dom/Window/window-postmessage-args.html (102316 => 102317)
--- trunk/LayoutTests/fast/dom/Window/window-postmessage-args.html 2011-12-08 06:50:01 UTC (rev 102316)
+++ trunk/LayoutTests/fast/dom/Window/window-postmessage-args.html 2011-12-08 06:59:10 UTC (rev 102317)
@@ -46,10 +46,13 @@
tryPostMessage('2', '*', 'c', true);
tryPostMessage('3', '*', { x: 1 }, true);
tryPostMessage('4', '*', window); // Passes because window has a length attribute of value '0', so it looks like an array
+tryPostMessage('4a', window, '*'); // Legacy argument order.
tryPostMessage('5', '*', null);
tryPostMessage('6', '*', void 0);
var channel1 = new MessageChannel;
tryPostMessageFunction(window.postMessage, '7', '*', [channel1.port1, channel1.port2]);
+var channel1a = new MessageChannel;
+tryPostMessageFunction(window.postMessage, '7a', [channel1a.port1, channel1a.port2], '*');
var channel2 = new MessageChannel;
tryPostMessageFunction(window.webkitPostMessage, '7', '*', [channel2.port1, channel2.port2]);
var channel3 = new MessageChannel;
Modified:
[webkit-changes] [101831] trunk
Title: [101831] trunk
Revision 101831
Author dslo...@google.com
Date 2011-12-02 11:00:27 -0800 (Fri, 02 Dec 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=73589
[V8][Chromium] Adjust postMessage to the latest implementation-ready spec.
- postMessage should support transfer of MessagePorts
- the order of arguments to Window::postMessage and Window::webkitPostMessage should be (msg, targetOrigin [, transfer])
Reviewed by David Levin.
Source/WebCore:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
LayoutTests:
* fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js:
(wrapSend):
(wrapFailSend):
* fast/dom/Window/window-postmessage-args.html:
* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js
trunk/LayoutTests/fast/dom/Window/window-postmessage-args.html
trunk/LayoutTests/platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (101830 => 101831)
--- trunk/LayoutTests/ChangeLog 2011-12-02 18:57:09 UTC (rev 101830)
+++ trunk/LayoutTests/ChangeLog 2011-12-02 19:00:27 UTC (rev 101831)
@@ -1,3 +1,18 @@
+2011-12-01 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=73589
+[V8][Chromium] Adjust postMessage to the latest implementation-ready spec.
+- postMessage should support transfer of MessagePorts
+- the order of arguments to Window::postMessage and Window::webkitPostMessage should be (msg, targetOrigin [, transfer])
+
+Reviewed by David Levin.
+
+* fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js:
+(wrapSend):
+(wrapFailSend):
+* fast/dom/Window/window-postmessage-args.html:
+* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
+
2011-12-02 Tom Sepez tse...@chromium.org
Content-security-policy script-src not enforced on workers.
Modified: trunk/LayoutTests/fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js (101830 => 101831)
--- trunk/LayoutTests/fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js 2011-12-02 18:57:09 UTC (rev 101830)
+++ trunk/LayoutTests/fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js 2011-12-02 19:00:27 UTC (rev 101831)
@@ -241,7 +241,7 @@
function wrapSend(testName, message, xfer)
{
try {
-window.webkitPostMessage(message, xfer, '*');
+window.webkitPostMessage(message, '*', xfer);
} catch (e) {
testFailed(testName + : could not webkitPostMessage: + e);
doneTest();
@@ -253,7 +253,7 @@
function wrapFailSend(testName, message, xfer)
{
try {
-window.webkitPostMessage(message, xfer, '*');
+window.webkitPostMessage(message, '*', xfer);
} catch (e) {
return true;
}
Modified: trunk/LayoutTests/fast/dom/Window/window-postmessage-args.html (101830 => 101831)
--- trunk/LayoutTests/fast/dom/Window/window-postmessage-args.html 2011-12-02 18:57:09 UTC (rev 101830)
+++ trunk/LayoutTests/fast/dom/Window/window-postmessage-args.html 2011-12-02 19:00:27 UTC (rev 101831)
@@ -29,9 +29,9 @@
postMessageFunction(first, second);
else
postMessageFunction(first, second, third);
-console.innerHTML += (shouldFail ? FAIL : PASS) + : Posting message (' + first + ', + second + ) did not throw an exceptionbr;
+console.innerHTML += (shouldFail ? FAIL : PASS) + : Posting message (' + first + ', + third + ) did not throw an exceptionbr;
} catch (e) {
-console.innerHTML += (shouldFail ? PASS : FAIL) + : Posting message (' + first + ', + second + ): threw exception + e + br;
+console.innerHTML += (shouldFail ? PASS : FAIL) + : Posting message (' + first + ', + third + ): threw exception + e + br;
}
}
@@ -42,27 +42,27 @@
document.getElementById(description).innerHTML = Test that the second argument of window.postMessage is ignored or triggers an error if it is not a message port. You should see PASS message '1' through '7', followed by 'done', with messages 4-7 received below.brbr;
-tryPostMessage('1', 1, '*', true);
-tryPostMessage('2', , '*', true);
-tryPostMessage('3', { x: 1 }, '*', true);
-tryPostMessage('4', window, '*');
[webkit-changes] [101849] trunk/LayoutTests
Title: [101849] trunk/LayoutTests
Revision 101849
Author dslo...@google.com
Date 2011-12-02 13:59:05 -0800 (Fri, 02 Dec 2011)
Log Message
Unreviewed: reset expectation for tests until https://bugs.webkit.org/show_bug.cgi?id=73691
is fixed.
* fast/dom/Window/window-postmessage-args-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (101848 => 101849)
--- trunk/LayoutTests/ChangeLog 2011-12-02 21:55:41 UTC (rev 101848)
+++ trunk/LayoutTests/ChangeLog 2011-12-02 21:59:05 UTC (rev 101849)
@@ -1,3 +1,10 @@
+2011-12-02 Dmitry Lomov dslo...@google.com
+
+Unreviewed: reset expectation for tests until https://bugs.webkit.org/show_bug.cgi?id=73691
+is fixed.
+
+* fast/dom/Window/window-postmessage-args-expected.txt:
+
2011-12-02 Kent Tamura tk...@chromium.org
[Lion][Windows] Both of placeholder and input text are shown in input type=number
Modified: trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt (101848 => 101849)
--- trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-02 21:55:41 UTC (rev 101848)
+++ trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-02 21:59:05 UTC (rev 101849)
@@ -2,39 +2,32 @@
PASS: Posting message ('1', 1): threw exception TypeError: Type error
PASS: Posting message ('1', 1): threw exception TypeError: Type error
-PASS: Posting message ('2', ): threw exception TypeError: Type error
-PASS: Posting message ('2', ): threw exception TypeError: Type error
+PASS: Posting message ('2', c): threw exception TypeError: Type error
+PASS: Posting message ('2', c): threw exception TypeError: Type error
PASS: Posting message ('3', [object Object]): threw exception TypeError: Type error
PASS: Posting message ('3', [object Object]): threw exception TypeError: Type error
-PASS: Posting message ('4', [object DOMWindow]) did not throw an exception
-PASS: Posting message ('4', [object DOMWindow]) did not throw an exception
+FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
+FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
-PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
-PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
+FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
PASS: Posting message ('2147483648', null) did not throw an exception
PASS: Posting message ('2147483648', null) did not throw an exception
-FAIL: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
-PASS: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
-PASS: Posting message ('[object MessagePort],[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
+FAIL: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+FAIL: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+FAIL: Posting message ('[object MessagePort],[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
FAIL: Posting message ('[object ArrayBuffer]', [object ArrayBuffer]): threw exception TypeError: Type error
FAIL: arrayBuffer not neutered; byteLength = 30
FAIL: view was not neutered; length = 10
-PASS: Posting message ('done', *) did not throw an exception
-Received message '4' with 0 ports.
-Received message '4' with 0 ports.
+PASS: Posting message ('done', undefined) did not throw an exception
Received message '5' with 0 ports.
Received message '5' with 0 ports.
Received message '6' with 0 ports.
Received message '6' with 0 ports.
-Received message '7' with 2 ports.
-Received message '7' with 2 ports.
Received message '2147483648' with 0 ports.
Received message '2147483648' with 0 ports.
-Received message '[object Object]' with 2 ports.
-Received message '[object MessagePort]' with 2 ports.
-Received message '[object MessagePort],[object MessagePort]' with 2 ports.
Received message 'done' with 0 ports.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [101904] trunk
Title: [101904] trunk
Revision 101904
Author dslo...@google.com
Date 2011-12-02 21:40:46 -0800 (Fri, 02 Dec 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=73691
[JSC] Implement correct order of window.postMessage arguments.
Reviewed by Geoffrey Garen.
Source/WebCore:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::handlePostMessage):
LayoutTests:
* fast/dom/Window/window-postmessage-args-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (101903 => 101904)
--- trunk/LayoutTests/ChangeLog 2011-12-03 05:34:42 UTC (rev 101903)
+++ trunk/LayoutTests/ChangeLog 2011-12-03 05:40:46 UTC (rev 101904)
@@ -1,3 +1,12 @@
+2011-12-02 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=73691
+[JSC] Implement correct order of window.postMessage arguments.
+
+Reviewed by Geoffrey Garen.
+
+* fast/dom/Window/window-postmessage-args-expected.txt:
+
2011-12-02 Stephen Chenney schen...@chromium.org
REGRESSION (r91125): Polyline tool in google docs is broken
Modified: trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt (101903 => 101904)
--- trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-03 05:34:42 UTC (rev 101903)
+++ trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-12-03 05:40:46 UTC (rev 101904)
@@ -6,28 +6,35 @@
PASS: Posting message ('2', c): threw exception TypeError: Type error
PASS: Posting message ('3', [object Object]): threw exception TypeError: Type error
PASS: Posting message ('3', [object Object]): threw exception TypeError: Type error
-FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
-FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
+PASS: Posting message ('4', [object DOMWindow]) did not throw an exception
+PASS: Posting message ('4', [object DOMWindow]) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
-FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
-FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
+PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
PASS: Posting message ('2147483648', null) did not throw an exception
PASS: Posting message ('2147483648', null) did not throw an exception
-FAIL: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
-FAIL: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
-FAIL: Posting message ('[object MessagePort],[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+PASS: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
+PASS: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
+PASS: Posting message ('[object MessagePort],[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
FAIL: Posting message ('[object ArrayBuffer]', [object ArrayBuffer]): threw exception TypeError: Type error
FAIL: arrayBuffer not neutered; byteLength = 30
FAIL: view was not neutered; length = 10
PASS: Posting message ('done', undefined) did not throw an exception
+Received message '4' with 0 ports.
+Received message '4' with 0 ports.
Received message '5' with 0 ports.
Received message '5' with 0 ports.
Received message '6' with 0 ports.
Received message '6' with 0 ports.
+Received message '7' with 2 ports.
+Received message '7' with 2 ports.
Received message '2147483648' with 0 ports.
Received message '2147483648' with 0 ports.
+Received message '[object Object]' with 2 ports.
+Received message '[object MessagePort]' with 2 ports.
+Received message '[object MessagePort],[object MessagePort]' with 2 ports.
Received message 'done' with 0 ports.
Modified: trunk/Source/WebCore/ChangeLog (101903 => 101904)
--- trunk/Source/WebCore/ChangeLog 2011-12-03 05:34:42 UTC (rev 101903)
+++ trunk/Source/WebCore/ChangeLog 2011-12-03 05:40:46 UTC (rev 101904)
@@ -1,3 +1,13 @@
+2011-12-02 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=73691
+[JSC]
[webkit-changes] [101064] trunk/Source
Title: [101064] trunk/Source
Revision 101064
Author dslo...@google.com
Date 2011-11-23 04:06:49 -0800 (Wed, 23 Nov 2011)
Log Message
Source/WebCore: Get rid of WebCore dependencies from TypedArray implementation types
https://bugs.webkit.org/show_bug.cgi?id=72783
Reviewed by David Levin.
Remove WebCore specific logic for neutering Typed Array implementations.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
* html/canvas/ArrayBuffer.cpp:
(WTF::ArrayBuffer::transfer):
* html/canvas/ArrayBuffer.h:
* html/canvas/ArrayBufferView.cpp:
(WTF::ArrayBufferView::neuter):
* html/canvas/ArrayBufferView.h:
* html/canvas/DataView.cpp:
(WebCore::DataView::neuter):
* html/canvas/DataView.h:
* html/canvas/Float32Array.h:
* html/canvas/Float64Array.h:
* html/canvas/Int16Array.h:
* html/canvas/Int32Array.h:
* html/canvas/Int8Array.h:
* html/canvas/Uint16Array.h:
* html/canvas/Uint32Array.h:
* html/canvas/Uint8Array.h:
Source/WebKit/chromium: Get rid of WebCore dependencies from TypedArray implementation types
https://bugs.webkit.org/show_bug.cgi?id=72783
Reviewed by David Levin.
* src/WebArrayBufferView.cpp: WebCore replaced with WTF
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/html/canvas/ArrayBuffer.cpp
trunk/Source/WebCore/html/canvas/ArrayBuffer.h
trunk/Source/WebCore/html/canvas/ArrayBufferView.cpp
trunk/Source/WebCore/html/canvas/ArrayBufferView.h
trunk/Source/WebCore/html/canvas/DataView.cpp
trunk/Source/WebCore/html/canvas/DataView.h
trunk/Source/WebCore/html/canvas/Float32Array.h
trunk/Source/WebCore/html/canvas/Float64Array.h
trunk/Source/WebCore/html/canvas/Int16Array.h
trunk/Source/WebCore/html/canvas/Int32Array.h
trunk/Source/WebCore/html/canvas/Int8Array.h
trunk/Source/WebCore/html/canvas/Uint16Array.h
trunk/Source/WebCore/html/canvas/Uint32Array.h
trunk/Source/WebCore/html/canvas/Uint8Array.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebArrayBufferView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (101063 => 101064)
--- trunk/Source/WebCore/ChangeLog 2011-11-23 11:55:12 UTC (rev 101063)
+++ trunk/Source/WebCore/ChangeLog 2011-11-23 12:06:49 UTC (rev 101064)
@@ -1,3 +1,33 @@
+2011-11-23 Dmitry Lomov dslo...@google.com
+
+Get rid of WebCore dependencies from TypedArray implementation types
+https://bugs.webkit.org/show_bug.cgi?id=72783
+
+Reviewed by David Levin.
+
+Remove WebCore specific logic for neutering Typed Array implementations.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation):
+* bindings/scripts/CodeGeneratorV8.pm:
+* html/canvas/ArrayBuffer.cpp:
+(WTF::ArrayBuffer::transfer):
+* html/canvas/ArrayBuffer.h:
+* html/canvas/ArrayBufferView.cpp:
+(WTF::ArrayBufferView::neuter):
+* html/canvas/ArrayBufferView.h:
+* html/canvas/DataView.cpp:
+(WebCore::DataView::neuter):
+* html/canvas/DataView.h:
+* html/canvas/Float32Array.h:
+* html/canvas/Float64Array.h:
+* html/canvas/Int16Array.h:
+* html/canvas/Int32Array.h:
+* html/canvas/Int8Array.h:
+* html/canvas/Uint16Array.h:
+* html/canvas/Uint32Array.h:
+* html/canvas/Uint8Array.h:
+
2011-11-23 Raul Hudea rhu...@adobe.com
First step towards http://webkit.org/b/70025
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (101063 => 101064)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-23 11:55:12 UTC (rev 101063)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-23 12:06:49 UTC (rev 101064)
@@ -2236,23 +2236,6 @@
push(@implContent, ;\n}\n);
}
-if ($parentClassName eq JSArrayBufferView and IsTypedArrayType($implType)) {
-push(@implContent, END);
-}
-namespace WTF {
-void ${implType}::neuterBinding(WebCore::ScriptExecutionContext*) {
-}
-}
-namespace WebCore {
-END
-} elsif ($parentClassName eq JSArrayBufferView) {
-push(@implContent, END);
-void ${implType}::neuterBinding(ScriptExecutionContext*) {
-}
-END
-}
-
-
push(@implContent, \n}\n);
my $conditionalString = GenerateConditionalString($dataNode);
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (101063 => 101064)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-23 11:55:12 UTC (rev 101063)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-23 12:06:49 UTC (rev 101064)
@@ -2701,28 +2701,6 @@
GenerateToV8Converters($dataNode, $interfaceName, $className, $nativeType, $serializedAttribute);
-if (IsSubType($dataNode, ArrayBufferView) IsTypedArrayType($interfaceName) not $interfaceName eq ArrayBufferView) {
-push(@implContent, END);
-}
-namespace
[webkit-changes] [101099] trunk/Source/WebCore
Title: [101099] trunk/Source/WebCore
Revision 101099
Author dslo...@google.com
Date 2011-11-23 11:58:31 -0800 (Wed, 23 Nov 2011)
Log Message
Unreviewed, rebaseline binding tests after http://trac.webkit.org/changeset/101064.
* bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::toFloat64Array):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (101098 => 101099)
--- trunk/Source/WebCore/ChangeLog 2011-11-23 19:40:41 UTC (rev 101098)
+++ trunk/Source/WebCore/ChangeLog 2011-11-23 19:58:31 UTC (rev 101099)
@@ -1,3 +1,12 @@
+2011-11-23 Dmitry Lomov dslo...@google.com
+
+Unreviewed, rebaseline binding tests after http://trac.webkit.org/changeset/101064.
+
+* bindings/scripts/test/JS/JSFloat64Array.cpp:
+(WebCore::toFloat64Array):
+* bindings/scripts/test/V8/V8Float64Array.cpp:
+(WebCore::V8Float64Array::wrapSlow):
+
2011-11-23 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r101069.
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp (101098 => 101099)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp 2011-11-23 19:40:41 UTC (rev 101098)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp 2011-11-23 19:58:31 UTC (rev 101099)
@@ -246,11 +246,5 @@
{
return value.inherits(JSFloat64Array::s_info) ? static_castJSFloat64Array*(asObject(value))-impl() : 0;
}
-}
-namespace WTF {
-void Float64Array::neuterBinding(WebCore::ScriptExecutionContext*) {
-}
-}
-namespace WebCore {
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.cpp (101098 => 101099)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.cpp 2011-11-23 19:40:41 UTC (rev 101098)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.cpp 2011-11-23 19:58:31 UTC (rev 101099)
@@ -106,15 +106,6 @@
getDOMObjectMap().set(impl, wrapperHandle);
return wrapper;
}
-}
-namespace WTF {
-void Float64Array::neuterBinding(WebCore::ScriptExecutionContext*) {
-v8::Handlev8::Value bound = WebCore::toV8(this);
-v8::Handlev8::Object object(bound.Asv8::Object());
-object-SetIndexedPropertiesToExternalArrayData(0, v8::kExternalByteArray, 0);
-}
-}
-namespace WebCore {
void V8Float64Array::derefObject(void* object)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101118] trunk
Title: [101118] trunk
Revision 101118
Author dslo...@google.com
Date 2011-11-23 21:14:24 -0800 (Wed, 23 Nov 2011)
Log Message
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.
Reviewed by David Levin.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::serializedValueCallback):
* bindings/v8/OptionsObject.cpp:
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
* bindings/v8/SerializedScriptValue.h:
* bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
(WebCore::getMessagePortArray):
* bindings/v8/V8Utilities.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
* bindings/v8/custom/V8MessageEventCustom.cpp:
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8MessagePortCustom.h: Removed.
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
Source/WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.
Reviewed by David Levin.
* src/WebSerializedScriptValue.cpp:
(WebKit::WebSerializedScriptValue::serialize):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.
Tests rebaselined to reflect new error message.
Reviewed by David Levin.
* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
* platform/chromium/fast/events/constructors/message-event-constructor-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt
trunk/LayoutTests/platform/chromium/fast/events/constructors/message-event-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/v8/OptionsObject.cpp
trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp
trunk/Source/WebCore/bindings/v8/SerializedScriptValue.h
trunk/Source/WebCore/bindings/v8/V8Utilities.cpp
trunk/Source/WebCore/bindings/v8/V8Utilities.h
trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp
Removed Paths
trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.h
Diff
Modified: trunk/LayoutTests/ChangeLog (101117 => 101118)
--- trunk/LayoutTests/ChangeLog 2011-11-24 03:24:26 UTC (rev 101117)
+++ trunk/LayoutTests/ChangeLog 2011-11-24 05:14:24 UTC (rev 101118)
@@ -1,3 +1,14 @@
+2011-11-23 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=73054
+[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.
+Tests rebaselined to reflect new error message.
+
+Reviewed by David Levin.
+
+* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
+* platform/chromium/fast/events/constructors/message-event-constructor-expected.txt:
+
2011-11-23 Joshua Bell jsb...@chromium.org
IndexedDB: Remove stylesheet links from layout tests
Modified: trunk/LayoutTests/platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt (101117 => 101118)
--- trunk/LayoutTests/platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt 2011-11-24 03:24:26 UTC (rev 101117)
+++ trunk/LayoutTests/platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt 2011-11-24 05:14:24 UTC (rev 101118)
@@ -1,11 +1,11 @@
Test that the second argument of window.postMessage is ignored or triggers an error if it is not a message port. You should see PASS message '1' through '7', followed by 'done', with messages 4-7 received below.
-PASS: Posting message ('1', 1): threw exception TypeError: MessagePortArray argument must be an object
-PASS: Posting message ('1', 1): threw exception TypeError: MessagePortArray argument must be an object
-PASS: Posting message ('2', ): threw exception TypeError: MessagePortArray argument must be an object
-PASS: Posting message ('2', ): threw exception TypeError: MessagePortArray argument
[webkit-changes] [100381] trunk/LayoutTests
Title: [100381] trunk/LayoutTests Revision 100381 Author dslo...@google.com Date 2011-11-15 17:43:12 -0800 (Tue, 15 Nov 2011) Log Message Unreviewed; skipping fast/dom/Window/window-postmessage-arrays.html until https://bugs.webkit.org/show_bug.cgi?id=72435 is fixed. * platform/mac/Skipped: * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100380 => 100381) --- trunk/LayoutTests/ChangeLog 2011-11-16 01:41:33 UTC (rev 100380) +++ trunk/LayoutTests/ChangeLog 2011-11-16 01:43:12 UTC (rev 100381) @@ -1,3 +1,11 @@ +2011-11-15 Dmitry Lomov dslo...@google.com + +Unreviewed; skipping fast/dom/Window/window-postmessage-arrays.html +until https://bugs.webkit.org/show_bug.cgi?id=72435 is fixed. + +* platform/mac/Skipped: +* platform/win/Skipped: + 2011-11-15 Erik Arvidsson a...@chromium.org Rebaseline after r100289 Modified: trunk/LayoutTests/platform/mac/Skipped (100380 => 100381) --- trunk/LayoutTests/platform/mac/Skipped 2011-11-16 01:41:33 UTC (rev 100380) +++ trunk/LayoutTests/platform/mac/Skipped 2011-11-16 01:43:12 UTC (rev 100381) @@ -480,3 +480,8 @@ # DRT doesn't support overridePreference(WebKit*FontMap...) fast/text/international/locale-sensitive-fonts.html + +# https://bugs.webkit.org/show_bug.cgi?id=72435 +fast/dom/Window/window-postmessage-arrays.html + + Modified: trunk/LayoutTests/platform/win/Skipped (100380 => 100381) --- trunk/LayoutTests/platform/win/Skipped 2011-11-16 01:41:33 UTC (rev 100380) +++ trunk/LayoutTests/platform/win/Skipped 2011-11-16 01:43:12 UTC (rev 100381) @@ -1450,3 +1450,8 @@ # DRT doesn't support overridePreference(WebKit*FontMap...) fast/text/international/locale-sensitive-fonts.html + +# https://bugs.webkit.org/show_bug.cgi?id=72435 +fast/dom/Window/window-postmessage-arrays.html + + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100239] trunk
Title: [100239] trunk
Revision 100239
Author dslo...@google.com
Date 2011-11-14 22:14:31 -0800 (Mon, 14 Nov 2011)
Log Message
Source/WebCore: [V8][Chromium]Serialize dense arrays densly
https://bugs.webkit.org/show_bug.cgi?id=72198
This patch ensures that:
- Dense arrays are serialized densly, and not as name-value pairs
- Sparse arrays are allocated as sparse on deserialization.
The criteria to choose whether to serialize densly or sparsely is the size
of a resulting serialized stream.
Reviewed by David Levin.
Test: fast/dom/Window/window-postmessage-arrays.html
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::V8ObjectMap::Writer::writeDenseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshSparseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshDenseArray):
(WebCore::V8ObjectMap::Serializer::writeDenseArray):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::execDepth):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::serializeProperties):
(WebCore::V8ObjectMap::Serializer::ObjectState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::DenseArrayState):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::objectDone):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::SparseArrayState):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::serializeDensely):
(WebCore::V8ObjectMap::Serializer::startArrayState):
(WebCore::V8ObjectMap::Serializer::startObjectState):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Deserializer::newSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeDenseArray):
LayoutTests: [V8][Chromium]Serialize dense arrays densly.
https://bugs.webkit.org/show_bug.cgi?id=72198
Reviewed by David Levin.
* fast/dom/Window/script-tests/postmessage-clone.js:
* fast/dom/Window/window-postmessage-arrays-expected.txt: Added.
* fast/dom/Window/window-postmessage-arrays.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp
Added Paths
trunk/LayoutTests/fast/dom/Window/window-postmessage-arrays-expected.txt
trunk/LayoutTests/fast/dom/Window/window-postmessage-arrays.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100238 => 100239)
--- trunk/LayoutTests/ChangeLog 2011-11-15 06:07:16 UTC (rev 100238)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 06:14:31 UTC (rev 100239)
@@ -1,3 +1,14 @@
+2011-11-14 Dmitry Lomov dslo...@google.com
+
+[V8][Chromium]Serialize dense arrays densly.
+https://bugs.webkit.org/show_bug.cgi?id=72198
+
+Reviewed by David Levin.
+
+* fast/dom/Window/script-tests/postmessage-clone.js:
+* fast/dom/Window/window-postmessage-arrays-expected.txt: Added.
+* fast/dom/Window/window-postmessage-arrays.html: Added.
+
2011-11-14 Peter Kasting pkast...@google.com
[chromium] More rebaselines for r100177 after r100193 did not fully
Modified: trunk/LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js (100238 => 100239)
--- trunk/LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js 2011-11-15 06:07:16 UTC (rev 100238)
+++ trunk/LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js 2011-11-15 06:14:31 UTC (rev 100239)
@@ -97,7 +97,7 @@
'a[1] = b; ' +
'return a;'
), false, evalThunk, function(v) {
-doPassFail(v.length === 3, length correct); // undefined
+doPassFail(v.length === 3 || v.length === 2, length correct); // undefined
doPassFail(v[0] === 0, index 0 OK); // mandatory
doPassFail(v[1].x === 41, accessor reached); // mandatory
doPassFail(v[2] === undefined, index 2 undefined); // undefined
Added: trunk/LayoutTests/fast/dom/Window/window-postmessage-arrays-expected.txt (0 => 100239)
--- trunk/LayoutTests/fast/dom/Window/window-postmessage-arrays-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Window/window-postmessage-arrays-expected.txt 2011-11-15 06:14:31 UTC (rev 100239)
@@ -0,0 +1,30 @@
+PASS: i = 29
+PASS: i = 28
+PASS: i = 27
+PASS: i = 26
+PASS: i = 25
+PASS: i = 24
+PASS: i = 23
+PASS: i = 22
+PASS: i = 21
+PASS: i = 20
+PASS: i = 19
+PASS: i = 18
+PASS: i = 17
+PASS: i = 16
+PASS: i = 15
+PASS: i = 14
+PASS: i = 13
+PASS: i = 12
+PASS: i = 11
+PASS: i = 10
+PASS: i = 9
+PASS: i = 8
+PASS: i = 7
+PASS: i = 6
+PASS: i = 5
+PASS: i = 4
+PASS: i = 3
+PASS: i = 2
+PASS: i = 1
+Done.
Added: trunk/LayoutTests/fast/dom/Window/window-postmessage-arrays.html (0 => 100239)
--- trunk/LayoutTests/fast/dom/Window/window-postmessage-arrays.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Window/window-postmessage-arrays.html 2011-11-15
[webkit-changes] [99495] trunk/Source/JavaScriptCore
Title: [99495] trunk/Source/_javascript_Core
Revision 99495
Author dslo...@google.com
Date 2011-11-07 15:49:17 -0800 (Mon, 07 Nov 2011)
Log Message
Unreviewed. Release build fix.
* parser/Lexer.cpp:
(JSC::assertCharIsIn8BitRange):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Lexer.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99494 => 99495)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-07 23:46:08 UTC (rev 99494)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-07 23:49:17 UTC (rev 99495)
@@ -1,3 +1,10 @@
+2011-11-07 Dmitry Lomov dslo...@google.com
+
+Unreviewed. Release build fix.
+
+* parser/Lexer.cpp:
+(JSC::assertCharIsIn8BitRange):
+
2011-11-07 Filip Pizlo fpi...@apple.com
Switch the value profiler back to 8 buckets, because we suspect that while this
Modified: trunk/Source/_javascript_Core/parser/Lexer.cpp (99494 => 99495)
--- trunk/Source/_javascript_Core/parser/Lexer.cpp 2011-11-07 23:46:08 UTC (rev 99494)
+++ trunk/Source/_javascript_Core/parser/Lexer.cpp 2011-11-07 23:49:17 UTC (rev 99495)
@@ -428,6 +428,7 @@
template typename T
inline void assertCharIsIn8BitRange(T c)
{
+UNUSED_PARAM(c);
ASSERT(c = 0);
ASSERT(c = 0xFF);
}
@@ -435,6 +436,7 @@
template
inline void assertCharIsIn8BitRange(UChar c)
{
+UNUSED_PARAM(c);
ASSERT(c = 0xFF);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99507] trunk/Source/WebCore
Title: [99507] trunk/Source/WebCore
Revision 99507
Author dslo...@google.com
Date 2011-11-07 16:59:33 -0800 (Mon, 07 Nov 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=71534
[V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache.
Reviewed by David Levin.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
* html/canvas/DataView.cpp:
* html/canvas/DataView.h:
* html/canvas/Float32Array.h:
* html/canvas/Float64Array.h:
* html/canvas/Int16Array.h:
* html/canvas/Int32Array.h:
* html/canvas/Int8Array.h:
* html/canvas/TypedArrayBase.h:
* html/canvas/Uint16Array.h:
* html/canvas/Uint32Array.h:
* html/canvas/Uint8Array.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/html/canvas/DataView.cpp
trunk/Source/WebCore/html/canvas/DataView.h
trunk/Source/WebCore/html/canvas/Float32Array.h
trunk/Source/WebCore/html/canvas/Float64Array.h
trunk/Source/WebCore/html/canvas/Int16Array.h
trunk/Source/WebCore/html/canvas/Int32Array.h
trunk/Source/WebCore/html/canvas/Int8Array.h
trunk/Source/WebCore/html/canvas/TypedArrayBase.h
trunk/Source/WebCore/html/canvas/Uint16Array.h
trunk/Source/WebCore/html/canvas/Uint32Array.h
trunk/Source/WebCore/html/canvas/Uint8Array.h
Property Changed
trunk/Source/WebCore/ChangeLog
Diff
Modified: trunk/Source/WebCore/ChangeLog (99506 => 99507)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 00:57:10 UTC (rev 99506)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 00:59:33 UTC (rev 99507)
@@ -1,3 +1,25 @@
+2011-11-07 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=71534
+[V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache.
+
+Reviewed by David Levin.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation):
+* bindings/scripts/CodeGeneratorV8.pm:
+* html/canvas/DataView.cpp:
+* html/canvas/DataView.h:
+* html/canvas/Float32Array.h:
+* html/canvas/Float64Array.h:
+* html/canvas/Int16Array.h:
+* html/canvas/Int32Array.h:
+* html/canvas/Int8Array.h:
+* html/canvas/TypedArrayBase.h:
+* html/canvas/Uint16Array.h:
+* html/canvas/Uint32Array.h:
+* html/canvas/Uint8Array.h:
+
2011-11-07 Adam Barth aba...@webkit.org
addMessage's last few arguments should be optional
Property changes on: trunk/Source/WebCore/ChangeLog
___
Deleted: svn:executable
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (99506 => 99507)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-08 00:57:10 UTC (rev 99506)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-08 00:59:33 UTC (rev 99507)
@@ -2216,6 +2216,14 @@
push(@implContent, ;\n}\n);
}
+if ($parentClassName eq JSArrayBufferView) {
+push(@implContent, END);
+void ${implType}::neuterBinding(ScriptExecutionContext*) {
+}
+END
+}
+
+
push(@implContent, \n}\n);
my $conditionalString = GenerateConditionalString($dataNode);
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (99506 => 99507)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-08 00:57:10 UTC (rev 99506)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-08 00:59:33 UTC (rev 99507)
@@ -2476,6 +2476,16 @@
GenerateToV8Converters($dataNode, $interfaceName, $className, $nativeType, $serializedAttribute);
+if (IsSubType($dataNode, ArrayBufferView) not $interfaceName eq ArrayBufferView) {
+push(@implContent, END);
+void ${nativeType}::neuterBinding(ScriptExecutionContext*) {
+v8::Handlev8::Value bound = toV8(this);
+v8::Handlev8::Object object(bound.Asv8::Object());
+object-SetIndexedPropertiesToExternalArrayData(0, v8::kExternalByteArray, 0);
+}
+END
+}
+
push(@implContent, END);
void ${className}::derefObject(void* object)
Modified: trunk/Source/WebCore/html/canvas/DataView.cpp (99506 => 99507)
--- trunk/Source/WebCore/html/canvas/DataView.cpp 2011-11-08 00:57:10 UTC (rev 99506)
+++ trunk/Source/WebCore/html/canvas/DataView.cpp 2011-11-08 00:59:33 UTC (rev 99507)
@@ -242,9 +242,4 @@
neuterBinding(context);
}
-void DataView::neuterBinding(ScriptExecutionContext*)
-{
-// FIXME https://bugs.webkit.org/show_bug.cgi?id=71534
}
-
-}
Modified: trunk/Source/WebCore/html/canvas/DataView.h (99506 => 99507)
--- trunk/Source/WebCore/html/canvas/DataView.h 2011-11-08 00:57:10 UTC (rev 99506)
+++ trunk/Source/WebCore/html/canvas/DataView.h 2011-11-08 00:59:33 UTC (rev 99507)
@@ -74,7 +74,7 @@
protected:
virtual void neuter(ScriptExecutionContext*);
-
[webkit-changes] [99324] trunk/Source/WebCore
Title: [99324] trunk/Source/WebCore
Revision 99324
Author dslo...@google.com
Date 2011-11-04 14:43:56 -0700 (Fri, 04 Nov 2011)
Log Message
Add the ability to transfer ArrayBuffer and neuter it.
https://bugs.webkit.org/show_bug.cgi?id=71535
Reviewed by David Levin.
* html/canvas/ArrayBuffer.cpp:
(WebCore::ArrayBuffer::create):
(WebCore::ArrayBuffer::ArrayBuffer):
(WebCore::ArrayBuffer::data):
(WebCore::ArrayBuffer::byteLength):
(WebCore::ArrayBuffer::transfer):
(WebCore::ArrayBufferContents::~ArrayBufferContents):
(WebCore::ArrayBufferContents::tryAllocate):
(WebCore::ArrayBuffer::addView):
(WebCore::ArrayBuffer::removeView):
* html/canvas/ArrayBuffer.h:
(WebCore::ArrayBufferContents::ArrayBufferContents):
(WebCore::ArrayBufferContents::data):
(WebCore::ArrayBufferContents::sizeInBytes):
(WebCore::ArrayBufferContents::release):
(WebCore::ArrayBuffer::~ArrayBuffer):
* html/canvas/ArrayBufferView.cpp:
(WebCore::ArrayBufferView::ArrayBufferView):
(WebCore::ArrayBufferView::~ArrayBufferView):
(WebCore::ArrayBufferView::neuter):
* html/canvas/ArrayBufferView.h:
* html/canvas/DataView.cpp:
(WebCore::DataView::neuter):
(WebCore::DataView::neuterBinding):
* html/canvas/DataView.h:
* html/canvas/TypedArrayBase.h:
(WebCore::TypedArrayBase::neuter):
(WebCore::TypedArrayBase::neuterBinding):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/ArrayBuffer.cpp
trunk/Source/WebCore/html/canvas/ArrayBuffer.h
trunk/Source/WebCore/html/canvas/ArrayBufferView.cpp
trunk/Source/WebCore/html/canvas/ArrayBufferView.h
trunk/Source/WebCore/html/canvas/DataView.cpp
trunk/Source/WebCore/html/canvas/DataView.h
trunk/Source/WebCore/html/canvas/TypedArrayBase.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99323 => 99324)
--- trunk/Source/WebCore/ChangeLog 2011-11-04 21:42:27 UTC (rev 99323)
+++ trunk/Source/WebCore/ChangeLog 2011-11-04 21:43:56 UTC (rev 99324)
@@ -1,3 +1,39 @@
+2011-11-04 Dmitry Lomov dslo...@google.com
+
+Add the ability to transfer ArrayBuffer and neuter it.
+https://bugs.webkit.org/show_bug.cgi?id=71535
+
+Reviewed by David Levin.
+
+* html/canvas/ArrayBuffer.cpp:
+(WebCore::ArrayBuffer::create):
+(WebCore::ArrayBuffer::ArrayBuffer):
+(WebCore::ArrayBuffer::data):
+(WebCore::ArrayBuffer::byteLength):
+(WebCore::ArrayBuffer::transfer):
+(WebCore::ArrayBufferContents::~ArrayBufferContents):
+(WebCore::ArrayBufferContents::tryAllocate):
+(WebCore::ArrayBuffer::addView):
+(WebCore::ArrayBuffer::removeView):
+* html/canvas/ArrayBuffer.h:
+(WebCore::ArrayBufferContents::ArrayBufferContents):
+(WebCore::ArrayBufferContents::data):
+(WebCore::ArrayBufferContents::sizeInBytes):
+(WebCore::ArrayBufferContents::release):
+(WebCore::ArrayBuffer::~ArrayBuffer):
+* html/canvas/ArrayBufferView.cpp:
+(WebCore::ArrayBufferView::ArrayBufferView):
+(WebCore::ArrayBufferView::~ArrayBufferView):
+(WebCore::ArrayBufferView::neuter):
+* html/canvas/ArrayBufferView.h:
+* html/canvas/DataView.cpp:
+(WebCore::DataView::neuter):
+(WebCore::DataView::neuterBinding):
+* html/canvas/DataView.h:
+* html/canvas/TypedArrayBase.h:
+(WebCore::TypedArrayBase::neuter):
+(WebCore::TypedArrayBase::neuterBinding):
+
2011-11-04 Noel Gordon noel.gor...@gmail.com
[Chromium] Implement canvas.toDataURL(image/webp)
Modified: trunk/Source/WebCore/html/canvas/ArrayBuffer.cpp (99323 => 99324)
--- trunk/Source/WebCore/html/canvas/ArrayBuffer.cpp 2011-11-04 21:42:27 UTC (rev 99323)
+++ trunk/Source/WebCore/html/canvas/ArrayBuffer.cpp 2011-11-04 21:43:56 UTC (rev 99324)
@@ -25,6 +25,7 @@
#include config.h
#include ArrayBuffer.h
+#include ArrayBufferView.h
#include wtf/RefPtr.h
@@ -42,10 +43,11 @@
PassRefPtrArrayBuffer ArrayBuffer::create(unsigned numElements, unsigned elementByteSize)
{
-void* data = "" elementByteSize);
-if (!data)
+ArrayBufferContents contents;
+ArrayBufferContents::tryAllocate(numElements, elementByteSize, contents);
+if (!contents.m_data)
return 0;
-return adoptRef(new ArrayBuffer(data, numElements * elementByteSize));
+return adoptRef(new ArrayBuffer(contents));
}
PassRefPtrArrayBuffer ArrayBuffer::create(ArrayBuffer* other)
@@ -55,33 +57,39 @@
PassRefPtrArrayBuffer ArrayBuffer::create(const void* source, unsigned byteLength)
{
-void* data = "" 1);
-if (!data)
+ArrayBufferContents contents;
+ArrayBufferContents::tryAllocate(byteLength, 1, contents);
+if (!contents.m_data)
return 0;
-RefPtrArrayBuffer buffer = adoptRef(new ArrayBuffer(data, byteLength));
+RefPtrArrayBuffer buffer = adoptRef(new ArrayBuffer(contents));
memcpy(buffer-data(), source, byteLength);
return buffer.release();
}
-ArrayBuffer::ArrayBuffer(void* data,
[webkit-changes] [98879] trunk
Title: [98879] trunk Revision 98879 Author dslo...@google.com Date 2011-10-31 14:07:22 -0700 (Mon, 31 Oct 2011) Log Message Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=70658 [JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage. Transfer of MessagePorts implemented. Reviewed by David Levin. * bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::serialize): (WebCore::CloneSerializer::CloneSerializer): (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::deserialize): (WebCore::CloneDeserializer::CloneDeserializer): (WebCore::CloneDeserializer::readTerminal): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::deserialize): LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=70658 [JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage. Some 'FAIL's remain in expected test results. These are due to the fact that JSC bindings chose not to throw type error exception for non-serializable values - non-serializable values are serialized as null. Reviewed by David Levin. * fast/dom/Window/window-postmessage-args-expected.txt: * fast/events/message-port-multi-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt trunk/LayoutTests/fast/events/message-port-multi-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp Diff Modified: trunk/LayoutTests/ChangeLog (98878 => 98879) --- trunk/LayoutTests/ChangeLog 2011-10-31 21:03:21 UTC (rev 98878) +++ trunk/LayoutTests/ChangeLog 2011-10-31 21:07:22 UTC (rev 98879) @@ -1,3 +1,16 @@ +2011-10-31 Dmitry Lomov dslo...@google.com + +https://bugs.webkit.org/show_bug.cgi?id=70658 +[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage. +Some 'FAIL's remain in expected test results. These are due to the fact that +JSC bindings chose not to throw type error exception for non-serializable values - +non-serializable values are serialized as null. + +Reviewed by David Levin. + +* fast/dom/Window/window-postmessage-args-expected.txt: +* fast/events/message-port-multi-expected.txt: + 2011-10-31 John Gregg john...@google.com Unreviewed, inspector/debugger/bind-script-to-resource.html fails after r98847 Modified: trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt (98878 => 98879) --- trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-10-31 21:03:21 UTC (rev 98878) +++ trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt 2011-10-31 21:07:22 UTC (rev 98879) @@ -31,7 +31,7 @@ Received message '2147483648' with 0 ports. Received message '2147483648' with 0 ports. Received message '[object Object]' with 2 ports. -Received message '[object Object]' with 2 ports. -Received message '[object Object],[object Object]' with 2 ports. +Received message '[object MessagePort]' with 2 ports. +Received message '[object MessagePort],[object MessagePort]' with 2 ports. Received message 'done' with 0 ports. Modified: trunk/LayoutTests/fast/events/message-port-multi-expected.txt (98878 => 98879) --- trunk/LayoutTests/fast/events/message-port-multi-expected.txt 2011-10-31 21:03:21 UTC (rev 98878) +++ trunk/LayoutTests/fast/events/message-port-multi-expected.txt 2011-10-31 21:07:22 UTC (rev 98879) @@ -15,9 +15,9 @@ PASS event.ports contains two ports when two ports sent PASS event.ports contains two ports when two ports re-sent after error FAIL Sending host object should throw -FAIL send-port: port transfer failed -FAIL send-port-twice: failed to transfer one port twice -FAIL send-two-ports: failed to transfer two ports +PASS send-port: transferred one port +PASS send-port-twice: transferred one port twice +PASS send-two-ports: transferred two ports FAIL Unexpected message [object Object] TEST COMPLETE Modified: trunk/Source/WebCore/ChangeLog (98878 => 98879) --- trunk/Source/WebCore/ChangeLog 2011-10-31 21:03:21 UTC (rev 98878) +++ trunk/Source/WebCore/ChangeLog 2011-10-31 21:07:22 UTC (rev 98879) @@ -1,3 +1,21 @@ +2011-10-31 Dmitry Lomov dslo...@google.com + +https://bugs.webkit.org/show_bug.cgi?id=70658 +[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage. +Transfer of MessagePorts implemented. + +Reviewed by David Levin. + +* bindings/js/SerializedScriptValue.cpp: +(WebCore::CloneSerializer::serialize): +(WebCore::CloneSerializer::CloneSerializer): +(WebCore::CloneSerializer::dumpIfTerminal): +(WebCore::CloneDeserializer::deserialize): +(WebCore::CloneDeserializer::CloneDeserializer): +(WebCore::CloneDeserializer::readTerminal): +(WebCore::SerializedScriptValue::create): +
[webkit-changes] [97576] trunk/Source/WebCore
Title: [97576] trunk/Source/WebCore
Revision 97576
Author dslo...@google.com
Date 2011-10-16 12:19:42 -0700 (Sun, 16 Oct 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=70186
Pass MessagePortArray to JSC's SerializedScriptValue::serialize/deserialize.
Reviewed by Oliver Hunt.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::handlePostMessage):
(WebCore::JSDOMWindow::postMessage):
(WebCore::JSDOMWindow::webkitPostMessage):
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
(WebCore::handleInitMessageEvent):
(WebCore::JSMessageEvent::initMessageEvent):
(WebCore::JSMessageEvent::webkitInitMessageEvent):
* bindings/js/JSMessagePortCustom.h:
(WebCore::handlePostMessage):
* bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state):
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::deserialize):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
* bindings/js/SerializedScriptValue.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/bindings/js/JSDictionary.cpp
trunk/Source/WebCore/bindings/js/JSHistoryCustom.cpp
trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp
trunk/Source/WebCore/bindings/js/JSMessagePortCustom.h
trunk/Source/WebCore/bindings/js/JSPopStateEventCustom.cpp
trunk/Source/WebCore/bindings/js/ScriptValue.cpp
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/bindings/js/SerializedScriptValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97575 => 97576)
--- trunk/Source/WebCore/ChangeLog 2011-10-16 15:55:33 UTC (rev 97575)
+++ trunk/Source/WebCore/ChangeLog 2011-10-16 19:19:42 UTC (rev 97576)
@@ -1,3 +1,36 @@
+2011-10-16 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=70186
+Pass MessagePortArray to JSC's SerializedScriptValue::serialize/deserialize.
+
+Reviewed by Oliver Hunt.
+
+* bindings/js/JSDOMWindowCustom.cpp:
+(WebCore::handlePostMessage):
+(WebCore::JSDOMWindow::postMessage):
+(WebCore::JSDOMWindow::webkitPostMessage):
+* bindings/js/JSDictionary.cpp:
+(WebCore::JSDictionary::convertValue):
+* bindings/js/JSHistoryCustom.cpp:
+(WebCore::JSHistory::pushState):
+(WebCore::JSHistory::replaceState):
+* bindings/js/JSMessageEventCustom.cpp:
+(WebCore::JSMessageEvent::data):
+(WebCore::handleInitMessageEvent):
+(WebCore::JSMessageEvent::initMessageEvent):
+(WebCore::JSMessageEvent::webkitInitMessageEvent):
+* bindings/js/JSMessagePortCustom.h:
+(WebCore::handlePostMessage):
+* bindings/js/JSPopStateEventCustom.cpp:
+(WebCore::JSPopStateEvent::state):
+* bindings/js/ScriptValue.cpp:
+(WebCore::ScriptValue::serialize):
+(WebCore::ScriptValue::deserialize):
+* bindings/js/SerializedScriptValue.cpp:
+(WebCore::SerializedScriptValue::create):
+(WebCore::SerializedScriptValue::deserialize):
+* bindings/js/SerializedScriptValue.h:
+
2011-10-16 Dan Bernstein m...@apple.com
REGRESSION (r96620): Float-avoiding block positioned incorrectly in right-to-left block
Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (97575 => 97576)
--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2011-10-16 15:55:33 UTC (rev 97575)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2011-10-16 19:19:42 UTC (rev 97576)
@@ -715,33 +715,39 @@
return handler.returnValue();
}
-JSValue JSDOMWindow::postMessage(ExecState* exec)
+static JSValue handlePostMessage(DOMWindow* impl, ExecState* exec, bool doTransfer)
{
-RefPtrSerializedScriptValue message = SerializedScriptValue::create(exec, exec-argument(0));
-
-if (exec-hadException())
-return jsUndefined();
-
MessagePortArray messagePorts;
if (exec-argumentCount() 2)
fillMessagePortArray(exec, exec-argument(1), messagePorts);
if (exec-hadException())
return jsUndefined();
+RefPtrSerializedScriptValue message = SerializedScriptValue::create(exec, exec-argument(0),
+ doTransfer ? messagePorts : 0);
+
+if (exec-hadException())
+return jsUndefined();
+
String targetOrigin = valueToStringWithUndefinedOrNullCheck(exec, exec-argument((exec-argumentCount() == 2) ? 1 : 2));
if (exec-hadException())
return jsUndefined();
ExceptionCode ec = 0;
-impl()-postMessage(message.release(), messagePorts, targetOrigin, activeDOMWindow(exec), ec);
+
[webkit-changes] [97516] trunk/Source
Title: [97516] trunk/Source Revision 97516 Author dslo...@google.com Date 2011-10-14 15:13:00 -0700 (Fri, 14 Oct 2011) Log Message https://bugs.webkit.org/show_bug.cgi?id=70120 [Chromium] Pass MessagePortArray to SerializedScriptValue::serialize/deserialize. This patch augments SerializedScriptValue with MessagePortArray* parameter to implement MessagePort transfer within the message in the future. Reviewed by David Levin. Source/WebCore: * bindings/scripts/CodeGeneratorV8.pm: (GenerateParametersCheck): * bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::SerializedScriptValue): (WebCore::SerializedScriptValue::deserialize): * bindings/v8/SerializedScriptValue.h: * bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::handlePostMessageCallback): (WebCore::V8DOMWindow::postMessageCallback): (WebCore::V8DOMWindow::webkitPostMessageCallback): * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: (WebCore::handlePostMessageCallback): (WebCore::V8DedicatedWorkerContext::postMessageCallback): (WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback): * bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::pushStateCallback): (WebCore::V8History::replaceStateCallback): * bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::dataAccessorGetter): * bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::handlePostMessageCallback): (WebCore::V8MessagePort::postMessageCallback): (WebCore::V8MessagePort::webkitPostMessageCallback): * bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::handlePostMessageCallback): (WebCore::V8Worker::postMessageCallback): (WebCore::V8Worker::webkitPostMessageCallback): * workers/Worker.idl: Source/WebKit/chromium: * src/WebSerializedScriptValue.cpp: (WebKit::WebSerializedScriptValue::serialize): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp trunk/Source/WebCore/bindings/v8/SerializedScriptValue.h trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp trunk/Source/WebCore/workers/Worker.idl trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (97515 => 97516) --- trunk/Source/WebCore/ChangeLog 2011-10-14 22:11:30 UTC (rev 97515) +++ trunk/Source/WebCore/ChangeLog 2011-10-14 22:13:00 UTC (rev 97516) @@ -1,3 +1,42 @@ +2011-10-14 Dmitry Lomov dslo...@google.com + +https://bugs.webkit.org/show_bug.cgi?id=70120 +[Chromium] Pass MessagePortArray to SerializedScriptValue::serialize/deserialize. +This patch augments SerializedScriptValue with MessagePortArray* parameter to implement MessagePort +transfer within the message in the future. + +Reviewed by David Levin. + +* bindings/scripts/CodeGeneratorV8.pm: +(GenerateParametersCheck): +* bindings/v8/SerializedScriptValue.cpp: +(WebCore::SerializedScriptValue::create): +(WebCore::SerializedScriptValue::SerializedScriptValue): +(WebCore::SerializedScriptValue::deserialize): +* bindings/v8/SerializedScriptValue.h: +* bindings/v8/custom/V8DOMWindowCustom.cpp: +(WebCore::handlePostMessageCallback): +(WebCore::V8DOMWindow::postMessageCallback): +(WebCore::V8DOMWindow::webkitPostMessageCallback): +* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: +(WebCore::handlePostMessageCallback): +(WebCore::V8DedicatedWorkerContext::postMessageCallback): +(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback): +* bindings/v8/custom/V8HistoryCustom.cpp: +(WebCore::V8History::pushStateCallback): +(WebCore::V8History::replaceStateCallback): +* bindings/v8/custom/V8MessageEventCustom.cpp: +(WebCore::V8MessageEvent::dataAccessorGetter): +* bindings/v8/custom/V8MessagePortCustom.cpp: +(WebCore::handlePostMessageCallback): +(WebCore::V8MessagePort::postMessageCallback): +(WebCore::V8MessagePort::webkitPostMessageCallback): +* bindings/v8/custom/V8WorkerCustom.cpp: +(WebCore::handlePostMessageCallback): +(WebCore::V8Worker::postMessageCallback): +(WebCore::V8Worker::webkitPostMessageCallback): +* workers/Worker.idl: + 2011-10-14 Jeff Miller je...@apple.com InjectedBundleHitTestResult::imageRect() should return rect in WKView coordinates Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (97515 => 97516) ---
[webkit-changes] [95653] trunk/LayoutTests
Title: [95653] trunk/LayoutTests Revision 95653 Author dslo...@google.com Date 2011-09-21 11:38:58 -0700 (Wed, 21 Sep 2011) Log Message Fixed bug number in test expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (95652 => 95653) --- trunk/LayoutTests/ChangeLog 2011-09-21 18:33:43 UTC (rev 95652) +++ trunk/LayoutTests/ChangeLog 2011-09-21 18:38:58 UTC (rev 95653) @@ -1,3 +1,9 @@ +2011-09-21 Dmitry Lomov dslo...@google.com + +Fixed bug number in test expectations. + +* platform/chromium/test_expectations.txt: + 2011-09-21 Vsevolod Vlasov vse...@chromium.org Web Inspector: clear resource agent resource cache upon resource agent's disable. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95652 => 95653) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-21 18:33:43 UTC (rev 95652) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-21 18:38:58 UTC (rev 95653) @@ -3849,7 +3849,7 @@ BUGWK68270 LEOPARD CPU DEBUG : fast/css/only-child-pseudo-class.html = IMAGE BUGWK68270 LEOPARD CPU DEBUG : fast/css/only-of-type-pseudo-class.html = IMAGE -BUGWK88444 : fast/js/string-split-conformance.html = FAIL +BUGWK68445 : fast/js/string-split-conformance.html = FAIL // Tests that have become flaky (causing regressions, but only sometimes) BUG_EPOGER SNOWLEOPARD CPU-CG CPU DEBUG : fast/js/try-catch-crash.html = PASS TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95438] trunk/LayoutTests
Title: [95438] trunk/LayoutTests Revision 95438 Author dslo...@google.com Date 2011-09-19 10:34:53 -0700 (Mon, 19 Sep 2011) Log Message [Chromium] Rebaseline expectations due to r95402. * platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (95437 => 95438) --- trunk/LayoutTests/ChangeLog 2011-09-19 17:18:07 UTC (rev 95437) +++ trunk/LayoutTests/ChangeLog 2011-09-19 17:34:53 UTC (rev 95438) @@ -1,3 +1,9 @@ +2011-09-19 Dmitry Lomov dslo...@google.com + + [Chromium] Rebaseline expectations due to r95402. + +* platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Removed. + 2011-09-19 Ilya Tikhonovsky loi...@chromium.org Unreviewed skip inspector/timeline/timeline-animation-frame.html on win platform. Deleted: trunk/LayoutTests/platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt (95437 => 95438) --- trunk/LayoutTests/platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt 2011-09-19 17:18:07 UTC (rev 95437) +++ trunk/LayoutTests/platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt 2011-09-19 17:34:53 UTC (rev 95438) @@ -1,21 +0,0 @@ - -This tests that the navigator object of a deleted frame is disconnected properly. Accessing fields or methods shouldn't crash the browser. - Check Navigator -navigator.appCodeName is OK -navigator.appName is OK -navigator.appVersion is OK -navigator.cookieEnabled is OK -navigator.getStorageUpdates() is OK -navigator.javaEnabled() is OK -navigator.language is OK -navigator.mimeTypes is OK -navigator.onLine is OK -navigator.platform is OK -navigator.plugins is OK -navigator.product is OK -navigator.productSub is OK -navigator.registerProtocolHandler() threw err TypeError: Not enough arguments -navigator.userAgent is OK -navigator.vendor is OK -navigator.vendorSub is OK - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95442] trunk/LayoutTests
Title: [95442] trunk/LayoutTests Revision 95442 Author dslo...@google.com Date 2011-09-19 11:12:08 -0700 (Mon, 19 Sep 2011) Log Message [Chromium] Rebaseline expectations and file WK68372. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (95441 => 95442) --- trunk/LayoutTests/ChangeLog 2011-09-19 18:03:06 UTC (rev 95441) +++ trunk/LayoutTests/ChangeLog 2011-09-19 18:12:08 UTC (rev 95442) @@ -1,5 +1,11 @@ 2011-09-19 Dmitry Lomov dslo...@google.com +[Chromium] Rebaseline expectations and file WK68372. + +* platform/chromium/test_expectations.txt: + +2011-09-19 Dmitry Lomov dslo...@google.com + [Chromium] Rebaseline expectations due to r95402. * platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Removed. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95441 => 95442) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-19 18:03:06 UTC (rev 95441) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-19 18:12:08 UTC (rev 95442) @@ -3756,3 +3756,4 @@ // Crashes or timeouts once in a while but never fails BUG_KEISHI LINUX : media/video-controls-visible-audio-only.html = PASS TIMEOUT CRASH +BUGWK68372 SNOWLEOPARD : svg/animations/svglength-animation-px-to-exs.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95368] trunk/Source/WebKit/chromium
Title: [95368] trunk/Source/WebKit/chromium
Revision 95368
Author dslo...@google.com
Date 2011-09-16 22:30:14 -0700 (Fri, 16 Sep 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=67733
[Chromium] Separate WebKit initialization and V8 initialization in chromium port.
Reviewed by Darin Fisher.
* public/WebKit.h:
* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::initializeWithoutV8):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebKit.h
trunk/Source/WebKit/chromium/src/WebKit.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (95367 => 95368)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-17 05:24:58 UTC (rev 95367)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-17 05:30:14 UTC (rev 95368)
@@ -1,3 +1,15 @@
+2011-09-16 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67733
+[Chromium] Separate WebKit initialization and V8 initialization in chromium port.
+
+Reviewed by Darin Fisher.
+
+* public/WebKit.h:
+* src/WebKit.cpp:
+(WebKit::initialize):
+(WebKit::initializeWithoutV8):
+
2011-09-16 Vincent Scheib sch...@chromium.org
[Chromium] Add movementX/Y members to WebMouseEvent
Modified: trunk/Source/WebKit/chromium/public/WebKit.h (95367 => 95368)
--- trunk/Source/WebKit/chromium/public/WebKit.h 2011-09-17 05:24:58 UTC (rev 95367)
+++ trunk/Source/WebKit/chromium/public/WebKit.h 2011-09-17 05:30:14 UTC (rev 95368)
@@ -42,6 +42,13 @@
// non-null and must remain valid until the current thread calls shutdown.
WEBKIT_EXPORT void initialize(WebKitPlatformSupport*);
+// Must be called on the thread that will be the main WebKit thread before
+// using any other WebKit APIs. The provided WebKitPlatformSupport; must be
+// non-null and must remain valid until the current thread calls shutdown.
+//
+// This is a special variant of initialize that does not intitialize V8.
+WEBKIT_EXPORT void initializeWithoutV8(WebKitPlatformSupport*);
+
// Once shutdown, the WebKitPlatformSupport passed to initialize will no longer
// be accessed. No other WebKit objects should be in use when this function is
// called. Any background threads created by WebKit are promised to be
Modified: trunk/Source/WebKit/chromium/src/WebKit.cpp (95367 => 95368)
--- trunk/Source/WebKit/chromium/src/WebKit.cpp 2011-09-17 05:24:58 UTC (rev 95367)
+++ trunk/Source/WebKit/chromium/src/WebKit.cpp 2011-09-17 05:30:14 UTC (rev 95368)
@@ -68,6 +68,15 @@
void initialize(WebKitPlatformSupport* webKitPlatformSupport)
{
+initializeWithoutV8(webKitPlatformSupport);
+
+v8::V8::SetEntropySource(generateEntropy);
+v8::V8::Initialize();
+WebCore::V8BindingPerIsolateData::ensureInitialized(v8::Isolate::GetCurrent());
+}
+
+void initializeWithoutV8(WebKitPlatformSupport* webKitPlatformSupport)
+{
ASSERT(!s_webKitInitialized);
s_webKitInitialized = true;
@@ -88,11 +97,10 @@
// this, initializing this lazily probably doesn't buy us much.
WebCore::UTF8Encoding();
-v8::V8::SetEntropySource(generateEntropy);
-v8::V8::Initialize();
-WebCore::V8BindingPerIsolateData::ensureInitialized(v8::Isolate::GetCurrent());
+
}
+
void shutdown()
{
s_webKitPlatformSupport = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94647] trunk/Source/WebCore
Title: [94647] trunk/Source/WebCore
Revision 94647
Author dslo...@google.com
Date 2011-09-07 00:50:23 -0700 (Wed, 07 Sep 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=67413
[Chromium]Web Inspector: inspected page with dedicated worker crashes on refresh.
This patch enforces lifetime ordering between WorkerInspectorController and WorkerScriptController.
Reviewed by Yury Semikhatsky.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::clearInspector):
* workers/WorkerContext.h:
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::performTask):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerContext.cpp
trunk/Source/WebCore/workers/WorkerContext.h
trunk/Source/WebCore/workers/WorkerThread.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94646 => 94647)
--- trunk/Source/WebCore/ChangeLog 2011-09-07 07:45:04 UTC (rev 94646)
+++ trunk/Source/WebCore/ChangeLog 2011-09-07 07:50:23 UTC (rev 94647)
@@ -1,3 +1,17 @@
+2011-09-07 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67413
+[Chromium]Web Inspector: inspected page with dedicated worker crashes on refresh.
+This patch enforces lifetime ordering between WorkerInspectorController and WorkerScriptController.
+
+Reviewed by Yury Semikhatsky.
+
+* workers/WorkerContext.cpp:
+(WebCore::WorkerContext::clearInspector):
+* workers/WorkerContext.h:
+* workers/WorkerThread.cpp:
+(WebCore::WorkerThreadShutdownFinishTask::performTask):
+
2011-09-07 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r94627 and r94632.
Modified: trunk/Source/WebCore/workers/WorkerContext.cpp (94646 => 94647)
--- trunk/Source/WebCore/workers/WorkerContext.cpp 2011-09-07 07:45:04 UTC (rev 94646)
+++ trunk/Source/WebCore/workers/WorkerContext.cpp 2011-09-07 07:50:23 UTC (rev 94647)
@@ -219,6 +219,13 @@
DOMTimer::removeById(scriptExecutionContext(), timeoutId);
}
+#if ENABLE(INSPECTOR)
+void WorkerContext::clearInspector()
+{
+m_workerInspectorController.clear();
+}
+#endif
+
int WorkerContext::setInterval(PassOwnPtrScheduledAction action, int timeout)
{
return DOMTimer::install(scriptExecutionContext(), action, timeout, false);
Modified: trunk/Source/WebCore/workers/WorkerContext.h (94646 => 94647)
--- trunk/Source/WebCore/workers/WorkerContext.h 2011-09-07 07:45:04 UTC (rev 94646)
+++ trunk/Source/WebCore/workers/WorkerContext.h 2011-09-07 07:50:23 UTC (rev 94647)
@@ -79,6 +79,9 @@
WorkerScriptController* script() { return m_script.get(); }
void clearScript() { m_script.clear(); }
+#if ENABLE(INSPECTOR)
+void clearInspector();
+#endif
WorkerThread* thread() const { return m_thread; }
Modified: trunk/Source/WebCore/workers/WorkerThread.cpp (94646 => 94647)
--- trunk/Source/WebCore/workers/WorkerThread.cpp 2011-09-07 07:45:04 UTC (rev 94646)
+++ trunk/Source/WebCore/workers/WorkerThread.cpp 2011-09-07 07:50:23 UTC (rev 94647)
@@ -174,6 +174,9 @@
{
ASSERT(context-isWorkerContext());
WorkerContext* workerContext = static_castWorkerContext*(context);
+#if ENABLE(INSPECTOR)
+workerContext-clearInspector();
+#endif
// It's not safe to call clearScript until all the cleanup tasks posted by functions initiated by WorkerThreadShutdownStartTask have completed.
workerContext-clearScript();
workerContext-thread()-runLoop().terminate();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92802] trunk/Source/WebKit/chromium
Title: [92802] trunk/Source/WebKit/chromium Revision 92802 Author dslo...@google.com Date 2011-08-10 16:51:29 -0700 (Wed, 10 Aug 2011) Log Message [Chromium] Decouple implementation of allowFileSystem, openFileSystem and allowDatabase from WebWorkerBase. https://bugs.webkit.org/show_bug.cgi?id=65997. This patch moves implementation of allowFileSystem, openFileSystem and allowDatabase from WebWorkerBase to respectively LocalFileSystemChromium and DatabaseObserver, parameterizing them with relevant data from WebWorker. Reviewed by Jian Li. * src/DatabaseObserver.cpp: Move allowDatabase from WebWorkerBase and update the caller. (WebKit::AllowDatabaseMainThreadBridge::create): (WebKit::AllowDatabaseMainThreadBridge::cancel): (WebKit::AllowDatabaseMainThreadBridge::result): (WebKit::AllowDatabaseMainThreadBridge::signalCompleted): (WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge): (WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask): (WebKit::AllowDatabaseMainThreadBridge::didComplete): (WebKit::allowDatabaseForWorker): (WebCore::DatabaseObserver::canEstablishDatabase): * src/LocalFileSystemChromium.cpp: Move allowFileSystem and openFileSystem from WebWorkerBase and update the caller. (WebCore::openFileSystemHelper): * src/WebWorkerBase.cpp: Move allowFileSystem, openFileSystem and allowDatabase to LocalFileSystemChromium and DatabaseObserver resp. * src/WebWorkerBase.h: (WebKit::WebWorkerBase::webView): * src/WorkerFileSystemCallbacksBridge.cpp: Generalized WorkerFileSystemCallbacksBridge to work on WorkerLoaderProxy, not on WebWorkerBase. (WebKit::WorkerFileSystemCallbacksBridge::stop): (WebKit::WorkerFileSystemCallbacksBridge::WorkerFileSystemCallbacksBridge): (WebKit::WorkerFileSystemCallbacksBridge::dispatchTaskToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker): * src/WorkerFileSystemCallbacksBridge.h: (WebKit::WorkerFileSystemCallbacksBridge::create): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/DatabaseObserver.cpp trunk/Source/WebKit/chromium/src/LocalFileSystemChromium.cpp trunk/Source/WebKit/chromium/src/WebWorkerBase.cpp trunk/Source/WebKit/chromium/src/WebWorkerBase.h trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (92801 => 92802) --- trunk/Source/WebKit/chromium/ChangeLog 2011-08-10 23:19:30 UTC (rev 92801) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-10 23:51:29 UTC (rev 92802) @@ -1,3 +1,37 @@ +2011-08-10 Dmitry Lomov dslo...@google.com + +[Chromium] Decouple implementation of allowFileSystem, openFileSystem and allowDatabase from WebWorkerBase. +https://bugs.webkit.org/show_bug.cgi?id=65997. + +This patch moves implementation of allowFileSystem, openFileSystem and allowDatabase from +WebWorkerBase to respectively LocalFileSystemChromium and DatabaseObserver, +parameterizing them with relevant data from WebWorker. + +Reviewed by Jian Li. + +* src/DatabaseObserver.cpp: Move allowDatabase from WebWorkerBase and update the caller. +(WebKit::AllowDatabaseMainThreadBridge::create): +(WebKit::AllowDatabaseMainThreadBridge::cancel): +(WebKit::AllowDatabaseMainThreadBridge::result): +(WebKit::AllowDatabaseMainThreadBridge::signalCompleted): +(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge): +(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask): +(WebKit::AllowDatabaseMainThreadBridge::didComplete): +(WebKit::allowDatabaseForWorker): +(WebCore::DatabaseObserver::canEstablishDatabase): +* src/LocalFileSystemChromium.cpp: Move allowFileSystem and openFileSystem from WebWorkerBase and update the caller. +(WebCore::openFileSystemHelper): +* src/WebWorkerBase.cpp: Move allowFileSystem, openFileSystem and allowDatabase to LocalFileSystemChromium and DatabaseObserver resp. +* src/WebWorkerBase.h: +(WebKit::WebWorkerBase::webView): +* src/WorkerFileSystemCallbacksBridge.cpp: Generalized WorkerFileSystemCallbacksBridge to work on WorkerLoaderProxy, not on WebWorkerBase. +(WebKit::WorkerFileSystemCallbacksBridge::stop): +(WebKit::WorkerFileSystemCallbacksBridge::WorkerFileSystemCallbacksBridge): +(WebKit::WorkerFileSystemCallbacksBridge::dispatchTaskToMainThread): +(WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker): +* src/WorkerFileSystemCallbacksBridge.h: +(WebKit::WorkerFileSystemCallbacksBridge::create): + 2011-08-10 Vsevolod Vlasov vse...@chromium.org Web Inspector: Remove Network.initialContentSet from protocol, store workers content on backend. Modified: trunk/Source/WebKit/chromium/src/DatabaseObserver.cpp (92801 => 92802) ---
[webkit-changes] [92694] trunk/Source
Title: [92694] trunk/Source Revision 92694 Author dslo...@google.com Date 2011-08-09 12:01:05 -0700 (Tue, 09 Aug 2011) Log Message Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=65778 [WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates. Reviewed by Dmitry Titov. Covered by existing tests. * bindings/v8/V8Binding.cpp: (WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData): * bindings/v8/V8Binding.h: (WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate): (WebCore::V8BindingPerIsolateData::hiddenPropertyName): (WebCore::V8BindingPerIsolateData::globalHandleMap): (WebCore::AllowAllocation::AllowAllocation):Moving to V8Binding.h from V8Utilities.h to resolve header dependency. (WebCore::AllowAllocation::~AllowAllocation): (WebCore::AllowAllocation::current): (WebCore::SafeAllocation::newInstance): * bindings/v8/V8GCController.cpp: (WebCore::currentGlobalHandleMap): (WebCore::enumerateGlobalHandles): (WebCore::V8GCController::registerGlobalHandle): (WebCore::V8GCController::unregisterGlobalHandle): * bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::createString): * bindings/v8/V8HiddenPropertyName.h: (WebCore::V8HiddenPropertyName::V8HiddenPropertyName): * bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::prepareListenerObject): * bindings/v8/V8NPObject.cpp: * bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::checkNewLegal): * bindings/v8/V8Utilities.h: * bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::initIsolate): * bindings/v8/WorkerContextExecutionProxy.h: * bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::scheduleExecutionTermination): Source/WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=65778 [WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates Reviewed by Dmitry Titov. * src/BoundObject.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/v8/V8Binding.cpp trunk/Source/WebCore/bindings/v8/V8Binding.h trunk/Source/WebCore/bindings/v8/V8GCController.cpp trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp trunk/Source/WebCore/bindings/v8/V8NPObject.cpp trunk/Source/WebCore/bindings/v8/V8Proxy.cpp trunk/Source/WebCore/bindings/v8/V8Utilities.h trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.h trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/BoundObject.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (92693 => 92694) --- trunk/Source/WebCore/ChangeLog 2011-08-09 18:36:47 UTC (rev 92693) +++ trunk/Source/WebCore/ChangeLog 2011-08-09 19:01:05 UTC (rev 92694) @@ -1,3 +1,44 @@ +2011-08-09 Dmitry Lomov dslo...@google.com + +https://bugs.webkit.org/show_bug.cgi?id=65778 +[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates. + +Reviewed by Dmitry Titov. + +Covered by existing tests. + +* bindings/v8/V8Binding.cpp: +(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData): +* bindings/v8/V8Binding.h: +(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate): +(WebCore::V8BindingPerIsolateData::hiddenPropertyName): +(WebCore::V8BindingPerIsolateData::globalHandleMap): +(WebCore::AllowAllocation::AllowAllocation):Moving to V8Binding.h from V8Utilities.h to resolve header dependency. +(WebCore::AllowAllocation::~AllowAllocation): +(WebCore::AllowAllocation::current): +(WebCore::SafeAllocation::newInstance): +* bindings/v8/V8GCController.cpp: +(WebCore::currentGlobalHandleMap): +(WebCore::enumerateGlobalHandles): +(WebCore::V8GCController::registerGlobalHandle): +(WebCore::V8GCController::unregisterGlobalHandle): +* bindings/v8/V8HiddenPropertyName.cpp: +(WebCore::V8HiddenPropertyName::createString): +* bindings/v8/V8HiddenPropertyName.h: +(WebCore::V8HiddenPropertyName::V8HiddenPropertyName): +* bindings/v8/V8LazyEventListener.cpp: +(WebCore::V8LazyEventListener::prepareListenerObject): +* bindings/v8/V8NPObject.cpp: +* bindings/v8/V8Proxy.cpp: +(WebCore::V8Proxy::checkNewLegal): +* bindings/v8/V8Utilities.h: +* bindings/v8/WorkerContextExecutionProxy.cpp: +(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): +(WebCore::WorkerContextExecutionProxy::initIsolate): +* bindings/v8/WorkerContextExecutionProxy.h: +* bindings/v8/WorkerScriptController.cpp: +
[webkit-changes] [92619] trunk/Source
Title: [92619] trunk/Source Revision 92619 Author dslo...@google.com Date 2011-08-08 12:11:33 -0700 (Mon, 08 Aug 2011) Log Message Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=65778 [WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates. Reviewed by David Levin. Covered by existing tests. * bindings/v8/V8Binding.h: (WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate): (WebCore::V8BindingPerIsolateData::hiddenPropertyName): (WebCore::V8BindingPerIsolateData::globalHandleMap): (WebCore::AllowAllocation::AllowAllocation): Moving to V8Binding.h from V8Utilities.h to resolve header dependency. (WebCore::AllowAllocation::~AllowAllocation): (WebCore::AllowAllocation::current): (WebCore::SafeAllocation::newInstance): * bindings/v8/V8GCController.cpp: (WebCore::currentGlobalHandleMap): (WebCore::enumerateGlobalHandles): (WebCore::V8GCController::registerGlobalHandle): (WebCore::V8GCController::unregisterGlobalHandle): * bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::createString): * bindings/v8/V8HiddenPropertyName.h: * bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::prepareListenerObject): * bindings/v8/V8NPObject.cpp: * bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::checkNewLegal): * bindings/v8/V8Utilities.h: * bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::initIsolate): * bindings/v8/WorkerContextExecutionProxy.h: * bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::scheduleExecutionTermination): Source/WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=65778 [WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates Reviewed by David Levin. * src/BoundObject.cpp: AllowAllocation moved from V8Utilities.h to V8Binding.h Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/v8/V8Binding.h trunk/Source/WebCore/bindings/v8/V8GCController.cpp trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp trunk/Source/WebCore/bindings/v8/V8NPObject.cpp trunk/Source/WebCore/bindings/v8/V8Proxy.cpp trunk/Source/WebCore/bindings/v8/V8Utilities.h trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.h trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/BoundObject.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (92618 => 92619) --- trunk/Source/WebCore/ChangeLog 2011-08-08 19:09:51 UTC (rev 92618) +++ trunk/Source/WebCore/ChangeLog 2011-08-08 19:11:33 UTC (rev 92619) @@ -1,3 +1,41 @@ +2011-08-08 Dmitry Lomov dslo...@google.com + +https://bugs.webkit.org/show_bug.cgi?id=65778 +[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates. + +Reviewed by David Levin. + +Covered by existing tests. + +* bindings/v8/V8Binding.h: +(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate): +(WebCore::V8BindingPerIsolateData::hiddenPropertyName): +(WebCore::V8BindingPerIsolateData::globalHandleMap): +(WebCore::AllowAllocation::AllowAllocation): Moving to V8Binding.h from V8Utilities.h to resolve header dependency. +(WebCore::AllowAllocation::~AllowAllocation): +(WebCore::AllowAllocation::current): +(WebCore::SafeAllocation::newInstance): +* bindings/v8/V8GCController.cpp: +(WebCore::currentGlobalHandleMap): +(WebCore::enumerateGlobalHandles): +(WebCore::V8GCController::registerGlobalHandle): +(WebCore::V8GCController::unregisterGlobalHandle): +* bindings/v8/V8HiddenPropertyName.cpp: +(WebCore::V8HiddenPropertyName::createString): +* bindings/v8/V8HiddenPropertyName.h: +* bindings/v8/V8LazyEventListener.cpp: +(WebCore::V8LazyEventListener::prepareListenerObject): +* bindings/v8/V8NPObject.cpp: +* bindings/v8/V8Proxy.cpp: +(WebCore::V8Proxy::checkNewLegal): +* bindings/v8/V8Utilities.h: +* bindings/v8/WorkerContextExecutionProxy.cpp: +(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): +(WebCore::WorkerContextExecutionProxy::initIsolate): +* bindings/v8/WorkerContextExecutionProxy.h: +* bindings/v8/WorkerScriptController.cpp: +(WebCore::WorkerScriptController::scheduleExecutionTermination): + 2011-08-08 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r92607. Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (92618 => 92619) --- trunk/Source/WebCore/bindings/v8/V8Binding.h 2011-08-08 19:09:51 UTC (rev
[webkit-changes] [92387] trunk/Source/ThirdParty
Title: [92387] trunk/Source/ThirdParty
Revision 92387
Author dslo...@google.com
Date 2011-08-04 10:52:20 -0700 (Thu, 04 Aug 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=61812
TestWebKitApi breaks in release mode due to gtest incompatibility with fast malloc
Disable fast malloc for offending class (::std::strstream) in gtest.
This looks like the most non-intrusive solution.
Reviewed by David Levin.
Modified Paths
trunk/Source/ThirdParty/ChangeLog
trunk/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h
Diff
Modified: trunk/Source/ThirdParty/ChangeLog (92386 => 92387)
--- trunk/Source/ThirdParty/ChangeLog 2011-08-04 17:48:40 UTC (rev 92386)
+++ trunk/Source/ThirdParty/ChangeLog 2011-08-04 17:52:20 UTC (rev 92387)
@@ -1,3 +1,19 @@
+2011-08-03 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=61812
+TestWebKitApi breaks in release mode due to gtest incompatibility with fast malloc
+
+Disable fast malloc for offending class (::std::strstream) in gtest.
+This looks like the most non-intrusive solution.
+
+Reviewed by David Levin.
+
+* gtest/include/gtest/internal/gtest-port.h:
+(testing::internal::StrStream::operator new):
+(testing::internal::StrStream::operator new[]):
+(testing::internal::StrStream::operator delete):
+(testing::internal::StrStream::operator delete[]):
+
2011-07-05 Adam Barth aba...@webkit.org
Import qunit _javascript_ unit testing framework
Modified: trunk/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h (92386 => 92387)
--- trunk/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h 2011-08-04 17:48:40 UTC (rev 92386)
+++ trunk/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h 2011-08-04 17:52:20 UTC (rev 92387)
@@ -609,8 +609,30 @@
class String;
-typedef ::std::stringstream StrStream;
+class StrStream : public ::std::stringstream {
+ public:
+ void* operator new(size_t, void* p) { return p; }
+ void* operator new[](size_t, void* p) { return p; }
+ void* operator new(size_t size) {
+return malloc(size);
+ }
+
+ void operator delete(void* p) {
+free(p);
+ }
+
+ void* operator new[](size_t size) {
+return malloc(size);
+ }
+
+ void operator delete[](void* p) {
+free(p);
+ }
+};
+
+
+
// A helper for suppressing warnings on constant condition. It just
// returns 'condition'.
GTEST_API_ bool IsTrue(bool condition);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92391] trunk/Tools
Title: [92391] trunk/Tools
Revision 92391
Author dslo...@google.com
Date 2011-08-04 11:17:11 -0700 (Thu, 04 Aug 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=65706
Run run-unit-tests on release mode test bots.
Reenabling after 61812 is fixed.
Reviewed by Adam Roben.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (92390 => 92391)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-08-04 18:11:57 UTC (rev 92390)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-08-04 18:17:11 UTC (rev 92391)
@@ -626,8 +626,7 @@
self.addStep(trigger.Trigger, schedulerNames=triggers)
def unitTestsSupported(configuration, platform):
-# FIXME: Only running in debug mode due to https://bugs.webkit.org/show_bug.cgi?id=61812
-return configuration == 'debug' and (platform == 'win' or (platform.startswith('mac') and platform != 'mac-leopard'))
+return platform == 'win' or (platform.startswith('mac') and platform != 'mac-leopard')
class TestFactory(Factory):
TestClass = RunWebKitTests
Modified: trunk/Tools/ChangeLog (92390 => 92391)
--- trunk/Tools/ChangeLog 2011-08-04 18:11:57 UTC (rev 92390)
+++ trunk/Tools/ChangeLog 2011-08-04 18:17:11 UTC (rev 92391)
@@ -1,3 +1,13 @@
+2011-08-04 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=65706
+Run run-unit-tests on release mode test bots.
+Reenabling after 61812 is fixed.
+
+Reviewed by Adam Roben.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+
2011-08-04 Adam Barth aba...@webkit.org
builders.js needs unit tests
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91814] trunk/Source/WebCore
Title: [91814] trunk/Source/WebCore
Revision 91814
Author dslo...@google.com
Date 2011-07-26 19:41:13 -0700 (Tue, 26 Jul 2011)
Log Message
[V8][Chromium] Run workers in a separate v8::Isolate
https://bugs.webkit.org/show_bug.cgi?id=65004
This patch allocates a new v8::Isolate for every worker and enters it on worker thread.
Reviewed by David Levin.
Covered by existing chromium tests.
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
* bindings/v8/StaticDOMDataStore.cpp:
(WebCore::StaticDOMDataStore::StaticDOMDataStore):
(WebCore::StaticDOMDataStore::~StaticDOMDataStore):
* bindings/v8/StaticDOMDataStore.h:
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::registerDOMDataStore):
(WebCore::V8BindingPerIsolateData::unregisterDOMDataStore):
* bindings/v8/V8DOMMap.cpp:
(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
(WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initV8):
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):
* bindings/v8/WorkerScriptController.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp
trunk/Source/WebCore/bindings/v8/StaticDOMDataStore.cpp
trunk/Source/WebCore/bindings/v8/StaticDOMDataStore.h
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
trunk/Source/WebCore/bindings/v8/V8DOMMap.cpp
trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp
trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.h
trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp
trunk/Source/WebCore/bindings/v8/WorkerScriptController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (91813 => 91814)
--- trunk/Source/WebCore/ChangeLog 2011-07-27 02:37:03 UTC (rev 91813)
+++ trunk/Source/WebCore/ChangeLog 2011-07-27 02:41:13 UTC (rev 91814)
@@ -1,3 +1,35 @@
+2011-07-26 Dmitry Lomov dslo...@google.com
+
+[V8][Chromium] Run workers in a separate v8::Isolate
+https://bugs.webkit.org/show_bug.cgi?id=65004
+This patch allocates a new v8::Isolate for every worker and enters it on worker thread.
+
+Reviewed by David Levin.
+
+Covered by existing chromium tests.
+
+* bindings/v8/DOMDataStore.cpp:
+(WebCore::DOMDataStore::DOMDataStore):
+(WebCore::DOMDataStore::~DOMDataStore):
+* bindings/v8/StaticDOMDataStore.cpp:
+(WebCore::StaticDOMDataStore::StaticDOMDataStore):
+(WebCore::StaticDOMDataStore::~StaticDOMDataStore):
+* bindings/v8/StaticDOMDataStore.h:
+* bindings/v8/V8Binding.h:
+(WebCore::V8BindingPerIsolateData::registerDOMDataStore):
+(WebCore::V8BindingPerIsolateData::unregisterDOMDataStore):
+* bindings/v8/V8DOMMap.cpp:
+(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
+(WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):
+* bindings/v8/WorkerContextExecutionProxy.cpp:
+(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
+(WebCore::WorkerContextExecutionProxy::initV8):
+* bindings/v8/WorkerContextExecutionProxy.h:
+* bindings/v8/WorkerScriptController.cpp:
+(WebCore::WorkerScriptController::WorkerScriptController):
+(WebCore::WorkerScriptController::~WorkerScriptController):
+* bindings/v8/WorkerScriptController.h:
+
2011-07-26 James Robinson jam...@chromium.org
[chromium] Avoid clearing the framebuffer when compositing in release builds
Modified: trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp (91813 => 91814)
--- trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp 2011-07-27 02:37:03 UTC (rev 91813)
+++ trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp 2011-07-27 02:41:13 UTC (rev 91814)
@@ -91,12 +91,10 @@
, m_domSvgElementInstanceMap(0)
#endif
{
-DOMDataStore::allStores().append(this);
}
DOMDataStore::~DOMDataStore()
{
-DOMDataStore::allStores().remove(DOMDataStore::allStores().find(this));
}
DOMDataList DOMDataStore::allStores()
Modified: trunk/Source/WebCore/bindings/v8/StaticDOMDataStore.cpp (91813 => 91814)
--- trunk/Source/WebCore/bindings/v8/StaticDOMDataStore.cpp 2011-07-27 02:37:03 UTC (rev 91813)
+++ trunk/Source/WebCore/bindings/v8/StaticDOMDataStore.cpp 2011-07-27 02:41:13 UTC (rev 91814)
@@ -30,6 +30,7 @@
#include config.h
#include StaticDOMDataStore.h
+#include V8Binding.h
namespace WebCore {
@@ -48,6 +49,12 @@
#if ENABLE(SVG)
m_domSvgElementInstanceMap = m_staticDomSvgElementInstanceMap;
#endif
+V8BindingPerIsolateData::current()-registerDOMDataStore(this);
}
[webkit-changes] [90931] trunk/Source/WebCore
Title: [90931] trunk/Source/WebCore
Revision 90931
Author dslo...@google.com
Date 2011-07-13 10:49:11 -0700 (Wed, 13 Jul 2011)
Log Message
2011-07-12 Dmitry Lomov dslo...@google.com
https://bugs.webkit.org/show_bug.cgi?id=63041
[Chromium][V8] Make DOMDataStore per-isolate
This patch:
- makes DOMData class an utility class with static members only
- adds an isolate-specific DOMDataStore in V8BindingPerIsolateData.
Dromaeo benchmarks are not affected.
Reviewed by Adam Barth.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/DOMData.cpp
trunk/Source/WebCore/bindings/v8/DOMData.h
trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp
trunk/Source/WebCore/bindings/v8/DOMDataStore.h
trunk/Source/WebCore/bindings/v8/ScopedDOMDataStore.cpp
trunk/Source/WebCore/bindings/v8/ScopedDOMDataStore.h
trunk/Source/WebCore/bindings/v8/StaticDOMDataStore.cpp
trunk/Source/WebCore/bindings/v8/StaticDOMDataStore.h
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
trunk/Source/WebCore/bindings/v8/V8DOMMap.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90930 => 90931)
--- trunk/Source/WebCore/ChangeLog 2011-07-13 17:36:43 UTC (rev 90930)
+++ trunk/Source/WebCore/ChangeLog 2011-07-13 17:49:11 UTC (rev 90931)
@@ -1,3 +1,39 @@
+2011-07-12 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=63041
+[Chromium][V8] Make DOMDataStore per-isolate
+This patch:
+ - makes DOMData class an utility class with static members only
+ - adds an isolate-specific DOMDataStore in V8BindingPerIsolateData.
+Dromaeo benchmarks are not affected.
+
+Reviewed by Adam Barth.
+
+* bindings/v8/DOMData.cpp:
+(WebCore::getDefaultStore):
+(WebCore::DOMData::getCurrentStore):
+* bindings/v8/DOMData.h:
+* bindings/v8/DOMDataStore.cpp:
+(WebCore::DOMDataStore::DOMDataStore):
+(WebCore::DOMDataStore::allStores):
+* bindings/v8/DOMDataStore.h:
+* bindings/v8/ScopedDOMDataStore.cpp:
+(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
+* bindings/v8/ScopedDOMDataStore.h:
+* bindings/v8/StaticDOMDataStore.cpp:
+(WebCore::StaticDOMDataStore::StaticDOMDataStore):
+* bindings/v8/StaticDOMDataStore.h:
+* bindings/v8/V8Binding.h:
+(WebCore::V8BindingPerIsolateData::allStores):
+(WebCore::V8BindingPerIsolateData::getDOMDataStore):
+(WebCore::V8BindingPerIsolateData::setDOMDataStore):
+* bindings/v8/V8Binding.cpp:
+(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
+* bindings/v8/V8DOMMap.cpp:
+(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
+(WebCore::getDOMDataStore):
+(WebCore::enableFasterDOMStoreAccess):
+
2011-07-12 Simon Fraser simon.fra...@apple.com
Rename compositing-related updateContentsScale() methods
Modified: trunk/Source/WebCore/bindings/v8/DOMData.cpp (90930 => 90931)
--- trunk/Source/WebCore/bindings/v8/DOMData.cpp 2011-07-13 17:36:43 UTC (rev 90930)
+++ trunk/Source/WebCore/bindings/v8/DOMData.cpp 2011-07-13 17:49:11 UTC (rev 90931)
@@ -30,36 +30,28 @@
#include config.h
#include DOMData.h
+#include V8Binding.h
#include V8IsolatedContext.h
#include WebGLContextAttributes.h
#include WebGLUniformLocation.h
namespace WebCore {
-DOMData::DOMData()
-: m_defaultStore(this)
+static StaticDOMDataStore getDefaultStore()
{
+DEFINE_STATIC_LOCAL(StaticDOMDataStore, defaultStore, ());
+return defaultStore;
}
-DOMData::~DOMData()
+DOMDataStore DOMData::getCurrentStore()
{
-}
-
-DOMData* DOMData::getCurrent()
-{
-DEFINE_STATIC_LOCAL(DOMData, mainThreadDOMData, ());
-return mainThreadDOMData;
-}
-
-DOMDataStore DOMData::getMainThreadStore()
-{
-// This is broken out as a separate non-virtual method from getStore()
-// so that it can be inlined by getCurrentMainThreadStore, which is
-// a hot spot in Dromaeo DOM tests.
+V8BindingPerIsolateData* data = ""
+if (UNLIKELY(data-domDataStore() != 0))
+return *data-domDataStore();
V8IsolatedContext* context = V8IsolatedContext::getEntered();
if (UNLIKELY(context != 0))
return *context-world()-domDataStore();
-return m_defaultStore;
+return getDefaultStore();
}
void DOMData::derefObject(WrapperTypeInfo* type, void* domObject)
Modified: trunk/Source/WebCore/bindings/v8/DOMData.h (90930 => 90931)
--- trunk/Source/WebCore/bindings/v8/DOMData.h 2011-07-13 17:36:43 UTC (rev 90930)
+++ trunk/Source/WebCore/bindings/v8/DOMData.h 2011-07-13 17:49:11 UTC (rev 90931)
@@ -45,23 +45,17 @@
// use different subclasses.
//
class DOMData {
-WTF_MAKE_NONCOPYABLE(DOMData);
public:
-DOMData();
-virtual ~DOMData();
-
-static DOMData* getCurrent();
-
[webkit-changes] [90785] trunk/Tools/Scripts/webkitpy/common/config/committers.py
Title: [90785] trunk/Tools/Scripts/webkitpy/common/config/committers.py Revision 90785 Author dslo...@google.com Date 2011-07-11 15:24:34 -0700 (Mon, 11 Jul 2011) Log Message Unreviewed, adding myself as a committer Modified Paths trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (90784 => 90785) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-07-11 22:00:11 UTC (rev 90784) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-07-11 22:24:34 UTC (rev 90785) @@ -139,6 +139,7 @@ Committer(David Smith, [catfish@gmail.com, dsm...@webkit.org], catfishman), Committer(Dean Jackson, d...@apple.com, dino), Committer(Diego Gonzalez, [diego...@webkit.org, diego.gonza...@openbossa.org], diegohcg), +Committer(Dmitry Lomov, [dslo...@google.com, dslo...@chromium.org], dslomov), Committer(Dominic Cooney, domin...@chromium.org, dominicc), Committer(Drew Wilson, atwil...@chromium.org, atwilson), Committer(Eli Fidler, e...@staikos.net, QBin), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
