[webkit-changes] [147033] trunk/Source/WebCore
Title: [147033] trunk/Source/WebCore
Revision 147033
Author fmal...@chromium.org
Date 2013-03-27 17:18:09 -0700 (Wed, 27 Mar 2013)
Log Message
Remove unused RenderLayer::renderBox{X,Y} methods
https://bugs.webkit.org/show_bug.cgi?id=113408
Reviewed by Simon Fraser.
Minor cleanup - renderBoxX() and renderBox() are no longer used.
No new tests: no functional changes.
* rendering/RenderLayer.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (147032 => 147033)
--- trunk/Source/WebCore/ChangeLog 2013-03-28 00:18:06 UTC (rev 147032)
+++ trunk/Source/WebCore/ChangeLog 2013-03-28 00:18:09 UTC (rev 147033)
@@ -1,3 +1,16 @@
+2013-03-27 Florin Malita fmal...@chromium.org
+
+Remove unused RenderLayer::renderBox{X,Y} methods
+https://bugs.webkit.org/show_bug.cgi?id=113408
+
+Reviewed by Simon Fraser.
+
+Minor cleanup - renderBoxX() and renderBox() are no longer used.
+
+No new tests: no functional changes.
+
+* rendering/RenderLayer.h:
+
2013-03-27 PhistucK phist...@chromium.org
Web Inspector: Plumb and expose cookie clearing options throughout the Resources Cookies tree and views
Modified: trunk/Source/WebCore/rendering/RenderLayer.h (147032 => 147033)
--- trunk/Source/WebCore/rendering/RenderLayer.h 2013-03-28 00:18:06 UTC (rev 147032)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2013-03-28 00:18:09 UTC (rev 147033)
@@ -920,8 +920,6 @@
void setLastChild(RenderLayer* last) { m_last = last; }
LayoutPoint renderBoxLocation() const { return renderer()-isBox() ? toRenderBox(renderer())-location() : LayoutPoint(); }
-LayoutUnit renderBoxX() const { return renderBoxLocation().x(); }
-LayoutUnit renderBoxY() const { return renderBoxLocation().y(); }
void collectLayers(bool includeHiddenLayers, CollectLayersBehavior, OwnPtrVectorRenderLayer* , OwnPtrVectorRenderLayer* );
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146495] trunk
Title: [146495] trunk Revision 146495 Author fmal...@chromium.org Date 2013-03-21 12:14:00 -0700 (Thu, 21 Mar 2013) Log Message [SVG] Suppress painting when an empty viewBox is specified https://bugs.webkit.org/show_bug.cgi?id=112623 Reviewed by Philip Rogers. Source/WebCore: Per spec, elements with an empty viewBox should not be rendered: http://www.w3.org/TR/SVG/coords.html#ViewBoxAttribute. This patch adds the missing viewBox checks to RenderSVGRoot, RenderSVGViewPortContainer, RenderSVGResourceMarker and RenderSVGResourceMarker's paint methods. In order to detect the case of viewBox present but invalid, the patch also introduces SVGAnimatedProperty plumbing for tracking property validity: the baseVal setter now takes an additional optional 'validValue' boolean parameter, which can later be queried via a macroed getter (LowerProperty##IsValid()). Test: svg/custom/viewBox-empty.html * rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::draw): * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildPattern): * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paintReplaced): * rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::paint): (WebCore): * rendering/svg/RenderSVGViewportContainer.h: (RenderSVGViewportContainer): * svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes): * svg/SVGSVGElement.h: (WebCore::SVGSVGElement::hasEmptyViewBox): (SVGSVGElement): Suppress painting if a valid empty viewBox is found. * svg/SVGFitToViewBox.h: (WebCore::SVGFitToViewBox::parseAttribute): Mark the viewBox property as invalid if not successfully parsed. * svg/SVGExternalResourcesRequired.h: (SVGExternalResourcesRequired): * svg/SVGURIReference.h: (SVGURIReference): * svg/properties/SVGAnimatedPropertyMacros.h: (WebCore::SVGSynchronizableAnimatedProperty::SVGSynchronizableAnimatedProperty): (SVGSynchronizableAnimatedProperty): (WebCore): Plumbing for tracking property value validation. LayoutTests: * svg/custom/script-tests/svg-viewBox-dynamic.js: * svg/custom/svg-viewBox-dynamic-expected.txt: * svg/custom/viewBox-empty-expected.html: Added. * svg/custom/viewBox-empty.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/svg/custom/script-tests/svg-viewBox-dynamic.js trunk/LayoutTests/svg/custom/svg-viewBox-dynamic-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.h trunk/Source/WebCore/svg/SVGExternalResourcesRequired.h trunk/Source/WebCore/svg/SVGFitToViewBox.h trunk/Source/WebCore/svg/SVGPatternElement.cpp trunk/Source/WebCore/svg/SVGSVGElement.h trunk/Source/WebCore/svg/SVGURIReference.h trunk/Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h Added Paths trunk/LayoutTests/svg/custom/viewBox-empty-expected.html trunk/LayoutTests/svg/custom/viewBox-empty.html Diff Modified: trunk/LayoutTests/ChangeLog (146494 => 146495) --- trunk/LayoutTests/ChangeLog 2013-03-21 19:06:05 UTC (rev 146494) +++ trunk/LayoutTests/ChangeLog 2013-03-21 19:14:00 UTC (rev 146495) @@ -1,3 +1,15 @@ +2013-03-21 Florin Malita fmal...@chromium.org + +[SVG] Suppress painting when an empty viewBox is specified +https://bugs.webkit.org/show_bug.cgi?id=112623 + +Reviewed by Philip Rogers. + +* svg/custom/script-tests/svg-viewBox-dynamic.js: +* svg/custom/svg-viewBox-dynamic-expected.txt: +* svg/custom/viewBox-empty-expected.html: Added. +* svg/custom/viewBox-empty.html: Added. + 2013-03-21 Stephen White senorbla...@chromium.org [Chromium] Unreviewed gardening. Modified: trunk/LayoutTests/svg/custom/script-tests/svg-viewBox-dynamic.js (146494 => 146495) --- trunk/LayoutTests/svg/custom/script-tests/svg-viewBox-dynamic.js 2013-03-21 19:06:05 UTC (rev 146494) +++ trunk/LayoutTests/svg/custom/script-tests/svg-viewBox-dynamic.js 2013-03-21 19:14:00 UTC (rev 146495) @@ -2,6 +2,7 @@ var svgDoc = document.implementation.createDocument(http://www.w3.org/2000/svg, svg, null); var svg = svgDoc.rootElement; + svg.setAttribute(viewBox, 20 10 200 100); shouldBe(svg.viewBox.baseVal.x, 20); shouldBe(svg.viewBox.baseVal.y, 10); @@ -13,4 +14,16 @@ shouldBe(svg.viewBox.baseVal.width, 0); shouldBe(svg.viewBox.baseVal.height, 0); +svg.setAttribute(viewBox, 20 10 200 100); +shouldBe(svg.viewBox.baseVal.x, 20); +shouldBe(svg.viewBox.baseVal.y, 10); +shouldBe(svg.viewBox.baseVal.width, 200); +shouldBe(svg.viewBox.baseVal.height, 100); +svg.setAttribute(viewBox, invalid value); +shouldBe(svg.viewBox.baseVal.x, 0); +shouldBe(svg.viewBox.baseVal.y, 0); +shouldBe(svg.viewBox.baseVal.width, 0);
[webkit-changes] [146503] trunk/Source/WebCore
Title: [146503] trunk/Source/WebCore Revision 146503 Author fmal...@chromium.org Date 2013-03-21 13:02:40 -0700 (Thu, 21 Mar 2013) Log Message [SVG] Remove explicit LightSource dispatchers https://bugs.webkit.org/show_bug.cgi?id=112827 Reviewed by Stephen Chenney. Convert LightSource setters to dynamic dispatch. This allows us to remove LightSource.cpp altogether. No new tests: refactoring only. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/filters/DistantLightSource.h: (DistantLightSource): * platform/graphics/filters/LightSource.cpp: Removed. * platform/graphics/filters/LightSource.h: (WebCore::LightSource::setAzimuth): (WebCore::LightSource::setElevation): (WebCore::LightSource::setX): (WebCore::LightSource::setY): (WebCore::LightSource::setZ): (WebCore::LightSource::setPointsAtX): (WebCore::LightSource::setPointsAtY): (WebCore::LightSource::setPointsAtZ): (WebCore::LightSource::setSpecularExponent): (WebCore::LightSource::setLimitingConeAngle): * platform/graphics/filters/PointLightSource.h: (PointLightSource): * platform/graphics/filters/SpotLightSource.h: (SpotLightSource): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/filters/DistantLightSource.h trunk/Source/WebCore/platform/graphics/filters/LightSource.h trunk/Source/WebCore/platform/graphics/filters/PointLightSource.h trunk/Source/WebCore/platform/graphics/filters/SpotLightSource.h Removed Paths trunk/Source/WebCore/platform/graphics/filters/LightSource.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (146502 => 146503) --- trunk/Source/WebCore/CMakeLists.txt 2013-03-21 19:55:26 UTC (rev 146502) +++ trunk/Source/WebCore/CMakeLists.txt 2013-03-21 20:02:40 UTC (rev 146503) @@ -1995,7 +1995,6 @@ platform/graphics/filters/FilterEffect.cpp platform/graphics/filters/FilterOperation.cpp platform/graphics/filters/FilterOperations.cpp -platform/graphics/filters/LightSource.cpp platform/graphics/filters/PointLightSource.cpp platform/graphics/filters/SourceAlpha.cpp platform/graphics/filters/SourceGraphic.cpp Modified: trunk/Source/WebCore/ChangeLog (146502 => 146503) --- trunk/Source/WebCore/ChangeLog 2013-03-21 19:55:26 UTC (rev 146502) +++ trunk/Source/WebCore/ChangeLog 2013-03-21 20:02:40 UTC (rev 146503) @@ -1,3 +1,42 @@ +2013-03-21 Florin Malita fmal...@chromium.org + +[SVG] Remove explicit LightSource dispatchers +https://bugs.webkit.org/show_bug.cgi?id=112827 + +Reviewed by Stephen Chenney. + +Convert LightSource setters to dynamic dispatch. This allows us to remove LightSource.cpp +altogether. + +No new tests: refactoring only. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.vcxproj/WebCore.vcxproj: +* WebCore.vcxproj/WebCore.vcxproj.filters: +* WebCore.xcodeproj/project.pbxproj: +* platform/graphics/filters/DistantLightSource.h: +(DistantLightSource): +* platform/graphics/filters/LightSource.cpp: Removed. +* platform/graphics/filters/LightSource.h: +(WebCore::LightSource::setAzimuth): +(WebCore::LightSource::setElevation): +(WebCore::LightSource::setX): +(WebCore::LightSource::setY): +(WebCore::LightSource::setZ): +(WebCore::LightSource::setPointsAtX): +(WebCore::LightSource::setPointsAtY): +(WebCore::LightSource::setPointsAtZ): +(WebCore::LightSource::setSpecularExponent): +(WebCore::LightSource::setLimitingConeAngle): +* platform/graphics/filters/PointLightSource.h: +(PointLightSource): +* platform/graphics/filters/SpotLightSource.h: +(SpotLightSource): + 2013-03-21 Igor Oliveira igo...@sisa.samsung.com [Texmap] Implement support for OpenGLES EXT_unpack_subimage extension Modified: trunk/Source/WebCore/GNUmakefile.list.am (146502 => 146503) --- trunk/Source/WebCore/GNUmakefile.list.am 2013-03-21 19:55:26 UTC (rev 146502) +++ trunk/Source/WebCore/GNUmakefile.list.am 2013-03-21 20:02:40 UTC (rev 146503) @@ -5600,7 +5600,6 @@ Source/WebCore/platform/graphics/filters/FilterOperation.cpp \ Source/WebCore/platform/graphics/filters/FilterOperations.cpp \ Source/WebCore/platform/graphics/filters/FilterOperations.h \ -
[webkit-changes] [145830] trunk/Source/WebCore
Title: [145830] trunk/Source/WebCore Revision 145830 Author fmal...@chromium.org Date 2013-03-14 11:32:21 -0700 (Thu, 14 Mar 2013) Log Message Tighten up the type bounds for SVGPropertyInfo callback parameters https://bugs.webkit.org/show_bug.cgi?id=111786 Reviewed by Philip Rogers. Update SVGPropertyInfo's callbacks to pass SVGElement* parameters instead of void*. This allows us to perform some ASSERT-based type checking before downcasting in implementors. To avoid adding virtual methods unused in release builds to the base class (and overrides in descendants), for subtypes lacking polymorphic type markers (isXXX()) the check is performed using hasTagName() instead. The patch is also removing the lookupOrCreateWrapperForAnimatedProperty() SVGPropertyInfo callback for SVGViewSpec properties, because a) it doesn't appear to be reachable (SVGViewSpec doesn't have a backing element and thus cannot have an associated animator) b) it interferes with the parameter specialization described above (SVGViewSpec does not inherit from SVGElement) No new tests, refactoring only. * svg/SVGElement.cpp: (WebCore::SVGElement::synchronizeRequiredFeatures): (WebCore::SVGElement::synchronizeRequiredExtensions): (WebCore::SVGElement::synchronizeSystemLanguage): * svg/SVGElement.h: (SVGElement): * svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::synchronizeOrientType): (WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper): * svg/SVGMarkerElement.h: (SVGMarkerElement): (WebCore::toSVGMarkerElement): (WebCore): * svg/SVGPathElement.cpp: (WebCore::SVGPathElement::lookupOrCreateDWrapper): (WebCore::SVGPathElement::synchronizeD): * svg/SVGPathElement.h: (SVGPathElement): (WebCore::toSVGPathElement): (WebCore): * svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::synchronizePoints): (WebCore::SVGPolyElement::lookupOrCreatePointsWrapper): * svg/SVGPolyElement.h: (SVGPolyElement): (WebCore::toSVGPolyElement): (WebCore): * svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::synchronizeTextLength): (WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper): * svg/SVGTextContentElement.h: (SVGTextContentElement): (WebCore::toSVGTextContentElement): (WebCore): Change SVGPropertyInfo callback params to SVGElement* and replace static casts with conversion wrappers. Implement conversion wrappers where needed. * svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::viewBoxPropertyInfo): (WebCore::SVGViewSpec::preserveAspectRatioPropertyInfo): (WebCore::SVGViewSpec::transformPropertyInfo): (WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper): (WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper): (WebCore::SVGViewSpec::lookupOrCreateTransformWrapper): * svg/SVGViewSpec.h: (SVGViewSpec): Remove SVGPropertyInfo-based lookupOrCreate* callbacks and updated the methods' parameters to SVGViewSpec*. Remove now-unneeded casts. * svg/properties/SVGAnimatedPropertyMacros.h: (WebCore): * svg/properties/SVGPropertyInfo.h: (WebCore): (SVGPropertyInfo): Update callback declarations. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/SVGElement.cpp trunk/Source/WebCore/svg/SVGElement.h trunk/Source/WebCore/svg/SVGMarkerElement.cpp trunk/Source/WebCore/svg/SVGMarkerElement.h trunk/Source/WebCore/svg/SVGPathElement.cpp trunk/Source/WebCore/svg/SVGPathElement.h trunk/Source/WebCore/svg/SVGPolyElement.cpp trunk/Source/WebCore/svg/SVGPolyElement.h trunk/Source/WebCore/svg/SVGTextContentElement.cpp trunk/Source/WebCore/svg/SVGTextContentElement.h trunk/Source/WebCore/svg/SVGViewSpec.cpp trunk/Source/WebCore/svg/SVGViewSpec.h trunk/Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h trunk/Source/WebCore/svg/properties/SVGPropertyInfo.h Diff Modified: trunk/Source/WebCore/ChangeLog (145829 => 145830) --- trunk/Source/WebCore/ChangeLog 2013-03-14 18:20:44 UTC (rev 145829) +++ trunk/Source/WebCore/ChangeLog 2013-03-14 18:32:21 UTC (rev 145830) @@ -1,3 +1,84 @@ +2013-03-12 Florin Malita fmal...@chromium.org + +Tighten up the type bounds for SVGPropertyInfo callback parameters +https://bugs.webkit.org/show_bug.cgi?id=111786 + +Reviewed by Philip Rogers. + +Update SVGPropertyInfo's callbacks to pass SVGElement* parameters instead of void*. This +allows us to perform some ASSERT-based type checking before downcasting in implementors. + +To avoid adding virtual methods unused in release builds to the base class (and overrides +in descendants), for subtypes lacking polymorphic type markers (isXXX()) the check is +performed using hasTagName() instead. + +The patch is also removing the lookupOrCreateWrapperForAnimatedProperty() SVGPropertyInfo +callback for SVGViewSpec properties, because + + a) it doesn't appear to be reachable (SVGViewSpec doesn't have a backing element and + thus cannot have an associated animator) + + b) it interferes with the parameter specialization
[webkit-changes] [145541] trunk
Title: [145541] trunk Revision 145541 Author fmal...@chromium.org Date 2013-03-12 07:38:48 -0700 (Tue, 12 Mar 2013) Log Message SVG Pattern pixelated on inline SVG with CSS transforms https://bugs.webkit.org/show_bug.cgi?id=111587 Reviewed by Dirk Schulze. Source/WebCore: When calculating the resolution for resource image buffers, we need to also consider CSS transforms. This patch updates calculateTransformationToOutermostSVGCoordinateSystem() (renamed to calculateTransformationToOutermostCoordinateSystem) to include the affine component from CSS transforms by walking the parent layer tree. Test: svg/custom/resources-css-scaled.html * rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyClippingToContext): * rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource): * rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): * rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource): * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildPattern): * rendering/svg/SVGRenderingContext.cpp: (WebCore::SVGRenderingContext::calculateScreenFontSizeScalingFactor): (WebCore::SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem): * rendering/svg/SVGRenderingContext.h: (SVGRenderingContext): LayoutTests: * svg/custom/resources-css-scaled-expected.html: Added. * svg/custom/resources-css-scaled.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp trunk/Source/WebCore/rendering/svg/SVGRenderingContext.h Added Paths trunk/LayoutTests/svg/custom/resources-css-scaled-expected.html trunk/LayoutTests/svg/custom/resources-css-scaled.html Diff Modified: trunk/LayoutTests/ChangeLog (145540 => 145541) --- trunk/LayoutTests/ChangeLog 2013-03-12 14:35:33 UTC (rev 145540) +++ trunk/LayoutTests/ChangeLog 2013-03-12 14:38:48 UTC (rev 145541) @@ -1,3 +1,13 @@ +2013-03-12 Florin Malita fmal...@chromium.org + +SVG Pattern pixelated on inline SVG with CSS transforms +https://bugs.webkit.org/show_bug.cgi?id=111587 + +Reviewed by Dirk Schulze. + +* svg/custom/resources-css-scaled-expected.html: Added. +* svg/custom/resources-css-scaled.html: Added. + 2013-03-12 Vsevolod Vlasov vse...@chromium.org Web Inspector: ResourceScriptFile diverged state should be correctly reset after debugger reset. Added: trunk/LayoutTests/svg/custom/resources-css-scaled-expected.html (0 => 145541) --- trunk/LayoutTests/svg/custom/resources-css-scaled-expected.html (rev 0) +++ trunk/LayoutTests/svg/custom/resources-css-scaled-expected.html 2013-03-12 14:38:48 UTC (rev 145541) @@ -0,0 +1,48 @@ +!DOCTYPE html +html +body + +div style=position: relative; left: 27px; width: 100px; +div style=width: 50px; + svg width=600 height=400 xmlns=http://www.w3.org/2000/svg +defs + pattern id=pattern width=100 height=100 patternUnits=userSpaceOnUse +circle cx=50 cy=50 r=50 fill=green/ + /pattern + + mask id=mask +circle cx=50 cy=50 r=50 fill=white/ + /mask + + clipPath id=clip +circle cx=50 cy=50 r=50/ +circle cx=50 cy=50 r=50/ + /clipPath + + filter id=filter +feOffset dx=0 dy=0/ + /filter +/defs + +circle cx=50 cy=50 r=50 fill=green/ + +g transform=translate(300) + rect width=100 height=100 fill=url(#pattern)/rect +/g + +g transform=translate(150 150) + rect width=100 height=100 fill=green mask=url(#mask)/ +/g + +g transform=translate(0 300) + rect width=100 height=100 fill=green clip-path=url(#clip)/ +/g + +g transform=translate(300 300) + circle cx=50 cy=50 r=50 fill=green filter=url(#filter)/ +/g + /svg +/div +/div +/body +/html Added: trunk/LayoutTests/svg/custom/resources-css-scaled.html (0 => 145541) --- trunk/LayoutTests/svg/custom/resources-css-scaled.html (rev 0) +++ trunk/LayoutTests/svg/custom/resources-css-scaled.html 2013-03-12 14:38:48 UTC (rev 145541) @@ -0,0 +1,52 @@ +!DOCTYPE html +html +body + +!-- Test for https://bugs.webkit.org/show_bug.cgi?id=111587 -- +!-- Passes if all circles are drawn at high resolution, without pixelation -- + +div style=position: relative; left: 27px; -webkit-transform: scale(5); -webkit-transform-origin: 0 0; width: 100px; +div style=-webkit-transform: scale(2); -webkit-transform-origin: 0 0; width: 50px; + svg width=40 height=40
[webkit-changes] [144948] trunk
Title: [144948] trunk Revision 144948 Author fmal...@chromium.org Date 2013-03-06 10:51:10 -0800 (Wed, 06 Mar 2013) Log Message SVG pattern to pattern reference does not work if first pattern has a child node https://bugs.webkit.org/show_bug.cgi?id=111586 Reviewed by Philip Rogers. Source/WebCore: SVGPatternElement::collectPatternAttributes should test for child elements, not child nodes. Tests: svg/custom/pattern-reference-expected.svg svg/custom/pattern-reference.svg * svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes): LayoutTests: * svg/custom/pattern-reference-expected.svg: Added. * svg/custom/pattern-reference.svg: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/SVGPatternElement.cpp Added Paths trunk/LayoutTests/svg/custom/pattern-reference-expected.svg trunk/LayoutTests/svg/custom/pattern-reference.svg Diff Modified: trunk/LayoutTests/ChangeLog (144947 => 144948) --- trunk/LayoutTests/ChangeLog 2013-03-06 18:50:27 UTC (rev 144947) +++ trunk/LayoutTests/ChangeLog 2013-03-06 18:51:10 UTC (rev 144948) @@ -1,3 +1,13 @@ +2013-03-06 Florin Malita fmal...@chromium.org + +SVG pattern to pattern reference does not work if first pattern has a child node +https://bugs.webkit.org/show_bug.cgi?id=111586 + +Reviewed by Philip Rogers. + +* svg/custom/pattern-reference-expected.svg: Added. +* svg/custom/pattern-reference.svg: Added. + 2013-03-06 Ryosuke Niwa rn...@webkit.org Add a flaky failure expectation to fast/css/hover-update.html on Mac per bug 111592. Added: trunk/LayoutTests/svg/custom/pattern-reference-expected.svg (0 => 144948) --- trunk/LayoutTests/svg/custom/pattern-reference-expected.svg (rev 0) +++ trunk/LayoutTests/svg/custom/pattern-reference-expected.svg 2013-03-06 18:51:10 UTC (rev 144948) @@ -0,0 +1,5 @@ +?xml version=1.0 standalone=no? +svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink + rect width=100 height=100 fill=green/ + rect x=200 width=100 height=100 fill=green/ +/svg Added: trunk/LayoutTests/svg/custom/pattern-reference.svg (0 => 144948) --- trunk/LayoutTests/svg/custom/pattern-reference.svg (rev 0) +++ trunk/LayoutTests/svg/custom/pattern-reference.svg 2013-03-06 18:51:10 UTC (rev 144948) @@ -0,0 +1,23 @@ +?xml version=1.0 standalone=no? +svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink + !-- Test for https://bugs.webkit.org/show_bug.cgi?id=111586 -- + defs +pattern id=ref_pattern1 patternUnits=userSpaceOnUse width=100 height=100 viewBox=0 0 100 100 + rect width=100 height=100 fill=green/ +/pattern +pattern id=ref_pattern2 patternUnits=userSpaceOnUse width=100 height=100 viewBox=0 0 100 100 + rect width=100 height=100 fill=red/ +/pattern + +pattern id=pattern1 xlink:href="" + random text node - should be ignored +/pattern +pattern id=pattern2 xlink:href="" + rect width=100 height=100 fill=green/ +/pattern + /defs + + !-- You should see two green rects -- + rect width=100 height=100 fill=url(#pattern1)/ + rect x=200 width=100 height=100 fill=url(#pattern2)/ +/svg Modified: trunk/Source/WebCore/ChangeLog (144947 => 144948) --- trunk/Source/WebCore/ChangeLog 2013-03-06 18:50:27 UTC (rev 144947) +++ trunk/Source/WebCore/ChangeLog 2013-03-06 18:51:10 UTC (rev 144948) @@ -1,3 +1,18 @@ +2013-03-06 Florin Malita fmal...@chromium.org + +SVG pattern to pattern reference does not work if first pattern has a child node +https://bugs.webkit.org/show_bug.cgi?id=111586 + +Reviewed by Philip Rogers. + +SVGPatternElement::collectPatternAttributes should test for child elements, not child nodes. + +Tests: svg/custom/pattern-reference-expected.svg + svg/custom/pattern-reference.svg + +* svg/SVGPatternElement.cpp: +(WebCore::SVGPatternElement::collectPatternAttributes): + 2013-03-06 Christophe Dumez ch.du...@sisa.samsung.com [soup] session cookies are not correctly reported in getRawCookies() Modified: trunk/Source/WebCore/svg/SVGPatternElement.cpp (144947 => 144948) --- trunk/Source/WebCore/svg/SVGPatternElement.cpp 2013-03-06 18:50:27 UTC (rev 144947) +++ trunk/Source/WebCore/svg/SVGPatternElement.cpp 2013-03-06 18:51:10 UTC (rev 144948) @@ -222,7 +222,7 @@ attributes.setPatternTransform(transform); } -if (!attributes.hasPatternContentElement() current-hasChildNodes()) +if (!attributes.hasPatternContentElement() current-childElementCount()) attributes.setPatternContentElement(current); processedPatterns.add(current); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144195] trunk
Title: [144195] trunk Revision 144195 Author fmal...@chromium.org Date 2013-02-27 08:45:06 -0800 (Wed, 27 Feb 2013) Log Message [Chromium] Layout Test svg/custom/transform-with-shadow-and-gradient.svg is failing https://bugs.webkit.org/show_bug.cgi?id=76557 Reviewed by Stephen Chenney. Source/WebCore: Always use kDst_Mode transfer for the shadow looper. Using kSrc_Mode to enforce CSS box-shadow opaqueness at this level is not necessary since the RenderBoxModel box decoration code already makes sure that shadows are filled with opaque black. This change aligns the SVG shadow behavior (and pixel results) with CG/Safari. No new tests, coverage provided by existing tests. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): LayoutTests: * platform/chromium-linux/svg/css/text-shadow-multiple-expected.png: * platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/svg/css/text-shadow-multiple-expected.png trunk/LayoutTests/platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Diff Modified: trunk/LayoutTests/ChangeLog (144194 => 144195) --- trunk/LayoutTests/ChangeLog 2013-02-27 16:42:06 UTC (rev 144194) +++ trunk/LayoutTests/ChangeLog 2013-02-27 16:45:06 UTC (rev 144195) @@ -1,3 +1,14 @@ +2013-02-27 Florin Malita fmal...@chromium.org + +[Chromium] Layout Test svg/custom/transform-with-shadow-and-gradient.svg is failing +https://bugs.webkit.org/show_bug.cgi?id=76557 + +Reviewed by Stephen Chenney. + +* platform/chromium-linux/svg/css/text-shadow-multiple-expected.png: +* platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png: +* platform/chromium/TestExpectations: + 2013-02-27 No'am Rosenthal n...@webkit.org [Texmap] TextureMapper is too eager to use intermediate surfaces Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144194 => 144195) --- trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-27 16:42:06 UTC (rev 144194) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-27 16:45:06 UTC (rev 144195) @@ -3696,6 +3696,10 @@ webkit.org/b/108429 svg/custom/text-ctm.svg [ Pass Failure ] webkit.org/b/108429 svg/repaint/svgsvgelement-repaint-children.html [ Pass Failure ] +# Need rebaseline after https://bugs.webkit.org/show_bug.cgi?id=76557 +webkit.org/b/76557 svg/css/text-shadow-multiple.xhtml [ Pass ImageOnlyFailure ] +webkit.org/b/76557 svg/custom/transform-with-shadow-and-gradient.svg [ Pass ImageOnlyFailure ] + # Chromium still has the CC toggle button, not the menu of tracks. webkit.org/b/101670 media/video-controls-captions-trackmenu.html [ Skip ] webkit.org/b/101670 media/video-controls-captions-trackmenu-sorted.html [ Skip ] Modified: trunk/LayoutTests/platform/chromium-linux/svg/css/text-shadow-multiple-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png (Binary files differ) Modified: trunk/Source/WebCore/ChangeLog (144194 => 144195) --- trunk/Source/WebCore/ChangeLog 2013-02-27 16:42:06 UTC (rev 144194) +++ trunk/Source/WebCore/ChangeLog 2013-02-27 16:45:06 UTC (rev 144195) @@ -1,3 +1,21 @@ +2013-02-27 Florin Malita fmal...@chromium.org + +[Chromium] Layout Test svg/custom/transform-with-shadow-and-gradient.svg is failing +https://bugs.webkit.org/show_bug.cgi?id=76557 + +Reviewed by Stephen Chenney. + +Always use kDst_Mode transfer for the shadow looper. Using kSrc_Mode to enforce CSS +box-shadow opaqueness at this level is not necessary since the RenderBoxModel box +decoration code already makes sure that shadows are filled with opaque black. + +This change aligns the SVG shadow behavior (and pixel results) with CG/Safari. + +No new tests, coverage provided by existing tests. + +* platform/graphics/skia/GraphicsContextSkia.cpp: +(WebCore::GraphicsContext::setPlatformShadow): + 2013-02-25 Kentaro Hara hara...@chromium.org [V8] Generate a wrapper function for ReplaceableAttrSetter() Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (144194 => 144195) --- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2013-02-27 16:42:06 UTC (rev 144194) +++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2013-02-27 16:45:06 UTC (rev 144195) @@ -1011,7 +1011,6 @@ double blur = blurFloat; uint32_t mfFlags = SkBlurMaskFilter::kHighQuality_BlurFlag; -SkXfermode::Mode colorMode = SkXfermode::kSrc_Mode; if
[webkit-changes] [143454] trunk
Title: [143454] trunk
Revision 143454
Author fmal...@chromium.org
Date 2013-02-20 05:38:02 -0800 (Wed, 20 Feb 2013)
Log Message
Clear SVGPathSeg role on removal.
https://bugs.webkit.org/show_bug.cgi?id=110058
Reviewed by Dirk Schulze.
Source/WebCore:
SVGPathSegListPropertyTearOff::initialize() and SVGPathSegListPropertyTearOff::replaceItem()
need to clear the context and role for segments being expunged from the list, similarly to
removeItem(). Otherwise, processIncomingListItemValue() can get confused and attempt to
remove stale segments.
Test: svg/dom/SVGPathSegList-crash.html
* svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
(WebCore::SVGPathSegListPropertyTearOff::clear):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore):
* svg/properties/SVGPathSegListPropertyTearOff.h:
(WebCore::SVGPathSegListPropertyTearOff::initialize):
(SVGPathSegListPropertyTearOff):
LayoutTests:
* svg/dom/SVGPathSegList-crash-expected.txt: Added.
* svg/dom/SVGPathSegList-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.cpp
trunk/Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.h
Added Paths
trunk/LayoutTests/svg/dom/SVGPathSegList-crash-expected.txt
trunk/LayoutTests/svg/dom/SVGPathSegList-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (143453 => 143454)
--- trunk/LayoutTests/ChangeLog 2013-02-20 12:45:58 UTC (rev 143453)
+++ trunk/LayoutTests/ChangeLog 2013-02-20 13:38:02 UTC (rev 143454)
@@ -1,3 +1,13 @@
+2013-02-20 Florin Malita fmal...@chromium.org
+
+Clear SVGPathSeg role on removal.
+https://bugs.webkit.org/show_bug.cgi?id=110058
+
+Reviewed by Dirk Schulze.
+
+* svg/dom/SVGPathSegList-crash-expected.txt: Added.
+* svg/dom/SVGPathSegList-crash.html: Added.
+
2013-02-20 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r143434.
Added: trunk/LayoutTests/svg/dom/SVGPathSegList-crash-expected.txt (0 => 143454)
--- trunk/LayoutTests/svg/dom/SVGPathSegList-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/dom/SVGPathSegList-crash-expected.txt 2013-02-20 13:38:02 UTC (rev 143454)
@@ -0,0 +1 @@
+PASS: Did not crash.
Added: trunk/LayoutTests/svg/dom/SVGPathSegList-crash.html (0 => 143454)
--- trunk/LayoutTests/svg/dom/SVGPathSegList-crash.html (rev 0)
+++ trunk/LayoutTests/svg/dom/SVGPathSegList-crash.html 2013-02-20 13:38:02 UTC (rev 143454)
@@ -0,0 +1,20 @@
+!DOCTYPE html
+html
+ body
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var path = document.createElementNS(http://www.w3.org/2000/svg, path);
+var seg1 = path.createSVGPathSegLinetoAbs(10, 10);
+var seg2 = path.createSVGPathSegLinetoAbs(100, 100);
+
+path.pathSegList.initialize(seg1);
+path.pathSegList.initialize(seg2);
+path.pathSegList.initialize(seg1);
+path.pathSegList.replaceItem(seg2, 0);
+path.pathSegList.initialize(seg1);
+/script
+ /body
+ divPASS: Did not crash./div
+/html
Modified: trunk/Source/WebCore/ChangeLog (143453 => 143454)
--- trunk/Source/WebCore/ChangeLog 2013-02-20 12:45:58 UTC (rev 143453)
+++ trunk/Source/WebCore/ChangeLog 2013-02-20 13:38:02 UTC (rev 143454)
@@ -1,3 +1,26 @@
+2013-02-20 Florin Malita fmal...@chromium.org
+
+Clear SVGPathSeg role on removal.
+https://bugs.webkit.org/show_bug.cgi?id=110058
+
+Reviewed by Dirk Schulze.
+
+SVGPathSegListPropertyTearOff::initialize() and SVGPathSegListPropertyTearOff::replaceItem()
+need to clear the context and role for segments being expunged from the list, similarly to
+removeItem(). Otherwise, processIncomingListItemValue() can get confused and attempt to
+remove stale segments.
+
+Test: svg/dom/SVGPathSegList-crash.html
+
+* svg/properties/SVGPathSegListPropertyTearOff.cpp:
+(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
+(WebCore::SVGPathSegListPropertyTearOff::clear):
+(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
+(WebCore):
+* svg/properties/SVGPathSegListPropertyTearOff.h:
+(WebCore::SVGPathSegListPropertyTearOff::initialize):
+(SVGPathSegListPropertyTearOff):
+
2013-02-20 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r143434.
Modified: trunk/Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.cpp (143453 => 143454)
--- trunk/Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.cpp 2013-02-20 12:45:58 UTC (rev 143453)
+++ trunk/Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.cpp 2013-02-20 13:38:02 UTC (rev 143454)
@@ -29,18 +29,23 @@
namespace WebCore {
-void
[webkit-changes] [143485] branches/chromium/1410/Source/Platform
Title: [143485] branches/chromium/1410/Source/Platform
Revision 143485
Author fmal...@chromium.org
Date 2013-02-20 12:14:30 -0800 (Wed, 20 Feb 2013)
Log Message
Merge 142496
[Chromium] FilterTypeSaturatingBrightness enum
https://bugs.webkit.org/show_bug.cgi?id=109380
Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
to support existing interntal clients which rely on the current saturating brightness
behavior (in preparation of switching to the new brightness implementation).
Reviewed by James Robinson.
* chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
(WebKit::WebFilterOperation::setAmount):
TBR=jam...@chromium.org
Review URL: https://codereview.chromium.org/12321021
Modified Paths
branches/chromium/1410/Source/Platform/ChangeLog
branches/chromium/1410/Source/Platform/chromium/public/WebFilterOperation.h
Diff
Modified: branches/chromium/1410/Source/Platform/ChangeLog (143484 => 143485)
--- branches/chromium/1410/Source/Platform/ChangeLog 2013-02-20 19:58:16 UTC (rev 143484)
+++ branches/chromium/1410/Source/Platform/ChangeLog 2013-02-20 20:14:30 UTC (rev 143485)
@@ -1,3 +1,19 @@
+2013-02-10 Florin Malita fmal...@chromium.org
+
+[Chromium] FilterTypeSaturatingBrightness enum
+https://bugs.webkit.org/show_bug.cgi?id=109380
+
+Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
+to support existing interntal clients which rely on the current saturating brightness
+behavior (in preparation of switching to the new brightness implementation).
+
+Reviewed by James Robinson.
+
+* chromium/public/WebFilterOperation.h:
+(WebKit::WebFilterOperation::amount):
+(WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
+(WebKit::WebFilterOperation::setAmount):
+
2013-02-09 James Robinson jam...@chromium.org
[chromium] Enable more of webkit_unit_tests in component builds
Modified: branches/chromium/1410/Source/Platform/chromium/public/WebFilterOperation.h (143484 => 143485)
--- branches/chromium/1410/Source/Platform/chromium/public/WebFilterOperation.h 2013-02-20 19:58:16 UTC (rev 143484)
+++ branches/chromium/1410/Source/Platform/chromium/public/WebFilterOperation.h 2013-02-20 20:14:30 UTC (rev 143485)
@@ -49,6 +49,7 @@
FilterTypeDropShadow,
FilterTypeColorMatrix,
FilterTypeZoom,
+FilterTypeSaturatingBrightness, // Not used in CSS/SVG.
};
FilterType type() const { return m_type; }
@@ -65,7 +66,8 @@
|| m_type == FilterTypeOpacity
|| m_type == FilterTypeBlur
|| m_type == FilterTypeDropShadow
- || m_type == FilterTypeZoom);
+ || m_type == FilterTypeZoom
+ || m_type == FilterTypeSaturatingBrightness);
return m_amount;
}
WebPoint dropShadowOffset() const
@@ -102,6 +104,7 @@
static WebFilterOperation createDropShadowFilter(WebPoint offset, float stdDeviation, WebColor color) { return WebFilterOperation(FilterTypeDropShadow, offset, stdDeviation, color); }
static WebFilterOperation createColorMatrixFilter(SkScalar matrix[20]) { return WebFilterOperation(FilterTypeColorMatrix, matrix); }
static WebFilterOperation createZoomFilter(WebRect rect, int inset) { return WebFilterOperation(FilterTypeZoom, rect, inset); }
+static WebFilterOperation createSaturatingBrightnessFilter(float amount) { return WebFilterOperation(FilterTypeSaturatingBrightness, amount); }
bool equals(const WebFilterOperation other) const;
@@ -120,7 +123,8 @@
|| m_type == FilterTypeOpacity
|| m_type == FilterTypeBlur
|| m_type == FilterTypeDropShadow
- || m_type == FilterTypeZoom);
+ || m_type == FilterTypeZoom
+ || m_type == FilterTypeSaturatingBrightness);
m_amount = amount;
}
void setDropShadowOffset(WebPoint offset)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143498] trunk/Source/WebCore
Title: [143498] trunk/Source/WebCore
Revision 143498
Author fmal...@chromium.org
Date 2013-02-20 13:43:29 -0800 (Wed, 20 Feb 2013)
Log Message
[SVG] Update of element referenced by multiple 'use' nodes is absurdly slow
https://bugs.webkit.org/show_bug.cgi?id=97905
Reviewed by Dirk Schulze.
Rebuilding the shadow and instance trees of dependent use nodes recursively can be
extremely inefficient with non-trivial dependency graphs (the trees are not constructed
in topological order).
To avoid redundant buildShadowAndInstanceTree() invokations, separate the invalidation
phase from the actual tree (re)building phase, and only descend into the dependency DAG
during the invalidation phase (recursion also stops at nodes that have been previously
invalidated).
No new tests: functional coverage provided by existing tests, perfomance tracked by
PerformanceTests/SVG/SvgNestedUse.html.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::invalidateShadowTree):
(WebCore):
(WebCore::SVGUseElement::invalidateDependentShadowTrees):
* svg/SVGUseElement.h:
(SVGUseElement):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGUseElement.cpp
trunk/Source/WebCore/svg/SVGUseElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (143497 => 143498)
--- trunk/Source/WebCore/ChangeLog 2013-02-20 21:34:19 UTC (rev 143497)
+++ trunk/Source/WebCore/ChangeLog 2013-02-20 21:43:29 UTC (rev 143498)
@@ -1,3 +1,31 @@
+2013-02-20 Florin Malita fmal...@chromium.org
+
+[SVG] Update of element referenced by multiple 'use' nodes is absurdly slow
+https://bugs.webkit.org/show_bug.cgi?id=97905
+
+Reviewed by Dirk Schulze.
+
+Rebuilding the shadow and instance trees of dependent use nodes recursively can be
+extremely inefficient with non-trivial dependency graphs (the trees are not constructed
+in topological order).
+
+To avoid redundant buildShadowAndInstanceTree() invokations, separate the invalidation
+phase from the actual tree (re)building phase, and only descend into the dependency DAG
+during the invalidation phase (recursion also stops at nodes that have been previously
+invalidated).
+
+No new tests: functional coverage provided by existing tests, perfomance tracked by
+PerformanceTests/SVG/SvgNestedUse.html.
+
+* svg/SVGUseElement.cpp:
+(WebCore::SVGUseElement::buildPendingResource):
+(WebCore::SVGUseElement::buildShadowAndInstanceTree):
+(WebCore::SVGUseElement::invalidateShadowTree):
+(WebCore):
+(WebCore::SVGUseElement::invalidateDependentShadowTrees):
+* svg/SVGUseElement.h:
+(SVGUseElement):
+
2013-02-20 Tim Horton timothy_hor...@apple.com
RenderLayerBacking should initialize TiledBacking's isInWindow state with Page's isInWindow, not isOnscreen
Modified: trunk/Source/WebCore/svg/SVGUseElement.cpp (143497 => 143498)
--- trunk/Source/WebCore/svg/SVGUseElement.cpp 2013-02-20 21:34:19 UTC (rev 143497)
+++ trunk/Source/WebCore/svg/SVGUseElement.cpp 2013-02-20 21:43:29 UTC (rev 143498)
@@ -409,10 +409,10 @@
void SVGUseElement::buildPendingResource()
{
-if (!referencedDocument())
+if (!referencedDocument() || isInShadowTree())
return;
clearResourceReferences();
-if (!inDocument() || isInShadowTree())
+if (!inDocument())
return;
String id;
@@ -430,8 +430,11 @@
return;
}
-if (target-isSVGElement())
+if (target-isSVGElement()) {
buildShadowAndInstanceTree(static_castSVGElement*(target));
+invalidateDependentShadowTrees();
+}
+
ASSERT(!m_needsShadowTreeRecreation);
}
@@ -517,10 +520,6 @@
// Update relative length information.
updateRelativeLengthsInformation();
-// Rebuild all dependent use elements.
-ASSERT(document());
-document()-accessSVGExtensions()-rebuildAllElementReferencesForTarget(this);
-
// Eventually dump instance tree
#ifdef DUMP_INSTANCE_TREE
String text;
@@ -906,8 +905,22 @@
return;
m_needsShadowTreeRecreation = true;
setNeedsStyleRecalc();
+invalidateDependentShadowTrees();
}
+void SVGUseElement::invalidateDependentShadowTrees()
+{
+// Recursively invalidate dependent use shadow trees
+const HashSetSVGElementInstance* instances = instancesForElement();
+const HashSetSVGElementInstance*::const_iterator end = instances.end();
+for (HashSetSVGElementInstance*::const_iterator it = instances.begin(); it != end; ++it) {
+if (SVGUseElement* element = (*it)-correspondingUseElement()) {
+ASSERT(element-inDocument());
+element-invalidateShadowTree();
+}
+}
+}
+
void SVGUseElement::transferUseAttributesToReplacedElement(SVGElement* from, SVGElement* to) const
{
ASSERT(from);
Modified:
[webkit-changes] [142880] trunk/LayoutTests
Title: [142880] trunk/LayoutTests Revision 142880 Author fmal...@chromium.org Date 2013-02-14 08:47:39 -0800 (Thu, 14 Feb 2013) Log Message [Chromium] Unreviewed rebaseline after brightness filter update. * platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png: * platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png: * platform/chromium-linux/css3/filters/effect-brightness-expected.png: * platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png: * platform/chromium-linux/css3/filters/effect-combined-hw-expected.png: * platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png: * platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png: * platform/chromium-mac/css3/filters/effect-brightness-expected.png: * platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png: * platform/chromium-mac/css3/filters/effect-combined-expected.png: * platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: * platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png: * platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png: * platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.png: * platform/chromium-win/css3/filters/effect-brightness-expected.png: * platform/chromium-win/css3/filters/effect-brightness-hw-expected.png: * platform/chromium-win/css3/filters/effect-combined-expected.png: * platform/chromium-win/css3/filters/effect-combined-hw-expected.png: * platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png trunk/LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png trunk/LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-expected.png trunk/LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png trunk/LayoutTests/platform/chromium-linux/css3/filters/effect-combined-hw-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/effect-brightness-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/effect-combined-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/effect-combined-hw-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/effect-brightness-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/effect-brightness-hw-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/effect-combined-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/effect-combined-hw-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (142879 => 142880) --- trunk/LayoutTests/ChangeLog 2013-02-14 16:39:23 UTC (rev 142879) +++ trunk/LayoutTests/ChangeLog 2013-02-14 16:47:39 UTC (rev 142880) @@ -1,3 +1,28 @@ +2013-02-14 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed rebaseline after brightness filter update. + +* platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png: +* platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png: +* platform/chromium-linux/css3/filters/effect-brightness-expected.png: +* platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png: +* platform/chromium-linux/css3/filters/effect-combined-hw-expected.png: +* platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png: +* platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png: +* platform/chromium-mac/css3/filters/effect-brightness-expected.png: +* platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png: +* platform/chromium-mac/css3/filters/effect-combined-expected.png: +* platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: +* platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png: +* platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png: +*
[webkit-changes] [142955] trunk
Title: [142955] trunk
Revision 142955
Author fmal...@chromium.org
Date 2013-02-14 19:58:18 -0800 (Thu, 14 Feb 2013)
Log Message
[SVG] Cached filter results are not invalidated on repaint rect change
https://bugs.webkit.org/show_bug.cgi?id=106221
Reviewed by Dean Jackson.
Source/WebCore:
Since the cached filter results are not invalidated for different repaint rects, we need
to render the content of the whole filter region upfront (otherwise elements not visible
during the initial paint due to scrolling/window size/etc. are never redrawn).
Tests: svg/filters/filter-hidden-content-expected.svg
svg/filters/filter-hidden-content.svg
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::drawingRegion):
(WebCore):
* rendering/svg/RenderSVGResourceFilter.h:
(FilterData):
(RenderSVGResourceFilter):
Track the filter drawing region in FilterData.
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
* rendering/svg/SVGRenderingContext.h:
Update paintInfo.rect to cover the whole drawing region while rendering filter content, and
restore it when done.
LayoutTests:
* svg/filters/filter-hidden-content-expected.svg: Added.
* svg/filters/filter-hidden-content.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.h
trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp
trunk/Source/WebCore/rendering/svg/SVGRenderingContext.h
Added Paths
trunk/LayoutTests/platform/chromium-linux/svg/filters/filter-hidden-content-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/filters/filter-hidden-content-expected.txt
trunk/LayoutTests/svg/filters/filter-hidden-content.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (142954 => 142955)
--- trunk/LayoutTests/ChangeLog 2013-02-15 03:57:57 UTC (rev 142954)
+++ trunk/LayoutTests/ChangeLog 2013-02-15 03:58:18 UTC (rev 142955)
@@ -1,3 +1,13 @@
+2013-02-14 Florin Malita fmal...@chromium.org
+
+[SVG] Cached filter results are not invalidated on repaint rect change
+https://bugs.webkit.org/show_bug.cgi?id=106221
+
+Reviewed by Dean Jackson.
+
+* svg/filters/filter-hidden-content-expected.svg: Added.
+* svg/filters/filter-hidden-content.svg: Added.
+
2013-02-14 Hajime Morrita morr...@google.com
Unreviewed rebaselining following r142940.
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (142954 => 142955)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-15 03:57:57 UTC (rev 142954)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-15 03:58:18 UTC (rev 142955)
@@ -3944,6 +3944,9 @@
webkit.org/b/98275 media/event-queue-crash.html [ Skip ]
+# Needs platform results after webkit.org/b/106221
+webkit.org/b/106221 svg/filters/filter-hidden-content.svg [ Failure Pass ]
+
# Needs rebaselining on after webkit.org/b/107339
webkit.org/b/107339 [ Mac Android Win ] platform/chromium/fast/events/touch/compositor-touch-hit-rects.html [ Pass Failure ]
Added: trunk/LayoutTests/platform/chromium-linux/svg/filters/filter-hidden-content-expected.png (0 => 142955)
--- trunk/LayoutTests/platform/chromium-linux/svg/filters/filter-hidden-content-expected.png (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/svg/filters/filter-hidden-content-expected.png 2013-02-15 03:58:18 UTC (rev 142955)
@@ -0,0 +1,80 @@
+\x89PNG
+
+
+IHDR R \xCB^$\xB0 )tEXtchecksum c4b402e8e8ee01a39e35829c2e3933bc\xA0 e\xAE
+rIDATx\x9C\xED\xD8\xC1 AEAG\xCC{\xDD\xC8\xDB\xF6 d\\xA8\x8A\xE0 \xFA\xF0\xE8\xF5x?\xFE\xD0 \xB3{\xC9:\xD7\xEE \xDC \xBF\xF0\xDC= \xE0\xDE\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xD6\xCC\xEC\xDE pc\xBES \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+ \x91S \x89\x9C H\xE4 @\xA7 9 \x90\xC8) \x80DN $r
+
[webkit-changes] [142496] trunk/Source/Platform
Title: [142496] trunk/Source/Platform
Revision 142496
Author fmal...@chromium.org
Date 2013-02-11 12:37:51 -0800 (Mon, 11 Feb 2013)
Log Message
[Chromium] FilterTypeSaturatingBrightness enum
https://bugs.webkit.org/show_bug.cgi?id=109380
Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
to support existing interntal clients which rely on the current saturating brightness
behavior (in preparation of switching to the new brightness implementation).
Reviewed by James Robinson.
* chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
(WebKit::WebFilterOperation::setAmount):
Modified Paths
trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebFilterOperation.h
Diff
Modified: trunk/Source/Platform/ChangeLog (142495 => 142496)
--- trunk/Source/Platform/ChangeLog 2013-02-11 20:36:32 UTC (rev 142495)
+++ trunk/Source/Platform/ChangeLog 2013-02-11 20:37:51 UTC (rev 142496)
@@ -1,3 +1,19 @@
+2013-02-10 Florin Malita fmal...@chromium.org
+
+[Chromium] FilterTypeSaturatingBrightness enum
+https://bugs.webkit.org/show_bug.cgi?id=109380
+
+Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
+to support existing interntal clients which rely on the current saturating brightness
+behavior (in preparation of switching to the new brightness implementation).
+
+Reviewed by James Robinson.
+
+* chromium/public/WebFilterOperation.h:
+(WebKit::WebFilterOperation::amount):
+(WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
+(WebKit::WebFilterOperation::setAmount):
+
2013-02-09 James Robinson jam...@chromium.org
[chromium] Enable more of webkit_unit_tests in component builds
Modified: trunk/Source/Platform/chromium/public/WebFilterOperation.h (142495 => 142496)
--- trunk/Source/Platform/chromium/public/WebFilterOperation.h 2013-02-11 20:36:32 UTC (rev 142495)
+++ trunk/Source/Platform/chromium/public/WebFilterOperation.h 2013-02-11 20:37:51 UTC (rev 142496)
@@ -49,6 +49,7 @@
FilterTypeDropShadow,
FilterTypeColorMatrix,
FilterTypeZoom,
+FilterTypeSaturatingBrightness, // Not used in CSS/SVG.
};
FilterType type() const { return m_type; }
@@ -65,7 +66,8 @@
|| m_type == FilterTypeOpacity
|| m_type == FilterTypeBlur
|| m_type == FilterTypeDropShadow
- || m_type == FilterTypeZoom);
+ || m_type == FilterTypeZoom
+ || m_type == FilterTypeSaturatingBrightness);
return m_amount;
}
WebPoint dropShadowOffset() const
@@ -102,6 +104,7 @@
static WebFilterOperation createDropShadowFilter(WebPoint offset, float stdDeviation, WebColor color) { return WebFilterOperation(FilterTypeDropShadow, offset, stdDeviation, color); }
static WebFilterOperation createColorMatrixFilter(SkScalar matrix[20]) { return WebFilterOperation(FilterTypeColorMatrix, matrix); }
static WebFilterOperation createZoomFilter(WebRect rect, int inset) { return WebFilterOperation(FilterTypeZoom, rect, inset); }
+static WebFilterOperation createSaturatingBrightnessFilter(float amount) { return WebFilterOperation(FilterTypeSaturatingBrightness, amount); }
bool equals(const WebFilterOperation other) const;
@@ -120,7 +123,8 @@
|| m_type == FilterTypeOpacity
|| m_type == FilterTypeBlur
|| m_type == FilterTypeDropShadow
- || m_type == FilterTypeZoom);
+ || m_type == FilterTypeZoom
+ || m_type == FilterTypeSaturatingBrightness);
m_amount = amount;
}
void setDropShadowOffset(WebPoint offset)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [142516] trunk/Source/WebKit/chromium
Title: [142516] trunk/Source/WebKit/chromium
Revision 142516
Author fmal...@chromium.org
Date 2013-02-11 14:24:17 -0800 (Mon, 11 Feb 2013)
Log Message
Unreviewed. Rolled Chromium DEPS to r181770.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (142515 => 142516)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-02-11 22:23:08 UTC (rev 142515)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-02-11 22:24:17 UTC (rev 142516)
@@ -1,3 +1,9 @@
+2013-02-11 Florin Malita fmal...@chromium.org
+
+Unreviewed. Rolled Chromium DEPS to r181770.
+
+* DEPS:
+
2013-02-11 Sheriff Bot webkit.review@gmail.com
Unreviewed. Rolled Chromium DEPS to r181742. Requested by
Modified: trunk/Source/WebKit/chromium/DEPS (142515 => 142516)
--- trunk/Source/WebKit/chromium/DEPS 2013-02-11 22:23:08 UTC (rev 142515)
+++ trunk/Source/WebKit/chromium/DEPS 2013-02-11 22:24:17 UTC (rev 142516)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '181742'
+ 'chromium_rev': '181770'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141642] trunk/LayoutTests
Title: [141642] trunk/LayoutTests Revision 141642 Author fmal...@chromium.org Date 2013-02-01 14:00:08 -0800 (Fri, 01 Feb 2013) Log Message [Chromium] Unreviewed gardening. Skip a test added in r14618 that uses setAutomaticLinkDetectionEnabled. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (141641 => 141642) --- trunk/LayoutTests/ChangeLog 2013-02-01 22:00:00 UTC (rev 141641) +++ trunk/LayoutTests/ChangeLog 2013-02-01 22:00:08 UTC (rev 141642) @@ -1,3 +1,11 @@ +2013-02-01 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed gardening. + +Skip a test added in r14618 that uses setAutomaticLinkDetectionEnabled. + +* platform/chromium/TestExpectations: + 2013-02-01 David Farler dfar...@apple.com [Mac] Layout test fast/parser/parser-yield-timing.html is flaky on debug bots Modified: trunk/LayoutTests/platform/chromium/TestExpectations (141641 => 141642) --- trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-01 22:00:00 UTC (rev 141641) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-01 22:00:08 UTC (rev 141642) @@ -2022,6 +2022,7 @@ webkit.org/b/ http/tests/appcache/origin-usage.html # LayoutTestController::setAutomaticLinkDetectionEnabled isn't implemented +webkit.org/b/85463 editing/inserting/smart-link-when-caret-is-moved-before-URL.html webkit.org/b/85463 editing/inserting/typing-space-to-trigger-smart-link.html # These tests got very flaky (failing 8/10 runs!) after ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141664] trunk/LayoutTests
Title: [141664] trunk/LayoutTests Revision 141664 Author fmal...@chromium.org Date 2013-02-01 16:50:38 -0800 (Fri, 01 Feb 2013) Log Message [Chromium] Unreviewed gardening. Rebaseline after http://trac.webkit.org/changeset/141634 * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt. * platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt: * platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt. * platform/chromium-win/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt Added Paths trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/threaded/ trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/threaded/compositing/ trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/threaded/compositing/visibility/ trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (141663 => 141664) --- trunk/LayoutTests/ChangeLog 2013-02-02 00:33:02 UTC (rev 141663) +++ trunk/LayoutTests/ChangeLog 2013-02-02 00:50:38 UTC (rev 141664) @@ -1,3 +1,14 @@ +2013-02-01 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed gardening. + +Rebaseline after http://trac.webkit.org/changeset/141634 + +* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt. +* platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt: +* platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt. +* platform/chromium-win/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt. + 2013-02-01 Jessie Berlin jber...@apple.com The assertions in updateLayerPositionsAfterScroll were commented out in r141278, so stop Copied: trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt (from rev 141663, trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt) (0 => 141664) --- trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt 2013-02-02 00:50:38 UTC (rev 141664) @@ -0,0 +1,142 @@ + + + +Initial + +(GraphicsLayer + (bounds 785.00 626.00) + (children 1 +(GraphicsLayer + (bounds 785.00 626.00) + (contentsOpaque 1) + (children 3 +(GraphicsLayer + (position 14.00 6.00) + (bounds 757.00 152.00) + (children 1 +(GraphicsLayer + (position 20.00 20.00) + (bounds 108.00 108.00) + (contentsVisible 0) +) + ) +) +(GraphicsLayer + (position 14.00 160.00) + (bounds 757.00 152.00) + (contentsVisible 0) + (children 1 +(GraphicsLayer + (position
[webkit-changes] [141408] trunk/LayoutTests
Title: [141408] trunk/LayoutTests Revision 141408 Author fmal...@chromium.org Date 2013-01-31 05:39:59 -0800 (Thu, 31 Jan 2013) Log Message [Chromium] Unreviewed gardening. * platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (141407 => 141408) --- trunk/LayoutTests/ChangeLog 2013-01-31 13:34:32 UTC (rev 141407) +++ trunk/LayoutTests/ChangeLog 2013-01-31 13:39:59 UTC (rev 141408) @@ -1,3 +1,9 @@ +2013-01-31 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed gardening. + +* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png: + 2013-01-31 Vineet Chaudhary rgf...@motorola.com formMethod to have empty string as default value and 'get' as invalid. Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141427] trunk/Source/WebCore
Title: [141427] trunk/Source/WebCore
Revision 141427
Author fmal...@chromium.org
Date 2013-01-31 09:36:46 -0800 (Thu, 31 Jan 2013)
Log Message
[Skia] Update SkiaImageFilterBuilder's brightness matrix to match Chromium's implementation
https://bugs.webkit.org/show_bug.cgi?id=107841
Reviewed by Stephen White.
Update Skia's brightness filter to match the spec after http://trac.webkit.org/changeset/139770.
No new tests: covered by existing tests (currently disabled pending rebaseline).
* platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (141426 => 141427)
--- trunk/Source/WebCore/ChangeLog 2013-01-31 17:17:30 UTC (rev 141426)
+++ trunk/Source/WebCore/ChangeLog 2013-01-31 17:36:46 UTC (rev 141427)
@@ -1,3 +1,16 @@
+2013-01-31 Florin Malita fmal...@chromium.org
+
+[Skia] Update SkiaImageFilterBuilder's brightness matrix to match Chromium's implementation
+https://bugs.webkit.org/show_bug.cgi?id=107841
+
+Reviewed by Stephen White.
+
+Update Skia's brightness filter to match the spec after http://trac.webkit.org/changeset/139770.
+
+No new tests: covered by existing tests (currently disabled pending rebaseline).
+
+* platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:
+
2013-01-31 Andrey Lushnikov lushni...@chromium.org
Web Inspector: show cursor location in DTE
Modified: trunk/Source/WebCore/platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp (141426 => 141427)
--- trunk/Source/WebCore/platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp 2013-01-31 17:17:30 UTC (rev 141426)
+++ trunk/Source/WebCore/platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp 2013-01-31 17:36:46 UTC (rev 141427)
@@ -39,8 +39,8 @@
void getBrightnessMatrix(float amount, SkScalar matrix[20])
{
memset(matrix, 0, 20 * sizeof(SkScalar));
-matrix[0] = matrix[6] = matrix[12] = matrix[18] = 1;
-matrix[4] = matrix[9] = matrix[14] = amount * 255;
+matrix[0] = matrix[6] = matrix[12] = amount;
+matrix[18] = 1;
}
void getContrastMatrix(float amount, SkScalar matrix[20])
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141440] trunk/LayoutTests
Title: [141440] trunk/LayoutTests Revision 141440 Author fmal...@chromium.org Date 2013-01-31 10:46:22 -0800 (Thu, 31 Jan 2013) Log Message [Chromium] Unreviewed gardening. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (141439 => 141440) --- trunk/LayoutTests/ChangeLog 2013-01-31 18:43:41 UTC (rev 141439) +++ trunk/LayoutTests/ChangeLog 2013-01-31 18:46:22 UTC (rev 141440) @@ -1,3 +1,9 @@ +2013-01-31 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed gardening. + +* platform/chromium/TestExpectations: + 2013-01-31 Christophe Dumez dch...@gmail.com [EFL] Disable Web Intents Modified: trunk/LayoutTests/platform/chromium/TestExpectations (141439 => 141440) --- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-31 18:43:41 UTC (rev 141439) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-31 18:46:22 UTC (rev 141440) @@ -4367,4 +4367,4 @@ webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Skip ] webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ] -webkit.org/b/108424 media/video-error-does-not-exist.html [ Failure ] +webkit.org/b/108424 media/video-error-does-not-exist.html [ Failure Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141478] trunk/Tools
Title: [141478] trunk/Tools
Revision 141478
Author fmal...@chromium.org
Date 2013-01-31 13:47:25 -0800 (Thu, 31 Jan 2013)
Log Message
[Chromium] Unreviewed gardening.
Win build fix after http://trac.webkit.org/changeset/141471.
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(MockSpellCheck::spellCheckWord):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp
Diff
Modified: trunk/Tools/ChangeLog (141477 => 141478)
--- trunk/Tools/ChangeLog 2013-01-31 21:42:46 UTC (rev 141477)
+++ trunk/Tools/ChangeLog 2013-01-31 21:47:25 UTC (rev 141478)
@@ -1,3 +1,12 @@
+2013-01-31 Florin Malita fmal...@chromium.org
+
+[Chromium] Unreviewed gardening.
+
+Win build fix after http://trac.webkit.org/changeset/141471.
+
+* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
+(MockSpellCheck::spellCheckWord):
+
2013-01-31 Enrica Casucci enr...@apple.com
WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp (141477 => 141478)
--- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp 2013-01-31 21:42:46 UTC (rev 141477)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp 2013-01-31 21:47:25 UTC (rev 141478)
@@ -81,7 +81,7 @@
// extracted word if this word is a known misspelled word.
// (See the comment in MockSpellCheck::initializeIfNeeded() why we use a
// misspelled-word table.)
-for (int i = 0; i m_misspelledWords.size(); ++i) {
+for (size_t i = 0; i m_misspelledWords.size(); ++i) {
wordLength = static_castint(m_misspelledWords.at(i).length()) maxWordLength ? maxWordLength : static_castint(m_misspelledWords.at(i).length());
word = stringText.substring(wordOffset, wordLength);
if (word == m_misspelledWords.at(i) (static_castint(stringText.length()) == wordOffset + wordLength || isNotASCIIAlpha(stringText[wordOffset + wordLength]))) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141496] trunk/Source/WebKit/chromium
Title: [141496] trunk/Source/WebKit/chromium
Revision 141496
Author fmal...@chromium.org
Date 2013-01-31 15:38:04 -0800 (Thu, 31 Jan 2013)
Log Message
[Chromium] Unreviewed gardening.
WebViewTest.SetCompositionFromExistingText failing after r141479.
* tests/WebViewTest.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/WebViewTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (141495 => 141496)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-01-31 23:26:01 UTC (rev 141495)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-31 23:38:04 UTC (rev 141496)
@@ -1,3 +1,11 @@
+2013-01-31 Florin Malita fmal...@chromium.org
+
+[Chromium] Unreviewed gardening.
+
+WebViewTest.SetCompositionFromExistingText failing after r141479.
+
+* tests/WebViewTest.cpp:
+
2013-01-31 Alexandre Elias ael...@chromium.org
[chromium] Rework page scale factor limits initialization
Modified: trunk/Source/WebKit/chromium/tests/WebViewTest.cpp (141495 => 141496)
--- trunk/Source/WebKit/chromium/tests/WebViewTest.cpp 2013-01-31 23:26:01 UTC (rev 141495)
+++ trunk/Source/WebKit/chromium/tests/WebViewTest.cpp 2013-01-31 23:38:04 UTC (rev 141496)
@@ -434,7 +434,8 @@
webView-close();
}
-TEST_F(WebViewTest, SetCompositionFromExistingText)
+// Disabled, https://bugs.webkit.org/show_bug.cgi?id=108543
+TEST_F(WebViewTest, DISABLED_SetCompositionFromExistingText)
{
URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8(input_field_populated.html));
WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + input_field_populated.html);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141261] trunk/LayoutTests
Title: [141261] trunk/LayoutTests Revision 141261 Author fmal...@chromium.org Date 2013-01-30 06:31:51 -0800 (Wed, 30 Jan 2013) Log Message [Chromium] Unreviewed gaedening. Updated results after http://trac.webkit.org/changeset/141243. * platform/chromium-linux/fast/repaint/4774354-expected.png: * platform/chromium-linux/fast/repaint/4776765-expected.png: * platform/chromium-linux/fast/repaint/caret-with-transformation-expected.png: Added. * platform/chromium-mac-lion/fast/repaint/4774354-expected.png: * platform/chromium-mac-lion/fast/repaint/4776765-expected.png: * platform/chromium-mac-lion/fast/repaint/caret-with-transformation-expected.png: Added. * platform/chromium-mac-snowleopard/fast/repaint/4774354-expected.png: * platform/chromium-mac-snowleopard/fast/repaint/4776765-expected.png: * platform/chromium-mac/fast/repaint/4774354-expected.png: * platform/chromium-mac/fast/repaint/4776765-expected.png: * platform/chromium-mac/fast/repaint/caret-with-transformation-expected.png: Added. * platform/chromium-mac/fast/repaint/caret-with-transformation-expected.txt: Added. * platform/chromium-win/fast/repaint/4774354-expected.png: * platform/chromium-win/fast/repaint/4776765-expected.png: * platform/chromium-win/fast/repaint/caret-with-transformation-expected.png: Added. * platform/chromium-win/fast/repaint/caret-with-transformation-expected.txt: Added. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/fast/repaint/4774354-expected.png trunk/LayoutTests/platform/chromium-linux/fast/repaint/4776765-expected.png trunk/LayoutTests/platform/chromium-mac/fast/repaint/4774354-expected.png trunk/LayoutTests/platform/chromium-mac/fast/repaint/4776765-expected.png trunk/LayoutTests/platform/chromium-mac-lion/fast/repaint/4774354-expected.png trunk/LayoutTests/platform/chromium-mac-lion/fast/repaint/4776765-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/4774354-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/4776765-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/4774354-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/4776765-expected.png Added Paths trunk/LayoutTests/platform/chromium-linux/fast/repaint/caret-with-transformation-expected.png trunk/LayoutTests/platform/chromium-mac/fast/repaint/caret-with-transformation-expected.png trunk/LayoutTests/platform/chromium-mac/fast/repaint/caret-with-transformation-expected.txt trunk/LayoutTests/platform/chromium-mac-lion/fast/repaint/caret-with-transformation-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/caret-with-transformation-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/caret-with-transformation-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (141260 => 141261) --- trunk/LayoutTests/ChangeLog 2013-01-30 14:03:32 UTC (rev 141260) +++ trunk/LayoutTests/ChangeLog 2013-01-30 14:31:51 UTC (rev 141261) @@ -1,3 +1,27 @@ +2013-01-30 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed gaedening. + +Updated results after http://trac.webkit.org/changeset/141243. + +* platform/chromium-linux/fast/repaint/4774354-expected.png: +* platform/chromium-linux/fast/repaint/4776765-expected.png: +* platform/chromium-linux/fast/repaint/caret-with-transformation-expected.png: Added. +* platform/chromium-mac-lion/fast/repaint/4774354-expected.png: +* platform/chromium-mac-lion/fast/repaint/4776765-expected.png: +* platform/chromium-mac-lion/fast/repaint/caret-with-transformation-expected.png: Added. +* platform/chromium-mac-snowleopard/fast/repaint/4774354-expected.png: +* platform/chromium-mac-snowleopard/fast/repaint/4776765-expected.png: +* platform/chromium-mac/fast/repaint/4774354-expected.png: +* platform/chromium-mac/fast/repaint/4776765-expected.png: +* platform/chromium-mac/fast/repaint/caret-with-transformation-expected.png: Added. +* platform/chromium-mac/fast/repaint/caret-with-transformation-expected.txt: Added. +* platform/chromium-win/fast/repaint/4774354-expected.png: +* platform/chromium-win/fast/repaint/4776765-expected.png: +* platform/chromium-win/fast/repaint/caret-with-transformation-expected.png: Added. +* platform/chromium-win/fast/repaint/caret-with-transformation-expected.txt: Added. +* platform/chromium/TestExpectations: + 2013-01-30 Allan Sandfeld Jensen allan.jen...@digia.com [Qt][WK1] Support better testing of Web Notifications Modified: trunk/LayoutTests/platform/chromium/TestExpectations (141260 => 141261) --- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-30 14:03:32 UTC (rev 141260) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-30 14:31:51 UTC (rev 141261) @@
[webkit-changes] [141266] trunk/LayoutTests
Title: [141266] trunk/LayoutTests Revision 141266 Author fmal...@chromium.org Date 2013-01-30 07:00:04 -0800 (Wed, 30 Jan 2013) Log Message [Qt] Unreviewed gardening. Skip some failing tests. https://bugs.webkit.org/show_bug.cgi?id=108340. Patch by Ádám Kallai ka...@inf.u-szeged.hu on 2013-01-30 * platform/qt/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (141265 => 141266) --- trunk/LayoutTests/ChangeLog 2013-01-30 14:55:50 UTC (rev 141265) +++ trunk/LayoutTests/ChangeLog 2013-01-30 15:00:04 UTC (rev 141266) @@ -7,6 +7,19 @@ 2013-01-30 Florin Malita fmal...@chromium.org +[Chromium] Unreviewed gardening. + +* platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.png: + +2013-01-30 Ádám Kallai ka...@inf.u-szeged.hu + +[Qt] Unreviewed gardening. Skip some failing tests. +https://bugs.webkit.org/show_bug.cgi?id=108340. + +* platform/qt/TestExpectations: + +2013-01-30 Florin Malita fmal...@chromium.org + [Chromium] Unreviewed gaedening. Updated results after http://trac.webkit.org/changeset/141243. Modified: trunk/LayoutTests/platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141280] trunk/Source/WebCore
Title: [141280] trunk/Source/WebCore
Revision 141280
Author fmal...@chromium.org
Date 2013-01-30 09:55:48 -0800 (Wed, 30 Jan 2013)
Log Message
Do not restart the matched properties cache timer if active
https://bugs.webkit.org/show_bug.cgi?id=108345
Reviewed by Andreas Kling.
StyleResolver::addToMatchedPropertiesCache() keeps resetting the timer as more than
matchedDeclarationCacheAdditionsBetweenSweeps entries are added. When armed, we should let
the timer expire at its scheduled time - otherwise it may never get a chance to fire if
entries keep getting added.
No new tests. This is a long lived timer (1min) which makes testing impractical.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::addToMatchedPropertiesCache):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (141279 => 141280)
--- trunk/Source/WebCore/ChangeLog 2013-01-30 17:55:34 UTC (rev 141279)
+++ trunk/Source/WebCore/ChangeLog 2013-01-30 17:55:48 UTC (rev 141280)
@@ -1,3 +1,20 @@
+2013-01-30 Florin Malita fmal...@chromium.org
+
+Do not restart the matched properties cache timer if active
+https://bugs.webkit.org/show_bug.cgi?id=108345
+
+Reviewed by Andreas Kling.
+
+StyleResolver::addToMatchedPropertiesCache() keeps resetting the timer as more than
+matchedDeclarationCacheAdditionsBetweenSweeps entries are added. When armed, we should let
+the timer expire at its scheduled time - otherwise it may never get a chance to fire if
+entries keep getting added.
+
+No new tests. This is a long lived timer (1min) which makes testing impractical.
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::addToMatchedPropertiesCache):
+
2013-01-30 Simon Fraser simon.fra...@apple.com
Temporarily disable assertions related to clip rect computation in RenderLayer
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (141279 => 141280)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2013-01-30 17:55:34 UTC (rev 141279)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2013-01-30 17:55:48 UTC (rev 141280)
@@ -2472,7 +2472,8 @@
void StyleResolver::addToMatchedPropertiesCache(const RenderStyle* style, const RenderStyle* parentStyle, unsigned hash, const MatchResult matchResult)
{
static const unsigned matchedDeclarationCacheAdditionsBetweenSweeps = 100;
-if (++m_matchedPropertiesCacheAdditionsSinceLastSweep = matchedDeclarationCacheAdditionsBetweenSweeps) {
+if (++m_matchedPropertiesCacheAdditionsSinceLastSweep = matchedDeclarationCacheAdditionsBetweenSweeps
+ !m_matchedPropertiesCacheSweepTimer.isActive()) {
static const unsigned matchedDeclarationCacheSweepTimeInSeconds = 60;
m_matchedPropertiesCacheSweepTimer.startOneShot(matchedDeclarationCacheSweepTimeInSeconds);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141286] trunk/LayoutTests
Title: [141286] trunk/LayoutTests Revision 141286 Author fmal...@chromium.org Date 2013-01-30 11:02:16 -0800 (Wed, 30 Jan 2013) Log Message [Chromium] Unreviewed gardening. inspector/editor/text-editor-ctrl-movements.html is timing out after r141245. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (141285 => 141286) --- trunk/LayoutTests/ChangeLog 2013-01-30 18:54:00 UTC (rev 141285) +++ trunk/LayoutTests/ChangeLog 2013-01-30 19:02:16 UTC (rev 141286) @@ -1,3 +1,11 @@ +2013-01-30 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed gardening. + +inspector/editor/text-editor-ctrl-movements.html is timing out after r141245. + +* platform/chromium/TestExpectations: + 2013-01-30 Thiago Marcos P. Santos thiago.san...@intel.com REGRESSION (r141051): Broke plugin support on non-Mac WebKit2 Ports Modified: trunk/LayoutTests/platform/chromium/TestExpectations (141285 => 141286) --- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-30 18:54:00 UTC (rev 141285) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-30 19:02:16 UTC (rev 141286) @@ -1071,6 +1071,9 @@ webkit.org/b/104800 [ Debug ] inspector-protocol/heap-profiler [ Crash ] +# Timing out after http://trac.webkit.org/changeset/141245 +webkit.org/b/107944 inspector/editor/text-editor-ctrl-movements.html [ Pass Timeout ] + # - # Editing tests # - ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141304] trunk/Source/WebCore
Title: [141304] trunk/Source/WebCore
Revision 141304
Author fmal...@chromium.org
Date 2013-01-30 13:55:30 -0800 (Wed, 30 Jan 2013)
Log Message
[Chromium] Unreviewed gardening.
Attempted Mac build fix after http://trac.webkit.org/changeset/141291.
* platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp:
(WebCore::harfBuzzCoreTextGetFontFuncs):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (141303 => 141304)
--- trunk/Source/WebCore/ChangeLog 2013-01-30 21:09:52 UTC (rev 141303)
+++ trunk/Source/WebCore/ChangeLog 2013-01-30 21:55:30 UTC (rev 141304)
@@ -1,3 +1,12 @@
+2013-01-30 Florin Malita fmal...@chromium.org
+
+[Chromium] Unreviewed gardening.
+
+Attempted Mac build fix after http://trac.webkit.org/changeset/141291.
+
+* platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp:
+(WebCore::harfBuzzCoreTextGetFontFuncs):
+
2013-01-30 Philip Rogers p...@google.com
Track scale and zoom together when drawing SVG images
Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp (141303 => 141304)
--- trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp 2013-01-30 21:09:52 UTC (rev 141303)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp 2013-01-30 21:55:30 UTC (rev 141304)
@@ -85,7 +85,7 @@
return true;
}
-static hb_font_funcs_t* harfbuzzCoreTextGetFontFuncs()
+static hb_font_funcs_t* harfBuzzCoreTextGetFontFuncs()
{
static hb_font_funcs_t* harfBuzzCoreTextFontFuncs = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141105] trunk/Source/WebCore
Title: [141105] trunk/Source/WebCore Revision 141105 Author fmal...@chromium.org Date 2013-01-29 06:19:25 -0800 (Tue, 29 Jan 2013) Log Message [Chromium] Unreviewed gardening. Update bindings-tests results after http://trac.webkit.org/changeset/141034. * bindings/scripts/test/V8/V8Float64Array.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8Float64Array::createWrapper): * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestActiveDOMObject::createWrapper): * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestCustomNamedGetter::createWrapper): * bindings/scripts/test/V8/V8TestEventConstructor.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestEventConstructor::createWrapper): * bindings/scripts/test/V8/V8TestEventTarget.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestEventTarget::createWrapper): * bindings/scripts/test/V8/V8TestException.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestException::createWrapper): * bindings/scripts/test/V8/V8TestInterface.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestInterface::createWrapper): * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestMediaQueryListListener::createWrapper): * bindings/scripts/test/V8/V8TestNamedConstructor.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestNamedConstructor::createWrapper): * bindings/scripts/test/V8/V8TestNode.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestNode::createWrapper): * bindings/scripts/test/V8/V8TestObj.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestObj::createWrapper): * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestOverloadedConstructors::createWrapper): * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: (WebCore): (WebCore::checkTypeOrDieTrying): (WebCore::V8TestSerializedScriptValueInterface::createWrapper): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (141104 => 141105) --- trunk/Source/WebCore/ChangeLog 2013-01-29 14:14:40 UTC (rev 141104) +++ trunk/Source/WebCore/ChangeLog 2013-01-29 14:19:25 UTC (rev 141105) @@ -1,3 +1,62 @@ +2013-01-29 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed gardening. + +Update bindings-tests results after http://trac.webkit.org/changeset/141034. + +* bindings/scripts/test/V8/V8Float64Array.cpp: +(WebCore): +(WebCore::checkTypeOrDieTrying): +(WebCore::V8Float64Array::createWrapper): +* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: +(WebCore): +(WebCore::checkTypeOrDieTrying): +(WebCore::V8TestActiveDOMObject::createWrapper): +* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: +(WebCore): +(WebCore::checkTypeOrDieTrying): +(WebCore::V8TestCustomNamedGetter::createWrapper): +* bindings/scripts/test/V8/V8TestEventConstructor.cpp: +(WebCore): +(WebCore::checkTypeOrDieTrying): +(WebCore::V8TestEventConstructor::createWrapper): +* bindings/scripts/test/V8/V8TestEventTarget.cpp: +(WebCore): +(WebCore::checkTypeOrDieTrying): +(WebCore::V8TestEventTarget::createWrapper): +* bindings/scripts/test/V8/V8TestException.cpp: +(WebCore): +(WebCore::checkTypeOrDieTrying): +(WebCore::V8TestException::createWrapper): +* bindings/scripts/test/V8/V8TestInterface.cpp: +(WebCore): +(WebCore::checkTypeOrDieTrying): +(WebCore::V8TestInterface::createWrapper): +* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: +(WebCore): +(WebCore::checkTypeOrDieTrying): +(WebCore::V8TestMediaQueryListListener::createWrapper): +*
[webkit-changes] [141125] trunk/Source/WebKit/chromium
Title: [141125] trunk/Source/WebKit/chromium
Revision 141125
Author fmal...@chromium.org
Date 2013-01-29 09:44:35 -0800 (Tue, 29 Jan 2013)
Log Message
[Chromium] Unreviewed gardening.
Disable WebFrameTest.pageScaleFactorShrinksViewport (pending investigation after r141053).
* tests/WebFrameTest.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (141124 => 141125)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-01-29 17:32:35 UTC (rev 141124)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-29 17:44:35 UTC (rev 141125)
@@ -1,3 +1,11 @@
+2013-01-29 Florin Malita fmal...@chromium.org
+
+[Chromium] Unreviewed gardening.
+
+Disable WebFrameTest.pageScaleFactorShrinksViewport (pending investigation after r141053).
+
+* tests/WebFrameTest.cpp:
+
2013-01-29 Keishi Hattori kei...@webkit.org
[Chromium] Disabling WebFrameTest.DisambiguationPopupMobileSite because WebFrameTest is still failing after r141073.
Modified: trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp (141124 => 141125)
--- trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2013-01-29 17:32:35 UTC (rev 141124)
+++ trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2013-01-29 17:44:35 UTC (rev 141125)
@@ -355,7 +355,8 @@
EXPECT_EQ(3, webViewImpl-pageScaleFactor());
}
-TEST_F(WebFrameTest, pageScaleFactorShrinksViewport)
+// Disabled, pending investigation after http://trac.webkit.org/changeset/141053
+TEST_F(WebFrameTest, DISABLED_pageScaleFactorShrinksViewport)
{
registerMockedHttpURLLoad(fixed_layout.html);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [139915] trunk/LayoutTests
Title: [139915] trunk/LayoutTests
Revision 139915
Author fmal...@chromium.org
Date 2013-01-16 13:18:18 -0800 (Wed, 16 Jan 2013)
Log Message
[Chromium] Unreviewed gardening.
Adding results for platform/chromium/compositing/rounded-corners.html.
* platform/chromium-mac/platform/chromium/compositing/rounded-corners-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/rounded-corners-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/platform/chromium/compositing/rounded-corners-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
Added Paths
trunk/LayoutTests/platform/chromium/platform/chromium/compositing/rounded-corners-expected.txt
trunk/LayoutTests/platform/chromium-mac/platform/chromium/compositing/rounded-corners-expected.png
trunk/LayoutTests/platform/chromium-win/platform/chromium/compositing/rounded-corners-expected.png
Removed Paths
trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (139914 => 139915)
--- trunk/LayoutTests/ChangeLog 2013-01-16 21:09:08 UTC (rev 139914)
+++ trunk/LayoutTests/ChangeLog 2013-01-16 21:18:18 UTC (rev 139915)
@@ -1,3 +1,14 @@
+2013-01-16 Florin Malita fmal...@chromium.org
+
+[Chromium] Unreviewed gardening.
+
+Adding results for platform/chromium/compositing/rounded-corners.html.
+
+* platform/chromium-mac/platform/chromium/compositing/rounded-corners-expected.png: Added.
+* platform/chromium-win/platform/chromium/compositing/rounded-corners-expected.png: Added.
+* platform/chromium/TestExpectations:
+* platform/chromium/platform/chromium/compositing/rounded-corners-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt.
+
2013-01-16 Arnaud Renevier a.renev...@sisa.samsung.com
inconsistency in drawImage with target rect negative dimensions.
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139914 => 139915)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-16 21:09:08 UTC (rev 139914)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-16 21:18:18 UTC (rev 139915)
@@ -4211,9 +4211,6 @@
webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks.html [ Failure Pass ]
webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_associate_with_navigation_timing.html [ Failure Pass ]
-# Needs platform-specific results
-webkit.org/b/106898 platform/chromium/compositing/rounded-corners.html [ Pass Missing ]
-
# Flaky since r136945
webkit.org/b/94002 [ Win Mac Debug ] inspector/debugger/live-edit-breakpoints.html [ Failure Timeout ]
webkit.org/b/94002 [ Mac Debug ] inspector/debugger/live-edit.html [ Crash Pass Timeout ]
Copied: trunk/LayoutTests/platform/chromium/platform/chromium/compositing/rounded-corners-expected.txt (from rev 139913, trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt) (0 => 139915)
--- trunk/LayoutTests/platform/chromium/platform/chromium/compositing/rounded-corners-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/platform/chromium/compositing/rounded-corners-expected.txt 2013-01-16 21:18:18 UTC (rev 139915)
@@ -0,0 +1,7 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x216
+ RenderBlock {HTML} at (0,0) size 800x216
+RenderBody {BODY} at (8,8) size 784x200
+layer at (8,8) size 200x200
+ RenderBlock {DIV} at (0,0) size 200x200 [bgcolor=#008000]
Deleted: trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt (139914 => 139915)
--- trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt 2013-01-16 21:09:08 UTC (rev 139914)
+++ trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt 2013-01-16 21:18:18 UTC (rev 139915)
@@ -1,7 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x216
- RenderBlock {HTML} at (0,0) size 800x216
-RenderBody {BODY} at (8,8) size 784x200
-layer at (8,8) size 200x200
- RenderBlock {DIV} at (0,0) size 200x200 [bgcolor=#008000]
Added: trunk/LayoutTests/platform/chromium-mac/platform/chromium/compositing/rounded-corners-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-mac/platform/chromium/compositing/rounded-corners-expected.png
___
Added: svn:mime-type
Added:
[webkit-changes] [139745] trunk
Title: [139745] trunk Revision 139745 Author fmal...@chromium.org Date 2013-01-15 08:57:55 -0800 (Tue, 15 Jan 2013) Log Message [Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect https://bugs.webkit.org/show_bug.cgi?id=106898 Reviewed by Stephen White. Source/WebCore: Since drawRRect() doesn't cover the whole bounding rect, it needs to pass a didDrawBounded notification down to the opaque region tracker (instead of didDrawRect as it currently does). Test: platform/chromium/compositing/rounded-corners.html * platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::drawRRect): Source/WebKit/chromium: * tests/PlatformContextSkiaTest.cpp: (WebCore::TEST): (WebCore): LayoutTests: * platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png: Added. * platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt: Added. * platform/chromium/TestExpectations: * platform/chromium/compositing/rounded-corners.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/tests/PlatformContextSkiaTest.cpp Added Paths trunk/LayoutTests/platform/chromium/compositing/rounded-corners.html trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (139744 => 139745) --- trunk/LayoutTests/ChangeLog 2013-01-15 16:35:41 UTC (rev 139744) +++ trunk/LayoutTests/ChangeLog 2013-01-15 16:57:55 UTC (rev 139745) @@ -1,3 +1,15 @@ +2013-01-15 Florin Malita fmal...@chromium.org + +[Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect +https://bugs.webkit.org/show_bug.cgi?id=106898 + +Reviewed by Stephen White. + +* platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png: Added. +* platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt: Added. +* platform/chromium/TestExpectations: +* platform/chromium/compositing/rounded-corners.html: Added. + 2013-01-15 Vsevolod Vlasov vse...@chromium.org Unreviewed failing test skip. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139744 => 139745) --- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-15 16:35:41 UTC (rev 139744) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-15 16:57:55 UTC (rev 139745) @@ -4210,6 +4210,9 @@ webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks.html [ Failure Pass ] webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_associate_with_navigation_timing.html [ Failure Pass ] +# Needs platform-specific results +webkit.org/b/106898 platform/chromium/compositing/rounded-corners.html [ Pass Missing ] + # Flaky since r136945 webkit.org/b/94002 [ Win Mac Debug ] inspector/debugger/live-edit-breakpoints.html [ Failure Timeout ] webkit.org/b/94002 [ Mac Debug ] inspector/debugger/live-edit.html [ Crash Pass Timeout ] Added: trunk/LayoutTests/platform/chromium/compositing/rounded-corners.html (0 => 139745) --- trunk/LayoutTests/platform/chromium/compositing/rounded-corners.html (rev 0) +++ trunk/LayoutTests/platform/chromium/compositing/rounded-corners.html 2013-01-15 16:57:55 UTC (rev 139745) @@ -0,0 +1,7 @@ +!DOCTYPE html +html +body +!-- Test for https://bugs.webkit.org/show_bug.cgi?id=106898 -- +div style=width: 200px; height: 200px; background: green; border-radius: 25%; -webkit-transform: translateZ(0);/div +/body +/html Added: trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png (0 => 139745) --- trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png (rev 0) +++ trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png 2013-01-15 16:57:55 UTC (rev 139745) @@ -0,0 +1,24 @@ +\x89PNG + + +IHDR X ' )tEXtchecksum fb023a73ef30b97adb409d2d5d7b11ae7/ŋ \xAFIDATx\x9C\xEDݿ\x8Fw \xC7\xE1\xC9\xE9$\xB6\xF3P\xB1\x9D\x87n;\x9B\x8At\xBB\xA9\xAE\x8CS]\xB9\xA6J\xBA\xDD\xFC,e\xAA@w\xA90\xE5U1]\xAE\xC2t\xB9 +\xD3\xEDU \xE9\x86Ω\xB8\xC2 +\x8A\xFB˼=^\xCF#\x8A\x90H\xF8#\xE5+\xF1\xD2g\xBE;\xFE\xE2ݻw 9\xDB\xF4 \xDBF` \x84
[webkit-changes] [139450] trunk/LayoutTests
Title: [139450] trunk/LayoutTests Revision 139450 Author fmal...@chromium.org Date 2013-01-11 08:56:53 -0800 (Fri, 11 Jan 2013) Log Message [Chromium] Unreviewed gardening. Rebaselining results after http://trac.webkit.org/changeset/139238. * platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png: * platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: * platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: * platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: * platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: * platform/chromium-mac-lion/svg/custom/svg-fonts-in-html-expected.png: * platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: * platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: * platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: * platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: * platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png: * platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png: * platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png: * platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png: * platform/chromium-mac/fast/borders/border-radius-wide-border-05-expected.png: * platform/chromium-mac/fast/borders/border-styles-split-expected.png: * platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: * platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png: * platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png: * platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png: * platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: * platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: * platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: * platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png: * platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png: * platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png: * platform/chromium-win/fast/borders/border-radius-inset-outset-expected.png: * platform/chromium-win/fast/borders/border-radius-wide-border-05-expected.png: * platform/chromium-win/fast/borders/border-styles-split-expected.png: * platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png: * platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png: * platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.png: * platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.png: * platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: * platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: * platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: * platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-wide-border-05-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-styles-split-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png
[webkit-changes] [139457] trunk
Title: [139457] trunk
Revision 139457
Author fmal...@chromium.org
Date 2013-01-11 10:10:10 -0800 (Fri, 11 Jan 2013)
Log Message
[SVG] Suppress resource rebuilding for unattached and shadow elements
https://bugs.webkit.org/show_bug.cgi?id=106664
Reviewed by Dirk Schulze.
Source/WebCore:
SVGStyledElement::buildPendingResourcesIfNeeded() can be called while cloning a subtree
(as nodes are inserted into the clone, while still detached) or when elements are inserted
into the shadow tree. Both of these cases are problematic for SVGUseElement and can trigger
indirect recursion in SVGUseElement::buildPendingResource.
Since shadow and !inDocument() nodes are of no interest to ID dependents (they cannot be
found by ID in the document), the patch short-circuits buildPendingResource() for these
cases.
Test: svg/custom/use-rebuild-resources-crash.svg
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
LayoutTests:
* svg/custom/use-rebuild-resources-crash-expected.txt: Added.
* svg/custom/use-rebuild-resources-crash.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGStyledElement.cpp
Added Paths
trunk/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt
trunk/LayoutTests/svg/custom/use-rebuild-resources-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (139456 => 139457)
--- trunk/LayoutTests/ChangeLog 2013-01-11 18:06:57 UTC (rev 139456)
+++ trunk/LayoutTests/ChangeLog 2013-01-11 18:10:10 UTC (rev 139457)
@@ -1,3 +1,13 @@
+2013-01-11 Florin Malita fmal...@chromium.org
+
+[SVG] Suppress resource rebuilding for unattached and shadow elements
+https://bugs.webkit.org/show_bug.cgi?id=106664
+
+Reviewed by Dirk Schulze.
+
+* svg/custom/use-rebuild-resources-crash-expected.txt: Added.
+* svg/custom/use-rebuild-resources-crash.svg: Added.
+
2013-01-11 Dominic Mazzoni dmazz...@google.com
AX: Computed hierarchical level is not consistent with aria-level
Added: trunk/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt (0 => 139457)
--- trunk/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt 2013-01-11 18:10:10 UTC (rev 139457)
@@ -0,0 +1,2 @@
+PASS: Did not crash.
+
Added: trunk/LayoutTests/svg/custom/use-rebuild-resources-crash.svg (0 => 139457)
--- trunk/LayoutTests/svg/custom/use-rebuild-resources-crash.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/use-rebuild-resources-crash.svg 2013-01-11 18:10:10 UTC (rev 139457)
@@ -0,0 +1,31 @@
+?xml version=1.0 encoding=iso-8859-1 standalone=no?
+svg id=svg xmlns:xlink=http://www.w3.org/1999/xlink xmlns=http://www.w3.org/2000/svg
+ !-- Test for https://bugs.webkit.org/show_bug.cgi?id=106664 --
+ defs
+symbol id=s1
+ use/
+ rect id=r1/
+/symbol
+
+use id=u1 xlink:href=""
+
+style
+ use { clip-path: url(#r1); }
+/style
+ /defs
+
+ textPASS: Did not crash./text
+
+ script
+function initCF() {
+ u1 = document.getElementById('u1');
+ clone = u1.cloneNode(false);
+ document.getElementById('svg').appendChild(clone);
+}
+
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+document.addEventListener(DOMContentLoaded, initCF, false);
+ /script
+/svg
Modified: trunk/Source/WebCore/ChangeLog (139456 => 139457)
--- trunk/Source/WebCore/ChangeLog 2013-01-11 18:06:57 UTC (rev 139456)
+++ trunk/Source/WebCore/ChangeLog 2013-01-11 18:10:10 UTC (rev 139457)
@@ -1,3 +1,24 @@
+2013-01-11 Florin Malita fmal...@chromium.org
+
+[SVG] Suppress resource rebuilding for unattached and shadow elements
+https://bugs.webkit.org/show_bug.cgi?id=106664
+
+Reviewed by Dirk Schulze.
+
+SVGStyledElement::buildPendingResourcesIfNeeded() can be called while cloning a subtree
+(as nodes are inserted into the clone, while still detached) or when elements are inserted
+into the shadow tree. Both of these cases are problematic for SVGUseElement and can trigger
+indirect recursion in SVGUseElement::buildPendingResource.
+
+Since shadow and !inDocument() nodes are of no interest to ID dependents (they cannot be
+found by ID in the document), the patch short-circuits buildPendingResource() for these
+cases.
+
+Test: svg/custom/use-rebuild-resources-crash.svg
+
+* svg/SVGStyledElement.cpp:
+(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
+
2013-01-11 Dominic Mazzoni dmazz...@google.com
AX: Computed hierarchical level is not consistent with aria-level
Modified: trunk/Source/WebCore/svg/SVGStyledElement.cpp (139456 => 139457)
--- trunk/Source/WebCore/svg/SVGStyledElement.cpp 2013-01-11 18:06:57 UTC (rev 139456)
+++ trunk/Source/WebCore/svg/SVGStyledElement.cpp
[webkit-changes] [139353] trunk/Source/WebCore
Title: [139353] trunk/Source/WebCore Revision 139353 Author fmal...@chromium.org Date 2013-01-10 12:51:41 -0800 (Thu, 10 Jan 2013) Log Message Rename GraphicsContext::addRoundedRectClip https://bugs.webkit.org/show_bug.cgi?id=106581 Reviewed by Simon Fraser. This patch renames GraphicsContext::addRoundedRectClip to clipRoundedRect for consistency with the other GC clipping methods. No new tests: no functional changes. * WebCore.order: * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clipRoundedRect): * platform/graphics/GraphicsContext.h: (GraphicsContext): * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipRoundedRect): * rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::pushContentsClip): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::clipRoundedInnerRect): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::drawBoxSideFromPath): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::clipToRect): * rendering/RenderThemeChromiumWin.cpp: (WebCore): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): * rendering/RenderThemeMacShared.mm: (WebCore::RenderThemeMacShared::paintMenuListButtonGradients): (WebCore::RenderThemeMacShared::paintSliderTrack): * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack): * rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.order trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp trunk/Source/WebCore/platform/graphics/GraphicsContext.h trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderThemeChromiumWin.cpp trunk/Source/WebCore/rendering/RenderThemeMacShared.mm trunk/Source/WebCore/rendering/RenderThemeSafari.cpp trunk/Source/WebCore/rendering/RenderThemeWinCE.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (139352 => 139353) --- trunk/Source/WebCore/ChangeLog 2013-01-10 20:44:15 UTC (rev 139352) +++ trunk/Source/WebCore/ChangeLog 2013-01-10 20:51:41 UTC (rev 139353) @@ -1,3 +1,43 @@ +2013-01-10 Florin Malita fmal...@chromium.org + +Rename GraphicsContext::addRoundedRectClip +https://bugs.webkit.org/show_bug.cgi?id=106581 + +Reviewed by Simon Fraser. + +This patch renames GraphicsContext::addRoundedRectClip to clipRoundedRect for consistency +with the other GC clipping methods. + +No new tests: no functional changes. + +* WebCore.order: +* platform/graphics/GraphicsContext.cpp: +(WebCore::GraphicsContext::clipRoundedRect): +* platform/graphics/GraphicsContext.h: +(GraphicsContext): +* platform/graphics/skia/GraphicsContextSkia.cpp: +(WebCore::GraphicsContext::clipRoundedRect): +* rendering/RenderBox.cpp: +(WebCore::RenderBox::paintBoxDecorations): +(WebCore::RenderBox::pushContentsClip): +* rendering/RenderBoxModelObject.cpp: +(WebCore::RenderBoxModelObject::clipRoundedInnerRect): +(WebCore::RenderBoxModelObject::paintBorder): +(WebCore::RenderBoxModelObject::drawBoxSideFromPath): +* rendering/RenderLayer.cpp: +(WebCore::RenderLayer::clipToRect): +* rendering/RenderThemeChromiumWin.cpp: +(WebCore): +(WebCore::RenderThemeChromiumWin::paintTextFieldInternal): +* rendering/RenderThemeMacShared.mm: +(WebCore::RenderThemeMacShared::paintMenuListButtonGradients): +(WebCore::RenderThemeMacShared::paintSliderTrack): +* rendering/RenderThemeSafari.cpp: +(WebCore::RenderThemeSafari::paintMenuListButtonGradients): +(WebCore::RenderThemeSafari::paintSliderTrack): +* rendering/RenderThemeWinCE.cpp: +(WebCore::RenderThemeWinCE::paintSearchFieldCancelButton): + 2013-01-10 Tommy Widenflycht tom...@google.com MediaStream API: Adding the new id attribute to MediaStream and MediaStreamTrack Modified: trunk/Source/WebCore/WebCore.order (139352 => 139353) --- trunk/Source/WebCore/WebCore.order 2013-01-10 20:44:15 UTC (rev 139352) +++ trunk/Source/WebCore/WebCore.order 2013-01-10 20:51:41 UTC (rev 139353) @@ -14291,7 +14291,7 @@ __ZN7WebCore15GraphicsContext15fillRoundedRectERKNS_7IntRectERKNS_7IntSizeES6_S6_S6_RKNS_5ColorENS_10ColorSpaceE __ZN7WebCoreL39backgroundRectAdjustedForBleedAvoidanceEPNS_15GraphicsContextERKNS_7IntRectENS_24BackgroundBleedAvoidanceE __ZN7WebCore20RenderBoxModelObject24getBackgroundRoundedRectERKNS_7IntRectEPNS_13InlineFlowBoxEiibb -__ZN7WebCore15GraphicsContext18addRoundedRectClipERKNS_14RoundedRectE
[webkit-changes] [139238] trunk
Title: [139238] trunk Revision 139238 Author fmal...@chromium.org Date 2013-01-09 14:01:09 -0800 (Wed, 09 Jan 2013) Log Message [Skia] Implement GraphicsContext::addRoundedRectClip() using SkCanvas::clipRRect() https://bugs.webkit.org/show_bug.cgi?id=106461 Reviewed by Stephen White. Source/WebCore: This patch adds a Skia-specific version of GraphicsContext::addRoundedRectClip() to take advantage of the SkCanvas::clipRRect() primitive. As a minor cleanup, the anonymous namespace in GraphicsContextSkia.cpp is extended to cover all the local helper functions. No new tests: coverage provided by existing tests. * platform/graphics/GraphicsContext.cpp: (WebCore): * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore): (WebCore::GraphicsContext::fillRoundedRect): * platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::clipRRect): (WebCore): LayoutTests: * platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png: * platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png: * platform/chromium-linux/fast/borders/border-radius-inset-outset-expected.png: * platform/chromium-linux/fast/borders/border-radius-wide-border-05-expected.png: * platform/chromium-linux/fast/borders/border-styles-split-expected.png: * platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png: * platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png: * platform/chromium-linux/fast/css/background-clip-radius-values-expected.png: * platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png: * platform/chromium-linux/fast/writing-mode/border-styles-vertical-lr-expected.png: * platform/chromium-linux/fast/writing-mode/border-styles-vertical-rl-expected.png: * platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: * platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: * platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: * platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-inset-outset-expected.png trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-wide-border-05-expected.png trunk/LayoutTests/platform/chromium-linux/fast/borders/border-styles-split-expected.png trunk/LayoutTests/platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png trunk/LayoutTests/platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png trunk/LayoutTests/platform/chromium-linux/fast/css/background-clip-radius-values-expected.png trunk/LayoutTests/platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png trunk/LayoutTests/platform/chromium-linux/fast/writing-mode/border-styles-vertical-lr-expected.png trunk/LayoutTests/platform/chromium-linux/fast/writing-mode/border-styles-vertical-rl-expected.png trunk/LayoutTests/platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png trunk/LayoutTests/platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png trunk/LayoutTests/platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png trunk/LayoutTests/platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png trunk/LayoutTests/platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h Diff Modified: trunk/LayoutTests/ChangeLog (139237 => 139238) --- trunk/LayoutTests/ChangeLog 2013-01-09 21:55:18 UTC (rev 139237) +++ trunk/LayoutTests/ChangeLog 2013-01-09 22:01:09 UTC (rev 139238) @@ -1,3 +1,28 @@ +2013-01-09 Florin Malita fmal...@chromium.org + +[Skia] Implement GraphicsContext::addRoundedRectClip() using SkCanvas::clipRRect() +https://bugs.webkit.org/show_bug.cgi?id=106461 + +Reviewed by Stephen White. + +* platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png: +*
[webkit-changes] [139138] trunk/Source/WebCore
Title: [139138] trunk/Source/WebCore
Revision 139138
Author fmal...@chromium.org
Date 2013-01-08 17:36:28 -0800 (Tue, 08 Jan 2013)
Log Message
Remove unused GraphicsContext::addInnerRoundedRectClip()
https://bugs.webkit.org/show_bug.cgi?id=106376
Reviewed by Andreas Kling.
Since there don't seem to be any users left for it, remove addInnerRoundedRectClip().
No new tests: no functional changes.
* platform/graphics/GraphicsContext.h:
(GraphicsContext):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
* platform/graphics/qt/GraphicsContextQt.cpp:
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
* platform/graphics/wx/GraphicsContextWx.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebCore/platform/graphics/openvg/GraphicsContextOpenVG.cpp
trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp
trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
trunk/Source/WebCore/platform/graphics/wince/GraphicsContextWinCE.cpp
trunk/Source/WebCore/platform/graphics/wx/GraphicsContextWx.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (139137 => 139138)
--- trunk/Source/WebCore/ChangeLog 2013-01-09 01:17:19 UTC (rev 139137)
+++ trunk/Source/WebCore/ChangeLog 2013-01-09 01:36:28 UTC (rev 139138)
@@ -1,3 +1,25 @@
+2013-01-08 Florin Malita fmal...@chromium.org
+
+Remove unused GraphicsContext::addInnerRoundedRectClip()
+https://bugs.webkit.org/show_bug.cgi?id=106376
+
+Reviewed by Andreas Kling.
+
+Since there don't seem to be any users left for it, remove addInnerRoundedRectClip().
+
+No new tests: no functional changes.
+
+* platform/graphics/GraphicsContext.h:
+(GraphicsContext):
+* platform/graphics/cairo/GraphicsContextCairo.cpp:
+* platform/graphics/cg/GraphicsContextCG.cpp:
+* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
+* platform/graphics/qt/GraphicsContextQt.cpp:
+* platform/graphics/skia/GraphicsContextSkia.cpp:
+(WebCore):
+* platform/graphics/wince/GraphicsContextWinCE.cpp:
+* platform/graphics/wx/GraphicsContextWx.cpp:
+
2013-01-08 Justin Novosad ju...@google.com
Color bleeding with rounded rectangles on high dpi displays
Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.h (139137 => 139138)
--- trunk/Source/WebCore/platform/graphics/GraphicsContext.h 2013-01-09 01:17:19 UTC (rev 139137)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.h 2013-01-09 01:36:28 UTC (rev 139138)
@@ -344,7 +344,6 @@
void clip(const IntRect);
void clip(const FloatRect);
void addRoundedRectClip(const RoundedRect);
-void addInnerRoundedRectClip(const IntRect, int thickness);
void clipOut(const IntRect);
void clipOutRoundedRect(const RoundedRect);
void clipPath(const Path, WindRule);
Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp (139137 => 139138)
--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp 2013-01-09 01:17:19 UTC (rev 139137)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp 2013-01-09 01:36:28 UTC (rev 139138)
@@ -844,29 +844,6 @@
m_data-setCTM(transform);
}
-void GraphicsContext::addInnerRoundedRectClip(const IntRect rect, int thickness)
-{
-if (paintingDisabled())
-return;
-
-cairo_t* cr = platformContext()-cr();
-clip(rect);
-
-Path p;
-FloatRect r(rect);
-// Add outer ellipse
-p.addEllipse(r);
-// Add inner ellipse
-r.inflate(-thickness);
-p.addEllipse(r);
-appendWebCorePathToCairoContext(cr, p);
-
-cairo_fill_rule_t savedFillRule = cairo_get_fill_rule(cr);
-cairo_set_fill_rule(cr, CAIRO_FILL_RULE_EVEN_ODD);
-cairo_clip(cr);
-cairo_set_fill_rule(cr, savedFillRule);
-}
-
void GraphicsContext::setPlatformShadow(FloatSize const size, float, Color const, ColorSpace)
{
if (paintingDisabled())
Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (139137 => 139138)
--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2013-01-09 01:17:19 UTC (rev 139137)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2013-01-09 01:36:28 UTC (rev 139138)
@@ -1097,23 +1097,6 @@
return enclosingIntRect(CGContextGetClipBoundingBox(platformContext()));
}
-void GraphicsContext::addInnerRoundedRectClip(const IntRect rect, int thickness)
-{
-if (paintingDisabled())
-return;
-
-clip(rect);
-CGContextRef context = platformContext();
-
-// Add outer ellipse
-
[webkit-changes] [137740] trunk/LayoutTests
Title: [137740] trunk/LayoutTests Revision 137740 Author fmal...@chromium.org Date 2012-12-14 05:49:49 -0800 (Fri, 14 Dec 2012) Log Message [Chromium] Unreviewed rebaseline after Skia roll @6773. * platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png: * platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png: * platform/chromium-linux/fast/borders/borderRadiusDotted04-expected.png: * platform/chromium-mac/fast/borders/borderRadiusDotted02-expected.png: * platform/chromium-mac/fast/borders/borderRadiusDotted03-expected.png: * platform/chromium-mac/fast/borders/borderRadiusDotted04-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png trunk/LayoutTests/platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png trunk/LayoutTests/platform/chromium-linux/fast/borders/borderRadiusDotted04-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/borderRadiusDotted02-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/borderRadiusDotted03-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/borderRadiusDotted04-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (137739 => 137740) --- trunk/LayoutTests/ChangeLog 2012-12-14 12:04:28 UTC (rev 137739) +++ trunk/LayoutTests/ChangeLog 2012-12-14 13:49:49 UTC (rev 137740) @@ -1,3 +1,14 @@ +2012-12-14 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed rebaseline after Skia roll @6773. + +* platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png: +* platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png: +* platform/chromium-linux/fast/borders/borderRadiusDotted04-expected.png: +* platform/chromium-mac/fast/borders/borderRadiusDotted02-expected.png: +* platform/chromium-mac/fast/borders/borderRadiusDotted03-expected.png: +* platform/chromium-mac/fast/borders/borderRadiusDotted04-expected.png: + 2012-12-14 John Mellor joh...@chromium.org Text Autosizing: Don't autosize unwrappable blocks Modified: trunk/LayoutTests/platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-linux/fast/borders/borderRadiusDotted04-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/borderRadiusDotted02-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/borderRadiusDotted03-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/borderRadiusDotted04-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137660] trunk/LayoutTests
Title: [137660] trunk/LayoutTests Revision 137660 Author fmal...@chromium.org Date 2012-12-13 15:11:14 -0800 (Thu, 13 Dec 2012) Log Message [Chromium] Unreviewed rebaselining after Skia roll @6773. * platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png: * platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png: * platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png: * platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png trunk/LayoutTests/platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (137659 => 137660) --- trunk/LayoutTests/ChangeLog 2012-12-13 23:06:25 UTC (rev 137659) +++ trunk/LayoutTests/ChangeLog 2012-12-13 23:11:14 UTC (rev 137660) @@ -1,3 +1,12 @@ +2012-12-13 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed rebaselining after Skia roll @6773. + +* platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png: +* platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png: +* platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png: +* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: + 2012-12-13 Beth Dakin bda...@apple.com Another attempt at getting these expectations right for the bots. Modified: trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136541] trunk
Title: [136541] trunk
Revision 136541
Author fmal...@chromium.org
Date 2012-12-04 11:35:30 -0800 (Tue, 04 Dec 2012)
Log Message
Stale SVGUseElement reference in CachedResource::checkNotify()
https://bugs.webkit.org/show_bug.cgi?id=104004
Reviewed by Eric Seidel.
Source/WebCore:
SVGUseElement tracks one CachedSVGDocument at a time (for external references), but when
the href attribute is updated it fails to unregister with the current CachedSVGDocument
and only updates its CachedSVGDocument with the new instance. This leaves an untracked
reference with the original CachedSVGDocument.
The patch adds the missing removeClient() call on href change, and encapsulates the
CachedSVGDocument manipulation in a helper method which handles the necessary cleanup.
Test: svg/custom/use-href-update-crash.svg
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::~SVGUseElement):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::setCachedDocument):
(WebCore):
* svg/SVGUseElement.h:
(SVGUseElement):
LayoutTests:
* svg/custom/use-href-update-crash-expected.txt: Added.
* svg/custom/use-href-update-crash.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGUseElement.cpp
trunk/Source/WebCore/svg/SVGUseElement.h
Added Paths
trunk/LayoutTests/svg/custom/use-href-update-crash-expected.txt
trunk/LayoutTests/svg/custom/use-href-update-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (136540 => 136541)
--- trunk/LayoutTests/ChangeLog 2012-12-04 19:29:48 UTC (rev 136540)
+++ trunk/LayoutTests/ChangeLog 2012-12-04 19:35:30 UTC (rev 136541)
@@ -1,3 +1,13 @@
+2012-12-04 Florin Malita fmal...@chromium.org
+
+Stale SVGUseElement reference in CachedResource::checkNotify()
+https://bugs.webkit.org/show_bug.cgi?id=104004
+
+Reviewed by Eric Seidel.
+
+* svg/custom/use-href-update-crash-expected.txt: Added.
+* svg/custom/use-href-update-crash.svg: Added.
+
2012-12-04 Antoine Quint grao...@apple.com
Missing -expected.txt files for new track tests
Added: trunk/LayoutTests/svg/custom/use-href-update-crash-expected.txt (0 => 136541)
--- trunk/LayoutTests/svg/custom/use-href-update-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/use-href-update-crash-expected.txt 2012-12-04 19:35:30 UTC (rev 136541)
@@ -0,0 +1 @@
+PASS: did not crash.
Added: trunk/LayoutTests/svg/custom/use-href-update-crash.svg (0 => 136541)
--- trunk/LayoutTests/svg/custom/use-href-update-crash.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/use-href-update-crash.svg 2012-12-04 19:35:30 UTC (rev 136541)
@@ -0,0 +1,17 @@
+?xml version=1.0 encoding=UTF-8?
+svg xmlns:xlink=http://www.w3.org/1999/xlink xmlns=http://www.w3.org/2000/svg
+ !-- Test for https://bugs.webkit.org/show_bug.cgi?id=104004 --
+ use id=use xlink:href=""
+ textPASS: did not crash./text
+
+ script
+var use = document.getElementById('use');
+use.setAttribute('xlink:href', 'bar.svg#bar');
+use.parentNode.removeChild(use);
+use = null;
+gc();
+
+if (window.testRunner)
+ testRunner.dumpAsText();
+ /script
+/svg
Modified: trunk/Source/WebCore/ChangeLog (136540 => 136541)
--- trunk/Source/WebCore/ChangeLog 2012-12-04 19:29:48 UTC (rev 136540)
+++ trunk/Source/WebCore/ChangeLog 2012-12-04 19:35:30 UTC (rev 136541)
@@ -1,3 +1,28 @@
+2012-12-04 Florin Malita fmal...@chromium.org
+
+Stale SVGUseElement reference in CachedResource::checkNotify()
+https://bugs.webkit.org/show_bug.cgi?id=104004
+
+Reviewed by Eric Seidel.
+
+SVGUseElement tracks one CachedSVGDocument at a time (for external references), but when
+the href attribute is updated it fails to unregister with the current CachedSVGDocument
+and only updates its CachedSVGDocument with the new instance. This leaves an untracked
+reference with the original CachedSVGDocument.
+
+The patch adds the missing removeClient() call on href change, and encapsulates the
+CachedSVGDocument manipulation in a helper method which handles the necessary cleanup.
+
+Test: svg/custom/use-href-update-crash.svg
+
+* svg/SVGUseElement.cpp:
+(WebCore::SVGUseElement::~SVGUseElement):
+(WebCore::SVGUseElement::svgAttributeChanged):
+(WebCore::SVGUseElement::setCachedDocument):
+(WebCore):
+* svg/SVGUseElement.h:
+(SVGUseElement):
+
2012-12-04 Yury Semikhatsky yu...@chromium.org
Web Inspector: Can't take a heap snapshot in chromium (Uncaught ReferenceError)
Modified: trunk/Source/WebCore/svg/SVGUseElement.cpp (136540 => 136541)
--- trunk/Source/WebCore/svg/SVGUseElement.cpp 2012-12-04 19:29:48 UTC (rev 136540)
+++ trunk/Source/WebCore/svg/SVGUseElement.cpp 2012-12-04 19:35:30 UTC (rev 136541)
@@ -107,8 +107,7 @@
SVGUseElement::~SVGUseElement()
{
-if (m_cachedDocument)
[webkit-changes] [136586] trunk/LayoutTests
Title: [136586] trunk/LayoutTests
Revision 136586
Author fmal...@chromium.org
Date 2012-12-04 15:49:51 -0800 (Tue, 04 Dec 2012)
Log Message
Unreviewed gardening - add missing js-test-pre.js include to avoid use-href-update-crash.svg
failures on platforms that do not define gc().
* svg/custom/use-href-update-crash.svg:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/svg/custom/use-href-update-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (136585 => 136586)
--- trunk/LayoutTests/ChangeLog 2012-12-04 23:41:37 UTC (rev 136585)
+++ trunk/LayoutTests/ChangeLog 2012-12-04 23:49:51 UTC (rev 136586)
@@ -1,3 +1,10 @@
+2012-12-04 Florin Malita fmal...@chromium.org
+
+Unreviewed gardening - add missing js-test-pre.js include to avoid use-href-update-crash.svg
+failures on platforms that do not define gc().
+
+* svg/custom/use-href-update-crash.svg:
+
2012-12-04 Emil A Eklund e...@chromium.org
Unreviewed, mark css3/filters/effect-reference-hw.html as failing rather than crashing.
Modified: trunk/LayoutTests/svg/custom/use-href-update-crash.svg (136585 => 136586)
--- trunk/LayoutTests/svg/custom/use-href-update-crash.svg 2012-12-04 23:41:37 UTC (rev 136585)
+++ trunk/LayoutTests/svg/custom/use-href-update-crash.svg 2012-12-04 23:49:51 UTC (rev 136586)
@@ -3,7 +3,8 @@
!-- Test for https://bugs.webkit.org/show_bug.cgi?id=104004 --
use id=use xlink:href=""
textPASS: did not crash./text
-
+
+ script src=""
script
var use = document.getElementById('use');
use.setAttribute('xlink:href', 'bar.svg#bar');
@@ -14,4 +15,5 @@
if (window.testRunner)
testRunner.dumpAsText();
/script
+ script src=""
/svg
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136604] trunk/LayoutTests
Title: [136604] trunk/LayoutTests Revision 136604 Author fmal...@chromium.org Date 2012-12-04 17:39:27 -0800 (Tue, 04 Dec 2012) Log Message Unreviewed gardening - suppressing failing svg/custom/use-href-update-crash.svg on Mac and Qt. * platform/mac/TestExpectations: * platform/qt/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/qt/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (136603 => 136604) --- trunk/LayoutTests/ChangeLog 2012-12-05 01:35:55 UTC (rev 136603) +++ trunk/LayoutTests/ChangeLog 2012-12-05 01:39:27 UTC (rev 136604) @@ -1,3 +1,11 @@ +2012-12-04 Florin Malita fmal...@chromium.org + +Unreviewed gardening - suppressing failing svg/custom/use-href-update-crash.svg on Mac and +Qt. + +* platform/mac/TestExpectations: +* platform/qt/TestExpectations: + 2012-12-04 Stephen White senorbla...@chromium.org [chromium] Turn on the new Skia mask blur algorithm. Modified: trunk/LayoutTests/platform/mac/TestExpectations (136603 => 136604) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-05 01:35:55 UTC (rev 136603) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-05 01:39:27 UTC (rev 136604) @@ -1057,6 +1057,9 @@ # Fails on WK1, but passes on WK2. (No syntax available for this situation.) webkit.org/b/58192 plugins/npp-set-window-called-during-destruction.html [ Failure Pass ] +# https://bugs.webkit.org/show_bug.cgi?id=104054 +webkit.org/b/104054 svg/custom/use-href-update-crash.svg [ Failure Pass ] + # Flakey plugin tests webkit.org/b/82752 plugins/netscape-dom-access-and-reload.html [ Failure Pass ] Modified: trunk/LayoutTests/platform/qt/TestExpectations (136603 => 136604) --- trunk/LayoutTests/platform/qt/TestExpectations 2012-12-05 01:35:55 UTC (rev 136603) +++ trunk/LayoutTests/platform/qt/TestExpectations 2012-12-05 01:39:27 UTC (rev 136604) @@ -1295,6 +1295,9 @@ webkit.org/b/98718 svg/animations/animate-css-xml-attributeType.html [ Failure Pass ] +# https://bugs.webkit.org/show_bug.cgi?id=104054 +webkit.org/b/104054 svg/custom/use-href-update-crash.svg [ Failure Pass ] + # [Qt] svg/animations/animate-path-nested-transforms.html fails # https://bugs.webkit.org/show_bug.cgi?id=48987 svg/animations/animate-path-nested-transforms.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136610] trunk/LayoutTests
Title: [136610] trunk/LayoutTests Revision 136610 Author fmal...@chromium.org Date 2012-12-04 19:25:34 -0800 (Tue, 04 Dec 2012) Log Message Unreviewed gardening - skip use-href-update-crash.svg on Win. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (136609 => 136610) --- trunk/LayoutTests/ChangeLog 2012-12-05 02:49:07 UTC (rev 136609) +++ trunk/LayoutTests/ChangeLog 2012-12-05 03:25:34 UTC (rev 136610) @@ -1,3 +1,9 @@ +2012-12-04 Florin Malita fmal...@chromium.org + +Unreviewed gardening - skip use-href-update-crash.svg on Win. + +* platform/win/TestExpectations: + 2012-12-04 Takashi Sakamoto ta...@google.com Unreviewed, WebKit gardening. Modified: trunk/LayoutTests/platform/win/TestExpectations (136609 => 136610) --- trunk/LayoutTests/platform/win/TestExpectations 2012-12-05 02:49:07 UTC (rev 136609) +++ trunk/LayoutTests/platform/win/TestExpectations 2012-12-05 03:25:34 UTC (rev 136610) @@ -254,6 +254,9 @@ # https://bugs.webkit.org/show_bug.cgi?id=35013 (Impossible to test text-only-zoom from DRT on Windows) svg/zoom/text +# https://bugs.webkit.org/show_bug.cgi?id=104054 +svg/custom/use-href-update-crash.svg + # Crashes due to debug assert until we fix issues with style elements in SVG svg/custom/use-referencing-style-crash.svg ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136435] trunk/Source/WebCore
Title: [136435] trunk/Source/WebCore Revision 136435 Author fmal...@chromium.org Date 2012-12-03 13:42:39 -0800 (Mon, 03 Dec 2012) Log Message [Skia] Deferred SkCanvas save() https://bugs.webkit.org/show_bug.cgi?id=102272 Reviewed by Stephen White. Implement a lazy save() strategy: instead of delegating to the canvas upfront, defer and only commit when a clip/matrix mutation is observed. The patch yields a 1-20% SkCanvas save/restore reduction for heavy pages, with much larger gains observed for deeply nested SVG content. No new tests: no behaviour changes, coverage provided by existing tests. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::canvasClip): * platform/graphics/skia/PlatformContextSkia.cpp: (WebCore): (WebCore::PlatformContextSkia::DeferredSaveState::DeferredSaveState): (PlatformContextSkia::DeferredSaveState): (WebCore::PlatformContextSkia::PlatformContextSkia): (WebCore::PlatformContextSkia::save): (WebCore::PlatformContextSkia::saveLayer): (WebCore::PlatformContextSkia::beginLayerClippedToImage): (WebCore::PlatformContextSkia::restore): (WebCore::PlatformContextSkia::applyClipFromImage): * platform/graphics/skia/PlatformContextSkia.h: (PlatformContextSkia): (WebCore::PlatformContextSkia::realizeSave): (WebCore): (WebCore::PlatformContextSkia::canvas): (WebCore::PlatformContextSkia::clipPath): (WebCore::PlatformContextSkia::clipRect): (WebCore::PlatformContextSkia::setMatrix): (WebCore::PlatformContextSkia::concat): (WebCore::PlatformContextSkia::rotate): (WebCore::PlatformContextSkia::scale): (WebCore::PlatformContextSkia::translate): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h Diff Modified: trunk/Source/WebCore/ChangeLog (136434 => 136435) --- trunk/Source/WebCore/ChangeLog 2012-12-03 21:22:41 UTC (rev 136434) +++ trunk/Source/WebCore/ChangeLog 2012-12-03 21:42:39 UTC (rev 136435) @@ -1,3 +1,43 @@ +2012-12-03 Florin Malita fmal...@chromium.org + +[Skia] Deferred SkCanvas save() +https://bugs.webkit.org/show_bug.cgi?id=102272 + +Reviewed by Stephen White. + +Implement a lazy save() strategy: instead of delegating to the canvas upfront, defer and +only commit when a clip/matrix mutation is observed. + +The patch yields a 1-20% SkCanvas save/restore reduction for heavy pages, with much larger +gains observed for deeply nested SVG content. + +No new tests: no behaviour changes, coverage provided by existing tests. + +* platform/graphics/skia/GraphicsContextSkia.cpp: +(WebCore::GraphicsContext::canvasClip): +* platform/graphics/skia/PlatformContextSkia.cpp: +(WebCore): +(WebCore::PlatformContextSkia::DeferredSaveState::DeferredSaveState): +(PlatformContextSkia::DeferredSaveState): +(WebCore::PlatformContextSkia::PlatformContextSkia): +(WebCore::PlatformContextSkia::save): +(WebCore::PlatformContextSkia::saveLayer): +(WebCore::PlatformContextSkia::beginLayerClippedToImage): +(WebCore::PlatformContextSkia::restore): +(WebCore::PlatformContextSkia::applyClipFromImage): +* platform/graphics/skia/PlatformContextSkia.h: +(PlatformContextSkia): +(WebCore::PlatformContextSkia::realizeSave): +(WebCore): +(WebCore::PlatformContextSkia::canvas): +(WebCore::PlatformContextSkia::clipPath): +(WebCore::PlatformContextSkia::clipRect): +(WebCore::PlatformContextSkia::setMatrix): +(WebCore::PlatformContextSkia::concat): +(WebCore::PlatformContextSkia::rotate): +(WebCore::PlatformContextSkia::scale): +(WebCore::PlatformContextSkia::translate): + 2012-12-03 Simon Fraser simon.fra...@apple.com When animating mask-postion on a composited layer, element renders incorrectly Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (136434 => 136435) --- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2012-12-03 21:22:41 UTC (rev 136434) +++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2012-12-03 21:42:39 UTC (rev 136435) @@ -334,7 +334,7 @@ if (paintingDisabled()) return; -platformContext()-canvasClipPath(path.isNull() ? SkPath() : *path.platformPath()); +platformContext()-clipPath(path.isNull() ? SkPath() : *path.platformPath()); } void GraphicsContext::clipOut(const IntRect rect) Modified: trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp (136434 => 136435) --- trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp 2012-12-03 21:22:41 UTC (rev 136434) +++ trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp 2012-12-03 21:42:39 UTC (rev 136435) @@ -58,6
[webkit-changes] [136250] trunk
Title: [136250] trunk Revision 136250 Author fmal...@chromium.org Date 2012-11-30 09:49:11 -0800 (Fri, 30 Nov 2012) Log Message SVG pattern data deleted while in use https://bugs.webkit.org/show_bug.cgi?id=103415 Reviewed by Dirk Schulze. Source/WebCore: Various calls in RenderSVGResourcePattern::applyResource() can trigger invalidations, which may end up deleting our current pattern data (via removeAllClientsFromCache). To avoid this, we should add the pattern data to the cache only after it is fully built. For clarity, the patch also refactors the pattern setup code into a separate method. Test: svg/custom/large-image-pattern-crash.html * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildPattern): (WebCore::RenderSVGResourcePattern::applyResource): * rendering/svg/RenderSVGResourcePattern.h: (RenderSVGResourcePattern): LayoutTests: * svg/custom/large-image-pattern-crash-expected.txt: Added. * svg/custom/large-image-pattern-crash.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.h Added Paths trunk/LayoutTests/svg/custom/large-image-pattern-crash-expected.txt trunk/LayoutTests/svg/custom/large-image-pattern-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (136249 => 136250) --- trunk/LayoutTests/ChangeLog 2012-11-30 17:20:42 UTC (rev 136249) +++ trunk/LayoutTests/ChangeLog 2012-11-30 17:49:11 UTC (rev 136250) @@ -1,3 +1,13 @@ +2012-11-30 Florin Malita fmal...@chromium.org + +SVG pattern data deleted while in use +https://bugs.webkit.org/show_bug.cgi?id=103415 + +Reviewed by Dirk Schulze. + +* svg/custom/large-image-pattern-crash-expected.txt: Added. +* svg/custom/large-image-pattern-crash.html: Added. + 2012-11-30 Stephen Chenney schen...@chromium.org [Chromium] Fixing TestExpectations Added: trunk/LayoutTests/svg/custom/large-image-pattern-crash-expected.txt (0 => 136250) --- trunk/LayoutTests/svg/custom/large-image-pattern-crash-expected.txt (rev 0) +++ trunk/LayoutTests/svg/custom/large-image-pattern-crash-expected.txt 2012-11-30 17:49:11 UTC (rev 136250) @@ -0,0 +1,2 @@ +PASS: did not crash. + Added: trunk/LayoutTests/svg/custom/large-image-pattern-crash.html (0 => 136250) --- trunk/LayoutTests/svg/custom/large-image-pattern-crash.html (rev 0) +++ trunk/LayoutTests/svg/custom/large-image-pattern-crash.html 2012-11-30 17:49:11 UTC (rev 136250) @@ -0,0 +1,19 @@ +!DOCTYPE html +html + body +svg xmlns=http://www.w3.org/2000/svg + pattern id=pattern width=100 height=100 +image height=4 width=4 xlink:href="" + svg xmlns='http://www.w3.org/2000/svg'/svg +/ + /pattern + rect fill=url(#pattern) height=300 width=400/ + textPASS: did not crash./text + + script +if (window.testRunner) + testRunner.dumpAsText(); + /script +/svg + /body +/html Modified: trunk/Source/WebCore/ChangeLog (136249 => 136250) --- trunk/Source/WebCore/ChangeLog 2012-11-30 17:20:42 UTC (rev 136249) +++ trunk/Source/WebCore/ChangeLog 2012-11-30 17:49:11 UTC (rev 136250) @@ -1,3 +1,23 @@ +2012-11-30 Florin Malita fmal...@chromium.org + +SVG pattern data deleted while in use +https://bugs.webkit.org/show_bug.cgi?id=103415 + +Reviewed by Dirk Schulze. + +Various calls in RenderSVGResourcePattern::applyResource() can trigger invalidations, +which may end up deleting our current pattern data (via removeAllClientsFromCache). +To avoid this, we should add the pattern data to the cache only after it is fully built. +For clarity, the patch also refactors the pattern setup code into a separate method. + +Test: svg/custom/large-image-pattern-crash.html + +* rendering/svg/RenderSVGResourcePattern.cpp: +(WebCore::RenderSVGResourcePattern::buildPattern): +(WebCore::RenderSVGResourcePattern::applyResource): +* rendering/svg/RenderSVGResourcePattern.h: +(RenderSVGResourcePattern): + 2012-11-30 Alexander Pavlov apav...@chromium.org Web Inspector: It's Sass, not SASS Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp (136249 => 136250) --- trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp 2012-11-30 17:20:42 UTC (rev 136249) +++ trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp 2012-11-30 17:49:11 UTC (rev 136250) @@ -55,20 +55,15 @@ markClientForInvalidation(client, markForInvalidation ? RepaintInvalidation : ParentOnlyInvalidation); } -bool RenderSVGResourcePattern::applyResource(RenderObject* object, RenderStyle* style, GraphicsContext* context, unsigned short resourceMode) +PatternData* RenderSVGResourcePattern::buildPattern(RenderObject* object, unsigned
[webkit-changes] [136125] trunk/Source
Title: [136125] trunk/Source
Revision 136125
Author fmal...@chromium.org
Date 2012-11-29 05:34:34 -0800 (Thu, 29 Nov 2012)
Log Message
[Skia] Add missing OpaqueRegionSkia notifier calls
https://bugs.webkit.org/show_bug.cgi?id=102824
Reviewed by Stephen White.
Source/WebCore:
http://trac.webkit.org/changeset/135390 exposed some canvas draw clients which are not
updating the opaque region tracker. This patch adds the required notifier calls.
No new tests: platform unit tests added.
* platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
* platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::writePixels):
(WebCore::PlatformContextSkia::drawBitmap):
(WebCore::PlatformContextSkia::drawBitmapRect):
(WebCore::PlatformContextSkia::drawIRect):
(WebCore::PlatformContextSkia::drawPosText):
(WebCore::PlatformContextSkia::drawPosTextH):
(WebCore::PlatformContextSkia::drawTextOnPath):
Source/WebKit/chromium:
Add opaque region tracking unit tests for the new PlatformContextSkia draw methods.
* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.h
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/PlatformContextSkiaTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (136124 => 136125)
--- trunk/Source/WebCore/ChangeLog 2012-11-29 13:25:53 UTC (rev 136124)
+++ trunk/Source/WebCore/ChangeLog 2012-11-29 13:34:34 UTC (rev 136125)
@@ -1,3 +1,26 @@
+2012-11-29 Florin Malita fmal...@chromium.org
+
+[Skia] Add missing OpaqueRegionSkia notifier calls
+https://bugs.webkit.org/show_bug.cgi?id=102824
+
+Reviewed by Stephen White.
+
+http://trac.webkit.org/changeset/135390 exposed some canvas draw clients which are not
+updating the opaque region tracker. This patch adds the required notifier calls.
+
+No new tests: platform unit tests added.
+
+* platform/graphics/skia/OpaqueRegionSkia.h:
+(OpaqueRegionSkia):
+* platform/graphics/skia/PlatformContextSkia.h:
+(WebCore::PlatformContextSkia::writePixels):
+(WebCore::PlatformContextSkia::drawBitmap):
+(WebCore::PlatformContextSkia::drawBitmapRect):
+(WebCore::PlatformContextSkia::drawIRect):
+(WebCore::PlatformContextSkia::drawPosText):
+(WebCore::PlatformContextSkia::drawPosTextH):
+(WebCore::PlatformContextSkia::drawTextOnPath):
+
2012-11-29 Andy Shaw andy.s...@digia.com
[Qt] Implement support for Cocoa based NPAPI plugins on Mac
Modified: trunk/Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.h (136124 => 136125)
--- trunk/Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.h 2012-11-29 13:25:53 UTC (rev 136124)
+++ trunk/Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.h 2012-11-29 13:34:34 UTC (rev 136125)
@@ -57,16 +57,17 @@
void setImageMask(const SkRect imageOpaqueRect);
+enum DrawType {
+FillOnly,
+FillOrStroke
+};
+
void didDrawRect(const PlatformContextSkia*, const SkRect, const SkPaint, const SkBitmap* sourceBitmap);
void didDrawPath(const PlatformContextSkia*, const SkPath, const SkPaint);
void didDrawPoints(const PlatformContextSkia*, SkCanvas::PointMode, int numPoints, const SkPoint[], const SkPaint);
void didDrawBounded(const PlatformContextSkia*, const SkRect, const SkPaint);
+void didDrawUnbounded(const PlatformContextSkia*, const SkPaint, DrawType);
-enum DrawType {
-FillOnly,
-FillOrStroke
-};
-
struct CanvasLayerState {
CanvasLayerState()
: hasImageMask(false)
@@ -85,7 +86,6 @@
private:
void didDraw(const PlatformContextSkia*, const SkRect, const SkPaint, const SkBitmap* sourceBitmap, bool fillsBounds, DrawType);
-void didDrawUnbounded(const PlatformContextSkia*, const SkPaint, DrawType);
void applyOpaqueRegionFromLayer(const PlatformContextSkia*, const SkRect layerOpaqueRect, const SkPaint);
void markRectAsOpaque(const SkRect);
void markRectAsNonOpaque(const SkRect);
Modified: trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h (136124 => 136125)
--- trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h 2012-11-29 13:25:53 UTC (rev 136124)
+++ trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h 2012-11-29 13:34:34 UTC (rev 136125)
@@ -302,6 +302,14 @@
SkCanvas::Config config)
{
m_canvas-writePixels(bitmap, x, y, config);
+
+if (m_trackOpaqueRegion) {
+SkRect rect = SkRect::MakeXYWH(x, y, bitmap.width(), bitmap.height());
+SkPaint paint;
+
+paint.setXfermodeMode(SkXfermode::kSrc_Mode);
+m_opaqueRegion.didDrawRect(this, rect, paint, bitmap);
+}
}
inline bool PlatformContextSkia::isDrawingToLayer()
[webkit-changes] [135719] trunk
Title: [135719] trunk
Revision 135719
Author fmal...@chromium.org
Date 2012-11-26 07:03:36 -0800 (Mon, 26 Nov 2012)
Log Message
RenderSVGResourceContainer does not clear cached data on removal
https://bugs.webkit.org/show_bug.cgi?id=102620
Reviewed by Dirk Schulze.
Source/WebCore:
RenderSVGResourceContainer::removeClient needs to also remove the client from specialized
caches, otherwise we can end up with stale references.
Test: svg/custom/stale-resource-data-crash.svg
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::removeClient):
LayoutTests:
* svg/custom/stale-resource-data-crash-expected.txt: Added.
* svg/custom/stale-resource-data-crash.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp
Added Paths
trunk/LayoutTests/svg/custom/stale-resource-data-crash-expected.txt
trunk/LayoutTests/svg/custom/stale-resource-data-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (135718 => 135719)
--- trunk/LayoutTests/ChangeLog 2012-11-26 15:01:24 UTC (rev 135718)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 15:03:36 UTC (rev 135719)
@@ -1,3 +1,13 @@
+2012-11-26 Florin Malita fmal...@chromium.org
+
+RenderSVGResourceContainer does not clear cached data on removal
+https://bugs.webkit.org/show_bug.cgi?id=102620
+
+Reviewed by Dirk Schulze.
+
+* svg/custom/stale-resource-data-crash-expected.txt: Added.
+* svg/custom/stale-resource-data-crash.svg: Added.
+
2012-11-26 'Pavel Feldman' pfeld...@chromium.org
Not reviewed: rolling out r135714 and r135712 for breaking debug tests.
Added: trunk/LayoutTests/svg/custom/stale-resource-data-crash-expected.txt (0 => 135719)
--- trunk/LayoutTests/svg/custom/stale-resource-data-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/stale-resource-data-crash-expected.txt 2012-11-26 15:03:36 UTC (rev 135719)
@@ -0,0 +1,2 @@
+PASS: did not crash.
+
Added: trunk/LayoutTests/svg/custom/stale-resource-data-crash.svg (0 => 135719)
--- trunk/LayoutTests/svg/custom/stale-resource-data-crash.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/stale-resource-data-crash.svg 2012-11-26 15:03:36 UTC (rev 135719)
@@ -0,0 +1,32 @@
+?xml version=1.0 encoding=UTF-8?
+svg id=svg xmlns:xlink=http://www.w3.org/1999/xlink xmlns=http://www.w3.org/2000/svg
+ defs id=defs
+filter id=f1
+ feDiffuseLighting
+feDistantLight azimuth=45 id=light/
+ /feDiffuseLighting
+/filter
+filter id=f2/
+ /defs
+ image id=img filter=url(#f1) xlink:href=""
+
+ textPASS: did not crash./text
+
+ script
+f2 = document.getElementById('f2');
+docElement = document.getElementById('svg');
+light = document.getElementById('light');
+newDefs = document.getElementById('defs').cloneNode(true);
+
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ // Force a paint at this point to generate cached filter results.
+ testRunner.display();
+}
+
+docElement.appendChild(newDefs);
+docElement.appendChild(f2);
+docElement.offsetTop;
+light.removeAttribute('azimuth');
+ /script
+/svg
Modified: trunk/Source/WebCore/ChangeLog (135718 => 135719)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 15:01:24 UTC (rev 135718)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 15:03:36 UTC (rev 135719)
@@ -1,3 +1,18 @@
+2012-11-26 Florin Malita fmal...@chromium.org
+
+RenderSVGResourceContainer does not clear cached data on removal
+https://bugs.webkit.org/show_bug.cgi?id=102620
+
+Reviewed by Dirk Schulze.
+
+RenderSVGResourceContainer::removeClient needs to also remove the client from specialized
+caches, otherwise we can end up with stale references.
+
+Test: svg/custom/stale-resource-data-crash.svg
+
+* rendering/svg/RenderSVGResourceContainer.cpp:
+(WebCore::RenderSVGResourceContainer::removeClient):
+
2012-11-26 'Pavel Feldman' pfeld...@chromium.org
Not reviewed: rolling out r135714 and r135712 for breaking debug tests.
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp (135718 => 135719)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2012-11-26 15:01:24 UTC (rev 135718)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2012-11-26 15:03:36 UTC (rev 135719)
@@ -151,6 +151,7 @@
void RenderSVGResourceContainer::removeClient(RenderObject* client)
{
ASSERT(client);
+removeClientFromCache(client, false);
m_clients.remove(client);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135393] trunk/Source/WebCore
Title: [135393] trunk/Source/WebCore Revision 135393 Author fmal...@chromium.org Date 2012-11-21 06:03:58 -0800 (Wed, 21 Nov 2012) Log Message [Chromium] Unreviewed Mac build fix after http://trac.webkit.org/changeset/135390. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::drawInnerPath): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (135392 => 135393) --- trunk/Source/WebCore/ChangeLog 2012-11-21 13:53:23 UTC (rev 135392) +++ trunk/Source/WebCore/ChangeLog 2012-11-21 14:03:58 UTC (rev 135393) @@ -1,5 +1,12 @@ 2012-11-21 Florin Malita fmal...@chromium.org +[Chromium] Unreviewed Mac build fix after http://trac.webkit.org/changeset/135390. + +* platform/graphics/skia/GraphicsContextSkia.cpp: +(WebCore::drawInnerPath): + +2012-11-21 Florin Malita fmal...@chromium.org + [Skia] Encapsulate access to PlatformContextSkia's SkCanvas https://bugs.webkit.org/show_bug.cgi?id=102694 Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (135392 => 135393) --- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2012-11-21 13:53:23 UTC (rev 135392) +++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2012-11-21 14:03:58 UTC (rev 135393) @@ -493,8 +493,7 @@ #if PLATFORM(CHROMIUM) OS(DARWIN) paint.setAlpha(128); paint.setStrokeWidth(width * 0.5f); -context-canvas()-drawPath(path, paint); -context-didDrawPath(path, paint); +context-drawPath(path, paint); #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [132665] trunk
Title: [132665] trunk Revision 132665 Author fmal...@chromium.org Date 2012-10-26 08:57:08 -0700 (Fri, 26 Oct 2012) Log Message Crash on loading SVG filter resource on HTML element https://bugs.webkit.org/show_bug.cgi?id=100491 Reviewed by Dirk Schulze. Source/WebCore: Skip non-filter elements referenced via -webkit-filter. Test: svg/filters/filter-reference-crash.html * rendering/RenderLayerFilterInfo.cpp: (WebCore::RenderLayerFilterInfo::updateReferenceFilterClients): LayoutTests: * svg/filters/filter-reference-crash-expected.txt: Added. * svg/filters/filter-reference-crash.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderLayerFilterInfo.cpp Added Paths trunk/LayoutTests/svg/filters/filter-reference-crash-expected.txt trunk/LayoutTests/svg/filters/filter-reference-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (132664 => 132665) --- trunk/LayoutTests/ChangeLog 2012-10-26 15:49:30 UTC (rev 132664) +++ trunk/LayoutTests/ChangeLog 2012-10-26 15:57:08 UTC (rev 132665) @@ -1,3 +1,13 @@ +2012-10-26 Florin Malita fmal...@chromium.org + +Crash on loading SVG filter resource on HTML element +https://bugs.webkit.org/show_bug.cgi?id=100491 + +Reviewed by Dirk Schulze. + +* svg/filters/filter-reference-crash-expected.txt: Added. +* svg/filters/filter-reference-crash.html: Added. + 2012-10-26 Jussi Kukkonen jussi.kukko...@intel.com [WK2] should enable two postredirect tests Added: trunk/LayoutTests/svg/filters/filter-reference-crash-expected.txt (0 => 132665) --- trunk/LayoutTests/svg/filters/filter-reference-crash-expected.txt (rev 0) +++ trunk/LayoutTests/svg/filters/filter-reference-crash-expected.txt 2012-10-26 15:57:08 UTC (rev 132665) @@ -0,0 +1,2 @@ +PASS: did not crash. + Added: trunk/LayoutTests/svg/filters/filter-reference-crash.html (0 => 132665) --- trunk/LayoutTests/svg/filters/filter-reference-crash.html (rev 0) +++ trunk/LayoutTests/svg/filters/filter-reference-crash.html 2012-10-26 15:57:08 UTC (rev 132665) @@ -0,0 +1,13 @@ +!DOCTYPE html +html lang=en + !-- Test for https://bugs.webkit.org/show_bug.cgi?id=100491 -- + body +div id=fake_filterPASS: did not crash./div +div style=width: 100px; height: 100px; background-color: green; -webkit-filter: url(#fake_filter);/div + + script +if(window.testRunner) + testRunner.dumpAsText(); + /script + /body +/html Modified: trunk/Source/WebCore/ChangeLog (132664 => 132665) --- trunk/Source/WebCore/ChangeLog 2012-10-26 15:49:30 UTC (rev 132664) +++ trunk/Source/WebCore/ChangeLog 2012-10-26 15:57:08 UTC (rev 132665) @@ -1,3 +1,17 @@ +2012-10-26 Florin Malita fmal...@chromium.org + +Crash on loading SVG filter resource on HTML element +https://bugs.webkit.org/show_bug.cgi?id=100491 + +Reviewed by Dirk Schulze. + +Skip non-filter elements referenced via -webkit-filter. + +Test: svg/filters/filter-reference-crash.html + +* rendering/RenderLayerFilterInfo.cpp: +(WebCore::RenderLayerFilterInfo::updateReferenceFilterClients): + 2012-10-26 Antti Koivisto an...@apple.com Lots of time spent under DNSResolveQueue::platformProxyIsEnabledInSystemPreferences Modified: trunk/Source/WebCore/rendering/RenderLayerFilterInfo.cpp (132664 => 132665) --- trunk/Source/WebCore/rendering/RenderLayerFilterInfo.cpp 2012-10-26 15:49:30 UTC (rev 132664) +++ trunk/Source/WebCore/rendering/RenderLayerFilterInfo.cpp 2012-10-26 15:57:08 UTC (rev 132665) @@ -141,9 +141,8 @@ // Reference is internal; add layer as a client so we can trigger // filter repaint on SVG attribute change. Element* filter = m_layer-renderer()-node()-document()-getElementById(referenceFilterOperation-fragment()); -if (!filter || !filter-renderer()) +if (!filter || !filter-renderer() || !filter-renderer()-isSVGResourceFilter()) continue; -ASSERT(filter-renderer()-isSVGResourceContainer()); filter-renderer()-toRenderSVGResourceContainer()-addClientRenderLayer(m_layer); m_internalSVGReferences.append(filter); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [132477] trunk/LayoutTests
Title: [132477] trunk/LayoutTests Revision 132477 Author fmal...@chromium.org Date 2012-10-25 06:05:04 -0700 (Thu, 25 Oct 2012) Log Message [Chromium] Unreviewed rebaseline after https://bugs.webkit.org/show_bug.cgi?id=99874. * platform/chromium-mac-lion/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added. * platform/chromium-mac-lion/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added. * platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png: * platform/chromium-mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png: * platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: * platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: * platform/chromium-win/svg/zoom/page/zoom-svg-float-border-padding-expected.png: * platform/chromium-win/svg/zoom/text/zoom-svg-float-border-padding-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png trunk/LayoutTests/platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-float-border-padding-expected.png trunk/LayoutTests/platform/chromium-win/svg/zoom/text/zoom-svg-float-border-padding-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac-lion/svg/zoom/page/zoom-svg-float-border-padding-expected.png trunk/LayoutTests/platform/chromium-mac-lion/svg/zoom/text/ trunk/LayoutTests/platform/chromium-mac-lion/svg/zoom/text/zoom-svg-float-border-padding-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (132476 => 132477) --- trunk/LayoutTests/ChangeLog 2012-10-25 12:47:42 UTC (rev 132476) +++ trunk/LayoutTests/ChangeLog 2012-10-25 13:05:04 UTC (rev 132477) @@ -1,3 +1,17 @@ +2012-10-25 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed rebaseline after https://bugs.webkit.org/show_bug.cgi?id=99874. + +* platform/chromium-mac-lion/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added. +* platform/chromium-mac-lion/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added. +* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png: +* platform/chromium-mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png: +* platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: +* platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: +* platform/chromium-win/svg/zoom/page/zoom-svg-float-border-padding-expected.png: +* platform/chromium-win/svg/zoom/text/zoom-svg-float-border-padding-expected.png: +* platform/chromium/TestExpectations: + 2012-10-25 Balazs Kelemen kbal...@webkit.org [Qt] Pixel tests need rebaseline Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132476 => 132477) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-25 12:47:42 UTC (rev 132476) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-25 13:05:04 UTC (rev 132477) @@ -2796,12 +2796,6 @@ crbug.com/83504 [ Win ] fast/css/custom-font-xheight.html [ Failure Pass Slow ] crbug.com/83504 [ Mac ] fast/css/custom-font-xheight.html [ Failure Pass ] -# Need rebaselining after 99874 -webkit.org/b/99874 svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml [ Pass ImageOnlyFailure ] -webkit.org/b/99874 svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml [ Pass ImageOnlyFailure ] -webkit.org/b/99874 svg/zoom/page/zoom-svg-float-border-padding.xml [ Pass ImageOnlyFailure ] -webkit.org/b/99874 svg/zoom/text/zoom-svg-float-border-padding.xml [ Pass ImageOnlyFailure ] - # New tests added in r87121 webkit.org/b/61169 [ Android Linux Win ] css3/images/optimize-contrast-canvas.html [ ImageOnlyFailure ] webkit.org/b/61169 [ Android Linux Win ] css3/images/optimize-contrast-image.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png (Binary files differ) Added: trunk/LayoutTests/platform/chromium-mac-lion/svg/zoom/page/zoom-svg-float-border-padding-expected.png (Binary files differ) Property changes on:
[webkit-changes] [132377] trunk
Title: [132377] trunk Revision 132377 Author fmal...@chromium.org Date 2012-10-24 11:13:57 -0700 (Wed, 24 Oct 2012) Log Message [Chromium] SVG repaint issues https://bugs.webkit.org/show_bug.cgi?id=99874 Reviewed by Levi Weintraub. Source/WebCore: RenderSVGRoot::paintReplaced() converts the container offsets to a relative transform, but in doing so it ends up accumulating subpixel rounding deltas twice: first for adjustedPaintOffset and second in localToParentTransform(). If coordinates are on half-pixel boundaries, the 2x rounding delta yields a full pixel drift and we end up painting at the wrong location. This can be avoided by using localToBorderBoxTransform() directly, which (unlike localToParentTransform()) doesn't perform rounding. No new tests: existing pixel results cover this change after rebaseline. * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paintReplaced): LayoutTests: * platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png: * platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png: * platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: * platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png trunk/LayoutTests/platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp Diff Modified: trunk/LayoutTests/ChangeLog (132376 => 132377) --- trunk/LayoutTests/ChangeLog 2012-10-24 18:10:28 UTC (rev 132376) +++ trunk/LayoutTests/ChangeLog 2012-10-24 18:13:57 UTC (rev 132377) @@ -1,3 +1,16 @@ +2012-10-24 Florin Malita fmal...@chromium.org + +[Chromium] SVG repaint issues +https://bugs.webkit.org/show_bug.cgi?id=99874 + +Reviewed by Levi Weintraub. + +* platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png: +* platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png: +* platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: +* platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: +* platform/chromium/TestExpectations: + 2012-10-24 Dana Jansens dan...@chromium.org Layout tests to verify scaled composited layers have crisp text Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132376 => 132377) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-24 18:10:28 UTC (rev 132376) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-24 18:13:57 UTC (rev 132377) @@ -2794,6 +2794,12 @@ crbug.com/83504 [ Win ] fast/css/custom-font-xheight.html [ Failure Pass Slow ] crbug.com/83504 [ Mac ] fast/css/custom-font-xheight.html [ Failure Pass ] +# Need rebaselining after 99874 +webkit.org/b/99874 svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml [ Pass ImageOnlyFailure ] +webkit.org/b/99874 svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml [ Pass ImageOnlyFailure ] +webkit.org/b/99874 svg/zoom/page/zoom-svg-float-border-padding.xml [ Pass ImageOnlyFailure ] +webkit.org/b/99874 svg/zoom/text/zoom-svg-float-border-padding.xml [ Pass ImageOnlyFailure ] + # New tests added in r87121 webkit.org/b/61169 [ Android Linux Win ] css3/images/optimize-contrast-canvas.html [ ImageOnlyFailure ] webkit.org/b/61169 [ Android Linux Win ] css3/images/optimize-contrast-image.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png (Binary files differ) Modified: trunk/Source/WebCore/ChangeLog (132376 => 132377) --- trunk/Source/WebCore/ChangeLog 2012-10-24 18:10:28 UTC (rev 132376) +++ trunk/Source/WebCore/ChangeLog 2012-10-24 18:13:57 UTC (rev 132377) @@ -1,3 +1,24 @@ +2012-10-24 Florin Malita fmal...@chromium.org + +[Chromium] SVG repaint issues +
[webkit-changes] [132069] trunk
Title: [132069] trunk Revision 132069 Author fmal...@chromium.org Date 2012-10-22 07:10:18 -0700 (Mon, 22 Oct 2012) Log Message Incorrect embedded SVG image sizing on first load https://bugs.webkit.org/show_bug.cgi?id=99489 Reviewed by Nikolas Zimmermann. Source/WebCore: RenderSVGImage::updateImageViewport() must be called after the image loader is finished, to ensure that a SVGImageCache::SizeAndScalesMap entry is created even if layout has already been performed. Test: svg/custom/svg-image-initial-size.html * rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged): LayoutTests: * svg/custom/svg-image-initial-size-expected.html: Added. * svg/custom/svg-image-initial-size.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp Added Paths trunk/LayoutTests/svg/custom/svg-image-initial-size-expected.html trunk/LayoutTests/svg/custom/svg-image-initial-size.html Diff Modified: trunk/LayoutTests/ChangeLog (132068 => 132069) --- trunk/LayoutTests/ChangeLog 2012-10-22 14:04:18 UTC (rev 132068) +++ trunk/LayoutTests/ChangeLog 2012-10-22 14:10:18 UTC (rev 132069) @@ -1,3 +1,13 @@ +2012-10-22 Florin Malita fmal...@chromium.org + +Incorrect embedded SVG image sizing on first load +https://bugs.webkit.org/show_bug.cgi?id=99489 + +Reviewed by Nikolas Zimmermann. + +* svg/custom/svg-image-initial-size-expected.html: Added. +* svg/custom/svg-image-initial-size.html: Added. + 2012-10-22 Christophe Dumez christophe.du...@intel.com [EFL][WK2] Skip plugins/npruntime/remove-property.html Added: trunk/LayoutTests/svg/custom/svg-image-initial-size-expected.html (0 => 132069) --- trunk/LayoutTests/svg/custom/svg-image-initial-size-expected.html (rev 0) +++ trunk/LayoutTests/svg/custom/svg-image-initial-size-expected.html 2012-10-22 14:10:18 UTC (rev 132069) @@ -0,0 +1,8 @@ +!DOCTYPE html +html + body style=margin: 0px; padding: 0px; +svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink version=1.1 width=600 height=600 + rect width=500px height=500px fill=green/ +/svg + /body +/html Added: trunk/LayoutTests/svg/custom/svg-image-initial-size.html (0 => 132069) --- trunk/LayoutTests/svg/custom/svg-image-initial-size.html (rev 0) +++ trunk/LayoutTests/svg/custom/svg-image-initial-size.html 2012-10-22 14:10:18 UTC (rev 132069) @@ -0,0 +1,15 @@ +!DOCTYPE html +html + !-- Test for https://bugs.webkit.org/show_bug.cgi?id=99489 -- + body style=margin: 0px; padding: 0px; +svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink version=1.1 width=600 height=600 + g transform=scale(5) +image id=img width=100px height=100px xlink:href="" + svg xmlns='http://www.w3.org/2000/svg' +rect width='100' height='100' fill='green'/ + /svg + / + /g +/svg + /body +/html Modified: trunk/Source/WebCore/ChangeLog (132068 => 132069) --- trunk/Source/WebCore/ChangeLog 2012-10-22 14:04:18 UTC (rev 132068) +++ trunk/Source/WebCore/ChangeLog 2012-10-22 14:10:18 UTC (rev 132069) @@ -1,3 +1,19 @@ +2012-10-22 Florin Malita fmal...@chromium.org + +Incorrect embedded SVG image sizing on first load +https://bugs.webkit.org/show_bug.cgi?id=99489 + +Reviewed by Nikolas Zimmermann. + +RenderSVGImage::updateImageViewport() must be called after the image loader is finished, +to ensure that a SVGImageCache::SizeAndScalesMap entry is created even if layout has +already been performed. + +Test: svg/custom/svg-image-initial-size.html + +* rendering/svg/RenderSVGImage.cpp: +(WebCore::RenderSVGImage::imageChanged): + 2012-10-22 Keishi Hattori kei...@webkit.org Remove monthFormatInLDML Modified: trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp (132068 => 132069) --- trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp 2012-10-22 14:04:18 UTC (rev 132068) +++ trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp 2012-10-22 14:10:18 UTC (rev 132069) @@ -179,6 +179,11 @@ // Eventually notify parent resources, that we've changed. RenderSVGResource::markForLayoutAndParentResourceInvalidation(this, false); +// Update the SVGImageCache sizeAndScales entry in case image loading finished after layout. +// (https://bugs.webkit.org/show_bug.cgi?id=99489) +m_objectBoundingBox = FloatRect(); +updateImageViewport(); + repaint(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [131987] trunk/LayoutTests
Title: [131987] trunk/LayoutTests Revision 131987 Author fmal...@chromium.org Date 2012-10-20 07:29:25 -0700 (Sat, 20 Oct 2012) Log Message Unreviewed rebaseline after http://trac.webkit.org/changeset/131974. * platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed. * platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed. * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: * platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added. * platform/chromium-mac-lion/svg/custom/js-late-pattern-creation-expected.png: Added. * platform/chromium-mac-lion/svg/custom/pattern-scaling-expected.png: Added. * platform/chromium-mac-lion/svg/custom/pattern-with-transformation-expected.png: Added. * platform/chromium-mac-lion/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added. * platform/chromium-mac-lion/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added. * platform/chromium-mac-snowleopard/svg/custom/pattern-scaling-expected.png: Added. * platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: * platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: * platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed. * platform/chromium-mac/svg/custom/pattern-scaling-expected.png: Added. * platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png: * platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added. * platform/chromium-win-xp/svg/custom/js-late-pattern-creation-expected.png: Added. * platform/chromium-win-xp/svg/custom/pattern-scaling-expected.png: Added. * platform/chromium-win-xp/svg/custom/pattern-with-transformation-expected.png: Added. * platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: * platform/chromium-win-xp/svg/transforms/text-with-pattern-with-svg-transform-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png trunk/LayoutTests/platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png trunk/LayoutTests/platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png trunk/LayoutTests/platform/chromium-win-xp/svg/transforms/text-with-pattern-with-svg-transform-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac/svg/custom/pattern-scaling-expected.png trunk/LayoutTests/platform/chromium-mac-lion/svg/W3C-SVG-1.1/ trunk/LayoutTests/platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png trunk/LayoutTests/platform/chromium-mac-lion/svg/custom/ trunk/LayoutTests/platform/chromium-mac-lion/svg/custom/js-late-pattern-creation-expected.png trunk/LayoutTests/platform/chromium-mac-lion/svg/custom/pattern-scaling-expected.png trunk/LayoutTests/platform/chromium-mac-lion/svg/custom/pattern-with-transformation-expected.png trunk/LayoutTests/platform/chromium-mac-lion/svg/transforms/ trunk/LayoutTests/platform/chromium-mac-lion/svg/transforms/text-with-pattern-inside-transformed-html-expected.png trunk/LayoutTests/platform/chromium-mac-lion/svg/transforms/text-with-pattern-with-svg-transform-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/pattern-scaling-expected.png trunk/LayoutTests/platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png trunk/LayoutTests/platform/chromium-win-xp/svg/custom/js-late-pattern-creation-expected.png trunk/LayoutTests/platform/chromium-win-xp/svg/custom/pattern-scaling-expected.png trunk/LayoutTests/platform/chromium-win-xp/svg/custom/pattern-with-transformation-expected.png Removed Paths trunk/LayoutTests/platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.png trunk/LayoutTests/platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (131986 => 131987) --- trunk/LayoutTests/ChangeLog 2012-10-20 10:58:42 UTC (rev 131986) +++ trunk/LayoutTests/ChangeLog 2012-10-20 14:29:25 UTC (rev 131987) @@ -1,3 +1,30 @@ +2012-10-20 Florin Malita fmal...@chromium.org + +Unreviewed rebaseline after http://trac.webkit.org/changeset/131974. + +*
[webkit-changes] [131994] trunk/LayoutTests
Title: [131994] trunk/LayoutTests Revision 131994 Author fmal...@chromium.org Date 2012-10-20 18:31:56 -0700 (Sat, 20 Oct 2012) Log Message [Chromium] Unreviewed rebaselines after http://trac.webkit.org/changeset/131974, take two. * platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt. * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt. * platform/chromium-mac-lion/svg/custom/pattern-scaling-expected.txt: Added. * platform/chromium-mac-snowleopard/svg/custom/pattern-scaling-expected.txt: Added. * platform/chromium-mac/svg/custom/pattern-scaling-expected.txt: Added. * platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Removed. * platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt. * platform/chromium-win-xp/svg/custom/js-late-pattern-creation-expected.png: Removed. * platform/chromium-win-xp/svg/custom/pattern-scaling-expected.txt: Added. * platform/chromium-win-xp/svg/custom/pattern-with-transformation-expected.png: Removed. * platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed. * platform/chromium-win-xp/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed. * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: * platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png: * platform/chromium-win/svg/custom/pattern-with-transformation-expected.png: * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: * platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt trunk/LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/pattern-with-transformation-expected.png trunk/LayoutTests/platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png trunk/LayoutTests/platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png Added Paths trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt trunk/LayoutTests/platform/chromium-mac/svg/custom/pattern-scaling-expected.txt trunk/LayoutTests/platform/chromium-mac-lion/svg/custom/pattern-scaling-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/pattern-scaling-expected.txt trunk/LayoutTests/platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt trunk/LayoutTests/platform/chromium-win-xp/svg/custom/pattern-scaling-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png trunk/LayoutTests/platform/chromium-win-xp/svg/custom/js-late-pattern-creation-expected.png trunk/LayoutTests/platform/chromium-win-xp/svg/custom/pattern-with-transformation-expected.png trunk/LayoutTests/platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png trunk/LayoutTests/platform/chromium-win-xp/svg/transforms/text-with-pattern-with-svg-transform-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (131993 => 131994) --- trunk/LayoutTests/ChangeLog 2012-10-20 23:08:07 UTC (rev 131993) +++ trunk/LayoutTests/ChangeLog 2012-10-21 01:31:56 UTC (rev 131994) @@ -1,3 +1,26 @@ +2012-10-20 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed rebaselines after http://trac.webkit.org/changeset/131974, take two. + +* platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt. +* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt. +* platform/chromium-mac-lion/svg/custom/pattern-scaling-expected.txt: Added. +* platform/chromium-mac-snowleopard/svg/custom/pattern-scaling-expected.txt: Added. +* platform/chromium-mac/svg/custom/pattern-scaling-expected.txt: Added. +* platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Removed. +* platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Copied from
[webkit-changes] [131974] trunk
Title: [131974] trunk Revision 131974 Author fmal...@chromium.org Date 2012-10-19 19:51:00 -0700 (Fri, 19 Oct 2012) Log Message Incorrect pattern scaling https://bugs.webkit.org/show_bug.cgi?id=99870 Reviewed by Dirk Schulze. Source/WebCore: The pattern space transform scale should reflect the tile_size(user space) to tile_image_size ratio, instead of tile_size to absolute_tile_size. Test: svg/custom/pattern-scaling.svg * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): LayoutTests: * platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png: * platform/chromium-linux/svg/custom/pattern-scaling-expected.png: Added. * platform/chromium-linux/svg/custom/pattern-scaling-expected.txt: Added. * platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png: * platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: * platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png: * platform/chromium/TestExpectations: * platform/efl/TestExpectations: * platform/gtk/TestExpectations: * platform/mac/TestExpectations: * platform/qt/TestExpectations: * svg/custom/pattern-scaling.svg: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png trunk/LayoutTests/platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/qt/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp Added Paths trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-scaling-expected.png trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-scaling-expected.txt trunk/LayoutTests/svg/custom/pattern-scaling.svg Diff Modified: trunk/LayoutTests/ChangeLog (131973 => 131974) --- trunk/LayoutTests/ChangeLog 2012-10-20 02:33:29 UTC (rev 131973) +++ trunk/LayoutTests/ChangeLog 2012-10-20 02:51:00 UTC (rev 131974) @@ -1,3 +1,23 @@ +2012-10-19 Florin Malita fmal...@chromium.org + +Incorrect pattern scaling +https://bugs.webkit.org/show_bug.cgi?id=99870 + +Reviewed by Dirk Schulze. + +* platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png: +* platform/chromium-linux/svg/custom/pattern-scaling-expected.png: Added. +* platform/chromium-linux/svg/custom/pattern-scaling-expected.txt: Added. +* platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png: +* platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: +* platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png: +* platform/chromium/TestExpectations: +* platform/efl/TestExpectations: +* platform/gtk/TestExpectations: +* platform/mac/TestExpectations: +* platform/qt/TestExpectations: +* svg/custom/pattern-scaling.svg: Added. + 2012-10-19 Levi Weintraub le...@chromium.org Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/webgl/array-bounds-clamping.html Modified: trunk/LayoutTests/platform/chromium/TestExpectations (131973 => 131974) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-20 02:33:29 UTC (rev 131973) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-20 02:51:00 UTC (rev 131974) @@ -2797,6 +2797,13 @@ crbug.com/83504 [ Win ] fast/css/custom-font-xheight.html [ Failure Pass Slow ] crbug.com/83504 [ Mac ] fast/css/custom-font-xheight.html [ Failure Pass ] +# Need rebaselining after 99870 +webkit.org/b/99870 svg/custom/js-late-pattern-creation.svg [ Pass ImageOnlyFailure ] +webkit.org/b/99870 svg/custom/pattern-skew-transformed.svg [ Pass ImageOnlyFailure ] +webkit.org/b/99870 svg/custom/pattern-with-transformation.svg [ Pass ImageOnlyFailure ] +webkit.org/b/99870 svg/transforms/text-with-pattern-inside-transformed-html.xhtml [ Pass ImageOnlyFailure ] +webkit.org/b/99870 svg/custom/pattern-scaling.svg [ Pass ImageOnlyFailure Missing ] + # Need rebaseline webkit.org/b/99818 fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html [ Pass ImageOnlyFailure Missing ] webkit.org/b/99818 fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html [ Pass ImageOnlyFailure ] Modified: trunk/LayoutTests/platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png (Binary files differ) Added:
[webkit-changes] [130780] trunk/Source/WebCore
Title: [130780] trunk/Source/WebCore
Revision 130780
Author fmal...@chromium.org
Date 2012-10-09 11:36:17 -0700 (Tue, 09 Oct 2012)
Log Message
SVGResources should use HashSetAtomicString instead of HashSetAtomicStringImpl*
https://bugs.webkit.org/show_bug.cgi?id=98683
Reviewed by Darin Adler.
Eric's notes:
SVGResources should use HashSetAtomicString instead of HashSetAtomicStringImpl*
They do basically the same thing, and the former is much more common (and less code). It's
also safe, on the off-chance that we're using AtomicStrings which might otherwise go away.
No new tests, refactoring.
* rendering/svg/SVGResources.cpp:
(WebCore::clipperFilterMaskerTags):
(WebCore::markerTags):
(WebCore::fillAndStrokeTags):
(WebCore::chainableResourceTags):
(WebCore::SVGResources::buildCachedResources):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGResources.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (130779 => 130780)
--- trunk/Source/WebCore/ChangeLog 2012-10-09 18:09:28 UTC (rev 130779)
+++ trunk/Source/WebCore/ChangeLog 2012-10-09 18:36:17 UTC (rev 130780)
@@ -1,3 +1,25 @@
+2012-10-09 Florin Malita fmal...@chromium.org
+
+SVGResources should use HashSetAtomicString instead of HashSetAtomicStringImpl*
+https://bugs.webkit.org/show_bug.cgi?id=98683
+
+Reviewed by Darin Adler.
+
+Eric's notes:
+
+SVGResources should use HashSetAtomicString instead of HashSetAtomicStringImpl*
+They do basically the same thing, and the former is much more common (and less code). It's
+also safe, on the off-chance that we're using AtomicStrings which might otherwise go away.
+
+No new tests, refactoring.
+
+* rendering/svg/SVGResources.cpp:
+(WebCore::clipperFilterMaskerTags):
+(WebCore::markerTags):
+(WebCore::fillAndStrokeTags):
+(WebCore::chainableResourceTags):
+(WebCore::SVGResources::buildCachedResources):
+
2012-10-09 Enrica Casucci enr...@apple.com
[chromium] fast/text/international/text-spliced-font.html and fast/writing-mode/Kusa-Makura-background-canvas.html
Modified: trunk/Source/WebCore/rendering/svg/SVGResources.cpp (130779 => 130780)
--- trunk/Source/WebCore/rendering/svg/SVGResources.cpp 2012-10-09 18:09:28 UTC (rev 130779)
+++ trunk/Source/WebCore/rendering/svg/SVGResources.cpp 2012-10-09 18:36:17 UTC (rev 130780)
@@ -44,46 +44,46 @@
{
}
-static HashSetAtomicStringImpl* clipperFilterMaskerTags()
+static HashSetAtomicString clipperFilterMaskerTags()
{
-DEFINE_STATIC_LOCAL(HashSetAtomicStringImpl*, s_tagList, ());
+DEFINE_STATIC_LOCAL(HashSetAtomicString, s_tagList, ());
if (s_tagList.isEmpty()) {
// container elements: http://www.w3.org/TR/SVG11/intro.html#TermContainerElement
// graphics elements : http://www.w3.org/TR/SVG11/intro.html#TermGraphicsElement
-s_tagList.add(SVGNames::aTag.localName().impl());
-s_tagList.add(SVGNames::circleTag.localName().impl());
-s_tagList.add(SVGNames::ellipseTag.localName().impl());
-s_tagList.add(SVGNames::glyphTag.localName().impl());
-s_tagList.add(SVGNames::gTag.localName().impl());
-s_tagList.add(SVGNames::imageTag.localName().impl());
-s_tagList.add(SVGNames::lineTag.localName().impl());
-s_tagList.add(SVGNames::markerTag.localName().impl());
-s_tagList.add(SVGNames::maskTag.localName().impl());
-s_tagList.add(SVGNames::missing_glyphTag.localName().impl());
-s_tagList.add(SVGNames::pathTag.localName().impl());
-s_tagList.add(SVGNames::polygonTag.localName().impl());
-s_tagList.add(SVGNames::polylineTag.localName().impl());
-s_tagList.add(SVGNames::rectTag.localName().impl());
-s_tagList.add(SVGNames::svgTag.localName().impl());
-s_tagList.add(SVGNames::textTag.localName().impl());
-s_tagList.add(SVGNames::useTag.localName().impl());
+s_tagList.add(SVGNames::aTag.localName());
+s_tagList.add(SVGNames::circleTag.localName());
+s_tagList.add(SVGNames::ellipseTag.localName());
+s_tagList.add(SVGNames::glyphTag.localName());
+s_tagList.add(SVGNames::gTag.localName());
+s_tagList.add(SVGNames::imageTag.localName());
+s_tagList.add(SVGNames::lineTag.localName());
+s_tagList.add(SVGNames::markerTag.localName());
+s_tagList.add(SVGNames::maskTag.localName());
+s_tagList.add(SVGNames::missing_glyphTag.localName());
+s_tagList.add(SVGNames::pathTag.localName());
+s_tagList.add(SVGNames::polygonTag.localName());
+s_tagList.add(SVGNames::polylineTag.localName());
+s_tagList.add(SVGNames::rectTag.localName());
+s_tagList.add(SVGNames::svgTag.localName());
+s_tagList.add(SVGNames::textTag.localName());
+s_tagList.add(SVGNames::useTag.localName());
// Not listed in the definitions is the
[webkit-changes] [130073] trunk/PerformanceTests
Title: [130073] trunk/PerformanceTests
Revision 130073
Author fmal...@chromium.org
Date 2012-10-01 13:53:45 -0700 (Mon, 01 Oct 2012)
Log Message
Add a performance test for nested use elements
https://bugs.webkit.org/show_bug.cgi?id=98047
Reviewed by Ryosuke Niwa.
Currently at ~5 runs per second on my workstation, but should go up significantly (100+)
after landing a fix for https://bugs.webkit.org/show_bug.cgi?id=97905.
* SVG/SvgNestedUse.html: Added.
Modified Paths
trunk/PerformanceTests/ChangeLog
Added Paths
trunk/PerformanceTests/SVG/SvgNestedUse.html
Diff
Modified: trunk/PerformanceTests/ChangeLog (130072 => 130073)
--- trunk/PerformanceTests/ChangeLog 2012-10-01 20:44:10 UTC (rev 130072)
+++ trunk/PerformanceTests/ChangeLog 2012-10-01 20:53:45 UTC (rev 130073)
@@ -1,3 +1,15 @@
+2012-10-01 Florin Malita fmal...@chromium.org
+
+Add a performance test for nested use elements
+https://bugs.webkit.org/show_bug.cgi?id=98047
+
+Reviewed by Ryosuke Niwa.
+
+Currently at ~5 runs per second on my workstation, but should go up significantly (100+)
+after landing a fix for https://bugs.webkit.org/show_bug.cgi?id=97905.
+
+* SVG/SvgNestedUse.html: Added.
+
2012-09-28 Ryosuke Niwa rn...@webkit.org
Add back test.runCount for runPerSecond as it's used by tests in fast/harness/perftests.
Added: trunk/PerformanceTests/SVG/SvgNestedUse.html (0 => 130073)
--- trunk/PerformanceTests/SVG/SvgNestedUse.html (rev 0)
+++ trunk/PerformanceTests/SVG/SvgNestedUse.html 2012-10-01 20:53:45 UTC (rev 130073)
@@ -0,0 +1,82 @@
+!DOCTYPE html
+html
+ head
+script src=""
+ /head
+ body
+div id=wrapper
+ svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
+defs
+ g id=unit
+polygon points=0,0 10,0 5,8.66025403784439/
+ /g
+
+ g id=q
+use id=q0 xlink:href="" x=10 y=0 fill=red/
+use id=q1 xlink:href="" transform=translate(10,0) rotate(60) fill=green/
+use id=q2 xlink:href="" transform=translate(10,0) rotate(120) fill=blue/
+use id=q3 xlink:href="" transform=rotate(60) translate(10,0) rotate(-60) fill=purple/
+ /g
+
+ g id=qq
+ use id=qq0 xlink:href="" x=20 y=0/
+ use id=qq1 xlink:href="" transform=translate(20,0) rotate(60)/
+ use id=qq2 xlink:href="" transform=translate(20,0) rotate(120)/
+ use id=qq3 xlink:href="" transform=rotate(60) translate(20,0) rotate(-60) scale(2) fill=purple/
+ /g
+
+ g id=qqq
+ use xlink:href="" x=40 y=0/
+ use xlink:href="" transform=translate(40,0) rotate(60)/
+ use xlink:href="" transform=translate(40,0) rotate(120)/
+ use xlink:href="" transform=rotate(60) translate(40,0) rotate(-60) scale(2)/
+ /g
+/defs
+
+use xlink:href=""
+g transform=translate(300 200)
+ rect width=70 height=26 stroke-width=1 fill=rgb(255,255,255) fill-opacity=1.000 stroke=rgb(0,0,0) stroke-opacity=1.000/
+ text id=FPS y=23 font-family=Verdana font-size=230/text
+/g
+ /svg
+/div
+
+script type=text/_javascript_
+var frame = 0;
+var times = [PerfTestRunner.now()];
+var unit = document.getElementById(unit);
+
+requestAnimationFrame =
+window['requestAnimationFrame'] ||
+window['webkitRequestAnimationFrame'] ||
+window['mozRequestAnimationFrame'] ||
+window['oRequestAnimationFrame'] ||
+window['msRequestAnimationFrame'] ||
+function(callback) {
+window.setTimeout(callback, 1000 / 60);
+};
+
+function newFrame() {
+times.push(PerfTestRunner.now());
+var avg = (times[times.length - 1] - times[0]) / (times.length - 1);
+while (times.length 10)
+times.shift();
+
+document.getElementById(FPS).textContent = (1000 / avg).toFixed(2);
+unit.setAttribute('transform', 'scale(' + (Math.abs(frame++ % 20 - 10) / 10) + ')');
+};
+
+function animate() {
+newFrame();
+requestAnimationFrame(animate);
+}
+
+if (window.testRunner) {
+PerfTestRunner.runPerSecond({ run: newFrame, done: function() {
+document.getElementById('wrapper').style.display = 'none';
+}});
+} else
+requestAnimationFrame(animate);
+/script
+ /body
+/html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129897] trunk
Title: [129897] trunk
Revision 129897
Author fmal...@chromium.org
Date 2012-09-28 08:24:41 -0700 (Fri, 28 Sep 2012)
Log Message
[Chromium] Incorrect resampling of clipped/masked images.
https://bugs.webkit.org/show_bug.cgi?id=97409
Reviewed by Stephen White.
Source/WebCore:
Currently, high-quality resampling is used for translate/scale-only transforms, but when
the scale is negative the resampling subset ends up positioned incorrectly.
ImageSkia.cpp:drawResampledBitmap needs to account for negative scaling factors, and apply
only absolute values when calculating the resampling subregion in bitmap coordinates.
Thanks p...@google.com for isolating the regression.
Test: svg/custom/clip-mask-negative-scale.svg
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::drawResampledBitmap):
LayoutTests:
* platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png: Added.
* platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* svg/custom/clip-mask-negative-scale.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp
Added Paths
trunk/LayoutTests/platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.txt
trunk/LayoutTests/svg/custom/clip-mask-negative-scale.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (129896 => 129897)
--- trunk/LayoutTests/ChangeLog 2012-09-28 14:55:07 UTC (rev 129896)
+++ trunk/LayoutTests/ChangeLog 2012-09-28 15:24:41 UTC (rev 129897)
@@ -1,3 +1,19 @@
+2012-09-28 Florin Malita fmal...@chromium.org
+
+[Chromium] Incorrect resampling of clipped/masked images.
+https://bugs.webkit.org/show_bug.cgi?id=97409
+
+Reviewed by Stephen White.
+
+* platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png: Added.
+* platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.txt: Added.
+* platform/chromium/TestExpectations:
+* platform/efl/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/qt/TestExpectations:
+* svg/custom/clip-mask-negative-scale.svg: Added.
+
2012-09-28 Stephen Chenney schen...@chromium.org
Unreviewed Chromium TestExpectation addition
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129896 => 129897)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-28 14:55:07 UTC (rev 129896)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-28 15:24:41 UTC (rev 129897)
@@ -2346,6 +2346,9 @@
webkit.org/b/60094 [ Debug ] fast/encoding/parser-tests-110.html [ Pass Timeout ]
webkit.org/b/60094 [ Debug ] fast/encoding/parser-tests-120.html [ Pass Timeout ]
+# Needs results
+webkit.org/b/97409 svg/custom/clip-mask-negative-scale.svg [ Missing Pass ]
+
# Flaky since creation because we lack testRunner.setSerializeHTTPLoads
webkit.org/b/57593 fast/preloader/document-write-2.html [ Failure ]
webkit.org/b/57593 fast/preloader/document-write.html [ Failure ]
Added: trunk/LayoutTests/platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png (0 => 129897)
--- trunk/LayoutTests/platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png 2012-09-28 15:24:41 UTC (rev 129897)
@@ -0,0 +1,37 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum af118e540de5a51e3ab33877466e0fa2}\xDB\xE4 IDATx\x9C\xED\xDD\x8C\xA4w} \xF0\xF7\xEC\xAF\xF3\xF9,\xA5\xCD\xC58\x8688\xC22`,l\x9CRى\\xE3ʡ
+$\xD0 +(\x92\xEB\xA4
+\xD4$U\x8AbH0\x8AD \x84\xE2\x88\xFAW\xEF 61
+\xAA-T \x9A\xD8Pb\xDFac\x8C]\xFC\xEBnw\xF6\xE9 \x93g\xB7\xB3;\xBBw\xF7\xD9ݙ\xD9\xD7Kh5\xF7\xCC3\xDF_\xCFg\xDF\xF3\xCC3\xEBN\x9A\xB0\x9A\xEA\x81\xEE\xA4S{@\x86]\x9AKo\xCAM\xDB\xDD
+\x9Ef\xD9o
+\xF5j]\x94\x8Bn\xCF\xED\xDB\xDD
+\x9E6\xB3\xDD
+ \x986 @1 \xA0\x98\x80 PL\xC0 (` \xB0 \x8A X \xC5, \x80b @1 \xA0\x98\x80 PL\xC0 (` \xB0 \x8A X \xC5, \x80b @1 \xA0\x98\x80 PL\xC0 (` \xB0 \x8A X \xC5, \x80b @1 \xA0\x98\x80 PL\xC0 (` \xB0 \x8A X \xC5, \x80b @1 \xA0\x98\x80 PL\xC0 (` \xB0 \x8A X \xC5, \x80b @1 \xA0\x98\x80 PL\xC0 (` \xB0 \x8A
[webkit-changes] [129949] trunk/LayoutTests
Title: [129949] trunk/LayoutTests
Revision 129949
Author fmal...@chromium.org
Date 2012-09-28 14:15:39 -0700 (Fri, 28 Sep 2012)
Log Message
[Chromium] Unreviewed rebaseline for svg/custom/clip-mask-negative-scale.svg
* platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png: Added.
* platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png: Added.
* platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png: Added.
* platform/chromium/svg/custom/clip-mask-negative-scale-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.txt.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium/svg/custom/clip-mask-negative-scale-expected.txt
trunk/LayoutTests/platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png
trunk/LayoutTests/platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png
Removed Paths
trunk/LayoutTests/platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (129948 => 129949)
--- trunk/LayoutTests/ChangeLog 2012-09-28 20:57:47 UTC (rev 129948)
+++ trunk/LayoutTests/ChangeLog 2012-09-28 21:15:39 UTC (rev 129949)
@@ -1,3 +1,12 @@
+2012-09-28 Florin Malita fmal...@chromium.org
+
+[Chromium] Unreviewed rebaseline for svg/custom/clip-mask-negative-scale.svg
+
+* platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png: Added.
+* platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png: Added.
+* platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png: Added.
+* platform/chromium/svg/custom/clip-mask-negative-scale-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.txt.
+
2012-09-28 Filip Pizlo fpi...@apple.com
ASSERTION in m_graph[tailNodeIndex].op() == Flush || m_graph[tailNodeIndex].op() == SetLocal on plus.google.com
Copied: trunk/LayoutTests/platform/chromium/svg/custom/clip-mask-negative-scale-expected.txt (from rev 129948, trunk/LayoutTests/platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.txt) (0 => 129949)
--- trunk/LayoutTests/platform/chromium/svg/custom/clip-mask-negative-scale-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/svg/custom/clip-mask-negative-scale-expected.txt 2012-09-28 21:15:39 UTC (rev 129949)
@@ -0,0 +1,46 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderSVGRoot {svg} at (0,0) size 667x404
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+ RenderSVGResourceClipper {clipPath} [id=clip] [clipPathUnits=userSpaceOnUse]
+RenderSVGPath {path} at (280,280) size 120x120 [fill={[type=SOLID] [color=#00]}] [data="" 10 10 L 100 10 L 100 100 L 10 100 Z]
+ RenderSVGResourceMasker {mask} [id=mask] [maskUnits=objectBoundingBox] [maskContentUnits=userSpaceOnUse]
+RenderSVGRect {rect} at (280,280) size 120x120 [fill={[type=SOLID] [color=#FF]}] [x=10.00] [y=10.00] [width=90.00] [height=90.00]
+ RenderSVGImage {image} at (280,280) size 267x267
+RenderSVGContainer {g} at (146,146) size 121x121 [transform={m=((1.00,0.00)(0.00,1.00)) t=(-100.00,-100.00)}]
+ [masker=mask] RenderSVGResourceMasker {mask} at (10,10) size 90x90
+ RenderSVGContainer {use} at (146,146) size 268x268
+RenderSVGImage {image} at (146,146) size 268x268
+RenderSVGContainer {g} at (0,0) size 120x120 [transform={m=((-1.00,0.00)(0.00,-1.00)) t=(-100.00,-100.00)}]
+ [masker=mask] RenderSVGResourceMasker {mask} at (10,10) size 90x90
+ RenderSVGContainer {use} at (0,0) size 121x121
+RenderSVGImage {image} at (0,0) size 121x121
+RenderSVGContainer {g} at (0,146) size 120x121 [transform={m=((-1.00,0.00)(0.00,1.00)) t=(-100.00,-100.00)}]
+ [masker=mask] RenderSVGResourceMasker {mask} at (10,10) size 90x90
+ RenderSVGContainer {use} at (0,146) size 121x268
+RenderSVGImage {image} at (0,146) size 121x268
+RenderSVGContainer {g} at (146,0) size 121x120 [transform={m=((1.00,0.00)(0.00,-1.00)) t=(-100.00,-100.00)}]
+ [masker=mask] RenderSVGResourceMasker {mask} at (10,10) size 90x90
+ RenderSVGContainer {use} at (146,0) size 268x121
+RenderSVGImage {image} at (146,0) size 268x121
+RenderSVGContainer {g} at (400,0) size 267x267 [transform={m=((1.00,0.00)(0.00,1.00)) t=(300.00,0.00)}]
+ RenderSVGContainer {g} at (546,146) size 121x121 [transform={m=((1.00,0.00)(0.00,1.00)) t=(-100.00,-100.00)}]
+[clipPath=clip] RenderSVGResourceClipper {clipPath} at (10,10) size 90x90
+RenderSVGContainer {use} at (546,146) size 254x268
+ RenderSVGImage {image} at
[webkit-changes] [129804] trunk/Tools
Title: [129804] trunk/Tools
Revision 129804
Author fmal...@chromium.org
Date 2012-09-27 14:55:47 -0700 (Thu, 27 Sep 2012)
Log Message
[Perftest] PerfTestRunner exception when using nested git checkouts
https://bugs.webkit.org/show_bug.cgi?id=97796
Reviewed by Ryosuke Niwa.
In order to support separate Chromium vs. WebKit git trees, PerfTestsRunner needs to
instantiate per-repository SCM objects when collecting revision information.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_results_dict):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
Diff
Modified: trunk/Tools/ChangeLog (129803 => 129804)
--- trunk/Tools/ChangeLog 2012-09-27 21:54:20 UTC (rev 129803)
+++ trunk/Tools/ChangeLog 2012-09-27 21:55:47 UTC (rev 129804)
@@ -1,3 +1,16 @@
+2012-09-27 Florin Malita fmal...@chromium.org
+
+[Perftest] PerfTestRunner exception when using nested git checkouts
+https://bugs.webkit.org/show_bug.cgi?id=97796
+
+Reviewed by Ryosuke Niwa.
+
+In order to support separate Chromium vs. WebKit git trees, PerfTestsRunner needs to
+instantiate per-repository SCM objects when collecting revision information.
+
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+(PerfTestsRunner._generate_results_dict):
+
2012-09-27 Sudarsana Nagineni sudarsana.nagin...@intel.com
[Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (129803 => 129804)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2012-09-27 21:54:20 UTC (rev 129803)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2012-09-27 21:55:47 UTC (rev 129804)
@@ -36,6 +36,7 @@
import time
from webkitpy.common import find_files
+from webkitpy.common.checkout.scm.detection import SCMDetector
from webkitpy.common.host import Host
from webkitpy.common.net.file_uploader import FileUploader
from webkitpy.performance_tests.perftest import PerfTestFactory
@@ -205,7 +206,8 @@
if description:
contents['description'] = description
for (name, path) in self._port.repository_paths():
-contents[name + '-revision'] = self._host.scm().svn_revision(path)
+scm = SCMDetector(self._host.filesystem, self._host.executive).detect_scm_system(path) or self._host.scm()
+contents[name + '-revision'] = scm.svn_revision(path)
# FIXME: Add --branch or auto-detect the branch we're in
for key, value in {'timestamp': int(timestamp), 'branch': self._default_branch, 'platform': platform,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128702] trunk
Title: [128702] trunk
Revision 128702
Author fmal...@chromium.org
Date 2012-09-15 22:03:43 -0700 (Sat, 15 Sep 2012)
Log Message
use not working when the SVG doc is embedded as object data
https://bugs.webkit.org/show_bug.cgi?id=96816
Reviewed by Dirk Schulze.
Source/WebCore:
Updated SVGURIReference::isExternalURIReference() to correctly classify fragment-only URIs.
Also, since the fragment-only test is cheap, it should be the first thing to try.
Test: svg/custom/object-data-href.html
* svg/SVGURIReference.h:
(WebCore::SVGURIReference::isExternalURIReference):
LayoutTests:
* svg/custom/object-data-href-expected.html: Added.
* svg/custom/object-data-href.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGURIReference.h
Added Paths
trunk/LayoutTests/svg/custom/object-data-href-expected.html
trunk/LayoutTests/svg/custom/object-data-href.html
Diff
Modified: trunk/LayoutTests/ChangeLog (128701 => 128702)
--- trunk/LayoutTests/ChangeLog 2012-09-16 04:34:58 UTC (rev 128701)
+++ trunk/LayoutTests/ChangeLog 2012-09-16 05:03:43 UTC (rev 128702)
@@ -1,3 +1,13 @@
+2012-09-15 Florin Malita fmal...@chromium.org
+
+use not working when the SVG doc is embedded as object data
+https://bugs.webkit.org/show_bug.cgi?id=96816
+
+Reviewed by Dirk Schulze.
+
+* svg/custom/object-data-href-expected.html: Added.
+* svg/custom/object-data-href.html: Added.
+
2012-09-15 Andreas Kling kl...@webkit.org
REGRESSION(r127438): Google Docs to renders text too small.
Added: trunk/LayoutTests/svg/custom/object-data-href-expected.html (0 => 128702)
--- trunk/LayoutTests/svg/custom/object-data-href-expected.html (rev 0)
+++ trunk/LayoutTests/svg/custom/object-data-href-expected.html 2012-09-16 05:03:43 UTC (rev 128702)
@@ -0,0 +1,10 @@
+!DOCTYPE html
+html
+body style=margin: 0px; padding: 0px;
+ object data=""
+svg xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink'
+ rect id='rect' width='100' height='100' fill='green'/
+/svg
+ /object
+/body
+/html
Added: trunk/LayoutTests/svg/custom/object-data-href.html (0 => 128702)
--- trunk/LayoutTests/svg/custom/object-data-href.html (rev 0)
+++ trunk/LayoutTests/svg/custom/object-data-href.html 2012-09-16 05:03:43 UTC (rev 128702)
@@ -0,0 +1,14 @@
+!DOCTYPE html
+html
+body style=margin: 0px; padding: 0px;
+ !-- Test for https://bugs.webkit.org/show_bug.cgi?id=96816 --
+ object data=""
+svg xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink'
+ defs
+rect id='rect' width='100' height='100' fill='green'/
+ /defs
+ use xlink:href=''/
+/svg
+ /object
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (128701 => 128702)
--- trunk/Source/WebCore/ChangeLog 2012-09-16 04:34:58 UTC (rev 128701)
+++ trunk/Source/WebCore/ChangeLog 2012-09-16 05:03:43 UTC (rev 128702)
@@ -1,3 +1,18 @@
+2012-09-15 Florin Malita fmal...@chromium.org
+
+use not working when the SVG doc is embedded as object data
+https://bugs.webkit.org/show_bug.cgi?id=96816
+
+Reviewed by Dirk Schulze.
+
+Updated SVGURIReference::isExternalURIReference() to correctly classify fragment-only URIs.
+Also, since the fragment-only test is cheap, it should be the first thing to try.
+
+Test: svg/custom/object-data-href.html
+
+* svg/SVGURIReference.h:
+(WebCore::SVGURIReference::isExternalURIReference):
+
2012-09-15 Benjamin Poulain benja...@webkit.org
Fix the build with WTF URL
Modified: trunk/Source/WebCore/svg/SVGURIReference.h (128701 => 128702)
--- trunk/Source/WebCore/svg/SVGURIReference.h 2012-09-16 04:34:58 UTC (rev 128701)
+++ trunk/Source/WebCore/svg/SVGURIReference.h 2012-09-16 05:03:43 UTC (rev 128702)
@@ -43,14 +43,14 @@
static inline bool isExternalURIReference(const String uri, Document* document)
{
-// If the URI matches our documents URL, early exit, we're dealing with a local reference.
+// Fragment-only URIs are always internal
+if (uri.startsWith('#'))
+return false;
+
+// If the URI matches our documents URL, we're dealing with a local reference.
ASSERT(document);
KURL url = ""
-if (equalIgnoringFragmentIdentifier(url, document-url()))
-return false;
-
-// If the URI doesn't contain a base string, just see if it starts with a fragment-identifier.
-return uri.find('#') != notFound;
+return !equalIgnoringFragmentIdentifier(url, document-url());
}
protected:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128309] trunk
Title: [128309] trunk
Revision 128309
Author fmal...@chromium.org
Date 2012-09-12 07:36:26 -0700 (Wed, 12 Sep 2012)
Log Message
getScreenCTM returns different values depending on zoom
https://bugs.webkit.org/show_bug.cgi?id=96361
Reviewed by Dirk Schulze.
Source/WebCore:
SVGSVGElement::localCoordinateSpaceTransform() needs to adjust for the
zoom level (which is already factored into CSS coordinates) at the
SVG/HTML boundary.
Test: svg/zoom/page/zoom-get-screen-ctm.html
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
LayoutTests:
* svg/zoom/page/zoom-get-screen-ctm-expected.txt: Added.
* svg/zoom/page/zoom-get-screen-ctm.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGSVGElement.cpp
Added Paths
trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm-expected.txt
trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm.html
Diff
Modified: trunk/LayoutTests/ChangeLog (128308 => 128309)
--- trunk/LayoutTests/ChangeLog 2012-09-12 14:35:03 UTC (rev 128308)
+++ trunk/LayoutTests/ChangeLog 2012-09-12 14:36:26 UTC (rev 128309)
@@ -1,3 +1,13 @@
+2012-09-12 Florin Malita fmal...@chromium.org
+
+getScreenCTM returns different values depending on zoom
+https://bugs.webkit.org/show_bug.cgi?id=96361
+
+Reviewed by Dirk Schulze.
+
+* svg/zoom/page/zoom-get-screen-ctm-expected.txt: Added.
+* svg/zoom/page/zoom-get-screen-ctm.html: Added.
+
2012-09-12 Allan Sandfeld Jensen allan.jen...@nokia.com
Unreviewed gardening. These tests should have been unskipped when fixed.
Added: trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm-expected.txt (0 => 128309)
--- trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm-expected.txt 2012-09-12 14:36:26 UTC (rev 128309)
@@ -0,0 +1,14 @@
+This test checks getScreenCTM() on zoomed pages.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS CTM1 is 1, 0, 0, 1, 0, 100
+PASS CTM2 is 1, 0, 0, 1, 100, 200
+PASS CTM3 is 1, 0, 0, 1, 200, 300
+PASS CTM4 is 1, 0, 0, 1, 300, 400
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm.html (0 => 128309)
--- trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm.html (rev 0)
+++ trunk/LayoutTests/svg/zoom/page/zoom-get-screen-ctm.html 2012-09-12 14:36:26 UTC (rev 128309)
@@ -0,0 +1,51 @@
+!DOCTYPE html
+html
+body style=margin: 0px; padding: 0px; _onload_=runRepaintTest()
+ div style=width: 100px; height: 100px;/div
+ svg id=svg1 xmlns=http://www.w3.org/2000/svg width=400 height=400
+rect width=100 height=100 fill=green/
+svg id=svg2 x=100 y=100 width=300 height=300
+ rect width=100 height=100 fill=green/
+ svg id=svg3 x=100 y=100 width=200 height=200
+rect width=100 height=100 fill=green/
+svg id=svg4 x=100 y=100 width=100 height=100
+ rect width=100 height=100 fill=green/
+/svg
+ /svg
+/svg
+ /svg
+
+script
+ var zoomCount = 2;
+
+ if (window.testRunner) {
+testRunner.waitUntilDone();
+window.postZoomCallback = executeTest;
+ }
+
+ function ctmToString(ctm) {
+return [ ctm.a, ctm.b, ctm.c, ctm.d, ctm.e, ctm.f ].join(', ');
+ }
+
+ function executeTest() {
+CTM1 = ctmToString(document.getElementById('svg1').getScreenCTM());
+CTM2 = ctmToString(document.getElementById('svg2').getScreenCTM());
+CTM3 = ctmToString(document.getElementById('svg3').getScreenCTM());
+CTM4 = ctmToString(document.getElementById('svg4').getScreenCTM());
+
+description(This test checks getScreenCTM() on zoomed pages.);
+
+shouldBeEqualToString('CTM1', '1, 0, 0, 1, 0, 100');
+shouldBeEqualToString('CTM2', '1, 0, 0, 1, 100, 200');
+shouldBeEqualToString('CTM3', '1, 0, 0, 1, 200, 300');
+shouldBeEqualToString('CTM4', '1, 0, 0, 1, 300, 400');
+debug('');
+ }
+
+/script
+script src=""
+script src=""
+script src=""
+
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (128308 => 128309)
--- trunk/Source/WebCore/ChangeLog 2012-09-12 14:35:03 UTC (rev 128308)
+++ trunk/Source/WebCore/ChangeLog 2012-09-12 14:36:26 UTC (rev 128309)
@@ -1,3 +1,19 @@
+2012-09-12 Florin Malita fmal...@chromium.org
+
+getScreenCTM returns different values depending on zoom
+https://bugs.webkit.org/show_bug.cgi?id=96361
+
+Reviewed by Dirk Schulze.
+
+SVGSVGElement::localCoordinateSpaceTransform() needs to adjust for the
+zoom level (which is already factored into CSS coordinates) at the
+SVG/HTML boundary.
+
+Test: svg/zoom/page/zoom-get-screen-ctm.html
+
+* svg/SVGSVGElement.cpp:
+(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
+
2012-09-12 Simon Hausmann simon.hausm...@nokia.com
[Qt]
[webkit-changes] [126993] trunk
Title: [126993] trunk Revision 126993 Author fmal...@chromium.org Date 2012-08-29 05:24:49 -0700 (Wed, 29 Aug 2012) Log Message Incorrect large-area clipping https://bugs.webkit.org/show_bug.cgi?id=95197 Reviewed by Nikolas Zimmermann. Source/WebCore: ImageBuffers allocated for clipping and masking are clamped to kMaxImageBufferSize max (4096x4096). In order to properly account for the scaling factor introduced by this clamping, the repaintRect translation component needs to be pushed after the scaling transform. Tests: svg/custom/clamped-masking-clipping-expected.svg svg/custom/clamped-masking-clipping.svg * rendering/svg/SVGRenderingContext.cpp: (WebCore::SVGRenderingContext::createImageBuffer): LayoutTests: * svg/custom/clamped-masking-clipping-expected.svg: Added. * svg/custom/clamped-masking-clipping.svg: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp Added Paths trunk/LayoutTests/svg/custom/clamped-masking-clipping-expected.svg trunk/LayoutTests/svg/custom/clamped-masking-clipping.svg Diff Modified: trunk/LayoutTests/ChangeLog (126992 => 126993) --- trunk/LayoutTests/ChangeLog 2012-08-29 12:18:53 UTC (rev 126992) +++ trunk/LayoutTests/ChangeLog 2012-08-29 12:24:49 UTC (rev 126993) @@ -1,3 +1,13 @@ +2012-08-29 Florin Malita fmal...@chromium.org + +Incorrect large-area clipping +https://bugs.webkit.org/show_bug.cgi?id=95197 + +Reviewed by Nikolas Zimmermann. + +* svg/custom/clamped-masking-clipping-expected.svg: Added. +* svg/custom/clamped-masking-clipping.svg: Added. + 2012-08-29 Dominik Röttsches dominik.rottsc...@intel.com [EFL] Move known crash issue to TestExpectations Added: trunk/LayoutTests/svg/custom/clamped-masking-clipping-expected.svg (0 => 126993) --- trunk/LayoutTests/svg/custom/clamped-masking-clipping-expected.svg (rev 0) +++ trunk/LayoutTests/svg/custom/clamped-masking-clipping-expected.svg 2012-08-29 12:24:49 UTC (rev 126993) @@ -0,0 +1,4 @@ +svg xmlns=http://www.w3.org/2000/svg width=1 height=400 +rect x=100 width=100 height=100 fill=green/ +rect x=300 width=100 height=100 fill=green/ +/svg Added: trunk/LayoutTests/svg/custom/clamped-masking-clipping.svg (0 => 126993) --- trunk/LayoutTests/svg/custom/clamped-masking-clipping.svg (rev 0) +++ trunk/LayoutTests/svg/custom/clamped-masking-clipping.svg 2012-08-29 12:24:49 UTC (rev 126993) @@ -0,0 +1,33 @@ +svg xmlns=http://www.w3.org/2000/svg width=1 height=400 + !-- test for https://bugs.webkit.org/show_bug.cgi?id=95197 -- + defs +mask id=mask + !-- forcing a repaintRect offset -- + rect x=100 width=1 height=1 fill=black/ + rect x=200 width=8092 height=100 fill=white/ +/mask + +clipPath id=clip1 + !-- forcing clipping via masking -- + path d=M 0 0 V 100 H 1 V 0 Z/ +/clipPath + +clipPath id=clip2 clip-path=url(#clip1) + path d=M 100 0 H 200 V 200 H 8292 V 0 Z/ +/clipPath + +mask id=crop + rect width=300 height=100 fill=white/ +/mask + /defs + + g mask=url(#crop) transform=translate(-100, 0) +rect width=1 height=400 fill=red mask=url(#mask)/ +rect x=200 width=100 height=100 fill=green/ + /g + + g mask=url(#crop) transform=translate(100, 0) +rect width=1 height=400 fill=red clip-path=url(#clip2)/ +rect x=200 width=100 height=100 fill=green/ + /g +/svg Modified: trunk/Source/WebCore/ChangeLog (126992 => 126993) --- trunk/Source/WebCore/ChangeLog 2012-08-29 12:18:53 UTC (rev 126992) +++ trunk/Source/WebCore/ChangeLog 2012-08-29 12:24:49 UTC (rev 126993) @@ -1,3 +1,21 @@ +2012-08-29 Florin Malita fmal...@chromium.org + +Incorrect large-area clipping +https://bugs.webkit.org/show_bug.cgi?id=95197 + +Reviewed by Nikolas Zimmermann. + +ImageBuffers allocated for clipping and masking are clamped to kMaxImageBufferSize max +(4096x4096). In order to properly account for the scaling factor introduced by this +clamping, the repaintRect translation component needs to be pushed after the scaling +transform. + +Tests: svg/custom/clamped-masking-clipping-expected.svg + svg/custom/clamped-masking-clipping.svg + +* rendering/svg/SVGRenderingContext.cpp: +(WebCore::SVGRenderingContext::createImageBuffer): + 2012-08-29 Yury Semikhatsky yu...@chromium.org Web Inspector: unsafe static_cast in RetainedDOMInfo::IsEquivalent Modified: trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp (126992 => 126993) --- trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp 2012-08-29 12:18:53 UTC (rev 126992) +++ trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp 2012-08-29 12:24:49 UTC (rev 126993) @@ -205,15 +205,11 @@ GraphicsContext* imageContext = image-context();
[webkit-changes] [126997] trunk/Tools
Title: [126997] trunk/Tools Revision 126997 Author fmal...@chromium.org Date 2012-08-29 06:15:26 -0700 (Wed, 29 Aug 2012) Log Message Unreviewed, updating Kelly Norton's email address at his request. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (126996 => 126997) --- trunk/Tools/ChangeLog 2012-08-29 13:00:34 UTC (rev 126996) +++ trunk/Tools/ChangeLog 2012-08-29 13:15:26 UTC (rev 126997) @@ -1,3 +1,9 @@ +2012-08-29 Florin Malita fmal...@chromium.org + +Unreviewed, updating Kelly Norton's email address at his request. + +* Scripts/webkitpy/common/config/committers.py: + 2012-08-29 Kristóf Kosztyó kkris...@inf.u-szeged.hu [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (126996 => 126997) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-08-29 13:00:34 UTC (rev 126996) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-08-29 13:15:26 UTC (rev 126997) @@ -300,7 +300,7 @@ Committer(Justin Schuh, jsc...@chromium.org, jschuh), Committer(Kaustubh Atrawalkar, [kaust...@motorola.com], silverroots), Committer(Keishi Hattori, kei...@webkit.org, keishi), -Committer(Kelly Norton, knor...@google.com), +Committer(Kelly Norton, knor...@alum.mit.edu), Committer(Ken Buchanan, ke...@chromium.org, kenrb), Committer(Kenichi Ishibashi, ba...@chromium.org, bashi), Committer(Kenji Imasaki, imas...@chromium.org, imasaki), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [126657] trunk
Title: [126657] trunk
Revision 126657
Author fmal...@chromium.org
Date 2012-08-24 17:06:39 -0700 (Fri, 24 Aug 2012)
Log Message
ASSERTION FAILED: !attached() in WebCore::Node::attach()
https://bugs.webkit.org/show_bug.cgi?id=94650
Reviewed by Abhishek Arya.
Source/WebCore:
Prevent SVGTests::handleAttributeChange() from attaching elements with detached parents.
Test: svg/custom/system-language-crash.html
* svg/SVGTests.cpp:
(WebCore::SVGTests::handleAttributeChange):
LayoutTests:
* svg/custom/system-language-crash-expected.txt: Added.
* svg/custom/system-language-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGTests.cpp
Added Paths
trunk/LayoutTests/svg/custom/system-language-crash-expected.txt
trunk/LayoutTests/svg/custom/system-language-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (126656 => 126657)
--- trunk/LayoutTests/ChangeLog 2012-08-24 23:58:43 UTC (rev 126656)
+++ trunk/LayoutTests/ChangeLog 2012-08-25 00:06:39 UTC (rev 126657)
@@ -1,3 +1,13 @@
+2012-08-24 Florin Malita fmal...@chromium.org
+
+ASSERTION FAILED: !attached() in WebCore::Node::attach()
+https://bugs.webkit.org/show_bug.cgi?id=94650
+
+Reviewed by Abhishek Arya.
+
+* svg/custom/system-language-crash-expected.txt: Added.
+* svg/custom/system-language-crash.html: Added.
+
2012-08-24 Glenn Adams gl...@skynav.com
CSSStyleDeclaration.cssText should not contain extraneous whitespace in final delimiter
Added: trunk/LayoutTests/svg/custom/system-language-crash-expected.txt (0 => 126657)
--- trunk/LayoutTests/svg/custom/system-language-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/system-language-crash-expected.txt 2012-08-25 00:06:39 UTC (rev 126657)
@@ -0,0 +1,2 @@
+PASS: did not crash.
+
Added: trunk/LayoutTests/svg/custom/system-language-crash.html (0 => 126657)
--- trunk/LayoutTests/svg/custom/system-language-crash.html (rev 0)
+++ trunk/LayoutTests/svg/custom/system-language-crash.html 2012-08-25 00:06:39 UTC (rev 126657)
@@ -0,0 +1,20 @@
+!DOCTYPE html
+html
+body _onload_=runTest()
+ !-- Test for https://bugs.webkit.org/show_bug.cgi?id=94650 --
+ divPASS: did not crash./div
+ svg id=svg xmlns=http://www.w3.org/2000/svg
+text id=text/text
+ /svg
+
+ script
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+function runTest() {
+ document.getElementById('svg').systemLanguage.initialize(X);
+ document.getElementById('text').systemLanguage.clear();
+}
+ /script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (126656 => 126657)
--- trunk/Source/WebCore/ChangeLog 2012-08-24 23:58:43 UTC (rev 126656)
+++ trunk/Source/WebCore/ChangeLog 2012-08-25 00:06:39 UTC (rev 126657)
@@ -1,3 +1,17 @@
+2012-08-24 Florin Malita fmal...@chromium.org
+
+ASSERTION FAILED: !attached() in WebCore::Node::attach()
+https://bugs.webkit.org/show_bug.cgi?id=94650
+
+Reviewed by Abhishek Arya.
+
+Prevent SVGTests::handleAttributeChange() from attaching elements with detached parents.
+
+Test: svg/custom/system-language-crash.html
+
+* svg/SVGTests.cpp:
+(WebCore::SVGTests::handleAttributeChange):
+
2012-08-24 Glenn Adams gl...@skynav.com
CSSStyleDeclaration.cssText should not contain extraneous whitespace in final delimiter
Modified: trunk/Source/WebCore/svg/SVGTests.cpp (126656 => 126657)
--- trunk/Source/WebCore/svg/SVGTests.cpp 2012-08-24 23:58:43 UTC (rev 126656)
+++ trunk/Source/WebCore/svg/SVGTests.cpp 2012-08-25 00:06:39 UTC (rev 126657)
@@ -155,11 +155,14 @@
return false;
if (!targetElement-inDocument())
return true;
+
bool valid = targetElement-isValid();
-if (valid !targetElement-attached())
+bool attached = targetElement-attached();
+if (valid !attached targetElement-parentNode()-attached())
targetElement-attach();
-if (!valid targetElement-attached())
+else if (!valid attached)
targetElement-detach();
+
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [126205] trunk
Title: [126205] trunk
Revision 126205
Author fmal...@chromium.org
Date 2012-08-21 16:07:54 -0700 (Tue, 21 Aug 2012)
Log Message
ASSERT triggered in SVGTRefTargetEventListener::handleEvent()
https://bugs.webkit.org/show_bug.cgi?id=94487
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The current way of tracking tref target elements by id can leave stale event listeners
under certain circumstances. This patch switches to storing a target RefPtr instead
to avoid an id lookup which may not return the original/attached element.
Test: svg/custom/tref-stale-listener-crash.html
* svg/SVGTRefElement.cpp:
(SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::isAttached): use m_target instead of an explicit bool.
(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::attach): save a target RefPtr instead of an id.
(WebCore::SVGTRefTargetEventListener::detach): detach the target element directly without
going through a lookup.
(WebCore::SVGTRefTargetEventListener::handleEvent):
(WebCore::SVGTRefElement::updateReferencedText): use an explicit target pointer instead of
the id-based lookup.
(WebCore::SVGTRefElement::buildPendingResource):
* svg/SVGTRefElement.h:
(SVGTRefElement):
LayoutTests:
* svg/custom/tref-stale-listener-crash-expected.txt: Added.
* svg/custom/tref-stale-listener-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGTRefElement.cpp
trunk/Source/WebCore/svg/SVGTRefElement.h
Added Paths
trunk/LayoutTests/svg/custom/tref-stale-listener-crash-expected.txt
trunk/LayoutTests/svg/custom/tref-stale-listener-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (126204 => 126205)
--- trunk/LayoutTests/ChangeLog 2012-08-21 23:06:06 UTC (rev 126204)
+++ trunk/LayoutTests/ChangeLog 2012-08-21 23:07:54 UTC (rev 126205)
@@ -1,3 +1,13 @@
+2012-08-21 Florin Malita fmal...@chromium.org
+
+ASSERT triggered in SVGTRefTargetEventListener::handleEvent()
+https://bugs.webkit.org/show_bug.cgi?id=94487
+
+Reviewed by Nikolas Zimmermann.
+
+* svg/custom/tref-stale-listener-crash-expected.txt: Added.
+* svg/custom/tref-stale-listener-crash.html: Added.
+
2012-08-21 Brady Eidson beid...@apple.com
Rebaseline failing fast/canvas tests for Mountain Lion
Added: trunk/LayoutTests/svg/custom/tref-stale-listener-crash-expected.txt (0 => 126205)
--- trunk/LayoutTests/svg/custom/tref-stale-listener-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/tref-stale-listener-crash-expected.txt 2012-08-21 23:07:54 UTC (rev 126205)
@@ -0,0 +1,4 @@
+
+
+
+PASS: did not crash.
Added: trunk/LayoutTests/svg/custom/tref-stale-listener-crash.html (0 => 126205)
--- trunk/LayoutTests/svg/custom/tref-stale-listener-crash.html (rev 0)
+++ trunk/LayoutTests/svg/custom/tref-stale-listener-crash.html 2012-08-21 23:07:54 UTC (rev 126205)
@@ -0,0 +1,26 @@
+!DOCTYPE html
+html
+body _onload_=crash()
+ !-- Test for https://bugs.webkit.org/show_bug.cgi?id=94487 --
+ input/
+ svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
+g
+ tref xlink:href=""
+ g id=target/g
+/g
+ /svg
+ input/
+ divPASS: did not crash./div
+
+ script
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+function crash() {
+ document.designMode='on';
+ document.execCommand('selectall');
+ document.execCommand('FormatBlock', false, ''+'pre');
+}
+ /script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (126204 => 126205)
--- trunk/Source/WebCore/ChangeLog 2012-08-21 23:06:06 UTC (rev 126204)
+++ trunk/Source/WebCore/ChangeLog 2012-08-21 23:07:54 UTC (rev 126205)
@@ -1,3 +1,30 @@
+2012-08-21 Florin Malita fmal...@chromium.org
+
+ASSERT triggered in SVGTRefTargetEventListener::handleEvent()
+https://bugs.webkit.org/show_bug.cgi?id=94487
+
+Reviewed by Nikolas Zimmermann.
+
+The current way of tracking tref target elements by id can leave stale event listeners
+under certain circumstances. This patch switches to storing a target RefPtr instead
+to avoid an id lookup which may not return the original/attached element.
+
+Test: svg/custom/tref-stale-listener-crash.html
+
+* svg/SVGTRefElement.cpp:
+(SVGTRefTargetEventListener):
+(WebCore::SVGTRefTargetEventListener::isAttached): use m_target instead of an explicit bool.
+(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
+(WebCore::SVGTRefTargetEventListener::attach): save a target RefPtr instead of an id.
+(WebCore::SVGTRefTargetEventListener::detach): detach the target element directly without
+going through a lookup.
+(WebCore::SVGTRefTargetEventListener::handleEvent):
+(WebCore::SVGTRefElement::updateReferencedText): use an
[webkit-changes] [125608] trunk
Title: [125608] trunk
Revision 125608
Author fmal...@chromium.org
Date 2012-08-14 14:33:56 -0700 (Tue, 14 Aug 2012)
Log Message
beginElement() does not observe updated animation attributes
https://bugs.webkit.org/show_bug.cgi?id=93972
Reviewed by Dirk Schulze.
Source/WebCore:
The SVG animation attributes 'from', 'to' and 'by' should be registered as supported
SVGSMILElement attributes in order to trigger animationAttributeChanged() on dynamic
updates.
Test: svg/animations/updated-attributes.html
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::updateAnimation):
Minor optimization - avoid recalculating animationMode().
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::isSupportedAttribute):
Register 'from', 'to' and 'by' as supported SVGSMILElement attributes.
LayoutTests:
* svg/animations/updated-attributes-expected.txt: Added.
* svg/animations/updated-attributes.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGAnimationElement.cpp
trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp
Added Paths
trunk/LayoutTests/svg/animations/updated-attributes-expected.txt
trunk/LayoutTests/svg/animations/updated-attributes.html
Diff
Modified: trunk/LayoutTests/ChangeLog (125607 => 125608)
--- trunk/LayoutTests/ChangeLog 2012-08-14 21:33:21 UTC (rev 125607)
+++ trunk/LayoutTests/ChangeLog 2012-08-14 21:33:56 UTC (rev 125608)
@@ -1,3 +1,13 @@
+2012-08-14 Florin Malita fmal...@chromium.org
+
+beginElement() does not observe updated animation attributes
+https://bugs.webkit.org/show_bug.cgi?id=93972
+
+Reviewed by Dirk Schulze.
+
+* svg/animations/updated-attributes-expected.txt: Added.
+* svg/animations/updated-attributes.html: Added.
+
2012-08-14 Roger Fong roger_f...@apple.com
Rebaseline fast/box-sizing/box-sizing.html and compositing/overflow/clip-descendents.html.
Added: trunk/LayoutTests/svg/animations/updated-attributes-expected.txt (0 => 125608)
--- trunk/LayoutTests/svg/animations/updated-attributes-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/animations/updated-attributes-expected.txt 2012-08-14 21:33:56 UTC (rev 125608)
@@ -0,0 +1,2 @@
+PASS: animated width is 100
+
Added: trunk/LayoutTests/svg/animations/updated-attributes.html (0 => 125608)
--- trunk/LayoutTests/svg/animations/updated-attributes.html (rev 0)
+++ trunk/LayoutTests/svg/animations/updated-attributes.html 2012-08-14 21:33:56 UTC (rev 125608)
@@ -0,0 +1,36 @@
+html
+body
+ !-- Test for https://bugs.webkit.org/show_bug.cgi?id=93972 --
+ div id=result/div
+
+ svg xmlns=http://www.w3.org/2000/svg
+rect id=rect height=100 fill=green
+ animate id=animation attributeName=width from=10 to=100 begin=0s dur=indefinite fill=freeze /
+/rect
+ /svg
+
+script
+ if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+ }
+
+ function check() {
+var width = document.getElementById('rect').width.animVal.value;
+document.getElementById('result').innerHTML = (width == 100 ? PASS: : FAIL: ) + 'animated width is ' + width;
+
+if (window.testRunner)
+ testRunner.notifyDone();
+ }
+
+ window.setTimeout(function() {
+var ani = document.getElementById('animation');
+ani.setAttribute(from, 100);
+ani.beginElement();
+
+window.setTimeout(function() { check(); }, 0);
+ }, 0);
+/script
+/body
+/html
+
Modified: trunk/Source/WebCore/ChangeLog (125607 => 125608)
--- trunk/Source/WebCore/ChangeLog 2012-08-14 21:33:21 UTC (rev 125607)
+++ trunk/Source/WebCore/ChangeLog 2012-08-14 21:33:56 UTC (rev 125608)
@@ -1,3 +1,24 @@
+2012-08-14 Florin Malita fmal...@chromium.org
+
+beginElement() does not observe updated animation attributes
+https://bugs.webkit.org/show_bug.cgi?id=93972
+
+Reviewed by Dirk Schulze.
+
+The SVG animation attributes 'from', 'to' and 'by' should be registered as supported
+SVGSMILElement attributes in order to trigger animationAttributeChanged() on dynamic
+updates.
+
+Test: svg/animations/updated-attributes.html
+
+* svg/SVGAnimationElement.cpp:
+(WebCore::SVGAnimationElement::updateAnimation):
+Minor optimization - avoid recalculating animationMode().
+
+* svg/animation/SVGSMILElement.cpp:
+(WebCore::SVGSMILElement::isSupportedAttribute):
+Register 'from', 'to' and 'by' as supported SVGSMILElement attributes.
+
2012-08-14 Filip Spacek fspa...@rim.com
[BlackBerry] Don't crash on OOM in AC
Modified: trunk/Source/WebCore/svg/SVGAnimationElement.cpp (125607 => 125608)
--- trunk/Source/WebCore/svg/SVGAnimationElement.cpp 2012-08-14 21:33:21 UTC (rev 125607)
+++ trunk/Source/WebCore/svg/SVGAnimationElement.cpp 2012-08-14 21:33:56 UTC (rev 125608)
@@ -574,8 +574,9 @@
return;
float effectivePercent;
-
[webkit-changes] [125454] trunk
Title: [125454] trunk Revision 125454 Author fmal...@chromium.org Date 2012-08-13 14:49:18 -0700 (Mon, 13 Aug 2012) Log Message Unreviewed, rolling out r125422. http://trac.webkit.org/changeset/125422 https://bugs.webkit.org/show_bug.cgi?id=93902 Broke the Android canary build (Requested by fmalita on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2012-08-13 Source/WebKit/chromium: * WebKitUnitTests.gyp: Tools: * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKitUnitTests.gyp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (125453 => 125454) --- trunk/Source/WebKit/chromium/ChangeLog 2012-08-13 21:42:11 UTC (rev 125453) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-13 21:49:18 UTC (rev 125454) @@ -1,3 +1,14 @@ +2012-08-13 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r125422. +http://trac.webkit.org/changeset/125422 +https://bugs.webkit.org/show_bug.cgi?id=93902 + +Broke the Android canary build (Requested by fmalita on +#webkit). + +* WebKitUnitTests.gyp: + 2012-08-13 Leandro Gracia Gil leandrogra...@chromium.org [Chromium] Fix nits in the find-in-page match rects API Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (125453 => 125454) --- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-13 21:42:11 UTC (rev 125453) +++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-13 21:49:18 UTC (rev 125454) @@ -183,8 +183,6 @@ '-DANDROID_TOOLCHAIN=(android_toolchain)', '--ant-args', '-DPRODUCT_DIR=(ant_build_out)', -'--ant-args', -'-DCHROMIUM_SRC=(chromium_src_dir)', '--sdk-build=(sdk_build)', '--app_abi', '(android_app_abi)', Modified: trunk/Tools/ChangeLog (125453 => 125454) --- trunk/Tools/ChangeLog 2012-08-13 21:42:11 UTC (rev 125453) +++ trunk/Tools/ChangeLog 2012-08-13 21:49:18 UTC (rev 125454) @@ -1,3 +1,15 @@ +2012-08-13 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r125422. +http://trac.webkit.org/changeset/125422 +https://bugs.webkit.org/show_bug.cgi?id=93902 + +Broke the Android canary build (Requested by fmalita on +#webkit). + +* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: +* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: + 2012-08-13 Raphael Kubo da Costa rak...@webkit.org [CMake] Remove glib-related Find modules and write single new one instead. Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (125453 => 125454) --- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-08-13 21:42:11 UTC (rev 125453) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-08-13 21:49:18 UTC (rev 125454) @@ -500,8 +500,6 @@ '-DANDROID_TOOLCHAIN=(android_toolchain)', '--ant-args', '-DPRODUCT_DIR=(ant_build_out)', -'--ant-args', -'-DCHROMIUM_SRC=(chromium_src_dir)', '--sdk-build=(sdk_build)', '--app_abi', '(android_app_abi)', Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp (125453 => 125454) --- trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp 2012-08-13 21:42:11 UTC (rev 125453) +++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp 2012-08-13 21:49:18 UTC (rev 125454) @@ -143,8 +143,6 @@ '-DANDROID_TOOLCHAIN=(android_toolchain)', '--ant-args', '-DPRODUCT_DIR=(ant_build_out)', -'--ant-args', -'-DCHROMIUM_SRC=(chromium_src_dir)', '--sdk-build=(sdk_build)', '--app_abi', '(android_app_abi)', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125305] trunk/Source/WebCore
Title: [125305] trunk/Source/WebCore Revision 125305 Author fmal...@chromium.org Date 2012-08-10 11:40:46 -0700 (Fri, 10 Aug 2012) Log Message Unreviewed gardening: build fix for 32bit platforms after 125294. * css/StyleResolver.cpp: (RuleData): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/StyleResolver.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (125304 => 125305) --- trunk/Source/WebCore/ChangeLog 2012-08-10 18:35:37 UTC (rev 125304) +++ trunk/Source/WebCore/ChangeLog 2012-08-10 18:40:46 UTC (rev 125305) @@ -1,3 +1,10 @@ +2012-08-10 Florin Malita fmal...@chromium.org + +Unreviewed gardening: build fix for 32bit platforms after 125294. + +* css/StyleResolver.cpp: +(RuleData): + 2012-08-10 Takashi Sakamoto ta...@google.com box-shadow creates incorrect shadow when border-radius is too large Modified: trunk/Source/WebCore/css/StyleResolver.cpp (125304 => 125305) --- trunk/Source/WebCore/css/StyleResolver.cpp 2012-08-10 18:35:37 UTC (rev 125304) +++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-08-10 18:40:46 UTC (rev 125305) @@ -223,18 +223,18 @@ private: StyleRule* m_rule; -unsigned m_selectorIndex : 12; +uint64_t m_selectorIndex : 12; // This number was picked fairly arbitrarily. We can probably lower it if we need to. // Some simple testing showed 100,000 RuleData's on large sites. -unsigned m_position : 20; -unsigned m_specificity : 24; -unsigned m_hasFastCheckableSelector : 1; -unsigned m_hasMultipartSelector : 1; -unsigned m_hasRightmostSelectorMatchingHTMLBasedOnRuleHash : 1; -unsigned m_containsUncommonAttributeSelector : 1; -unsigned m_linkMatchType : 2; // SelectorChecker::LinkMatchMask -unsigned m_hasDocumentSecurityOrigin : 1; -unsigned m_isInRegionRule : 1; +uint64_t m_position : 20; +uint64_t m_specificity : 24; +uint64_t m_hasFastCheckableSelector : 1; +uint64_t m_hasMultipartSelector : 1; +uint64_t m_hasRightmostSelectorMatchingHTMLBasedOnRuleHash : 1; +uint64_t m_containsUncommonAttributeSelector : 1; +uint64_t m_linkMatchType : 2; // SelectorChecker::LinkMatchMask +uint64_t m_hasDocumentSecurityOrigin : 1; +uint64_t m_isInRegionRule : 1; // Use plain array instead of a Vector to minimize memory overhead. unsigned m_descendantSelectorIdentifierHashes[maximumIdentifierCount]; }; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125323] trunk/Source/WebKit/chromium
Title: [125323] trunk/Source/WebKit/chromium
Revision 125323
Author fmal...@chromium.org
Date 2012-08-10 13:30:45 -0700 (Fri, 10 Aug 2012)
Log Message
Unreviewed, rolling out r125310.
http://trac.webkit.org/changeset/125310
https://bugs.webkit.org/show_bug.cgi?id=93739
The DEPS roll broke Android. One does not simply break
Android. (Requested by fmalita_ on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-08-10
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125322 => 125323)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-10 20:21:57 UTC (rev 125322)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-10 20:30:45 UTC (rev 125323)
@@ -1,5 +1,16 @@
2012-08-10 Sheriff Bot webkit.review@gmail.com
+Unreviewed, rolling out r125310.
+http://trac.webkit.org/changeset/125310
+https://bugs.webkit.org/show_bug.cgi?id=93739
+
+The DEPS roll broke Android. One does not simply break
+Android. (Requested by fmalita_ on #webkit).
+
+* DEPS:
+
+2012-08-10 Sheriff Bot webkit.review@gmail.com
+
Unreviewed. Rolled DEPS.
* DEPS:
Modified: trunk/Source/WebKit/chromium/DEPS (125322 => 125323)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-10 20:21:57 UTC (rev 125322)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-10 20:30:45 UTC (rev 125323)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '150986'
+ 'chromium_rev': '150169'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125328] trunk/LayoutTests
Title: [125328] trunk/LayoutTests Revision 125328 Author fmal...@chromium.org Date 2012-08-10 14:42:57 -0700 (Fri, 10 Aug 2012) Log Message [Chromium] Updated results for fast/borders/border-shadow-large-radius.html. Unreviewed gardening. * platform/chromium-win/fast/borders/border-shadow-large-radius-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-win/fast/borders/border-shadow-large-radius-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (125327 => 125328) --- trunk/LayoutTests/ChangeLog 2012-08-10 21:34:00 UTC (rev 125327) +++ trunk/LayoutTests/ChangeLog 2012-08-10 21:42:57 UTC (rev 125328) @@ -1,3 +1,11 @@ +2012-08-10 Florin Malita fmal...@chromium.org + +[Chromium] Updated results for fast/borders/border-shadow-large-radius.html. + +Unreviewed gardening. + +* platform/chromium-win/fast/borders/border-shadow-large-radius-expected.png: Added. + 2012-08-10 Zan Dobersek zandober...@gmail.com Unreviewed GTK gardening. Added: trunk/LayoutTests/platform/chromium-win/fast/borders/border-shadow-large-radius-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/fast/borders/border-shadow-large-radius-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125333] trunk/Source/WebCore
Title: [125333] trunk/Source/WebCore
Revision 125333
Author fmal...@chromium.org
Date 2012-08-10 15:41:51 -0700 (Fri, 10 Aug 2012)
Log Message
Improved RuleData packing on some 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=93737
Reviewed by Andreas Kling.
Certain 32-bit plarforms use an 8-byte alignment for uint64_t. We can save 4 bytes per
object on these platforms by using two naturally-aligning unsigned ints instead.
* css/StyleResolver.cpp:
(RuleData):
(SameSizeAsRuleData):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (125332 => 125333)
--- trunk/Source/WebCore/ChangeLog 2012-08-10 22:17:57 UTC (rev 125332)
+++ trunk/Source/WebCore/ChangeLog 2012-08-10 22:41:51 UTC (rev 125333)
@@ -1,3 +1,17 @@
+2012-08-10 Florin Malita fmal...@chromium.org
+
+Improved RuleData packing on some 32-bit platforms
+https://bugs.webkit.org/show_bug.cgi?id=93737
+
+Reviewed by Andreas Kling.
+
+Certain 32-bit plarforms use an 8-byte alignment for uint64_t. We can save 4 bytes per
+object on these platforms by using two naturally-aligning unsigned ints instead.
+
+* css/StyleResolver.cpp:
+(RuleData):
+(SameSizeAsRuleData):
+
2012-08-10 Max Vujovic mvujo...@adobe.com
[CSS Shaders] Add blend mode and composite op to compiled program cache key
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (125332 => 125333)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2012-08-10 22:17:57 UTC (rev 125332)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-08-10 22:41:51 UTC (rev 125333)
@@ -223,26 +223,27 @@
private:
StyleRule* m_rule;
-uint64_t m_selectorIndex : 12;
+unsigned m_selectorIndex : 12;
// This number was picked fairly arbitrarily. We can probably lower it if we need to.
// Some simple testing showed 100,000 RuleData's on large sites.
-uint64_t m_position : 20;
-uint64_t m_specificity : 24;
-uint64_t m_hasFastCheckableSelector : 1;
-uint64_t m_hasMultipartSelector : 1;
-uint64_t m_hasRightmostSelectorMatchingHTMLBasedOnRuleHash : 1;
-uint64_t m_containsUncommonAttributeSelector : 1;
-uint64_t m_linkMatchType : 2; // SelectorChecker::LinkMatchMask
-uint64_t m_hasDocumentSecurityOrigin : 1;
-uint64_t m_isInRegionRule : 1;
+unsigned m_position : 20;
+unsigned m_specificity : 24;
+unsigned m_hasFastCheckableSelector : 1;
+unsigned m_hasMultipartSelector : 1;
+unsigned m_hasRightmostSelectorMatchingHTMLBasedOnRuleHash : 1;
+unsigned m_containsUncommonAttributeSelector : 1;
+unsigned m_linkMatchType : 2; // SelectorChecker::LinkMatchMask
+unsigned m_hasDocumentSecurityOrigin : 1;
+unsigned m_isInRegionRule : 1;
// Use plain array instead of a Vector to minimize memory overhead.
unsigned m_descendantSelectorIdentifierHashes[maximumIdentifierCount];
};
struct SameSizeAsRuleData {
void* a;
-uint64_t b;
-unsigned c[4];
+unsigned b;
+unsigned c;
+unsigned d[4];
};
COMPILE_ASSERT(sizeof(RuleData) == sizeof(SameSizeAsRuleData), RuleData_should_stay_small);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125175] trunk/LayoutTests
Title: [125175] trunk/LayoutTests
Revision 125175
Author fmal...@chromium.org
Date 2012-08-09 08:49:58 -0700 (Thu, 09 Aug 2012)
Log Message
[Chromium] Unreviewed gardening: updated results for 125167.
Patch by Florin Malita fmal...@chromium.org on 2012-08-09
* platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
* platform/chromium-mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
* platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
* platform/chromium/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt
trunk/LayoutTests/platform/chromium-mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (125174 => 125175)
--- trunk/LayoutTests/ChangeLog 2012-08-09 15:13:56 UTC (rev 125174)
+++ trunk/LayoutTests/ChangeLog 2012-08-09 15:49:58 UTC (rev 125175)
@@ -1,3 +1,12 @@
+2012-08-09 Florin Malita fmal...@chromium.org
+
+[Chromium] Unreviewed gardening: updated results for 125167.
+
+* platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
+* platform/chromium-mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
+* platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
+* platform/chromium/TestExpectations:
+
2012-08-09 Pavel Feldman pfeld...@chromium.org
Web Inspector: generate preview for the objects dumped into the console upon logging.
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (125174 => 125175)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-09 15:13:56 UTC (rev 125174)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-09 15:49:58 UTC (rev 125175)
@@ -3492,4 +3492,4 @@
// Tests requiring rebaseling afer bug 93475
BUGWK93475 : fast/block/float/overhanging-tall-block.html = TEXT
BUGWK93475 : fast/html/details-writing-mode.html = IMAGE
-BUGWK93475 : svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml = TEXT
+
Modified: trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt (125174 => 125175)
--- trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt 2012-08-09 15:13:56 UTC (rev 125174)
+++ trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt 2012-08-09 15:49:58 UTC (rev 125175)
@@ -33,10 +33,10 @@
text run at (408,327) width 4:
RenderText {#text} at (0,0) size 0x0
layer at (420,48) size 202x302
- RenderSVGRoot {svg} at (420,48) size 203x288
+ RenderSVGRoot {svg} at (420,48) size 202x287
RenderSVGText {text} at (5,265) size 162x19 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 162x19
chunk 1 text run 1 at (5.00,280.00) startOffset 0 endOffset 24 width 162.00: +Accelerated Compositing
-RenderSVGContainer {g} at (421,49) size 201x201
- RenderSVGRect {rect} at (421,149) size 101x101 [fill={[type=PATTERN] [id=pattern]}] [x=0.00] [y=100.00] [width=100.00] [height=100.00]
- RenderSVGRect {rect} at (521,49) size 101x101 [fill={[type=PATTERN] [id=pattern]}] [x=100.00] [y=0.00] [width=100.00] [height=100.00]
+RenderSVGContainer {g} at (421,49) size 200x200
+ RenderSVGRect {rect} at (421,149) size 100x100 [fill={[type=PATTERN] [id=pattern]}] [x=0.00] [y=100.00] [width=100.00] [height=100.00]
+ RenderSVGRect {rect} at (521,49) size 100x100 [fill={[type=PATTERN] [id=pattern]}] [x=100.00] [y=0.00] [width=100.00] [height=100.00]
Modified: trunk/LayoutTests/platform/chromium-mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt (125174 => 125175)
--- trunk/LayoutTests/platform/chromium-mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt 2012-08-09 15:13:56 UTC (rev 125174)
+++ trunk/LayoutTests/platform/chromium-mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt 2012-08-09 15:49:58 UTC (rev 125175)
@@ -33,10 +33,10 @@
text run at (408,324) width 4:
RenderText {#text} at (0,0) size 0x0
layer at (420,44) size 202x302
- RenderSVGRoot {svg} at (420,44) size 203x288
+ RenderSVGRoot {svg} at (420,44) size 202x287
RenderSVGText {text} at (5,266) size 169x18 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 169x18
chunk 1 text run 1 at (5.00,280.00) startOffset 0 endOffset 24 width 169.00: +Accelerated Compositing
-RenderSVGContainer {g} at (421,45) size 201x201
- RenderSVGRect {rect} at (421,145) size 101x101
[webkit-changes] [125177] trunk/LayoutTests
Title: [125177] trunk/LayoutTests Revision 125177 Author fmal...@chromium.org Date 2012-08-09 09:11:04 -0700 (Thu, 09 Aug 2012) Log Message [Chromium] Unreviewed gardening: updated Win results for 125160. Patch by Florin Malita fmal...@chromium.org on 2012-08-09 * platform/chromium-win/svg/custom/use-detach-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/svg/custom/use-detach-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (125176 => 125177) --- trunk/LayoutTests/ChangeLog 2012-08-09 16:10:45 UTC (rev 125176) +++ trunk/LayoutTests/ChangeLog 2012-08-09 16:11:04 UTC (rev 125177) @@ -1,5 +1,11 @@ 2012-08-09 Florin Malita fmal...@chromium.org +[Chromium] Unreviewed gardening: updated Win results for 125160. + +* platform/chromium-win/svg/custom/use-detach-expected.png: + +2012-08-09 Florin Malita fmal...@chromium.org + [Chromium] Unreviewed gardening: updated results for 125167. * platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Modified: trunk/LayoutTests/platform/chromium-win/svg/custom/use-detach-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125180] trunk/LayoutTests
Title: [125180] trunk/LayoutTests Revision 125180 Author fmal...@chromium.org Date 2012-08-09 10:10:02 -0700 (Thu, 09 Aug 2012) Log Message [Chromium] Unreviewed gardening: updated expectations for console-format-collections.html. Patch by Florin Malita fmal...@chromium.org on 2012-08-09 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (125179 => 125180) --- trunk/LayoutTests/ChangeLog 2012-08-09 16:22:05 UTC (rev 125179) +++ trunk/LayoutTests/ChangeLog 2012-08-09 17:10:02 UTC (rev 125180) @@ -1,5 +1,11 @@ 2012-08-09 Florin Malita fmal...@chromium.org +[Chromium] Unreviewed gardening: updated expectations for console-format-collections.html. + +* platform/chromium/TestExpectations: + +2012-08-09 Florin Malita fmal...@chromium.org + [Chromium] Unreviewed gardening: updated Win results for 125160. * platform/chromium-win/svg/custom/use-detach-expected.png: Modified: trunk/LayoutTests/platform/chromium/TestExpectations (125179 => 125180) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-09 16:22:05 UTC (rev 125179) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-09 17:10:02 UTC (rev 125180) @@ -3413,6 +3413,9 @@ // Fails since creation in 122663 BUGWK91372 WIN : css2.1/20110323/vertical-align-boxes-001.htm = IMAGE +// Fails on Win +BUGWK93624 WIN : inspector/console/console-format-collections.html = TEXT + // Times out in DRT, but works in chrome BUGWK92776 SKIP : storage/indexeddb/intversion-delete-in-upgradeneeded.html = PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125190] trunk/LayoutTests
Title: [125190] trunk/LayoutTests Revision 125190 Author fmal...@chromium.org Date 2012-08-09 11:46:19 -0700 (Thu, 09 Aug 2012) Log Message [Chromium] Updated expectations for script-change-externalResourcesRequired-while-loading.svg Unreviewed gardening. Patch by Florin Malita fmal...@chromium.org on 2012-08-09 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (125189 => 125190) --- trunk/LayoutTests/ChangeLog 2012-08-09 18:41:05 UTC (rev 125189) +++ trunk/LayoutTests/ChangeLog 2012-08-09 18:46:19 UTC (rev 125190) @@ -1,3 +1,11 @@ +2012-08-09 Florin Malita fmal...@chromium.org + +[Chromium] Updated expectations for script-change-externalResourcesRequired-while-loading.svg + +Unreviewed gardening. + +* platform/chromium/TestExpectations: + 2012-08-09 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com [EFL] Gardening after r125102 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (125189 => 125190) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-09 18:41:05 UTC (rev 125189) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-09 18:46:19 UTC (rev 125190) @@ -1290,7 +1290,8 @@ BUGWK85107 : svg/as-image/svg-as-relative-image-with-explicit-size.html = PASS IMAGE BUGWK85107 : svg/as-image/animated-svg-as-image.html = PASS IMAGE -BUGWK93589 SLOW SNOWLEOPARD DEBUG : svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg = PASS +// Times out on debug builds +BUGWK93589 LINUX SNOWLEOPARD DEBUG : svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg = TIMEOUT PASS TEXT // - // End SVG TESTS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125106] trunk/LayoutTests
Title: [125106] trunk/LayoutTests Revision 125106 Author fmal...@chromium.org Date 2012-08-08 16:19:42 -0700 (Wed, 08 Aug 2012) Log Message [Chromium] Unreviewed gardening: compositing/plugins/no-backing-store.html yields incorrect results. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (125105 => 125106) --- trunk/LayoutTests/ChangeLog 2012-08-08 23:14:58 UTC (rev 125105) +++ trunk/LayoutTests/ChangeLog 2012-08-08 23:19:42 UTC (rev 125106) @@ -1,3 +1,9 @@ +2012-08-08 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed gardening: compositing/plugins/no-backing-store.html yields incorrect results. + +* platform/chromium/TestExpectations: + 2012-08-08 Dean Jackson d...@apple.com REGRESSION (r124416): fast/forms/basic-selects.html failing on Lion Debug Tests Modified: trunk/LayoutTests/platform/chromium/TestExpectations (125105 => 125106) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-08 23:14:58 UTC (rev 125105) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-08 23:19:42 UTC (rev 125106) @@ -2619,6 +2619,8 @@ BUGWK65453 MAC : fast/css/outline-auto-empty-rects.html = IMAGE +BUGWK93546 : compositing/plugins/no-backing-store.html = PASS TEXT + // For some reason, these tests are running as pixel tests most of the time instead of dumping as text. BUGWK74694 : http/tests/cache/history-only-cached-subresource-loads.html = MISSING PASS BUGWK74694 : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = MISSING PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125109] trunk/LayoutTests
Title: [125109] trunk/LayoutTests Revision 125109 Author fmal...@chromium.org Date 2012-08-08 16:36:00 -0700 (Wed, 08 Aug 2012) Log Message [Chromium] Unreviewed gardening: Chromium results for compositing/repaint/newly-composited-on-scroll.html. * platform/chromium-mac/compositing/repaint/newly-composited-on-scroll-expected.png: Added. * platform/chromium-win/compositing/repaint/newly-composited-on-scroll-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-mac/compositing/repaint/newly-composited-on-scroll-expected.png trunk/LayoutTests/platform/chromium-win/compositing/repaint/newly-composited-on-scroll-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (125108 => 125109) --- trunk/LayoutTests/ChangeLog 2012-08-08 23:27:47 UTC (rev 125108) +++ trunk/LayoutTests/ChangeLog 2012-08-08 23:36:00 UTC (rev 125109) @@ -1,5 +1,12 @@ 2012-08-08 Florin Malita fmal...@chromium.org +[Chromium] Unreviewed gardening: Chromium results for compositing/repaint/newly-composited-on-scroll.html. + +* platform/chromium-mac/compositing/repaint/newly-composited-on-scroll-expected.png: Added. +* platform/chromium-win/compositing/repaint/newly-composited-on-scroll-expected.png: Added. + +2012-08-08 Florin Malita fmal...@chromium.org + [Chromium] Unreviewed gardening: compositing/plugins/no-backing-store.html yields incorrect results. * platform/chromium/TestExpectations: Added: trunk/LayoutTests/platform/chromium-mac/compositing/repaint/newly-composited-on-scroll-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac/compositing/repaint/newly-composited-on-scroll-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/compositing/repaint/newly-composited-on-scroll-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/compositing/repaint/newly-composited-on-scroll-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124895] trunk/Source/WebCore
Title: [124895] trunk/Source/WebCore Revision 124895 Author fmal...@chromium.org Date 2012-08-07 09:30:59 -0700 (Tue, 07 Aug 2012) Log Message [Chromium] Unreviewed build fix after r124879. Patch by Florin Malita fmal...@chromium.org on 2012-08-07 * WebCore.gypi: Remove deleted file references. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi Diff Modified: trunk/Source/WebCore/ChangeLog (124894 => 124895) --- trunk/Source/WebCore/ChangeLog 2012-08-07 15:58:54 UTC (rev 124894) +++ trunk/Source/WebCore/ChangeLog 2012-08-07 16:30:59 UTC (rev 124895) @@ -1,3 +1,9 @@ +2012-08-07 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed build fix after r124879. + +* WebCore.gypi: Remove deleted file references. + 2012-08-07 George Staikos stai...@webkit.org [BlackBerry] We should fail the HTTP auth silently for non-main loads Modified: trunk/Source/WebCore/WebCore.gypi (124894 => 124895) --- trunk/Source/WebCore/WebCore.gypi 2012-08-07 15:58:54 UTC (rev 124894) +++ trunk/Source/WebCore/WebCore.gypi 2012-08-07 16:30:59 UTC (rev 124895) @@ -2735,7 +2735,6 @@ 'editing/mac/FrameSelectionMac.mm', 'editing/markup.cpp', 'editing/qt/EditorQt.cpp', -'editing/qt/SmartReplaceQt.cpp', 'editing/visible_units.cpp', 'editing/wx/EditorWx.cpp', 'fileapi/AsyncFileStream.cpp', @@ -4486,7 +4485,6 @@ 'platform/text/mac/TextCodecMac.cpp', 'platform/text/mac/TextCodecMac.h', 'platform/text/qt/TextBoundariesQt.cpp', -'platform/text/qt/TextBreakIteratorQt.cpp', 'platform/text/qt/TextCodecQt.cpp', 'platform/text/qt/TextCodecQt.h', 'platform/text/transcoder/FontTranscoder.cpp', @@ -4646,8 +4644,6 @@ 'plugins/mac/PluginPackageMac.cpp', 'plugins/mac/PluginViewMac.mm', 'plugins/npapi.cpp', -'plugins/qt/PluginContainerQt.cpp', -'plugins/qt/PluginContainerQt.h', 'plugins/qt/PluginPackageQt.cpp', 'plugins/qt/PluginViewQt.cpp', 'plugins/win/PluginDatabaseWin.cpp', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124681] trunk
Title: [124681] trunk
Revision 124681
Author fmal...@chromium.org
Date 2012-08-03 18:23:58 -0700 (Fri, 03 Aug 2012)
Log Message
[SVG] Tref target event listener cleanup
https://bugs.webkit.org/show_bug.cgi?id=93004
Reviewed by Abhishek Arya.
Source/WebCore:
Currently SVGTRefElement allocates event listeners dynamically as it attaches to its
targets. Synchronizing the lifetime of the target listener vs. the tref element is
error prone, as various events can stack and trigger nested handlers.
In order to reduce complexity and address a couple of outstanding issues, this patch
changes the way event listeners are allocated: only one target listener is created
for the lifetime of the SVGTRefElement, and gets reused if the target element changes.
Test: svg/custom/tref-nested-events-crash.svg
* dom/EventListener.h:
Added new tref target event listener type.
* svg/SVGTRefElement.cpp:
(WebCore):
(WebCore::SVGTRefTargetEventListener::create):
(WebCore::SVGTRefTargetEventListener::cast):
(SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::isAttached):
(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::attach):
(WebCore::SVGTRefTargetEventListener::detach):
(WebCore::SVGTRefTargetEventListener::operator==):
(WebCore::SVGTRefTargetEventListener::handleEvent):
No need to check m_trefElement anymore - the listener is allocated for the whole element
lifetime, detached when the element is removed and deallocated when the element is
destroyed.
(WebCore::SVGTRefElement::SVGTRefElement):
Allocate one target listener per element, at construction time.
(WebCore::SVGTRefElement::~SVGTRefElement):
Detach the listener if necessary.
(WebCore::SVGTRefElement::detachTarget):
Check whether the element is still in document after updating the text (may have been
removed by event handlers).
(WebCore::SVGTRefElement::buildPendingResource):
Attach the event listener before updating the text content to avoid racing with event
handlers (which can remove the element).
(WebCore::SVGTRefElement::removedFrom):
* svg/SVGTRefElement.h:
(WebCore):
(SVGTRefElement):
LayoutTests:
* svg/custom/tref-nested-events-crash-expected.txt: Added.
* svg/custom/tref-nested-events-crash.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventListener.h
trunk/Source/WebCore/svg/SVGTRefElement.cpp
trunk/Source/WebCore/svg/SVGTRefElement.h
Added Paths
trunk/LayoutTests/svg/custom/tref-nested-events-crash-expected.txt
trunk/LayoutTests/svg/custom/tref-nested-events-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (124680 => 124681)
--- trunk/LayoutTests/ChangeLog 2012-08-04 01:13:22 UTC (rev 124680)
+++ trunk/LayoutTests/ChangeLog 2012-08-04 01:23:58 UTC (rev 124681)
@@ -1,3 +1,13 @@
+2012-08-03 Florin Malita fmal...@chromium.org
+
+[SVG] Tref target event listener cleanup
+https://bugs.webkit.org/show_bug.cgi?id=93004
+
+Reviewed by Abhishek Arya.
+
+* svg/custom/tref-nested-events-crash-expected.txt: Added.
+* svg/custom/tref-nested-events-crash.svg: Added.
+
2012-08-01 Ryosuke Niwa rn...@webkit.org
Use testRunner instead of layoutTestController in fast/scrolling through fast/xsl tests
Added: trunk/LayoutTests/svg/custom/tref-nested-events-crash-expected.txt (0 => 124681)
--- trunk/LayoutTests/svg/custom/tref-nested-events-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/tref-nested-events-crash-expected.txt 2012-08-04 01:23:58 UTC (rev 124681)
@@ -0,0 +1 @@
+PASS: did not crash.
Added: trunk/LayoutTests/svg/custom/tref-nested-events-crash.svg (0 => 124681)
--- trunk/LayoutTests/svg/custom/tref-nested-events-crash.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/tref-nested-events-crash.svg 2012-08-04 01:23:58 UTC (rev 124681)
@@ -0,0 +1,36 @@
+?xml version=1.0 encoding=UTF-8?
+svg _onload_=CFcrash() xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
+ !-- Test for https://bugs.webkit.org/show_bug.cgi?id=93004 --
+ g id=test-body-content
+defs
+text id=hello
+tspan id=tspan##/tspan
+/text
+/defs
+
+text
+tref id=tref xlink:href=""
+/text
+ /g
+
+ textPASS: did not crash./text
+ script
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+var test_body_content = document.getElementById(test-body-content);
+var tspan = document.getElementById(tspan);
+
+function CFcrash() {
+test_body_content.addEventListener(DOMCharacterDataModified, function () {
+try { test_body_content.parentNode.removeChild(test_body_content); } catch (e) {}
+
+if (window.testRunner)
+setTimeout('testRunner.notifyDone()', 0);
+}, false);
+document.adoptNode(tspan);
+}
+ /script
+/svg
Modified:
[webkit-changes] [124369] trunk
Title: [124369] trunk
Revision 124369
Author fmal...@chromium.org
Date 2012-08-01 14:24:28 -0700 (Wed, 01 Aug 2012)
Log Message
SVG animation not working for elements inserted after parsing is finished
https://bugs.webkit.org/show_bug.cgi?id=92025
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Time containers for SVG elements inserted after document parsing is finished need to be
initialized on insertion (since they've missed the Document::implicitClose() initialization
point).
Test: svg/animations/deferred-insertion.html
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::insertedInto):
LayoutTests:
* svg/animations/deferred-insertion-expected.txt: Added.
* svg/animations/deferred-insertion.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGSVGElement.cpp
Added Paths
trunk/LayoutTests/svg/animations/deferred-insertion-expected.txt
trunk/LayoutTests/svg/animations/deferred-insertion.html
Diff
Modified: trunk/LayoutTests/ChangeLog (124368 => 124369)
--- trunk/LayoutTests/ChangeLog 2012-08-01 21:21:55 UTC (rev 124368)
+++ trunk/LayoutTests/ChangeLog 2012-08-01 21:24:28 UTC (rev 124369)
@@ -1,3 +1,13 @@
+2012-08-01 Florin Malita fmal...@chromium.org
+
+SVG animation not working for elements inserted after parsing is finished
+https://bugs.webkit.org/show_bug.cgi?id=92025
+
+Reviewed by Nikolas Zimmermann.
+
+* svg/animations/deferred-insertion-expected.txt: Added.
+* svg/animations/deferred-insertion.html: Added.
+
2012-08-01 Vincent Scheib sch...@chromium.org
Block pointer lock for sandboxed iframes.
Added: trunk/LayoutTests/svg/animations/deferred-insertion-expected.txt (0 => 124369)
--- trunk/LayoutTests/svg/animations/deferred-insertion-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/animations/deferred-insertion-expected.txt 2012-08-01 21:24:28 UTC (rev 124369)
@@ -0,0 +1,19 @@
+SVG 1.1 dynamic animation tests
+
+Test for animation on elements inserted programmatically. Should result in a 200x200 rect and only PASS messages
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS rect.width.animVal.value is 200
+PASS rect.width.baseVal.value is 200
+PASS rect.width.animVal.value is 150
+PASS rect.width.baseVal.value is 200
+PASS rect.width.animVal.value is 100
+PASS rect.width.baseVal.value is 200
+PASS rect.width.animVal.value is 200
+PASS rect.width.baseVal.value is 200
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/svg/animations/deferred-insertion.html (0 => 124369)
--- trunk/LayoutTests/svg/animations/deferred-insertion.html (rev 0)
+++ trunk/LayoutTests/svg/animations/deferred-insertion.html 2012-08-01 21:24:28 UTC (rev 124369)
@@ -0,0 +1,79 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+script src=""
+script src=""
+/head
+body _onload_=scheduleTest()
+h1SVG 1.1 dynamic animation tests/h1
+p id=description/p
+div id=console/div
+script
+
+function scheduleTest() {
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+setTimeout(startTest, 0);
+}
+
+function startTest() {
+description(Test for animation on elements inserted programmatically. Should result in a 200x200 rect and only PASS messages);
+createSVGTestCase();
+
+// Setup test document
+var rect = createSVGElement(rect);
+rect.setAttribute(id, rect);
+rect.setAttribute(width, 200);
+rect.setAttribute(height, 200);
+rect.setAttribute(fill, green);
+rect.setAttribute(onclick, executeTest());
+
+var animate = createSVGElement(animate);
+animate.setAttribute(id, animation);
+animate.setAttribute(attributeName, width);
+animate.setAttribute(from, 200);
+animate.setAttribute(to, 100);
+animate.setAttribute(begin, click);
+animate.setAttribute(dur, 4s);
+rect.appendChild(animate);
+rootSVGElement.appendChild(rect);
+
+runSMILTest();
+}
+
+function sample1() {
+// Check initial/end conditions
+shouldBeCloseEnough(rect.width.animVal.value, 200);
+shouldBe(rect.width.baseVal.value, 200);
+}
+
+function sample2() {
+// Check half-time conditions
+shouldBeCloseEnough(rect.width.animVal.value, 150);
+shouldBe(rect.width.baseVal.value, 200);
+}
+
+function sample3() {
+// Check just before-end conditions
+shouldBeCloseEnough(rect.width.animVal.value, 100);
+shouldBe(rect.width.baseVal.value, 200);
+}
+
+function executeTest() {
+const expectedValues = [
+// [animationId, time, sampleCallback]
+[animation, 0.0, sample1],
+[animation, 2.0, sample2],
+[animation, 3.999, sample3],
+[animation, 4.001, sample1]
+];
+
+runAnimationTest(expectedValues);
+}
+
+var successfullyParsed = true;
+/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (124368 => 124369)
---
[webkit-changes] [123508] branches/chromium/1180
Title: [123508] branches/chromium/1180
Revision 123508
Author fmal...@chromium.org
Date 2012-07-24 12:40:53 -0700 (Tue, 24 Jul 2012)
Log Message
Merge 122755 - SVGAnimationElement::currentValuesForValuesAnimation crash
https://bugs.webkit.org/show_bug.cgi?id=91326
Reviewed by Simon Fraser.
SVGSMILElement::progress() assumes that seekToIntervalCorrespondingToTime() always
lands inside a defined interval, but one can force arbitrary time offsets using
setCurrentTime(). This patch adds logic for handling non-interval time offsets
gracefully.
Source/WebCore:
Test: svg/animations/smil-setcurrenttime-crash.svg
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::progress):
LayoutTests:
* svg/animations/smil-setcurrenttime-crash-expected.txt: Added.
* svg/animations/smil-setcurrenttime-crash.svg: Added.
TBR=fmal...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10802091
Modified Paths
branches/chromium/1180/Source/WebCore/svg/animation/SVGSMILElement.cpp
Added Paths
branches/chromium/1180/LayoutTests/svg/animations/smil-setcurrenttime-crash-expected.txt
branches/chromium/1180/LayoutTests/svg/animations/smil-setcurrenttime-crash.svg
Diff
Copied: branches/chromium/1180/LayoutTests/svg/animations/smil-setcurrenttime-crash-expected.txt (from rev 122755, trunk/LayoutTests/svg/animations/smil-setcurrenttime-crash-expected.txt) (0 => 123508)
--- branches/chromium/1180/LayoutTests/svg/animations/smil-setcurrenttime-crash-expected.txt (rev 0)
+++ branches/chromium/1180/LayoutTests/svg/animations/smil-setcurrenttime-crash-expected.txt 2012-07-24 19:40:53 UTC (rev 123508)
@@ -0,0 +1 @@
+PASS: not crashing.
Copied: branches/chromium/1180/LayoutTests/svg/animations/smil-setcurrenttime-crash.svg (from rev 122755, trunk/LayoutTests/svg/animations/smil-setcurrenttime-crash.svg) (0 => 123508)
--- branches/chromium/1180/LayoutTests/svg/animations/smil-setcurrenttime-crash.svg (rev 0)
+++ branches/chromium/1180/LayoutTests/svg/animations/smil-setcurrenttime-crash.svg 2012-07-24 19:40:53 UTC (rev 123508)
@@ -0,0 +1,16 @@
+?xml version=1.0 encoding=UTF-8?
+svg version=1.1 xmlns=http://www.w3.org/2000/svg
+ !-- Test for https://bugs.webkit.org/show_bug.cgi?id=91326 --
+ rect
+animate attributeName=fill begin=1s; 10s dur=3s fill=freeze values=#000;#fff/
+ /rect
+ textPASS: not crashing./text
+
+ script
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+document.documentElement.setCurrentTime(5);
+ /script
+/svg
+
Modified: branches/chromium/1180/Source/WebCore/svg/animation/SVGSMILElement.cpp (123507 => 123508)
--- branches/chromium/1180/Source/WebCore/svg/animation/SVGSMILElement.cpp 2012-07-24 19:40:26 UTC (rev 123507)
+++ branches/chromium/1180/Source/WebCore/svg/animation/SVGSMILElement.cpp 2012-07-24 19:40:53 UTC (rev 123508)
@@ -1045,7 +1045,11 @@
// This call may obtain a new interval -- never call calculateAnimationPercentAndRepeat() before!
if (seekToTime) {
seekToIntervalCorrespondingToTime(elapsed);
-ASSERT(elapsed = m_intervalBegin);
+if (elapsed m_intervalBegin) {
+// elapsed is not within an interval.
+m_nextProgressTime = m_intervalBegin;
+return false;
+}
}
unsigned repeat = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [122872] trunk/LayoutTests
Title: [122872] trunk/LayoutTests
Revision 122872
Author fmal...@chromium.org
Date 2012-07-17 13:44:40 -0700 (Tue, 17 Jul 2012)
Log Message
SVG getBBox does not update bound after path data change
https://bugs.webkit.org/show_bug.cgi?id=82629
Reviewed by Dirk Schulze.
The bug appears to have been fixed - adding a test for it.
* svg/custom/path-bbox-update-expected.txt: Added.
* svg/custom/path-bbox-update.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/svg/custom/path-bbox-update-expected.txt
trunk/LayoutTests/svg/custom/path-bbox-update.html
Diff
Modified: trunk/LayoutTests/ChangeLog (122871 => 122872)
--- trunk/LayoutTests/ChangeLog 2012-07-17 20:24:40 UTC (rev 122871)
+++ trunk/LayoutTests/ChangeLog 2012-07-17 20:44:40 UTC (rev 122872)
@@ -1,3 +1,15 @@
+2012-07-17 Florin Malita fmal...@chromium.org
+
+SVG getBBox does not update bound after path data change
+https://bugs.webkit.org/show_bug.cgi?id=82629
+
+Reviewed by Dirk Schulze.
+
+The bug appears to have been fixed - adding a test for it.
+
+* svg/custom/path-bbox-update-expected.txt: Added.
+* svg/custom/path-bbox-update.html: Added.
+
2012-07-17 Tony Chang t...@chromium.org
[chromium] Unreviewed gardening. Add baselines after r122861.
Added: trunk/LayoutTests/svg/custom/path-bbox-update-expected.txt (0 => 122872)
--- trunk/LayoutTests/svg/custom/path-bbox-update-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/path-bbox-update-expected.txt 2012-07-17 20:44:40 UTC (rev 122872)
@@ -0,0 +1,2 @@
+PASS: bounding box is (80, 80, 100, 100)
+
Added: trunk/LayoutTests/svg/custom/path-bbox-update.html (0 => 122872)
--- trunk/LayoutTests/svg/custom/path-bbox-update.html (rev 0)
+++ trunk/LayoutTests/svg/custom/path-bbox-update.html 2012-07-17 20:44:40 UTC (rev 122872)
@@ -0,0 +1,33 @@
+!DOCTYPE html
+html
+ !-- Test for https://bugs.webkit.org/show_bug.cgi?id=82629 --
+ head
+script
+ if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+ }
+
+ function runTest() {
+var path = document.getElementById('path');
+path.setAttribute('d', M80 80L100 100);
+
+// The bounding box should be updated.
+var box = path.getBBox();
+var pass = (box.x == 80) (box.y == 80) (box.width == 20) (box.height == 20);
+document.getElementById('output').innerHTML = (pass ? 'PASS' : 'FAIL') + ': bounding box is ('
+ + box.x + ', ' + box.y + ', ' + (box.x + box.width) + ', ' + (box.y + box.height) + ')';
+
+if (window.testRunner)
+ testRunner.notifyDone();
+ }
+/script
+ /head
+ body
+div id=output/div
+svg xmlns=http://www.w3.org/2000/svg _onload_=runTest()
+ path id=path d=M30 30 L50 50 stroke-width=3 stroke=green/path
+/svg
+ /body
+/html
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [122755] trunk
Title: [122755] trunk
Revision 122755
Author fmal...@chromium.org
Date 2012-07-16 13:31:54 -0700 (Mon, 16 Jul 2012)
Log Message
SVGAnimationElement::currentValuesForValuesAnimation crash
https://bugs.webkit.org/show_bug.cgi?id=91326
Reviewed by Simon Fraser.
SVGSMILElement::progress() assumes that seekToIntervalCorrespondingToTime() always
lands inside a defined interval, but one can force arbitrary time offsets using
setCurrentTime(). This patch adds logic for handling non-interval time offsets
gracefully.
Source/WebCore:
Test: svg/animations/smil-setcurrenttime-crash.svg
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::progress):
LayoutTests:
* svg/animations/smil-setcurrenttime-crash-expected.txt: Added.
* svg/animations/smil-setcurrenttime-crash.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp
Added Paths
trunk/LayoutTests/svg/animations/smil-setcurrenttime-crash-expected.txt
trunk/LayoutTests/svg/animations/smil-setcurrenttime-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (122754 => 122755)
--- trunk/LayoutTests/ChangeLog 2012-07-16 20:29:07 UTC (rev 122754)
+++ trunk/LayoutTests/ChangeLog 2012-07-16 20:31:54 UTC (rev 122755)
@@ -1,3 +1,18 @@
+2012-07-16 Florin Malita fmal...@chromium.org
+
+SVGAnimationElement::currentValuesForValuesAnimation crash
+https://bugs.webkit.org/show_bug.cgi?id=91326
+
+Reviewed by Simon Fraser.
+
+SVGSMILElement::progress() assumes that seekToIntervalCorrespondingToTime() always
+lands inside a defined interval, but one can force arbitrary time offsets using
+setCurrentTime(). This patch adds logic for handling non-interval time offsets
+gracefully.
+
+* svg/animations/smil-setcurrenttime-crash-expected.txt: Added.
+* svg/animations/smil-setcurrenttime-crash.svg: Added.
+
2012-07-16 W. James MacLean wjmacl...@chromium.org
[chromium] Unreviewed gardening. Layout Test fast/frames/calculate-fixed.html is flaky
Added: trunk/LayoutTests/svg/animations/smil-setcurrenttime-crash-expected.txt (0 => 122755)
--- trunk/LayoutTests/svg/animations/smil-setcurrenttime-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/animations/smil-setcurrenttime-crash-expected.txt 2012-07-16 20:31:54 UTC (rev 122755)
@@ -0,0 +1 @@
+PASS: not crashing.
Added: trunk/LayoutTests/svg/animations/smil-setcurrenttime-crash.svg (0 => 122755)
--- trunk/LayoutTests/svg/animations/smil-setcurrenttime-crash.svg (rev 0)
+++ trunk/LayoutTests/svg/animations/smil-setcurrenttime-crash.svg 2012-07-16 20:31:54 UTC (rev 122755)
@@ -0,0 +1,16 @@
+?xml version=1.0 encoding=UTF-8?
+svg version=1.1 xmlns=http://www.w3.org/2000/svg
+ !-- Test for https://bugs.webkit.org/show_bug.cgi?id=91326 --
+ rect
+animate attributeName=fill begin=1s; 10s dur=3s fill=freeze values=#000;#fff/
+ /rect
+ textPASS: not crashing./text
+
+ script
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+document.documentElement.setCurrentTime(5);
+ /script
+/svg
+
Modified: trunk/Source/WebCore/ChangeLog (122754 => 122755)
--- trunk/Source/WebCore/ChangeLog 2012-07-16 20:29:07 UTC (rev 122754)
+++ trunk/Source/WebCore/ChangeLog 2012-07-16 20:31:54 UTC (rev 122755)
@@ -1,3 +1,20 @@
+2012-07-16 Florin Malita fmal...@chromium.org
+
+SVGAnimationElement::currentValuesForValuesAnimation crash
+https://bugs.webkit.org/show_bug.cgi?id=91326
+
+Reviewed by Simon Fraser.
+
+SVGSMILElement::progress() assumes that seekToIntervalCorrespondingToTime() always
+lands inside a defined interval, but one can force arbitrary time offsets using
+setCurrentTime(). This patch adds logic for handling non-interval time offsets
+gracefully.
+
+Test: svg/animations/smil-setcurrenttime-crash.svg
+
+* svg/animation/SVGSMILElement.cpp:
+(WebCore::SVGSMILElement::progress):
+
2012-07-16 Joshua Netterfield jnetterfi...@rim.com
[BlackBerry] Upstream WebGL Code
Modified: trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp (122754 => 122755)
--- trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2012-07-16 20:29:07 UTC (rev 122754)
+++ trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp 2012-07-16 20:31:54 UTC (rev 122755)
@@ -1043,7 +1043,11 @@
// This call may obtain a new interval -- never call calculateAnimationPercentAndRepeat() before!
if (seekToTime) {
seekToIntervalCorrespondingToTime(elapsed);
-ASSERT(elapsed = m_intervalBegin);
+if (elapsed m_intervalBegin) {
+// elapsed is not within an interval.
+m_nextProgressTime = m_intervalBegin;
+return false;
+}
}
unsigned repeat = 0;
___
webkit-changes mailing list
[webkit-changes] [122449] trunk
Title: [122449] trunk
Revision 122449
Author fmal...@chromium.org
Date 2012-07-12 05:26:03 -0700 (Thu, 12 Jul 2012)
Log Message
Incorrect handling of chained pending resources in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=89686
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Currently SVGUseElement builds the shadow tree when the target first
becomes available. This is normally OK, but if the target itself (or
one of its children) is a use element with pending resources, then
the shadow expansion only captures the current state of the tree and
never gets updated when the pending resource becomes available.
In order to support arbitrary use-on-use constructs, this patch
tracks nested use dependencies and rebuilds the dependent trees
whenever the target gets updated.
Tests: svg/custom/use-nested-expected.svg
svg/custom/use-nested.svg
* svg/SVGElement.cpp:
(WebCore::SVGElement::removedFrom): removedFrom needs to be called up the inheritance chain
before invoking removeAllElementReferencesForTarget. Otherwise we could end up finding the
element being removed as a valid target in SVGUseElement::buildInstanceTree because its
InDocument flag is not cleared yet.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::~SVGUseElement):
(WebCore::SVGUseElement::clearResourceReferences):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::buildInstanceTree):
* svg/SVGUseElement.h:
(SVGUseElement):
Track use - use dependencies using SVGDocumentExtensions'
m_elementDependencies framework and ensure dependent trees are rebuilt
when the target itself gets rebuilt.
LayoutTests:
Added reftest to verify that nested/indirect use constructs are
handled correctly WRT pending resource tracking.
Also updated the svg/hixie/error/017-expected.txt to match the current
results. Per comments in SVGUseElement::buildShadowAndInstanceTree, the
new behavior is correct: use cycles are to be ignored.
* platform/chromium-win/svg/hixie/error/017-expected.txt:
* platform/efl/svg/hixie/error/017-expected.txt:
* platform/gtk/svg/hixie/error/017-expected.txt:
* platform/mac/svg/hixie/error/017-expected.txt:
* platform/qt/svg/hixie/error/017-expected.txt:
* svg/custom/use-nested-expected.svg: Added.
* svg/custom/use-nested.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/svg/hixie/error/017-expected.txt
trunk/LayoutTests/platform/efl/svg/hixie/error/017-expected.txt
trunk/LayoutTests/platform/gtk/svg/hixie/error/017-expected.txt
trunk/LayoutTests/platform/mac/svg/hixie/error/017-expected.txt
trunk/LayoutTests/platform/qt/svg/hixie/error/017-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGElement.cpp
trunk/Source/WebCore/svg/SVGUseElement.cpp
trunk/Source/WebCore/svg/SVGUseElement.h
Added Paths
trunk/LayoutTests/svg/custom/use-nested-expected.svg
trunk/LayoutTests/svg/custom/use-nested.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (122448 => 122449)
--- trunk/LayoutTests/ChangeLog 2012-07-12 12:05:28 UTC (rev 122448)
+++ trunk/LayoutTests/ChangeLog 2012-07-12 12:26:03 UTC (rev 122449)
@@ -1,3 +1,25 @@
+2012-07-12 Florin Malita fmal...@chromium.org
+
+Incorrect handling of chained pending resources in SVGUseElement
+https://bugs.webkit.org/show_bug.cgi?id=89686
+
+Reviewed by Nikolas Zimmermann.
+
+Added reftest to verify that nested/indirect use constructs are
+handled correctly WRT pending resource tracking.
+
+Also updated the svg/hixie/error/017-expected.txt to match the current
+results. Per comments in SVGUseElement::buildShadowAndInstanceTree, the
+new behavior is correct: use cycles are to be ignored.
+
+* platform/chromium-win/svg/hixie/error/017-expected.txt:
+* platform/efl/svg/hixie/error/017-expected.txt:
+* platform/gtk/svg/hixie/error/017-expected.txt:
+* platform/mac/svg/hixie/error/017-expected.txt:
+* platform/qt/svg/hixie/error/017-expected.txt:
+* svg/custom/use-nested-expected.svg: Added.
+* svg/custom/use-nested.svg: Added.
+
2012-07-12 Zan Dobersek zandober...@gmail.com
Unreviewed GTK gardening, fixing a typo in test's filename in TestExpectations.
Modified: trunk/LayoutTests/platform/chromium-win/svg/hixie/error/017-expected.txt (122448 => 122449)
--- trunk/LayoutTests/platform/chromium-win/svg/hixie/error/017-expected.txt 2012-07-12 12:05:28 UTC (rev 122448)
+++ trunk/LayoutTests/platform/chromium-win/svg/hixie/error/017-expected.txt 2012-07-12 12:26:03 UTC (rev 122449)
@@ -5,12 +5,8 @@
RenderSVGHiddenContainer {defs} at (0,0) size 0x0
RenderSVGContainer {g} at (0,0) size 0x0
RenderSVGContainer {use} at (0,0) size 0x0
- RenderSVGContainer {g} at (0,0) size 0x0
-RenderSVGContainer {g} at (0,0) size 0x0
RenderSVGContainer {g} at (0,0) size 0x0
[webkit-changes] [121041] trunk
Title: [121041] trunk
Revision 121041
Author fmal...@chromium.org
Date 2012-06-22 11:19:32 -0700 (Fri, 22 Jun 2012)
Log Message
REGRESSION (Safari 5.1.5 - ToT): Crash in RenderSVGRoot::computeReplacedLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=85797
Reviewed by Darin Adler.
Source/WebCore:
Test: svg/custom/svg-width-intrinsic-crash.html
RenderSVGRoot::computeReplacedLogicalWidth assumes that if
SVGSVGElement::widthAttributeEstablishesViewport returns false, the
SVG must be embedded via object. This is not always the case, though:
widthAttributeEstablishesViewport can also return false for inline
SVG if it doesn't have a replaced logical width.
Updated computeReplacedLogical{Width,Height} to handle the
!widthAttributeEstablishesViewport !isEmbeddedThroughFrameContainingSVGDocument
case gracefully.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
LayoutTests:
* svg/custom/svg-width-intrinsic-crash-expected.txt: Added.
* svg/custom/svg-width-intrinsic-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
Added Paths
trunk/LayoutTests/svg/custom/svg-width-intrinsic-crash-expected.txt
trunk/LayoutTests/svg/custom/svg-width-intrinsic-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (121040 => 121041)
--- trunk/LayoutTests/ChangeLog 2012-06-22 18:10:03 UTC (rev 121040)
+++ trunk/LayoutTests/ChangeLog 2012-06-22 18:19:32 UTC (rev 121041)
@@ -1,3 +1,13 @@
+2012-06-22 Florin Malita fmal...@chromium.org
+
+REGRESSION (Safari 5.1.5 - ToT): Crash in RenderSVGRoot::computeReplacedLogicalWidth
+https://bugs.webkit.org/show_bug.cgi?id=85797
+
+Reviewed by Darin Adler.
+
+* svg/custom/svg-width-intrinsic-crash-expected.txt: Added.
+* svg/custom/svg-width-intrinsic-crash.html: Added.
+
2012-06-22 Hayato Ito hay...@chromium.org
Modify event re-targeting algorithm so that we can tell which distributed node is clicked.
Added: trunk/LayoutTests/svg/custom/svg-width-intrinsic-crash-expected.txt (0 => 121041)
--- trunk/LayoutTests/svg/custom/svg-width-intrinsic-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/svg-width-intrinsic-crash-expected.txt 2012-06-22 18:19:32 UTC (rev 121041)
@@ -0,0 +1,2 @@
+PASS (didn't crash).
+
Added: trunk/LayoutTests/svg/custom/svg-width-intrinsic-crash.html (0 => 121041)
--- trunk/LayoutTests/svg/custom/svg-width-intrinsic-crash.html (rev 0)
+++ trunk/LayoutTests/svg/custom/svg-width-intrinsic-crash.html 2012-06-22 18:19:32 UTC (rev 121041)
@@ -0,0 +1,15 @@
+!DOCTYPE html
+html
+body
+ !-- Test for https://bugs.webkit.org/show_bug.cgi?id=85797 --
+ divPASS (didn't crash)./div
+ div style=width: 100px;
+svg style=width: intrinsic;/
+ /div
+ script
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+ /script
+/body
+/html
+
Modified: trunk/Source/WebCore/ChangeLog (121040 => 121041)
--- trunk/Source/WebCore/ChangeLog 2012-06-22 18:10:03 UTC (rev 121040)
+++ trunk/Source/WebCore/ChangeLog 2012-06-22 18:19:32 UTC (rev 121041)
@@ -1,3 +1,26 @@
+2012-06-22 Florin Malita fmal...@chromium.org
+
+REGRESSION (Safari 5.1.5 - ToT): Crash in RenderSVGRoot::computeReplacedLogicalWidth
+https://bugs.webkit.org/show_bug.cgi?id=85797
+
+Reviewed by Darin Adler.
+
+Test: svg/custom/svg-width-intrinsic-crash.html
+
+RenderSVGRoot::computeReplacedLogicalWidth assumes that if
+SVGSVGElement::widthAttributeEstablishesViewport returns false, the
+SVG must be embedded via object. This is not always the case, though:
+widthAttributeEstablishesViewport can also return false for inline
+SVG if it doesn't have a replaced logical width.
+
+Updated computeReplacedLogical{Width,Height} to handle the
+!widthAttributeEstablishesViewport !isEmbeddedThroughFrameContainingSVGDocument
+case gracefully.
+
+* rendering/svg/RenderSVGRoot.cpp:
+(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
+(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
+
2012-06-22 Hayato Ito hay...@chromium.org
Modify event re-targeting algorithm so that we can tell which distributed node is clicked.
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp (121040 => 121041)
--- trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2012-06-22 18:10:03 UTC (rev 121040)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2012-06-22 18:19:32 UTC (rev 121041)
@@ -173,9 +173,12 @@
if (svg-widthAttributeEstablishesViewport())
return resolveLengthAttributeForSVG(svg-intrinsicWidth(SVGSVGElement::IgnoreCSSProperties), style()-effectiveZoom(), containingBlock()-availableLogicalWidth(), view());
-// Only
[webkit-changes] [120460] trunk/Source/WebCore
Title: [120460] trunk/Source/WebCore
Revision 120460
Author fmal...@chromium.org
Date 2012-06-15 08:18:59 -0700 (Fri, 15 Jun 2012)
Log Message
[Chromium] Unreviewed debug build fix for r120457
Patch by Florin Malita fmal...@chromium.org on 2012-06-15
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toYUVVideoDrawQuad):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDrawQuad.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120459 => 120460)
--- trunk/Source/WebCore/ChangeLog 2012-06-15 15:15:01 UTC (rev 120459)
+++ trunk/Source/WebCore/ChangeLog 2012-06-15 15:18:59 UTC (rev 120460)
@@ -1,3 +1,10 @@
+2012-06-15 Florin Malita fmal...@chromium.org
+
+[Chromium] Unreviewed debug build fix for r120457
+
+* platform/graphics/chromium/cc/CCDrawQuad.cpp:
+(WebCore::CCDrawQuad::toYUVVideoDrawQuad):
+
2012-06-15 'Pavel Feldman' pfeld...@chromium.org
Not reviewed: remove redundant Mac-specific style rule from inspector front-end.
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCDrawQuad.cpp (120459 => 120460)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCDrawQuad.cpp 2012-06-15 15:15:01 UTC (rev 120459)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCDrawQuad.cpp 2012-06-15 15:18:59 UTC (rev 120460)
@@ -116,7 +116,7 @@
const CCYUVVideoDrawQuad* CCDrawQuad::toYUVVideoDrawQuad() const
{
-ASSERT(m_material == VideoContent);
+ASSERT(m_material == YUVVideoContent);
return static_castconst CCYUVVideoDrawQuad*(this);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120467] trunk
Title: [120467] trunk Revision 120467 Author fmal...@chromium.org Date 2012-06-15 08:56:18 -0700 (Fri, 15 Jun 2012) Log Message Specular light filters produce dark results https://bugs.webkit.org/show_bug.cgi?id=89116 Reviewed by Dirk Schulze. Source/WebCore: Tests: svg/filters/feSpecularLight-premultiplied-expected.svg svg/filters/feSpecularLight-premultiplied.svg Per spec (http://www.w3.org/TR/SVG/filters.html#feSpecularLightingElement), light filters should operate on pre-multiplied RGBA. Currently, the results are stored in the unmultiplied buffer but the alpha channel is calculated for premultiplied values (which causes a darkening of the result upon the subsequent unmultiplied-premultiplied conversion). This patch updates FELighting to generate premultiplied results. * platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::platformApplySoftware): LayoutTests: * platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: * platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: * platform/chromium-linux/svg/filters/feLighting-crash-expected.png: * platform/chromium/TestExpectations: * platform/mac/TestExpectations: * svg/filters/feSpecularLight-premultiplied-expected.svg: Added. * svg/filters/feSpecularLight-premultiplied.svg: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png trunk/LayoutTests/platform/chromium-linux/svg/filters/feLighting-crash-expected.png trunk/LayoutTests/platform/mac/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/filters/FELighting.cpp Added Paths trunk/LayoutTests/svg/filters/feSpecularLight-premultiplied-expected.svg trunk/LayoutTests/svg/filters/feSpecularLight-premultiplied.svg Diff Modified: trunk/LayoutTests/ChangeLog (120466 => 120467) --- trunk/LayoutTests/ChangeLog 2012-06-15 15:56:08 UTC (rev 120466) +++ trunk/LayoutTests/ChangeLog 2012-06-15 15:56:18 UTC (rev 120467) @@ -1,3 +1,27 @@ +2012-06-15 Florin Malita fmal...@chromium.org + +Specular light filters produce dark results +https://bugs.webkit.org/show_bug.cgi?id=89116 + +Reviewed by Dirk Schulze. + +* platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: +* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: +* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: +*
[webkit-changes] [120479] trunk/LayoutTests
Title: [120479] trunk/LayoutTests Revision 120479 Author fmal...@chromium.org Date 2012-06-15 11:37:51 -0700 (Fri, 15 Jun 2012) Log Message Unreviewed chromium rebaseline for r120467. Patch by Florin Malita fmal...@chromium.org on 2012-06-15 * platform/chromium-linux-x86/svg/filters/feLighting-crash-expected.png: * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: * platform/chromium-mac-leopard/svg/filters/feLighting-crash-expected.png: * platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: * platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: * platform/chromium-mac-snowleopard/svg/filters/feLighting-crash-expected.png: * platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: * platform/chromium-mac/svg/filters/feLighting-crash-expected.png: * platform/chromium-win-vista/svg/filters/feLighting-crash-expected.png: * platform/chromium-win-xp/svg/filters/feLighting-crash-expected.png: * platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: * platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: *
[webkit-changes] [119914] trunk
Title: [119914] trunk
Revision 119914
Author fmal...@chromium.org
Date 2012-06-09 12:37:07 -0700 (Sat, 09 Jun 2012)
Log Message
Fixed-position foreignObject descendants should be relative to the foreignObject viewport
https://bugs.webkit.org/show_bug.cgi?id=88547
Reviewed by Abhishek Arya.
Source/WebCore:
Tests: svg/foreignObject/fO-fixed-position-crash.html
svg/foreignObject/fixed-position-expected.svg
svg/foreignObject/fixed-position.svg
Fixed position elements are currently registered with the top level
RenderView even when embedded within an SVG foreignOject. This patch
changes containingBlock() container() to return the containing
foreignObject renderer instead.
The new foreignObject fixed position behavior matches that of current
FireFox and Opera versions and is consistent with the spec:
http://www.w3.org/TR/CSS2/visuren.html#fixed-positioning
http://www.w3.org/TR/SVG/coords.html#EstablishingANewViewport
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::container):
LayoutTests:
* svg/foreignObject/fO-fixed-position-crash-expected.txt: Added.
* svg/foreignObject/fO-fixed-position-crash.html: Added.
* svg/foreignObject/fixed-position-expected.svg: Added.
* svg/foreignObject/fixed-position.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
Added Paths
trunk/LayoutTests/svg/foreignObject/fO-fixed-position-crash-expected.txt
trunk/LayoutTests/svg/foreignObject/fO-fixed-position-crash.html
trunk/LayoutTests/svg/foreignObject/fixed-position-expected.svg
trunk/LayoutTests/svg/foreignObject/fixed-position.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (119913 => 119914)
--- trunk/LayoutTests/ChangeLog 2012-06-09 19:35:02 UTC (rev 119913)
+++ trunk/LayoutTests/ChangeLog 2012-06-09 19:37:07 UTC (rev 119914)
@@ -1,3 +1,15 @@
+2012-06-09 Florin Malita fmal...@chromium.org
+
+Fixed-position foreignObject descendants should be relative to the foreignObject viewport
+https://bugs.webkit.org/show_bug.cgi?id=88547
+
+Reviewed by Abhishek Arya.
+
+* svg/foreignObject/fO-fixed-position-crash-expected.txt: Added.
+* svg/foreignObject/fO-fixed-position-crash.html: Added.
+* svg/foreignObject/fixed-position-expected.svg: Added.
+* svg/foreignObject/fixed-position.svg: Added.
+
2012-06-09 Adam Barth aba...@webkit.org
Can't use eval in iframes sanbdoxed via CSP header
Added: trunk/LayoutTests/svg/foreignObject/fO-fixed-position-crash-expected.txt (0 => 119914)
--- trunk/LayoutTests/svg/foreignObject/fO-fixed-position-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/foreignObject/fO-fixed-position-crash-expected.txt 2012-06-09 19:37:07 UTC (rev 119914)
@@ -0,0 +1 @@
+PASS
Added: trunk/LayoutTests/svg/foreignObject/fO-fixed-position-crash.html (0 => 119914)
--- trunk/LayoutTests/svg/foreignObject/fO-fixed-position-crash.html (rev 0)
+++ trunk/LayoutTests/svg/foreignObject/fO-fixed-position-crash.html 2012-06-09 19:37:07 UTC (rev 119914)
@@ -0,0 +1,22 @@
+!DOCTYPE html
+html
+body
+!-- Test for https://bugs.webkit.org/show_bug.cgi?id=88547 --
+svg xmlns=http://www.w3.org/2000/svg
+ foreignObject
+div id=div style=position:fixed; height:50%; counter-increment:inherit;Passes if replacing this text doesn't cause a crash./div
+ /foreignObject
+
+ script
+window._onload_=function() {
+ document.designMode=on;
+ document.execCommand(SelectAll);
+ document.getElementById('div').innerHTML = PASS;
+};
+
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+ /script
+/svg
+/body
+/html
Added: trunk/LayoutTests/svg/foreignObject/fixed-position-expected.svg (0 => 119914)
--- trunk/LayoutTests/svg/foreignObject/fixed-position-expected.svg (rev 0)
+++ trunk/LayoutTests/svg/foreignObject/fixed-position-expected.svg 2012-06-09 19:37:07 UTC (rev 119914)
@@ -0,0 +1,4 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+svg xmlns=http://www.w3.org/2000/svg
+ rect width=100 height=100 fill=green/
+/svg
Added: trunk/LayoutTests/svg/foreignObject/fixed-position.svg (0 => 119914)
--- trunk/LayoutTests/svg/foreignObject/fixed-position.svg (rev 0)
+++ trunk/LayoutTests/svg/foreignObject/fixed-position.svg 2012-06-09 19:37:07 UTC (rev 119914)
@@ -0,0 +1,8 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+svg xmlns=http://www.w3.org/2000/svg
+ rect width=98 height=98 fill=red/
+ foreignObject width=200 height=200 transform=translate(-100, 0)
+!-- Fixed-position content should be relative to the foreignObject viewport. --
+div xmlns=http://www.w3.org/1999/xhtml style=position: fixed; left: 100px; width: 100px; height: 50%; background-color: green;/div
+ /foreignObject
+/svg
Modified: trunk/Source/WebCore/ChangeLog (119913 =>
[webkit-changes] [119241] trunk
Title: [119241] trunk
Revision 119241
Author fmal...@chromium.org
Date 2012-06-01 09:03:33 -0700 (Fri, 01 Jun 2012)
Log Message
http://shinydemos.com/clock/ doesn't seem to work
https://bugs.webkit.org/show_bug.cgi?id=79682
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Test: svg/repaint/text-mask-update.svg
Currently, parent resources are not invalidated when SVGInlineText nodes
are added or removed. Adjusting SVGResourcesCache::clientWasAddedToTree()
and SVGResourcesCache::clientWillBeRemovedFromTree() to cover this case.
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):
LayoutTests:
* platform/chromium-linux/svg/repaint/text-mask-update-expected.png: Added.
* platform/chromium-linux/svg/repaint/text-mask-update-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/test_expectations.txt:
* svg/repaint/text-mask-update.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/mac/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp
Added Paths
trunk/LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.txt
trunk/LayoutTests/svg/repaint/text-mask-update.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (119240 => 119241)
--- trunk/LayoutTests/ChangeLog 2012-06-01 16:03:14 UTC (rev 119240)
+++ trunk/LayoutTests/ChangeLog 2012-06-01 16:03:33 UTC (rev 119241)
@@ -1,3 +1,16 @@
+2012-06-01 Florin Malita fmal...@chromium.org
+
+http://shinydemos.com/clock/ doesn't seem to work
+https://bugs.webkit.org/show_bug.cgi?id=79682
+
+Reviewed by Nikolas Zimmermann.
+
+* platform/chromium-linux/svg/repaint/text-mask-update-expected.png: Added.
+* platform/chromium-linux/svg/repaint/text-mask-update-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+* platform/mac/test_expectations.txt:
+* svg/repaint/text-mask-update.svg: Added.
+
2012-06-01 Christophe Dumez christophe.du...@intel.com
[EFL] EFL's LayoutTestController needs to implement deliverWebIntent
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (119240 => 119241)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-06-01 16:03:14 UTC (rev 119240)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-06-01 16:03:33 UTC (rev 119241)
@@ -1223,6 +1223,9 @@
BUGWK81217 : svg/carto.net/tabgroup.svg = PASS FAIL
BUGWK81217 : svg/hixie/perf/003.xml = PASS FAIL
+// Needs rebaseline after https://bugs.webkit.org/show_bug.cgi?id=79682
+BUGWK79682 WIN MAC : svg/repaint/text-mask-update.svg = MISSING IMAGE+TEXT IMAGE TEXT PASS
+
BUGWK81240 MAC : svg/text/bidi-reorder-value-lists.svg = PASS IMAGE+TEXT
BUGWK81243 : svg/repaint/repainting-after-animation-element-removal.svg = PASS IMAGE
Added: trunk/LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.png (0 => 119241)
--- trunk/LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.png (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.png 2012-06-01 16:03:33 UTC (rev 119241)
@@ -0,0 +1,8 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum b9636cc360c1d9aab9f48d9a3fb3c267\x8A\xD1l\x97 \xA9IDATx\x9C\xED\xDD_\xA8\xDEu \xC0\xF1\xDF9\xFE\xD9\xD2
+\x8E,l*\x86څ\xA69E\xC1\xD0\x9AZ\xA0]\x84k\xE4\xCCɛ]H\xA4\x96 2EtL\xC3]i,KSD
+RF\xCAʜ\xA7%\xCEԡ\xA4E\xEA,\x9DR\xA7n\xEEt\xB18 6\xF3l\xF2\x8F\xF2z\xF1\\xBF\xDF\xF7\xF3\xFC\xCEs\xEE\xDEϗ\xDF32111|D,\\xB8\xF0\xC3~ \xD3\xFD\xB0\xDF \xC0Ǎ\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88MX#? \x99\xFA\x98uŬC\xAF=t\xC9]K\x9Ey\xE5\x99\xFF\xF5\x92+\xD7\\xB9߲\xFD\xDE\xDA\xFA\xD6{\xAE\xAE\xFC\xF3\xCA#\x96 \xB1\xF7O\xF6b\xF9+\xC6W\xFA\xCFGG~\xB2[ 3\xDC4\x81\xF5\xEE\xA5\xEFt\xFEC۟o\\xBA\xF1\xF5 \xBC~\xF79w\xAF{~\xDDq?=\xEE\xC9MO\xEE\xBFeۖ\xEB\xD7^\xFF\xF2[/\xDF\xFA\x97[w^\xBD~\xED\xF5K\xEEZ2oK7\xDE\xFB\xED{ǟ?j\xC5Q\xBB5 0\xF3MX\xA3#\xA3\xC7 p\xDC\xF6\xE7\xFB\xEF\xBB\xFF^\xA3{ \xF9\x99#/\xFF\xEA\xE5/m~i\xE9o\x97\xEE\xBFj\xFD\xAA9\xFB\xCC\x86\xE1\xC6\xF1w^]\xF6\xFBe\xC30,\xFF\xC6\xF2\xFD\xB1߁\x9F:p\xE5\x99+O\xFF\xFC\xE9\xBB5 0\xF3}\x90=X' |\xD20 \xAB\x9F^\xBD\xF3\xD25\xBC\xE6\xA63o:\xE6\xB3\xC7\xF0\x8F y\xE1\x91 V_\xDE\xFC\xF20 \xEB_X?y\xE6\xA2.ڭ \x80\x99\xEF\x83\xD6\xEC=gðmb\xDB\xE7W?\xBDzl\xF6\xD8\xF1 ޗ\xCE\x86\xE1\xC6?\xED\xF8!\xD69G\x9D3 \xC3Y??\xEB\xF6\xC7o\xDF~愃Nح \x80\x99\xEF\x83\xD6}\xCF\xDC7 \xC3\xE4W\x87\x93\xAE~\xE0ꋿ|\xF10 \x8B\xBE\xB8h\xD6 \xB3ny\xE4\x967\xB6\xBC1uຯ_wޗ\xCE۴yӷ~\xF1\xAD\xF97\xCFx\xE3\xC3c\xB3\xC7.\x9B\xD8\xF5 \x80\x99o7\xEB\x8E'\xEE\x86\xE1\xB1=v\xE1\xAF/
[webkit-changes] [117056] trunk
Title: [117056] trunk
Revision 117056
Author fmal...@chromium.org
Date 2012-05-15 05:56:35 -0700 (Tue, 15 May 2012)
Log Message
Mask deformations when masked content is rotated
https://bugs.webkit.org/show_bug.cgi?id=76527
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Test: svg/repaint/mask-clip-target-transform.svg
RenderSVGResource::markForLayoutAndParentResourceInvalidation() needs to also
invalidate parent mask and clip resources, not just filters.
* rendering/svg/RenderSVGResource.cpp:
(WebCore::removeFromCacheAndInvalidateDependencies):
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
LayoutTests:
* platform/chromium-linux/svg/repaint/mask-clip-target-transform-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/test_expectations.txt:
* svg/repaint/mask-clip-target-transform-expected.txt: Added.
* svg/repaint/mask-clip-target-transform.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/mac/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp
Added Paths
trunk/LayoutTests/platform/chromium-linux/svg/repaint/mask-clip-target-transform-expected.png
trunk/LayoutTests/svg/repaint/mask-clip-target-transform-expected.txt
trunk/LayoutTests/svg/repaint/mask-clip-target-transform.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (117055 => 117056)
--- trunk/LayoutTests/ChangeLog 2012-05-15 12:50:02 UTC (rev 117055)
+++ trunk/LayoutTests/ChangeLog 2012-05-15 12:56:35 UTC (rev 117056)
@@ -1,3 +1,16 @@
+2012-05-15 Florin Malita fmal...@chromium.org
+
+Mask deformations when masked content is rotated
+https://bugs.webkit.org/show_bug.cgi?id=76527
+
+Reviewed by Nikolas Zimmermann.
+
+* platform/chromium-linux/svg/repaint/mask-clip-target-transform-expected.png: Added.
+* platform/chromium/test_expectations.txt:
+* platform/mac/test_expectations.txt:
+* svg/repaint/mask-clip-target-transform-expected.txt: Added.
+* svg/repaint/mask-clip-target-transform.svg: Added.
+
2012-05-15 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r117052.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (117055 => 117056)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-05-15 12:50:02 UTC (rev 117055)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-05-15 12:56:35 UTC (rev 117056)
@@ -1218,6 +1218,9 @@
BUGWK81217 : svg/carto.net/tabgroup.svg = PASS FAIL
BUGWK81217 : svg/hixie/perf/003.xml = PASS FAIL
+// Needs rebaselining after landing 76527
+BUGWK76527 WIN MAC : svg/repaint/mask-clip-target-transform.svg = IMAGE+TEXT IMAGE TEXT PASS
+
BUGWK81240 MAC : svg/text/bidi-reorder-value-lists.svg = PASS IMAGE+TEXT
BUGWK81243 : svg/repaint/repainting-after-animation-element-removal.svg = PASS IMAGE
Added: trunk/LayoutTests/platform/chromium-linux/svg/repaint/mask-clip-target-transform-expected.png (0 => 117056)
--- trunk/LayoutTests/platform/chromium-linux/svg/repaint/mask-clip-target-transform-expected.png (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/svg/repaint/mask-clip-target-transform-expected.png 2012-05-15 12:56:35 UTC (rev 117056)
@@ -0,0 +1,37 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum f50102403b090a7eac6782fca184a35a\xF7|\xD1\xD6 \x94IDATx\x9C\xED\xDDO\x88\xDC\xF5\xFD\xC7\xF1o~T\xBA+\xD2\xCC\xFC\xF0\x83\x87X%\xA5!6\xBD\xAA;Y\x83VݤBVz\x88!\xC4K\xA0\xCDB\x82
+m\xCD ,V0춐\x8B\xCAjBԬZA\x90tgKo\x9BM,m*\xE6 q\xDC)\xE6w\xEB/F\x93\xDD\xC4w\xE6\xF3\xFD~\xE7\xF18\x85\x92 =\xF9\xCEg\xBE\xBB\xA4\xDDng@:###\xA9' \xECR (\x81 L` X \xC1 @0\x81 L` X \xC1 @0\x81 L` X \xC1 @0\x81 L` X \xC1 @0\x81 L` X \xC1 @0\x81 L` X \xC1 @0\x81 L` X \xC1 @0\x81 L` X \xC1 @0\x81 L` X \xC1 @0\x81 L` X \xC1 @0\x81 L` X \xC1 @0\x81 L` X \xC1 @\xB0\xEF\xA4 @Q\xCD\xCDL6g\xEBsS\xE7\xFF}~n\xFE\x83\xCEo\x9E\xE8\xFFW\xA3\xAF\xFD埩\xB6\x96\xAC\x99\xFF^\xE7\xD7\xFD\xB7,\xFD\xEE\xD2\xDA\xC0p\xA5z\xD3\xC0\xE0\xA6\x8B\xA0[\x96\xB4\xDB\xED\x85\xFFdY\x96e\xF5\xA9\xF1\xFA\xDC\xD4_\xCF\xFF\xA3\xDEw\xEE\xBAR\xD5֒Zkُ\x96\xAE\xAC
+ ׆w.,\xA2\x91\x91\x91\xD4 \xB0X\xD8ԡ\xDDo\x9C|e\xEA\xBA\xF7\xBFMT]J\xB5\xB5d\xF8\xF3[ \xBA\xFD\x91\xE1\xCDO\x87\xFF\xE5\x85 \xB0 \xCAG`qIs3\x93\xBF\xF3Wר\xAB\xBE\xAESZ?{\xF0\xA9^\xFB Q`\x94\x8F\xC0\xE2ԧ\xC6\xF7\xD7\xF7MW\x9BI\xFE\xF5u\x8Dʓ\xB5=\xBD\xF3ѡ\xC0( \xDF\xE4+\xEAS\xE3C;\xAA\xEBN\x8C\xA6\xAA\xAB,˦\xAB\xCDu'F\x87vT\xEBS\xE3\xA96 \xC0\xB7!\xB0\xF8S\xEFn ]\x9E6\xAD.\xD4ɬ\x8D\xA3\xCBϜz7\xF5 \xB82\x8B,˲}\xFB\x86\xEEx\xF9\x9E#\x95\xB3\xA9\x87\\xECH\xE5\xEC
[webkit-changes] [117088] trunk/LayoutTests
Title: [117088] trunk/LayoutTests Revision 117088 Author fmal...@chromium.org Date 2012-05-15 10:18:42 -0700 (Tue, 15 May 2012) Log Message [Chromium] Unreviewed. Rebaseline svg/repaint/mask-clip-target-transform-expected.png. Patch by Florin Malita fmal...@chromium.org on 2012-05-15 * platform/chromium-mac/svg/repaint/mask-clip-target-transform-expected.png: Added. * platform/chromium-win/svg/repaint/mask-clip-target-transform-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-mac/svg/repaint/mask-clip-target-transform-expected.png trunk/LayoutTests/platform/chromium-win/svg/repaint/mask-clip-target-transform-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (117087 => 117088) --- trunk/LayoutTests/ChangeLog 2012-05-15 17:11:25 UTC (rev 117087) +++ trunk/LayoutTests/ChangeLog 2012-05-15 17:18:42 UTC (rev 117088) @@ -1,3 +1,11 @@ +2012-05-15 Florin Malita fmal...@chromium.org + +[Chromium] Unreviewed. Rebaseline svg/repaint/mask-clip-target-transform-expected.png. + +* platform/chromium-mac/svg/repaint/mask-clip-target-transform-expected.png: Added. +* platform/chromium-win/svg/repaint/mask-clip-target-transform-expected.png: Added. +* platform/chromium/test_expectations.txt: + 2012-05-15 Christophe Dumez christophe.du...@intel.com Unreviewed EFL gardening. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (117087 => 117088) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-05-15 17:11:25 UTC (rev 117087) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-05-15 17:18:42 UTC (rev 117088) @@ -1218,9 +1218,6 @@ BUGWK81217 : svg/carto.net/tabgroup.svg = PASS FAIL BUGWK81217 : svg/hixie/perf/003.xml = PASS FAIL -// Needs rebaselining after landing 76527 -BUGWK76527 WIN MAC : svg/repaint/mask-clip-target-transform.svg = IMAGE+TEXT IMAGE TEXT PASS - BUGWK81240 MAC : svg/text/bidi-reorder-value-lists.svg = PASS IMAGE+TEXT BUGWK81243 : svg/repaint/repainting-after-animation-element-removal.svg = PASS IMAGE Added: trunk/LayoutTests/platform/chromium-mac/svg/repaint/mask-clip-target-transform-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac/svg/repaint/mask-clip-target-transform-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/svg/repaint/mask-clip-target-transform-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/svg/repaint/mask-clip-target-transform-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115196] trunk/Source/WebCore
Title: [115196] trunk/Source/WebCore
Revision 115196
Author fmal...@chromium.org
Date 2012-04-25 06:45:14 -0700 (Wed, 25 Apr 2012)
Log Message
[Coverity] Uninitialized fields in RenderSVGShape constructors
https://bugs.webkit.org/show_bug.cgi?id=84749
Reviewed by Darin Adler.
Removing unused RenderSVGShape constructor and field.
No new tests - no behavior change.
* rendering/svg/RenderSVGShape.cpp:
* rendering/svg/RenderSVGShape.h:
(RenderSVGShape):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGShape.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (115195 => 115196)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 13:36:58 UTC (rev 115195)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 13:45:14 UTC (rev 115196)
@@ -1,3 +1,18 @@
+2012-04-25 Florin Malita fmal...@chromium.org
+
+[Coverity] Uninitialized fields in RenderSVGShape constructors
+https://bugs.webkit.org/show_bug.cgi?id=84749
+
+Reviewed by Darin Adler.
+
+Removing unused RenderSVGShape constructor and field.
+
+No new tests - no behavior change.
+
+* rendering/svg/RenderSVGShape.cpp:
+* rendering/svg/RenderSVGShape.h:
+(RenderSVGShape):
+
2012-04-25 'Pavel Feldman' pfeld...@chromium.org
Not reviewed: follow up to r115194, removed debug output.
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp (115195 => 115196)
--- trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp 2012-04-25 13:36:58 UTC (rev 115195)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp 2012-04-25 13:45:14 UTC (rev 115196)
@@ -62,13 +62,6 @@
{
}
-RenderSVGShape::RenderSVGShape(SVGStyledTransformableElement* node, Path* path, bool isFillFallback)
-: RenderSVGModelObject(node)
-, m_path(adoptPtr(path))
-, m_fillFallback(isFillFallback)
-{
-}
-
RenderSVGShape::~RenderSVGShape()
{
}
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGShape.h (115195 => 115196)
--- trunk/Source/WebCore/rendering/svg/RenderSVGShape.h 2012-04-25 13:36:58 UTC (rev 115195)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGShape.h 2012-04-25 13:45:14 UTC (rev 115196)
@@ -144,7 +144,6 @@
bool m_needsShapeUpdate : 1;
bool m_needsTransformUpdate : 1;
bool m_fillFallback : 1;
-bool m_strokeContainsFallBack : 1;
};
inline RenderSVGShape* toRenderSVGShape(RenderObject* object)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115053] trunk
Title: [115053] trunk
Revision 115053
Author fmal...@chromium.org
Date 2012-04-24 07:49:36 -0700 (Tue, 24 Apr 2012)
Log Message
WebCore::EventTarget::addEventListener crash
https://bugs.webkit.org/show_bug.cgi?id=84171
Source/WebCore:
Reviewed by Nikolas Zimmermann.
Test: svg/custom/use-tref-crash.svg
Adding tref target event listeners while building the shadow tree is
problematic, because SVGUseElement::buildShadowAndInstanceTree() only
sets the element instance-shadow element association at a later time.
Fortunately, buildShadowAndInstanceTree() also propagates the event
handlers (transferEventListenersToShadowTree) - so we can simply skip
them in SVGTRefElement::buildPendingResource() for shadow elements.
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::buildPendingResource):
LayoutTests:
Reviewed by Nikolas Zimmermann.
* svg/custom/use-tref-crash-expected.txt: Added.
* svg/custom/use-tref-crash.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGTRefElement.cpp
Added Paths
trunk/LayoutTests/svg/custom/use-tref-crash-expected.txt
trunk/LayoutTests/svg/custom/use-tref-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (115052 => 115053)
--- trunk/LayoutTests/ChangeLog 2012-04-24 14:47:23 UTC (rev 115052)
+++ trunk/LayoutTests/ChangeLog 2012-04-24 14:49:36 UTC (rev 115053)
@@ -1,3 +1,13 @@
+2012-04-24 Florin Malita fmal...@google.com
+
+WebCore::EventTarget::addEventListener crash
+https://bugs.webkit.org/show_bug.cgi?id=84171
+
+Reviewed by Nikolas Zimmermann.
+
+* svg/custom/use-tref-crash-expected.txt: Added.
+* svg/custom/use-tref-crash.svg: Added.
+
2012-04-24 Mikhail Naganov mnaga...@chromium.org
[Chromium] Unreviewed test expectations update.
Added: trunk/LayoutTests/svg/custom/use-tref-crash-expected.txt (0 => 115053)
--- trunk/LayoutTests/svg/custom/use-tref-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/use-tref-crash-expected.txt 2012-04-24 14:49:36 UTC (rev 115053)
@@ -0,0 +1 @@
+PASS (not crashing) -- https://bugs.webkit.org/show_bug.cgi?id=84171
Added: trunk/LayoutTests/svg/custom/use-tref-crash.svg (0 => 115053)
--- trunk/LayoutTests/svg/custom/use-tref-crash.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/use-tref-crash.svg 2012-04-24 14:49:36 UTC (rev 115053)
@@ -0,0 +1,14 @@
+?xml version=1.0 encoding=UTF-8?
+svg xmlns:svg=http://www.w3.org/2000/svg
+ xmlns=http://www.w3.org/2000/svg
+ xmlns:xlink=http://www.w3.org/1999/xlink
+
+ tref xlink:href="" id=tref/
+ use xlink:href=""
+ textPASS (not crashing) -- https://bugs.webkit.org/show_bug.cgi?id=84171/text
+
+ script
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+ /script
+/svg
Modified: trunk/Source/WebCore/ChangeLog (115052 => 115053)
--- trunk/Source/WebCore/ChangeLog 2012-04-24 14:47:23 UTC (rev 115052)
+++ trunk/Source/WebCore/ChangeLog 2012-04-24 14:49:36 UTC (rev 115053)
@@ -1,3 +1,23 @@
+2012-04-24 Florin Malita fmal...@chromium.org
+
+WebCore::EventTarget::addEventListener crash
+https://bugs.webkit.org/show_bug.cgi?id=84171
+
+Reviewed by Nikolas Zimmermann.
+
+Test: svg/custom/use-tref-crash.svg
+
+Adding tref target event listeners while building the shadow tree is
+problematic, because SVGUseElement::buildShadowAndInstanceTree() only
+sets the element instance-shadow element association at a later time.
+
+Fortunately, buildShadowAndInstanceTree() also propagates the event
+handlers (transferEventListenersToShadowTree) - so we can simply skip
+them in SVGTRefElement::buildPendingResource() for shadow elements.
+
+* svg/SVGTRefElement.cpp:
+(WebCore::SVGTRefElement::buildPendingResource):
+
2012-04-24 Kent Tamura tk...@chromium.org
Clickable area of a calendar picker indicator is too small.
Modified: trunk/Source/WebCore/svg/SVGTRefElement.cpp (115052 => 115053)
--- trunk/Source/WebCore/svg/SVGTRefElement.cpp 2012-04-24 14:47:23 UTC (rev 115052)
+++ trunk/Source/WebCore/svg/SVGTRefElement.cpp 2012-04-24 14:49:36 UTC (rev 115053)
@@ -281,9 +281,15 @@
updateReferencedText();
-m_eventListener = TargetListener::create(this, id);
-target-addEventListener(eventNames().DOMSubtreeModifiedEvent, m_eventListener.get(), false);
-target-addEventListener(eventNames().DOMNodeRemovedFromDocumentEvent, m_eventListener.get(), false);
+// Don't set up event listeners if this is a shadow tree node.
+// SVGUseElement::transferEventListenersToShadowTree() handles this task, and addEventListener()
+// expects every element instance to have an associated shadow tree element - which is not the
+// case when we land here from SVGUseElement::buildShadowTree().
+if (!isInShadowTree()) {
+m_eventListener =
[webkit-changes] [113638] trunk/Tools
Title: [113638] trunk/Tools Revision 113638 Author fmal...@chromium.org Date 2012-04-09 16:20:03 -0700 (Mon, 09 Apr 2012) Log Message Unreviewed: adding myself to committers.py. Patch by Florin Malita fmal...@chromium.org on 2012-04-09 * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (113637 => 113638) --- trunk/Tools/ChangeLog 2012-04-09 22:52:25 UTC (rev 113637) +++ trunk/Tools/ChangeLog 2012-04-09 23:20:03 UTC (rev 113638) @@ -1,3 +1,9 @@ +2012-04-09 Florin Malita fmal...@chromium.org + +Unreviewed: adding myself to committers.py. + +* Scripts/webkitpy/common/config/committers.py: + 2012-04-09 Ming Xie m...@rim.com [BlackBerry] Allow simulator to use GLES2 acceleration Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (113637 => 113638) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-04-09 22:52:25 UTC (rev 113637) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-04-09 23:20:03 UTC (rev 113638) @@ -227,6 +227,7 @@ Committer(Evan Stade, est...@chromium.org, estade), Committer(Fady Samuel, fsam...@chromium.org, fsamuel), Committer(Feng Qian, f...@chromium.org), +Committer(Florin Malita, [fmal...@chromium.org, fmal...@google.com], fmalita), Committer(Fumitoshi Ukai, u...@chromium.org, ukai), Committer(Gabor Loki, l...@webkit.org, loki04), Committer(Gabor Rapcsanyi, [rga...@webkit.org, rga...@inf.u-szeged.hu], rgabor), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
