[webkit-changes] [WebKit/WebKit] fb4a3b: Deploy RefCountedAndCanMakeWeakPtr in more places

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb4a3b26498786e683bcf32283649cafcf51b6e0
  
https://github.com/WebKit/WebKit/commit/fb4a3b26498786e683bcf32283649cafcf51b6e0
  Author: Geoffrey Garen 
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
M Source/WebCore/Modules/WebGPU/GPUBindGroupLayout.h
M Source/WebCore/Modules/WebGPU/GPUBuffer.h
M Source/WebCore/Modules/WebGPU/GPUExternalTexture.h
M Source/WebCore/Modules/WebGPU/GPUQuerySet.h
M Source/WebCore/Modules/WebGPU/GPUShaderModule.h
M Source/WebCore/Modules/WebGPU/GPUTexture.h
M Source/WebCore/Modules/WebGPU/GPUTextureView.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUAdapter.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroup.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroupLayout.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBuffer.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCommandBuffer.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCommandEncoder.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCompositorIntegration.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUComputePassEncoder.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUComputePipeline.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUDevice.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPipelineLayout.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPresentationContext.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQuerySet.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQueue.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderBundle.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderBundleEncoder.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassEncoder.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPipeline.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUSampler.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUShaderModule.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTexture.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTextureView.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUXRBinding.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUXRProjectionLayer.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUXRSubImage.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUXRView.h
M Source/WebCore/Modules/async-clipboard/ClipboardItem.h
M Source/WebCore/Modules/contact-picker/ContactsManager.h
M Source/WebCore/Modules/encryptedmedia/CDM.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemAccess.h
M Source/WebCore/Modules/fetch/FetchBodyOwner.h
M Source/WebCore/Modules/fetch/FormDataConsumer.h
M Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.h
M Source/WebCore/Modules/gamepad/Gamepad.h
M Source/WebCore/Modules/geolocation/Geolocation.h
M Source/WebCore/Modules/highlight/Highlight.h
M Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.h
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.h
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h
M Source/WebCore/Modules/mediacapabilities/MediaCapabilities.h
M Source/WebCore/Modules/mediasession/MediaSession.h
M Source/WebCore/Modules/mediastream/RTCController.h
M Source/WebCore/Modules/reporting/ReportingScope.h
M Source/WebCore/Modules/streams/WritableStream.h
M Source/WebCore/Modules/web-locks/WebLockManager.h
M Source/WebCore/Modules/web-locks/WebLockRegistry.cpp
M Source/WebCore/Modules/webxr/WebXRHand.h
M Source/WebCore/Modules/webxr/WebXRInputSource.h
M Source/WebCore/Modules/webxr/WebXRRigidTransform.h
M Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h
M Source/WebCore/animation/AnimationEffect.h
M Source/WebCore/animation/AnimationTimeline.h
M Source/WebCore/crypto/SubtleCrypto.h
M Source/WebCore/css/CSSCounterStyle.h
M Source/WebCore/css/CSSPaintCallback.h
M Source/WebCore/css/DeprecatedCSSOMValue.h
M Source/WebCore/css/StyleSheetContents.cpp
M Source/WebCore/css/StyleSheetContents.h
M Source/WebCore/dom/DataTransfer.h
M Source/WebCore/dom/EventListener.h
M Source/WebCore/dom/EventLoop.cpp
M Source/WebCore/dom/EventLoop.h
M Source/WebCore/dom/NodeIterator.h
M Source/WebCore/dom/UserGestureIndicator.h
M Source/WebCore/dom/messageports/MessagePortChannel.h
M Source/WebCore/history/HistoryItem.cpp
M Source/WebCore/history/HistoryItem.h
M Source/WebCore/html/DOMURL.h
M Source/WebCore/loader/CookieJar.h
M Source/WebCore/loader/FormSubmission.h
M Source/WebCore/loader/ResourceLoader.h
M Source/WebCore/loader/cache/CachedResourceLoader.h
M Source/WebCore/page/CaptionUserPreferences.h
M Source/WebCore/page/DOMTimer.h
M Source/WebCore/page/IntersectionObserver.h

[webkit-changes] [WebKit/WebKit] b21650: Node refcounting should prevent ref()'s that escap...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b21650be30cd366e48323bd1c5de1e42e6481dd4
  
https://github.com/WebKit/WebKit/commit/b21650be30cd366e48323bd1c5de1e42e6481dd4
  Author: Geoffrey Garen 
  Date:   2024-12-01 (Sun, 01 Dec 2024)

  Changed paths:
M Source/WebCore/dom/Node.cpp

  Log Message:
  ---
  Node refcounting should prevent ref()'s that escape the destructor
https://bugs.webkit.org/show_bug.cgi?id=283852
rdar://140730076

Reviewed by Ryosuke Niwa.

A ref that escapes the destructor is a use after free. This patch adds a
RELEASE_ASSERT to ensure the safety model at runtime.

Hilariously, the existing code was accidentally performing the debug mode
check in release builds. So this patch just standardizes the check with how
RefCounted does it, making the check more efficient in release builds.

* Source/WebCore/dom/Node.cpp:
(WebCore::Node::~Node):

Canonical link: https://commits.webkit.org/287208@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fd3b26: RefCounted should prevent ref()'s that escape the ...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd3b26ee65ebcea01c84a67adec4c5676b12b5e5
  
https://github.com/WebKit/WebKit/commit/fd3b26ee65ebcea01c84a67adec4c5676b12b5e5
  Author: Geoffrey Garen 
  Date:   2024-12-01 (Sun, 01 Dec 2024)

  Changed paths:
M Source/WTF/wtf/RefCounted.h

  Log Message:
  ---
  RefCounted should prevent ref()'s that escape the destructor
https://bugs.webkit.org/show_bug.cgi?id=283849
rdar://140727952

Reviewed by Chris Dumez.

A ref that escapes the destructor is a use after free. We already have a debug
ASSERT to help catch and diagnose this mistake in testing. This patch adds a
RELEASE_ASSERT to ensure the safety model at runtime.

* Source/WTF/wtf/RefCounted.h:
(WTF::RefCountedBase::~RefCountedBase):

Canonical link: https://commits.webkit.org/287197@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e886ba: Skip a smart pointer failure in our bindings gener...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e886babe40c804c368c31ded04887984eccd40dd
  
https://github.com/WebKit/WebKit/commit/e886babe40c804c368c31ded04887984eccd40dd
  Author: Geoffrey Garen 
  Date:   2024-11-22 (Fri, 22 Nov 2024)

  Changed paths:
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp

  Log Message:
  ---
  Skip a smart pointer failure in our bindings generator
https://bugs.webkit.org/show_bug.cgi?id=283530
rdar://140382457

Reviewed by Ryosuke Niwa and Chris Dumez.

We have some work to do in the bindings generator, but it's not productive to
block all new patches to IDL files because of it.

* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):

Canonical link: https://commits.webkit.org/286962@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 15e2f5: Added ZippedRange, and ported some improvements fr...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 15e2f508ca1a41912a0d13c510a4c5704883f2b9
  
https://github.com/WebKit/WebKit/commit/15e2f508ca1a41912a0d13c510a4c5704883f2b9
  Author: Geoffrey Garen 
  Date:   2024-11-16 (Sat, 16 Nov 2024)

  Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
M Source/WTF/wtf/HexNumber.cpp
M Source/WTF/wtf/IndexedRange.h
M Source/WTF/wtf/JSONValues.cpp
A Source/WTF/wtf/ZippedRange.h
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/RenderPipeline.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKTouchEventGenerator.mm

  Log Message:
  ---
  Added ZippedRange, and ported some improvements from it to IndexedRange
https://bugs.webkit.org/show_bug.cgi?id=283249
rdar://140054429

Reviewed by Chris Dumez.

We use these types to assist bounds-safe iteration.

* Source/WTF/WTF.xcodeproj/project.pbxproj: New header.

* Source/WTF/wtf/CMakeLists.txt: New header.

* Source/WTF/wtf/IndexedRange.h:
(WTF::BoundsCheckedIterator::begin):
(WTF::BoundsCheckedIterator::end): Use a universal reference argument type and
std::forward so that we can handle const / non-const and other variations.
Previously we only supported const&, but sometimes you want to assign while
you iterate.

(WTF::BoundsCheckedIterator::operator* const): Support non-copyable types and
avoid expensive copies by returning the universal reference type.

'auto' return values decay "T&" to "T", which often creates a copy. 'auto&&'
does not decay, and returns "T&" for "T&".

If you are as confused as I am, these sources may help you:

https://skebanga.github.io/structured-bindings/
https://devblogs.microsoft.com/oldnewthing/20201015-00/?p=104369
https://devblogs.microsoft.com/oldnewthing/20201014-00/?p=104367

(WTF::BoundsCheckedIterator::BoundsCheckedIterator):
(WTF::boundsCheckedBegin):
(WTF::boundsCheckedEnd): No need to have Collection as a part of our type;
it's only needed in our constructor.

(WTF::IndexedRangeIterator::operator*): Just use pair. Tuple is more fancy
than we need to be.

(WTF::IndexedRange::IndexedRange): Use the universal reference type.

(WTF::indexedRange): We need to use a helper function instead of instantiating
IndexedRange directly in order to trigger template argument deduction.

* Source/WTF/wtf/JSONValues.cpp: Initial use of ZippedRange.

* Source/WTF/wtf/ZippedRange.h: Added. Same as IndexedRange, except we keep
two iterators instead of an index and an iterator. There are fancier ways to
do this, but this seems to fit our needs.

Here's one fancier option:
https://github.com/alemuntoni/zip-views

(WTF::ZippedRangeIterator::ZippedRangeIterator):
(WTF::ZippedRangeIterator::operator++):
(WTF::ZippedRangeIterator::operator*):
(WTF::ZippedRangeIterator::operator== const):
(WTF::ZippedRange::ZippedRange):
(WTF::ZippedRange::begin):
(WTF::ZippedRange::end):
(WTF::zippedRange):

* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::beginRenderPass):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::Device::createRenderBundleEncoder):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::m_maxDrawCount):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::createVertexDescriptor):
* Source/WebKit/UIProcess/API/Cocoa/_WKTouchEventGenerator.mm:
(-[_WKTouchEventGenerator init]):
(-[_WKTouchEventGenerator _updateTouchPoints:window:]):
(-[_WKTouchEventGenerator touchDownAtPoints:touchCount:window:]):
(-[_WKTouchEventGenerator liftUpAtPoints:touchCount:window:]): Updated to use
indexedRange() instead of IndexedRange(), since indexedRange() is now required
for template argument deduction.

Canonical link: https://commits.webkit.org/286698@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 670d67: Re-enable -Wunsafe-buffer-usage enforcement in Jav...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 670d67bb5fd99c097102562828ef4c6ade8cd5fe
  
https://github.com/WebKit/WebKit/commit/670d67bb5fd99c097102562828ef4c6ade8cd5fe
  Author: Geoffrey Garen 
  Date:   2024-11-08 (Fri, 08 Nov 2024)

  Changed paths:
M Source/JavaScriptCore/Configurations/Base.xcconfig
M Source/WebCore/Configurations/Base.xcconfig

  Log Message:
  ---
  Re-enable -Wunsafe-buffer-usage enforcement in JavaScriptCore and WebCore
https://bugs.webkit.org/show_bug.cgi?id=282838
rdar://139518369

Reviewed by Chris Dumez.

286318@main temporarily downgraded enforcement to a -Wno-error warning.

All Apple internal post-commits bots built without any warnings, so we can
re-enable enforcement.

* Source/JavaScriptCore/Configurations/Base.xcconfig:
* Source/WebCore/Configurations/Base.xcconfig:

Canonical link: https://commits.webkit.org/286359@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6feab0: Added some missing cases of WTF_ALLOW_UNSAFE_BUFFE...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6feab009ebad1069533f590b16f2b167c5b012f0
  
https://github.com/WebKit/WebKit/commit/6feab009ebad1069533f590b16f2b167c5b012f0
  Author: Geoffrey Garen 
  Date:   2024-11-07 (Thu, 07 Nov 2024)

  Changed paths:
M Source/JavaScriptCore/Configurations/Base.xcconfig
M Source/JavaScriptCore/assembler/MacroAssembler.h
M Source/JavaScriptCore/assembler/testmasm.cpp
M Source/JavaScriptCore/b3/air/opcode_generator.rb
M Source/JavaScriptCore/b3/air/testair.cpp
M Source/JavaScriptCore/b3/testb3_1.cpp
M Source/JavaScriptCore/b3/testb3_2.cpp
M Source/JavaScriptCore/b3/testb3_3.cpp
M Source/JavaScriptCore/b3/testb3_4.cpp
M Source/JavaScriptCore/b3/testb3_5.cpp
M Source/JavaScriptCore/b3/testb3_6.cpp
M Source/JavaScriptCore/b3/testb3_7.cpp
M Source/JavaScriptCore/b3/testb3_8.cpp
M Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
M Source/JavaScriptCore/jit/GPRInfo.h
M Source/JavaScriptCore/jit/JITCodeMap.h
M Source/JavaScriptCore/jit/JITOperations.cpp
M Source/JavaScriptCore/jit/SIMDShuffle.h
M Source/JavaScriptCore/runtime/JSCell.cpp
M Source/JavaScriptCore/runtime/Uint16WithFraction.h
M Source/JavaScriptCore/tools/HeapVerifier.cpp
M Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp
M Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.h
M Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp
M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp
M Source/JavaScriptCore/wasm/generateWasmOpsHeader.py
M Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.cpp
M Source/JavaScriptCore/yarr/YarrJIT.cpp
M Source/WTF/wtf/ButterflyArray.h
M Source/WTF/wtf/FixedBitVector.h
M Source/WTF/wtf/Liveness.h
M Source/WTF/wtf/text/StringSearch.h
M Source/WebCore/Configurations/Base.xcconfig
M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp
M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp
M Source/WebCore/Modules/mediastream/SFrameUtils.cpp
M Source/WebCore/Modules/mediastream/SFrameUtils.h
M Source/WebCore/Modules/mediastream/STUNMessageParsing.cpp
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp
M Source/WebCore/Modules/webauthn/AuthenticatorAttestationResponse.cpp
M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp
M Source/WebCore/cssjit/RegisterAllocator.h
M Source/WebCore/fileapi/Blob.cpp
M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
M Source/WebCore/platform/audio/mac/AudioSessionMac.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/rendering/mac/RenderThemeMac.mm
M Source/WebCore/style/RuleSet.cpp

  Log Message:
  ---
  Added some missing cases of WTF_ALLOW_UNSAFE_BUFFER_USAGE
https://bugs.webkit.org/show_bug.cgi?id=282775
rdar://139463652

Reviewed by David Kilzer.

We had one header that #ifdef'd the closing WTF_ALLOW_UNSAFE_BUFFER_USAGE_END
incorrectly, which, in unified builds, had the effect of skipping unsafe buffer
usage warnings in subsequent files.

I fixed the closing WTF_ALLOW_UNSAFE_BUFFER_USAGE_END, and then added
WTF_ALLOW_UNSAFE_BUFFER_USAGE_END annotations to all the new files that showed
up as failures.

I'm also temporarily disabling WTF_ALLOW_UNSAFE_BUFFER_USAGE enforcement in
JSC and WebCore to ensure I get pre-commit and post-commit bot results before
re-enabling. (I left WebKit enabled because I don't want to regress on our 100%
coverage achievement, and the header was in JSC and I didn't find any new
failures in WebKit.)

* Source/JavaScriptCore/assembler/MacroAssembler.h:
* Source/JavaScriptCore/assembler/testmasm.cpp:
* Source/JavaScriptCore/b3/air/opcode_generator.rb:
* Source/JavaScriptCore/b3/air/testair.cpp:
* Source/JavaScriptCore/b3/testb3_1.cpp:
* Source/JavaScriptCore/b3/testb3_2.cpp:
* Source/JavaScriptCore/b3/testb3_3.cpp:
* Source/JavaScriptCore/b3/testb3_4.cpp:
* Source/JavaScriptCore/b3/testb3_5.cpp:
* Source/JavaScriptCore/b3/testb3_6.cpp:
* Source/JavaScriptCore/b3/testb3_7.cpp:
* Source/JavaScriptCore/b3/testb3_8.cpp:
* Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:
* Source/JavaScriptCore/jit/SIMDShuffle.h:
* Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp:
* Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.h:
* Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp:
* Source/JavaSc

[webkit-changes] [WebKit/WebKit] 238d5d: Fix the SaferCPP bot build after 286031@main

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 238d5dac981a79795488c0b33d6d83b096629e7a
  
https://github.com/WebKit/WebKit/commit/238d5dac981a79795488c0b33d6d83b096629e7a
  Author: Geoffrey Garen 
  Date:   2024-11-07 (Thu, 07 Nov 2024)

  Changed paths:
M Source/WebCore/crypto/cocoa/CryptoAlgorithmX25519Cocoa.cpp
M Source/WebCore/crypto/cocoa/CryptoKeyECMac.cpp
M Source/WebCore/crypto/cocoa/CryptoKeyOKPCocoa.cpp

  Log Message:
  ---
  Fix the SaferCPP bot build after 286031@main
https://bugs.webkit.org/show_bug.cgi?id=282483


Reviewed by Chris Dumez.

Resolved some unsafe spans in the !HAVE(SWIFT_CPP_INTEROP) code path.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/crypto/cocoa/CryptoAlgorithmEd25519Cocoa.cpp:
(WebCore::signEd25519):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmX25519Cocoa.cpp:
(WebCore::deriveBitsCoreCrypto):
* Source/WebCore/crypto/cocoa/CryptoKeyECMac.cpp:
(WebCore::CryptoKeyEC::platformExportSpki const):
(WebCore::CryptoKeyEC::platformExportPkcs8 const):
* Source/WebCore/crypto/cocoa/CryptoKeyOKPCocoa.cpp:
(WebCore::CryptoKeyOKP::importSpki):
(WebCore::CryptoKeyOKP::importPkcs8):
(WebCore::CryptoKeyOKP::generateJwkX const):

Canonical link: https://commits.webkit.org/286304@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 254d15: Finish off span adoption in RemoteGraphicsContextGL.h

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 254d15e9ef1e495f02f8f1a9e8dec6960fc4852d
  
https://github.com/WebKit/WebKit/commit/254d15e9ef1e495f02f8f1a9e8dec6960fc4852d
  Author: Geoffrey Garen 
  Date:   2024-11-07 (Thu, 07 Nov 2024)

  Changed paths:
M Source/WTF/wtf/StdLibExtras.h
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h
M 
Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h
M Tools/Scripts/generate-gpup-webgl

  Log Message:
  ---
  Finish off span adoption in RemoteGraphicsContextGL.h
https://bugs.webkit.org/show_bug.cgi?id=282709
rdar://139381582

Reviewed by Chris Dumez.

* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h: No need for
markers anymore.

* 
Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h: 
Autogenerated
(getFloatv):
(getIntegerv):
(getIntegeri_v):
(getBooleanv):
(getShaderPrecisionFormat):
(getUniformfv):
(getUniformiv):
(getUniformuiv):
(getActiveUniformBlockiv):
(getInternalformativ):

* Tools/Scripts/generate-gpup-webgl: Use safe span constructors.
(cpp_type_container.is_dynamic_span):
(cpp_type_container):
(cpp_type_container.is_array):
(cpp_array_reinterpret_cast_conversion):

* Source/WTF/wtf/StdLibExtras.h: Reversed the order of U and Extent because it
is useful to be able to specify Extent and infer U.

Canonical link: https://commits.webkit.org/286282@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cbab3e: Resolved the remaining uses of WTF_ALLOW_UNSAFE_BU...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cbab3e78a6a1b42a42b5d1a1560b97b11286e7a3
  
https://github.com/WebKit/WebKit/commit/cbab3e78a6a1b42a42b5d1a1560b97b11286e7a3
  Author: Geoffrey Garen 
  Date:   2024-11-07 (Thu, 07 Nov 2024)

  Changed paths:
M Source/WTF/wtf/Compiler.h
M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm
M Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp
M Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp
M Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm
M Source/WebKit/Platform/IPC/JSIPCBinding.h
M Source/WebKit/Platform/IPC/StreamConnectionEncoder.h
M Source/WebKit/Platform/IPC/glib/ArgumentCodersGlib.h
M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp
M Source/WebKit/Platform/IPC/unix/UnixMessage.h
M Source/WebKit/Shared/API/c/skia/WKImageSkia.h
M Source/WebKit/Shared/API/glib/WebKitURIRequest.cpp
M 
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h
M 
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm
M Source/WebKit/Shared/RTCNetwork.h
M Source/WebKit/Shared/RTCPacketOptions.h
M Source/WebKit/Shared/RTCWebKitEncodedFrameInfo.h
M Source/WebKit/Shared/WebCoreArgumentCoders.h
M Source/WebKit/Shared/libwpe/NativeWebTouchEventLibWPE.cpp
M Source/WebKit/Shared/libwpe/WebEventFactory.cpp
M Source/WebKit/Shared/linux/WebMemorySamplerLinux.cpp
M Source/WebKit/Shared/skia/CoreIPCSkColorSpace.h
M Source/WebKit/Shared/skia/CoreIPCSkData.h
M Source/WebKit/Shared/unix/AuxiliaryProcessMain.cpp
M Source/WebKit/UIProcess/API/C/glib/WKTextCheckerGLib.cpp
M Source/WebKit/UIProcess/API/glib/WebKitContextMenuClient.cpp
M Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp
M Source/WebKit/UIProcess/API/glib/WebKitFileChooserRequest.cpp
M Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp
M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp
M Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp
M Source/WebKit/UIProcess/API/glib/WebKitUserContent.cpp
M Source/WebKit/UIProcess/API/glib/WebKitUserContentFilterStore.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp
M Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp
M Source/WebKit/UIProcess/API/gtk/WebKitInputMethodContextImplGtk.cpp
M Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp
M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
M Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp
M Source/WebKit/UIProcess/Automation/skia/WebAutomationSessionSkia.cpp
M Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorClient.cpp
M Source/WebKit/UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp
M Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp
M Source/WebKit/UIProcess/Launcher/glib/FlatpakLauncher.cpp
M Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp
M Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp
M Source/WebKit/UIProcess/Notifications/glib/NotificationService.cpp
M Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp
M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
M Source/WebKit/UIProcess/gtk/ClipboardGtk4.cpp
M Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp
M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp
M Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitScriptWorld.cpp
M 
Source/WebKit/WebProcess/InjectedBundle/API/glib/WebProcessExtensionManager.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCDnsResolverFactory.h
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.h
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.h
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.h
M Source/WebKit/WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp
M Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp
M Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.h

  Log Message:
  ---
  Resolved the remaining uses of WTF_ALLOW_UNSAFE_BUFFER_USAGE_BEGIN in 
/WebKit/ in Apple ports
https://bugs.webkit.org/show_bug.cgi?id=282730
rdar://139395062

Reviewed by Chris Dumez.

You can now audit WebKit by searching for the regex

WTF_ALLOW_UNSAFE_BUFFER_USAGE_BEGIN(?! //.*port)

and it should turn up no results.

Fixed one or two remaining unsafe buffer uses.

Added a WTF_IGNORE_WARNINGS_IN_THIRD_PARTY_CODE_BEGIN/_END to d

[webkit-changes] [WebKit/WebKit] 99002f: Encapsulate g_jscConfig and g_wtfConfig a tiny bit

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99002f45c0c0b19808461a325ca0aacfdcdc9b16
  
https://github.com/WebKit/WebKit/commit/99002f45c0c0b19808461a325ca0aacfdcdc9b16
  Author: Geoffrey Garen 
  Date:   2024-11-06 (Wed, 06 Nov 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/JSCConfig.h
M Source/WTF/wtf/WTFConfig.h
M 
Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUServiceEntryPoint.mm

  Log Message:
  ---
  Encapsulate g_jscConfig and g_wtfConfig a tiny bit
https://bugs.webkit.org/show_bug.cgi?id=282673
rdar://139334844

Reviewed by Chris Dumez.

These macros trigger bounds safety warnings in lots of places.

They are indeed written in an unsafe style, and we should fix that; but callers
don't pass indexing parameters into these macros, so warning about them at call
sites isn't useful.

I did one test removal of a warning suppression in this patch, to prove it 
works.

* Source/JavaScriptCore/runtime/JSCConfig.h:
(JSC::addressOfJSCConfig):
* Source/WTF/wtf/WTFConfig.h:
(WTF::addressOfWTFConfig):
* Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUServiceEntryPoint.mm:
(GPU_SERVICE_INITIALIZER):

Canonical link: https://commits.webkit.org/286222@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 00c493: Re-land 286031@main (67602317a964)

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00c493c9bfa27c8745a47cbb699f6ad88c5a7528
  
https://github.com/WebKit/WebKit/commit/00c493c9bfa27c8745a47cbb699f6ad88c5a7528
  Author: Geoffrey Garen 
  Date:   2024-11-05 (Tue, 05 Nov 2024)

  Changed paths:
M Source/WebCore/Configurations/Base.xcconfig

  Log Message:
  ---
  Re-land 286031@main (67602317a964)
https://bugs.webkit.org/show_bug.cgi?id=282619
rdar://139292382

Unreviewed, re-landing.

Internal builders no longer report warnings in WebCore, as far as I
can tell.

* Source/WebCore/Configurations/Base.xcconfig:

Canonical link: https://commits.webkit.org/286179@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a3abee: Re-land 286030@main (df3193fce7c7)

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a3abee3cfc50bb2c27f14a8e8237988a84a3c675
  
https://github.com/WebKit/WebKit/commit/a3abee3cfc50bb2c27f14a8e8237988a84a3c675
  Author: Geoffrey Garen 
  Date:   2024-11-05 (Tue, 05 Nov 2024)

  Changed paths:
M Source/JavaScriptCore/Configurations/Base.xcconfig

  Log Message:
  ---
  Re-land 286030@main (df3193fce7c7)
https://bugs.webkit.org/show_bug.cgi?id=282617
rdar://139291505

Unreviewed, re-landing.

Internal builders no longer report warnings in JavaScriptCore, as far as I
can tell.

* Source/JavaScriptCore/Configurations/Base.xcconfig:

Canonical link: https://commits.webkit.org/286171@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 56bf85: v2 Skip a few more unsafe buffer usage warnings

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 56bf85f218c6d57d18c8d56a62908fa0d46f3857
  
https://github.com/WebKit/WebKit/commit/56bf85f218c6d57d18c8d56a62908fa0d46f3857
  Author: Geoffrey Garen 
  Date:   2024-11-04 (Mon, 04 Nov 2024)

  Changed paths:
M Source/JavaScriptCore/KeywordLookupGenerator.py
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M Source/WebCore/bindings/scripts/test/JS/JSTestDerivedDictionary.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestDerivedDictionary2.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestDictionary.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestDictionaryNoToNative.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestDictionaryWithOnlyConditionalMembers.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestEmptyDictionary.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestInheritedDictionary.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestInheritedDictionary2.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp

  Log Message:
  ---
  v2 Skip a few more unsafe buffer usage warnings
https://bugs.webkit.org/show_bug.cgi?id=282573
rdar://139244029

Reviewed by David Kilzer.

* Source/JavaScriptCore/KeywordLookupGenerator.py:
(Trie.printAsC):
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionaryImplementation):

Canonical link: https://commits.webkit.org/286135@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6ce7c2: Skip a few more unsafe buffer usage warnings

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ce7c207f2533580e85b981dcb1793a12a2baf34
  
https://github.com/WebKit/WebKit/commit/6ce7c207f2533580e85b981dcb1793a12a2baf34
  Author: Geoffrey Garen 
  Date:   2024-11-04 (Mon, 04 Nov 2024)

  Changed paths:
M Source/JavaScriptCore/generator/DSL.rb
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONEnum.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp
M Source/WebCore/editing/cocoa/DataDetection.mm

  Log Message:
  ---
  Skip a few more unsafe buffer usage warnings
https://bugs.webkit.org/show_bug.cgi?id=282556
rdar://139229772

Reviewed by Chris Dumez.

* Source/JavaScriptCore/generator/DSL.rb:
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateEnumerationImplementation):
* Source/WebCore/editing/cocoa/DataDetection.mm:

Canonical link: https://commits.webkit.org/286120@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8f7893: Build fix for MediaRecorderPrivateEncoder in recen...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8f78933a3164d21c547e2d88c91d44f1a798f46b
  
https://github.com/WebKit/WebKit/commit/8f78933a3164d21c547e2d88c91d44f1a798f46b
  Author: Geoffrey Garen 
  Date:   2024-11-04 (Mon, 04 Nov 2024)

  Changed paths:
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateEncoder.cpp
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateEncoder.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateMock.cpp
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateMock.h

  Log Message:
  ---
  Build fix for MediaRecorderPrivateEncoder in recent clang toolchains
https://bugs.webkit.org/show_bug.cgi?id=282549
rdar://139216339

Reviewed by Chris Dumez.

MediaRecorderPrivateEncoder tells the compiler "You can only use m_mimeType
inside a scope in which you assertIsMainThread()".

Recent versions of clang notice that this scope ends when a function returns,
so, in the mimeType() accessor, it is an error to return a reference to 
m_mimeType.

The simplest fix for now seems to be to return String instead of String&.

Latern on, maybe we can annotate the accessor in a way that shows the compiler
that assertIsMainThread() continues to be true after we return.

* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateEncoder.h:

Canonical link: https://commits.webkit.org/286111@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f09e61: Partially re-landing 286031@main (67602317a964) & ...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f09e61868a2a2bd8b269176105ea6e2b231b82c0
  
https://github.com/WebKit/WebKit/commit/f09e61868a2a2bd8b269176105ea6e2b231b82c0
  Author: Geoffrey Garen 
  Date:   2024-11-03 (Sun, 03 Nov 2024)

  Changed paths:
M Source/JavaScriptCore/Configurations/Base.xcconfig
M Source/WebCore/Configurations/Base.xcconfig

  Log Message:
  ---
  Partially re-landing 286031@main (67602317a964) & 286030@main (df3193fce7c7)
https://bugs.webkit.org/show_bug.cgi?id=282516


Unreviewed, re-landing.

Re-land with -Werror enforcement disabled, so we can gather a comprehensive
list of warnings from post-commit bots, and then resolve them.

Partially re-landed change:

Enable -Wunsafe-buffer-usage in WebCore
https://bugs.webkit.org/show_bug.cgi?id=282406
rdar://137810622
286031@main (67602317a964)

Partially re-landed change:

Enable -Wunsafe-buffer-usage in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=282405
rdar://137810623
286030@main (df3193fce7c7)

Canonical link: https://commits.webkit.org/286065@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f5478d: Build fix for some Apple internal bots

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5478d9ee0c44575582ea6cb20319ef98c734a2c
  
https://github.com/WebKit/WebKit/commit/f5478d9ee0c44575582ea6cb20319ef98c734a2c
  Author: Geoffrey Garen 
  Date:   2024-11-03 (Sun, 03 Nov 2024)

  Changed paths:
M Source/WTF/wtf/IndexedRange.h

  Log Message:
  ---
  Build fix for some Apple internal bots
https://bugs.webkit.org/show_bug.cgi?id=282513
rdar://139160864

Unreviewed, build fix.

Some versions of libc++ use an unqualified call to 'begin()' when e.g.
instantiating a span.

In some contexts that creates a name conflict with WTF::begin because of
argument-dependent lookup.

Rename begin/end to boundsCheckedBegin/boundsCheckedEnd to fix this.

* Source/WTF/wtf/IndexedRange.h:
(WTF::boundsCheckedBegin):
(WTF::boundsCheckedEnd):
(WTF::IndexedRange::IndexedRange):
(WTF::begin): Deleted.
(WTF::end): Deleted.

Canonical link: https://commits.webkit.org/286062@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 22aa3d: More span adoption in IPC MessageHandlers

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22aa3d40e84f9aa40c420f76baf6109a860061ce
  
https://github.com/WebKit/WebKit/commit/22aa3d40e84f9aa40c420f76baf6109a860061ce
  Author: Geoffrey Garen 
  Date:   2024-11-03 (Sun, 03 Nov 2024)

  Changed paths:
M Source/WTF/wtf/MallocSpan.h
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
M Source/WebKit/Platform/IPC/ArrayReferenceTuple.h

  Log Message:
  ---
  More span adoption in IPC MessageHandlers
https://bugs.webkit.org/show_bug.cgi?id=282495
rdar://139133937

Reviewed by Chris Dumez.

* Source/WTF/wtf/MallocSpan.h:
(WTF::MallocSpan::operator bool const):
(WTF::MallocSpan::operator! const):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::WebCore::vectorCopyCast):
(WebKit::RemoteGraphicsContextGL::getBufferSubDataInline):
(WebKit::RemoteGraphicsContextGL::readPixelsInline):
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
* Source/WebKit/Platform/IPC/ArrayReferenceTuple.h:
(IPC::ArrayReferenceTuple::span const):

Canonical link: https://commits.webkit.org/286061@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 460abf: IndexedRange is unsafe to use with temporaries

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 460abf576622806c66767e3ac5c9f01ee912070e
  
https://github.com/WebKit/WebKit/commit/460abf576622806c66767e3ac5c9f01ee912070e
  Author: Geoffrey Garen 
  Date:   2024-11-03 (Sun, 03 Nov 2024)

  Changed paths:
M Source/WTF/wtf/IndexedRange.h

  Log Message:
  ---
  IndexedRange is unsafe to use with temporaries
https://bugs.webkit.org/show_bug.cgi?id=282503
rdar://139127354

Reviewed by Mike Wyrzykowski and Chris Dumez.

This was technically undef:

for (auto [ index, value ] : IndexedRange(std::span(collection))) { ... }

because IndexedRange kept a reference to its constructor argument, which was
a destroyed temporary.

The solution has three parts:

1. Use an IndexedRange(Collection&&) overload to detect construction with a
temporary.

2. Store begin() / end() iterators instead of a reference to the collection.
This eliminates the reference to a destroyed temporary -- but adds use of
an iterator after invalidation. Yayboo.

3. static_assert that the temporary supports std::ranges::borrowed_range,
which makes use of an iterator after invalidation well-defined. Yay.

* Source/WTF/wtf/IndexedRange.h:
(WTF::IndexedRange::IndexedRange):
(WTF::IndexedRange::begin):
(WTF::IndexedRange::end):

Canonical link: https://commits.webkit.org/286060@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 635a07: A little bit more safety for BoundsCheckedIterator

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 635a079e5128f24a69f90de3141943153e46e5bb
  
https://github.com/WebKit/WebKit/commit/635a079e5128f24a69f90de3141943153e46e5bb
  Author: Geoffrey Garen 
  Date:   2024-11-02 (Sat, 02 Nov 2024)

  Changed paths:
M Source/WTF/wtf/IndexedRange.h

  Log Message:
  ---
  A little bit more safety for BoundsCheckedIterator
https://bugs.webkit.org/show_bug.cgi?id=282493
rdar://139127354

Reviewed by Chris Dumez.

Make the BoundsCheckedIterator constructor private because, similar to the two
argument span constructor, it can't guarantee that the iterator belongs to the
collection.

Helper functions for constructing begin() and end() can offer that guarantee.

* Source/WTF/wtf/IndexedRange.h:
(WTF::BoundsCheckedIterator::begin):
(WTF::BoundsCheckedIterator::end):
(WTF::BoundsCheckedIterator::BoundsCheckedIterator):
(WTF::IndexedRange::IndexedRange):
(WTF::IndexedRange::begin):
(WTF::IndexedRange::end):

Canonical link: https://commits.webkit.org/286059@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3817fe: IndexedRangeIterator should be safer

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3817fe4c0b26d13f04c3b692e14d193308fa3c50
  
https://github.com/WebKit/WebKit/commit/3817fe4c0b26d13f04c3b692e14d193308fa3c50
  Author: Geoffrey Garen 
  Date:   2024-11-01 (Fri, 01 Nov 2024)

  Changed paths:
M Source/WTF/wtf/IndexedRange.h

  Log Message:
  ---
  IndexedRangeIterator should be safer
https://bugs.webkit.org/show_bug.cgi?id=282472
rdar://139101044

Reviewed by Chris Dumez.

I originally built IndexedRangeIterator assuming you would only use it inside
a range-based for loop that implicitly checks the end iterator.

But no mechanism actually prevents a programmer from using it directly and not
checking the end iterator.

So I added explicit checks.

Testing locally in some toy examples shows that clang -O3 evaporates all the
checks when the iterator is used as intended.

* Source/WTF/wtf/IndexedRange.h:
(WTF::BoundsCheckedIterator::BoundsCheckedIterator):
(WTF::BoundsCheckedIterator::operator++):
(WTF::BoundsCheckedIterator::operator* const):
(WTF::BoundsCheckedIterator::operator== const):
(WTF::IndexedRangeIterator::IndexedRangeIterator):
(WTF::IndexedRange::IndexedRange):
(WTF::IndexedRange::begin):
(WTF::IndexedRange::end):

Canonical link: https://commits.webkit.org/286046@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 676023: Enable -Wunsafe-buffer-usage in WebCore

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67602317a9642dce33a46bbe4ff849fe1a97e88d
  
https://github.com/WebKit/WebKit/commit/67602317a9642dce33a46bbe4ff849fe1a97e88d
  Author: Geoffrey Garen 
  Date:   2024-11-01 (Fri, 01 Nov 2024)

  Changed paths:
M Source/WebCore/Configurations/Base.xcconfig

  Log Message:
  ---
  Enable -Wunsafe-buffer-usage in WebCore
https://bugs.webkit.org/show_bug.cgi?id=282406
rdar://137810622

Reviewed by David Kilzer.

* Source/WebCore/Configurations/Base.xcconfig:

Canonical link: https://commits.webkit.org/286031@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] df3193: Enable -Wunsafe-buffer-usage in JavaScriptCore

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df3193fce7c7e80b8ca345021fe00a682ce01b43
  
https://github.com/WebKit/WebKit/commit/df3193fce7c7e80b8ca345021fe00a682ce01b43
  Author: Geoffrey Garen 
  Date:   2024-11-01 (Fri, 01 Nov 2024)

  Changed paths:
M Source/JavaScriptCore/Configurations/Base.xcconfig

  Log Message:
  ---
  Enable -Wunsafe-buffer-usage in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=282405
rdar://137810623

Reviewed by David Kilzer.

* Source/JavaScriptCore/Configurations/Base.xcconfig:

Canonical link: https://commits.webkit.org/286030@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0d723d: Updated bindings expectations after 286022@main

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d723d86354d898759715cee796b6f2d818dc9d8
  
https://github.com/WebKit/WebKit/commit/0d723d86354d898759715cee796b6f2d818dc9d8
  Author: Geoffrey Garen 
  Date:   2024-11-01 (Fri, 01 Nov 2024)

  Changed paths:
M Source/WebCore/bindings/scripts/test/JS/JSDOMWindow.cpp
M Source/WebCore/bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.cpp
M Source/WebCore/bindings/scripts/test/JS/JSExposedStar.cpp
M Source/WebCore/bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp
M Source/WebCore/bindings/scripts/test/JS/JSPaintWorkletGlobalScope.cpp
M Source/WebCore/bindings/scripts/test/JS/JSServiceWorkerGlobalScope.cpp
M Source/WebCore/bindings/scripts/test/JS/JSShadowRealmGlobalScope.cpp
M Source/WebCore/bindings/scripts/test/JS/JSSharedWorkerGlobalScope.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestAsyncIterable.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestAsyncKeyValueIterable.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestCallTracer.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestConditionalIncludes.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSON.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestDelegateToSharedSyntheticAttribute.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestDomainSecurity.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestEnabledForContext.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestGenerateAddOpaqueRoot.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestIterable.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestMapLike.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverri

[webkit-changes] [WebKit/WebKit] f8f959: v4 skip markers for JavaScriptCore and WebCore fil...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8f95922e779698a4014fc17d6823b1ad967e9f5
  
https://github.com/WebKit/WebKit/commit/f8f95922e779698a4014fc17d6823b1ad967e9f5
  Author: Geoffrey Garen 
  Date:   2024-11-01 (Fri, 01 Nov 2024)

  Changed paths:
M Source/JavaScriptCore/API/tests/JSONParseTest.cpp
M Source/JavaScriptCore/API/tests/testapi.cpp
M Source/JavaScriptCore/bytecode/InstructionStream.h
M Source/JavaScriptCore/bytecode/StructureSet.h
M Source/JavaScriptCore/dfg/testdfg.cpp
M Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h
M Source/JavaScriptCore/disassembler/X86Disassembler.cpp
M Source/JavaScriptCore/disassembler/zydis/Zydis/Zycore.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreAllocator.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreAllocator.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreBitset.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreBitset.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreComparison.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreFormat.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreFormat.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreLibC.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreList.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreList.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreObject.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreStatus.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreString.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreString.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreTypes.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreVector.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreVector.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/Zydis.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoderData.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoderTypes.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisFormatter.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisFormatter.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisFormatterATT.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisFormatterBase.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisFormatterBuffer.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisFormatterBuffer.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisFormatterIntel.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisInternalDecoderData.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisInternalFormatterATT.h
M 
Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisInternalFormatterBase.h
M 
Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisInternalFormatterIntel.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisInternalSharedData.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisInternalString.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisMetaInfo.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisMetaInfo.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisMnemonic.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisMnemonic.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisRegister.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisRegister.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisSharedData.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisSharedTypes.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisShortString.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisStatus.h
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisString.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisUtils.c
M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisUtils.h
M Source/JavaScriptCore/dynbench.cpp
M Source/JavaScriptCore/heap/AbstractSlotVisitorInlines.h
M Source/JavaScriptCore/heap/SlotVisitorInlines.h
M Source/JavaScriptCore/interpreter/CallFrameInlines.h
M Source/JavaScriptCore/jsc.cpp
M Source/JavaScriptCore/parser/Parser.h
M Source/JavaScriptCore/runtime/BigInteger.h
M Source/JavaScriptCore/testRegExp.cpp
M Source/WTF/wtf/BubbleSort.h
M Source/WTF/wtf/BumpPointerAllocator.h
M Source/WTF/wtf/ConcurrentBuffer.h
M Source/WTF/wtf/ConcurrentVector.h
M Source/WTF/wtf/EnumTraits.h
M Source/WTF/wtf/ListDump.h
M Source/WTF/wtf/SmallSet.h
M Source/WTF/wtf/TinyPtrSet.h
M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp
M Source/WebCore/Modules/WebGPU/GPUQueue.cpp
M Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp
M Source/WebCore/Modules/indexeddb/

[webkit-changes] [WebKit/WebKit] f687b5: Renamed unsafeForgeSpan to unsafeMakeSpan

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f687b57a0a69304a15a8689a9609bcf493981887
  
https://github.com/WebKit/WebKit/commit/f687b57a0a69304a15a8689a9609bcf493981887
  Author: Geoffrey Garen 
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/IntlCollator.cpp
M Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp
M Source/JavaScriptCore/runtime/IntlLocale.cpp
M Source/JavaScriptCore/runtime/IntlObject.cpp
M Source/JavaScriptCore/runtime/IntlPluralRules.cpp
M Source/JavaScriptCore/tools/FunctionAllowlist.cpp
M Source/JavaScriptCore/tools/FunctionOverrides.cpp
M Source/WTF/wtf/BitSet.h
M Source/WTF/wtf/MallocSpan.h
M Source/WTF/wtf/StdLibExtras.h
M Source/WTF/wtf/cocoa/SpanCocoa.mm
M Source/WTF/wtf/glib/GSpanExtras.h
M Source/WTF/wtf/text/ASCIILiteral.h
M Source/WTF/wtf/text/StringCommon.h
M Source/WTF/wtf/text/StringImpl.cpp
M Source/WebGPU/WebGPU/Buffer.mm
M Source/WebGPU/WebGPU/ComputePassEncoder.mm
M Source/WebGPU/WebGPU/Queue.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/WebGPU.h
M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm
M Source/WebKit/NetworkProcess/cache/NetworkCacheDataCocoa.mm
M Source/WebKit/Shared/API/APIData.h
M Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm
M Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectInterface.mm
M Source/WebKit/Shared/API/c/WKArray.cpp
M Source/WebKit/Shared/API/c/WKData.cpp
M Source/WebKit/Shared/API/c/WKDictionary.cpp
M Source/WebKit/Shared/API/c/WKString.cpp
M 
Source/WebKit/Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonEntryPoint.mm
M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
M Source/WebKit/Shared/mac/WebMemorySampler.mac.mm
M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
M Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidConnection.mm
M Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp
M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
M 
Source/WebKit/WebProcess/Extensions/Bindings/Scripts/CodeGeneratorExtensions.pm
M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp
M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp
M Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFScriptEvaluation.mm
M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp

  Log Message:
  ---
  Renamed unsafeForgeSpan to unsafeMakeSpan
https://bugs.webkit.org/show_bug.cgi?id=282411
rdar://139032153

Reviewed by Simon Fraser and Chris Dumez.

People found "forge" to be awkward.

* Source/JavaScriptCore/runtime/IntlCollator.cpp:
(JSC::IntlCollator::sortLocaleData):
* Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::localeData):
* Source/JavaScriptCore/runtime/IntlLocale.cpp:
(JSC::IntlLocale::calendars):
(JSC::IntlLocale::collations):
* Source/JavaScriptCore/runtime/IntlObject.cpp:
(JSC::intlAvailableCalendars):
(JSC::availableCollations):
(JSC::availableCurrencies):
(JSC::intlAvailableTimeZones):
* Source/JavaScriptCore/runtime/IntlPluralRules.cpp:
(JSC::IntlPluralRules::resolvedOptions const):
* Source/JavaScriptCore/tools/FunctionAllowlist.cpp:
(JSC::FunctionAllowlist::FunctionAllowlist):
* Source/JavaScriptCore/tools/FunctionOverrides.cpp:
(JSC::parseClause):
* Source/WTF/wtf/BitSet.h:
* Source/WTF/wtf/MallocSpan.h:
(WTF::MallocSpan::realloc):
(WTF::MallocSpan::MallocSpan):
* Source/WTF/wtf/StdLibExtras.h:
(WTF::unsafeMakeSpan):
(WTF::asByteSpan):
(WTF::asMutableByteSpan):
(WTF::unsafeForgeSpan): Deleted.
* Source/WTF/wtf/cocoa/SpanCocoa.mm:
(WTF::dispatch_data_apply_span):
* Source/WTF/wtf/glib/GSpanExtras.h:
(WTF::span):
* Source/WTF/wtf/text/ASCIILiteral.h:
(WTF::StringLiterals::operator_span):
* Source/WTF/wtf/text/StringCommon.h:
(WTF::span):
(WTF::span8):
(WTF::span8IncludingNullTerminator):
* Source/WTF/wtf/text/StringImpl.cpp:
(WTF::StringImpl::createUninitializedInternalNonEmpty):
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::span):
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(wgpuComputePassEncoderSetBindGroup):
* Source/WebGPU/WebGPU/Queue.mm:
(wgpuQueueSubmit):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::makeSpanFromBuffer):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(wgpuRenderPassEncoderExecuteBundles):
(wgpuRenderPassEncoderSetBindGroup):
* Source/WebGPU/WebGPU/WebGPU.h:
(WGPUPipelineLayoutDescriptor::bindGroupLayoutsSpan const):
(WGPURenderBundleEncoderDescriptor::colorFormatsSpan const):
(WGPUBindGroupDescriptor::entriesSpan const):
(WGPUProgrammableStageDescriptor::constantsSpan const):
(WGPUShaderModuleDescriptor::hintsSpan const):
(WGPUT

[webkit-changes] [WebKit/WebKit] 73db6b: v3 skip markers for JavaScriptCore and WebCore fil...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73db6bd1b70f04009cb233cc59c74e385465813c
  
https://github.com/WebKit/WebKit/commit/73db6bd1b70f04009cb233cc59c74e385465813c
  Author: Geoffrey Garen 
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
M Source/WTF/wtf/AccessibleAddress.h
M Source/WebCore/css/process-css-pseudo-selectors.py
M Source/WebCore/dom/make_names.pl
M Source/WebCore/testing/MockLibWebRTCPeerConnection.h

  Log Message:
  ---
  v3 skip markers for JavaScriptCore and WebCore files that do not conform to 
-Wunsafe-buffer-usage
https://bugs.webkit.org/show_bug.cgi?id=282400
rdar://139019533

Reviewed by David Kilzer.

Found a few more.

* Source/WTF/wtf/AccessibleAddress.h:
* Source/WebCore/css/process-css-pseudo-selectors.py:
* Source/WebCore/dom/make_names.pl:
(printTagNameCppFile):
(printNodeNameCppFile):
* Source/WebCore/testing/MockLibWebRTCPeerConnection.h:

Canonical link: https://commits.webkit.org/285971@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4325dc: v2 skip markers for JavaScriptCore and WebCore fil...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4325dcb2ad6bc01dff33efa9c56cdc383bfcee33
  
https://github.com/WebKit/WebKit/commit/4325dcb2ad6bc01dff33efa9c56cdc383bfcee33
  Author: Geoffrey Garen 
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
M Source/JavaScriptCore/API/tests/CompareAndSwapTest.cpp
M Source/JavaScriptCore/API/tests/JSNode.c
M Source/JavaScriptCore/API/tests/minidom.c
M Source/JavaScriptCore/runtime/DataView.h
M Source/JavaScriptCore/testmem/testmem.mm
M Source/WTF/wtf/FlipBytes.h
M Source/WTF/wtf/ParallelJobs.h
M Source/WTF/wtf/SegmentedVector.h
M Source/WTF/wtf/SequenceLocked.h
M Source/WTF/wtf/TinyLRUCache.h
M Source/WTF/wtf/text/FastCharacterComparison.h
M Source/WTF/wtf/text/StringParsingBuffer.h
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUBufferImpl.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUShaderModuleImpl.cpp
M Source/WebCore/contentextensions/ContentExtensionActions.cpp
M Source/WebCore/contentextensions/ContentExtensionsBackend.cpp
M Source/WebCore/css/process-css-properties.py
M Source/WebCore/platform/PlatformMediaError.cpp
M Source/WebCore/platform/audio/AudioBus.cpp
M Source/WebCore/platform/audio/AudioChannel.cpp
M Source/WebCore/platform/audio/AudioResamplerKernel.cpp
M Source/WebCore/platform/audio/AudioUtilities.cpp
M Source/WebCore/platform/audio/Biquad.cpp
M Source/WebCore/platform/audio/DirectConvolver.cpp
M Source/WebCore/platform/audio/DownSampler.cpp
M Source/WebCore/platform/audio/DynamicsCompressor.cpp
M Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp
M Source/WebCore/platform/audio/ReverbAccumulationBuffer.cpp
M Source/WebCore/platform/audio/ReverbConvolverStage.cpp
M Source/WebCore/platform/audio/ReverbInputBuffer.cpp
M Source/WebCore/platform/audio/StereoPanner.cpp
M Source/WebCore/platform/audio/UpSampler.cpp
M Source/WebCore/platform/cf/KeyedDecoderCF.cpp
M Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm
M Source/WebCore/platform/graphics/FontSelectionAlgorithm.cpp
M Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm
M Source/WebCore/platform/graphics/transforms/TransformOperation.cpp
M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp
M Source/WebCore/platform/ios/WebAVPlayerController.mm
M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.cpp
M Source/WebCore/platform/mac/KeyEventMac.mm
M Source/WebCore/platform/mac/PasteboardMac.mm
M Source/WebCore/platform/mac/ThemeMac.mm
M Source/WebCore/platform/mac/ThreadCheck.mm
M Source/WebCore/platform/mediastream/RealtimeIncomingAudioSource.h
M Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDTMFSenderBackend.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.cpp
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.h
M Source/WebCore/platform/network/HTTPHeaderMap.cpp
M Source/WebCore/platform/network/HTTPParsers.cpp
M Source/WebCore/platform/network/RFC8941.cpp
M Source/WebCore/platform/network/create-http-header-name-table
M Source/WebCore/platform/sql/SQLiteFileSystem.cpp
M Source/WebCore/platform/sql/SQLiteStatement.cpp
M Source/WebCore/platform/text/DateTimeFormat.cpp
M Source/WebCore/platform/text/PlatformLocale.cpp
M Source/WebCore/platform/text/SegmentedString.cpp
M Source/WebCore/platform/text/mac/CoreTextChineseCompositionEngine.cpp
M Source/WebCore/platform/video-codecs/cocoa/RTCVideoDecoderVTBAV1.mm
M Source/WebCore/platform/video-codecs/cocoa/WebRTCVideoDecoder.mm
M Source/WebCore/xml/XPathGrammar.cpp
M Source/WebCore/xml/XPathGrammar.h
M Source/WebCore/xml/XPathGrammar.y

  Log Message:
  ---
  v2 skip markers for JavaScriptCore and WebCore files that do not conform to 
-Wunsafe-buffer-usage
https://bugs.webkit.org/show_bug.cgi?id=282368
rdar://138964110

Reviewed by David Kilzer.

Found some more.

* Source/JavaScriptCore/API/tests/CompareAndSwapTest.cpp:
* Source/JavaScriptCore/API/tests/JSNode.c:
* Source/JavaScriptCore/API/tests/minidom.c:
* Source/JavaScriptCore/runtime/DataView.h:
* Source/JavaScriptCore/testmem/testmem.mm:
* Source/WTF/wtf/FlipBytes.h:
* Source/WTF/wtf/ParallelJobs.h:
* Source/WTF/wtf/SegmentedVector.h:
* Source/WTF/wtf/SequenceLocked.h:
* Source/WTF/wtf/TinyLRUCache.h:
* Source/WTF/wtf/text/FastCharacterComparison.h:
* Source/WTF/wtf/text/StringParsingBuffer.h:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUBufferImpl.cpp:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp:
* Source/WebCore/Modules/WebGPU/Imple

[webkit-changes] [WebKit/WebKit] b94261: Added skip markers for JavaScriptCore and WebCore ...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b942617ff39a1ce246ae7c51069796a20dc9b353
  
https://github.com/WebKit/WebKit/commit/b942617ff39a1ce246ae7c51069796a20dc9b353
  Author: Geoffrey Garen 
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
M Source/JavaScriptCore/API/JSClassRef.cpp
M Source/JavaScriptCore/API/JSContext.mm
M Source/JavaScriptCore/API/JSObjectRef.cpp
M Source/JavaScriptCore/API/JSScriptRef.cpp
M Source/JavaScriptCore/API/JSStringRef.cpp
M Source/JavaScriptCore/API/JSStringRefCF.cpp
M Source/JavaScriptCore/API/JSTypedArray.cpp
M Source/JavaScriptCore/API/JSValue.mm
M Source/JavaScriptCore/API/JSWrapperMap.mm
M Source/JavaScriptCore/API/MarkedJSValueRefArray.cpp
M Source/JavaScriptCore/API/MarkedJSValueRefArray.h
M Source/JavaScriptCore/API/ObjCCallbackFunction.mm
M Source/JavaScriptCore/API/ObjcRuntimeExtras.h
M Source/JavaScriptCore/API/tests/CustomGlobalObjectClassTest.c
M Source/JavaScriptCore/API/tests/TypedArrayCTest.cpp
M Source/JavaScriptCore/API/tests/testapi.c
M Source/JavaScriptCore/assembler/ARM64Assembler.h
M Source/JavaScriptCore/assembler/AssemblerBuffer.h
M Source/JavaScriptCore/assembler/CPU.cpp
M Source/JavaScriptCore/assembler/FastJITPermissions.h
M Source/JavaScriptCore/assembler/JITOperationList.cpp
M Source/JavaScriptCore/assembler/LinkBuffer.cpp
M Source/JavaScriptCore/assembler/LinkBuffer.h
M Source/JavaScriptCore/assembler/MacroAssembler.h
M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h
M Source/JavaScriptCore/assembler/MacroAssemblerARM64E.h
M Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp
M Source/JavaScriptCore/assembler/PerfLog.cpp
M Source/JavaScriptCore/assembler/ProbeContext.h
M Source/JavaScriptCore/assembler/ProbeStack.cpp
M Source/JavaScriptCore/assembler/ProbeStack.h
M Source/JavaScriptCore/assembler/SecureARM64EHashPins.cpp
M Source/JavaScriptCore/assembler/SecureARM64EHashPins.h
M Source/JavaScriptCore/assembler/SecureARM64EHashPinsInlines.h
M Source/JavaScriptCore/b3/B3AtomicValue.h
M Source/JavaScriptCore/b3/B3CCallValue.h
M Source/JavaScriptCore/b3/B3CheckValue.h
M Source/JavaScriptCore/b3/B3Const128Value.cpp
M Source/JavaScriptCore/b3/B3ExtractValue.h
M Source/JavaScriptCore/b3/B3LowerMacros.cpp
M Source/JavaScriptCore/b3/B3LowerToAir.cpp
M Source/JavaScriptCore/b3/B3MemoryValue.h
M Source/JavaScriptCore/b3/B3MoveConstants.cpp
M Source/JavaScriptCore/b3/B3PatchpointValue.h
M Source/JavaScriptCore/b3/B3ReduceStrength.cpp
M Source/JavaScriptCore/b3/B3SIMDValue.h
M Source/JavaScriptCore/b3/B3SwitchValue.h
M Source/JavaScriptCore/b3/B3UpsilonValue.h
M Source/JavaScriptCore/b3/B3Value.cpp
M Source/JavaScriptCore/b3/B3Value.h
M Source/JavaScriptCore/b3/B3ValueKey.cpp
M Source/JavaScriptCore/b3/B3ValueKey.h
M Source/JavaScriptCore/b3/B3ValueKeyInlines.h
M Source/JavaScriptCore/b3/B3VariableValue.h
M Source/JavaScriptCore/b3/B3WasmAddressValue.h
M Source/JavaScriptCore/b3/B3WasmBoundsCheckValue.h
M 
Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp
M Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackByLinearScan.cpp
M Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp
M Source/JavaScriptCore/b3/air/AirDisassembler.cpp
M Source/JavaScriptCore/b3/air/AirFixPartialRegisterStalls.cpp
M Source/JavaScriptCore/b3/air/AirLowerMacros.cpp
M Source/JavaScriptCore/builtins/BuiltinExecutables.cpp
M 
Source/JavaScriptCore/bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp
M Source/JavaScriptCore/bytecode/ArrayProfile.h
M Source/JavaScriptCore/bytecode/BytecodeDumper.cpp
M Source/JavaScriptCore/bytecode/BytecodeGraph.h
M Source/JavaScriptCore/bytecode/BytecodeRewriter.cpp
M Source/JavaScriptCore/bytecode/BytecodeRewriter.h
M Source/JavaScriptCore/bytecode/CodeBlock.cpp
M Source/JavaScriptCore/bytecode/CodeBlock.h
M Source/JavaScriptCore/bytecode/CodeBlockHash.cpp
M Source/JavaScriptCore/bytecode/ExpressionInfo.cpp
M Source/JavaScriptCore/bytecode/ExpressionInfo.h
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/Instruction.h
M Source/JavaScriptCore/bytecode/MetadataTable.cpp
M Source/JavaScriptCore/bytecode/MetadataTable.h
M Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.h
M Source/JavaScriptCore/bytecode/Opcode.cpp
M Source/JavaScriptCore/bytecode/ReduceWhitespace.cpp
M Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.cpp
M Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h
M Source/JavaScriptCore/bytecode/UnlinkedMetadataTableInlines.h
M Source/JavaScriptCore/bytecode/ValueProfile.h
M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
M Sou

[webkit-changes] [WebKit/WebKit] c65738: Enable -Wunsafe-buffer-usage in WebInspectorUI

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c65738315dbc0746b5a4ab918749852551e71821
  
https://github.com/WebKit/WebKit/commit/c65738315dbc0746b5a4ab918749852551e71821
  Author: Geoffrey Garen 
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
M Source/WebInspectorUI/Configurations/Base.xcconfig

  Log Message:
  ---
  Enable -Wunsafe-buffer-usage in WebInspectorUI
https://bugs.webkit.org/show_bug.cgi?id=282245
rdar://137810561

Reviewed by Chris Dumez.

* Source/WebInspectorUI/Configurations/Base.xcconfig:

Canonical link: https://commits.webkit.org/285853@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] db7b20: Enable -Wunsafe-buffer-usage in WebCore/PAL

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db7b208cc2700705b099cc204deb64321368a13f
  
https://github.com/WebKit/WebKit/commit/db7b208cc2700705b099cc204deb64321368a13f
  Author: Geoffrey Garen 
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
M Source/WebCore/PAL/Configurations/Base.xcconfig
M Source/WebCore/PAL/pal/PALSwift.h
M Source/WebCore/PAL/pal/avfoundation/OutputContext.mm
M Source/WebCore/PAL/pal/cocoa/Gunzip.cpp
M Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp
M Source/WebCore/PAL/pal/text/DecodeEscapeSequences.h
M Source/WebCore/PAL/pal/text/EncodingTables.cpp
M Source/WebCore/PAL/pal/text/TextCodecASCIIFastPath.h
M Source/WebCore/PAL/pal/text/TextCodecCJK.cpp
M Source/WebCore/PAL/pal/text/TextCodecICU.cpp
M Source/WebCore/PAL/pal/text/TextCodecLatin1.cpp
M Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp
M Source/WebCore/PAL/pal/text/TextCodecUTF16.cpp
M Source/WebCore/PAL/pal/text/TextCodecUTF8.cpp
M Source/WebCore/PAL/pal/text/TextCodecUserDefined.cpp
M Source/WebCore/PAL/pal/text/TextEncodingDetectorICU.cpp
M Source/WebCore/PAL/pal/text/TextEncodingRegistry.cpp

  Log Message:
  ---
  Enable -Wunsafe-buffer-usage in WebCore/PAL
https://bugs.webkit.org/show_bug.cgi?id=28
rdar://137810571

Reviewed by Chris Dumez.

Added skip markers for non-conforming files.

* Source/WebCore/PAL/Configurations/Base.xcconfig:
* Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:
* Source/WebCore/PAL/pal/cocoa/Gunzip.cpp:
* Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp:
* Source/WebCore/PAL/pal/text/DecodeEscapeSequences.h:
* Source/WebCore/PAL/pal/text/EncodingTables.cpp:
* Source/WebCore/PAL/pal/text/TextCodecASCIIFastPath.h:
* Source/WebCore/PAL/pal/text/TextCodecCJK.cpp:
* Source/WebCore/PAL/pal/text/TextCodecICU.cpp:
* Source/WebCore/PAL/pal/text/TextCodecLatin1.cpp:
* Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp:
* Source/WebCore/PAL/pal/text/TextCodecUTF16.cpp:
* Source/WebCore/PAL/pal/text/TextCodecUTF8.cpp:
* Source/WebCore/PAL/pal/text/TextCodecUserDefined.cpp:
* Source/WebCore/PAL/pal/text/TextEncodingDetectorICU.cpp:
* Source/WebCore/PAL/pal/text/TextEncodingRegistry.cpp:

Canonical link: https://commits.webkit.org/285826@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7b4e25: Finish off smart pointer adoption in WebCore/Modul...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b4e2500f1524427c596d5362ee5008dba8a
  
https://github.com/WebKit/WebKit/commit/7b4e2500f1524427c596d5362ee5008dba8a
  Author: Geoffrey Garen 
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.h
M 
Source/WebCore/Modules/WebGPU/Implementation/WebGPUComputePassEncoderImpl.cpp
M 
Source/WebCore/Modules/WebGPU/Implementation/WebGPUComputePassEncoderImpl.h
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.cpp
M 
Source/WebCore/Modules/WebGPU/Implementation/WebGPUPresentationContextImpl.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.cpp
M 
Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.cpp
M 
Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.h
M 
Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderPassEncoderImpl.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderPassEncoderImpl.h
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUTextureImpl.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUXRBindingImpl.cpp
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroupDescriptor.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBufferBinding.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCanvasConfiguration.h
M 
Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUComputePassTimestampWrites.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUImageCopyBuffer.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUImageCopyTexture.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPipelineDescriptorBase.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUProgrammableStage.h
M 
Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassColorAttachment.h
M 
Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDepthStencilAttachment.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDescriptor.h
M 
Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassTimestampWrites.h
M Source/WebGPU/WebGPU/ExternalTexture.h
M Source/WebGPU/WebGPU/ExternalTexture.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.h
M Source/WebKit/Shared/WebGPU/WebGPUBindGroupDescriptor.cpp
M Source/WebKit/Shared/WebGPU/WebGPUBindGroupEntry.cpp
M Source/WebKit/Shared/WebGPU/WebGPUBufferBinding.cpp
M Source/WebKit/Shared/WebGPU/WebGPUCanvasConfiguration.cpp
M Source/WebKit/Shared/WebGPU/WebGPUComputePassTimestampWrites.cpp
M Source/WebKit/Shared/WebGPU/WebGPUImageCopyBuffer.cpp
M Source/WebKit/Shared/WebGPU/WebGPUImageCopyTexture.cpp
M Source/WebKit/Shared/WebGPU/WebGPUPipelineDescriptorBase.cpp
M Source/WebKit/Shared/WebGPU/WebGPUProgrammableStage.cpp
M Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.cpp
M Source/WebKit/Shared/WebGPU/WebGPURenderPassDepthStencilAttachment.cpp
M Source/WebKit/Shared/WebGPU/WebGPURenderPassDescriptor.cpp
M Source/WebKit/Shared/WebGPU/WebGPURenderPassTimestampWrites.cpp

  Log Message:
  ---
  Finish off smart pointer adoption in WebCore/Modules/WebGPU/Implementation
https://bugs.webkit.org/show_bug.cgi?id=282207
rdar://138794979

Reviewed by Mike Wyrzykowski.

Static analysis told me to.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp:
(WebCore::WebGPU::CommandEncoderImpl::beginRenderPass):
(WebCore::WebGPU::CommandEncoderImpl::beginComputePass):
(WebCore::WebGPU::CommandEncoderImpl::copyBufferToBuffer):
(WebCore::WebGPU::CommandEncoderImpl::copyBufferToTexture):
(WebCore::WebGPU::CommandEncoderImpl::copyTextureToBuffer):
(WebCore::WebGPU::CommandEncoderImpl::copyTextureToTexture):
(WebCore::WebGPU::CommandEncoderImpl::clearBuffer):
(WebCore::WebGPU::CommandEncoderImpl::writeTimestamp):
(WebCore::WebGPU::CommandEncoderImpl::resolveQuerySet):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.h:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUComputePassEncoderImpl.cpp:
(WebCore::WebGPU::ComputePassEncoderImpl::setPipeline):
(WebCore::WebGPU::ComputePassEncoderImpl::dispatchIndirect):
(WebCore::WebGPU::ComputePassEncoderImpl::setBindGroup):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUComputePassEncoderImpl.h:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp:
(WebCore::WebGPU::DeviceImpl::createBuffer):
(WebCore::WebGPU::DeviceImpl::createTexture):
(WebCore::WebGPU::DeviceImpl::createSampler):
(WebCore::WebGPU::DeviceImpl::createBindGroup):
(WebCore::WebGPU::DeviceImpl::createShaderModule):
(WebCore::WebGPU::convertToBacking):
(WebCore::WebGPU::DeviceImpl::createRenderBundleEncode

[webkit-changes] [WebKit/WebKit] 3af977: WebGPU, heap-use-after-free in in WebGPU::Device::...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3af977b5f7ffe871816bd6f826380eee28ff3561
  
https://github.com/WebKit/WebKit/commit/3af977b5f7ffe871816bd6f826380eee28ff3561
  Author: Geoffrey Garen 
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
M Source/WebGPU/WebGPU/Adapter.h
M Source/WebGPU/WebGPU/Device.h
M Source/WebGPU/WebGPU/Device.mm

  Log Message:
  ---
  WebGPU, heap-use-after-free in in WebGPU::Device::instance()
https://bugs.webkit.org/show_bug.cgi?id=282177
rdar://138765627

Reviewed by Mike Wyrzykowski.

Avoid using Adapter on a secondary thread since it's single-threaded. We can
store Instance directly, since that's thread-safe.

* Source/WebGPU/WebGPU/Adapter.h:
(WebGPU::Adapter::weakInstance const):
* Source/WebGPU/WebGPU/Device.h:
(WebGPU::Device::instance const):
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::Device):

Canonical link: https://commits.webkit.org/285774@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7a71be: Enable -Wunsafe-buffer-usage in WTF

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a71befb39c7b1bc3e0dac9d557dc18f83253c11
  
https://github.com/WebKit/WebKit/commit/7a71befb39c7b1bc3e0dac9d557dc18f83253c11
  Author: Geoffrey Garen 
  Date:   2024-10-27 (Sun, 27 Oct 2024)

  Changed paths:
M Source/WTF/Configurations/Base.xcconfig
M Source/WTF/wtf/Assertions.cpp
M Source/WTF/wtf/BitVector.cpp
M Source/WTF/wtf/CodePtr.h
M Source/WTF/wtf/Compiler.h
M Source/WTF/wtf/ConcurrentPtrHashSet.cpp
M Source/WTF/wtf/ConcurrentPtrHashSet.h
M Source/WTF/wtf/DataLog.cpp
M Source/WTF/wtf/DateMath.cpp
M Source/WTF/wtf/DateMath.h
M Source/WTF/wtf/FastBitVector.cpp
M Source/WTF/wtf/FastBitVector.h
M Source/WTF/wtf/FastFloat.cpp
M Source/WTF/wtf/FileSystem.cpp
M Source/WTF/wtf/FunctionPtr.h
M Source/WTF/wtf/Gigacage.h
M Source/WTF/wtf/HexNumber.cpp
M Source/WTF/wtf/JSONValues.cpp
M Source/WTF/wtf/ParkingLot.cpp
M Source/WTF/wtf/PtrTag.cpp
M Source/WTF/wtf/PtrTag.h
M Source/WTF/wtf/RefCounted.cpp
M Source/WTF/wtf/RefTrackerMixin.cpp
M Source/WTF/wtf/SHA1.cpp
M Source/WTF/wtf/SIMDUTF.cpp
M Source/WTF/wtf/SixCharacterHash.cpp
M Source/WTF/wtf/StackBounds.cpp
M Source/WTF/wtf/StackBounds.h
M Source/WTF/wtf/StackShotProfiler.h
M Source/WTF/wtf/StringPrintStream.cpp
M Source/WTF/wtf/URL.cpp
M Source/WTF/wtf/URLHelpers.cpp
M Source/WTF/wtf/URLParser.cpp
M Source/WTF/wtf/UUID.cpp
M Source/WTF/wtf/WTFConfig.cpp
M Source/WTF/wtf/WTFConfig.h
M Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm
M Source/WTF/wtf/cocoa/NSURLExtras.mm
M Source/WTF/wtf/cocoa/SystemTracingCocoa.cpp
M Source/WTF/wtf/darwin/OSLogPrintStream.mm
M Source/WTF/wtf/dragonbox/detail/cache_holder.h
M Source/WTF/wtf/dragonbox/detail/policy.h
M Source/WTF/wtf/dragonbox/dragonbox_to_chars.cpp
M Source/WTF/wtf/dragonbox/dragonbox_to_chars.h
M Source/WTF/wtf/dtoa.cpp
M Source/WTF/wtf/dtoa/bignum.cc
M Source/WTF/wtf/dtoa/cached-powers.cc
M Source/WTF/wtf/dtoa/double-conversion.cc
M Source/WTF/wtf/dtoa/fast-dtoa.cc
M Source/WTF/wtf/dtoa/strtod.cc
M Source/WTF/wtf/fast_float/ascii_number.h
M Source/WTF/wtf/fast_float/bigint.h
M Source/WTF/wtf/fast_float/decimal_to_binary.h
M Source/WTF/wtf/fast_float/digit_comparison.h
M Source/WTF/wtf/fast_float/float_common.h
M Source/WTF/wtf/persistence/PersistentCoders.cpp
M Source/WTF/wtf/persistence/PersistentDecoder.cpp
M Source/WTF/wtf/persistence/PersistentEncoder.cpp
M Source/WTF/wtf/persistence/PersistentEncoder.h
M Source/WTF/wtf/posix/FileSystemPOSIX.cpp
M Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp
M Source/WTF/wtf/posix/ThreadingPOSIX.cpp
M Source/WTF/wtf/text/AdaptiveStringSearcher.h
M Source/WTF/wtf/text/AtomString.cpp
M Source/WTF/wtf/text/AtomStringImpl.cpp
M Source/WTF/wtf/text/Base64.cpp
M Source/WTF/wtf/text/Base64.h
M Source/WTF/wtf/text/CString.cpp
M Source/WTF/wtf/text/IntegerToStringConversion.h
M Source/WTF/wtf/text/LineEnding.cpp
M Source/WTF/wtf/text/StringBuilder.cpp
M Source/WTF/wtf/text/StringBuilderInternals.h
M Source/WTF/wtf/text/StringBuilderJSON.cpp
M Source/WTF/wtf/text/StringBuilderJSON.h
M Source/WTF/wtf/text/StringCommon.cpp
M Source/WTF/wtf/text/StringImpl.cpp
M Source/WTF/wtf/text/StringView.cpp
M Source/WTF/wtf/text/WTFString.cpp
M Source/WTF/wtf/text/WYHash.h
M Source/WTF/wtf/text/cf/AtomStringImplCF.cpp
M Source/WTF/wtf/text/cf/StringImplCF.cpp
M Source/WTF/wtf/text/cocoa/ContextualizedNSString.mm
M Source/WTF/wtf/text/icu/UTextProvider.cpp
M Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp
M Source/WTF/wtf/threads/Signals.cpp
M Source/WTF/wtf/unicode/UTF8Conversion.cpp
M Source/WTF/wtf/unicode/icu/CollatorICU.cpp
M Source/WTF/wtf/unicode/icu/ICUHelpers.cpp
M Source/bmalloc/bmalloc/BCompiler.h
M Source/bmalloc/bmalloc/Gigacage.h
M Source/bmalloc/bmalloc/TZoneHeapManager.cpp
M Source/bmalloc/bmalloc/VMAllocate.h
M Source/bmalloc/bmalloc/bmalloc.h
M Source/bmalloc/libpas/src/libpas/pas_platform.h
M Source/bmalloc/libpas/src/libpas/pas_thread_suspend_lock.h

  Log Message:
  ---
  Enable -Wunsafe-buffer-usage in WTF
https://bugs.webkit.org/show_bug.cgi?id=282081
rdar://137810587

Reviewed by Chris Dumez.

Added skip markers to files that do not yet conform.

* Source/WTF/Configurations/Base.xcconfig:
* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/Assertions.cpp:
* Source/WTF/wtf/BitVector.cpp:
* Source/WTF/wtf/CodePtr.h:
* Source/WTF/wtf/ConcurrentPtrHashSet.cpp:
* Source/WTF/wtf/ConcurrentPtrHashSet.h:
* Source/WTF/wtf/DataLog.cpp:
* Source/WTF/wtf/DateMath.cpp:
* Source/WTF/wtf/DateMath.h:
* Source/WTF/wtf/FastBitVector.cpp:
* Source/WTF/wtf/FastBitVector.h:
* Source/WTF/wtf/FastFloat.cpp:
* Source/WTF/wtf

[webkit-changes] [WebKit/WebKit] ee90c1: Finish off smart pointer coverage in WebGPU

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee90c1745f1a38eb48656cbf01916274168c7984
  
https://github.com/WebKit/WebKit/commit/ee90c1745f1a38eb48656cbf01916274168c7984
  Author: Geoffrey Garen 
  Date:   2024-10-27 (Sun, 27 Oct 2024)

  Changed paths:
M Source/WebCore/Modules/WebGPU/GPUPipelineLayoutDescriptor.h
M Source/WebCore/Modules/WebGPU/GPUQueue.cpp
M Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.h
M 
Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderPassEncoderImpl.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderPassEncoderImpl.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPipelineLayoutDescriptor.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQueue.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassEncoder.h
M Source/WebGPU/WebGPU/Adapter.h
M Source/WebGPU/WebGPU/BindGroup.h
M Source/WebGPU/WebGPU/BindGroup.mm
M Source/WebGPU/WebGPU/Buffer.h
M Source/WebGPU/WebGPU/Buffer.mm
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/CommandsMixin.mm
M Source/WebGPU/WebGPU/ComputePassEncoder.mm
M Source/WebGPU/WebGPU/ComputePipeline.mm
M Source/WebGPU/WebGPU/Device.h
M Source/WebGPU/WebGPU/Device.mm
M Source/WebGPU/WebGPU/ExternalTexture.mm
M Source/WebGPU/WebGPU/Pipeline.mm
M Source/WebGPU/WebGPU/PipelineLayout.mm
M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
M Source/WebGPU/WebGPU/QuerySet.mm
M Source/WebGPU/WebGPU/Queue.h
M Source/WebGPU/WebGPU/Queue.mm
M Source/WebGPU/WebGPU/RenderBundle.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.h
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/RenderPipeline.h
M Source/WebGPU/WebGPU/RenderPipeline.mm
M Source/WebGPU/WebGPU/ShaderModule.mm
M Source/WebGPU/WebGPU/Texture.h
M Source/WebGPU/WebGPU/Texture.mm
M Source/WebGPU/WebGPU/TextureView.mm
M Source/WebGPU/WebGPU/XRBinding.h
M Source/WebGPU/WebGPU/XRBinding.mm
M Source/WebGPU/WebGPU/XRProjectionLayer.mm
M Source/WebGPU/WebGPU/XRSubImage.mm
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebKit/Shared/WebGPU/WebGPUPipelineLayoutDescriptor.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.h

  Log Message:
  ---
  Finish off smart pointer coverage in WebGPU
https://bugs.webkit.org/show_bug.cgi?id=282145
rdar://138712492

Reviewed by Mike Wyrzykowski.

Fixed the remaining static analyzer complaints.

I skipped false positives to do with the implementations of RefCounted,
ThreadSafeRefCounted, String, and Thread.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.cpp:
(WebCore::WebGPU::QueueImpl::submit):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.h:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderPassEncoderImpl.cpp:
(WebCore::WebGPU::RenderPassEncoderImpl::executeBundles):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderPassEncoderImpl.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQueue.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassEncoder.h:
* Source/WebGPU/WebGPU/Adapter.h:
* Source/WebGPU/WebGPU/BindGroup.h:
(WebGPU::BindGroup::bindGroupLayout const):
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::BindGroup::rebindSamplersIfNeeded const):
(WebGPU::BindGroup::bindGroupLayout const): Deleted.
* Source/WebGPU/WebGPU/Buffer.h:
(WebGPU::Buffer::indirectIndexedBuffer const):
(WebGPU::Buffer::isDestroyed const):
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Buffer::incrementBufferMapCount):
(WebGPU::Buffer::decrementBufferMapCount):
(WebGPU::Buffer::destroy):
(WebGPU::Buffer::isDestroyed const): Deleted.
(WebGPU::Buffer::indirectIndexedBuffer const): Deleted.
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::discardCommandBuffer):
(WebGPU::CommandEncoder::copyBufferToTexture):
* Source/WebGPU/WebGPU/CommandsMixin.mm:
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::executePreDispatchCommands):
(WebGPU::ComputePassEncoder::setBindGroup):
* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::ComputePipeline::getBindGroupLayout):
* Source/WebGPU/WebGPU/Device.h:
(WebGPU::Device::instance const):
(WebGPU::Device::maxBuffersPlusVertexBuffersForVertexStage const):
(WebGPU::Device::maxBuffersForFragmentS

[webkit-changes] [WebKit/WebKit] d45649: Work around -Wunsafe-buffer-usage warnings in mig-...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d45649fa32a499702c30474e94bd6843c4c67849
  
https://github.com/WebKit/WebKit/commit/d45649fa32a499702c30474e94bd6843c4c67849
  Author: Geoffrey Garen 
  Date:   2024-10-27 (Sun, 27 Oct 2024)

  Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj

  Log Message:
  ---
  Work around -Wunsafe-buffer-usage warnings in mig-generated files by invoking 
mig manually and post-processing the results
https://bugs.webkit.org/show_bug.cgi?id=282138
rdar://138704307

Reviewed by Keith Miller.

I considered passing extra compiler flags to Xcode's built-in Mig build step,
but that has no effect (rdar://138572990).

* Source/WTF/WTF.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/285743@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1ae2a8: 285731@main broke Apple Internal tvOS builds

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ae2a8be06f29795c0bbd5ca4c6c12276bb2cda9
  
https://github.com/WebKit/WebKit/commit/1ae2a8be06f29795c0bbd5ca4c6c12276bb2cda9
  Author: Geoffrey Garen 
  Date:   2024-10-27 (Sun, 27 Oct 2024)

  Changed paths:
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  ---
  285731@main broke Apple Internal tvOS builds
https://bugs.webkit.org/show_bug.cgi?id=282152
rdar://138715837

Unreviewed, build fix.

Bracket unsafe span construction.

FIXME: We should make safe helper functions instead.

* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::registerLogHook):

Canonical link: https://commits.webkit.org/285741@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5d5797: Smart pointer adoption in WebGPU/Adapter.mm etc.

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d5797f2c90f26393f60171a79aed5d6717bbe4b
  
https://github.com/WebKit/WebKit/commit/5d5797f2c90f26393f60171a79aed5d6717bbe4b
  Author: Geoffrey Garen 
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
M Source/WebGPU/WebGPU/BindGroup.h
M Source/WebGPU/WebGPU/BindGroup.mm
M Source/WebGPU/WebGPU/Buffer.h
M Source/WebGPU/WebGPU/Buffer.mm
M Source/WebGPU/WebGPU/CommandBuffer.h
M Source/WebGPU/WebGPU/CommandBuffer.mm
M Source/WebGPU/WebGPU/CommandEncoder.h
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/ComputePassEncoder.h
M Source/WebGPU/WebGPU/ComputePassEncoder.mm
M Source/WebGPU/WebGPU/ComputePipeline.h
M Source/WebGPU/WebGPU/ComputePipeline.mm
M Source/WebGPU/WebGPU/Device.h
M Source/WebGPU/WebGPU/Device.mm

  Log Message:
  ---
  Smart pointer adoption in WebGPU/Adapter.mm etc.
https://bugs.webkit.org/show_bug.cgi?id=281921


Reviewed by Mike Wyrzykowski.

Static analysis told me to.

* Source/WebGPU/WebGPU/BindGroup.h:
(WebGPU::BindGroup::protectedDevice const):
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createExternalTextureFromPixelBuffer const):
(WebGPU::Device::createBindGroup):
(WebGPU::BindGroup::updateExternalTextures):
* Source/WebGPU/WebGPU/Buffer.h:
(WebGPU::Buffer::protectedDevice const):
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Buffer::destroy):
(WebGPU::Buffer::mapAsync):
(WebGPU::Buffer::unmap):
* Source/WebGPU/WebGPU/CommandBuffer.h:
(WebGPU::CommandBuffer::setBufferMapCount):
(WebGPU::CommandBuffer::bufferMapCount const):
* Source/WebGPU/WebGPU/CommandBuffer.mm:
(WebGPU::CommandBuffer::~CommandBuffer):
(WebGPU::CommandBuffer::makeInvalid):
(WebGPU::CommandBuffer::setBufferMapCount): Deleted.
(WebGPU::CommandBuffer::bufferMapCount const): Deleted.
* Source/WebGPU/WebGPU/CommandEncoder.h:
(WebGPU::CommandEncoder::protectedCachedCommandBuffer const):
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::Device::createCommandEncoder):
(WebGPU::CommandEncoder::~CommandEncoder):
(WebGPU::CommandEncoder::ensureBlitCommandEncoder):
(WebGPU::errorValidatingTimestampWrites):
(WebGPU::CommandEncoder::setExistingEncoder):
(WebGPU::CommandEncoder::discardCommandBuffer):
(WebGPU::CommandEncoder::endEncoding):
(WebGPU::CommandEncoder::runClearEncoder):
(WebGPU::CommandEncoder::encoderIsCurrent const):
(WebGPU::CommandEncoder::makeInvalid):
(WebGPU::CommandEncoder::makeSubmitInvalid):
(WebGPU::CommandEncoder::clearBuffer):
(WebGPU::CommandEncoder::finish):
(WebGPU::CommandEncoder::writeTimestamp):
* Source/WebGPU/WebGPU/Device.h:
(WebGPU::Device::getQueue const):
(WebGPU::Device::protectedQueue const):
(WebGPU::Device::isValid const):
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::getQueue): Deleted.
(WebGPU::Device::isValid const): Deleted.

Canonical link: https://commits.webkit.org/285584@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 513843: Enforce -Wunsafe-buffer-usage in Source/WebGPU

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5138438b500796279ab122bbcce0c1af840579d0
  
https://github.com/WebKit/WebKit/commit/5138438b500796279ab122bbcce0c1af840579d0
  Author: Geoffrey Garen 
  Date:   2024-10-21 (Mon, 21 Oct 2024)

  Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
M Source/WTF/wtf/Compiler.h
M Source/WTF/wtf/FastFloat.cpp
M Source/WTF/wtf/FastFloat.h
A Source/WTF/wtf/IndexedRange.h
M Source/WTF/wtf/ReferenceWrapperVector.h
M Source/WTF/wtf/dtoa/utils.h
M Source/WebGPU/Configurations/Base.xcconfig
M Source/WebGPU/WGSL/AST/ASTBinaryExpression.h
M Source/WebGPU/WGSL/AST/ASTBuilder.cpp
M Source/WebGPU/WGSL/AST/ASTBuilder.h
M Source/WebGPU/WGSL/AST/ASTUnaryExpression.h
M Source/WebGPU/WGSL/Lexer.cpp
M Source/WebGPU/WGSL/MangleNames.cpp
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/Types.h
M Source/WebGPU/WebGPU/Adapter.mm
M Source/WebGPU/WebGPU/BindGroup.mm
M Source/WebGPU/WebGPU/BindGroupLayout.h
M Source/WebGPU/WebGPU/BindGroupLayout.mm
M Source/WebGPU/WebGPU/Buffer.mm
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/ComputePassEncoder.h
M Source/WebGPU/WebGPU/ComputePassEncoder.mm
M Source/WebGPU/WebGPU/ComputePipeline.mm
M Source/WebGPU/WebGPU/Pipeline.h
M Source/WebGPU/WebGPU/Pipeline.mm
M Source/WebGPU/WebGPU/PipelineLayout.mm
M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
M Source/WebGPU/WebGPU/Queue.mm
M Source/WebGPU/WebGPU/RenderBundle.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.h
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/RenderPipeline.mm
M Source/WebGPU/WebGPU/ShaderModule.mm
M Source/WebGPU/WebGPU/Texture.mm
M Source/WebGPU/WebGPU/WebGPU.h

  Log Message:
  ---
  Enforce -Wunsafe-buffer-usage in Source/WebGPU
https://bugs.webkit.org/show_bug.cgi?id=281792
rdar://138218909

Reviewed by Mike Wyrzykowski.

Added an IndexedRange class so you can access the iteration index in
a safe range-based for loop:

for (auto [ index, value ] : IndexedRange(collection)) { ... }

Deployed std::array and std::span in lots of places.

Added a parseHexDouble helper because, hilariously, it is the year 2024
and there is no bounds-check aware option for hex parsing of 16bit
characters in C or C++.

I chose to make xxxSpan() member functions for most WGPU API types, rather than
modifying the types themselves, in order to keep the existing API stable
and reduce the scope of change.

* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/CMakeLists.txt:
* Source/WTF/wtf/Compiler.h:
* Source/WTF/wtf/IndexedRange.h: Added.
(WTF::IndexedRangeIterator::IndexedRangeIterator):
(WTF::IndexedRangeIterator::operator++):
(WTF::IndexedRangeIterator::operator*):
(WTF::IndexedRangeIterator::operator== const):
(WTF::IndexedRange::IndexedRange):
(WTF::IndexedRange::begin):
(WTF::IndexedRange::end):
* Source/WTF/wtf/ReferenceWrapperVector.h:
(WTF::ReferenceWrapperVectorIterator::operator++):
(WTF::ReferenceWrapperVectorIterator::operator--):
(WTF::ReferenceWrapperVectorConstIterator::operator++):
(WTF::ReferenceWrapperVectorConstIterator::operator--):
* Source/WTF/wtf/dtoa/utils.h:
* Source/WebGPU/Configurations/Base.xcconfig:
* Source/WebGPU/WGSL/AST/ASTBinaryExpression.h:
(WGSL::AST::toASCIILiteral):
* Source/WebGPU/WGSL/AST/ASTBuilder.cpp:
(WGSL::AST::Builder::Builder):
(WGSL::AST::Builder::allocateArena):
(WGSL::AST::Builder::saveCurrentState):
(WGSL::AST::Builder::restore):
(WGSL::AST::Builder::arena): Deleted.
* Source/WebGPU/WGSL/AST/ASTBuilder.h:
(WGSL::AST::Builder::construct):
* Source/WebGPU/WGSL/AST/ASTUnaryExpression.h:
(WGSL::AST::toASCIILiteral):
* Source/WebGPU/WGSL/MangleNames.cpp:
(WGSL::MangledName::toString const):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser::maybeSplitToken):
* Source/WebGPU/WGSL/Types.h:
(WGSL::Types::PrimitiveStruct::>>):
* Source/WebGPU/WebGPU/Adapter.mm:
(WebGPU::Adapter::requestDevice):
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createExternalTextureFromPixelBuffer const):
(WebGPU::Device::createBindGroup):
* Source/WebGPU/WebGPU/BindGroupLayout.h:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
(WebGPU::BindGroupLayout::errorValidatingDynamicOffsets const):
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::span):
(WebGPU::Buffer::getMappedRange):
(WebGPU::Buffer::getBufferContents):
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::beginRenderPass):
* Source/WebGPU/WebGPU/ComputePassEncoder.h:
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::setBindGroup):
(wgpuComputePassEncoderSetBindGroup):
* Source/WebGPU/WebGPU/ComputePipeline.mm:
* Source/WebGPU/WebGPU/Pipeline.h:
* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::createLibrary):
* Source/We

[webkit-changes] [WebKit/WebKit] 820c41: Adopt -Wunsafe-buffer-usage in WebPageProxy.cpp etc.

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 820c41526f721e4c6dd43200f5353ce204b87e14
  
https://github.com/WebKit/WebKit/commit/820c41526f721e4c6dd43200f5353ce204b87e14
  Author: Geoffrey Garen 
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
M Source/WTF/wtf/StdLibExtras.h
M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm
M 
Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp
M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  ---
  Adopt -Wunsafe-buffer-usage in WebPageProxy.cpp etc.
https://bugs.webkit.org/show_bug.cgi?id=281591
rdar://138049676

Reviewed by David Kilzer.

Also added some helper functions that should assist future adoption.

I had to use the unsafe helper function in WebRTC because the imported callback
ultimately comes from libwebrtc code we import as a third party library.

* Source/WTF/wtf/StdLibExtras.h:
(WTF::makeSpan):
(WTF::unsafeForgeSpan):
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::LibWebRTCCodecsProxy::createEncoder):
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::firePushEvent):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::gatherNetworkMap):
(WebKit::isEqual):
(WebKit::sortNetworks):
* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::setSessionPermissions):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performInteractionSequence):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::swapToProvisionalPage):

Canonical link: https://commits.webkit.org/285286@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 942d20: Removed the DEFINE_VIRTUAL_REFCOUNTED macro

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 942d209b73a952046ba9fd2691472d085bf7f2d7
  
https://github.com/WebKit/WebKit/commit/942d209b73a952046ba9fd2691472d085bf7f2d7
  Author: Geoffrey Garen 
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
M Source/WTF/wtf/RefCounted.h
M Source/WebCore/Modules/WebGPU/GPUDevice.h
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.h
M Source/WebCore/Modules/applepay/ApplePaySession.h
M Source/WebCore/Modules/applepay/ApplePaySetupWebCore.h
M Source/WebCore/Modules/audiosession/DOMAudioSession.h
M Source/WebCore/Modules/cache/DOMCache.h
M Source/WebCore/Modules/cache/DOMCacheStorage.h
M Source/WebCore/Modules/cookie-store/CookieStore.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySession.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemAccess.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h
M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h
M Source/WebCore/Modules/entriesapi/FileSystemDirectoryReader.h
M Source/WebCore/Modules/entriesapi/FileSystemEntry.h
M Source/WebCore/Modules/fetch/FetchBodyOwner.h
M Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h
M Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.h
M Source/WebCore/Modules/gamepad/GamepadHapticActuator.h
M Source/WebCore/Modules/geolocation/Geolocation.h
M Source/WebCore/Modules/mediarecorder/MediaRecorder.h
M Source/WebCore/Modules/mediasession/MediaSession.h
M Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h
M Source/WebCore/Modules/mediasource/MediaSource.h
M Source/WebCore/Modules/mediasource/SourceBuffer.h
M Source/WebCore/Modules/mediasource/SourceBufferList.h
M Source/WebCore/Modules/mediastream/ImageCapture.h
M Source/WebCore/Modules/mediastream/MediaDevices.h
M Source/WebCore/Modules/mediastream/MediaStream.h
M Source/WebCore/Modules/mediastream/MediaStreamTrack.h
M Source/WebCore/Modules/mediastream/RTCDTMFSender.h
M Source/WebCore/Modules/mediastream/RTCDataChannel.h
M Source/WebCore/Modules/mediastream/RTCDtlsTransport.h
M Source/WebCore/Modules/mediastream/RTCIceTransport.h
M Source/WebCore/Modules/mediastream/RTCPeerConnection.h
M Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.h
M Source/WebCore/Modules/mediastream/RTCSctpTransport.h
M Source/WebCore/Modules/mediastream/UserMediaRequest.h
M Source/WebCore/Modules/notifications/Notification.h
M Source/WebCore/Modules/paymentrequest/PaymentRequest.h
M Source/WebCore/Modules/paymentrequest/PaymentResponse.h
M Source/WebCore/Modules/pictureinpicture/PictureInPictureWindow.h
M Source/WebCore/Modules/remoteplayback/RemotePlayback.h
M Source/WebCore/Modules/reporting/ReportingObserver.h
M Source/WebCore/Modules/screen-wake-lock/WakeLockSentinel.h
M Source/WebCore/Modules/speech/SpeechRecognition.h
M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp
M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h
M Source/WebCore/Modules/streams/ReadableStreamSource.h
M Source/WebCore/Modules/web-locks/WebLockManager.h
M Source/WebCore/Modules/websockets/WebSocket.h
M Source/WebCore/Modules/webxr/WebXRSession.h
M Source/WebCore/Modules/webxr/WebXRSystem.h
M Source/WebCore/animation/WebAnimation.h
M Source/WebCore/css/CSSComputedStyleDeclaration.h
M Source/WebCore/css/CSSFontFaceSet.h
M Source/WebCore/css/CSSFontSelector.h
M Source/WebCore/css/CSSRuleList.h
M Source/WebCore/css/CSSSegmentedFontFace.h
M Source/WebCore/css/FontFace.h
M Source/WebCore/css/FontFaceSet.h
M Source/WebCore/css/MediaQueryList.h
M Source/WebCore/css/PropertySetCSSStyleDeclaration.h
M Source/WebCore/dom/InternalObserver.h
M Source/WebCore/dom/Subscriber.h
M Source/WebCore/dom/ViewTransition.h
M Source/WebCore/fileapi/Blob.h
M Source/WebCore/fileapi/FileReader.h
M Source/WebCore/html/ImageBitmap.cpp
M Source/WebCore/html/OffscreenCanvas.h
M Source/WebCore/html/PublicURLManager.h
M Source/WebCore/html/track/TextTrack.h
M Source/WebCore/html/track/TextTrackCue.h
M Source/WebCore/html/track/TrackListBase.h
M Source/WebCore/loader/DocumentLoader.h
M Source/WebCore/page/DOMTimer.h
M Source/WebCore/page/EventSource.h
M Source/WebCore/page/Navigator.h
M Source/WebCore/page/ScreenOrientation.h
M Source/WebCore/platform/audio/AudioHardwareListener.cpp
M Source/WebCore/platform/graphics/MediaPlayer.cpp
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
M Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h
M Source/WebCore/platform/graphics/win/MediaPlayerP

[webkit-changes] [WebKit/WebKit] f22fe5: Adopted std::array in TransformMatrix

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f22fe57254df91190dfc98f53061da368a2d66d1
  
https://github.com/WebKit/WebKit/commit/f22fe57254df91190dfc98f53061da368a2d66d1
  Author: Geoffrey Garen 
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp
M Source/WebCore/platform/graphics/transforms/TransformationMatrix.h

  Log Message:
  ---
  Adopted std::array in TransformMatrix
https://bugs.webkit.org/show_bug.cgi?id=281472


Reviewed by Richard Robinson.

I had to add CSSMatrixComponent.cpp to the smart pointer analysis skip list
to work around rdar://137965803.

* Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::decompose4):
(WebCore::TransformationMatrix::multiply):
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::TransformationMatrix):

Canonical link: https://commits.webkit.org/285218@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 59ca35: Replaced the DECLARE_VIRTUAL_REFCOUNTED macro with...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59ca354ec983a0f06f75fb8bdb0983d88eb1c785
  
https://github.com/WebKit/WebKit/commit/59ca354ec983a0f06f75fb8bdb0983d88eb1c785
  Author: Geoffrey Garen 
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj
A Source/WTF/wtf/AbstractRefCounted.h
A Source/WTF/wtf/AbstractRefCountedAndCanMakeWeakPtr.h
M Source/WTF/wtf/CMakeLists.txt
M Source/WTF/wtf/FunctionDispatcher.h
M Source/WTF/wtf/RefCounted.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.h
M Source/WebCore/Modules/push-api/PushSubscriptionOwner.h
M Source/WebCore/Modules/streams/ReadableStreamSource.h
M Source/WebCore/Modules/webtransport/WebTransportSession.h
M Source/WebCore/css/CSSFontFace.h
M Source/WebCore/css/CSSRuleList.h
M Source/WebCore/css/CSSStyleDeclaration.h
M Source/WebCore/dom/ActiveDOMObject.h
M Source/WebCore/loader/ContentFilterClient.h
M Source/WebCore/page/SpeechSynthesisClient.h
M Source/WebCore/platform/DateTimeChooser.h
M Source/WebCore/platform/RemoteCommandListener.h
M Source/WebCore/platform/audio/AudioDestination.h
M Source/WebCore/platform/audio/AudioHardwareListener.h
M Source/WebCore/platform/graphics/MediaPlayerPrivate.h
M Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h
M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
M Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.h
M Source/WebCore/platform/network/curl/CurlRequestClient.h
M 
Source/WebCore/workers/service/background-fetch/BackgroundFetchRecordLoader.h
M Source/WebCore/workers/service/context/SWContextManager.h
M Source/WebKit/NetworkProcess/Downloads/DownloadManager.h
M Source/WebKit/NetworkProcess/NetworkDataTask.h
M Source/WebKit/UIProcess/Cocoa/ExtensionCapabilityGranter.h
M Source/WebKit/UIProcess/FrameLoadState.h
M Source/WebKit/UIProcess/PageLoadState.h
M Source/WebKit/UIProcess/ResponsivenessTimer.h
M Source/WebKit/UIProcess/WebAuthentication/Authenticator.h
M Source/WebKit/WebProcess/GPU/GPUProcessConnection.h
M Source/WebKit/WebProcess/Model/ModelProcessConnection.h
M Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.h
M Source/WebKit/webpushd/PushService.mm

  Log Message:
  ---
  Replaced the DECLARE_VIRTUAL_REFCOUNTED macro with an abstract base class
https://bugs.webkit.org/show_bug.cgi?id=281428
rdar://137875169

Reviewed by Chris Dumez.

Chris pointed out that macros are hard to read/understand, and can interfere
with debugging.

We can use an abstract base class instead.

I like having a class for this because it matches how we declare concrete
refcounting.

* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/CMakeLists.txt:
* Source/WTF/wtf/FunctionDispatcher.h:
* Source/WTF/wtf/RefCounted.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.h:
* Source/WebCore/Modules/push-api/PushSubscriptionOwner.h:
* Source/WebCore/Modules/streams/ReadableStreamSource.h:
* Source/WebCore/Modules/webtransport/WebTransportSession.h:
* Source/WebCore/css/CSSFontFace.h:
* Source/WebCore/css/CSSRuleList.h:
* Source/WebCore/css/CSSStyleDeclaration.h:
* Source/WebCore/dom/ActiveDOMObject.h:
* Source/WebCore/loader/ContentFilterClient.h:
* Source/WebCore/page/SpeechSynthesisClient.h:
* Source/WebCore/platform/DateTimeChooser.h:
* Source/WebCore/platform/RemoteCommandListener.h:
* Source/WebCore/platform/audio/AudioDestination.h:
* Source/WebCore/platform/audio/AudioHardwareListener.h:
* Source/WebCore/platform/graphics/MediaPlayerPrivate.h:
* Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h:
* Source/WebCore/platform/mediastream/RealtimeMediaSource.h:
* Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.h:
(WebCore::CapturerObserver::capturerConfigurationChanged):
* Source/WebCore/platform/network/curl/CurlRequestClient.h:
* Source/WebCore/workers/service/background-fetch/BackgroundFetchRecordLoader.h:
* Source/WebCore/workers/service/context/SWContextManager.h:
* Source/WebKit/NetworkProcess/Downloads/DownloadManager.h:
* Source/WebKit/NetworkProcess/NetworkDataTask.h:
* Source/WebKit/UIProcess/Cocoa/ExtensionCapabilityGranter.h:
* Source/WebKit/UIProcess/FrameLoadState.h:
* Source/WebKit/UIProcess/PageLoadState.h:
* Source/WebKit/UIProcess/ResponsivenessTimer.h:
* Source/WebKit/UIProcess/WebAuthentication/Authenticator.h:
* Source/WebKit/WebProcess/GPU/GPUProcessConnection.h:
* Source/WebKit/WebProcess/Model/ModelProcessConnection.h:
* Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.h:
* Source/WebKit/webpushd/PushService.mm:

Canonical link: https://commits.webkit.org/285138@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-cha

[webkit-changes] [WebKit/WebKit] 22d792: Build fix for GeneratedSerializers.mm after 285046...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22d7925f299857bec6ae4dd7e0c228fddd9480dd
  
https://github.com/WebKit/WebKit/commit/22d7925f299857bec6ae4dd7e0c228fddd9480dd
  Author: Geoffrey Garen 
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
M Source/WebKit/Configurations/Base.xcconfig

  Log Message:
  ---
  Build fix for GeneratedSerializers.mm after 285046@main
https://bugs.webkit.org/show_bug.cgi?id=281360
rdar://137788481

Unreviewed build fix.

On Apple-internal builders, 285046@main appears to have the effect of enabling
-Wmissing-field-initializers for the first time.

I'm not sure why this is, but re-disabling it explicitly seems to work.

* Source/WebKit/Configurations/Base.xcconfig:

Canonical link: https://commits.webkit.org/285055@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1f7382: Build fix for XR after 285046@main

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f7382c02c2134396c3d366b9a687379c36cf13f
  
https://github.com/WebKit/WebKit/commit/1f7382c02c2134396c3d366b9a687379c36cf13f
  Author: Geoffrey Garen 
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
M Source/WebCore/platform/xr/cocoa/PlatformXRPose.h

  Log Message:
  ---
  Build fix for XR after 285046@main
https://bugs.webkit.org/show_bug.cgi?id=281355
rdar://137784142

Unreviewed, build fix.

* Source/WebCore/platform/xr/cocoa/PlatformXRPose.h:

Canonical link: https://commits.webkit.org/285053@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8012a2: Enable -Wunsafe-buffer-usage in WebKit.framework

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8012a2ef24887940831a4ddc777d5d757f523c99
  
https://github.com/WebKit/WebKit/commit/8012a2ef24887940831a4ddc777d5d757f523c99
  Author: Geoffrey Garen 
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
M Source/JavaScriptCore/API/APICast.h
M Source/JavaScriptCore/JavaScriptCorePrefix.h
M Source/JavaScriptCore/heap/Strong.h
M Source/JavaScriptCore/heap/WeakInlines.h
M 
Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py
M Source/JavaScriptCore/interpreter/CallFrame.h
M Source/JavaScriptCore/parser/SourceProvider.h
M Source/JavaScriptCore/runtime/ArrayBuffer.h
M Source/JavaScriptCore/runtime/ExceptionScope.h
M Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h
M Source/JavaScriptCore/runtime/JSArrayBufferViewInlines.h
M Source/JavaScriptCore/runtime/JSBigInt.h
M Source/JavaScriptCore/runtime/JSCInlines.h
M Source/JavaScriptCore/runtime/JSCJSValueInlines.h
M Source/JavaScriptCore/runtime/JSCellInlines.h
M Source/JavaScriptCore/runtime/JSObject.h
M Source/JavaScriptCore/runtime/Options.h
M Source/JavaScriptCore/runtime/TypedArrays.h
M Source/JavaScriptCore/runtime/VM.h
M Source/JavaScriptCore/wasm/WasmModule.h
M Source/WTF/wtf/ASCIICType.h
M Source/WTF/wtf/Atomics.h
M Source/WTF/wtf/BitSet.h
M Source/WTF/wtf/BitVector.h
M Source/WTF/wtf/BloomFilter.h
M Source/WTF/wtf/Brigand.h
M Source/WTF/wtf/Compiler.h
M Source/WTF/wtf/CrossThreadCopier.h
M Source/WTF/wtf/Deque.h
M Source/WTF/wtf/FileSystem.h
M Source/WTF/wtf/FixedVector.h
M Source/WTF/wtf/HashMap.h
M Source/WTF/wtf/HashSet.h
M Source/WTF/wtf/HexNumber.h
M Source/WTF/wtf/IteratorAdaptors.h
M Source/WTF/wtf/Locker.h
M Source/WTF/wtf/ObjectIdentifier.h
M Source/WTF/wtf/PageBlock.h
M Source/WTF/wtf/RefCounted.h
M Source/WTF/wtf/RobinHoodHashTable.h
M Source/WTF/wtf/SIMDHelpers.h
M Source/WTF/wtf/SortedArrayMap.h
M Source/WTF/wtf/StackTrace.h
M Source/WTF/wtf/StdLibExtras.h
M Source/WTF/wtf/TZoneMallocInlines.h
M Source/WTF/wtf/Threading.h
M Source/WTF/wtf/TrailingArray.h
M Source/WTF/wtf/UUID.h
M Source/WTF/wtf/UniqueArray.h
M Source/WTF/wtf/Vector.h
M Source/WTF/wtf/WTFConfig.h
M Source/WTF/wtf/cf/VectorCF.h
M Source/WTF/wtf/cocoa/SpanCocoa.h
M Source/WTF/wtf/text/ASCIIFastPath.h
M Source/WTF/wtf/text/ASCIILiteral.h
M Source/WTF/wtf/text/CString.h
M Source/WTF/wtf/text/MakeString.h
M Source/WTF/wtf/text/StringBuilder.h
M Source/WTF/wtf/text/StringCommon.h
M Source/WTF/wtf/text/StringConcatenate.h
M Source/WTF/wtf/text/StringConcatenateNumbers.h
M Source/WTF/wtf/text/StringHasherInlines.h
M Source/WTF/wtf/text/StringImpl.h
M Source/WTF/wtf/text/StringView.h
M Source/WTF/wtf/text/TextBreakIterator.h
M Source/WTF/wtf/text/WTFString.h
M Source/WTF/wtf/text/icu/TextBreakIteratorICU.h
M Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h
M Source/WebCore/Scripts/SettingsTemplates/Settings.h.erb
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/bindings/IDLTypes.h
M Source/WebCore/bindings/js/BufferSource.h
M Source/WebCore/bindings/js/DOMWrapperWorld.h
M Source/WebCore/bindings/js/JSDOMConvertBase.h
M Source/WebCore/bindings/js/JSDOMGlobalObject.h
M Source/WebCore/bindings/js/JSDOMWrapper.h
M Source/WebCore/css/CSSSelector.h
M Source/WebCore/css/CSSSelectorList.h
M Source/WebCore/css/parser/CSSParserTokenRange.h
M Source/WebCore/dom/ElementData.h
M Source/WebCore/dom/SpaceSplitString.h
M Source/WebCore/dom/messageports/MessagePortChannel.h
M Source/WebCore/page/StructuredSerializeOptions.h
M Source/WebCore/platform/ProcessQualified.h
M Source/WebCore/platform/SharedBuffer.h
M Source/WebCore/platform/SharedMemory.h
M Source/WebCore/platform/audio/AudioChannel.h
M Source/WebCore/platform/graphics/FontTaggedSettings.h
M Source/WebCore/platform/graphics/FourCC.h
M Source/WebCore/platform/graphics/GlyphBuffer.h
M Source/WebCore/platform/graphics/GlyphPage.h
M Source/WebCore/platform/graphics/WidthCache.h
M Source/WebCore/platform/graphics/transforms/TransformationMatrix.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h
M Source/WebCore/platform/network/HTTPHeaderMap.h
M Source/WebCore/workers/WorkerOrWorkletScriptController.h
M Source/WebKit/Configurations/Base.xcconfig
M 
Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUServiceEntryPoint.mm
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h
M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.c

[webkit-changes] [WebKit/WebKit] f34000: [IsDeprecatedWeakRefSmartPointerException] Make mo...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f3400055a83487a80be79c3c85de61d39c38f3f0
  
https://github.com/WebKit/WebKit/commit/f3400055a83487a80be79c3c85de61d39c38f3f0
  Author: Geoffrey Garen 
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/BackgroundFetchLoad.cpp
M Source/WebKit/NetworkProcess/BackgroundFetchLoad.h
M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h
M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp
M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h
M Source/WebKit/NetworkProcess/Downloads/Download.h
M Source/WebKit/NetworkProcess/NetworkLoadChecker.h
M Source/WebKit/NetworkProcess/NetworkLoadScheduler.h
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.h
M Source/WebKit/NetworkProcess/NetworkSession.cpp
M Source/WebKit/NetworkProcess/NetworkSession.h
M Source/WebKit/NetworkProcess/PingLoad.cpp
M Source/WebKit/NetworkProcess/PingLoad.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Make more network process classes 
refcounted
https://bugs.webkit.org/show_bug.cgi?id=280293
rdar://136618733

Reviewed by Basuke Suzuki.

static_assert told me to.

* Source/WebKit/NetworkProcess/BackgroundFetchLoad.cpp:
(WebKit::BackgroundFetchLoad::BackgroundFetchLoad):
* Source/WebKit/NetworkProcess/BackgroundFetchLoad.h:
* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
* Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
* Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
* Source/WebKit/NetworkProcess/Downloads/Download.h:
* Source/WebKit/NetworkProcess/NetworkLoadChecker.h:
(WebKit::NetworkLoadChecker::create):
* Source/WebKit/NetworkProcess/NetworkLoadScheduler.h:
(WebKit::NetworkLoadScheduler::create):
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
* Source/WebKit/NetworkProcess/NetworkResourceLoader.h:
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::networkLoadScheduler):
* Source/WebKit/NetworkProcess/NetworkSession.h:
* Source/WebKit/NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
* Source/WebKit/NetworkProcess/PingLoad.h:

Canonical link: https://commits.webkit.org/284320@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f697d3: Re-landing 284236@main (966da8693f4b)

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f697d3cc179183bdd37a7e2b96a882a142cdcd4f
  
https://github.com/WebKit/WebKit/commit/f697d3cc179183bdd37a7e2b96a882a142cdcd4f
  Author: Geoffrey Garen 
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
M Source/WebKit/Shared/API/APIObject.cpp
M Source/WebKit/Shared/API/APIObject.h
M Source/WebKit/Shared/Cocoa/APIObject.mm

  Log Message:
  ---
  Re-landing 284236@main (966da8693f4b)

Reviewed by Chris Dumez.

284253@main fixes the test failures we saw on bots.

API objects should be safe to ref() inside their constructors
https://bugs.webkit.org/show_bug.cgi?id=280278
rdar://136599625
284236@main (966da8693f4b)

Canonical link: https://commits.webkit.org/284304@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 966da8: API objects should be safe to ref() inside their c...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 966da8693f4b60deedaa3226f3641530ff7d5f0a
  
https://github.com/WebKit/WebKit/commit/966da8693f4b60deedaa3226f3641530ff7d5f0a
  Author: Geoffrey Garen 
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
M Source/WebKit/Shared/API/APIObject.cpp
M Source/WebKit/Shared/API/APIObject.h
M Source/WebKit/Shared/Cocoa/APIObject.mm

  Log Message:
  ---
  API objects should be safe to ref() inside their constructors
https://bugs.webkit.org/show_bug.cgi?id=280278
rdar://136599625

Reviewed by Chris Dumez and Ryosuke Niwa.

284023@main caused a crash because it instantiated a RefPtr inside an API
object's constructor.

API objects delegate refcounting to their ObjC wrappers. However, the wrapper
data member is not initialized until after construction is over, so RefPtr
inside a constructor is use of uninitialized memory.

Fix this by initializing the wrapper data member in our base class
constructor.

For now, we use a ThreadSpecific to avoid having to update all API
constructors and #ifdef them for COCOA vs non-COCOA. Longer term, it
would be nice to find a way to just pass the wrapper as a constructor
argument.

(Note: We can't just assign the wrapper before invoking the constructor
because that's Undefined Behavior, and an API test seems to demonstrate
that clang does in fact trip over it, at least some of the time.)

* Source/WebKit/Shared/API/APIObject.h:
(API::Object::constructInWrapper):

Canonical link: https://commits.webkit.org/284236@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 669e25: [IsDeprecatedWeakRefSmartPointerException] make Ba...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 669e25c22543c8c82efd7b449718f1c2c7aed0ac
  
https://github.com/WebKit/WebKit/commit/669e25c22543c8c82efd7b449718f1c2c7aed0ac
  Author: Geoffrey Garen 
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
M Source/WebCore/workers/service/background-fetch/BackgroundFetch.cpp
M Source/WebCore/workers/service/background-fetch/BackgroundFetch.h
M Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.cpp
M Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.h
M 
Source/WebCore/workers/service/background-fetch/BackgroundFetchRecordLoader.h
M Source/WebCore/workers/service/server/SWServer.cpp
M Source/WebCore/workers/service/server/SWServer.h
M Source/WebCore/workers/service/server/SWServerDelegate.h
M Source/WebKit/NetworkProcess/BackgroundFetchLoad.h
M Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp
M Source/WebKit/NetworkProcess/Downloads/DownloadManager.h
M Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp
M Source/WebKit/NetworkProcess/Downloads/PendingDownload.h
M Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkDataTask.h
M Source/WebKit/NetworkProcess/NetworkLoad.h
M Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
M Source/WebKit/NetworkProcess/NetworkLoadChecker.h
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.h
M Source/WebKit/NetworkProcess/NetworkSession.cpp
M Source/WebKit/NetworkProcess/NetworkSession.h
M Source/WebKit/NetworkProcess/PingLoad.cpp
M Source/WebKit/NetworkProcess/PingLoad.h
M Source/WebKit/NetworkProcess/PreconnectTask.cpp
M Source/WebKit/NetworkProcess/PreconnectTask.h
M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp
M 
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp
M 
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.h
M 
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h
M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreManager.h
M Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] make BackgroundFetch related 
classes RefCounted
https://bugs.webkit.org/show_bug.cgi?id=280194
rdar://136516715

Reviewed by Ryosuke Niwa.

static_assert told me to.

* Source/WebCore/workers/service/background-fetch/BackgroundFetch.h:
* Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.cpp:
(WebCore::BackgroundFetchEngine::startBackgroundFetch):
(WebCore::BackgroundFetchEngine::resumeBackgroundFetch):
* Source/WebCore/workers/service/background-fetch/BackgroundFetchRecordLoader.h:
* Source/WebCore/workers/service/server/SWServer.h:
(WebCore::SWServer::createBackgroundFetchRecordLoader):
* Source/WebCore/workers/service/server/SWServerDelegate.h:
* Source/WebKit/NetworkProcess/BackgroundFetchLoad.h:
* Source/WebKit/NetworkProcess/NetworkDataTask.h:
* Source/WebKit/NetworkProcess/NetworkLoad.h:
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::createBackgroundFetchRecordLoader):
* Source/WebKit/NetworkProcess/NetworkSession.h:
* Source/WebKit/NetworkProcess/PingLoad.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::loadImageForDecoding):
* Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreManager.h:
(WebKit::BackgroundFetchStoreManager::create):
* Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:
(WebKit::OriginStorageManager::StorageBucket::backgroundFetchManager):

Canonical link: https://commits.webkit.org/284174@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6e02a5: Removed Ref{Ptr}AllowingPartiallyDestroyed

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e02a5c532f283f2d81a096b854e5b3cecb5cc3a
  
https://github.com/WebKit/WebKit/commit/6e02a5c532f283f2d81a096b854e5b3cecb5cc3a
  Author: Geoffrey Garen 
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
M Source/WTF/wtf/Ref.h
M Source/WTF/wtf/RefCounted.h
M Source/WTF/wtf/RefPtr.h
M Source/WTF/wtf/ThreadSafeRefCounted.h
M Source/WebCore/Modules/mediasource/MediaSource.cpp
M Source/WebCore/dom/ActiveDOMObject.cpp
M Source/WebCore/dom/Attr.cpp
M Source/WebCore/dom/CharacterData.cpp
M Source/WebCore/dom/ContainerNode.cpp
M Source/WebCore/dom/ContainerNodeAlgorithms.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/EmptyScriptExecutionContext.h
M Source/WebCore/dom/MessagePort.cpp
M Source/WebCore/dom/Node.cpp
M Source/WebCore/dom/Node.h
M Source/WebCore/dom/ScriptExecutionContext.cpp
M Source/WebCore/dom/ScriptExecutionContext.h
M Source/WebCore/dom/ShadowRoot.cpp
M Source/WebCore/html/HTMLElement.cpp
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/csp/ContentSecurityPolicy.cpp
M Source/WebCore/svg/SVGElement.cpp
M Source/WebCore/svg/SVGFontFaceElement.cpp
M Source/WebCore/svg/SVGSVGElement.cpp
M Source/WebCore/svg/SVGTests.cpp
M Source/WebCore/svg/SVGTitleElement.cpp
M Source/WebCore/svg/SVGUseElement.cpp
M Source/WebCore/workers/WorkerOrWorkletGlobalScope.h
M Source/WebCore/workers/service/server/SWServerWorker.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
M Source/WebKit/Shared/API/APIObject.h
M 
Source/WebKit/UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm
M 
Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.mm
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm
M Tools/TestWebKitAPI/Tests/WTF/Ref.cpp
M Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp

  Log Message:
  ---
  Removed Ref{Ptr}AllowingPartiallyDestroyed
https://bugs.webkit.org/show_bug.cgi?id=280130
rdar://136430183

Reviewed by Ryosuke Niwa.

As of https://commits.webkit.org/283685@main, it's obsolete.

* Source/WTF/wtf/Ref.h:
(WTF::RefDerefTraitsAllowingPartiallyDestroyed::refIfNotNull): Deleted.
(WTF::RefDerefTraitsAllowingPartiallyDestroyed::ref): Deleted.
(WTF::RefDerefTraitsAllowingPartiallyDestroyed::derefIfNotNull): Deleted.
* Source/WTF/wtf/RefCounted.h:
(WTF::RefCountedBase::ref const):
(WTF::RefCountedBase::derefBase const):
(WTF::RefCountedBase::refAllowingPartiallyDestroyed const): Deleted.
(WTF::RefCountedBase::derefAllowingPartiallyDestroyedBase const): Deleted.
(WTF::RefCounted::derefAllowingPartiallyDestroyed const): Deleted.
* Source/WTF/wtf/RefPtr.h:
* Source/WTF/wtf/ThreadSafeRefCounted.h:
(WTF::ThreadSafeRefCountedBase::ref const):
(WTF::ThreadSafeRefCountedBase::refAllowingPartiallyDestroyed const): Deleted.
(WTF::ThreadSafeRefCounted::derefAllowingPartiallyDestroyed const): Deleted.
* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::ensureWeakOnHTMLMediaElementContext const):
* Source/WebCore/dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):
(WebCore::ActiveDOMObject::queueTaskInEventLoop):
* Source/WebCore/dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):
* Source/WebCore/dom/CharacterData.cpp:
(WebCore::CharacterData::~CharacterData):
* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeAllChildrenWithScriptAssertion):
(WebCore::ContainerNode::removeNodeWithScriptAssertion):
(WebCore::ContainerNode::~ContainerNode):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::rebuildSVGExtensionsElementsIfNecessary):
(WebCore::ContainerNode::childrenChanged):
(WebCore::dispatchChildRemovalEvents):
* Source/WebCore/dom/ContainerNodeAlgorithms.cpp:
(WebCore::removeDetachedChildrenInContainer):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::removedLastRef):
(WebCore::Document::willBeRemovedFromFrame):
(WebCore::Document::wheelEventHandlersChanged):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::removedFromAncestor):
* Source/WebCore/dom/EmptyScriptExecutionContext.h:
* Source/WebCore/dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::~Node):
* Source/WebCore/dom/Node.h:
(WebCore::Node::ref const):
(WebCore::Node::applyRefDuring

[webkit-changes] [WebKit/WebKit] 7c2599: Weak data types should not hard code WeakPtrFactory

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c2599f8defb332d27a04e95dc5eca101af4042e
  
https://github.com/WebKit/WebKit/commit/7c2599f8defb332d27a04e95dc5eca101af4042e
  Author: Geoffrey Garen 
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
M Source/WTF/wtf/CanMakeWeakPtr.h
M Source/WTF/wtf/StdLibExtras.h
M Source/WTF/wtf/WeakHashMap.h
M Source/WTF/wtf/WeakHashSet.h
M Source/WTF/wtf/WeakListHashSet.h
M Source/WTF/wtf/WeakPtr.h
M Source/WTF/wtf/WeakPtrFactory.h
M Source/WTF/wtf/WeakRef.h
M Source/WebCore/Modules/cookie-store/CookieStore.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySession.h
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
M Source/WebCore/Modules/mediarecorder/MediaRecorder.h
M Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h
M Source/WebCore/Modules/mediasource/MediaSource.h
M Source/WebCore/Modules/mediasource/SourceBuffer.h
M Source/WebCore/Modules/mediastream/MediaStream.h
M Source/WebCore/Modules/model-element/HTMLModelElement.h
M Source/WebCore/Modules/speech/SpeechRecognition.h
M Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h
M Source/WebCore/Modules/webxr/WebXRSession.h
M Source/WebCore/css/CSSFontSelector.h
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/ProcessingInstruction.h
M Source/WebCore/html/HTMLLinkElement.h
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/html/HTMLTrackElement.h
M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
M Source/WebCore/html/shadow/SpinButtonElement.h
M Source/WebCore/loader/DocumentLoader.h
M Source/WebCore/page/EventSource.h
M Source/WebCore/page/ScreenOrientation.h
M Source/WebCore/platform/ScrollView.h
M Source/WebCore/platform/audio/AudioSession.h
M Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
M Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h
M Source/WebCore/workers/Worker.h
M Source/WebCore/workers/WorkerGlobalScope.h
M Source/WebCore/workers/WorkerOrWorkletGlobalScope.h
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
M Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.h
M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.h
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.h
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h
M 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h
M Source/WebKit/ModelProcess/ModelConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h
M 
Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h
M Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.h
M Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebProcessPool.h
M Source/WebKit/UIProcess/XR/PlatformXRSystem.h
M Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/cocoa/AudioSessionRoutingArbitrator.h
M Source/WebKit/WebProcess/cocoa/VideoPresentationManager.h
M Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp

  Log Message:
  ---
  Weak data types should not hard code WeakPtrFactory
https://bugs.webkit.org/show_bug.cgi?id=280131
rdar://136431404

Reviewed by Ryosuke Niwa.

This is work toward implementing a more efficient weak pointer.

* Source/WTF/wtf/CanMakeWeakPtr.h:
(WTF::CanMakeWeakPtrBase::weakImplIfExists const):
(WTF::CanMakeWeakPtrBase::weakImpl const):
(WTF::CanMakeWeakPtrBase::initializeWeakPtrFactory const):
(WTF::CanMakeWeakPtrBase::weakPtrFactory const): Deleted.
(WTF::CanMakeWeakPtrBase::weakPtrFactory): Deleted.
(WTF::CanMakeWeakPtrBase::initializeWeakPtrFactory): Deleted.
* Source/WTF/wtf/StdLibExtras.h:
* Source/WTF/wtf/WeakHashMap.h:
* Source/WTF/wtf/WeakHashSet.h:
* Source/WTF/wtf/WeakListHashSet.h:
* Source/WTF/wtf/WeakPtr.h:
(WTF::WeakPtr::WeakPtr):
(WTF::WeakPtr::implForObject): Deleted.
* Source/WTF/wtf/WeakPtrFactory.h:
* Source/WTF/wtf/WeakRef.h:
(WTF::WeakRef::WeakRef):
(WTF::WeakRef::implForObject): Deleted.
* Source/WebCore/Modules/cookie-store/CookieStor

[webkit-changes] [WebKit/WebKit] 5d100c: Standardized how we declare refcounting interfaces...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d100c24f90237a63172d016c390a3bd223293e6
  
https://github.com/WebKit/WebKit/commit/5d100c24f90237a63172d016c390a3bd223293e6
  Author: Geoffrey Garen 
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
M Source/WTF/wtf/FunctionDispatcher.h
M Source/WTF/wtf/RefCounted.h
M Source/WebCore/Modules/WebGPU/GPUDevice.h
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.h
M Source/WebCore/Modules/applepay/ApplePaySession.h
M Source/WebCore/Modules/applepay/ApplePaySetupWebCore.h
M Source/WebCore/Modules/audiosession/DOMAudioSession.h
M Source/WebCore/Modules/cache/DOMCache.h
M Source/WebCore/Modules/cache/DOMCacheStorage.h
M Source/WebCore/Modules/cookie-store/CookieStore.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySession.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemAccess.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h
M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h
M Source/WebCore/Modules/entriesapi/FileSystemDirectoryReader.h
M Source/WebCore/Modules/entriesapi/FileSystemEntry.h
M Source/WebCore/Modules/fetch/FetchBodyOwner.h
M Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h
M Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.h
M Source/WebCore/Modules/gamepad/GamepadHapticActuator.h
M Source/WebCore/Modules/geolocation/Geolocation.h
M Source/WebCore/Modules/mediarecorder/MediaRecorder.h
M Source/WebCore/Modules/mediasession/MediaSession.h
M Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h
M Source/WebCore/Modules/mediasource/MediaSource.h
M Source/WebCore/Modules/mediasource/SourceBuffer.h
M Source/WebCore/Modules/mediasource/SourceBufferList.h
M Source/WebCore/Modules/mediastream/ImageCapture.h
M Source/WebCore/Modules/mediastream/MediaDevices.h
M Source/WebCore/Modules/mediastream/MediaStream.h
M Source/WebCore/Modules/mediastream/MediaStreamTrack.h
M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.h
M Source/WebCore/Modules/mediastream/RTCDTMFSender.h
M Source/WebCore/Modules/mediastream/RTCDataChannel.h
M Source/WebCore/Modules/mediastream/RTCDtlsTransport.h
M Source/WebCore/Modules/mediastream/RTCIceTransport.h
M Source/WebCore/Modules/mediastream/RTCPeerConnection.h
M Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.h
M Source/WebCore/Modules/mediastream/RTCSctpTransport.h
M Source/WebCore/Modules/mediastream/UserMediaRequest.h
M Source/WebCore/Modules/notifications/Notification.h
M Source/WebCore/Modules/paymentrequest/PaymentRequest.h
M Source/WebCore/Modules/paymentrequest/PaymentResponse.h
M Source/WebCore/Modules/pictureinpicture/PictureInPictureWindow.h
M Source/WebCore/Modules/push-api/PushSubscriptionOwner.h
M Source/WebCore/Modules/remoteplayback/RemotePlayback.h
M Source/WebCore/Modules/reporting/ReportingObserver.h
M Source/WebCore/Modules/screen-wake-lock/WakeLockSentinel.h
M Source/WebCore/Modules/speech/SpeechRecognition.h
M Source/WebCore/Modules/speech/SpeechSynthesis.h
M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h
M Source/WebCore/Modules/streams/ReadableStreamSource.h
M Source/WebCore/Modules/web-locks/WebLockManager.h
M Source/WebCore/Modules/websockets/WebSocket.h
M Source/WebCore/Modules/webtransport/WebTransportSession.h
M Source/WebCore/Modules/webxr/WebXRSession.h
M Source/WebCore/Modules/webxr/WebXRSystem.h
M Source/WebCore/animation/WebAnimation.h
M Source/WebCore/css/CSSComputedStyleDeclaration.h
M Source/WebCore/css/CSSFontFace.h
M Source/WebCore/css/CSSFontFaceSet.h
M Source/WebCore/css/CSSFontSelector.h
M Source/WebCore/css/CSSRuleList.h
M Source/WebCore/css/CSSSegmentedFontFace.h
M Source/WebCore/css/CSSStyleDeclaration.h
M Source/WebCore/css/CSSStyleSheet.cpp
M Source/WebCore/css/FontFace.h
M Source/WebCore/css/FontFaceSet.h
M Source/WebCore/css/MediaQueryList.h
M Source/WebCore/css/MutableStyleProperties.cpp
M Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
M Source/WebCore/css/PropertySetCSSStyleDeclaration.h
M Source/WebCore/css/StyleProperties.cpp
M Source/WebCore/dom/ActiveDOMObject.h
M Source/WebCore/dom/InternalObserver.h
M Source/WebCore/dom/Subscriber.h
M Source/WebCore/dom/ViewTransition.h
M Source/WebCore/fileapi/Blob.h
M Source/WebCore/fileapi/FileReader.h
M Source/WebCore/html/ImageBitmap.cpp
M Source/WebCore/html/OffscreenCanvas.h
M Source/WebCore/html/PublicURLManager.h
M Source/WebCore/html/track/TextTrack.h
M Source/WebCore/html/track/TextTrackCue.h
M Source/WebCore/html/track/TrackListBase.h
M Source/WebCore/loader/ContentFilt

[webkit-changes] [WebKit/WebKit] 09ce03: REGRESSION(283982@main): Broke visionOS builds

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 09ce03a42cec48d0fa75ce461919f07f0256a24a
  
https://github.com/WebKit/WebKit/commit/09ce03a42cec48d0fa75ce461919f07f0256a24a
  Author: Geoffrey Garen 
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.h

  Log Message:
  ---
  REGRESSION(283982@main): Broke visionOS builds
https://bugs.webkit.org/show_bug.cgi?id=280070
rdar://136369742

Reviewed by Mike Wyrzykowski.

Restore a forward declaration I removed by accident.

* Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.h:

Canonical link: https://commits.webkit.org/283989@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d5e61e: [IsDeprecatedWeakRefSmartPointerException] Fixed s...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5e61e6b8907e46307d4bf3a2f95f9b0d4f116f2
  
https://github.com/WebKit/WebKit/commit/d5e61e6b8907e46307d4bf3a2f95f9b0d4f116f2
  Author: Geoffrey Garen 
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
M Source/WebKit/GPUProcess/GPUProcess.cpp
M Source/WebKit/GPUProcess/GPUProcess.h
M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.h
M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.h
M Source/WebKit/GPUProcess/media/RemoteCDMFactoryProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteCDMFactoryProxy.h
M Source/WebKit/GPUProcess/media/RemoteCDMProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteCDMProxy.h
M Source/WebKit/GPUProcess/media/RemoteLegacyCDMFactoryProxy.h
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.h
M 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp
M 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.h
M Source/WebKit/ModelProcess/ModelConnectionToWebProcess.cpp
M Source/WebKit/ModelProcess/ModelConnectionToWebProcess.h
M Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] Fixed some cases in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=280022
rdar://136325137

Reviewed by Youenn Fablet.

static_assert told me to.

* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::cdmFactoryProxy):
(WebKit::GPUConnectionToWebProcess::audioSessionProxy):
(WebKit::GPUConnectionToWebProcess::legacyCdmFactoryProxy):
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:
* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::audioSessionManager const):
* Source/WebKit/GPUProcess/GPUProcess.h:
* Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp:
(WebKit::RemoteAudioSessionProxy::create): Deleted.
* Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.h:
(WebKit::RemoteAudioSessionProxy::create):
* Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.h:
(WebKit::RemoteAudioSessionProxyManager::create):
* Source/WebKit/GPUProcess/media/RemoteCDMFactoryProxy.cpp:
(WebKit::RemoteCDMFactoryProxy::addProxy):
* Source/WebKit/GPUProcess/media/RemoteCDMFactoryProxy.h:
* Source/WebKit/GPUProcess/media/RemoteCDMProxy.cpp:
(WebKit::RemoteCDMProxy::create):
* Source/WebKit/GPUProcess/media/RemoteCDMProxy.h:
* Source/WebKit/GPUProcess/media/RemoteLegacyCDMFactoryProxy.h:
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
(WebKit::RemoteMediaPlayerManagerProxy::create):
* 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManagerUnit::create):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::createUnit):
* 
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.h:
* Source/WebKit/ModelProcess/ModelConnectionToWebProcess.cpp:
(WebKit::ModelConnectionToWebProcess::ModelConnectionToWebProcess):
* Source/WebKit/ModelProcess/ModelConnectionToWebProcess.h:
* Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.h:
(WebKit::ModelProcessModelPlayerManagerProxy::create):

Canonical link: https://commits.webkit.org/283982@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6ad1c4: Adopt smart pointers in RemoteRenderBundleEncoder (3)

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ad1c4e980f5ed162f44d8d5ae06f380753876a0
  
https://github.com/WebKit/WebKit/commit/6ad1c4e980f5ed162f44d8d5ae06f380753876a0
  Author: Geoffrey Garen 
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp

  Log Message:
  ---
  Adopt smart pointers in RemoteRenderBundleEncoder (3)
https://bugs.webkit.org/show_bug.cgi?id=279919
rdar://136250220

Reviewed by Mike Wyrzykowski.

Static analysis told me to.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp:
(WebKit::RemoteRenderBundleEncoder::setVertexBuffer):
(WebKit::RemoteRenderBundleEncoder::finish):

Canonical link: https://commits.webkit.org/283876@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bd305b: Adopt smart pointers in RemoteRenderBundleEncoder (2)

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd305ba649f694cd5648ff92f5f9be52755c1db2
  
https://github.com/WebKit/WebKit/commit/bd305ba649f694cd5648ff92f5f9be52755c1db2
  Author: Geoffrey Garen 
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp

  Log Message:
  ---
  Adopt smart pointers in RemoteRenderBundleEncoder (2)
https://bugs.webkit.org/show_bug.cgi?id=279893
rdar://problem/136223331

Reviewed by Mike Wyrzykowski.

Static analysis told me to.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp:
(WebKit::RemoteRenderBundleEncoder::setIndexBuffer):
(WebKit::RemoteRenderBundleEncoder::setVertexBuffer):
(WebKit::RemoteRenderBundleEncoder::drawIndirect):
(WebKit::RemoteRenderBundleEncoder::drawIndexedIndirect):

Canonical link: https://commits.webkit.org/283865@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 70446c: Adopt smart pointers in RemoteShaderModule

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70446ce2948d8ecabaa31c30ec7aeeb3c7cc8a12
  
https://github.com/WebKit/WebKit/commit/70446ce2948d8ecabaa31c30ec7aeeb3c7cc8a12
  Author: Geoffrey Garen 
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.h

  Log Message:
  ---
  Adopt smart pointers in RemoteShaderModule
https://bugs.webkit.org/show_bug.cgi?id=279854
rdar://136187009

Reviewed by Mike Wyrzykowski.

Static analysis told me to.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.cpp:
(WebKit::RemoteShaderModule::destruct):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.h:

Canonical link: https://commits.webkit.org/283839@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 13d38b: Adopt smart pointers in RemoteAdapter

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13d38b46abc1db30175b12caee66fd2c6e3834e0
  
https://github.com/WebKit/WebKit/commit/13d38b46abc1db30175b12caee66fd2c6e3834e0
  Author: Geoffrey Garen 
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp

  Log Message:
  ---
  Adopt smart pointers in RemoteAdapter
https://bugs.webkit.org/show_bug.cgi?id=279853
rdar://136186839

Reviewed by Mike Wyrzykowski.

Static analysis told me to.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp:
(WebKit::RemoteAdapter::requestDevice):

Canonical link: https://commits.webkit.org/283818@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d0cf75: Adopt smart pointers in RemoteRenderBundleEncoder

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0cf75687e62a3dd2b1563b98477ae4b0c30457d
  
https://github.com/WebKit/WebKit/commit/d0cf75687e62a3dd2b1563b98477ae4b0c30457d
  Author: Geoffrey Garen 
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h

  Log Message:
  ---
  Adopt smart pointers in RemoteRenderBundleEncoder
https://bugs.webkit.org/show_bug.cgi?id=279852
rdar://136186314

Reviewed by Mike Wyrzykowski.

Static analysis told me to.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp:
(WebKit::RemoteRenderBundleEncoder::setPipeline):
(WebKit::RemoteRenderBundleEncoder::setVertexBuffer):
(WebKit::RemoteRenderBundleEncoder::drawIndirect):
(WebKit::RemoteRenderBundleEncoder::setBindGroup):
(WebKit::RemoteRenderBundleEncoder::finish):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp:
(WebKit::RemoteRenderPassEncoder::executeBundles):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h:

Canonical link: https://commits.webkit.org/283817@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1f82dc: Adopt smart pointers in RemotePresentationContext

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f82dc441f5976e04414b64b2abe1826d154450a
  
https://github.com/WebKit/WebKit/commit/1f82dc441f5976e04414b64b2abe1826d154450a
  Author: Geoffrey Garen 
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.h

  Log Message:
  ---
  Adopt smart pointers in RemotePresentationContext
https://bugs.webkit.org/show_bug.cgi?id=279855
rdar://136187387

Reviewed by Mike Wyrzykowski.

Static analysis told me to.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.cpp:
(WebKit::RemotePresentationContext::getCurrentTexture):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.h:

Canonical link: https://commits.webkit.org/283816@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bc74bc: [IsDeprecatedWeakRefSmartPointerException] Pending...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc74bcf9e05d4dd52dc9a93dc0414acf8df0d748
  
https://github.com/WebKit/WebKit/commit/bc74bcf9e05d4dd52dc9a93dc0414acf8df0d748
  Author: Geoffrey Garen 
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
A Source/WTF/wtf/RefCountedAndCanMakeWeakPtr.h
M Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp
M Source/WebKit/NetworkProcess/Downloads/DownloadManager.h
M Source/WebKit/NetworkProcess/Downloads/PendingDownload.h

  Log Message:
  ---
  [IsDeprecatedWeakRefSmartPointerException] PendingDownload should not be a 
smart pointer exception
https://bugs.webkit.org/show_bug.cgi?id=279796
rdar://136113361

Reviewed by Ryosuke Niwa.

* Source/WTF/wtf/RefCountedWithWeakPtr.h: Added. For now, this class is just
a convenience to do the right thing by default without extra typing. In the
future I plan to optimize by combining the two separate implementations.

* Source/WebKit/NetworkProcess/Downloads/PendingDownload.h: Make it refcounted.

Canonical link: https://commits.webkit.org/283792@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a4d31e: Smart pointer adoption in some IPC-adjacent code

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4d31ef91fcd38d963f59a8fda513693f4d14f94
  
https://github.com/WebKit/WebKit/commit/a4d31ef91fcd38d963f59a8fda513693f4d14f94
  Author: Geoffrey Garen 
  Date:   2024-09-16 (Mon, 16 Sep 2024)

  Changed paths:
M Source/WTF/wtf/RunLoop.h
M Source/WTF/wtf/cf/RunLoopCF.cpp
M Source/WTF/wtf/generic/RunLoopGeneric.cpp
M Source/WTF/wtf/glib/RunLoopGLib.cpp
M Source/WTF/wtf/win/RunLoopWin.cpp
M Source/WebCore/platform/graphics/DestinationColorSpace.cpp
M Source/WebCore/platform/graphics/DestinationColorSpace.h
M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
M Source/WebKit/GPUProcess/ShapeDetection/RemoteFaceDetector.cpp
M Source/WebKit/GPUProcess/ShapeDetection/RemoteFaceDetector.h
M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp
M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h
M Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.h
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp
M Source/WebKit/Platform/IPC/StreamConnectionWorkQueue.cpp
M Source/WebKit/Platform/IPC/StreamConnectionWorkQueue.h
M Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm
M Source/WebKit/Shared/IPCStreamTester.cpp
M Source/WebKit/Shared/IPCStreamTester.h
M Source/WebKit/Shared/IPCTester.cpp
M Source/WebKit/Shared/graphics/ImageBufferSet.h
M Source/WebKit/UIProcess/Cocoa/UIRemoteObjectRegistry.cpp
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMenuItemCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionController.cpp
M Source/WebKit/UIProcess/Extensions/WebExtensionController.h
M Source/WebKit/UIProcess/RemotePageVisitedLinkStoreRegistration.h
M Source/WebKit/UIProcess/ViewGestureController.cpp
M Source/WebKit/UIProcess/VisitedLinkStore.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
M Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm

  Log Message:
  ---
  Smart pointer adoption in some IPC-adjacent code
https://bugs.webkit.org/show_bug.cgi?id=279696
rdar://135978755

Reviewed by Timothy Hatcher.

Static analysis told me to.

* Source/WTF/wtf/RunLoop.h:
* Source/WTF/wtf/cf/RunLoopCF.cpp:
(WTF::RunLoop::TimerBase::TimerBase):
* Source/WTF/wtf/generic/RunLoopGeneric.cpp:
(WTF::RunLoop::TimerBase::TimerBase):
* Source/WTF/wtf/glib/RunLoopGLib.cpp:
(WTF::RunLoop::TimerBase::TimerBase):
* Source/WTF/wtf/win/RunLoopWin.cpp:
(WTF::RunLoop::TimerBase::TimerBase):
* Source/WebCore/platform/graphics/DestinationColorSpace.cpp:
(WebCore::DestinationColorSpace::DestinationColorSpace): Deleted.
* Source/WebCore/platform/graphics/DestinationColorSpace.h:
(WebCore::DestinationColorSpace::DestinationColorSpace):
* Source/WebKit/GPUProcess/ShapeDetection/RemoteFaceDetector.cpp:
(WebKit::RemoteFaceDetector::sharedPreferencesForWebProcess const):
(WebKit::RemoteFaceDetector::detect):
* Source/WebKit/GPUProcess/ShapeDetection/RemoteFaceDetector.h:
(WebKit::RemoteFaceDetector::protectedBackend const):
* Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp:
(WebKit::RemoteImageBuffer::RemoteImageBuffer):
(WebKit::RemoteImageBuffer::~RemoteImageBuffer):
(WebKit::RemoteImageBuffer::stopListeningForIPC):
(WebKit::RemoteImageBuffer::getPixelBuffer):
(WebKit::RemoteImageBuffer::getShareableBitmap):
* Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp:
(WebKit::RemoteImageBufferSet::~RemoteImageBufferSet):
(WebKit::RemoteImageBufferSet::ensureBufferForDisplay):
(WebKit::RemoteImageBufferSet::prepareBufferForDisplay):
* Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.h:
(WebKit::RemoteImageBufferSet::protectedFrontBuffer):
(WebKit::RemoteImageBufferSet::protectedPreviousFrontBuffer):
(WebKit::RemoteImageBufferSet::protectedBackBuffer):
(WebKit::RemoteImageBufferSet::protectedSecondaryBackBuffer):
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
(WebKit::RemoteRenderingBackend::protectedSharedResourceCache):
* Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.h:
(WebKit::RemoteMediaRecorder::mimeType const):
(WebKit::RemoteMediaRecorder::audioBitRate const):
(WebKit::RemoteMediaRecorder::videoBitRate const):
(WebKit::RemoteMediaRecorder::protectedWriter const):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::protectedSampleBufferDisplayLayer 
const):
(WebKit::RemoteSampleBufferDisplayLayer::bounds const):
(WebKit::RemoteSampleBufferDisplayLayer::sampleBufferDisplayLayerStatusDidFail):
* Source/WebKit/GPUProcess/webrtc/RemoteSa

[webkit-changes] [WebKit/WebKit] 711a78: RefCounted should have precise tracking for RefPtr...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 711a78ba787296a441d0805b854da8f602bfd66d
  
https://github.com/WebKit/WebKit/commit/711a78ba787296a441d0805b854da8f602bfd66d
  Author: Geoffrey Garen 
  Date:   2024-09-15 (Sun, 15 Sep 2024)

  Changed paths:
M Source/WTF/wtf/RefCounted.cpp
M Source/WTF/wtf/RefCounted.h
M Source/WTF/wtf/SizeLimits.cpp
M Source/WTF/wtf/ThreadSafeRefCounted.h
M Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp

  Log Message:
  ---
  RefCounted should have precise tracking for RefPtrs that escape from 
destructors
https://bugs.webkit.org/show_bug.cgi?id=279723
rdar://136026234

Reviewed by Ryosuke Niwa.

Inside an object's destructor, if we call ref() on the object without a
balancing call to deref(), we 'escape' a RefPtr to the object. When such
a RefPtr is dereferenced or destroyed, it will use-after-free the object.

Our current approach to detecting this error is to ASSERT when we call
ref() on an object inside its destructor, and then, in cases we believe
to be false positives, silence that ASSERT using
RefPtrAllowingPartiallyDestroyed.

There are downsides to this approach:

1. RefPtrAllowingPartiallyDestroyed complex-ifies our refcounting rules,
making them hard to document and explain, and hard to write static
analyses for; and even causing confusion in software update merges.

2. In the RefPtrAllowingPartiallyDestroyed case, our detection of
use-after-free is cleverly probabilistic, but not deterministic.

3. The approach is not compatible with Swift-C++.

This patch replaces our ASSERT in ref(), stating that deletion must not
have begun, with an ASSERT after destruction is over, stating that there
must not be any outstanding references left.

To aid debugging when the ASSERT fires, we keep a lock-free global log
of all ref() calls that happen during destruction. Before we ASSERT,
we dump the log.

This should allow use to remove RefPtrAllowingPartiallyDestroyed in a
follow-up patch.

Example output from unit tests:

TestWTF.WTF_RefPtr.DanglingRefPtr
Error: Dangling RefPtr: 0x10f0041d0
This means that a ref() during destruction was not balanced by a 
deref() before destruction ended.
Below are the most recent ref()'s during destruction for this address.

1   0x10110724c WTF::RefCountedBase::refAllowingPartiallyDestroyed() 
const
2   0x101107218 WTF::RefCountedBase::ref() const
3   0x1016ae820 TestWebKitAPI::DanglingRefPtrTest::~DanglingRefPtrTest()
4   0x1016ae790 TestWebKitAPI::DanglingRefPtrTest::~DanglingRefPtrTest()
5   0x1016ae754 
WTF::RefCounted::deref() const
6   0x1016ae6d4 
WTF::DefaultRefDerefTraits::derefIfNotNull(TestWebKitAPI::DanglingRefPtrTest*)
7   0x1016a95ac WTF::RefPtr, 
WTF::DefaultRefDerefTraits>::operator=(std::nullptr_t)
8   0x1016a94c0 
TestWebKitAPI::WTF_RefPtr_DanglingRefPtr_Test::TestBody()
9   0x101b5ea8c void 
testing::internal::HandleSehExceptionsInMethodIfSupported(testing::Test*, void (testing::Test::*)(), char const*)
10  0x101b0c254 void 
testing::internal::HandleExceptionsInMethodIfSupported(testing::Test*, void (testing::Test::*)(), char const*)
11  0x101b0c188 testing::Test::Run()
12  0x101b0d388 testing::TestInfo::Run()

1   0x10110724c WTF::RefCountedBase::refAllowingPartiallyDestroyed() 
const
2   0x101107218 WTF::RefCountedBase::ref() const
3   0x1016ae7e8 TestWebKitAPI::DanglingRefPtrTest::~DanglingRefPtrTest()
4   0x1016ae790 TestWebKitAPI::DanglingRefPtrTest::~DanglingRefPtrTest()
5   0x1016ae754 
WTF::RefCounted::deref() const
6   0x1016ae6d4 
WTF::DefaultRefDerefTraits::derefIfNotNull(TestWebKitAPI::DanglingRefPtrTest*)
7   0x1016a95ac WTF::RefPtr, 
WTF::DefaultRefDerefTraits>::operator=(std::nullptr_t)
8   0x1016a94c0 
TestWebKitAPI::WTF_RefPtr_DanglingRefPtr_Test::TestBody()
9   0x101b5ea8c void 
testing::internal::HandleSehExceptionsInMethodIfSupported(testing::Test*, void (testing::Test::*)(), char const*)
10  0x101b0c254 void 
testing::internal::HandleExceptionsInMethodIfSupported(testing::Test*, void (testing::Test::*)(), char const*)
11  0x101b0c188 testing::Test::Run()
12  0x101b0d388 testing::TestInfo::Run()

TestWTF.WTF_RefPtr.DanglingRefPtrThreadSafe
Error: Dangling RefPtr: 0x1110041d0
This means that a ref() during destruction was not balanced by a 
deref() before destruction ended.
Below are the most recent ref()'s during destruction for this address.

1   0x1026b6320 
WTF::ThreadSafeRefCountedBase::refAllowingPartiallyDestroyed() const
2   0x1026b62f4 WTF::ThreadSafeRefCountedBase::ref() const
3   0x102cfad70 
TestWebKitAPI::DanglingRefPtrTestThreadSafe::~DanglingRefPtrTestThreadSafe()
4   0x102cfad08 
TestWebKitAPI::DanglingRefPtrTestThreadSafe::~DanglingRefPtrTestThreadSafe()
   

[webkit-changes] [WebKit/WebKit] bd4459: WebGPUPresentationContextDescriptor should use a s...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd44599de95d6b14a5a8a192be9c14c280846549
  
https://github.com/WebKit/WebKit/commit/bd44599de95d6b14a5a8a192be9c14c280846549
  Author: Geoffrey Garen 
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
M 
Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPresentationContextDescriptor.h

  Log Message:
  ---
  WebGPUPresentationContextDescriptor should use a smart pointer
https://bugs.webkit.org/show_bug.cgi?id=279679
rdar://135956495

Reviewed by Wenson Hsieh, Mike Wyrzykowski, and Alex Christensen.

Static analysis told me to.

* 
Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPresentationContextDescriptor.h:

Canonical link: https://commits.webkit.org/283636@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a3ae93: Deploy more smart pointers in WebKit.*WebGPU (2)

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a3ae939a297b9f8d22eece4ccc1fb242fc4a0408
  
https://github.com/WebKit/WebKit/commit/a3ae939a297b9f8d22eece4ccc1fb242fc4a0408
  Author: Geoffrey Garen 
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupLayoutProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandBufferProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCompositorIntegrationProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteComputePassEncoderProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteComputePipelineProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteExternalTextureProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePipelineLayoutProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePresentationContextProxy.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePresentationContextProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQuerySetProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPipelineProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteSamplerProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteShaderModuleProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureViewProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteXRBindingProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteXRBindingProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteXRProjectionLayerProxy.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteXRProjectionLayerProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteXRSubImageProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteXRSubImageProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteXRViewProxy.h

  Log Message:
  ---
  Deploy more smart pointers in WebKit.*WebGPU (2)
https://bugs.webkit.org/show_bug.cgi?id=279627
rdar://135914848

Reviewed by Mike Wyrzykowski.

Following static analysis.

* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupLayoutProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandBufferProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.h:
* 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCompositorIntegrationProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteComputePassEncoderProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteComputePipelineProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp:
(WebKit::WebGPU::RemoteDeviceProxy::createTexture):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteExternalTextureProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp:
(WebKit::RemoteGPUProxy::createPresentationContext):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePipelineLayoutProxy.h:
* 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePresentationContextProxy.cpp:
(WebKit::WebGPU::RemotePresentationContextProxy::getCurrentTexture):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePresentationContextProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQuerySetProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPipelineProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteSamplerProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteShaderModuleProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTex

[webkit-changes] [WebKit/WebKit] 0cc333: Deploy more smart pointers in WebKit.*WebGPU

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0cc333194f5fb9e44012e91f7cf318606b5b7a7e
  
https://github.com/WebKit/WebKit/commit/0cc333194f5fb9e44012e91f7cf318606b5b7a7e
  Author: Geoffrey Garen 
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h

  Log Message:
  ---
  Deploy more smart pointers in WebKit.*WebGPU
https://bugs.webkit.org/show_bug.cgi?id=279609
rdar://135903757

Reviewed by Chris Dumez.

As dictated by static analysis.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp:
(WebKit::RemoteAdapter::destruct):
(WebKit::RemoteAdapter::requestDevice):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp:
(WebKit::RemoteBindGroup::updateExternalTextures):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp:
(WebKit::RemoteCommandEncoder::destruct):
(WebKit::RemoteCommandEncoder::beginRenderPass):
(WebKit::RemoteCommandEncoder::beginComputePass):
(WebKit::RemoteCommandEncoder::copyBufferToBuffer):
(WebKit::RemoteCommandEncoder::clearBuffer):
(WebKit::RemoteCommandEncoder::writeTimestamp):
(WebKit::RemoteCommandEncoder::resolveQuerySet):
(WebKit::RemoteCommandEncoder::finish):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.cpp:
(WebKit::RemoteCompositorIntegration::connection const):
(WebKit::RemoteCompositorIntegration::recreateRenderBuffers):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.cpp:
(WebKit::RemoteComputePassEncoder::setPipeline):
(WebKit::RemoteComputePassEncoder::dispatchIndirect):
(WebKit::RemoteComputePassEncoder::setBindGroup):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.cpp:
(WebKit::RemoteComputePipeline::getBindGroupLayout):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp:
(WebKit::RemoteDevice::destruct):
(WebKit::RemoteDevice::createXRBinding):
(WebKit::RemoteDevice::createBuffer):
(WebKit::RemoteDevice::createTexture):
(WebKit::RemoteDevice::createSampler):
(WebKit::RemoteDevice::importExternalTextureFromVideoFrame):
(WebKit::RemoteDevice::updateExternalTexture):
(WebKit::RemoteDevice::createBindGroupLayout):
(WebKit::RemoteDevice::createPipelineLayout):
(WebKit::RemoteDevice::createBindGroup):
(WebKit::RemoteDevice::createShaderModule):
(WebKit::RemoteDevice::createComputePipeline):
(WebKit::RemoteDevice::createRenderPipeline):
(WebKit::RemoteDevice::createComputePipelineAsync):
(WebKit::RemoteDevice::createRenderPipelineAsync):
(WebKit::RemoteDevice::createCommandEncoder):
(WebKit::RemoteDevice::createRenderBundleEncoder):
(WebKit::RemoteDevice::createQuerySet):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.cpp:
(WebKit::RemoteRenderPipeline::getBindGroupLayout):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp:
(WebKit::WebGPU::RemoteDeviceProxy::createTexture):
* Source/Web

[webkit-changes] [WebKit/WebKit] d1499a: Marked some Legacy WebKit notification names as de...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d1499acf0f8633c4673883b62fd05832184f0597
  
https://github.com/WebKit/WebKit/commit/d1499acf0f8633c4673883b62fd05832184f0597
  Author: Geoffrey Garen 
  Date:   2024-06-17 (Mon, 17 Jun 2024)

  Changed paths:
M Source/WebKitLegacy/mac/WebView/WebView.h

  Log Message:
  ---
  Marked some Legacy WebKit notification names as deprecated
https://bugs.webkit.org/show_bug.cgi?id=275587
rdar://130033164

Reviewed by Brady Eidson.

The rest are already marked as such, but we missed these.

This helps clarify in the SDK why these APIs weren't updated to use modern
thread safety techniques.

* Source/WebKitLegacy/mac/WebView/WebView.h:

Canonical link: https://commits.webkit.org/280101@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 13873b: Annotate some main-thread-only classes and protoco...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13873b2f58fb7748c641b8f29ebc19e5ea73f267
  
https://github.com/WebKit/WebKit/commit/13873b2f58fb7748c641b8f29ebc19e5ea73f267
  Author: Geoffrey Garen 
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
M Source/WebKit/Shared/API/Cocoa/WKFoundation.h
M Source/WebKit/UIProcess/API/Cocoa/WKBackForwardList.h
M Source/WebKit/UIProcess/API/Cocoa/WKBackForwardListItem.h
M Source/WebKit/UIProcess/API/Cocoa/WKContentRuleList.h
M Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListStore.h
M Source/WebKit/UIProcess/API/Cocoa/WKContentWorld.h
M Source/WebKit/UIProcess/API/Cocoa/WKContextMenuElementInfo.h
M Source/WebKit/UIProcess/API/Cocoa/WKDownload.h
M Source/WebKit/UIProcess/API/Cocoa/WKDownloadDelegate.h
M Source/WebKit/UIProcess/API/Cocoa/WKFindConfiguration.h
M Source/WebKit/UIProcess/API/Cocoa/WKFindResult.h
M Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.h
M Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.h
M Source/WebKit/UIProcess/API/Cocoa/WKNavigation.h
M Source/WebKit/UIProcess/API/Cocoa/WKNavigationAction.h
M Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegate.h
M Source/WebKit/UIProcess/API/Cocoa/WKNavigationResponse.h
M Source/WebKit/UIProcess/API/Cocoa/WKOpenPanelParameters.h
M Source/WebKit/UIProcess/API/Cocoa/WKPDFConfiguration.h
M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h
M Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.h
M Source/WebKit/UIProcess/API/Cocoa/WKScriptMessage.h
M Source/WebKit/UIProcess/API/Cocoa/WKScriptMessageHandler.h
M Source/WebKit/UIProcess/API/Cocoa/WKScriptMessageHandlerWithReply.h
M Source/WebKit/UIProcess/API/Cocoa/WKSecurityOrigin.h
M Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.h
M Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h
M Source/WebKit/UIProcess/API/Cocoa/WKURLSchemeHandler.h
M Source/WebKit/UIProcess/API/Cocoa/WKUserContentController.h
M Source/WebKit/UIProcess/API/Cocoa/WKUserScript.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecord.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h
M Source/WebKit/UIProcess/API/Cocoa/WKWindowFeatures.h

  Log Message:
  ---
  Annotate some main-thread-only classes and protocols in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=273798
rdar://127629908

Reviewed by Brady Eidson.

Most WebKit APIs are main-thread-only so let's say so for better
ergonomics and error checking for clients.

I manually tested these classes:

WKBackForwardList
WKBackForwardListItem
WKWebViewConfiguration
WKUserContentController
WKContentRuleList
WKContentRuleListStore
WKContentWorld
WKContextMenuElementInfo
WKDownload
WKFindConfiguration
WKFindResult
WKFrameInfo
WKHTTPCookieStore
WKNavigation
WKNavigationAction
WKNavigationResponse
WKPreferences
WKProcessPool
WKScriptMessage
WKWebsiteDataStore
WKOpenPanelParameters
WKPDFConfiguration
WKSecurityOrigin
WKSnapshotConfiguration
WKUserScript
WKWebpagePreferences
WKWebsiteDataRecord
WKWebView
WKWindowFeatures

...and these callback-to-WebKit APIs:

WKDownloadDelegate
   - decideDestinationUsingResponse
   - willPerformHTTPRedirection
   - didReceiveAuthenticationChallenge

WKUIDelegate
   - runJavaScriptAlertPanelWithMessage
   - runJavaScriptConfirmPanelWithMessage
   - runJavaScriptTextInputPanelWithPrompt
   - requestMediaCapturePermissionForOrigin
   - requestDeviceOrientationAndMotionPermissionForOrigin
   - contextMenuConfigurationForElement
   - showLockdownModeFirstUseMessage
   - runOpenPanelWithParameters

WKScriptMessageHandlerWithReply
   - didReceiveScriptMessage

...and verified that they compile when used in "isolated" (i.e. main thread)
code and fail to compile when used in "nonisolated" (i.e. secondary thread)
code.

I manually tested these protocols:

WKHTTPCookieStoreObserver
WKUIDelegate
WKURLSchemeHandler
WKScriptMessageHandler
WKScriptMessageHandlerWithReply
WKDownloadDelegate
WKNavigationDelegate

...and these callback-to-client APIs:

WKContentRuleListStore
   - compileContentRuleListForIdentifier
   - lookUpContentRuleListForIdentifier
   - removeContentRuleListForIdentifier
   - getAvailableContentRuleListIdentifiers

WKDownload
   - cancel

WKHTTPCookieStore
   - getAllCookies
   - setCookie
   - deleteCookie
   - setCookiePolicy
   - getCookiePolicy

WKWebsiteDataStore
   - fetchDataRecordsOfTypes
   - removeDataOfTypes
   - removeDataOfTypes
   - removeDataStoreForIdentifier
   - fetchAllDataStoreIdentifiers

* WKWebView.h
   - evaluateJavaScript
   - evaluateJavaScript
   - callAsyncJavaScript
   - closeAllMediaPresentationsWithCompletionHandler
   - pauseAllMediaPlaybackWithCompletionHandler
   - setAllMediaPlaybackSuspended
   

[webkit-changes] [WebKit/WebKit] cdf0e8: Weak ref smart pointer check should be smarter

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cdf0e8ad7972a47c7ef9a620b28dcbc12eeb88f9
  
https://github.com/WebKit/WebKit/commit/cdf0e8ad7972a47c7ef9a620b28dcbc12eeb88f9
  Author: Geoffrey Garen 
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
M Source/WTF/wtf/TypeTraits.h
M Source/WTF/wtf/WeakPtr.h
M Source/WTF/wtf/WeakRef.h

  Log Message:
  ---
  Weak ref smart pointer check should be smarter
https://bugs.webkit.org/show_bug.cgi?id=273594
rdar://127395924

Reviewed by Chris Dumez.

Improved the SFINAE usage to account for const/non-const overload.

Moved the static_assert to dereference operations so that WeakPtr can be
more like T* in its support for forward declaration. Now you don't need the
full type definition available in order to destroy a WeakPtr; only to
dereference one.

* Source/WTF/wtf/TypeTraits.h:
* Source/WTF/wtf/WeakPtr.h:
(WTF::WeakPtr::releaseImpl):
(WTF::WeakPtr::get const):
(WTF::WeakPtr::operator-> const):
(WTF::WeakPtr::operator* const):
(WTF::WeakPtr::~WeakPtr): Deleted.
* Source/WTF/wtf/WeakRef.h:
(WTF::WeakRef::ptrAllowingHashTableEmptyValue const):
(WTF::WeakRef::ptr const):
(WTF::WeakRef::get const):
(WTF::WeakRef::~WeakRef): Deleted.

Canonical link: https://commits.webkit.org/278249@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 03f4b6: Fix the MODEL_PROCESS build after 278224@main

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03f4b61006b78fc7053a78fa282b14efe01829f9
  
https://github.com/WebKit/WebKit/commit/03f4b61006b78fc7053a78fa282b14efe01829f9
  Author: Geoffrey Garen 
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
M Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.h

  Log Message:
  ---
  Fix the MODEL_PROCESS build after 278224@main
https://bugs.webkit.org/show_bug.cgi?id=273579
rdar://127387527

Unreviewed, build fix.

Added some more exceptions.

* Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.h:

Canonical link: https://commits.webkit.org/278233@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c13321: Added a compile time assertion that forbids classe...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c13321a96e1de0debe0e734a4b092001b22854aa
  
https://github.com/WebKit/WebKit/commit/c13321a96e1de0debe0e734a4b092001b22854aa
  Author: Geoffrey Garen 
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
M Source/JavaScriptCore/inspector/InspectorTarget.h
M Source/JavaScriptCore/runtime/ConsoleClient.h
M Source/JavaScriptCore/runtime/JSGlobalObject.cpp
M Source/JavaScriptCore/runtime/JSGlobalObject.h
M Source/WTF/wtf/CancellableTask.h
M Source/WTF/wtf/ListHashSet.h
M Source/WTF/wtf/NativePromise.h
M Source/WTF/wtf/Observer.h
M Source/WTF/wtf/TypeTraits.h
M Source/WTF/wtf/WeakPtr.h
M Source/WTF/wtf/WeakRef.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBufferBinding.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCanvasConfiguration.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUImageCopyTexture.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPipelineDescriptorBase.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUProgrammableStage.h
M 
Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassColorAttachment.h
M 
Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDepthStencilAttachment.h
M Source/WebCore/Modules/applepay/PaymentCoordinator.h
M Source/WebCore/Modules/audiosession/DOMAudioSession.h
M Source/WebCore/Modules/encryptedmedia/CDMClient.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemClient.h
M Source/WebCore/Modules/fetch/FormDataConsumer.h
M Source/WebCore/Modules/gamepad/NavigatorGamepad.h
M Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseManager.h
M Source/WebCore/Modules/mediarecorder/MediaRecorder.h
M Source/WebCore/Modules/mediasession/MediaSession.cpp
M Source/WebCore/Modules/mediasession/MediaSession.h
M Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h
M Source/WebCore/Modules/mediasession/MediaSessionCoordinatorPrivate.h
M Source/WebCore/Modules/mediastream/MediaStream.h
M Source/WebCore/Modules/mediastream/MediaStreamTrack.h
M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.h
M Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
M Source/WebCore/Modules/mediastream/RTCController.h
M Source/WebCore/Modules/mediastream/RTCDataChannelRemoteHandler.h
M Source/WebCore/Modules/mediastream/RTCDtlsTransport.h
M Source/WebCore/Modules/mediastream/RTCDtlsTransportBackend.h
M Source/WebCore/Modules/mediastream/RTCIceTransport.h
M Source/WebCore/Modules/mediastream/RTCIceTransportBackend.h
M Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp
M Source/WebCore/Modules/mediastream/RTCRtpTransceiver.h
M Source/WebCore/Modules/mediastream/RTCSctpTransport.h
M Source/WebCore/Modules/mediastream/RTCSctpTransportBackend.h
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerDtlsTransportBackend.cpp
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerDtlsTransportBackend.h
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceTransportBackend.cpp
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceTransportBackend.h
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpSenderBackend.h
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerSctpTransportBackend.cpp
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerSctpTransportBackend.h
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.cpp
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.h
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.cpp
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.h
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCSctpTransportBackend.cpp
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCSctpTransportBackend.h
M Source/WebCore/Modules/model-element/ModelPlayerClient.h
M Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderClient.h
M Source/WebCore/Modules/permissions/PermissionObserver.h
M Source/WebCore/Modules/speech/SpeechRecognitionCaptureSourceImpl.h
M Source/WebCore/Modules/speech/SpeechRecognitionConnectionClient.h
M Source/WebCore/Modules/speech/SpeechRecognitionRequest.h
M Source/WebCore/Modules/speech/SpeechRecognizer.h
M Source/WebCore/Modules/storage/StorageManager.cpp
M Source/WebCore/Modules/storage/StorageManager.h
M Source/WebCo

[webkit-changes] [WebKit/WebKit] 4e0902: REGRESSION (277633@main): [ MacOS iOS Debug ] Test...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e0902cf80f621c0d596a179bf3c71f4765ebd61
  
https://github.com/WebKit/WebKit/commit/4e0902cf80f621c0d596a179bf3c71f4765ebd61
  Author: Geoffrey Garen 
  Date:   2024-04-24 (Wed, 24 Apr 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WTF/CheckedPtr.cpp
M Tools/TestWebKitAPI/Tests/WTF/CheckedRef.cpp

  Log Message:
  ---
  REGRESSION (277633@main): [ MacOS iOS Debug ] 
TestWTF.WTF_CheckedPtr.CheckedRef is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=273158
rdar://126954078

Unreviewed test fix.

Removed use after destruction test, since we assert when you do that now.

Changed test objects to be heap-allocated instead of stack-allocated. Stack
allocation wasn't the direct cause of the failure we saw, but CheckedPtr
requires heap allocation as of 277633@main, so let's do it right.

* Tools/TestWebKitAPI/Tests/WTF/CheckedPtr.cpp:
(TestWebKitAPI::TEST(WTF_CheckedPtr, Basic)):
(TestWebKitAPI::TEST(WTF_CheckedPtr, CheckedRef)):
(TestWebKitAPI::TEST(WTF_CheckedPtr, DerivedClass)):
(TestWebKitAPI::TEST(WTF_CheckedPtr, HashSet)):
(TestWebKitAPI::TEST(WTF_CheckedPtr, ReferenceCountLimit)):
(TestWebKitAPI::TEST(WTF_CheckedPtr, CanMakeThreadSafeCheckedPtr)):
* Tools/TestWebKitAPI/Tests/WTF/CheckedRef.cpp:

Canonical link: https://commits.webkit.org/277922@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2e9fdd: One file per class for WeakPtrImpl, WeakPtrFactory...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e9fdd8937169f6c6c4161bf5bcc4fd4cad3cef5
  
https://github.com/WebKit/WebKit/commit/2e9fdd8937169f6c6c4161bf5bcc4fd4cad3cef5
  Author: Geoffrey Garen 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
A Source/WTF/wtf/CanMakeWeakPtr.h
M Source/WTF/wtf/WeakPtr.h
A Source/WTF/wtf/WeakPtrFactory.h
A Source/WTF/wtf/WeakPtrImpl.h
M Source/WTF/wtf/WeakRef.h

  Log Message:
  ---
  One file per class for WeakPtrImpl, WeakPtrFactory, and CanMakeWeakPtr

https://bugs.webkit.org/show_bug.cgi?id=273084
rdar://126878970

Reviewed by Chris Dumez.

* Source/WTF/wtf/CanMakeWeakPtr.h:
* Source/WTF/wtf/WeakPtr.h:
* Source/WTF/wtf/WeakPtrImpl.h:

Canonical link: https://commits.webkit.org/277848@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cd5312: Removed CHECKED_POINTER_DEBUG

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd53122f509a647fe44aaeaf14b865194bbe6da4
  
https://github.com/WebKit/WebKit/commit/cd53122f509a647fe44aaeaf14b865194bbe6da4
  Author: Geoffrey Garen 
  Date:   2024-04-17 (Wed, 17 Apr 2024)

  Changed paths:
M Source/WTF/wtf/CheckedPtr.h
M Source/WTF/wtf/CheckedRef.h
M Source/WebCore/Modules/speech/SpeechRecognitionCaptureSourceImpl.h
M Source/WebCore/dom/PendingScriptClient.h
M Source/WebCore/dom/ScriptRunner.h
M Source/WebCore/html/parser/HTMLDocumentParser.h
M Source/WebCore/platform/cocoa/PlaybackSessionModel.h
M Source/WebCore/platform/cocoa/VideoPresentationModel.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
M Source/WebCore/platform/graphics/cocoa/NullPlaybackSessionInterface.h
M Source/WebCore/platform/graphics/cocoa/NullVideoPresentationInterface.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h
M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
M Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.h
M Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm
M Source/WebCore/platform/mac/VideoPresentationInterfaceMac.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.h
M Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.h
M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
M 
Source/WebCore/platform/mediastream/mac/MediaStreamTrackAudioSourceProviderCocoa.h
M Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h
M Source/WebCore/rendering/RenderListBox.h
M Source/WebCore/testing/Internals.h
M Source/WebCore/xml/parser/XMLDocumentParser.h
M Source/WebKit/NetworkProcess/Downloads/DownloadManager.h
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
M 
Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp
M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h
M Source/WebKit/WebProcess/cocoa/VideoPresentationManager.h

  Log Message:
  ---
  Removed CHECKED_POINTER_DEBUG
https://bugs.webkit.org/show_bug.cgi?id=272866
rdar://126655179

Reviewed by Ryosuke Niwa.

As of 277590@main, a dangling CheckedPtr crashes in its destructor. That
directly shows us the CheckedPtr we were using CHECKED_POINTER_DEBUG to 
discover.

Canonical link: https://commits.webkit.org/277650@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9c719c: Unreviewed, re-landing 277590@main

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c719c79cdfa4cf0ba10756b3da3e7b4a10fc14c
  
https://github.com/WebKit/WebKit/commit/9c719c79cdfa4cf0ba10756b3da3e7b4a10fc14c
  Author: Geoffrey Garen 
  Date:   2024-04-17 (Wed, 17 Apr 2024)

  Changed paths:
M Source/WTF/wtf/CheckedRef.h
M Source/WTF/wtf/FastMalloc.h
M Source/WTF/wtf/SingleThreadIntegralWrapper.h
M Source/WebCore/Modules/fetch/FetchLoader.h
M Source/WebCore/Modules/notifications/NotificationResourcesLoader.h
M Source/WebCore/Modules/speech/SpeechRecognitionCaptureSourceImpl.h
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/animation/DocumentTimelinesController.h
M Source/WebCore/bindings/js/ScriptController.h
M Source/WebCore/dom/CustomElementDefaultARIA.h
M Source/WebCore/dom/CustomElementReactionQueue.h
M Source/WebCore/dom/DeviceMotionController.h
M Source/WebCore/dom/DeviceOrientationController.h
M Source/WebCore/dom/DocumentMarkerController.h
M Source/WebCore/dom/EventLoop.h
M Source/WebCore/dom/ExtensionStyleSheets.cpp
M Source/WebCore/dom/ExtensionStyleSheets.h
M Source/WebCore/dom/FullscreenManager.h
M Source/WebCore/dom/IdTargetObserver.h
M Source/WebCore/dom/IdTargetObserverRegistry.cpp
M Source/WebCore/dom/IdTargetObserverRegistry.h
M Source/WebCore/dom/PendingScriptClient.h
M Source/WebCore/dom/RejectedPromiseTracker.h
M Source/WebCore/dom/ScriptRunner.h
M Source/WebCore/dom/VisitedLinkState.h
M Source/WebCore/dom/messageports/MessagePortChannelRegistry.h
M Source/WebCore/dom/messageports/WorkerMessagePortChannelProvider.h
M Source/WebCore/editing/Editor.h
M Source/WebCore/editing/FrameSelection.h
M Source/WebCore/editing/TextManipulationController.h
M Source/WebCore/fileapi/FileReaderLoader.h
M Source/WebCore/history/BackForwardController.h
M Source/WebCore/history/CachedPage.h
M Source/WebCore/html/FTPDirectoryDocument.cpp
M Source/WebCore/html/FormListedElement.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/parser/HTMLDocumentParser.h
M Source/WebCore/html/parser/TextDocumentParser.h
M Source/WebCore/html/shadow/SliderThumbElement.cpp
M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp
M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.h
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
M Source/WebCore/layout/layouttree/LayoutBox.h
M Source/WebCore/layout/layouttree/LayoutElementBox.h
M Source/WebCore/layout/layouttree/LayoutInitialContainingBlock.h
M Source/WebCore/layout/layouttree/LayoutInlineTextBox.h
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/FrameLoader.h
M Source/WebCore/loader/HistoryController.h
M Source/WebCore/loader/NavigationScheduler.h
M Source/WebCore/loader/ProgressTracker.h
M Source/WebCore/loader/ThreadableLoaderClient.h
M Source/WebCore/loader/WorkerThreadableLoader.cpp
M Source/WebCore/loader/WorkerThreadableLoader.h
M Source/WebCore/page/AlternativeTextClient.h
M Source/WebCore/page/DeviceController.h
M Source/WebCore/page/DiagnosticLoggingClient.h
M Source/WebCore/page/EditorClient.h
M Source/WebCore/page/ElementTargetingController.h
M Source/WebCore/page/EventHandler.h
M Source/WebCore/page/EventSource.h
M Source/WebCore/page/FocusController.h
M Source/WebCore/page/FrameView.h
M Source/WebCore/page/LocalFrameView.h
M Source/WebCore/page/LocalFrameViewLayoutContext.h
M Source/WebCore/page/PageConsoleClient.h
M Source/WebCore/page/RemoteFrameView.h
M Source/WebCore/page/RenderingUpdateScheduler.h
M Source/WebCore/page/csp/ContentSecurityPolicy.h
M Source/WebCore/page/scrolling/ScrollingStateTree.h
M Source/WebCore/platform/KeyboardScrollingAnimator.h
M Source/WebCore/platform/OrientationNotifier.h
M Source/WebCore/platform/ScrollView.h
M Source/WebCore/platform/ScrollableArea.cpp
M Source/WebCore/platform/ScrollableArea.h
M Source/WebCore/platform/cocoa/PlaybackSessionModel.h
M Source/WebCore/platform/cocoa/VideoPresentationModel.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
M Source/WebCore/platform/graphics/DisplayRefreshMonitorClient.h
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/platform/graphics/TextRun.cpp
M Source/WebCore/platform/graphics/TextRun.h
M Source/WebCore/platform/graphics/TiledBacking.h
M Source/WebCore/platform/graphics/ca/LayerPool.h
M Source/WebCore/platform/graphics/ca/TileController.h
M Source/WebCore/platform/graphics/cocoa/NullPlaybackSessionInterface.h
M Source/WebCore/platform/graphics/cocoa/NullVideoPresentationInterface.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h
M Source/WebCore/platform/ios/P

[webkit-changes] [WebKit/WebKit] bf47ad: CheckedPtr should use zombie mode

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bf47ad4f9e351004a197f61b30dae13c11a03c37
  
https://github.com/WebKit/WebKit/commit/bf47ad4f9e351004a197f61b30dae13c11a03c37
  Author: Geoffrey Garen 
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
M Source/WTF/wtf/CheckedRef.h
M Source/WTF/wtf/FastMalloc.h
M Source/WTF/wtf/SingleThreadIntegralWrapper.h
M Source/WebCore/Modules/fetch/FetchLoader.h
M Source/WebCore/Modules/notifications/NotificationResourcesLoader.h
M Source/WebCore/Modules/speech/SpeechRecognitionCaptureSourceImpl.h
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/animation/DocumentTimelinesController.h
M Source/WebCore/bindings/js/ScriptController.h
M Source/WebCore/dom/CustomElementDefaultARIA.h
M Source/WebCore/dom/CustomElementReactionQueue.h
M Source/WebCore/dom/DeviceMotionController.h
M Source/WebCore/dom/DeviceOrientationController.h
M Source/WebCore/dom/DocumentMarkerController.h
M Source/WebCore/dom/EventLoop.h
M Source/WebCore/dom/ExtensionStyleSheets.cpp
M Source/WebCore/dom/ExtensionStyleSheets.h
M Source/WebCore/dom/FullscreenManager.h
M Source/WebCore/dom/IdTargetObserver.h
M Source/WebCore/dom/IdTargetObserverRegistry.cpp
M Source/WebCore/dom/IdTargetObserverRegistry.h
M Source/WebCore/dom/PendingScriptClient.h
M Source/WebCore/dom/RejectedPromiseTracker.h
M Source/WebCore/dom/ScriptRunner.h
M Source/WebCore/dom/VisitedLinkState.h
M Source/WebCore/dom/messageports/MessagePortChannelRegistry.h
M Source/WebCore/dom/messageports/WorkerMessagePortChannelProvider.h
M Source/WebCore/editing/Editor.h
M Source/WebCore/editing/FrameSelection.h
M Source/WebCore/editing/TextManipulationController.h
M Source/WebCore/fileapi/FileReaderLoader.h
M Source/WebCore/history/BackForwardController.h
M Source/WebCore/history/CachedPage.h
M Source/WebCore/html/FTPDirectoryDocument.cpp
M Source/WebCore/html/FormListedElement.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/parser/HTMLDocumentParser.h
M Source/WebCore/html/parser/TextDocumentParser.h
M Source/WebCore/html/shadow/SliderThumbElement.cpp
M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp
M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.h
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
M Source/WebCore/layout/layouttree/LayoutBox.h
M Source/WebCore/layout/layouttree/LayoutElementBox.h
M Source/WebCore/layout/layouttree/LayoutInitialContainingBlock.h
M Source/WebCore/layout/layouttree/LayoutInlineTextBox.h
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/FrameLoader.h
M Source/WebCore/loader/HistoryController.h
M Source/WebCore/loader/NavigationScheduler.h
M Source/WebCore/loader/ProgressTracker.h
M Source/WebCore/loader/ThreadableLoaderClient.h
M Source/WebCore/loader/WorkerThreadableLoader.cpp
M Source/WebCore/loader/WorkerThreadableLoader.h
M Source/WebCore/page/AlternativeTextClient.h
M Source/WebCore/page/DeviceController.h
M Source/WebCore/page/DiagnosticLoggingClient.h
M Source/WebCore/page/EditorClient.h
M Source/WebCore/page/ElementTargetingController.h
M Source/WebCore/page/EventHandler.h
M Source/WebCore/page/EventSource.h
M Source/WebCore/page/FocusController.h
M Source/WebCore/page/FrameView.h
M Source/WebCore/page/LocalFrameView.h
M Source/WebCore/page/LocalFrameViewLayoutContext.h
M Source/WebCore/page/PageConsoleClient.h
M Source/WebCore/page/RemoteFrameView.h
M Source/WebCore/page/RenderingUpdateScheduler.h
M Source/WebCore/page/csp/ContentSecurityPolicy.h
M Source/WebCore/page/scrolling/ScrollingStateTree.h
M Source/WebCore/platform/KeyboardScrollingAnimator.h
M Source/WebCore/platform/OrientationNotifier.h
M Source/WebCore/platform/ScrollView.h
M Source/WebCore/platform/ScrollableArea.cpp
M Source/WebCore/platform/ScrollableArea.h
M Source/WebCore/platform/cocoa/PlaybackSessionModel.h
M Source/WebCore/platform/cocoa/VideoPresentationModel.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
M Source/WebCore/platform/graphics/DisplayRefreshMonitorClient.h
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/platform/graphics/TextRun.cpp
M Source/WebCore/platform/graphics/TextRun.h
M Source/WebCore/platform/graphics/TiledBacking.h
M Source/WebCore/platform/graphics/ca/LayerPool.h
M Source/WebCore/platform/graphics/ca/TileController.h
M Source/WebCore/platform/graphics/cocoa/NullPlaybackSessionInterface.h
M Source/WebCore/platform/graphics/cocoa/NullVideoPresentationInterface.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h
M Source/WebCore/platform/ios/P

[webkit-changes] [WebKit/WebKit] 8b7d41: CheckedPtr should require FastMalloc, Part 2

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b7d41505065a3dacb612e0dc4112df118590c05
  
https://github.com/WebKit/WebKit/commit/8b7d41505065a3dacb612e0dc4112df118590c05
  Author: Geoffrey Garen 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WTF/wtf/CheckedRef.h
M Source/WebCore/Modules/speech/SpeechRecognitionCaptureSourceImpl.h
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/animation/DocumentTimelinesController.h
M Source/WebCore/bindings/js/ScriptController.h
M Source/WebCore/dom/CustomElementDefaultARIA.h
M Source/WebCore/dom/CustomElementReactionQueue.h
M Source/WebCore/dom/DocumentMarkerController.h
M Source/WebCore/dom/EventLoop.h
M Source/WebCore/dom/ExtensionStyleSheets.h
M Source/WebCore/dom/FullscreenManager.h
M Source/WebCore/dom/IdTargetObserver.h
M Source/WebCore/dom/IdTargetObserverRegistry.h
M Source/WebCore/dom/PendingScriptClient.h
M Source/WebCore/dom/RejectedPromiseTracker.h
M Source/WebCore/dom/ScriptRunner.h
M Source/WebCore/dom/VisitedLinkState.h
M Source/WebCore/dom/messageports/MessagePortChannelRegistry.h
M Source/WebCore/dom/messageports/WorkerMessagePortChannelProvider.h
M Source/WebCore/editing/Editor.h
M Source/WebCore/editing/FrameSelection.h
M Source/WebCore/editing/TextManipulationController.h
M Source/WebCore/history/BackForwardController.h
M Source/WebCore/history/CachedPage.h
M Source/WebCore/html/parser/HTMLDocumentParser.h
M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.h
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
M Source/WebCore/layout/layouttree/LayoutBox.h
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/FrameLoader.h
M Source/WebCore/loader/HistoryController.h
M Source/WebCore/loader/NavigationScheduler.h
M Source/WebCore/loader/ProgressTracker.h
M Source/WebCore/loader/ThreadableLoaderClient.h
M Source/WebCore/page/AlternativeTextClient.h
M Source/WebCore/page/DeviceController.h
M Source/WebCore/page/DiagnosticLoggingClient.h
M Source/WebCore/page/EditorClient.h
M Source/WebCore/page/ElementTargetingController.h
M Source/WebCore/page/EventHandler.h
M Source/WebCore/page/FocusController.h
M Source/WebCore/page/LocalFrameViewLayoutContext.h
M Source/WebCore/page/PageConsoleClient.h
M Source/WebCore/page/csp/ContentSecurityPolicy.h
M Source/WebCore/page/scrolling/ScrollingStateTree.h
M Source/WebCore/platform/KeyboardScrollingAnimator.h
M Source/WebCore/platform/OrientationNotifier.h
M Source/WebCore/platform/ScrollView.h
M Source/WebCore/platform/ScrollableArea.cpp
M Source/WebCore/platform/ScrollableArea.h
M Source/WebCore/platform/cocoa/PlaybackSessionModel.h
M Source/WebCore/platform/cocoa/VideoPresentationModel.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
M Source/WebCore/platform/graphics/DisplayRefreshMonitorClient.h
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/platform/graphics/GlyphBuffer.h
M Source/WebCore/platform/graphics/TextRun.cpp
M Source/WebCore/platform/graphics/TextRun.h
M Source/WebCore/platform/graphics/TiledBacking.h
M Source/WebCore/platform/graphics/WidthIterator.cpp
M Source/WebCore/platform/graphics/ca/LayerPool.h
M Source/WebCore/platform/graphics/cocoa/NullPlaybackSessionInterface.h
M Source/WebCore/platform/graphics/cocoa/NullVideoPresentationInterface.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h
M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
M Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.h
M Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm
M Source/WebCore/platform/mac/VideoPresentationInterfaceMac.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateMock.h
M Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.h
M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
M 
Source/WebCore/platform/mediastream/mac/MediaStreamTrackAudioSourceProviderCocoa.h
M Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h
M Source/WebCore/platform/network/curl/CurlMultipartHandleClient.h
M Source/WebCore/platform/network/curl/CurlRequest.h
M Source/WebCore/platform/sql/SQLiteDatabase.h
M Source/WebCore/rendering/LegacyRootInlineBox.cpp
M Source/WebCore/rendering/LegacyRoo

[webkit-changes] [WebKit/WebKit] 1bcc99: CheckedPtr should require FastMalloc, Part 1

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1bcc994da88e880d58bef947d62b6c89bd290b90
  
https://github.com/WebKit/WebKit/commit/1bcc994da88e880d58bef947d62b6c89bd290b90
  Author: Geoffrey Garen 
  Date:   2024-03-31 (Sun, 31 Mar 2024)

  Changed paths:
M Source/WTF/wtf/CheckedPtr.h
M Source/WTF/wtf/FastMalloc.h
M Source/WTF/wtf/StdLibExtras.h
M Source/WTF/wtf/UniqueRef.h
M Source/WebCore/platform/ScrollableArea.cpp
M Source/WebCore/platform/graphics/TextRun.cpp
M Source/WebCore/rendering/LegacyRootInlineBox.cpp
M Source/WebCore/rendering/MarkedText.h
M Source/WebCore/rendering/RegionContext.h
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebKit/Shared/WebPreferencesStore.h
M Source/bmalloc/bmalloc/IsoHeap.h
M Source/bmalloc/bmalloc/IsoHeapInlines.h
M Source/bmalloc/bmalloc/TZoneHeap.h
M Source/bmalloc/bmalloc/TZoneHeapInlines.h

  Log Message:
  ---
  CheckedPtr should require FastMalloc, Part 1
https://bugs.webkit.org/show_bug.cgi?id=271950

Reviewed by Ryosuke Niwa.

This will enable zombie-mode CheckedPtr.

It's also just good performance hygiene.

* Source/WTF/wtf/CheckedPtr.h:
(WTF::CheckedPtr::refIfNotNull):
(WTF::CheckedPtr::derefIfNotNull): Use static_assert to verify use of 
FastMalloc.
This is a good spot because it provides a complete type definition for T and
it's our lowest level funnel. (Not enabled yet because there are a few complex
cases left to work through.)

(WTF::CheckedPtr::operator UnspecifiedBoolType const): Deleted.
(WTF::CheckedPtr::unspecifiedBoolTypeInstance const): Deleted. Took the
opportunity to remove these. 'explicit operator bool()' obsoletes them.

* Source/WTF/wtf/FastMalloc.h: Capitalized our type name since that's WebKit
style. Renamed to WTFIsFastAllocated to match the macro WTF_MAKE_FAST_ALLOCATED.

* Source/WTF/wtf/StdLibExtras.h:
(WTF::makeUnique):
(WTF::makeUniqueWithoutRefCountedCheck):
(WTF::makeUniqueWithoutFastMallocCheck): Adopted new typename for
WTFIsFastAllocated and added a little more instruction to the error message.

* Source/WTF/wtf/UniqueRef.h:
(WTF::makeUniqueRef): Ditto

* Source/bmalloc/bmalloc/IsoHeap.h:
* Source/bmalloc/bmalloc/IsoHeapInlines.h:
* Source/bmalloc/bmalloc/TZoneHeap.h:
* Source/bmalloc/bmalloc/TZoneHeapInlines.h: Ditto

* Source/WebCore/platform/ScrollableArea.cpp:
* Source/WebCore/platform/graphics/TextRun.cpp:
* Source/WebCore/rendering/LegacyRootInlineBox.cpp:
* Source/WebCore/rendering/MarkedText.h:
* Source/WebCore/rendering/RegionContext.h: Adopt FastMalloc.

* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::adjustOverflowScrollbarContainerLayers): Fixed
a type safety bug uncovered by removing the UnspecifiedBoolType operator. This
code certainly did something before, but probably not what the author expected! 
:P

* Source/WebCore/rendering/RenderObject.cpp:
* Source/WebKit/Shared/WebPreferencesStore.h: Adopt FastMalloc.

Canonical link: https://commits.webkit.org/276869@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0dc90f: Remove more ASSERTs from WebFullScreenManager::wil...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0dc90f513149b730dd704f1e19f97bebcc6da750
  
https://github.com/WebKit/WebKit/commit/0dc90f513149b730dd704f1e19f97bebcc6da750
  Author: Geoffrey Garen 
  Date:   2022-12-06 (Tue, 06 Dec 2022)

  Changed paths:
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp

  Log Message:
  ---
  Remove more ASSERTs from WebFullScreenManager::willExitFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=248829


Reviewed by Ryan Haddad.

Remove all m_element ASSERTs in the exit path. Some are still firing
when running media/video-fullscreen-reload-crash.html.

* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::didExitFullScreen):
(WebKit::WebFullScreenManager::requestExitFullScreen):

Canonical link: https://commits.webkit.org/257433@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dcbdfc: Remove an ASSERT from WebFullScreenManager::willEx...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dcbdfca03eb01d96bc0e7746a8c580c988a53564
  
https://github.com/WebKit/WebKit/commit/dcbdfca03eb01d96bc0e7746a8c580c988a53564
  Author: Geoffrey Garen 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp

  Log Message:
  ---
  Remove an ASSERT from WebFullScreenManager::willExitFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=248782
rdar://102997345

Reviewed by Aditya Keerthi.

This ASSERT fires when running media/video-fullscreen-reload-crash.html.

* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::willExitFullScreen):

Canonical link: https://commits.webkit.org/257384@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cb6582: Remove the DidExceedBackgroundResourceLimitWhileIn...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb6582ef6afa39ef0358603c30a8d8ac80314701
  
https://github.com/WebKit/WebKit/commit/cb6582ef6afa39ef0358603c30a8d8ac80314701
  Author: Geoffrey Garen 
  Date:   2022-10-07 (Fri, 07 Oct 2022)

  Changed paths:
M Source/WTF/wtf/MemoryPressureHandler.cpp
M Source/WTF/wtf/MemoryPressureHandler.h
M Source/WebKit/UIProcess/API/APIUIClient.h
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/C/WKPageUIClient.h
M Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
M Source/WebKit/UIProcess/Cocoa/UIDelegate.h
M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/UIProcess/WebProcessProxy.messages.in
M Source/WebKit/WebProcess/WebProcess.cpp

  Log Message:
  ---
  Remove the DidExceedBackgroundResourceLimitWhileInForeground delegate callback
https://bugs.webkit.org/show_bug.cgi?id=246230


Reviewed by Chris Dumez.

Because it is unused.

* Source/WTF/wtf/MemoryPressureHandler.cpp:
(WTF::MemoryPressureHandler::doesExceedInactiveLimitWhileActive): Deleted.
(WTF::MemoryPressureHandler::doesNotExceedInactiveLimitWhileActive): Deleted.
* Source/WTF/wtf/MemoryPressureHandler.h:
(WTF::MemoryPressureHandler::setMemoryPressureStatusChangedCallback):
(WTF::MemoryPressureHandler::setDidExceedInactiveLimitWhileActiveCallback): 
Deleted.
* Source/WebKit/UIProcess/API/APIUIClient.h:
(API::UIClient::didExceedBackgroundResourceLimitWhileInForeground): Deleted.
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* Source/WebKit/UIProcess/API/C/WKPageUIClient.h:
* Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.h:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didExceedBackgroundResourceLimitWhileInForeground):
 Deleted.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didExceedInactiveMemoryLimitWhileActive): Deleted.
(WebKit::WebPageProxy::didExceedBackgroundCPULimitWhileInForeground): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didExceedCPULimit):
(WebKit::WebProcessProxy::didExceedInactiveMemoryLimitWhileActive): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::isUnderMemoryPressure const):
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

Canonical link: https://commits.webkit.org/255301@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes