[webkit-changes] [147157] trunk/Source/WebCore

[jamesr]

Title: [147157] trunk/Source/WebCore








Revision 147157
Author jam...@google.com
Date 2013-03-28 14:31:38 -0700 (Thu, 28 Mar 2013)


Log Message
Remove unnecessary 1 second sleep on windows from preprocessor.pm
https://bugs.webkit.org/show_bug.cgi?id=113536

Unreviewed, partial rollout of r146661.

This rolls out one line of 146661 that slows down the windows build significantly.

* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/preprocessor.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (147156 => 147157)

--- trunk/Source/WebCore/ChangeLog	2013-03-28 21:03:44 UTC (rev 147156)
+++ trunk/Source/WebCore/ChangeLog	2013-03-28 21:31:38 UTC (rev 147157)
@@ -1,3 +1,15 @@
+2013-03-28  James Robinson  jam...@chromium.org
+
+Remove unnecessary 1 second sleep on windows from preprocessor.pm
+https://bugs.webkit.org/show_bug.cgi?id=113536
+
+Unreviewed, partial rollout of r146661.
+
+This rolls out one line of 146661 that slows down the windows build significantly.
+
+* bindings/scripts/preprocessor.pm:
+(applyPreprocessor):
+
 2013-03-28  Levi Weintraub  le...@chromium.org
 
 Enable font measurement optimization for Chromium-mac when there are no font-feature-settings.


Modified: trunk/Source/WebCore/bindings/scripts/preprocessor.pm (147156 => 147157)

--- trunk/Source/WebCore/bindings/scripts/preprocessor.pm	2013-03-28 21:03:44 UTC (rev 147156)
+++ trunk/Source/WebCore/bindings/scripts/preprocessor.pm	2013-03-28 21:31:38 UTC (rev 147157)
@@ -85,7 +85,7 @@
 # name isn't needlessly echoed.
 use Symbol 'gensym'; my $err = gensym;
 $pid = open3(\*PP_IN, \*PP_OUT, $err, split(' ', $preprocessor), @args, @macros, $fileName);
-sleep 1;
+1;
 } or do {
 sleep 1;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [146850] trunk/LayoutTests

[jamesr]

Title: [146850] trunk/LayoutTests








Revision 146850
Author jam...@google.com
Date 2013-03-25 23:07:52 -0700 (Mon, 25 Mar 2013)


Log Message
Update a few more chromium compositor baselines.

* platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png
trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (146849 => 146850)

--- trunk/LayoutTests/ChangeLog	2013-03-26 04:51:35 UTC (rev 146849)
+++ trunk/LayoutTests/ChangeLog	2013-03-26 06:07:52 UTC (rev 146850)
@@ -1,3 +1,14 @@
+2013-03-25  James Robinson  jam...@chromium.org
+
+Update a few more chromium compositor baselines.
+
+* platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
+* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
+* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
+* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
+* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
+* platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.
+
 2013-03-25  Noel Gordon  noel.gor...@gmail.com
 
 [chromium] Rebaseline canvas-toDataURL-webp test expectations


Deleted: trunk/LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt (146849 => 146850)

--- trunk/LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt	2013-03-26 04:51:35 UTC (rev 146849)
+++ trunk/LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt	2013-03-26 06:07:52 UTC (rev 146850)
@@ -1,31 +0,0 @@
-(GraphicsLayer
-  (bounds 800.00 600.00)
-  (children 1
-(GraphicsLayer
-  (bounds 800.00 600.00)
-  (contentsOpaque 1)
-  (children 4
-(GraphicsLayer
-  (position 21.00 21.00)
-  (bounds 100.00 100.00)
-)
-(GraphicsLayer
-  (position 21.00 21.00)
-  (bounds 100.00 100.00)
-  (contentsOpaque 1)
-  (drawsContent 1)
-)
-(GraphicsLayer
-  (bounds 142.00 142.00)
-  (drawsContent 1)
-)
-(GraphicsLayer
-  (position 0.00 13.00)
-  (bounds 216.00 15.00)
-  (drawsContent 1)
-)
-  )
-)
-  )
-)
-


Added: trunk/LayoutTests/platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt (0 => 146850)

--- trunk/LayoutTests/platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt	2013-03-26 06:07:52 UTC (rev 146850)
@@ -0,0 +1,58 @@
+
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (children 1
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (contentsOpaque 1)
+  (children 2
+(GraphicsLayer
+  (position 58.00 58.00)
+  (bounds 350.00 200.00)
+  (drawsContent 1)
+  (children 1
+(GraphicsLayer
+  (position 15.00 15.00)
+  (children 2
+(GraphicsLayer
+  (bounds 305.00 170.00)
+  

[webkit-changes] [146936] trunk/LayoutTests

[jamesr]

Title: [146936] trunk/LayoutTests








Revision 146936
Author jam...@google.com
Date 2013-03-26 15:03:57 -0700 (Tue, 26 Mar 2013)


Log Message
Clean up last failing expectations from solid color layer patch.

* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt
trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png
trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt
trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt
trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt
trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt

[webkit-changes] [146948] trunk/Source/WTF

[jamesr]

Title: [146948] trunk/Source/WTF








Revision 146948
Author jam...@google.com
Date 2013-03-26 17:09:16 -0700 (Tue, 26 Mar 2013)


Log Message
Fix compile for OS(WIN) != PLATFORM(WIN)
https://bugs.webkit.org/show_bug.cgi?id=113356

Reviewed by Tim Horton.

* wtf/ProcessID.h:
(WTF::getCurrentProcessID):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ProcessID.h




Diff

Modified: trunk/Source/WTF/ChangeLog (146947 => 146948)

--- trunk/Source/WTF/ChangeLog	2013-03-27 00:03:41 UTC (rev 146947)
+++ trunk/Source/WTF/ChangeLog	2013-03-27 00:09:16 UTC (rev 146948)
@@ -1,3 +1,13 @@
+2013-03-26  James Robinson  jam...@chromium.org
+
+Fix compile for OS(WIN) != PLATFORM(WIN)
+https://bugs.webkit.org/show_bug.cgi?id=113356
+
+Reviewed by Tim Horton.
+
+* wtf/ProcessID.h:
+(WTF::getCurrentProcessID):
+
 2013-03-23  Filip Pizlo  fpi...@apple.com
 
 JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere


Modified: trunk/Source/WTF/wtf/ProcessID.h (146947 => 146948)

--- trunk/Source/WTF/wtf/ProcessID.h	2013-03-27 00:03:41 UTC (rev 146947)
+++ trunk/Source/WTF/wtf/ProcessID.h	2013-03-27 00:09:16 UTC (rev 146948)
@@ -32,7 +32,7 @@
 #include unistd.h
 #endif
 
-#if PLATFORM(WIN)
+#if OS(WIN)
 #include windows.h
 #endif
 
@@ -40,7 +40,7 @@
 
 inline int getCurrentProcessID()
 {
-#if PLATFORM(WIN)
+#if OS(WIN)
 return GetCurrentProcessId();
 #else
 return getpid();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [146951] trunk/Source/WTF

[jamesr]

Title: [146951] trunk/Source/WTF








Revision 146951
Author jam...@google.com
Date 2013-03-26 17:15:19 -0700 (Tue, 26 Mar 2013)


Log Message
Compile fix - OS(WINDOWS), not OS(WIN).

* wtf/ProcessID.h:
(WTF::getCurrentProcessID):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ProcessID.h




Diff

Modified: trunk/Source/WTF/ChangeLog (146950 => 146951)

--- trunk/Source/WTF/ChangeLog	2013-03-27 00:12:31 UTC (rev 146950)
+++ trunk/Source/WTF/ChangeLog	2013-03-27 00:15:19 UTC (rev 146951)
@@ -1,5 +1,12 @@
 2013-03-26  James Robinson  jam...@chromium.org
 
+Compile fix - OS(WINDOWS), not OS(WIN).
+
+* wtf/ProcessID.h:
+(WTF::getCurrentProcessID):
+
+2013-03-26  James Robinson  jam...@chromium.org
+
 Fix compile for OS(WIN) != PLATFORM(WIN)
 https://bugs.webkit.org/show_bug.cgi?id=113356
 


Modified: trunk/Source/WTF/wtf/ProcessID.h (146950 => 146951)

--- trunk/Source/WTF/wtf/ProcessID.h	2013-03-27 00:12:31 UTC (rev 146950)
+++ trunk/Source/WTF/wtf/ProcessID.h	2013-03-27 00:15:19 UTC (rev 146951)
@@ -32,7 +32,7 @@
 #include unistd.h
 #endif
 
-#if OS(WIN)
+#if OS(WINDOWS)
 #include windows.h
 #endif
 
@@ -40,7 +40,7 @@
 
 inline int getCurrentProcessID()
 {
-#if OS(WIN)
+#if OS(WINDOWS)
 return GetCurrentProcessId();
 #else
 return getpid();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [146836] trunk/LayoutTests

[jamesr]

Title: [146836] trunk/LayoutTests








Revision 146836
Author jam...@google.com
Date 2013-03-25 18:36:06 -0700 (Mon, 25 Mar 2013)


Log Message
Revert bad change to expectation from r146826

* compositing/geometry/object-clip-rects-assertion-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/geometry/object-clip-rects-assertion-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (146835 => 146836)

--- trunk/LayoutTests/ChangeLog	2013-03-26 01:33:10 UTC (rev 146835)
+++ trunk/LayoutTests/ChangeLog	2013-03-26 01:36:06 UTC (rev 146836)
@@ -1,3 +1,9 @@
+2013-03-25  James Robinson  jam...@chromium.org
+
+Revert bad change to expectation from r146826
+
+* compositing/geometry/object-clip-rects-assertion-expected.txt:
+
 2013-03-25  Tony Chang  t...@chromium.org
 
 Image alt text not included in plain-text version when copying


Modified: trunk/LayoutTests/compositing/geometry/object-clip-rects-assertion-expected.txt (146835 => 146836)

--- trunk/LayoutTests/compositing/geometry/object-clip-rects-assertion-expected.txt	2013-03-26 01:33:10 UTC (rev 146835)
+++ trunk/LayoutTests/compositing/geometry/object-clip-rects-assertion-expected.txt	2013-03-26 01:36:06 UTC (rev 146836)
@@ -1,7 +1,3 @@
-argv[0] src ../resources/video.mp4
-argv[1] autoplay false
-argv[2] height 100
-argv[3] width 100
 This testcase should not fire an assertion related to clip rects.
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [146839] trunk/LayoutTests

[jamesr]

Title: [146839] trunk/LayoutTests








Revision 146839
Author jam...@google.com
Date 2013-03-25 19:14:09 -0700 (Mon, 25 Mar 2013)


Log Message
Update chromium baselines for windows related to r146826

* platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
* platform/chromium-linux/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
* platform/chromium-linux/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
* platform/chromium-mac-lion/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
* platform/chromium-mac/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
* platform/chromium-mac/compositing/geometry/preserve-3d-switching-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
* platform/chromium-win-xp/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
* platform/chromium-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
* platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
* platform/chromium/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/geometry/object-clip-rects-assertion-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png


Added Paths

trunk/LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-fixed-expected.txt
trunk/LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/
trunk/LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed-expected.txt
trunk/LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt
trunk/LayoutTests/platform/chromium-mac/compositing/geometry/preserve-3d-switching-expected.txt
trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt
trunk/LayoutTests/platform/chromium-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt

[webkit-changes] [146736] trunk/Source

[jamesr]

Title: [146736] trunk/Source








Revision 146736
Author jam...@google.com
Date 2013-03-24 16:37:24 -0700 (Sun, 24 Mar 2013)


Log Message
[chromium] Wire windows scrollByPage enum up to compositor thread input handling
https://bugs.webkit.org/show_bug.cgi?id=113117

Reviewed by Adrienne Walker.

Source/Platform:

* chromium/public/WebInputHandlerClient.h:

Source/WebKit/chromium:

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
* tests/WebCompositorInputHandlerImplTest.cpp:
(MockWebInputHandlerClient):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebInputHandlerClient.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp
trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (146735 => 146736)

--- trunk/Source/Platform/ChangeLog	2013-03-24 23:15:56 UTC (rev 146735)
+++ trunk/Source/Platform/ChangeLog	2013-03-24 23:37:24 UTC (rev 146736)
@@ -1,3 +1,12 @@
+2013-03-22  James Robinson  jam...@chromium.org
+
+[chromium] Wire windows scrollByPage enum up to compositor thread input handling
+https://bugs.webkit.org/show_bug.cgi?id=113117
+
+Reviewed by Adrienne Walker.
+
+* chromium/public/WebInputHandlerClient.h:
+
 2013-03-23  Dominic Mazzoni  dmazz...@google.com
 
 Implement Web Speech Synthesis for Chromium


Modified: trunk/Source/Platform/chromium/public/WebInputHandlerClient.h (146735 => 146736)

--- trunk/Source/Platform/chromium/public/WebInputHandlerClient.h	2013-03-24 23:15:56 UTC (rev 146735)
+++ trunk/Source/Platform/chromium/public/WebInputHandlerClient.h	2013-03-24 23:37:24 UTC (rev 146736)
@@ -27,6 +27,7 @@
 #include WebCommon.h
 #include WebFloatSize.h
 #include WebPoint.h
+#include WebScrollbar.h
 #include WebSize.h
 
 namespace WebKit {
@@ -56,10 +57,11 @@
 // ancestor layer that can be scrolled will be moved instead. If there is no
 // such layer to be moved, this returns false. Returns true otherwise.
 // Should only be called if scrollBegin() returned ScrollStarted.
-virtual bool scrollByIfPossible(WebPoint origin, WebFloatSize delta) { return scrollByIfPossible(origin, WebSize(delta.width, delta.height)); }
+virtual bool scrollByIfPossible(WebPoint origin, WebFloatSize delta)  = 0;
 
-// TODO(aelias): Delete this after WebKit roll.
-virtual bool scrollByIfPossible(WebPoint origin, WebSize delta) { return scrollByIfPossible(origin, WebFloatSize(delta.width, delta.height)); }
+// Scroll the selected layer vertically by one logical page in the given
+// direction.
+virtual bool scrollVerticallyByPageIfPossible(WebPoint origin, WebScrollbar::ScrollDirection) = 0;
 
 // Stop scrolling the selected layer. Should only be called if scrollBegin()
 // returned ScrollStarted.


Modified: trunk/Source/WebKit/chromium/ChangeLog (146735 => 146736)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-24 23:15:56 UTC (rev 146735)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-24 23:37:24 UTC (rev 146736)
@@ -1,3 +1,15 @@
+2013-03-22  James Robinson  jam...@chromium.org
+
+[chromium] Wire windows scrollByPage enum up to compositor thread input handling
+https://bugs.webkit.org/show_bug.cgi?id=113117
+
+Reviewed by Adrienne Walker.
+
+* src/WebCompositorInputHandlerImpl.cpp:
+(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
+* tests/WebCompositorInputHandlerImplTest.cpp:
+(MockWebInputHandlerClient):
+
 2013-03-24  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed.  Rolled Chromium DEPS to r190276.  Requested by


Modified: trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp (146735 => 146736)

--- trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2013-03-24 23:15:56 UTC (rev 146735)
+++ trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2013-03-24 23:37:24 UTC (rev 146736)
@@ -123,7 +123,13 @@
 switch (scrollStatus) {
 case WebInputHandlerClient::ScrollStatusStarted: {
 TRACE_EVENT_INSTANT2(webkit, WebCompositorInputHandlerImpl::handleInput wheel scroll, deltaX, -wheelEvent.deltaX, deltaY, -wheelEvent.deltaY);
-bool didScroll = m_inputHandlerClient-scrollByIfPossible(WebPoint(wheelEvent.x, wheelEvent.y), WebFloatSize(-wheelEvent.deltaX, -wheelEvent.deltaY));
+bool didScroll = false;
+if (wheelEvent.scrollByPage) {
+ASSERT(!wheelEvent.deltaX);
+WebScrollbar::ScrollDirection direction = (wheelEvent.deltaY  0) ? WebScrollbar::ScrollForward : WebScrollbar::ScrollBackward;
+didScroll = m_inputHandlerClient-scrollVerticallyByPageIfPossible(WebPoint(wheelEvent.x, wheelEvent.y), direction);
+} else
+didScroll = 

[webkit-changes] [146163] trunk/Source

[jamesr]

Title: [146163] trunk/Source








Revision 146163
Author jam...@google.com
Date 2013-03-18 17:37:23 -0700 (Mon, 18 Mar 2013)


Log Message
[chromium] Remove unused type WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=112634

Reviewed by Adam Barth.

Source/Platform:

* Platform.gypi:
* chromium/public/WebTransformationMatrix.h: Removed.

Source/WebCore:

* WebCore.gypi:
* platform/chromium/support/WebTransformationMatrix.cpp: Removed.

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi


Removed Paths

trunk/Source/Platform/chromium/public/WebTransformationMatrix.h
trunk/Source/WebCore/platform/chromium/support/WebTransformationMatrix.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (146162 => 146163)

--- trunk/Source/Platform/ChangeLog	2013-03-19 00:34:35 UTC (rev 146162)
+++ trunk/Source/Platform/ChangeLog	2013-03-19 00:37:23 UTC (rev 146163)
@@ -1,3 +1,13 @@
+2013-03-18  James Robinson  jam...@chromium.org
+
+[chromium] Remove unused type WebTransformationMatrix
+https://bugs.webkit.org/show_bug.cgi?id=112634
+
+Reviewed by Adam Barth.
+
+* Platform.gypi:
+* chromium/public/WebTransformationMatrix.h: Removed.
+
 2013-03-18  W. James MacLean  wjmacl...@chromium.org
 
 [chromium] Remove code that relies on boundsContainsPageScale().


Modified: trunk/Source/Platform/Platform.gypi (146162 => 146163)

--- trunk/Source/Platform/Platform.gypi	2013-03-19 00:34:35 UTC (rev 146162)
+++ trunk/Source/Platform/Platform.gypi	2013-03-19 00:37:23 UTC (rev 146163)
@@ -134,7 +134,6 @@
 'chromium/public/WebString.h',
 'chromium/public/WebThread.h',
 'chromium/public/WebThreadSafeData.h',
-'chromium/public/WebTransformationMatrix.h',
 'chromium/public/WebTransformAnimationCurve.h',
 'chromium/public/WebTransformKeyframe.h',
 'chromium/public/WebTransformOperations.h',


Deleted: trunk/Source/Platform/chromium/public/WebTransformationMatrix.h (146162 => 146163)

--- trunk/Source/Platform/chromium/public/WebTransformationMatrix.h	2013-03-19 00:34:35 UTC (rev 146162)
+++ trunk/Source/Platform/chromium/public/WebTransformationMatrix.h	2013-03-19 00:37:23 UTC (rev 146163)
@@ -1,115 +0,0 @@
-/*
- * Copyright (C) 2012 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef WebTransformationMatrix_h
-#define WebTransformationMatrix_h
-
-#if WEBKIT_IMPLEMENTATION
-#include TransformationMatrix.h
-#endif
-
-#include WebCommon.h
-#include WebPrivateOwnPtr.h
-
-namespace WebCore {
-class TransformationMatrix;
-}
-
-namespace WebKit {
-
-class WebTransformationMatrix {
-public:
-WEBKIT_EXPORT WebTransformationMatrix();
-WEBKIT_EXPORT WebTransformationMatrix(const WebTransformationMatrix);
-~WebTransformationMatrix() { reset(); }
-
-WEBKIT_EXPORT void reset();
-
-// Accessors
-WEBKIT_EXPORT double m11() const;
-WEBKIT_EXPORT void setM11(double);
-WEBKIT_EXPORT double m12() const;
-WEBKIT_EXPORT void setM12(double);
-WEBKIT_EXPORT double m13() const;
-WEBKIT_EXPORT void setM13(double);
-WEBKIT_EXPORT double m14() const;
-WEBKIT_EXPORT void setM14(double);
-WEBKIT_EXPORT double m21() const;
-WEBKIT_EXPORT void setM21(double);
-WEBKIT_EXPORT double m22() const;
-WEBKIT_EXPORT void setM22(double);
-WEBKIT_EXPORT double m23() 

[webkit-changes] [145857] trunk/LayoutTests

[jamesr]

Title: [145857] trunk/LayoutTests








Revision 145857
Author jam...@google.com
Date 2013-03-14 17:02:29 -0700 (Thu, 14 Mar 2013)


Log Message
Fix flaky layout tests that rely on setTimeout()s firing after body is parsed
https://bugs.webkit.org/show_bug.cgi?id=112306

Reviewed by Eric Seidel.

These tests all rely in one way or another on the body of a setTimeout set in an inline script in the head
firing after the body element is generated by the HTML parser. This is a flaky pattern since the HTML parser
may yield when parsing a /script or when runnnig out of bytes from the network. In practice, this pattern used
to be not terribly flaky for layout tests loaded from disk unless there was a large GC pause. However, since the
threaded HTML parser yields more frequently when hitting a /script this flakes more.

These tests were found by identifying layout tests that call setTimeout before the document's body exists by
modifying the code, then intersecting that set with tests that are flaky on the chromium flakiness dashboard.

* editing/inserting/insert-text-into-empty-frameset-crash.html:
* editing/style/apply-style-crash.html:
* fast/block/float/float-originating-line-deleted-crash.html:
* fast/block/float/floats-not-cleared-crash.html:
* fast/block/line-layout/inline-box-wrapper-crash.html:
* fast/css/positioned-in-relative-position-inline-crash.html:
* fast/css/user-stylesheet-crash.html:
* fast/encoding/script-in-head.html:
* fast/forms/textarea-placeholder-relayout-assertion.html:
* fast/frames/seamless/seamless-form-get.html:
* fast/frames/seamless/seamless-form-post-named.html:
* fast/frames/seamless/seamless-window-location-href.html:
* fast/frames/seamless/seamless-window-location-replace.html:
* fast/inline/update-always-create-line-boxes-full-layout-crash.html:
* fast/innerHTML/innerHTML-iframe.html:
* fast/js/same-origin-subframe-about-blank.html:
* fast/multicol/span/removal-of-multicol-span-crash.html:
* fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html:
* fast/writing-mode/overhanging-float-legend-crash.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/inserting/insert-text-into-empty-frameset-crash.html
trunk/LayoutTests/editing/style/apply-style-crash.html
trunk/LayoutTests/fast/block/float/float-originating-line-deleted-crash.html
trunk/LayoutTests/fast/block/float/floats-not-cleared-crash.html
trunk/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash.html
trunk/LayoutTests/fast/css/positioned-in-relative-position-inline-crash.html
trunk/LayoutTests/fast/css/user-stylesheet-crash.html
trunk/LayoutTests/fast/encoding/script-in-head.html
trunk/LayoutTests/fast/forms/textarea-placeholder-relayout-assertion.html
trunk/LayoutTests/fast/frames/seamless/seamless-form-get.html
trunk/LayoutTests/fast/frames/seamless/seamless-form-post-named.html
trunk/LayoutTests/fast/frames/seamless/seamless-window-location-href.html
trunk/LayoutTests/fast/frames/seamless/seamless-window-location-replace.html
trunk/LayoutTests/fast/inline/update-always-create-line-boxes-full-layout-crash.html
trunk/LayoutTests/fast/innerHTML/innerHTML-iframe.html
trunk/LayoutTests/fast/js/same-origin-subframe-about-blank.html
trunk/LayoutTests/fast/multicol/span/removal-of-multicol-span-crash.html
trunk/LayoutTests/fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html
trunk/LayoutTests/fast/writing-mode/overhanging-float-legend-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (145856 => 145857)

--- trunk/LayoutTests/ChangeLog	2013-03-14 23:33:21 UTC (rev 145856)
+++ trunk/LayoutTests/ChangeLog	2013-03-15 00:02:29 UTC (rev 145857)
@@ -1,3 +1,39 @@
+2013-03-13  James Robinson  jam...@chromium.org
+
+Fix flaky layout tests that rely on setTimeout()s firing after body is parsed
+https://bugs.webkit.org/show_bug.cgi?id=112306
+
+Reviewed by Eric Seidel.
+
+These tests all rely in one way or another on the body of a setTimeout set in an inline script in the head
+firing after the body element is generated by the HTML parser. This is a flaky pattern since the HTML parser
+may yield when parsing a /script or when runnnig out of bytes from the network. In practice, this pattern used
+to be not terribly flaky for layout tests loaded from disk unless there was a large GC pause. However, since the
+threaded HTML parser yields more frequently when hitting a /script this flakes more.
+
+These tests were found by identifying layout tests that call setTimeout before the document's body exists by
+modifying the code, then intersecting that set with tests that are flaky on the chromium flakiness dashboard.
+
+* editing/inserting/insert-text-into-empty-frameset-crash.html:
+* editing/style/apply-style-crash.html:
+* fast/block/float/float-originating-line-deleted-crash.html:
+* fast/block/float/floats-not-cleared-crash.html:
+* 

[webkit-changes] [145737] trunk/LayoutTests

[jamesr]

Title: [145737] trunk/LayoutTests








Revision 145737
Author jam...@google.com
Date 2013-03-13 12:32:18 -0700 (Wed, 13 Mar 2013)


Log Message
Clean out some stale chromium TestExpectations entries.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (145736 => 145737)

--- trunk/LayoutTests/ChangeLog	2013-03-13 19:28:59 UTC (rev 145736)
+++ trunk/LayoutTests/ChangeLog	2013-03-13 19:32:18 UTC (rev 145737)
@@ -1,3 +1,9 @@
+2013-03-13  James Robinson  jam...@chromium.org
+
+Clean out some stale chromium TestExpectations entries.
+
+* platform/chromium/TestExpectations:
+
 2013-03-13  Tony Chang  t...@chromium.org
 
 Regression(r143542): -webkit-align-items: center with overflow: auto/scroll has extra bottom padding


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (145736 => 145737)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-13 19:28:59 UTC (rev 145736)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-13 19:32:18 UTC (rev 145737)
@@ -1299,9 +1299,9 @@
 # These require more investigation. There is a small change, probably two pixels, in the filter offset
 # when comparing the former and new results. This may be due to bad test design or may be revealing a bug
 # in the code. Turbulence results are very different.
-webkit.org/b/80517 [ Android Lion SnowLeopard ] svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html [ ImageOnlyFailure ]
+webkit.org/b/80517 [ Android ] svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html [ ImageOnlyFailure ]
 webkit.org/b/80517 [ Android XP ] svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html [ ImageOnlyFailure ]
-webkit.org/b/80517 [ Android Lion SnowLeopard ] svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html [ ImageOnlyFailure ]
+webkit.org/b/80517 [ Android ] svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html [ ImageOnlyFailure ]
 webkit.org/b/80517 [ Android XP ] svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html [ ImageOnlyFailure ]
 webkit.org/b/80517 [ Android ] svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html [ ImageOnlyFailure ]
 webkit.org/b/80517 [ Android ] svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html [ ImageOnlyFailure ]
@@ -2871,13 +2871,6 @@
 crbug.com/88894 http/tests/cache/subresource-expiration-1.html [ Pass Slow ]
 crbug.com/88894 http/tests/cache/subresource-expiration-2.html [ Pass Slow ]
 
-# The following are missing baselines.
-webkit.org/b/107935 platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents.html [ Missing ]
-webkit.org/b/107935 platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html [ Missing ]
-webkit.org/b/107935 compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html [ Missing ]
-webkit.org/b/107935 platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html [ Missing ]
-webkit.org/b/107935 platform/chromium/virtual/softwarecompositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html [ Missing ]
-webkit.org/b/107935 compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html [ Missing ]
 webkit.org/b/107935 platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container.html [ Failure ]
 webkit.org/b/107935 compositing/overflow/composited-scrolling-creates-a-stacking-container.html [ Failure ]
 webkit.org/b/107935 platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container.html [ Failure ]
@@ -3094,11 +3087,9 @@
 webkit.org/b/48454 compositing/tiling/huge-layer-img.html [ Skip ]
 webkit.org/b/48454 platform/chromium/virtual/softwarecompositing/tiling/huge-layer-img.html [ Skip ]
 
-# Need image baselines for Chromium
-webkit.org/b/100808 compositing/tiling/rotated-tiled-clamped.html [ ImageOnlyFailure ]
-webkit.org/b/100808 platform/chromium/virtual/softwarecompositing/tiling/rotated-tiled-clamped.html [ ImageOnlyFailure ]
-webkit.org/b/100808 compositing/tiling/rotated-tiled-preserve3d-clamped.html [ ImageOnlyFailure ]
-webkit.org/b/100808 platform/chromium/virtual/softwarecompositing/tiling/rotated-tiled-preserve3d-clamped.html [ ImageOnlyFailure ]
+# Show seaming artifacts in software compositing
+crbug.com/181300 platform/chromium/virtual/softwarecompositing/tiling/rotated-tiled-clamped.html [ ImageOnlyFailure ]
+crbug.com/181300 platform/chromium/virtual/softwarecompositing/tiling/rotated-tiled-preserve3d-clamped.html [ ImageOnlyFailure ]
 
 webkit.org/b/75932 fast/js/array-defineOwnProperty.html [ Failure ]
 

[webkit-changes] [145749] trunk/LayoutTests

[jamesr]

Title: [145749] trunk/LayoutTests








Revision 145749
Author jam...@google.com
Date 2013-03-13 13:55:22 -0700 (Wed, 13 Mar 2013)


Log Message
Force clip in fast/regions/autoheight-break-after-expected.html to match test
https://bugs.webkit.org/show_bug.cgi?id=112283

Reviewed by David Hyatt.

Regions always set a clip rect when rendering their contents. On Mountain Lion, the Ahem glyphs very slightly
visually overflow their bounds if there's no clip set. This sets a clip in the reference file so we get the same
rendering.

* fast/regions/autoheight-break-after-expected.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/regions/autoheight-break-after-expected.html




Diff

Modified: trunk/LayoutTests/ChangeLog (145748 => 145749)

--- trunk/LayoutTests/ChangeLog	2013-03-13 20:44:08 UTC (rev 145748)
+++ trunk/LayoutTests/ChangeLog	2013-03-13 20:55:22 UTC (rev 145749)
@@ -1,3 +1,16 @@
+2013-03-13  James Robinson  jam...@chromium.org
+
+Force clip in fast/regions/autoheight-break-after-expected.html to match test
+https://bugs.webkit.org/show_bug.cgi?id=112283
+
+Reviewed by David Hyatt.
+
+Regions always set a clip rect when rendering their contents. On Mountain Lion, the Ahem glyphs very slightly
+visually overflow their bounds if there's no clip set. This sets a clip in the reference file so we get the same
+rendering.
+
+* fast/regions/autoheight-break-after-expected.html:
+
 2013-03-13  Tim Horton  timothy_hor...@apple.com
 
 Make lint-test-expectations happy with the Apple-Windows TestExpectations files


Modified: trunk/LayoutTests/fast/regions/autoheight-break-after-expected.html (145748 => 145749)

--- trunk/LayoutTests/fast/regions/autoheight-break-after-expected.html	2013-03-13 20:44:08 UTC (rev 145748)
+++ trunk/LayoutTests/fast/regions/autoheight-break-after-expected.html	2013-03-13 20:55:22 UTC (rev 145749)
@@ -6,6 +6,7 @@
 width: 200px;
 margin: 10px;
 float: left;
+overflow: hidden;
 }
 .regionAuto {
 border: thick solid red;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [145603] trunk/Source

[jamesr]

Title: [145603] trunk/Source








Revision 145603
Author jam...@google.com
Date 2013-03-12 15:49:56 -0700 (Tue, 12 Mar 2013)


Log Message
Build fix for r145592 - update gyp files to refer to new file locations.

Source/WebCore:

* WebCore.gypi:

Source/WTF:

* WTF.gypi:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.gypi
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi




Diff

Modified: trunk/Source/WTF/ChangeLog (145602 => 145603)

--- trunk/Source/WTF/ChangeLog	2013-03-12 22:49:44 UTC (rev 145602)
+++ trunk/Source/WTF/ChangeLog	2013-03-12 22:49:56 UTC (rev 145603)
@@ -1,3 +1,9 @@
+2013-03-12  James Robinson  jam...@chromium.org
+
+Build fix for r145592 - update gyp files to refer to new file locations.
+
+* WTF.gypi:
+
 2013-03-12  Geoffrey Garen  gga...@apple.com
 
 Moved RunLoopTimer and SchedulePair to WTF


Modified: trunk/Source/WTF/WTF.gypi (145602 => 145603)

--- trunk/Source/WTF/WTF.gypi	2013-03-12 22:49:44 UTC (rev 145602)
+++ trunk/Source/WTF/WTF.gypi	2013-03-12 22:49:56 UTC (rev 145603)
@@ -153,6 +153,8 @@
 'wtf/ArrayBufferView.cpp',
 'wtf/ArrayBufferView.h',
 'wtf/Assertions.cpp',
+'wtf/AutodrainedPool.h',
+'wtf/AutodrainedPoolMac.mm',
 'wtf/BitVector.cpp',
 'wtf/CryptographicallyRandomNumber.cpp',
 'wtf/CurrentTime.cpp',
@@ -174,15 +176,13 @@
 'wtf/MD5.cpp',
 'wtf/MainThread.cpp',
 'wtf/MallocZoneSupport.h',
+'wtf/MediaTime.cpp',
 'wtf/MediaTime.h',
-'wtf/MediaTime.cpp',
 'wtf/MetaAllocator.cpp',
 'wtf/MetaAllocator.h',
 'wtf/NullPtr.cpp',
 'wtf/NumberOfCores.cpp',
 'wtf/NumberOfCores.h',
-'wtf/RAMSize.cpp',
-'wtf/RAMSize.h',
 'wtf/OSAllocatorPosix.cpp',
 'wtf/OSAllocatorWin.cpp',
 'wtf/OSRandomSource.cpp',
@@ -195,11 +195,16 @@
 'wtf/ParallelJobsLibdispatch.h',
 'wtf/ParallelJobsOpenMP.h',
 'wtf/PrintStream.cpp',
+'wtf/RAMSize.cpp',
+'wtf/RAMSize.h',
 'wtf/RandomNumber.cpp',
 'wtf/RandomNumberSeed.h',
 'wtf/RefCountedLeakCounter.cpp',
+'wtf/RunLoopTimer.h',
+'wtf/RunLoopTimerCF.cpp',
 'wtf/SHA1.cpp',
 'wtf/SHA1.h',
+'wtf/SchedulePairMac.mm',
 'wtf/SegmentedVector.h',
 'wtf/SizeLimits.cpp',
 'wtf/StackBounds.cpp',


Modified: trunk/Source/WebCore/ChangeLog (145602 => 145603)

--- trunk/Source/WebCore/ChangeLog	2013-03-12 22:49:44 UTC (rev 145602)
+++ trunk/Source/WebCore/ChangeLog	2013-03-12 22:49:56 UTC (rev 145603)
@@ -1,3 +1,9 @@
+2013-03-12  James Robinson  jam...@chromium.org
+
+Build fix for r145592 - update gyp files to refer to new file locations.
+
+* WebCore.gypi:
+
 2013-03-12  Benjamin Poulain  bpoul...@apple.com
 
 Add a single character cache to WidthCache


Modified: trunk/Source/WebCore/WebCore.gypi (145602 => 145603)

--- trunk/Source/WebCore/WebCore.gypi	2013-03-12 22:49:44 UTC (rev 145602)
+++ trunk/Source/WebCore/WebCore.gypi	2013-03-12 22:49:56 UTC (rev 145603)
@@ -3632,7 +3632,6 @@
 'platform/AsyncFileSystem.cpp',
 'platform/AsyncFileSystem.h',
 'platform/AsyncFileSystemCallbacks.h',
-'platform/AutodrainedPool.h',
 'platform/CalculationValue.cpp',
 'platform/CalculationValue.h',
 'platform/Clock.cpp',
@@ -3688,7 +3687,6 @@
 'platform/PrerenderClient.h',
 'platform/PurgeableBuffer.h',
 'platform/ReferrerPolicy.h',
-'platform/RunLoopTimer.h',
 'platform/RuntimeApplicationChecks.cpp',
 'platform/RuntimeApplicationChecks.h',
 'platform/SSLKeyGenerator.h',
@@ -3809,8 +3807,6 @@
 'platform/cf/BinaryPropertyList.cpp',
 'platform/cf/FileSystemCF.cpp',
 'platform/cf/KURLCFNet.cpp',
-'platform/cf/RunLoopTimerCF.cpp',
-'platform/cf/SchedulePair.cpp',
 'platform/cf/SharedBufferCF.cpp',
 'platform/chromium/ChromiumDataObject.cpp',
 'platform/chromium/ChromiumDataObject.h',
@@ -4462,7 +4458,6 @@
 'platform/leveldb/LevelDBTransaction.h',
 'platform/leveldb/LevelDBWriteBatch.cpp',
 'platform/leveldb/LevelDBWriteBatch.h',
-'platform/mac/AutodrainedPool.mm',
 'platform/mac/BlockExceptions.mm',
 'platform/mac/ClipboardMac.mm',
 'platform/mac/ContextMenuItemMac.mm',
@@ -4491,7 +4486,6 @@
 'platform/mac/PopupMenuMac.mm',
 'platform/mac/PurgeableBufferMac.cpp',
 'platform/mac/SSLKeyGeneratorMac.cpp',
-'platform/mac/SchedulePairMac.mm',
  

[webkit-changes] [145667] trunk/LayoutTests

[jamesr]

Title: [145667] trunk/LayoutTests








Revision 145667
Author jam...@google.com
Date 2013-03-12 18:46:27 -0700 (Tue, 12 Mar 2013)


Log Message
Update a few chromium test expectations.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (145666 => 145667)

--- trunk/LayoutTests/ChangeLog	2013-03-13 01:45:39 UTC (rev 145666)
+++ trunk/LayoutTests/ChangeLog	2013-03-13 01:46:27 UTC (rev 145667)
@@ -1,5 +1,11 @@
 2013-03-12  James Robinson  jam...@chromium.org
 
+Update a few chromium test expectations.
+
+* platform/chromium/TestExpectations:
+
+2013-03-12  James Robinson  jam...@chromium.org
+
 Fix Gamepad::axes and Gamepad::buttons to avoid calling std::copy(..., ..., 0)
 https://bugs.webkit.org/show_bug.cgi?id=89510
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (145666 => 145667)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-13 01:45:39 UTC (rev 145666)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-13 01:46:27 UTC (rev 145667)
@@ -4426,7 +4426,6 @@
 # The html5lib tests are all too slow to run in Debug, largely due to v8 per-document boot-up.
 # V8 bug: https://code.google.com/p/v8/issues/detail?id=2567
 webkit.org/b/110876 [ Debug ] html5lib/generated/ [ Skip ]
-webkit.org/b/ [ Linux Win ] html5lib/generated/run-tests16-data.html [ Slow ]
 
 # HALF_FLOAT_OES is not yet working in chromium.
 crbug.com/179503 fast/canvas/webgl/oes-texture-half-float.html [ Failure ]
@@ -4467,3 +4466,7 @@
 webkit.org/b/112058 [ Debug SnowLeopard ] svg/custom/foreign-object-skew.svg [ Failure ]
 
 webkit.org/b/112193 fast/dom/Window/window-postmessage-clone.html [ Failure Pass ]
+
+webkit.org/b/112219 fast/layers/no-clipping-overflow-hidden-added-after-transform.html [ ImageOnlyFailure Pass ]
+webkit.org/b/112219 fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html [ ImageOnlyFailure Pass ]
+webkit.org/b/112219 fast/layers/no-clipping-overflow-hidden-added-after-transition.html [ ImageOnlyFailure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [145394] trunk/LayoutTests

[jamesr]

Title: [145394] trunk/LayoutTests








Revision 145394
Author jam...@google.com
Date 2013-03-11 13:17:33 -0700 (Mon, 11 Mar 2013)


Log Message
Update chromium expectations.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (145393 => 145394)

--- trunk/LayoutTests/ChangeLog	2013-03-11 20:03:10 UTC (rev 145393)
+++ trunk/LayoutTests/ChangeLog	2013-03-11 20:17:33 UTC (rev 145394)
@@ -1,3 +1,9 @@
+2013-03-11  James Robinson  jam...@chromium.org
+
+Update chromium expectations.
+
+* platform/chromium/TestExpectations:
+
 2013-03-11  Adam Klein  ad...@chromium.org
 
 MutationCallback should be a WebIDL 'callback', not a [Callback] interface


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (145393 => 145394)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-11 20:03:10 UTC (rev 145393)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-11 20:17:33 UTC (rev 145394)
@@ -4468,3 +4468,6 @@
 
 # Test is a performance test, not useful in debug
 webkit.org/b/111808 [ Debug ] fast/js/regress/nested-function-parsing-random.html [ Pass Timeout ]
+
+# Subtle pixel difference in debug only.
+webkit.org/b/112058 [ Debug SnowLeopard ] svg/custom/foreign-object-skew.svg [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [145405] trunk/Source/WebCore

[jamesr]

Title: [145405] trunk/Source/WebCore








Revision 145405
Author jam...@google.com
Date 2013-03-11 14:26:30 -0700 (Mon, 11 Mar 2013)


Log Message
Compile fix. Rubber-stamp by Eric Seidel.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/MediaControlElements.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (145404 => 145405)

--- trunk/Source/WebCore/ChangeLog	2013-03-11 21:20:36 UTC (rev 145404)
+++ trunk/Source/WebCore/ChangeLog	2013-03-11 21:26:30 UTC (rev 145405)
@@ -1,3 +1,10 @@
+2013-03-11  James Robinson  jam...@chromium.org
+
+Compile fix. Rubber-stamp by Eric Seidel.
+
+* html/shadow/MediaControlElements.cpp:
+(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
+
 2013-03-11  Dima Gorbik  dgor...@apple.com
 
 Fix build for r145397 (part 2)


Modified: trunk/Source/WebCore/html/shadow/MediaControlElements.cpp (145404 => 145405)

--- trunk/Source/WebCore/html/shadow/MediaControlElements.cpp	2013-03-11 21:20:36 UTC (rev 145404)
+++ trunk/Source/WebCore/html/shadow/MediaControlElements.cpp	2013-03-11 21:26:30 UTC (rev 145405)
@@ -1270,7 +1270,7 @@
 RefPtrTextTrackCueBox displayBox = cue-getDisplayTree(m_videoDisplaySize.size());
 if (displayBox-hasChildNodes()  !contains(static_castNode*(displayBox.get(
 // Note: the display tree of a cue is removed when the active flag of the cue is unset.
-appendChild(displayBox, ASSERT_NO_EXCEPTION, false);
+appendChild(displayBox, ASSERT_NO_EXCEPTION, AttachNow);
 }
 
 // 11. Return output.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [145413] trunk/Source/WebCore

[jamesr]

Title: [145413] trunk/Source/WebCore








Revision 145413
Author jam...@google.com
Date 2013-03-11 15:18:58 -0700 (Mon, 11 Mar 2013)


Log Message
Fix typo from r145399. Rubber stamped by Abhishek Arya.

* rendering/svg/RenderSVGViewportContainer.h:
(WebCore::toRenderSVGViewportContainer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (145412 => 145413)

--- trunk/Source/WebCore/ChangeLog	2013-03-11 22:15:06 UTC (rev 145412)
+++ trunk/Source/WebCore/ChangeLog	2013-03-11 22:18:58 UTC (rev 145413)
@@ -1,3 +1,10 @@
+2013-03-11  James Robinson  jam...@chromium.org
+
+Fix typo from r145399. Rubber stamped by Abhishek Arya.
+
+* rendering/svg/RenderSVGViewportContainer.h:
+(WebCore::toRenderSVGViewportContainer):
+
 2013-03-11  Hans Muller  hmul...@adobe.com
 
 [CSS Exclusions] Refactor the ExclusionPolygon class to enable storing multiple boundaries


Modified: trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.h (145412 => 145413)

--- trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.h	2013-03-11 22:15:06 UTC (rev 145412)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGViewportContainer.h	2013-03-11 22:18:58 UTC (rev 145413)
@@ -63,13 +63,13 @@
   
 inline RenderSVGViewportContainer* toRenderSVGViewportContainer(RenderObject* object)
 {
-ASSERT_WITH_SECURITY_IMPLICATION(!object || !object-isSVGViewportContainer());
+ASSERT_WITH_SECURITY_IMPLICATION(!object || object-isSVGViewportContainer());
 return static_castRenderSVGViewportContainer*(object);
 }
 
 inline const RenderSVGViewportContainer* toRenderSVGViewportContainer(const RenderObject* object)
 {
-ASSERT_WITH_SECURITY_IMPLICATION(!object || !object-isSVGViewportContainer());
+ASSERT_WITH_SECURITY_IMPLICATION(!object || object-isSVGViewportContainer());
 return static_castconst RenderSVGViewportContainer*(object);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [145418] trunk/LayoutTests

[jamesr]

Title: [145418] trunk/LayoutTests








Revision 145418
Author jam...@google.com
Date 2013-03-11 15:37:41 -0700 (Mon, 11 Mar 2013)


Log Message
Update chromium render tree baselines for track cue changes in r145397.

* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Added.
* platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.txt:
* platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
* platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt
trunk/LayoutTests/platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt
trunk/LayoutTests/platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.txt


Added Paths

trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt
trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (145417 => 145418)

--- trunk/LayoutTests/ChangeLog	2013-03-11 22:36:28 UTC (rev 145417)
+++ trunk/LayoutTests/ChangeLog	2013-03-11 22:37:41 UTC (rev 145418)
@@ -1,3 +1,13 @@
+2013-03-11  James Robinson  jam...@chromium.org
+
+Update chromium render tree baselines for track cue changes in r145397.
+
+* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
+* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Added.
+* platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.txt:
+* platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
+* platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt:
+
 2013-03-11  Benjamin Poulain  benja...@webkit.org
 
 Modernize the test visited-link-background-color.html


Added: trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt (0 => 145418)

--- trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt	2013-03-11 22:37:41 UTC (rev 145418)
@@ -0,0 +1,75 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x341
+  RenderBlock {HTML} at (0,0) size 800x341
+RenderBody {BODY} at (8,8) size 784x325
+  RenderBlock (anonymous) at (0,0) size 784x245
+RenderText {#text} at (0,0) size 0x0
+  RenderBlock {DIV} at (0,245) size 784x80
+RenderText {#text} at (0,0) size 250x19
+  text run at (0,0) width 250: Rendering horizontal line-positioned cues.
+RenderBR {BR} at (250,0) size 0x19
+RenderText {#text} at (0,20) size 151x19
+  text run at (0,20) width 151: EVENT(canplaythrough)
+RenderBR {BR} at (151,20) size 0x19
+RenderText {#text} at (0,40) size 103x19
+  text run at (0,40) width 103: EVENT(seeked)
+RenderBR {BR} at (103,40) size 0x19
+RenderText {#text} at (0,60) size 97x19
+  text run at (0,60) width 97: END OF TEST
+RenderBR {BR} at (97,60) size 0x19
+layer at (8,8) size 320x240
+  RenderVideo {VIDEO} at (0,0) size 320x240
+layer at (8,8) size 320x240
+  RenderFlexibleBox {DIV} at (0,0) size 320x240
+RenderBlock {DIV} at (0,205) size 320x35
+layer at (8,8) size 320x205
+  RenderBlock (relative positioned) {DIV} at (0,0) size 320x205 [color=#FF]
+layer at (8,8) size 320x15 scrollHeight 17
+  RenderBlock (positioned) {DIV} at (0,0) size 320x15
+RenderInline {DIV} at (0,0) size 280x19 [bgcolor=#00CC]
+  RenderText {#text} at (22,0) size 276x15
+text run at (22,0) width 276: Cue 1: should be positioned at the top of the video.
+layer at (8,27) size 320x15 scrollHeight 17
+  RenderBlock (positioned) {DIV} at (0,19) size 320x15
+RenderInline {DIV} at (0,0) size 308x19 [bgcolor=#00CC]
+  RenderText {#text} at (8,0) size 304x15
+text run at (8,0) width 304: Cue 2: should be the second cue and not overlap cue 1.
+layer at (8,46) size 320x15 scrollHeight 17
+  RenderBlock (positioned) {DIV} at (0,38) size 320x15
+RenderInline {DIV} at (0,0) size 304x19 [bgcolor=#00CC]
+  RenderText {#text} at (10,0) size 300x15
+text run at (10,0) width 300: Cue 3: should become the third line from top to bottom.
+layer at (8,103) size 320x15 scrollHeight 17
+  RenderBlock (positioned) {DIV} at (0,95) size 320x15
+RenderInline {DIV} at (0,0) size 294x19 [bgcolor=#00CC]
+  RenderText {#text} at (15,0) size 290x15
+text run at (15,0) width 290: Cue 4: should be 

[webkit-changes] [145429] trunk/LayoutTests

[jamesr]

Title: [145429] trunk/LayoutTests








Revision 145429
Author jam...@google.com
Date 2013-03-11 16:40:36 -0700 (Mon, 11 Mar 2013)


Log Message
De-flake fast/dom/title-directionality.html
https://bugs.webkit.org/show_bug.cgi?id=112075

Reviewed by Adam Barth.

This moves the test logic from an inline script to an onload handler. Otherwise, the whitespace collapsing logic
creates a race between the style recalc timer and the HTML parser which sometimes produces an extra newline at
the end of the text output.

* fast/dom/title-directionality-expected.txt:
* fast/dom/title-directionality.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/title-directionality-expected.txt
trunk/LayoutTests/fast/dom/title-directionality.html




Diff

Modified: trunk/LayoutTests/ChangeLog (145428 => 145429)

--- trunk/LayoutTests/ChangeLog	2013-03-11 23:40:19 UTC (rev 145428)
+++ trunk/LayoutTests/ChangeLog	2013-03-11 23:40:36 UTC (rev 145429)
@@ -1,3 +1,17 @@
+2013-03-11  James Robinson  jam...@chromium.org
+
+De-flake fast/dom/title-directionality.html
+https://bugs.webkit.org/show_bug.cgi?id=112075
+
+Reviewed by Adam Barth.
+
+This moves the test logic from an inline script to an onload handler. Otherwise, the whitespace collapsing logic
+creates a race between the style recalc timer and the HTML parser which sometimes produces an extra newline at
+the end of the text output.
+
+* fast/dom/title-directionality-expected.txt:
+* fast/dom/title-directionality.html:
+
 2013-03-05  Ojan Vafai  o...@chromium.org
 
 Intrinsic width keyword values don't work for tables


Modified: trunk/LayoutTests/fast/dom/title-directionality-expected.txt (145428 => 145429)

--- trunk/LayoutTests/fast/dom/title-directionality-expected.txt	2013-03-11 23:40:19 UTC (rev 145428)
+++ trunk/LayoutTests/fast/dom/title-directionality-expected.txt	2013-03-11 23:40:36 UTC (rev 145429)
@@ -3,4 +3,3 @@
 htmltitle dir=rtlfoo/title/html should have title direction rtl. PASS
 html dir=rtltitlefoo/title/html should have title direction rtl. PASS
 html dir=rtltitle dir=ltrfoo/title/html should have title direction ltr. PASS
-


Modified: trunk/LayoutTests/fast/dom/title-directionality.html (145428 => 145429)

--- trunk/LayoutTests/fast/dom/title-directionality.html	2013-03-11 23:40:19 UTC (rev 145428)
+++ trunk/LayoutTests/fast/dom/title-directionality.html	2013-03-11 23:40:36 UTC (rev 145429)
@@ -3,43 +3,45 @@
 head
 titlepage title/title
 /head
-body
+body _onload_=runTest()
 iframe id=iframe/iframe
 script
-var iframe = document.getElementById('iframe');
+function runTest() {
+var iframe = document.getElementById('iframe');
 
-function assertDirection(label, expectedDirection, html)
-{
-var doc = iframe.contentDocument;
-doc.open();
-doc.write(html);
-doc.close();
+function assertDirection(label, expectedDirection, html)
+{
+var doc = iframe.contentDocument;
+doc.open();
+doc.write(html);
+doc.close();
 
-var dir = window.testRunner ?
-testRunner.titleTextDirection
-  : 'testRunner unavailable';
-var status = html + ' should have title direction ' + expectedDirection + '. ';
-if (dir == expectedDirection) {
-status += 'PASS';
-} else {
-status += 'FAIL (got: ' + dir + ')';
+var dir = window.testRunner ?
+testRunner.titleTextDirection
+  : 'testRunner unavailable';
+var status = html + ' should have title direction ' + expectedDirection + '. ';
+if (dir == expectedDirection) {
+status += 'PASS';
+} else {
+status += 'FAIL (got: ' + dir + ')';
+}
+var div = document.createElement('div');
+div.innerText = status;
+document.body.appendChild(div);
 }
-var div = document.createElement('div');
-div.innerText = status;
-document.body.appendChild(div);
-}
 
-if (window.testRunner)
-testRunner.dumpAsText();
+if (window.testRunner)
+testRunner.dumpAsText();
 
-assertDirection('normal doc', 'ltr',
-'htmltitlefoo/title/html');
-assertDirection('title dir=rtl', 'rtl',
-'htmltitle dir=rtlfoo/title/html');
-assertDirection('html dir=rtl', 'rtl',
-'html dir=rtltitlefoo/title/html');
-assertDirection('html dir=rtl, title dir=ltr', 'ltr',
-'html dir=rtltitle dir=ltrfoo/title/html');
+assertDirection('normal doc', 'ltr',
+'htmltitlefoo/title/html');
+assertDirection('title dir=rtl', 'rtl',
+'htmltitle dir=rtlfoo/title/html');
+assertDirection('html dir=rtl', 'rtl',
+'html dir=rtltitlefoo/title/html');
+assertDirection('html dir=rtl, title dir=ltr', 'ltr',
+'html dir=rtltitle dir=ltrfoo/title/html');
+}
 /script
 /body
 /html






___

[webkit-changes] [145445] trunk/LayoutTests

[jamesr]

Title: [145445] trunk/LayoutTests








Revision 145445
Author jam...@google.com
Date 2013-03-11 17:53:06 -0700 (Mon, 11 Mar 2013)


Log Message
More chromium layer tree rebaselines for r145422

* platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
* platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
* platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
* platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
* platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
* platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt
trunk/LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt


Added Paths

trunk/LayoutTests/platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt
trunk/LayoutTests/platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt
trunk/LayoutTests/platform/chromium-mac-lion/compositing/layer-creation/
trunk/LayoutTests/platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt
trunk/LayoutTests/platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/layer-creation/
trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt
trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/
trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt
trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (145444 => 145445)

--- trunk/LayoutTests/ChangeLog	2013-03-12 00:50:46 UTC (rev 145444)
+++ trunk/LayoutTests/ChangeLog	2013-03-12 00:53:06 UTC (rev 145445)
@@ -1,5 +1,20 @@
 2013-03-11  James Robinson  jam...@chromium.org
 
+More chromium layer tree rebaselines for r145422
+
+* platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
+* platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Copied 

[webkit-changes] [145259] trunk/LayoutTests

[jamesr]

Title: [145259] trunk/LayoutTests








Revision 145259
Author jam...@google.com
Date 2013-03-08 13:04:27 -0800 (Fri, 08 Mar 2013)


Log Message
Chromium gardening.

* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
* platform/chromium-linux/editing/pasteboard/paste-text-016-expected.txt: Added.
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-016-expected.txt: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations


Added Paths

trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/paste-text-016-expected.txt
trunk/LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-016-expected.txt
trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png
trunk/LayoutTests/platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (145258 => 145259)

--- trunk/LayoutTests/ChangeLog	2013-03-08 21:02:00 UTC (rev 145258)
+++ trunk/LayoutTests/ChangeLog	2013-03-08 21:04:27 UTC (rev 145259)
@@ -1,3 +1,15 @@
+2013-03-08  James Robinson  jam...@chromium.org
+
+Chromium gardening.
+
+* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
+* platform/chromium-linux/editing/pasteboard/paste-text-016-expected.txt: Added.
+* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
+* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-016-expected.txt: Added.
+* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
+* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
+* platform/chromium/TestExpectations:
+
 2013-03-08  Ryosuke Niwa  rn...@webkit.org
 
 Mac rebaseline after r145242. I'm really hoping that the optimization didn't mess this up.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (145258 => 145259)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-08 21:02:00 UTC (rev 145258)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-08 21:04:27 UTC (rev 145259)
@@ -3559,8 +3559,6 @@
 
 webkit.org/b/88124 [ Debug ] fast/css/absolute-child-with-percent-height-inside-relative-parent.html [ Failure Pass ]
 
-webkit.org/b/88131 [ Debug ] fast/dom/HTMLMeterElement/meter-element-crash.html [ Failure Pass ]
-
 webkit.org/b/88593 fast/table/multiple-captions-display.xhtml [ Failure ImageOnlyFailure Pass ]
 
 webkit.org/b/88939 fast/events/before-unload-adopt-subframe-to-outside.html [ Failure Pass ]
@@ -4473,3 +4471,5 @@
 webkit.org/b/111774 [ Win ] http/tests/security/cross-origin-css.html [ Pass Failure ]
 
 webkit.org/b/111816 fast/borders/border-fit-2.html [ Failure ]
+
+webkit.org/b/111872 fast/dom/title-directionality-removeChild.html [ Pass Failure ]


Added: trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/paste-text-016-expected.txt (0 => 145259)

--- trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/paste-text-016-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/paste-text-016-expected.txt	2013-03-08 21:04:27 UTC (rev 145259)
@@ -0,0 +1,65 @@
+EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of BODY  HTML  #document to 10 of BODY  HTML  #document
+EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING 

[webkit-changes] [145263] trunk/LayoutTests

[jamesr]

Title: [145263] trunk/LayoutTests








Revision 145263
Author jam...@google.com
Date 2013-03-08 13:20:24 -0800 (Fri, 08 Mar 2013)


Log Message
Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88131

Reviewed by Tony Chang.

This test was calling setTimeout(..., 0) in a script block before the end of the document.
The timeout sometimes fired before parsing the rest of the document and sometimes after,
depending on when the parser yielded. This moves the script block to the end of the document
so it always runs after parsing the rest of the test, which is the more common and expected
behavior.

* fast/dom/HTMLMeterElement/meter-element-crash.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (145262 => 145263)

--- trunk/LayoutTests/ChangeLog	2013-03-08 21:14:48 UTC (rev 145262)
+++ trunk/LayoutTests/ChangeLog	2013-03-08 21:20:24 UTC (rev 145263)
@@ -1,3 +1,18 @@
+2013-03-08  James Robinson  jam...@chromium.org
+
+Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=88131
+
+Reviewed by Tony Chang.
+
+This test was calling setTimeout(..., 0) in a script block before the end of the document.
+The timeout sometimes fired before parsing the rest of the document and sometimes after,
+depending on when the parser yielded. This moves the script block to the end of the document
+so it always runs after parsing the rest of the test, which is the more common and expected
+behavior.
+
+* fast/dom/HTMLMeterElement/meter-element-crash.html:
+
 2013-03-07  Geoffrey Garen  gga...@apple.com
 
 Added a regression test for raw parsing speed


Modified: trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-crash.html (145262 => 145263)

--- trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-crash.html	2013-03-08 21:14:48 UTC (rev 145262)
+++ trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-crash.html	2013-03-08 21:20:24 UTC (rev 145263)
@@ -4,6 +4,14 @@
-webkit-appearance: none;
  }  
 /style
+span id=test
+script
+document.body.offsetTop;
+/script
+input type=text
+meter
+/meter
+/span
 script
 if (window.testRunner) {
 testRunner.dumpAsText();
@@ -16,11 +24,3 @@
 testRunner.notifyDone();
 }, 0);
 /script
-span id=test
-script
-document.body.offsetTop;
-/script
-input type=text
-meter
-/meter
-/span






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [145266] trunk/LayoutTests

[jamesr]

Title: [145266] trunk/LayoutTests








Revision 145266
Author jam...@google.com
Date 2013-03-08 13:47:42 -0800 (Fri, 08 Mar 2013)


Log Message
Update baselines for string prototypes fixed by v8-i18n roll 164:171

* platform/chromium/fast/js/kde/function_length-expected.txt: Removed.
* platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:
* platform/chromium/fast/js/string-prototype-properties-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt
trunk/LayoutTests/platform/chromium/fast/js/string-prototype-properties-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium/fast/js/kde/function_length-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (145265 => 145266)

--- trunk/LayoutTests/ChangeLog	2013-03-08 21:45:29 UTC (rev 145265)
+++ trunk/LayoutTests/ChangeLog	2013-03-08 21:47:42 UTC (rev 145266)
@@ -1,3 +1,11 @@
+2013-03-08  James Robinson  jam...@chromium.org
+
+Update baselines for string prototypes fixed by v8-i18n roll 164:171
+
+* platform/chromium/fast/js/kde/function_length-expected.txt: Removed.
+* platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:
+* platform/chromium/fast/js/string-prototype-properties-expected.txt:
+
 2013-03-08  Christian Biesinger  cbiesin...@chromium.org
 
 REGRESSION (r143643): button should support ::first-line and ::first-letter


Deleted: trunk/LayoutTests/platform/chromium/fast/js/kde/function_length-expected.txt (145265 => 145266)

--- trunk/LayoutTests/platform/chromium/fast/js/kde/function_length-expected.txt	2013-03-08 21:45:29 UTC (rev 145265)
+++ trunk/LayoutTests/platform/chromium/fast/js/kde/function_length-expected.txt	2013-03-08 21:47:42 UTC (rev 145266)
@@ -1,132 +0,0 @@
-KDE JS Test
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS Array.prototype.toString.length is 0
-PASS Array.prototype.toLocaleString.length is 0
-PASS Array.prototype.concat.length is 1
-PASS Array.prototype.join.length is 1
-PASS Array.prototype.pop.length is 0
-PASS Array.prototype.push.length is 1
-PASS Array.prototype.reverse.length is 0
-PASS Array.prototype.shift.length is 0
-PASS Array.prototype.slice.length is 2
-PASS Array.prototype.sort.length is 1
-PASS Array.prototype.splice.length is 2
-PASS Array.prototype.unshift.length is 1
-PASS Boolean.prototype.toString.length is 0
-PASS Boolean.prototype.valueOf.length is 0
-PASS Date.prototype.toString.length is 0
-PASS Date.prototype.toUTCString.length is 0
-PASS Date.prototype.toDateString.length is 0
-PASS Date.prototype.toTimeString.length is 0
-FAIL Date.prototype.toLocaleString.length should be 0. Was 2.
-FAIL Date.prototype.toLocaleDateString.length should be 0. Was 2.
-FAIL Date.prototype.toLocaleTimeString.length should be 0. Was 2.
-PASS Date.prototype.valueOf.length is 0
-PASS Date.prototype.getTime.length is 0
-PASS Date.prototype.getFullYear.length is 0
-PASS Date.prototype.getUTCFullYear.length is 0
-PASS Date.prototype.toGMTString.length is 0
-PASS Date.prototype.getMonth.length is 0
-PASS Date.prototype.getUTCMonth.length is 0
-PASS Date.prototype.getDate.length is 0
-PASS Date.prototype.getUTCDate.length is 0
-PASS Date.prototype.getDay.length is 0
-PASS Date.prototype.getUTCDay.length is 0
-PASS Date.prototype.getHours.length is 0
-PASS Date.prototype.getUTCHours.length is 0
-PASS Date.prototype.getMinutes.length is 0
-PASS Date.prototype.getUTCMinutes.length is 0
-PASS Date.prototype.getSeconds.length is 0
-PASS Date.prototype.getUTCSeconds.length is 0
-PASS Date.prototype.getMilliseconds.length is 0
-PASS Date.prototype.getUTCMilliseconds.length is 0
-PASS Date.prototype.getTimezoneOffset.length is 0
-PASS Date.prototype.setTime.length is 1
-PASS Date.prototype.setMilliseconds.length is 1
-PASS Date.prototype.setUTCMilliseconds.length is 1
-PASS Date.prototype.setSeconds.length is 2
-PASS Date.prototype.setUTCSeconds.length is 2
-PASS Date.prototype.setMinutes.length is 3
-PASS Date.prototype.setUTCMinutes.length is 3
-PASS Date.prototype.setHours.length is 4
-PASS Date.prototype.setUTCHours.length is 4
-PASS Date.prototype.setDate.length is 1
-PASS Date.prototype.setUTCDate.length is 1
-PASS Date.prototype.setMonth.length is 2
-PASS Date.prototype.setUTCMonth.length is 2
-PASS Date.prototype.setFullYear.length is 3
-PASS Date.prototype.setUTCFullYear.length is 3
-PASS Date.prototype.setYear.length is 1
-PASS Date.prototype.getYear.length is 0
-PASS Date.prototype.toGMTString.length is 0
-PASS Error.prototype.toString.length is 0
-PASS eval.length is 1
-PASS parseInt.length is 2
-PASS parseFloat.length is 1
-PASS isNaN.length is 1
-PASS isFinite.length is 1
-PASS escape.length is 1
-PASS unescape.length is 1
-PASS Math.abs.length is 1
-PASS Math.acos.length is 1
-PASS Math.asin.length is 1
-PASS Math.atan.length is 1
-PASS Math.atan2.length is 2
-PASS Math.ceil.length is 1
-PASS 

[webkit-changes] [145269] trunk/LayoutTests

[jamesr]

Title: [145269] trunk/LayoutTests








Revision 145269
Author jam...@google.com
Date 2013-03-08 14:26:57 -0800 (Fri, 08 Mar 2013)


Log Message
Update baselines for a few chromium compositor tests.

* platform/chromium-linux/compositing/checkerboard-expected.png: Removed.
* platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-mac-lion/compositing/checkerboard-expected.png: Removed.
* platform/chromium-mac/compositing/checkerboard-expected.png:
* platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-win/compositing/checkerboard-expected.png: Removed.
* platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png
trunk/LayoutTests/platform/chromium-mac/compositing/checkerboard-expected.png
trunk/LayoutTests/platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png
trunk/LayoutTests/platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-linux/compositing/checkerboard-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/compositing/checkerboard-expected.png
trunk/LayoutTests/platform/chromium-win/compositing/checkerboard-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (145268 => 145269)

--- trunk/LayoutTests/ChangeLog	2013-03-08 22:19:51 UTC (rev 145268)
+++ trunk/LayoutTests/ChangeLog	2013-03-08 22:26:57 UTC (rev 145269)
@@ -1,3 +1,16 @@
+2013-03-08  James Robinson  jam...@chromium.org
+
+Update baselines for a few chromium compositor tests.
+
+* platform/chromium-linux/compositing/checkerboard-expected.png: Removed.
+* platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
+* platform/chromium-mac-lion/compositing/checkerboard-expected.png: Removed.
+* platform/chromium-mac/compositing/checkerboard-expected.png:
+* platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
+* platform/chromium-win/compositing/checkerboard-expected.png: Removed.
+* platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
+* platform/chromium/TestExpectations:
+
 2013-03-08  Mike West  mk...@chromium.org
 
 CSP: 'eval()' is blocked in report-only mode.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (145268 => 145269)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-08 22:19:51 UTC (rev 145268)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-08 22:26:57 UTC (rev 145269)
@@ -4201,7 +4201,6 @@
 
 # This test is consistently leaking state into the next test.
 webkit.org/b/85522 http/tests/security/sandboxed-iframe-form-top.html [ Skip ]
-webkit.org/b/102542 [ Linux Mac Win ] compositing/checkerboard.html [ ImageOnlyFailure ]
 
 webkit.org/b/102724 [ Linux ] svg/carto.net/colourpicker.svg [ ImageOnlyFailure Pass ]
 
@@ -4247,7 +4246,6 @@
 webkit.org/b/103700 compositing/masks/simple-composited-mask.html [ ImageOnlyFailure ]
 
 # Some compositing tests doesn't work on multiple platforms.
-webkit.org/b/103721 [ Mac Win Linux ] compositing/geometry/vertical-scroll-composited.html [ ImageOnlyFailure ]
 webkit.org/b/103721 [ Mac Win Linux ] compositing/reflections/load-video-in-reflection.html [ ImageOnlyFailure ]
 webkit.org/b/103721 [ Mac Win Linux ] compositing/reflections/nested-reflection-anchor-point.html [ ImageOnlyFailure ]
 webkit.org/b/103721 [ Mac Win Linux ] compositing/reflections/nested-reflection-animated.html [ ImageOnlyFailure ]


Deleted: trunk/LayoutTests/platform/chromium-linux/compositing/checkerboard-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/compositing/checkerboard-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-mac-lion/compositing/checkerboard-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-win/compositing/checkerboard-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [145287] trunk/LayoutTests

[jamesr]

Title: [145287] trunk/LayoutTests








Revision 145287
Author jam...@google.com
Date 2013-03-08 16:29:45 -0800 (Fri, 08 Mar 2013)


Log Message
Update a few more chromium baselines.

* platform/chromium-mac-lion/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
* platform/chromium-mac/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
* platform/chromium-win-xp/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
* platform/chromium-win-xp/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt


Added Paths

trunk/LayoutTests/platform/chromium-mac/editing/pasteboard/paste-text-016-expected.txt
trunk/LayoutTests/platform/chromium-mac-lion/editing/pasteboard/paste-text-016-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/editing/pasteboard/paste-text-016-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (145286 => 145287)

--- trunk/LayoutTests/ChangeLog	2013-03-09 00:17:51 UTC (rev 145286)
+++ trunk/LayoutTests/ChangeLog	2013-03-09 00:29:45 UTC (rev 145287)
@@ -1,3 +1,13 @@
+2013-03-08  James Robinson  jam...@chromium.org
+
+Update a few more chromium baselines.
+
+* platform/chromium-mac-lion/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
+* platform/chromium-mac/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
+* platform/chromium-win-xp/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
+* platform/chromium-win-xp/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
+* platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt:
+
 2013-03-08  Harald Alvestrand  h...@chromium.org
 
 Implemented new API for RTCStatsReport object.


Copied: trunk/LayoutTests/platform/chromium-mac/editing/pasteboard/paste-text-016-expected.txt (from rev 145280, trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt) (0 => 145287)

--- trunk/LayoutTests/platform/chromium-mac/editing/pasteboard/paste-text-016-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-mac/editing/pasteboard/paste-text-016-expected.txt	2013-03-09 00:29:45 UTC (rev 145287)
@@ -0,0 +1,65 @@
+EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of BODY  HTML  #document to 10 of BODY  HTML  #document
+EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of #text  P  DIV  DIV  BODY  HTML  #document to 0 of P  DIV  DIV  BODY  HTML  #document
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of P  DIV  DIV  BODY  HTML  #document to 6 of DIV  DIV  BODY  HTML  #document toDOMRange:range from 0 of P  DIV  DIV  BODY  HTML  #document to 0 of P  DIV  DIV  BODY  HTML  #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 2 of 

[webkit-changes] [145298] trunk/LayoutTests

[jamesr]

Title: [145298] trunk/LayoutTests








Revision 145298
Author jam...@google.com
Date 2013-03-08 18:29:31 -0800 (Fri, 08 Mar 2013)


Log Message
Update chromium baselines for transforms/3d/point-mapping

* platform/chromium-linux-x86/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-win-xp/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Removed.
* platform/chromium/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png
trunk/LayoutTests/platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png
trunk/LayoutTests/platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png
trunk/LayoutTests/platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png
trunk/LayoutTests/platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png
trunk/LayoutTests/platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png
trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png
trunk/LayoutTests/platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt
trunk/LayoutTests/platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/transforms/3d/
trunk/LayoutTests/platform/chromium-linux-x86/transforms/3d/point-mapping/
trunk/LayoutTests/platform/chromium-linux-x86/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt
trunk/LayoutTests/platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png
trunk/LayoutTests/platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png

[webkit-changes] [145131] trunk/Source

[jamesr]

Title: [145131] trunk/Source








Revision 145131
Author jam...@google.com
Date 2013-03-07 13:53:48 -0800 (Thu, 07 Mar 2013)


Log Message
[chromium] Stop using WebTransformationMatrix on WebLayer
https://bugs.webkit.org/show_bug.cgi?id=111635

Reviewed by Adrienne Walker.

Source/Platform:

WebLayer supports setting transforms by using either SkMatrix44 or WebTransformationMatrix,
both of which are wrappers around 16 doubles. There's no need to have both.

* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):

Source/WebCore:

Switches over to the SkMatrix44 transform setters.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::transformToSkMatrix44):
  Utility for convering a WebCore::TransformationMatrix to an SkMatrix44.
  Will move to a more common location once it gets more callers.
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):

Source/WebKit/chromium:

* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::computeEnclosingCompositingLayer):
* tests/GraphicsLayerChromiumTest.cpp:
(GraphicsLayerChromiumTest):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/LinkHighlight.cpp
trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (145130 => 145131)

--- trunk/Source/Platform/ChangeLog	2013-03-07 21:50:51 UTC (rev 145130)
+++ trunk/Source/Platform/ChangeLog	2013-03-07 21:53:48 UTC (rev 145131)
@@ -1,3 +1,17 @@
+2013-03-06  James Robinson  jam...@chromium.org
+
+[chromium] Stop using WebTransformationMatrix on WebLayer
+https://bugs.webkit.org/show_bug.cgi?id=111635
+
+Reviewed by Adrienne Walker.
+
+WebLayer supports setting transforms by using either SkMatrix44 or WebTransformationMatrix,
+both of which are wrappers around 16 doubles. There's no need to have both.
+
+* chromium/public/WebLayer.h:
+(WebKit):
+(WebLayer):
+
 2013-03-06  Kenneth Russell  k...@google.com
 
 [Chromium] Fix byte ordering bugs reading back WebGL canvases' content on Android


Modified: trunk/Source/WebCore/ChangeLog (145130 => 145131)

--- trunk/Source/WebCore/ChangeLog	2013-03-07 21:50:51 UTC (rev 145130)
+++ trunk/Source/WebCore/ChangeLog	2013-03-07 21:53:48 UTC (rev 145131)
@@ -1,3 +1,19 @@
+2013-03-06  James Robinson  jam...@chromium.org
+
+[chromium] Stop using WebTransformationMatrix on WebLayer
+https://bugs.webkit.org/show_bug.cgi?id=111635
+
+Reviewed by Adrienne Walker.
+
+Switches over to the SkMatrix44 transform setters.
+
+* platform/graphics/chromium/GraphicsLayerChromium.cpp:
+(WebCore::transformToSkMatrix44):
+  Utility for convering a WebCore::TransformationMatrix to an SkMatrix44.
+  Will move to a more common location once it gets more callers.
+(WebCore::GraphicsLayerChromium::updateTransform):
+(WebCore::GraphicsLayerChromium::updateChildrenTransform):
+
 2013-03-07  Eric Carlson  eric.carl...@apple.com
 
 [Mac] allow iOS to use CaptionUserPreferencesMac


Modified: trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp (145130 => 145131)

--- trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2013-03-07 21:50:51 UTC (rev 145130)
+++ trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2013-03-07 21:53:48 UTC (rev 145131)
@@ -68,7 +68,6 @@
 #include public/WebFloatRect.h
 #include public/WebImageLayer.h
 #include public/WebSize.h
-#include public/WebTransformationMatrix.h
 #include wtf/CurrentTime.h
 #include wtf/HashSet.h
 #include wtf/MemoryInstrumentationHashMap.h
@@ -702,14 +701,36 @@
 platformLayer()-setAnchorPointZ(m_anchorPoint.z());
 }
 
+static SkMatrix44 transformToSkMatrix44(const TransformationMatrix matrix)
+{
+SkMatrix44 ret(SkMatrix44::kUninitialized_Constructor);
+ret.setDouble(0, 0, matrix.m11());
+ret.setDouble(0, 1, matrix.m21());
+ret.setDouble(0, 2, matrix.m31());
+ret.setDouble(0, 3, matrix.m41());
+ret.setDouble(1, 0, matrix.m12());
+ret.setDouble(1, 1, matrix.m22());
+ret.setDouble(1, 2, matrix.m32());
+ret.setDouble(1, 3, matrix.m42());
+ret.setDouble(2, 0, matrix.m13());
+ret.setDouble(2, 1, matrix.m23());
+ret.setDouble(2, 2, matrix.m33());
+ret.setDouble(2, 3, matrix.m43());
+ret.setDouble(3, 0, matrix.m14());
+ret.setDouble(3, 1, matrix.m24());
+ret.setDouble(3, 2, matrix.m34());
+ret.setDouble(3, 3, matrix.m44());
+return ret;
+}
+
 void GraphicsLayerChromium::updateTransform()
 {
-platformLayer()-setTransform(WebTransformationMatrix(m_transform));
+platformLayer()-setTransform(transformToSkMatrix44(m_transform));
 }
 
 void 

[webkit-changes] [144775] trunk/Tools

[jamesr]

Title: [144775] trunk/Tools








Revision 144775
Author jam...@google.com
Date 2013-03-05 10:18:45 -0800 (Tue, 05 Mar 2013)


Log Message
Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
https://bugs.webkit.org/show_bug.cgi?id=111440

Reviewed by Adrienne Walker.

Remove unnecessary WebCompositorSupport::shutdown call

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp




Diff

Modified: trunk/Tools/ChangeLog (144774 => 144775)

--- trunk/Tools/ChangeLog	2013-03-05 18:06:08 UTC (rev 144774)
+++ trunk/Tools/ChangeLog	2013-03-05 18:18:45 UTC (rev 144775)
@@ -1,3 +1,15 @@
+2013-03-05  James Robinson  jam...@chromium.org
+
+Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
+https://bugs.webkit.org/show_bug.cgi?id=111440
+
+Reviewed by Adrienne Walker.
+
+Remove unnecessary WebCompositorSupport::shutdown call
+
+* DumpRenderTree/chromium/DumpRenderTree.cpp:
+(main):
+
 2013-03-05  Gustavo Noronha Silva  g...@gnome.org
 
 Unreviewed build fix.


Modified: trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp (144774 => 144775)

--- trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp	2013-03-05 18:06:08 UTC (rev 144774)
+++ trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp	2013-03-05 18:18:45 UTC (rev 144775)
@@ -292,8 +292,5 @@
 shell.resetTestController();
 }
 
-// Shutdown WebCompositor after TestShell is destructed properly.
-WebKit::Platform::current()-compositorSupport()-shutdown();
-
 return EXIT_SUCCESS;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144827] trunk

[jamesr]

Title: [144827] trunk








Revision 144827
Author jam...@google.com
Date 2013-03-05 15:15:23 -0800 (Tue, 05 Mar 2013)


Log Message
[chromium] Move check for threaded compositing from WebCompositorSupport to Platform
https://bugs.webkit.org/show_bug.cgi?id=111386

Reviewed by Adrienne Walker.

Source/Platform:

This moves the query for if threaded compositing is enabled from WebCompositorSupport
to Platform. This is part of an effort to remove statefulness on WebCompositorSupport
and because it's much easier to override Platform functions for different tests.

* chromium/public/Platform.h:
(WebKit::Platform::isThreadedCompositingEnabled):
(Platform):
* chromium/public/WebCompositorSupport.h:

Source/WebCore:

This moves checks for whether threaded compositing is enabled from WebCompositorSupport
to Platform. In the case of Canvas2DLayerBridge, the check is moved completely out of
the class to make it easier for tests to specify the threaded configuration to use in the test.

* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
* platform/graphics/chromium/Canvas2DLayerBridge.h:
(WebCore::Canvas2DLayerBridge::create):
(Canvas2DLayerBridge):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::scheduleComposite):
* tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
* tests/Canvas2DLayerManagerTest.cpp:
(FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):

Tools:

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/Platform.h
trunk/Source/Platform/chromium/public/WebCompositorSupport.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.cpp
trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.h
trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/tests/Canvas2DLayerBridgeTest.cpp
trunk/Source/WebKit/chromium/tests/Canvas2DLayerManagerTest.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (144826 => 144827)

--- trunk/Source/Platform/ChangeLog	2013-03-05 23:04:10 UTC (rev 144826)
+++ trunk/Source/Platform/ChangeLog	2013-03-05 23:15:23 UTC (rev 144827)
@@ -1,3 +1,19 @@
+2013-03-04  James Robinson  jam...@chromium.org
+
+[chromium] Move check for threaded compositing from WebCompositorSupport to Platform
+https://bugs.webkit.org/show_bug.cgi?id=111386
+
+Reviewed by Adrienne Walker.
+
+This moves the query for if threaded compositing is enabled from WebCompositorSupport
+to Platform. This is part of an effort to remove statefulness on WebCompositorSupport
+and because it's much easier to override Platform functions for different tests.
+
+* chromium/public/Platform.h:
+(WebKit::Platform::isThreadedCompositingEnabled):
+(Platform):
+* chromium/public/WebCompositorSupport.h:
+
 2013-03-05  James Robinson  jam...@chromium.org
 
 [chromium] Clean up WebWidget / WebLayerTreeView interactions


Modified: trunk/Source/Platform/chromium/public/Platform.h (144826 => 144827)

--- trunk/Source/Platform/chromium/public/Platform.h	2013-03-05 23:04:10 UTC (rev 144826)
+++ trunk/Source/Platform/chromium/public/Platform.h	2013-03-05 23:15:23 UTC (rev 144827)
@@ -478,6 +478,8 @@
 // This value must be checked again after a context loss event as the platform's capabilities may have changed.
 virtual bool canAccelerate2dCanvas() { return false; }
 
+virtual bool isThreadedCompositingEnabled() { return false; }
+
 virtual WebCompositorSupport* compositorSupport() { return 0; }
 
 virtual WebFlingAnimator* createFlingAnimator() { return 0; }


Modified: trunk/Source/Platform/chromium/public/WebCompositorSupport.h (144826 => 144827)

--- trunk/Source/Platform/chromium/public/WebCompositorSupport.h	2013-03-05 23:04:10 UTC (rev 144826)
+++ trunk/Source/Platform/chromium/public/WebCompositorSupport.h	2013-03-05 23:15:23 UTC (rev 144827)
@@ -61,9 +61,6 @@
 // prior to calling initialize.
 virtual void initialize(WebThread*) { }
 
-// Returns whether the compositor was initialized with threading enabled.
-virtual bool isThreadingEnabled() { return false; }
-
 // Shuts down the compositor. This must be called when all compositor data
 // types have been deleted. No 

[webkit-changes] [144673] trunk/Source/WebKit/chromium

[jamesr]

Title: [144673] trunk/Source/WebKit/chromium








Revision 144673
Author jam...@google.com
Date 2013-03-04 14:15:04 -0800 (Mon, 04 Mar 2013)


Log Message
[chromium] Roll chromium DEPS 185662 - 185963

Roll roll roll the deps
  Gently from downstream.
Merrily merrily merrily merrily
  Green bots are but a dream.

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (144672 => 144673)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-04 22:08:26 UTC (rev 144672)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-04 22:15:04 UTC (rev 144673)
@@ -1,3 +1,14 @@
+2013-03-04  James Robinson  jam...@chromium.org
+
+[chromium] Roll chromium DEPS 185662 - 185963
+
+Roll roll roll the deps
+  Gently from downstream.
+Merrily merrily merrily merrily
+  Green bots are but a dream.
+
+* DEPS:
+
 2013-03-04  Tony Chang  t...@chromium.org
 
 Unreviewed, rolling out r144562.


Modified: trunk/Source/WebKit/chromium/DEPS (144672 => 144673)

--- trunk/Source/WebKit/chromium/DEPS	2013-03-04 22:08:26 UTC (rev 144672)
+++ trunk/Source/WebKit/chromium/DEPS	2013-03-04 22:15:04 UTC (rev 144673)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '185662'
+  'chromium_rev': '185963'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144712] trunk/Source/WebKit/chromium

[jamesr]

Title: [144712] trunk/Source/WebKit/chromium








Revision 144712
Author jam...@google.com
Date 2013-03-04 19:49:29 -0800 (Mon, 04 Mar 2013)


Log Message
Unreviewed.  Rolled Chromium DEPS to r185990.  Requested by
jamesr_ via sheriffbot.

Patch by Sheriff Bot webkit.review@gmail.com on 2013-03-04

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (144711 => 144712)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-05 03:40:47 UTC (rev 144711)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-05 03:49:29 UTC (rev 144712)
@@ -1,3 +1,10 @@
+2013-03-04  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed.  Rolled Chromium DEPS to r185990.  Requested by
+jamesr_ via sheriffbot.
+
+* DEPS:
+
 2013-02-26  Kentaro Hara  hara...@chromium.org
 
 [chromium] Implement TRACE_EVENT macros for sampling profiling


Modified: trunk/Source/WebKit/chromium/DEPS (144711 => 144712)

--- trunk/Source/WebKit/chromium/DEPS	2013-03-05 03:40:47 UTC (rev 144711)
+++ trunk/Source/WebKit/chromium/DEPS	2013-03-05 03:49:29 UTC (rev 144712)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '185963'
+  'chromium_rev': '185990'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144512] trunk/LayoutTests

[jamesr]

Title: [144512] trunk/LayoutTests








Revision 144512
Author jam...@google.com
Date 2013-03-01 15:22:00 -0800 (Fri, 01 Mar 2013)


Log Message
[chromium] Mark some software compositing tests as failing before landing anti-aliasing changes
https://bugs.webkit.org/show_bug.cgi?id=111224

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (144511 => 144512)

--- trunk/LayoutTests/ChangeLog	2013-03-01 23:05:27 UTC (rev 144511)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 23:22:00 UTC (rev 144512)
@@ -1,3 +1,10 @@
+2013-03-01  James Robinson  jam...@chromium.org
+
+[chromium] Mark some software compositing tests as failing before landing anti-aliasing changes
+https://bugs.webkit.org/show_bug.cgi?id=111224
+
+* platform/chromium/TestExpectations:
+
 2013-03-01  Adrienne Walker  e...@chromium.org
 
 [chromium] Mark more flaky tests related to scrollbar ordering


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144511 => 144512)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-01 23:05:27 UTC (rev 144511)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-01 23:22:00 UTC (rev 144512)
@@ -4403,6 +4403,12 @@
 crbug.com/175926 [ Linux ] platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ Failure ImageOnlyFailure ]
 crbug.com/175926 [ Linux ] platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow.html [ Failure ImageOnlyFailure ]
 
+# Need rebaseline after compositor edge AA changes land.
+webkit.org/b/111224 platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep.html [ ImageOnlyFailure ]
+webkit.org/b/111224 platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children.html [ ImageOnlyFailure ]
+webkit.org/b/111224 platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited.html [ ImageOnlyFailure ]
+webkit.org/b/111224 platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection.html [ ImageOnlyFailure ]
+
 # Need rebaseline
 webkit.org/b/110654 [ Mac Win ] css2.1/20110323/replaced-elements-001.htm [ Failure ]
 webkit.org/b/109413 [ Linux Win ] svg/custom/foreign-object-skew.svg [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144398] trunk/Tools

[jamesr]

Title: [144398] trunk/Tools








Revision 144398
Author jam...@google.com
Date 2013-02-28 16:50:37 -0800 (Thu, 28 Feb 2013)


Log Message
[chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
https://bugs.webkit.org/show_bug.cgi?id=111017

Reviewed by Adam Barth.

This decouples DumpRenderTree from WebLayerTreeViewClient.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHostDRTLayerTreeViewClient):
(WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
(WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
(WebViewHostDRTLayerTreeViewClient::Layout):
(WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
(WebViewHost::initializeLayerTreeView):
* DumpRenderTree/chromium/WebViewHost.h:
(webkit_support):
(WebViewHost):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Tools/ChangeLog (144397 => 144398)

--- trunk/Tools/ChangeLog	2013-03-01 00:47:10 UTC (rev 144397)
+++ trunk/Tools/ChangeLog	2013-03-01 00:50:37 UTC (rev 144398)
@@ -1,3 +1,23 @@
+2013-02-27  James Robinson  jam...@chromium.org
+
+[chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
+https://bugs.webkit.org/show_bug.cgi?id=111017
+
+Reviewed by Adam Barth.
+
+This decouples DumpRenderTree from WebLayerTreeViewClient.
+
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHostDRTLayerTreeViewClient):
+(WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
+(WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
+(WebViewHostDRTLayerTreeViewClient::Layout):
+(WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
+(WebViewHost::initializeLayerTreeView):
+* DumpRenderTree/chromium/WebViewHost.h:
+(webkit_support):
+(WebViewHost):
+
 2013-02-28  Ryuan Choi  ryuan.c...@samsung.com
 
 Unreviewed, add my secondary email address to the list.


Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h (144397 => 144398)

--- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h	2013-03-01 00:47:10 UTC (rev 144397)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h	2013-03-01 00:50:37 UTC (rev 144398)
@@ -108,6 +108,8 @@
 
 void setLogConsoleOutput(bool enabled);
 
+void scheduleComposite();
+
 #if WEBTESTRUNNER_IMPLEMENTATION
 void display();
 void displayInvalidatedRegion();
@@ -125,7 +127,6 @@
 
 void didInvalidateRect(const WebKit::WebRect);
 void didScrollRect(int, int, const WebKit::WebRect);
-void scheduleComposite();
 void scheduleAnimation();
 void setWindowRect(const WebKit::WebRect);
 void show(WebKit::WebNavigationPolicy);
@@ -251,11 +252,6 @@
 WebTestProxyBase::didScrollRect(dx, dy, clipRect);
 Base::didScrollRect(dx, dy, clipRect);
 }
-virtual void scheduleComposite()
-{
-WebTestProxyBase::scheduleComposite();
-Base::scheduleComposite();
-}
 virtual void scheduleAnimation()
 {
 WebTestProxyBase::scheduleAnimation();


Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp (144397 => 144398)

--- trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp	2013-03-01 00:47:10 UTC (rev 144397)
+++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp	2013-03-01 00:50:37 UTC (rev 144398)
@@ -262,12 +262,26 @@
 setWindowRect(WebRect(0, 0, newSize.width, newSize.height));
 }
 
+class WebViewHostDRTLayerTreeViewClient : public webkit_support::DRTLayerTreeViewClient {
+public:
+explicit WebViewHostDRTLayerTreeViewClient(WebViewHost* host)
+: m_host(host) { }
+virtual ~WebViewHostDRTLayerTreeViewClient() { }
+
+virtual void Layout() { m_host-webView()-layout(); }
+virtual void ScheduleComposite() { m_host-proxy()-scheduleComposite(); }
+
+private:
+WebViewHost* m_host;
+};
+
 void WebViewHost::initializeLayerTreeView(WebLayerTreeViewClient* client, const WebLayer rootLayer, const WebLayerTreeView::Settings settings)
 {
+m_layerTreeViewClient = adoptPtr(new WebViewHostDRTLayerTreeViewClient(this));
 if (m_shell-softwareCompositingEnabled())
-m_layerTreeView = adoptPtr(webkit_support::CreateLayerTreeViewSoftware(client));
+m_layerTreeView = adoptPtr(webkit_support::CreateLayerTreeViewSoftware(m_layerTreeViewClient.get()));
 else
-m_layerTreeView = adoptPtr(webkit_support::CreateLayerTreeView3d(client));
+m_layerTreeView = adoptPtr(webkit_support::CreateLayerTreeView3d(m_layerTreeViewClient.get()));
 
 ASSERT(m_layerTreeView);
 m_layerTreeView-setRootLayer(rootLayer);


Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.h (144397 => 144398)

--- 

[webkit-changes] [144206] trunk/Source/WebKit/chromium

[jamesr]

Title: [144206] trunk/Source/WebKit/chromium








Revision 144206
Author jam...@google.com
Date 2013-02-27 09:53:04 -0800 (Wed, 27 Feb 2013)


Log Message
[chromium] Remove WebViewImpl::animate shimmy out through compositor
https://bugs.webkit.org/show_bug.cgi?id=110935

Reviewed by Adrienne Walker.

WebViewImpl::animate() and WebViewImpl::updateAnimations() are confusingly similar. ::animate() implements
the WebWidget API and is called by content::RenderWidget and WebViewHost. ::updateAnimations() implements
the WebLayerTreeViewClient API and is called by content::RenderWidgetCompositor and by ::animate(). The
important part of this indirection is that whenever the compositor is active, all animation calls must
route through cc::LayerTreeHost before entering into WebCore's animation code so that the compositor
can set the appropriate rate limiting state. Animations may originate from
content::RenderWidget::AnimateIfNeeded when in software and single threaded mode or from
cc::LayerTreeHost::updateAnimations in threaded compositing mode. In the long ago, content::RenderWidget had no
idea if compositing was active or not and always called WebWidget::animate(), so WebViewImpl::animate() had to
redirect to the compositor when appropriate.

Now (as of chromium r180947) RenderWidget calls WebWidget::animate only when in software mode and otherwise
calls directly into the compositor. Thus WebViewImpl::animate() no longer needs to do this check. In a
follow-up, WebViewImpl::updateAnimations will go away completely in favor of just calling WebWidget::animate in
all cases.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (144205 => 144206)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-27 17:48:07 UTC (rev 144205)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-27 17:53:04 UTC (rev 144206)
@@ -1,3 +1,30 @@
+2013-02-26  James Robinson  jam...@chromium.org
+
+[chromium] Remove WebViewImpl::animate shimmy out through compositor
+https://bugs.webkit.org/show_bug.cgi?id=110935
+
+Reviewed by Adrienne Walker.
+
+WebViewImpl::animate() and WebViewImpl::updateAnimations() are confusingly similar. ::animate() implements
+the WebWidget API and is called by content::RenderWidget and WebViewHost. ::updateAnimations() implements
+the WebLayerTreeViewClient API and is called by content::RenderWidgetCompositor and by ::animate(). The
+important part of this indirection is that whenever the compositor is active, all animation calls must
+route through cc::LayerTreeHost before entering into WebCore's animation code so that the compositor
+can set the appropriate rate limiting state. Animations may originate from
+content::RenderWidget::AnimateIfNeeded when in software and single threaded mode or from
+cc::LayerTreeHost::updateAnimations in threaded compositing mode. In the long ago, content::RenderWidget had no
+idea if compositing was active or not and always called WebWidget::animate(), so WebViewImpl::animate() had to
+redirect to the compositor when appropriate.
+
+Now (as of chromium r180947) RenderWidget calls WebWidget::animate only when in software mode and otherwise
+calls directly into the compositor. Thus WebViewImpl::animate() no longer needs to do this check. In a
+follow-up, WebViewImpl::updateAnimations will go away completely in favor of just calling WebWidget::animate in
+all cases.
+
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::animate):
+(WebKit::WebViewImpl::updateAnimations):
+
 2013-02-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r144179.


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (144205 => 144206)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-27 17:48:07 UTC (rev 144205)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-27 17:53:04 UTC (rev 144206)
@@ -1815,20 +1815,9 @@
 }
 #endif
 
-void WebViewImpl::animate(double)
+void WebViewImpl::animate(double monotonicFrameBeginTime)
 {
-#if ENABLE(REQUEST_ANIMATION_FRAME)
-double monotonicFrameBeginTime = monotonicallyIncreasingTime();
-
-#if USE(ACCELERATED_COMPOSITING)
-// In composited mode, we always go through the compositor so it can apply
-// appropriate flow-control mechanisms.
-if (isAcceleratedCompositingActive())
-m_layerTreeView-updateAnimations(monotonicFrameBeginTime);
-else
-#endif
-updateAnimations(monotonicFrameBeginTime);
-#endif
+updateAnimations(monotonicFrameBeginTime);
 }
 
 void WebViewImpl::willBeginFrame()
@@ -1844,6 +1833,9 @@
 
 void WebViewImpl::updateAnimations(double monotonicFrameBeginTime)
 {
+if (!monotonicFrameBeginTime)
+   

[webkit-changes] [144120] trunk/Source

[jamesr]

Title: [144120] trunk/Source








Revision 144120
Author jam...@google.com
Date 2013-02-26 16:31:11 -0800 (Tue, 26 Feb 2013)


Log Message
[chromium] Remove unused WebLayerTreeViewClient calls
https://bugs.webkit.org/show_bug.cgi?id=110923

Reviewed by Adrienne Walker.

These notifications existed for instrumentation, but now the instrumentation routes
through WebDevToolsAgent.

Source/Platform:

* chromium/public/WebLayerTreeViewClient.h:

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
* tests/WebLayerTreeViewTestCommon.h:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h




Diff

Modified: trunk/Source/Platform/ChangeLog (144119 => 144120)

--- trunk/Source/Platform/ChangeLog	2013-02-27 00:28:23 UTC (rev 144119)
+++ trunk/Source/Platform/ChangeLog	2013-02-27 00:31:11 UTC (rev 144120)
@@ -1,3 +1,15 @@
+2013-02-26  James Robinson  jam...@chromium.org
+
+[chromium] Remove unused WebLayerTreeViewClient calls
+https://bugs.webkit.org/show_bug.cgi?id=110923
+
+Reviewed by Adrienne Walker.
+
+These notifications existed for instrumentation, but now the instrumentation routes
+through WebDevToolsAgent.
+
+* chromium/public/WebLayerTreeViewClient.h:
+
 2013-02-26  Dana Jansens  dan...@chromium.org
 
 Create the SharedGraphicsContext3D through its own method.


Modified: trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h (144119 => 144120)

--- trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h	2013-02-27 00:28:23 UTC (rev 144119)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h	2013-02-27 00:31:11 UTC (rev 144120)
@@ -69,24 +69,6 @@
 
 virtual WebInputHandler* createInputHandler() { return 0; }
 
-// Indicates that a frame will be committed to the impl side of the compositor
-// for rendering.
-virtual void willCommit() { }
-
-// Indicates that a frame was committed to the impl side of the compositor
-// for rendering.
-//
-// FIXME: make this non-virtual when ui/compositor DEP is resolved.
-virtual void didCommit() { }
-
-// Indicates that a frame was committed to the impl side and drawing
-// commands for it were issued to the GPU.
-virtual void didCommitAndDrawFrame() = 0;
-
-// Indicates that a frame previously issued to the GPU has completed
-// rendering.
-virtual void didCompleteSwapBuffers() = 0;
-
 // Schedules a compositing pass, meaning the client should call
 // WebLayerTreeView::composite at a later time. This is only called if the
 // compositor thread is disabled; when enabled, the compositor will


Modified: trunk/Source/WebKit/chromium/ChangeLog (144119 => 144120)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-27 00:28:23 UTC (rev 144119)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-27 00:31:11 UTC (rev 144120)
@@ -1,3 +1,17 @@
+2013-02-26  James Robinson  jam...@chromium.org
+
+[chromium] Remove unused WebLayerTreeViewClient calls
+https://bugs.webkit.org/show_bug.cgi?id=110923
+
+Reviewed by Adrienne Walker.
+
+These notifications existed for instrumentation, but now the instrumentation routes
+through WebDevToolsAgent.
+
+* src/WebViewImpl.cpp:
+* src/WebViewImpl.h:
+* tests/WebLayerTreeViewTestCommon.h:
+
 2013-02-26  Dirk Pranke  dpra...@chromium.org
 
 Roll Chromium DEPS from r183905 - r184646.


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (144119 => 144120)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-27 00:28:23 UTC (rev 144119)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-27 00:31:11 UTC (rev 144120)
@@ -4250,32 +4250,6 @@
 }
 }
 
-void WebViewImpl::willCommit()
-{
-if (m_devToolsAgent)
-m_devToolsAgent-willComposite();
-}
-
-void WebViewImpl::didCommit()
-{
-if (m_client) {
-m_client-didCommitCompositorFrame();
-m_client-didBecomeReadyForAdditionalInput();
-}
-}
-
-void WebViewImpl::didCommitAndDrawFrame()
-{
-if (m_client)
-m_client-didCommitAndDrawCompositorFrame();
-}
-
-void WebViewImpl::didCompleteSwapBuffers()
-{
-if (m_client)
-m_client-didCompleteSwapBuffers();
-}
-
 void WebViewImpl::didRecreateOutputSurface(bool success)
 {
 // Switch back to software rendering mode, if necessary


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (144119 => 144120)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.h	2013-02-27 00:28:23 UTC (rev 144119)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h	2013-02-27 00:31:11 UTC (rev 144120)
@@ -322,10 +322,6 @@
 virtual WebCompositorOutputSurface* createOutputSurface() OVERRIDE;
 

[webkit-changes] [144129] trunk/Source

[jamesr]

Title: [144129] trunk/Source








Revision 144129
Author jam...@google.com
Date 2013-02-26 17:09:52 -0800 (Tue, 26 Feb 2013)


Log Message
[chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
https://bugs.webkit.org/show_bug.cgi?id=110928

Reviewed by Adrienne Walker.

Source/Platform:

* chromium/public/WebLayerTreeViewClient.h:

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
* tests/WebLayerTreeViewTestCommon.h:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h




Diff

Modified: trunk/Source/Platform/ChangeLog (144128 => 144129)

--- trunk/Source/Platform/ChangeLog	2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/Platform/ChangeLog	2013-02-27 01:09:52 UTC (rev 144129)
@@ -1,5 +1,14 @@
 2013-02-26  James Robinson  jam...@chromium.org
 
+[chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
+https://bugs.webkit.org/show_bug.cgi?id=110928
+
+Reviewed by Adrienne Walker.
+
+* chromium/public/WebLayerTreeViewClient.h:
+
+2013-02-26  James Robinson  jam...@chromium.org
+
 [chromium] Remove unused WebLayerTreeViewClient calls
 https://bugs.webkit.org/show_bug.cgi?id=110923
 


Modified: trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h (144128 => 144129)

--- trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h	2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h	2013-02-27 01:09:52 UTC (rev 144129)
@@ -37,17 +37,6 @@
 
 class WebLayerTreeViewClient {
 public:
-// Indicates to the embedder that the compositor is about to begin a
-// frame. This is is a signal to flow control mechanisms that a frame is
-// beginning. This call will be followed by updateAnimations and then
-// layout, which should be used for actual animation or tree manipulation
-// tasks.  FIXME: make pure virtual once upstream deps are satisfied.
-virtual void willBeginFrame() { }
-
-// Indicates that main thread tasks associated with frame rendering have completed.
-// Issued unconditionally, even if the context was lost in the process.
-virtual void didBeginFrame() { }
-
 // Updates animation and layout. These are called before the compositing
 // pass so that layers can be updated at the given frame time.
 virtual void updateAnimations(double monotonicFrameBeginTime) = 0;


Modified: trunk/Source/WebKit/chromium/ChangeLog (144128 => 144129)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-27 01:09:52 UTC (rev 144129)
@@ -1,3 +1,14 @@
+2013-02-26  James Robinson  jam...@chromium.org
+
+[chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
+https://bugs.webkit.org/show_bug.cgi?id=110928
+
+Reviewed by Adrienne Walker.
+
+* src/WebViewImpl.cpp:
+* src/WebViewImpl.h:
+* tests/WebLayerTreeViewTestCommon.h:
+
 2013-02-26  Alpha Lam  hc...@chromium.org
 
 [chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (144128 => 144129)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-27 01:09:52 UTC (rev 144129)
@@ -1831,17 +1831,6 @@
 #endif
 }
 
-void WebViewImpl::willBeginFrame()
-{
-m_client-willBeginCompositorFrame();
-}
-
-void WebViewImpl::didBeginFrame()
-{
-if (m_devToolsAgent)
-m_devToolsAgent-didComposite();
-}
-
 void WebViewImpl::updateAnimations(double monotonicFrameBeginTime)
 {
 #if ENABLE(REQUEST_ANIMATION_FRAME)


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (144128 => 144129)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.h	2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h	2013-02-27 01:09:52 UTC (rev 144129)
@@ -315,8 +315,6 @@
 virtual void setContinuousPaintingEnabled(bool);
 
 // WebLayerTreeViewClient
-virtual void willBeginFrame();
-virtual void didBeginFrame();
 virtual void updateAnimations(double monotonicFrameBeginTime);
 virtual void applyScrollAndScale(const WebSize, float);
 virtual WebCompositorOutputSurface* createOutputSurface() OVERRIDE;


Modified: trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h (144128 => 144129)

--- trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h	2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h	2013-02-27 01:09:52 UTC (rev 144129)
@@ -37,8 +37,6 @@
 public:
 MOCK_METHOD0(scheduleComposite, void());
 virtual 

[webkit-changes] [143998] trunk/Source/WebKit/chromium

[jamesr]

Title: [143998] trunk/Source/WebKit/chromium








Revision 143998
Author jam...@google.com
Date 2013-02-25 18:25:13 -0800 (Mon, 25 Feb 2013)


Log Message
[chromium] WebViewImpl::m_client can be null in some unit tests, check it before calling
https://bugs.webkit.org/show_bug.cgi?id=110834

Reviewed by Adrienne Walker.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::setRootGraphicsLayer):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (143997 => 143998)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-26 02:25:04 UTC (rev 143997)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-26 02:25:13 UTC (rev 143998)
@@ -1,3 +1,14 @@
+2013-02-25  James Robinson  jam...@chromium.org
+
+[chromium] WebViewImpl::m_client can be null in some unit tests, check it before calling
+https://bugs.webkit.org/show_bug.cgi?id=110834
+
+Reviewed by Adrienne Walker.
+
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::suppressInvalidations):
+(WebKit::WebViewImpl::setRootGraphicsLayer):
+
 2013-02-25  Ken Kania  kka...@chromium.org
 
 Remove browser patching mechanism for handling _javascript_ dialogs in chromium port


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (143997 => 143998)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-26 02:25:04 UTC (rev 143997)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-26 02:25:13 UTC (rev 143998)
@@ -4002,7 +4002,8 @@
 void WebViewImpl::suppressInvalidations(bool enable)
 {
 m_suppressInvalidations = enable;
-m_client-suppressCompositorScheduling(enable);
+if (m_client)
+m_client-suppressCompositorScheduling(enable);
 }
 
 #if USE(ACCELERATED_COMPOSITING)
@@ -4013,8 +4014,7 @@
 
 void WebViewImpl::setRootGraphicsLayer(GraphicsLayer* layer)
 {
-m_client-suppressCompositorScheduling(true);
-TemporaryChangebool change(m_suppressInvalidations, true);
+suppressInvalidations(true);
 
 m_rootGraphicsLayer = layer;
 m_rootLayer = layer ? layer-platformLayer() : 0;
@@ -4038,7 +4038,7 @@
 m_layerTreeView-clearRootLayer();
 }
 
-m_client-suppressCompositorScheduling(false);
+suppressInvalidations(false);
 }
 
 void WebViewImpl::scheduleCompositingLayerSync()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [143547] trunk

[jamesr]

Title: [143547] trunk








Revision 143547
Author jam...@google.com
Date 2013-02-20 18:09:53 -0800 (Wed, 20 Feb 2013)


Log Message
[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
https://bugs.webkit.org/show_bug.cgi?id=109634

Reviewed by Adrienne Walker.

Source/Platform:

* chromium/public/WebUnitTestSupport.h:

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebUnitTestSupport.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Source/Platform/ChangeLog (143546 => 143547)

--- trunk/Source/Platform/ChangeLog	2013-02-21 02:02:24 UTC (rev 143546)
+++ trunk/Source/Platform/ChangeLog	2013-02-21 02:09:53 UTC (rev 143547)
@@ -1,3 +1,12 @@
+2013-02-14  James Robinson  jam...@chromium.org
+
+[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
+https://bugs.webkit.org/show_bug.cgi?id=109634
+
+Reviewed by Adrienne Walker.
+
+* chromium/public/WebUnitTestSupport.h:
+
 2013-02-20  Mark Pilgrim  pilg...@chromium.org
 
 [Chromium] Move WebKitPlatformSupport declaration to Platform.h


Modified: trunk/Source/Platform/chromium/public/WebUnitTestSupport.h (143546 => 143547)

--- trunk/Source/Platform/chromium/public/WebUnitTestSupport.h	2013-02-21 02:02:24 UTC (rev 143546)
+++ trunk/Source/Platform/chromium/public/WebUnitTestSupport.h	2013-02-21 02:09:53 UTC (rev 143547)
@@ -32,6 +32,7 @@
 namespace WebKit {
 
 class WebLayerTreeView;
+class WebLayerTreeViewClient;
 class WebURL;
 class WebURLResponse;
 struct WebURLError;
@@ -55,16 +56,17 @@
 virtual WebString webKitRootDir() { return WebString(); }
 
 // Constructs a WebLayerTreeView set up with reasonable defaults for
-// testing. A LayerTreeTypeUnitTest view can initialize and perform most
-// operations, but is not capable of rendering pixels. A
-// LayerTreeTypeLayoutTest view can render.
+// testing.
 
+virtual WebLayerTreeView* createLayerTreeViewForTesting() { return 0; }
+
+// DEPRECATED, use the version above.
 #define HAVE_CREATELAYERTREEVIEWFORTESTING 1
 enum TestViewType {
 TestViewTypeUnitTest,
 TestViewTypeLayoutTest
 };
-virtual WebLayerTreeView* createLayerTreeViewForTesting(TestViewType type) { return 0; }
+virtual WebLayerTreeView* createLayerTreeViewForTesting(TestViewType) { return 0; }
 };
 
 }


Modified: trunk/Tools/ChangeLog (143546 => 143547)

--- trunk/Tools/ChangeLog	2013-02-21 02:02:24 UTC (rev 143546)
+++ trunk/Tools/ChangeLog	2013-02-21 02:09:53 UTC (rev 143547)
@@ -1,3 +1,14 @@
+2013-02-14  James Robinson  jam...@chromium.org
+
+[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
+https://bugs.webkit.org/show_bug.cgi?id=109634
+
+Reviewed by Adrienne Walker.
+
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::createOutputSurface):
+(WebViewHost::initializeLayerTreeView):
+
 2013-02-20  Martin Robinson  mrobin...@igalia.com
 
 [GTK] Re-enable 3D CSS transforms when using build-webkit


Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp (143546 => 143547)

--- trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp	2013-02-21 02:02:24 UTC (rev 143546)
+++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp	2013-02-21 02:09:53 UTC (rev 143547)
@@ -121,18 +121,6 @@
 return webkit_support::CreateSessionStorageNamespace(quota);
 }
 
-WebCompositorOutputSurface* WebViewHost::createOutputSurface()
-{
-if (!webView())
-return 0;
-
-if (m_shell-softwareCompositingEnabled())
-return WebKit::Platform::current()-compositorSupport()-createOutputSurfaceForSoftware();
-
-WebGraphicsContext3D* context = webkit_support::CreateGraphicsContext3D(WebGraphicsContext3D::Attributes(), webView());
-return WebKit::Platform::current()-compositorSupport()-createOutputSurfaceFor3D(context);
-}
-
 void WebViewHost::didAddMessageToConsole(const WebConsoleMessage message, const WebString sourceName, unsigned sourceLine)
 {
 }
@@ -276,9 +264,14 @@
 
 void WebViewHost::initializeLayerTreeView(WebLayerTreeViewClient* client, const WebLayer rootLayer, const WebLayerTreeView::Settings settings)
 {
-m_layerTreeView = adoptPtr(Platform::current()-compositorSupport()-createLayerTreeView(client, rootLayer, settings));
-if (m_layerTreeView)
-m_layerTreeView-setSurfaceReady();
+if (m_shell-softwareCompositingEnabled())
+m_layerTreeView = adoptPtr(webkit_support::CreateLayerTreeViewSoftware(client));
+else
+m_layerTreeView = adoptPtr(webkit_support::CreateLayerTreeView3d(client));
+
+ASSERT(m_layerTreeView);
+m_layerTreeView-setRootLayer(rootLayer);
+

[webkit-changes] [142841] trunk

[jamesr]

Title: [142841] trunk








Revision 142841
Author jam...@google.com
Date 2013-02-13 18:30:25 -0800 (Wed, 13 Feb 2013)


Log Message
[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
https://bugs.webkit.org/show_bug.cgi?id=109634

Reviewed by Adrienne Walker.

Source/Platform:

* chromium/public/WebUnitTestSupport.h:

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebUnitTestSupport.h
trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp
trunk/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (142840 => 142841)

--- trunk/Source/Platform/ChangeLog	2013-02-14 02:16:23 UTC (rev 142840)
+++ trunk/Source/Platform/ChangeLog	2013-02-14 02:30:25 UTC (rev 142841)
@@ -1,3 +1,12 @@
+2013-02-12  James Robinson  jam...@chromium.org
+
+[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
+https://bugs.webkit.org/show_bug.cgi?id=109634
+
+Reviewed by Adrienne Walker.
+
+* chromium/public/WebUnitTestSupport.h:
+
 2013-02-13  Eberhard Graether  egraet...@google.com
 
 chromium: remove CompositorHUDFontAtlas


Modified: trunk/Source/Platform/chromium/public/WebUnitTestSupport.h (142840 => 142841)

--- trunk/Source/Platform/chromium/public/WebUnitTestSupport.h	2013-02-14 02:16:23 UTC (rev 142840)
+++ trunk/Source/Platform/chromium/public/WebUnitTestSupport.h	2013-02-14 02:30:25 UTC (rev 142841)
@@ -32,6 +32,7 @@
 namespace WebKit {
 
 class WebLayerTreeView;
+class WebLayerTreeViewClient;
 class WebURL;
 class WebURLResponse;
 struct WebURLError;
@@ -62,9 +63,11 @@
 #define HAVE_CREATELAYERTREEVIEWFORTESTING 1
 enum TestViewType {
 TestViewTypeUnitTest,
-TestViewTypeLayoutTest
+TestViewTypeLayoutTestSoftware,
+TestViewTypeLayoutTest3d,
 };
-virtual WebLayerTreeView* createLayerTreeViewForTesting(TestViewType type) { return 0; }
+virtual WebLayerTreeView* createLayerTreeViewForTesting(TestViewType, WebLayerTreeViewClient*) { return 0; }
+virtual WebLayerTreeView* createLayerTreeViewForTesting(TestViewType) { return 0; }
 };
 
 }


Modified: trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp (142840 => 142841)

--- trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp	2013-02-14 02:16:23 UTC (rev 142840)
+++ trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp	2013-02-14 02:30:25 UTC (rev 142841)
@@ -62,7 +62,7 @@
 Platform::current()-compositorSupport()-initialize(0);
 m_graphicsLayer = adoptPtr(new GraphicsLayerChromium(m_client));
 m_platformLayer = m_graphicsLayer-platformLayer();
-m_layerTreeView = adoptPtr(Platform::current()-unitTestSupport()-createLayerTreeViewForTesting(WebUnitTestSupport::TestViewTypeUnitTest));
+m_layerTreeView = adoptPtr(Platform::current()-unitTestSupport()-createLayerTreeViewForTesting(WebUnitTestSupport::TestViewTypeUnitTest, 0));
 ASSERT(m_layerTreeView);
 m_layerTreeView-setRootLayer(*m_platformLayer);
 m_layerTreeView-setViewportSize(WebSize(1, 1), WebSize(1, 1));


Modified: trunk/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp (142840 => 142841)

--- trunk/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp	2013-02-14 02:16:23 UTC (rev 142840)
+++ trunk/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp	2013-02-14 02:30:25 UTC (rev 142841)
@@ -59,7 +59,7 @@
 
 virtual void initializeLayerTreeView(WebLayerTreeViewClient* client, const WebLayer rootLayer, const WebLayerTreeView::Settings settings)
 {
-m_layerTreeView = adoptPtr(Platform::current()-unitTestSupport()-createLayerTreeViewForTesting(WebUnitTestSupport::TestViewTypeUnitTest));
+m_layerTreeView = adoptPtr(Platform::current()-unitTestSupport()-createLayerTreeViewForTesting(WebUnitTestSupport::TestViewTypeUnitTest, 0));
 ASSERT(m_layerTreeView);
 m_layerTreeView-setRootLayer(rootLayer);
 }


Modified: trunk/Tools/ChangeLog (142840 => 142841)

--- trunk/Tools/ChangeLog	2013-02-14 02:16:23 UTC (rev 142840)
+++ trunk/Tools/ChangeLog	2013-02-14 02:30:25 UTC (rev 142841)
@@ -1,3 +1,14 @@
+2013-02-12  James Robinson  jam...@chromium.org
+
+[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
+https://bugs.webkit.org/show_bug.cgi?id=109634
+
+Reviewed by Adrienne Walker.
+
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::createOutputSurface):
+(WebViewHost::initializeLayerTreeView):
+
 2013-02-13  David Farler  dfar...@apple.com
 
 TestWebKitAPI fails to build for iphonesimulator: 

[webkit-changes] [142568] trunk/Source

[jamesr]

Title: [142568] trunk/Source








Revision 142568
Author jam...@google.com
Date 2013-02-11 18:50:58 -0800 (Mon, 11 Feb 2013)


Log Message
[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=109403

Reviewed by Adam Barth.

Source/Platform:

webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
thing.

* chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):
* chromium/public/WebUnitTestSupport.h:
(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):

Source/WebKit/chromium:

* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
* tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::FakeWebViewClient::initializeLayerTreeView):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebCompositorSupport.h
trunk/Source/Platform/chromium/public/WebUnitTestSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp
trunk/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (142567 => 142568)

--- trunk/Source/Platform/ChangeLog	2013-02-12 02:38:54 UTC (rev 142567)
+++ trunk/Source/Platform/ChangeLog	2013-02-12 02:50:58 UTC (rev 142568)
@@ -1,3 +1,21 @@
+2013-02-11  James Robinson  jam...@chromium.org
+
+[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
+https://bugs.webkit.org/show_bug.cgi?id=109403
+
+Reviewed by Adam Barth.
+
+webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
+thing.
+
+* chromium/public/WebCompositorSupport.h:
+(WebCompositorSupport):
+(WebKit::WebCompositorSupport::createLayerTreeView):
+* chromium/public/WebUnitTestSupport.h:
+(WebKit):
+(WebUnitTestSupport):
+(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):
+
 2013-02-10  Florin Malita  fmal...@chromium.org
 
 [Chromium] FilterTypeSaturatingBrightness enum


Modified: trunk/Source/Platform/chromium/public/WebCompositorSupport.h (142567 => 142568)

--- trunk/Source/Platform/chromium/public/WebCompositorSupport.h	2013-02-12 02:38:54 UTC (rev 142567)
+++ trunk/Source/Platform/chromium/public/WebCompositorSupport.h	2013-02-12 02:50:58 UTC (rev 142568)
@@ -69,9 +69,6 @@
 // after shutdown.
 virtual void shutdown() { }
 
-// May return 0 if initialization fails.
-virtual WebLayerTreeView* createLayerTreeView(WebLayerTreeViewClient*, const WebLayer root, const WebLayerTreeView::Settings) { return 0; }
-
 // Creates an output surface for the compositor backed by a 3d context.
 virtual WebCompositorOutputSurface* createOutputSurfaceFor3D(WebKit::WebGraphicsContext3D*) { return 0; }
 
@@ -107,6 +104,13 @@
 
 virtual WebTransformOperations* createTransformOperations() { return 0; }
 
+
+// Testing --
+
+// DEPRECATED
+// May return 0 if initialization fails.
+virtual WebLayerTreeView* createLayerTreeView(WebLayerTreeViewClient*, const WebLayer root, const WebLayerTreeView::Settings) { return 0; }
+
 protected:
 virtual ~WebCompositorSupport() { }
 };


Modified: trunk/Source/Platform/chromium/public/WebUnitTestSupport.h (142567 => 142568)

--- trunk/Source/Platform/chromium/public/WebUnitTestSupport.h	2013-02-12 02:38:54 UTC (rev 142567)
+++ trunk/Source/Platform/chromium/public/WebUnitTestSupport.h	2013-02-12 02:50:58 UTC (rev 142568)
@@ -31,6 +31,7 @@
 
 namespace WebKit {
 
+class WebLayerTreeView;
 class WebURL;
 class WebURLResponse;
 struct WebURLError;
@@ -52,6 +53,18 @@
 
 // Returns the root directory of the WebKit code.
 virtual WebString webKitRootDir() { return WebString(); }
+
+// Constructs a WebLayerTreeView set up with reasonable defaults for
+// testing. A LayerTreeTypeUnitTest view can initialize and perform most
+// operations, but is not capable of rendering pixels. A
+// LayerTreeTypeLayoutTest view can render.
+
+#define HAVE_CREATELAYERTREEVIEWFORTESTING 1
+enum TestViewType {
+TestViewTypeUnitTest,
+TestViewTypeLayoutTest
+};
+virtual WebLayerTreeView* createLayerTreeViewForTesting(TestViewType type) { return 0; }
 };
 
 }


Modified: trunk/Source/WebKit/chromium/ChangeLog (142567 => 142568)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-12 02:38:54 UTC (rev 142567)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-12 02:50:58 UTC (rev 142568)
@@ -1,3 +1,15 @@
+2013-02-11  James Robinson  jam...@chromium.org
+
+[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
+

[webkit-changes] [142581] trunk/Source

[jamesr]

Title: [142581] trunk/Source








Revision 142581
Author jam...@google.com
Date 2013-02-11 22:42:53 -0800 (Mon, 11 Feb 2013)


Log Message
[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=109403

Reviewed by Adam Barth.

Source/Platform:

webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
thing.

* chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):
* chromium/public/WebUnitTestSupport.h:
(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):

Source/WebKit/chromium:

* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
* tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::FakeWebViewClient::initializeLayerTreeView):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebCompositorSupport.h
trunk/Source/Platform/chromium/public/WebUnitTestSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp
trunk/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (142580 => 142581)

--- trunk/Source/Platform/ChangeLog	2013-02-12 06:30:19 UTC (rev 142580)
+++ trunk/Source/Platform/ChangeLog	2013-02-12 06:42:53 UTC (rev 142581)
@@ -1,3 +1,21 @@
+2013-02-11  James Robinson  jam...@chromium.org
+
+[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
+https://bugs.webkit.org/show_bug.cgi?id=109403
+
+Reviewed by Adam Barth.
+
+webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
+thing.
+
+* chromium/public/WebCompositorSupport.h:
+(WebCompositorSupport):
+(WebKit::WebCompositorSupport::createLayerTreeView):
+* chromium/public/WebUnitTestSupport.h:
+(WebKit):
+(WebUnitTestSupport):
+(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):
+
 2013-02-11  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r142568.


Modified: trunk/Source/Platform/chromium/public/WebCompositorSupport.h (142580 => 142581)

--- trunk/Source/Platform/chromium/public/WebCompositorSupport.h	2013-02-12 06:30:19 UTC (rev 142580)
+++ trunk/Source/Platform/chromium/public/WebCompositorSupport.h	2013-02-12 06:42:53 UTC (rev 142581)
@@ -69,9 +69,6 @@
 // after shutdown.
 virtual void shutdown() { }
 
-// May return 0 if initialization fails.
-virtual WebLayerTreeView* createLayerTreeView(WebLayerTreeViewClient*, const WebLayer root, const WebLayerTreeView::Settings) { return 0; }
-
 // Creates an output surface for the compositor backed by a 3d context.
 virtual WebCompositorOutputSurface* createOutputSurfaceFor3D(WebKit::WebGraphicsContext3D*) { return 0; }
 
@@ -107,6 +104,13 @@
 
 virtual WebTransformOperations* createTransformOperations() { return 0; }
 
+
+// Testing --
+
+// DEPRECATED
+// May return 0 if initialization fails.
+virtual WebLayerTreeView* createLayerTreeView(WebLayerTreeViewClient*, const WebLayer root, const WebLayerTreeView::Settings) { return 0; }
+
 protected:
 virtual ~WebCompositorSupport() { }
 };


Modified: trunk/Source/Platform/chromium/public/WebUnitTestSupport.h (142580 => 142581)

--- trunk/Source/Platform/chromium/public/WebUnitTestSupport.h	2013-02-12 06:30:19 UTC (rev 142580)
+++ trunk/Source/Platform/chromium/public/WebUnitTestSupport.h	2013-02-12 06:42:53 UTC (rev 142581)
@@ -31,6 +31,7 @@
 
 namespace WebKit {
 
+class WebLayerTreeView;
 class WebURL;
 class WebURLResponse;
 struct WebURLError;
@@ -52,6 +53,18 @@
 
 // Returns the root directory of the WebKit code.
 virtual WebString webKitRootDir() { return WebString(); }
+
+// Constructs a WebLayerTreeView set up with reasonable defaults for
+// testing. A LayerTreeTypeUnitTest view can initialize and perform most
+// operations, but is not capable of rendering pixels. A
+// LayerTreeTypeLayoutTest view can render.
+
+#define HAVE_CREATELAYERTREEVIEWFORTESTING 1
+enum TestViewType {
+TestViewTypeUnitTest,
+TestViewTypeLayoutTest
+};
+virtual WebLayerTreeView* createLayerTreeViewForTesting(TestViewType type) { return 0; }
 };
 
 }


Modified: trunk/Source/WebKit/chromium/ChangeLog (142580 => 142581)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-12 06:30:19 UTC (rev 142580)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-12 06:42:53 UTC (rev 142581)
@@ -1,3 +1,15 @@
+2013-02-11  James Robinson  jam...@chromium.org
+
+[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
+

[webkit-changes] [142386] trunk/LayoutTests

[jamesr]

Title: [142386] trunk/LayoutTests








Revision 142386
Author jam...@google.com
Date 2013-02-09 22:26:44 -0800 (Sat, 09 Feb 2013)


Log Message
Chromium gardening

* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (142385 => 142386)

--- trunk/LayoutTests/ChangeLog	2013-02-10 06:11:14 UTC (rev 142385)
+++ trunk/LayoutTests/ChangeLog	2013-02-10 06:26:44 UTC (rev 142386)
@@ -1,3 +1,10 @@
+2013-02-09  James Robinson  jam...@chromium.org
+
+Chromium gardening
+
+* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
+* platform/chromium/TestExpectations:
+
 2013-02-09  Dominic Mazzoni  dmazz...@google.com
 
 fast/encoding/parser-tests-*.html tests sometimes crash


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (142385 => 142386)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-10 06:11:14 UTC (rev 142385)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-10 06:26:44 UTC (rev 142386)
@@ -2173,7 +2173,6 @@
 crbug.com/148638  [ Android ] svg/hixie/perf/001.xml [ Failure ImageOnlyFailure ]
 crbug.com/148638  [ Android ] svg/hixie/perf/002.xml [ Failure ImageOnlyFailure ]
 crbug.com/148638  [ Android ] svg/transforms/text-with-pattern-inside-transformed-html.xhtml [ Failure ImageOnlyFailure ]
-crbug.com/148638  [ Mac ] svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html [ Pass Timeout ]
 crbug.com/148638  [ Mac ] svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html [ Pass Timeout ImageOnlyFailure ]
 crbug.com/148638  [ Android ] svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html [ Failure ImageOnlyFailure ]
  


Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [142388] trunk/Source/Platform

[jamesr]

Title: [142388] trunk/Source/Platform








Revision 142388
Author jam...@google.com
Date 2013-02-09 23:09:15 -0800 (Sat, 09 Feb 2013)


Log Message
[chromium] Enable more of webkit_unit_tests in component builds
https://bugs.webkit.org/show_bug.cgi?id=109369

Reviewed by Darin Fisher.

Add a set of testing APIs to a WebUnitTestSupport interface available off of Platform for unit tests to access
in component builds.

* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::unitTestSupport):
* chromium/public/WebUnitTestSupport.h: Added.
(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::registerMockedURL):
(WebKit::WebUnitTestSupport::registerMockedErrorURL):
(WebKit::WebUnitTestSupport::unregisterMockedURL):
(WebKit::WebUnitTestSupport::unregisterAllMockedURLs):
(WebKit::WebUnitTestSupport::serveAsynchronousMockedRequests):
(WebKit::WebUnitTestSupport::webKitRootDir):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/Platform.h


Added Paths

trunk/Source/Platform/chromium/public/WebUnitTestSupport.h




Diff

Modified: trunk/Source/Platform/ChangeLog (142387 => 142388)

--- trunk/Source/Platform/ChangeLog	2013-02-10 06:41:34 UTC (rev 142387)
+++ trunk/Source/Platform/ChangeLog	2013-02-10 07:09:15 UTC (rev 142388)
@@ -1,3 +1,27 @@
+2013-02-09  James Robinson  jam...@chromium.org
+
+[chromium] Enable more of webkit_unit_tests in component builds
+https://bugs.webkit.org/show_bug.cgi?id=109369
+
+Reviewed by Darin Fisher.
+
+Add a set of testing APIs to a WebUnitTestSupport interface available off of Platform for unit tests to access
+in component builds.
+
+* chromium/public/Platform.h:
+(WebKit):
+(Platform):
+(WebKit::Platform::unitTestSupport):
+* chromium/public/WebUnitTestSupport.h: Added.
+(WebKit):
+(WebUnitTestSupport):
+(WebKit::WebUnitTestSupport::registerMockedURL):
+(WebKit::WebUnitTestSupport::registerMockedErrorURL):
+(WebKit::WebUnitTestSupport::unregisterMockedURL):
+(WebKit::WebUnitTestSupport::unregisterAllMockedURLs):
+(WebKit::WebUnitTestSupport::serveAsynchronousMockedRequests):
+(WebKit::WebUnitTestSupport::webKitRootDir):
+
 2013-02-08  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Removing the deprecated WebMediaStreamDescriptor and WebMediaStreamComponent shims


Modified: trunk/Source/Platform/chromium/public/Platform.h (142387 => 142388)

--- trunk/Source/Platform/chromium/public/Platform.h	2013-02-10 06:41:34 UTC (rev 142387)
+++ trunk/Source/Platform/chromium/public/Platform.h	2013-02-10 07:09:15 UTC (rev 142388)
@@ -67,13 +67,14 @@
 class WebSandboxSupport;
 class WebSocketStreamHandle;
 class WebStorageNamespace;
+class WebUnitTestSupport;
 class WebThemeEngine;
 class WebThread;
 class WebURL;
 class WebURLLoader;
 class WebWorkerRunLoop;
+struct WebFloatPoint;
 struct WebLocalizedString;
-struct WebFloatPoint;
 struct WebSize;
 
 class Platform {
@@ -360,6 +361,13 @@
 virtual void callOnMainThread(void (*func)(void*), void* context) { }
 
 
+// Testing -
+
+#define HAVE_WEBUNITTESTSUPPORT 1
+// Get a pointer to testing support interfaces. Will not be available in production builds.
+virtual WebUnitTestSupport* unitTestSupport() { return 0; }
+
+
 // Tracing -
 
 // Get a pointer to the enabled state of the given trace category. The


Added: trunk/Source/Platform/chromium/public/WebUnitTestSupport.h (0 => 142388)

--- trunk/Source/Platform/chromium/public/WebUnitTestSupport.h	(rev 0)
+++ trunk/Source/Platform/chromium/public/WebUnitTestSupport.h	2013-02-10 07:09:15 UTC (rev 142388)
@@ -0,0 +1,59 @@
+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS AS IS AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 

[webkit-changes] [141920] trunk/Source/Platform

[jamesr]

Title: [141920] trunk/Source/Platform








Revision 141920
Author jam...@google.com
Date 2013-02-05 13:04:09 -0800 (Tue, 05 Feb 2013)


Log Message
[chromium] Remove optionalness of second parameter to WebLayerTreeView::setViewportSize
https://bugs.webkit.org/show_bug.cgi?id=108972

Reviewed by Adam Barth.

This was added to ease the transition of adding this parameter, but it's now always set.

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebLayerTreeView.h




Diff

Modified: trunk/Source/Platform/ChangeLog (141919 => 141920)

--- trunk/Source/Platform/ChangeLog	2013-02-05 20:58:23 UTC (rev 141919)
+++ trunk/Source/Platform/ChangeLog	2013-02-05 21:04:09 UTC (rev 141920)
@@ -1,3 +1,15 @@
+2013-02-05  James Robinson  jam...@chromium.org
+
+[chromium] Remove optionalness of second parameter to WebLayerTreeView::setViewportSize
+https://bugs.webkit.org/show_bug.cgi?id=108972
+
+Reviewed by Adam Barth.
+
+This was added to ease the transition of adding this parameter, but it's now always set.
+
+* chromium/public/WebLayerTreeView.h:
+(WebLayerTreeView):
+
 2013-02-02  Michael Nordman  micha...@google.com
 
 [chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.


Modified: trunk/Source/Platform/chromium/public/WebLayerTreeView.h (141919 => 141920)

--- trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2013-02-05 20:58:23 UTC (rev 141919)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2013-02-05 21:04:09 UTC (rev 141920)
@@ -96,7 +96,7 @@
 
 // View properties ---
 
-virtual void setViewportSize(const WebSize layoutViewportSize, const WebSize deviceViewportSize = WebSize()) = 0;
+virtual void setViewportSize(const WebSize layoutViewportSize, const WebSize deviceViewportSize) = 0;
 // Gives the viewport size in layer space.
 virtual WebSize layoutViewportSize() const = 0;
 // Gives the viewport size in physical device pixels (may be different






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140716] trunk/Source/WebKit/chromium

[jamesr]

Title: [140716] trunk/Source/WebKit/chromium








Revision 140716
Author jam...@google.com
Date 2013-01-24 13:31:00 -0800 (Thu, 24 Jan 2013)


Log Message
[chromium] Null check WebLayerTreeView before dereffing in WebViewImpl::invalidateRect
https://bugs.webkit.org/show_bug.cgi?id=107855

Reviewed by Adrienne Walker.

During frame shutdown, WebViewImpl::m_layerTreeView may become 0 while commits are deferred but we still
may get invalidateRect() calls before shutdown completes.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::invalidateRect):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (140715 => 140716)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-24 21:16:32 UTC (rev 140715)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-24 21:31:00 UTC (rev 140716)
@@ -1,3 +1,16 @@
+2013-01-24  James Robinson  jam...@chromium.org
+
+[chromium] Null check WebLayerTreeView before dereffing in WebViewImpl::invalidateRect
+https://bugs.webkit.org/show_bug.cgi?id=107855
+
+Reviewed by Adrienne Walker.
+
+During frame shutdown, WebViewImpl::m_layerTreeView may become 0 while commits are deferred but we still
+may get invalidateRect() calls before shutdown completes.
+
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::invalidateRect):
+
 2013-01-24  Mihai Maerean  mmaer...@adobe.com
 
 [CSSRegions] remove setExperimentalCSSRegionsEnabled deprecated API in Source/WebKit/chromium/public/WebSettings.h


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (140715 => 140716)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-01-24 21:16:32 UTC (rev 140715)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-01-24 21:31:00 UTC (rev 140716)
@@ -3957,7 +3957,8 @@
 if (m_layerTreeViewCommitsDeferred) {
 // If we receive an invalidation from WebKit while in deferred commit mode,
 // that means it's time to start producing frames again so un-defer.
-m_layerTreeView-setDeferCommits(false);
+if (m_layerTreeView)
+m_layerTreeView-setDeferCommits(false);
 m_layerTreeViewCommitsDeferred = false;
 }
 if (m_isAcceleratedCompositingActive) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140732] trunk/Source/WebCore

[jamesr]

Title: [140732] trunk/Source/WebCore








Revision 140732
Author jam...@google.com
Date 2013-01-24 15:14:42 -0800 (Thu, 24 Jan 2013)


Log Message
REGRESSION(140571): Crash in ScrollingCoordinator::mainThreadScrollingReasons during Frame::createView
https://bugs.webkit.org/show_bug.cgi?id=107868

Reviewed by Beth Dakin.

When using fixed layout mode, it's possible to update the scrollbar state of the main FrameView before
it's set on the main frame, which can lead to calling in to ScrollingCoordinator to compute main thread
scrolling regions when m_page-mainFrame()-view() is 0. In this case, we don't have any main
thread scrolling reasons and should just return 0.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (140731 => 140732)

--- trunk/Source/WebCore/ChangeLog	2013-01-24 23:01:06 UTC (rev 140731)
+++ trunk/Source/WebCore/ChangeLog	2013-01-24 23:14:42 UTC (rev 140732)
@@ -1,3 +1,18 @@
+2013-01-24  James Robinson  jam...@chromium.org
+
+REGRESSION(140571): Crash in ScrollingCoordinator::mainThreadScrollingReasons during Frame::createView
+https://bugs.webkit.org/show_bug.cgi?id=107868
+
+Reviewed by Beth Dakin.
+
+When using fixed layout mode, it's possible to update the scrollbar state of the main FrameView before
+it's set on the main frame, which can lead to calling in to ScrollingCoordinator to compute main thread
+scrolling regions when m_page-mainFrame()-view() is 0. In this case, we don't have any main
+thread scrolling reasons and should just return 0.
+
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
+
 2013-01-24  Martin Robinson  mrobin...@igalia.com
 
 Abstract the logic for appending a UChar32 onto StringBuilder


Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (140731 => 140732)

--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2013-01-24 23:01:06 UTC (rev 140731)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2013-01-24 23:14:42 UTC (rev 140732)
@@ -449,6 +449,8 @@
 MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons() const
 {
 FrameView* frameView = m_page-mainFrame()-view();
+if (!frameView)
+return static_castMainThreadScrollingReasons(0);
 
 MainThreadScrollingReasons mainThreadScrollingReasons = (MainThreadScrollingReasons)0;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139385] trunk

[jamesr]

Title: [139385] trunk








Revision 139385
Author jam...@google.com
Date 2013-01-10 16:07:22 -0800 (Thu, 10 Jan 2013)


Log Message
[chromium] Store scrollable layer's contents size for coordinated scrollable layers
https://bugs.webkit.org/show_bug.cgi?id=106518

Reviewed by Adrienne Walker.

Source/WebCore:

This stores a scrollable layer's contentsSize in the scroll layer's bounds, which is otherwise not useful. This
value is currently calculated based on fragile knowledge of the tree structure immediately beneath a scrollable
layer.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):

LayoutTests:

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (139384 => 139385)

--- trunk/LayoutTests/ChangeLog	2013-01-11 00:01:42 UTC (rev 139384)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 00:07:22 UTC (rev 139385)
@@ -1,3 +1,12 @@
+2013-01-10  James Robinson  jam...@chromium.org
+
+[chromium] Store scrollable layer's contents size for coordinated scrollable layers
+https://bugs.webkit.org/show_bug.cgi?id=106518
+
+Reviewed by Adrienne Walker.
+
+* platform/chromium/TestExpectations:
+
 2013-01-10  Michael Pruett  mich...@68k.org
 
 IndexedDB: Update expected results for IndexedDB layout tests


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139384 => 139385)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 00:01:42 UTC (rev 139384)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 00:07:22 UTC (rev 139385)
@@ -3124,8 +3124,6 @@
 webkit.org/b/81145 [ Lion MountainLion ] platform/chromium/virtual/softwarecompositing/plugins/composited-plugin.html [ Failure ]
 webkit.org/b/81145 [ Lion MountainLion ] fast/repaint/transform-absolute-in-positioned-container.html [ Failure ]
 webkit.org/b/81145 [ Lion MountainLion ] animations/cross-fade-webkit-mask-box-image.html [ ImageOnlyFailure ]
-webkit.org/b/81145 [ Lion MountainLion ] compositing/iframes/iframe-content-flipping.html [ ImageOnlyFailure ]
-webkit.org/b/81145 [ Lion MountainLion ] platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html [ ImageOnlyFailure ]
 webkit.org/b/81145 [ Lion MountainLion ] fast/frames/invalid.html [ Failure ImageOnlyFailure Pass Slow ]
 webkit.org/b/81145 [ Lion MountainLion ] fast/repaint/background-scaling.html [ ImageOnlyFailure ]
 webkit.org/b/81145 [ Lion MountainLion ] fast/repaint/scale-page-shrink.html [ ImageOnlyFailure ]
@@ -4113,6 +4111,8 @@
 
 webkit.org/b/104993 [ XP ] fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html [ Failure ]
 
+webkit.org/b/106518 compositing/iframes/iframe-content-flipping.html [ ImageOnlyFailure ]
+webkit.org/b/106518 platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html [ ImageOnlyFailure ]
 
 webkit.org/b/101539 [ Linux Win ] editing/execCommand/switch-list-type-with-orphaned-li.html [ Failure ]
 


Modified: trunk/Source/WebCore/ChangeLog (139384 => 139385)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 00:01:42 UTC (rev 139384)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 00:07:22 UTC (rev 139385)
@@ -1,3 +1,17 @@
+2013-01-10  James Robinson  jam...@chromium.org
+
+[chromium] Store scrollable layer's contents size for coordinated scrollable layers
+https://bugs.webkit.org/show_bug.cgi?id=106518
+
+Reviewed by Adrienne Walker.
+
+This stores a scrollable layer's contentsSize in the scroll layer's bounds, which is otherwise not useful. This
+value is currently calculated based on fragile knowledge of the tree structure immediately beneath a scrollable
+layer.
+
+* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
+(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):
+
 2013-01-10  Dan Beam  db...@chromium.org
 
 Implement AutocompleteErrorEvent#reason


Modified: trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp (139384 => 139385)

--- trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp	2013-01-11 00:01:42 UTC (rev 139384)
+++ trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp	2013-01-11 00:07:22 UTC (rev 139385)
@@ -106,7 +106,7 @@
 delete m_private;
 }
 
-void ScrollingCoordinatorChromium::frameViewLayoutUpdated(FrameView*)
+void ScrollingCoordinatorChromium::frameViewLayoutUpdated(FrameView* frameView)
 {
 ASSERT(m_page);
 
@@ -121,6 +121,8 @@
 computeAbsoluteTouchEventTargetRects(m_page-mainFrame()-document(), touchEventTargetRects);
 setTouchEventTargetRects(touchEventTargetRects);
 #endif
+if 

[webkit-changes] [138859] trunk/Source/WebKit/chromium

[jamesr]

Title: [138859] trunk/Source/WebKit/chromium








Revision 138859
Author jam...@google.com
Date 2013-01-04 15:21:00 -0800 (Fri, 04 Jan 2013)


Log Message
[chromium] Remove WebWidget::layerTreeView(), ownership is the other way around
https://bugs.webkit.org/show_bug.cgi?id=106139

Reviewed by Adrienne Walker.

This was added with the thought that it would be useful for transitioning code for a world where the
WebLayerTreeView for a given widget was owned by the WebWidgetClient instead of the WebWidget, but as it turns
out we've transitioned without every adding any callers to this.

* public/WebWidget.h:
(WebWidget):
* src/WebViewImpl.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (138858 => 138859)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-04 23:15:40 UTC (rev 138858)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-04 23:21:00 UTC (rev 138859)
@@ -1,3 +1,18 @@
+2013-01-04  James Robinson  jam...@chromium.org
+
+[chromium] Remove WebWidget::layerTreeView(), ownership is the other way around
+https://bugs.webkit.org/show_bug.cgi?id=106139
+
+Reviewed by Adrienne Walker.
+
+This was added with the thought that it would be useful for transitioning code for a world where the
+WebLayerTreeView for a given widget was owned by the WebWidgetClient instead of the WebWidget, but as it turns
+out we've transitioned without every adding any callers to this.
+
+* public/WebWidget.h:
+(WebWidget):
+* src/WebViewImpl.cpp:
+
 2013-01-04  Dana Jansens  dan...@chromium.org
 
 [chromium] Remove lost-compositor-context layout tests


Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (138858 => 138859)

--- trunk/Source/WebKit/chromium/public/WebWidget.h	2013-01-04 23:15:40 UTC (rev 138858)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h	2013-01-04 23:21:00 UTC (rev 138859)
@@ -134,10 +134,6 @@
 // ready to use.
 virtual void setCompositorSurfaceReady() = 0;
 
-// Returns this widget's WebLayerTreeView if compositing is active, nil
-// otherwise.
-virtual WebLayerTreeView* layerTreeView() { return 0; }
-
 // Temporary method for the embedder to notify the WebWidget that the widget
 // has taken damage, e.g. due to a window expose. This method will be
 // removed when the WebWidget inversion patch lands --- http://crbug.com/112837


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (138858 => 138859)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-01-04 23:15:40 UTC (rev 138858)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-01-04 23:21:00 UTC (rev 138859)
@@ -1733,11 +1733,6 @@
 m_layerTreeView-setSurfaceReady();
 }
 
-WebLayerTreeView* WebViewImpl::webLayerTreeView()
-{
-return m_layerTreeView;
-}
-
 void WebViewImpl::animate(double)
 {
 #if ENABLE(REQUEST_ANIMATION_FRAME)


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (138858 => 138859)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.h	2013-01-04 23:15:40 UTC (rev 138858)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h	2013-01-04 23:21:00 UTC (rev 138859)
@@ -142,7 +142,6 @@
 virtual void willExitFullScreen();
 virtual void didExitFullScreen();
 virtual void setCompositorSurfaceReady();
-virtual WebLayerTreeView* webLayerTreeView();
 virtual void animate(double);
 virtual void layout(); // Also implements WebLayerTreeViewClient::layout()
 virtual void enterForceCompositingMode(bool enable) OVERRIDE;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137616] trunk/Source

[jamesr]

Title: [137616] trunk/Source








Revision 137616
Author jam...@google.com
Date 2012-12-13 10:52:58 -0800 (Thu, 13 Dec 2012)


Log Message
Check whether a touchDown lands on a registered touch event handler from the compositor
https://bugs.webkit.org/show_bug.cgi?id=104863

Patch by Yusuf Ozuysal yus...@google.com on 2012-12-13
Reviewed by James Robinson.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):

Modified Paths

trunk/Source/Platform/chromium/public/WebInputHandlerClient.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp
trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp




Diff

Modified: trunk/Source/Platform/chromium/public/WebInputHandlerClient.h (137615 => 137616)

--- trunk/Source/Platform/chromium/public/WebInputHandlerClient.h	2012-12-13 18:48:43 UTC (rev 137615)
+++ trunk/Source/Platform/chromium/public/WebInputHandlerClient.h	2012-12-13 18:52:58 UTC (rev 137616)
@@ -73,6 +73,10 @@
 // Request another callback to WebInputHandler::animate().
 virtual void scheduleAnimation() = 0;
 
+// Returns whether there are any touch event handlers registered on the
+// given WebPoint.
+virtual bool haveTouchEventHandlersAt(WebPoint) = 0;
+
 // Indicate that the final input event for the current vsync interval was received.
 virtual void didReceiveLastInputEventForVSync() { }
 


Modified: trunk/Source/WebKit/chromium/ChangeLog (137615 => 137616)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-13 18:48:43 UTC (rev 137615)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-13 18:52:58 UTC (rev 137616)
@@ -1,3 +1,13 @@
+2012-12-13  Yusuf Ozuysal  yus...@google.com
+
+Check whether a touchDown lands on a registered touch event handler from the compositor
+https://bugs.webkit.org/show_bug.cgi?id=104863
+
+Reviewed by James Robinson.
+
+* src/WebCompositorInputHandlerImpl.cpp:
+(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
+
 2012-12-07  Levi Weintraub  le...@chromium.org
 
 Add support for tracking hit test rectangles to enable fast event rejection in the compositor


Modified: trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp (137615 => 137616)

--- trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2012-12-13 18:48:43 UTC (rev 137615)
+++ trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2012-12-13 18:52:58 UTC (rev 137616)
@@ -198,6 +198,12 @@
 } else if (event.type == WebInputEvent::GestureFlingCancel) {
 if (cancelCurrentFling())
 return DidHandle;
+#if ENABLE(TOUCH_EVENT_TRACKING)
+} else if (event.type == WebInputEvent::TouchStart) {
+const WebTouchEvent touchEvent = *static_castconst WebTouchEvent*(event);
+if (!m_inputHandlerClient-haveTouchEventHandlersAt(touchEvent.touches[0].position))
+return DropEvent;
+#endif
 } else if (WebInputEvent::isKeyboardEventType(event.type)) {
  cancelCurrentFling();
 }


Modified: trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp (137615 => 137616)

--- trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp	2012-12-13 18:48:43 UTC (rev 137615)
+++ trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp	2012-12-13 18:52:58 UTC (rev 137616)
@@ -58,6 +58,8 @@
 
 MOCK_METHOD0(scheduleAnimation, void());
 
+MOCK_METHOD1(haveTouchEventHandlersAt, bool(WebPoint));
+
 MOCK_METHOD2(scrollBegin, ScrollStatus(WebPoint, WebInputHandlerClient::ScrollInputType));
 MOCK_METHOD2(scrollByIfPossible, bool(WebPoint, WebSize));
 MOCK_METHOD0(scrollEnd, void());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [134857] trunk/LayoutTests

[jamesr]

Title: [134857] trunk/LayoutTests








Revision 134857
Author jam...@google.com
Date 2012-11-15 16:39:27 -0800 (Thu, 15 Nov 2012)


Log Message
Clean up some TestExpectations for tests that pass now.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (134856 => 134857)

--- trunk/LayoutTests/ChangeLog	2012-11-16 00:37:58 UTC (rev 134856)
+++ trunk/LayoutTests/ChangeLog	2012-11-16 00:39:27 UTC (rev 134857)
@@ -1,3 +1,9 @@
+2012-11-15  James Robinson  jam...@chromium.org
+
+Clean up some TestExpectations for tests that pass now.
+
+* platform/chromium/TestExpectations:
+
 2012-11-15  David Grogan  dgro...@chromium.org
 
 IndexedDB setVersion-removal batch 7


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (134856 => 134857)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-11-16 00:37:58 UTC (rev 134856)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-11-16 00:39:27 UTC (rev 134857)
@@ -3903,12 +3903,8 @@
 webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-video-layer.html [ ImageOnlyFailure Pass ]
 webkit.org/b/98086 [ Win Mac Linux ] platform/chromium/virtual/threaded/compositing/visibility/visibility-composited.html [ ImageOnlyFailure Pass ]
 webkit.org/b/98086 [ Win Mac Linux ] platform/chromium/virtual/threaded/compositing/visibility/layer-visible-content.html [ ImageOnlyFailure Pass ]
-webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/webgl/webgl-nonpremultiplied-blend.html [ Crash Pass ]
-webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/webgl/webgl-no-alpha.html [ Crash Pass ]
-webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/webgl/webgl-reflection.html [ Crash Pass ]
-webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/webgl/webgl-repaint.html [ Crash Pass ]
-webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html [ ImageOnlyFailure Crash Pass ]
-webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-canvas2d-layer.html [ ImageOnlyFailure Crash Pass ]
+webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html [ ImageOnlyFailure Pass ]
+webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-canvas2d-layer.html [ ImageOnlyFailure Pass ]
 
 webkit.org/b/98087 [ Linux ] fast/css/lang-mapped-to-webkit-locale-dynamic.xhtml [ Failure Pass ]
 
@@ -4179,7 +4175,6 @@
 webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html [ Pass Image ]
 webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping.html [ Pass Image ]
 webkit.org/b/102131 [ Win ] fast/workers/worker-exception-during-navigation.html [ Pass Crash ]
-webkit.org/b/102247 platform/chromium/virtual/threaded/compositing/webgl/webgl-background-color.html [ ImageOnlyFailure ]
 webkit.org/b/102264 [ Debug ] css3/filters/custom/custom-filter-property-computed-style.html [ Pass Timeout ]
 webkit.org/b/102277 fast/events/frame-scroll-fake-mouse-move.html [ Pass Text ]
 webkit.org/b/102277 fast/events/overflow-scroll-fake-mouse-move.html [ Pass Text ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [134502] trunk/LayoutTests

[jamesr]

Title: [134502] trunk/LayoutTests








Revision 134502
Author jam...@google.com
Date 2012-11-13 15:56:54 -0800 (Tue, 13 Nov 2012)


Log Message
Rebaselines for filtering changes due to chromium r167479

* platform/chromium-linux/compositing/checkerboard-expected.png: Added.
* platform/chromium-mac/compositing/checkerboard-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
* platform/chromium-win/compositing/checkerboard-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-linux/compositing/checkerboard-expected.png
trunk/LayoutTests/platform/chromium-mac/compositing/checkerboard-expected.png
trunk/LayoutTests/platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png
trunk/LayoutTests/platform/chromium-win/compositing/checkerboard-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (134501 => 134502)

--- trunk/LayoutTests/ChangeLog	2012-11-13 23:55:07 UTC (rev 134501)
+++ trunk/LayoutTests/ChangeLog	2012-11-13 23:56:54 UTC (rev 134502)
@@ -1,3 +1,13 @@
+2012-11-13  James Robinson  jam...@chromium.org
+
+Rebaselines for filtering changes due to chromium r167479
+
+* platform/chromium-linux/compositing/checkerboard-expected.png: Added.
+* platform/chromium-mac/compositing/checkerboard-expected.png: Added.
+* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
+* platform/chromium-win/compositing/checkerboard-expected.png: Added.
+* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png:
+
 2012-11-13  Chris Fleizach  cfleiz...@apple.com
 
 AX: MathML types need to be semantically identified in AX tree


Added: trunk/LayoutTests/platform/chromium-linux/compositing/checkerboard-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/compositing/checkerboard-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac/compositing/checkerboard-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/compositing/checkerboard-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-win/compositing/checkerboard-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/compositing/checkerboard-expected.png
___

Added: svn:mime-type

Modified: trunk/LayoutTests/platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [133516] trunk/Source

[jamesr]

Title: [133516] trunk/Source








Revision 133516
Author jam...@google.com
Date 2012-11-05 12:49:05 -0800 (Mon, 05 Nov 2012)


Log Message
[chromium] Use const SkBitmap parameter for WebLayerTreeView::setFontAtlas
https://bugs.webkit.org/show_bug.cgi?id=101016

Reviewed by Adrienne Walker.

Passing SkBitmap by value requires including SkBitmap.h, which is tricky for some clients to do since it
requires having the rest of skia's headers on the include path and setting up the correct config to set
preprocessor defines.  Also shuffles the parameter order around to make rolling easier since you can't override
just by const ref-ness.

* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::setFontAtlas):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebLayerTreeView.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (133515 => 133516)

--- trunk/Source/Platform/ChangeLog	2012-11-05 20:40:13 UTC (rev 133515)
+++ trunk/Source/Platform/ChangeLog	2012-11-05 20:49:05 UTC (rev 133516)
@@ -1,3 +1,18 @@
+2012-11-05  James Robinson  jam...@chromium.org
+
+[chromium] Use const SkBitmap parameter for WebLayerTreeView::setFontAtlas
+https://bugs.webkit.org/show_bug.cgi?id=101016
+
+Reviewed by Adrienne Walker.
+
+Passing SkBitmap by value requires including SkBitmap.h, which is tricky for some clients to do since it
+requires having the rest of skia's headers on the include path and setting up the correct config to set
+preprocessor defines.  Also shuffles the parameter order around to make rolling easier since you can't override
+just by const ref-ness.
+
+* chromium/public/WebLayerTreeView.h:
+(WebKit::WebLayerTreeView::setFontAtlas):
+
 2012-11-05  Alok Priyadarshi  al...@chromium.org
 
 [chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents


Modified: trunk/Source/Platform/chromium/public/WebLayerTreeView.h (133515 => 133516)

--- trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2012-11-05 20:40:13 UTC (rev 133515)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2012-11-05 20:49:05 UTC (rev 133516)
@@ -26,7 +26,6 @@
 #ifndef WebLayerTreeView_h
 #define WebLayerTreeView_h
 
-#include SkBitmap.h
 #include WebColor.h
 #include WebCommon.h
 #include WebFloatPoint.h
@@ -34,6 +33,8 @@
 #include WebPrivateOwnPtr.h
 #include WebSize.h
 
+class SkBitmap;
+
 namespace WebKit {
 class WebGraphicsContext3D;
 class WebLayer;
@@ -170,7 +171,7 @@
 
 // Provides a font atlas to use for debug visualizations. The atlas must be a bitmap containing glyph data, a table of
 // ASCII character values to a subrectangle of the atlas representing the corresponding glyph, and the glyph height.
-virtual void setFontAtlas(SkBitmap, WebRect asciiToRectTable[128], int fontHeight) = 0;
+virtual void setFontAtlas(WebRect asciiToRectTable[128], const SkBitmap, int fontHeight) { }
 
 // Simulates a lost context. For testing only.
 virtual void loseCompositorContext(int numTimes) = 0;


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (133515 => 133516)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-11-05 20:40:13 UTC (rev 133515)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-11-05 20:49:05 UTC (rev 133516)
@@ -4003,7 +4003,7 @@
 WebRect asciiToRectTable[128];
 int fontHeight;
 SkBitmap bitmap = WebCore::CompositorHUDFontAtlas::generateFontAtlas(asciiToRectTable, fontHeight);
-m_layerTreeView-setFontAtlas(bitmap, asciiToRectTable, fontHeight);
+m_layerTreeView-setFontAtlas(asciiToRectTable, bitmap, fontHeight);
 }
 } else {
 m_nonCompositedContentHost.clear();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132862] trunk/Source/WebKit/chromium

[jamesr]

Title: [132862] trunk/Source/WebKit/chromium








Revision 132862
Author jam...@google.com
Date 2012-10-29 16:49:00 -0700 (Mon, 29 Oct 2012)


Log Message
[chromium] Defer commits between page unload and first invalidation in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=100702

Reviewed by Adrienne Walker.

In threaded compositing mode, it's not terribly useful to commit after unloading a page and before receiving
the first invalidation for the new page since the document is likely not loaded enough to paint usefully.
This defers commits from the time compositing is deactivated (which in force compositing mode only happens
at FrameView destruction) until we get the first invalidation from WebCore.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::invalidateContentsAndRootView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::invalidateRect):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (132861 => 132862)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-10-29 23:38:45 UTC (rev 132861)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-10-29 23:49:00 UTC (rev 132862)
@@ -1,3 +1,24 @@
+2012-10-29  James Robinson  jam...@chromium.org
+
+[chromium] Defer commits between page unload and first invalidation in threaded compositing mode
+https://bugs.webkit.org/show_bug.cgi?id=100702
+
+Reviewed by Adrienne Walker.
+
+In threaded compositing mode, it's not terribly useful to commit after unloading a page and before receiving
+the first invalidation for the new page since the document is likely not loaded enough to paint usefully.
+This defers commits from the time compositing is deactivated (which in force compositing mode only happens
+at FrameView destruction) until we get the first invalidation from WebCore.
+
+* src/ChromeClientImpl.cpp:
+(WebKit::ChromeClientImpl::invalidateContentsAndRootView):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::invalidateRect):
+(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
+(WebKit):
+* src/WebViewImpl.h:
+(WebViewImpl):
+
 2012-10-29  Stephen White  senorbla...@chromium.org
 
 Unreviewed.  Rolled DEPS.


Modified: trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp (132861 => 132862)

--- trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp	2012-10-29 23:38:45 UTC (rev 132861)
+++ trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp	2012-10-29 23:49:00 UTC (rev 132862)
@@ -495,15 +495,7 @@
 {
 if (updateRect.isEmpty())
 return;
-#if USE(ACCELERATED_COMPOSITING)
-if (!m_webView-isAcceleratedCompositingActive()) {
-#endif
-if (m_webView-client())
-m_webView-client()-didInvalidateRect(updateRect);
-#if USE(ACCELERATED_COMPOSITING)
-} else
-m_webView-invalidateRootLayerRect(updateRect);
-#endif
+m_webView-invalidateRect(updateRect);
 }
 
 void ChromeClientImpl::invalidateContentsForSlowScroll(const IntRect updateRect, bool immediate)


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (132861 => 132862)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-10-29 23:38:45 UTC (rev 132861)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-10-29 23:49:00 UTC (rev 132862)
@@ -419,6 +419,7 @@
 , m_rootLayer(0)
 , m_rootGraphicsLayer(0)
 , m_isAcceleratedCompositingActive(false)
+, m_layerTreeViewCommitsDeferred(false)
 , m_compositorCreationFailed(false)
 , m_recreatingGraphicsContext(false)
 , m_compositorSurfaceReady(false)
@@ -3830,17 +3831,26 @@
 updateLayerTreeViewport();
 }
 
-void WebViewImpl::invalidateRootLayerRect(const IntRect rect)
+void WebViewImpl::invalidateRect(const IntRect rect)
 {
-ASSERT(m_layerTreeView);
+if (m_layerTreeViewCommitsDeferred) {
+// If we receive an invalidation from WebKit while in deferred commit mode,
+// that means it's time to start producing frames again so un-defer.
+m_layerTreeView-setDeferCommits(false);
+m_layerTreeViewCommitsDeferred = false;
+}
+if (m_isAcceleratedCompositingActive) {
+ASSERT(m_layerTreeView);
 
-if (!page())
-return;
+if (!page())
+return;
 
-FrameView* view = page()-mainFrame()-view();
-IntRect dirtyRect = view-windowToContents(rect);
-updateLayerTreeViewport();
-m_nonCompositedContentHost-invalidateRect(dirtyRect);
+FrameView* view = page()-mainFrame()-view();
+IntRect dirtyRect = view-windowToContents(rect);
+updateLayerTreeViewport();
+m_nonCompositedContentHost-invalidateRect(dirtyRect);
+} 

[webkit-changes] [131692] trunk/Source/WebCore

[jamesr]

Title: [131692] trunk/Source/WebCore








Revision 131692
Author jam...@google.com
Date 2012-10-17 18:42:29 -0700 (Wed, 17 Oct 2012)


Log Message
Unreviewed clang compile fix - GraphicsLayerUpdater needs a virtual destructor.

* platform/graphics/GraphicsLayerUpdater.h:
(GraphicsLayerUpdater):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (131691 => 131692)

--- trunk/Source/WebCore/ChangeLog	2012-10-18 01:42:02 UTC (rev 131691)
+++ trunk/Source/WebCore/ChangeLog	2012-10-18 01:42:29 UTC (rev 131692)
@@ -1,3 +1,10 @@
+2012-10-17  James Robinson  jam...@chromium.org
+
+Unreviewed clang compile fix - GraphicsLayerUpdater needs a virtual destructor.
+
+* platform/graphics/GraphicsLayerUpdater.h:
+(GraphicsLayerUpdater):
+
 2012-10-17  Ryuan Choi  ryuan.c...@samsung.com
 
 Attempt to fix the build after r131680.


Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.h (131691 => 131692)

--- trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.h	2012-10-18 01:42:02 UTC (rev 131691)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.h	2012-10-18 01:42:29 UTC (rev 131692)
@@ -48,7 +48,7 @@
 {
 public:
 GraphicsLayerUpdater(GraphicsLayerUpdaterClient*, PlatformDisplayID);
-~GraphicsLayerUpdater();
+virtual ~GraphicsLayerUpdater();
 
 void scheduleUpdate();
 void screenDidChange(PlatformDisplayID);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [130802] trunk/Tools

[jamesr]

Title: [130802] trunk/Tools








Revision 130802
Author jam...@google.com
Date 2012-10-09 13:28:00 -0700 (Tue, 09 Oct 2012)


Log Message
Unreviewed, rolling out r128488.
http://trac.webkit.org/changeset/128488
https://bugs.webkit.org/show_bug.cgi?id=96678

The bot is fixed now

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (130801 => 130802)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js	2012-10-09 20:12:15 UTC (rev 130801)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js	2012-10-09 20:28:00 UTC (rev 130802)
@@ -86,9 +86,7 @@
 // FIXME: Should garden-o-matic show these? I can imagine showing the deps bots being useful at least so
 // that the gardener only need to look at garden-o-matic and never at the waterfall. Not really sure who
 // watches the GPU bots.
-return builderName.indexOf('GPU') == -1  builderName.indexOf('deps') == -1 
-   builderName.indexOf('ASAN') == -1  builderName.indexOf('Content Shell') == -1 
-   builderName.indexOf('Android Builder (dbg)') == -1; // This bot is sick right now - http://crbug.com/149014
+return builderName.indexOf('GPU') == -1  builderName.indexOf('deps') == -1  builderName.indexOf('ASAN') == -1  builderName.indexOf('Content Shell') == -1;
 },
 },
 'gtk' : {


Modified: trunk/Tools/ChangeLog (130801 => 130802)

--- trunk/Tools/ChangeLog	2012-10-09 20:12:15 UTC (rev 130801)
+++ trunk/Tools/ChangeLog	2012-10-09 20:28:00 UTC (rev 130802)
@@ -1,3 +1,14 @@
+2012-10-09  James Robinson  jam...@chromium.org
+
+Unreviewed, rolling out r128488.
+http://trac.webkit.org/changeset/128488
+https://bugs.webkit.org/show_bug.cgi?id=96678
+
+The bot is fixed now
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
+(.):
+
 2012-10-09  Zan Dobersek  zandober...@gmail.com
 
 XvfbDriver unit test is flaky on Linux builders






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128716] trunk/Source/WebCore

[jamesr]

Title: [128716] trunk/Source/WebCore








Revision 128716
Author jam...@google.com
Date 2012-09-16 21:41:11 -0700 (Sun, 16 Sep 2012)


Log Message
Chromium win build fix - listing a file that doesn't exist is a fatal errors in the msvs gyp generator.

* WebCore.gypi:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi




Diff

Modified: trunk/Source/WebCore/ChangeLog (128715 => 128716)

--- trunk/Source/WebCore/ChangeLog	2012-09-17 04:00:48 UTC (rev 128715)
+++ trunk/Source/WebCore/ChangeLog	2012-09-17 04:41:11 UTC (rev 128716)
@@ -1,3 +1,9 @@
+2012-09-16  James Robinson  jam...@chromium.org
+
+Chromium win build fix - listing a file that doesn't exist is a fatal errors in the msvs gyp generator.
+
+* WebCore.gypi:
+
 2012-09-16  Dan Bernstein  m...@apple.com
 
 REGRESSION (r126763): css1/pseudo/firstline.html fails when using the complex text code path


Modified: trunk/Source/WebCore/WebCore.gypi (128715 => 128716)

--- trunk/Source/WebCore/WebCore.gypi	2012-09-17 04:00:48 UTC (rev 128715)
+++ trunk/Source/WebCore/WebCore.gypi	2012-09-17 04:41:11 UTC (rev 128716)
@@ -591,7 +591,6 @@
 'rendering/style/BasicShapes.h',
 'rendering/style/BorderData.h',
 'rendering/style/BorderValue.h',
-'rendering/style/ClipPathOperation.h',
 'rendering/style/CollapsedBorderValue.h',
 'rendering/style/ContentData.h',
 'rendering/style/CounterContent.h',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128659] trunk/LayoutTests

[jamesr]

Title: [128659] trunk/LayoutTests








Revision 128659
Author jam...@google.com
Date 2012-09-14 15:21:31 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed gardening.

Update fixpos layout test results. Chromium currently doesn't set the fixpos-forms-stacking-context setting in
DumpRenderTree.

* fast/block/positioning/016-expected.png: Copied from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
* fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/025-expected.png.
* platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
* platform/chromium-linux-x86/fast/block/positioning/016-expected.txt: Added.
* platform/chromium-linux-x86/fast/block/positioning/025-expected.txt: Added.
* platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
* platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
* platform/chromium-linux/fast/block/positioning/016-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/016-expected.png.
* platform/chromium-linux/fast/block/positioning/016-expected.txt: Added.
* platform/chromium-linux/fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/025-expected.png.
* platform/chromium-linux/fast/block/positioning/025-expected.txt: Added.
* platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
* platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
* platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
* platform/chromium-mac/fast/block/positioning/016-expected.png: Added.
* platform/chromium-mac/fast/block/positioning/016-expected.txt: Added.
* platform/chromium-mac/fast/block/positioning/025-expected.png: Added.
* platform/chromium-mac/fast/block/positioning/025-expected.txt: Added.
* platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
* platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/block/positioning/016-expected.png
trunk/LayoutTests/fast/block/positioning/025-expected.png
trunk/LayoutTests/platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt
trunk/LayoutTests/platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/016-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/025-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt

[webkit-changes] [128681] trunk/LayoutTests

[jamesr]

Title: [128681] trunk/LayoutTests








Revision 128681
Author jam...@google.com
Date 2012-09-14 21:18:44 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed gardening - more position:fixed stacking context rebaselines.

* fast/block/positioning/016-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/016-expected.txt.
* fast/block/positioning/025-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/025-expected.txt.
* platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
* platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
* platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
* platform/chromium-mac/fast/block/positioning/016-expected.txt: Removed.
* platform/chromium-mac/fast/block/positioning/025-expected.txt: Removed.
* platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
* platform/chromium-win/fast/block/positioning/016-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.png.
* platform/chromium-win/fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.png.
* platform/chromium-win/fast/block/positioning/fixed-position-stacking-context-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png.
* platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt.
* platform/chromium/fast/block/positioning/016-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.txt.
* platform/chromium/fast/block/positioning/025-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.txt.
* platform/chromium/fast/block/positioning/fixed-position-stacking-context-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt.
* platform/efl/fast/block/positioning/016-expected.txt: Removed.
* platform/efl/fast/block/positioning/025-expected.txt: Removed.
* platform/gtk/fast/block/positioning/016-expected.txt: Removed.
* platform/gtk/fast/block/positioning/025-expected.txt: Removed.
* platform/qt/fast/block/positioning/016-expected.txt: Removed.
* platform/qt/fast/block/positioning/025-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/block/positioning/016-expected.txt
trunk/LayoutTests/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium/fast/block/positioning/fixed-position-stacking-context-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/block/positioning/016-expected.png
trunk/LayoutTests/platform/chromium-win/fast/block/positioning/025-expected.png
trunk/LayoutTests/platform/chromium-win/fast/block/positioning/fixed-position-stacking-context-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt

[webkit-changes] [128488] trunk/Tools

[jamesr]

Title: [128488] trunk/Tools








Revision 128488
Author jam...@google.com
Date 2012-09-13 12:06:00 -0700 (Thu, 13 Sep 2012)


Log Message
[chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
https://bugs.webkit.org/show_bug.cgi?id=96678

Reviewed by Dirk Pranke.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (128487 => 128488)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js	2012-09-13 18:41:49 UTC (rev 128487)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js	2012-09-13 19:06:00 UTC (rev 128488)
@@ -86,7 +86,9 @@
 // FIXME: Should garden-o-matic show these? I can imagine showing the deps bots being useful at least so
 // that the gardener only need to look at garden-o-matic and never at the waterfall. Not really sure who
 // watches the GPU bots.
-return builderName.indexOf('GPU') == -1  builderName.indexOf('deps') == -1  builderName.indexOf('ASAN') == -1  builderName.indexOf('Content Shell') == -1;
+return builderName.indexOf('GPU') == -1  builderName.indexOf('deps') == -1 
+   builderName.indexOf('ASAN') == -1  builderName.indexOf('Content Shell') == -1 
+   builderName.indexOf('Android Builder (dbg)') == -1; // This bot is sick right now - http://crbug.com/149014
 },
 },
 'gtk' : {


Modified: trunk/Tools/ChangeLog (128487 => 128488)

--- trunk/Tools/ChangeLog	2012-09-13 18:41:49 UTC (rev 128487)
+++ trunk/Tools/ChangeLog	2012-09-13 19:06:00 UTC (rev 128488)
@@ -1,3 +1,13 @@
+2012-09-13  James Robinson  jam...@chromium.org
+
+[chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
+https://bugs.webkit.org/show_bug.cgi?id=96678
+
+Reviewed by Dirk Pranke.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
+(.):
+
 2012-09-13  Rob Buis  rb...@rim.com
 
 Unreviewed changes to watchlist.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128510] trunk/LayoutTests

[jamesr]

Title: [128510] trunk/LayoutTests








Revision 128510
Author jam...@google.com
Date 2012-09-13 14:29:53 -0700 (Thu, 13 Sep 2012)


Log Message
Unreviewed gardening - upstream some skia_test_expectations.txt entries.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128509 => 128510)

--- trunk/LayoutTests/ChangeLog	2012-09-13 21:21:25 UTC (rev 128509)
+++ trunk/LayoutTests/ChangeLog	2012-09-13 21:29:53 UTC (rev 128510)
@@ -1,3 +1,9 @@
+2012-09-13  James Robinson  jam...@chromium.org
+
+Unreviewed gardening - upstream some skia_test_expectations.txt entries.
+
+* platform/chromium/TestExpectations:
+
 2012-09-13  John Mellor  joh...@chromium.org
 
 Text Autosizing: Add explanations to tests.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128509 => 128510)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-13 21:21:25 UTC (rev 128509)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-13 21:29:53 UTC (rev 128510)
@@ -3631,3 +3631,9 @@
 BUGWK96550 : http/tests/media/media-source/seek-to-end-after-duration-change.html = PASS TIMEOUT
 BUGWK96594 MAC : fast/table/bad-replaced-sizing-preferred-logical-widths.html = TEXT
 BUGWK96416 MAC : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE
+
+BUGCR63921 : platform/chromium/virtual/gpu/fast/canvas/canvas-fillPath-shadow.html = TEXT
+BUGCR139863 WIN : fast/canvas/fillText-shadow.html = TEXT
+BUGCR139863 WIN : platform/chromium/virtual/gpu/fast/canvas/fillText-shadow.html = TEXT
+BUGWK77550 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html = TEXT
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128515] trunk/LayoutTests

[jamesr]

Title: [128515] trunk/LayoutTests








Revision 128515
Author jam...@google.com
Date 2012-09-13 15:50:29 -0700 (Thu, 13 Sep 2012)


Log Message
Unreviewed gardening. Fix lint error in my last TestExpectations patch - whoops!

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128514 => 128515)

--- trunk/LayoutTests/ChangeLog	2012-09-13 22:32:28 UTC (rev 128514)
+++ trunk/LayoutTests/ChangeLog	2012-09-13 22:50:29 UTC (rev 128515)
@@ -1,3 +1,9 @@
+2012-09-13  James Robinson  jam...@chromium.org
+
+Unreviewed gardening. Fix lint error in my last TestExpectations patch - whoops!
+
+* platform/chromium/TestExpectations:
+
 2012-09-13  Adrienne Walker  e...@google.com
 
 Hide all ancestors of the full screen element when going full screen


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128514 => 128515)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-13 22:32:28 UTC (rev 128514)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-13 22:50:29 UTC (rev 128515)
@@ -2191,6 +2191,7 @@
 BUGCR67540 LINUX ANDROID WIN SNOWLEOPARD : fast/repaint/text-emphasis-h.html = IMAGE
 BUGCR67540 LINUX ANDROID : fast/repaint/text-emphasis-v.html = IMAGE
 
+// See also CRBUG139863
 BUGCR67442 LINUX ANDROID WIN : fast/canvas/fillText-shadow.html = TEXT
 BUGCR67442 LINUX WIN : platform/chromium/virtual/gpu/fast/canvas/fillText-shadow.html = TEXT
 
@@ -3633,7 +3634,5 @@
 BUGWK96416 MAC : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE
 
 BUGCR63921 : platform/chromium/virtual/gpu/fast/canvas/canvas-fillPath-shadow.html = TEXT
-BUGCR139863 WIN : fast/canvas/fillText-shadow.html = TEXT
-BUGCR139863 WIN : platform/chromium/virtual/gpu/fast/canvas/fillText-shadow.html = TEXT
 BUGWK77550 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html = TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128522] trunk/Source/WebKit/chromium

[jamesr]

Title: [128522] trunk/Source/WebKit/chromium








Revision 128522
Author jam...@google.com
Date 2012-09-13 16:07:20 -0700 (Thu, 13 Sep 2012)


Log Message
Fix compile warning/error on windows - literal that isn't exactly representable as a float needs f suffix.

* tests/PlatformGestureCurveTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (128521 => 128522)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-13 23:04:21 UTC (rev 128521)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-13 23:07:20 UTC (rev 128522)
@@ -1,3 +1,9 @@
+2012-09-13  James Robinson  jam...@chromium.org
+
+Fix compile warning/error on windows - literal that isn't exactly representable as a float needs f suffix.
+
+* tests/PlatformGestureCurveTest.cpp:
+
 2012-09-13  Julien Chaffraix  jchaffr...@webkit.org
 
 [Chromium] REGRESSION(r127457): Context menu on textarea is displayed in the wrong place


Modified: trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp (128521 => 128522)

--- trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp	2012-09-13 23:04:21 UTC (rev 128521)
+++ trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp	2012-09-13 23:07:20 UTC (rev 128522)
@@ -107,7 +107,7 @@
 // coded into the create call above.
 EXPECT_TRUE(animation-animate(0));
 EXPECT_TRUE(animation-animate(0.25));
-EXPECT_TRUE(animation-animate(0.45)); // Use non-uniform tick spacing.
+EXPECT_TRUE(animation-animate(0.45f)); // Use non-uniform tick spacing.
 EXPECT_TRUE(animation-animate(1));
 EXPECT_FALSE(animation-animate(1.5));
 EXPECT_NEAR(target.cumulativeDelta().x(), 1193, 1);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128526] trunk/Source/WebKit/chromium

[jamesr]

Title: [128526] trunk/Source/WebKit/chromium








Revision 128526
Author jam...@google.com
Date 2012-09-13 16:29:55 -0700 (Thu, 13 Sep 2012)


Log Message
PlatformGestureCurveTest compile fix pt 2

* tests/PlatformGestureCurveTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (128525 => 128526)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-13 23:18:24 UTC (rev 128525)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-13 23:29:55 UTC (rev 128526)
@@ -1,5 +1,11 @@
 2012-09-13  James Robinson  jam...@chromium.org
 
+PlatformGestureCurveTest compile fix pt 2
+
+* tests/PlatformGestureCurveTest.cpp:
+
+2012-09-13  James Robinson  jam...@chromium.org
+
 Fix compile warning/error on windows - literal that isn't exactly representable as a float needs f suffix.
 
 * tests/PlatformGestureCurveTest.cpp:


Modified: trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp (128525 => 128526)

--- trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp	2012-09-13 23:18:24 UTC (rev 128525)
+++ trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp	2012-09-13 23:29:55 UTC (rev 128526)
@@ -101,7 +101,7 @@
 MockPlatformGestureCurveTarget target;
 // Explicitly parametrized to make test non-brittle in face of
 // parameter changes.
-OwnPtrActivePlatformGestureAnimation animation = ActivePlatformGestureAnimation::create(TouchFlingPlatformGestureCurve::create(FloatPoint(initialVelocity, 0), -5.70762e+03, 1.72e+02, 3.7e+00, 1.3), target);
+OwnPtrActivePlatformGestureAnimation animation = ActivePlatformGestureAnimation::create(TouchFlingPlatformGestureCurve::create(FloatPoint(initialVelocity, 0), -5.70762e+03f, 1.72e+02f, 3.7e+00f, 1.3f), target);
 
 // Note: the expectations below are dependent on the curve parameters hard
 // coded into the create call above.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128528] trunk/LayoutTests

[jamesr]

Title: [128528] trunk/LayoutTests








Revision 128528
Author jam...@google.com
Date 2012-09-13 16:53:20 -0700 (Thu, 13 Sep 2012)


Log Message
Unreviewed gardening for r128516/r128517:
  remove the now-unnecessary cr-mac expectations for fast/writing-mode test.
  fix baseline for fast/table/bad-replaced-sizing-preferred-logical-widths.html

* platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/table/bad-replaced-sizing-preferred-logical-widths-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (128527 => 128528)

--- trunk/LayoutTests/ChangeLog	2012-09-13 23:48:50 UTC (rev 128527)
+++ trunk/LayoutTests/ChangeLog	2012-09-13 23:53:20 UTC (rev 128528)
@@ -1,3 +1,11 @@
+2012-09-13  James Robinson  jam...@chromium.org
+
+Unreviewed gardening for r128516/r128517:
+  remove the now-unnecessary cr-mac expectations for fast/writing-mode test.
+  fix baseline for fast/table/bad-replaced-sizing-preferred-logical-widths.html
+
+* platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
+
 2012-09-13  Tom Sepez  tse...@chromium.org
 
 ASSERT(!eventDispatchForbidden()) firest when removed plugin re-inserted as part of readyStateChange.


Modified: trunk/LayoutTests/fast/table/bad-replaced-sizing-preferred-logical-widths-expected.txt (128527 => 128528)

--- trunk/LayoutTests/fast/table/bad-replaced-sizing-preferred-logical-widths-expected.txt	2012-09-13 23:48:50 UTC (rev 128527)
+++ trunk/LayoutTests/fast/table/bad-replaced-sizing-preferred-logical-widths-expected.txt	2012-09-13 23:53:20 UTC (rev 128528)
@@ -4,4 +4,4 @@
 
 
 PASS
-dolor sit amet...
+


Deleted: trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt (128527 => 128528)

--- trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt	2012-09-13 23:48:50 UTC (rev 128527)
+++ trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt	2012-09-13 23:53:20 UTC (rev 128528)
@@ -1,39 +0,0 @@
-compatMode: BackCompat
-PASS
-PASS
-PASS
-PASS
-PASS
-FAIL:
-Expected 100 for height, but got 600. 
-
-div class=container
-div style=width: 100%; height: 100%; data-expected-height=100 data-expected-width=200
-div class=item vertical-rl style=width: 100%; height: 100%; data-expected-height=100 data-expected-width=200/div
-/div
-/div
-PASS
-FAIL:
-Expected 100 for height, but got 600. 
-Expected 100 for height, but got 600. 
-Expected 100 for height, but got 600. 
-
-div class=container
-div style=width: 150px; data-expected-height=100 data-expected-width=150
-div data-expected-height=100 data-expected-width=150
-div class=item vertical-rl style=width: 100%; height: 100%; data-expected-height=100 data-expected-width=150/div
-/div
-/div
-/div
-FAIL:
-Expected 584 for height, but got 1419. 
-
-div class=container style=width: auto; height: auto; float: left;
-div class=item style=width: 100%; height: 100%; data-expected-height=584 data-expected-width=0/div
-/div
-FAIL:
-Expected 584 for height, but got 600. 
-
-div class=container style=width: auto; height: auto; float: left;
-div class=item vertical-rl style=width: 100%; height: 100%; data-expected-height=584 data-expected-width=0/div
-/div






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128384] trunk/LayoutTests

[jamesr]

Title: [128384] trunk/LayoutTests








Revision 128384
Author jam...@google.com
Date 2012-09-12 17:04:41 -0700 (Wed, 12 Sep 2012)


Log Message
Rebaseline chromium-mac pixel results for 128375

* platform/chromium-mac-snowleopard/fast/table/height-percent-test-vertical-expected.png:
* platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/table/height-percent-test-vertical-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (128383 => 128384)

--- trunk/LayoutTests/ChangeLog	2012-09-12 23:48:43 UTC (rev 128383)
+++ trunk/LayoutTests/ChangeLog	2012-09-13 00:04:41 UTC (rev 128384)
@@ -1,3 +1,10 @@
+2012-09-12  James Robinson  jam...@chromium.org
+
+Rebaseline chromium-mac pixel results for 128375
+
+* platform/chromium-mac-snowleopard/fast/table/height-percent-test-vertical-expected.png:
+* platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added.
+
 2012-09-12  Tony Chang  t...@chromium.org
 
 flex item sized incorrectly in a column flexbox with height set via top/bottom


Added: trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt (0 => 128384)

--- trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt	2012-09-13 00:04:41 UTC (rev 128384)
@@ -0,0 +1,39 @@
+compatMode: BackCompat
+PASS
+PASS
+PASS
+PASS
+PASS
+FAIL:
+Expected 100 for height, but got 600. 
+
+div class=container
+div style=width: 100%; height: 100%; data-expected-height=100 data-expected-width=200
+div class=item vertical-rl style=width: 100%; height: 100%; data-expected-height=100 data-expected-width=200/div
+/div
+/div
+PASS
+FAIL:
+Expected 100 for height, but got 600. 
+Expected 100 for height, but got 600. 
+Expected 100 for height, but got 600. 
+
+div class=container
+div style=width: 150px; data-expected-height=100 data-expected-width=150
+div data-expected-height=100 data-expected-width=150
+div class=item vertical-rl style=width: 100%; height: 100%; data-expected-height=100 data-expected-width=150/div
+/div
+/div
+/div
+FAIL:
+Expected 584 for height, but got 1419. 
+
+div class=container style=width: auto; height: auto; float: left;
+div class=item style=width: 100%; height: 100%; data-expected-height=584 data-expected-width=0/div
+/div
+FAIL:
+Expected 584 for height, but got 600. 
+
+div class=container style=width: auto; height: auto; float: left;
+div class=item vertical-rl style=width: 100%; height: 100%; data-expected-height=584 data-expected-width=0/div
+/div
Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt
___


Added: svn:eol-style

Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/table/height-percent-test-vertical-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128220] trunk/Source/WebCore

[jamesr]

Title: [128220] trunk/Source/WebCore








Revision 128220
Author jam...@google.com
Date 2012-09-11 13:14:51 -0700 (Tue, 11 Sep 2012)


Log Message
Unreviewed, rolling out r128212.
http://trac.webkit.org/changeset/128212
https://bugs.webkit.org/show_bug.cgi?id=96037

Assertion fails on linux 64

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::compare):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128219 => 128220)

--- trunk/Source/WebCore/ChangeLog	2012-09-11 20:00:31 UTC (rev 128219)
+++ trunk/Source/WebCore/ChangeLog	2012-09-11 20:14:51 UTC (rev 128220)
@@ -1,3 +1,17 @@
+2012-09-11  James Robinson  jam...@chromium.org
+
+Unreviewed, rolling out r128212.
+http://trac.webkit.org/changeset/128212
+https://bugs.webkit.org/show_bug.cgi?id=96037
+
+Assertion fails on linux 64
+
+* Modules/indexeddb/IDBLevelDBCoding.cpp:
+(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
+(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
+(IDBLevelDBCoding):
+(WebCore::IDBLevelDBCoding::compare):
+
 2012-09-11  Joshua Bell  jsb...@chromium.org
 
 IndexedDB: IDBObjectStore.count() is slow


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp (128219 => 128220)

--- trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp	2012-09-11 20:00:31 UTC (rev 128219)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp	2012-09-11 20:14:51 UTC (rev 128220)
@@ -505,8 +505,9 @@
 return 0;
 }
 
-const char* extractEncodedIDBKey(const char* start, const char* limit, Vectorchar* result = 0)
+const char* extractEncodedIDBKey(const char* start, const char* limit, Vectorchar* result)
 {
+ASSERT(result);
 const char* p = start;
 if (p = limit)
 return 0;
@@ -516,7 +517,8 @@
 switch (type) {
 case IDBKeyNullTypeByte:
 case IDBKeyMinKeyTypeByte:
-break;
+*result = encodeByte(type);
+return p;
 case IDBKeyArrayTypeByte: {
 int64_t length;
 p = decodeVarInt(p, limit, length);
@@ -524,12 +526,16 @@
 return 0;
 if (length  0)
 return 0;
+result-clear();
+result-append(start, p - start);
 while (length--) {
-p = extractEncodedIDBKey(p, limit);
+Vectorchar subkey;
+p = extractEncodedIDBKey(p, limit, subkey);
 if (!p)
 return 0;
+result-append(subkey);
 }
-break;
+return p;
 }
 case IDBKeyStringTypeByte: {
 int64_t length;
@@ -538,25 +544,20 @@
 return 0;
 if (p + length * 2  limit)
 return 0;
-p += length * 2;
-break;
+result-clear();
+result-append(start, p - start + length * 2);
+return p + length * 2;
 }
 case IDBKeyDateTypeByte:
 case IDBKeyNumberTypeByte:
 if (p + sizeof(double)  limit)
 return 0;
-p += sizeof(double);
-break;
-}
-
-if (result) {
-ASSERT(p);
-ASSERT(p = limit);
 result-clear();
-result-append(start, p - start);
+result-append(start, 1 + sizeof(double));
+return p + sizeof(double);
 }
-
-return p;
+ASSERT_NOT_REACHED();
+return 0;
 }
 
 static IDBKey::Type keyTypeByteToKeyType(unsigned char type)
@@ -580,13 +581,13 @@
 return IDBKey::InvalidType;
 }
 
-int compareEncodedIDBKeys(const char* ptrA, const char* limitA, const char* ptrB, const char* limitB)
+int compareEncodedIDBKeys(const char* p, const char* limitA, const char* q, const char* limitB)
 {
-ASSERT(ptrA != ptrB);
-ASSERT(ptrA  limitA);
-ASSERT(ptrB  limitB);
-unsigned char typeA = *ptrA++;
-unsigned char typeB = *ptrB++;
+ASSERT(p != q);
+ASSERT(p  limitA);
+ASSERT(q  limitB);
+unsigned char typeA = *p++;
+unsigned char typeB = *q++;
 
 if (int x = IDBKey::compareTypes(keyTypeByteToKeyType(typeA), keyTypeByteToKeyType(typeB)))
 return x;
@@ -598,16 +599,16 @@
 return 0;
 case IDBKeyArrayTypeByte: {
 int64_t lengthA, lengthB;
-ptrA = decodeVarInt(ptrA, limitA, lengthA);
-if (!ptrA)
+p = decodeVarInt(p, limitA, lengthA);
+if (!p)
 return 0;
-ptrB = decodeVarInt(ptrB, limitB, lengthB);
-if (!ptrB)
+q = decodeVarInt(q, limitB, lengthB);
+if (!q)
 return 0;
 if (lengthA  0 || lengthB  0)
 return 0;
 for (int64_t i = 0; i  lengthA  i  lengthB; ++i) {
-if (int cmp = compareEncodedIDBKeys(ptrA, limitA, ptrB, limitB))
+if (int cmp = compareEncodedIDBKeys(p, limitA, 

[webkit-changes] [128229] trunk/LayoutTests

[jamesr]

Title: [128229] trunk/LayoutTests








Revision 128229
Author jam...@google.com
Date 2012-09-11 15:25:24 -0700 (Tue, 11 Sep 2012)


Log Message
Unreviewed gardening. Update some expectations to reference specific bugs.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128228 => 128229)

--- trunk/LayoutTests/ChangeLog	2012-09-11 22:02:13 UTC (rev 128228)
+++ trunk/LayoutTests/ChangeLog	2012-09-11 22:25:24 UTC (rev 128229)
@@ -1,3 +1,9 @@
+2012-09-11  James Robinson  jam...@chromium.org
+
+Unreviewed gardening. Update some expectations to reference specific bugs.
+
+* platform/chromium/TestExpectations:
+
 2012-09-11  Chris Fleizach  cfleiz...@apple.com
 
 AX: title attribute is not exposed as the AXDescription on AXImage when there is no other fallback content


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128228 => 128229)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-11 22:02:13 UTC (rev 128228)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-11 22:25:24 UTC (rev 128229)
@@ -2060,8 +2060,8 @@
 // content of video elements.
 BUGWK91205 SKIP : media/nodesFromRect-shadowContent.html = TEXT
 
-BUGJAMESR LINUX ANDROID WIN : fast/text/international/vertical-text-glyph-test.html = IMAGE+TEXT
-BUGJAMESR LINUX ANDROID WIN : fast/text/international/vertical-text-metrics-test.html = TEXT
+BUGWK48459 LINUX ANDROID WIN : fast/text/international/vertical-text-glyph-test.html = IMAGE+TEXT
+BUGWK48459 LINUX ANDROID WIN : fast/text/international/vertical-text-metrics-test.html = TEXT
 
 // Added in Webkit r69707 without expected results.
 // Expected result file added in r83450. Still no match.
@@ -2611,7 +2611,7 @@
 BUGWK66989 : transforms/3d/point-mapping/3d-point-mapping-coplanar.html = IMAGE IMAGE+TEXT
 
 // We don't seem to load this glyph on windows
-BUGJAMESR WIN : fast/text/fallback-traits-fixup.html = IMAGE+TEXT
+BUGWK96430 WIN : fast/text/fallback-traits-fixup.html = IMAGE+TEXT
 
 // Failing after r94946
 BUGWK67926 WIN : fast/events/constructors/progress-event-constructor.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128132] trunk/Source

[jamesr]

Title: [128132] trunk/Source








Revision 128132
Author jam...@google.com
Date 2012-09-10 17:12:38 -0700 (Mon, 10 Sep 2012)


Log Message
Unreviewed, rolling out r127837.
http://trac.webkit.org/changeset/127837
https://bugs.webkit.org/show_bug.cgi?id=93898

Broke ScrollingCoordinator on chromium

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setForceMainThreadScrollLayerPositionUpdates):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/ScrollingCoordinatorNone.cpp:
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::scrollingPeformanceLoggingEnabled):
* page/scrolling/ScrollingTree.h:
* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
(WebCore::ScrollingTreeNode::update):
* page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThread):
(ScrollingTreeNode):
* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setShouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::shouldUpdateScrollLayerPositionOnMainThread):
(ScrollingTreeState):
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/mac/ScrollingTreeMac.mm:
(WebCore::ScrollingTree::updateDebugRootLayer):
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollPositionWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):

Source/WebKit2:

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h
trunk/Source/WebCore/page/scrolling/ScrollingCoordinatorNone.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTree.h
trunk/Source/WebCore/page/scrolling/ScrollingTreeNode.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTreeNode.h
trunk/Source/WebCore/page/scrolling/ScrollingTreeState.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTreeState.h
trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp
trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm
trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeNodeMac.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (128131 => 128132)

--- trunk/Source/WebCore/ChangeLog	2012-09-11 00:07:26 UTC (rev 128131)
+++ trunk/Source/WebCore/ChangeLog	2012-09-11 00:12:38 UTC (rev 128132)
@@ -1,3 +1,50 @@
+2012-09-10  James Robinson  jam...@chromium.org
+
+Unreviewed, rolling out r127837.
+http://trac.webkit.org/changeset/127837
+https://bugs.webkit.org/show_bug.cgi?id=93898
+
+Broke ScrollingCoordinator on chromium
+
+* WebCore.xcodeproj/project.pbxproj:
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
+(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
+(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
+(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
+(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
+(WebCore::ScrollingCoordinator::setForceMainThreadScrollLayerPositionUpdates):
+(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
+* page/scrolling/ScrollingCoordinator.h:
+(ScrollingCoordinator):
+* page/scrolling/ScrollingCoordinatorNone.cpp:
+(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
+* page/scrolling/ScrollingTree.cpp:
+(WebCore::ScrollingTree::scrollingPeformanceLoggingEnabled):
+* page/scrolling/ScrollingTree.h:
+* 

[webkit-changes] [127994] trunk/Source/WebKit/chromium

[jamesr]

Title: [127994] trunk/Source/WebKit/chromium








Revision 127994
Author jam...@google.com
Date 2012-09-09 14:04:02 -0700 (Sun, 09 Sep 2012)


Log Message
[chromium] Use WebCompositorSupport creation functions in GraphicsLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=96212

Reviewed by Adrienne Walker.

The static ::create()s the test references currently are going away soon.

* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::TEST_F):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (127993 => 127994)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-09 21:02:14 UTC (rev 127993)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-09 21:04:02 UTC (rev 127994)
@@ -1,3 +1,16 @@
+2012-09-09  James Robinson  jam...@chromium.org
+
+[chromium] Use WebCompositorSupport creation functions in GraphicsLayerChromiumTest
+https://bugs.webkit.org/show_bug.cgi?id=96212
+
+Reviewed by Adrienne Walker.
+
+The static ::create()s the test references currently are going away soon.
+
+* tests/GraphicsLayerChromiumTest.cpp:
+(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
+(WebKit::TEST_F):
+
 2012-09-07  Benjamin Poulain  benja...@webkit.org
 
 Unreviewed prospective build fix.


Modified: trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp (127993 => 127994)

--- trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp	2012-09-09 21:02:14 UTC (rev 127993)
+++ trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp	2012-09-09 21:04:02 UTC (rev 127994)
@@ -68,7 +68,7 @@
 Platform::current()-compositorSupport()-initialize(0);
 m_graphicsLayer = static_pointer_castGraphicsLayerChromium(GraphicsLayer::create(m_client));
 m_platformLayer = m_graphicsLayer-platformLayer();
-m_layerTreeView = adoptPtr(WebLayerTreeView::create(m_layerTreeViewClient, *m_platformLayer, WebLayerTreeView::Settings()));
+m_layerTreeView = adoptPtr(Platform::current()-compositorSupport()-createLayerTreeView(m_layerTreeViewClient, *m_platformLayer, WebLayerTreeView::Settings()));
 m_layerTreeView-setViewportSize(WebSize(1, 1), WebSize(1, 1));
 }
 
@@ -98,9 +98,9 @@
 {
 ASSERT_FALSE(m_platformLayer-hasActiveAnimation());
 
-OwnPtrWebFloatAnimationCurve curve = adoptPtr(WebFloatAnimationCurve::create());
+OwnPtrWebFloatAnimationCurve curve = adoptPtr(Platform::current()-compositorSupport()-createFloatAnimationCurve());
 curve-add(WebFloatKeyframe(0.0, 0.0));
-OwnPtrWebAnimation floatAnimation(adoptPtr(WebAnimation::create(*curve, WebAnimation::TargetPropertyOpacity)));
+OwnPtrWebAnimation floatAnimation(adoptPtr(Platform::current()-compositorSupport()-createAnimation(*curve, WebAnimation::TargetPropertyOpacity)));
 int animationId = floatAnimation-id();
 ASSERT_TRUE(m_platformLayer-addAnimation(floatAnimation.get()));
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [127995] trunk/Source

[jamesr]

Title: [127995] trunk/Source








Revision 127995
Author jam...@google.com
Date 2012-09-09 14:04:49 -0700 (Sun, 09 Sep 2012)


Log Message
[chromium] webkit_platform should only be linked into the webkit target
https://bugs.webkit.org/show_bug.cgi?id=96213

Reviewed by Adrienne Walker.

The Platform.gyp:webkit_platform target provides the implementation of several WEBKIT_EXPORTed symbols. It only
makes sense as a target of WebKit.gyp:webkit, other targets shouldn't directly depend on it.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

* WebKit.gyp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebCore/ChangeLog (127994 => 127995)

--- trunk/Source/WebCore/ChangeLog	2012-09-09 21:04:02 UTC (rev 127994)
+++ trunk/Source/WebCore/ChangeLog	2012-09-09 21:04:49 UTC (rev 127995)
@@ -1,3 +1,15 @@
+2012-09-09  James Robinson  jam...@chromium.org
+
+[chromium] webkit_platform should only be linked into the webkit target
+https://bugs.webkit.org/show_bug.cgi?id=96213
+
+Reviewed by Adrienne Walker.
+
+The Platform.gyp:webkit_platform target provides the implementation of several WEBKIT_EXPORTed symbols. It only
+makes sense as a target of WebKit.gyp:webkit, other targets shouldn't directly depend on it.
+
+* WebCore.gyp/WebCore.gyp:
+
 2012-09-09  Gyuyoung Kim  gyuyoung@samsung.com
 
 [EFL] Fix build break when MEDIA_STREAM is enabled.


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (127994 => 127995)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-09-09 21:04:02 UTC (rev 127994)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-09-09 21:04:49 UTC (rev 127995)
@@ -1335,7 +1335,6 @@
 '../../ThirdParty/glu/glu.gyp:libtess',
 '../../_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp:yarr',
 '../../WTF/WTF.gyp/WTF.gyp:wtf',
-'../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
 '(chromium_src_dir)/build/temp_gyp/googleurl.gyp:googleurl',
 '(chromium_src_dir)/skia/skia.gyp:skia',
 '(chromium_src_dir)/third_party/iccjpeg/iccjpeg.gyp:iccjpeg',
@@ -1355,7 +1354,6 @@
   'export_dependent_settings': [
 '../../_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp:yarr',
 '../../WTF/WTF.gyp/WTF.gyp:wtf',
-'../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
 '(chromium_src_dir)/build/temp_gyp/googleurl.gyp:googleurl',
 '(chromium_src_dir)/skia/skia.gyp:skia',
 '(chromium_src_dir)/third_party/iccjpeg/iccjpeg.gyp:iccjpeg',
@@ -1380,6 +1378,7 @@
   'WEBCORE_NAVIGATOR_VENDOR=Google Inc.',
 ],
 'include_dirs': [
+  '../../Platform/chromium',
   '(INTERMEDIATE_DIR)',
   '@(webcore_include_dirs)',
   '(chromium_src_dir)/gpu',
@@ -2146,7 +2145,6 @@
 'webcore_rendering',
 # Exported.
 'webcore_bindings',
-'../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
 '../../WTF/WTF.gyp/WTF.gyp:wtf',
 '(chromium_src_dir)/build/temp_gyp/googleurl.gyp:googleurl',
 '(chromium_src_dir)/skia/skia.gyp:skia',
@@ -2156,7 +2154,6 @@
   ],
   'export_dependent_settings': [
 'webcore_bindings',
-'../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
 '../../WTF/WTF.gyp/WTF.gyp:wtf',
 '(chromium_src_dir)/build/temp_gyp/googleurl.gyp:googleurl',
 '(chromium_src_dir)/skia/skia.gyp:skia',


Modified: trunk/Source/WebKit/chromium/ChangeLog (127994 => 127995)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-09 21:04:02 UTC (rev 127994)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-09 21:04:49 UTC (rev 127995)
@@ -1,5 +1,17 @@
 2012-09-09  James Robinson  jam...@chromium.org
 
+[chromium] webkit_platform should only be linked into the webkit target
+https://bugs.webkit.org/show_bug.cgi?id=96213
+
+Reviewed by Adrienne Walker.
+
+The Platform.gyp:webkit_platform target provides the implementation of several WEBKIT_EXPORTed symbols. It only
+makes sense as a target of WebKit.gyp:webkit, other targets shouldn't directly depend on it.
+
+* WebKit.gyp:
+
+2012-09-09  James Robinson  jam...@chromium.org
+
 [chromium] Use WebCompositorSupport creation functions in GraphicsLayerChromiumTest
 https://bugs.webkit.org/show_bug.cgi?id=96212
 


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (127994 => 127995)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-09-09 21:04:02 UTC (rev 127994)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-09-09 21:04:49 UTC (rev 127995)
@@ -865,12 +865,14 @@
 'target_name': 'webkit_wtf_support',
 'type': 'static_library',
 'dependencies': [
-

[webkit-changes] [127996] trunk/Source/Platform

[jamesr]

Title: [127996] trunk/Source/Platform








Revision 127996
Author jam...@google.com
Date 2012-09-09 14:05:24 -0700 (Sun, 09 Sep 2012)


Log Message
[chromium] Export WebFilterOperation(FilterType, SkScalar[20]) constructor
https://bugs.webkit.org/show_bug.cgi?id=96215

Reviewed by Adrienne Walker.

Unlike the other WebFilterOperation constructors this one is defined out-of-line and so must be exported to be
usable outside of WebKit.dll

* chromium/public/WebFilterOperation.h:
(WebFilterOperation):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebFilterOperation.h




Diff

Modified: trunk/Source/Platform/ChangeLog (127995 => 127996)

--- trunk/Source/Platform/ChangeLog	2012-09-09 21:04:49 UTC (rev 127995)
+++ trunk/Source/Platform/ChangeLog	2012-09-09 21:05:24 UTC (rev 127996)
@@ -1,3 +1,16 @@
+2012-09-09  James Robinson  jam...@chromium.org
+
+[chromium] Export WebFilterOperation(FilterType, SkScalar[20]) constructor
+https://bugs.webkit.org/show_bug.cgi?id=96215
+
+Reviewed by Adrienne Walker.
+
+Unlike the other WebFilterOperation constructors this one is defined out-of-line and so must be exported to be
+usable outside of WebKit.dll
+
+* chromium/public/WebFilterOperation.h:
+(WebFilterOperation):
+
 2012-09-07  James Robinson  jam...@chromium.org
 
 [chromium] Remove unused WebScrollbarThemePainter::isNull


Modified: trunk/Source/Platform/chromium/public/WebFilterOperation.h (127995 => 127996)

--- trunk/Source/Platform/chromium/public/WebFilterOperation.h	2012-09-09 21:04:49 UTC (rev 127995)
+++ trunk/Source/Platform/chromium/public/WebFilterOperation.h	2012-09-09 21:05:24 UTC (rev 127996)
@@ -120,7 +120,7 @@
 m_dropShadowColor = color;
 }
 
-WebFilterOperation(FilterType, SkScalar matrix[20]);
+WEBKIT_EXPORT WebFilterOperation(FilterType, SkScalar matrix[20]);
 
 WebFilterOperation(FilterType type, WebRect rect, float inset)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128004] trunk/LayoutTests

[jamesr]

Title: [128004] trunk/LayoutTests








Revision 128004
Author jam...@google.com
Date 2012-09-09 15:49:37 -0700 (Sun, 09 Sep 2012)


Log Message
Rebaseline media/video-zoom-controls on chromium-mac for subpixel change.

* platform/chromium-mac/media/video-zoom-controls-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/media/video-zoom-controls-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (128003 => 128004)

--- trunk/LayoutTests/ChangeLog	2012-09-09 22:48:00 UTC (rev 128003)
+++ trunk/LayoutTests/ChangeLog	2012-09-09 22:49:37 UTC (rev 128004)
@@ -1,3 +1,9 @@
+2012-09-09  James Robinson  jam...@chromium.org
+
+Rebaseline media/video-zoom-controls on chromium-mac for subpixel change.
+
+* platform/chromium-mac/media/video-zoom-controls-expected.txt:
+
 2012-09-09  Andreas Kling  kl...@webkit.org
 
 EventListenerMap: Use Vector instead of HashMap as backend.


Modified: trunk/LayoutTests/platform/chromium-mac/media/video-zoom-controls-expected.txt (128003 => 128004)

--- trunk/LayoutTests/platform/chromium-mac/media/video-zoom-controls-expected.txt	2012-09-09 22:48:00 UTC (rev 128003)
+++ trunk/LayoutTests/platform/chromium-mac/media/video-zoom-controls-expected.txt	2012-09-09 22:49:37 UTC (rev 128004)
@@ -28,7 +28,7 @@
 RenderBlock {DIV} at (1,1) size 6x36
 RenderBlock {DIV} at (-4,1) size 36x36
 RenderButton {INPUT} at (284,0) size 46x45
-layer at (127,217) size 49x36
+layer at (127,217) size 48x36
   RenderBlock (relative positioned) {DIV} at (-11,-12) size 49x36
 layer at (57,310) size 240x180
   RenderVideo {VIDEO} at (45,298) size 240x180
@@ -52,5 +52,5 @@
 RenderBlock {DIV} at (1,1) size 6x36
 RenderBlock {DIV} at (-4,1) size 36x36
 RenderButton {INPUT} at (284,0) size 46x45
-layer at (127,442) size 49x36 backgroundClip at (60,417) size 225x45 clip at (60,417) size 225x45 outlineClip at (60,417) size 225x45
+layer at (127,442) size 48x36 backgroundClip at (60,417) size 225x45 clip at (60,417) size 225x45 outlineClip at (60,417) size 225x45
   RenderBlock (relative positioned) {DIV} at (-11,-12) size 49x36






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [127891] trunk/Source

[jamesr]

Title: [127891] trunk/Source








Revision 127891
Author jam...@google.com
Date 2012-09-07 10:57:47 -0700 (Fri, 07 Sep 2012)


Log Message
[chromium] Remove dead CCActiveGestureAnimation code and related classes
https://bugs.webkit.org/show_bug.cgi?id=96075

Reviewed by Adrienne Walker.

Source/WebCore:

The CCGestureCurve / CCActiveGestureAnimation code isn't used and never has been used. Gesture curves are
evaluated by the CCInputHandlerClient (WebCompositorInputHandlerImpl), CC itself logically doesn't know anything
about gestures.

* WebCore.gypi:
* platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp: Removed.
* platform/graphics/chromium/cc/CCActiveGestureAnimation.h: Removed.
* platform/graphics/chromium/cc/CCGestureCurve.h: Removed.
* platform/graphics/chromium/cc/CCInputHandler.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::animate):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

Cuts out unnecessary boilerplate in PlatformGestureCurve evaluation for handling flings. WCIHI can easily
evaluate the curve itself without intermediate classes.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
* src/WebCompositorInputHandlerImpl.h:
(WebCore):
(WebCompositorInputHandlerImpl):
* tests/PlatformGestureCurveTest.cpp:
* tests/WebCompositorInputHandlerImplTest.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/graphics/chromium/cc/CCInputHandler.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.h
trunk/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp
trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp


Removed Paths

trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveGestureAnimation.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCGestureCurve.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (127890 => 127891)

--- trunk/Source/WebCore/ChangeLog	2012-09-07 17:57:37 UTC (rev 127890)
+++ trunk/Source/WebCore/ChangeLog	2012-09-07 17:57:47 UTC (rev 127891)
@@ -1,3 +1,24 @@
+2012-09-07  James Robinson  jam...@chromium.org
+
+[chromium] Remove dead CCActiveGestureAnimation code and related classes
+https://bugs.webkit.org/show_bug.cgi?id=96075
+
+Reviewed by Adrienne Walker.
+
+The CCGestureCurve / CCActiveGestureAnimation code isn't used and never has been used. Gesture curves are
+evaluated by the CCInputHandlerClient (WebCompositorInputHandlerImpl), CC itself logically doesn't know anything
+about gestures.
+
+* WebCore.gypi:
+* platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp: Removed.
+* platform/graphics/chromium/cc/CCActiveGestureAnimation.h: Removed.
+* platform/graphics/chromium/cc/CCGestureCurve.h: Removed.
+* platform/graphics/chromium/cc/CCInputHandler.h:
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::animate):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+(CCLayerTreeHostImpl):
+
 2012-09-07  Martin Robinson  mrobin...@igalia.com
 
 [GTK] Move user agent helpers to WebCore


Modified: trunk/Source/WebCore/WebCore.gypi (127890 => 127891)

--- trunk/Source/WebCore/WebCore.gypi	2012-09-07 17:57:37 UTC (rev 127890)
+++ trunk/Source/WebCore/WebCore.gypi	2012-09-07 17:57:47 UTC (rev 127891)
@@ -8438,8 +8438,6 @@
 'platform/graphics/chromium/VideoLayerChromium.h',
 'platform/graphics/chromium/cc/CCActiveAnimation.cpp',
 'platform/graphics/chromium/cc/CCActiveAnimation.h',
-'platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp',
-'platform/graphics/chromium/cc/CCActiveGestureAnimation.h',
 'platform/graphics/chromium/cc/CCAnimationCurve.cpp',
 'platform/graphics/chromium/cc/CCAnimationCurve.h',
 'platform/graphics/chromium/cc/CCAnimationEvents.h',
@@ -8464,7 +8462,6 @@
 'platform/graphics/chromium/cc/CCFrameRateController.h',
 'platform/graphics/chromium/cc/CCFrameRateCounter.cpp',
 'platform/graphics/chromium/cc/CCFrameRateCounter.h',
-'platform/graphics/chromium/cc/CCGestureCurve.h',
 'platform/graphics/chromium/cc/CCGraphicsContext.h',
 'platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp',
 

[webkit-changes] [127952] trunk/Source

[jamesr]

Title: [127952] trunk/Source








Revision 127952
Author jam...@google.com
Date 2012-09-07 18:32:53 -0700 (Fri, 07 Sep 2012)


Log Message
[chromium] Remove transitional WebCompositorSupport fallback code
https://bugs.webkit.org/show_bug.cgi?id=96155

Reviewed by Adrienne Walker.

Source/WebCore:

The implementation of WebCompositorSupport has rolled out everywhere and the static ::create() functions are
going way.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
* platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::createWebAnimation):
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

Source/WebKit/chromium:

* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimation):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp
trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.cpp
trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/LinkHighlight.cpp
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (127951 => 127952)

--- trunk/Source/WebCore/ChangeLog	2012-09-08 01:30:41 UTC (rev 127951)
+++ trunk/Source/WebCore/ChangeLog	2012-09-08 01:32:53 UTC (rev 127952)
@@ -1,3 +1,26 @@
+2012-09-07  James Robinson  jam...@chromium.org
+
+[chromium] Remove transitional WebCompositorSupport fallback code
+https://bugs.webkit.org/show_bug.cgi?id=96155
+
+Reviewed by Adrienne Walker.
+
+The implementation of WebCompositorSupport has rolled out everywhere and the static ::create() functions are
+going way.
+
+* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
+(WebCore::createScrollbarLayer):
+* platform/graphics/chromium/AnimationTranslationUtil.cpp:
+(WebCore::createWebAnimation):
+* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
+(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
+* platform/graphics/chromium/DrawingBufferChromium.cpp:
+(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
+* platform/graphics/chromium/GraphicsLayerChromium.cpp:
+(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
+(WebCore::GraphicsLayerChromium::setContentsToImage):
+(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
+
 2012-09-07  Simon Hausmann  simon.hausm...@nokia.com
 
 Fix compilation of TextureMapperShaderManager.cpp with MSVC


Modified: trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp (127951 => 127952)

--- trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp	2012-09-08 01:30:41 UTC (rev 127951)
+++ trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp	2012-09-08 01:32:53 UTC (rev 127952)
@@ -37,6 +37,8 @@
 #include ScrollbarThemeComposite.h
 #include WebScrollbarImpl.h
 #include WebScrollbarThemeGeometryNative.h
+#include public/Platform.h
+#include public/WebCompositorSupport.h
 #include public/WebScrollbar.h
 #include public/WebScrollbarLayer.h
 #include public/WebScrollbarThemeGeometry.h
@@ -161,7 +163,7 @@
 WebKit::WebScrollbarThemePainter painter(themeComposite, scrollbar);
 OwnPtrWebKit::WebScrollbarThemeGeometry geometry(WebKit::WebScrollbarThemeGeometryNative::create(themeComposite));
 
-OwnPtrWebScrollbarLayer scrollbarLayer = adoptPtr(WebScrollbarLayer::create(new WebKit::WebScrollbarImpl(scrollbar), painter, geometry.leakPtr()));
+OwnPtrWebScrollbarLayer scrollbarLayer = adoptPtr(WebKit::Platform::current()-compositorSupport()-createScrollbarLayer(new WebKit::WebScrollbarImpl(scrollbar), painter, geometry.leakPtr()));
 scrollbarLayer-setScrollLayer(scrollLayer);
 
 

[webkit-changes] [127953] trunk/Source/Platform

[jamesr]

Title: [127953] trunk/Source/Platform








Revision 127953
Author jam...@google.com
Date 2012-09-07 18:33:27 -0700 (Fri, 07 Sep 2012)


Log Message
[chromium] Remove unused WebScrollbarThemePainter::isNull
https://bugs.webkit.org/show_bug.cgi?id=96169

Reviewed by Adrienne Walker.

This doesn't appear to be used anywhere and triggers MSVS C4800 in any chromium file that #includes this header.

* chromium/public/WebScrollbarThemePainter.h:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebScrollbarThemePainter.h




Diff

Modified: trunk/Source/Platform/ChangeLog (127952 => 127953)

--- trunk/Source/Platform/ChangeLog	2012-09-08 01:32:53 UTC (rev 127952)
+++ trunk/Source/Platform/ChangeLog	2012-09-08 01:33:27 UTC (rev 127953)
@@ -1,5 +1,16 @@
 2012-09-07  James Robinson  jam...@chromium.org
 
+[chromium] Remove unused WebScrollbarThemePainter::isNull
+https://bugs.webkit.org/show_bug.cgi?id=96169
+
+Reviewed by Adrienne Walker.
+
+This doesn't appear to be used anywhere and triggers MSVS C4800 in any chromium file that #includes this header.
+
+* chromium/public/WebScrollbarThemePainter.h:
+
+2012-09-07  James Robinson  jam...@chromium.org
+
 [chromium] Implement WebCompositorInputHandlerImpl on top of exposed API instead of CC internals
 https://bugs.webkit.org/show_bug.cgi?id=96151
 


Modified: trunk/Source/Platform/chromium/public/WebScrollbarThemePainter.h (127952 => 127953)

--- trunk/Source/Platform/chromium/public/WebScrollbarThemePainter.h	2012-09-08 01:32:53 UTC (rev 127952)
+++ trunk/Source/Platform/chromium/public/WebScrollbarThemePainter.h	2012-09-08 01:33:27 UTC (rev 127953)
@@ -49,7 +49,6 @@
 return *this;
 }
 
-bool isNull() const { return m_theme; }
 WEBKIT_EXPORT void assign(const WebScrollbarThemePainter);
 
 WEBKIT_EXPORT void paintScrollbarBackground(WebCanvas*, const WebRect);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [127954] trunk/LayoutTests

[jamesr]

Title: [127954] trunk/LayoutTests








Revision 127954
Author jam...@google.com
Date 2012-09-07 18:36:02 -0700 (Fri, 07 Sep 2012)


Log Message
Skip some tests that appear to be making bots unstable.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (127953 => 127954)

--- trunk/LayoutTests/ChangeLog	2012-09-08 01:33:27 UTC (rev 127953)
+++ trunk/LayoutTests/ChangeLog	2012-09-08 01:36:02 UTC (rev 127954)
@@ -1,3 +1,9 @@
+2012-09-07  James Robinson  jam...@chromium.org
+
+Skip some tests that appear to be making bots unstable.
+
+* platform/chromium/TestExpectations:
+
 2012-09-07  Victoria Kirst  v...@chromium.org
 
 Seek to end after duration change in HTMLMediaElement


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127953 => 127954)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-08 01:33:27 UTC (rev 127953)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-08 01:36:02 UTC (rev 127954)
@@ -3567,6 +3567,9 @@
 
 BUGWK95617 : fast/js/function-constructor-this-value.html = PASS TEXT
 
+// These tests appear to be making bots flaky. See bug for details.
+BUGWK96041 SKIP : platform/chromium-linux/compositing/gestures = PASS IMAGE
+
 //Require rebaseline after https://bugs.webkit.org/show_bug.cgi?id=80394
 BUGWK80394 MAC WIN : fast/block/margin-collapse/empty-clear-blocks.html = IMAGE+TEXT
 BUGWK80394 MAC WIN : fast/block/float/024.html = IMAGE+TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [127762] trunk/Source/WebCore

[jamesr]

Title: [127762] trunk/Source/WebCore








Revision 127762
Author jam...@google.com
Date 2012-09-06 11:13:21 -0700 (Thu, 06 Sep 2012)


Log Message
SharedGraphicsContext3D shouldn't depend on CCProxy
https://bugs.webkit.org/show_bug.cgi?id=95921

Reviewed by Adrienne Walker.

This class just wants to ASSERT() that we're on or not on the main thread. There's perfectly fine cross-platform
code in WTF to do that.

* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::getForImplThread):
(WebCore::SharedGraphicsContext3D::haveForImplThread):
(WebCore::SharedGraphicsContext3D::createForImplThread):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (127761 => 127762)

--- trunk/Source/WebCore/ChangeLog	2012-09-06 18:06:02 UTC (rev 127761)
+++ trunk/Source/WebCore/ChangeLog	2012-09-06 18:13:21 UTC (rev 127762)
@@ -1,3 +1,18 @@
+2012-09-05  James Robinson  jam...@chromium.org
+
+SharedGraphicsContext3D shouldn't depend on CCProxy
+https://bugs.webkit.org/show_bug.cgi?id=95921
+
+Reviewed by Adrienne Walker.
+
+This class just wants to ASSERT() that we're on or not on the main thread. There's perfectly fine cross-platform
+code in WTF to do that.
+
+* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
+(WebCore::SharedGraphicsContext3D::getForImplThread):
+(WebCore::SharedGraphicsContext3D::haveForImplThread):
+(WebCore::SharedGraphicsContext3D::createForImplThread):
+
 2012-09-06  Zan Dobersek  zandober...@gmail.com
 
 [Gtk] Remove configuration options for features that are not supported by the Gtk port


Modified: trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp (127761 => 127762)

--- trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp	2012-09-06 18:06:02 UTC (rev 127761)
+++ trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp	2012-09-06 18:13:21 UTC (rev 127762)
@@ -28,8 +28,8 @@
 
 #include SharedGraphicsContext3D.h
 
-#include CCProxy.h
 #include Extensions3D.h
+#include wtf/MainThread.h
 
 namespace WebCore {
 
@@ -89,19 +89,19 @@
 
 PassRefPtrGraphicsContext3D SharedGraphicsContext3D::getForImplThread()
 {
-ASSERT(CCProxy::isImplThread());
+ASSERT(!isMainThread());
 return getOrCreateContextForImplThread(Get);
 }
 
 bool SharedGraphicsContext3D::haveForImplThread()
 {
-ASSERT(CCProxy::isMainThread());
+ASSERT(isMainThread());
 return getOrCreateContextForImplThread(Get);
 }
 
 bool SharedGraphicsContext3D::createForImplThread()
 {
-ASSERT(CCProxy::isMainThread());
+ASSERT(isMainThread());
 return getOrCreateContextForImplThread(Create);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [127781] trunk/Source/WebKit/chromium

[jamesr]

Title: [127781] trunk/Source/WebKit/chromium








Revision 127781
Author jam...@google.com
Date 2012-09-06 13:55:13 -0700 (Thu, 06 Sep 2012)


Log Message
[chromium] Put chromium implementations of WTF symbols in separate static library
https://bugs.webkit.org/show_bug.cgi?id=95933

Reviewed by Adam Barth.

A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
component build is a DLL. This moves these files into a static library that webkit depends on so targets can
statically link in wtf and these support files without depending directly on webkit.

* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (127780 => 127781)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-06 20:19:40 UTC (rev 127780)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-06 20:55:13 UTC (rev 127781)
@@ -1,3 +1,17 @@
+2012-09-06  James Robinson  jam...@chromium.org
+
+[chromium] Put chromium implementations of WTF symbols in separate static library
+https://bugs.webkit.org/show_bug.cgi?id=95933
+
+Reviewed by Adam Barth.
+
+A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
+implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
+component build is a DLL. This moves these files into a static library that webkit depends on so targets can
+statically link in wtf and these support files without depending directly on webkit.
+
+* WebKit.gyp:
+
 2012-09-06  Iain Merrick  hu...@chromium.org
 
 [chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (127780 => 127781)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-09-06 20:19:40 UTC (rev 127780)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-09-06 20:55:13 UTC (rev 127781)
@@ -71,13 +71,14 @@
 'type': 'static_library',
 'variables': { 'enable_wexit_time_destructors': 1, },
 'dependencies': [
+'../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
 '../../WebCore/WebCore.gyp/WebCore.gyp:webcore',
-'../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
 '(chromium_src_dir)/skia/skia.gyp:skia',
+'(chromium_src_dir)/third_party/angle/src/build_angle.gyp:translator_glsl',
 '(chromium_src_dir)/third_party/icu/icu.gyp:icuuc',
 '(chromium_src_dir)/third_party/npapi/npapi.gyp:npapi',
-'(chromium_src_dir)/third_party/angle/src/build_angle.gyp:translator_glsl',
 '(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8',
+'webkit_wtf_support',
 ],
 'export_dependent_settings': [
 '../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
@@ -362,9 +363,6 @@
 'src/DateTimeChooserImpl.h',
 'src/ChromeClientImpl.cpp',
 'src/ChromeClientImpl.h',
-'src/ChromiumCurrentTime.cpp',
-'src/ChromiumOSRandomSource.cpp',
-'src/ChromiumThreading.cpp',
 'src/ColorChooserUIController.cpp',
 'src/ColorChooserUIController.h',
 'src/CompositionUnderlineBuilder.h',
@@ -865,6 +863,29 @@
 ],
 },
 {
+'target_name': 'webkit_wtf_support',
+'type': 'static_library',
+'dependencies': [
+'../../Platform/Platform.gyp/Platform.gyp:webkit_platform',
+'../../WTF/WTF.gyp/WTF.gyp:wtf',
+],
+'defines': [
+'WEBKIT_IMPLEMENTATION=1',
+],
+'sources': [
+'src/ChromiumCurrentTime.cpp',
+'src/ChromiumOSRandomSource.cpp',
+'src/ChromiumThreading.cpp',
+],
+'conditions': [
+['component==shared_library', {
+'defines': [
+'WEBKIT_DLL',
+],
+}],
+],
+},
+{
 'target_name': 'inspector_resources',
 'type': 'none',
 'dependencies': [






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [127787] trunk/Source/WebCore

[jamesr]

Title: [127787] trunk/Source/WebCore








Revision 127787
Author jam...@google.com
Date 2012-09-06 14:44:59 -0700 (Thu, 06 Sep 2012)


Log Message
[chromium] Split platform geometry types into separate static target
https://bugs.webkit.org/show_bug.cgi?id=96021

Reviewed by Tony Chang.

This moves several WebCore/platform geometry classes out of webcore_platform into a separate static library.
This library is relatively standalone and useful to statically link against in other contexts.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi




Diff

Modified: trunk/Source/WebCore/ChangeLog (127786 => 127787)

--- trunk/Source/WebCore/ChangeLog	2012-09-06 21:41:34 UTC (rev 127786)
+++ trunk/Source/WebCore/ChangeLog	2012-09-06 21:44:59 UTC (rev 127787)
@@ -1,3 +1,16 @@
+2012-09-06  James Robinson  jam...@chromium.org
+
+[chromium] Split platform geometry types into separate static target
+https://bugs.webkit.org/show_bug.cgi?id=96021
+
+Reviewed by Tony Chang.
+
+This moves several WebCore/platform geometry classes out of webcore_platform into a separate static library.
+This library is relatively standalone and useful to statically link against in other contexts.
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+
 2012-09-06  Kenneth Rohde Christiansen  kenn...@webkit.org
 
 [EFL] Fuzzy load the Edje theme for HTML forms


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (127786 => 127787)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-09-06 21:41:34 UTC (rev 127786)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-09-06 21:44:59 UTC (rev 127787)
@@ -1900,6 +1900,19 @@
   ],
 },
 {
+  'target_name': 'webcore_platform_geometry',
+  'type': 'static_library',
+  'dependencies': [
+'webcore_prerequisites',
+  ],
+  'defines': [
+'WEBKIT_IMPLEMENTATION=1',
+  ],
+  'sources': [
+'@(webcore_platform_geometry_files)',
+  ],
+},
+{
   'target_name': 'webcore_chromium_compositor',
   'type': 'static_library',
   'dependencies': [
@@ -2130,6 +2143,7 @@
 'webcore_dom',
 'webcore_html',
 'webcore_platform',
+'webcore_platform_geometry',
 'webcore_remaining',
 'webcore_rendering',
 # Exported.


Modified: trunk/Source/WebCore/WebCore.gypi (127786 => 127787)

--- trunk/Source/WebCore/WebCore.gypi	2012-09-06 21:41:34 UTC (rev 127786)
+++ trunk/Source/WebCore/WebCore.gypi	2012-09-06 21:44:59 UTC (rev 127787)
@@ -4735,11 +4735,6 @@
 'platform/graphics/CrossfadeGeneratedImage.cpp',
 'platform/graphics/CrossfadeGeneratedImage.h',
 'platform/graphics/Extensions3D.h',
-'platform/graphics/FloatPoint.cpp',
-'platform/graphics/FloatPoint3D.cpp',
-'platform/graphics/FloatQuad.cpp',
-'platform/graphics/FloatRect.cpp',
-'platform/graphics/FloatSize.cpp',
 'platform/graphics/Font.cpp',
 'platform/graphics/FontCache.cpp',
 'platform/graphics/FontData.cpp',
@@ -4751,7 +4746,6 @@
 'platform/graphics/FontPlatformData.cpp',
 'platform/graphics/FontPlatformData.h',
 'platform/graphics/FractionalLayoutBoxExtent.cpp',
-'platform/graphics/FractionalLayoutRect.cpp',
 'platform/graphics/GeneratorGeneratedImage.cpp',
 'platform/graphics/GeneratedImage.cpp',
 'platform/graphics/GeneratedImage.h',
@@ -4769,7 +4763,6 @@
 'platform/graphics/ImageBuffer.cpp',
 'platform/graphics/ImageOrientation.cpp',
 'platform/graphics/ImageSource.cpp',
-'platform/graphics/IntRect.cpp',
 'platform/graphics/MediaPlayer.cpp',
 'platform/graphics/MediaPlayerPrivate.h',
 'platform/graphics/NativeImagePtr.h' ,
@@ -4777,7 +4770,6 @@
 'platform/graphics/PathTraversalState.cpp',
 'platform/graphics/PathTraversalState.h',
 'platform/graphics/Pattern.cpp',
-'platform/graphics/Region.cpp',
 'platform/graphics/RoundedRect.cpp',
 'platform/graphics/SegmentedFontData.cpp',
 'platform/graphics/SegmentedFontData.h',
@@ -5011,8 +5003,6 @@
 'platform/graphics/gpu/SharedGraphicsContext3D.h',
 'platform/graphics/gpu/Texture.cpp',
 'platform/graphics/gpu/Texture.h',
-'platform/graphics/gpu/TilingData.cpp',
-'platform/graphics/gpu/TilingData.h',
 'platform/graphics/gpu/mac/DrawingBufferMac.mm',
 'platform/graphics/gpu/qt/DrawingBufferQt.cpp',
 'platform/graphics/gstreamer/GRefPtrGStreamer.cpp',
@@ -5201,7 +5191,6 @@
 

[webkit-changes] [127792] trunk/Source/WebKit/chromium

[jamesr]

Title: [127792] trunk/Source/WebKit/chromium








Revision 127792
Author jam...@google.com
Date 2012-09-06 16:16:14 -0700 (Thu, 06 Sep 2012)


Log Message
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot webkit.review@gmail.com on 2012-09-06

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (127791 => 127792)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-06 23:14:08 UTC (rev 127791)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-06 23:16:14 UTC (rev 127792)
@@ -1,3 +1,9 @@
+2012-09-06  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed.  Rolled DEPS.
+
+* DEPS:
+
 2012-09-06  Alec Flett  alecfl...@chromium.org
 
 IndexedDB: make IDBKeyPath's string and array constructors explicit


Modified: trunk/Source/WebKit/chromium/DEPS (127791 => 127792)

--- trunk/Source/WebKit/chromium/DEPS	2012-09-06 23:14:08 UTC (rev 127791)
+++ trunk/Source/WebKit/chromium/DEPS	2012-09-06 23:16:14 UTC (rev 127792)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '155144'
+  'chromium_rev': '155215'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [127796] trunk/Source/Platform

[jamesr]

Title: [127796] trunk/Source/Platform








Revision 127796
Author jam...@google.com
Date 2012-09-06 16:21:22 -0700 (Thu, 06 Sep 2012)


Log Message
[chromium] Export public functions on WebTransformationMatrix so they can be used outside of WebKit.dll
https://bugs.webkit.org/show_bug.cgi?id=96025

Reviewed by Adrienne Walker.

* chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebTransformationMatrix.h




Diff

Modified: trunk/Source/Platform/ChangeLog (127795 => 127796)

--- trunk/Source/Platform/ChangeLog	2012-09-06 23:21:09 UTC (rev 127795)
+++ trunk/Source/Platform/ChangeLog	2012-09-06 23:21:22 UTC (rev 127796)
@@ -1,5 +1,15 @@
 2012-09-06  James Robinson  jam...@chromium.org
 
+[chromium] Export public functions on WebTransformationMatrix so they can be used outside of WebKit.dll
+https://bugs.webkit.org/show_bug.cgi?id=96025
+
+Reviewed by Adrienne Walker.
+
+* chromium/public/WebTransformationMatrix.h:
+(WebTransformationMatrix):
+
+2012-09-06  James Robinson  jam...@chromium.org
+
 [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
 https://bugs.webkit.org/show_bug.cgi?id=96007
 


Modified: trunk/Source/Platform/chromium/public/WebTransformationMatrix.h (127795 => 127796)

--- trunk/Source/Platform/chromium/public/WebTransformationMatrix.h	2012-09-06 23:21:09 UTC (rev 127795)
+++ trunk/Source/Platform/chromium/public/WebTransformationMatrix.h	2012-09-06 23:21:22 UTC (rev 127796)
@@ -45,93 +45,93 @@
 
 class WebTransformationMatrix {
 public:
-WebTransformationMatrix();
-WebTransformationMatrix(double a, double b, double c, double d, double e, double f);
-WebTransformationMatrix(double m11, double m12, double m13, double m14,
-double m21, double m22, double m23, double m24,
-double m31, double m32, double m33, double m34,
-double m41, double m42, double m43, double m44);
-WebTransformationMatrix(const WebTransformationMatrix);
+WEBKIT_EXPORT WebTransformationMatrix();
+WEBKIT_EXPORT WebTransformationMatrix(double a, double b, double c, double d, double e, double f);
+WEBKIT_EXPORT WebTransformationMatrix(double m11, double m12, double m13, double m14,
+  double m21, double m22, double m23, double m24,
+  double m31, double m32, double m33, double m34,
+  double m41, double m42, double m43, double m44);
+WEBKIT_EXPORT WebTransformationMatrix(const WebTransformationMatrix);
 ~WebTransformationMatrix() { }
 
 // Operations that return a separate matrix and do not modify this one.
-WebTransformationMatrix inverse() const;
-WebTransformationMatrix to2dTransform() const;
+WEBKIT_EXPORT WebTransformationMatrix inverse() const;
+WEBKIT_EXPORT WebTransformationMatrix to2dTransform() const;
 
-WebTransformationMatrix operator=(const WebTransformationMatrix);
-bool operator==(const WebTransformationMatrix) const;
-WebTransformationMatrix operator*(const WebTransformationMatrix) const;
+WEBKIT_EXPORT WebTransformationMatrix operator=(const WebTransformationMatrix);
+WEBKIT_EXPORT bool operator==(const WebTransformationMatrix) const;
+WEBKIT_EXPORT WebTransformationMatrix operator*(const WebTransformationMatrix) const;
 
 // Operations that modify this matrix
-void multiply(const WebTransformationMatrix);
-void makeIdentity();
-void translate(double tx, double ty);
-void translate3d(double tx, double ty, double tz);
-void translateRight3d(double tx, double ty, double tz);
-void scale(double s);
-void scaleNonUniform(double sx, double sy);
-void scale3d(double sx, double sy, double sz);
-void rotate(double angle);
-void rotate3d(double rx, double ry, double rz);
-void rotate3d(double x, double y, double z, double angle);
-void skewX(double angle);
-void skewY(double angle);
-void applyPerspective(double p);
-void blend(const WebTransformationMatrix from, double progress);
+WEBKIT_EXPORT void multiply(const WebTransformationMatrix);
+WEBKIT_EXPORT void makeIdentity();
+WEBKIT_EXPORT void translate(double tx, double ty);
+WEBKIT_EXPORT void translate3d(double tx, double ty, double tz);
+WEBKIT_EXPORT void translateRight3d(double tx, double ty, double tz);
+WEBKIT_EXPORT void scale(double s);
+WEBKIT_EXPORT void scaleNonUniform(double sx, double sy);
+WEBKIT_EXPORT void scale3d(double sx, double sy, double sz);
+WEBKIT_EXPORT void rotate(double angle);
+WEBKIT_EXPORT void rotate3d(double rx, double ry, double rz);
+WEBKIT_EXPORT void rotate3d(double x, double y, double z, double angle);
+WEBKIT_EXPORT void skewX(double angle);
+

[webkit-changes] [127800] trunk/Source

[jamesr]

Title: [127800] trunk/Source








Revision 127800
Author jam...@google.com
Date 2012-09-06 16:50:59 -0700 (Thu, 06 Sep 2012)


Log Message
[chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
https://bugs.webkit.org/show_bug.cgi?id=96024

Reviewed by Adam Barth.

When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
We don't need to link anything in to WebKit.dll.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

* WebKit.gyp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/WebKit.gypi




Diff

Modified: trunk/Source/WebCore/ChangeLog (127799 => 127800)

--- trunk/Source/WebCore/ChangeLog	2012-09-06 23:41:29 UTC (rev 127799)
+++ trunk/Source/WebCore/ChangeLog	2012-09-06 23:50:59 UTC (rev 127800)
@@ -1,3 +1,15 @@
+2012-09-06  James Robinson  jam...@chromium.org
+
+[chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
+https://bugs.webkit.org/show_bug.cgi?id=96024
+
+Reviewed by Adam Barth.
+
+When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
+We don't need to link anything in to WebKit.dll.
+
+* WebCore.gyp/WebCore.gyp:
+
 2012-09-06  Simon Fraser  simon.fra...@apple.com
 
 Parcel up logic related to sticky positioning into a Constraints class that will later be used for threaded scrolling


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (127799 => 127800)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-09-06 23:41:29 UTC (rev 127799)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-09-06 23:50:59 UTC (rev 127800)
@@ -46,8 +46,6 @@
 # binary and increasing the speed of gdb.
 'enable_svg%': 1,
 
-# If set to 1, links against the cc library from the chromium repository
-# instead of the compositor implementation files in platform/graphics/chromium
 'use_libcc_for_compositor%': 0,
 
 'enable_wexit_time_destructors': 1,
@@ -2214,12 +2212,8 @@
 'webcore_svg',
   ],
 }],
-['use_libcc_for_compositor==1', {
+['use_libcc_for_compositor==0', {
   'dependencies': [
-'(chromium_src_dir)/cc/cc.gyp:cc'
-  ],
-}, { # use_libcc_for_compositor==0
-  'dependencies': [
 'webcore_chromium_compositor'
   ],
 }]


Modified: trunk/Source/WebKit/chromium/ChangeLog (127799 => 127800)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-06 23:41:29 UTC (rev 127799)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-06 23:50:59 UTC (rev 127800)
@@ -1,5 +1,17 @@
 2012-09-06  James Robinson  jam...@chromium.org
 
+[chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
+https://bugs.webkit.org/show_bug.cgi?id=96024
+
+Reviewed by Adam Barth.
+
+When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
+We don't need to link anything in to WebKit.dll.
+
+* WebKit.gyp:
+
+2012-09-06  James Robinson  jam...@chromium.org
+
 [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
 https://bugs.webkit.org/show_bug.cgi?id=96007
 


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (127799 => 127800)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-09-06 23:41:29 UTC (rev 127799)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-09-06 23:50:59 UTC (rev 127800)
@@ -54,7 +54,7 @@
 # stored as is. Otherwise, a concatenated file is stored.
 'debug_devtools%': 0,
 
-# If set to 1, links against the compositor bindings from the chromium repository
+# If set to 1, uses the compositor bindings provided by PlatformSupport
 # instead of the compositor-implementation binding files in WebKit/chromium/src.
 'use_libcc_for_compositor%': 0,
 
@@ -838,9 +838,6 @@
 },
 }],
 ['use_libcc_for_compositor==1', {
-'dependencies': [
-'(chromium_src_dir)/webkit/compositor_bindings/compositor_bindings.gyp:webkit_compositor_bindings',
-],
 'sources!': [
 '../../WebCore/platform/chromium/support/CCThreadImpl.cpp',
 '../../WebCore/platform/chromium/support/CCThreadImpl.h',


Modified: trunk/Source/WebKit/chromium/WebKit.gypi (127799 => 127800)

--- trunk/Source/WebKit/chromium/WebKit.gypi	2012-09-06 23:41:29 UTC (rev 127799)
+++ trunk/Source/WebKit/chromium/WebKit.gypi	2012-09-06 23:50:59 UTC (rev 127800)
@@ -101,8 +101,8 @@
 'tests/TreeTestHelpers.h',
 'tests/URLTestHelpers.cpp',
 

[webkit-changes] [127672] trunk/Source

[jamesr]

Title: [127672] trunk/Source








Revision 127672
Author jam...@google.com
Date 2012-09-05 18:16:45 -0700 (Wed, 05 Sep 2012)


Log Message
[chromium] Move static WebCompositor functions to WebCompositorSupport
https://bugs.webkit.org/show_bug.cgi?id=95785

Reviewed by Darin Fisher.

The statics on WebCompositor need to be moved to WebCompositorSupport so the embedder can inject an
implementation for these via PlatformSupport. This adds the interface for the statics to WebCompositorSupport.
After an implementation of these lands on the chromium side, I'll switch all callers over to use these and
remove the WebCompositor interface from the API.

* chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
(WebKit::WebCompositorSupport::initialize):
(WebKit::WebCompositorSupport::threadingEnabled):
(WebKit::WebCompositorSupport::shutdown):
(WebKit::WebCompositorSupport::setPerTilePaintingEnabled):
(WebKit::WebCompositorSupport::setPartialSwapEnabled):
(WebKit::WebCompositorSupport::setAcceleratedAnimationEnabled):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebCompositor.h
trunk/Source/Platform/chromium/public/WebCompositorSupport.h
trunk/Source/WebCore/platform/chromium/support/WebCompositorImpl.cpp
trunk/Source/WebCore/platform/chromium/support/WebCompositorImpl.h
trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.cpp
trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (127671 => 127672)

--- trunk/Source/Platform/ChangeLog	2012-09-06 01:16:40 UTC (rev 127671)
+++ trunk/Source/Platform/ChangeLog	2012-09-06 01:16:45 UTC (rev 127672)
@@ -1,3 +1,24 @@
+2012-09-05  James Robinson  jam...@chromium.org
+
+[chromium] Move static WebCompositor functions to WebCompositorSupport
+https://bugs.webkit.org/show_bug.cgi?id=95785
+
+Reviewed by Darin Fisher.
+
+The statics on WebCompositor need to be moved to WebCompositorSupport so the embedder can inject an
+implementation for these via PlatformSupport. This adds the interface for the statics to WebCompositorSupport.
+After an implementation of these lands on the chromium side, I'll switch all callers over to use these and
+remove the WebCompositor interface from the API.
+
+* chromium/public/WebCompositorSupport.h:
+(WebCompositorSupport):
+(WebKit::WebCompositorSupport::initialize):
+(WebKit::WebCompositorSupport::threadingEnabled):
+(WebKit::WebCompositorSupport::shutdown):
+(WebKit::WebCompositorSupport::setPerTilePaintingEnabled):
+(WebKit::WebCompositorSupport::setPartialSwapEnabled):
+(WebKit::WebCompositorSupport::setAcceleratedAnimationEnabled):
+
 2012-09-05  Mark Pilgrim  pilg...@chromium.org
 
 [Chromium] Remove getRenderStyleForStrike from PlatformSupport


Modified: trunk/Source/Platform/chromium/public/WebCompositor.h (127671 => 127672)

--- trunk/Source/Platform/chromium/public/WebCompositor.h	2012-09-06 01:16:40 UTC (rev 127671)
+++ trunk/Source/Platform/chromium/public/WebCompositor.h	2012-09-06 01:16:45 UTC (rev 127672)
@@ -44,7 +44,7 @@
 WEBKIT_EXPORT static void initialize(WebThread*);
 
 // Returns whether the compositor was initialized with threading enabled.
-WEBKIT_EXPORT static bool threadingEnabled();
+WEBKIT_EXPORT static bool isThreadingEnabled();
 
 // Shuts down the compositor. This must be called when all compositor data
 // types have been deleted. No compositor classes or methods should be used


Modified: trunk/Source/Platform/chromium/public/WebCompositorSupport.h (127671 => 127672)

--- trunk/Source/Platform/chromium/public/WebCompositorSupport.h	2012-09-06 01:16:40 UTC (rev 127671)
+++ trunk/Source/Platform/chromium/public/WebCompositorSupport.h	2012-09-06 01:16:45 UTC (rev 127672)
@@ -46,12 +46,31 @@
 class WebScrollbarLayer;
 class WebScrollbarThemeGeometry;
 class WebSolidColorLayer;
+class WebThread;
 class WebTransformAnimationCurve;
 class WebVideoFrameProvider;
 class WebVideoLayer;
 
 class WebCompositorSupport {
 public:
+// Initializes the compositor. Threaded compositing is enabled by passing in
+// a non-null WebThread. No compositor classes or methods should be used
+// prior to calling initialize.
+virtual void initialize(WebThread*) { }
+
+// Returns whether the compositor was initialized with threading enabled.
+virtual bool isThreadingEnabled() { return false; }
+
+// Shuts down the compositor. This must be called when all compositor data
+// types have been deleted. No compositor classes or methods should be used
+// after shutdown.
+virtual void shutdown() { }
+
+// These may only be called before initialize.
+virtual void setPerTilePaintingEnabled(bool) { }
+virtual void setPartialSwapEnabled(bool) { }
+virtual void 

[webkit-changes] [127693] trunk/Source/WebCore

[jamesr]

Title: [127693] trunk/Source/WebCore








Revision 127693
Author jam...@google.com
Date 2012-09-05 22:28:45 -0700 (Wed, 05 Sep 2012)


Log Message
Unreviewed chromium windows build fix.

Some of the rules in webcore_remaining only apply to files under WebCore/platform/. Since r127687 moved all such
files from the webcore_files variable to webcore_platform_files, these rules have to be applied to
webcore_platform instead. This also means that these files link into webcore_platform instead of
webcore_remaining, which makes a lot more sense, and we can delete several redundant rules.

* WebCore.gyp/WebCore.gyp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp




Diff

Modified: trunk/Source/WebCore/ChangeLog (127692 => 127693)

--- trunk/Source/WebCore/ChangeLog	2012-09-06 05:10:15 UTC (rev 127692)
+++ trunk/Source/WebCore/ChangeLog	2012-09-06 05:28:45 UTC (rev 127693)
@@ -1,3 +1,14 @@
+2012-09-05  James Robinson  jam...@chromium.org
+
+Unreviewed chromium windows build fix.
+
+Some of the rules in webcore_remaining only apply to files under WebCore/platform/. Since r127687 moved all such
+files from the webcore_files variable to webcore_platform_files, these rules have to be applied to
+webcore_platform instead. This also means that these files link into webcore_platform instead of
+webcore_remaining, which makes a lot more sense, and we can delete several redundant rules.
+
+* WebCore.gyp/WebCore.gyp:
+
 2012-09-05  Nate Chapin  jap...@chromium.org
 
 [chromium] Some SubstituteData loads broken after r121912


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (127692 => 127693)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-09-06 05:10:15 UTC (rev 127692)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-09-06 05:28:45 UTC (rev 127693)
@@ -1848,6 +1848,10 @@
   'sources/': [
 ['exclude', 'Posix\\.cpp$'],
 
+['include', '/opentype/'],
+['include', '/SkiaFontWin\\.cpp$'],
+['include', '/TransparencyWin\\.cpp$'],
+
 # The Chromium Win currently uses GlyphPageTreeNodeChromiumWin.cpp from
 # platform/graphics/chromium, included by regex above, instead.
 ['exclude', 'platform/graphics/skia/FontCacheSkia\\.cpp$'],
@@ -2085,19 +2089,6 @@
 ['OS==win and buildtype==Official', {
   'msvs_shard': 10,
 }],
-['OS==win', {
-  'sources/': [
-['exclude', 'Posix\\.cpp$'],
-['include', '/opentype/'],
-['include', '/SkiaFontWin\\.cpp$'],
-['include', '/TransparencyWin\\.cpp$'],
-  ],
-},{ # OS!=win
-  'sources/': [
-['exclude', 'Win\\.cpp$'],
-['exclude', '/(Windows|Uniscribe)[^/]*\\.cpp$']
-  ],
-}],
 ['os_posix == 1 and OS != mac and gcc_version == 42', {
   # Due to a bug in gcc 4.2.1 (the current version on hardy), we get
   # warnings about uninitialized this.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [127378] trunk/Source/WebKit/chromium

[jamesr]

Title: [127378] trunk/Source/WebKit/chromium








Revision 127378
Author jam...@google.com
Date 2012-09-01 12:06:10 -0700 (Sat, 01 Sep 2012)


Log Message
Unreviewed chromium buildfix when use_libcc_for_compositor=1

This gyp target was renamed downstream.

* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (127377 => 127378)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-01 18:16:19 UTC (rev 127377)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-01 19:06:10 UTC (rev 127378)
@@ -1,3 +1,11 @@
+2012-09-01  James Robinson  jam...@chromium.org
+
+Unreviewed chromium buildfix when use_libcc_for_compositor=1
+
+This gyp target was renamed downstream.
+
+* WebKit.gyp:
+
 2012-09-01  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Add MediaStream management to RTCPeerConnection


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (127377 => 127378)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-09-01 18:16:19 UTC (rev 127377)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-09-01 19:06:10 UTC (rev 127378)
@@ -839,7 +839,7 @@
 }],
 ['use_libcc_for_compositor==1', {
 'dependencies': [
-'(chromium_src_dir)/webkit/compositor/compositor.gyp:webkit_compositor',
+'(chromium_src_dir)/webkit/compositor_bindings/compositor_bindings.gyp:webkit_compositor_bindings',
 ],
 'sources!': [
 '../../WebCore/platform/chromium/support/CCThreadImpl.cpp',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [127336] trunk/Source/WebKit/chromium

[jamesr]

Title: [127336] trunk/Source/WebKit/chromium








Revision 127336
Author jam...@google.com
Date 2012-08-31 16:46:52 -0700 (Fri, 31 Aug 2012)


Log Message
[chromium] Clean up Web*Layer initialization paths
https://bugs.webkit.org/show_bug.cgi?id=95523

Reviewed by Darin Fisher.

Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling
implementation. Also normalizes naming conventions in these files.

* src/WebAnimationImpl.cpp:
(WebKit::WebAnimation::create):
(WebKit::WebAnimationImpl::WebAnimationImpl):
* src/WebAnimationImpl.h:
(WebAnimationImpl):
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::layer):
(WebKit::WebContentLayerImpl::setDoubleSided):
(WebKit::WebContentLayerImpl::setContentsScale):
(WebKit::WebContentLayerImpl::setUseLCDText):
(WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebFloatAnimationCurveImpl.cpp:
(WebKit::WebFloatAnimationCurve::create):
(WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
* src/WebFloatAnimationCurveImpl.h:
(WebFloatAnimationCurveImpl):
* src/WebIOSurfaceLayerImpl.cpp:
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
* src/WebIOSurfaceLayerImpl.h:
(WebIOSurfaceLayerImpl):
* src/WebImageLayerImpl.cpp:
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayerImpl::WebImageLayerImpl):
* src/WebImageLayerImpl.h:
(WebImageLayerImpl):
* src/WebLayerImpl.cpp:
(WebKit::WebLayer::create):
(WebKit):
(WebKit::WebLayerImpl::WebLayerImpl):
* src/WebLayerImpl.h:
(WebLayerImpl):
* src/WebScrollbarLayerImpl.cpp:
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
* src/WebScrollbarLayerImpl.h:
(WebScrollbarLayerImpl):
* src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
* src/WebSolidColorLayerImpl.h:
(WebSolidColorLayerImpl):
* src/WebTransformAnimationCurveImpl.cpp:
(WebKit::WebTransformAnimationCurve::create):
(WebKit::WebTransformAnimationCurveImpl::WebTransformAnimationCurveImpl):
* src/WebTransformAnimationCurveImpl.h:
(WebTransformAnimationCurveImpl):
* src/WebVideoLayerImpl.cpp:
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
* src/WebVideoLayerImpl.h:
(WebVideoLayerImpl):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebAnimationImpl.cpp
trunk/Source/WebKit/chromium/src/WebAnimationImpl.h
trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebContentLayerImpl.h
trunk/Source/WebKit/chromium/src/WebFloatAnimationCurveImpl.cpp
trunk/Source/WebKit/chromium/src/WebFloatAnimationCurveImpl.h
trunk/Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.h
trunk/Source/WebKit/chromium/src/WebImageLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebImageLayerImpl.h
trunk/Source/WebKit/chromium/src/WebLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebLayerImpl.h
trunk/Source/WebKit/chromium/src/WebScrollbarLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebScrollbarLayerImpl.h
trunk/Source/WebKit/chromium/src/WebSolidColorLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebSolidColorLayerImpl.h
trunk/Source/WebKit/chromium/src/WebTransformAnimationCurveImpl.cpp
trunk/Source/WebKit/chromium/src/WebTransformAnimationCurveImpl.h
trunk/Source/WebKit/chromium/src/WebVideoLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebVideoLayerImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (127335 => 127336)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-08-31 23:42:35 UTC (rev 127335)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-08-31 23:46:52 UTC (rev 127336)
@@ -1,3 +1,70 @@
+2012-08-31  James Robinson  jam...@chromium.org
+
+[chromium] Clean up Web*Layer initialization paths
+https://bugs.webkit.org/show_bug.cgi?id=95523
+
+Reviewed by Darin Fisher.
+
+Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling
+implementation. Also normalizes naming conventions in these files.
+
+* src/WebAnimationImpl.cpp:
+(WebKit::WebAnimation::create):
+(WebKit::WebAnimationImpl::WebAnimationImpl):
+* src/WebAnimationImpl.h:
+(WebAnimationImpl):
+* src/WebContentLayerImpl.cpp:
+(WebKit::WebContentLayerImpl::WebContentLayerImpl):
+(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
+(WebKit::WebContentLayerImpl::layer):
+(WebKit::WebContentLayerImpl::setDoubleSided):
+(WebKit::WebContentLayerImpl::setContentsScale):
+(WebKit::WebContentLayerImpl::setUseLCDText):
+

[webkit-changes] [127172] trunk/Source

[jamesr]

Title: [127172] trunk/Source








Revision 127172
Author jam...@google.com
Date 2012-08-30 12:52:42 -0700 (Thu, 30 Aug 2012)


Log Message
[chromium] Add CompositorSupport interface for constructing compositor classes
https://bugs.webkit.org/show_bug.cgi?id=95040

Reviewed by Darin Fisher.

Source/Platform:

Adds a WebCompositorSupport interface as a tear-off of PlatformSupport so the embedder can handle provide
implementations of compositor interfaces.

Adds a new WebPassOwnPtr type for use when the caller of an API must take ownership of the provided parameter.

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(WebKit::Platform::compositorSupport):
(Platform):
* chromium/public/WebCompositorSupport.h: Added.
(WebKit):
(WebCompositorSupport):
(WebKit::WebCompositorSupport::~WebCompositorSupport):

Source/WebCore:

Uses WebCompositorSupport interfaces where appropriate to construct compositor types.

* platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::createWebAnimation):
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

Source/WebKit/chromium:

* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimation):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
* src/WebMediaPlayerClientImpl.h:
(WebKit):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
* src/WebPluginContainerImpl.h:
(WebKit):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/Platform/chromium/public/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp
trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.cpp
trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/LinkHighlight.cpp
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h


Added Paths

trunk/Source/Platform/chromium/public/WebCompositorSupport.h
trunk/Source/Platform/chromium/public/WebPassOwnPtr.h




Diff

Modified: trunk/Source/Platform/ChangeLog (127171 => 127172)

--- trunk/Source/Platform/ChangeLog	2012-08-30 19:46:13 UTC (rev 127171)
+++ trunk/Source/Platform/ChangeLog	2012-08-30 19:52:42 UTC (rev 127172)
@@ -1,3 +1,25 @@
+2012-08-27  James Robinson  jam...@chromium.org
+
+[chromium] Add CompositorSupport interface for constructing compositor classes
+https://bugs.webkit.org/show_bug.cgi?id=95040
+
+Reviewed by Darin Fisher.
+
+Adds a WebCompositorSupport interface as a tear-off of PlatformSupport so the embedder can handle provide
+implementations of compositor interfaces.
+
+Adds a new WebPassOwnPtr type for use when the caller of an API must take ownership of the provided parameter.
+
+* Platform.gypi:
+* chromium/public/Platform.h:
+(WebKit):
+(WebKit::Platform::compositorSupport):
+(Platform):
+* chromium/public/WebCompositorSupport.h: Added.
+(WebKit):
+(WebCompositorSupport):
+(WebKit::WebCompositorSupport::~WebCompositorSupport):
+
 2012-08-30  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Introduce MediaConstraints


Modified: trunk/Source/Platform/Platform.gypi (127171 => 127172)

--- trunk/Source/Platform/Platform.gypi	2012-08-30 19:46:13 UTC (rev 127171)
+++ trunk/Source/Platform/Platform.gypi	2012-08-30 19:52:42 UTC (rev 127172)
@@ -44,6 +44,8 @@
 'chromium/public/WebClipboard.h',
 'chromium/public/WebColor.h',
 'chromium/public/WebCommon.h',
+'chromium/public/WebCompositor.h',
+'chromium/public/WebCompositorSurface.h',
 'chromium/public/WebCompositorOutputSurface.h',
 'chromium/public/WebCompositorOutputSurfaceClient.h',
 'chromium/public/WebContentLayer.h',
@@ -92,6 +94,7 @@
 'chromium/public/WebMessagePortChannelClient.h',
 'chromium/public/WebMimeRegistry.h',
 'chromium/public/WebNonCopyable.h',
+

[webkit-changes] [127175] trunk/Source/WebKit/chromium

[jamesr]

Title: [127175] trunk/Source/WebKit/chromium








Revision 127175
Author jam...@google.com
Date 2012-08-30 13:02:02 -0700 (Thu, 30 Aug 2012)


Log Message
[chromium] Make webkit_compositor specific unit test compilation conditional on gyp var
https://bugs.webkit.org/show_bug.cgi?id=95401

Reviewed by Dirk Pranke.

If use_libcc_for_compositor is set, these tests are being compiled and run elsewhere.

* WebKit.gyp:
* WebKit.gypi:
* WebKitUnitTests.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/WebKit.gypi
trunk/Source/WebKit/chromium/WebKitUnitTests.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (127174 => 127175)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-08-30 20:01:23 UTC (rev 127174)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-08-30 20:02:02 UTC (rev 127175)
@@ -1,3 +1,16 @@
+2012-08-30  James Robinson  jam...@chromium.org
+
+[chromium] Make webkit_compositor specific unit test compilation conditional on gyp var
+https://bugs.webkit.org/show_bug.cgi?id=95401
+
+Reviewed by Dirk Pranke.
+
+If use_libcc_for_compositor is set, these tests are being compiled and run elsewhere.
+
+* WebKit.gyp:
+* WebKit.gypi:
+* WebKitUnitTests.gyp:
+
 2012-08-27  James Robinson  jam...@chromium.org
 
 [chromium] Add CompositorSupport interface for constructing compositor classes


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (127174 => 127175)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-08-30 20:01:23 UTC (rev 127174)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-08-30 20:02:02 UTC (rev 127175)
@@ -738,6 +738,11 @@
   'WARNING_CFLAGS!': ['-Wglobal-constructors'],
 },
 }],
+['use_libcc_for_compositor==0', {
+'sources': [
+'@(webkit_compositor_unittest_files)',
+],
+}],
 ],
 'msvs_settings': {
   'VCLinkerTool': {


Modified: trunk/Source/WebKit/chromium/WebKit.gypi (127174 => 127175)

--- trunk/Source/WebKit/chromium/WebKit.gypi	2012-08-30 20:01:23 UTC (rev 127174)
+++ trunk/Source/WebKit/chromium/WebKit.gypi	2012-08-30 20:02:02 UTC (rev 127175)
@@ -57,6 +57,63 @@
 'tests/AssociatedURLLoaderTest.cpp',
 'tests/Canvas2DLayerBridgeTest.cpp',
 'tests/Canvas2DLayerManagerTest.cpp',
+'tests/ClipboardChromiumTest.cpp',
+'tests/ContentLayerChromiumTest.cpp',
+'tests/DateTimeFormatTest.cpp',
+'tests/DecimalTest.cpp',
+'tests/DragImageTest.cpp',
+'tests/EventListenerTest.cpp',
+'tests/FloatQuadTest.cpp',
+'tests/FrameLoaderClientImplTest.cpp',
+'tests/FrameTestHelpers.cpp',
+'tests/FrameTestHelpers.h',
+'tests/GraphicsLayerChromiumTest.cpp',
+'tests/IDBAbortOnCorruptTest.cpp',
+'tests/IDBBindingUtilitiesTest.cpp',
+'tests/IDBDatabaseBackendTest.cpp',
+'tests/IDBFakeBackingStore.h',
+'tests/IDBKeyPathTest.cpp',
+'tests/IDBLevelDBCodingTest.cpp',
+'tests/IDBRequestTest.cpp',
+'tests/ImageLayerChromiumTest.cpp',
+'tests/KeyboardTest.cpp',
+'tests/KURLTest.cpp',
+'tests/LevelDBTest.cpp',
+'tests/LinkHighlightTest.cpp',
+'tests/ListenerLeakTest.cpp',
+'tests/MemoryInfo.cpp',
+'tests/MemoryInstrumentationTest.cpp',
+'tests/OpaqueRectTrackingContentLayerDelegateTest.cpp',
+'tests/OpenTypeVerticalDataTest.cpp',
+'tests/PaintAggregatorTest.cpp',
+'tests/PlatformGestureCurveTest.cpp',
+'tests/PlatformContextSkiaTest.cpp',
+'tests/PODArenaTest.cpp',
+'tests/PODIntervalTreeTest.cpp',
+'tests/PODRedBlackTreeTest.cpp',
+'tests/PopupContainerTest.cpp',
+'tests/RegionTest.cpp',
+'tests/RenderTableCellTest.cpp',
+'tests/RenderTableRowTest.cpp',
+'tests/ScrollbarLayerChromiumTest.cpp',
+'tests/TilingDataTest.cpp',
+'tests/TreeTestHelpers.cpp',
+'tests/TreeTestHelpers.h',
+'tests/URLTestHelpers.cpp',
+'tests/URLTestHelpers.h',
+'tests/WebCompositorInputHandlerImplTest.cpp',
+'tests/WebFrameTest.cpp',
+'tests/WebMediaPlayerClientImplTest.cpp',
+'tests/WebPageNewSerializerTest.cpp',
+'tests/WebPageSerializerTest.cpp',
+'tests/WebSocketDeflaterTest.cpp',
+

[webkit-changes] [127194] trunk/Source/Platform

[jamesr]

Title: [127194] trunk/Source/Platform








Revision 127194
Author jam...@google.com
Date 2012-08-30 14:41:22 -0700 (Thu, 30 Aug 2012)


Log Message
Chromium win build fix - fix typo in gypi

* Platform.gypi:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi




Diff

Modified: trunk/Source/Platform/ChangeLog (127193 => 127194)

--- trunk/Source/Platform/ChangeLog	2012-08-30 21:40:39 UTC (rev 127193)
+++ trunk/Source/Platform/ChangeLog	2012-08-30 21:41:22 UTC (rev 127194)
@@ -1,3 +1,9 @@
+2012-08-30  James Robinson  jam...@chromium.org
+
+Chromium win build fix - fix typo in gypi
+
+* Platform.gypi:
+
 2012-08-27  James Robinson  jam...@chromium.org
 
 [chromium] Add CompositorSupport interface for constructing compositor classes


Modified: trunk/Source/Platform/Platform.gypi (127193 => 127194)

--- trunk/Source/Platform/Platform.gypi	2012-08-30 21:40:39 UTC (rev 127193)
+++ trunk/Source/Platform/Platform.gypi	2012-08-30 21:41:22 UTC (rev 127194)
@@ -45,7 +45,7 @@
 'chromium/public/WebColor.h',
 'chromium/public/WebCommon.h',
 'chromium/public/WebCompositor.h',
-'chromium/public/WebCompositorSurface.h',
+'chromium/public/WebCompositorSupport.h',
 'chromium/public/WebCompositorOutputSurface.h',
 'chromium/public/WebCompositorOutputSurfaceClient.h',
 'chromium/public/WebContentLayer.h',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [127225] trunk/Source

[jamesr]

Title: [127225] trunk/Source








Revision 127225
Author jam...@google.com
Date 2012-08-30 20:30:56 -0700 (Thu, 30 Aug 2012)


Log Message
[chromium] Revert WebCompositorSupport to raw ptrs, make dtor protected
https://bugs.webkit.org/show_bug.cgi?id=95520

Reviewed by Darin Fisher.

Source/Platform:

WebPassOwnPtrT isn't quite usable from the chromium side - it needs some more work and isn't worth blocking
WebCompositorSupport for. Also, the d'tor for WebCompositorSupport needs to be protected, not private, so it can
be implemented.

* Platform.gypi:
* chromium/public/WebCompositorSupport.h:
(WebKit):
(WebKit::WebCompositorSupport::createLayerTreeView):
(WebKit::WebCompositorSupport::createLayer):
(WebKit::WebCompositorSupport::createContentLayer):
(WebKit::WebCompositorSupport::createExternalTextureLayer):
(WebKit::WebCompositorSupport::createIOSurfaceLayer):
(WebKit::WebCompositorSupport::createImageLayer):
(WebKit::WebCompositorSupport::createSolidColorLayer):
(WebKit::WebCompositorSupport::createVideoLayer):
(WebKit::WebCompositorSupport::createScrollbarLayer):
(WebKit::WebCompositorSupport::createAnimation):
(WebKit::WebCompositorSupport::createFloatAnimationCurve):
(WebKit::WebCompositorSupport::createTransformAnimationCurve):
(WebCompositorSupport):
* chromium/public/WebPassOwnPtr.h: Removed.

Source/WebCore:

Adopt the return value of WebCompositorSupport explicitly.

* platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::createWebAnimation):
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

Source/WebKit/chromium:

Adopt the return value of WebCompositorSupport explicitly.

* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimation):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/Platform/chromium/public/WebCompositorSupport.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp
trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.cpp
trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/LinkHighlight.cpp
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp


Removed Paths

trunk/Source/Platform/chromium/public/WebPassOwnPtr.h




Diff

Modified: trunk/Source/Platform/ChangeLog (127224 => 127225)

--- trunk/Source/Platform/ChangeLog	2012-08-31 01:25:43 UTC (rev 127224)
+++ trunk/Source/Platform/ChangeLog	2012-08-31 03:30:56 UTC (rev 127225)
@@ -1,5 +1,34 @@
 2012-08-30  James Robinson  jam...@chromium.org
 
+[chromium] Revert WebCompositorSupport to raw ptrs, make dtor protected
+https://bugs.webkit.org/show_bug.cgi?id=95520
+
+Reviewed by Darin Fisher.
+
+WebPassOwnPtrT isn't quite usable from the chromium side - it needs some more work and isn't worth blocking
+WebCompositorSupport for. Also, the d'tor for WebCompositorSupport needs to be protected, not private, so it can
+be implemented.
+
+* Platform.gypi:
+* chromium/public/WebCompositorSupport.h:
+(WebKit):
+(WebKit::WebCompositorSupport::createLayerTreeView):
+(WebKit::WebCompositorSupport::createLayer):
+(WebKit::WebCompositorSupport::createContentLayer):
+(WebKit::WebCompositorSupport::createExternalTextureLayer):
+(WebKit::WebCompositorSupport::createIOSurfaceLayer):
+(WebKit::WebCompositorSupport::createImageLayer):
+(WebKit::WebCompositorSupport::createSolidColorLayer):
+(WebKit::WebCompositorSupport::createVideoLayer):
+(WebKit::WebCompositorSupport::createScrollbarLayer):
+(WebKit::WebCompositorSupport::createAnimation):
+(WebKit::WebCompositorSupport::createFloatAnimationCurve):
+(WebKit::WebCompositorSupport::createTransformAnimationCurve):
+(WebCompositorSupport):
+* chromium/public/WebPassOwnPtr.h: Removed.
+
+2012-08-30  James Robinson  jam...@chromium.org
+
 Chromium win build fix - fix typo in gypi
 
 * Platform.gypi:


Modified: trunk/Source/Platform/Platform.gypi (127224 => 127225)

--- 

[webkit-changes] [127077] trunk

[jamesr]

Title: [127077] trunk








Revision 127077
Author jam...@google.com
Date 2012-08-29 18:34:14 -0700 (Wed, 29 Aug 2012)


Log Message
[chromium] Register/unregister contents layers with GraphicsLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=95379

Reviewed by Adrienne Walker.

Source/WebCore:

Several composited layer types in WebCore are represented by a painted layer and a child contents layer that
represents some non-painted specific content type. For example, a composited video has a WebCore-painted layer
for CSS background and border effects and a child platform video layer backed by a WebVideoLayer with the output
of the video decoding pipeline. Cross-platform code associates the PlatformLayer from the various composited
systems with the right GraphicsLayer, but the object owning the layer and the GraphicsLayer holding the pointer
otherwise have no relationship. This makes shutdown a bit tricky since the object destroying the contents layer
has no direct way to notify the GraphicsLayer holding the contents layer pointer that it is going away. The
GraphicsLayer will be notified after the next style recalc that its contents layer is gone, but may need to do
any number of bookkeeping operations before that happens.

On most platforms the PlatformLayer is refcounted, so the GraphicsLayer simply holds a ref to its contents layer
from the time it is orphaned until the next style recalc and compositing tree rebuild. In Chromium, however,
PlatformLayer is not refcounted. This adds an explicit registration mechanism for layers that may be contents
layers.  A layer has to be registered with GraphicsLayerChromium before it can be used as a contents layer -
typically this is just done at creation - and unregistered before it is destroyed.

Tests: fast/canvas/transformed-canvas-reset.html
   platform/chromium/virtual/gpu/fast/canvas/transformed-canvas-reset.html

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::~ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore):
(WebCore::GraphicsLayerChromium::registerContentsLayer):
(WebCore::GraphicsLayerChromium::unregisterContentsLayer):
(WebCore::GraphicsLayerChromium::clearContentsLayerIfUnregistered):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):

Source/WebKit/chromium:

* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::~WebPluginContainerImpl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.cpp
trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp


Added Paths

trunk/LayoutTests/fast/canvas/transformed-canvas-reset-expected.txt
trunk/LayoutTests/fast/canvas/transformed-canvas-reset.html




Diff

Added: trunk/LayoutTests/fast/canvas/transformed-canvas-reset-expected.txt (0 => 127077)

--- trunk/LayoutTests/fast/canvas/transformed-canvas-reset-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/canvas/transformed-canvas-reset-expected.txt	2012-08-30 01:34:14 UTC (rev 127077)
@@ -0,0 +1 @@
+ Test passes if DRT doesn't crash.
Property changes on: trunk/LayoutTests/fast/canvas/transformed-canvas-reset-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/fast/canvas/transformed-canvas-reset.html (0 => 127077)

--- 

[webkit-changes] [126784] trunk/Tools

[jamesr]

Title: [126784] trunk/Tools








Revision 126784
Author jam...@google.com
Date 2012-08-27 12:16:22 -0700 (Mon, 27 Aug 2012)


Log Message
[chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
https://bugs.webkit.org/show_bug.cgi?id=95115

Reviewed by Adam Barth.

Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
code if the unit tests crash.

* Scripts/run-chromium-webkit-unit-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-chromium-webkit-unit-tests




Diff

Modified: trunk/Tools/ChangeLog (126783 => 126784)

--- trunk/Tools/ChangeLog	2012-08-27 19:06:54 UTC (rev 126783)
+++ trunk/Tools/ChangeLog	2012-08-27 19:16:22 UTC (rev 126784)
@@ -1,3 +1,15 @@
+2012-08-27  James Robinson  jam...@chromium.org
+
+[chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
+https://bugs.webkit.org/show_bug.cgi?id=95115
+
+Reviewed by Adam Barth.
+
+Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
+code if the unit tests crash.
+
+* Scripts/run-chromium-webkit-unit-tests:
+
 2012-08-27  Benjamin Poulain  benja...@webkit.org
 
 Add ECMAScript Number to String conversion to WTF::String


Modified: trunk/Tools/Scripts/run-chromium-webkit-unit-tests (126783 => 126784)

--- trunk/Tools/Scripts/run-chromium-webkit-unit-tests	2012-08-27 19:06:54 UTC (rev 126783)
+++ trunk/Tools/Scripts/run-chromium-webkit-unit-tests	2012-08-27 19:16:22 UTC (rev 126784)
@@ -32,9 +32,9 @@
 use FindBin;
 use lib $FindBin::Bin;
 use webkitdirs;
+use VCSUtils;
 
 push(@ARGV, --chromium);
 setConfiguration();
 my $pathToBinary = productDir() . /webkit_unit_tests;
-# perl's system function's return value has to be right shifted by 8 to get the program's exit code.
-exit system ($pathToBinary, @ARGV)  8;
+exit exitStatus(system ($pathToBinary, @ARGV));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [126803] trunk/Source

[jamesr]

Title: [126803] trunk/Source








Revision 126803
Author jam...@google.com
Date 2012-08-27 15:01:45 -0700 (Mon, 27 Aug 2012)


Log Message
[chromium] Clean up dependencies of WebScrollbar and WebScrollbarLayer
https://bugs.webkit.org/show_bug.cgi?id=94996

Reviewed by Adrienne Walker.

Source/Platform:

This moves the WebScrollbarLayer::create factory out of #if WEBKIT_IMPLEMENTATION and expresses it in API terms
only so anyone who can get a handle on a WebScrollbar can construct the layer. Also removes the ::create() from
WebScrollbar, anyone who currently has access to a WebCore::Scrollbar also has access to WebScrollbarImpl.

* chromium/public/WebScrollbar.h:
(WebScrollbar):
* chromium/public/WebScrollbarLayer.h:
(WebScrollbarLayer):

Source/WebCore:

Moves WebScrollbarImpl into WebCore/platform/support to make it accessible to chromium-specific WebCore code and
uses it to construct WebScrollbar instances around WebCore::Scrollbars.

* WebCore.gypi:
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
* platform/chromium/support/WebScrollbarImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarImpl.cpp.
(WebKit):
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::isOverlay):
(WebKit::WebScrollbarImpl::value):
(WebKit::WebScrollbarImpl::location):
(WebKit::WebScrollbarImpl::size):
(WebKit::WebScrollbarImpl::enabled):
(WebKit::WebScrollbarImpl::maximum):
(WebKit::WebScrollbarImpl::totalSize):
(WebKit::WebScrollbarImpl::isScrollViewScrollbar):
(WebKit::WebScrollbarImpl::isScrollableAreaActive):
(WebKit::WebScrollbarImpl::getTickmarks):
(WebKit::WebScrollbarImpl::controlSize):
(WebKit::WebScrollbarImpl::pressedPart):
(WebKit::WebScrollbarImpl::hoveredPart):
(WebKit::WebScrollbarImpl::scrollbarOverlayStyle):
(WebKit::WebScrollbarImpl::orientation):
(WebKit::WebScrollbarImpl::isCustomScrollbar):
* platform/chromium/support/WebScrollbarImpl.h: Renamed from Source/WebKit/chromium/src/WebScrollbarImpl.h.
(WebCore):
(WebKit):
(WebScrollbarImpl):

Source/WebKit/chromium:

Fix up tests for API changes.

* WebKit.gyp:
* src/WebScrollbarLayerImpl.cpp:
(WebKit::WebScrollbarLayer::create):
* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::TEST):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebScrollbar.h
trunk/Source/Platform/chromium/public/WebScrollbarLayer.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/WebScrollbarLayerImpl.cpp
trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp


Added Paths

trunk/Source/WebCore/platform/chromium/support/WebScrollbarImpl.cpp
trunk/Source/WebCore/platform/chromium/support/WebScrollbarImpl.h


Removed Paths

trunk/Source/WebKit/chromium/src/WebScrollbarImpl.cpp
trunk/Source/WebKit/chromium/src/WebScrollbarImpl.h




Diff

Modified: trunk/Source/Platform/ChangeLog (126802 => 126803)

--- trunk/Source/Platform/ChangeLog	2012-08-27 21:57:27 UTC (rev 126802)
+++ trunk/Source/Platform/ChangeLog	2012-08-27 22:01:45 UTC (rev 126803)
@@ -1,3 +1,19 @@
+2012-08-24  James Robinson  jam...@chromium.org
+
+[chromium] Clean up dependencies of WebScrollbar and WebScrollbarLayer
+https://bugs.webkit.org/show_bug.cgi?id=94996
+
+Reviewed by Adrienne Walker.
+
+This moves the WebScrollbarLayer::create factory out of #if WEBKIT_IMPLEMENTATION and expresses it in API terms
+only so anyone who can get a handle on a WebScrollbar can construct the layer. Also removes the ::create() from
+WebScrollbar, anyone who currently has access to a WebCore::Scrollbar also has access to WebScrollbarImpl.
+
+* chromium/public/WebScrollbar.h:
+(WebScrollbar):
+* chromium/public/WebScrollbarLayer.h:
+(WebScrollbarLayer):
+
 2012-08-23  James Robinson  jam...@chromium.org
 
 [chromium] Convert WebLayerTreeView interface into pure virtual


Modified: trunk/Source/Platform/chromium/public/WebScrollbar.h (126802 => 126803)

--- trunk/Source/Platform/chromium/public/WebScrollbar.h	2012-08-27 21:57:27 UTC (rev 126802)
+++ trunk/Source/Platform/chromium/public/WebScrollbar.h	2012-08-27 22:01:45 UTC (rev 126803)
@@ -106,10 +106,6 @@
 virtual ScrollbarOverlayStyle scrollbarOverlayStyle() const = 0;
 virtual bool isCustomScrollbar() const = 0;
 virtual Orientation orientation() const = 0;
-
-#if WEBKIT_IMPLEMENTATION
-WEBKIT_EXPORT static PassOwnPtrWebScrollbar create(WebCore::Scrollbar*);
-#endif
 };
 
 } // namespace WebKit


Modified: trunk/Source/Platform/chromium/public/WebScrollbarLayer.h (126802 => 126803)

--- trunk/Source/Platform/chromium/public/WebScrollbarLayer.h	2012-08-27 21:57:27 UTC (rev 126802)
+++ trunk/Source/Platform/chromium/public/WebScrollbarLayer.h	2012-08-27 22:01:45 

[webkit-changes] [126810] trunk

[jamesr]

Title: [126810] trunk








Revision 126810
Author jam...@google.com
Date 2012-08-27 15:42:30 -0700 (Mon, 27 Aug 2012)


Log Message
WebGL should not flip textures on presentation if contents are unchanged
https://bugs.webkit.org/show_bug.cgi?id=94961

Reviewed by Kenneth Russell.

Source/WebCore:

For WebGL contexts where antialias and preserveDrawingBuffer are false, chromium implements DrawingBuffer using
two textures and flips them on presentation. If the page hasn't actually rendered anything into the WebGL
context since the last presentation, this makes an old frame available. This fixes the bug by marking the
DrawingBuffer when its contents change.

Test: compositing/webgl/webgl-repaint.html

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::markContextChanged):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::prepareBackBuffer):
* platform/graphics/gpu/DrawingBuffer.h:
(WebCore::DrawingBuffer::markContentsChanged):
(DrawingBuffer):

Tools:

Run some compositing webgl tests in threaded mode to catch regressions specific to that mode.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):

LayoutTests:

Adds a test to make sure multiple displays without any WebGL draw calls leave the WebGL output alone.

* compositing/webgl/webgl-repaint-expected.png: Added.
* compositing/webgl/webgl-repaint-expected.txt: Added.
* compositing/webgl/webgl-repaint.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp
trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py


Added Paths

trunk/LayoutTests/compositing/webgl/webgl-repaint-expected.png
trunk/LayoutTests/compositing/webgl/webgl-repaint-expected.txt
trunk/LayoutTests/compositing/webgl/webgl-repaint.html




Diff

Modified: trunk/LayoutTests/ChangeLog (126809 => 126810)

--- trunk/LayoutTests/ChangeLog	2012-08-27 22:36:09 UTC (rev 126809)
+++ trunk/LayoutTests/ChangeLog	2012-08-27 22:42:30 UTC (rev 126810)
@@ -1,3 +1,16 @@
+2012-08-24  James Robinson  jam...@chromium.org
+
+WebGL should not flip textures on presentation if contents are unchanged
+https://bugs.webkit.org/show_bug.cgi?id=94961
+
+Reviewed by Kenneth Russell.
+
+Adds a test to make sure multiple displays without any WebGL draw calls leave the WebGL output alone.
+
+* compositing/webgl/webgl-repaint-expected.png: Added.
+* compositing/webgl/webgl-repaint-expected.txt: Added.
+* compositing/webgl/webgl-repaint.html: Added.
+
 2012-08-27  Leo Yang  leoy...@rim.com
 
 [BlackBerry] Test expectation for fast/js/constructor-length.html


Added: trunk/LayoutTests/compositing/webgl/webgl-repaint-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/compositing/webgl/webgl-repaint-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/compositing/webgl/webgl-repaint-expected.txt (0 => 126810)

--- trunk/LayoutTests/compositing/webgl/webgl-repaint-expected.txt	(rev 0)
+++ trunk/LayoutTests/compositing/webgl/webgl-repaint-expected.txt	2012-08-27 22:42:30 UTC (rev 126810)
@@ -0,0 +1 @@
+
Property changes on: trunk/LayoutTests/compositing/webgl/webgl-repaint-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/compositing/webgl/webgl-repaint.html (0 => 126810)

--- trunk/LayoutTests/compositing/webgl/webgl-repaint.html	(rev 0)
+++ trunk/LayoutTests/compositing/webgl/webgl-repaint.html	2012-08-27 22:42:30 UTC (rev 126810)
@@ -0,0 +1,65 @@
+!DOCTYPE html
+html
+head
+style type=text/css media=screen
+canvas {
+margin: 20px;
+width: 200px;
+height: 200px;
+padding: 0 0;
+}
+.border {
+border: 1px solid black;
+}
+/style
+script
+if (window.testRunner)
+testRunner.overridePreference(WebKitWebGLEnabled, 1);
+
+function initWebGL()
+{
+var canvas = document.getElementById('canvas');
+var gl = canvas.getContext(experimental-webgl, {'antialias': false});
+if (!gl) {
+alert(No WebGL context found);
+return null;
+}
+
+return gl;
+}
+
+var gl = null;
+
+function init()
+{
+  gl = initWebGL();
+  gl.viewport(0, 0, 200, 200);
+  gl.clearColor(1, 0, 0, 1); // red
+  gl.clear(gl.COLOR_BUFFER_BIT);
+  if (window.testRunner) {
+  testRunner.display();
+  testRunner.dumpAsText(true);
+  drawGreen();
+  } else
+  window.setTimeout(drawGreen, 50);
+}
+
+function drawGreen()
+{
+  gl.clearColor(0, 1, 0, 1); // green
+  gl.clear(gl.COLOR_BUFFER_BIT);
+  if (window.testRunner) {
+  

[webkit-changes] [126830] trunk/Source/WebCore

[jamesr]

Title: [126830] trunk/Source/WebCore








Revision 126830
Author jam...@google.com
Date 2012-08-27 18:02:11 -0700 (Mon, 27 Aug 2012)


Log Message
[chromium] Add some #includes that were implicitly picked up to CCScrollbarGeometry*
https://bugs.webkit.org/show_bug.cgi?id=95158

Reviewed by Adrienne Walker.

These includes are picked up implicitly, better to #include them explicitly to be more robust to refactors.

* platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp:
* platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h:
* platform/graphics/chromium/cc/CCScrollbarGeometryStub.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryStub.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (126829 => 126830)

--- trunk/Source/WebCore/ChangeLog	2012-08-28 00:50:56 UTC (rev 126829)
+++ trunk/Source/WebCore/ChangeLog	2012-08-28 01:02:11 UTC (rev 126830)
@@ -1,3 +1,16 @@
+2012-08-27  James Robinson  jam...@chromium.org
+
+[chromium] Add some #includes that were implicitly picked up to CCScrollbarGeometry*
+https://bugs.webkit.org/show_bug.cgi?id=95158
+
+Reviewed by Adrienne Walker.
+
+These includes are picked up implicitly, better to #include them explicitly to be more robust to refactors.
+
+* platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp:
+* platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h:
+* platform/graphics/chromium/cc/CCScrollbarGeometryStub.h:
+
 2012-08-27  Adam Barth  aba...@webkit.org
 
 [V8] V8DOMWindowShell::installDOMWindow is subtle and should explain itself more


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp (126829 => 126830)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp	2012-08-28 00:50:56 UTC (rev 126829)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp	2012-08-28 01:02:11 UTC (rev 126830)
@@ -27,6 +27,7 @@
 
 #include CCScrollbarGeometryFixedThumb.h
 
+#include cmath
 #include public/WebRect.h
 #include public/WebScrollbar.h
 


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h (126829 => 126830)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h	2012-08-28 00:50:56 UTC (rev 126829)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h	2012-08-28 01:02:11 UTC (rev 126830)
@@ -27,6 +27,7 @@
 #define CCScrollbarGeometryFixedThumb_h
 
 #include CCScrollbarGeometryStub.h
+#include IntSize.h
 
 namespace WebCore {
 


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryStub.h (126829 => 126830)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryStub.h	2012-08-28 00:50:56 UTC (rev 126829)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryStub.h	2012-08-28 01:02:11 UTC (rev 126830)
@@ -27,6 +27,7 @@
 #define CCScrollbarGeometryStub_h
 
 #include public/WebScrollbarThemeGeometry.h
+#include wtf/OwnPtr.h
 #include wtf/PassOwnPtr.h
 
 namespace WebCore {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [126650] trunk/Source

[jamesr]

Title: [126650] trunk/Source








Revision 126650
Author jam...@google.com
Date 2012-08-24 16:25:04 -0700 (Fri, 24 Aug 2012)


Log Message
[chromium] Clean up WebAnimation animationId/groupId generation
https://bugs.webkit.org/show_bug.cgi?id=94973

Reviewed by Adrienne Walker.

Source/Platform:

This removes the unused groupId from the public interface and makes the implicit animation id generation a bit
clearer.

* chromium/public/WebAnimation.h:
(WebAnimation):

Source/WebCore:

This gets rid of AnimationIdVendor and simplifies GraphicsLayerChromium's name-id mapping. We only have to
track the IDs of animations that we have started and can let WebAnimation generate new IDs if we haven't seen
the name before.

* WebCore.gypi:
* platform/graphics/chromium/AnimationIdVendor.cpp: Removed.
* platform/graphics/chromium/AnimationIdVendor.h: Removed.
* platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::createWebAnimation):
* platform/graphics/chromium/AnimationTranslationUtil.h:
(WebCore):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
* platform/graphics/chromium/GraphicsLayerChromium.h:

Source/WebKit/chromium:

* src/WebAnimationImpl.cpp:
(WebKit::WebAnimation::create):
(WebKit::WebAnimationImpl::WebAnimationImpl):
(WebKit::WebAnimationImpl::id):
(WebKit):
* src/WebAnimationImpl.h:
(WebAnimationImpl):
* tests/AnimationTranslationUtilTest.cpp:
(WebKit::animationCanBeTranslated):
* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::TEST_F):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebAnimation.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp
trunk/Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.h
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebAnimationImpl.cpp
trunk/Source/WebKit/chromium/src/WebAnimationImpl.h
trunk/Source/WebKit/chromium/tests/AnimationTranslationUtilTest.cpp
trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp


Removed Paths

trunk/Source/WebCore/platform/graphics/chromium/AnimationIdVendor.cpp
trunk/Source/WebCore/platform/graphics/chromium/AnimationIdVendor.h




Diff

Modified: trunk/Source/Platform/ChangeLog (126649 => 126650)

--- trunk/Source/Platform/ChangeLog	2012-08-24 23:23:47 UTC (rev 126649)
+++ trunk/Source/Platform/ChangeLog	2012-08-24 23:25:04 UTC (rev 126650)
@@ -1,3 +1,16 @@
+2012-08-24  James Robinson  jam...@chromium.org
+
+[chromium] Clean up WebAnimation animationId/groupId generation
+https://bugs.webkit.org/show_bug.cgi?id=94973
+
+Reviewed by Adrienne Walker.
+
+This removes the unused groupId from the public interface and makes the implicit animation id generation a bit
+clearer.
+
+* chromium/public/WebAnimation.h:
+(WebAnimation):
+
 2012-08-24  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Add readyState functionality to RTCPeerConnection


Modified: trunk/Source/Platform/chromium/public/WebAnimation.h (126649 => 126650)

--- trunk/Source/Platform/chromium/public/WebAnimation.h	2012-08-24 23:23:47 UTC (rev 126649)
+++ trunk/Source/Platform/chromium/public/WebAnimation.h	2012-08-24 23:25:04 UTC (rev 126650)
@@ -50,15 +50,15 @@
 };
 
 // The caller takes ownership of the returned value.
-WEBKIT_EXPORT static WebAnimation* create(const WebAnimationCurve, TargetProperty);
+// Pass a non-zero value for animationId specify an id to use for this animation, otherwise one will
+// be generated for you.
+WEBKIT_EXPORT static WebAnimation* create(const WebAnimationCurve, TargetProperty, int animationId = 0);
 
-// An animationId is effectively the animation's name, and it is not unique.
-// Animations with the same groupId are run at the same time. An animation
-// may be uniquely identified by a combination of groupId and target property.
-WEBKIT_EXPORT static WebAnimation* create(const WebAnimationCurve, int animationId, int groupId, TargetProperty);
-
 virtual ~WebAnimation() { }
 
+// An id is effectively the animation's name, and it is not unique.
+virtual int id() = 0;
+
 virtual TargetProperty targetProperty() const = 0;
 
 // This is the number of times that the animation will play. If this


Modified: trunk/Source/WebCore/ChangeLog (126649 => 126650)

--- trunk/Source/WebCore/ChangeLog	2012-08-24 23:23:47 UTC (rev 126649)
+++ trunk/Source/WebCore/ChangeLog	2012-08-24 23:25:04 UTC (rev 126650)
@@ -1,3 +1,27 @@
+2012-08-24  James Robinson  jam...@chromium.org
+
+[chromium] Clean up WebAnimation animationId/groupId 

[webkit-changes] [126498] trunk/Source

[jamesr]

Title: [126498] trunk/Source








Revision 126498
Author jam...@google.com
Date 2012-08-23 16:14:21 -0700 (Thu, 23 Aug 2012)


Log Message
[chromium] Remove WebLayer::setChildren API
https://bugs.webkit.org/show_bug.cgi?id=94749

Reviewed by Adrienne Walker.

Source/Platform:

This is redundant with removeAllChildren() / addChild() and less efficient.

* chromium/public/WebLayer.h:
(WebLayer):

Source/WebCore:

Sets up the child list directly instead of building an intermediate buffer. Covered by compositing/*

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateChildList):

Source/WebKit/chromium:

* src/WebLayer.cpp:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebLayer.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebLayerImpl.h




Diff

Modified: trunk/Source/Platform/ChangeLog (126497 => 126498)

--- trunk/Source/Platform/ChangeLog	2012-08-23 23:12:47 UTC (rev 126497)
+++ trunk/Source/Platform/ChangeLog	2012-08-23 23:14:21 UTC (rev 126498)
@@ -1,5 +1,17 @@
 2012-08-22  James Robinson  jam...@chromium.org
 
+[chromium] Remove WebLayer::setChildren API
+https://bugs.webkit.org/show_bug.cgi?id=94749
+
+Reviewed by Adrienne Walker.
+
+This is redundant with removeAllChildren() / addChild() and less efficient.
+
+* chromium/public/WebLayer.h:
+(WebLayer):
+
+2012-08-22  James Robinson  jam...@chromium.org
+
 [chromium] Change WebLayer from a concrete type to a pure virtual interface
 https://bugs.webkit.org/show_bug.cgi?id=94174
 


Modified: trunk/Source/Platform/chromium/public/WebLayer.h (126497 => 126498)

--- trunk/Source/Platform/chromium/public/WebLayer.h	2012-08-23 23:12:47 UTC (rev 126497)
+++ trunk/Source/Platform/chromium/public/WebLayer.h	2012-08-23 23:14:21 UTC (rev 126498)
@@ -67,7 +67,6 @@
 virtual void addChild(WebLayer*) = 0;
 virtual void insertChild(WebLayer*, size_t index) = 0;
 virtual void replaceChild(WebLayer* reference, WebLayer* newLayer) = 0;
-virtual void setChildren(const WebVectorWebLayer*) = 0;
 virtual void removeFromParent() = 0;
 virtual void removeAllChildren() = 0;
 


Modified: trunk/Source/WebCore/ChangeLog (126497 => 126498)

--- trunk/Source/WebCore/ChangeLog	2012-08-23 23:12:47 UTC (rev 126497)
+++ trunk/Source/WebCore/ChangeLog	2012-08-23 23:14:21 UTC (rev 126498)
@@ -1,3 +1,15 @@
+2012-08-22  James Robinson  jam...@chromium.org
+
+[chromium] Remove WebLayer::setChildren API
+https://bugs.webkit.org/show_bug.cgi?id=94749
+
+Reviewed by Adrienne Walker.
+
+Sets up the child list directly instead of building an intermediate buffer. Covered by compositing/*
+
+* platform/graphics/chromium/GraphicsLayerChromium.cpp:
+(WebCore::GraphicsLayerChromium::updateChildList):
+
 2012-08-23  Dominic Mazzoni  dmazz...@google.com
 
 AX: Focusable elements without a role should not be ignored


Modified: trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp (126497 => 126498)

--- trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2012-08-23 23:12:47 UTC (rev 126497)
+++ trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2012-08-23 23:14:21 UTC (rev 126498)
@@ -597,16 +597,17 @@
 
 void GraphicsLayerChromium::updateChildList()
 {
-VectorWebLayer* newChildren;
+WebLayer* childHost = m_transformLayer ? m_transformLayer.get() : m_layer-layer();
+childHost-removeAllChildren();
 
 if (m_transformLayer) {
 // Add the primary layer first. Even if we have negative z-order children, the primary layer always comes behind.
-newChildren.append(m_layer-layer());
+childHost-addChild(m_layer-layer());
 } else if (m_contentsLayer) {
 // FIXME: add the contents layer in the correct order with negative z-order children.
 // This does not cause visible rendering issues because currently contents layers are only used
 // for replaced elements that don't have children.
-newChildren.append(m_contentsLayer);
+childHost-addChild(m_contentsLayer);
 }
 
 const VectorGraphicsLayer* childLayers = children();
@@ -614,29 +615,18 @@
 for (size_t i = 0; i  numChildren; ++i) {
 GraphicsLayerChromium* curChild = static_castGraphicsLayerChromium*(childLayers[i]);
 
-newChildren.append(curChild-platformLayer());
+childHost-addChild(curChild-platformLayer());
 }
 
 if (m_linkHighlight)
-newChildren.append(m_linkHighlight-layer());
+childHost-addChild(m_linkHighlight-layer());
 
-for (size_t i = 0; i  newChildren.size(); ++i)
-newChildren[i]-removeFromParent();
-
-WebVectorWebLayer* 

[webkit-changes] [126198] trunk/Source

[jamesr]

Title: [126198] trunk/Source








Revision 126198
Author jam...@google.com
Date 2012-08-21 15:35:41 -0700 (Tue, 21 Aug 2012)


Log Message
[chromium] Should be able to destroy a CCLayerTreeHost without manually setting the root layer
https://bugs.webkit.org/show_bug.cgi?id=94631

Reviewed by Adrienne Walker.

Source/WebCore:

In the depths of time when dinosaurs roamed the earth, LayerChromium and CCLayerTreeHost were both reference
counted and there was a cycle between the root LayerChromium and CCLayerTreeHost. This required all users of
CCLayerTreeHost to manually break the cycle by calling setRootLayer(0) before dropping their reference to the
host. Nowadays, CCLayerTreeHost has a single owner and LayerChromiums only have a weak pointer to their host
so we should just do this cleanup ourselves instead of imposing it on callers.

Unit test added to LayerChromiumTest.cpp

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):

Source/WebKit/chromium:

Tests that destroying a CCLayerTreeHost that still points to a non-null root doesn't crash.

* tests/LayerChromiumTest.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (126197 => 126198)

--- trunk/Source/WebCore/ChangeLog	2012-08-21 22:35:21 UTC (rev 126197)
+++ trunk/Source/WebCore/ChangeLog	2012-08-21 22:35:41 UTC (rev 126198)
@@ -1,3 +1,21 @@
+2012-08-21  James Robinson  jam...@chromium.org
+
+[chromium] Should be able to destroy a CCLayerTreeHost without manually setting the root layer
+https://bugs.webkit.org/show_bug.cgi?id=94631
+
+Reviewed by Adrienne Walker.
+
+In the depths of time when dinosaurs roamed the earth, LayerChromium and CCLayerTreeHost were both reference
+counted and there was a cycle between the root LayerChromium and CCLayerTreeHost. This required all users of
+CCLayerTreeHost to manually break the cycle by calling setRootLayer(0) before dropping their reference to the
+host. Nowadays, CCLayerTreeHost has a single owner and LayerChromiums only have a weak pointer to their host
+so we should just do this cleanup ourselves instead of imposing it on callers.
+
+Unit test added to LayerChromiumTest.cpp
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
+
 2012-08-21  Ulan Degenbaev  u...@chromium.org
 
 Call AdjustAmountOfExternalAllocatedMemory when V8ArrayBuffer constructed and destructed


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (126197 => 126198)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2012-08-21 22:35:21 UTC (rev 126197)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2012-08-21 22:35:41 UTC (rev 126198)
@@ -113,6 +113,8 @@
 
 CCLayerTreeHost::~CCLayerTreeHost()
 {
+if (m_rootLayer)
+m_rootLayer-setLayerTreeHost(0);
 ASSERT(CCProxy::isMainThread());
 TRACE_EVENT0(cc, CCLayerTreeHost::~CCLayerTreeHost);
 ASSERT(m_proxy);


Modified: trunk/Source/WebKit/chromium/ChangeLog (126197 => 126198)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-08-21 22:35:21 UTC (rev 126197)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-08-21 22:35:41 UTC (rev 126198)
@@ -1,5 +1,16 @@
 2012-08-21  James Robinson  jam...@chromium.org
 
+[chromium] Should be able to destroy a CCLayerTreeHost without manually setting the root layer
+https://bugs.webkit.org/show_bug.cgi?id=94631
+
+Reviewed by Adrienne Walker.
+
+Tests that destroying a CCLayerTreeHost that still points to a non-null root doesn't crash.
+
+* tests/LayerChromiumTest.cpp:
+
+2012-08-21  James Robinson  jam...@chromium.org
+
 Unreviewed, rolling out r126170.
 http://trac.webkit.org/changeset/126170
 https://bugs.webkit.org/show_bug.cgi?id=94614


Modified: trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp (126197 => 126198)

--- trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp	2012-08-21 22:35:21 UTC (rev 126197)
+++ trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp	2012-08-21 22:35:41 UTC (rev 126198)
@@ -803,6 +803,18 @@
 WebKit::WebCompositor::shutdown();
 }
 
+TEST(LayerChromiumLayerTreeHostTest, destroyHostWithNonNullRootLayer)
+{
+WebKit::WebCompositor::initialize(0);
+RefPtrLayerChromium root = LayerChromium::create();
+RefPtrLayerChromium child = LayerChromium::create();
+root-addChild(child);
+OwnPtrFakeCCLayerTreeHost layerTreeHost(FakeCCLayerTreeHost::create());
+layerTreeHost-setRootLayer(root);
+layerTreeHost.clear();
+WebKit::WebCompositor::shutdown();
+}
+
 class MockLayerChromium : public LayerChromium {
 public:
 

[webkit-changes] [126091] trunk/Source/WebKit/chromium

[jamesr]

Title: [126091] trunk/Source/WebKit/chromium








Revision 126091
Author jam...@google.com
Date 2012-08-20 16:43:58 -0700 (Mon, 20 Aug 2012)


Log Message
Unreviewed. Roll WebKit chromium DEPS forward.

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (126090 => 126091)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-08-20 23:43:14 UTC (rev 126090)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-08-20 23:43:58 UTC (rev 126091)
@@ -1,3 +1,9 @@
+2012-08-20  James Robinson  jam...@chromium.org
+
+Unreviewed. Roll WebKit chromium DEPS forward.
+
+* DEPS:
+
 2012-08-20  Kentaro Hara  hara...@chromium.org
 
 [V8] Move clearForClose() and clearForNavigation() from V8Proxy to ScriptController


Modified: trunk/Source/WebKit/chromium/DEPS (126090 => 126091)

--- trunk/Source/WebKit/chromium/DEPS	2012-08-20 23:43:14 UTC (rev 126090)
+++ trunk/Source/WebKit/chromium/DEPS	2012-08-20 23:43:58 UTC (rev 126091)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '152079'
+  'chromium_rev': '152373'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [126099] trunk/Source

[jamesr]

Title: [126099] trunk/Source








Revision 126099
Author jam...@google.com
Date 2012-08-20 17:06:28 -0700 (Mon, 20 Aug 2012)


Log Message
[chromium] REGRESSION(126076) Should not touch old GraphicsLayerChromium::m_contentsLayer when setting up a new contents layer
https://bugs.webkit.org/show_bug.cgi?id=94544

Reviewed by Adrienne Walker.

Source/Platform:

Exposes an id so users of the WebLayer API can make identity checks for layers that they do not have ownership
of.

* chromium/public/WebLayer.h:
(WebLayer):

Source/WebCore:

GraphicsLayerChromium only keeps a weak pointer to its m_contentsLayer. When replacing it with a new contents
layer, it may be unsafe to touch the old value. It's also completely unnecessary.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:

Source/WebKit/chromium:

* src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::id):
(WebKit):
* src/WebLayerImpl.h:
(WebLayerImpl):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebLayer.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebLayerImpl.h




Diff

Modified: trunk/Source/Platform/ChangeLog (126098 => 126099)

--- trunk/Source/Platform/ChangeLog	2012-08-21 00:02:03 UTC (rev 126098)
+++ trunk/Source/Platform/ChangeLog	2012-08-21 00:06:28 UTC (rev 126099)
@@ -1,3 +1,16 @@
+2012-08-20  James Robinson  jam...@chromium.org
+
+[chromium] REGRESSION(126076) Should not touch old GraphicsLayerChromium::m_contentsLayer when setting up a new contents layer
+https://bugs.webkit.org/show_bug.cgi?id=94544
+
+Reviewed by Adrienne Walker.
+
+Exposes an id so users of the WebLayer API can make identity checks for layers that they do not have ownership
+of.
+
+* chromium/public/WebLayer.h:
+(WebLayer):
+
 2012-08-16  James Robinson  jam...@chromium.org
 
 [chromium] Change WebLayer from a concrete type to a pure virtual interface


Modified: trunk/Source/Platform/chromium/public/WebLayer.h (126098 => 126099)

--- trunk/Source/Platform/chromium/public/WebLayer.h	2012-08-21 00:02:03 UTC (rev 126098)
+++ trunk/Source/Platform/chromium/public/WebLayer.h	2012-08-21 00:06:28 UTC (rev 126099)
@@ -54,6 +54,9 @@
 
 virtual ~WebLayer() { }
 
+// Returns a positive ID that will be unique across all WebLayers allocated in this process.
+virtual int id() const = 0;
+
 // Sets a region of the layer as invalid, i.e. needs to update its content.
 virtual void invalidateRect(const WebFloatRect) = 0;
 


Modified: trunk/Source/WebCore/ChangeLog (126098 => 126099)

--- trunk/Source/WebCore/ChangeLog	2012-08-21 00:02:03 UTC (rev 126098)
+++ trunk/Source/WebCore/ChangeLog	2012-08-21 00:06:28 UTC (rev 126099)
@@ -1,3 +1,20 @@
+2012-08-20  James Robinson  jam...@chromium.org
+
+[chromium] REGRESSION(126076) Should not touch old GraphicsLayerChromium::m_contentsLayer when setting up a new contents layer
+https://bugs.webkit.org/show_bug.cgi?id=94544
+
+Reviewed by Adrienne Walker.
+
+GraphicsLayerChromium only keeps a weak pointer to its m_contentsLayer. When replacing it with a new contents
+layer, it may be unsafe to touch the old value. It's also completely unnecessary.
+
+* platform/graphics/chromium/GraphicsLayerChromium.cpp:
+(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
+(WebCore::GraphicsLayerChromium::setContentsToImage):
+(WebCore::GraphicsLayerChromium::setContentsTo):
+(WebCore::GraphicsLayerChromium::setupContentsLayer):
+* platform/graphics/chromium/GraphicsLayerChromium.h:
+
 2012-08-20  Kentaro Hara  hara...@chromium.org
 
 [V8] Move collectGarbage() from ScriptController to V8GCController


Modified: trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp (126098 => 126099)

--- trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2012-08-21 00:02:03 UTC (rev 126098)
+++ trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2012-08-21 00:06:28 UTC (rev 126099)
@@ -84,6 +84,7 @@
 GraphicsLayerChromium::GraphicsLayerChromium(GraphicsLayerClient* client)
 : GraphicsLayer(client)
 , m_contentsLayer(0)
+, m_contentsLayerId(0)
 , m_contentsLayerPurpose(NoContentsLayer)
 , m_contentsLayerHasBackgroundColor(false)
 , m_inSetChildren(false)
@@ -443,7 +444,7 @@
 {
 bool childrenChanged = false;
 if (image) {
-if