from:"jfernandez"

[webkit-changes] [294121] trunk

2022-05-12 Thread jfernandez

Title: [294121] trunk








Revision 294121
Author jfernan...@igalia.com
Date 2022-05-12 14:30:42 -0700 (Thu, 12 May 2022)


Log Message
Add GitHub account to contributors.json and update expertise field
https://bugs.webkit.org/show_bug.cgi?id=240360

Unreviewed.


* metadata/contributors.json:

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (294120 => 294121)

--- trunk/ChangeLog	2022-05-12 21:14:06 UTC (rev 294120)
+++ trunk/ChangeLog	2022-05-12 21:30:42 UTC (rev 294121)
@@ -1,3 +1,12 @@
+2022-05-12  Javier Fernandez  
+
+Add GitHub account to contributors.json and update expertise field
+https://bugs.webkit.org/show_bug.cgi?id=240360
+
+Unreviewed.
+
+* metadata/contributors.json:
+
 2022-05-11  Yury Semikhatsky  
 
 [WinCairo] Support file downloads


Modified: trunk/metadata/contributors.json (294120 => 294121)

--- trunk/metadata/contributors.json	2022-05-12 21:14:06 UTC (rev 294120)
+++ trunk/metadata/contributors.json	2022-05-12 21:30:42 UTC (rev 294121)
@@ -3296,6 +3296,8 @@
   "emails" : [
  "jfernan...@igalia.com"
   ],
+  "expertise" : "Layout, CSS",
+  "github" : "javifernandez",
   "name" : "Javier Fernandez",
   "nicks" : [
  "lajava"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262828] trunk/LayoutTests

2020-06-09 Thread jfernandez

Title: [262828] trunk/LayoutTests








Revision 262828
Author jfernan...@igalia.com
Date 2020-06-09 18:44:04 -0700 (Tue, 09 Jun 2020)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=212997

Unreviewed test gardening


* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (262827 => 262828)

--- trunk/LayoutTests/ChangeLog	2020-06-10 00:21:56 UTC (rev 262827)
+++ trunk/LayoutTests/ChangeLog	2020-06-10 01:44:04 UTC (rev 262828)
@@ -1,3 +1,12 @@
+2020-06-09  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=212997
+
+Unreviewed test gardening
+
+* platform/gtk/TestExpectations:
+
 2020-06-09  Diego Pino Garcia  
 
 [GTK] Gardening, update results of flaky timeout failures


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (262827 => 262828)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2020-06-10 00:21:56 UTC (rev 262827)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2020-06-10 01:44:04 UTC (rev 262828)
@@ -3831,13 +3831,6 @@
 webkit.org/b/209720 fast/css-grid-layout/grid-align-baseline-vertical.html [ Failure ]
 webkit.org/b/209720 fast/writing-mode/vertical-baseline-alignment.html [ Failure ]
 
-webkit.org/b/209282 imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-001.html [ Failure ]
-webkit.org/b/209282 imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-002.html [ Failure ]
-webkit.org/b/209282 imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-003.html [ Failure ]
-webkit.org/b/209282 imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-004.html [ Failure ]
-webkit.org/b/209282 imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-005.html [ Failure ]
-webkit.org/b/209282 imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-006.html [ Failure ]
-
 webkit.org/b/169910 fast/multicol/simple-line-layout-line-index-after-strut.html [ ImageOnlyFailure ]
 
 webkit.org/b/105954 http/tests/navigation/reload-subframe-object.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262788] trunk/LayoutTests

2020-06-09 Thread jfernandez

Title: [262788] trunk/LayoutTests








Revision 262788
Author jfernan...@igalia.com
Date 2020-06-09 05:11:13 -0700 (Tue, 09 Jun 2020)


Log Message
[css-grid] Import some grid tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=212920

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Imported some grid related tests from WPT to check how baseline
alignment affects the grid's intrinsic size computation.

* resources/import-expectations.json:
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-001-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-001.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-002-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-002.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-003-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-003.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-004-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-004.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-005-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-005.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-006-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-006.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:

LayoutTests:

The imported tests fail only for WebKitGtk+ platform.

* platform/gtk/TestExpectations: Added Failure entries,

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/resources/import-expectations.json
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-002-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-002.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-003-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-003.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-004-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-004.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-005-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-005.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-006-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-006.html




Diff

Modified: trunk/LayoutTests/ChangeLog (262787 => 262788)

--- trunk/LayoutTests/ChangeLog	2020-06-09 11:54:59 UTC (rev 262787)
+++ trunk/LayoutTests/ChangeLog	2020-06-09 12:11:13 UTC (rev 262788)
@@ -1,3 +1,14 @@
+2020-06-09  Javier Fernandez  
+
+[css-grid] Import some grid tests from WPT
+https://bugs.webkit.org/show_bug.cgi?id=212920
+
+Reviewed by Manuel Rego Casasnovas.
+
+The imported tests fail only for WebKitGtk+ platform.
+
+* platform/gtk/TestExpectations: Added Failure entries,
+
 2020-06-09  Diego Pino Garcia  
 
 [GLIB] Gardening, clean up failures filed under bug 186638


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (262787 => 262788)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2020-06-09 11:54:59 UTC (rev 262787)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2020-06-09 12:11:13 UTC (rev 262788)
@@ -1,3 +1,28 @@
+2020-06-09  Javier Fernandez  
+
+[css-grid] Import some grid tests from WPT
+

[webkit-changes] [262481] trunk

2020-06-03 Thread jfernandez

Title: [262481] trunk








Revision 262481
Author jfernan...@igalia.com
Date 2020-06-03 00:31:29 -0700 (Wed, 03 Jun 2020)


Log Message
[css-grid] Dynamically setting "position: absolute" in a grid item doesn't trigger a relayout of that element
https://bugs.webkit.org/show_bug.cgi?id=191465

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

>From Blink r484620 by Sergio Villar 

Containing block overrides not cleared for position:absolute

Whenever a position:absolute block gets a new containing block the
previously set containing block overrides are not cleared. This causes the
block not to be properly layout for its new containing block (for example
when using relative sizes).

In particular this affects grid items which always get a containing block
override size (which represent the grid areas) in case their
containing block switches from the grid container to a grid ancestor.

No new tests, as this change is covered by current web platform tests.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject): Clear the containing block's override width and height.

LayoutTests:

Several tests pass now thanks to this change.

* TestExpectations: Removed failure expectations, since now these tests pass now.
  - absolute-positioning-changing-containing-block-001.html
  - grid-item-absolute-positioning-dynamic-001.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (262480 => 262481)

--- trunk/LayoutTests/ChangeLog	2020-06-03 07:28:11 UTC (rev 262480)
+++ trunk/LayoutTests/ChangeLog	2020-06-03 07:31:29 UTC (rev 262481)
@@ -1,3 +1,16 @@
+2020-06-03  Javier Fernandez  
+
+[css-grid] Dynamically setting "position: absolute" in a grid item doesn't trigger a relayout of that element
+https://bugs.webkit.org/show_bug.cgi?id=191465
+
+Reviewed by Manuel Rego Casasnovas.
+
+Several tests pass now thanks to this change.
+
+* TestExpectations: Removed failure expectations, since now these tests pass now.
+  - absolute-positioning-changing-containing-block-001.html
+  - grid-item-absolute-positioning-dynamic-001.html
+
 2020-06-02  Yusuke Suzuki  
 
 ASSERTION FAILED: isCell() under WebCore::JSDOMConstructor seen with webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html


Modified: trunk/LayoutTests/TestExpectations (262480 => 262481)

--- trunk/LayoutTests/TestExpectations	2020-06-03 07:28:11 UTC (rev 262480)
+++ trunk/LayoutTests/TestExpectations	2020-06-03 07:31:29 UTC (rev 262481)
@@ -1054,8 +1054,6 @@
 webkit.org/b/136754 css3/flexbox/csswg/ttwf-reftest-flex-wrap.html [ ImageOnlyFailure ]
 
 # grid layout tests
-webkit.org/b/191465 imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-changing-containing-block-001.html [ ImageOnlyFailure ]
-webkit.org/b/191465 imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioning-dynamic-001.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010.html [ Pass Failure ]
 imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-013.html [ Pass Failure ]
 imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-015.html [ Pass Failure ]


Modified: trunk/Source/WebCore/ChangeLog (262480 => 262481)

--- trunk/Source/WebCore/ChangeLog	2020-06-03 07:28:11 UTC (rev 262480)
+++ trunk/Source/WebCore/ChangeLog	2020-06-03 07:31:29 UTC (rev 262481)
@@ -1,3 +1,28 @@
+2020-06-03  Javier Fernandez  
+
+[css-grid] Dynamically setting "position: absolute" in a grid item doesn't trigger a relayout of that element
+https://bugs.webkit.org/show_bug.cgi?id=191465
+
+Reviewed by Manuel Rego Casasnovas.
+
+From Blink r484620 by Sergio Villar 
+
+Containing block overrides not cleared for position:absolute
+
+Whenever a position:absolute block gets a new containing block the
+previously set containing block overrides are not cleared. This causes the
+block not to be properly layout for its new containing block (for example
+when using relative sizes).
+
+In particular this affects grid items which always get a containing block
+override size (which represent the grid areas) in case their
+containing block switches from the grid container to a grid ancestor.
+
+No new tests, as this change is covered by current web platform tests.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::insertPositionedObject): Clear the containing block's override width and height.
+
 2020-06-03  Youenn Fablet  
 
 Add more logging related to service worker fetch event handling


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (262480 =>

[webkit-changes] [262284] trunk/LayoutTests

2020-05-29 Thread jfernandez

Title: [262284] trunk/LayoutTests








Revision 262284
Author jfernan...@igalia.com
Date 2020-05-29 01:00:43 -0700 (Fri, 29 May 2020)


Log Message
[css-grid] Import tests for the grid as flexbox item case
https://bugs.webkit.org/show_bug.cgi?id=212374

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Imported tests from the WPT CSS Grid Layout test suite.

* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-001-expected.xht: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-001.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-002-expected.xht: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-002.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-003-expected.xht: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-003.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-004-expected.xht: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-004.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-005-expected.xht: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-005.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-006-expected.xht: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-006.html: Added.

LayoutTests:

These tests cover the case of a grid container being rendered as a flexbox item.
They are also useful as regression tests for the bug 209282 .

* TestExpectations: Added Failure entries for the tests that fail due to bug 209282

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-001-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-002-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-002.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-003-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-003.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-004-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-004.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-005-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-005.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-006-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-006.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-007-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-007.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-008-expected.xht
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-008.html




Diff

Modified: trunk/LayoutTests/ChangeLog (262283 => 262284)

--- trunk/LayoutTests/ChangeLog	2020-05-29 07:27:03 UTC (rev 262283)
+++ trunk/LayoutTests/ChangeLog	2020-05-29 08:00:43 UTC (rev 262284)
@@ -1,3 +1,15 @@
+2020-05-29  Javier Fernandez  
+
+[css-grid] Import tests for the grid as flexbox item case
+https://bugs.webkit.org/show_bug.cgi?id=212374
+
+Reviewed by Manuel Rego Casasnovas.
+
+These tests cover the case of a grid container being rendered as a flexbox item.
+They are also useful as regression tests for the bug 209282 .
+
+* TestExpectations: Added Failure entries for the tests that fail due to bug 209282

[webkit-changes] [262052] trunk/Tools

2020-05-22 Thread jfernandez

Title: [262052] trunk/Tools








Revision 262052
Author jfernan...@igalia.com
Date 2020-05-22 04:28:36 -0700 (Fri, 22 May 2020)


Log Message
[Flatpak SDK] CCACHE_ env vars are not forwarded to the sandbox environment
https://bugs.webkit.org/show_bug.cgi?id=212257

Reviewed by Philippe Normand.

Added the "CCACHE" prefix to the ones the SDK should keep from the
user's environment, and forwarded to the Flatpak sandbox.

* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/flatpak/flatpakutils.py




Diff

Modified: trunk/Tools/ChangeLog (262051 => 262052)

--- trunk/Tools/ChangeLog	2020-05-22 11:15:00 UTC (rev 262051)
+++ trunk/Tools/ChangeLog	2020-05-22 11:28:36 UTC (rev 262052)
@@ -1,3 +1,16 @@
+2020-05-22  Javier Fernandez  
+
+[Flatpak SDK] CCACHE_ env vars are not forwarded to the sandbox environment
+https://bugs.webkit.org/show_bug.cgi?id=212257
+
+Reviewed by Philippe Normand.
+
+Added the "CCACHE" prefix to the ones the SDK should keep from the
+user's environment, and forwarded to the Flatpak sandbox.
+
+* flatpak/flatpakutils.py:
+(WebkitFlatpak.run_in_sandbox):
+
 2020-05-22  Tim Horton  
 
 iOS: Pressing tab in the Mail subject field moves focus to the body, but pressing shift tab doesn't move it back


Modified: trunk/Tools/flatpak/flatpakutils.py (262051 => 262052)

--- trunk/Tools/flatpak/flatpakutils.py	2020-05-22 11:15:00 UTC (rev 262051)
+++ trunk/Tools/flatpak/flatpakutils.py	2020-05-22 11:28:36 UTC (rev 262052)
@@ -727,6 +727,7 @@
 
 env_var_prefixes_to_keep = [
 "G",
+"CCACHE",
 "GIGACAGE",
 "GST",
 "GTK",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258735] trunk

2020-03-19 Thread jfernandez

Title: [258735] trunk








Revision 258735
Author jfernan...@igalia.com
Date 2020-03-19 15:27:06 -0700 (Thu, 19 Mar 2020)


Log Message
[css-grid] Changes in grid or elements inside the grid affects margin on other elements in the grid
https://bugs.webkit.org/show_bug.cgi?id=209203

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Imported new Web Platform tests to detect regressions in the auto-margins logic durignn relayouts.

* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-001-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-001.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-002-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-002.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-003-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-003.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-004-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-004.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-005-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-005.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-006-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-006.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-007-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-007.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-008-expected.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-008.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-001-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-001.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-002-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-002.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-003-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-003.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-004-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-004.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-005-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-005.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-006-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-006.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-007-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-007.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-008-expected.html: Added.
* web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-008.html: Added.

Source/WebCore:

We should ignore the previously computed auto margins wheneven a relayout is performed.

Tests: imported/w3c/web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-001.html
   imported/w3c/web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-002.html
   imported/w3c/web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-003.html
   imported/w3c/web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-004.html
   imported/w3c/web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-005.html
   imported/w3c/web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-006.html
   imported/w3c/web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-007.html
   imported/w3c/web-platform-tests/css/css-grid/alignment/grid-block-axis-alignment-auto-margins-008.html
   imported/w3c/web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-001.html
   imported/w3c/web-platform-tests/css/css-grid/alignment/grid-inline-axis-alignment-auto-margins-002.html

[webkit-changes] [246104] trunk/LayoutTests

2019-06-05 Thread jfernandez

Title: [246104] trunk/LayoutTests








Revision 246104
Author jfernan...@igalia.com
Date 2019-06-05 06:22:53 -0700 (Wed, 05 Jun 2019)


Log Message
Update the CSS Text WPT test suite
https://bugs.webkit.org/show_bug.cgi?id=197929

Reviewed by Myles C. Maxfield.

Import the last changes in the CSS Text suite.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-text/line-break/line-break-anywhere-001.html:
* web-platform-tests/css/css-text/line-break/line-break-anywhere-002.html:
* web-platform-tests/css/css-text/line-break/line-break-anywhere-013-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-013.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-024.html.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-014-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-014.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-024.html.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-015-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-015.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-024.html.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-016-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-016.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-024.html.
* web-platform-tests/css/css-text/line-break/w3c-import.log:
* web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-008.html:
* web-platform-tests/css/css-text/white-space/break-spaces-009.html:
* web-platform-tests/css/css-text/white-space/break-spaces-010-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-010.html: Added.
* web-platform-tests/css/css-text/white-space/w3c-import.log:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-004-expected.html:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-004.html:
* web-platform-tests/css/css-text/white-space/white-space-pre-wrap-trailing-spaces-002-expected.html:
* web-platform-tests/css/css-text/white-space/white-space-pre-wrap-trailing-spaces-002.html:
* web-platform-tests/css/css-text/white-space/white-space-pre-wrap-trailing-spaces-003-expected.html:
* web-platform-tests/css/css-text/white-space/white-space-pre-wrap-trailing-spaces-003.html:
* web-platform-tests/css/css-text/word-break/w3c-import.log:
* web-platform-tests/css/css-text/word-break/word-break-break-all-017.html:
* web-platform-tests/css/css-text/word-break/word-break-break-all-023.html:
* web-platform-tests/css/css-text/word-break/word-break-break-all-024.html:
* web-platform-tests/css/css-text/word-break/word-break-break-all-025-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-025.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-024.html.
* web-platform-tests/css/css-text/word-break/word-break-break-all-026-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-026.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-024.html.
* web-platform-tests/css/css-text/word-break/word-break-break-all-027-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-027.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-024.html.
* web-platform-tests/css/css-text/word-break/word-break-break-all-028-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-028.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-024.html.

LayoutTests:

* TestExpectations: A few tests pass now
  - white-space-intrinsic-size-004.html
  - white-space-pre-wrap-trailing-spaces-003.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-001-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-002.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/line-break/w3c-import.log
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-008.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-009.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/w3c-import.log

[webkit-changes] [245275] trunk

2019-05-14 Thread jfernandez

Title: [245275] trunk








Revision 245275
Author jfernan...@igalia.com
Date 2019-05-14 06:20:54 -0700 (Tue, 14 May 2019)


Log Message
Implement "line-break: anywhere"
https://bugs.webkit.org/show_bug.cgi?id=181169


Reviewed by Myles C. Maxfield.

LayoutTests/imported/w3c:

New tests to verify the new line-break: anywhere feature and how
it behaves different to 'word-break: break-all'.

* web-platform-tests/css/css-text/line-break/line-break-anywhere-001.html:
* web-platform-tests/css/css-text/line-break/line-break-anywhere-002.html:
* web-platform-tests/css/css-text/line-break/line-break-anywhere-003-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-003.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-004-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-004.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-005-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-005.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-006-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-006.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-007-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-007.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-008-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-008.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-009-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-009.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-010-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-010.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-011-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-011.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-012-expected.html: Added.
* web-platform-tests/css/css-text/line-break/line-break-anywhere-012.html: Added.
* web-platform-tests/css/css-text/parsing/line-break-valid-expected.txt:
* web-platform-tests/css/css-text/word-break/word-break-break-all-016-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-016.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-017-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-017.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-018-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-018.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-019-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-019.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-021-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-021.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-022-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-022.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-023-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-023.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-024-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-024.html: Added.

Source/WebCore:

The CSS WG resolved [1] to add a new value 'anywhere' to the 'line-break'
CSS property in order to allow additional breaking opportunities not
considered in the definition of the 'word-break: break-all'.

[1] https://github.com/w3c/csswg-drafts/issues/1171

Tests: imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-003.html
   imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-004.html
   imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-005.html
   imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-006.html
   imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-007.html
   imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-008.html
   imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-009.html
   imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-010.html
   imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-011.html
   imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-012.html

[webkit-changes] [244748] trunk

2019-04-29 Thread jfernandez

Title: [244748] trunk








Revision 244748
Author jfernan...@igalia.com
Date 2019-04-29 12:56:56 -0700 (Mon, 29 Apr 2019)


Log Message
line should not be broken before the first space after a word
https://bugs.webkit.org/show_bug.cgi?id=197278

Reviewed by Myles C. Maxfield.

LayoutTests/imported/w3c:

Added new Web Platform Tests to cover the cases discussed [1] with the CSS WG.

[1] https://github.com/w3c/csswg-drafts/issues/3701

* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-001-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-001.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-002-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-002.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-003-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-003.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-004-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-004.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-005-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-005.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-006-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-006.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-007-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-007.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-008-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-008.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-009-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-009.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-010-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-010.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-011-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-011.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-012-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-012.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-013-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-013.html: Added.

Source/WebCore:

The 'white-space: break-spaces' only adds breaking opportunities after
a white space character. However, it's possible to break before the
first space after a word when the feature is used in combination with
other properties, like overflow-wrap.

However, breaking before the first space should not be allowed if
there are previous opportunities. We wrongly assumed that we had to
consider these previous breaking opportunities if the proper combination
of line breaking properties is being used, so that breaking before the
first space after a word is allowed.

This wrong assumption caused several issues, like the one described in
the bug, that lead to incorrectly break before the first space even
though there are previous opportunities, either white spaces or between
letters.

Theses issues have been analyzed [1] by the CSS WG and finally agreed on a
expected behavior, represented in the Web Platform tests added in this
patch.

For the later case, of considering previous opportunities between
letters, we have a seperated issue #952254, so the tests covering such
cases will be added to the TestExpecations as Failure entries.

[1] https://github.com/w3c/csswg-drafts/issues/3701

Tests: imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-001.html
   imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-002.html
   imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-003.html
   imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-004.html
   imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-005.html
   imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-006.html
   imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-007.html

[webkit-changes] [244728] trunk/LayoutTests

2019-04-29 Thread jfernandez

Title: [244728] trunk/LayoutTests








Revision 244728
Author jfernan...@igalia.com
Date 2019-04-29 01:08:51 -0700 (Mon, 29 Apr 2019)


Log Message
Update the CSS Text WPT test suite
https://bugs.webkit.org/show_bug.cgi?id=197326

Unreviewed test gardening.


LayoutTests/imported/w3c:

* web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007.html:
* web-platform-tests/css/css-text/overflow-wrap/w3c-import.log:
* web-platform-tests/css/css-text/parsing/text-transform-valid.html:
* web-platform-tests/css/css-text/parsing/word-break-invalid-expected.txt:
* web-platform-tests/css/css-text/parsing/word-break-invalid.html:
* web-platform-tests/css/css-text/parsing/word-break-valid-expected.txt:
* web-platform-tests/css/css-text/parsing/word-break-valid.html:
* web-platform-tests/css/css-text/text-transform/w3c-import.log:
* web-platform-tests/css/css-text/white-space/break-spaces-003-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-003.html:
* web-platform-tests/css/css-text/white-space/break-spaces-004.html:
* web-platform-tests/css/css-text/white-space/break-spaces-005-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-005.html:
* web-platform-tests/css/css-text/white-space/break-spaces-006-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-006.html:
* web-platform-tests/css/css-text/white-space/break-spaces-007-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-007.html:
* web-platform-tests/css/css-text/white-space/break-spaces-008-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-008.html:
* web-platform-tests/css/css-text/white-space/break-spaces-009-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-009.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-008-expected.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-008.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-015.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-016.html:
* web-platform-tests/css/css-text/white-space/textarea-break-spaces-001-expected.html:
* web-platform-tests/css/css-text/white-space/w3c-import.log:

LayoutTests:

* TestExpectations:
  - The break-spaces-008.html fails due to bug 197277

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/w3c-import.log
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-valid.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-break-invalid-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-break-invalid.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-break-valid-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-break-valid.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/w3c-import.log
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-003-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-003.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-004.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-005-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-005.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-006-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-006.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-007-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-007.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-008-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-008.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-009-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-009.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-008-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-008.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-015.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-016.html

[webkit-changes] [244036] trunk

2019-04-08 Thread jfernandez

Title: [244036] trunk

Revision 244036
Author jfernan...@igalia.com
Date 2019-04-08 13:31:05 -0700 (Mon, 08 Apr 2019)

Log Message
Implement white-space:break-spaces value
https://bugs.webkit.org/show_bug.cgi?id=177327

Reviewed by Myles Maxfield and Zalan Bujtas.

LayoutTests/imported/w3c:

Imoprted a few aditional tests from the CSS Text WPT suite that are relevant for this change.

* web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-008-expected.html: Added.
* web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-008.html: Added.
* web-platform-tests/css/css-text/overflow-wrap/w3c-import.log:
* web-platform-tests/css/css-text/parsing/white-space-valid-expected.txt:
* web-platform-tests/css/css-text/white-space/break-spaces-003-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-003.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-009-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-009.html: Added.
* web-platform-tests/css/css-text/white-space/w3c-import.log:

Source/WebCore:

Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] https://github.com/w3c/csswg-drafts/pull/2841

Tests: imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-008.html
imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-003.html
imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-009.html

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): New mapping for CSSVaueBreakSpaces.
(WebCore::CSSPrimitiveValue::operator WhiteSpace const): New value BreakSpaces for the Whitespace enum.
* css/CSSProperties.json: new 'break-spaces' value for the 'white-space' property.
* css/CSSValueKeywords.in: new break-spaces keyword
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
* rendering/SimpleLineLayout.cpp: The SimpleLineLayut codepath must handle properly the new behavior of preserved whitespaces.
(WebCore::SimpleLineLayout::LineState::hasTrailingWhitespace const): Require that m_trailingWhitespaceWidth being greater than zero.
(WebCore::SimpleLineLayout::LineState::hasWhitespaceFragments const): New function to detect former whitespae fragments that could be breaking opportunities.
(WebCore::SimpleLineLayout::removeTrailingWhitespace): The 'break-spaces' feature forbids to remove any trailing whitespace.
(WebCore::SimpleLineLayout::firstFragment): We have now leading whitespace sequences comming from the previous line.
(WebCore::SimpleLineLayout::createLineRuns): We should revert some breaking opportunities if others were formerly found in the line.
* rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style): New style fields to determine whether the break-space feature is being used. Also split out the break-all and breal-all values.
* rendering/SimpleLineLayoutTextFragmentIterator.h:
* rendering/line/BreakingContext.h: Different codepath but similar changes to properly handle the new behavior of preserved whitespace.
(WebCore::BreakingContext::BreakingContext): New class field to determine whether there are some whitespace that may prevent the word ot be broken.
(WebCore::BreakingContext::handleText): New line-breaking logic to implement the break-spaces behavior.
(WebCore::BreakingContext::trailingSpacesHang): Cases where the preserved breakspaces should hand or overflow.
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::collapseWhiteSpace): With break-spaces collapsing whitespaces is not allowed.
(WebCore::RenderStyle::breakOnlyAfterWhiteSpace const): Add the WhiteSpace::BreakSpaces to this group.
* rendering/style/RenderStyleConstants.h: A new constan added.

LayoutTests:

Removed many failure expectations of tests that pass now thanks to this change.

The overflow-wrap-break-word-003.html tests fails in mac and iOS platforms due to an issue related to
how we compute widths using 'ch' units and 'monospace' fonts. I filed bug #196169 to report the specific
case of this test (break-word+pre-wrap) but the root cause it's probably the bug #196353.

I have submitted a PR [1] to the Web Platform Tests to change several tests that failed only if the
monospace font is used, but pass with the Ahem font. Additionally, I've requested another PR [2] to
add new layout tests, with the

[webkit-changes] [243664] trunk/LayoutTests

2019-03-29 Thread jfernandez

Title: [243664] trunk/LayoutTests








Revision 243664
Author jfernan...@igalia.com
Date 2019-03-29 14:52:53 -0700 (Fri, 29 Mar 2019)


Log Message
Update the CSS Text WPT test suite
https://bugs.webkit.org/show_bug.cgi?id=196397

Reviewed by Manuel Rego Casasnovas.

Updated several tests from the CSS Text test suite.

* resources/resource-files.json:
* web-platform-tests/css/css-text/META.yml:
* web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-006.html:
* web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007.html:
* web-platform-tests/css/css-text/white-space/break-spaces-004.html:
* web-platform-tests/css/css-text/white-space/break-spaces-005.html:
* web-platform-tests/css/css-text/white-space/break-spaces-006.html:
* web-platform-tests/css/css-text/white-space/break-spaces-007.html:
* web-platform-tests/css/css-text/white-space/break-spaces-008.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-008.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-015.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-016.html:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-001-expected.html:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-001.html:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-002-expected.html:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-002.html:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-003-expected.html:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-003.html:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-004-expected.html:
* web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-004.html:
* web-platform-tests/css/css-text/word-break/w3c-import.log:
* web-platform-tests/css/css-text/word-break/word-break-break-all-010.html:
* web-platform-tests/css/css-text/word-break/word-break-break-all-011.html:
* web-platform-tests/css/css-text/word-break/word-break-break-all-012.html:
* web-platform-tests/css/css-text/word-break/word-break-break-all-013.html:
* web-platform-tests/css/css-text/word-break/word-break-break-all-015.html:
* web-platform-tests/css/css-text/word-break/word-break-break-word-overflow-wrap-interactions-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-word-overflow-wrap-interactions.html: Added.

Modified Paths

trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/META.yml
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-006.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-004.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-005.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-006.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-007.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-008.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-008.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-015.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-016.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-001-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-002-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-002.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-003-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-003.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-004-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-004.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/w3c-import.log
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-010.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-011.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-012.html

[webkit-changes] [243437] trunk

2019-03-25 Thread jfernandez

Title: [243437] trunk








Revision 243437
Author jfernan...@igalia.com
Date 2019-03-25 08:07:35 -0700 (Mon, 25 Mar 2019)


Log Message
A single leading space is not considered as a word break even when word-break: break-all is set
https://bugs.webkit.org/show_bug.cgi?id=195361

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Imported additonal WPT from the CSS Text Suite that verify the
change doesn't regress in any case, specially for the word-break:
break-word feature.

* web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007-expected.html: Added.
* web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007.html: Added.
* web-platform-tests/css/css-text/overflow-wrap/w3c-import.log:
* web-platform-tests/css/css-text/white-space/pre-wrap-008-expected.html: Added.
* web-platform-tests/css/css-text/white-space/pre-wrap-008.html: Added.
* web-platform-tests/css/css-text/white-space/w3c-import.log:
* web-platform-tests/css/css-text/word-break/w3c-import.log:
* web-platform-tests/css/css-text/word-break/word-break-break-all-015-expected.html: Added.
* web-platform-tests/css/css-text/word-break/word-break-break-all-015.html: Added.

Source/WebCore:

We must consider leading white-spaces as potential soft-breaking
opportunities that may avoid breaking in the middle of the word.

However, 'break-word: break-all' [1] implies that we should ignore
previous opportunities and break at any character (among the ones
valid for 'break-all') that prevents the line to overflow. Note,
that these breakable characters are different from the ones
provided by 'line-break: anywhere' [2].

This change is covered by the already existent tests of the CSS
Text 3 suite of the Web Platform Tests.

The word-break-break-all-010.html was precisely designed to cover
the basic issue fixed with this change, verifying that the word is
indeed broken even if a single leading space constitutes a
previous soft-breaking opportunity.

There are other Web Platform Tests. which already pass before this
change, to verify that such leading white-space must be used
instead of breaking the word in any other case, including
overflow-wrap: break-word and even the deprecated word-break:
break-word.

   - white-space/pre-wrap-008.html
   - white-space/pre-wrap-015.html
   - white-space/pre-wrap-016.html
   - overflow-wrap/overflow-wrap-break-word-004.html
   - overflow-wrap/overflow-wrap-break-word-005.html
   - overflow-wrap/overflow-wrap-break-word-007.html
   - word-break/word-break-break-all-011.html
   - word-break/word-break-break-all-014.html

The reason why the word-break-break-all-010.html passes in Mac
platform is that for that case the SimpleLineLayout codepath is
executed instead, which doesn't have this bug, present in the old
line-breaking logic implemented in the BreakingContext class.

In order to verify the validity of this change, I've added several
tests under fast/text with the SimpleLineLayout disabled.

Tests: fast/text/overflow-wrap-break-word-004.html
   fast/text/overflow-wrap-break-word-005.html
   fast/text/overflow-wrap-break-word-007.html
   fast/text/whitespace/pre-wrap-008.html
   fast/text/whitespace/pre-wrap-015.html
   fast/text/whitespace/pre-wrap-016.html
   fast/text/word-break-break-all-010.html
   fast/text/word-break-break-all-011.html
   fast/text/word-break-break-all-015.html
   imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007.html
   imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-008.html
   imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-015.html

* rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):

LayoutTests:

Removed some entries from the GTK expectation file.
Added tests to verify the codepath with SimpleLineLayout disabled.

* fast/text/overflow-wrap-break-word-004-expected.html: Added.
* fast/text/overflow-wrap-break-word-004.html: Added.
* fast/text/overflow-wrap-break-word-005-expected.html: Added.
* fast/text/overflow-wrap-break-word-005.html: Added.
* fast/text/overflow-wrap-break-word-007-expected.html: Added.
* fast/text/overflow-wrap-break-word-007.html: Added.
* fast/text/whitespace/pre-wrap-008-expected.html: Added.
* fast/text/whitespace/pre-wrap-008.html: Added.
* fast/text/whitespace/pre-wrap-015-expected.html: Added.
* fast/text/whitespace/pre-wrap-015.html: Added.
* fast/text/whitespace/pre-wrap-016-expected.html: Added.
* fast/text/whitespace/pre-wrap-016.html: Added.
* fast/text/word-break-break-all-010-expected.html: Added.
* fast/text/word-break-break-all-010.html: Added.
* fast/text/word-break-break-all-011-expected.html: Added.
* fast/text/word-break-break-all-011.html: Added.
* fast/text/word-break-break-all-015-expected.html: Added.
* fast/text/word-break-break-all-015.html: Added.
* platform/gtk/TestExpectations:
  - word-break-break-all-010.html passes now thanks to this change.

[webkit-changes] [242704] trunk/LayoutTests

2019-03-11 Thread jfernandez

Title: [242704] trunk/LayoutTests








Revision 242704
Author jfernan...@igalia.com
Date 2019-03-11 08:38:13 -0700 (Mon, 11 Mar 2019)


Log Message
Unreviewed GTK test gardening
https://bugs.webkit.org/show_bug.cgi?id=195551

Unreviewed test gardening.

Mark the text-transform-capitilize-026.html as flaky for all platforms.


* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (242703 => 242704)

--- trunk/LayoutTests/ChangeLog	2019-03-11 15:26:04 UTC (rev 242703)
+++ trunk/LayoutTests/ChangeLog	2019-03-11 15:38:13 UTC (rev 242704)
@@ -1,3 +1,14 @@
+2019-03-11  Javier Fernandez  
+
+Unreviewed GTK test gardening
+https://bugs.webkit.org/show_bug.cgi?id=195551
+
+Unreviewed test gardening.
+
+Mark the text-transform-capitilize-026.html as flaky for all platforms.
+
+* TestExpectations:
+
 2019-03-10  Zalan Bujtas  
 
 [ContentChangeObserver] Fix failing test cases


Modified: trunk/LayoutTests/TestExpectations (242703 => 242704)

--- trunk/LayoutTests/TestExpectations	2019-03-11 15:26:04 UTC (rev 242703)
+++ trunk/LayoutTests/TestExpectations	2019-03-11 15:38:13 UTC (rev 242704)
@@ -1860,7 +1860,7 @@
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-001.html [ ImageOnlyFailure ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-018.html [ ImageOnlyFailure Pass ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-020.html [ ImageOnlyFailure Pass ]
-webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-026.html [ ImageOnlyFailure ]
+webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-026.html [ ImageOnlyFailure Pass ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-028.html [ ImageOnlyFailure Pass ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-fullwidth-001.xht [ ImageOnlyFailure ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-fullwidth-002.xht [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238888] trunk

2018-12-05 Thread jfernandez

Title: [23] trunk








Revision 23
Author jfernan...@igalia.com
Date 2018-12-05 00:17:10 -0800 (Wed, 05 Dec 2018)


Log Message
[css-grid] Crash on debug changing the style of a positioned element
https://bugs.webkit.org/show_bug.cgi?id=191473

Reviewed by Dean Jackson and Zalan Bujtas.

Source/WebCore:

When an box becomes {out-of,in}-flow, it may be re-parented and it may become a grid
item. In that case, we must mark the RenderGrid as dirty, so that the grid items
placement logic is executed again.

Test: fast/css-grid-layout/grid-crash-out-of-flow-positioned-element.html

* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::childFlowStateChangesAndAffectsParentBlock): Consider the case of a box's new parent being a grid container.

LayoutTests:

Regression test to ensure that the grid placement logic is executed
when a positioned item becomes a grid item.

* fast/css-grid-layout/grid-crash-out-of-flow-positioned-element-expected.txt:
* fast/css-grid-layout/grid-crash-out-of-flow-positioned-element.html:
* TestExpectations: Remove a Skip entry, since the test doesn't crash anymore.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/fast/css-grid-layout/grid-crash-out-of-flow-positioned-element-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-crash-out-of-flow-positioned-element.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (238887 => 23)

--- trunk/LayoutTests/ChangeLog	2018-12-05 06:52:17 UTC (rev 238887)
+++ trunk/LayoutTests/ChangeLog	2018-12-05 08:17:10 UTC (rev 23)
@@ -1,3 +1,17 @@
+2018-12-05  Javier Fernandez  
+
+[css-grid] Crash on debug changing the style of a positioned element
+https://bugs.webkit.org/show_bug.cgi?id=191473
+
+Reviewed by Dean Jackson and Zalan Bujtas.
+
+Regression test to ensure that the grid placement logic is executed
+when a positioned item becomes a grid item.
+
+* fast/css-grid-layout/grid-crash-out-of-flow-positioned-element-expected.txt:
+* fast/css-grid-layout/grid-crash-out-of-flow-positioned-element.html:
+* TestExpectations: Remove a Skip entry, since the test doesn't crash anymore.
+
 2018-12-04  Simon Fraser  
 
 Attempt to de-flake this test by scrolling a bit more.


Modified: trunk/LayoutTests/TestExpectations (238887 => 23)

--- trunk/LayoutTests/TestExpectations	2018-12-05 06:52:17 UTC (rev 238887)
+++ trunk/LayoutTests/TestExpectations	2018-12-05 08:17:10 UTC (rev 23)
@@ -617,7 +617,6 @@
 webkit.org/b/191462 imported/w3c/web-platform-tests/css/css-grid/grid-items/percentage-size-replaced-subitems-001.html [ ImageOnlyFailure ]
 webkit.org/b/191463 imported/w3c/web-platform-tests/css/css-grid/grid-items/explicitly-sized-grid-item-as-table.html
 webkit.org/b/191627 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html [ Failure ]
-webkit.org/b/191473 fast/css-grid-layout/grid-crash-out-of-flow-positioned-element.html [ Skip ]
 webkit.org/b/149890 fast/css-grid-layout/grid-shorthands-style-format.html [ Failure ]
 webkit.org/b/191506 fast/css-grid-layout/grid-item-scroll-position.html [ Failure ]
 webkit.org/b/191507 fast/css-grid-layout/positioned-grid-container-percentage-tracks.html [ Failure ]


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-crash-out-of-flow-positioned-element-expected.txt (238887 => 23)

--- trunk/LayoutTests/fast/css-grid-layout/grid-crash-out-of-flow-positioned-element-expected.txt	2018-12-05 06:52:17 UTC (rev 238887)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-crash-out-of-flow-positioned-element-expected.txt	2018-12-05 08:17:10 UTC (rev 23)
@@ -0,0 +1,2 @@
+This test has passed if it didn't crash.
+


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-crash-out-of-flow-positioned-element.html (238887 => 23)

--- trunk/LayoutTests/fast/css-grid-layout/grid-crash-out-of-flow-positioned-element.html	2018-12-05 06:52:17 UTC (rev 238887)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-crash-out-of-flow-positioned-element.html	2018-12-05 08:17:10 UTC (rev 23)
@@ -3,7 +3,6 @@
 
 .absolutelyPositioned { position: absolute; }
 
-crbug.com/280451 - Heap-use-after-free in WebCore::LayoutGrid::computePreferredTrackWidth
 This test has passed if it didn't crash.
 
 if (window.testRunner)
@@ -10,8 +9,8 @@
 testRunner.dumpAsText();
 
 var cell = document.createElement("cell");
-cell.setAttribute("class", "absolutelyPositioned");
+cell.classList.add("absolutelyPositioned");
 document.body.appendChild(cell);
-window.scrollBy(98, 28);
-cell.setAttribute("class",

[webkit-changes] [238551] trunk

2018-11-27 Thread jfernandez

Title: [238551] trunk








Revision 238551
Author jfernan...@igalia.com
Date 2018-11-27 05:52:57 -0800 (Tue, 27 Nov 2018)


Log Message
[css-grid] align-self center and position sticky don't work together
https://bugs.webkit.org/show_bug.cgi?id=191963

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

This change makes several cases of the following tests to pass now.

* web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt:
* web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt:
* web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-001-expected.txt:
* web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-002-expected.txt:

Source/WebCore:

This is a fix for a regression introduced in r515391, where we landed
the implementation of alignment for positioned objects in a Grid Layout
container.

We assumed that items with non-static positions shouldn't honor the
CSS Box Alignment properties. This is only true for out-of-flow items,
absolute or fixed positioned elements. However, sticky positioned
elements are treated as relative positioned items, but they indeed use
non-static position to define their behavior.

No new tests, this change is covered by current tests and make several cases to pass now.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::columnAxisPositionForChild const):
(WebCore::RenderGrid::rowAxisPositionForChild const):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-002-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (238550 => 238551)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-11-27 13:34:17 UTC (rev 238550)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-11-27 13:52:57 UTC (rev 238551)
@@ -1,3 +1,17 @@
+2018-11-27  Javier Fernandez  
+
+[css-grid] align-self center and position sticky don't work together
+https://bugs.webkit.org/show_bug.cgi?id=191963
+
+Reviewed by Manuel Rego Casasnovas.
+
+This change makes several cases of the following tests to pass now.
+
+* web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt:
+* web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt:
+* web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-001-expected.txt:
+* web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-sticky-positioned-items-002-expected.txt:
+
 2018-11-26  Javier Fernandez  
 
 [css-grid] absolute positioned child is sized wrongly when using auto-fit, generating spurious collapsed tracks


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt (238550 => 238551)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt	2018-11-27 13:34:17 UTC (rev 238550)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-001-expected.txt	2018-11-27 13:52:57 UTC (rev 238551)
@@ -1,38 +1,4 @@
 
-FAIL .grid 1 assert_equals: 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-offsetTop expected 140 but got 100
-FAIL .grid 2 assert_equals: 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-offsetTop expected 140 but got 100
+PASS .grid 1 
+PASS .grid 2 
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt (238550 => 238551)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt	2018-11-27 13:34:17 UTC (rev 238550)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-sticky-positioned-items-002-expected.txt	2018-11-27 13:52:57 UTC (rev 238551)
@@ -1,38 +1,4 @@
 
-FAIL .grid 1 assert_equals: 
-

[webkit-changes] [238491] trunk

2018-11-26 Thread jfernandez

Title: [238491] trunk








Revision 238491
Author jfernan...@igalia.com
Date 2018-11-26 04:09:04 -0800 (Mon, 26 Nov 2018)


Log Message
[css-grid] absolute positioned child is sized wrongly when using auto-fit, generating spurious collapsed tracks
https://bugs.webkit.org/show_bug.cgi?id=191938

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

This change makes several cases of the following tests to pass now.

* web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-004-expected.txt:
* web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-005-expected.txt:
* web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-006-expected.txt:
* web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-007-expected.txt:

Source/WebCore:

The guttersSize function has a complex logic to compute the gaps in a
specific GridSpan, considering different scenarios of collapsed tracks
for such span.

The first case is avoiding the duplicated gap because of trailing
collapsed tracks.

The second case considered is looking for non-empty tracks before the
GridSpan end, if it points to an empty track, so we must add this gap.

The last case is to consider the gap of non-empty tracks after the
GridSpan end line, if it points to an empty track.

There are several cases that are not considered or incorrectly computed.
This patch addresses those cases; basically, we should only consider gaps
when there are non-empty tracks before and after the collapsed tracks.
Additionally, we should avoid duplicating the gaps size adding both,
before and after non-empty track's gap.

No new tests, this change is covered by current tests and make several cases to pass now.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::guttersSize const):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-004-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-005-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-006-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-007-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (238490 => 238491)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-11-26 09:40:49 UTC (rev 238490)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-11-26 12:09:04 UTC (rev 238491)
@@ -1,3 +1,17 @@
+2018-11-26  Javier Fernandez  
+
+[css-grid] absolute positioned child is sized wrongly when using auto-fit, generating spurious collapsed tracks
+https://bugs.webkit.org/show_bug.cgi?id=191938
+
+Reviewed by Manuel Rego Casasnovas.
+
+This change makes several cases of the following tests to pass now.
+
+* web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-004-expected.txt:
+* web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-005-expected.txt:
+* web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-006-expected.txt:
+* web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-007-expected.txt:
+
 2018-11-26  Manuel Rego Casasnovas  
 
 [css-grid] Fix grid container sizing under min-content height


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-004-expected.txt (238490 => 238491)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-004-expected.txt	2018-11-26 09:40:49 UTC (rev 238490)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-004-expected.txt	2018-11-26 12:09:04 UTC (rev 238491)
@@ -1,11 +1,4 @@
 
-FAIL .grid 1 assert_equals: 
-
-
-
-
-
-
-width expected 30 but got 25
+PASS .grid 1 
 
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-005-expected.txt (238490 => 238491)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-005-expected.txt	2018-11-26 09:40:49 UTC (rev 238490)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-and-autofit-tracks-005-expected.txt	2018-11-26 12:09:04 UTC (rev 238491)
@@ -1,11 +1,4 @@
 
-FAIL .grid 1 assert_equals: 
-
-
-
-
-
-
-width expected 30 but got 25
+PASS .grid 1 
 
 


Modified:

[webkit-changes] [238441] trunk

2018-11-22 Thread jfernandez

Title: [238441] trunk








Revision 238441
Author jfernan...@igalia.com
Date 2018-11-22 00:45:48 -0800 (Thu, 22 Nov 2018)


Log Message
Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: baseline
https://bugs.webkit.org/show_bug.cgi?id=191881

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

We should use the font's descent value when wriring-mode flips line flow (vertical-lr).

This change also fixes bug 170175, since Flexbox use the same code to determine the first
line baseline of a flex item.

Test: fast/writing-mode/vertical-align-table-baseline-latin.html

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::firstLineBaseline const):

LayoutTests:

Tests to verify that columns of a vertical-lr table vertically aligned by baseline work like
in the case of horizontal tables.
Also added tests to verify flexbox baseline alignment works as expected in vertical-lr mode.

The vertical-align-table-baseline.html test has been rebaselined due to the new behavior.

* fast/writing-mode/vertical-align-table-baseline-latin-expected.html: Added.
* fast/writing-mode/vertical-align-table-baseline-latin.html: Added.
* fast/writing-mode/vertical-align-flex-baseline-expected.html: Added.
* fast/writing-mode/vertical-align-flex-baseline-html: Added.
* platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt: Rebaseline.
* platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png: Rebaseline.
* platform/win/fast/writing-mode/vertical-align-table-baseline-expected.txt: Rebaseline.
* platform/win/fast/writing-mode/vertical-align-table-baseline-expected.png: Rebaseline.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png
trunk/LayoutTests/platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt
trunk/LayoutTests/platform/win/fast/writing-mode/vertical-align-table-baseline-expected.png
trunk/LayoutTests/platform/win/fast/writing-mode/vertical-align-table-baseline-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp


Added Paths

trunk/LayoutTests/fast/writing-mode/vertical-align-flexbox-baseline-expected.html
trunk/LayoutTests/fast/writing-mode/vertical-align-flexbox-baseline.html
trunk/LayoutTests/fast/writing-mode/vertical-align-table-baseline-latin-expected.html
trunk/LayoutTests/fast/writing-mode/vertical-align-table-baseline-latin.html




Diff

Modified: trunk/LayoutTests/ChangeLog (238440 => 238441)

--- trunk/LayoutTests/ChangeLog	2018-11-22 06:39:15 UTC (rev 238440)
+++ trunk/LayoutTests/ChangeLog	2018-11-22 08:45:48 UTC (rev 238441)
@@ -1,3 +1,25 @@
+2018-11-22  Javier Fernandez  
+
+Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: baseline
+https://bugs.webkit.org/show_bug.cgi?id=191881
+
+Reviewed by Manuel Rego Casasnovas.
+
+Tests to verify that columns of a vertical-lr table vertically aligned by baseline work like
+in the case of horizontal tables.
+Also added tests to verify flexbox baseline alignment works as expected in vertical-lr mode.
+
+The vertical-align-table-baseline.html test has been rebaselined due to the new behavior.
+
+* fast/writing-mode/vertical-align-table-baseline-latin-expected.html: Added.
+* fast/writing-mode/vertical-align-table-baseline-latin.html: Added.
+* fast/writing-mode/vertical-align-flex-baseline-expected.html: Added.
+* fast/writing-mode/vertical-align-flex-baseline-html: Added.
+* platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt: Rebaseline.
+* platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png: Rebaseline.
+* platform/win/fast/writing-mode/vertical-align-table-baseline-expected.txt: Rebaseline.
+* platform/win/fast/writing-mode/vertical-align-table-baseline-expected.png: Rebaseline.
+
 2018-11-21  Wenson Hsieh  
 
 [Cocoa] [WebKit2] Add support for replacing find-in-page text matches


Added: trunk/LayoutTests/fast/writing-mode/vertical-align-flexbox-baseline-expected.html (0 => 238441)

--- trunk/LayoutTests/fast/writing-mode/vertical-align-flexbox-baseline-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/writing-mode/vertical-align-flexbox-baseline-expected.html	2018-11-22 08:45:48 UTC (rev 238441)
@@ -0,0 +1,26 @@
+
+
+.block {
+   background: grey;
+   margin: 5px;
+   padding: 5px 10px 10px 5px;
+   width: 200px;
+   writing-mode: vertical-lr;
+   flex-flow: row;
+   align-items: baseline;
+}
+.block > :nth-child(1) { font-size:48px; }
+.block > :nth-child(2) { font-size:64px; }
+.block > :nth-child(3) { font-size:96px; }
+.block > :nth-child(4) { font-size:128px; }
+.block > div {
+   display: inline-block;
+   border-width: 4px 2px 2px 4px;
+   border-style: solid;
+   padding: 6px 4px 4px 6px;
+   margin: 10px 4px 4px 10px;
+}

[webkit-changes] [238114] trunk/Source/WebCore

2018-11-12 Thread jfernandez

cpp (238113 => 238114)

--- trunk/Source/WebCore/rendering/Grid.cpp	2018-11-12 23:42:49 UTC (rev 238113)
+++ trunk/Source/WebCore/rendering/Grid.cpp	2018-11-13 00:31:51 UTC (rev 238114)
@@ -157,7 +157,6 @@
 
 m_grid.shrink(0);
 m_gridItemArea.clear();
-m_hasAnyOrthogonalGridItem = false;
 m_smallestRowStart = 0;
 m_smallestColumnStart = 0;
 m_autoRepeatEmptyColumns = nullptr;


Modified: trunk/Source/WebCore/rendering/Grid.h (238113 => 238114)

--- trunk/Source/WebCore/rendering/Grid.h	2018-11-12 23:42:49 UTC (rev 238113)
+++ trunk/Source/WebCore/rendering/Grid.h	2018-11-13 00:31:51 UTC (rev 238114)
@@ -53,10 +53,6 @@
 // this method will return false for a grid container with only out of flow children.
 bool hasGridItems() const { return !m_gridItemArea.isEmpty(); }
 
-// FIXME: move this to SizingData once placeItemsOnGrid() takes it as argument.
-bool hasAnyOrthogonalGridItem() const { return m_hasAnyOrthogonalGridItem; }
-void setHasAnyOrthogonalGridItem(bool hasAnyOrthogonalGridItem) { m_hasAnyOrthogonalGridItem = hasAnyOrthogonalGridItem; }
-
 GridArea gridItemArea(const RenderBox& item) const;
 void setGridItemArea(const RenderBox& item, GridArea);
 
@@ -95,7 +91,6 @@
 unsigned m_autoRepeatColumns { 0 };
 unsigned m_autoRepeatRows { 0 };
 
-bool m_hasAnyOrthogonalGridItem { false };
 bool m_needsItemsPlacement { true };
 
 GridAsMatrix m_grid;


Modified: trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp (238113 => 238114)

--- trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp	2018-11-12 23:42:49 UTC (rev 238113)
+++ trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp	2018-11-13 00:31:51 UTC (rev 238114)
@@ -533,24 +533,35 @@
 track->setPlannedSize(track->plannedSize() == infinity ? track->tempSize() : std::max(track->plannedSize(), track->tempSize()));
 }
 
-LayoutUnit GridTrackSizingAlgorithm::assumedRowsSizeForOrthogonalChild(const RenderBox& child) const
+LayoutSize GridTrackSizingAlgorithm::estimatedGridAreaBreadthForChild(const RenderBox& child) const
 {
-ASSERT(GridLayoutFunctions::isOrthogonalChild(*m_renderGrid, child));
-const GridSpan& span = m_grid.gridItemSpan(child, ForRows);
+return {estimatedGridAreaBreadthForChild(child, ForColumns), estimatedGridAreaBreadthForChild(child, ForRows)};
+}
+
+LayoutUnit GridTrackSizingAlgorithm::estimatedGridAreaBreadthForChild(const RenderBox& child, GridTrackSizingDirection direction) const
+{
+const GridSpan& span = m_grid.gridItemSpan(child, direction);
 LayoutUnit gridAreaSize;
 bool gridAreaIsIndefinite = false;
-LayoutUnit containingBlockAvailableSize = m_renderGrid->containingBlockLogicalHeightForContent(ExcludeMarginBorderPadding);
+std::optional availableSize = availableSpace(direction);
 for (auto trackPosition : span) {
-GridLength maxTrackSize = gridTrackSize(ForRows, trackPosition).maxTrackBreadth();
-if (maxTrackSize.isContentSized() || maxTrackSize.isFlex())
+// We may need to estimate the grid area size before running the track
+// sizing algorithm in order to perform the pre-layout of orthogonal
+// items.
+GridTrackSize trackSize = wasSetup() ? gridTrackSize(direction, trackPosition) : rawGridTrackSize(direction, trackPosition);
+GridLength maxTrackSize = trackSize.maxTrackBreadth();
+if (maxTrackSize.isContentSized() || maxTrackSize.isFlex() || isRelativeGridLengthAsAuto(maxTrackSize, direction))
 gridAreaIsIndefinite = true;
 else
-gridAreaSize += valueForLength(maxTrackSize.length(), containingBlockAvailableSize);
+gridAreaSize += valueForLength(maxTrackSize.length(), availableSize.value_or(LayoutUnit()));
 }
 
-gridAreaSize += m_renderGrid->guttersSize(m_grid, ForRows, span.startLine(), span.integerSpan(), availableSpace(ForRows));
+gridAreaSize += m_renderGrid->guttersSize(m_grid, direction, span.startLine(), span.integerSpan(), availableSize);
 
-return gridAreaIsIndefinite ? std::max(child.maxPreferredLogicalWidth(), gridAreaSize) : gridAreaSize;
+GridTrackSizingDirection childInlineDirection = GridLayoutFunctions::flowAwareDirectionForChild(*m_renderGrid, child, ForColumns);
+if (gridAreaIsIndefinite)
+return direction == childInlineDirection ? std::max(child.maxPreferredLogicalWidth(), gridAreaSize) : LayoutUnit(-1);
+return gridAreaSize;
 }
 
 LayoutUnit GridTrackSizingAlgorithm::gridAreaBreadthForChild(const RenderBox& child, GridTrackSizingDirection direction) const
@@ -565,7 +576,7 @@
 // FIXME (jfernandez) Content Alignment should account for this heuristic.
 // https://github.com/w3c/csswg-drafts/issues/2697
 if (m_sizingState == ColumnSizingFirstIteration)
-return assumedRowsSizeForOrthogonalChild(child);
+return estimatedGridAre

[webkit-changes] [237884] trunk

2018-11-06 Thread jfernandez

Title: [237884] trunk








Revision 237884
Author jfernan...@igalia.com
Date 2018-11-06 13:45:40 -0800 (Tue, 06 Nov 2018)


Log Message
CSS grid elements with justify-content: space-around have extra whitespace, sometimes a lot
https://bugs.webkit.org/show_bug.cgi?id=191308

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Imported WPT to cover the behavior changes added in this patch.

* resources/import-expectations.json:
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-003-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-003.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-004-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-004.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:

Source/WebCore:

The CSS WG resolved [1] that Content Alignment should account to the
track sizing algorithm.

The sizing algorithm has been modified so that two new steps (1.5
and 2.5) were added to compute the Content Alignment offsets after
resolving the columns' and rows' sizes respectively.

This change decouples the Content Alignment logic from the tracks
position, so that we can use it as part of the track sizing algorithm.

I also had to store the whole ContentAlignmentData structure in two
class attributes. We need both, position and distribution offsets, to
be used in different parts of the layout logic.

[1] https://github.com/w3c/csswg-drafts/issues/2557

Tests: imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001.html
   imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html
   imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-003.html
   imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-004.html
   imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001.html
   imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001.html
   imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001.html
   imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001.html

* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::repeatTracksSizingIfNeeded):
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::gridItemOffset const):
(WebCore::RenderGrid::trackSizesForComputedStyle const):
(WebCore::RenderGrid::populateGridPositionsForDirection):
(WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild):
(WebCore::contentDistributionOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionOffset):
(WebCore::RenderGrid::nonCollapsedTracks const):
* rendering/RenderGrid.h:
(WebCore::ContentAlignmentData::isValid):
(WebCore::ContentAlignmentData::defaultOffsets):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/resources/import-expectations.json
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html

[webkit-changes] [233885] trunk

2018-07-17 Thread jfernandez

Title: [233885] trunk








Revision 233885
Author jfernan...@igalia.com
Date 2018-07-17 01:48:49 -0700 (Tue, 17 Jul 2018)


Log Message
Delete content of a single cell table should not delete the whole table
https://bugs.webkit.org/show_bug.cgi?id=173117

Reviewed by Ryosuke Niwa.

Source/WebCore:

We should not extend selection looking for special elements if the
delete operation has been triggered by a caret based selection.

This change is based on a recent [1] resolution of the Editing TF,
which acknowledges that behavior of single-cell tables must be the
same that multi-cell tables and even if the last character is
deleted, we should not delete the whole table structure.

A different case would be when the user actively selects the whole
content of a table; in this case, as we do in multi-cell tables,
the structure of single-cell tables should be deleted together
with the content.

[1] https://github.com/w3c/editing/issues/163

Tests: editing/deleting/backspace-delete-last-char-in-table.html
   editing/deleting/forward-delete-last-char-in-table.html
   editing/deleting/select-and-delete-last-char-in-table.html

* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):

LayoutTests:

Tests to verify that single-cell tables are not deleted when their
last character is deleted, unless it was previously selected by
the user.

Changes two expected files to adapt them to the new logic.

* LayoutTests/editing/deleting/deleting-relative-positioned-special-element-expected.txt: The paragraph is not deleted, even if it's empty. The paragraphs above are not merged, which was the goal of the test.
* editing/deleting/delete-last-char-in-table-expected.txt: The table is not removed, even if it's empty. The formatted elements are deleted, which was the goal of the test.
* editing/deleting/backspace-delete-last-char-in-table-expected.txt: Added.
* editing/deleting/backspace-delete-last-char-in-table.html: Added.
* editing/deleting/forward-delete-last-char-in-table-expected.txt: Added.
* editing/deleting/forward-delete-last-char-in-table.html: Added.
* editing/deleting/select-and-delete-last-char-in-table-expected.txt: Added.
* editing/deleting/select-and-delete-last-char-in-table.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/deleting/delete-last-char-in-table-expected.txt
trunk/LayoutTests/editing/deleting/deleting-relative-positioned-special-element-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TypingCommand.cpp


Added Paths

trunk/LayoutTests/editing/deleting/backspace-delete-last-char-in-table-expected.txt
trunk/LayoutTests/editing/deleting/backspace-delete-last-char-in-table.html
trunk/LayoutTests/editing/deleting/forward-delete-last-char-in-table-expected.txt
trunk/LayoutTests/editing/deleting/forward-delete-last-char-in-table.html
trunk/LayoutTests/editing/deleting/select-and-delete-last-char-in-table-expected.txt
trunk/LayoutTests/editing/deleting/select-and-delete-last-char-in-table.html




Diff

Modified: trunk/LayoutTests/ChangeLog (233884 => 233885)

--- trunk/LayoutTests/ChangeLog	2018-07-17 05:07:34 UTC (rev 233884)
+++ trunk/LayoutTests/ChangeLog	2018-07-17 08:48:49 UTC (rev 233885)
@@ -1,3 +1,25 @@
+2018-07-17  Javier Fernandez  
+
+Delete content of a single cell table should not delete the whole table
+https://bugs.webkit.org/show_bug.cgi?id=173117
+
+Reviewed by Ryosuke Niwa.
+
+Tests to verify that single-cell tables are not deleted when their
+last character is deleted, unless it was previously selected by
+the user.
+
+Changes two expected files to adapt them to the new logic.
+
+* LayoutTests/editing/deleting/deleting-relative-positioned-special-element-expected.txt: The paragraph is not deleted, even if it's empty. The paragraphs above are not merged, which was the goal of the test.
+* editing/deleting/delete-last-char-in-table-expected.txt: The table is not removed, even if it's empty. The formatted elements are deleted, which was the goal of the test.
+* editing/deleting/backspace-delete-last-char-in-table-expected.txt: Added.
+* editing/deleting/backspace-delete-last-char-in-table.html: Added.
+* editing/deleting/forward-delete-last-char-in-table-expected.txt: Added.
+* editing/deleting/forward-delete-last-char-in-table.html: Added.
+* editing/deleting/select-and-delete-last-char-in-table-expected.txt: Added.
+* editing/deleting/select-and-delete-last-char-in-table.html: Added.
+
 2018-07-16  Simon Fraser  
 
 Roll out r233873 and r233875 since they caused 8 new layout test crashes.


Added: trunk/LayoutTests/editing/deleting/backspace-delete-last-char-in-table-expected.txt (0 => 233885)

--- trunk/LayoutTests/editing/deleting/backspace-delete-last-char-in-table-expected.txt	(rev 0)
+++

[webkit-changes] [230848] trunk

2018-04-20 Thread jfernandez

Title: [230848] trunk








Revision 230848
Author jfernan...@igalia.com
Date 2018-04-20 13:06:53 -0700 (Fri, 20 Apr 2018)


Log Message
Update Alignment shorthands to the spec now that they are not ambiguous
https://bugs.webkit.org/show_bug.cgi?id=184812

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Imported new Web Platform Tests from the css-align test suite.
Additionally, updated the ones we already have to verify the new shorthand syntax is correct.

* resources/import-expectations.json:
* web-platform-tests/css/css-align/OWNERS: Added.
* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001.html:
* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002.html:
* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-001.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-003.html:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001.html:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002.html:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004.html:
* web-platform-tests/css/css-align/default-alignment/shorthand-serialization-001-expected.txt: Added.
* web-platform-tests/css/css-align/default-alignment/shorthand-serialization-001.html: Added.
* web-platform-tests/css/css-align/default-alignment/w3c-import.log:
* web-platform-tests/css/css-align/gaps/column-gap-parsing-001-expected.txt:
* web-platform-tests/css/css-align/gaps/column-gap-parsing-001.html:
* web-platform-tests/css/css-align/gaps/gap-normal-computed-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/gap-normal-computed-001.html: Added.
* web-platform-tests/css/css-align/gaps/gap-normal-used-001-expected.xht: Added.
* web-platform-tests/css/css-align/gaps/gap-normal-used-001.html: Added.
* web-platform-tests/css/css-align/gaps/gap-normal-used-002-expected.xht: Added.
* web-platform-tests/css/css-align/gaps/gap-normal-used-002.html: Added.
* web-platform-tests/css/css-align/gaps/gap-parsing-001-expected.txt:
* web-platform-tests/css/css-align/gaps/gap-parsing-001.html:
* web-platform-tests/css/css-align/gaps/grid-column-gap-parsing-001-expected.txt:
* web-platform-tests/css/css-align/gaps/grid-column-gap-parsing-001.html:
* web-platform-tests/css/css-align/gaps/grid-gap-parsing-001-expected.txt:
* web-platform-tests/css/css-align/gaps/grid-gap-parsing-001.html:
* web-platform-tests/css/css-align/gaps/grid-row-gap-parsing-001-expected.txt:
* web-platform-tests/css/css-align/gaps/grid-row-gap-parsing-001.html:
* web-platform-tests/css/css-align/gaps/row-gap-parsing-001-expected.txt:
* web-platform-tests/css/css-align/gaps/row-gap-parsing-001.html:
* web-platform-tests/css/css-align/gaps/w3c-import.log:
* web-platform-tests/css/css-align/resources/alignment-parsing-utils.js:
* web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001.html:
* web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002.html:
* web-platform-tests/css/css-align/self-alignment/place-self-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/self-alignment/place-self-shorthand-004.html:
* web-platform-tests/css/css-align/w3c-import.log: Added.

Source/WebCore:

Now that the issue [1] about the syntax ambiguity has been resolved we
don't need to use the custom syntax anymore. The Alignment shorthands
use now the simple syntax, defined based on the longhands' syntax.

Since we allow all the values valid for each longhand, we'll update
in this CL the corresponding web platform tests. Additionally, this CL
updates also the shorthand serialization tests [2], which didn't
consider the new value 'legacy' for justify-items (and place-items) due
to the bug [3] Firefox still has pending to be fixed.

[1] https://github.com/w3c/csswg-drafts/issues/1001
[2] css/css-align/default-alignment/shorthand-serialization-001.html
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=1363875

Tests: imported/w3c/web-platform-tests/css/css-align/default-alignment/shorthand-serialization-001.html
   imported/w3c/web-platform-tests/css/css-align/gaps/gap-normal-computed-001.html
   imported/w3c/web-platform-tests/css/css-align/gaps/gap-normal-used-001.html
   imported/w3c/web-platform-tests/css/css-align/gaps/gap-normal-used-002.html

* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumePlaceContentShorthand): Using the justify-content and align-content parsing logic to parse the shorthand.
(WebCore::CSSPropertyParser::consumePlaceItemsShorthand): Using the justify-items and align-items parsing logic to parse the shorthand.

[webkit-changes] [229531] trunk

2018-03-12 Thread jfernandez

Title: [229531] trunk








Revision 229531
Author jfernan...@igalia.com
Date 2018-03-12 06:48:01 -0700 (Mon, 12 Mar 2018)


Log Message
Remove GridLayout runtime flag
https://bugs.webkit.org/show_bug.cgi?id=183484

Reviewed by Myles C. Maxfield.

Source/WebCore:

The Grid Layout feature has been enabled by default for almost a
year, so I think it's time to remove the runtime flag and the
codepath run when the feature is disabled.

No new tests, because there are no changes in functionality.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForContentPositionAndDistributionWithOverflowAlignment):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertContentAlignmentData):
* css/parser/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
* css/parser/CSSParserMode.h:
(WebCore::CSSParserContextHash::hash):
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
* dom/Document.cpp:
* dom/Document.h:
* page/RuntimeEnabledFeatures.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentOffset):
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::initialDefaultAlignment):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit:

The Grid Layout feature has been enabled by default for almost a
year, so I think it's time to remove the runtime flag and the
codepath run when the feature is disabled.

* Shared/WebPreferences.yaml:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Source/WebKitLegacy/mac:

The Grid Layout feature has been enabled by default for almost a
year, so I think it's time to remove the runtime flag and the

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Tools:

The Grid Layout feature has been enabled by default for almost a
year, so I think it's time to remove the runtime flag and the
codepath run when the feature is disabled.

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):

LayoutTests:

Since the GridLayout runtime flag is removed and the feature
enabled by default, we don't need the tests verifying the
codepaths run when the feature is disabled.

* css3/flexbox/flexbox-lines-must-be-stretched-by-default.html:
* css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled-expected.txt: Removed.
* css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html: Removed.
* fast/css-grid-layout/grid-disable-expected.txt: Removed.
* fast/css-grid-layout/grid-disable.html: Removed.
* fast/css/ensure-flexbox-compatibility-with-initial-values-expected.txt: Removed.
* fast/css/ensure-flexbox-compatibility-with-initial-values.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default-expected.txt
trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/StyleBuilderConverter.h
trunk/Source/WebCore/css/parser/CSSParser.cpp
trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp
trunk/Source/WebCore/css/parser/CSSParserMode.h
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Source/WebCore/testing/InternalSettings.idl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm


Removed Paths

trunk/LayoutTests/css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled-expected.txt
trunk/LayoutTests/css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html
trunk/LayoutTests/fast/css/ensure-flexbox-compatibility-with-initial-values-expected.txt

[webkit-changes] [228319] trunk

2018-02-09 Thread jfernandez

Title: [228319] trunk








Revision 228319
Author jfernan...@igalia.com
Date 2018-02-09 06:57:12 -0800 (Fri, 09 Feb 2018)


Log Message
[css-align] Implement the new behavior of 'legacy' for justify-items
https://bugs.webkit.org/show_bug.cgi?id=172712

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined Default Alignment related tests because of the new 'legacy' value.

* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-002-expected.txt:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-002.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-004-expected.txt:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004.html:

Source/WebCore:

The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

https://github.com/w3c/csswg-drafts/issues/1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Since the new value 'legacy' is also the default value, I don't expect
this change to break content of sites currently using the 'justify-items'
property.

No new tests, rebaselined existing test.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForItemPositionWithOverflowAlignment):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ItemPosition const):
* css/CSSProperties.json:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* css/parser/CSSPropertyParser.cpp:
(WebCore::isAuto):
(WebCore::isNormalOrStretch):
(WebCore::consumeSelfPositionOverflowPosition):
(WebCore::consumeJustifyItems):
(WebCore::consumeSimplifiedDefaultPosition):
(WebCore::consumeSimplifiedSelfPosition):
(WebCore::CSSPropertyParser::consumePlaceItemsShorthand):
(WebCore::CSSPropertyParser::consumePlaceSelfShorthand):
* rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentOffset):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::columnAxisPositionForChild const):
(WebCore::RenderGrid::rowAxisPositionForChild const):
* rendering/style/RenderStyle.cpp:
(WebCore::resolvedSelfAlignment):
(WebCore::RenderStyle::resolvedJustifyItems const):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::initialJustifyItems):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

LayoutTests:

Rebaselined Default Alignment related tests because of the new 'legacy' value.

* css3/parse-alignment-of-root-elements.html:
* css3/parse-place-items.html:
* fast/css/parse-justify-items.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/parse-alignment-of-root-elements-expected.txt
trunk/LayoutTests/css3/parse-alignment-of-root-elements.html
trunk/LayoutTests/css3/parse-place-items-expected.txt
trunk/LayoutTests/css3/parse-place-items.html
trunk/LayoutTests/fast/css/parse-justify-items-expected.txt
trunk/LayoutTests/fast/css/parse-justify-items.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-002-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-002.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-004-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp


Added Paths

[webkit-changes] [227947] trunk

2018-01-31 Thread jfernandez

Title: [227947] trunk








Revision 227947
Author jfernan...@igalia.com
Date 2018-01-31 17:56:52 -0800 (Wed, 31 Jan 2018)


Log Message
inline-block baseline not computed correctly for vertical-lr
https://bugs.webkit.org/show_bug.cgi?id=170176

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

When computing the baseline position of inline-block elements we use the
InlineFlow logicalTop and the FontMetrics ascent. The issue comes from
the fact that these units are incompatible. The logicalTop of a
vertical-lr element is offset to the left edge, while the ascent is the
distance from the right edge.

We need to either use logical value for the FontMetrics ascent so we can
compute the correctly the baselines of vertical-lr elements, or just using
the logicalBottom for these cases.

The approach based on a logicalAscent API for FontMetrics would require
a lot of work because inline-block logic assumes everything is vertical-rl
and at some point, flips the elements along the block-axis in case of
vertical-lr mode.

While it'd be desirable to get rid of this flipping logic, this patch tries
first the simpler approach of using logicalBottom, which aligns with the
currently implemented logic.

Tests: fast/inline-block/baseline-vertical-01.html
   fast/inline-block/baseline-vertical-02.html
   fast/inline-block/baseline-vertical-03.html
   fast/inline-block/baseline-vertical-04.html
   fast/inline-block/baseline-vertical-05.html
   fast/inline-block/baseline-vertical-06.html
   fast/inline-block/baseline-vertical-07.html
   fast/inline-block/baseline-vertical-08.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::inlineBlockBaseline const):

LayoutTests:

Tests to evaluate the baseline alignment in vertical modes.
Additionally, several tests were rebaselined.

Some of the new tests are marked as Failure for the ios-sim
platform because of pixel rounding errors in the absolute
positioned elements used as reference.

Finally, there are color differences in the border-styles-vertical-lr-expected.png
caused by changes in the gtk+ platform. Those differences were not noticeable until
now that the patch causes diffs in the expected.txt files.

* fast/inline-block/baseline-vertical-01-expected.html: Added.
* fast/inline-block/baseline-vertical-01.html: Added.
* fast/inline-block/baseline-vertical-02-expected.html: Added.
* fast/inline-block/baseline-vertical-02.html: Added.
* fast/inline-block/baseline-vertical-03-expected.html: Added.
* fast/inline-block/baseline-vertical-03.html: Added.
* fast/inline-block/baseline-vertical-04-expected.html: Added.
* fast/inline-block/baseline-vertical-04.html: Added.
* fast/inline-block/baseline-vertical-05-expected.html: Added.
* fast/inline-block/baseline-vertical-05.html: Added.
* fast/inline-block/baseline-vertical-06-expected.html: Added.
* fast/inline-block/baseline-vertical-06.html: Added.
* fast/inline-block/baseline-vertical-07-expected.html: Added.
* fast/inline-block/baseline-vertical-07.html: Added.
* fast/inline-block/baseline-vertical-08-expected.html: Added.
* fast/inline-block/baseline-vertical-08.html: Added.
* fast/text/emphasis-avoid-ruby-expected.png:
* fast/text/emphasis-avoid-ruby-expected.txt:
* fast/text/emphasis-overlap-expected.png:
* fast/text/emphasis-overlap-expected.txt:
* platform/gtk/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/gtk/fast/backgrounds/background-leakage-transforms-expected.txt:
* platform/gtk/fast/writing-mode/border-styles-vertical-lr-expected.png:
* platform/gtk/fast/writing-mode/border-styles-vertical-lr-expected.txt:
* platform/ios-simulator/TestExpectations:
* platform/ios/fast/backgrounds/background-leakage-transforms-expected.png: Added.
* platform/ios/fast/backgrounds/background-leakage-transforms-expected.txt:
* platform/ios/fast/writing-mode/border-styles-vertical-lr-expected.png:
* platform/ios/fast/writing-mode/border-styles-vertical-lr-expected.txt:
* platform/mac/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt:
* platform/mac/fast/writing-mode/border-styles-vertical-lr-expected.txt:
* platform/win/fast/writing-mode/text-orientation-basic-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/text/emphasis-avoid-ruby-expected.png
trunk/LayoutTests/fast/text/emphasis-avoid-ruby-expected.txt
trunk/LayoutTests/fast/text/emphasis-overlap-expected.png
trunk/LayoutTests/fast/text/emphasis-overlap-expected.txt
trunk/LayoutTests/platform/gtk/fast/backgrounds/background-leakage-transforms-expected.png
trunk/LayoutTests/platform/gtk/fast/backgrounds/background-leakage-transforms-expected.txt
trunk/LayoutTests/platform/gtk/fast/writing-mode/border-styles-vertical-lr-expected.png
trunk/LayoutTests/platform/gtk/fast/writing-mode/border-styles-vertical-lr-expected.txt

[webkit-changes] [227297] trunk

2018-01-22 Thread jfernandez

Title: [227297] trunk








Revision 227297
Author jfernan...@igalia.com
Date 2018-01-22 09:01:51 -0800 (Mon, 22 Jan 2018)


Log Message
[css-align] 'overflow' keyword must precede the self-position and content-position value
https://bugs.webkit.org/show_bug.cgi?id=181793

Reviewed by Antti Koivisto.

Source/WebCore:

There were several discussions to avoid ambiguities with the complex
values, specially when it comes to define the place-xxx shorthands.

One of the sources of problems is the 'overflow-position' keyword. The
CSS WG has decided to change the syntax of all the CSS Box Alignment
properties so that the 'overflow-position' keyword always precede the
'self-position' or the 'content-position' keywords.

https://github.com/w3c/csswg-drafts/issues/1446#event-1125715434

In order to apply this change to the Content Distribution properties'
(align-content and justify-content) syntax I had to completely
re-implement their parsing function. Thanks to this I addressed also
the issue with the content-distribution fallback, which cannot be
specified explicitly now.

https://github.com/w3c/csswg-drafts/issues/1002#ref-commit-c38cac4

No new tests, just rebaselined the expected results of the test cases affected.

Despite the so many layout tests affected by this change, it's
unlikely that it might break any content in current web
sites. This patch changes the new CSS syntax, obviously backward
compatible, defined by the new CSS Box Alignment. The
'overflow-position' keyword is only used by the layout models
implementing the new spec, so far only CSS Grid Layout.
Considering that CSS Grid has been shipped last year, it's unlikely
that many sites are using the new CSS values.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForItemPositionWithOverflowAlignment):
(WebCore::valueForContentPositionAndDistributionWithOverflowAlignment):
* css/CSSContentDistributionValue.cpp:
(WebCore::CSSContentDistributionValue::customCSSText const):
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertSelfOrDefaultAlignmentData):
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeOverflowPositionKeyword):
(WebCore::consumeContentPositionKeyword):
(WebCore::consumeContentDistributionOverflowPosition):
(WebCore::consumeSelfPositionOverflowPosition):

LayoutTests:

Rebaseline expected results of the test cases affected by this change.

* css3/parse-align-content.html:
* css3/parse-align-items.html:
* css3/parse-align-self.html:
* css3/parse-justify-content.html:
* css3/overwrite-self-alignment.html:
* css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html:
* css3/overwrite-content-alignment.html:
* fast/css-grid-layout/grid-content-alignment-overflow.html:
* fast/css-grid-layout/grid-align-justify-overflow.html:
* fast/css/parse-justify-items.html:
* fast/css/parse-justify-self.html:
* fast/repaint/align-items-overflow-change.html:
* fast/repaint/align-self-overflow-change.html:
* fast/repaint/justify-items-overflow-change.html:
* fast/repaint/justify-self-overflow-change.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html
trunk/LayoutTests/css3/overwrite-content-alignment-expected.txt
trunk/LayoutTests/css3/overwrite-content-alignment.html
trunk/LayoutTests/css3/overwrite-self-alignment-expected.txt
trunk/LayoutTests/css3/overwrite-self-alignment.html
trunk/LayoutTests/css3/parse-align-content.html
trunk/LayoutTests/css3/parse-align-items.html
trunk/LayoutTests/css3/parse-align-self.html
trunk/LayoutTests/css3/parse-justify-content.html
trunk/LayoutTests/fast/css/parse-justify-items.html
trunk/LayoutTests/fast/css/parse-justify-self.html
trunk/LayoutTests/fast/css-grid-layout/resources/grid-alignment.css
trunk/LayoutTests/fast/repaint/align-items-overflow-change.html
trunk/LayoutTests/fast/repaint/align-self-overflow-change.html
trunk/LayoutTests/fast/repaint/justify-items-overflow-change.html
trunk/LayoutTests/fast/repaint/justify-self-overflow-change.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSContentDistributionValue.cpp
trunk/Source/WebCore/css/StyleBuilderConverter.h
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (227296 => 227297)

--- trunk/LayoutTests/ChangeLog	2018-01-22 17:01:07 UTC (rev 227296)
+++ trunk/LayoutTests/ChangeLog	2018-01-22 17:01:51 UTC (rev 227297)
@@ -1,3 +1,28 @@
+2018-01-22  Javier Fernandez  
+
+[css-align] 'overflow' keyword must precede the self-position and content-position value
+https://bugs.webkit.org/show_bug.cgi?id=181793
+
+Reviewed by Antti Koivisto.
+
+Rebaseline expected results of the test cases affected by this change.
+
+* css3/parse-align-content.html:
+* css3/parse-align-items.html:
+* css3/parse-align-self.html:
+* css3/parse-justify-content.html:

[webkit-changes] [226448] trunk/Tools

2018-01-05 Thread jfernandez

Title: [226448] trunk/Tools








Revision 226448
Author jfernan...@igalia.com
Date 2018-01-05 07:34:42 -0800 (Fri, 05 Jan 2018)


Log Message
Unreviewed, added myself as WebKit reviewer

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (226447 => 226448)

--- trunk/Tools/ChangeLog	2018-01-05 14:39:31 UTC (rev 226447)
+++ trunk/Tools/ChangeLog	2018-01-05 15:34:42 UTC (rev 226448)
@@ -1,3 +1,9 @@
+2018-01-05  Javier Fernandez  
+
+Unreviewed, added myself as WebKit reviewer
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2018-01-05  Claudio Saavedra  
 
 WPE: Build fix after r226432.


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (226447 => 226448)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2018-01-05 14:39:31 UTC (rev 226447)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2018-01-05 15:34:42 UTC (rev 226448)
@@ -2703,7 +2703,7 @@
   "nicks" : [
  "lajava"
   ],
-  "status" : "committer"
+  "status" : "reviewer"
},
"Jay Civelli" : {
   "emails" : [
@@ -5957,4 +5957,4 @@
   ],
   "status" : "reviewer"
}
-}
\ No newline at end of file
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225163] trunk

2017-11-27 Thread jfernandez

Title: [225163] trunk








Revision 225163
Author jfernan...@igalia.com
Date 2017-11-27 01:29:07 -0800 (Mon, 27 Nov 2017)


Log Message
[css-grid] Display issues with child with max-width
https://bugs.webkit.org/show_bug.cgi?id=178973

Reviewed by Darin Adler.

Source/WebCore:

We have an utility function to compute the grid item's margins
when the item still needs to layout. We used the function
RenderStyle::hasMarings to decide whether such margin computation
worths. However, we need that function to operate on a specific
axis, hence I added a new function adding such logic.

Additionally, we must treat any 'auto' margin as 0px during the
tracks sizing algorithm, as the CSS Grid spec states:

  - https://drafts.csswg.org/css-grid/#auto-margins

Test: fast/css-grid-layout/auto-margins-ignored-during-track-sizing.html

* rendering/GridLayoutFunctions.cpp:
(WebCore::GridLayoutFunctions::childHasMargin): New funciton with axis dependent logic.
(WebCore::GridLayoutFunctions::computeMarginLogicalSizeForChild): Ignore auto margins.
(WebCore::GridLayoutFunctions::marginLogicalSizeForChild): Ignore auto margins.

LayoutTests:

Regression test for the bug.

* fast/css-grid-layout/auto-margins-ignored-during-track-sizing-expected.html: Added.
* fast/css-grid-layout/auto-margins-ignored-during-track-sizing.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/GridLayoutFunctions.cpp


Added Paths

trunk/LayoutTests/fast/css-grid-layout/auto-margins-ignored-during-track-sizing-expected.html
trunk/LayoutTests/fast/css-grid-layout/auto-margins-ignored-during-track-sizing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (225162 => 225163)

--- trunk/LayoutTests/ChangeLog	2017-11-27 08:53:00 UTC (rev 225162)
+++ trunk/LayoutTests/ChangeLog	2017-11-27 09:29:07 UTC (rev 225163)
@@ -1,3 +1,15 @@
+2017-11-27  Javier Fernandez  
+
+[css-grid] Display issues with child with max-width
+https://bugs.webkit.org/show_bug.cgi?id=178973
+
+Reviewed by Darin Adler.
+
+Regression test for the bug.
+
+* fast/css-grid-layout/auto-margins-ignored-during-track-sizing-expected.html: Added.
+* fast/css-grid-layout/auto-margins-ignored-during-track-sizing.html: Added.
+
 2017-11-25  Frederic Wang  
 
 Import MathML WPT tests


Added: trunk/LayoutTests/fast/css-grid-layout/auto-margins-ignored-during-track-sizing-expected.html (0 => 225163)

--- trunk/LayoutTests/fast/css-grid-layout/auto-margins-ignored-during-track-sizing-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/auto-margins-ignored-during-track-sizing-expected.html	2017-11-27 09:29:07 UTC (rev 225163)
@@ -0,0 +1,26 @@
+
+
+body { overflow: hidden; }
+.grid {
+  display: grid;
+  grid-template-columns: 1fr 1fr 1fr;
+}
+.margin { margin-top: 10px; }
+.center { justify-self: center; }
+.i1 { background: magenta;  }
+.i2 { background: cyan; }
+.i3 { background: yellow; }
+.i4 { background: lime; }
+
+
+  
+In a few questions, you’ll get an expert-designed investment portfolio to fit your financial needs.
+  
+  
+Open and fund your account with $10,000 or more and we’ll put your money to work.
+  
+  
+We’ll take it from here, monitoring your portfolio daily to help keep it on track.
+  
+  Learn More
+


Added: trunk/LayoutTests/fast/css-grid-layout/auto-margins-ignored-during-track-sizing.html (0 => 225163)

--- trunk/LayoutTests/fast/css-grid-layout/auto-margins-ignored-during-track-sizing.html	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/auto-margins-ignored-during-track-sizing.html	2017-11-27 09:29:07 UTC (rev 225163)
@@ -0,0 +1,29 @@
+
+
+body { overflow: hidden; }
+.grid {
+  display: grid;
+  grid-template-columns: 1fr 1fr 1fr;
+}
+.margin-center {
+  margin-top: 10px;
+  margin-left: auto;
+  margin-right: auto;
+}
+.i1 { background: magenta;  }
+.i2 { background: cyan; }
+.i3 { background: yellow; }
+.i4 { background: lime; }
+
+
+  
+In a few questions, you’ll get an expert-designed investment portfolio to fit your financial needs.
+  
+  
+Open and fund your account with $10,000 or more and we’ll put your money to work.
+  
+  
+We’ll take it from here, monitoring your portfolio daily to help keep it on track.
+  
+  Learn More
+


Modified: trunk/Source/WebCore/ChangeLog (225162 => 225163)

--- trunk/Source/WebCore/ChangeLog	2017-11-27 08:53:00 UTC (rev 225162)
+++ trunk/Source/WebCore/ChangeLog	2017-11-27 09:29:07 UTC (rev 225163)
@@ -1,3 +1,28 @@
+2017-11-27  Javier Fernandez  
+
+[css-grid] Display issues with child with max-width
+https://bugs.webkit.org/show_bug.cgi?id=178973
+
+Reviewed by Darin Adler.
+
+We have an utility function to compute the grid item's margins
+when the item still needs to layout. We used the function
+

[webkit-changes] [225104] trunk/Source/WebCore

2017-11-22 Thread jfernandez

Title: [225104] trunk/Source/WebCore








Revision 225104
Author jfernan...@igalia.com
Date 2017-11-22 15:46:15 -0800 (Wed, 22 Nov 2017)


Log Message
[css-grid] Refactoring and new namespace with grid related utility functions
https://bugs.webkit.org/show_bug.cgi?id=179633

Reviewed by Darin Adler.

Added a new namespace with several utility functions to share logic
between RenderGrid and GridTrackSizingAlgorithm.

No new tests, since no new functionality is added.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* rendering/GridLayoutUtils.cpp: Added.
(WebCore::GridLayoutUtils::computeMarginLogicalSizeForChild):
(WebCore::GridLayoutUtils::marginLogicalSizeForChild):
(WebCore::GridLayoutUtils::isOrthogonalChild):
(WebCore::GridLayoutUtils::flowAwareDirectionForChild):
* rendering/GridLayoutUtils.h: Added.
* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::assumedRowsSizeForOrthogonalChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::layoutPositionedObject):
(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching const):
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
(WebCore::RenderGrid::isInlineBaselineAlignedChild const):
(WebCore::RenderGrid::firstLineBaseline const):
(WebCore::RenderGrid::columnAxisPositionForChild const):
(WebCore::RenderGrid::rowAxisPositionForChild const):
(WebCore::RenderGrid::columnAxisOffsetForChild const):
(WebCore::RenderGrid::rowAxisOffsetForChild const):
(WebCore::RenderGrid::findChildLogicalPosition const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h
trunk/Source/WebCore/rendering/RenderMediaControls.cpp
trunk/Source/WebCore/rendering/RootInlineBox.cpp


Added Paths

trunk/Source/WebCore/rendering/GridLayoutFunctions.cpp
trunk/Source/WebCore/rendering/GridLayoutFunctions.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225103 => 225104)

--- trunk/Source/WebCore/ChangeLog	2017-11-22 22:20:26 UTC (rev 225103)
+++ trunk/Source/WebCore/ChangeLog	2017-11-22 23:46:15 UTC (rev 225104)
@@ -1,3 +1,44 @@
+2017-11-22  Javier Fernandez  
+
+[css-grid] Refactoring and new namespace with grid related utility functions
+https://bugs.webkit.org/show_bug.cgi?id=179633
+
+Reviewed by Darin Adler.
+
+Added a new namespace with several utility functions to share logic
+between RenderGrid and GridTrackSizingAlgorithm.
+
+No new tests, since no new functionality is added.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* rendering/GridLayoutUtils.cpp: Added.
+(WebCore::GridLayoutUtils::computeMarginLogicalSizeForChild):
+(WebCore::GridLayoutUtils::marginLogicalSizeForChild):
+(WebCore::GridLayoutUtils::isOrthogonalChild):
+(WebCore::GridLayoutUtils::flowAwareDirectionForChild):
+* rendering/GridLayoutUtils.h: Added.
+* rendering/GridTrackSizingAlgorithm.cpp:
+(WebCore::GridTrackSizingAlgorithm::assumedRowsSizeForOrthogonalChild const):
+(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const):
+(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
+(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
+(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
+(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):
+* rendering/RenderGrid.cpp:
+(WebCore::RenderGrid::layoutBlock):
+(WebCore::RenderGrid::placeItemsOnGrid const):
+(WebCore::RenderGrid::layoutPositionedObject):
+(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching const):
+(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
+(WebCore::RenderGrid::isInlineBaselineAlignedChild const):
+(WebCore::RenderGrid::firstLineBaseline const):
+(WebCore::RenderGrid::columnAxisPositionForChild const):
+(WebCore::RenderGrid::rowAxisPositionForChild const):
+(WebCore::RenderGrid::columnAxisOffsetForChild const):
+(WebCore::RenderGrid::rowAxisOffsetForChild const):
+(WebCore::RenderGrid::findChildLogicalPosition const):
+
 2017-11-22  Ali Juma  
 
 Implement VisualViewport API attributes

[webkit-changes] [223955] trunk/Source/WebCore

2017-10-25 Thread jfernandez

Title: [223955] trunk/Source/WebCore








Revision 223955
Author jfernan...@igalia.com
Date 2017-10-25 09:38:14 -0700 (Wed, 25 Oct 2017)


Log Message
[css-grid] Avoid clearing the overrideContainingBlockWidth if possible
https://bugs.webkit.org/show_bug.cgi?id=178260

Reviewed by Sergio Villar Senin.

Since the intrinsic width computation uses the same logic than the
track sizing algorithm we are clearing the overrideContainingBlockWidth
of some grid items that are required to laid out them properly.

It's very uncommon that any intrinsic size computation isn't performed
as part of a layout process. However, if it happens, once cleared the
overrideContainingBlockWidth it may lead to an incorrect layout of the
affected grid items.

This change is a defensive approach to avoid the issues caused by
such off-layout preferred size requests, which may imply recomputing
the grid container intrinsic size.

No new tests, because we are only removing some redundant logic.

* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::updateOverrideContainingBlockContentSizeForChild const):
(WebCore::IndefiniteSizeStrategy::minLogicalWidthForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):
* rendering/GridTrackSizingAlgorithm.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (223954 => 223955)

--- trunk/Source/WebCore/ChangeLog	2017-10-25 15:11:07 UTC (rev 223954)
+++ trunk/Source/WebCore/ChangeLog	2017-10-25 16:38:14 UTC (rev 223955)
@@ -1,3 +1,34 @@
+2017-10-25  Javier Fernandez  
+
+[css-grid] Avoid clearing the overrideContainingBlockWidth if possible
+https://bugs.webkit.org/show_bug.cgi?id=178260
+
+Reviewed by Sergio Villar Senin.
+
+Since the intrinsic width computation uses the same logic than the
+track sizing algorithm we are clearing the overrideContainingBlockWidth
+of some grid items that are required to laid out them properly.
+
+It's very uncommon that any intrinsic size computation isn't performed
+as part of a layout process. However, if it happens, once cleared the
+overrideContainingBlockWidth it may lead to an incorrect layout of the
+affected grid items.
+
+This change is a defensive approach to avoid the issues caused by
+such off-layout preferred size requests, which may imply recomputing
+the grid container intrinsic size.
+
+No new tests, because we are only removing some redundant logic.
+
+* rendering/GridTrackSizingAlgorithm.cpp:
+(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
+(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
+(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
+(WebCore::GridTrackSizingAlgorithmStrategy::updateOverrideContainingBlockContentSizeForChild const):
+(WebCore::IndefiniteSizeStrategy::minLogicalWidthForChild const):
+(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):
+* rendering/GridTrackSizingAlgorithm.h:
+
 2017-10-25  Gustavo Noronha Silva  
 
 Unreviewed follow up changing one more enum value as discussed in the bug


Modified: trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp (223954 => 223955)

--- trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp	2017-10-25 15:11:07 UTC (rev 223954)
+++ trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp	2017-10-25 16:38:14 UTC (rev 223955)
@@ -742,11 +742,6 @@
 {
 GridTrackSizingDirection childInlineDirection = flowAwareDirectionForChild(renderGrid(), child, ForColumns);
 if (direction() == childInlineDirection) {
-// If |child| has a relative logical width, we shouldn't let it override its intrinsic width, which is
-// what we are interested in here. Thus we need to set the override logical width to std::nullopt (no possible resolution).
-if (shouldClearOverrideContainingBlockContentSizeForChild(child, ForColumns))
-setOverrideContainingBlockContentSizeForChild(child, childInlineDirection, std::nullopt);
-
 // FIXME: It's unclear if we should return the intrinsic width or the preferred width.
 // See http://lists.w3.org/Archives/Public/www-style/2013Jan/0245.html
 LayoutUnit marginLogicalWidth = child.needsLayout() ? computeMarginLogicalSizeForChild(childInlineDirection, *renderGrid(), child) : child.marginLogicalWidth();
@@ -762,11 +757,6 @@
 {
 GridTrackSizingDirection

[webkit-changes] [222317] trunk

2017-09-21 Thread jfernandez

Title: [222317] trunk








Revision 222317
Author jfernan...@igalia.com
Date 2017-09-21 06:43:28 -0700 (Thu, 21 Sep 2017)


Log Message
Unpredictable selection when dragging out of float elements children of in-flow block-level box
https://bugs.webkit.org/show_bug.cgi?id=176096

Reviewed by David Hyatt.

Source/WebCore:

In order to improve Selection across float elements we need to
consider them as HitTest candidates.  Additionally, since
out-of-flow elements must not affect how in-flow elements are
rendered we have to deal with some special cases when implementing
the positionForPoint logic.

This patch addresses the issues caused by the fact that an in-flow
box's logicalBottom does not consider the out-of-flow children, as
they don't affect its height. Hence, we should add the lowest float
logical bottom to figure out the box the point is actually hitting.

Tests: editing/selection/select-out-of-floated-non-editable-01.html
   editing/selection/select-out-of-floated-non-editable-02.html
   editing/selection/select-out-of-floated-non-editable-03.html
   editing/selection/select-out-of-floated-non-editable-04.html
   editing/selection/select-out-of-floated-non-editable-05.html
   editing/selection/select-out-of-floated-non-editable-06.html
   editing/selection/select-out-of-floated-non-editable-07.html
   editing/selection/select-out-of-floated-non-editable-08.html
   editing/selection/select-out-of-floated-non-editable-09.html
   editing/selection/select-out-of-floated-non-editable-10.html
   editing/selection/select-out-of-floated-non-editable-11.html
   editing/selection/select-out-of-floated-non-editable-12.html

* rendering/RenderBlock.cpp:
(WebCore::isChildHitTestCandidate):
(WebCore::RenderBlock::positionForPoint):

LayoutTests:

Tests defining several cases of selection with floats, children of
a block-level box, so they behave as regular HitTest candidates
and don't mess the selection boundaries.

* editing/selection/resources/select-out-of-floated-non-editable.js: Added.
(clearLog):
(log):
(else.window.onmouseup):
(runTest):
(checkSelection):
* editing/selection/select-out-of-floated-non-editable-01-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-01.html: Added.
* editing/selection/select-out-of-floated-non-editable-02-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-02.html: Added.
* editing/selection/select-out-of-floated-non-editable-03-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-03.html: Added.
* editing/selection/select-out-of-floated-non-editable-04-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-04.html: Added.
* editing/selection/select-out-of-floated-non-editable-05-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-05.html: Added.
* editing/selection/select-out-of-floated-non-editable-06-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-06.html: Added.
* editing/selection/select-out-of-floated-non-editable-07-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-07.html: Added.
* editing/selection/select-out-of-floated-non-editable-08-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-08.html: Added.
* editing/selection/select-out-of-floated-non-editable-09-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-09.html: Added.
* editing/selection/select-out-of-floated-non-editable-10-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-10.html: Added.
* editing/selection/select-out-of-floated-non-editable-11-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-11.html: Added.
* editing/selection/select-out-of-floated-non-editable-12-expected.txt: Added.
* editing/selection/select-out-of-floated-non-editable-12.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlockFlow.h


Added Paths

trunk/LayoutTests/editing/selection/resources/select-out-of-floated-non-editable.js
trunk/LayoutTests/editing/selection/select-out-of-floated-non-editable-01-expected.txt
trunk/LayoutTests/editing/selection/select-out-of-floated-non-editable-01.html
trunk/LayoutTests/editing/selection/select-out-of-floated-non-editable-02-expected.txt
trunk/LayoutTests/editing/selection/select-out-of-floated-non-editable-02.html
trunk/LayoutTests/editing/selection/select-out-of-floated-non-editable-03-expected.txt
trunk/LayoutTests/editing/selection/select-out-of-floated-non-editable-03.html
trunk/LayoutTests/editing/selection/select-out-of-floated-non-editable-04-expected.txt
trunk/LayoutTests/editing/selection/select-out-of-floated-non-editable-04.html

[webkit-changes] [220398] trunk

2017-08-08 Thread jfernandez

Title: [220398] trunk








Revision 220398
Author jfernan...@igalia.com
Date 2017-08-08 05:22:33 -0700 (Tue, 08 Aug 2017)


Log Message
Not possible to remove the 'li' element inside the table cell
https://bugs.webkit.org/show_bug.cgi?id=173148

Reviewed by Ryosuke Niwa.

Source/WebCore:

We need to add a new case for breaking out empty list items when they are
at the start of an editable area. Since list items can be also inside
table cells, we need to consider this kind of elements as well.

Tests: editing/deleting/delete-list-items-in-table-cell-1.html
   editing/deleting/delete-list-items-in-table-cell-2.html
   editing/deleting/delete-list-items-in-table-cell-3.html
   editing/deleting/delete-list-items-in-table-cell-4.html
   editing/deleting/delete-list-items-in-table-cell-5.html
   editing/deleting/delete-list-items-in-table-cell-6.html
   editing/deleting/delete-list-items-in-table-cell-7.html
   editing/deleting/delete-list-items-in-table-cell-8.html

* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed):

LayoutTests:

Regression tests for different scenarios of list items removal.

* editing/deleting/delete-list-items-in-table-cell-1-expected.txt: Added.
* editing/deleting/delete-list-items-in-table-cell-1.html: Added.
* editing/deleting/delete-list-items-in-table-cell-2-expected.txt: Added.
* editing/deleting/delete-list-items-in-table-cell-2.html: Added.
* editing/deleting/delete-list-items-in-table-cell-3-expected.txt: Added.
* editing/deleting/delete-list-items-in-table-cell-3.html: Added.
* editing/deleting/delete-list-items-in-table-cell-4-expected.txt: Added.
* editing/deleting/delete-list-items-in-table-cell-4.html: Added.
* editing/deleting/delete-list-items-in-table-cell-5-expected.txt: Added.
* editing/deleting/delete-list-items-in-table-cell-5.html: Added.
* editing/deleting/delete-list-items-in-table-cell-6-expected.txt: Added.
* editing/deleting/delete-list-items-in-table-cell-6.html: Added.
* editing/deleting/delete-list-items-in-table-cell-7-expected.txt: Added.
* editing/deleting/delete-list-items-in-table-cell-7.html: Added.
* editing/deleting/delete-list-items-in-table-cell-8-expected.txt: Added.
* editing/deleting/delete-list-items-in-table-cell-8.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TypingCommand.cpp


Added Paths

trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-1-expected.txt
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-1.html
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-2-expected.txt
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-2.html
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-3-expected.txt
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-3.html
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-4-expected.txt
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-4.html
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-5-expected.txt
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-5.html
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-6-expected.txt
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-6.html
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-7-expected.txt
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-7.html
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-8-expected.txt
trunk/LayoutTests/editing/deleting/delete-list-items-in-table-cell-8.html




Diff

Modified: trunk/LayoutTests/ChangeLog (220397 => 220398)

--- trunk/LayoutTests/ChangeLog	2017-08-08 10:27:11 UTC (rev 220397)
+++ trunk/LayoutTests/ChangeLog	2017-08-08 12:22:33 UTC (rev 220398)
@@ -1,3 +1,29 @@
+2017-08-08  Javier Fernandez  
+
+Not possible to remove the 'li' element inside the table cell
+https://bugs.webkit.org/show_bug.cgi?id=173148
+
+Reviewed by Ryosuke Niwa.
+
+Regression tests for different scenarios of list items removal.
+
+* editing/deleting/delete-list-items-in-table-cell-1-expected.txt: Added.
+* editing/deleting/delete-list-items-in-table-cell-1.html: Added.
+* editing/deleting/delete-list-items-in-table-cell-2-expected.txt: Added.
+* editing/deleting/delete-list-items-in-table-cell-2.html: Added.
+* editing/deleting/delete-list-items-in-table-cell-3-expected.txt: Added.
+* editing/deleting/delete-list-items-in-table-cell-3.html: Added.
+* editing/deleting/delete-list-items-in-table-cell-4-expected.txt: Added.
+* editing/deleting/delete-list-items-in-table-cell-4.html: Added.
+* editing/deleting/delete-list-items-in-table-cell-5-expected.txt: Added.
+* editing/deleting/delete-list-items-in-table-cell-5.html: Added.
+*

[webkit-changes] [219914] trunk

2017-07-26 Thread jfernandez

Title: [219914] trunk








Revision 219914
Author jfernan...@igalia.com
Date 2017-07-26 02:48:37 -0700 (Wed, 26 Jul 2017)


Log Message
InsertOrderedList command applied to table cells inserts an extra BR before the table
https://bugs.webkit.org/show_bug.cgi?id=174593

Reviewed by Darin Adler.

Source/WebCore:

Don't add BR when pruning empty blocks if it's the start of a paragraph.

The function MoveParagraph is used for several operations and editing
commands, like 'insertOrderedList'. When moving paragraphs we check out
whether we should add a 'br' element to avoid undesired block collapse.

However, we shouldn't do this when destination is the start of a
paragraph.

Tests: editing/inserting/insert-list-in-table-cell-01.html
   editing/inserting/insert-list-in-table-cell-02.html
   editing/inserting/insert-list-in-table-cell-03.html
   editing/inserting/insert-list-in-table-cell-04.html
   editing/inserting/insert-list-in-table-cell-05.html
   editing/inserting/insert-list-in-table-cell-06.html
   editing/inserting/insert-list-in-table-cell-07.html
   editing/inserting/insert-list-in-table-cell-08.html

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):

LayoutTests:

Tests to verify that the insertOrderedList command works as expected when applied
in table cells.

* editing/inserting/insert-list-in-table-cell-01.html: Added.
* editing/inserting/insert-list-in-table-cell-01-expected.txt: Added.
* editing/inserting/insert-list-in-table-cell-02.html: Added.
* editing/inserting/insert-list-in-table-cell-02-expected.txt: Added.
* editing/inserting/insert-list-in-table-cell-03.html: Added.
* editing/inserting/insert-list-in-table-cell-03-expected.txt: Added.
* editing/inserting/insert-list-in-table-cell-04.html: Added.
* editing/inserting/insert-list-in-table-cell-04-expected.txt: Added.
* editing/inserting/insert-list-in-table-cell-05.html: Added.
* editing/inserting/insert-list-in-table-cell-05-expected.txt: Added.
* editing/inserting/insert-list-in-table-cell-06.html: Added.
* editing/inserting/insert-list-in-table-cell-06-expected.txt: Added.
* editing/inserting/insert-list-in-table-cell-07.html: Added.
* editing/inserting/insert-list-in-table-cell-07-expected.txt: Added.
* editing/inserting/insert-list-in-table-cell-08.html: Added.
* editing/inserting/insert-list-in-table-cell-08-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/CompositeEditCommand.cpp


Added Paths

trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-01-expected.txt
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-01.html
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-02-expected.txt
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-02.html
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-03-expected.txt
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-03.html
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-04-expected.txt
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-04.html
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-05-expected.txt
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-05.html
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-06-expected.txt
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-06.html
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-07-expected.txt
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-07.html
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-08-expected.txt
trunk/LayoutTests/editing/inserting/insert-list-in-table-cell-08.html




Diff

Modified: trunk/LayoutTests/ChangeLog (219913 => 219914)

--- trunk/LayoutTests/ChangeLog	2017-07-26 09:22:49 UTC (rev 219913)
+++ trunk/LayoutTests/ChangeLog	2017-07-26 09:48:37 UTC (rev 219914)
@@ -1,3 +1,30 @@
+2017-07-26  Javier Fernandez  
+
+InsertOrderedList command applied to table cells inserts an extra BR before the table
+https://bugs.webkit.org/show_bug.cgi?id=174593
+
+Reviewed by Darin Adler.
+
+Tests to verify that the insertOrderedList command works as expected when applied
+in table cells.
+
+* editing/inserting/insert-list-in-table-cell-01.html: Added.
+* editing/inserting/insert-list-in-table-cell-01-expected.txt: Added.
+* editing/inserting/insert-list-in-table-cell-02.html: Added.
+* editing/inserting/insert-list-in-table-cell-02-expected.txt: Added.
+* editing/inserting/insert-list-in-table-cell-03.html: Added.
+* editing/inserting/insert-list-in-table-cell-03-expected.txt: Added.
+* editing/inserting/insert-list-in-table-cell-04.html: Added.
+* editing/inserting/insert-list-in-table-cell-04-expected.txt: Added.
+* editing/inserting/insert-list-in-table-cell-05.html: Added.
+

[webkit-changes] [214966] trunk

2017-04-05 Thread jfernandez

Title: [214966] trunk








Revision 214966
Author jfernan...@igalia.com
Date 2017-04-05 13:44:10 -0700 (Wed, 05 Apr 2017)


Log Message
[css-align] Implement the place-items shorthand
https://bugs.webkit.org/show_bug.cgi?id=168847

Reviewed by David Hyatt.

Source/WebCore:

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-items and justify-items) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests. For the time being, as it happens with the
rest of the new alignment properties, the new parsing logic is
implemented behind the CSS Grid Layout runtime flag.

Test: css3/parse-place-items.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSProperties.json:
* css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::getAlignmentShorthandValue):
* css/StyleProperties.h:
* css/parser/CSSPropertyParser.cpp:
(WebCore::isAutoOrNormalOrStretch):
(WebCore::consumeSelfPositionOverflowPosition):
(WebCore::consumeSimplifiedItemPosition):
(WebCore::CSSPropertyParser::consumePlaceItemsShorthand):
* css/parser/CSSPropertyParser.h:

LayoutTests:

Regression tests for the new place-content alignment shorthand.

* css3/parse-place-items.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/StyleProperties.cpp
trunk/Source/WebCore/css/StyleProperties.h
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParser.h


Added Paths

trunk/LayoutTests/css3/parse-place-items-expected.txt
trunk/LayoutTests/css3/parse-place-items.html




Diff

Modified: trunk/LayoutTests/ChangeLog (214965 => 214966)

--- trunk/LayoutTests/ChangeLog	2017-04-05 20:17:37 UTC (rev 214965)
+++ trunk/LayoutTests/ChangeLog	2017-04-05 20:44:10 UTC (rev 214966)
@@ -1,3 +1,14 @@
+2017-04-05  Javier Fernandez  
+
+[css-align] Implement the place-items shorthand
+https://bugs.webkit.org/show_bug.cgi?id=168847
+
+Reviewed by David Hyatt.
+
+Regression tests for the new place-content alignment shorthand.
+
+* css3/parse-place-items.html: Added.
+
 2017-04-05  Carlos Alberto Lopez Perez  
 
 [WebRTC][OpenWebRTC] Add support for SDP BUNDLE ("a:group:BUNDLE" and "a=bundle-only" lines)


Added: trunk/LayoutTests/css3/parse-place-items-expected.txt (0 => 214966)

--- trunk/LayoutTests/css3/parse-place-items-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/parse-place-items-expected.txt	2017-04-05 20:44:10 UTC (rev 214966)
@@ -0,0 +1,28 @@
+Test to verify that the new place-items alignment shorthand is parsed as expected and correctly sets the longhand values.
+
+
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'normal' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'center auto' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'baseline' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'first baseline' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'last baseline' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'start' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'flex-start' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'end' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'self-start' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'stretch' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'start end' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'start self-end' value through CSS. 
+PASS Test getting the Computed Value of place-items's longhand properties when setting 'start baseline' value through CSS. 
+PASS Test setting '' as incorrect value through CSS. 
+PASS Test setting 'auto' as incorrect value through CSS. 
+PASS Test setting 'none' as incorrect value through CSS. 
+PASS Test setting 'safe' as incorrect value through CSS. 
+PASS Test setting 'start safe' as incorrect value through CSS. 
+PASS Test setting 'baseline safe' as incorrect value through CSS. 
+PASS Test setting 'start end left' as incorrect value through CSS. 
+PASS Test setting

[webkit-changes] [214938] trunk/LayoutTests

2017-04-05 Thread jfernandez

Title: [214938] trunk/LayoutTests








Revision 214938
Author jfernan...@igalia.com
Date 2017-04-05 02:13:42 -0700 (Wed, 05 Apr 2017)


Log Message
[GTK] Unreviewed tests gardening
https://bugs.webkit.org/show_bug.cgi?id=170497

Unreviewed test gardening. Rebaseline tests after r214712.


* platform/gtk/fast/multicol/table-vertical-align-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/multicol/table-vertical-align-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (214937 => 214938)

--- trunk/LayoutTests/ChangeLog	2017-04-05 08:24:48 UTC (rev 214937)
+++ trunk/LayoutTests/ChangeLog	2017-04-05 09:13:42 UTC (rev 214938)
@@ -1,3 +1,13 @@
+2017-04-05  Javier Fernandez  
+
+[GTK] Unreviewed tests gardening
+https://bugs.webkit.org/show_bug.cgi?id=170497
+
+Unreviewed test gardening. Rebaseline tests after r214712.
+
+* platform/gtk/fast/multicol/table-vertical-align-expected.txt:
+
+
 2017-04-04  Alexey Proskuryakov  
 
 Mark imported/w3c/web-platform-tests/fetch/api/response/response-trailer.html as flaky


Modified: trunk/LayoutTests/platform/gtk/fast/multicol/table-vertical-align-expected.txt (214937 => 214938)

--- trunk/LayoutTests/platform/gtk/fast/multicol/table-vertical-align-expected.txt	2017-04-05 08:24:48 UTC (rev 214937)
+++ trunk/LayoutTests/platform/gtk/fast/multicol/table-vertical-align-expected.txt	2017-04-05 09:13:42 UTC (rev 214938)
@@ -46,94 +46,94 @@
   text run at (11,249) width 105: "This cell has lots"
   text run at (11,266) width 44: "of text."
 RenderBR {BR} at (55,280) size 0x0
-RenderText {#text} at (11,283) size 105x41
+RenderText {#text} at (11,283) size 105x40
   text run at (11,283) width 105: "This cell has lots"
-  text run at (11,307) width 44: "of text."
-RenderBR {BR} at (55,321) size 0x0
-RenderText {#text} at (11,324) size 105x34
-  text run at (11,324) width 105: "This cell has lots"
-  text run at (11,341) width 44: "of text."
-RenderBR {BR} at (55,355) size 0x0
-RenderText {#text} at (11,358) size 105x34
-  text run at (11,358) width 105: "This cell has lots"
-  text run at (11,375) width 44: "of text."
-RenderBR {BR} at (55,389) size 0x0
-RenderText {#text} at (11,392) size 105x34
-  text run at (11,392) width 105: "This cell has lots"
-  text run at (11,409) width 44: "of text."
-RenderBR {BR} at (55,423) size 0x0
-RenderText {#text} at (11,426) size 105x34
-  text run at (11,426) width 105: "This cell has lots"
-  text run at (11,443) width 44: "of text."
-RenderBR {BR} at (55,457) size 0x0
-RenderText {#text} at (11,460) size 105x34
-  text run at (11,460) width 105: "This cell has lots"
-  text run at (11,477) width 44: "of text."
-RenderBR {BR} at (55,491) size 0x0
-RenderText {#text} at (11,494) size 105x34
-  text run at (11,494) width 105: "This cell has lots"
-  text run at (11,511) width 44: "of text."
-RenderBR {BR} at (55,525) size 0x0
-RenderText {#text} at (11,528) size 105x34
-  text run at (11,528) width 105: "This cell has lots"
-  text run at (11,545) width 44: "of text."
-RenderBR {BR} at (55,559) size 0x0
-RenderText {#text} at (11,562) size 105x34
-  text run at (11,562) width 105: "This cell has lots"
-  text run at (11,579) width 44: "of text."
-RenderBR {BR} at (55,593) size 0x0
-RenderText {#text} at (11,596) size 105x34
-  text run at (11,596) width 105: "This cell has lots"
-  text run at (11,613) width 44: "of text."
-RenderBR {BR} at (55,627) size 0x0
-RenderText {#text} at (11,630) size 105x44
-  text run at (11,630) width 105: "This cell has lots"
-  text run at (11,657) width 44: "of text."
-RenderBR {BR} at (55,671) size 0x0
-RenderText {#text} at (11,674) size 105x34
-  text run at (11,674) width 105: "This cell has lots"
-  text run at (11,691) width 44: "of text."
-RenderBR {BR} at (55,705) size 0x0
-RenderText {#text} at (11,708) size 105x34
-  text run at (11,708) width 105: "This cell has lots"
-  text run at (11,725) width 44: "of text."
-RenderBR {BR} at (55,739) size 0x0
-RenderText {#text} at (11,742) size 105x34
-  text run at (11,742) width 105: "This cell has lots"
-  text run at (11,759) width 44: "of text."
-RenderBR {BR} at (55,773) size 0x0
-RenderText {#text} at

[webkit-changes] [214852] trunk

2017-04-03 Thread jfernandez

Title: [214852] trunk








Revision 214852
Author jfernan...@igalia.com
Date 2017-04-03 16:08:42 -0700 (Mon, 03 Apr 2017)


Log Message
[css-align] Adapt place-content alignment shorthand to the new baseline syntax
https://bugs.webkit.org/show_bug.cgi?id=170340

Reviewed by David Hyatt.

Source/WebCore:

Now that the align-content and justify-content CSS properties are
adapted to the new baseline-position CSS values syntax we can adapt the
shorthand that controls such properties to the new syntax as well.

No new tests, just adding some additional cases to the tests we already have.

* css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::placeContentPropertyValue):
* css/StyleProperties.h:
* css/parser/CSSPropertyParser.cpp:
(WebCore::isContentDistributionKeyword):
(WebCore::isContentPositionKeyword):
(WebCore::isOverflowKeyword):
(WebCore::getBaselineKeyword):
(WebCore::consumeContentDistributionOverflowPosition):
(WebCore::consumeSimplifiedContentPosition):

LayoutTests:

Added additional test cases to evaluate the new baseline-alignment syntax.

* css3/parse-place-content-expected.txt:
* css3/parse-place-content.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/parse-place-content-expected.txt
trunk/LayoutTests/css3/parse-place-content.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleProperties.cpp
trunk/Source/WebCore/css/StyleProperties.h
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (214851 => 214852)

--- trunk/LayoutTests/ChangeLog	2017-04-03 23:06:25 UTC (rev 214851)
+++ trunk/LayoutTests/ChangeLog	2017-04-03 23:08:42 UTC (rev 214852)
@@ -1,3 +1,15 @@
+2017-04-03  Javier Fernandez  
+
+[css-align] Adapt place-content alignment shorthand to the new baseline syntax
+https://bugs.webkit.org/show_bug.cgi?id=170340
+
+Reviewed by David Hyatt.
+
+Added additional test cases to evaluate the new baseline-alignment syntax.
+
+* css3/parse-place-content-expected.txt:
+* css3/parse-place-content.html:
+
 2017-04-03  Nan Wang  
 
 AX: Expose link children when doing search predication on iOS


Modified: trunk/LayoutTests/css3/parse-place-content-expected.txt (214851 => 214852)

--- trunk/LayoutTests/css3/parse-place-content-expected.txt	2017-04-03 23:06:25 UTC (rev 214851)
+++ trunk/LayoutTests/css3/parse-place-content-expected.txt	2017-04-03 23:08:42 UTC (rev 214852)
@@ -3,6 +3,8 @@
 
 PASS Test getting the Computed Value of place-content's longhand properties when setting 'normal' value through CSS. 
 PASS Test getting the Computed Value of place-content's longhand properties when setting 'baseline' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'first baseline' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'last baseline' value through CSS. 
 PASS Test getting the Computed Value of place-content's longhand properties when setting 'start' value through CSS. 
 PASS Test getting the Computed Value of place-content's longhand properties when setting 'flex-start' value through CSS. 
 PASS Test getting the Computed Value of place-content's longhand properties when setting 'end' value through CSS. 
@@ -18,7 +20,7 @@
 PASS Test setting 'start safe' as incorrect value through CSS. 
 PASS Test setting 'baseline safe' as incorrect value through CSS. 
 PASS Test setting 'start end left' as incorrect value through CSS. 
-FAIL Test setting values through JS. assert_equals: placeContent specified value is not what it should. expected "center" but got "center center"
+PASS Test setting values through JS. 
 PASS Test setting incorrect values through JS. 
 PASS Test the 'initial' value of the place-content shorthand and its longhand properties' Computed value 
 PASS Test the 'inherit' value of the place-content shorthand and its longhand properties' Computed value 


Modified: trunk/LayoutTests/css3/parse-place-content.html (214851 => 214852)

--- trunk/LayoutTests/css3/parse-place-content.html	2017-04-03 23:06:25 UTC (rev 214851)
+++ trunk/LayoutTests/css3/parse-place-content.html	2017-04-03 23:08:42 UTC (rev 214852)
@@ -8,6 +8,12 @@
 #placeContentBaseline {
 place-content: baseline;
 }
+#placeContentFirstBaseline {
+place-content: first baseline;
+}
+#placeContentLastBaseline {
+place-content: last baseline;
+}
 #placeContentStart {
 place-content: start;
 }
@@ -63,6 +69,8 @@
 
 
 
+
+
 
 
 
@@ -82,20 +90,30 @@

[webkit-changes] [214624] trunk

2017-03-31 Thread jfernandez

Title: [214624] trunk








Revision 214624
Author jfernan...@igalia.com
Date 2017-03-30 14:27:09 -0700 (Thu, 30 Mar 2017)


Log Message
[css-align] Adapt content-alignment properties to the new baseline syntax
https://bugs.webkit.org/show_bug.cgi?id=170262

Reviewed by David Hyatt.

Source/WebCore:

The baseline-position syntax has changed recently, so we need to update
the CSS properties using the old syntax. This patch address only the
content-alignment (align-content and justify-content).

I used this patch to adapt the implementation of the parsing logic for
these properties to the new Blink's CSS Parsing Design.

The new baseline syntax is "[first | last ]? baseline" which implies
modifying the parsing and computed value logic.

There are several layout tests affected by this change, so I'll update
them accordingly.

No new tests, just added/modified some cases to the tests we
already have using the new baseline values.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForContentPositionAndDistributionWithOverflowAlignment):
* css/CSSContentDistributionValue.cpp:
(WebCore::CSSContentDistributionValue::customCSSText):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator ItemPosition):
(WebCore::CSSPrimitiveValue::operator ContentPosition):
* css/CSSValueKeywords.in:
* css/parser/CSSPropertyParser.cpp:
(WebCore::isBaselineKeyword):
(WebCore::consumeBaselineKeyword):
(WebCore::consumeContentDistributionOverflowPosition):
(WebCore::consumeSelfPositionOverflowPosition):

LayoutTests:

Added new cases to the alignment properties parsing tests so that we can verify the new
baseline-alignment syntax is parsed as expected.
Additionally, I modified the tests so that they use the testharness format.

* css3/parse-align-content-expected.txt:
* css3/parse-align-content.html:
* css3/parse-justify-content-expected.txt:
* css3/parse-justify-content.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/parse-align-content-expected.txt
trunk/LayoutTests/css3/parse-align-content.html
trunk/LayoutTests/css3/parse-justify-content-expected.txt
trunk/LayoutTests/css3/parse-justify-content.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSContentDistributionValue.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (214623 => 214624)

--- trunk/LayoutTests/ChangeLog	2017-03-30 21:13:21 UTC (rev 214623)
+++ trunk/LayoutTests/ChangeLog	2017-03-30 21:27:09 UTC (rev 214624)
@@ -1,3 +1,19 @@
+2017-03-30  Javier Fernandez  
+
+[css-align] Adapt content-alignment properties to the new baseline syntax
+https://bugs.webkit.org/show_bug.cgi?id=170262
+
+Reviewed by David Hyatt.
+
+Added new cases to the alignment properties parsing tests so that we can verify the new
+baseline-alignment syntax is parsed as expected.
+Additionally, I modified the tests so that they use the testharness format.
+
+* css3/parse-align-content-expected.txt:
+* css3/parse-align-content.html:
+* css3/parse-justify-content-expected.txt:
+* css3/parse-justify-content.html:
+
 2017-03-30  James Craig  
 
 AX: Expose a new AXSubrole for explicit ARIA "group" role


Modified: trunk/LayoutTests/css3/parse-align-content-expected.txt (214623 => 214624)

--- trunk/LayoutTests/css3/parse-align-content-expected.txt	2017-03-30 21:13:21 UTC (rev 214623)
+++ trunk/LayoutTests/css3/parse-align-content-expected.txt	2017-03-30 21:27:09 UTC (rev 214624)
@@ -1,144 +1,13 @@
 Test that setting and getting align-content works as expected
 
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
+PASS Test getting align-content values previously set through CSS. 
+PASS Test setting invalid values to align-content through CSS. 
+PASS Test initial value of align-content through JS 
+PASS Test getting and setting align-content through JS 
+PASS Test bad combinations of align-content 
+PASS Test the value 'initial' 
+PASS Test the value 'initial' for grid containers 
+PASS Test the value 'initial' for flex containers 
+PASS Test the value 'inherit' 
 
-Test getting align-content set through CSS
-PASS getComputedStyle(alignContentAuto, '').getPropertyValue('align-content') is "normal"
-PASS getComputedStyle(alignContentBaseline, '').getPropertyValue('align-content') is "baseline"
-PASS getComputedStyle(alignContentLastBaseline, '').getPropertyValue('align-content') is "last-baseline"
-PASS getComputedStyle(alignContentSpaceBetween, '').getPropertyValue('align-content') is "space-between"
-PASS getComputedStyle(alignContentSpaceAround, '').getPropertyValue('align-content') is "space-around"
-PASS getComputedStyle(alignContentSpaceEvenly,

[webkit-changes] [213775] trunk/LayoutTests

2017-03-12 Thread jfernandez

Title: [213775] trunk/LayoutTests








Revision 213775
Author jfernan...@igalia.com
Date 2017-03-12 17:16:54 -0700 (Sun, 12 Mar 2017)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=169534

Unreviewed GTK+ gardening.

Rebaseline tests:
LayoutTests/imported/w3c:

   - imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive.html


* web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive-expected.txt:

LayoutTests:

   - http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers.html


* platform/gtk/TestExpectations:
   - fast/text/font-selection-font-face-parse.html [ Skip ]
* platform/gtk/http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive-expected.txt
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (213774 => 213775)

--- trunk/LayoutTests/ChangeLog	2017-03-12 23:52:30 UTC (rev 213774)
+++ trunk/LayoutTests/ChangeLog	2017-03-13 00:16:54 UTC (rev 213775)
@@ -1,3 +1,17 @@
+2017-03-12  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=169534
+
+Unreviewed GTK+ gardening.
+
+Rebaseline tests:
+   - http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers.html
+
+* platform/gtk/TestExpectations:
+   - fast/text/font-selection-font-face-parse.html [ Skip ]
+* platform/gtk/http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers-expected.txt:
+
 2017-03-12  Romain Bellessort  
 
 [Readable Streams API] Implement ReadableStreamBYOBRequest respond() (closed stream state)


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (213774 => 213775)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-03-12 23:52:30 UTC (rev 213774)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-03-13 00:16:54 UTC (rev 213775)
@@ -1,3 +1,15 @@
+2017-03-12  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=169534
+
+Unreviewed GTK+ gardening.
+
+Rebaseline tests:
+   - imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive.html
+
+* web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive-expected.txt:
+
 2017-03-12  Romain Bellessort  
 
 [Readable Streams API] Implement ReadableStreamBYOBRequest respond() (closed stream state)


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive-expected.txt (213774 => 213775)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive-expected.txt	2017-03-12 23:52:30 UTC (rev 213774)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive-expected.txt	2017-03-13 00:16:54 UTC (rev 213775)
@@ -1,3 +1,3 @@
 
-FAIL XMLHttpRequest: getResponseHeader() case-insensitive matching assert_equals: expected "1, 2" but got "1,2"
+PASS XMLHttpRequest: getResponseHeader() case-insensitive matching 
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (213774 => 213775)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-12 23:52:30 UTC (rev 213774)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-13 00:16:54 UTC (rev 213775)
@@ -476,15 +476,18 @@
 webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/rsa_pss.worker.html [ Failure ]
 webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pkcs.html [ Failure ]
 webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pss.html [ Failure ]
-webkit.org/b/169272 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.worker.html [ Failure ]
-webkit.org/b/169272 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_ECDH.worker.html [ Failure ]
-webkit.org/b/169272 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDH.html [ Failure ]
-webkit.org/b/169272 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDH.html [ Failure ]
-webkit.org/b/169468 imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker.html [ Failure ]
-webkit.org/b/169468 imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2.html [ Failure ]
-webkit.org/b/169469 imported/w3c/web-platform-tests/WebCryptoAPI/import_export/ec_importKey.worker.html [ Failure ]
-webkit.org/b/169469

[webkit-changes] [213713] trunk/LayoutTests

2017-03-10 Thread jfernandez

Title: [213713] trunk/LayoutTests








Revision 213713
Author jfernan...@igalia.com
Date 2017-03-10 09:32:07 -0800 (Fri, 10 Mar 2017)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=169470

Unreviewed GTK+ gardening. Updated test expectations after regressions r213671 and r213560.


* platform/gtk/TestExpectations:
   - imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker.html [ Failure ]
   - imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2.html [ Failure ]
   - imported/w3c/web-platform-tests/WebCryptoAPI/import_export/ec_importKey.worker.html [ Failure ]
   - imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_ec_importKey.html [ Failure ]

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (213712 => 213713)

--- trunk/LayoutTests/ChangeLog	2017-03-10 16:01:50 UTC (rev 213712)
+++ trunk/LayoutTests/ChangeLog	2017-03-10 17:32:07 UTC (rev 213713)
@@ -1,3 +1,16 @@
+2017-03-10  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=169470
+
+Unreviewed GTK+ gardening. Updated test expectations after regressions r213671 and r213560.
+
+* platform/gtk/TestExpectations:
+   - imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker.html [ Failure ]
+   - imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2.html [ Failure ]
+   - imported/w3c/web-platform-tests/WebCryptoAPI/import_export/ec_importKey.worker.html [ Failure ]
+   - imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_ec_importKey.html [ Failure ]
+
 2017-03-10  Antti Koivisto  
 
 Loading in-body stylesheets should not block rendering of elements before them


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (213712 => 213713)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-10 16:01:50 UTC (rev 213712)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-10 17:32:07 UTC (rev 213713)
@@ -480,6 +480,10 @@
 webkit.org/b/169272 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_ECDH.worker.html [ Failure ]
 webkit.org/b/169272 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDH.html [ Failure ]
 webkit.org/b/169272 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDH.html [ Failure ]
+webkit.org/b/169468 imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker.html [ Failure ]
+webkit.org/b/169468 imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2.html [ Failure ]
+webkit.org/b/169469 imported/w3c/web-platform-tests/WebCryptoAPI/import_export/ec_importKey.worker.html [ Failure ]
+webkit.org/b/169469 imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_ec_importKey.html [ Failure ]
 
 # GTK does not implement setAutomaticLinkDetectionEnabled
 editing/inserting/typing-space-to-trigger-smart-link.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213365] trunk/LayoutTests

2017-03-03 Thread jfernandez

Title: [213365] trunk/LayoutTests








Revision 213365
Author jfernan...@igalia.com
Date 2017-03-03 06:16:10 -0800 (Fri, 03 Mar 2017)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=169127

Unreviewed GTK+ gardening. Removed duplicated TestExpectations entry.


* platform/gtk/TestExpectations:
- editing/selection/extend-by-character-007.html fails in GTK as well, so using the general TestExpectations entry.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (213364 => 213365)

--- trunk/LayoutTests/ChangeLog	2017-03-03 13:07:45 UTC (rev 213364)
+++ trunk/LayoutTests/ChangeLog	2017-03-03 14:16:10 UTC (rev 213365)
@@ -1,3 +1,13 @@
+2017-03-03  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=169127
+
+Unreviewed GTK+ gardening. Removed duplicated TestExpectations entry.
+
+* platform/gtk/TestExpectations:
+- editing/selection/extend-by-character-007.html fails in GTK as well, so using the general TestExpectations entry.
+
 2017-03-03  Antoine Quint  
 
 LayoutTest media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html is flaky


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (213364 => 213365)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-03 13:07:45 UTC (rev 213364)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-03 14:16:10 UTC (rev 213365)
@@ -2962,8 +2962,6 @@
 
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html [ Pass ]
 
-webkit.org/b/142548 editing/selection/extend-by-character-007.html [ Pass ]
-
 fast/multicol/multicol-with-child-renderLayer-for-input.html [ Pass ]
 
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213280] trunk/LayoutTests

2017-03-02 Thread jfernandez

Title: [213280] trunk/LayoutTests








Revision 213280
Author jfernan...@igalia.com
Date 2017-03-02 07:45:58 -0800 (Thu, 02 Mar 2017)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=169081

Unreviewed GTK+ gardening. Moved some failures to the GTK TestExpectations


* TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (213279 => 213280)

--- trunk/LayoutTests/ChangeLog	2017-03-02 15:07:40 UTC (rev 213279)
+++ trunk/LayoutTests/ChangeLog	2017-03-02 15:45:58 UTC (rev 213280)
@@ -1,3 +1,13 @@
+2017-03-02  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=169081
+
+Unreviewed GTK+ gardening. Moved some failures to the GTK TestExpectations
+
+* TestExpectations:
+* platform/gtk/TestExpectations:
+
 2017-03-02  Tomas Popela  
 
 [WK2] Keyboard menu key should show context menu


Modified: trunk/LayoutTests/TestExpectations (213279 => 213280)

--- trunk/LayoutTests/TestExpectations	2017-03-02 15:07:40 UTC (rev 213279)
+++ trunk/LayoutTests/TestExpectations	2017-03-02 15:45:58 UTC (rev 213280)
@@ -219,8 +219,6 @@
 webkit.org/b/133057 fast/table/border-collapsing/collapsed-borders-adjoining-sections.html [ ImageOnlyFailure ]
 
 webkit.org/b/169075 editing/selection/extend-by-character-007.html [ Failure ]
-webkit.org/b/169075 editing/selection/regional-indicators.html [ Failure ]
-webkit.org/b/169075 editing/deleting/skip-virama-001.html [ Failure ]
 
 # CSS Font Loading is not yet enabled on all platforms
 webkit.org/b/135390 fast/css/fontloader-download-error.html [ Skip ]


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (213279 => 213280)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-02 15:07:40 UTC (rev 213279)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-02 15:45:58 UTC (rev 213280)
@@ -2918,6 +2918,9 @@
 
 webkit.org/b/168719 fast/css/paint-order-shadow.html [ ImageOnlyFailure ]
 
+webkit.org/b/169075 editing/selection/regional-indicators.html [ Failure ]
+webkit.org/b/169075 editing/deleting/skip-virama-001.html [ Failure ]
+
 #
 # End of non-crashing, non-flaky tests failing
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213277] trunk/LayoutTests

2017-03-02 Thread jfernandez

Title: [213277] trunk/LayoutTests








Revision 213277
Author jfernan...@igalia.com
Date 2017-03-02 05:15:42 -0800 (Thu, 02 Mar 2017)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=169076

Unreviewed GTK+ gardening. Some tests fail after r213020:
  - editing/deleting/skip-virama-001.html [ Failure ]
  - editing/selection/extend-by-character-007.html [ Failure ]
  - editing/selection/regional-indicators.html [ Failure ]


* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (213276 => 213277)

--- trunk/LayoutTests/ChangeLog	2017-03-02 11:44:41 UTC (rev 213276)
+++ trunk/LayoutTests/ChangeLog	2017-03-02 13:15:42 UTC (rev 213277)
@@ -1,3 +1,15 @@
+2017-03-02  Javier Fernandez  
+
+[GTK] Unreviewed test gardening 
+https://bugs.webkit.org/show_bug.cgi?id=169076
+
+Unreviewed GTK+ gardening. Some tests fail after r213020:
+  - editing/deleting/skip-virama-001.html [ Failure ]
+  - editing/selection/extend-by-character-007.html [ Failure ]
+  - editing/selection/regional-indicators.html [ Failure ]
+
+* TestExpectations:
+
 2017-03-01  Myles C. Maxfield  
 
 Implement font-stretch for installed fonts


Modified: trunk/LayoutTests/TestExpectations (213276 => 213277)

--- trunk/LayoutTests/TestExpectations	2017-03-02 11:44:41 UTC (rev 213276)
+++ trunk/LayoutTests/TestExpectations	2017-03-02 13:15:42 UTC (rev 213277)
@@ -218,7 +218,9 @@
 
 webkit.org/b/133057 fast/table/border-collapsing/collapsed-borders-adjoining-sections.html [ ImageOnlyFailure ]
 
-webkit.org/b/142548 editing/selection/extend-by-character-007.html [ Failure ]
+webkit.org/b/169075 editing/selection/extend-by-character-007.html [ Failure ]
+webkit.org/b/169075 editing/selection/regional-indicators.html [ Failure ]
+webkit.org/b/169075 editing/deleting/skip-virama-001.html [ Failure ]
 
 # CSS Font Loading is not yet enabled on all platforms
 webkit.org/b/135390 fast/css/fontloader-download-error.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213247] trunk/Source/WebCore

2017-03-01 Thread jfernandez

Title: [213247] trunk/Source/WebCore








Revision 213247
Author jfernan...@igalia.com
Date 2017-03-01 14:45:45 -0800 (Wed, 01 Mar 2017)


Log Message
Missing 'specification' section in the place-content shorthand
https://bugs.webkit.org/show_bug.cgi?id=169052

Reviewed by Darin Adler.

Added 'specification' section in the place-content shorthand.

No new tests, no new functionality.

* css/CSSProperties.json:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSProperties.json




Diff

Modified: trunk/Source/WebCore/ChangeLog (213246 => 213247)

--- trunk/Source/WebCore/ChangeLog	2017-03-01 22:43:04 UTC (rev 213246)
+++ trunk/Source/WebCore/ChangeLog	2017-03-01 22:45:45 UTC (rev 213247)
@@ -1,3 +1,16 @@
+2017-03-01  Javier Fernandez  
+
+Missing 'specification' section in the place-content shorthand
+https://bugs.webkit.org/show_bug.cgi?id=169052
+
+Reviewed by Darin Adler.
+
+Added 'specification' section in the place-content shorthand.
+
+No new tests, no new functionality.
+
+* css/CSSProperties.json:
+
 2017-02-28  Matt Rajca  
 
 Media: notify clients when autoplayed media is muted


Modified: trunk/Source/WebCore/css/CSSProperties.json (213246 => 213247)

--- trunk/Source/WebCore/css/CSSProperties.json	2017-03-01 22:43:04 UTC (rev 213246)
+++ trunk/Source/WebCore/css/CSSProperties.json	2017-03-01 22:45:45 UTC (rev 213247)
@@ -4631,6 +4631,10 @@
 "align-content",
 "justify-content"
 ]
+},
+"specification": {
+"category": "css-align",
+"url": "https://www.w3.org/TR/css-align-3/#propdef-place-content"
 }
 },
 "grid": {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213230] trunk

2017-03-01 Thread jfernandez

Title: [213230] trunk








Revision 213230
Author jfernan...@igalia.com
Date 2017-03-01 10:47:49 -0800 (Wed, 01 Mar 2017)


Log Message
[css-align] Implement the place-content shorthand
https://bugs.webkit.org/show_bug.cgi?id=168771

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-content and justify-content) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests.

Test: css3/parse-place-content.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSProperties.json:
* css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue):
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeSimplifiedContentPosition):
(WebCore::CSSPropertyParser::consumePlaceContentShorthand):
(WebCore::CSSPropertyParser::parseShorthand):
* css/parser/CSSPropertyParser.h:

LayoutTests:

Regression tests for the new place-content alignment shorthand.
Added also a new parsing utility script which uses the testharness functions.

* css3/parse-place-content-expected.txt: Added.
* css3/parse-place-content.html: Added.
* css3/resources/alignment-parsing-utils-th.js: Added.
(checkValues):
(checkBadValues):
(checkInitialValues):
(checkInheritValues):
(checkLegacyValues):
(checkSupportedValues):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/StyleProperties.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParser.h


Added Paths

trunk/LayoutTests/css3/parse-place-content-expected.txt
trunk/LayoutTests/css3/parse-place-content.html
trunk/LayoutTests/css3/resources/alignment-parsing-utils-th.js




Diff

Modified: trunk/LayoutTests/ChangeLog (213229 => 213230)

--- trunk/LayoutTests/ChangeLog	2017-03-01 18:18:04 UTC (rev 213229)
+++ trunk/LayoutTests/ChangeLog	2017-03-01 18:47:49 UTC (rev 213230)
@@ -1,3 +1,23 @@
+2017-03-01  Javier Fernandez  
+
+[css-align] Implement the place-content shorthand
+https://bugs.webkit.org/show_bug.cgi?id=168771
+
+Reviewed by Manuel Rego Casasnovas.
+
+Regression tests for the new place-content alignment shorthand.
+Added also a new parsing utility script which uses the testharness functions.
+
+* css3/parse-place-content-expected.txt: Added.
+* css3/parse-place-content.html: Added.
+* css3/resources/alignment-parsing-utils-th.js: Added.
+(checkValues):
+(checkBadValues):
+(checkInitialValues):
+(checkInheritValues):
+(checkLegacyValues):
+(checkSupportedValues):
+
 2017-03-01  Carlos Garcia Campos  
 
 [GTK] fast/canvas/canvas-createPattern-video-loading.html makes its subsequent test timeout


Added: trunk/LayoutTests/css3/parse-place-content-expected.txt (0 => 213230)

--- trunk/LayoutTests/css3/parse-place-content-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/parse-place-content-expected.txt	2017-03-01 18:47:49 UTC (rev 213230)
@@ -0,0 +1,25 @@
+Test to verify that the new place-content alignment shorthand is parsed as expected and correctly sets the longhand values.
+
+
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'normal' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'baseline' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'start' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'flex-start' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'end' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'space-between' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'stretch' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'start end' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'start space-evenly' value through CSS. 
+PASS Test getting the Computed Value of place-content's longhand properties when setting 'start baseline' value through CSS. 
+PASS Test setting '' as incorrect value through CSS. 
+PASS Test setting 'auto' as incorrect value through CSS. 
+PASS Test setting 'none' as incorrect value through CSS. 
+PASS Test setting 'safe' as incorrect value through CSS. 
+PASS Test setting 'start safe' as incorrect value through CSS. 
+PASS Test setting

[webkit-changes] [213201] trunk/LayoutTests

2017-02-28 Thread jfernandez

Title: [213201] trunk/LayoutTests








Revision 213201
Author jfernan...@igalia.com
Date 2017-02-28 18:19:43 -0800 (Tue, 28 Feb 2017)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=169012

Unreviewed GTK+ gardening. New test results after r213149
  - platform/gtk/fast/replaced/table-percent-height.html PASS
  - tables/mozilla/bugs/bug32205-5.html FAIL


* platform/gtk/TestExpectations:
* platform/gtk/fast/replaced/table-percent-height-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/fast/replaced/table-percent-height-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (213200 => 213201)

--- trunk/LayoutTests/ChangeLog	2017-03-01 01:24:30 UTC (rev 213200)
+++ trunk/LayoutTests/ChangeLog	2017-03-01 02:19:43 UTC (rev 213201)
@@ -1,3 +1,15 @@
+2017-02-28  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=169012
+
+Unreviewed GTK+ gardening. New test results after r213149
+  - platform/gtk/fast/replaced/table-percent-height.html PASS
+  - tables/mozilla/bugs/bug32205-5.html FAIL
+
+* platform/gtk/TestExpectations:
+* platform/gtk/fast/replaced/table-percent-height-expected.txt:
+
 2017-02-28  Antoine Quint  
 
 [mac-wk1 Debug] LayoutTest media/modern-media-controls/rewind-button/rewind-button.html is a flaky timeout


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (213200 => 213201)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-01 01:24:30 UTC (rev 213200)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-01 02:19:43 UTC (rev 213201)
@@ -2296,6 +2296,8 @@
 webkit.org/b/118220 http/tests/cache/partitioned-cache.html [ Failure ]
 webkit.org/b/118220 http/tests/cache/partitioned-cache-iframe.html [ Failure ]
 
+webkit.org/b/169010 tables/mozilla/bugs/bug32205-5.html [ Failure ]
+
 webkit.org/b/118221 fast/text/complex-first-glyph-with-initial-advance.html [ ImageOnlyFailure ]
 
 webkit.org/b/118416 storage/websql/sql-error-codes.html [ Failure ]


Modified: trunk/LayoutTests/platform/gtk/fast/replaced/table-percent-height-expected.txt (213200 => 213201)

--- trunk/LayoutTests/platform/gtk/fast/replaced/table-percent-height-expected.txt	2017-03-01 01:24:30 UTC (rev 213200)
+++ trunk/LayoutTests/platform/gtk/fast/replaced/table-percent-height-expected.txt	2017-03-01 02:19:43 UTC (rev 213201)
@@ -52,32 +52,31 @@
 PASS getHeight('object-100') is '150px'
 PASS getWidth('button-75') is getWidth('button-100')
 PASS getHeight('button-75') != '0px' is true
-FAIL getHeight('button-75') should be 17px. Was 10.5px.
+PASS getHeight('button-75') is getHeight('button-100')
 PASS getWidth('input-button-75') is getWidth('input-button-100')
 PASS getHeight('input-button-75') != '0px' is true
-FAIL getHeight('input-button-75') should be 17px. Was 10.5px.
+PASS getHeight('input-button-75') is getHeight('input-button-100')
 PASS getWidth('input-checkbox-75') is getWidth('input-checkbox-100')
-PASS getHeight('input-checkbox-75') != '0px' is true
+PASS getHeight('input-checkbox-75') != '0px' is false
 PASS getHeight('input-checkbox-75') is 75% of getHeight('input-checkbox-100').
 PASS getWidth('input-file-75') is getWidth('input-file-100')
 PASS getHeight('input-file-75') != '0px' is true
-PASS getHeight('input-file-75') is 75% of getHeight('input-file-100').
 PASS getWidth('input-image-75') is '75px'
 PASS getHeight('input-image-75') is '75px'
 PASS getWidth('input-image-100') is '100px'
 PASS getHeight('input-image-100') is '100px'
 PASS getWidth('input-radio-75') is getWidth('input-radio-100')
-PASS getHeight('input-radio-75') != '0px' is true
+PASS getHeight('input-radio-75') != '0px' is false
 PASS getHeight('input-radio-75') is 75% of getHeight('input-radio-100').
 PASS getWidth('input-reset-75') is getWidth('input-reset-100')
 PASS getHeight('input-reset-75') != '0px' is true
-FAIL getHeight('input-reset-75') should be 17px. Was 10.5px.
+PASS getHeight('input-reset-75') is getHeight('input-reset-100')
 PASS getWidth('input-submit-75') is getWidth('input-submit-100')
 PASS getHeight('input-submit-75') != '0px' is true
-FAIL getHeight('input-submit-75') should be 17px. Was 10.5px.
+PASS getHeight('input-submit-75') is getHeight('input-submit-100')
 PASS getWidth('select-75') is getWidth('select-100')
 PASS getHeight('select-75') != '0px' is true
-FAIL getHeight('select-75') should be 25px. Was 18.25px.
+PASS getHeight('select-75') is getHeight('select-100')
 PASS successfullyParsed is true
 
 TEST COMPLETE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213199] trunk/LayoutTests

2017-02-28 Thread jfernandez

Title: [213199] trunk/LayoutTests








Revision 213199
Author jfernan...@igalia.com
Date 2017-02-28 17:18:18 -0800 (Tue, 28 Feb 2017)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=169005

Rebaseline platform/gtk/css3/flexbox/line-wrapping.html test.
The following tests fail, so updated TextExpectations accordingly:
  - css3/flexbox/flex-item-contains-strict.html
  - css3/flexbox/overflow-auto-resizes-correctly.html


* platform/gtk/css3/flexbox/line-wrapping-expected.txt:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/css3/flexbox/line-wrapping-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (213198 => 213199)

--- trunk/LayoutTests/ChangeLog	2017-03-01 01:17:18 UTC (rev 213198)
+++ trunk/LayoutTests/ChangeLog	2017-03-01 01:18:18 UTC (rev 213199)
@@ -1,3 +1,16 @@
+2017-02-28  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=169005
+
+Rebaseline platform/gtk/css3/flexbox/line-wrapping.html test.
+The following tests fail, so updated TextExpectations accordingly:
+  - css3/flexbox/flex-item-contains-strict.html
+  - css3/flexbox/overflow-auto-resizes-correctly.html
+
+* platform/gtk/css3/flexbox/line-wrapping-expected.txt:
+* platform/gtk/TestExpectations:
+
 2017-02-28  Antoine Quint  
 
 [mac-wk1 debug] LayoutTest media/modern-media-controls/skip-back-button/skip-back-button.html is a flaky timeout


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (213198 => 213199)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-01 01:17:18 UTC (rev 213198)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-01 01:18:18 UTC (rev 213199)
@@ -2290,6 +2290,8 @@
 webkit.org/b/116806 fast/css/text-overflow-ellipsis-behind-floats.html [ ImageOnlyFailure ]
 
 webkit.org/b/117582 fast/flexbox/clear-overflow-before-scroll-update.html [ Failure ]
+webkit.org/b/169007 css3/flexbox/flex-item-contains-strict.html [ Failure ]
+webkit.org/b/169007 css3/flexbox/overflow-auto-resizes-correctly.html [ Failure ]
 
 webkit.org/b/118220 http/tests/cache/partitioned-cache.html [ Failure ]
 webkit.org/b/118220 http/tests/cache/partitioned-cache-iframe.html [ Failure ]


Modified: trunk/LayoutTests/platform/gtk/css3/flexbox/line-wrapping-expected.txt (213198 => 213199)

--- trunk/LayoutTests/platform/gtk/css3/flexbox/line-wrapping-expected.txt	2017-03-01 01:17:18 UTC (rev 213198)
+++ trunk/LayoutTests/platform/gtk/css3/flexbox/line-wrapping-expected.txt	2017-03-01 01:18:18 UTC (rev 213199)
@@ -15,7 +15,7 @@
 
 
 
-
+
 
 
 
@@ -37,7 +37,7 @@
 
 
 
-
+
 
 
 
@@ -51,7 +51,7 @@
 
 
 
-
+
 
 
 
@@ -67,7 +67,7 @@
 
 
 
-
+
 
 
 
@@ -89,7 +89,7 @@
 
 
 
-
+
 
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212934] trunk/LayoutTests

2017-02-23 Thread jfernandez

Title: [212934] trunk/LayoutTests








Revision 212934
Author jfernan...@igalia.com
Date 2017-02-23 19:11:29 -0800 (Thu, 23 Feb 2017)


Log Message
[GTK] Layout test imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-api-texttracks.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=168799

Unreviewed test gardening.


* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (212933 => 212934)

--- trunk/LayoutTests/ChangeLog	2017-02-24 01:44:40 UTC (rev 212933)
+++ trunk/LayoutTests/ChangeLog	2017-02-24 03:11:29 UTC (rev 212934)
@@ -1,3 +1,12 @@
+2017-02-23  Javier Fernandez  
+
+[GTK] Layout test imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-api-texttracks.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=168799
+
+Unreviewed test gardening.
+
+* platform/gtk/TestExpectations:
+
 2017-02-23  Antoine Quint  
 
 [Modern Media Controls] Enforce a minimum layout height of 50pt for 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (212933 => 212934)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-02-24 01:44:40 UTC (rev 212933)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-02-24 03:11:29 UTC (rev 212934)
@@ -1475,6 +1475,7 @@
 webkit.org/b/84777 ietestcenter/css3/multicolumn/column-width-applies-to-015.htm [ Pass ImageOnlyFailure ]
 
 webkit.org/b/160129 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html [ Timeout Pass ]
+webkit.org/b/168799 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-api-texttracks.html [ Failure Pass ]
 
 webkit.org/b/160130 imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-textarea-L.html [ ImageOnlyFailure Pass ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212547] trunk/LayoutTests

2017-02-17 Thread jfernandez

Title: [212547] trunk/LayoutTests








Revision 212547
Author jfernan...@igalia.com
Date 2017-02-17 06:44:44 -0800 (Fri, 17 Feb 2017)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=168473

Unreviewed GTK+ test gardening.

 - rebaseline imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html test.


* web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt


Added Paths

trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/browsers/history/
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt
trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/
trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/browsers/
trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/browsers/history/
trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/
trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (212546 => 212547)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-02-17 14:17:08 UTC (rev 212546)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-02-17 14:44:44 UTC (rev 212547)
@@ -1,3 +1,14 @@
+2017-02-17  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=168473
+
+Unreviewed GTK+ test gardening.
+
+ - rebaseline imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html test.
+
+* web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt:
+
 2017-02-16  Chris Dumez  
 
 .labels is empty if type changes from text->hidden->checkbox


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt (212546 => 212547)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt	2017-02-17 14:17:08 UTC (rev 212546)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt	2017-02-17 14:44:44 UTC (rev 212547)
@@ -1,4 +1,4 @@
 
 PASS location hash 
-FAIL Setting location.hash on srcdoc iframe assert_true: Should have scrolled by more than one viewport height expected true got false
+PASS Setting location.hash on srcdoc iframe 
 


Copied: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt (from rev 212546, trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt) (0 => 212547)

--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt	2017-02-17 14:44:44 UTC (rev 212547)
@@ -0,0 +1,4 @@
+
+PASS location hash 
+FAIL Setting location.hash on srcdoc iframe assert_true: Should have scrolled by more than one viewport height expected true got false
+


Copied: trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt (from rev 212546, trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt) (0 => 212547)

--- trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt	2017-02-17 14:44:44 UTC (rev 212547)
@@ -0,0 +1,4 @@
+
+PASS location hash 
+FAIL Setting location.hash on srcdoc iframe assert_true: Should have scrolled by more than one viewport height expected true got false
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212544] trunk/LayoutTests

2017-02-17 Thread jfernandez

Title: [212544] trunk/LayoutTests








Revision 212544
Author jfernan...@igalia.com
Date 2017-02-17 04:47:28 -0800 (Fri, 17 Feb 2017)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=168504

Unreviewed GTK+ test gardening.

 - imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/async_007.htm test marked as Slow.
 - http/tests/security/bypassing-cors-checks-for-extension-urls.html skipped (bug 168466)
 - rebaseline http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html test (matching Mac expectations - bug 167252)


* platform/gtk/TestExpectations:
* platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (212543 => 212544)

--- trunk/LayoutTests/ChangeLog	2017-02-17 11:00:56 UTC (rev 212543)
+++ trunk/LayoutTests/ChangeLog	2017-02-17 12:47:28 UTC (rev 212544)
@@ -1,3 +1,17 @@
+2017-02-17  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=168504
+
+Unreviewed GTK+ test gardening.
+
+ - imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/async_007.htm test marked as Slow.
+ - http/tests/security/bypassing-cors-checks-for-extension-urls.html skipped (bug 168466)
+ - rebaseline http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html test (matching Mac expectations - bug 167252)
+
+* platform/gtk/TestExpectations:
+* platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt:
+
 2017-02-17  Carlos Garcia Campos  
 
 Unreviewed GTK+ gardening. Update expectations of several tests.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (212543 => 212544)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-02-17 11:00:56 UTC (rev 212543)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-02-17 12:47:28 UTC (rev 212544)
@@ -1572,6 +1572,9 @@
 
 webkit.org/b/159754 workers/bomb.html [ Slow ]
 
+imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/async_007.htm [ Slow ]
+imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/async_010.htm [ Slow ]
+
 #
 # End of slow tests
 #
@@ -1828,6 +1831,9 @@
 # Only Mac has implemented DictionaryLookup
 fast/layers/prevent-hit-test-during-layout.html [ Skip ]
 
+# This is a Mac specific feature
+webkit.org/b/168466 http/tests/security/bypassing-cors-checks-for-extension-urls.html [ Skip ]
+
 #
 # End of tests with architecture-specific results
 #


Modified: trunk/LayoutTests/platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt (212543 => 212544)

--- trunk/LayoutTests/platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt	2017-02-17 11:00:56 UTC (rev 212543)
+++ trunk/LayoutTests/platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt	2017-02-17 12:47:28 UTC (rev 212544)
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS typeof document.onsecuritypolicyviolation is "object"
+FAIL typeof document.onsecuritypolicyviolation should be object. Was undefined.
 PASS typeof SecurityPolicyViolationEvent is "function"
 PASS typeof window.e is "object"
 PASS window.e.documentURI is "documentURIValue"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212440] trunk/LayoutTests

2017-02-16 Thread jfernandez

Title: [212440] trunk/LayoutTests








Revision 212440
Author jfernan...@igalia.com
Date 2017-02-16 09:56:04 -0800 (Thu, 16 Feb 2017)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=168436

Unreviewed GTK+ gardening.

LayoutTests/imported/w3c:

- rebaseline setrequestheader-content-type-expected.txt which still have FAILs as Mac does (bug 161003)


* web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt:

LayoutTests:

- imported/w3c/web-platform-tests/XMLHttpRequest/event-readystatechange-loaded.htm marked as slow
- rebaseline LayoutTests/platform/gtk/js/dom/constructor-length-expected.txt to it matches current Mac expected results.
- the tests http/tests/xmlhttprequest/redirections-and-user-headers.html marked as Failure (bug 168433)


* platform/gtk/TestExpectations:
* platform/gtk/js/dom/constructor-length-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/js/dom/constructor-length-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (212439 => 212440)

--- trunk/LayoutTests/ChangeLog	2017-02-16 17:32:34 UTC (rev 212439)
+++ trunk/LayoutTests/ChangeLog	2017-02-16 17:56:04 UTC (rev 212440)
@@ -1,3 +1,17 @@
+2017-02-16  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=168436
+
+Unreviewed GTK+ gardening.
+
+- imported/w3c/web-platform-tests/XMLHttpRequest/event-readystatechange-loaded.htm marked as slow
+- rebaseline LayoutTests/platform/gtk/js/dom/constructor-length-expected.txt to it matches current Mac expected results.
+- the tests http/tests/xmlhttprequest/redirections-and-user-headers.html marked as Failure (bug 168433)
+
+* platform/gtk/TestExpectations:
+* platform/gtk/js/dom/constructor-length-expected.txt:
+
 2017-02-16  Yusuke Suzuki  
 
 Web Inspector: allow import() inside the inspector


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (212439 => 212440)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-02-16 17:32:34 UTC (rev 212439)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-02-16 17:56:04 UTC (rev 212440)
@@ -1,3 +1,14 @@
+2017-02-16  Javier Fernandez  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=168436
+
+Unreviewed GTK+ gardening.
+
+- rebaseline setrequestheader-content-type-expected.txt which still have FAILs as Mac does (bug 161003)
+
+* web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt:
+
 2017-02-15  Chris Dumez  
 
 Expose Symbol.toPrimitive / valueOf on Location instances


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt (212439 => 212440)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt	2017-02-16 17:32:34 UTC (rev 212439)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt	2017-02-16 17:56:04 UTC (rev 212440)
@@ -28,9 +28,9 @@
 PASS FormData request respects setRequestHeader("") 
 PASS FormData request has correct default Content-Type of "multipart/form-data;boundary=_" 
 PASS FormData request keeps setRequestHeader() Content-Type and charset 
-FAIL URLSearchParams respects setRequestHeader("") assert_unreached: Skipping test as could not create a URLSearchParams;  Reached unreachable code
-FAIL URLSearchParams request has correct default Content-Type of "application/x-www-form-urlencoded;charset=UTF-8" assert_unreached: Skipping test as could not create a URLSearchParams;  Reached unreachable code
-FAIL URLSearchParams request keeps setRequestHeader() Content-Type, with charset adjusted to UTF-8 assert_unreached: Skipping test as could not create a URLSearchParams;  Reached unreachable code
+PASS URLSearchParams respects setRequestHeader("") 
+FAIL URLSearchParams request has correct default Content-Type of "application/x-www-form-urlencoded;charset=UTF-8" assert_equals: expected "content-type: application/x-www-form-urlencoded;charset=utf-8" but got "content-type: text/plain;charset=utf-8"
+PASS URLSearchParams request keeps setRequestHeader() Content-Type, with charset adjusted to UTF-8 
 PASS ReadableStream request respects setRequestHeader("") 
 FAIL ReadableStream request with under type sends no Content-Type without setRequestHeader() call assert_equals: expected "" but got "content-type: text/plain;charset=utf-8"
 FAIL ReadableStream request keeps setRequestHeader() Content-Type and charset assert_equals: expected "content-type: application/xml;charset=ascii"

[webkit-changes] [210792] trunk

2017-01-16 Thread jfernandez

Title: [210792] trunk








Revision 210792
Author jfernan...@igalia.com
Date 2017-01-16 15:15:26 -0800 (Mon, 16 Jan 2017)


Log Message
[css-grid] Implementing baseline positioning for grid containers
https://bugs.webkit.org/show_bug.cgi?id=165063

Reviewed by Darin Adler and Sergio Villar Senin.

Source/WebCore:

Implementation of the 'first-line' baseline for Grid containers,
according to the CSS Grid Layout spec.
https://drafts.csswg.org/css-grid/#grid-baselines

The self-baseline and content-baseline alignment logic is still
not implemented, hence some cases will be implemented in
future patches.

Tests: fast/css-grid-layout/grid-baseline-margins.html
   fast/css-grid-layout/grid-baseline-must-respect-grid-order.html
   fast/css-grid-layout/grid-baseline.html

* rendering/RenderGrid.cpp:
(WebCore::synthesizedBaselineFromBorderBox):
(WebCore::RenderGrid::isInlineBaselineAlignedChild):
(WebCore::RenderGrid::baselinePosition):
(WebCore::RenderGrid::firstLineBaseline):
(WebCore::RenderGrid::inlineBlockBaseline):
* rendering/RenderGrid.h:

LayoutTests:

Tests to verify the baseline positioning of grid and inline-grid blocks.
Note that two of these new tests are expected to fail because of a Flexbox
bug, since we use Flexbox as reference test.

* TestExpectations:
* fast/css-grid-layout/grid-baseline-expected.html: Added.
* fast/css-grid-layout/grid-baseline-margins-expected.html: Added.
* fast/css-grid-layout/grid-baseline-margins.html: Added.
* fast/css-grid-layout/grid-baseline-must-respect-grid-order-expected.txt: Added.
* fast/css-grid-layout/grid-baseline-must-respect-grid-order.html: Added.
* fast/css-grid-layout/grid-baseline.html: Added.
* fast/css-grid-layout/resources/grid-alignment.css:
(.alignSelfBaseline):
(.selfBaseline):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/fast/css-grid-layout/resources/grid-alignment.css
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h


Added Paths

trunk/LayoutTests/fast/css-grid-layout/grid-baseline-expected.html
trunk/LayoutTests/fast/css-grid-layout/grid-baseline-margins-expected.html
trunk/LayoutTests/fast/css-grid-layout/grid-baseline-margins.html
trunk/LayoutTests/fast/css-grid-layout/grid-baseline-must-respect-grid-order-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-baseline-must-respect-grid-order.html
trunk/LayoutTests/fast/css-grid-layout/grid-baseline.html




Diff

Modified: trunk/LayoutTests/ChangeLog (210791 => 210792)

--- trunk/LayoutTests/ChangeLog	2017-01-16 23:04:47 UTC (rev 210791)
+++ trunk/LayoutTests/ChangeLog	2017-01-16 23:15:26 UTC (rev 210792)
@@ -1,3 +1,25 @@
+2017-01-16  Javier Fernandez  
+
+[css-grid] Implementing baseline positioning for grid containers
+https://bugs.webkit.org/show_bug.cgi?id=165063
+
+Reviewed by Darin Adler and Sergio Villar Senin.
+
+Tests to verify the baseline positioning of grid and inline-grid blocks.
+Note that two of these new tests are expected to fail because of a Flexbox
+bug, since we use Flexbox as reference test.
+
+* TestExpectations:
+* fast/css-grid-layout/grid-baseline-expected.html: Added.
+* fast/css-grid-layout/grid-baseline-margins-expected.html: Added.
+* fast/css-grid-layout/grid-baseline-margins.html: Added.
+* fast/css-grid-layout/grid-baseline-must-respect-grid-order-expected.txt: Added.
+* fast/css-grid-layout/grid-baseline-must-respect-grid-order.html: Added.
+* fast/css-grid-layout/grid-baseline.html: Added.
+* fast/css-grid-layout/resources/grid-alignment.css:
+(.alignSelfBaseline):
+(.selfBaseline):
+
 2017-01-15  Sam Weinig  
 
 [WebIDL] Remove custom bindings for HTMLInputElement, HTMLFrameElement, HTMLMediaElement and HTMLOptionsCollection


Modified: trunk/LayoutTests/TestExpectations (210791 => 210792)

--- trunk/LayoutTests/TestExpectations	2017-01-16 23:04:47 UTC (rev 210791)
+++ trunk/LayoutTests/TestExpectations	2017-01-16 23:15:26 UTC (rev 210792)
@@ -262,6 +262,10 @@
 webkit.org/b/136754 css3/flexbox/csswg/ttwf-reftest-flex-wrap-reverse.html [ ImageOnlyFailure ]
 webkit.org/b/136754 css3/flexbox/csswg/ttwf-reftest-flex-wrap.html [ ImageOnlyFailure ]
 
+# grid layout tests
+webkit.org/b/165062 fast/css-grid-layout/grid-baseline.html [ ImageOnlyFailure ]
+webkit.org/b/165062 fast/css-grid-layout/grid-baseline-margins.html [ ImageOnlyFailure ]
+
 # nth-child tests takes long time and Debug build sometimes timeouts because there are many test cases.
 webkit.org/b/137149 fast/selectors/nth-child-of-basics.html [ Slow ]
 


Added: trunk/LayoutTests/fast/css-grid-layout/grid-baseline-expected.html (0 => 210792)

--- trunk/LayoutTests/fast/css-grid-layout/grid-baseline-expected.html	(rev 0)
+++

[webkit-changes] [210669] trunk

2017-01-12 Thread jfernandez

Title: [210669] trunk








Revision 210669
Author jfernan...@igalia.com
Date 2017-01-12 10:41:28 -0800 (Thu, 12 Jan 2017)


Log Message
[css-grid] Make the grid sizing data persistent through layouts
https://bugs.webkit.org/show_bug.cgi?id=166883

Reviewed by Darin Adler and Manuel Rego Casasnovas.

Source/WebCore:

We want to keep the grid sizing data structures through different
layouts. This will allow to optimize some operations, reusing
these data while still valid. Additionally, operations like
determining the baseline position when the grid container is under
an inline formatting context need these data once the grid has
been laid out.

This patch controls the sizing data validity and make the data
structures persistent after layout.

Tests: fast/css-grid-layout/grid-add-item-with-positioned-items.html
   fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html
   fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child.html
   fast/css-grid-layout/grid-item-change-order-auto-flow.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange): Evaluate if the style change made the grid data invalid.
(WebCore::RenderBox::updateGridPositionAfterStyleChange): Evaluate if the style change made the grid data invalid.
* rendering/RenderBox.h:
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::Grid::setNeedsItemsPlacement): The grid must execute the items placement logic before continue processing the layout.
(WebCore::RenderGrid::addChild): Mark the grid data as dirty.
(WebCore::RenderGrid::removeChild): Mark the grid data as dirty.
(WebCore::RenderGrid::styleDidChange): Evaluate grid data validity.
(WebCore::RenderGrid::explicitGridDidResize): Mark the grid data as dirty.
(WebCore::RenderGrid::namedGridLinesDefinitionDidChange): Mark the grid data as dirty.
(WebCore::RenderGrid::layoutBlock): We don't need to clear the grid data anymore.
(WebCore::RenderGrid::dirtyGrid): Clearing the grid data and mark is as needing to execute the items placement logic.
(WebCore::RenderGrid::trackSizesForComputedStyle): Assert we don't need to perform the items placement logic.
(WebCore::RenderGrid::paintChildren): Assert we don't need to perform the items placement logic.
* rendering/RenderGrid.h:
(WebCore::RenderGrid::clear): Deleted.

LayoutTests:

The tests added are now needed to verify we perform correctly the
data validation after certain style changes.

* fast/css-grid-layout/grid-add-item-with-positioned-items-expected.txt: Added.
* fast/css-grid-layout/grid-add-item-with-positioned-items.html: Added.
* fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt: Added.
* fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html: Added.
* fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child-expected.txt: Added.
* fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child.html: Added.
* fast/css-grid-layout/grid-item-change-order-auto-flow-expected.txt: Added.
* fast/css-grid-layout/grid-item-change-order-auto-flow.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h


Added Paths

trunk/LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html
trunk/LayoutTests/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html
trunk/LayoutTests/fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-container-change-explicit-grid-recompute-child.html
trunk/LayoutTests/fast/css-grid-layout/grid-item-change-order-auto-flow-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-item-change-order-auto-flow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (210668 => 210669)

--- trunk/LayoutTests/ChangeLog	2017-01-12 18:34:20 UTC (rev 210668)
+++ trunk/LayoutTests/ChangeLog	2017-01-12 18:41:28 UTC (rev 210669)
@@ -1,3 +1,22 @@
+2017-01-12  Javier Fernandez  
+
+[css-grid] Make the grid sizing data persistent through layouts
+https://bugs.webkit.org/show_bug.cgi?id=166883
+
+Reviewed by Darin Adler and Manuel Rego Casasnovas.
+
+The tests added are now needed to verify we perform correctly the
+data validation after certain style changes.
+
+* fast/css-grid-layout/grid-add-item-with-positioned-items-expected.txt: Added.
+* fast/css-grid-layout/grid-add-item-with-positioned-items.html: Added.
+* fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt: Added.
+*

[webkit-changes] [207663] trunk

2016-10-21 Thread jfernandez

Title: [207663] trunk








Revision 207663
Author jfernan...@igalia.com
Date 2016-10-21 01:11:14 -0700 (Fri, 21 Oct 2016)


Log Message
[css-grid] Content Alignment broken with indefinite sized grid container
https://bugs.webkit.org/show_bug.cgi?id=163724

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

The Grid Tracks sizing algorithm receives as parameter the
available space to be used as space for tracks. We hold a variable
to store the remaining free space for each dimension.

When the grid container size is indefinite we can't compute the
available free space after computing track sizes until such
indefinite size is resolved.

No new tests, just added some additional test cases.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock): Compute freeSpace for Rows
after doing layout and resolving the indefinite height.

LayoutTests:

Added additional test cases to verify we compute properly the
available free space for content-alignment, handling correctly the
overflow when needed.

* fast/css-grid-layout/grid-content-alignment-overflow.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (207662 => 207663)

--- trunk/LayoutTests/ChangeLog	2016-10-21 08:04:43 UTC (rev 207662)
+++ trunk/LayoutTests/ChangeLog	2016-10-21 08:11:14 UTC (rev 207663)
@@ -1,3 +1,16 @@
+2016-10-21  Javier Fernandez  
+
+[css-grid] Content Alignment broken with indefinite sized grid container
+https://bugs.webkit.org/show_bug.cgi?id=163724
+
+Reviewed by Manuel Rego Casasnovas.
+
+Added additional test cases to verify we compute properly the
+available free space for content-alignment, handling correctly the
+overflow when needed.
+
+* fast/css-grid-layout/grid-content-alignment-overflow.html:
+
 2016-10-21  Jer Noble  
 
 [mac-wk2 release] LayoutTest media/media-source/media-source-seek-detach-crash.html is a flaky failure


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow-expected.txt (207662 => 207663)

--- trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow-expected.txt	2016-10-21 08:04:43 UTC (rev 207662)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow-expected.txt	2016-10-21 08:11:14 UTC (rev 207663)
@@ -1,10 +1,59 @@
 This test checks that the 'overflow' keyword is applied correctly for Content Alignment properties.
 
 PASS
+Grid container width of 60px not enough for 2 column tracks of 50px.
+Content-Alignment: center and Overflow-Alignment: default
+
 PASS
+Grid container height of 150px not enough for 2 row tracks of 100px.
+Content-Alignment: center and Overflow-Alignment: unsafe
+
 PASS
+Grid container width of 60px not enough for 2 column tracks of 50px.
+Content-Alignment: center and Overflow-Alignment: safe
+
 PASS
+Grid container height of 150px not enough for 2 row tracks of 100px.
+Content-Alignment: center and Overflow-Alignment: safe
+
 PASS
+Grid container width of 60px not enough for 2 column tracks of 50px.
+Content-Alignment: end and Overflow-Alignment: default
+
 PASS
+Grid container height of 150px not enough for 2 row tracks of 100px.
+Content-Alignment: end and Overflow-Alignment: unsafe
+
 PASS
+Grid container width of 60px not enough for 2 column tracks of 50px.
+Content-Alignment: end and Overflow-Alignment: safe
+
 PASS
+Grid container height of 150px not enough for 2 row tracks of 100px.
+Content-Alignment: end and Overflow-Alignment: safe
+
+PASS
+Grid container indefinite size using fit-content, hence no possible overflow.
+Content-Alignment: end and Overflow-Alignment: unsafe
+
+PASS
+Grid container indefinite size using fit-content, hence no possible overflow.
+Content-Alignment: center and Overflow-Alignment: unsafe
+
+PASS
+Grid container indefinite size using fit-content, but max-size constraints implies that the content-sized tracks overflow.
+Content-Alignment: end and Overflow-Alignment: unsafe
+
+PASS
+Grid container indefinite size using fit-content, but max-size constraints implies that the content-sized tracks overflow.
+Content-Alignment: center and Overflow-Alignment: unsafe
+
+PASS
+Grid container indefinite size using fit-content, but min-size constraints implies that the content-sized tracks don't overflow.
+Content-Alignment: end and Overflow-Alignment: unsafe
+
+PASS
+Grid container indefinite size using fit-content, but min-size constraints implies that the content-sized tracks don't overflow.
+Content-Alignment: center and Overflow-Alignment: unsafe
+
+


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow.html (207662 => 207663)

---

[webkit-changes] [207535] trunk

2016-10-19 Thread jfernandez

Title: [207535] trunk








Revision 207535
Author jfernan...@igalia.com
Date 2016-10-19 06:42:43 -0700 (Wed, 19 Oct 2016)


Log Message
Web Inspector: Debugger buttons positioned incorrectly, align-content default value is unexpected
https://bugs.webkit.org/show_bug.cgi?id=163572

Reviewed by Sergio Villar Senin.

Source/WebCore:

We only allow the new CSS Box Alignment syntax when the Grid Layout
feature is enabled. Due to flexbox backward compatibility we have
implemented a different code path for the style initial/default values
assignment. However, we have incorrectly resolved both align-content
and justify-content to 'flex-start' when grid layout is disabled.

This patch changes the approach, so we set 'normal' (the value specified
by the new syntax) for both properties, but using the values defined in
the old syntax (Flexbox specification) at computed style resolution.

Since 'stretch' is the default value for the align-content property, this
issue implies that any flexbox line with an undefined height will be
laid out incorrectly, if not explicitly set via CSS, because flex items
can't use the available height, even though they use 'stretch' for their
'align-self' properties.

Test: css3/flexbox/flexbox-lines-must-be-stretched-by-default.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForContentPositionAndDistributionWithOverflowAlignment):
(WebCore::ComputedStyleExtractor::propertyValue):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::initialContentAlignment):

LayoutTests:

Modified test cases for initial values.
Added regression test for the align-content issue.

* css3/flexbox/flexbox-lines-must-be-stretched-by-default-expected.txt: Added.
* css3/flexbox/flexbox-lines-must-be-stretched-by-default.html: Added.
* fast/css/ensure-flexbox-compatibility-with-initial-values-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/ensure-flexbox-compatibility-with-initial-values-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h


Added Paths

trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default-expected.txt
trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default.html




Diff

Modified: trunk/LayoutTests/ChangeLog (207534 => 207535)

--- trunk/LayoutTests/ChangeLog	2016-10-19 11:39:34 UTC (rev 207534)
+++ trunk/LayoutTests/ChangeLog	2016-10-19 13:42:43 UTC (rev 207535)
@@ -1,3 +1,17 @@
+2016-10-19  Javier Fernandez  
+
+Web Inspector: Debugger buttons positioned incorrectly, align-content default value is unexpected
+https://bugs.webkit.org/show_bug.cgi?id=163572
+
+Reviewed by Sergio Villar Senin.
+
+Modified test cases for initial values.
+Added regression test for the align-content issue.
+
+* css3/flexbox/flexbox-lines-must-be-stretched-by-default-expected.txt: Added.
+* css3/flexbox/flexbox-lines-must-be-stretched-by-default.html: Added.
+* fast/css/ensure-flexbox-compatibility-with-initial-values-expected.txt:
+
 2016-10-19  Jer Noble  
 
 [Mac][MSE] Movies with a 'mvex' box have a zero-duration


Added: trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default-expected.txt (0 => 207535)

--- trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default-expected.txt	2016-10-19 13:42:43 UTC (rev 207535)
@@ -0,0 +1,7 @@
+'Test for BUG=647694 - align-content "stretch" is not applied by default when grid is disabled.'
+
+PASS
+
+PASS
+
+


Added: trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default.html (0 => 207535)

--- trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default.html	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default.html	2016-10-19 13:42:43 UTC (rev 207535)
@@ -0,0 +1,63 @@
+
+
+.flex-container {
+display: flex;
+height:100px;
+width:200px;
+background-color:pink;
+flex-wrap: wrap;
+}
+.flex-item1 {
+width: 100%;
+background-color:blue;
+border:1px solid;
+border-color:red;
+}
+.flex-item2 {
+width: 100%;
+background-color:blue;
+}
+
+
+'Test for BUG=647694 - align-content "stretch" is not applied by default when grid is disabled.'
+