from:"jhoneycutt"

[webkit-changes] [195171] trunk/Source/WebKit2

2016-01-16 Thread jhoneycutt

Title: [195171] trunk/Source/WebKit2








Revision 195171
Author jhoneyc...@apple.com
Date 2016-01-16 11:03:08 -0800 (Sat, 16 Jan 2016)


Log Message
[iOS] Replace deprecated -[UIDocumentMenuViewController
_setIgnoreApplicationEntitlementForImport:]




Reviewed by Brent Fulgham.

* Platform/spi/ios/UIKitSPI.h:
Replace deprecated SPI with newer SPI.

* UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel presentWithParameters:resultListener:]):
(-[WKFileUploadPanel _showDocumentPickerMenu]):
Ditto.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (195170 => 195171)

--- trunk/Source/WebKit2/ChangeLog	2016-01-16 18:12:41 UTC (rev 195170)
+++ trunk/Source/WebKit2/ChangeLog	2016-01-16 19:03:08 UTC (rev 195171)
@@ -1,3 +1,21 @@
+2016-01-16  Jon Honeycutt  
+
+[iOS] Replace deprecated -[UIDocumentMenuViewController
+_setIgnoreApplicationEntitlementForImport:]
+
+
+
+
+Reviewed by Brent Fulgham.
+
+* Platform/spi/ios/UIKitSPI.h:
+Replace deprecated SPI with newer SPI.
+
+* UIProcess/ios/forms/WKFileUploadPanel.mm:
+(-[WKFileUploadPanel presentWithParameters:resultListener:]):
+(-[WKFileUploadPanel _showDocumentPickerMenu]):
+Ditto.
+
 2016-01-16  Michael Catanzaro  
 
 [GTK] Unreviewed. Fix a typo in an API comment.


Modified: trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h (195170 => 195171)

--- trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h	2016-01-16 18:12:41 UTC (rev 195170)
+++ trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h	2016-01-16 19:03:08 UTC (rev 195171)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2014, 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2014-2016 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -83,7 +83,7 @@
 #import 
 #else
 @interface UIDocumentMenuViewController ()
-@property (nonatomic, assign, setter = _setIgnoreApplicationEntitlementForImport:, getter = _ignoreApplicationEntitlementForImport) BOOL _ignoreApplicationEntitlementForImport;
+- (instancetype)_initIgnoringApplicationEntitlementForImportOfTypes:(NSArray *)types;
 @end
 #endif
 
@@ -763,7 +763,7 @@
 @end
 
 @interface UIDocumentMenuViewController ()
-@property (nonatomic, assign, setter = _setIgnoreApplicationEntitlementForImport:, getter = _ignoreApplicationEntitlementForImport) BOOL _ignoreApplicationEntitlementForImport;
+- (instancetype)_initIgnoringApplicationEntitlementForImportOfTypes:(NSArray *)types;
 @end
 
 @protocol UIDocumentPasswordViewDelegate;


Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm (195170 => 195171)

--- trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm	2016-01-16 18:12:41 UTC (rev 195170)
+++ trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm	2016-01-16 19:03:08 UTC (rev 195171)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2014 Apple Inc. All rights reserved.
+ * Copyright (C) 2014, 2016 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -375,7 +375,7 @@
 _mimeTypes = adoptNS([mimeTypes copy]);
 
 // FIXME: Remove this check and the fallback code when a new SDK is available. 
-if ([UIDocumentMenuViewController instancesRespondToSelector:@selector(_setIgnoreApplicationEntitlementForImport:)]) {
+if ([UIDocumentMenuViewController instancesRespondToSelector:@selector(_initIgnoringApplicationEntitlementForImportOfTypes:)]) {
 [self _showDocumentPickerMenu];
 return;
 }
@@ -515,14 +515,7 @@
 - (void)_showDocumentPickerMenu
 {
 // FIXME: Support multiple file selection when implemented. 
-// FIXME: We call -_setIgnoreApplicationEntitlementForImport: before initialization, because the assertion we're trying
-// to suppress is in the initializer.  tracks doing this with a private initializer.
-_documentMenuController = adoptNS([UIDocumentMenuViewController alloc]);
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
-[_documentMenuController _setIgnoreApplicationEntitlementForImport:YES];
-#pragma clang diagnostic pop
-[_documentMenuController initWithDocumentTypes:[self _documentPickerMenuMediaTypes] inMode:UIDocumentPickerModeImport];
+_documentMenuController = adoptNS([[UIDocumentMenuViewController alloc] _initIgnoringApplicationEntitlementForImportOfTypes:[self _documentPickerMenuMediaTypes]]);
 [_documentMenuController setDelegate:self];
 
 [_documentMenuController addOptionWithTitle:[self _photoLibraryButtonLabel] image:photoLibraryIcon() order:UIDocumentMenuOrderFirst handler:^{






__

[webkit-changes] [192369] trunk

2015-11-12 Thread jhoneycutt

Title: [192369] trunk








Revision 192369
Author jhoneyc...@apple.com
Date 2015-11-12 10:39:08 -0800 (Thu, 12 Nov 2015)


Log Message
popstate event should be dispatched asynchronously
https://bugs.webkit.org/show_bug.cgi?id=36202


Based on an original patch by Mihai Parparita .

Reviewed by Brent Fulgham.

Source/WebCore:

Tests: fast/loader/remove-iframe-during-history-navigation-different.html
   fast/loader/remove-iframe-during-history-navigation-same.html
   fast/loader/stateobjects/popstate-is-asynchronous.html

* dom/Document.cpp:
(WebCore::Document::enqueuePopstateEvent):
Use enqueueWindowEvent().

LayoutTests:

* fast/loader/remove-iframe-during-history-navigation-different-expected.txt: Added.
* fast/loader/remove-iframe-during-history-navigation-different.html: Added.
Imported from Blink.
* fast/loader/remove-iframe-during-history-navigation-same-expected.txt: Added.
* fast/loader/remove-iframe-during-history-navigation-same.html: Added.
Ditto.
* fast/loader/stateobjects/popstate-fires-on-history-traversal.html:
Modified to account for popstate firing asynchronously.
* fast/loader/stateobjects/popstate-is-asynchronous-expected.txt: Added.
* fast/loader/stateobjects/popstate-is-asynchronous.html: Added.
Based on Mihai's original test. Modified to pass in current WebKit.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/loader/stateobjects/popstate-fires-on-history-traversal.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp


Added Paths

trunk/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt
trunk/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html
trunk/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same-expected.txt
trunk/LayoutTests/fast/loader/remove-iframe-during-history-navigation-same.html
trunk/LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous-expected.txt
trunk/LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192368 => 192369)

--- trunk/LayoutTests/ChangeLog	2015-11-12 18:21:34 UTC (rev 192368)
+++ trunk/LayoutTests/ChangeLog	2015-11-12 18:39:08 UTC (rev 192369)
@@ -1,3 +1,25 @@
+2015-11-11  Jon Honeycutt  
+
+popstate event should be dispatched asynchronously
+https://bugs.webkit.org/show_bug.cgi?id=36202
+
+
+Based on an original patch by Mihai Parparita .
+
+Reviewed by Brent Fulgham.
+
+* fast/loader/remove-iframe-during-history-navigation-different-expected.txt: Added.
+* fast/loader/remove-iframe-during-history-navigation-different.html: Added.
+Imported from Blink.
+* fast/loader/remove-iframe-during-history-navigation-same-expected.txt: Added.
+* fast/loader/remove-iframe-during-history-navigation-same.html: Added.
+Ditto.
+* fast/loader/stateobjects/popstate-fires-on-history-traversal.html:
+Modified to account for popstate firing asynchronously.
+* fast/loader/stateobjects/popstate-is-asynchronous-expected.txt: Added.
+* fast/loader/stateobjects/popstate-is-asynchronous.html: Added.
+Based on Mihai's original test. Modified to pass in current WebKit.
+
 2015-11-12  Eric Carlson  
 
 [MediaStream] Reflect media stream tracks as HTMLMediaElement tracks


Added: trunk/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt (0 => 192369)

--- trunk/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different-expected.txt	2015-11-12 18:39:08 UTC (rev 192369)
@@ -0,0 +1 @@
+TEST PASSED


Added: trunk/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html (0 => 192369)

--- trunk/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html	(rev 0)
+++ trunk/LayoutTests/fast/loader/remove-iframe-during-history-navigation-different.html	2015-11-12 18:39:08 UTC (rev 192369)
@@ -0,0 +1,31 @@
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+// One iframe's popstate handler removes another iframe from the
+// document during a history navigation that affects both frames. The
+// history navigation loads a different document in the other frame.
+window._onload_ = function () {
+frames[0].history.pushState("first", "first");
+frames[0]._onpopstate_ = function () {
+document.body.innerHTML = "TEST PASSED";
+if (window.testRunner)
+testRunner.notifyDone();
+};
+document.querySelectorAll("iframe")[1]._onload_ = function () {
+setTimeout("history.go(-2);", 10);
+};
+setTimeout(function () {
+frames[1].location.href = ""
+

[webkit-changes] [192317] trunk/LayoutTests

2015-11-11 Thread jhoneycutt

Title: [192317] trunk/LayoutTests








Revision 192317
Author jhoneyc...@apple.com
Date 2015-11-11 11:02:53 -0800 (Wed, 11 Nov 2015)


Log Message
Fix a typo.

Rubber-stamped by Dan Bernstein.

* fast/parser/strip-script-attrs-on-input-expected.txt:
* fast/parser/strip-script-attrs-on-input.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/parser/strip-script-attrs-on-input-expected.txt
trunk/LayoutTests/fast/parser/strip-script-attrs-on-input.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192316 => 192317)

--- trunk/LayoutTests/ChangeLog	2015-11-11 18:48:33 UTC (rev 192316)
+++ trunk/LayoutTests/ChangeLog	2015-11-11 19:02:53 UTC (rev 192317)
@@ -1,3 +1,12 @@
+2015-11-11  Jon Honeycutt  
+
+Fix a typo.
+
+Rubber-stamped by Dan Bernstein.
+
+* fast/parser/strip-script-attrs-on-input-expected.txt:
+* fast/parser/strip-script-attrs-on-input.html:
+
 2015-11-10  Jon Honeycutt  
 
 Crash loading Blink layout test fast/parser/strip-script-attrs-on-input.html


Modified: trunk/LayoutTests/fast/parser/strip-script-attrs-on-input-expected.txt (192316 => 192317)

--- trunk/LayoutTests/fast/parser/strip-script-attrs-on-input-expected.txt	2015-11-11 18:48:33 UTC (rev 192316)
+++ trunk/LayoutTests/fast/parser/strip-script-attrs-on-input-expected.txt	2015-11-11 19:02:53 UTC (rev 192317)
@@ -1 +1 @@
-Text for WebKit bug #150201. Test passes if it does not crash in an ASan build.
+Test for WebKit bug #150201. Test passes if it does not crash in an ASan build.


Modified: trunk/LayoutTests/fast/parser/strip-script-attrs-on-input.html (192316 => 192317)

--- trunk/LayoutTests/fast/parser/strip-script-attrs-on-input.html	2015-11-11 18:48:33 UTC (rev 192316)
+++ trunk/LayoutTests/fast/parser/strip-script-attrs-on-input.html	2015-11-11 19:02:53 UTC (rev 192317)
@@ -24,7 +24,7 @@
 });
 
 
-Text for WebKit bug #+Test for WebKit bug # Test passes if it does not crash in an ASan build.
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192316] trunk

2015-11-11 Thread jhoneycutt

Title: [192316] trunk








Revision 192316
Author jhoneyc...@apple.com
Date 2015-11-11 10:48:33 -0800 (Wed, 11 Nov 2015)


Log Message
Crash loading Blink layout test fast/parser/strip-script-attrs-on-input.html
https://bugs.webkit.org/show_bug.cgi?id=150201


Reviewed by Brent Fulgham.

Source/WebCore:

Test: fast/parser/strip-script-attrs-on-input.html

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
Get the attribute after calling
HTMLConstructionSite::insertSelfClosingHTMLElement(), as this may
mutate the token's attributes.

LayoutTests:

* fast/parser/strip-script-attrs-on-input-expected.txt: Added.
* fast/parser/strip-script-attrs-on-input.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp


Added Paths

trunk/LayoutTests/fast/parser/strip-script-attrs-on-input-expected.txt
trunk/LayoutTests/fast/parser/strip-script-attrs-on-input.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192315 => 192316)

--- trunk/LayoutTests/ChangeLog	2015-11-11 18:20:43 UTC (rev 192315)
+++ trunk/LayoutTests/ChangeLog	2015-11-11 18:48:33 UTC (rev 192316)
@@ -1,3 +1,14 @@
+2015-11-10  Jon Honeycutt  
+
+Crash loading Blink layout test fast/parser/strip-script-attrs-on-input.html
+https://bugs.webkit.org/show_bug.cgi?id=150201
+
+
+Reviewed by Brent Fulgham.
+
+* fast/parser/strip-script-attrs-on-input-expected.txt: Added.
+* fast/parser/strip-script-attrs-on-input.html: Added.
+
 2015-11-10  Wenson Hsieh  
 
 UI-side scripts in WebKitTestRunner should wait until event handling completes before finishing


Added: trunk/LayoutTests/fast/parser/strip-script-attrs-on-input-expected.txt (0 => 192316)

--- trunk/LayoutTests/fast/parser/strip-script-attrs-on-input-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/parser/strip-script-attrs-on-input-expected.txt	2015-11-11 18:48:33 UTC (rev 192316)
@@ -0,0 +1 @@
+Text for WebKit bug #150201. Test passes if it does not crash in an ASan build.


Added: trunk/LayoutTests/fast/parser/strip-script-attrs-on-input.html (0 => 192316)

--- trunk/LayoutTests/fast/parser/strip-script-attrs-on-input.html	(rev 0)
+++ trunk/LayoutTests/fast/parser/strip-script-attrs-on-input.html	2015-11-11 18:48:33 UTC (rev 192316)
@@ -0,0 +1,30 @@
+
+
+
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+requestAnimationFrame(function() {
+var target = document.getElementById("target");
+var selection = window.getSelection();
+var range = document.createRange();
+range.selectNodeContents(target);
+selection.addRange(range);
+
+document.execCommand("Cut");
+document.execCommand("Paste");
+
+target.innerHTML = '';
+testRunner.notifyDone();
+});
+
+
+Text for WebKit bug #
+


Modified: trunk/Source/WebCore/ChangeLog (192315 => 192316)

--- trunk/Source/WebCore/ChangeLog	2015-11-11 18:20:43 UTC (rev 192315)
+++ trunk/Source/WebCore/ChangeLog	2015-11-11 18:48:33 UTC (rev 192316)
@@ -1,3 +1,19 @@
+2015-11-10  Jon Honeycutt  
+
+Crash loading Blink layout test fast/parser/strip-script-attrs-on-input.html
+https://bugs.webkit.org/show_bug.cgi?id=150201
+
+
+Reviewed by Brent Fulgham.
+
+Test: fast/parser/strip-script-attrs-on-input.html
+
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::processStartTagForInBody):
+Get the attribute after calling
+HTMLConstructionSite::insertSelfClosingHTMLElement(), as this may
+mutate the token's attributes.
+
 2015-11-11  Xabier Rodriguez Calvar  
 
 [Streams API] Remove bind usage


Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (192315 => 192316)

--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2015-11-11 18:20:43 UTC (rev 192315)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2015-11-11 18:48:33 UTC (rev 192316)
@@ -774,9 +774,9 @@
 return;
 }
 if (token.name() == inputTag) {
-Attribute* typeAttribute = findAttribute(token.attributes(), typeAttr);
 m_tree.reconstructTheActiveFormattingElements();
 m_tree.insertSelfClosingHTMLElement(&token);
+Attribute* typeAttribute = findAttribute(token.attributes(), typeAttr);
 if (!typeAttribute || !equalIgnoringCase(typeAttribute->value(), "hidden"))
 m_framesetOk = false;
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191981] trunk

2015-11-03 Thread jhoneycutt

Title: [191981] trunk








Revision 191981
Author jhoneyc...@apple.com
Date 2015-11-03 14:51:52 -0800 (Tue, 03 Nov 2015)


Log Message
Implement support for the autocomplete attribute
https://bugs.webkit.org/show_bug.cgi?id=150731
rdar://problem/21078968

LayoutTests/imported/w3c:

Reviewed by Brent Fulgham.

* web-platform-tests/html/dom/interfaces-expected.txt: Rebased.
* web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt:
Rebased.

Source/WebCore:

The autocomplete attribute is defined by
https://html.spec.whatwg.org/multipage/forms.html#autofill.

Reviewed by Brent Fulgham.

Test: fast/forms/autocomplete-tokens.html

* html/HTMLFormControlElement.cpp:
(WebCore::isContactToken):
Return true if this is a contact token.
(WebCore::categoryForAutofillFieldToken):
Adds all of the autofill field tokens to a map, and returns the
category for a given token.
(WebCore::maxTokensForAutofillFieldCategory):
Return the maximum number of tokens an autofill category supports.
(WebCore::HTMLFormControlElement::parseAutocompleteAttribute):
Implement the processing model defined in
https://html.spec.whatwg.org/multipage/forms.html#processing-model-3
with respect to the IDL-exposed autofill value.
(WebCore::HTMLFormControlElement::setAutocomplete):
Set the autocomplete attribute to the given string.

* html/HTMLFormControlElement.h:
Declare setAutocomplete() and autocomplete().

* html/HTMLInputElement.idl:
Remove the Reflect attribute. We now have custom processing for getting
this attribute.

* html/HTMLSelectElement.idl:
Declare the autocomplete attribute.

* html/HTMLTextAreaElement.idl:
Ditto.

LayoutTests:

Reviewed by Brent Fulgham.

* fast/forms/autocomplete-tokens-expected.txt: Added.
* fast/forms/autocomplete-tokens.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormControlElement.cpp
trunk/Source/WebCore/html/HTMLFormControlElement.h
trunk/Source/WebCore/html/HTMLInputElement.idl
trunk/Source/WebCore/html/HTMLSelectElement.idl
trunk/Source/WebCore/html/HTMLTextAreaElement.idl


Added Paths

trunk/LayoutTests/fast/forms/autocomplete-tokens-expected.txt
trunk/LayoutTests/fast/forms/autocomplete-tokens.html




Diff

Modified: trunk/LayoutTests/ChangeLog (191980 => 191981)

--- trunk/LayoutTests/ChangeLog	2015-11-03 22:24:14 UTC (rev 191980)
+++ trunk/LayoutTests/ChangeLog	2015-11-03 22:51:52 UTC (rev 191981)
@@ -1,3 +1,14 @@
+2015-10-30  Jon Honeycutt  
+
+Implement support for the autocomplete attribute
+https://bugs.webkit.org/show_bug.cgi?id=150731
+rdar://problem/21078968
+
+Reviewed by Brent Fulgham.
+
+* fast/forms/autocomplete-tokens-expected.txt: Added.
+* fast/forms/autocomplete-tokens.html: Added.
+
 2015-11-03  Nan Wang  
 
 AX: Add support for ARIA 1.1 attribute 'aria-modal' for dialog and alertdialog


Added: trunk/LayoutTests/fast/forms/autocomplete-tokens-expected.txt (0 => 191981)

--- trunk/LayoutTests/fast/forms/autocomplete-tokens-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/autocomplete-tokens-expected.txt	2015-11-03 22:51:52 UTC (rev 191981)
@@ -0,0 +1,211 @@
+Tests for valid autocomplete tokens on input, select, and textarea elements.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Valid keywords:
+PASS input.autocomplete is "name"
+PASS input.autocomplete is "honorific-prefix"
+PASS input.autocomplete is "given-name"
+PASS input.autocomplete is "additional-name"
+PASS input.autocomplete is "family-name"
+PASS input.autocomplete is "honorific-suffix"
+PASS input.autocomplete is "nickname"
+PASS input.autocomplete is "organization-title"
+PASS input.autocomplete is "username"
+PASS input.autocomplete is "new-password"
+PASS input.autocomplete is "current-password"
+PASS input.autocomplete is "organization"
+PASS input.autocomplete is "street-address"
+PASS input.autocomplete is "address-line1"
+PASS input.autocomplete is "address-line2"
+PASS input.autocomplete is "address-line3"
+PASS input.autocomplete is "address-level4"
+PASS input.autocomplete is "address-level3"
+PASS input.autocomplete is "address-level2"
+PASS input.autocomplete is "address-level1"
+PASS input.autocomplete is "country"
+PASS input.autocomplete is "country-name"
+PASS input.autocomplete is "postal-code"
+PASS input.autocomplete is "cc-name"
+PASS input.autocomplete is "cc-given-name"
+PASS input.autocomplete is "cc-additional-name"
+PASS input.autocomplete is "cc-family-name"
+PASS input.autocomplete is "cc-number"
+PASS input.autocomplete is "cc-exp"
+PASS input.autocomplete is "cc-exp-month"
+PASS input.autocomplete is "cc-exp-year"
+PASS i

[webkit-changes] [190892] trunk/LayoutTests

2015-10-12 Thread jhoneycutt

Title: [190892] trunk/LayoutTests








Revision 190892
Author jhoneyc...@apple.com
Date 2015-10-12 15:15:49 -0700 (Mon, 12 Oct 2015)


Log Message
Unreviewed, more Mac test gardening after r190629.

* platform/mac-wk1/TestExpectations:
Add a new expected time out. Group expected time outs for imported
Blink tests using requestAnimationFrame.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190891 => 190892)

--- trunk/LayoutTests/ChangeLog	2015-10-12 22:08:27 UTC (rev 190891)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 22:15:49 UTC (rev 190892)
@@ -1,3 +1,11 @@
+2015-10-12  Jon Honeycutt  
+
+Unreviewed, more Mac test gardening after r190629.
+
+* platform/mac-wk1/TestExpectations:
+Add a new expected time out. Group expected time outs for imported
+Blink tests using requestAnimationFrame.
+
 2015-10-12  Myles C. Maxfield  
 
 REGRESSION(r182192): Ligatures do not interact correctly with SHY in some fonts


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (190891 => 190892)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-10-12 22:08:27 UTC (rev 190891)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-10-12 22:15:49 UTC (rev 190892)
@@ -147,18 +147,20 @@
 fast/text/international/system-language [ Pass Failure ImageOnlyFailure ]
 
 # Imported Blink tests which have not been investigated.
+imported/blink/fast/canvas/bug382588.html [ Pass Timeout ImageOnlyFailure ]
+[ Debug ] imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ Pass ImageOnlyFailure ]
+
+# Blink tests that time out waiting on requestAnimationFrame callbacks. http://webkit.org/b/150050
 imported/blink/animations/background-shorthand-crash.html [ Pass Timeout ]
 imported/blink/compositing/squashing/invalidate-on-grouped-mapping-reorder.html [ Pass Timeout ]
 imported/blink/css3/calc/transition-asan-crash.html [ Pass Timeout ]
-imported/blink/fast/canvas/bug382588.html [ Pass Timeout ImageOnlyFailure ]
+imported/blink/fast/images/image-hover-display-alt.html [ Pass Timeout ]
 imported/blink/fast/inline/reparent-inline-box.html [ Pass Timeout ]
 imported/blink/fast/text-autosizing/print-autosizing.html  [ Pass Timeout ]
 imported/blink/paint/theme/search-field-resuts-decoration-crash.html [ Pass Timeout ]
 imported/blink/svg/filters/feColorMatrix-setAttribute-crash1.html [ Pass Timeout ]
 imported/blink/svg/hittest/rect-miterlimit.html [ Pass Timeout ]
-
 [ Release ] imported/blink/compositing/reorder-z-with-style.html [ Pass Timeout ]
 [ Release ] imported/blink/svg/custom/marker-layout-invalidation.html [ Pass Timeout ]
 [ Release ] imported/blink/fast/css/crash-corner-present.html [ Pass Timeout ]
 [ Release ] imported/blink/compositing/layer-creation/iframe-clip-removed.html [ Pass Timeout ]
-[ Debug ] imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190659] trunk/LayoutTests

2015-10-06 Thread jhoneycutt

Title: [190659] trunk/LayoutTests








Revision 190659
Author jhoneyc...@apple.com
Date 2015-10-06 20:35:26 -0700 (Tue, 06 Oct 2015)


Log Message
Unreviewed iOS test gardening after r190629.

* platform/ios-simulator/TestExpectations:
* platform/ios-simulator-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190658 => 190659)

--- trunk/LayoutTests/ChangeLog	2015-10-07 02:51:29 UTC (rev 190658)
+++ trunk/LayoutTests/ChangeLog	2015-10-07 03:35:26 UTC (rev 190659)
@@ -1,3 +1,10 @@
+2015-10-06  Jon Honeycutt  
+
+Unreviewed iOS test gardening after r190629.
+
+* platform/ios-simulator/TestExpectations:
+* platform/ios-simulator-wk1/TestExpectations:
+
 2015-10-06  Zalan Bujtas  
 
 Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (190658 => 190659)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2015-10-07 02:51:29 UTC (rev 190658)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2015-10-07 03:35:26 UTC (rev 190659)
@@ -2798,45 +2798,60 @@
 streams/reference-implementation/readable-stream-cancel.html [ Failure Pass ]
 compositing/visible-rect/coverage-scrolling.html [ Failure Pass ]
 
-# Imported Blink tests. (Oct 1, 2015)
-imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure ]
-imported/blink/compositing/draws-content/canvas-simple-background.html [ ImageOnlyFailure ]
-imported/blink/compositing/draws-content/webgl-simple-background.html [ ImageOnlyFailure ]
+# Imported Blink tests.
+imported/blink/animations/background-shorthand-crash.html [ Pass Timeout ]
+imported/blink/animations/base-render-style-font-selector-version-assert.html [ Pass Timeout ]
+imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure Pass ]
+imported/blink/compositing/draws-content/canvas-simple-background.html [ ImageOnlyFailure Pass ]
+imported/blink/compositing/draws-content/webgl-simple-background.html [ ImageOnlyFailure Pass ]
+imported/blink/compositing/layer-creation/iframe-clip-removed.html [ Pass Timeout ]
 imported/blink/compositing/overflow/body-switch-composited-scrolling.html [ ImageOnlyFailure Pass ]
-imported/blink/fast/css-grid-layout/grid-item-margins-and-writing-modes.html [ ImageOnlyFailure ]
-imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes.html [ ImageOnlyFailure ]
+imported/blink/compositing/reorder-z-with-style.html [ Timeout ]
+imported/blink/compositing/squashing/invalidate-on-grouped-mapping-reorder.html [ Pass Timeout ]
+imported/blink/css3/calc/transition-asan-crash.html [ Pass Timeout ]
+imported/blink/editing/execCommand/4128080-2.html [ Failure Pass ]
+imported/blink/fast/canvas/bug382588.html [ Pass Timeout ]
+imported/blink/fast/css-grid-layout/grid-item-margins-and-writing-modes.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes.html [ ImageOnlyFailure Pass ]
 imported/blink/fast/css/border-current-color.html [ ImageOnlyFailure Pass ]
-imported/blink/fast/css/text-overflow-ellipsis-button.html [ ImageOnlyFailure ]
-imported/blink/fast/css/transformed-overflow-hidden-clips-fixed.html [ ImageOnlyFailure ]
-imported/blink/fast/forms/select/listbox-line-height.html [ ImageOnlyFailure ]
-imported/blink/fast/forms/select/select-text-transform.html [ ImageOnlyFailure ]
+imported/blink/fast/css/crash-corner-present.html [ Skip ]
+imported/blink/fast/css/text-overflow-ellipsis-button.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/css/transformed-overflow-hidden-clips-fixed.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/events/popup-forwarded-gesture.html [ Skip ]
+imported/blink/fast/forms/select/listbox-line-height.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/forms/select/select-text-transform.html [ ImageOnlyFailure Pass ]
 imported/blink/fast/images/image-hover-display-alt.html [ ImageOnlyFailure Pass ]
-imported/blink/fast/multicol/client-rects-rtl.html [ ImageOnlyFailure ]
-imported/blink/fast/multicol/composited-layer-single-fragment.html [ ImageOnlyFailure ]
-imported/blink/fast/multicol/composited-relpos-2nd-column.html [ ImageOnlyFailure ]
-imported/blink/fast/multicol/dynamic/remove-spanner-in-content.html [ ImageOnlyFailure ]
+imported/blink/fast/images/image-hover-display-alt.html [ Pass Timeout ]
+imported/blink/fast/inline/reparent-inline-box.html [ Pass Timeout ]
+imported/blink/fast/multicol/client-rects-rtl.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/multicol/composited-layer-single-fragment.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/multicol/composited-relpos-2nd-column.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/multicol/dynamic/remove-spanner-in-content.html [ ImageOnlyFailure Pass ]
 imported

[webkit-changes] [190657] trunk/LayoutTests

2015-10-06 Thread jhoneycutt

Title: [190657] trunk/LayoutTests








Revision 190657
Author jhoneyc...@apple.com
Date 2015-10-06 19:11:09 -0700 (Tue, 06 Oct 2015)


Log Message
More unreviewed Windows test gardening after r190629.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190656 => 190657)

--- trunk/LayoutTests/ChangeLog	2015-10-07 02:07:19 UTC (rev 190656)
+++ trunk/LayoutTests/ChangeLog	2015-10-07 02:11:09 UTC (rev 190657)
@@ -1,5 +1,11 @@
 2015-10-06  Jon Honeycutt  
 
+More unreviewed Windows test gardening after r190629.
+
+* platform/win/TestExpectations:
+
+2015-10-06  Jon Honeycutt  
+
 Unreviewed Windows test gardening after r190629.
 
 * platform/win/TestExpectations:


Modified: trunk/LayoutTests/platform/win/TestExpectations (190656 => 190657)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-10-07 02:07:19 UTC (rev 190656)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-10-07 02:11:09 UTC (rev 190657)
@@ -3282,3 +3282,6 @@
 imported/blink/svg/custom/focus-ring-2.svg [ ImageOnlyFailure ]
 imported/blink/svg/custom/focus-ring-text.svg [ ImageOnlyFailure ]
 imported/blink/webexposed/webkit-focus-ring-exposed-to-quirks-mode.html [ ImageOnlyFailure ]
+imported/blink/fast/block/float/float-mark-descendants-for-layout-crash.html [ Failure ]
+imported/blink/http/tests/security/script-crossorigin-loads-correctly-credentials.html [ Failure ]
+imported/blink/printing/print-document-without-documentElement-crash.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190656] trunk/LayoutTests

2015-10-06 Thread jhoneycutt

Title: [190656] trunk/LayoutTests








Revision 190656
Author jhoneyc...@apple.com
Date 2015-10-06 19:07:19 -0700 (Tue, 06 Oct 2015)


Log Message
Unreviewed Windows test gardening after r190629.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190655 => 190656)

--- trunk/LayoutTests/ChangeLog	2015-10-07 01:24:54 UTC (rev 190655)
+++ trunk/LayoutTests/ChangeLog	2015-10-07 02:07:19 UTC (rev 190656)
@@ -1,5 +1,11 @@
 2015-10-06  Jon Honeycutt  
 
+Unreviewed Windows test gardening after r190629.
+
+* platform/win/TestExpectations:
+
+2015-10-06  Jon Honeycutt  
+
 Unreviewed Mac test gardening after r190629.
 
 * platform/mac-wk1/TestExpectations:


Modified: trunk/LayoutTests/platform/win/TestExpectations (190655 => 190656)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-10-07 01:24:54 UTC (rev 190655)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-10-07 02:07:19 UTC (rev 190656)
@@ -3246,3 +3246,39 @@
 webkit.org/b/148886 http/tests/navigation/ping-attribute/anchor-same-origin.html [ Pass Failure ]
 webkit.org/b/148887 http/tests/navigation/success200-reload.html [ Pass Failure ]
 webkit.org/b/14 http/tests/navigation/slowmetaredirect-basic.html [ Pass Failure ]
+
+# Imported Blink tests.
+imported/blink/compositing/iframes/ancestor-clipping-layer.html [ Skip ]
+imported/blink/compositing/perspective-origin-overflow-hidden.html [ Skip ]
+imported/blink/editing/execCommand/indent-button-crash.html [ Skip ]
+imported/blink/http/tests/plugins/get-url-notify-on-removal.html [ Skip ]
+imported/blink/plugins/empty-per-context-data.html [ Skip ]
+imported/blink/animations/animation-iteration-event-short-iterations.html [ Failure Pass ]
+imported/blink/fast/dom/ruby-numeric-overflow.html [ Failure Pass ]
+imported/blink/fast/masking/mask-serializing.html [ Failure Pass ]
+imported/blink/compositing/ancestor-painted-layer-should-appear.html [ ImageOnlyFailure ]
+imported/blink/compositing/child-transform-layer-with-foreground-layer.html [ ImageOnlyFailure ]
+imported/blink/compositing/draws-content/webgl-simple-background.html [ ImageOnlyFailure ]
+imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ ImageOnlyFailure ]
+imported/blink/compositing/will-change/stacking-context-creation.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/mix-blend-mode-background-size.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/mix-blend-mode-has-ancestor-clipping-layer.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/mix-blend-mode-multiply.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/mix-blend-mode-with-opacity-change-js.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/mix-blend-mode-with-squashing-layer.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/svg-blend-overlapping-elements.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/svg-isolation-foreign-no-isolation.html [ ImageOnlyFailure ]
+imported/blink/css3/blending/svg-isolation-nested-svg-no-isolation.html [ ImageOnlyFailure ]
+imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html [ ImageOnlyFailure ]
+imported/blink/css3/filters/effect-reference-on-transparent-element.html [ ImageOnlyFailure ]
+imported/blink/editing/selection/deleteFromDocument-crash.html [ ImageOnlyFailure ]
+imported/blink/fast/css/tab-size-complex-path.html [ ImageOnlyFailure ]
+imported/blink/fast/css/text-decoration-propagate.html [ ImageOnlyFailure ]
+imported/blink/fast/text/emoji-font-fallback-win.html [ ImageOnlyFailure ]
+imported/blink/fast/text/international/text-shaping-arabic.html [ ImageOnlyFailure ]
+imported/blink/imported/csswg-test/css-writing-modes-3/text-combine-upright-line-breaking-rules-001.html [ ImageOnlyFailure ]
+imported/blink/svg/as-image/default-font-size.html [ ImageOnlyFailure ]
+imported/blink/svg/as-image/default-sans-serif-font.html [ ImageOnlyFailure ]
+imported/blink/svg/custom/focus-ring-2.svg [ ImageOnlyFailure ]
+imported/blink/svg/custom/focus-ring-text.svg [ ImageOnlyFailure ]
+imported/blink/webexposed/webkit-focus-ring-exposed-to-quirks-mode.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190654] trunk/LayoutTests

2015-10-06 Thread jhoneycutt

Title: [190654] trunk/LayoutTests








Revision 190654
Author jhoneyc...@apple.com
Date 2015-10-06 18:12:54 -0700 (Tue, 06 Oct 2015)


Log Message
Unreviewed Mac test gardening after r190629.

* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190653 => 190654)

--- trunk/LayoutTests/ChangeLog	2015-10-07 00:06:59 UTC (rev 190653)
+++ trunk/LayoutTests/ChangeLog	2015-10-07 01:12:54 UTC (rev 190654)
@@ -1,3 +1,10 @@
+2015-10-06  Jon Honeycutt  
+
+Unreviewed Mac test gardening after r190629.
+
+* platform/mac-wk1/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2015-10-06  Nan Wang  
 
 AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (190653 => 190654)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-10-07 00:06:59 UTC (rev 190653)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-10-07 01:12:54 UTC (rev 190654)
@@ -145,3 +145,7 @@
 
 # Testing the system language declaratively only makes sense in WK2, because it's implemented in WebKitTestRunner by launching a new WebContent process.
 fast/text/international/system-language [ Pass Failure ImageOnlyFailure ]
+
+# Imported Blink tests
+imported/blink/svg/hittest/rect-miterlimit.html [ Pass Timeout ]
+imported/blink/fast/text-autosizing/print-autosizing.html  [ Pass Timeout ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (190653 => 190654)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-07 00:06:59 UTC (rev 190653)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-07 01:12:54 UTC (rev 190654)
@@ -530,3 +530,9 @@
 
 # WebKit1-only failure.
 webkit.org/b/103857 fast/events/mouse-cursor-change.html [ Pass ]
+
+# Imported Blink tests
+imported/blink/fast/multicol/basic-rtl.html [ Pass ImageOnlyFailure ]
+imported/blink/fast/multicol/dynamic/add-spanner-inside-overflow-hidden.html [ Pass ImageOnlyFailure ]
+imported/blink/fast/multicol/vertical-lr/float-big-line.html  [ Pass ImageOnlyFailure ]
+imported/blink/http/tests/plugins/get-url-notify-on-removal.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190339] trunk

2015-09-29 Thread jhoneycutt

Title: [190339] trunk








Revision 190339
Author jhoneyc...@apple.com
Date 2015-09-29 22:54:53 -0700 (Tue, 29 Sep 2015)


Log Message
Avoid reparsing an XSLT stylesheet after the first failure.
https://bugs.webkit.org/show_bug.cgi?id=149188


Reviewed by Dave Hyatt.

Patch by Jiewen Tan, jiewen_...@apple.com.

Source/WebCore:

Test: svg/custom/invalid-xslt-crash.svg

* xml/XSLStyleSheet.h:
Add a new member variable m_compilationFailed that tracks whether
compilation has failed. Default value is false.

* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::compileStyleSheet):
Return early if the compilation has failed before. After compiling the
style sheet, if we failed, set m_compilationFailed to true.

LayoutTests:

* svg/custom/invalid-xslt-crash-expected.txt: Added.
* svg/custom/invalid-xslt-crash.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XSLStyleSheet.h
trunk/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp


Added Paths

trunk/LayoutTests/svg/custom/invalid-xslt-crash-expected.txt
trunk/LayoutTests/svg/custom/invalid-xslt-crash.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (190338 => 190339)

--- trunk/LayoutTests/ChangeLog	2015-09-30 05:53:51 UTC (rev 190338)
+++ trunk/LayoutTests/ChangeLog	2015-09-30 05:54:53 UTC (rev 190339)
@@ -1,3 +1,16 @@
+2015-09-29  Jon Honeycutt  
+
+Avoid reparsing an XSLT stylesheet after the first failure.
+https://bugs.webkit.org/show_bug.cgi?id=149188
+
+
+Reviewed by Dave Hyatt.
+
+Patch by Jiewen Tan, jiewen_...@apple.com.
+
+* svg/custom/invalid-xslt-crash-expected.txt: Added.
+* svg/custom/invalid-xslt-crash.svg: Added.
+
 2015-09-29  Wenson Hsieh  
 
 Snap offsets should update when style is programmatically changed


Added: trunk/LayoutTests/svg/custom/invalid-xslt-crash-expected.txt (0 => 190339)

--- trunk/LayoutTests/svg/custom/invalid-xslt-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/custom/invalid-xslt-crash-expected.txt	2015-09-30 05:54:53 UTC (rev 190339)
@@ -0,0 +1,2 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600


Added: trunk/LayoutTests/svg/custom/invalid-xslt-crash.svg (0 => 190339)

--- trunk/LayoutTests/svg/custom/invalid-xslt-crash.svg	(rev 0)
+++ trunk/LayoutTests/svg/custom/invalid-xslt-crash.svg	2015-09-30 05:54:53 UTC (rev 190339)
@@ -0,0 +1,7 @@
+
+  
+  lime
+


Modified: trunk/Source/WebCore/ChangeLog (190338 => 190339)

--- trunk/Source/WebCore/ChangeLog	2015-09-30 05:53:51 UTC (rev 190338)
+++ trunk/Source/WebCore/ChangeLog	2015-09-30 05:54:53 UTC (rev 190339)
@@ -1,3 +1,24 @@
+2015-09-29  Jon Honeycutt  
+
+Avoid reparsing an XSLT stylesheet after the first failure.
+https://bugs.webkit.org/show_bug.cgi?id=149188
+
+
+Reviewed by Dave Hyatt.
+
+Patch by Jiewen Tan, jiewen_...@apple.com.
+
+Test: svg/custom/invalid-xslt-crash.svg
+
+* xml/XSLStyleSheet.h:
+Add a new member variable m_compilationFailed that tracks whether
+compilation has failed. Default value is false.
+
+* xml/XSLStyleSheetLibxslt.cpp:
+(WebCore::XSLStyleSheet::compileStyleSheet):
+Return early if the compilation has failed before. After compiling the
+style sheet, if we failed, set m_compilationFailed to true.
+
 2015-09-29  Hunseop Jeong  
 
 Use modern for-loops in WebCore/loader.


Modified: trunk/Source/WebCore/xml/XSLStyleSheet.h (190338 => 190339)

--- trunk/Source/WebCore/xml/XSLStyleSheet.h	2015-09-30 05:53:51 UTC (rev 190338)
+++ trunk/Source/WebCore/xml/XSLStyleSheet.h	2015-09-30 05:54:53 UTC (rev 190339)
@@ -116,7 +116,8 @@
 
 xmlDocPtr m_stylesheetDoc;
 bool m_stylesheetDocTaken;
-
+bool m_compilationFailed = false;
+
 XSLStyleSheet* m_parentStyleSheet;
 };
 


Modified: trunk/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp (190338 => 190339)

--- trunk/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp	2015-09-30 05:53:51 UTC (rev 190338)
+++ trunk/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp	2015-09-30 05:54:53 UTC (rev 190339)
@@ -245,12 +245,19 @@
 if (m_embedded)
 return xsltLoadStylesheetPI(document());
 
+// Certain libxslt versions are corrupting the xmlDoc on compilation
+// failures - hence attempting to recompile after a failure is unsafe.
+if (m_compilationFailed)
+return 0;
+
 // xsltParseStylesheetDoc makes the document part of the stylesheet
 // so we have to release our pointer to it.
 ASSERT(!m_stylesheetDocTaken);
 xsltStylesheetPtr result = xsltParseStylesheetDoc(m_stylesheetDoc);
 if (result)
 m_stylesheetDocTaken = true;
+else
+m_compilationFailed = true;
 return result;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/we

[webkit-changes] [189440] trunk/LayoutTests

2015-09-05 Thread jhoneycutt

Title: [189440] trunk/LayoutTests








Revision 189440
Author jhoneyc...@apple.com
Date 2015-09-05 13:54:31 -0700 (Sat, 05 Sep 2015)


Log Message
Import a couple of Chromium accesskey tests.
https://bugs.webkit.org/show_bug.cgi?id=148865

Reviewed by Daniel Bates.

* fast/forms/access-key-case-insensitive-expected.txt: Added.
* fast/forms/access-key-case-insensitive.html: Added.
* fast/forms/access-key-mutated-expected.txt: Added.
* fast/forms/access-key-mutated.html: Added.
* platform/ios-simulator/TestExpectations:
These tests are asynchronous and use unsupported features; skip them on
iOS so they don't time out.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations


Added Paths

trunk/LayoutTests/fast/forms/access-key-case-insensitive-expected.txt
trunk/LayoutTests/fast/forms/access-key-case-insensitive.html
trunk/LayoutTests/fast/forms/access-key-mutated-expected.txt
trunk/LayoutTests/fast/forms/access-key-mutated.html




Diff

Modified: trunk/LayoutTests/ChangeLog (189439 => 189440)

--- trunk/LayoutTests/ChangeLog	2015-09-05 19:45:58 UTC (rev 189439)
+++ trunk/LayoutTests/ChangeLog	2015-09-05 20:54:31 UTC (rev 189440)
@@ -1,3 +1,18 @@
+2015-09-04  Jon Honeycutt  
+
+Import a couple of Chromium accesskey tests.
+https://bugs.webkit.org/show_bug.cgi?id=148865
+
+Reviewed by Daniel Bates.
+
+* fast/forms/access-key-case-insensitive-expected.txt: Added.
+* fast/forms/access-key-case-insensitive.html: Added.
+* fast/forms/access-key-mutated-expected.txt: Added.
+* fast/forms/access-key-mutated.html: Added.
+* platform/ios-simulator/TestExpectations:
+These tests are asynchronous and use unsupported features; skip them on
+iOS so they don't time out.
+
 2015-09-05  Chris Dumez  
 
 Unreviewed, skip http/tests/w3c/html/semantics/embedded-content/media-elements/* tests on Win/Debug.


Added: trunk/LayoutTests/fast/forms/access-key-case-insensitive-expected.txt (0 => 189440)

--- trunk/LayoutTests/fast/forms/access-key-case-insensitive-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/access-key-case-insensitive-expected.txt	2015-09-05 20:54:31 UTC (rev 189440)
@@ -0,0 +1,12 @@
+Access key should work case-insensitively. To test this manually, press +a, ++b and ++c keys in this order (on Mac OS X, press + instead of ).
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Pressing the "a" access key triggered a focus event.
+PASS Pressing the "B" access key triggered a focus event.
+PASS Pressing the "C" access key triggered a focus event.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/forms/access-key-case-insensitive.html (0 => 189440)

--- trunk/LayoutTests/fast/forms/access-key-case-insensitive.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/access-key-case-insensitive.html	2015-09-05 20:54:31 UTC (rev 189440)
@@ -0,0 +1,61 @@
+
+
+
+Case insensitiveness of accesskey attribute
+
+
+
+