[webkit-changes] [144665] branches/chromium/1410
Title: [144665] branches/chromium/1410
Revision 144665
Author ju...@google.com
Date 2013-03-04 13:39:25 -0800 (Mon, 04 Mar 2013)
Log Message
Merge 144196
REGRESSION (r134631) of border-radius percentage with border pixel
https://bugs.webkit.org/show_bug.cgi?id=110889
Reviewed by Simon Fraser.
Source/WebCore:
Fixing background color filling to handle non renderable rounded
rectangles.
Test: fast/borders/border-radius-percent.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
LayoutTests:
Adding new pixel test to verify the correct rendering of
rounded rectangle backgrounds with inner border radii that
exceed the dimensions of the inner edge of the border.
* fast/borders/border-radius-percent-expected.txt: Added.
* fast/borders/border-radius-percent.html: Added.
* platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Added.
* platform/chromium/TestExpectations:
TBR=ju...@google.com
Review URL: https://codereview.chromium.org/12390064
Modified Paths
branches/chromium/1410/Source/WebCore/rendering/RenderBoxModelObject.cpp
Added Paths
branches/chromium/1410/LayoutTests/fast/borders/border-radius-percent-expected.txt
branches/chromium/1410/LayoutTests/fast/borders/border-radius-percent.html
branches/chromium/1410/LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png
Diff
Copied: branches/chromium/1410/LayoutTests/fast/borders/border-radius-percent-expected.txt (from rev 144196, trunk/LayoutTests/fast/borders/border-radius-percent-expected.txt) (0 => 144665)
--- branches/chromium/1410/LayoutTests/fast/borders/border-radius-percent-expected.txt (rev 0)
+++ branches/chromium/1410/LayoutTests/fast/borders/border-radius-percent-expected.txt 2013-03-04 21:39:25 UTC (rev 144665)
@@ -0,0 +1,3 @@
+Corners on top should be rounded and a border of 1px black on the bottom.
+
+Corners on top should be rounded and a border of 1px black all around.
Copied: branches/chromium/1410/LayoutTests/fast/borders/border-radius-percent.html (from rev 144196, trunk/LayoutTests/fast/borders/border-radius-percent.html) (0 => 144665)
--- branches/chromium/1410/LayoutTests/fast/borders/border-radius-percent.html (rev 0)
+++ branches/chromium/1410/LayoutTests/fast/borders/border-radius-percent.html 2013-03-04 21:39:25 UTC (rev 144665)
@@ -0,0 +1,28 @@
+!doctype html
+html
+head
+style type=text/css
+p{
+text-align:center;
+background:#ccc;
+border-radius:50% 50% 0 0 / 100%;
+width:300px;
+height:150px;
+}
+p.all{
+border:1px solid #000;
+}
+p.bottom{
+border-bottom:1px solid #000;
+}
+/style
+script
+if (window.testRunner)
+testRunner.dumpAsText(true);
+/script
+/head
+body
+p class=bottomCorners on top should be rounded and a border of 1px black on the bottom./p
+p class=allCorners on top should be rounded and a border of 1px black all around./p
+/body
+/html
Copied: branches/chromium/1410/LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png (from rev 144196, trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png)
(Binary files differ)
Modified: branches/chromium/1410/Source/WebCore/rendering/RenderBoxModelObject.cpp (144664 => 144665)
--- branches/chromium/1410/Source/WebCore/rendering/RenderBoxModelObject.cpp 2013-03-04 21:38:38 UTC (rev 144664)
+++ branches/chromium/1410/Source/WebCore/rendering/RenderBoxModelObject.cpp 2013-03-04 21:39:25 UTC (rev 144665)
@@ -711,7 +711,14 @@
if (hasRoundedBorder bleedAvoidance != BackgroundBleedUseTransparencyLayer) {
RoundedRect border = backgroundRoundedRectAdjustedForBleedAvoidance(context, rect, bleedAvoidance, box, boxSize, includeLeftEdge, includeRightEdge);
-context-fillRoundedRect(border, bgColor, style()-colorSpace());
+if (border.isRenderable())
+context-fillRoundedRect(border, bgColor, style()-colorSpace());
+else {
+context-save();
+clipRoundedInnerRect(context, rect, border);
+context-fillRect(border.rect(), bgColor, style()-colorSpace());
+context-restore();
+}
} else
context-fillRect(pixelSnappedIntRect(rect), bgColor, style()-colorSpace());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144349] trunk/LayoutTests
Title: [144349] trunk/LayoutTests Revision 144349 Author ju...@google.com Date 2013-02-28 12:31:55 -0800 (Thu, 28 Feb 2013) Log Message Re-baselining expected pixels for fast/borders/border-radius-percent.html on linux https://bugs.webkit.org/show_bug.cgi?id=110889 Unreviewed * TestExpectations: * platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (144348 => 144349) --- trunk/LayoutTests/ChangeLog 2013-02-28 20:18:00 UTC (rev 144348) +++ trunk/LayoutTests/ChangeLog 2013-02-28 20:31:55 UTC (rev 144349) @@ -1,3 +1,13 @@ +2013-02-28 Justin Novosad ju...@google.com + +Re-baselining expected pixels for fast/borders/border-radius-percent.html on linux +https://bugs.webkit.org/show_bug.cgi?id=110889 + +Unreviewed + +* TestExpectations: +* platform/chromium-linux/fast/borders/border-radius-percent-expected.png: + 2013-02-28 Stephen Chenney schen...@chromium.org [Chromium] Unreviewed gardening, update expectation Modified: trunk/LayoutTests/TestExpectations (144348 => 144349) --- trunk/LayoutTests/TestExpectations 2013-02-28 20:18:00 UTC (rev 144348) +++ trunk/LayoutTests/TestExpectations 2013-02-28 20:31:55 UTC (rev 144349) @@ -2,8 +2,5 @@ # # See http://trac.webkit.org/wiki/TestExpectations for more information on this file. -# New test in need of pixel baselines -webkit.org/b/110889 fast/borders/border-radius-percent.html [ ImageOnlyFailure Pass ] - # pending functional patch and per-port verification webkit.org/b/109954 css3/line-break [ Skip ] Modified: trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144196] trunk
Title: [144196] trunk
Revision 144196
Author ju...@google.com
Date 2013-02-27 08:48:03 -0800 (Wed, 27 Feb 2013)
Log Message
REGRESSION (r134631) of border-radius percentage with border pixel
https://bugs.webkit.org/show_bug.cgi?id=110889
Reviewed by Simon Fraser.
Source/WebCore:
Fixing background color filling to handle non renderable rounded
rectangles.
Test: fast/borders/border-radius-percent.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
LayoutTests:
Adding new pixel test to verify the correct rendering of
rounded rectangle backgrounds with inner border radii that
exceed the dimensions of the inner edge of the border.
* fast/borders/border-radius-percent-expected.txt: Added.
* fast/borders/border-radius-percent.html: Added.
* platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Added.
* platform/chromium/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
Added Paths
trunk/LayoutTests/fast/borders/border-radius-percent-expected.txt
trunk/LayoutTests/fast/borders/border-radius-percent.html
trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (144195 => 144196)
--- trunk/LayoutTests/ChangeLog 2013-02-27 16:45:06 UTC (rev 144195)
+++ trunk/LayoutTests/ChangeLog 2013-02-27 16:48:03 UTC (rev 144196)
@@ -1,3 +1,19 @@
+2013-02-27 Justin Novosad ju...@google.com
+
+REGRESSION (r134631) of border-radius percentage with border pixel
+https://bugs.webkit.org/show_bug.cgi?id=110889
+
+Reviewed by Simon Fraser.
+
+Adding new pixel test to verify the correct rendering of
+rounded rectangle backgrounds with inner border radii that
+exceed the dimensions of the inner edge of the border.
+
+* fast/borders/border-radius-percent-expected.txt: Added.
+* fast/borders/border-radius-percent.html: Added.
+* platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Added.
+* platform/chromium/TestExpectations:
+
2013-02-27 Florin Malita fmal...@chromium.org
[Chromium] Layout Test svg/custom/transform-with-shadow-and-gradient.svg is failing
Modified: trunk/LayoutTests/TestExpectations (144195 => 144196)
--- trunk/LayoutTests/TestExpectations 2013-02-27 16:45:06 UTC (rev 144195)
+++ trunk/LayoutTests/TestExpectations 2013-02-27 16:48:03 UTC (rev 144196)
@@ -2,5 +2,8 @@
#
# See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
+# New test in need of pixel baselines
+webkit.org/b/110889 fast/borders/border-radius-percent.html [ ImageOnlyFailure Pass ]
+
# pending functional patch and per-port verification
webkit.org/b/109954 css3/line-break [ Skip ]
Added: trunk/LayoutTests/fast/borders/border-radius-percent-expected.txt (0 => 144196)
--- trunk/LayoutTests/fast/borders/border-radius-percent-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/borders/border-radius-percent-expected.txt 2013-02-27 16:48:03 UTC (rev 144196)
@@ -0,0 +1,3 @@
+Corners on top should be rounded and a border of 1px black on the bottom.
+
+Corners on top should be rounded and a border of 1px black all around.
Added: trunk/LayoutTests/fast/borders/border-radius-percent.html (0 => 144196)
--- trunk/LayoutTests/fast/borders/border-radius-percent.html (rev 0)
+++ trunk/LayoutTests/fast/borders/border-radius-percent.html 2013-02-27 16:48:03 UTC (rev 144196)
@@ -0,0 +1,28 @@
+!doctype html
+html
+head
+style type=text/css
+p{
+text-align:center;
+background:#ccc;
+border-radius:50% 50% 0 0 / 100%;
+width:300px;
+height:150px;
+}
+p.all{
+border:1px solid #000;
+}
+p.bottom{
+border-bottom:1px solid #000;
+}
+/style
+script
+if (window.testRunner)
+testRunner.dumpAsText(true);
+/script
+/head
+body
+p class=bottomCorners on top should be rounded and a border of 1px black on the bottom./p
+p class=allCorners on top should be rounded and a border of 1px black all around./p
+/body
+/html
Added: trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png
___
Added: svn:mime-type
Modified: trunk/Source/WebCore/ChangeLog (144195 => 144196)
--- trunk/Source/WebCore/ChangeLog 2013-02-27 16:45:06 UTC (rev 144195)
+++ trunk/Source/WebCore/ChangeLog 2013-02-27 16:48:03 UTC (rev 144196)
@@ -1,3 +1,18 @@
+2013-02-27 Justin Novosad ju...@google.com
+
+REGRESSION (r134631) of border-radius percentage with border pixel
+
[webkit-changes] [141267] branches/chromium/1364
Title: [141267] branches/chromium/1364
Revision 141267
Author ju...@google.com
Date 2013-01-30 07:06:43 -0800 (Wed, 30 Jan 2013)
Log Message
Merge 141160
REGRESSION (r135628-135632): Double box shadow failure to render
https://bugs.webkit.org/show_bug.cgi?id=107833
Reviewed by Simon Fraser.
Source/WebCore:
Regression caused by http://trac.webkit.org/changeset/135629
The regression was due to faulty occlusion logic that was assuming
that drawing the background color of a render box background layer
could be skipped when the same layer also has an opaque image attached.
In the case where the background color is drawn for the purpose of
rendering a box shadow, the shadow is typically not
completely occluded by the background image because of the shadow
blur and/or offset. This patch fixes the problem by not culling a
background draw if it is used to draw a box shadow.
Test: fast/backgrounds/gradient-background-shadow.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Changing occlusion culling test to never cull background color
draw if it is used to draw a box shadow. This is because box shadows
can draw outside the border fill region.
LayoutTests:
New ref test verifies that box shadow is drawn when
background is an opaque image. Test uses an blue gradient
as background image. Reference uses blue background color.
* fast/backgrounds/gradient-background-shadow-expected.html: Added.
* fast/backgrounds/gradient-background-shadow.html: Added.
TBR=ju...@google.com
Review URL: https://codereview.chromium.org/12089070
Modified Paths
branches/chromium/1364/Source/WebCore/rendering/RenderBoxModelObject.cpp
Added Paths
branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-shadow-expected.html
branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-shadow.html
Diff
Copied: branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-shadow-expected.html (from rev 141160, trunk/LayoutTests/fast/backgrounds/gradient-background-shadow-expected.html) (0 => 141267)
--- branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-shadow-expected.html (rev 0)
+++ branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-shadow-expected.html 2013-01-30 15:06:43 UTC (rev 141267)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+head
+ style type=text/css
+.box {
+ height: 50px;
+ width: 50px;
+ background-color: blue;
+ -webkit-box-shadow: 20px 20px 5px green;
+}
+ /style
+/head
+body
+ Test passes when a blue box is drawn with a green shadow.
+ div class=box/div
+/body
+/html
Copied: branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-shadow.html (from rev 141160, trunk/LayoutTests/fast/backgrounds/gradient-background-shadow.html) (0 => 141267)
--- branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-shadow.html (rev 0)
+++ branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-shadow.html 2013-01-30 15:06:43 UTC (rev 141267)
@@ -0,0 +1,18 @@
+!DOCTYPE html
+html
+head
+ style type=text/css
+.box {
+ height: 50px;
+ width: 50px;
+ background-image: -webkit-linear-gradient(blue, blue);
+ background-color: red;
+ -webkit-box-shadow: 20px 20px 5px green;
+}
+ /style
+/head
+body
+ Test passes when a blue box is drawn with a green shadow.
+ div class=box/div
+/body
+/html
Modified: branches/chromium/1364/Source/WebCore/rendering/RenderBoxModelObject.cpp (141266 => 141267)
--- branches/chromium/1364/Source/WebCore/rendering/RenderBoxModelObject.cpp 2013-01-30 15:00:04 UTC (rev 141266)
+++ branches/chromium/1364/Source/WebCore/rendering/RenderBoxModelObject.cpp 2013-01-30 15:06:43 UTC (rev 141267)
@@ -912,35 +912,37 @@
// Paint the color first underneath all images, culled if background image occludes it.
// FIXME: In the bgLayer-hasFiniteBounds() case, we could improve the culling test
// by verifying whether the background image covers the entire layout rect.
-if (!bgLayer-next() !(shouldPaintBackgroundImage bgLayer-hasOpaqueImage(this) bgLayer-hasRepeatXY())) {
+if (!bgLayer-next()) {
IntRect backgroundRect(pixelSnappedIntRect(scrolledPaintRect));
bool boxShadowShouldBeAppliedToBackground = this-boxShadowShouldBeAppliedToBackground(bleedAvoidance, box);
-if (!boxShadowShouldBeAppliedToBackground)
-backgroundRect.intersect(paintInfo.rect);
+if (boxShadowShouldBeAppliedToBackground || !shouldPaintBackgroundImage || !bgLayer-hasOpaqueImage(this) || !bgLayer-hasRepeatXY()) {
+if (!boxShadowShouldBeAppliedToBackground)
+backgroundRect.intersect(paintInfo.rect);
-// If we have an alpha and we are painting the root element, go ahead and blend with the base background color.
-
[webkit-changes] [141160] trunk
Title: [141160] trunk
Revision 141160
Author ju...@google.com
Date 2013-01-29 13:32:07 -0800 (Tue, 29 Jan 2013)
Log Message
REGRESSION (r135628-135632): Double box shadow failure to render
https://bugs.webkit.org/show_bug.cgi?id=107833
Reviewed by Simon Fraser.
Source/WebCore:
Regression caused by http://trac.webkit.org/changeset/135629
The regression was due to faulty occlusion logic that was assuming
that drawing the background color of a render box background layer
could be skipped when the same layer also has an opaque image attached.
In the case where the background color is drawn for the purpose of
rendering a box shadow, the shadow is typically not
completely occluded by the background image because of the shadow
blur and/or offset. This patch fixes the problem by not culling a
background draw if it is used to draw a box shadow.
Test: fast/backgrounds/gradient-background-shadow.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Changing occlusion culling test to never cull background color
draw if it is used to draw a box shadow. This is because box shadows
can draw outside the border fill region.
LayoutTests:
New ref test verifies that box shadow is drawn when
background is an opaque image. Test uses an blue gradient
as background image. Reference uses blue background color.
* fast/backgrounds/gradient-background-shadow-expected.html: Added.
* fast/backgrounds/gradient-background-shadow.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
Added Paths
trunk/LayoutTests/fast/backgrounds/gradient-background-shadow-expected.html
trunk/LayoutTests/fast/backgrounds/gradient-background-shadow.html
Diff
Modified: trunk/LayoutTests/ChangeLog (141159 => 141160)
--- trunk/LayoutTests/ChangeLog 2013-01-29 21:22:27 UTC (rev 141159)
+++ trunk/LayoutTests/ChangeLog 2013-01-29 21:32:07 UTC (rev 141160)
@@ -1,3 +1,17 @@
+2013-01-29 Justin Novosad ju...@google.com
+
+REGRESSION (r135628-135632): Double box shadow failure to render
+https://bugs.webkit.org/show_bug.cgi?id=107833
+
+Reviewed by Simon Fraser.
+
+New ref test verifies that box shadow is drawn when
+background is an opaque image. Test uses an blue gradient
+as background image. Reference uses blue background color.
+
+* fast/backgrounds/gradient-background-shadow-expected.html: Added.
+* fast/backgrounds/gradient-background-shadow.html: Added.
+
2013-01-29 Pravin D pravind@gmail.com
Current error reporting method used by check-layout.js should not affect subsequent sub-tests using checking data-offset-y.
Added: trunk/LayoutTests/fast/backgrounds/gradient-background-shadow-expected.html (0 => 141160)
--- trunk/LayoutTests/fast/backgrounds/gradient-background-shadow-expected.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/gradient-background-shadow-expected.html 2013-01-29 21:32:07 UTC (rev 141160)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+head
+ style type=text/css
+.box {
+ height: 50px;
+ width: 50px;
+ background-color: blue;
+ -webkit-box-shadow: 20px 20px 5px green;
+}
+ /style
+/head
+body
+ Test passes when a blue box is drawn with a green shadow.
+ div class=box/div
+/body
+/html
Added: trunk/LayoutTests/fast/backgrounds/gradient-background-shadow.html (0 => 141160)
--- trunk/LayoutTests/fast/backgrounds/gradient-background-shadow.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/gradient-background-shadow.html 2013-01-29 21:32:07 UTC (rev 141160)
@@ -0,0 +1,18 @@
+!DOCTYPE html
+html
+head
+ style type=text/css
+.box {
+ height: 50px;
+ width: 50px;
+ background-image: -webkit-linear-gradient(blue, blue);
+ background-color: red;
+ -webkit-box-shadow: 20px 20px 5px green;
+}
+ /style
+/head
+body
+ Test passes when a blue box is drawn with a green shadow.
+ div class=box/div
+/body
+/html
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (141159 => 141160)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-29 21:22:27 UTC (rev 141159)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-29 21:32:07 UTC (rev 141160)
@@ -4284,6 +4284,7 @@
# Ref tests that now fail with Skia changes
crbug.com/169602 fast/backgrounds/background-opaque-clipped-gradients.html [ ImageOnlyFailure ]
crbug.com/169602 fast/backgrounds/background-opaque-images-over-color.html [ ImageOnlyFailure ]
+crbug.com/169602 fast/backgrounds/gradient-background-shadow.html [ ImageOnlyFailure ]
webkit.org/b/106858 [ Mac Debug ] scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ ImageOnlyFailure ]
webkit.org/b/106858 [ Linux Win Debug ]
[webkit-changes] [140464] branches/chromium/1364
Title: [140464] branches/chromium/1364
Revision 140464
Author ju...@google.com
Date 2013-01-22 14:03:09 -0800 (Tue, 22 Jan 2013)
Log Message
Merge 139137
Color bleeding with rounded rectangles on high dpi displays
https://bugs.webkit.org/show_bug.cgi?id=106373
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/backgrounds/gradient-background-leakage-hidpi.html
Avoid using the BackgroundBleedShrinkBackground draw strategy for
RenderBox when border width is less than two layout units. This
is because rounded rectangles are always snapped to integer layout
coordinates, even with subpixel layout enabled.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::determineBackgroundBleedAvoidance):
LayoutTests:
New layout test to verify that rounded rectangle corners do not
produce color bleeding on high dpi devices.
* fast/backgrounds/gradient-background-leakage-hidpi-expected.txt: Added.
* fast/backgrounds/gradient-background-leakage-hidpi.html: Added.
* platform/chromium-linux/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
TBR=ju...@google.com
Modified Paths
branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations
branches/chromium/1364/Source/WebCore/rendering/RenderBox.cpp
Added Paths
branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi-expected.txt
branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi.html
branches/chromium/1364/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-hidpi-expected.png
Diff
Copied: branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi-expected.txt (from rev 139137, trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi-expected.txt) (0 => 140464)
--- branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi-expected.txt (rev 0)
+++ branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi-expected.txt 2013-01-22 22:03:09 UTC (rev 140464)
@@ -0,0 +1,7 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x68
+ RenderBlock {HTML} at (0,0) size 800x68
+RenderBody {BODY} at (8,8) size 784x52
+ RenderBlock {DIV} at (0,0) size 220x52 [bgcolor=#FF]
+RenderBlock {DIV} at (10,10) size 202x32 [border: (1px solid #008000)]
Copied: branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi.html (from rev 139137, trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi.html) (0 => 140464)
--- branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi.html (rev 0)
+++ branches/chromium/1364/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi.html 2013-01-22 22:03:09 UTC (rev 140464)
@@ -0,0 +1,32 @@
+!DOCTYPE html
+html
+head
+ style type=text/css
+.box {
+ height: 30px;
+ width: 200px;
+ background-image: -webkit-linear-gradient(black, black);
+ border-radius: 25px;
+ border: 1px solid green;
+}
+ /style
+/head
+script
+window._onload_ = function() {
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.setBackingScaleFactor(2, finishTest);
+}
+}
+
+function finishTest() {
+setTimeout(function() { testRunner.notifyDone(); }, 0);
+}
+/script
+body
+ !-- You should see no red leaking through the inner edge of the border. --
+ div style=background-color: red; padding: 10px; width: 200px
+div class=box/div
+ /div
+/body
+/html
Modified: branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations (140463 => 140464)
--- branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations 2013-01-22 21:42:06 UTC (rev 140463)
+++ branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations 2013-01-22 22:03:09 UTC (rev 140464)
@@ -2720,6 +2720,9 @@
# New test added in r85454. Actual failure.
webkit.org/b/91676 fast/js/mozilla/strict/assign-to-callee-name.html [ Failure ]
+# Test needing new baselines with fix for bug 106373
+webkit.org/b/106373 fast/backgrounds/gradient-background-leakage-hidpi.html [ Pass ImageOnlyFailure ]
+
# Failure introduced by Chromium r83848.
crbug.com/137938 [ Mac Android ] fast/url/ipv6.html [ Failure ]
Copied: branches/chromium/1364/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-hidpi-expected.png (from rev 139137, trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-hidpi-expected.png) (0 => 140464)
--- branches/chromium/1364/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-hidpi-expected.png (rev 0)
+++
[webkit-changes] [139204] trunk/LayoutTests
Title: [139204] trunk/LayoutTests Revision 139204 Author ju...@google.com Date 2013-01-09 10:17:32 -0800 (Wed, 09 Jan 2013) Log Message New chromium-win pixel baseline for gradient-background-leakage-hidpi.html https://bugs.webkit.org/show_bug.cgi?id=106373 Unreviewed. * platform/chromium-win/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-hidpi-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (139203 => 139204) --- trunk/LayoutTests/ChangeLog 2013-01-09 18:10:34 UTC (rev 139203) +++ trunk/LayoutTests/ChangeLog 2013-01-09 18:17:32 UTC (rev 139204) @@ -1,3 +1,12 @@ +2013-01-09 Justin Novosad ju...@google.com + +New chromium-win pixel baseline for gradient-background-leakage-hidpi.html +https://bugs.webkit.org/show_bug.cgi?id=106373 + +Unreviewed. + +* platform/chromium-win/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added. + 2013-01-09 Alexis Menard ale...@webkit.org Implement CSS computed style value for transition shorthand Added: trunk/LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-hidpi-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-hidpi-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [139057] branches/chromium/1271
Title: [139057] branches/chromium/1271
Revision 139057
Author ju...@google.com
Date 2013-01-08 07:58:03 -0800 (Tue, 08 Jan 2013)
Log Message
Merge 138994
Fixing memory read after free in CanvasRenderingContext2D::accessFont
https://bugs.webkit.org/show_bug.cgi?id=106244
Reviewed by Abhishek Arya.
Source/WebCore:
Using a temporary String object to hold ref count on string that is
passed by reference in CanvasRenderingContext2D::accessFont.
Test: fast/canvas/canvas-measureText.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::accessFont):
LayoutTests:
New test case to verify stability of 2D canvas method measureText.
Test case was causing a DumpRenderTree crash on builds with
AddressSantitizer instrumentation.
* fast/canvas/canvas-measureText-expected.txt: Added.
* fast/canvas/canvas-measureText.html: Added.
TBR=ju...@google.com
Modified Paths
branches/chromium/1271/LayoutTests/ChangeLog
branches/chromium/1271/Source/WebCore/ChangeLog
branches/chromium/1271/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Added Paths
branches/chromium/1271/LayoutTests/fast/canvas/canvas-measureText-expected.txt
branches/chromium/1271/LayoutTests/fast/canvas/canvas-measureText.html
Diff
Modified: branches/chromium/1271/LayoutTests/ChangeLog (139056 => 139057)
--- branches/chromium/1271/LayoutTests/ChangeLog 2013-01-08 15:26:51 UTC (rev 139056)
+++ branches/chromium/1271/LayoutTests/ChangeLog 2013-01-08 15:58:03 UTC (rev 139057)
@@ -1,5 +1,19 @@
-2012-10-01 Keishi Hattori kei...@webkit.org
+2013-01-07 Justin Novosad ju...@google.com
+Fixing memory read after free in CanvasRenderingContext2D::accessFont
+https://bugs.webkit.org/show_bug.cgi?id=106244
+
+Reviewed by Abhishek Arya.
+
+New test case to verify stability of 2D canvas method measureText.
+Test case was causing a DumpRenderTree crash on builds with
+AddressSantitizer instrumentation.
+
+* fast/canvas/canvas-measureText-expected.txt: Added.
+* fast/canvas/canvas-measureText.html: Added.
+
+2013-01-07 Abhishek Arya infe...@chromium.org
+
REGRESSION(r127727): Calendar picker is ignoring step
https://bugs.webkit.org/show_bug.cgi?id=97893
Copied: branches/chromium/1271/LayoutTests/fast/canvas/canvas-measureText-expected.txt (from rev 138994, trunk/LayoutTests/fast/canvas/canvas-measureText-expected.txt) (0 => 139057)
--- branches/chromium/1271/LayoutTests/fast/canvas/canvas-measureText-expected.txt (rev 0)
+++ branches/chromium/1271/LayoutTests/fast/canvas/canvas-measureText-expected.txt 2013-01-08 15:58:03 UTC (rev 139057)
@@ -0,0 +1,5 @@
+Regression test for bug 106244
+
+Test passes by not crashing.
+
+
Copied: branches/chromium/1271/LayoutTests/fast/canvas/canvas-measureText.html (from rev 138994, trunk/LayoutTests/fast/canvas/canvas-measureText.html) (0 => 139057)
--- branches/chromium/1271/LayoutTests/fast/canvas/canvas-measureText.html (rev 0)
+++ branches/chromium/1271/LayoutTests/fast/canvas/canvas-measureText.html 2013-01-08 15:58:03 UTC (rev 139057)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+html
+body
+pRegression test for bug a href=""
+pTest passes by not crashing./p
+canvas id=test/canvas
+/body
+script
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+var canvas = document.getElementById(test);
+var context = canvas.getContext(2d);
+for (x = 0; x 100; x++) {
+ context.restore();
+ context.save();
+ context.save();
+ context.measureText(a, 0, 0, 0);
+}
+/script
+/html
Modified: branches/chromium/1271/Source/WebCore/ChangeLog (139056 => 139057)
--- branches/chromium/1271/Source/WebCore/ChangeLog 2013-01-08 15:26:51 UTC (rev 139056)
+++ branches/chromium/1271/Source/WebCore/ChangeLog 2013-01-08 15:58:03 UTC (rev 139057)
@@ -1,5 +1,20 @@
-2012-10-01 Keishi Hattori kei...@webkit.org
+2013-01-07 Justin Novosad ju...@google.com
+Fixing memory read after free in CanvasRenderingContext2D::accessFont
+https://bugs.webkit.org/show_bug.cgi?id=106244
+
+Reviewed by Abhishek Arya.
+
+Using a temporary String object to hold ref count on string that is
+passed by reference in CanvasRenderingContext2D::accessFont.
+
+Test: fast/canvas/canvas-measureText.html
+
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::CanvasRenderingContext2D::accessFont):
+
+2013-01-07 Anders Carlsson ander...@apple.com
+
REGRESSION(r127727): Calendar picker is ignoring step
https://bugs.webkit.org/show_bug.cgi?id=97893
Modified: branches/chromium/1271/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (139056 => 139057)
--- branches/chromium/1271/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2013-01-08 15:26:51 UTC (rev 139056)
+++ branches/chromium/1271/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2013-01-08 15:58:03
[webkit-changes] [139058] branches/chromium/1312
Title: [139058] branches/chromium/1312
Revision 139058
Author ju...@google.com
Date 2013-01-08 08:04:34 -0800 (Tue, 08 Jan 2013)
Log Message
Merge 138994
Fixing memory read after free in CanvasRenderingContext2D::accessFont
https://bugs.webkit.org/show_bug.cgi?id=106244
Reviewed by Abhishek Arya.
Source/WebCore:
Using a temporary String object to hold ref count on string that is
passed by reference in CanvasRenderingContext2D::accessFont.
Test: fast/canvas/canvas-measureText.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::accessFont):
LayoutTests:
New test case to verify stability of 2D canvas method measureText.
Test case was causing a DumpRenderTree crash on builds with
AddressSantitizer instrumentation.
* fast/canvas/canvas-measureText-expected.txt: Added.
* fast/canvas/canvas-measureText.html: Added.
TBR=ju...@google.com
Review URL: https://codereview.chromium.org/11783030
Modified Paths
branches/chromium/1312/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Added Paths
branches/chromium/1312/LayoutTests/fast/canvas/canvas-measureText-expected.txt
branches/chromium/1312/LayoutTests/fast/canvas/canvas-measureText.html
Diff
Copied: branches/chromium/1312/LayoutTests/fast/canvas/canvas-measureText-expected.txt (from rev 138994, trunk/LayoutTests/fast/canvas/canvas-measureText-expected.txt) (0 => 139058)
--- branches/chromium/1312/LayoutTests/fast/canvas/canvas-measureText-expected.txt (rev 0)
+++ branches/chromium/1312/LayoutTests/fast/canvas/canvas-measureText-expected.txt 2013-01-08 16:04:34 UTC (rev 139058)
@@ -0,0 +1,5 @@
+Regression test for bug 106244
+
+Test passes by not crashing.
+
+
Copied: branches/chromium/1312/LayoutTests/fast/canvas/canvas-measureText.html (from rev 138994, trunk/LayoutTests/fast/canvas/canvas-measureText.html) (0 => 139058)
--- branches/chromium/1312/LayoutTests/fast/canvas/canvas-measureText.html (rev 0)
+++ branches/chromium/1312/LayoutTests/fast/canvas/canvas-measureText.html 2013-01-08 16:04:34 UTC (rev 139058)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+html
+body
+pRegression test for bug a href=""
+pTest passes by not crashing./p
+canvas id=test/canvas
+/body
+script
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+var canvas = document.getElementById(test);
+var context = canvas.getContext(2d);
+for (x = 0; x 100; x++) {
+ context.restore();
+ context.save();
+ context.save();
+ context.measureText(a, 0, 0, 0);
+}
+/script
+/html
Modified: branches/chromium/1312/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (139057 => 139058)
--- branches/chromium/1312/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2013-01-08 15:58:03 UTC (rev 139057)
+++ branches/chromium/1312/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2013-01-08 16:04:34 UTC (rev 139058)
@@ -2360,8 +2360,13 @@
{
canvas()-document()-updateStyleIfNeeded();
-if (!state().m_realizedFont)
-setFont(state().m_unparsedFont);
+if (!state().m_realizedFont) {
+// Create temporary string object to hold ref count in case
+// state().m_unparsedFont in unreffed by call to realizeSaves in
+// setFont.
+String unparsedFont(state().m_unparsedFont);
+setFont(unparsedFont);
+}
return state().m_font;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [139059] branches/chromium/1364
Title: [139059] branches/chromium/1364
Revision 139059
Author ju...@google.com
Date 2013-01-08 08:08:24 -0800 (Tue, 08 Jan 2013)
Log Message
Merge 138994
Fixing memory read after free in CanvasRenderingContext2D::accessFont
https://bugs.webkit.org/show_bug.cgi?id=106244
Reviewed by Abhishek Arya.
Source/WebCore:
Using a temporary String object to hold ref count on string that is
passed by reference in CanvasRenderingContext2D::accessFont.
Test: fast/canvas/canvas-measureText.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::accessFont):
LayoutTests:
New test case to verify stability of 2D canvas method measureText.
Test case was causing a DumpRenderTree crash on builds with
AddressSantitizer instrumentation.
* fast/canvas/canvas-measureText-expected.txt: Added.
* fast/canvas/canvas-measureText.html: Added.
TBR=ju...@google.com
Review URL: https://codereview.chromium.org/11808004
Modified Paths
branches/chromium/1364/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Added Paths
branches/chromium/1364/LayoutTests/fast/canvas/canvas-measureText-expected.txt
branches/chromium/1364/LayoutTests/fast/canvas/canvas-measureText.html
Diff
Copied: branches/chromium/1364/LayoutTests/fast/canvas/canvas-measureText-expected.txt (from rev 138994, trunk/LayoutTests/fast/canvas/canvas-measureText-expected.txt) (0 => 139059)
--- branches/chromium/1364/LayoutTests/fast/canvas/canvas-measureText-expected.txt (rev 0)
+++ branches/chromium/1364/LayoutTests/fast/canvas/canvas-measureText-expected.txt 2013-01-08 16:08:24 UTC (rev 139059)
@@ -0,0 +1,5 @@
+Regression test for bug 106244
+
+Test passes by not crashing.
+
+
Copied: branches/chromium/1364/LayoutTests/fast/canvas/canvas-measureText.html (from rev 138994, trunk/LayoutTests/fast/canvas/canvas-measureText.html) (0 => 139059)
--- branches/chromium/1364/LayoutTests/fast/canvas/canvas-measureText.html (rev 0)
+++ branches/chromium/1364/LayoutTests/fast/canvas/canvas-measureText.html 2013-01-08 16:08:24 UTC (rev 139059)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+html
+body
+pRegression test for bug a href=""
+pTest passes by not crashing./p
+canvas id=test/canvas
+/body
+script
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+var canvas = document.getElementById(test);
+var context = canvas.getContext(2d);
+for (x = 0; x 100; x++) {
+ context.restore();
+ context.save();
+ context.save();
+ context.measureText(a, 0, 0, 0);
+}
+/script
+/html
Modified: branches/chromium/1364/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (139058 => 139059)
--- branches/chromium/1364/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2013-01-08 16:04:34 UTC (rev 139058)
+++ branches/chromium/1364/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2013-01-08 16:08:24 UTC (rev 139059)
@@ -2373,8 +2373,13 @@
{
canvas()-document()-updateStyleIfNeeded();
-if (!state().m_realizedFont)
-setFont(state().m_unparsedFont);
+if (!state().m_realizedFont) {
+// Create temporary string object to hold ref count in case
+// state().m_unparsedFont in unreffed by call to realizeSaves in
+// setFont.
+String unparsedFont(state().m_unparsedFont);
+setFont(unparsedFont);
+}
return state().m_font;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [139137] trunk
Title: [139137] trunk
Revision 139137
Author ju...@google.com
Date 2013-01-08 17:17:19 -0800 (Tue, 08 Jan 2013)
Log Message
Color bleeding with rounded rectangles on high dpi displays
https://bugs.webkit.org/show_bug.cgi?id=106373
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/backgrounds/gradient-background-leakage-hidpi.html
Avoid using the BackgroundBleedShrinkBackground draw strategy for
RenderBox when border width is less than two layout units. This
is because rounded rectangles are always snapped to integer layout
coordinates, even with subpixel layout enabled.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::determineBackgroundBleedAvoidance):
LayoutTests:
New layout test to verify that rounded rectangle corners do not
produce color bleeding on high dpi devices.
* fast/backgrounds/gradient-background-leakage-hidpi-expected.txt: Added.
* fast/backgrounds/gradient-background-leakage-hidpi.html: Added.
* platform/chromium-linux/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
Added Paths
trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi-expected.txt
trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi.html
trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-hidpi-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (139136 => 139137)
--- trunk/LayoutTests/ChangeLog 2013-01-09 01:11:32 UTC (rev 139136)
+++ trunk/LayoutTests/ChangeLog 2013-01-09 01:17:19 UTC (rev 139137)
@@ -1,3 +1,17 @@
+2013-01-08 Justin Novosad ju...@google.com
+
+Color bleeding with rounded rectangles on high dpi displays
+https://bugs.webkit.org/show_bug.cgi?id=106373
+
+Reviewed by Simon Fraser.
+
+New layout test to verify that rounded rectangle corners do not
+produce color bleeding on high dpi devices.
+
+* fast/backgrounds/gradient-background-leakage-hidpi-expected.txt: Added.
+* fast/backgrounds/gradient-background-leakage-hidpi.html: Added.
+* platform/chromium-linux/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
+
2013-01-08 Filip Pizlo fpi...@apple.com
DFG shouldn't treat the 'this' argument as being captured if a code block uses arguments
Added: trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi-expected.txt (0 => 139137)
--- trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi-expected.txt 2013-01-09 01:17:19 UTC (rev 139137)
@@ -0,0 +1,7 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x68
+ RenderBlock {HTML} at (0,0) size 800x68
+RenderBody {BODY} at (8,8) size 784x52
+ RenderBlock {DIV} at (0,0) size 220x52 [bgcolor=#FF]
+RenderBlock {DIV} at (10,10) size 202x32 [border: (1px solid #008000)]
Added: trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi.html (0 => 139137)
--- trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi.html 2013-01-09 01:17:19 UTC (rev 139137)
@@ -0,0 +1,32 @@
+!DOCTYPE html
+html
+head
+ style type=text/css
+.box {
+ height: 30px;
+ width: 200px;
+ background-image: -webkit-linear-gradient(black, black);
+ border-radius: 25px;
+ border: 1px solid green;
+}
+ /style
+/head
+script
+window._onload_ = function() {
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.setBackingScaleFactor(2, finishTest);
+}
+}
+
+function finishTest() {
+setTimeout(function() { testRunner.notifyDone(); }, 0);
+}
+/script
+body
+ !-- You should see no red leaking through the inner edge of the border. --
+ div style=background-color: red; padding: 10px; width: 200px
+div class=box/div
+ /div
+/body
+/html
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139136 => 139137)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-09 01:11:32 UTC (rev 139136)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-09 01:17:19 UTC (rev 139137)
@@ -2771,6 +2771,9 @@
# New test added in r85454. Actual failure.
webkit.org/b/91676 fast/js/mozilla/strict/assign-to-callee-name.html [ Failure ]
+# Test needing new baselines with fix for bug 106373
+webkit.org/b/106373 fast/backgrounds/gradient-background-leakage-hidpi.html [ Pass ImageOnlyFailure ]
+
# Failure introduced by Chromium r83848.
crbug.com/137938 [ Mac Android ] fast/url/ipv6.html [ Failure ]
Added:
[webkit-changes] [139144] trunk/Source/WebCore
Title: [139144] trunk/Source/WebCore
Revision 139144
Author ju...@google.com
Date 2013-01-08 18:30:03 -0800 (Tue, 08 Jan 2013)
Log Message
CanvasRenderingContext2D::setFont argument may reference destroyed object
https://bugs.webkit.org/show_bug.cgi?id=106385
Reviewed by Abhishek Arya.
No new tests: covered by fast/canvas/canvas-measureText.html
This is a re-write of r138994. Fixing bug in setFont instead of
workaround at call site.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::accessFont):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (139143 => 139144)
--- trunk/Source/WebCore/ChangeLog 2013-01-09 02:28:26 UTC (rev 139143)
+++ trunk/Source/WebCore/ChangeLog 2013-01-09 02:30:03 UTC (rev 139144)
@@ -1,3 +1,19 @@
+2013-01-08 Justin Novosad ju...@google.com
+
+CanvasRenderingContext2D::setFont argument may reference destroyed object
+https://bugs.webkit.org/show_bug.cgi?id=106385
+
+Reviewed by Abhishek Arya.
+
+No new tests: covered by fast/canvas/canvas-measureText.html
+
+This is a re-write of r138994. Fixing bug in setFont instead of
+workaround at call site.
+
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::CanvasRenderingContext2D::setFont):
+(WebCore::CanvasRenderingContext2D::accessFont):
+
2013-01-08 David Grogan dgro...@chromium.org
IndexedDB: Provide LevelDB with IDBEnv instead of Env::Default
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (139143 => 139144)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2013-01-09 02:28:26 UTC (rev 139143)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2013-01-09 02:30:03 UTC (rev 139144)
@@ -2088,8 +2088,9 @@
return;
// The parse succeeded.
+String newFontSafeCopy(newFont); // Create a string copy since newFont can be deleted inside realizeSaves.
realizeSaves();
-modifiableState().m_unparsedFont = newFont;
+modifiableState().m_unparsedFont = newFontSafeCopy;
// Map the canvas font into the text style. If the font uses keywords like larger/smaller, these will work
// relative to the canvas.
@@ -2373,13 +2374,8 @@
{
canvas()-document()-updateStyleIfNeeded();
-if (!state().m_realizedFont) {
-// Create temporary string object to hold ref count in case
-// state().m_unparsedFont in unreffed by call to realizeSaves in
-// setFont.
-String unparsedFont(state().m_unparsedFont);
-setFont(unparsedFont);
-}
+if (!state().m_realizedFont)
+setFont(state().m_unparsedFont);
return state().m_font;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138994] trunk
Title: [138994] trunk
Revision 138994
Author ju...@google.com
Date 2013-01-07 14:56:02 -0800 (Mon, 07 Jan 2013)
Log Message
Fixing memory read after free in CanvasRenderingContext2D::accessFont
https://bugs.webkit.org/show_bug.cgi?id=106244
Reviewed by Abhishek Arya.
Source/WebCore:
Using a temporary String object to hold ref count on string that is
passed by reference in CanvasRenderingContext2D::accessFont.
Test: fast/canvas/canvas-measureText.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::accessFont):
LayoutTests:
New test case to verify stability of 2D canvas method measureText.
Test case was causing a DumpRenderTree crash on builds with
AddressSantitizer instrumentation.
* fast/canvas/canvas-measureText-expected.txt: Added.
* fast/canvas/canvas-measureText.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Added Paths
trunk/LayoutTests/fast/canvas/canvas-measureText-expected.txt
trunk/LayoutTests/fast/canvas/canvas-measureText.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138993 => 138994)
--- trunk/LayoutTests/ChangeLog 2013-01-07 22:52:17 UTC (rev 138993)
+++ trunk/LayoutTests/ChangeLog 2013-01-07 22:56:02 UTC (rev 138994)
@@ -1,3 +1,17 @@
+2013-01-07 Justin Novosad ju...@google.com
+
+Fixing memory read after free in CanvasRenderingContext2D::accessFont
+https://bugs.webkit.org/show_bug.cgi?id=106244
+
+Reviewed by Abhishek Arya.
+
+New test case to verify stability of 2D canvas method measureText.
+Test case was causing a DumpRenderTree crash on builds with
+AddressSantitizer instrumentation.
+
+* fast/canvas/canvas-measureText-expected.txt: Added.
+* fast/canvas/canvas-measureText.html: Added.
+
2013-01-07 Abhishek Arya infe...@chromium.org
Heap-buffer-overflow in WebCore::RenderBlock::clone.
Added: trunk/LayoutTests/fast/canvas/canvas-measureText-expected.txt (0 => 138994)
--- trunk/LayoutTests/fast/canvas/canvas-measureText-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-measureText-expected.txt 2013-01-07 22:56:02 UTC (rev 138994)
@@ -0,0 +1,5 @@
+Regression test for bug 106244
+
+Test passes by not crashing.
+
+
Added: trunk/LayoutTests/fast/canvas/canvas-measureText.html (0 => 138994)
--- trunk/LayoutTests/fast/canvas/canvas-measureText.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-measureText.html 2013-01-07 22:56:02 UTC (rev 138994)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+html
+body
+pRegression test for bug a href=""
+pTest passes by not crashing./p
+canvas id=test/canvas
+/body
+script
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+var canvas = document.getElementById(test);
+var context = canvas.getContext(2d);
+for (x = 0; x 100; x++) {
+ context.restore();
+ context.save();
+ context.save();
+ context.measureText(a, 0, 0, 0);
+}
+/script
+/html
Modified: trunk/Source/WebCore/ChangeLog (138993 => 138994)
--- trunk/Source/WebCore/ChangeLog 2013-01-07 22:52:17 UTC (rev 138993)
+++ trunk/Source/WebCore/ChangeLog 2013-01-07 22:56:02 UTC (rev 138994)
@@ -1,3 +1,18 @@
+2013-01-07 Justin Novosad ju...@google.com
+
+Fixing memory read after free in CanvasRenderingContext2D::accessFont
+https://bugs.webkit.org/show_bug.cgi?id=106244
+
+Reviewed by Abhishek Arya.
+
+Using a temporary String object to hold ref count on string that is
+passed by reference in CanvasRenderingContext2D::accessFont.
+
+Test: fast/canvas/canvas-measureText.html
+
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::CanvasRenderingContext2D::accessFont):
+
2013-01-07 Anders Carlsson ander...@apple.com
DOMEvents.h should include DOMProgressEvent.h
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (138993 => 138994)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2013-01-07 22:52:17 UTC (rev 138993)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2013-01-07 22:56:02 UTC (rev 138994)
@@ -2373,8 +2373,13 @@
{
canvas()-document()-updateStyleIfNeeded();
-if (!state().m_realizedFont)
-setFont(state().m_unparsedFont);
+if (!state().m_realizedFont) {
+// Create temporary string object to hold ref count in case
+// state().m_unparsedFont in unreffed by call to realizeSaves in
+// setFont.
+String unparsedFont(state().m_unparsedFont);
+setFont(unparsedFont);
+}
return state().m_font;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137473] trunk
Title: [137473] trunk Revision 137473 Author ju...@google.com Date 2012-12-12 09:11:37 -0800 (Wed, 12 Dec 2012) Log Message Use render box background over border draw strategy in cases with background-image https://bugs.webkit.org/show_bug.cgi?id=103409 Reviewed by Simon Fraser. Source/WebCore: The BackgroundOverBorderBleedAvoidance mode was not being used in cases where the background is an opaque image. It was also not being used in cases with multiple layers. The multiple layer case is now safe with respect to color bleeding if the top layer is opaque, thank to the recent addition of layer occlusion culling in r135629. No new tests. Testing already covered by the following tests: fast/backgrounds/background-opaque-images-over-color.html fast/backgrounds/gradient-background-leakage-2.html * rendering/RenderBox.cpp: (WebCore::RenderBox::determineBackgroundBleedAvoidance): (WebCore::RenderBox::backgroundHasOpaqueTopLayer): * rendering/RenderBox.h: (RenderBox): LayoutTests: Added image failure expectation for fast/backgrounds/gradient-background-leakage-2.html which needs new baselines. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h Diff Modified: trunk/LayoutTests/ChangeLog (137472 => 137473) --- trunk/LayoutTests/ChangeLog 2012-12-12 16:52:35 UTC (rev 137472) +++ trunk/LayoutTests/ChangeLog 2012-12-12 17:11:37 UTC (rev 137473) @@ -1,3 +1,16 @@ +2012-12-12 Justin Novosad ju...@google.com + +Use render box background over border draw strategy in cases with background-image +https://bugs.webkit.org/show_bug.cgi?id=103409 + +Reviewed by Simon Fraser. + +Added image failure expectation for +fast/backgrounds/gradient-background-leakage-2.html which needs +new baselines. + +* platform/chromium/TestExpectations: + 2012-12-12 Philippe Normand pnorm...@igalia.com Unreviewed, GTK gardening. Flag some flaky media tests after r137271. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137472 => 137473) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-12 16:52:35 UTC (rev 137472) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-12 17:11:37 UTC (rev 137473) @@ -2142,6 +2142,9 @@ crbug.com/43890 [ Win ] http/tests/loading/basic.html [ Failure Pass ] +# Test need new image baselines with fix for webkit.org/b/103409 +webkit.org/b/103409 fast/backgrounds/gradient-background-leakage-2.html [ ImageOnlyFailure Pass ] + # The following tests fail on all platforms and need further investigation. # Many of these are skipped on the Mac platform webkit.org/b/45991 canvas/philip/tests/2d.drawImage.broken.html [ Failure ] Modified: trunk/Source/WebCore/ChangeLog (137472 => 137473) --- trunk/Source/WebCore/ChangeLog 2012-12-12 16:52:35 UTC (rev 137472) +++ trunk/Source/WebCore/ChangeLog 2012-12-12 17:11:37 UTC (rev 137473) @@ -1,3 +1,27 @@ +2012-12-12 Justin Novosad ju...@google.com + +Use render box background over border draw strategy in cases with background-image +https://bugs.webkit.org/show_bug.cgi?id=103409 + +Reviewed by Simon Fraser. + +The BackgroundOverBorderBleedAvoidance mode was not being used in +cases where the background is an opaque image. It was also not +being used in cases with multiple layers. The multiple layer +case is now safe with respect to color bleeding if the top layer +is opaque, thank to the recent addition of layer occlusion culling +in r135629. + +No new tests. Testing already covered by the following tests: +fast/backgrounds/background-opaque-images-over-color.html +fast/backgrounds/gradient-background-leakage-2.html + +* rendering/RenderBox.cpp: +(WebCore::RenderBox::determineBackgroundBleedAvoidance): +(WebCore::RenderBox::backgroundHasOpaqueTopLayer): +* rendering/RenderBox.h: +(RenderBox): + 2012-12-12 Ilya Tikhonovsky loi...@chromium.org Web Inspector: instrument static parts of RenderBlock and RenderBox Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (137472 => 137473) --- trunk/Source/WebCore/rendering/RenderBox.cpp 2012-12-12 16:52:35 UTC (rev 137472) +++ trunk/Source/WebCore/rendering/RenderBox.cpp 2012-12-12 17:11:37 UTC (rev 137473) @@ -888,7 +888,7 @@ FloatSize contextScaling(static_castfloat(ctm.xScale()), static_castfloat(ctm.yScale())); if (borderObscuresBackgroundEdge(contextScaling)) return BackgroundBleedShrinkBackground; -if (!style-hasAppearance() borderObscuresBackground() backgroundIsSingleOpaqueLayer()) +if (!style-hasAppearance() borderObscuresBackground() backgroundHasOpaqueTopLayer()) return
[webkit-changes] [137503] trunk/LayoutTests
Title: [137503] trunk/LayoutTests Revision 137503 Author ju...@google.com Date 2012-12-12 12:55:10 -0800 (Wed, 12 Dec 2012) Log Message calendar-picker tests have image diffs on cr-mac after r137473 https://bugs.webkit.org/show_bug.cgi?id=104825 Unreviewed * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png: * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: * platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png: * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png: * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png
[webkit-changes] [137504] trunk/LayoutTests
Title: [137504] trunk/LayoutTests Revision 137504 Author ju...@google.com Date 2012-12-12 13:07:12 -0800 (Wed, 12 Dec 2012) Log Message Rebaselining fast/backgrounds/gradient-background-leakage-2-expected.html after r137473 https://bugs.webkit.org/show_bug.cgi?id=103409 Unreviewed * platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png: * platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png: * platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png trunk/LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (137503 => 137504) --- trunk/LayoutTests/ChangeLog 2012-12-12 20:55:10 UTC (rev 137503) +++ trunk/LayoutTests/ChangeLog 2012-12-12 21:07:12 UTC (rev 137504) @@ -1,5 +1,17 @@ 2012-12-12 Justin Novosad ju...@google.com +Rebaselining fast/backgrounds/gradient-background-leakage-2-expected.html after r137473 +https://bugs.webkit.org/show_bug.cgi?id=103409 + +Unreviewed + +* platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png: +* platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png: +* platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png: +* platform/chromium/TestExpectations: + +2012-12-12 Justin Novosad ju...@google.com + calendar-picker tests have image diffs on cr-mac after r137473 https://bugs.webkit.org/show_bug.cgi?id=104825 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137503 => 137504) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-12 20:55:10 UTC (rev 137503) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-12 21:07:12 UTC (rev 137504) @@ -2142,9 +2142,6 @@ crbug.com/43890 [ Win ] http/tests/loading/basic.html [ Failure Pass ] -# Test need new image baselines with fix for webkit.org/b/103409 -webkit.org/b/103409 fast/backgrounds/gradient-background-leakage-2.html [ ImageOnlyFailure Pass ] - # The following tests fail on all platforms and need further investigation. # Many of these are skipped on the Mac platform webkit.org/b/45991 canvas/philip/tests/2d.drawImage.broken.html [ Failure ] Modified: trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137506] trunk/Tools
Title: [137506] trunk/Tools Revision 137506 Author ju...@google.com Date 2012-12-12 13:16:38 -0800 (Wed, 12 Dec 2012) Log Message Adding myself to SkiaGraphics watchlist Unreviewed * Scripts/webkitpy/common/config/watchlist: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/watchlist Diff Modified: trunk/Tools/ChangeLog (137505 => 137506) --- trunk/Tools/ChangeLog 2012-12-12 21:11:41 UTC (rev 137505) +++ trunk/Tools/ChangeLog 2012-12-12 21:16:38 UTC (rev 137506) @@ -1,3 +1,11 @@ +2012-12-12 Justin Novosad ju...@google.com + +Adding myself to SkiaGraphics watchlist + +Unreviewed + +* Scripts/webkitpy/common/config/watchlist: + 2012-12-12 Martin Robinson mrobin...@igalia.com [GTK] Add authentication support to DRT and fix exposed issues in the libsoup backend Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (137505 => 137506) --- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2012-12-12 21:11:41 UTC (rev 137505) +++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2012-12-12 21:16:38 UTC (rev 137506) @@ -358,7 +358,7 @@ SVNScripts: [ dba...@webkit.org ], ScrollingCoordinator: [ ander...@apple.com, jam...@chromium.org, toniki...@webkit.org ], SecurityCritical: [ aba...@webkit.org ], -SkiaGraphics: [ senorbla...@chromium.org ], +SkiaGraphics: [ senorbla...@chromium.org, ju...@google.com ], Selectors: [ allan.jen...@digia.com ], SoupNetwork: [ rak...@webkit.org, g...@gnome.org, mrobin...@webkit.org, d...@gnome.org ], StyleChecker: [ le...@chromium.org, ], ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136867] trunk/LayoutTests
Title: [136867] trunk/LayoutTests Revision 136867 Author ju...@google.com Date 2012-12-06 11:54:39 -0800 (Thu, 06 Dec 2012) Log Message New pixel baselines for fast/backgrounds/gradient-background-leakage.html https://bugs.webkit.org/show_bug.cgi?id=103896 Unreviewed * platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png: * platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png: * platform/chromium/TestExpectations: * platform/efl-wk1/fast/backgrounds: Added. * platform/efl-wk1/fast/backgrounds/gradient-background-leakage-expected.png: Added. * platform/efl/fast/backgrounds/gradient-background-leakage-expected.png: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png Added Paths trunk/LayoutTests/platform/efl-wk1/fast/backgrounds/ trunk/LayoutTests/platform/efl-wk1/fast/backgrounds/gradient-background-leakage-expected.png Removed Paths trunk/LayoutTests/platform/efl/fast/backgrounds/gradient-background-leakage-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (136866 => 136867) --- trunk/LayoutTests/ChangeLog 2012-12-06 19:48:25 UTC (rev 136866) +++ trunk/LayoutTests/ChangeLog 2012-12-06 19:54:39 UTC (rev 136867) @@ -1,3 +1,17 @@ +2012-12-06 Justin Novosad ju...@google.com + +New pixel baselines for fast/backgrounds/gradient-background-leakage.html +https://bugs.webkit.org/show_bug.cgi?id=103896 + +Unreviewed + +* platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png: +* platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png: +* platform/chromium/TestExpectations: +* platform/efl-wk1/fast/backgrounds: Added. +* platform/efl-wk1/fast/backgrounds/gradient-background-leakage-expected.png: Added. +* platform/efl/fast/backgrounds/gradient-background-leakage-expected.png: Removed. + 2012-12-06 Yael Aharon yael.aha...@intel.com Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (136866 => 136867) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-06 19:48:25 UTC (rev 136866) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-06 19:54:39 UTC (rev 136867) @@ -2185,9 +2185,6 @@ crbug.com/43890 [ Win ] http/tests/loading/basic.html [ Failure Pass ] -# Test requires ne baseline after fixing webkit.org/b/103896 -webkit.org/b/103896 fast/backgrounds/gradient-background-leakage.html [ Pass ImageOnlyFailure ] - # The following tests fail on all platforms and need further investigation. # Many of these are skipped on the Mac platform webkit.org/b/45991 canvas/philip/tests/2d.drawImage.broken.html [ Failure ] Modified: trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png (Binary files differ) Deleted: trunk/LayoutTests/platform/efl/fast/backgrounds/gradient-background-leakage-expected.png (Binary files differ) Added: trunk/LayoutTests/platform/efl-wk1/fast/backgrounds/gradient-background-leakage-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/efl-wk1/fast/backgrounds/gradient-background-leakage-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136742] trunk/Source/WebCore
Title: [136742] trunk/Source/WebCore Revision 136742 Author ju...@google.com Date 2012-12-05 12:53:24 -0800 (Wed, 05 Dec 2012) Log Message Use of uninitialized variable in WebCore::RenderBox::paintFillLayers https://bugs.webkit.org/show_bug.cgi?id=104154 Reviewed by Stephen White. Method FillLayer::clipOccludesNextLayers performs an internal initialization when called on the first layer of a list of layers. Without this initialization, calls to clipOccludesNextLayers on subsequent layers will use uninitialized data. In some cases, the call to clipOccludesNextLayers was being short-circuited in RenderBox::paintFillLayers. Fix: Predicate was permuted to ensure that clipOccludesNextLayers is never short-circuited. Test: fast/backgrounds/size/contain-and-cover-zoomed.html Running with valgrind reveals the error. * rendering/RenderBox.cpp: (WebCore::RenderBox::paintFillLayers): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBox.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (136741 => 136742) --- trunk/Source/WebCore/ChangeLog 2012-12-05 20:49:21 UTC (rev 136741) +++ trunk/Source/WebCore/ChangeLog 2012-12-05 20:53:24 UTC (rev 136742) @@ -1,3 +1,25 @@ +2012-12-05 Justin Novosad ju...@google.com + +Use of uninitialized variable in WebCore::RenderBox::paintFillLayers +https://bugs.webkit.org/show_bug.cgi?id=104154 + +Reviewed by Stephen White. + +Method FillLayer::clipOccludesNextLayers performs an internal +initialization when called on the first layer of a list of layers. +Without this initialization, calls to clipOccludesNextLayers on +subsequent layers will use uninitialized data. In some cases, the +call to clipOccludesNextLayers was being short-circuited in +RenderBox::paintFillLayers. +Fix: Predicate was permuted to ensure that clipOccludesNextLayers +is never short-circuited. + +Test: fast/backgrounds/size/contain-and-cover-zoomed.html +Running with valgrind reveals the error. + +* rendering/RenderBox.cpp: +(WebCore::RenderBox::paintFillLayers): + 2012-12-05 Elliott Sprehn espr...@gmail.com Encapsulate ElementRareData for possible future sharing Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (136741 => 136742) --- trunk/Source/WebCore/rendering/RenderBox.cpp 2012-12-05 20:49:21 UTC (rev 136741) +++ trunk/Source/WebCore/rendering/RenderBox.cpp 2012-12-05 20:53:24 UTC (rev 136742) @@ -1056,10 +1056,12 @@ // FIXME : It would be possible for the following occlusion culling test to be more aggressive // on layers with no repeat by testing whether the image covers the layout rect. // Testing that here would imply duplicating a lot of calculations that are currently done in -// RenderBoxModelOBject::paintFillLayerExtended. A more efficient solution might be to move +// RenderBoxModelObject::paintFillLayerExtended. A more efficient solution might be to move // the layer recursion into paintFillLayerExtended, or to compute the layer geometry here // and pass it down. -if (curLayer-hasOpaqueImage(this) curLayer-clipOccludesNextLayers(curLayer == fillLayer) curLayer-image()-canRender(this, style()-effectiveZoom()) curLayer-hasRepeatXY()) + +// The clipOccludesNextLayers condition must be evaluated first to avoid short-circuiting. +if (curLayer-clipOccludesNextLayers(curLayer == fillLayer) curLayer-hasOpaqueImage(this) curLayer-image()-canRender(this, style()-effectiveZoom()) curLayer-hasRepeatXY()) break; curLayer = curLayer-next(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136755] trunk
Title: [136755] trunk Revision 136755 Author ju...@google.com Date 2012-12-05 13:40:26 -0800 (Wed, 05 Dec 2012) Log Message [skia] Improve performance of GraphicsContext::createCompatibleBuffer by using SkDevice:createCompatibleDevice https://bugs.webkit.org/show_bug.cgi?id=103896 Reviewed by Stephen White. Source/WebCore: Refactored GraphicsContext::createCompatibleBuffer (platform common code) to use platform-specific implementations provided by ImageBuffer. There is no change in behavior for non-skia ports. The skia implementation uses skia'a own createCompatibleDevice implementation, which offers several performance benefits: 1. For accelerated contexts, the backing store may be allocated from the scratch texture pool, which minimizes texture allocation and deallocation overhead. 2. The backing store will not be initially cleared if it is known in advance that fully opaque contents will be drawn into the buffer. 3. For non-accelerated contexts, if the backing store is flagged as opaque, faster blitter loop implementations will be used for drawing the buffer contents into other buffers. (e.g. generated opaque gradient fills) No new tests: covered by existing layout tests * platform/graphics/Generator.h: (Generator): Added hasAlpha method so that it can be used by GeneratorGeneratedImage * platform/graphics/GeneratorGeneratedImage.cpp: (WebCore::GeneratorGeneratedImage::drawPattern): Passing m_generator-hasAlpha() to createCompatibleBuffer in order to take advantage of optimizations that apply to opaque buffers. * platform/graphics/Gradient.h: (Gradient): Made hasAlpha virtual so that it now overrides Generator::hasAlpha * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::createCompatibleBuffer): Refactored to use platform-specific implementation * platform/graphics/GraphicsContext.h: * platform/graphics/ImageBuffer.cpp: (WebCore::createCompatibleBuffer): Non-skia implementation. Mimics old GraphicsContext::createCompatibleBuffer * platform/graphics/ImageBuffer.h: (ImageBuffer): New skia-specific constructor * platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::createCompatibleBuffer): (WebCore::ImageBuffer::ImageBuffer): * platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::createCompatibleDevice): (WebCore): * platform/graphics/skia/PlatformContextSkia.h: (PlatformContextSkia): LayoutTests: Added image failure expectation for test needing new baselines * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/Generator.h trunk/Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp trunk/Source/WebCore/platform/graphics/Gradient.h trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp trunk/Source/WebCore/platform/graphics/GraphicsContext.h trunk/Source/WebCore/platform/graphics/ImageBuffer.cpp trunk/Source/WebCore/platform/graphics/ImageBuffer.h trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h Diff Modified: trunk/LayoutTests/ChangeLog (136754 => 136755) --- trunk/LayoutTests/ChangeLog 2012-12-05 21:38:52 UTC (rev 136754) +++ trunk/LayoutTests/ChangeLog 2012-12-05 21:40:26 UTC (rev 136755) @@ -1,3 +1,14 @@ +2012-12-05 Justin Novosad ju...@google.com + +[skia] Improve performance of GraphicsContext::createCompatibleBuffer by using SkDevice:createCompatibleDevice +https://bugs.webkit.org/show_bug.cgi?id=103896 + +Reviewed by Stephen White. + +Added image failure expectation for test needing new baselines + +* platform/chromium/TestExpectations: + 2012-12-05 Stephen White senorbla...@chromium.org [Chromium] Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (136754 => 136755) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-05 21:38:52 UTC (rev 136754) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-05 21:40:26 UTC (rev 136755) @@ -2188,6 +2188,9 @@ crbug.com/43890 [ Win ] http/tests/loading/basic.html [ Failure Pass ] +# Test requires ne baseline after fixing webkit.org/b/103896 +webkit.org/b/103896 fast/backgrounds/gradient-background-leakage.html [ Pass ImageOnlyFailure ] + # The following tests fail on all platforms and need further investigation. # Many of these are skipped on the Mac platform webkit.org/b/45991 canvas/philip/tests/2d.drawImage.broken.html [ Failure ] Modified: trunk/Source/WebCore/ChangeLog (136754 => 136755) --- trunk/Source/WebCore/ChangeLog 2012-12-05 21:38:52 UTC (rev 136754) +++ trunk/Source/WebCore/ChangeLog 2012-12-05 21:40:26 UTC (rev 136755) @@ -1,3 +1,57 @@ +2012-12-05 Justin Novosad ju...@google.com + +[skia] Improve performance of
[webkit-changes] [136326] trunk
Title: [136326] trunk
Revision 136326
Author ju...@google.com
Date 2012-12-02 02:55:24 -0800 (Sun, 02 Dec 2012)
Log Message
Fix occlusion culling logic to handle css background layer clipping
https://bugs.webkit.org/show_bug.cgi?id=103276
Reviewed by Simon Fraser.
Source/WebCore:
Bug was introduced by r135629
This patch fixes it by verifying layer clip. A fill layer must
not be treated as if it occludes the layers under it unless it has
a larger or equal clip setting than the layers under it.
Test: fast/backgrounds/background-opaque-clipped-gradients.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
* rendering/style/FillLayer.cpp:
(WebCore::clipMax):
(WebCore::FillLayer::computeClipMax):
(WebCore::FillLayer::clipOccludesNextLayers):
* rendering/style/FillLayer.h:
(FillLayer):
LayoutTests:
New ref test that verifies the superposition of background layers with
the layers having smaller clip regions than the layers beneath them.
This test ensures the bottom layers are not removed by culling
optimizations.
* fast/backgrounds/background-opaque-clipped-gradients-expected.html: Added.
* fast/backgrounds/background-opaque-clipped-gradients.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/style/FillLayer.cpp
trunk/Source/WebCore/rendering/style/FillLayer.h
Added Paths
trunk/LayoutTests/fast/backgrounds/background-opaque-clipped-gradients-expected.html
trunk/LayoutTests/fast/backgrounds/background-opaque-clipped-gradients.html
Diff
Modified: trunk/LayoutTests/ChangeLog (136325 => 136326)
--- trunk/LayoutTests/ChangeLog 2012-12-02 10:42:17 UTC (rev 136325)
+++ trunk/LayoutTests/ChangeLog 2012-12-02 10:55:24 UTC (rev 136326)
@@ -1,3 +1,18 @@
+2012-12-02 Justin Novosad ju...@google.com
+
+Fix occlusion culling logic to handle css background layer clipping
+https://bugs.webkit.org/show_bug.cgi?id=103276
+
+Reviewed by Simon Fraser.
+
+New ref test that verifies the superposition of background layers with
+the layers having smaller clip regions than the layers beneath them.
+This test ensures the bottom layers are not removed by culling
+optimizations.
+
+* fast/backgrounds/background-opaque-clipped-gradients-expected.html: Added.
+* fast/backgrounds/background-opaque-clipped-gradients.html: Added.
+
2012-12-02 Tony Chang t...@chromium.org
Avoid a second layout of flex items in layoutAndPlaceChildren()
Added: trunk/LayoutTests/fast/backgrounds/background-opaque-clipped-gradients-expected.html (0 => 136326)
--- trunk/LayoutTests/fast/backgrounds/background-opaque-clipped-gradients-expected.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/background-opaque-clipped-gradients-expected.html 2012-12-02 10:55:24 UTC (rev 136326)
@@ -0,0 +1,31 @@
+!doctype html
+html
+head
+style type=text/css media=screen
+#div1
+{
+width: 150px;
+height: 150px;
+border:25px dotted;
+background-color: green;
+}
+#div2
+{
+width: 100px;
+height: 100px;
+padding: 25px;
+background-color: blue;
+}
+#div3
+{
+width: 100px;
+height: 100px;
+background-color: yellow;
+}
+/style
+/head
+body
+Test passes if the image below shows nested green, blue and yellow squares with a dotted black border.
+div id=div1div id=div2div id=div3/div/div/div
+/body
+/html
Added: trunk/LayoutTests/fast/backgrounds/background-opaque-clipped-gradients.html (0 => 136326)
--- trunk/LayoutTests/fast/backgrounds/background-opaque-clipped-gradients.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/background-opaque-clipped-gradients.html 2012-12-02 10:55:24 UTC (rev 136326)
@@ -0,0 +1,19 @@
+!doctype html
+html
+head
+style type=text/css media=screen
+#div1 {
+width: 100px;
+height: 100px;
+padding: 25px;
+border: 25px dotted;
+background-image: -webkit-linear-gradient(top, yellow, yellow), -webkit-linear-gradient(top, blue, blue), -webkit-linear-gradient(top, green, green);
+background-clip: content-box, padding-box, border-box;
+}
+/style
+/head
+body
+Test passes if the image below shows nested green, blue and yellow squares with a dotted black border.
+div id=div1/div
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (136325 => 136326)
--- trunk/Source/WebCore/ChangeLog 2012-12-02 10:42:17 UTC (rev 136325)
+++ trunk/Source/WebCore/ChangeLog 2012-12-02 10:55:24 UTC (rev 136326)
@@ -1,3 +1,26 @@
+2012-12-02 Justin Novosad ju...@google.com
+
+Fix occlusion culling logic to handle css background layer clipping
+https://bugs.webkit.org/show_bug.cgi?id=103276
+
+Reviewed by Simon Fraser.
+
+Bug was introduced by r135629
+This patch fixes it by verifying layer clip. A fill layer must
+not be treated as if it occludes the layers under it unless it has
+a
[webkit-changes] [136262] trunk
Title: [136262] trunk
Revision 136262
Author ju...@google.com
Date 2012-11-30 13:11:31 -0800 (Fri, 30 Nov 2012)
Log Message
[Chromium] Animation updates fail when using a canvas as a CSS backround-image style with -webkit-canvas
https://bugs.webkit.org/show_bug.cgi?id=103643
Reviewed by Stephen White.
.:
New test to verify that elements using a canvas as a style image
source are redrawn when the canvas is animated. Added as a manual test
because the bug was not reproducible in DumpRenderTree.
* ManualTests/animated-canvas-as-background.html: Added.
Source/WebCore:
CanvasRenderingContext2D::didDraw was not propagating the change
notification to observers in the accelerated compositing case.
Problem fixed by adding observer notifications.
New manual test: animated-canvas-as-background.html
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::didDraw):
The observer notification was factored out into a separate method
so that it can be invoked directly for accelerated compositing.
(WebCore):
(WebCore::HTMLCanvasElement::notifyObserversCanvasChanged):
* html/HTMLCanvasElement.h:
(HTMLCanvasElement):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::didDraw):
Added observer notification call to trigger repainting of elements that
use this canvas for their style.
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCanvasElement.cpp
trunk/Source/WebCore/html/HTMLCanvasElement.h
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Added Paths
trunk/ManualTests/animated-canvas-as-background.html
Diff
Modified: trunk/ChangeLog (136261 => 136262)
--- trunk/ChangeLog 2012-11-30 21:09:21 UTC (rev 136261)
+++ trunk/ChangeLog 2012-11-30 21:11:31 UTC (rev 136262)
@@ -1,3 +1,16 @@
+2012-11-30 Justin Novosad ju...@google.com
+
+[Chromium] Animation updates fail when using a canvas as a CSS backround-image style with -webkit-canvas
+https://bugs.webkit.org/show_bug.cgi?id=103643
+
+Reviewed by Stephen White.
+
+New test to verify that elements using a canvas as a style image
+source are redrawn when the canvas is animated. Added as a manual test
+because the bug was not reproducible in DumpRenderTree.
+
+* ManualTests/animated-canvas-as-background.html: Added.
+
2012-11-30 Pierre Rossi pierre.ro...@gmail.com
[Qt] Unreviewed build break
Added: trunk/ManualTests/animated-canvas-as-background.html (0 => 136262)
--- trunk/ManualTests/animated-canvas-as-background.html (rev 0)
+++ trunk/ManualTests/animated-canvas-as-background.html 2012-11-30 21:11:31 UTC (rev 136262)
@@ -0,0 +1,42 @@
+!DOCTYPE html
+html
+head
+style
+#container {
+width: 300px;
+height: 300px;
+background-image: -webkit-canvas(sourceCanvas);
+background-size: 100%;
+display: inline-block;
+}
+/style
+/head
+body
+pThis test passes if two green squares are displayed below./p
+div
+div style=display: inline-block
+div id=container/div
+/div
+div id=canvas-container style=display: inline-block/div
+/div
+script
+var ctx = document.getCSSCanvasContext('2d', 'sourceCanvas', 300, 300);
+var canvas = ctx.canvas;
+
+function asyncDraw2() {
+ctx.fillStyle = green;
+ctx.fillRect(0, 0, 300, 300);
+}
+
+function asyncDraw1() {
+ctx.fillStyle = red;
+ctx.fillRect(0, 0, 300, 300);
+window.webkitRequestAnimationFrame(asyncDraw2);
+}
+
+window.webkitRequestAnimationFrame(asyncDraw1);
+
+document.querySelector('#canvas-container').appendChild(canvas);
+/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (136261 => 136262)
--- trunk/Source/WebCore/ChangeLog 2012-11-30 21:09:21 UTC (rev 136261)
+++ trunk/Source/WebCore/ChangeLog 2012-11-30 21:11:31 UTC (rev 136262)
@@ -1,3 +1,29 @@
+2012-11-30 Justin Novosad ju...@google.com
+
+[Chromium] Animation updates fail when using a canvas as a CSS backround-image style with -webkit-canvas
+https://bugs.webkit.org/show_bug.cgi?id=103643
+
+Reviewed by Stephen White.
+
+CanvasRenderingContext2D::didDraw was not propagating the change
+notification to observers in the accelerated compositing case.
+Problem fixed by adding observer notifications.
+
+New manual test: animated-canvas-as-background.html
+
+* html/HTMLCanvasElement.cpp:
+(WebCore::HTMLCanvasElement::didDraw):
+The observer notification was factored out into a separate method
+so that it can be invoked directly for accelerated compositing.
+(WebCore):
+(WebCore::HTMLCanvasElement::notifyObserversCanvasChanged):
+* html/HTMLCanvasElement.h:
+(HTMLCanvasElement):
+* html/canvas/CanvasRenderingContext2D.cpp:
+
[webkit-changes] [135859] trunk/LayoutTests
Title: [135859] trunk/LayoutTests
Revision 135859
Author ju...@google.com
Date 2012-11-27 06:56:51 -0800 (Tue, 27 Nov 2012)
Log Message
Convert test fast/backgrounds/background-opaque-images-over-color.html to a ref test
https://bugs.webkit.org/show_bug.cgi?id=103275
Reviewed by Simon Fraser
Removing existing baselines, and adding an -expecte.html to make
fast/backgrounds/background-opaque-images-over-color.html a ref test
* fast/backgrounds/background-opaque-images-over-color-expected.html: Added.
* fast/backgrounds/background-opaque-images-over-color-expected.txt: Removed.
* fast/backgrounds/background-opaque-images-over-color.html:
* platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/background-opaque-images-over-color-expected.png: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color.html
Added Paths
trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.html
Removed Paths
trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png
trunk/LayoutTests/platform/chromium-win/fast/backgrounds/background-opaque-images-over-color-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (135858 => 135859)
--- trunk/LayoutTests/ChangeLog 2012-11-27 14:42:46 UTC (rev 135858)
+++ trunk/LayoutTests/ChangeLog 2012-11-27 14:56:51 UTC (rev 135859)
@@ -1,3 +1,19 @@
+2012-11-27 Justin Novosad ju...@google.com
+
+Convert test fast/backgrounds/background-opaque-images-over-color.html to a ref test
+https://bugs.webkit.org/show_bug.cgi?id=103275
+
+Reviewed by Simon Fraser
+
+Removing existing baselines, and adding an -expecte.html to make
+fast/backgrounds/background-opaque-images-over-color.html a ref test
+
+* fast/backgrounds/background-opaque-images-over-color-expected.html: Added.
+* fast/backgrounds/background-opaque-images-over-color-expected.txt: Removed.
+* fast/backgrounds/background-opaque-images-over-color.html:
+* platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png: Removed.
+* platform/chromium-win/fast/backgrounds/background-opaque-images-over-color-expected.png: Removed.
+
2012-11-27 Jussi Kukkonen jussi.kukko...@intel.com
[EFL] Mark tests flaky
Added: trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.html (0 => 135859)
--- trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.html 2012-11-27 14:56:51 UTC (rev 135859)
@@ -0,0 +1,17 @@
+!doctype html
+html
+head
+style type=text/css media=screen
+ #greenBox {
+width:400px;
+height:100px;
+display:block;
+background-color: green;
+float: left;
+}
+/style
+/head
+body
+div id=greenBox/div
+/body
+/html
Deleted: trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt (135858 => 135859)
--- trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt 2012-11-27 14:42:46 UTC (rev 135858)
+++ trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt 2012-11-27 14:56:51 UTC (rev 135859)
@@ -1,27 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x108
- RenderBlock {HTML} at (0,0) size 800x108
-RenderBody {BODY} at (8,8) size 784x0
- RenderBlock {DIV} at (0,0) size 784x0
-RenderBlock (floating) {DIV} at (0,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (20,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (40,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (60,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (80,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (100,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (120,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (140,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (160,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (180,0) size 20x100 [bgcolor=#FF]
- RenderBlock {DIV} at (0,0) size 784x0
-RenderBlock (floating) {DIV} at (200,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (220,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (240,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (260,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (280,0)
[webkit-changes] [135861] trunk/LayoutTests
Title: [135861] trunk/LayoutTests
Revision 135861
Author ju...@google.com
Date 2012-11-27 07:45:56 -0800 (Tue, 27 Nov 2012)
Log Message
Correcting baseline for fast/backgrounds/background-opaque-images-over-color.html
https://bugs.webkit.org/show_bug.cgi?id=103275
Unreviewed
Fixing small error in ref test baseline.
* fast/backgrounds/background-opaque-images-over-color-expected.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.html
Diff
Modified: trunk/LayoutTests/ChangeLog (135860 => 135861)
--- trunk/LayoutTests/ChangeLog 2012-11-27 15:06:14 UTC (rev 135860)
+++ trunk/LayoutTests/ChangeLog 2012-11-27 15:45:56 UTC (rev 135861)
@@ -1,5 +1,16 @@
2012-11-27 Justin Novosad ju...@google.com
+Correcting baseline for fast/backgrounds/background-opaque-images-over-color.html
+https://bugs.webkit.org/show_bug.cgi?id=103275
+
+Unreviewed
+
+Fixing small error in ref test baseline.
+
+* fast/backgrounds/background-opaque-images-over-color-expected.html:
+
+2012-11-27 Justin Novosad ju...@google.com
+
Convert test fast/backgrounds/background-opaque-images-over-color.html to a ref test
https://bugs.webkit.org/show_bug.cgi?id=103275
Modified: trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.html (135860 => 135861)
--- trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.html 2012-11-27 15:06:14 UTC (rev 135860)
+++ trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.html 2012-11-27 15:45:56 UTC (rev 135861)
@@ -3,7 +3,7 @@
head
style type=text/css media=screen
#greenBox {
-width:400px;
+width:200px;
height:100px;
display:block;
background-color: green;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135873] trunk/LayoutTests
Title: [135873] trunk/LayoutTests Revision 135873 Author ju...@google.com Date 2012-11-27 10:11:29 -0800 (Tue, 27 Nov 2012) Log Message Skipping fast/backgrounds/background-opaque-images-over-color.html on mac https://bugs.webkit.org/show_bug.cgi?id=103435 Unreviewed * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135872 => 135873) --- trunk/LayoutTests/ChangeLog 2012-11-27 18:00:58 UTC (rev 135872) +++ trunk/LayoutTests/ChangeLog 2012-11-27 18:11:29 UTC (rev 135873) @@ -1,3 +1,12 @@ +2012-11-27 Justin Novosad ju...@google.com + +Skipping fast/backgrounds/background-opaque-images-over-color.html on mac +https://bugs.webkit.org/show_bug.cgi?id=103435 + +Unreviewed + +* platform/mac/TestExpectations: + 2012-11-27 Marja Hölttä ma...@chromium.org Add callbacks to the FrameLoaderClient when a resource is requested Modified: trunk/LayoutTests/platform/mac/TestExpectations (135872 => 135873) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-11-27 18:00:58 UTC (rev 135872) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-11-27 18:11:29 UTC (rev 135873) @@ -363,6 +363,9 @@ # https://bugs.webkit.org/show_bug.cgi?id=55944 fast/dom/Geolocation/page-reload-cancel-permission-requests.html +# https://bugs.webkit.org/show_bug.cgi?id=103435 +fast/backgrounds/background-opaque-images-over-color.html + # https://bugs.webkit.org/show_bug.cgi?id=56685 webarchive/test-link-rel-icon.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135725] trunk/LayoutTests
Title: [135725] trunk/LayoutTests Revision 135725 Author ju...@google.com Date 2012-11-26 07:51:38 -0800 (Mon, 26 Nov 2012) Log Message New baselines for test fast/backgrounds/gradient-background-leakage-2.html https://bugs.webkit.org/show_bug.cgi?id=103089 Unreviewed * platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. * platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. * platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Added Paths trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png trunk/LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (135724 => 135725) --- trunk/LayoutTests/ChangeLog 2012-11-26 15:47:01 UTC (rev 135724) +++ trunk/LayoutTests/ChangeLog 2012-11-26 15:51:38 UTC (rev 135725) @@ -1,3 +1,15 @@ +2012-11-26 Justin Novosad ju...@google.com + +New baselines for test fast/backgrounds/gradient-background-leakage-2.html +https://bugs.webkit.org/show_bug.cgi?id=103089 + +Unreviewed + +* platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. +* platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. +* platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. +* platform/chromium/TestExpectations: + 2012-11-26 Mike West mk...@chromium.org Web Inspector: URLs containing '^' are improperly linked in console messages. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135724 => 135725) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 15:47:01 UTC (rev 135724) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 15:51:38 UTC (rev 135725) @@ -2163,9 +2163,6 @@ crbug.com/117597 svg/batik/filters/feTile.svg [ ImageOnlyFailure ] -# Test needing new baselines -webkit.org/b/103089 fast/backgrounds/gradient-background-leakage-2.html [ Pass Missing ImageOnlyFailure Failure ] - # Caused by http://trac.webkit.org/changeset/56394. crbug.com/143475 [ Win ] http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html [ Failure Pass Timeout ] Added: trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135726] trunk/LayoutTests
Title: [135726] trunk/LayoutTests
Revision 135726
Author ju...@google.com
Date 2012-11-26 08:02:11 -0800 (Mon, 26 Nov 2012)
Log Message
New baselines for test fast/backgrounds/background-opaque-images-over-color.html
https://bugs.webkit.org/show_bug.cgi?id=102557
Unreviewed
* fast/backgrounds/background-opaque-images-over-color-expected.txt:
* platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
* platform/chromium-win/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
Added Paths
trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png
trunk/LayoutTests/platform/chromium-win/fast/backgrounds/background-opaque-images-over-color-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (135725 => 135726)
--- trunk/LayoutTests/ChangeLog 2012-11-26 15:51:38 UTC (rev 135725)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 16:02:11 UTC (rev 135726)
@@ -1,5 +1,18 @@
2012-11-26 Justin Novosad ju...@google.com
+New baselines for test fast/backgrounds/background-opaque-images-over-color.html
+https://bugs.webkit.org/show_bug.cgi?id=102557
+
+Unreviewed
+
+* fast/backgrounds/background-opaque-images-over-color-expected.txt:
+* platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
+* platform/chromium-win/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
+* platform/chromium/TestExpectations:
+* platform/mac/TestExpectations:
+
+2012-11-26 Justin Novosad ju...@google.com
+
New baselines for test fast/backgrounds/gradient-background-leakage-2.html
https://bugs.webkit.org/show_bug.cgi?id=103089
Modified: trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt (135725 => 135726)
--- trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt 2012-11-26 15:51:38 UTC (rev 135725)
+++ trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt 2012-11-26 16:02:11 UTC (rev 135726)
@@ -14,19 +14,14 @@
RenderBlock (floating) {DIV} at (140,0) size 20x100 [bgcolor=#FF]
RenderBlock (floating) {DIV} at (160,0) size 20x100 [bgcolor=#FF]
RenderBlock (floating) {DIV} at (180,0) size 20x100 [bgcolor=#FF]
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x108
- RenderBlock {HTML} at (0,0) size 800x108
-RenderBody {BODY} at (8,8) size 784x0
RenderBlock {DIV} at (0,0) size 784x0
-RenderBlock (floating) {DIV} at (0,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (20,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (40,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (60,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (80,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (100,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (120,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (140,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (160,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (180,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (200,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (220,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (240,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (260,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (280,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (300,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (320,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (340,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (360,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (380,0) size 20x100 [bgcolor=#FF]
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135725 => 135726)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 15:51:38 UTC (rev 135725)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 16:02:11 UTC (rev 135726)
@@ -1266,9 +1266,6 @@
webkit.org/b/60118 [ Mac ] svg/dom/SVGScriptElement/script-set-href.svg [ Failure Pass ]
-# New test in need of new baselines
-webkit.org/b/102557
[webkit-changes] [135825] trunk/LayoutTests
Title: [135825] trunk/LayoutTests Revision 135825 Author ju...@google.com Date 2012-11-26 23:20:00 -0800 (Mon, 26 Nov 2012) Log Message [Qt] new fast/backgrounds/background-opaque-images-over-color.html fails since r135629 https://bugs.webkit.org/show_bug.cgi?id=103227 Reviewed by Simon Hausmann. Unskipping test now that baseline has been fixed. * platform/qt/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135824 => 135825) --- trunk/LayoutTests/ChangeLog 2012-11-27 07:09:22 UTC (rev 135824) +++ trunk/LayoutTests/ChangeLog 2012-11-27 07:20:00 UTC (rev 135825) @@ -1,3 +1,14 @@ +2012-11-26 Justin Novosad ju...@google.com + +[Qt] new fast/backgrounds/background-opaque-images-over-color.html fails since r135629 +https://bugs.webkit.org/show_bug.cgi?id=103227 + +Reviewed by Simon Hausmann. + +Unskipping test now that baseline has been fixed. + +* platform/qt/TestExpectations: + 2012-11-26 Noel Gordon noel.gor...@gmail.com [chromium mac] Layout Test touchadjustment/touch-links-longpress.html is failing Modified: trunk/LayoutTests/platform/qt/TestExpectations (135824 => 135825) --- trunk/LayoutTests/platform/qt/TestExpectations 2012-11-27 07:09:22 UTC (rev 135824) +++ trunk/LayoutTests/platform/qt/TestExpectations 2012-11-27 07:20:00 UTC (rev 135825) @@ -1747,10 +1747,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=98751 fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html -# [Qt] new fast/backgrounds/background-opaque-images-over-color.html fails since r135629 -# https://bugs.webkit.org/show_bug.cgi?id=103227 -fast/backgrounds/background-opaque-images-over-color.html - # = # # failing security tests # = # ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135625] trunk
Title: [135625] trunk
Revision 135625
Author ju...@google.com
Date 2012-11-23 09:13:32 -0800 (Fri, 23 Nov 2012)
Log Message
Page background color bleeds through inner edge of div border with rounded edges
https://bugs.webkit.org/show_bug.cgi?id=103089
Reviewed by Stephen White.
Source/WebCore:
Test that verifies whether a RenderBoxEdge is more than 2 pixels wide
was applying the content scale factor backwards, so the
obscuresBackgroundEdge was falsely passing for downsized boxes.
Test: fast/backgrounds/gradient-background-leakage-2.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::BorderEdge::obscuresBackgroundEdge):
LayoutTests:
New layout test to verify that there is no color bleeding between
a div element's border and background when there are rounded corners
an a scale that reduces a thick border down to a width of less than
two pixels.
* fast/backgrounds/gradient-background-leakage-2-expected.txt: Added.
* fast/backgrounds/gradient-background-leakage-2.html: Added.
* platform/chromium/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
Added Paths
trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-2-expected.txt
trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-2.html
Diff
Modified: trunk/LayoutTests/ChangeLog (135624 => 135625)
--- trunk/LayoutTests/ChangeLog 2012-11-23 17:10:03 UTC (rev 135624)
+++ trunk/LayoutTests/ChangeLog 2012-11-23 17:13:32 UTC (rev 135625)
@@ -1,3 +1,19 @@
+2012-11-23 Justin Novosad ju...@google.com
+
+Page background color bleeds through inner edge of div border with rounded edges
+https://bugs.webkit.org/show_bug.cgi?id=103089
+
+Reviewed by Stephen White.
+
+New layout test to verify that there is no color bleeding between
+a div element's border and background when there are rounded corners
+an a scale that reduces a thick border down to a width of less than
+two pixels.
+
+* fast/backgrounds/gradient-background-leakage-2-expected.txt: Added.
+* fast/backgrounds/gradient-background-leakage-2.html: Added.
+* platform/chromium/TestExpectations:
+
2012-11-23 Robert Kroeger rjkro...@chromium.org
Gardening: update expectations for fast/events/stopPropagation-submit.html flaky
Added: trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-2-expected.txt (0 => 135625)
--- trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-2-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-2-expected.txt 2012-11-23 17:13:32 UTC (rev 135625)
@@ -0,0 +1,8 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x78
+ RenderBlock {HTML} at (0,0) size 800x78
+RenderBody {BODY} at (8,10) size 784x60
+ RenderBlock {DIV} at (0,0) size 310x60 [bgcolor=#FF]
+layer at (18,10) size 308x58
+ RenderBlock {DIV} at (10,0) size 308x58 [border: (4px solid #008000)]
Added: trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-2.html (0 => 135625)
--- trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-2.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/gradient-background-leakage-2.html 2012-11-23 17:13:32 UTC (rev 135625)
@@ -0,0 +1,22 @@
+!DOCTYPE html
+html
+head
+ style type=text/css
+.box {
+ height: 50px;
+ width: 300px;
+ margin: 10px;
+ background-image: -webkit-linear-gradient(black, black);
+ border-radius: 25px;
+ border: 4px solid green;
+ -webkit-transform: scale(0.25);
+}
+ /style
+/head
+body
+ !-- You should see no red leaking through the inner edge of the border. --
+ div style=background-color: red; height: 60px; width: 310px
+div class=box/div
+ /div
+/body
+/html
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135624 => 135625)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-23 17:10:03 UTC (rev 135624)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-23 17:13:32 UTC (rev 135625)
@@ -2157,6 +2157,9 @@
crbug.com/117597 svg/batik/filters/feTile.svg [ ImageOnlyFailure ]
+# Test needing new baselines
+webkit.org/b/103089 fast/backgrounds/gradient-background-leakage-2.html [ Pass Missing ImageOnlyFailure Failure ]
+
# Caused by http://trac.webkit.org/changeset/56394.
crbug.com/143475 [ Win ] http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html [ Failure Pass Timeout ]
Modified: trunk/Source/WebCore/ChangeLog (135624 => 135625)
--- trunk/Source/WebCore/ChangeLog 2012-11-23 17:10:03 UTC (rev 135624)
+++ trunk/Source/WebCore/ChangeLog 2012-11-23 17:13:32 UTC (rev 135625)
@@ -1,3 +1,19 @@
+2012-11-23 Justin Novosad ju...@google.com
+
+Page background color bleeds through inner edge of
[webkit-changes] [135629] trunk
Title: [135629] trunk Revision 135629 Author ju...@google.com Date 2012-11-23 10:43:51 -0800 (Fri, 23 Nov 2012) Log Message Adding occlusion detection to reduce overdraw in RenderBox background rendering https://bugs.webkit.org/show_bug.cgi?id=102557 Reviewed by Stephen White. Source/WebCore: Adding hasAlpha method to all classes dervived from CSSImageValue and StyleImage, in order to support occlusion testing. This allows the FillLayer recursion to stop early when an opaque layer is encountered while applying a CSS background style. This also allows the elimination of background color application when the background is completely covered by an image. The optimization also skips the clearing of the page's root element when the page background is entirely covered by an image (e.g a tiled bitmap or a gradient) Test: fast/backgrounds/background-opaque-images-over-color.html * css/CSSCrossfadeValue.cpp: (WebCore::subimageHasAlpha): (WebCore): (WebCore::CSSCrossfadeValue::isPending): (WebCore::CSSCrossfadeValue::hasAlpha): * css/CSSCrossfadeValue.h: (CSSCrossfadeValue): * css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::hasAlpha): (WebCore): * css/CSSGradientValue.h: (CSSGradientValue): * css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::hasAlpha): (WebCore): * css/CSSImageGeneratorValue.h: (CSSImageGeneratorValue): * css/CSSImageValue.cpp: (WebCore::CSSImageValue::hasAlpha): (WebCore): * css/CSSImageValue.h: (WebCore): (CSSImageValue): * loader/cache/CachedImage.cpp: (WebCore::CachedImage::currentFrameHasAlpha): Test whether a cached image has alpha, with side effect of ensuring the image is in cache. (new method) (WebCore): * loader/cache/CachedImage.h: (CachedImage): * rendering/RenderBox.cpp: (WebCore::RenderBox::paintFillLayers): Added layer recursion early exit when an opaque layer is encountered. * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Eliminated background color fill when the layer contains an opaque image that covers the entire RenderBox. * rendering/style/FillLayer.cpp: (WebCore::FillLayer::hasOpaqueImage): Returns true if the layer's image is known to be fully opaque. (WebCore): (WebCore::FillLayer::hasRepeatXY): * rendering/style/FillLayer.h: (FillLayer): * rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::hasAlpha): (WebCore): * rendering/style/StyleCachedImage.h: (StyleCachedImage): * rendering/style/StyleCachedImageSet.cpp: (WebCore::StyleCachedImageSet::hasAlpha): (WebCore): * rendering/style/StyleCachedImageSet.h: (StyleCachedImageSet): * rendering/style/StyleGeneratedImage.cpp: (WebCore::StyleGeneratedImage::hasAlpha): (WebCore): * rendering/style/StyleGeneratedImage.h: (StyleGeneratedImage): * rendering/style/StyleImage.h: (StyleImage): * rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::hasAlpha): LayoutTests: New test exercises different CSS background style use cases that are candidates for optimization by occlusion culling. * fast/backgrounds/background-opaque-images-over-color-expected.txt: Added. * fast/backgrounds/background-opaque-images-over-color.html: Added. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSCrossfadeValue.cpp trunk/Source/WebCore/css/CSSCrossfadeValue.h trunk/Source/WebCore/css/CSSGradientValue.cpp trunk/Source/WebCore/css/CSSGradientValue.h trunk/Source/WebCore/css/CSSImageGeneratorValue.cpp trunk/Source/WebCore/css/CSSImageGeneratorValue.h trunk/Source/WebCore/css/CSSImageValue.cpp trunk/Source/WebCore/css/CSSImageValue.h trunk/Source/WebCore/loader/cache/CachedImage.cpp trunk/Source/WebCore/loader/cache/CachedImage.h trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp trunk/Source/WebCore/rendering/style/FillLayer.cpp trunk/Source/WebCore/rendering/style/FillLayer.h trunk/Source/WebCore/rendering/style/StyleCachedImage.cpp trunk/Source/WebCore/rendering/style/StyleCachedImage.h trunk/Source/WebCore/rendering/style/StyleCachedImageSet.cpp trunk/Source/WebCore/rendering/style/StyleCachedImageSet.h trunk/Source/WebCore/rendering/style/StyleGeneratedImage.cpp trunk/Source/WebCore/rendering/style/StyleGeneratedImage.h trunk/Source/WebCore/rendering/style/StyleImage.h trunk/Source/WebCore/rendering/style/StylePendingImage.h Added Paths trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color.html Diff Modified: trunk/LayoutTests/ChangeLog (135628 => 135629) --- trunk/LayoutTests/ChangeLog 2012-11-23 18:39:51 UTC (rev 135628) +++ trunk/LayoutTests/ChangeLog 2012-11-23 18:43:51 UTC (rev 135629) @@ -1,3 +1,17 @@ +2012-11-23 Justin Novosad ju...@google.com + +Adding occlusion detection to
[webkit-changes] [134777] trunk/LayoutTests
Title: [134777] trunk/LayoutTests Revision 134777 Author ju...@google.com Date 2012-11-15 07:48:56 -0800 (Thu, 15 Nov 2012) Log Message Cleanup test expectations after rebaseline r134668 https://bugs.webkit.org/show_bug.cgi?id=101974 Unreviewed * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (134776 => 134777) --- trunk/LayoutTests/ChangeLog 2012-11-15 15:46:01 UTC (rev 134776) +++ trunk/LayoutTests/ChangeLog 2012-11-15 15:48:56 UTC (rev 134777) @@ -1,3 +1,12 @@ +2012-11-15 Justin Novosad ju...@google.com + +Cleanup test expectations after rebaseline r134668 +https://bugs.webkit.org/show_bug.cgi?id=101974 + +Unreviewed + +* platform/chromium/TestExpectations: + 2012-11-15 Raphael Kubo da Costa raphael.kubo.da.co...@intel.com [EFL] Gardening. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (134776 => 134777) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-15 15:46:01 UTC (rev 134776) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-15 15:48:56 UTC (rev 134777) @@ -3089,12 +3089,6 @@ webkit.org/b/77314 [ Mac Win ] fast/events/touch/send-oncancel-event.html [ Failure Pass ] -# Needs rebaselining after fix for bug 101974 -webkit.org/b/101974 fast/forms/validation-message-appearance.html [ ImageOnlyFailure Pass ] -webkit.org/b/101974 svg/custom/svg-fonts-in-html.html [ ImageOnlyFailure Pass ] -webkit.org/b/101974 fast/borders/border-radius-wide-border-01.html [ ImageOnlyFailure Pass ] -webkit.org/b/101974 fast/borders/borderRadiusInset01.html [ ImageOnlyFailure Pass ] - # Skipped until setTouchPointRadius get implemented webkit.org/b/91012 touchadjustment/focusout-on-touch.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134668] trunk/LayoutTests
Title: [134668] trunk/LayoutTests Revision 134668 Author ju...@google.com Date 2012-11-14 14:16:58 -0800 (Wed, 14 Nov 2012) Log Message Updating baselines after r134631 https://bugs.webkit.org/show_bug.cgi?id=101974 Unreviewed * platform/chromium-linux/fast/borders/border-radius-wide-border-01-expected.png: Removed. * platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png: * platform/chromium-linux/fast/forms/validation-message-appearance-expected.png: * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png: * platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png: * platform/chromium-mac-lion/svg/custom/svg-fonts-in-html-expected.png: * platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png: * platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png: * platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png: * platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: * platform/chromium-mac/fast/forms/validation-message-appearance-expected.png: * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png: * platform/chromium-win/fast/borders/border-radius-wide-border-01-expected.png: * platform/chromium-win/fast/borders/borderRadiusInset01-expected.png: * platform/chromium-win/fast/forms/validation-message-appearance-expected.png: * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png: * platform/efl-wk1/fast/borders: Added. * platform/efl-wk1/fast/borders/border-radius-wide-border-01-expected.png: Added. * platform/efl-wk1/fast/borders/borderRadiusInset01-expected.png: Added. * platform/efl-wk1/fast/forms/validation-message-appearance-expected.png: Added. * platform/efl/fast/borders/border-radius-wide-border-01-expected.png: Removed. * platform/efl/fast/borders/borderRadiusInset01-expected.png: Removed. * platform/efl/fast/forms/validation-message-appearance-expected.png: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png trunk/LayoutTests/platform/chromium-linux/fast/forms/validation-message-appearance-expected.png trunk/LayoutTests/platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png trunk/LayoutTests/platform/chromium-mac/fast/forms/validation-message-appearance-expected.png trunk/LayoutTests/platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png trunk/LayoutTests/platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png trunk/LayoutTests/platform/chromium-mac-lion/svg/custom/svg-fonts-in-html-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png trunk/LayoutTests/platform/chromium-win/fast/borders/border-radius-wide-border-01-expected.png trunk/LayoutTests/platform/chromium-win/fast/borders/borderRadiusInset01-expected.png trunk/LayoutTests/platform/chromium-win/fast/forms/validation-message-appearance-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png Added Paths trunk/LayoutTests/platform/efl-wk1/fast/borders/ trunk/LayoutTests/platform/efl-wk1/fast/borders/border-radius-wide-border-01-expected.png trunk/LayoutTests/platform/efl-wk1/fast/borders/borderRadiusInset01-expected.png trunk/LayoutTests/platform/efl-wk1/fast/forms/validation-message-appearance-expected.png Removed Paths trunk/LayoutTests/platform/chromium-linux/fast/borders/border-radius-wide-border-01-expected.png trunk/LayoutTests/platform/efl/fast/borders/border-radius-wide-border-01-expected.png trunk/LayoutTests/platform/efl/fast/borders/borderRadiusInset01-expected.png trunk/LayoutTests/platform/efl/fast/forms/validation-message-appearance-expected.png Property Changed trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (134667 => 134668) --- trunk/LayoutTests/ChangeLog 2012-11-14 22:09:12 UTC (rev 134667) +++ trunk/LayoutTests/ChangeLog 2012-11-14 22:16:58 UTC (rev 134668) @@ -1,3 +1,34 @@ +2012-11-14 Justin Novosad ju...@google.com + +Updating baselines after r134631 +https://bugs.webkit.org/show_bug.cgi?id=101974 + +Unreviewed + +* platform/chromium-linux/fast/borders/border-radius-wide-border-01-expected.png: Removed. +* platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png: +* platform/chromium-linux/fast/forms/validation-message-appearance-expected.png: +*
[webkit-changes] [132839] trunk
Title: [132839] trunk Revision 132839 Author ju...@google.com Date 2012-10-29 12:37:19 -0700 (Mon, 29 Oct 2012) Log Message [Chromium] flickering observed when copying 2D canvas to webGL texture https://bugs.webkit.org/show_bug.cgi?id=100691 Reviewed by Stephen White. Source/WebCore: Added a flush to the webgl context after texture upload from an image buffer to ensure proper graphics context synchronization with respect to subsequent changes to the source image. Tests: fast/canvas/webgl/canvas-2d-webgl-texture.html * platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::copyToPlatformTexture): LayoutTests: Modified test by adding a canvas draw imediately after webgl texture upload in order to exercise graphics context synchronization between the webGL and 2D canvas graphics contexts. * fast/canvas/webgl/canvas-2d-webgl-texture.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/canvas/webgl/canvas-2d-webgl-texture.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp Diff Modified: trunk/LayoutTests/ChangeLog (132838 => 132839) --- trunk/LayoutTests/ChangeLog 2012-10-29 19:29:12 UTC (rev 132838) +++ trunk/LayoutTests/ChangeLog 2012-10-29 19:37:19 UTC (rev 132839) @@ -1,3 +1,16 @@ +2012-10-29 Justin Novosad ju...@google.com + +[Chromium] flickering observed when copying 2D canvas to webGL texture +https://bugs.webkit.org/show_bug.cgi?id=100691 + +Reviewed by Stephen White. + +Modified test by adding a canvas draw imediately after webgl texture +upload in order to exercise graphics context synchronization between +the webGL and 2D canvas graphics contexts. + +* fast/canvas/webgl/canvas-2d-webgl-texture.html: + 2012-10-29 Glenn Adams gl...@skynav.com [CSSOM] Extraneous whitespace in CSSImportRule.cssText Modified: trunk/LayoutTests/fast/canvas/webgl/canvas-2d-webgl-texture.html (132838 => 132839) --- trunk/LayoutTests/fast/canvas/webgl/canvas-2d-webgl-texture.html 2012-10-29 19:29:12 UTC (rev 132838) +++ trunk/LayoutTests/fast/canvas/webgl/canvas-2d-webgl-texture.html 2012-10-29 19:37:19 UTC (rev 132839) @@ -30,6 +30,8 @@ ctx.fillStyle = rgb(0, 0, 200); ctx.fillRect(0, 0, 256, 256); gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, gl.RGBA, gl.UNSIGNED_BYTE, canvas2d); + ctx.fillStyle = rgb(200, 0, 0); + ctx.fillRect(0, 0, 256, 256); wtu.drawQuad(gl); wtu.checkCanvasRect(gl, 0, 0, 1, 1, [0, 0, 200, 255], Should have rendered blue., 1); Modified: trunk/Source/WebCore/ChangeLog (132838 => 132839) --- trunk/Source/WebCore/ChangeLog 2012-10-29 19:29:12 UTC (rev 132838) +++ trunk/Source/WebCore/ChangeLog 2012-10-29 19:37:19 UTC (rev 132839) @@ -1,3 +1,19 @@ +2012-10-29 Justin Novosad ju...@google.com + +[Chromium] flickering observed when copying 2D canvas to webGL texture +https://bugs.webkit.org/show_bug.cgi?id=100691 + +Reviewed by Stephen White. + +Added a flush to the webgl context after texture upload from an image +buffer to ensure proper graphics context synchronization with respect +to subsequent changes to the source image. + +Tests: fast/canvas/webgl/canvas-2d-webgl-texture.html + +* platform/graphics/skia/ImageBufferSkia.cpp: +(WebCore::ImageBuffer::copyToPlatformTexture): + 2012-10-29 Glenn Adams gl...@skynav.com [CSSOM] Extraneous whitespace in CSSImportRule.cssText Modified: trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (132838 => 132839) --- trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2012-10-29 19:29:12 UTC (rev 132838) +++ trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2012-10-29 19:37:19 UTC (rev 132839) @@ -194,6 +194,7 @@ context.pixelStorei(Extensions3D::UNPACK_FLIP_Y_CHROMIUM, false); context.pixelStorei(Extensions3D::UNPACK_UNPREMULTIPLY_ALPHA_CHROMIUM, false); +context.flush(); return true; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130958] trunk/Tools/Scripts/webkitpy/common/config/committers.py
Title: [130958] trunk/Tools/Scripts/webkitpy/common/config/committers.py Revision 130958 Author ju...@google.com Date 2012-10-10 14:17:32 -0700 (Wed, 10 Oct 2012) Log Message Unreviewed. Adding myself as Committer. Modified Paths trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (130957 => 130958) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-10-10 21:15:22 UTC (rev 130957) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-10-10 21:17:32 UTC (rev 130958) @@ -298,6 +298,7 @@ Committer(Joshua Bell, [jsb...@chromium.org, jsb...@google.com], jsbell), Committer(Julie Parent, [jpar...@google.com, jpar...@chromium.org], jparent), Committer(Jungshik Shin, js...@chromium.org), +Committer(Justin Novosad, [ju...@google.com, ju...@chromium.org], junov), Committer(Justin Schuh, jsc...@chromium.org, jschuh), Committer(Kaustubh Atrawalkar, [kaust...@motorola.com], silverroots), Committer(Keishi Hattori, kei...@webkit.org, keishi), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
