[webkit-changes] [264334] trunk/Source/WebCore

[justin_fan]

Title: [264334] trunk/Source/WebCore








Revision 264334
Author justin_...@apple.com
Date 2020-07-14 02:26:03 -0700 (Tue, 14 Jul 2020)


Log Message
[WebGL] REGRESSION (r262366): Google search photos do not render, black images
https://bugs.webkit.org/show_bug.cgi?id=214156


Reviewed by Dean Jackson.

http://trac.webkit.org/changeset/262366 separated WebGL canvas contents swapping and presentation
into two steps. This Google search page was only running the presentation code without the swapping
step, as it removes canvases from the observer Document before the Document is able to swap its canvas'
contents. Ensure that re-inserted canvas elements properly register their new Documents as observers.

Covered by existing tests.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::insertedIntoAncestor):
* html/HTMLCanvasElement.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCanvasElement.cpp
trunk/Source/WebCore/html/HTMLCanvasElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (264333 => 264334)

--- trunk/Source/WebCore/ChangeLog	2020-07-14 07:12:04 UTC (rev 264333)
+++ trunk/Source/WebCore/ChangeLog	2020-07-14 09:26:03 UTC (rev 264334)
@@ -1,3 +1,22 @@
+2020-07-14  Justin Fan  
+
+[WebGL] REGRESSION (r262366): Google search photos do not render, black images
+https://bugs.webkit.org/show_bug.cgi?id=214156
+
+
+Reviewed by Dean Jackson.
+
+http://trac.webkit.org/changeset/262366 separated WebGL canvas contents swapping and presentation
+into two steps. This Google search page was only running the presentation code without the swapping
+step, as it removes canvases from the observer Document before the Document is able to swap its canvas'
+contents. Ensure that re-inserted canvas elements properly register their new Documents as observers.
+
+Covered by existing tests.
+
+* html/HTMLCanvasElement.cpp:
+(WebCore::HTMLCanvasElement::insertedIntoAncestor): 
+* html/HTMLCanvasElement.h:
+
 2020-07-14  Fujii Hironori  
 
 Unreviewed non-unified build fixes


Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (264333 => 264334)

--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp	2020-07-14 07:12:04 UTC (rev 264333)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp	2020-07-14 09:26:03 UTC (rev 264334)
@@ -1008,6 +1008,14 @@
 HTMLElement::didMoveToNewDocument(oldDocument, newDocument);
 }
 
+Node::InsertedIntoAncestorResult HTMLCanvasElement::insertedIntoAncestor(InsertionType insertionType, ContainerNode& parentOfInsertedTree)
+{
+if (insertionType.connectedToDocument)
+addObserver(parentOfInsertedTree.document());
+
+return HTMLElement::insertedIntoAncestor(insertionType, parentOfInsertedTree);
+}
+
 void HTMLCanvasElement::removedFromAncestor(RemovalType removalType, ContainerNode& oldParentOfRemovedTree)
 {
 if (removalType.disconnectedFromDocument) {


Modified: trunk/Source/WebCore/html/HTMLCanvasElement.h (264333 => 264334)

--- trunk/Source/WebCore/html/HTMLCanvasElement.h	2020-07-14 07:12:04 UTC (rev 264333)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.h	2020-07-14 09:26:03 UTC (rev 264334)
@@ -169,6 +169,7 @@
 ScriptExecutionContext* canvasBaseScriptExecutionContext() const final { return HTMLElement::scriptExecutionContext(); }
 
 void didMoveToNewDocument(Document& oldDocument, Document& newDocument) final;
+Node::InsertedIntoAncestorResult insertedIntoAncestor(InsertionType, ContainerNode&) final;
 void removedFromAncestor(RemovalType, ContainerNode& oldParentOfRemovedTree) final;
 
 FloatRect m_dirtyRect;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258899] trunk/Source/WebCore

[justin_fan]

Title: [258899] trunk/Source/WebCore








Revision 258899
Author justin_...@apple.com
Date 2020-03-23 19:38:39 -0700 (Mon, 23 Mar 2020)


Log Message
[ Mac wk2 Debug ] webgpu/whlsl/vector-compare.html is flaky crashing.
https://bugs.webkit.org/show_bug.cgi?id=209024

Reviewed by Myles C. Maxfield.

Prevent GPUBindGroup destructor from accidentally dereferencing GPUBindGroupAllocator too many times
if the owning GPUDevice has already been destroyed. A GPUBindGroupAllocator should reset whenever its
spawned GPUBindGroups are all cleaned up.

Covered by existing tests.

* platform/graphics/gpu/GPUBindGroupAllocator.h:
* platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm:
(WebCore::GPUBindGroupAllocator::allocateAndSetEncoders):
(WebCore::GPUBindGroupAllocator::tryReset):
* platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm:
(WebCore::GPUBindGroup::~GPUBindGroup):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroupAllocator.h
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (258898 => 258899)

--- trunk/Source/WebCore/ChangeLog	2020-03-24 02:22:49 UTC (rev 258898)
+++ trunk/Source/WebCore/ChangeLog	2020-03-24 02:38:39 UTC (rev 258899)
@@ -1,3 +1,23 @@
+2020-03-23  Justin Fan  
+
+[ Mac wk2 Debug ] webgpu/whlsl/vector-compare.html is flaky crashing.
+https://bugs.webkit.org/show_bug.cgi?id=209024
+
+Reviewed by Myles C. Maxfield.
+
+Prevent GPUBindGroup destructor from accidentally dereferencing GPUBindGroupAllocator too many times
+if the owning GPUDevice has already been destroyed. A GPUBindGroupAllocator should reset whenever its
+spawned GPUBindGroups are all cleaned up. 
+
+Covered by existing tests.
+
+* platform/graphics/gpu/GPUBindGroupAllocator.h:
+* platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm:
+(WebCore::GPUBindGroupAllocator::allocateAndSetEncoders):
+(WebCore::GPUBindGroupAllocator::tryReset):
+* platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm:
+(WebCore::GPUBindGroup::~GPUBindGroup):
+
 2020-03-23  Wenson Hsieh  
 
 Remove the unused method PasteboardStrategy::uniqueName()


Modified: trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroupAllocator.h (258898 => 258899)

--- trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroupAllocator.h	2020-03-24 02:22:49 UTC (rev 258898)
+++ trunk/Source/WebCore/platform/graphics/gpu/GPUBindGroupAllocator.h	2020-03-24 02:38:39 UTC (rev 258899)
@@ -69,6 +69,7 @@
 #endif
 
 Ref m_errorScopes;
+int m_numBindGroups { 0 };
 };
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm (258898 => 258899)

--- trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm	2020-03-24 02:22:49 UTC (rev 258898)
+++ trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm	2020-03-24 02:38:39 UTC (rev 258899)
@@ -116,6 +116,7 @@
 END_BLOCK_OBJC_EXCEPTIONS;
 
 m_lastOffset = newOffset;
+++m_numBindGroups;
 
 return offsets;
 }
@@ -153,11 +154,14 @@
 
 void GPUBindGroupAllocator::tryReset()
 {
-if (!hasOneRef())
-return;
+--m_numBindGroups;
+
+ASSERT(m_numBindGroups > -1);
 
-m_argumentBuffer = nullptr;
-m_lastOffset = 0;
+if (!m_numBindGroups) {
+m_argumentBuffer = nullptr;
+m_lastOffset = 0;
+}
 }
 
 #endif // USE(METAL)


Modified: trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm (258898 => 258899)

--- trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm	2020-03-24 02:22:49 UTC (rev 258898)
+++ trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm	2020-03-24 02:38:39 UTC (rev 258899)
@@ -239,9 +239,7 @@
 
 GPUBindGroup::~GPUBindGroup()
 {
-GPUBindGroupAllocator& rawAllocator = m_allocator.leakRef();
-rawAllocator.deref();
-rawAllocator.tryReset();
+m_allocator->tryReset();
 }
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258462] trunk/LayoutTests

[justin_fan]

Title: [258462] trunk/LayoutTests








Revision 258462
Author justin_...@apple.com
Date 2020-03-13 23:43:46 -0700 (Fri, 13 Mar 2020)


Log Message
PROGRESSION: webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205736

Unreviewed test expectation update.

* TestExpectations:
* webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (258461 => 258462)

--- trunk/LayoutTests/ChangeLog	2020-03-14 06:16:27 UTC (rev 258461)
+++ trunk/LayoutTests/ChangeLog	2020-03-14 06:43:46 UTC (rev 258462)
@@ -1,5 +1,15 @@
 2020-03-13  Justin Fan  
 
+PROGRESSION: webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=205736
+
+Unreviewed test expectation update.
+
+* TestExpectations:
+* webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt:
+
+2020-03-13  Justin Fan  
+
 PROGRESSION (r253926): webgl/1.0.3/conformance/renderbuffers/feedback-loop.html is failing
 https://bugs.webkit.org/show_bug.cgi?id=205738
 


Modified: trunk/LayoutTests/TestExpectations (258461 => 258462)

--- trunk/LayoutTests/TestExpectations	2020-03-14 06:16:27 UTC (rev 258461)
+++ trunk/LayoutTests/TestExpectations	2020-03-14 06:43:46 UTC (rev 258462)
@@ -3288,7 +3288,6 @@
 
 # webkit.org/b/203908 Tests generate inconsistent results or time out
 webgl/1.0.3/conformance/textures/texture-npot-video.html [ Skip ]
-webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html [ Skip ]
 webgl/1.0.3/conformance/canvas/rapid-resizing.html [ Skip ]
 webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html [ Skip ]
 


Modified: trunk/LayoutTests/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt (258461 => 258462)

--- trunk/LayoutTests/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt	2020-03-14 06:16:27 UTC (rev 258461)
+++ trunk/LayoutTests/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt	2020-03-14 06:43:46 UTC (rev 258462)
@@ -1,56 +1,5 @@
 This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
 
 Test: ../../resources/webgl_test_files/conformance/textures/copy-tex-image-2d-formats.html
-[ 1: PASS ] getError was expected value: NO_ERROR : During Initialization
-[ 2: PASS ] getError was expected value: NO_ERROR : should be able to copyTexImage2D ALPHA from RGBA
-[ 3: FAIL ] at (0, 0) expected: 0,0,0,127 was 0,0,0,0
-[ 4: PASS ] getError was expected value: NO_ERROR : should be no errors
-[ 5: PASS ] getError was expected value: NO_ERROR : should be able to copyTexImage2D LUMINANCE from RGBA
-[ 6: FAIL ] at (0, 0) expected: 64,64,64,255 was 0,0,0,255
-[ 7: PASS ] getError was expected value: NO_ERROR : should be no errors
-[ 8: PASS ] getError was expected value: NO_ERROR : should be able to copyTexImage2D LUMINANCE_ALPHA from RGBA
-[ 9: FAIL ] at (0, 0) expected: 64,64,64,127 was 0,0,0,0
-[ 10: PASS ] getError was expected value: NO_ERROR : should be no errors
-[ 11: PASS ] getError was expected value: NO_ERROR : should be able to copyTexImage2D RGB from RGBA
-[ 12: PASS ] should be 64,255,191,255
-[ 13: PASS ] getError was expected value: NO_ERROR : should be no errors
-[ 14: PASS ] getError was expected value: NO_ERROR : should be able to copyTexImage2D RGBA from RGBA
-[ 15: PASS ] should be 64,255,191,127
-[ 16: PASS ] getError was expected value: NO_ERROR : should be no errors
-[ 17: PASS ] getError was expected value: INVALID_OPERATION : should not be able to copyTexImage2D ALPHA from RGB
-[ 18: PASS ] getError was expected value: NO_ERROR : should be able to copyTexImage2D LUMINANCE from RGB
-[ 19: PASS ] should be 64,64,64,255
-[ 20: PASS ] getError was expected value: NO_ERROR : should be no errors
-[ 21: PASS ] getError was expected value: INVALID_OPERATION : should not be able to copyTexImage2D LUMINANCE_ALPHA from RGB
-[ 22: PASS ] getError was expected value: NO_ERROR : should be able to copyTexImage2D RGB from RGB
-[ 23: PASS ] should be 64,255,191,255
-[ 24: PASS ] getError was expected value: NO_ERROR : should be no errors
-[ 25: PASS ] getError was expected value: INVALID_OPERATION : should not be able to copyTexImage2D RGBA from RGB
-[ 26: PASS ] getError was expected value: NO_ERROR : should be able to copyTexImage2D ALPHA from RGBA
-[ 27: PASS ] should be 0,0,0,127
-[ 28: PASS ] getError was expected value: NO_ERROR : should be no errors
-[ 29: PASS ] getError was expected value: NO_ERROR : should be able to copyTexImage2D LUMINANCE from RGBA
-[ 30: PASS ] should be 64,64,64,255
-[ 31: PASS ] getError was expected value: NO_ERROR : should be no errors
-[ 32: PASS ] getError was expected value: NO_ERROR : should b

[webkit-changes] [258461] trunk/LayoutTests

[justin_fan]

Title: [258461] trunk/LayoutTests








Revision 258461
Author justin_...@apple.com
Date 2020-03-13 23:16:27 -0700 (Fri, 13 Mar 2020)


Log Message
PROGRESSION (r253926): webgl/1.0.3/conformance/renderbuffers/feedback-loop.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205738

Unreviewed test expectation updates.

* TestExpectations:
* platform/ios/TestExpectations:
* webgl/1.0.3/conformance/renderbuffers/feedback-loop-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/webgl/1.0.3/conformance/renderbuffers/feedback-loop-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (258460 => 258461)

--- trunk/LayoutTests/ChangeLog	2020-03-14 04:11:44 UTC (rev 258460)
+++ trunk/LayoutTests/ChangeLog	2020-03-14 06:16:27 UTC (rev 258461)
@@ -1,3 +1,14 @@
+2020-03-13  Justin Fan  
+
+PROGRESSION (r253926): webgl/1.0.3/conformance/renderbuffers/feedback-loop.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=205738
+
+Unreviewed test expectation updates.
+
+* TestExpectations:
+* platform/ios/TestExpectations:
+* webgl/1.0.3/conformance/renderbuffers/feedback-loop-expected.txt:
+
 2020-03-13  Said Abou-Hallawa  
 
 SVGMatrix should have the access right of its owner SVGTransform always


Modified: trunk/LayoutTests/TestExpectations (258460 => 258461)

--- trunk/LayoutTests/TestExpectations	2020-03-14 04:11:44 UTC (rev 258460)
+++ trunk/LayoutTests/TestExpectations	2020-03-14 06:16:27 UTC (rev 258461)
@@ -3288,7 +3288,6 @@
 
 # webkit.org/b/203908 Tests generate inconsistent results or time out
 webgl/1.0.3/conformance/textures/texture-npot-video.html [ Skip ]
-webgl/1.0.3/conformance/renderbuffers/feedback-loop.html [ Skip ]
 webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html [ Skip ]
 webgl/1.0.3/conformance/canvas/rapid-resizing.html [ Skip ]
 webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html [ Skip ]


Modified: trunk/LayoutTests/platform/ios/TestExpectations (258460 => 258461)

--- trunk/LayoutTests/platform/ios/TestExpectations	2020-03-14 04:11:44 UTC (rev 258460)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2020-03-14 06:16:27 UTC (rev 258461)
@@ -2703,7 +2703,6 @@
 webgl/1.0.3/conformance/context/context-attributes-alpha-depth-stencil-antialias.html [ Failure ]
 webgl/1.0.3/conformance/context/context-hidden-alpha.html [ Failure ]
 webgl/1.0.3/conformance/extensions/webgl-compressed-texture-pvrtc.html [ Failure ]
-webgl/1.0.3/conformance/renderbuffers/feedback-loop.html [ Failure ]
 fast/canvas/webgl/read-pixels-test.html [ Skip ]
 fast/canvas/webgl/webglcontextchangedevent.html [ Skip ]
 webgl/1.0.3/conformance/context/context-creation-and-destruction.html [ Skip ]


Modified: trunk/LayoutTests/webgl/1.0.3/conformance/renderbuffers/feedback-loop-expected.txt (258460 => 258461)

--- trunk/LayoutTests/webgl/1.0.3/conformance/renderbuffers/feedback-loop-expected.txt	2020-03-14 04:11:44 UTC (rev 258460)
+++ trunk/LayoutTests/webgl/1.0.3/conformance/renderbuffers/feedback-loop-expected.txt	2020-03-14 06:16:27 UTC (rev 258461)
@@ -1,14 +1,5 @@
 This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
 
 Test: ../../resources/webgl_test_files/conformance/renderbuffers/feedback-loop.html
-[ 1: PASS ] getError was expected value: NO_ERROR : after creating texture
-[ 2: PASS ] framebuffer should be FRAMEBUFFER_COMPLETE.
-[ 3: PASS ] getError was expected value: NO_ERROR : after initWebGL
-[ 4: FAIL ] getError expected: INVALID_OPERATION. Was NO_ERROR : after draw with invalid feedback loop
-[ 5: PASS ] getError was expected value: NO_ERROR : after drawing
-[ 6: PASS ] Should be blue.
-[ 7: PASS ] getError was expected value: NO_ERROR : after draw where framebuffer texture is bound to inactive texture unit
-[ 8: PASS ] Should be red.
-[ 9: PASS ] successfullyParsed is true
-[ FAIL ] 1 failures reported
+[ PASS ] All tests passed
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258299] trunk/LayoutTests

[justin_fan]

Title: [258299] trunk/LayoutTests








Revision 258299
Author justin_...@apple.com
Date 2020-03-11 17:30:58 -0700 (Wed, 11 Mar 2020)


Log Message
[WebGL] Additional WebGL bot gardening
https://bugs.webkit.org/show_bug.cgi?id=208961

Unreviewed test gardening.

* webgl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (258298 => 258299)

--- trunk/LayoutTests/ChangeLog	2020-03-11 23:58:38 UTC (rev 258298)
+++ trunk/LayoutTests/ChangeLog	2020-03-12 00:30:58 UTC (rev 258299)
@@ -1,3 +1,12 @@
+2020-03-11  Justin Fan  
+
+[WebGL] Additional WebGL bot gardening
+https://bugs.webkit.org/show_bug.cgi?id=208961
+
+Unreviewed test gardening.
+
+* webgl/TestExpectations:
+
 2020-03-11  Jiewen Tan  
 
 [WebAuthn] Formalize the Keychain schema


Modified: trunk/LayoutTests/webgl/TestExpectations (258298 => 258299)

--- trunk/LayoutTests/webgl/TestExpectations	2020-03-11 23:58:38 UTC (rev 258298)
+++ trunk/LayoutTests/webgl/TestExpectations	2020-03-12 00:30:58 UTC (rev 258299)
@@ -11,9 +11,12 @@
 
 # Flaky time outs
 webgl/2.0.0/deqp/functional/gles3/shaderoperator/angle_and_trigonometry_01.html [ Timeout Pass ]
+webgl/2.0.0/deqp/functional/gles3/vertexarrays/single_attribute.first.html [ Timeout Pass ]
 
 # DEQP flaky results
 webgl/2.0.0/deqp/functional/gles3/builtinprecision [ Pass Failure ]
+webgl/2.0.0/deqp/functional/gles3/pixelbufferobject.html [ Pass Failure ]
+webgl/2.0.0/deqp/functional/gles3/shaderbuiltinvar.html [ Pass Failure ]
 
 # DEQP crashes
 webgl/2.0.0/deqp/functional/gles3/fbomultisample.2_samples.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258230] trunk/LayoutTests

[justin_fan]

Title: [258230] trunk/LayoutTests








Revision 258230
Author justin_...@apple.com
Date 2020-03-10 14:47:44 -0700 (Tue, 10 Mar 2020)


Log Message
[WebGL] Additional gardening for webgl bot DEQP expectations
https://bugs.webkit.org/show_bug.cgi?id=208884

Unreviewed test gardening.

* webgl/2.0.0/deqp/functional/gles3/pixelbufferobject-expected.txt:
* webgl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/pixelbufferobject-expected.txt
trunk/LayoutTests/webgl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (258229 => 258230)

--- trunk/LayoutTests/ChangeLog	2020-03-10 21:27:17 UTC (rev 258229)
+++ trunk/LayoutTests/ChangeLog	2020-03-10 21:47:44 UTC (rev 258230)
@@ -1,3 +1,13 @@
+2020-03-10  Justin Fan  
+
+[WebGL] Additional gardening for webgl bot DEQP expectations
+https://bugs.webkit.org/show_bug.cgi?id=208884
+
+Unreviewed test gardening.
+
+* webgl/2.0.0/deqp/functional/gles3/pixelbufferobject-expected.txt:
+* webgl/TestExpectations:
+
 2020-03-10  Diego Pino Garcia  
 
 [WPE] Gardening, emit new baselines of WebGL 1.0.3 conformance tests


Modified: trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/pixelbufferobject-expected.txt (258229 => 258230)

--- trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/pixelbufferobject-expected.txt	2020-03-10 21:27:17 UTC (rev 258229)
+++ trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/pixelbufferobject-expected.txt	2020-03-10 21:47:44 UTC (rev 258230)
@@ -8,7 +8,7 @@
 [ 5: FAIL ] pixel_buffer_object.renderbuffer.rgba8i_triangles: gl.createProgram()
 [ 6: FAIL ] pixel_buffer_object.renderbuffer.rgba8i_clears: gl.createProgram()
 [ 7: FAIL ] pixel_buffer_object.renderbuffer.rgba8ui_triangles: useProgram failed
-[ 8: FAIL ] pixel_buffer_object.renderbuffer.rgba8ui_clears: rgba8ui_clears
+[ 8: PASS ] pixel_buffer_object.renderbuffer.rgba8ui_clears: rgba8ui_clears
 [ 9: FAIL ] pixel_buffer_object.renderbuffer.rgba16i_triangles: gl.createProgram()
 [ 10: FAIL ] pixel_buffer_object.renderbuffer.rgba16i_clears: gl.createProgram()
 [ 11: FAIL ] pixel_buffer_object.renderbuffer.rgba16ui_triangles: useProgram failed
@@ -46,5 +46,5 @@
 [ 43: FAIL ] pixel_buffer_object.renderbuffer.rg32ui_triangles: gl.createProgram()
 [ 44: FAIL ] pixel_buffer_object.renderbuffer.rg32ui_clears: gl.createProgram()
 [ 45: PASS ] successfullyParsed is true
-[ FAIL ] 40 failures reported
+[ FAIL ] 39 failures reported
 


Modified: trunk/LayoutTests/webgl/TestExpectations (258229 => 258230)

--- trunk/LayoutTests/webgl/TestExpectations	2020-03-10 21:27:17 UTC (rev 258229)
+++ trunk/LayoutTests/webgl/TestExpectations	2020-03-10 21:47:44 UTC (rev 258230)
@@ -9,6 +9,12 @@
 # Run as much of DEQP as possible
 webgl/2.0.0/deqp [ Pass Slow ]
 
+# Flaky time outs
+webgl/2.0.0/deqp/functional/gles3/shaderoperator/angle_and_trigonometry_01.html [ Timeout Pass ]
+
+# DEQP flaky results
+webgl/2.0.0/deqp/functional/gles3/builtinprecision [ Pass Failure ]
+
 # DEQP crashes
 webgl/2.0.0/deqp/functional/gles3/fbomultisample.2_samples.html [ Skip ]
 webgl/2.0.0/deqp/functional/gles3/fbomultisample.4_samples.html [ Skip ]
@@ -164,4 +170,6 @@
 webgl/2.0.0/deqp/functional/gles3/vertexarrays/multiple_attributes.output.html [ Skip ]
 webgl/2.0.0/deqp/functional/gles3/framebufferblit/default_framebuffer_03.html [ Skip ]
 webgl/2.0.0/deqp/functional/gles3/shaderoperator/angle_and_trigonometry_00.html [ Skip ]
-webgl/2.0.0/deqp/functional/gles3/texturefiltering/cube_combinations_05.html [ Skip ]
\ No newline at end of file
+webgl/2.0.0/deqp/functional/gles3/texturefiltering/cube_combinations_05.html [ Skip ]
+webgl/2.0.0/deqp/functional/gles3/framebufferblit/default_framebuffer_05.html [ Skip ]
+webgl/2.0.0/deqp/functional/gles3/vertexarrays/multiple_attributes.stride.html [ Skip ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257509] trunk/LayoutTests

[justin_fan]

Title: [257509] trunk/LayoutTests








Revision 257509
Author justin_...@apple.com
Date 2020-02-26 13:39:52 -0800 (Wed, 26 Feb 2020)


Log Message
[WebGL] Garden dedicated queue
https://bugs.webkit.org/show_bug.cgi?id=204547

Unreviewed test gardening.

One more pass to stabilize the WebGL bot.

* platform/ios/TestExpectations: Remove reference to non-existent test.
* webgl/2.0.0/deqp/functional/gles3/builtinprecision/acos-expected.txt:
* webgl/2.0.0/deqp/functional/gles3/builtinprecision/acosh-expected.txt:
* webgl/2.0.0/deqp/functional/gles3/builtinprecision/cosh-expected.txt:
* webgl/2.0.0/deqp/functional/gles3/builtinprecision/fract-expected.txt:
* webgl/2.0.0/deqp/functional/gles3/builtinprecision/pow-expected.txt:
* webgl/2.0.0/deqp/functional/gles3/builtinprecision/reflect-expected.txt:
* webgl/2.0.0/deqp/functional/gles3/builtinprecision/sinh-expected.txt:
* webgl/2.0.0/deqp/functional/gles3/pixelbufferobject-expected.txt:
* webgl/2.0.0/deqp/functional/gles3/texturefiltering/2d_combinations_01-expected.txt:
* webgl/2.0.0/deqp/functional/gles3/texturefiltering/cube_combinations_01-expected.txt:
* webgl/2.0.0/deqp/functional/gles3/texturespecification/basic_copyteximage2d-expected.txt:
* webgl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/builtinprecision/acos-expected.txt
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/builtinprecision/acosh-expected.txt
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/builtinprecision/cosh-expected.txt
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/builtinprecision/fract-expected.txt
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/builtinprecision/pow-expected.txt
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/builtinprecision/reflect-expected.txt
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/builtinprecision/sinh-expected.txt
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/pixelbufferobject-expected.txt
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/texturefiltering/2d_combinations_01-expected.txt
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/texturefiltering/cube_combinations_01-expected.txt
trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/texturespecification/basic_copyteximage2d-expected.txt
trunk/LayoutTests/webgl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (257508 => 257509)

--- trunk/LayoutTests/ChangeLog	2020-02-26 21:38:40 UTC (rev 257508)
+++ trunk/LayoutTests/ChangeLog	2020-02-26 21:39:52 UTC (rev 257509)
@@ -1,3 +1,26 @@
+2020-02-26  Justin Fan  
+
+[WebGL] Garden dedicated queue
+https://bugs.webkit.org/show_bug.cgi?id=204547
+
+Unreviewed test gardening.
+
+One more pass to stabilize the WebGL bot.
+
+* platform/ios/TestExpectations: Remove reference to non-existent test.
+* webgl/2.0.0/deqp/functional/gles3/builtinprecision/acos-expected.txt:
+* webgl/2.0.0/deqp/functional/gles3/builtinprecision/acosh-expected.txt:
+* webgl/2.0.0/deqp/functional/gles3/builtinprecision/cosh-expected.txt:
+* webgl/2.0.0/deqp/functional/gles3/builtinprecision/fract-expected.txt:
+* webgl/2.0.0/deqp/functional/gles3/builtinprecision/pow-expected.txt:
+* webgl/2.0.0/deqp/functional/gles3/builtinprecision/reflect-expected.txt:
+* webgl/2.0.0/deqp/functional/gles3/builtinprecision/sinh-expected.txt:
+* webgl/2.0.0/deqp/functional/gles3/pixelbufferobject-expected.txt:
+* webgl/2.0.0/deqp/functional/gles3/texturefiltering/2d_combinations_01-expected.txt:
+* webgl/2.0.0/deqp/functional/gles3/texturefiltering/cube_combinations_01-expected.txt:
+* webgl/2.0.0/deqp/functional/gles3/texturespecification/basic_copyteximage2d-expected.txt:
+* webgl/TestExpectations:
+
 2020-02-26  Per Arne Vollan  
 
 [iOS] Issue mach sandbox extensions to the WebContent process for a set of specific services


Modified: trunk/LayoutTests/platform/ios/TestExpectations (257508 => 257509)

--- trunk/LayoutTests/platform/ios/TestExpectations	2020-02-26 21:38:40 UTC (rev 257508)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2020-02-26 21:39:52 UTC (rev 257509)
@@ -3509,7 +3509,6 @@
 webkit.org/b/207858 webgl/webgl-backing-store-size-update.html [ Pass Failure ImageOnlyFailure ]
 webkit.org/b/207858 webgl/webgl-border.html [ Pass Failure ImageOnlyFailure ]
 webkit.org/b/207858 webgl/webgl-box-shadow.html [ Pass Failure ImageOnlyFailure ]
-webkit.org/b/207858 webgl/misc/switch-to-discrete-gpu.html [ Skip ]
 webkit.org/b/207858 fast/canvas/webgl/oes-texture-half-float-uint16.html [ Pass Failure ]
 webkit.org/b/207858 fast/canvas/webgl/program-test.html [ Failure ]
 webkit.org/b/207858 fast/canvas/webgl/uninitialized-test.html [ Pass Failure ]


Modified: trunk/LayoutTests/webgl/2.0.0/deqp/functional/gles3/builtinprecision/acos-expected.txt (257508 => 257509)

--- trunk/Layout

[webkit-changes] [257382] trunk/LayoutTests

[justin_fan]

Title: [257382] trunk/LayoutTests








Revision 257382
Author justin_...@apple.com
Date 2020-02-25 15:21:30 -0800 (Tue, 25 Feb 2020)


Log Message
[WebGL] More 2.0.0 conformance suite gardening after ANGLE rollout
https://bugs.webkit.org/show_bug.cgi?id=208211

Unreviewed test gardening.

Mark one more unsupported test as flaky, and add in Intel graphics-specific results for
5 tests that were failing consistently across all bots.


* TestExpectations:
* webgl/2.0.0/conformance/buffers/buffer-uninitialized-expected.txt:
* webgl/2.0.0/conformance/extensions/angle-instanced-arrays-expected.txt:
* webgl/2.0.0/conformance/rendering/clipping-wide-points-expected.txt:
* webgl/2.0.0/conformance2/rendering/clipping-wide-points-expected.txt:
* webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/webgl/2.0.0/conformance/buffers/buffer-uninitialized-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance/extensions/angle-instanced-arrays-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance/rendering/clipping-wide-points-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance2/rendering/clipping-wide-points-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (257381 => 257382)

--- trunk/LayoutTests/ChangeLog	2020-02-25 23:17:36 UTC (rev 257381)
+++ trunk/LayoutTests/ChangeLog	2020-02-25 23:21:30 UTC (rev 257382)
@@ -1,3 +1,20 @@
+2020-02-25  Justin Fan  
+
+[WebGL] More 2.0.0 conformance suite gardening after ANGLE rollout
+https://bugs.webkit.org/show_bug.cgi?id=208211
+
+Unreviewed test gardening.
+
+Mark one more unsupported test as flaky, and add in Intel graphics-specific results for 
+5 tests that were failing consistently across all bots.
+
+* TestExpectations:
+* webgl/2.0.0/conformance/buffers/buffer-uninitialized-expected.txt:
+* webgl/2.0.0/conformance/extensions/angle-instanced-arrays-expected.txt:
+* webgl/2.0.0/conformance/rendering/clipping-wide-points-expected.txt:
+* webgl/2.0.0/conformance2/rendering/clipping-wide-points-expected.txt:
+* webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit-expected.txt:
+
 2020-02-25  Jason Lawrence  
 
 [ Mac ] compositing/video/video-clip-change-src.html is flaky failing.


Modified: trunk/LayoutTests/TestExpectations (257381 => 257382)

--- trunk/LayoutTests/TestExpectations	2020-02-25 23:17:36 UTC (rev 257381)
+++ trunk/LayoutTests/TestExpectations	2020-02-25 23:21:30 UTC (rev 257382)
@@ -3356,12 +3356,22 @@
 # DEQP is skipped on the main fleet of bots because of the long run time.
 webgl/2.0.0/deqp [ Skip ]
 
-# webkit.org/b/208078 To-be-addressed WebGL 2 tests that generate inconsistent results
-webgl/2.0.0/conformance2/renderbuffers/multisample-with-full-sample-counts.html [ Skip ]
-webgl/2.0.0/conformance/extensions/webgl-draw-buffers.html [ Skip ]
-webgl/2.0.0/conformance2/buffers/buffer-data-and-buffer-sub-data-sub-source.html [ Skip ]
-webgl/2.0.0/conformance2/buffers/get-buffer-sub-data.html [ Skip ]
+# webkit.org/b/208078 To-be-addressed WebGL 2 tests that generate inconsistent results between devices
+webgl/2.0.0/conformance2/renderbuffers/multisample-with-full-sample-counts.html [ Pass Failure ]
+webgl/2.0.0/conformance/extensions/webgl-draw-buffers.html [ Pass Failure ]
+webgl/2.0.0/conformance2/buffers/buffer-data-and-buffer-sub-data-sub-source.html [ Pass Failure ]
+webgl/2.0.0/conformance2/buffers/get-buffer-sub-data.html [ Pass Failure ]
 
+# webkit.org/b/208211 Additional inconsitencies between Intel bots and AMD machine
+webgl/2.0.0/conformance/buffers/buffer-uninitialized.html [ Pass Failure ]
+webgl/2.0.0/conformance/extensions/angle-instanced-arrays.html [ Pass Failure ]
+webgl/2.0.0/conformance/rendering/clipping-wide-points.html [ Pass Failure ]
+webgl/2.0.0/conformance2/rendering/clipping-wide-points.html [ Pass Failure ]
+webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit.html [ Pass Failure ]
+
+# WebGL 2 To-be-implemented flaky tests
+webgl/2.0.0/conformance2/renderbuffers/multisampled-renderbuffer-initialization.html [ Pass Failure ]
+
 # To-be-addressed WebGL 2 Timeouts
 webgl/2.0.0/conformance/context/context-creation-and-destruction.html [ Skip ]
 webgl/2.0.0/conformance/context/context-creation.html [ Skip ]


Modified: trunk/LayoutTests/webgl/2.0.0/conformance/buffers/buffer-uninitialized-expected.txt (257381 => 257382)

--- trunk/LayoutTests/webgl/2.0.0/conformance/buffers/buffer-uninitialized-expected.txt	2020-02-25 23:17:36 UTC (rev 257381)
+++ trunk/LayoutTests/webgl/2.0.0/conformance/buffers/buffer-uninitialized-expected.txt	2020-02-25 23:21:30 UTC (rev 257382)
@@ -1,207 +1,5 @@
 This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
 
 Test: ../../resources/webgl_test_files/conforma

[webkit-changes] [257283] trunk/LayoutTests

[justin_fan]

Title: [257283] trunk/LayoutTests








Revision 257283
Author justin_...@apple.com
Date 2020-02-24 16:48:50 -0800 (Mon, 24 Feb 2020)


Log Message
[WebGL] Unskip runnable WebGL 2.0.0 conformance suite for mac
https://bugs.webkit.org/show_bug.cgi?id=208078

Unreviewed test gardening.

Actually run WebGL 2 tests. Update expectations for ANGLE backend.


* TestExpectations: Unskip non-DEQP WebGL 2.0.0 tests that do not crash nor timeout.
* platform/ios-wk2/TestExpectations: Continue to skip 2.0.0 on iOS WK2 until discrepancies can be addressed.
* webgl/2.0.0/conformance2/renderbuffers/framebuffer-object-attachment-expected.txt:
* webgl/2.0.0/conformance2/renderbuffers/invalidate-framebuffer-expected.txt:
* webgl/2.0.0/conformance2/renderbuffers/multisampled-renderbuffer-initialization-expected.txt:
* webgl/2.0.0/conformance2/rendering/blitframebuffer-test-expected.txt:
* webgl/2.0.0/conformance2/rendering/rgb-format-support-expected.txt:
* webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/webgl/2.0.0/conformance2/renderbuffers/framebuffer-object-attachment-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance2/renderbuffers/invalidate-framebuffer-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance2/renderbuffers/multisampled-renderbuffer-initialization-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance2/rendering/blitframebuffer-test-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance2/rendering/rgb-format-support-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (257282 => 257283)

--- trunk/LayoutTests/ChangeLog	2020-02-25 00:46:59 UTC (rev 257282)
+++ trunk/LayoutTests/ChangeLog	2020-02-25 00:48:50 UTC (rev 257283)
@@ -1,3 +1,21 @@
+2020-02-24  Justin Fan  
+
+[WebGL] Unskip runnable WebGL 2.0.0 conformance suite for mac
+https://bugs.webkit.org/show_bug.cgi?id=208078
+
+Unreviewed test gardening.
+
+Actually run WebGL 2 tests. Update expectations for ANGLE backend.
+
+* TestExpectations: Unskip non-DEQP WebGL 2.0.0 tests that do not crash nor timeout.
+* platform/ios-wk2/TestExpectations: Continue to skip 2.0.0 on iOS WK2 until discrepancies can be addressed.
+* webgl/2.0.0/conformance2/renderbuffers/framebuffer-object-attachment-expected.txt:
+* webgl/2.0.0/conformance2/renderbuffers/invalidate-framebuffer-expected.txt:
+* webgl/2.0.0/conformance2/renderbuffers/multisampled-renderbuffer-initialization-expected.txt:
+* webgl/2.0.0/conformance2/rendering/blitframebuffer-test-expected.txt:
+* webgl/2.0.0/conformance2/rendering/rgb-format-support-expected.txt:
+* webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit-expected.txt:
+
 2020-02-24  Jason Lawrence  
 
 [ Mac wk2 Debug ] is inspector/dom-debugger/attribute-modified-style.html is flaky crashing.


Modified: trunk/LayoutTests/TestExpectations (257282 => 257283)

--- trunk/LayoutTests/TestExpectations	2020-02-25 00:46:59 UTC (rev 257282)
+++ trunk/LayoutTests/TestExpectations	2020-02-25 00:48:50 UTC (rev 257283)
@@ -3340,14 +3340,591 @@
 
 webkit.org/b/197673 http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html [ Pass Failure Timeout ]
 
-# To aid transition to ANGLE backend for WebGL, skip all of WebGL 2 tests for now. 
-# Re-enable as each chunk of tests are verified with ANGLE backend.
-webgl/2.0.0 [ Skip ]
+# WebGL 2 Conformance Suite rules for regular bots post ANGLE backend adoption.
+# DEQP is skipped on the main fleet of bots because of the long run time.
+webgl/2.0.0/deqp [ Skip ]
 
-webgl/2.0.0/conformance2/samplers [ Pass ]
-webgl/2.0.0/conformance2/transform_feedback [ Pass ]
-webgl/2.0.0/conformance2/textures/misc/tex-image-and-sub-image-with-array-buffer-view-sub-source.html [ Pass ]
+# webkit.org/b/208078 To-be-addressed WebGL 2 tests that generate inconsistent results
+webgl/2.0.0/conformance2/renderbuffers/multisample-with-full-sample-counts.html [ Skip ]
+webgl/2.0.0/conformance/extensions/webgl-draw-buffers.html [ Skip ]
+webgl/2.0.0/conformance2/buffers/buffer-data-and-buffer-sub-data-sub-source.html [ Skip ]
+webgl/2.0.0/conformance2/buffers/get-buffer-sub-data.html [ Skip ]
 
+# To-be-addressed WebGL 2 Timeouts
+webgl/2.0.0/conformance/context/context-creation-and-destruction.html [ Skip ]
+webgl/2.0.0/conformance/context/context-creation.html [ Skip ]
+webgl/2.0.0/conformance/extensions/oes-texture-float-with-canvas.html [ Skip ]
+webgl/2.0.0/conformance/extensions/oes-texture-float-with-image.html [ Skip ]
+webgl/2.0.0/conformance/extensions/oes-texture-float-with-video.html [ Skip ]
+webgl/2.0.0/conformance/extensions/oes-texture-half-float-with-canvas.html [ Skip ]
+webgl/2.0.0/conformance/extensions/oes-texture-half-float-

[webkit-changes] [257073] trunk

[justin_fan]

Title: [257073] trunk








Revision 257073
Author justin_...@apple.com
Date 2020-02-20 11:33:58 -0800 (Thu, 20 Feb 2020)


Log Message
GraphicsContextGLOpenGL::transformFeedbackVaryings passes deallocated memory to gl::TransformFeedbackVaryings
https://bugs.webkit.org/show_bug.cgi?id=207526

Reviewed by Brent Fulgham.

Source/WebCore:

Covered by WebGL2 Transform Feedback tests.

* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLOpenGL::transformFeedbackVaryings):

LayoutTests:

Unskip known WebGL 2.0.0 conformance suite progressions.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (257072 => 257073)

--- trunk/LayoutTests/ChangeLog	2020-02-20 19:22:12 UTC (rev 257072)
+++ trunk/LayoutTests/ChangeLog	2020-02-20 19:33:58 UTC (rev 257073)
@@ -1,3 +1,14 @@
+2020-02-19  Justin Fan  
+
+GraphicsContextGLOpenGL::transformFeedbackVaryings passes deallocated memory to gl::TransformFeedbackVaryings
+https://bugs.webkit.org/show_bug.cgi?id=207526
+
+Reviewed by Brent Fulgham.
+
+Unskip known WebGL 2.0.0 conformance suite progressions.
+
+* TestExpectations:
+
 2020-02-20  Jason Lawrence  
 
 [ iOS wk2 Release ] perf/clone-with-focus.html is flaky failing.


Modified: trunk/LayoutTests/TestExpectations (257072 => 257073)

--- trunk/LayoutTests/TestExpectations	2020-02-20 19:22:12 UTC (rev 257072)
+++ trunk/LayoutTests/TestExpectations	2020-02-20 19:33:58 UTC (rev 257073)
@@ -3340,6 +3340,10 @@
 # Re-enable as each chunk of tests are verified with ANGLE backend.
 webgl/2.0.0 [ Skip ]
 
+webgl/2.0.0/conformance2/samplers [ Pass ]
+webgl/2.0.0/conformance2/transform_feedback [ Pass ]
+webgl/2.0.0/conformance2/textures/misc/tex-image-and-sub-image-with-array-buffer-view-sub-source.html [ Pass ]
+
 # pre-wrap progression. Other rendering engines agree with the result.
 webkit.org/b/206168 [ Debug ] fast/dom/insert-span-into-long-text-bug-28245.html [ Skip ]
 


Modified: trunk/Source/WebCore/ChangeLog (257072 => 257073)

--- trunk/Source/WebCore/ChangeLog	2020-02-20 19:22:12 UTC (rev 257072)
+++ trunk/Source/WebCore/ChangeLog	2020-02-20 19:33:58 UTC (rev 257073)
@@ -1,3 +1,15 @@
+2020-02-19  Justin Fan  
+
+GraphicsContextGLOpenGL::transformFeedbackVaryings passes deallocated memory to gl::TransformFeedbackVaryings
+https://bugs.webkit.org/show_bug.cgi?id=207526
+
+Reviewed by Brent Fulgham.
+
+Covered by WebGL2 Transform Feedback tests.
+
+* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
+(WebCore::GraphicsContextGLOpenGL::transformFeedbackVaryings):
+
 2020-02-20  Antti Koivisto  
 
 [macOS] Disable RunLoop function dispatch when there is a pending rendering update


Modified: trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp (257072 => 257073)

--- trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp	2020-02-20 19:22:12 UTC (rev 257072)
+++ trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp	2020-02-20 19:33:58 UTC (rev 257073)
@@ -1940,11 +1940,14 @@
 
 void GraphicsContextGLOpenGL::transformFeedbackVaryings(PlatformGLObject program, const Vector& varyings, GCGLenum bufferMode)
 {
-auto convertedVaryings = varyings.map([](const String& varying) -> const char* {
-return varying.utf8().data();
+Vector convertedVaryings = varyings.map([](const String& varying) {
+return varying.utf8();
 });
+Vector pointersToVaryings = convertedVaryings.map([](const CString& varying) {
+return varying.data();
+});
 makeContextCurrent();
-gl::TransformFeedbackVaryings(program, varyings.size(), convertedVaryings.data(), bufferMode);
+gl::TransformFeedbackVaryings(program, pointersToVaryings.size(), pointersToVaryings.data(), bufferMode);
 }
 
 void GraphicsContextGLOpenGL::getTransformFeedbackVarying(PlatformGLObject program, GCGLuint index, ActiveInfo& info)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255531] trunk

[justin_fan]

Title: [255531] trunk








Revision 255531
Author justin_...@apple.com
Date 2020-01-31 16:23:20 -0800 (Fri, 31 Jan 2020)


Log Message
[WebGL] Revert logging added to investigate 205757
https://bugs.webkit.org/show_bug.cgi?id=207076

Unreviewed.

Revert https://trac.webkit.org/changeset/255468.


Source/WebCore:

* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::bindTexture):
(WebCore::WebGLRenderingContextBase::createTexture):
(WebCore::WebGLRenderingContextBase::getError):
(WebCore::WebGLRenderingContextBase::texSubImage2D):
(WebCore::WebGLRenderingContextBase::texImage2D):
* platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:
(WebCore::GraphicsContextGLOpenGL::texImage2D):
* platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
(WebCore::GraphicsContextGLOpenGL::bindTexture):
(WebCore::GraphicsContextGLOpenGL::getError):
(WebCore::GraphicsContextGLOpenGL::texSubImage2D):
(WebCore::GraphicsContextGLOpenGL::createTexture):

LayoutTests:

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (255530 => 255531)

--- trunk/LayoutTests/ChangeLog	2020-02-01 00:14:35 UTC (rev 255530)
+++ trunk/LayoutTests/ChangeLog	2020-02-01 00:23:20 UTC (rev 255531)
@@ -1,3 +1,14 @@
+2020-01-31  Justin Fan  
+
+[WebGL] Revert logging added to investigate 205757
+https://bugs.webkit.org/show_bug.cgi?id=207076
+
+Unreviewed.
+
+Revert https://trac.webkit.org/changeset/255468.
+
+* TestExpectations:
+
 2020-01-31  Jacob Uphoff  
 
 [ macOS wk2 ] webgpu/whlsl/textures-sample-level.html is flaky failing


Modified: trunk/LayoutTests/TestExpectations (255530 => 255531)

--- trunk/LayoutTests/TestExpectations	2020-02-01 00:14:35 UTC (rev 255530)
+++ trunk/LayoutTests/TestExpectations	2020-02-01 00:23:20 UTC (rev 255531)
@@ -3492,9 +3492,4 @@
 
 webkit.org/b/206578 [ Debug ] imported/w3c/web-platform-tests/css/css-backgrounds/animations/border-image-width-interpolation.html [ Crash ]
 webkit.org/b/206579 [ Debug ] imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/zero-height-ratio-auto-5px.html [ Crash ]
-webkit.org/b/206579 [ Debug ] imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/zero-width-ratio-auto-5px.html [ Crash ]
-
-# Slow now due to added logging for unrelated investigation. Will be reverted.
-webkit.org/b/207006 fast/canvas/webgl/uniform-samplers-test.html [ Timeout ]
-webkit.org/b/207006 webgl/1.0.3/conformance/state/gl-object-get-calls.html [ Timeout ]
-webkit.org/b/207006 webgl/1.0.3/conformance/uniforms/uniform-samplers-test.html [ Timeout ]
\ No newline at end of file
+webkit.org/b/206579 [ Debug ] imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/zero-width-ratio-auto-5px.html [ Crash ]
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (255530 => 255531)

--- trunk/Source/WebCore/ChangeLog	2020-02-01 00:14:35 UTC (rev 255530)
+++ trunk/Source/WebCore/ChangeLog	2020-02-01 00:23:20 UTC (rev 255531)
@@ -1,3 +1,26 @@
+2020-01-31  Justin Fan  
+
+[WebGL] Revert logging added to investigate 205757
+https://bugs.webkit.org/show_bug.cgi?id=207076
+
+Unreviewed.
+
+Revert https://trac.webkit.org/changeset/255468.
+
+* html/canvas/WebGLRenderingContextBase.cpp:
+(WebCore::WebGLRenderingContextBase::bindTexture):
+(WebCore::WebGLRenderingContextBase::createTexture):
+(WebCore::WebGLRenderingContextBase::getError):
+(WebCore::WebGLRenderingContextBase::texSubImage2D):
+(WebCore::WebGLRenderingContextBase::texImage2D):
+* platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:
+(WebCore::GraphicsContextGLOpenGL::texImage2D):
+* platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
+(WebCore::GraphicsContextGLOpenGL::bindTexture):
+(WebCore::GraphicsContextGLOpenGL::getError):
+(WebCore::GraphicsContextGLOpenGL::texSubImage2D):
+(WebCore::GraphicsContextGLOpenGL::createTexture):
+
 2020-01-31  Antoine Quint  
 
 [Web Animations] [WK1] REGRESSION: opacity doesn't animate


Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (255530 => 255531)

--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2020-02-01 00:14:35 UTC (rev 255530)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2020-02-01 00:23:20 UTC (rev 255531)
@@ -1314,8 +1314,6 @@
 
 void WebGLRenderingContextBase::bindTexture(GCGLenum target, WebGLTexture* texture)
 {
-WTFLogAlways("[ WEBGL ] bindTexture()");
-
 bool del

[webkit-changes] [255468] trunk

[justin_fan]

Title: [255468] trunk








Revision 255468
Author justin_...@apple.com
Date 2020-01-30 16:23:55 -0800 (Thu, 30 Jan 2020)


Log Message
[WebGL] Add logging statements to attempt to catch texture-upload-size.html timeout
https://bugs.webkit.org/show_bug.cgi?id=207006

Source/WebCore:

Unreviewed temporary logging additions for flaky timeout investigation.


* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::bindTexture):
(WebCore::WebGLRenderingContextBase::createTexture):
(WebCore::WebGLRenderingContextBase::getError):
(WebCore::WebGLRenderingContextBase::texSubImage2D):
(WebCore::WebGLRenderingContextBase::texImage2D):
* platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:
(WebCore::GraphicsContextGLOpenGL::texImage2D):
* platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
(WebCore::GraphicsContextGLOpenGL::bindTexture):
(WebCore::GraphicsContextGLOpenGL::getError):
(WebCore::GraphicsContextGLOpenGL::texSubImage2D):
(WebCore::GraphicsContextGLOpenGL::createTexture):

LayoutTests:

Unreviewed temporary logging additions caused unrelated tests to time out.


* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (255467 => 255468)

--- trunk/LayoutTests/ChangeLog	2020-01-31 00:15:47 UTC (rev 255467)
+++ trunk/LayoutTests/ChangeLog	2020-01-31 00:23:55 UTC (rev 255468)
@@ -1,3 +1,12 @@
+2020-01-30  Justin Fan  
+
+[WebGL] Add logging statements to attempt to catch texture-upload-size.html timeout
+https://bugs.webkit.org/show_bug.cgi?id=207006
+
+Unreviewed temporary logging additions caused unrelated tests to time out.
+
+* TestExpectations:
+
 2020-01-30  Ryan Haddad  
 
 Regression: fast/hidpi/image-srcset-relative-svg-canvas-2x.html is consistently failing on iOS EWS


Modified: trunk/LayoutTests/TestExpectations (255467 => 255468)

--- trunk/LayoutTests/TestExpectations	2020-01-31 00:15:47 UTC (rev 255467)
+++ trunk/LayoutTests/TestExpectations	2020-01-31 00:23:55 UTC (rev 255468)
@@ -3493,3 +3493,8 @@
 webkit.org/b/206578 [ Debug ] imported/w3c/web-platform-tests/css/css-backgrounds/animations/border-image-width-interpolation.html [ Crash ]
 webkit.org/b/206579 [ Debug ] imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/zero-height-ratio-auto-5px.html [ Crash ]
 webkit.org/b/206579 [ Debug ] imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/zero-width-ratio-auto-5px.html [ Crash ]
+
+# Slow now due to added logging for unrelated investigation. Will be reverted.
+webkit.org/b/207006 fast/canvas/webgl/uniform-samplers-test.html [ Timeout ]
+webkit.org/b/207006 webgl/1.0.3/conformance/state/gl-object-get-calls.html [ Timeout ]
+webkit.org/b/207006 webgl/1.0.3/conformance/uniforms/uniform-samplers-test.html [ Timeout ]
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (255467 => 255468)

--- trunk/Source/WebCore/ChangeLog	2020-01-31 00:15:47 UTC (rev 255467)
+++ trunk/Source/WebCore/ChangeLog	2020-01-31 00:23:55 UTC (rev 255468)
@@ -1,3 +1,24 @@
+2020-01-30  Justin Fan  
+
+[WebGL] Add logging statements to attempt to catch texture-upload-size.html timeout
+https://bugs.webkit.org/show_bug.cgi?id=207006
+
+Unreviewed temporary logging additions for flaky timeout investigation.
+
+* html/canvas/WebGLRenderingContextBase.cpp:
+(WebCore::WebGLRenderingContextBase::bindTexture):
+(WebCore::WebGLRenderingContextBase::createTexture):
+(WebCore::WebGLRenderingContextBase::getError):
+(WebCore::WebGLRenderingContextBase::texSubImage2D):
+(WebCore::WebGLRenderingContextBase::texImage2D):
+* platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:
+(WebCore::GraphicsContextGLOpenGL::texImage2D):
+* platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
+(WebCore::GraphicsContextGLOpenGL::bindTexture):
+(WebCore::GraphicsContextGLOpenGL::getError):
+(WebCore::GraphicsContextGLOpenGL::texSubImage2D):
+(WebCore::GraphicsContextGLOpenGL::createTexture):
+
 2020-01-30  Per Arne Vollan  
 
 [iOS] Issue mach sandbox extension to the frontboard and icon service when the attachment element is enabled


Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (255467 => 255468)

--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2020-01-31 00:15:47 UTC (rev 255467)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2020-01-31 00:23:55 UTC (rev 255468)
@@ -1314,6 +1314,8 @@
 
 void WebGLRenderingContextBase::bindTexture(GCGLenum target, WebGLTexture

[webkit-changes] [255411] trunk/LayoutTests

[justin_fan]

Title: [255411] trunk/LayoutTests








Revision 255411
Author justin_...@apple.com
Date 2020-01-29 18:59:28 -0800 (Wed, 29 Jan 2020)


Log Message
[WebGL] Skip ANGLE-dependent WebGL 2 expected progressions on WebGL bot
https://bugs.webkit.org/show_bug.cgi?id=206977

Unreviewed test gardening.

These tests are expected to progress with ANGLE enabled, but since ANGLE is not enabled,
expect failure for now.


* webgl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255410 => 255411)

--- trunk/LayoutTests/ChangeLog	2020-01-30 02:42:49 UTC (rev 255410)
+++ trunk/LayoutTests/ChangeLog	2020-01-30 02:59:28 UTC (rev 255411)
@@ -1,3 +1,15 @@
+2020-01-29  Justin Fan  
+
+[WebGL] Skip ANGLE-dependent WebGL 2 expected progressions on WebGL bot
+https://bugs.webkit.org/show_bug.cgi?id=206977
+
+Unreviewed test gardening.
+
+These tests are expected to progress with ANGLE enabled, but since ANGLE is not enabled,
+expect failure for now.
+
+* webgl/TestExpectations:
+
 2020-01-29  Ryan Haddad  
 
 imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is timing out on Mojave wk1 debug EWS


Modified: trunk/LayoutTests/webgl/TestExpectations (255410 => 255411)

--- trunk/LayoutTests/webgl/TestExpectations	2020-01-30 02:42:49 UTC (rev 255410)
+++ trunk/LayoutTests/webgl/TestExpectations	2020-01-30 02:59:28 UTC (rev 255411)
@@ -3,6 +3,11 @@
 # Currently skipped due to fetching external resources.
 webgl/1.0.3/conformance/more/functions [ Skip ]
 
+# Expected ANGLE-based 2.0.0 progressions; mark as "failing" until ANGLE re-enabled.
+webgl/2.0.0/conformance2/samplers [ Fail ]
+webgl/2.0.0/conformance2/transform_feedback [ Fail ]
+webgl/2.0.0/conformance2/textures/misc/tex-image-and-sub-image-with-array-buffer-view-sub-source.html [ Fail ]
+
 # Tests crashing
 webgl/2.0.0/conformance2/renderbuffers/framebuffer-object-attachment.html [ Skip ]
 webgl/2.0.0/conformance2/rendering/draw-buffers.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255316] trunk

[justin_fan]

Title: [255316] trunk








Revision 255316
Author justin_...@apple.com
Date 2020-01-28 14:50:57 -0800 (Tue, 28 Jan 2020)


Log Message
[WebGL2] Implement sub-source texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=206782


Reviewed by Dean Jackson.

Source/WebCore:

Implement sub-source override versions of texImage2D and texSubImage2D.
Some refactoring of bufferData and bufferSubData to share code with new implementation.

Conformance test results updated for:
webgl/2.0.0/conformance2/buffers/buffer-data-and-buffer-sub-data-sub-source.html
webgl/2.0.0/conformance2/misc/views-with-offsets.html
webgl/2.0.0/conformance2/textures/misc/tex-image-and-sub-image-with-array-buffer-view-sub-source.html

* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::arrayBufferViewSliceFactory): Creates sub-resource of appropriate type for ArrayBufferView resources.
(WebCore::WebGL2RenderingContext::sliceArrayBufferView): Consolidates duplicate logic of buffer/SubData.
(WebCore::WebGL2RenderingContext::bufferData):
(WebCore::WebGL2RenderingContext::bufferSubData):
(WebCore::WebGL2RenderingContext::getBufferSubData): DataView buffers are allowed, and remove unnecessary elementSize helper function.
(WebCore::WebGL2RenderingContext::texImage2D): Implement sub-source version and improve log messaging for unimplemented overrides.
(WebCore::WebGL2RenderingContext::sliceTypedArrayBufferView): Creates sub-resource of appropriate type for TypedArray buffer resources.
(WebCore::WebGL2RenderingContext::texImage3D): Improve log messaging.
(WebCore::WebGL2RenderingContext::texSubImage2D): Implement sub-source version and improve log messaging for unimplemented overrides.
(WebCore::WebGL2RenderingContext::texSubImage3D): Improve log messaging.
(WebCore::WebGL2RenderingContext::compressedTexImage3D):
(WebCore::WebGL2RenderingContext::compressedTexSubImage3D):
(WebCore::WebGL2RenderingContext::compressedTexImage2D):
(WebCore::WebGL2RenderingContext::compressedTexSubImage2D):
(WebCore::WebGL2RenderingContext::readPixels):
(WebCore::arrayBufferViewElementSize): Deleted. Unnecessary given utilities in TypedArrayType.h.
* html/canvas/WebGL2RenderingContext.h:
* platform/graphics/GraphicsContextGL.h: Remove some extra overrides that aren't actually present in OpenGL ES 3.
* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
* platform/graphics/opengl/GraphicsContextGLOpenGL.h:
* platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
(WebCore::GraphicsContextGLOpenGL::texImage2D): Deleted.

LayoutTests:

Update expected results for ANGLE backend for texImage2D and texSubImage2D.

* webgl/2.0.0/conformance2/buffers/buffer-data-and-buffer-sub-data-sub-source-expected.txt:
Test was not fully running due to typo.
After fixing, 0 regression from running the fixed test on tip of tree with ANGLE enabled.
* webgl/2.0.0/conformance2/misc/views-with-offsets-expected.txt:
The 3 additional failures are not regressions, and total number of sub-tests run increased from 65 to 155.
* webgl/2.0.0/conformance2/textures/misc/tex-image-and-sub-image-with-array-buffer-view-sub-source-expected.txt:
Passes all texImage2D and texSubImage2D tests. The "3D" methods are not yet implemented.
* webgl/2.0.0/resources/webgl_test_files/conformance2/buffers/buffer-data-and-buffer-sub-data-sub-source.html:
Fix typo to actually run the test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgl/2.0.0/conformance2/buffers/buffer-data-and-buffer-sub-data-sub-source-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance2/misc/views-with-offsets-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance2/textures/misc/tex-image-and-sub-image-with-array-buffer-view-sub-source-expected.txt
trunk/LayoutTests/webgl/2.0.0/resources/webgl_test_files/conformance2/buffers/buffer-data-and-buffer-sub-data-sub-source.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h
trunk/Source/WebCore/platform/graphics/GraphicsContextGL.h
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (255315 => 255316)

--- trunk/LayoutTests/ChangeLog	2020-01-28 22:48:05 UTC (rev 255315)
+++ trunk/LayoutTests/ChangeLog	2020-01-28 22:50:57 UTC (rev 255316)
@@ -1,3 +1,23 @@
+2020-01-28  Justin Fan  
+
+[WebGL2] Implement sub-source texImage2D and texSubImage2D
+https://bugs.webkit.org/show_bug.cgi?id=206782
+
+
+Reviewed by Dean Jackson.
+
+Update expected results for ANGLE backend for texImage2D and texSubImage2D.
+
+* webgl/2.0.0/conformance2/buffers/buffer-data-and-buffer-sub-data-sub-source-expected.txt: 
+Test was not fully running due t

[webkit-changes] [254869] trunk

[justin_fan]

Title: [254869] trunk








Revision 254869
Author justin_...@apple.com
Date 2020-01-21 11:48:05 -0800 (Tue, 21 Jan 2020)


Log Message
[WebGL2] Sampler objects
https://bugs.webkit.org/show_bug.cgi?id=126941


Source/WebCore:

Implement enough of Samplers to pass the "samplers" conformance tests with ANGLE enabled.

Reviewed by Dean Jackson.

Covered by webgl/2.0.0/conformance2/samplers directory of tests.

* bindings/js/JSDOMConvertWebGL.cpp:
(WebCore::convertToJSValue):
* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::WebGL2RenderingContext):
(WebCore::WebGL2RenderingContext::initializeSamplerCache):
(WebCore::WebGL2RenderingContext::createSampler):
(WebCore::WebGL2RenderingContext::deleteSampler):
(WebCore::WebGL2RenderingContext::isSampler):
(WebCore::WebGL2RenderingContext::bindSampler):
(WebCore::WebGL2RenderingContext::samplerParameteri):
(WebCore::WebGL2RenderingContext::samplerParameterf):
(WebCore::WebGL2RenderingContext::getSamplerParameter):
(WebCore::WebGL2RenderingContext::bindTransformFeedback):
(WebCore::WebGL2RenderingContext::getParameter):
* html/canvas/WebGL2RenderingContext.h:
* html/canvas/WebGLAny.h:
* html/canvas/WebGLSampler.cpp:
(WebCore::WebGLSampler::WebGLSampler):
(WebCore::WebGLSampler::deleteObjectImpl):
* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLOpenGL::createSampler):
(WebCore::GraphicsContextGLOpenGL::deleteSampler):
(WebCore::GraphicsContextGLOpenGL::isSampler):
(WebCore::GraphicsContextGLOpenGL::bindSampler):
(WebCore::GraphicsContextGLOpenGL::samplerParameteri):
(WebCore::GraphicsContextGLOpenGL::samplerParameterf):
(WebCore::GraphicsContextGLOpenGL::getSamplerParameterfv):
(WebCore::GraphicsContextGLOpenGL::getSamplerParameteriv):

LayoutTests:

Reviewed by Dean Jackson.

Update to passing expectations, though these tests remain skipped until ANGLE backend is enabled.

* webgl/2.0.0/conformance2/samplers/sampler-drawing-test-expected.txt:
* webgl/2.0.0/conformance2/samplers/samplers-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgl/2.0.0/conformance2/samplers/sampler-drawing-test-expected.txt
trunk/LayoutTests/webgl/2.0.0/conformance2/samplers/samplers-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp
trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h
trunk/Source/WebCore/html/canvas/WebGLAny.h
trunk/Source/WebCore/html/canvas/WebGLSampler.cpp
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (254868 => 254869)

--- trunk/LayoutTests/ChangeLog	2020-01-21 19:40:47 UTC (rev 254868)
+++ trunk/LayoutTests/ChangeLog	2020-01-21 19:48:05 UTC (rev 254869)
@@ -1,3 +1,16 @@
+2020-01-21  Justin Fan  
+
+[WebGL2] Sampler objects
+https://bugs.webkit.org/show_bug.cgi?id=126941
+
+
+Reviewed by Dean Jackson.
+
+Update to passing expectations, though these tests remain skipped until ANGLE backend is enabled.
+
+* webgl/2.0.0/conformance2/samplers/sampler-drawing-test-expected.txt:
+* webgl/2.0.0/conformance2/samplers/samplers-expected.txt:
+
 2020-01-21  Sunny He  
 
 Disallow setting SVGElement currentScale to non-finite values


Modified: trunk/LayoutTests/webgl/2.0.0/conformance2/samplers/sampler-drawing-test-expected.txt (254868 => 254869)

--- trunk/LayoutTests/webgl/2.0.0/conformance2/samplers/sampler-drawing-test-expected.txt	2020-01-21 19:40:47 UTC (rev 254868)
+++ trunk/LayoutTests/webgl/2.0.0/conformance2/samplers/sampler-drawing-test-expected.txt	2020-01-21 19:48:05 UTC (rev 254869)
@@ -1,8 +1,5 @@
-CONSOLE MESSAGE: line 85: TypeError: Argument 1 ('sampler') to WebGL2RenderingContext.samplerParameteri must be an instance of WebGLSampler
 This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
 
 Test: ../../resources/webgl_test_files/conformance2/samplers/sampler-drawing-test.html
-[ 1: PASS ] WebGL context exists
-[ 2: FAIL ] successfullyParsed should be true (of type boolean). Was undefined (of type undefined).
-[ FAIL ] 1 failures reported
+[ PASS ] All tests passed
 


Modified: trunk/LayoutTests/webgl/2.0.0/conformance2/samplers/samplers-expected.txt (254868 => 254869)

--- trunk/LayoutTests/webgl/2.0.0/conformance2/samplers/samplers-expected.txt	2020-01-21 19:40:47 UTC (rev 254868)
+++ trunk/LayoutTests/webgl/2.0.0/conformance2/samplers/samplers-expected.txt	2020-01-21 19:48:05 UTC (rev 254869)
@@ -1,163 +1,5 @@
 This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
 
 Test: ../../resources/webgl_test_files/conformance2/samplers/samplers.html
-[ 1: PASS ] WebGL context exists
-[ 2: PASS ] gl.SAMPLER_BINDING is 0x8919
-[ 3: PASS ] gl.getParameter(gl.SAMPLER_BINDING) is null
-[ 4: FAIL ] getError expected: NO_ERROR. Was INVALID_ENUM : SAMPLER_BINDING query should succeed
-

[webkit-changes] [254481] trunk

[justin_fan]

Title: [254481] trunk








Revision 254481
Author justin_...@apple.com
Date 2020-01-13 18:34:34 -0800 (Mon, 13 Jan 2020)


Log Message
[WebGL 2] Implement transform feedback and pass transform feedback conformance tests
https://bugs.webkit.org/show_bug.cgi?id=205823

Reviewed by Dean Jackson.

Source/WebCore:

Covered by webgl/2.0.0/conformance2/transform_feedback conformance tests.

* bindings/js/JSDOMConvertWebGL.cpp:
(WebCore::convertToJSValue):
* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::WebGL2RenderingContext):
(WebCore::WebGL2RenderingContext::~WebGL2RenderingContext):
(WebCore::WebGL2RenderingContext::initializeTransformFeedbackBufferCache):
(WebCore::WebGL2RenderingContext::getBufferSubData): ANGLE validation in mapBufferRange may fail; prevent copying from a nullptr.
(WebCore::WebGL2RenderingContext::vertexAttribIPointer):

Bare minimum stubs to get WebGLQuery passing transform_feedback tests:
(WebCore::WebGL2RenderingContext::createQuery):
(WebCore::WebGL2RenderingContext::beginQuery):
(WebCore::WebGL2RenderingContext::endQuery):
(WebCore::WebGL2RenderingContext::getQueryParameter):
(WebCore::WebGLQuery::WebGLQuery):
* html/canvas/WebGLQuery.h:

Transform feedback functions:
(WebCore::WebGL2RenderingContext::createTransformFeedback):
(WebCore::WebGL2RenderingContext::deleteTransformFeedback):
(WebCore::WebGL2RenderingContext::isTransformFeedback):
(WebCore::WebGL2RenderingContext::bindTransformFeedback):
(WebCore::WebGL2RenderingContext::beginTransformFeedback):
(WebCore::WebGL2RenderingContext::endTransformFeedback):
(WebCore::WebGL2RenderingContext::transformFeedbackVaryings):
(WebCore::WebGL2RenderingContext::getTransformFeedbackVarying):
* html/canvas/WebGLTransformFeedback.cpp:
(WebCore::WebGLTransformFeedback::WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::deleteObjectImpl):

Misc functions that needed added functionality:
(WebCore::WebGL2RenderingContext::bindBufferBase):
(WebCore::WebGL2RenderingContext::getIndexedParameter):
(WebCore::WebGL2RenderingContext::getParameter):

Helper functions to track WebGL2 state/objects:
(WebCore::WebGL2RenderingContext::uncacheDeletedBuffer):
* html/canvas/WebGL2RenderingContext.h:
* html/canvas/WebGLAny.h:
* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::setTarget):
* html/canvas/WebGLBuffer.h:
* html/canvas/WebGLQuery.cpp:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::validateAndCacheBufferBinding):
(WebCore::WebGLRenderingContextBase::bindBuffer):
(WebCore::WebGLRenderingContextBase::uncacheDeletedBuffer):
(WebCore::WebGLRenderingContextBase::deleteBuffer):
(WebCore::WebGLRenderingContextBase::getProgramParameter):
* html/canvas/WebGLRenderingContextBase.h:

Pipe new GraphicsContextGL methods to ANGLE:
* platform/graphics/GraphicsContextGL.h:
* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLOpenGL::vertexAttribIPointer):
(WebCore::GraphicsContextGLOpenGL::createQuery):
(WebCore::GraphicsContextGLOpenGL::beginQuery):
(WebCore::GraphicsContextGLOpenGL::endQuery):
(WebCore::GraphicsContextGLOpenGL::getQueryObjectuiv):
(WebCore::GraphicsContextGLOpenGL::createTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::deleteTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::isTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::bindTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::beginTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::endTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::transformFeedbackVaryings):
(WebCore::GraphicsContextGLOpenGL::getTransformFeedbackVarying):
(WebCore::GraphicsContextGLOpenGL::bindBufferBase):

Add missing unrelated GraphicsContextGL stubs for ANGLE builds:
* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLOpenGL::vertexAttribIPointer):
(WebCore::GraphicsContextGLOpenGL::getUniformBlockIndex):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformBlockiv):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformBlockName):
(WebCore::GraphicsContextGLOpenGL::uniformBlockBinding):
(WebCore::GraphicsContextGLOpenGL::createQuery):
(WebCore::GraphicsContextGLOpenGL::beginQuery):
(WebCore::GraphicsContextGLOpenGL::endQuery):
(WebCore::GraphicsContextGLOpenGL::getQueryObjectuiv):
(WebCore::GraphicsContextGLOpenGL::createTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::deleteTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::isTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::bindTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::beginTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::endTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::transformFeedbackVaryings):
(WebCore::GraphicsContextGLOpenGL::getTransformFeedbackVarying):
(WebCore::GraphicsContextGLOpenGL::bindBufferBase):
(WebCore::GraphicsContextGLOpenGL::bufferData):
(WebCore::GraphicsContextGLOpenGL::bufferSubData):
(WebCore::GraphicsContextGLOpenGL::getBufferSubData):
(WebCore::Grap

[webkit-changes] [254279] trunk/LayoutTests

[justin_fan]

Title: [254279] trunk/LayoutTests








Revision 254279
Author justin_...@apple.com
Date 2020-01-09 11:12:05 -0800 (Thu, 09 Jan 2020)


Log Message
[WebGL] Skip all webgl/2.0.0 tests, as ANGLE switch obsoletes all old expectated results
https://bugs.webkit.org/show_bug.cgi?id=205988

Unreviewed test gardening.

The WebGL dedicated queue will continue to run failing tests.
Normal bots will only enable 2.0.0 tests after development work confirms they are passing with ANGLE.


* TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (254278 => 254279)

--- trunk/LayoutTests/ChangeLog	2020-01-09 18:56:57 UTC (rev 254278)
+++ trunk/LayoutTests/ChangeLog	2020-01-09 19:12:05 UTC (rev 254279)
@@ -1,3 +1,16 @@
+2020-01-09  Justin Fan  
+
+[WebGL] Skip all webgl/2.0.0 tests, as ANGLE switch obsoletes all old expectated results
+https://bugs.webkit.org/show_bug.cgi?id=205988
+
+Unreviewed test gardening.
+
+The WebGL dedicated queue will continue to run failing tests.
+Normal bots will only enable 2.0.0 tests after development work confirms they are passing with ANGLE.
+
+* TestExpectations:
+* platform/mac/TestExpectations:
+
 2020-01-09  youenn fablet  
 
 REGRESSION: [ Mac wk2 ] http/wpt/service-workers/persistent-importScripts.html is a flaky failure


Modified: trunk/LayoutTests/TestExpectations (254278 => 254279)

--- trunk/LayoutTests/TestExpectations	2020-01-09 18:56:57 UTC (rev 254278)
+++ trunk/LayoutTests/TestExpectations	2020-01-09 19:12:05 UTC (rev 254279)
@@ -1556,27 +1556,6 @@
 
 webkit.org/b/139639 [ Debug ] cssom/non-subpixel-scroll-top-left-values.html [ Slow ]
 
-# These tests are generating inconsistent results between my machine (AMD) and test bots (INTEL)
-webkit.org/b/189641 webgl/2.0.0/conformance/buffers/buffer-uninitialized.html [ Skip ]
-webkit.org/b/189641 webgl/2.0.0/conformance/extensions/webgl-draw-buffers.html [ Skip ]
-webkit.org/b/189641 webgl/2.0.0/conformance/renderbuffers/feedback-loop.html [ Skip ] 
-webkit.org/b/189641 webgl/2.0.0/conformance/rendering/clipping-wide-points.html [ Skip ] 
-webkit.org/b/189641 webgl/2.0.0/conformance/textures/misc/copy-tex-image-2d-formats.html [ Skip ] 
-webkit.org/b/189641 webgl/2.0.0/conformance2/state/gl-object-get-calls.html [ Skip ]
-webkit.org/b/189641 webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit.html [ Skip ]
-
-webkit.org/b/189641 webgl/2.0.0/conformance/ogles/GL/acos/acos_001_to_006.html [ Skip ]
-webkit.org/b/189641 webgl/2.0.0/conformance/ogles/GL/asin/asin_001_to_006.html [ Skip ]
-webkit.org/b/189641 webgl/2.0.0/conformance/ogles/GL/atan/atan_001_to_008.html [ Skip ]
-webkit.org/b/189641 webgl/2.0.0/conformance/ogles/GL/faceforward/faceforward_001_to_006.html [ Skip ]
-webkit.org/b/189641 webgl/2.0.0/conformance/ogles/GL/floor/floor_001_to_006.html [ Skip ]
-webkit.org/b/189641 webgl/2.0.0/conformance/ogles/GL/functions/functions_001_to_008.html [ Skip ]
-webkit.org/b/189641 webgl/2.0.0/conformance/ogles/GL/log/log_001_to_008.html [ Skip ]
-webkit.org/b/189641 webgl/2.0.0/conformance/ogles/GL/log2/log2_001_to_008.html [ Skip ]
-webkit.org/b/189641 webgl/2.0.0/conformance/ogles/GL/mat/mat_001_to_008.html [ Skip ]
-
-webkit.org/b/189641 webgl/2.0.0/conformance2/rendering/blitframebuffer-filter-outofbounds.html [ Slow ]
-
 [ Debug ] fast/workers/worker-cloneport.html [ Slow ]
 
 # Imported W3C HTML/DOM ref tests that are failing.
@@ -2688,599 +2667,6 @@
 [ Debug ] imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html [ Pass Failure ]
 webkit.org/b/186574 media/video-buffering-allowed.html [ Pass Failure ]
 
-### WebL Conformance Suite 2.0.0 tests that do not yet have support as of webkit.org/b/189686. Enable as support is implemented. ###
-
-
-# Skip entire deqp suite; these will likely never be run as part of the normal LayoutTests.
-webgl/2.0.0/deqp [ Skip ]
-
-# This test spits out numbers in its failure messages that appear to be different between processes
-webkit.org/b/189686 webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test.html [ Skip ]
-
-# Skipping crashes and timeouts as of 9/17/2018 and checking in current expectations, including
-# failures and partially passing tests.  
-
-# conformance timeouts
-webgl/2.0.0/conformance/canvas/rapid-resizing.html [ Skip ]
-webgl/2.0.0/conformance/context/context-creation-and-destruction.html [ Skip ]
-webgl/2.0.0/conformance/context/context-creation.html [ Skip ]
-webgl/2.0.0/conformance/extensions/oes-texture-float-with-canvas.html [ Skip ]
-webgl/2.0.0/conformance/extensions/oes-texture-float-with-image.html [ Skip ]
-webgl/2.0.0/conformance/extensions/oes-texture-float-with-video.html [ Skip ]
-webgl/2.0.0/conformance/extensions/oes-texture-half-float-with-canvas.html [ Skip ]
-webgl/2.0.0/conformance/extensions/o

[webkit-changes] [252751] trunk/Source/WebCore

[justin_fan]

Title: [252751] trunk/Source/WebCore








Revision 252751
Author justin_...@apple.com
Date 2019-11-21 13:47:59 -0800 (Thu, 21 Nov 2019)


Log Message
[WebGL] Fix framebufferTexture2D with DEPTH_STENCIL_ATTACHMENT on ANGLE
https://bugs.webkit.org/show_bug.cgi?id=204433

Reviewed by Dean Jackson.

ANGLE expects requests for DEPTH_STENCIL_ATTACHMENT to not be split into two calls, as previous WebGL 1 backend required.

No new tests. Prevents conformance/extensions/webgl-depth-texture.html regression when run with the ANGLE backend.

* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::framebufferTexture2D):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (252750 => 252751)

--- trunk/Source/WebCore/ChangeLog	2019-11-21 21:42:42 UTC (rev 252750)
+++ trunk/Source/WebCore/ChangeLog	2019-11-21 21:47:59 UTC (rev 252751)
@@ -1,3 +1,17 @@
+2019-11-21  Justin Fan  
+
+[WebGL] Fix framebufferTexture2D with DEPTH_STENCIL_ATTACHMENT on ANGLE
+https://bugs.webkit.org/show_bug.cgi?id=204433
+
+Reviewed by Dean Jackson.
+
+ANGLE expects requests for DEPTH_STENCIL_ATTACHMENT to not be split into two calls, as previous WebGL 1 backend required.
+
+No new tests. Prevents conformance/extensions/webgl-depth-texture.html regression when run with the ANGLE backend.
+
+* html/canvas/WebGLRenderingContextBase.cpp:
+(WebCore::WebGLRenderingContextBase::framebufferTexture2D):
+
 2019-11-21  Zalan Bujtas  
 
 [LFC][IFC] Cache trailing trimmable width.


Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (252750 => 252751)

--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2019-11-21 21:42:42 UTC (rev 252750)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2019-11-21 21:47:59 UTC (rev 252751)
@@ -2472,20 +2472,15 @@
 return;
 }
 Platform3DObject textureObject = objectOrZero(texture);
-switch (attachment) {
-case GraphicsContext3D::DEPTH_STENCIL_ATTACHMENT:
+
+#if !USE_ANGLE
+if (attachment == GraphicsContext3D::DEPTH_STENCIL_ATTACHMENT) {
 m_context->framebufferTexture2D(target, GraphicsContext3D::DEPTH_ATTACHMENT, textarget, textureObject, level);
 m_context->framebufferTexture2D(target, GraphicsContext3D::STENCIL_ATTACHMENT, textarget, textureObject, level);
-break;
-case GraphicsContext3D::DEPTH_ATTACHMENT:
+} else
+#endif
 m_context->framebufferTexture2D(target, attachment, textarget, textureObject, level);
-break;
-case GraphicsContext3D::STENCIL_ATTACHMENT:
-m_context->framebufferTexture2D(target, attachment, textarget, textureObject, level);
-break;
-default:
-m_context->framebufferTexture2D(target, attachment, textarget, textureObject, level);
-}
+
 targetFramebuffer->setAttachmentForBoundFramebuffer(attachment, textarget, texture, level);
 applyStencilTest();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [252715] trunk/LayoutTests

[justin_fan]

Title: [252715] trunk/LayoutTests








Revision 252715
Author justin_...@apple.com
Date 2019-11-20 15:31:01 -0800 (Wed, 20 Nov 2019)


Log Message
webgl/1.0.3/conformance/context/context-release-upon-reload.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=203984

Unreviewed test gardening. Skip the 2.0.0 version of this test as well.


* platform/mac-highsierra-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (252714 => 252715)

--- trunk/LayoutTests/ChangeLog	2019-11-20 23:21:10 UTC (rev 252714)
+++ trunk/LayoutTests/ChangeLog	2019-11-20 23:31:01 UTC (rev 252715)
@@ -1,3 +1,12 @@
+2019-11-20  Justin Fan  
+
+webgl/1.0.3/conformance/context/context-release-upon-reload.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=203984
+
+Unreviewed test gardening. Skip the 2.0.0 version of this test as well.
+
+* platform/mac-highsierra-wk1/TestExpectations:
+
 2019-11-20  Jonathan Bedard  
 
 [WebGL] Add `--webgl-test-suite` flag for run-webkit-tests


Modified: trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations (252714 => 252715)

--- trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations	2019-11-20 23:21:10 UTC (rev 252714)
+++ trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations	2019-11-20 23:31:01 UTC (rev 252715)
@@ -3,4 +3,5 @@
 # See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
 #
 
-webkit.org/b/203984 [ Debug ] webgl/1.0.3/conformance/context/context-release-upon-reload.html [ Skip ]
\ No newline at end of file
+webkit.org/b/203984 [ Debug ] webgl/1.0.3/conformance/context/context-release-upon-reload.html [ Skip ]
+webkit.org/b/203984 [ Debug ] webgl/2.0.0/conformance/context/context-release-upon-reload.html [ Skip ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [252225] trunk/LayoutTests

[justin_fan]

Title: [252225] trunk/LayoutTests








Revision 252225
Author justin_...@apple.com
Date 2019-11-07 17:35:31 -0800 (Thu, 07 Nov 2019)


Log Message
[WebGL] Fixing WebGL tests: Add new baselines for iOS bots
https://bugs.webkit.org/show_bug.cgi?id=203938

Unreviewed test expectation gardening.

Follow-up to https://bugs.webkit.org/show_bug.cgi?id=203908.
New baselines for iOS tests generated from simulator.


* TestExpectations:
* platform/ios/TestExpectations:
* platform/ios/webgl/1.0.3/conformance/extensions/get-extension-expected.txt: Added.
* platform/ios/webgl/1.0.3/conformance/extensions/oes-texture-float-expected.txt: Added.
* platform/ios/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit-expected.txt: Added.
* platform/ios/webgl/1.0.3/conformance/extensions/webgl-draw-buffers-expected.txt: Added.
* platform/ios/webgl/1.0.3/conformance/more/functions/readPixelsBadArgs-expected.txt: Added.
* platform/ios/webgl/1.0.3/conformance/more/functions/texImage2DHTML-expected.txt: Added.
* platform/ios/webgl/1.0.3/conformance/more/functions/texSubImage2DHTML-expected.txt: Added.
* platform/ios/webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Added.
* platform/ios/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt: Added.
* platform/ios/webgl/1.0.3/conformance/textures/texture-npot-video-expected.txt: Added.
* platform/ios/webgl/2.0.0/conformance/extensions/angle-instanced-arrays-expected.txt: Added.
* platform/ios/webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/ios/TestExpectations


Added Paths

trunk/LayoutTests/platform/ios/webgl/1.0.3/
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/extensions/
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/extensions/get-extension-expected.txt
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/extensions/oes-texture-float-expected.txt
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit-expected.txt
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/extensions/webgl-draw-buffers-expected.txt
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/more/
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/more/functions/
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/more/functions/readPixelsBadArgs-expected.txt
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/more/functions/texImage2DHTML-expected.txt
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/more/functions/texSubImage2DHTML-expected.txt
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/renderbuffers/
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment-expected.txt
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/textures/
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt
trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/textures/texture-npot-video-expected.txt
trunk/LayoutTests/platform/ios/webgl/2.0.0/conformance/extensions/
trunk/LayoutTests/platform/ios/webgl/2.0.0/conformance/extensions/angle-instanced-arrays-expected.txt
trunk/LayoutTests/platform/ios/webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (252224 => 252225)

--- trunk/LayoutTests/ChangeLog	2019-11-08 01:29:07 UTC (rev 252224)
+++ trunk/LayoutTests/ChangeLog	2019-11-08 01:35:31 UTC (rev 252225)
@@ -1,5 +1,30 @@
 2019-11-07  Justin Fan  
 
+[WebGL] Fixing WebGL tests: Add new baselines for iOS bots
+https://bugs.webkit.org/show_bug.cgi?id=203938
+
+Unreviewed test expectation gardening.
+
+Follow-up to https://bugs.webkit.org/show_bug.cgi?id=203908.
+New baselines for iOS tests generated from simulator.
+
+* TestExpectations:
+* platform/ios/TestExpectations:
+* platform/ios/webgl/1.0.3/conformance/extensions/get-extension-expected.txt: Added.
+* platform/ios/webgl/1.0.3/conformance/extensions/oes-texture-float-expected.txt: Added.
+* platform/ios/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit-expected.txt: Added.
+* platform/ios/webgl/1.0.3/conformance/extensions/webgl-draw-buffers-expected.txt: Added.
+* platform/ios/webgl/1.0.3/conformance/more/functions/readPixelsBadArgs-expected.txt: Added.
+* platform/ios/webgl/1.0.3/conformance/more/functions/texImage2DHTML-expected.txt: Added.
+* platform/ios/webgl/1.0.3/conformance/more/functions/texSubImage2DHTML-expected.txt: Added.
+* platform/ios/webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Added.
+* platform/ios/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expecte

[webkit-changes] [252222] trunk/LayoutTests

[justin_fan]

Title: [25] trunk/LayoutTests








Revision 25
Author justin_...@apple.com
Date 2019-11-07 17:15:24 -0800 (Thu, 07 Nov 2019)


Log Message
webgl/1.0.3/conformance/context/context-release-upon-reload.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=203984

Unreviewed test expectation addition.

Skip context-release-upon-reload.html on High Sierra WK1 debug bots.

* platform/mac-highsierra-wk1/TestExpectations: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (252221 => 25)

--- trunk/LayoutTests/ChangeLog	2019-11-08 01:13:19 UTC (rev 252221)
+++ trunk/LayoutTests/ChangeLog	2019-11-08 01:15:24 UTC (rev 25)
@@ -1,3 +1,14 @@
+2019-11-07  Justin Fan  
+
+webgl/1.0.3/conformance/context/context-release-upon-reload.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=203984
+
+Unreviewed test expectation addition.
+
+Skip context-release-upon-reload.html on High Sierra WK1 debug bots.
+
+* platform/mac-highsierra-wk1/TestExpectations: Added.
+
 2019-11-07  Ryosuke Niwa  
 
 WindowEventLoop should be shared among similar origin documents


Added: trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations (0 => 25)

--- trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations	(rev 0)
+++ trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations	2019-11-08 01:15:24 UTC (rev 25)
@@ -0,0 +1,6 @@
+# These are the layout test expectations for Apple's Mac port of WebKit Legacy
+#
+# See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
+#
+
+webkit.org/b/203984 [ Debug ] webgl/1.0.3/conformance/context/context-release-upon-reload.html [ Skip ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [252204] trunk/LayoutTests

[justin_fan]

Title: [252204] trunk/LayoutTests








Revision 252204
Author justin_...@apple.com
Date 2019-11-07 13:34:15 -0800 (Thu, 07 Nov 2019)


Log Message
REGRESSION: r252121 introduced timeout in webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html
https://bugs.webkit.org/show_bug.cgi?id=203949

Unreviewed test expectation gardening.

shader-with-non-reserved-words takes dozens of minutes to pass. Skip everywhere.

* platform/gtk/TestExpectations:
* platform/ios-simulator-wk2/TestExpectations:
* platform/mac/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (252203 => 252204)

--- trunk/LayoutTests/ChangeLog	2019-11-07 21:07:42 UTC (rev 252203)
+++ trunk/LayoutTests/ChangeLog	2019-11-07 21:34:15 UTC (rev 252204)
@@ -1,3 +1,17 @@
+2019-11-07  Justin Fan  
+
+REGRESSION: r252121 introduced timeout in webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html
+https://bugs.webkit.org/show_bug.cgi?id=203949
+
+Unreviewed test expectation gardening.
+
+shader-with-non-reserved-words takes dozens of minutes to pass. Skip everywhere.
+
+* platform/gtk/TestExpectations:
+* platform/ios-simulator-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2019-11-07  Devin Rousso  
 
 Web Inspector: REGRESSION(r250087): inspector/model/remote-object.html is timing out


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (252203 => 252204)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2019-11-07 21:07:42 UTC (rev 252203)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2019-11-07 21:34:15 UTC (rev 252204)
@@ -473,7 +473,6 @@
 webkit.org/b/169917 webgl/1.0.3/conformance/context/context-creation-and-destruction.html [ Pass Timeout ]
 webkit.org/b/169917 webgl/1.0.3/conformance/extensions/oes-texture-float-with-video.html [ Timeout ]
 webkit.org/b/169917 webgl/1.0.3/conformance/glsl/misc/shader-uniform-packing-restrictions.html [ Slow ]
-webkit.org/b/169917 webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html [ Slow ]
 webkit.org/b/169917 webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Slow ]
 webkit.org/b/169917 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html [ Timeout ]
 webkit.org/b/169917 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba.html [ Timeout ]


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (252203 => 252204)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2019-11-07 21:07:42 UTC (rev 252203)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2019-11-07 21:34:15 UTC (rev 252204)
@@ -18,8 +18,6 @@
 
 webkit.org/b/173178 [ Release ] svg/animations/svglength-element-removed-crash.svg [ Skip ]
 
-webkit.org/b/174100 webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html [ Skip ]
-
 webkit.org/b/173010 js/slow-stress/Int32Array-alloc-huge.html [ Pass Timeout ]
 
 webkit.org/b/174183 animations/resume-after-page-cache.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/mac/TestExpectations (252203 => 252204)

--- trunk/LayoutTests/platform/mac/TestExpectations	2019-11-07 21:07:42 UTC (rev 252203)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2019-11-07 21:34:15 UTC (rev 252204)
@@ -398,8 +398,6 @@
 webgl/1.0.3/conformance/context/context-creation-and-destruction.html [ Pass Timeout ]
 webgl/1.0.3/conformance/rendering/multisample-corruption.html [ Pass Timeout ]
 
-webkit.org/b/124935 [ Debug ] webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html [ Slow ]
-
 # Skip 1.0.3 tests that pass in conformance suite but timeout in TestRunner
 webgl/1.0.3/conformance/more/glsl [ Skip ]
 webgl/1.0.3/conformance/more/conformance [ Skip ]


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (252203 => 252204)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2019-11-07 21:07:42 UTC (rev 252203)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2019-11-07 21:34:15 UTC (rev 252204)
@@ -1072,7 +1072,6 @@
 webkit.org/b/159754 workers/bomb.html [ Skip ]
 
 webkit.org/b/169917 webgl/1.0.3/conformance/glsl/misc/shader-uniform-packing-restrictions.html [ Slow ]
-webkit.org/b/169917 webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html [ Slow ]
 webkit.org/b/169917 webgl/1.0.3/conformance/uniforms/gl-uniform-arrays.html [ Slow ]
 webkit.org/b/169917 webgl/1.0.3/conformance/uniforms/out-of-bounds-uniform-array-access.html [ Slow ]
 webkit.org/b/169917 webgl/1.0.3/conformance/glsl/bugs/temp-expressions-should-not-crash.html [ Slow ]

[webkit-changes] [250885] trunk/LayoutTests

[justin_fan]

Title: [250885] trunk/LayoutTests








Revision 250885
Author justin_...@apple.com
Date 2019-10-08 20:31:45 -0700 (Tue, 08 Oct 2019)


Log Message
WebGPU tests are skipped on iOS
https://bugs.webkit.org/show_bug.cgi?id=192889

Unreviewed test expectation updates.

Unskip WebGPU tests on iOS devices while skipping on simulator.

* platform/ios-simulator/TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (250884 => 250885)

--- trunk/LayoutTests/ChangeLog	2019-10-09 02:12:04 UTC (rev 250884)
+++ trunk/LayoutTests/ChangeLog	2019-10-09 03:31:45 UTC (rev 250885)
@@ -1,3 +1,15 @@
+2019-10-08  Justin Fan  
+
+WebGPU tests are skipped on iOS
+https://bugs.webkit.org/show_bug.cgi?id=192889
+
+Unreviewed test expectation updates.
+
+Unskip WebGPU tests on iOS devices while skipping on simulator.
+
+* platform/ios-simulator/TestExpectations:
+* platform/ios/TestExpectations:
+
 2019-10-08  Myles C. Maxfield  
 
 Make fast/text/complex-initial-advance.html more robust


Modified: trunk/LayoutTests/platform/ios/TestExpectations (250884 => 250885)

--- trunk/LayoutTests/platform/ios/TestExpectations	2019-10-09 02:12:04 UTC (rev 250884)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2019-10-09 03:31:45 UTC (rev 250885)
@@ -41,8 +41,6 @@
 compositing/no-compositing-when-fulll-screen-is-present.html
 webkit.org/b/200308 fast/events/touch/ios/content-observation/non-visible-content-change-in-fullscreen-mode.html [ Skip ]
 
-# WebGPU is not enabled on iOS Simulator.
-webgpu [ Skip ]
 inspector/canvas/create-context-webgpu.html [ Skip ]
 inspector/canvas/requestClientNodes-webgpu.html [ Skip ]
 inspector/canvas/requestShaderSource-webgpu.html [ Skip ]


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (250884 => 250885)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2019-10-09 02:12:04 UTC (rev 250884)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2019-10-09 03:31:45 UTC (rev 250885)
@@ -131,3 +131,6 @@
 webkit.org/b/201509 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_timeupdate_on_seek.html [ Failure ]
 
 webkit.org/b/202648 crypto/workers/subtle/aes-indexeddb.html [ Skip ]
+
+# WebGPU is not enabled on iOS Simulator.
+webgpu [ Skip ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250101] trunk/Websites/webkit.org

[justin_fan]

Title: [250101] trunk/Websites/webkit.org








Revision 250101
Author justin_...@apple.com
Date 2019-09-19 12:36:35 -0700 (Thu, 19 Sep 2019)


Log Message
[WebGPU] Update messaging to reflect STP 92 requirement for demos
https://bugs.webkit.org/show_bug.cgi?id=201931

Reviewed by Jon Lee.

Demos don't work anymore on versions of Safari older than STP 92,
so update WebGPU feature detection to reflect that.

* demos/webgpu/babylon/babylonWebGpu.max.js:
* demos/webgpu/babylon/oneHelmetWebGPU.html:
* demos/webgpu/babylon/oneSphereWebGPU.html:
* demos/webgpu/compute-blur.html:
* demos/webgpu/compute-boids-compile.html:
* demos/webgpu/compute-boids.html:
* demos/webgpu/hello-cube.html:
* demos/webgpu/hello-triangle.html:
* demos/webgpu/scripts/compute-blur.js:
(async.init):
* demos/webgpu/scripts/compute-boids-compile.js:
* demos/webgpu/scripts/hello-triangle.js:
(async.helloTriangle):
* demos/webgpu/textured-cube.html:

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/demos/webgpu/babylon/babylonWebGpu.max.js
trunk/Websites/webkit.org/demos/webgpu/babylon/oneHelmetWebGPU.html
trunk/Websites/webkit.org/demos/webgpu/babylon/oneSphereWebGPU.html
trunk/Websites/webkit.org/demos/webgpu/compute-blur.html
trunk/Websites/webkit.org/demos/webgpu/compute-boids-compile.html
trunk/Websites/webkit.org/demos/webgpu/compute-boids.html
trunk/Websites/webkit.org/demos/webgpu/hello-cube.html
trunk/Websites/webkit.org/demos/webgpu/hello-triangle.html
trunk/Websites/webkit.org/demos/webgpu/scripts/compute-blur.js
trunk/Websites/webkit.org/demos/webgpu/scripts/compute-boids-compile.js
trunk/Websites/webkit.org/demos/webgpu/scripts/hello-triangle.js
trunk/Websites/webkit.org/demos/webgpu/textured-cube.html




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (250100 => 250101)

--- trunk/Websites/webkit.org/ChangeLog	2019-09-19 19:19:37 UTC (rev 250100)
+++ trunk/Websites/webkit.org/ChangeLog	2019-09-19 19:36:35 UTC (rev 250101)
@@ -1,3 +1,28 @@
+2019-09-19  Justin Fan  
+
+[WebGPU] Update messaging to reflect STP 92 requirement for demos
+https://bugs.webkit.org/show_bug.cgi?id=201931
+
+Reviewed by Jon Lee.
+
+Demos don't work anymore on versions of Safari older than STP 92,
+so update WebGPU feature detection to reflect that.
+
+* demos/webgpu/babylon/babylonWebGpu.max.js:
+* demos/webgpu/babylon/oneHelmetWebGPU.html:
+* demos/webgpu/babylon/oneSphereWebGPU.html:
+* demos/webgpu/compute-blur.html:
+* demos/webgpu/compute-boids-compile.html:
+* demos/webgpu/compute-boids.html:
+* demos/webgpu/hello-cube.html:
+* demos/webgpu/hello-triangle.html:
+* demos/webgpu/scripts/compute-blur.js:
+(async.init):
+* demos/webgpu/scripts/compute-boids-compile.js:
+* demos/webgpu/scripts/hello-triangle.js:
+(async.helloTriangle):
+* demos/webgpu/textured-cube.html:
+
 2019-09-18  Myles C. Maxfield  
 
 [WebGPU] Update demos to work on STP 92


Modified: trunk/Websites/webkit.org/demos/webgpu/babylon/babylonWebGpu.max.js (250100 => 250101)

--- trunk/Websites/webkit.org/demos/webgpu/babylon/babylonWebGpu.max.js	2019-09-19 19:19:37 UTC (rev 250100)
+++ trunk/Websites/webkit.org/demos/webgpu/babylon/babylonWebGpu.max.js	2019-09-19 19:36:35 UTC (rev 250101)
@@ -41963,7 +41963,7 @@
 _this._decodeEngine.getCaps().textureHalfFloat = false;
 _this._decodeEngine.getCaps().textureHalfFloatRender = false;
 _Misc_logger__WEBPACK_IMPORTED_MODULE_1__["Logger"].Log("Babylon.js v" + _Engines_engine__WEBPACK_IMPORTED_MODULE_4__["Engine"].Version + " - WebGPU engine");
-if (!navigator.gpu) {
+if (!navigator.gpu || GPUBufferUsage.COPY_SRC === undefined) {
 _Misc_logger__WEBPACK_IMPORTED_MODULE_1__["Logger"].Error("WebGPU is not supported by your browser.");
 return _this;
 }


Modified: trunk/Websites/webkit.org/demos/webgpu/babylon/oneHelmetWebGPU.html (250100 => 250101)

--- trunk/Websites/webkit.org/demos/webgpu/babylon/oneHelmetWebGPU.html	2019-09-19 19:19:37 UTC (rev 250100)
+++ trunk/Websites/webkit.org/demos/webgpu/babylon/oneHelmetWebGPU.html	2019-09-19 19:36:35 UTC (rev 250101)
@@ -175,8 +175,8 @@
 let Shaderc = {Compiler, CompileOptions, shader_kind: ShaderKind};
 
 (async function() {
-if (!navigator.gpu) {
-alert("WebGPU is not enabled.");
+if (!navigator.gpu || GPUBufferUsage.COPY_SRC === undefined) {
+alert("WebGPU is not enabled. Are you using Safari Technology Preview 92 or above?");
 return;
 }
 const canvas = document.getElementById("renderCanvas");


Modified: trunk/Websites/webkit.org/demos/webgpu/babylon/oneSphereWebGPU.html (250100 => 250101)

--- trunk/Websites/webkit.org/demos/webgpu/babylon/oneSphereWebGPU.html	2019-09-19 19:19:37 UTC (rev 250100)
+++ trunk/Websites/webkit.org/demos/webgpu/babylon/oneSp

[webkit-changes] [249881] trunk/Source/WebCore

[justin_fan]

Title: [249881] trunk/Source/WebCore








Revision 249881
Author justin_...@apple.com
Date 2019-09-14 15:31:02 -0700 (Sat, 14 Sep 2019)


Log Message
[WebGPU] Make WebGPURenderPipeline and WebGPUComputePipeline inherit from GPUObjectBase
https://bugs.webkit.org/show_bug.cgi?id=201207

Reviewed by Dean Jackson.

Make remaining WebGPU "client" classes manage their error scopes, instead of the internal classes.
Matches Web/GPUBuffer, and allows "invalid" WebGPU objects to create errors.

Covered by existing tests.

* Modules/webgpu/WebGPUComputePipeline.cpp:
(WebCore::WebGPUComputePipeline::create):
(WebCore::WebGPUComputePipeline::WebGPUComputePipeline):
* Modules/webgpu/WebGPUComputePipeline.h:
* Modules/webgpu/WebGPUDevice.cpp:
(WebCore::WebGPUDevice::createRenderPipeline const):
(WebCore::WebGPUDevice::createComputePipeline const):
* Modules/webgpu/WebGPURenderPipeline.cpp:
(WebCore::WebGPURenderPipeline::create):
(WebCore::WebGPURenderPipeline::WebGPURenderPipeline):
* Modules/webgpu/WebGPURenderPipeline.h:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/gpu/GPUComputePipeline.h:
* platform/graphics/gpu/GPURenderPipeline.h:
* platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:
(WebCore::GPUComputePipeline::tryCreate):
(WebCore::GPUComputePipeline::GPUComputePipeline):
* platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::GPURenderPipeline::tryCreate):
(WebCore::GPURenderPipeline::GPURenderPipeline):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webgpu/WebGPUComputePipeline.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUComputePipeline.h
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPURenderPipeline.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPURenderPipeline.h
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/gpu/GPUComputePipeline.h
trunk/Source/WebCore/platform/graphics/gpu/GPURenderPipeline.h
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (249880 => 249881)

--- trunk/Source/WebCore/ChangeLog	2019-09-14 19:36:29 UTC (rev 249880)
+++ trunk/Source/WebCore/ChangeLog	2019-09-14 22:31:02 UTC (rev 249881)
@@ -1,3 +1,36 @@
+2019-09-14  Justin Fan  
+
+[WebGPU] Make WebGPURenderPipeline and WebGPUComputePipeline inherit from GPUObjectBase
+https://bugs.webkit.org/show_bug.cgi?id=201207
+
+Reviewed by Dean Jackson.
+
+Make remaining WebGPU "client" classes manage their error scopes, instead of the internal classes.
+Matches Web/GPUBuffer, and allows "invalid" WebGPU objects to create errors.
+
+Covered by existing tests.
+
+* Modules/webgpu/WebGPUComputePipeline.cpp:
+(WebCore::WebGPUComputePipeline::create):
+(WebCore::WebGPUComputePipeline::WebGPUComputePipeline):
+* Modules/webgpu/WebGPUComputePipeline.h:
+* Modules/webgpu/WebGPUDevice.cpp:
+(WebCore::WebGPUDevice::createRenderPipeline const):
+(WebCore::WebGPUDevice::createComputePipeline const):
+* Modules/webgpu/WebGPURenderPipeline.cpp:
+(WebCore::WebGPURenderPipeline::create):
+(WebCore::WebGPURenderPipeline::WebGPURenderPipeline):
+* Modules/webgpu/WebGPURenderPipeline.h:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/graphics/gpu/GPUComputePipeline.h:
+* platform/graphics/gpu/GPURenderPipeline.h:
+* platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:
+(WebCore::GPUComputePipeline::tryCreate):
+(WebCore::GPUComputePipeline::GPUComputePipeline):
+* platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
+(WebCore::GPURenderPipeline::tryCreate):
+(WebCore::GPURenderPipeline::GPURenderPipeline):
+
 2019-09-14  Yusuke Suzuki  
 
 Retire x86 32bit JIT support


Modified: trunk/Source/WebCore/Modules/webgpu/WebGPUComputePipeline.cpp (249880 => 249881)

--- trunk/Source/WebCore/Modules/webgpu/WebGPUComputePipeline.cpp	2019-09-14 19:36:29 UTC (rev 249880)
+++ trunk/Source/WebCore/Modules/webgpu/WebGPUComputePipeline.cpp	2019-09-14 22:31:02 UTC (rev 249881)
@@ -30,13 +30,14 @@
 
 namespace WebCore {
 
-Ref WebGPUComputePipeline::create(RefPtr&& pipeline)
+Ref WebGPUComputePipeline::create(RefPtr&& pipeline, GPUErrorScopes& errorScopes)
 {
-return adoptRef(*new WebGPUComputePipeline(WTFMove(pipeline)));
+return adoptRef(*new WebGPUComputePipeline(WTFMove(pipeline), errorScopes));
 }
 
-WebGPUComputePipeline::WebGPUComputePipeline(RefPtr&& pipeline)
-: m_computePipeline { WTFMove(pipeline) }
+WebGPUComputePipeline::WebGPUComputePipeline(RefPtr&& pipeline, GPUErrorScopes& errorScopes)
+: GPUObjectBase(makeRef(errorScopes))
+, m_computePipeline { WTFMove(pipeline) }
 {
 }
 


Modified: trunk/Source/WebCore/Modules/webgpu/WebGPU

[webkit-changes] [249685] trunk/Websites/webkit.org

[justin_fan]

Title: [249685] trunk/Websites/webkit.org








Revision 249685
Author justin_...@apple.com
Date 2019-09-09 18:39:57 -0700 (Mon, 09 Sep 2019)


Log Message
[WebGPU] Upload Babylon.js, WSL compile, and MotionMark links to demo page
https://bugs.webkit.org/show_bug.cgi?id=201621

Reviewed by Dean Jackson.

Add new demos to the WebGPU demo collection.
Ensure error alerts/divs display properly if WebGPU is not enabled.

* demos/webgpu/babylon/oneHelmetWebGPU.html:
* demos/webgpu/babylon/oneSphereWebGPU.html:
* demos/webgpu/compute-blur.html:
* demos/webgpu/compute-boids-compile.html:
* demos/webgpu/compute-boids.html:
* demos/webgpu/hello-cube.html:
* demos/webgpu/hello-triangle.html:
* demos/webgpu/index.html:
* demos/webgpu/resources/babylon-helmet.png: Added.
* demos/webgpu/resources/babylon-sphere.png: Added.
* demos/webgpu/resources/motionmark.jpeg: Added.
* demos/webgpu/resources/webkit-logo.png: Added.
* demos/webgpu/scripts/compute-boids-compile.js:
* demos/webgpu/textured-cube.html:

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/demos/webgpu/babylon/oneHelmetWebGPU.html
trunk/Websites/webkit.org/demos/webgpu/babylon/oneSphereWebGPU.html
trunk/Websites/webkit.org/demos/webgpu/compute-blur.html
trunk/Websites/webkit.org/demos/webgpu/compute-boids-compile.html
trunk/Websites/webkit.org/demos/webgpu/compute-boids.html
trunk/Websites/webkit.org/demos/webgpu/hello-cube.html
trunk/Websites/webkit.org/demos/webgpu/hello-triangle.html
trunk/Websites/webkit.org/demos/webgpu/index.html
trunk/Websites/webkit.org/demos/webgpu/scripts/compute-boids-compile.js
trunk/Websites/webkit.org/demos/webgpu/textured-cube.html


Added Paths

trunk/Websites/webkit.org/demos/webgpu/resources/babylon-helmet.png
trunk/Websites/webkit.org/demos/webgpu/resources/babylon-sphere.png
trunk/Websites/webkit.org/demos/webgpu/resources/motionmark.jpeg
trunk/Websites/webkit.org/demos/webgpu/resources/webkit-logo.png




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (249684 => 249685)

--- trunk/Websites/webkit.org/ChangeLog	2019-09-10 01:39:18 UTC (rev 249684)
+++ trunk/Websites/webkit.org/ChangeLog	2019-09-10 01:39:57 UTC (rev 249685)
@@ -1,3 +1,28 @@
+2019-09-09  Justin Fan  
+
+[WebGPU] Upload Babylon.js, WSL compile, and MotionMark links to demo page
+https://bugs.webkit.org/show_bug.cgi?id=201621
+
+Reviewed by Dean Jackson.
+
+Add new demos to the WebGPU demo collection.
+Ensure error alerts/divs display properly if WebGPU is not enabled.
+
+* demos/webgpu/babylon/oneHelmetWebGPU.html:
+* demos/webgpu/babylon/oneSphereWebGPU.html:
+* demos/webgpu/compute-blur.html:
+* demos/webgpu/compute-boids-compile.html:
+* demos/webgpu/compute-boids.html:
+* demos/webgpu/hello-cube.html:
+* demos/webgpu/hello-triangle.html:
+* demos/webgpu/index.html:
+* demos/webgpu/resources/babylon-helmet.png: Added.
+* demos/webgpu/resources/babylon-sphere.png: Added.
+* demos/webgpu/resources/motionmark.jpeg: Added.
+* demos/webgpu/resources/webkit-logo.png: Added.
+* demos/webgpu/scripts/compute-boids-compile.js:
+* demos/webgpu/textured-cube.html:
+
 2019-09-09  Jon Lee  
 
 Add Babylon demos


Modified: trunk/Websites/webkit.org/demos/webgpu/babylon/oneHelmetWebGPU.html (249684 => 249685)

--- trunk/Websites/webkit.org/demos/webgpu/babylon/oneHelmetWebGPU.html	2019-09-10 01:39:18 UTC (rev 249684)
+++ trunk/Websites/webkit.org/demos/webgpu/babylon/oneHelmetWebGPU.html	2019-09-10 01:39:57 UTC (rev 249685)
@@ -176,7 +176,7 @@
 
 (async function() {
 if (!navigator.gpu) {
-alert("Web GPU is not supported on your platform so far.");
+alert("WebGPU is not enabled.");
 return;
 }
 const canvas = document.getElementById("renderCanvas");


Modified: trunk/Websites/webkit.org/demos/webgpu/babylon/oneSphereWebGPU.html (249684 => 249685)

--- trunk/Websites/webkit.org/demos/webgpu/babylon/oneSphereWebGPU.html	2019-09-10 01:39:18 UTC (rev 249684)
+++ trunk/Websites/webkit.org/demos/webgpu/babylon/oneSphereWebGPU.html	2019-09-10 01:39:57 UTC (rev 249685)
@@ -177,7 +177,7 @@
 
 (async function() {
 if (!navigator.gpu) {
-alert("Web GPU is not supported on your platform so far.");
+alert("WebGPU is not enabled.");
 return;
 }
 const canvas = document.getElementById("renderCanvas");


Modified: trunk/Websites/webkit.org/demos/webgpu/compute-blur.html (249684 => 249685)

--- trunk/Websites/webkit.org/demos/webgpu/compute-blur.html	2019-09-10 01:39:18 UTC (rev 249684)
+++ trunk/Websites/webkit.org/demos/webgpu/compute-blur.html	2019-09-10 01:39:57 UTC (rev 249685)
@@ -77,8 +77,8 @@
 WebGPU not available
 
 Make sure you are on a system with WebGPU enabled. In
-Safari, first make sure the Developer Menu is visible (Preferences â

[webkit-changes] [249555] trunk/LayoutTests

[justin_fan]

Title: [249555] trunk/LayoutTests








Revision 249555
Author justin_...@apple.com
Date 2019-09-05 16:42:52 -0700 (Thu, 05 Sep 2019)


Log Message
[WebGPU] Fix new test results after adding console warnings
https://bugs.webkit.org/show_bug.cgi?id=201526

Unreviewed test expectation updates.

* webgpu/buffer-errors-expected.txt:
* webgpu/map-read-buffers-expected.txt:
* webgpu/map-write-buffers-expected.txt:
* webgpu/render-pipelines.html: Fix WHLSL compile error.
* webgpu/uncaptured-errors-expected.txt: Added.
* webgpu/whlsl/use-undefined-variable-2-expected.txt:
* webgpu/whlsl/use-undefined-variable-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgpu/buffer-errors-expected.txt
trunk/LayoutTests/webgpu/map-read-buffers-expected.txt
trunk/LayoutTests/webgpu/map-write-buffers-expected.txt
trunk/LayoutTests/webgpu/render-pipelines.html
trunk/LayoutTests/webgpu/whlsl/use-undefined-variable-2-expected.txt
trunk/LayoutTests/webgpu/whlsl/use-undefined-variable-expected.txt


Added Paths

trunk/LayoutTests/webgpu/uncaptured-errors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (249554 => 249555)

--- trunk/LayoutTests/ChangeLog	2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/ChangeLog	2019-09-05 23:42:52 UTC (rev 249555)
@@ -1,3 +1,18 @@
+2019-09-05  Justin Fan  
+
+[WebGPU] Fix new test results after adding console warnings
+https://bugs.webkit.org/show_bug.cgi?id=201526
+
+Unreviewed test expectation updates.
+
+* webgpu/buffer-errors-expected.txt:
+* webgpu/map-read-buffers-expected.txt:
+* webgpu/map-write-buffers-expected.txt:
+* webgpu/render-pipelines.html: Fix WHLSL compile error.
+* webgpu/uncaptured-errors-expected.txt: Added.
+* webgpu/whlsl/use-undefined-variable-2-expected.txt:
+* webgpu/whlsl/use-undefined-variable-expected.txt:
+
 2019-09-05  Ryan Haddad  
 
 Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html is a flaky failure


Modified: trunk/LayoutTests/webgpu/buffer-errors-expected.txt (249554 => 249555)

--- trunk/LayoutTests/webgpu/buffer-errors-expected.txt	2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/webgpu/buffer-errors-expected.txt	2019-09-05 23:42:52 UTC (rev 249555)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: GPUDevice.createBuffer(): Buffer cannot have both MAP_READ and MAP_WRITE usage!
 
 PASS GPUBuffers can be created with both read-only and STORAGE usages. 
 PASS unmap on already unmapped, mappable GPUBuffer should not generate error. 


Modified: trunk/LayoutTests/webgpu/map-read-buffers-expected.txt (249554 => 249555)

--- trunk/LayoutTests/webgpu/map-read-buffers-expected.txt	2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/webgpu/map-read-buffers-expected.txt	2019-09-05 23:42:52 UTC (rev 249555)
@@ -1,3 +1,7 @@
+CONSOLE MESSAGE: GPUBuffer.mapReadAsync(): Invalid operation!
+CONSOLE MESSAGE: GPUBuffer.mapWriteAsync(): Invalid operation!
+CONSOLE MESSAGE: GPUBuffer.mapReadAsync(): Invalid operation!
+CONSOLE MESSAGE: GPUBuffer.mapReadAsync(): Invalid operation!
 
 PASS mapReadAsync, unmap, and destroy on a GPUBuffer. 
 PASS GPUBuffer.mapReadAsync on a buffer created via GPUDevice.createBufferMapped. 


Modified: trunk/LayoutTests/webgpu/map-write-buffers-expected.txt (249554 => 249555)

--- trunk/LayoutTests/webgpu/map-write-buffers-expected.txt	2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/webgpu/map-write-buffers-expected.txt	2019-09-05 23:42:52 UTC (rev 249555)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: GPUBuffer.mapWriteAsync(): Invalid operation!
+CONSOLE MESSAGE: GPUBuffer.mapWriteAsync(): Invalid operation!
 
 PASS Map write, unmap, and destroy a GPUBuffer. 
 PASS Reject a map write on a buffer not created with MAP_WRITE usage. 


Modified: trunk/LayoutTests/webgpu/render-pipelines.html (249554 => 249555)

--- trunk/LayoutTests/webgpu/render-pipelines.html	2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/webgpu/render-pipelines.html	2019-09-05 23:42:52 UTC (rev 249555)
@@ -5,7 +5,7 @@
 

[webkit-changes] [249539] trunk

[justin_fan]

Title: [249539] trunk








Revision 249539
Author justin_...@apple.com
Date 2019-09-05 12:21:58 -0700 (Thu, 05 Sep 2019)


Log Message
[WebGPU] Implement GPUUncapturedErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=199676

Reviewed by Dean Jackson.

Source/WebCore:

Implement GPUUncapturedErrorEvent and "uncapturederror" event name.
Add the onuncapturederror EventHandler attribute to GPUDevice.

Test: webgpu/uncaptured-errors.html

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Modules/webgpu/GPUUncapturedErrorEvent.cpp:
(WebCore::GPUUncapturedErrorEvent::create):
(WebCore::GPUUncapturedErrorEvent::GPUUncapturedErrorEvent):
(WebCore::GPUUncapturedErrorEvent::eventInterface const):
* Modules/webgpu/GPUUncapturedErrorEvent.h:
* Modules/webgpu/GPUUncapturedErrorEvent.idl:
* Modules/webgpu/WebGPUAdapter.cpp: Must now provide ScriptExecutionContext to any created GPUDevice.
(WebCore::WebGPUAdapter::requestDevice const):
* Modules/webgpu/WebGPUAdapter.h:
* Modules/webgpu/WebGPUAdapter.idl:
* Modules/webgpu/WebGPUDevice.cpp: Is now an EventTarget.
(WebCore::WebGPUDevice::tryCreate):
(WebCore::WebGPUDevice::WebGPUDevice):
(WebCore::printValidationErrorToConsole):
(WebCore::WebGPUDevice::dispatchUncapturedError): Events should only be fired from the main thread.
* Modules/webgpu/WebGPUDevice.h:
* Modules/webgpu/WebGPUDevice.idl:
* Modules/webgpu/WebGPUDeviceEventHandler.idl:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:
* dom/EventNames.h:
* dom/EventNames.in:
* dom/EventTargetFactory.in:
* platform/graphics/gpu/GPUError.cpp: GPUErrors can only be created internally; creation should never fail.
(WebCore::createError):
* platform/graphics/gpu/GPUError.h:
* platform/graphics/gpu/GPUErrorScopes.cpp:
(WebCore::GPUErrorScopes::create):
(WebCore::GPUErrorScopes::GPUErrorScopes):
(WebCore::GPUErrorScopes::generateError): Use a callback for now, since GPUErrorScopes is still under platform.
* platform/graphics/gpu/GPUErrorScopes.h:
(WebCore::GPUErrorScopes::create): Deleted.

LayoutTests:

Add a test to ensure GPUUncapturedErrorEvents work.

* webgpu/uncaptured-errors.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources-input.xcfilelist
trunk/Source/WebCore/DerivedSources-output.xcfilelist
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Modules/webgpu/WebGPUAdapter.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUAdapter.h
trunk/Source/WebCore/Modules/webgpu/WebGPUAdapter.idl
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.h
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.idl
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
trunk/Source/WebCore/dom/EventNames.h
trunk/Source/WebCore/dom/EventNames.in
trunk/Source/WebCore/dom/EventTargetFactory.in
trunk/Source/WebCore/platform/graphics/gpu/GPUError.cpp
trunk/Source/WebCore/platform/graphics/gpu/GPUError.h
trunk/Source/WebCore/platform/graphics/gpu/GPUErrorScopes.cpp
trunk/Source/WebCore/platform/graphics/gpu/GPUErrorScopes.h


Added Paths

trunk/LayoutTests/webgpu/uncaptured-errors.html
trunk/Source/WebCore/Modules/webgpu/GPUUncapturedErrorEvent.cpp
trunk/Source/WebCore/Modules/webgpu/GPUUncapturedErrorEvent.h
trunk/Source/WebCore/Modules/webgpu/GPUUncapturedErrorEvent.idl
trunk/Source/WebCore/Modules/webgpu/WebGPUDeviceEventHandler.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (249538 => 249539)

--- trunk/LayoutTests/ChangeLog	2019-09-05 18:47:55 UTC (rev 249538)
+++ trunk/LayoutTests/ChangeLog	2019-09-05 19:21:58 UTC (rev 249539)
@@ -1,3 +1,14 @@
+2019-09-05  Justin Fan  
+
+[WebGPU] Implement GPUUncapturedErrorEvent
+https://bugs.webkit.org/show_bug.cgi?id=199676
+
+Reviewed by Dean Jackson.
+
+Add a test to ensure GPUUncapturedErrorEvents work.
+
+* webgpu/uncaptured-errors.html: Added.
+
 2019-09-05  Ryan Haddad  
 
 [iOS] Layout Test imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_timeupdate_on_seek.html is failing


Added: trunk/LayoutTests/webgpu/uncaptured-errors.html (0 => 249539)

--- trunk/LayoutTests/webgpu/uncaptured-errors.html	(rev 0)
+++ trunk/LayoutTests/webgpu/uncaptured-errors.html	2019-09-05 19:21:58 UTC (rev 249539)
@@ -0,0 +1,52 @@
+
+
+Test Error Scopes.
+
+
+let tests = {};
+let eventWatcher;
+
+const causeUncapturedErrorEvent = device => {
+device.createBuffer({ size: 4, usage: GPUBufferUsage.MAP_READ | GPUBufferUsage.MAP_WRITE });
+};
+
+tests["Fire an uncaptured GPUDevice error event at 'device'."] = async device => {
+const asyncTest = async_test("GPUUncapturedErrorEvent async test.");
+const eventWatcher = new EventWatcher(asyncTest, device

[webkit-changes] [249446] trunk/Websites/webkit.org

[justin_fan]

Title: [249446] trunk/Websites/webkit.org








Revision 249446
Author justin_...@apple.com
Date 2019-09-03 17:20:57 -0700 (Tue, 03 Sep 2019)


Log Message
[WebGPU] Add compute-boids to WebGPU demo page
https://bugs.webkit.org/show_bug.cgi?id=201416

Reviewed by Dean Jackson.

Add the compute-boids demo for use with STP 91.

* demos/webgpu/compute-boids.html: Added.
* demos/webgpu/index.html:
* demos/webgpu/resources/compute-boids.png: Added.

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/demos/webgpu/index.html


Added Paths

trunk/Websites/webkit.org/demos/webgpu/compute-boids.html
trunk/Websites/webkit.org/demos/webgpu/resources/compute-boids.png




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (249445 => 249446)

--- trunk/Websites/webkit.org/ChangeLog	2019-09-03 23:37:12 UTC (rev 249445)
+++ trunk/Websites/webkit.org/ChangeLog	2019-09-04 00:20:57 UTC (rev 249446)
@@ -1,3 +1,16 @@
+2019-09-03  Justin Fan  
+
+[WebGPU] Add compute-boids to WebGPU demo page
+https://bugs.webkit.org/show_bug.cgi?id=201416
+
+Reviewed by Dean Jackson.
+
+Add the compute-boids demo for use with STP 91.
+
+* demos/webgpu/compute-boids.html: Added.
+* demos/webgpu/index.html:
+* demos/webgpu/resources/compute-boids.png: Added.
+
 2019-08-06  Justin Fan  
 
 [WebGPU] Fix up demos on and add compute demo to webkit.org/demos


Added: trunk/Websites/webkit.org/demos/webgpu/compute-boids.html (0 => 249446)

--- trunk/Websites/webkit.org/demos/webgpu/compute-boids.html	(rev 0)
+++ trunk/Websites/webkit.org/demos/webgpu/compute-boids.html	2019-09-04 00:20:57 UTC (rev 249446)
@@ -0,0 +1,373 @@
+
+
+
+
+  
+  WebGPU Compute Flocking
+  
+  body {
+  font-family: system-ui;
+  color: #f7f7ff;
+  background-color: rgb(38, 38, 127);
+  text-align: center;
+  }
+  canvas {
+  margin: 0 auto;
+  }
+  
+
+
+  

+
Compute Flocking
+

+This demo uses a compute shader to update the positions of objects in parallel.
+
+
+  
+  

+  
WebGPU not available
+  

+  Make sure you are on a system with WebGPU enabled. In
+  Safari, first make sure the Developer Menu is visible (Preferences →
+  Advanced), then Develop → Experimental Features → WebGPU.
+  
+  
+