[webkit-changes] [147504] trunk

[leviw]

Title: [147504] trunk








Revision 147504
Author le...@chromium.org
Date 2013-04-02 16:10:49 -0700 (Tue, 02 Apr 2013)


Log Message
Source/WebCore: InlineIterator needs to be updated when RenderCombineText shrinks at a line break
https://bugs.webkit.org/show_bug.cgi?id=113733

Reviewed by Emil A Eklund.

Update stale InlineIterators that point beyond the end of a RenderCombineText that's
shrunk when RenderCombineText::combineText() is called.

Test: fast/text/international/combine-at-line-break-crash.html

* rendering/BidiRun.h:
(WebCore::BidiRun::BidiRun): Adding an assertion that runs are created within
the bounds of their associated RenderText.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::iteratorIsBeyondEndOfRenderCombineText): Added.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Update stale iterators.

LayoutTests: InlineIterator needs to be updated when RenderCombineText shrinks at a line break
https://bugs.webkit.org/show_bug.cgi?id=113732

Reviewed by Emil A Eklund.

* fast/text/international/combine-at-line-break-crash-expected.txt: Added.
* fast/text/international/combine-at-line-break-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/BidiRun.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp


Added Paths

trunk/LayoutTests/fast/text/international/combine-at-line-break-crash-expected.txt
trunk/LayoutTests/fast/text/international/combine-at-line-break-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (147503 => 147504)

--- trunk/LayoutTests/ChangeLog	2013-04-02 22:51:23 UTC (rev 147503)
+++ trunk/LayoutTests/ChangeLog	2013-04-02 23:10:49 UTC (rev 147504)
@@ -1,3 +1,13 @@
+2013-04-02  Levi Weintraub  le...@chromium.org
+
+InlineIterator needs to be updated when RenderCombineText shrinks at a line break
+https://bugs.webkit.org/show_bug.cgi?id=113732
+
+Reviewed by Emil A Eklund.
+
+* fast/text/international/combine-at-line-break-crash-expected.txt: Added.
+* fast/text/international/combine-at-line-break-crash.html: Added.
+
 2013-04-02  Jochen Eisinger  joc...@chromium.org
 
 Use cross-port testRunner methods in fast/loader/url-selected-user-gesture.html


Added: trunk/LayoutTests/fast/text/international/combine-at-line-break-crash-expected.txt (0 => 147504)

--- trunk/LayoutTests/fast/text/international/combine-at-line-break-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/text/international/combine-at-line-break-crash-expected.txt	2013-04-02 23:10:49 UTC (rev 147504)
@@ -0,0 +1 @@
+Test passes if there's no crash.


Added: trunk/LayoutTests/fast/text/international/combine-at-line-break-crash.html (0 => 147504)

--- trunk/LayoutTests/fast/text/international/combine-at-line-break-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/text/international/combine-at-line-break-crash.html	2013-04-02 23:10:49 UTC (rev 147504)
@@ -0,0 +1,29 @@
+html
+head
+style
+body * {
+-webkit-writing-mode: vertical-lr;
+-webkit-text-combine: horizontal;
+}
+#test {
+height: 7px;
+white-space: pre-wrap;
+}
+/style
+script
+function runTest() {
+if (window.testRunner)
+testRunner.dumpAsText();
+document.body.offsetTop;
+var testContainer = document.getElementById('test');
+testContainer.parentNode.removeChild(testContainer);
+}
+/script
+/head
+body _onload_='runTest()'pTest passes if there's no crash./p
+!-- The empty scripts tags are needed to split the RenderCombineText and reproduce the bug. --
+div id=testpfoo   script/script
+  script/script
+/p
+/div
+/body
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (147503 => 147504)

--- trunk/Source/WebCore/ChangeLog	2013-04-02 22:51:23 UTC (rev 147503)
+++ trunk/Source/WebCore/ChangeLog	2013-04-02 23:10:49 UTC (rev 147504)
@@ -1,3 +1,22 @@
+2013-04-02  Levi Weintraub  le...@chromium.org
+
+InlineIterator needs to be updated when RenderCombineText shrinks at a line break
+https://bugs.webkit.org/show_bug.cgi?id=113733
+
+Reviewed by Emil A Eklund.
+
+Update stale InlineIterators that point beyond the end of a RenderCombineText that's
+shrunk when RenderCombineText::combineText() is called.
+
+Test: fast/text/international/combine-at-line-break-crash.html
+
+* rendering/BidiRun.h:
+(WebCore::BidiRun::BidiRun): Adding an assertion that runs are created within
+the bounds of their associated RenderText.
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::iteratorIsBeyondEndOfRenderCombineText): Added.
+(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Update stale iterators.
+
 2013-04-02  Max Vujovic  mvujo...@adobe.com
 
 [CSS Filters] Filter outsets clipped on composited layers when filter is applied after first layout


Modified: trunk/Source/WebCore/rendering/BidiRun.h (147503 => 147504)

--- 

[webkit-changes] [147156] trunk

[leviw]

Title: [147156] trunk








Revision 147156
Author le...@chromium.org
Date 2013-03-28 14:03:44 -0700 (Thu, 28 Mar 2013)


Log Message
Source/WebCore: Enable font measurement optimization for Chromium-mac when there are no font-feature-settings.

Enable measure-once optimization on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=113243

Reviewed by Eric Seidel.

Bugs in Chromium-mac's -webkit-font-feature-settings support prevented us from enabling the
optimization when it was enabled for all other platforms. This was believed to be related to
kerning, but the bug shows up when there are any font-feature-settings specified. For now,
optimizing the common case and only turning off the optimization when there are font-feature-
settings in play.

Updated test fast/text/shaping/shaping-selection-rect.html to avoid breaking due to
https://bugs.webkit.org/show_bug.cgi?id=113418

* rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):

LayoutTests: Disable font measurement optimization for Chromium-mac when there are font-feature-settings.

Enable measure-once optimization on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=113243

Reviewed by Eric Seidel.

* fast/text/shaping/shaping-selection-rect.html: Adding a small-caps case to prevent regressing
due to https://bugs.webkit.org/show_bug.cgi?id=113418.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/text/shaping/shaping-selection-rect.html
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (147155 => 147156)

--- trunk/LayoutTests/ChangeLog	2013-03-28 21:01:49 UTC (rev 147155)
+++ trunk/LayoutTests/ChangeLog	2013-03-28 21:03:44 UTC (rev 147156)
@@ -1,3 +1,15 @@
+2013-03-28  Levi Weintraub  le...@chromium.org
+
+Disable font measurement optimization for Chromium-mac when there are font-feature-settings.
+
+Enable measure-once optimization on Chromium-Mac
+https://bugs.webkit.org/show_bug.cgi?id=113243
+
+Reviewed by Eric Seidel.
+
+* fast/text/shaping/shaping-selection-rect.html: Adding a small-caps case to prevent regressing
+due to https://bugs.webkit.org/show_bug.cgi?id=113418.
+
 2013-03-28  Zoltan Horvath  zol...@webkit.org
 
 [CSS Exclusions][CSS Regions] Block children do not layout inline content correctly in a region with shape-inside set


Modified: trunk/LayoutTests/fast/text/shaping/shaping-selection-rect.html (147155 => 147156)

--- trunk/LayoutTests/fast/text/shaping/shaping-selection-rect.html	2013-03-28 21:01:49 UTC (rev 147155)
+++ trunk/LayoutTests/fast/text/shaping/shaping-selection-rect.html	2013-03-28 21:03:44 UTC (rev 147156)
@@ -1,23 +1,36 @@
 html
 head
 style
-#target {
+div {
 font-family: times new roman; /* non AAT font on mac */
+}
+span {
+direction: rtl;
+unicode-bidi: bidi-override;
+}
+#kerning {
 -webkit-font-feature-settings: 'kern';
-};
+}
+#smallcaps {
+-webkit-font-feature-settings: 'smcp';
+}
 /style
 script
 function test()
 {
-var targetText = document.getElementById(target).firstChild;
-window.getSelection().setBaseAndExtent(target, 0, target, 9);
+var start = document.getElementById(kerning).firstChild;
+var end = document.getElementById(smallcaps).lastChild;
+window.getSelection().setBaseAndExtent(start, 0, end, 3);
 }
 /script
 /head
 body _onload_=test()
-pThe selection should cover the all of the below text. There should be no blank between C and F.
-div id=target
-ABCspan style=direction: rtl; unicode-bidi: bidi-override;DEF/spanGHI
+pThe selection should cover the all of the below text. There should be no blank between either C and F.
+div id=kerning
+ABCspanDEF/spanGHI
 /div
+div id=smallcaps
+ABCspanDEF/spanGHI
+/div
 /body
 /html


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (147155 => 147156)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-28 21:01:49 UTC (rev 147155)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-03-28 21:03:44 UTC (rev 147156)
@@ -3763,6 +3763,9 @@
 # Flaky assertion failures on debug bots
 webkit.org/b/112369 [ Debug ] inspector/debugger/pause-in-inline-script.html [ Pass Crash Timeout ]
 
+# Needs rebaseline on all platforms
+Bug(leviw) fast/text/shaping/shaping-selection-rect.html [ Failure ]
+
 # Flaky tests
 webkit.org/b/112598 [ Win Mac Linux ] http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html [ Failure Pass ]
 webkit.org/b/112601 http/tests/security/cross-frame-access-port-explicit-domain.html [ Failure Pass ]


Modified: trunk/Source/WebCore/ChangeLog (147155 => 147156)

--- trunk/Source/WebCore/ChangeLog	2013-03-28 21:01:49 UTC (rev 147155)
+++ trunk/Source/WebCore/ChangeLog	2013-03-28 21:03:44 UTC (rev 147156)
@@ -1,3 +1,24 @@
+2013-03-28  Levi W

[webkit-changes] [144995] trunk

[leviw]

Title: [144995] trunk








Revision 144995
Author le...@chromium.org
Date 2013-03-06 16:07:02 -0800 (Wed, 06 Mar 2013)


Log Message
InsertUnorderedList can lead to lost content and assertions in moveParagraphs
https://bugs.webkit.org/show_bug.cgi?id=111228

Reviewed by Ryosuke Niwa.

Source/WebCore:

When a list is wrapped in a presentational inline like a b tag, we'd create markup that included
everything up to the b tag from moveParagraphs when intending to only move the contents of the
list item. This could make it impossible to remove content from a list and trigger loss of
editable text.

Test: editing/execCommand/insert-remove-block-list-inside-presentational-inline.html

* editing/EditingStyle.cpp:
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl): Ensure there's an inline style
before calling propertyExistsInStyle.
(WebCore::HTMLElementEquivalent::propertyExistsInStyle): Removing null check for style.
All callers ensure this value isn't null.
* editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup): Avoid going over RenderBlocks when finding the highest
presentational ancestor to avoid leaving the bounds of the original paragraph.

LayoutTests:

* editing/deleting/pruning-after-merge-1-expected.txt:
* editing/execCommand/insert-remove-block-list-inside-presentational-inline-expected.txt: Added.
* editing/execCommand/insert-remove-block-list-inside-presentational-inline.html: Added.
* editing/pasteboard/paste-and-sanitize-expected.txt:
* editing/pasteboard/paste-and-sanitize.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/deleting/pruning-after-merge-1-expected.txt
trunk/LayoutTests/editing/pasteboard/paste-and-sanitize-expected.txt
trunk/LayoutTests/editing/pasteboard/paste-and-sanitize.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/EditingStyle.cpp
trunk/Source/WebCore/editing/markup.cpp


Added Paths

trunk/LayoutTests/editing/execCommand/insert-remove-block-list-inside-presentational-inline-expected.txt
trunk/LayoutTests/editing/execCommand/insert-remove-block-list-inside-presentational-inline.html




Diff

Modified: trunk/LayoutTests/ChangeLog (144994 => 144995)

--- trunk/LayoutTests/ChangeLog	2013-03-06 23:56:27 UTC (rev 144994)
+++ trunk/LayoutTests/ChangeLog	2013-03-07 00:07:02 UTC (rev 144995)
@@ -1,3 +1,16 @@
+2013-03-06  Levi Weintraub  le...@chromium.org
+
+InsertUnorderedList can lead to lost content and assertions in moveParagraphs
+https://bugs.webkit.org/show_bug.cgi?id=111228
+
+Reviewed by Ryosuke Niwa.
+
+* editing/deleting/pruning-after-merge-1-expected.txt:
+* editing/execCommand/insert-remove-block-list-inside-presentational-inline-expected.txt: Added.
+* editing/execCommand/insert-remove-block-list-inside-presentational-inline.html: Added.
+* editing/pasteboard/paste-and-sanitize-expected.txt:
+* editing/pasteboard/paste-and-sanitize.html:
+
 2013-03-06  Rafael Weinstein  rafa...@chromium.org
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/editing/deleting/pruning-after-merge-1-expected.txt (144994 => 144995)

--- trunk/LayoutTests/editing/deleting/pruning-after-merge-1-expected.txt	2013-03-06 23:56:27 UTC (rev 144994)
+++ trunk/LayoutTests/editing/deleting/pruning-after-merge-1-expected.txt	2013-03-07 00:07:02 UTC (rev 144995)
@@ -5,7 +5,7 @@
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldDeleteDOMRange:range from 1 of #text  DIV  BODY  HTML  #document to 1 of #text  DIV  B  DIV  BODY  HTML  #document
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of #text  DIV  B  DIV  BODY  HTML  #document to 2 of #text  DIV  B  DIV  BODY  HTML  #document toDOMRange:range from 1 of #text  DIV  BODY  HTML  #document to 1 of #text  DIV  BODY  HTML  #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of #text  SPAN  DIV  BODY  HTML  #document to 2 of #text  SPAN  DIV  BODY  HTML  #document toDOMRange:range from 1 of #text  DIV  BODY  HTML  #document to 1 of #text  DIV  BODY  HTML  #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
 This tests the pruning that delete does when the it merges two paragraphs when the selection to delete spans multiple blocks.


Added: trunk/LayoutTests/editing/execCommand/insert-remove-block-list-inside-presentational-inline-expected.txt (0 => 144995)

--- trunk/LayoutTests/editing/execCommand/insert-remove-block-list-inside-presentational-inline-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/execCommand/insert-remove-block-list-inside-presentational-inline-expected.txt	2013-03-07 00:07:02 UTC 

[webkit-changes] [144646] trunk/Source

[leviw]

Title: [144646] trunk/Source








Revision 144646
Author le...@chromium.org
Date 2013-03-04 10:56:53 -0800 (Mon, 04 Mar 2013)


Log Message
Add support for 8 bit TextRuns on Chromium Linux  Mac
https://bugs.webkit.org/show_bug.cgi?id=99393

Reviewed by Eric Seidel.

Source/WebCore: 

Adding support for 8 bit TextRuns for Mac and Linux Chromium. To accomplish this,
8 bit text runs are upconverted to 16 bit in the complex text path during string
normalization, as HarfBuzz operates on UChars.

Windows has platfom assumptions that TextRuns are 16 bit that need to be addressed
before enabling this optimization.

No new tests. No change in behavior.

(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):
* platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):

Source/WebKit/chromium: 

Enabling 8 bit text runs for Linux and Mac platforms.

* features.gypi:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi




Diff

Modified: trunk/Source/WebCore/ChangeLog (144645 => 144646)

--- trunk/Source/WebCore/ChangeLog	2013-03-04 18:50:47 UTC (rev 144645)
+++ trunk/Source/WebCore/ChangeLog	2013-03-04 18:56:53 UTC (rev 144646)
@@ -1,3 +1,25 @@
+2013-03-04  Levi Weintraub  le...@chromium.org
+
+Add support for 8 bit TextRuns on Chromium Linux  Mac
+https://bugs.webkit.org/show_bug.cgi?id=99393
+
+Reviewed by Eric Seidel.
+
+Adding support for 8 bit TextRuns for Mac and Linux Chromium. To accomplish this,
+8 bit text runs are upconverted to 16 bit in the complex text path during string
+normalization, as HarfBuzz operates on UChars.
+
+Windows has platfom assumptions that TextRuns are 16 bit that need to be addressed
+before enabling this optimization.
+
+No new tests. No change in behavior.
+
+(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):
+* platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
+* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
+(WebCore::normalizeCharacters):
+(WebCore::HarfBuzzShaper::HarfBuzzShaper):
+
 2013-03-04  Alexis Menard  ale...@webkit.org
 
 transition-property property and transition shorthand property doesn't accept all, all.


Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp (144645 => 144646)

--- trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp	2013-03-04 18:50:47 UTC (rev 144645)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp	2013-03-04 18:56:53 UTC (rev 144646)
@@ -156,10 +156,18 @@
 return position;
 }
 
-static void normalizeCharacters(const UChar* source, UChar* destination, int length)
+static void normalizeCharacters(const TextRun run, UChar* destination, int length)
 {
 int position = 0;
 bool error = false;
+const UChar* source;
+String stringFor8BitRun;
+if (run.is8Bit()) {
+stringFor8BitRun = String::make16BitFrom8BitSource(run.characters8(), run.length());
+source = stringFor8BitRun.characters16();
+} else
+source = run.characters16();
+
 while (position  length) {
 UChar32 character;
 int nextPosition = position;
@@ -182,7 +190,7 @@
 {
 m_normalizedBuffer = adoptArrayPtr(new UChar[m_run.length() + 1]);
 m_normalizedBufferLength = m_run.length();
-normalizeCharacters(m_run.characters16(), m_normalizedBuffer.get(), m_normalizedBufferLength);
+normalizeCharacters(m_run, m_normalizedBuffer.get(), m_normalizedBufferLength);
 setPadding(m_run.expansion());
 setFontFeatures();
 }


Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp (144645 => 144646)

--- trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp	2013-03-04 18:50:47 UTC (rev 144645)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp	2013-03-04 18:56:53 UTC (rev 144646)
@@ -94,10 +94,18 @@
 icu::UnicodeString normalizedString;
 UErrorCode error = U_ZERO_ERROR;
 
+const UChar* runCharacters;
+String stringFor8BitRun;
+if (m_run.is8Bit()) {
+stringFor8BitRun = String::make16BitFrom8BitSource(m_run.characters8(), m_run.length());
+runCharacters = stringFor8BitRun.characters16();
+} else
+runCharacters = m_run.characters16();
+
 for (int i = 0; i  m_run.length(); ++i) {
-UChar ch = m_run[i];
+UChar ch = runCharacters[i];
 if (::ublock_getCode(ch) == UBLOCK_COMBINING_DIACRITICAL_MARKS) {
-icu::Normalizer::normalize(icu::UnicodeString(m_run.characters16(),
+icu::Normalizer::normalize(icu::UnicodeString(runCharacters,
  

[webkit-changes] [144400] trunk

[leviw]

Title: [144400] trunk








Revision 144400
Author le...@chromium.org
Date 2013-02-28 17:24:47 -0800 (Thu, 28 Feb 2013)


Log Message
Stale FrameSelection in removed iframe causes crash
https://bugs.webkit.org/show_bug.cgi?id=108696

Reviewed by Ryosuke Niwa.

Source/WebCore:

Catching a specific issue where selectFrameElementInParentIfFullySelected in a nested
iFrame that is removed can leave the outer frame's selection referencing stale nodes.
Instead, in this case, we keep the frame alive long enough to check for this condition
and clear our selection if we hit it.

Test: editing/selection/selection-in-iframe-removed-crash.html

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):

LayoutTests:

* editing/selection/selection-in-iframe-removed-crash-expected.txt: Added.
* editing/selection/selection-in-iframe-removed-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/FrameSelection.cpp


Added Paths

trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash-expected.txt
trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (144399 => 144400)

--- trunk/LayoutTests/ChangeLog	2013-03-01 01:01:31 UTC (rev 144399)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 01:24:47 UTC (rev 144400)
@@ -1,3 +1,13 @@
+2013-02-28  Levi Weintraub  le...@chromium.org
+
+Stale FrameSelection in removed iframe causes crash
+https://bugs.webkit.org/show_bug.cgi?id=108696
+
+Reviewed by Ryosuke Niwa.
+
+* editing/selection/selection-in-iframe-removed-crash-expected.txt: Added.
+* editing/selection/selection-in-iframe-removed-crash.html: Added.
+
 2013-02-28  Stephen Chenney  schen...@chromium.org
 
 [Chromium] Rebaselines for Mac decorations-with-text-combine.html


Added: trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash-expected.txt (0 => 144400)

--- trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash-expected.txt	2013-03-01 01:24:47 UTC (rev 144400)
@@ -0,0 +1 @@
+Test passes if it does not crash. 


Added: trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash.html (0 => 144400)

--- trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash.html	(rev 0)
+++ trunk/LayoutTests/editing/selection/selection-in-iframe-removed-crash.html	2013-03-01 01:24:47 UTC (rev 144400)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+Test passes if it does not crash.
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var docElement = document.documentElement;
+function crash() {
+iframe1 = document.createElementNS(http://www.w3.org/1999/xhtml, iframe);
+iframe1.setAttribute(srcdoc, ABC);
+docElement.appendChild(iframe1);
+document1 = document.implementation.createDocument(, null);
+iframe1.addEventListener(DOMFocusOut, function () { document1.adoptNode(iframe1); }, false);
+iframe1.focus();
+setTimeout(finish();, 0);
+}
+
+function finish() {
+document.designMode = on;
+range1 = document.createRange();
+range1.selectNodeContents(iframe1.contentDocument);
+window.getSelection().addRange(range1);
+}
+
+document.addEventListener(DOMContentLoaded, crash, false);
+/script
+/html


Modified: trunk/Source/WebCore/ChangeLog (144399 => 144400)

--- trunk/Source/WebCore/ChangeLog	2013-03-01 01:01:31 UTC (rev 144399)
+++ trunk/Source/WebCore/ChangeLog	2013-03-01 01:24:47 UTC (rev 144400)
@@ -1,3 +1,20 @@
+2013-02-28  Levi Weintraub  le...@chromium.org
+
+Stale FrameSelection in removed iframe causes crash
+https://bugs.webkit.org/show_bug.cgi?id=108696
+
+Reviewed by Ryosuke Niwa.
+
+Catching a specific issue where selectFrameElementInParentIfFullySelected in a nested
+iFrame that is removed can leave the outer frame's selection referencing stale nodes.
+Instead, in this case, we keep the frame alive long enough to check for this condition
+and clear our selection if we hit it.
+
+Test: editing/selection/selection-in-iframe-removed-crash.html
+
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::setSelection):
+
 2013-02-28  Conrad Shultz  conrad_shu...@apple.com
 
 Need API to control page underlay color


Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (144399 => 144400)

--- trunk/Source/WebCore/editing/FrameSelection.cpp	2013-03-01 01:01:31 UTC (rev 144399)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp	2013-03-01 01:24:47 UTC (rev 144400)
@@ -280,7 +280,13 @@
 if (s.base().anchorNode()) {
 Document* document = s.base().anchorNode()-document();
 if (document  document-frame()  document-frame() != m_frame  document != m_frame-document()) {
+

[webkit-changes] [144065] trunk/Source

[leviw]

Title: [144065] trunk/Source








Revision 144065
Author le...@chromium.org
Date 2013-02-26 09:08:05 -0800 (Tue, 26 Feb 2013)


Log Message
Add support for 8 bit TextRuns for Chromium/HarfBuzz
https://bugs.webkit.org/show_bug.cgi?id=99393

Reviewed by Eric Seidel.

Source/WebCore:

Adding support for 8 bit TextRuns for platforms using HarfBuzz. To accomplish this,
8 bit text runs are upconverted to 16 bit in the complex text path during string
normalization, as HarfBuzz operates on UChars.

No new tests. No change in behavior.

(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):
* platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):

Source/WebKit/chromium:

Enabling 8 bit text runs for Chromium.

* features.gypi:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi




Diff

Modified: trunk/Source/WebCore/ChangeLog (144064 => 144065)

--- trunk/Source/WebCore/ChangeLog	2013-02-26 16:37:50 UTC (rev 144064)
+++ trunk/Source/WebCore/ChangeLog	2013-02-26 17:08:05 UTC (rev 144065)
@@ -1,3 +1,22 @@
+2013-02-26  Levi Weintraub  le...@chromium.org
+
+Add support for 8 bit TextRuns for Chromium/HarfBuzz
+https://bugs.webkit.org/show_bug.cgi?id=99393
+
+Reviewed by Eric Seidel.
+
+Adding support for 8 bit TextRuns for platforms using HarfBuzz. To accomplish this,
+8 bit text runs are upconverted to 16 bit in the complex text path during string
+normalization, as HarfBuzz operates on UChars.
+
+No new tests. No change in behavior.
+
+(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):
+* platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
+* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
+(WebCore::normalizeCharacters):
+(WebCore::HarfBuzzShaper::HarfBuzzShaper):
+
 2013-02-26  Dmitry Zvorygin  zvory...@chromium.org
 
 Merged Tip and Debug log levels for web console.


Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp (144064 => 144065)

--- trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp	2013-02-26 16:37:50 UTC (rev 144064)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp	2013-02-26 17:08:05 UTC (rev 144065)
@@ -156,10 +156,18 @@
 return position;
 }
 
-static void normalizeCharacters(const UChar* source, UChar* destination, int length)
+static void normalizeCharacters(const TextRun run, UChar* destination, int length)
 {
 int position = 0;
 bool error = false;
+const UChar* source;
+String stringFor8BitRun;
+if (run.is8Bit()) {
+stringFor8BitRun = String::make16BitFrom8BitSource(run.characters8(), run.length());
+source = stringFor8BitRun.characters16();
+} else
+source = run.characters16();
+
 while (position  length) {
 UChar32 character;
 int nextPosition = position;
@@ -182,7 +190,7 @@
 {
 m_normalizedBuffer = adoptArrayPtr(new UChar[m_run.length() + 1]);
 m_normalizedBufferLength = m_run.length();
-normalizeCharacters(m_run.characters16(), m_normalizedBuffer.get(), m_normalizedBufferLength);
+normalizeCharacters(m_run, m_normalizedBuffer.get(), m_normalizedBufferLength);
 setPadding(m_run.expansion());
 setFontFeatures();
 }


Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp (144064 => 144065)

--- trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp	2013-02-26 16:37:50 UTC (rev 144064)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp	2013-02-26 17:08:05 UTC (rev 144065)
@@ -94,10 +94,18 @@
 icu::UnicodeString normalizedString;
 UErrorCode error = U_ZERO_ERROR;
 
+const UChar* runCharacters;
+String stringFor8BitRun;
+if (m_run.is8Bit()) {
+stringFor8BitRun = String::make16BitFrom8BitSource(m_run.characters8(), m_run.length());
+runCharacters = stringFor8BitRun.characters16();
+} else
+runCharacters = m_run.characters16();
+
 for (int i = 0; i  m_run.length(); ++i) {
-UChar ch = m_run[i];
+UChar ch = runCharacters[i];
 if (::ublock_getCode(ch) == UBLOCK_COMBINING_DIACRITICAL_MARKS) {
-icu::Normalizer::normalize(icu::UnicodeString(m_run.characters16(),
+icu::Normalizer::normalize(icu::UnicodeString(runCharacters,
m_run.length()), UNORM_NFC, 0 /* no options */,
normalizedString, error);
 if (U_FAILURE(error))
@@ -109,7 +117,7 @@
 const UChar* sourceText;
 if (normalizedString.isEmpty()) {
 m_normalizedBufferLength = m_run.length();
-

[webkit-changes] [143752] branches/chromium/1410

[leviw]

Title: [143752] branches/chromium/1410








Revision 143752
Author le...@chromium.org
Date 2013-02-22 10:45:07 -0800 (Fri, 22 Feb 2013)


Log Message
Merge 142659
 REGRESSION(r136967): Combination of float and clear yields to bad layout
 https://bugs.webkit.org/show_bug.cgi?id=109476
 
 Reviewed by Levi Weintraub.
 
 Source/WebCore:
 
 Test: fast/block/margin-collapse/self-collapsing-block-with-float-children.html
 
 The change made at http://trac.webkit.org/changeset/136967 only needs to worry about the first floated
 child of a self-collapsing block. The ones that follow are not affected by its margins.
 
 * rendering/RenderBlockLineLayout.cpp:
 (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
 
 LayoutTests:
 
 * fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt: Added.
 * fast/block/margin-collapse/self-collapsing-block-with-float-children.html: Added.
 

TBR=rob...@webkit.org
Review URL: https://codereview.chromium.org/12335038

Modified Paths

branches/chromium/1410/Source/WebCore/rendering/RenderBlockLineLayout.cpp


Added Paths

branches/chromium/1410/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt
branches/chromium/1410/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html




Diff

Copied: branches/chromium/1410/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt (from rev 142659, trunk/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt) (0 => 143752)

--- branches/chromium/1410/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt	(rev 0)
+++ branches/chromium/1410/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt	2013-02-22 18:45:07 UTC (rev 143752)
@@ -0,0 +1,7 @@
+These words should
+PASS
+be all on the
+PASS
+same line.
+PASS
+https://bugs.webkit.org/show_bug.cgi?id=109476 : only the first floated child of a self-collapsing block needs to account for its collapsed margin.


Copied: branches/chromium/1410/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html (from rev 142659, trunk/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html) (0 => 143752)

--- branches/chromium/1410/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html	(rev 0)
+++ branches/chromium/1410/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html	2013-02-22 18:45:07 UTC (rev 143752)
@@ -0,0 +1,33 @@
+!doctype html
+html
+head
+style
+.cleared-container {
+font: 30px/1 Ahem;
+clear: both;
+list-style: none;
+padding: 0;
+margin: 1em 0 0;
+}
+.floated-child {
+float: left;
+width: 33.33%;
+background: rgb(200,200,200);
+}
+/style
+/head
+body
+script src=""
+ul class=cleared-container
+li class=floated-child data-offset-y=30pxThese words should/li
+li class=floated-child data-offset-y=30pxbe all on the /li
+li class=floated-child data-offset-y=30pxsame line./li
+/ul
+p https://bugs.webkit.org/show_bug.cgi?id=109476 : only the first floated child of a self-collapsing block needs to account
+for its collapsed margin. /p
+script
+checkLayout('.floated-child');
+/script
+/body
+/html
+


Modified: branches/chromium/1410/Source/WebCore/rendering/RenderBlockLineLayout.cpp (143751 => 143752)

--- branches/chromium/1410/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2013-02-22 18:40:44 UTC (rev 143751)
+++ branches/chromium/1410/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2013-02-22 18:45:07 UTC (rev 143752)
@@ -2281,8 +2281,8 @@
 }
 } else if (object-isFloating()) {
 // The top margin edge of a self-collapsing block that clears a float intrudes up into it by the height of the margin,
-// so in order to place this child float at the top content edge of the self-collapsing block add the margin back in before placement.
-LayoutUnit marginOffset = (m_block-isSelfCollapsingBlock()  m_block-style()-clear()  m_block-getClearDelta(m_block, LayoutUnit())) ? m_block-collapsedMarginBeforeForChild(m_block) : LayoutUnit();
+// so in order to place this first child float at the top content edge of the self-collapsing block add the margin back in before placement.
+LayoutUnit marginOffset = (!object-previousSibling()  m_block-isSelfCollapsingBlock()  m_block-style()-clear()  m_block-getClearDelta(m_block, LayoutUnit())) ? m_block-collapsedMarginBeforeForChild(m_block) : LayoutUnit();
 LayoutUnit oldLogicalHeight = m_block-logicalHeight();
 

[webkit-changes] [143812] trunk/Source/WebCore

[leviw]

Title: [143812] trunk/Source/WebCore








Revision 143812
Author le...@chromium.org
Date 2013-02-22 16:00:27 -0800 (Fri, 22 Feb 2013)


Log Message
Add descriptive names for different addMidpoint use cases
https://bugs.webkit.org/show_bug.cgi?id=110644

Reviewed by Ryosuke Niwa.

Midpoints are used to delineate ranges where we don't add line boxes for contents (collapsed spaces),
and to explicitly split a RenderText into multiple text runs so that text paragraph seperators get
their own line boxes. This patch encapsulates the different cases where midpoints are added to
lineMidpointState into 4 helper functions to make it clearer what's going on in each case.

No new tests. No change in functionality.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::deprecatedAddMidpoint): Original function simply adds a midpoint to the lineMidpointState.
Renaming to deprecated to discourage callers.
(WebCore::startIgnoringSpaces): Adds a midpoint to start collapsing subsequent spaces. Asserts that
we have an even number of midpoints.
(WebCore::stopIgnoringSpaces): Adds the corresponding midpoint from startIgnoringSpaces and asserts
that it's an odd number.
(WebCore::ensureLineBoxInsideIgnoredSpaces): When ignoring spaces and we come across a RenderInline
that needs a line box, this function adds a pair of midpoints which ensures we'll later add a line
box for it.
(WebCore::ensureCharacterGetsLineBox): Adds a pair of midpoints in a text renderer to mark that
the current character needs its own line box. This is used by svg for absolutely positioned
characters, or for text paragraph seperators.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (143811 => 143812)

--- trunk/Source/WebCore/ChangeLog	2013-02-22 23:37:20 UTC (rev 143811)
+++ trunk/Source/WebCore/ChangeLog	2013-02-23 00:00:27 UTC (rev 143812)
@@ -1,3 +1,31 @@
+2013-02-22  Levi Weintraub  le...@chromium.org
+
+Add descriptive names for different addMidpoint use cases
+https://bugs.webkit.org/show_bug.cgi?id=110644
+
+Reviewed by Ryosuke Niwa.
+
+Midpoints are used to delineate ranges where we don't add line boxes for contents (collapsed spaces),
+and to explicitly split a RenderText into multiple text runs so that text paragraph seperators get
+their own line boxes. This patch encapsulates the different cases where midpoints are added to
+lineMidpointState into 4 helper functions to make it clearer what's going on in each case.
+
+No new tests. No change in functionality.
+
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::deprecatedAddMidpoint): Original function simply adds a midpoint to the lineMidpointState.
+Renaming to deprecated to discourage callers.
+(WebCore::startIgnoringSpaces): Adds a midpoint to start collapsing subsequent spaces. Asserts that
+we have an even number of midpoints.
+(WebCore::stopIgnoringSpaces): Adds the corresponding midpoint from startIgnoringSpaces and asserts
+that it's an odd number.
+(WebCore::ensureLineBoxInsideIgnoredSpaces): When ignoring spaces and we come across a RenderInline
+that needs a line box, this function adds a pair of midpoints which ensures we'll later add a line
+box for it.
+(WebCore::ensureCharacterGetsLineBox): Adds a pair of midpoints in a text renderer to mark that
+the current character needs its own line box. This is used by svg for absolutely positioned
+characters, or for text paragraph seperators.
+
 2013-02-22  Justin Schuh  jsc...@chromium.org
 
 RenderArena masking has low entropy


Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (143811 => 143812)

--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2013-02-22 23:37:20 UTC (rev 143811)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2013-02-23 00:00:27 UTC (rev 143812)
@@ -359,7 +359,8 @@
 }
 }
 
-static void addMidpoint(LineMidpointState lineMidpointState, const InlineIterator midpoint)
+// Don't call this directly. Use one of the descriptive helper functions below.
+static void deprecatedAddMidpoint(LineMidpointState lineMidpointState, const InlineIterator midpoint)
 {
 if (lineMidpointState.midpoints.size() = lineMidpointState.numMidpoints)
 lineMidpointState.midpoints.grow(lineMidpointState.numMidpoints + 10);
@@ -368,6 +369,35 @@
 midpoints[lineMidpointState.numMidpoints++] = midpoint;
 }
 
+static inline void startIgnoringSpaces(LineMidpointState lineMidpointState, const InlineIterator midpoint)
+{
+ASSERT(!(lineMidpointState.numMidpoints % 2));
+deprecatedAddMidpoint(lineMidpointState, midpoint);
+}
+
+static inline void stopIgnoringSpaces(LineMidpointState lineMidpointState, const InlineIterator midpoint)
+{
+ASSERT(lineMidpointState.numMidpoints % 2);
+

[webkit-changes] [143814] trunk/LayoutTests

[leviw]

Title: [143814] trunk/LayoutTests








Revision 143814
Author le...@chromium.org
Date 2013-02-22 16:35:54 -0800 (Fri, 22 Feb 2013)


Log Message
Unreviewed gardening, updating test expecations after r140374.

* platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch: Removed.
* platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
* platform/chromium-win-xp/platform/chromium/fast/events/touch: Removed.
* platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt
trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch/
trunk/LayoutTests/platform/chromium-win-xp/platform/chromium/fast/events/touch/




Diff

Modified: trunk/LayoutTests/ChangeLog (143813 => 143814)

--- trunk/LayoutTests/ChangeLog	2013-02-23 00:21:59 UTC (rev 143813)
+++ trunk/LayoutTests/ChangeLog	2013-02-23 00:35:54 UTC (rev 143814)
@@ -1,3 +1,12 @@
+2013-02-22  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening, updating test expecations after r140374.
+
+* platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch: Removed.
+* platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
+* platform/chromium-win-xp/platform/chromium/fast/events/touch: Removed.
+* platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
+
 2013-02-22  Dirk Pranke  dpra...@chromium.org
 
 Unreviewed, rolling out r143794.


Modified: trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt (143813 => 143814)

--- trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt	2013-02-23 00:21:59 UTC (rev 143813)
+++ trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt	2013-02-23 00:35:54 UTC (rev 143814)
@@ -1,15 +1,16 @@
 This tests verifies the hit test regions given to the compositor. It can only be run in DumpRenderTree. The outputted rects should cover the hit test regions of all the listed elements.
 
-normalFlow[0]: (8, 68, 784, 10)
-absoluteChildContainer[0]: (8, 96, 784, 10)
+normalFlow[0]: (8, 68, 769, 10)
+absoluteChildContainer[0]: (8, 96, 769, 10)
 absoluteChildContainer[1]: (118, 300, 140, 10)
-relativeChildContainer[0]: (8, 142, 784, 10)
+relativeChildContainer[0]: (8, 142, 769, 10)
 relativeChildContainer[1]: (128, 342, 140, 10)
-overhangingContainer[0]: (8, 188, 784, 10)
+overhangingContainer[0]: (8, 188, 769, 10)
 overhangingContainer[1]: (8, 188, 110, 80)
-transformedChildContainer[0]: (63, 222, 674, 34)
-transformedChildContainer[1]: (8, 234, 784, 10)
+transformedChildContainer[0]: (62, 223, 661, 32)
+transformedChildContainer[1]: (8, 234, 769, 10)
 continuation[0]: (108, 280, 110, 10)
 inlineAbsoluteChildContainer[0]: (378, 300, 250, 10)
 inlineAbsoluteChildContainer[1]: (108, 328, 270, 10)
+document[0]: (0, 0, 785, 1024)
 


Modified: trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt (143813 => 143814)

--- trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt	2013-02-23 00:21:59 UTC (rev 143813)
+++ trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt	2013-02-23 00:35:54 UTC (rev 143814)
@@ -1,15 +1,16 @@
 This tests verifies the hit test regions given to the compositor. It can only be run in DumpRenderTree. The outputted rects should cover the hit test regions of all the listed elements.
 
-normalFlow[0]: (8, 72, 784, 10)
-absoluteChildContainer[0]: (8, 102, 784, 10)
+normalFlow[0]: (8, 72, 769, 10)
+absoluteChildContainer[0]: (8, 102, 769, 10)
 absoluteChildContainer[1]: (118, 300, 140, 10)
-relativeChildContainer[0]: (8, 152, 784, 10)
+relativeChildContainer[0]: (8, 152, 769, 10)
 relativeChildContainer[1]: (128, 352, 140, 10)
-overhangingContainer[0]: (8, 202, 784, 10)
+overhangingContainer[0]: (8, 202, 769, 10)
 overhangingContainer[1]: (8, 202, 110, 80)
-transformedChildContainer[0]: (63, 240, 674, 34)
-transformedChildContainer[1]: (8, 252, 784, 10)
+transformedChildContainer[0]: (62, 241, 661, 32)
+transformedChildContainer[1]: (8, 252, 769, 10)
 continuation[0]: (108, 302, 110, 10)
 inlineAbsoluteChildContainer[0]: (378, 300, 250, 10)
 inlineAbsoluteChildContainer[1]: (108, 352, 270, 10)
+document[0]: (0, 0, 785, 1024)
 






___
webkit-changes mailing list

[webkit-changes] [143520] trunk

[leviw]

Title: [143520] trunk








Revision 143520
Author le...@chromium.org
Date 2013-02-20 15:44:21 -0800 (Wed, 20 Feb 2013)


Log Message
Line layout (but not pref widths) double-counts word spacing when between inlines
https://bugs.webkit.org/show_bug.cgi?id=110381

Reviewed by Emil A Eklund.

Source/WebCore:

When a word break with a space occurs between inlines and word-spacing is non-zero,
line layout incorrectly committed the word-spacing value to the line twice, causing
wrapping in inline-blocks. To fix this, clear the word-spacing value when between
words and ignoring spaces, as we will already have added the word-spacing to the
line.

Test: fast/text/word-space-between-inlines.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

* fast/text/word-space-between-inlines-expected.html: Added.
* fast/text/word-space-between-inlines.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp


Added Paths

trunk/LayoutTests/fast/text/word-space-between-inlines-expected.html
trunk/LayoutTests/fast/text/word-space-between-inlines.html




Diff

Modified: trunk/LayoutTests/ChangeLog (143519 => 143520)

--- trunk/LayoutTests/ChangeLog	2013-02-20 23:44:17 UTC (rev 143519)
+++ trunk/LayoutTests/ChangeLog	2013-02-20 23:44:21 UTC (rev 143520)
@@ -1,3 +1,13 @@
+2013-02-20  Levi Weintraub  le...@chromium.org
+
+Line layout (but not pref widths) double-counts word spacing when between inlines
+https://bugs.webkit.org/show_bug.cgi?id=110381
+
+Reviewed by Emil A Eklund.
+
+* fast/text/word-space-between-inlines-expected.html: Added.
+* fast/text/word-space-between-inlines.html: Added.
+
 2013-02-20  Nate Chapin  jap...@chromium.org
 
 Test for https://bugs.webkit.org/show_bug.cgi?id=110237


Added: trunk/LayoutTests/fast/text/word-space-between-inlines-expected.html (0 => 143520)

--- trunk/LayoutTests/fast/text/word-space-between-inlines-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/word-space-between-inlines-expected.html	2013-02-20 23:44:21 UTC (rev 143520)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+head
+style
+div {
+  word-spacing: 1px;
+}
+.float {
+  float: left;
+}
+.inline-block {
+  display: inline-block;
+}
+/style
+/head
+body
+pThis test ensures that preferred width and layout match for blocks with word-spacing between inlines.
+All the text below should be on one line./p
+div class=float style=background-color: reda b/div
+div class=float style=background-color: orangec d/div
+div class=float style=background-color: yellowe f/div
+div class=float style=background-color: greeng h/div
+div class=inline-block style=background-color: bluei j
+/divdiv class=inline-block style=background-color: indigok l
+/divdiv class=inline-block style=background-color: purplem n
+/divdiv class=inline-block style=background-color: violeto p
+/div
+/body
\ No newline at end of file


Added: trunk/LayoutTests/fast/text/word-space-between-inlines.html (0 => 143520)

--- trunk/LayoutTests/fast/text/word-space-between-inlines.html	(rev 0)
+++ trunk/LayoutTests/fast/text/word-space-between-inlines.html	2013-02-20 23:44:21 UTC (rev 143520)
@@ -0,0 +1,35 @@
+!DOCTYPE html
+html
+head
+style
+div {
+  word-spacing: 1px;
+}
+.float {
+  float: left;
+}
+.inline-block {
+  display: inline-block;
+}
+/style
+/head
+body
+pThis test ensures that preferred width and layout match for blocks with word-spacing between inlines.
+All the text below should be on one line./p
+div class=float style=background-color: redspana/span
+  spanb/span/div
+div class=float style=background-color: orangec
+  d/div
+div class=float style=background-color: yellowe
+  spanf/span/div
+div class=float style=background-color: greenspang/span
+  h/div
+div class=inline-block style=background-color: bluespani/span
+  spanj/span
+/divdiv class=inline-block style=background-color: indigok
+  l
+/divdiv class=inline-block style=background-color: purplem
+  spann/span
+/divdiv class=inline-block style=background-color: violetspano/span
+  p/div
+/body
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (143519 => 143520)

--- trunk/Source/WebCore/ChangeLog	2013-02-20 23:44:17 UTC (rev 143519)
+++ trunk/Source/WebCore/ChangeLog	2013-02-20 23:44:21 UTC (rev 143520)
@@ -1,3 +1,21 @@
+2013-02-20  Levi Weintraub  le...@chromium.org
+
+Line layout (but not pref widths) double-counts word spacing when between inlines
+https://bugs.webkit.org/show_bug.cgi?id=110381
+
+Reviewed by Emil A Eklund.
+
+When a word break with a space occurs between inlines and word-spacing is non-zero,
+line layout incorrectly committed the word-spacing value to the line twice, causing
+wrapping in inline-blocks. To fix this, clear the word-spacing value when between
+words and 

[webkit-changes] [143365] branches/chromium/1410

[leviw]

Title: [143365] branches/chromium/1410








Revision 143365
Author le...@chromium.org
Date 2013-02-19 11:34:35 -0800 (Tue, 19 Feb 2013)


Log Message
Merge 142793
 Bidi-Isolated inlines can cause subsequent content to not be rendered
 https://bugs.webkit.org/show_bug.cgi?id=108137
 
 Reviewed by Eric Seidel.
 
 Source/WebCore:
 
 First step in fixing how inline isolates behave with collapsed spaces.
 webkit.org/b/109624 tracks the overarching issue.
 
 Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html
 
 * rendering/InlineIterator.h:
 (WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while
 ignoring spaces, ensure we leave it considering them again. This can result in
 including spaces that should be ignored following the isolate on the line, but
 failing to do so results in those contents not being rendered at all.
 
 LayoutTests:
 
 * fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added.
 * fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added.
 

TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/12308006

Modified Paths

branches/chromium/1410/Source/WebCore/rendering/InlineIterator.h


Added Paths

branches/chromium/1410/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt
branches/chromium/1410/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace.html




Diff

Copied: branches/chromium/1410/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt (from rev 142793, trunk/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt) (0 => 143365)

--- branches/chromium/1410/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt	(rev 0)
+++ branches/chromium/1410/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt	2013-02-19 19:34:35 UTC (rev 143365)
@@ -0,0 +1,2 @@
+123 456 789
+PASS


Copied: branches/chromium/1410/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace.html (from rev 142793, trunk/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace.html) (0 => 143365)

--- branches/chromium/1410/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace.html	(rev 0)
+++ branches/chromium/1410/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace.html	2013-02-19 19:34:35 UTC (rev 143365)
@@ -0,0 +1,8 @@
+!DOCTYPE html
+body
+pspan data-expected-width=80 id=test123
+ span style=unicode-bidi: -webkit-isolate456/span 789/span/p
+script src=""
+script
+checkLayout('#test');
+/script
\ No newline at end of file


Modified: branches/chromium/1410/Source/WebCore/rendering/InlineIterator.h (143364 => 143365)

--- branches/chromium/1410/Source/WebCore/rendering/InlineIterator.h	2013-02-19 19:29:42 UTC (rev 143364)
+++ branches/chromium/1410/Source/WebCore/rendering/InlineIterator.h	2013-02-19 19:34:35 UTC (rev 143365)
@@ -489,6 +489,14 @@
 // We don't need to mark the end of the run because this is implicit: it is either endOfLine or the end of the
 // isolate, when we call createBidiRunsForLine it will stop at whichever comes first.
 addPlaceholderRunForIsolatedInline(resolver, obj, pos);
+// FIXME: Inline isolates don't work properly with collapsing whitespace, see webkit.org/b/109624
+// For now, if we enter an isolate between midpoints, we increment our current midpoint or else
+// we'll leave the isolate and ignore the content that follows.
+MidpointStateInlineIterator midpointState = resolver.midpointState();
+if (midpointState.betweenMidpoints  midpointState.midpoints[midpointState.currentMidpoint].object() == obj) {
+midpointState.betweenMidpoints = false;
+++midpointState.currentMidpoint;
+}
 }
 
 private:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [142920] branches/chromium/1410

[leviw]

Title: [142920] branches/chromium/1410








Revision 142920
Author le...@chromium.org
Date 2013-02-14 14:30:27 -0800 (Thu, 14 Feb 2013)


Log Message
Merge 142788. Requested by Christian Biesinger cbiesin...@chromium.org.
 Crash when encountering object style=resize:both;
 https://bugs.webkit.org/show_bug.cgi?id=109728
 
 Source/WebCore:
 
 See also https://code.google.com/p/chromium/issues/detail?id=175535
 This bug can be reproduced on
 http://dramalink.net/tudou.y/?xink=162601060
 
 Patch by Christian Biesinger cbiesin...@chromium.org on 2013-02-13
 Reviewed by Eric Seidel.
 
 Test: fast/css/resize-object-crash.html
 
 * rendering/RenderWidget.cpp:
 (WebCore::RenderWidget::paint):
 Only call paintResizer() if we have a layer and canResize() is true
 
 LayoutTests:
 
 See also https://code.google.com/p/chromium/issues/detail?id=175535
 
 Patch by Christian Biesinger cbiesin...@chromium.org on 2013-02-13
 Reviewed by Eric Seidel.
 
 * fast/css/resize-object-crash-expected.txt: Added.
 * fast/css/resize-object-crash.html: Added.

TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/12252048

Modified Paths

branches/chromium/1410/Source/WebCore/rendering/RenderWidget.cpp


Added Paths

branches/chromium/1410/LayoutTests/fast/css/resize-object-crash-expected.txt
branches/chromium/1410/LayoutTests/fast/css/resize-object-crash.html




Diff

Copied: branches/chromium/1410/LayoutTests/fast/css/resize-object-crash-expected.txt (from rev 142788, trunk/LayoutTests/fast/css/resize-object-crash-expected.txt) (0 => 142920)

--- branches/chromium/1410/LayoutTests/fast/css/resize-object-crash-expected.txt	(rev 0)
+++ branches/chromium/1410/LayoutTests/fast/css/resize-object-crash-expected.txt	2013-02-14 22:30:27 UTC (rev 142920)
@@ -0,0 +1,2 @@
+
+PASS


Copied: branches/chromium/1410/LayoutTests/fast/css/resize-object-crash.html (from rev 142788, trunk/LayoutTests/fast/css/resize-object-crash.html) (0 => 142920)

--- branches/chromium/1410/LayoutTests/fast/css/resize-object-crash.html	(rev 0)
+++ branches/chromium/1410/LayoutTests/fast/css/resize-object-crash.html	2013-02-14 22:30:27 UTC (rev 142920)
@@ -0,0 +1,21 @@
+html
+head
+title/title
+script
+if (window.testRunner) {
+testRunner.dumpAsText();
+}
+/script
+style
+object {
+resize: both !important;
+}
+/style
+/head
+body
+!--
+Test for https://crbug.com/175535 - Crash with object style=resize:both
+--
+object/objectbr
+PASS
+/body


Modified: branches/chromium/1410/Source/WebCore/rendering/RenderWidget.cpp (142919 => 142920)

--- branches/chromium/1410/Source/WebCore/rendering/RenderWidget.cpp	2013-02-14 22:27:52 UTC (rev 142919)
+++ branches/chromium/1410/Source/WebCore/rendering/RenderWidget.cpp	2013-02-14 22:30:27 UTC (rev 142920)
@@ -312,7 +312,7 @@
 paintInfo.context-fillRect(pixelSnappedIntRect(selectionRect()), selectionBackgroundColor(), style()-colorSpace());
 }
 
-if (style()-resize() != RESIZE_NONE)
+if (hasLayer()  layer()-canResize())
 layer()-paintResizer(paintInfo.context, roundedIntPoint(adjustedPaintOffset), paintInfo.rect);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [142793] trunk

[leviw]

Title: [142793] trunk








Revision 142793
Author le...@chromium.org
Date 2013-02-13 13:55:24 -0800 (Wed, 13 Feb 2013)


Log Message
Bidi-Isolated inlines can cause subsequent content to not be rendered
https://bugs.webkit.org/show_bug.cgi?id=108137

Reviewed by Eric Seidel.

Source/WebCore:

First step in fixing how inline isolates behave with collapsed spaces.
webkit.org/b/109624 tracks the overarching issue.

Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html

* rendering/InlineIterator.h:
(WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while
ignoring spaces, ensure we leave it considering them again. This can result in
including spaces that should be ignored following the isolate on the line, but
failing to do so results in those contents not being rendered at all.

LayoutTests:

* fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added.
* fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineIterator.h


Added Paths

trunk/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt
trunk/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace.html




Diff

Modified: trunk/LayoutTests/ChangeLog (142792 => 142793)

--- trunk/LayoutTests/ChangeLog	2013-02-13 21:49:23 UTC (rev 142792)
+++ trunk/LayoutTests/ChangeLog	2013-02-13 21:55:24 UTC (rev 142793)
@@ -1,3 +1,13 @@
+2013-02-13  Levi Weintraub  le...@chromium.org
+
+Bidi-Isolated inlines can cause subsequent content to not be rendered
+https://bugs.webkit.org/show_bug.cgi?id=108137
+
+Reviewed by Eric Seidel.
+
+* fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added.
+* fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added.
+
 2013-02-13  Christian Biesinger  cbiesin...@chromium.org
 
 Crash when encountering object style=resize:both;


Added: trunk/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt (0 => 142793)

--- trunk/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt	2013-02-13 21:55:24 UTC (rev 142793)
@@ -0,0 +1,2 @@
+123 456 789
+PASS


Added: trunk/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace.html (0 => 142793)

--- trunk/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace.html	(rev 0)
+++ trunk/LayoutTests/fast/text/content-following-inline-isolate-with-collapsed-whitespace.html	2013-02-13 21:55:24 UTC (rev 142793)
@@ -0,0 +1,8 @@
+!DOCTYPE html
+body
+pspan data-expected-width=80 id=test123
+ span style=unicode-bidi: -webkit-isolate456/span 789/span/p
+script src=""
+script
+checkLayout('#test');
+/script
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (142792 => 142793)

--- trunk/Source/WebCore/ChangeLog	2013-02-13 21:49:23 UTC (rev 142792)
+++ trunk/Source/WebCore/ChangeLog	2013-02-13 21:55:24 UTC (rev 142793)
@@ -1,3 +1,21 @@
+2013-02-13  Levi Weintraub  le...@chromium.org
+
+Bidi-Isolated inlines can cause subsequent content to not be rendered
+https://bugs.webkit.org/show_bug.cgi?id=108137
+
+Reviewed by Eric Seidel.
+
+First step in fixing how inline isolates behave with collapsed spaces.
+webkit.org/b/109624 tracks the overarching issue.
+
+Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html
+
+* rendering/InlineIterator.h:
+(WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while
+ignoring spaces, ensure we leave it considering them again. This can result in
+including spaces that should be ignored following the isolate on the line, but
+failing to do so results in those contents not being rendered at all.
+
 2013-02-13  Andreas Kling  akl...@apple.com
 
 Better names for ElementAttributeData  subclasses.


Modified: trunk/Source/WebCore/rendering/InlineIterator.h (142792 => 142793)

--- trunk/Source/WebCore/rendering/InlineIterator.h	2013-02-13 21:49:23 UTC (rev 142792)
+++ trunk/Source/WebCore/rendering/InlineIterator.h	2013-02-13 21:55:24 UTC (rev 142793)
@@ -489,6 +489,14 @@
 // We don't need to mark the end of the run because this is implicit: it is either endOfLine or the end of the
 // isolate, when we call createBidiRunsForLine it will stop at whichever comes first.
 addPlaceholderRunForIsolatedInline(resolver, obj, pos);
+// FIXME: Inline isolates don't work properly with collapsing whitespace, see webkit.org/b/109624
+  

[webkit-changes] [142821] trunk/LayoutTests

[leviw]

Title: [142821] trunk/LayoutTests








Revision 142821
Author le...@chromium.org
Date 2013-02-13 16:37:59 -0800 (Wed, 13 Feb 2013)


Log Message
REGRESSION(r125794) - inline-children-root-linebox-crash asserts in Chromium debug
https://bugs.webkit.org/show_bug.cgi?id=94256

Unreviewed test expectations update. Re-enabling inline-children-root-linebox-crash
as it was fixed by r139479.


* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (142820 => 142821)

--- trunk/LayoutTests/ChangeLog	2013-02-14 00:12:37 UTC (rev 142820)
+++ trunk/LayoutTests/ChangeLog	2013-02-14 00:37:59 UTC (rev 142821)
@@ -1,3 +1,13 @@
+2013-02-13  Levi Weintraub  le...@chromium.org
+
+REGRESSION(r125794) - inline-children-root-linebox-crash asserts in Chromium debug
+https://bugs.webkit.org/show_bug.cgi?id=94256
+
+Unreviewed test expectations update. Re-enabling inline-children-root-linebox-crash
+as it was fixed by r139479.
+
+* platform/chromium/TestExpectations:
+
 2013-02-13  Elliott Sprehn  espr...@chromium.org
 
 ASSERT(!renderer()-needsLayout()) when calling Element::focus() with generated content


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (142820 => 142821)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-14 00:12:37 UTC (rev 142820)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-14 00:37:59 UTC (rev 142821)
@@ -3681,8 +3681,6 @@
 
 webkit.org/b/94078 [ Win Release ] http/tests/inspector/web-socket-frame-error.html [ Failure Pass ]
 
-webkit.org/b/94256 [ Debug ] fast/block/inline-children-root-linebox-crash.html [ Crash Pass ]
-
 # Following tests need baselines on Win and Linux 
 webkit.org/b/94492 [ Linux Win ] css3/filters/custom/custom-filter-color-matrix.html [ ImageOnlyFailure ]
 webkit.org/b/94492 [ Linux Win ] css3/filters/custom/custom-filter-composite-source-atop.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [142657] trunk

[leviw]

Title: [142657] trunk








Revision 142657
Author le...@chromium.org
Date 2013-02-12 13:01:37 -0800 (Tue, 12 Feb 2013)


Log Message
ASSERTION FAILED: !object || object-isBox(), UNKNOWN in WebCore::RenderListItem::positionListMarker
https://bugs.webkit.org/show_bug.cgi?id=108699

Reviewed by Abhishek Arya.

Source/WebCore:

RenderListItems performs special management of its children to maintain list markers. Splitting a flow
through a list item results in assumptions made inside RenderListItem failing, so for now, avoid splitting
flows when inside one.

Test: fast/multicol/span/list-multi-column-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::containingColumnsBlock):

LayoutTests:

* fast/multicol/span/list-multi-column-crash-expected.txt: Added.
* fast/multicol/span/list-multi-column-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp


Added Paths

trunk/LayoutTests/fast/multicol/span/list-multi-column-crash-expected.txt
trunk/LayoutTests/fast/multicol/span/list-multi-column-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (142656 => 142657)

--- trunk/LayoutTests/ChangeLog	2013-02-12 20:56:57 UTC (rev 142656)
+++ trunk/LayoutTests/ChangeLog	2013-02-12 21:01:37 UTC (rev 142657)
@@ -1,3 +1,13 @@
+2013-02-12  Levi Weintraub  le...@chromium.org
+
+ASSERTION FAILED: !object || object-isBox(), UNKNOWN in WebCore::RenderListItem::positionListMarker
+https://bugs.webkit.org/show_bug.cgi?id=108699
+
+Reviewed by Abhishek Arya.
+
+* fast/multicol/span/list-multi-column-crash-expected.txt: Added.
+* fast/multicol/span/list-multi-column-crash.html: Added.
+
 2013-02-12  Vivek Galatage  vivek...@samsung.com
 
 Web Inspector: _javascript_ execution disabled by browser/UA should be notified to the front-end


Added: trunk/LayoutTests/fast/multicol/span/list-multi-column-crash-expected.txt (0 => 142657)

--- trunk/LayoutTests/fast/multicol/span/list-multi-column-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/multicol/span/list-multi-column-crash-expected.txt	2013-02-12 21:01:37 UTC (rev 142657)
@@ -0,0 +1 @@
+Test passes if it does not crash.


Added: trunk/LayoutTests/fast/multicol/span/list-multi-column-crash.html (0 => 142657)

--- trunk/LayoutTests/fast/multicol/span/list-multi-column-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/span/list-multi-column-crash.html	2013-02-12 21:01:37 UTC (rev 142657)
@@ -0,0 +1,39 @@
+!DOCTYPE html
+html
+body
+Test passes if it does not crash.
+style
+.columns
+{
+	-webkit-column-count: 2;
+	-webkit-column-span: all;
+}
+.list
+{
+	display: list-item;
+}
+/style
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+list = document.createElement('p');
+list.setAttribute('class', 'list');
+listChild = document.createElement('hr');
+list.appendChild(listChild);
+list.appendChild(document.createTextNode('Text.'));
+outerColumns = document.createElement('div');
+outerColumns.appendChild(list);
+document.body.appendChild(outerColumns);
+outerColumns.setAttribute('class', 'columns');
+document.body.offsetTop;
+
+innerColumns = document.createElement('div');
+innerColumns.setAttribute('class', 'columns');
+listChild.appendChild(innerColumns);
+document.body.offsetTop;
+
+document.body.removeChild(outerColumns);
+/script
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (142656 => 142657)

--- trunk/Source/WebCore/ChangeLog	2013-02-12 20:56:57 UTC (rev 142656)
+++ trunk/Source/WebCore/ChangeLog	2013-02-12 21:01:37 UTC (rev 142657)
@@ -1,3 +1,19 @@
+2013-02-12  Levi Weintraub  le...@chromium.org
+
+ASSERTION FAILED: !object || object-isBox(), UNKNOWN in WebCore::RenderListItem::positionListMarker
+https://bugs.webkit.org/show_bug.cgi?id=108699
+
+Reviewed by Abhishek Arya.
+
+RenderListItems performs special management of its children to maintain list markers. Splitting a flow
+through a list item results in assumptions made inside RenderListItem failing, so for now, avoid splitting
+flows when inside one.
+
+Test: fast/multicol/span/list-multi-column-crash.html
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::containingColumnsBlock):
+
 2013-02-12  Roger Fong  roger_f...@apple.com
 
 Unreviewed Windows build fix.


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (142656 => 142657)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2013-02-12 20:56:57 UTC (rev 142656)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2013-02-12 21:01:37 UTC (rev 142657)
@@ -529,13 +529,10 @@
 || curr-isInlineBlockOrInlineTable())
 return 0;
 
-// FIXME: Table manages its own table parts, most of which are RenderBoxes.
-// Multi-column code cannot handle splitting the flow in table. Disabling it
-// to prevent crashes.
- 

[webkit-changes] [141609] branches/chromium/1364

[leviw]

Title: [141609] branches/chromium/1364








Revision 141609
Author le...@chromium.org
Date 2013-02-01 10:56:23 -0800 (Fri, 01 Feb 2013)


Log Message
Merge 141357
 [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
 https://bugs.webkit.org/show_bug.cgi?id=108381
 
 Reviewed by James Robinson.
 
 Source/WebKit/chromium:
 
 WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
 touch events. Some plugins make this request more than once, leading to an imbalance in Document's
 touch event handler map, and a stale node pointer when the plugin is destroyed. This change
 has WebPluginContainerImpl only add one ref for the plugin at a time.
 
 * src/WebPluginContainerImpl.cpp:
 (WebKit::WebPluginContainerImpl::requestTouchEventType):
 
 Tools:
 
 * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that
 tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.
 
 LayoutTests:
 
 * platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added.
 * platform/chromium/plugins/re-request-touch-events-crash.html: Added.
 

TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/12088115

Modified Paths

branches/chromium/1364/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
branches/chromium/1364/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp


Added Paths

branches/chromium/1364/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt
branches/chromium/1364/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html




Diff

Copied: branches/chromium/1364/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt (from rev 141357, trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt) (0 => 141609)

--- branches/chromium/1364/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt	2013-02-01 18:56:23 UTC (rev 141609)
@@ -0,0 +1,5 @@
+PASS window.internals.touchEventHandlerCount(document) is 1
+PASS window.internals.touchEventHandlerCount(document) is 0
+This test ensures that we don't imbalance the touch event handler count if a plugin requests touch events more than once. The test passes if there are no touch event listeners after the plugin is removed, and there is no crash. Must be run in DRT.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.


Copied: branches/chromium/1364/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html (from rev 141357, trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html) (0 => 141609)

--- branches/chromium/1364/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html	2013-02-01 18:56:23 UTC (rev 141609)
@@ -0,0 +1,25 @@
+html
+head
+script src=""
+/head
+
+body
+embed id=touch_plugin type=application/x-webkit-test-webplugin accepts-touch=raw re-request-touch=true/embed
+p id=description/p
+script
+description(This test ensures that we don't imbalance the touch event handler count if a plugin requests touch events more than once. The test passes if there are no touch event listeners after the plugin is removed, and there is no crash. Must be run in DRT.);
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+
+// Force the plugin to initialize
+touch_plugin.offsetTop;
+
+shouldBe(window.internals.touchEventHandlerCount(document), 1)
+touch_plugin.parentNode.removeChild(touch_plugin);
+shouldBe(window.internals.touchEventHandlerCount(document), 0)
+}
+
+/script
+/body
+script src=""


Modified: branches/chromium/1364/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (141608 => 141609)

--- branches/chromium/1364/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp	2013-02-01 18:55:09 UTC (rev 141608)
+++ branches/chromium/1364/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp	2013-02-01 18:56:23 UTC (rev 141609)
@@ -525,11 +525,12 @@
 {
 if (m_touchEventRequestType == requestType)
 return;
-m_touchEventRequestType = requestType;
-if (m_touchEventRequestType != TouchEventRequestTypeNone)
+
+if (requestType != TouchEventRequestTypeNone  m_touchEventRequestType == TouchEventRequestTypeNone)
 m_element-document()-didAddTouchEventHandler(m_element);
-else
+else if (requestType == TouchEventRequestTypeNone  m_touchEventRequestType != TouchEventRequestTypeNone)
 m_element-document()-didRemoveTouchEventHandler(m_element);
+m_touchEventRequestType = requestType;
 }
 
 void WebPluginContainerImpl::setWantsWheelEvents(bool wantsWheelEvents)


Modified: 

[webkit-changes] [141670] trunk/Source/WebCore

[leviw]

Title: [141670] trunk/Source/WebCore








Revision 141670
Author le...@chromium.org
Date 2013-02-01 17:27:00 -0800 (Fri, 01 Feb 2013)


Log Message
Unreviewed, rolling out r141669.
http://trac.webkit.org/changeset/141669
https://bugs.webkit.org/show_bug.cgi?id=108728

Broke the windows build. (Requested by leviw on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2013-02-01

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (141669 => 141670)

--- trunk/Source/WebCore/ChangeLog	2013-02-02 01:10:04 UTC (rev 141669)
+++ trunk/Source/WebCore/ChangeLog	2013-02-02 01:27:00 UTC (rev 141670)
@@ -1,3 +1,24 @@
+2013-02-01  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r141669.
+http://trac.webkit.org/changeset/141669
+https://bugs.webkit.org/show_bug.cgi?id=108728
+
+Broke the windows build. (Requested by leviw on #webkit).
+
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
+(WebCore):
+(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
+(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
+(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
+(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
+(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
+(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
+(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
+* rendering/RenderBoxModelObject.h:
+(RenderBoxModelObject):
+
 2013-02-01  Emil A Eklund  e...@chromium.org
 
 Remove duplicate code in RenderBoxModelObject::computedCSSPadding*


Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (141669 => 141670)

--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp	2013-02-02 01:10:04 UTC (rev 141669)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp	2013-02-02 01:27:00 UTC (rev 141670)
@@ -558,10 +558,11 @@
 return snapSizeToPixel(offsetHeight(), offsetTop());
 }
 
-LayoutUnit RenderBoxModelObject::computedCSSPadding(Length padding) const
+LayoutUnit RenderBoxModelObject::computedCSSPaddingTop() const
 {
 LayoutUnit w = 0;
 RenderView* renderView = 0;
+Length padding = style()-paddingTop();
 if (padding.isPercent())
 w = containingBlockLogicalWidthForContent();
 else if (padding.isViewportPercentage())
@@ -569,6 +570,90 @@
 return minimumValueForLength(padding, w, renderView);
 }
 
+LayoutUnit RenderBoxModelObject::computedCSSPaddingBottom() const
+{
+LayoutUnit w = 0;
+RenderView* renderView = 0;
+Length padding = style()-paddingBottom();
+if (padding.isPercent())
+w = containingBlockLogicalWidthForContent();
+else if (padding.isViewportPercentage())
+renderView = view();
+return minimumValueForLength(padding, w, renderView);
+}
+
+LayoutUnit RenderBoxModelObject::computedCSSPaddingLeft() const
+{
+LayoutUnit w = 0;
+RenderView* renderView = 0;
+Length padding = style()-paddingLeft();
+if (padding.isPercent())
+w = containingBlockLogicalWidthForContent();
+else if (padding.isViewportPercentage())
+renderView = view();
+return minimumValueForLength(padding, w, renderView);
+}
+
+LayoutUnit RenderBoxModelObject::computedCSSPaddingRight() const
+{
+LayoutUnit w = 0;
+RenderView* renderView = 0;
+Length padding = style()-paddingRight();
+if (padding.isPercent())
+w = containingBlockLogicalWidthForContent();
+else if (padding.isViewportPercentage())
+renderView = view();
+return minimumValueForLength(padding, w, renderView);
+}
+
+LayoutUnit RenderBoxModelObject::computedCSSPaddingBefore() const
+{
+LayoutUnit w = 0;
+RenderView* renderView = 0;
+Length padding = style()-paddingBefore();
+if (padding.isPercent())
+w = containingBlockLogicalWidthForContent();
+else if (padding.isViewportPercentage())
+renderView = view();
+return minimumValueForLength(padding, w, renderView);
+}
+
+LayoutUnit RenderBoxModelObject::computedCSSPaddingAfter() const
+{
+LayoutUnit w = 0;
+RenderView* renderView = 0;
+Length padding =

[webkit-changes] [141357] trunk

[leviw]

Title: [141357] trunk








Revision 141357
Author le...@chromium.org
Date 2013-01-30 18:15:03 -0800 (Wed, 30 Jan 2013)


Log Message
[Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
https://bugs.webkit.org/show_bug.cgi?id=108381

Reviewed by James Robinson.

Source/WebKit/chromium:

WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
touch events. Some plugins make this request more than once, leading to an imbalance in Document's
touch event handler map, and a stale node pointer when the plugin is destroyed. This change
has WebPluginContainerImpl only add one ref for the plugin at a time.

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::requestTouchEventType):

Tools:

* DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that
tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.

LayoutTests:

* platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added.
* platform/chromium/plugins/re-request-touch-events-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp


Added Paths

trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt
trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (141356 => 141357)

--- trunk/LayoutTests/ChangeLog	2013-01-31 02:13:12 UTC (rev 141356)
+++ trunk/LayoutTests/ChangeLog	2013-01-31 02:15:03 UTC (rev 141357)
@@ -1,3 +1,13 @@
+2013-01-30  Levi Weintraub  le...@chromium.org
+
+[Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
+https://bugs.webkit.org/show_bug.cgi?id=108381
+
+Reviewed by James Robinson.
+
+* platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added.
+* platform/chromium/plugins/re-request-touch-events-crash.html: Added.
+
 2013-01-30  Rouslan Solomakhin  rous...@chromium.org
 
 Tests for spellcheck behavior


Added: trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt (0 => 141357)

--- trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt	2013-01-31 02:15:03 UTC (rev 141357)
@@ -0,0 +1,5 @@
+PASS window.internals.touchEventHandlerCount(document) is 1
+PASS window.internals.touchEventHandlerCount(document) is 0
+This test ensures that we don't imbalance the touch event handler count if a plugin requests touch events more than once. The test passes if there are no touch event listeners after the plugin is removed, and there is no crash. Must be run in DRT.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.


Added: trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html (0 => 141357)

--- trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html	(rev 0)
+++ trunk/LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html	2013-01-31 02:15:03 UTC (rev 141357)
@@ -0,0 +1,25 @@
+html
+head
+script src=""
+/head
+
+body
+embed id=touch_plugin type=application/x-webkit-test-webplugin accepts-touch=raw re-request-touch=true/embed
+p id=description/p
+script
+description(This test ensures that we don't imbalance the touch event handler count if a plugin requests touch events more than once. The test passes if there are no touch event listeners after the plugin is removed, and there is no crash. Must be run in DRT.);
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+
+// Force the plugin to initialize
+touch_plugin.offsetTop;
+
+shouldBe(window.internals.touchEventHandlerCount(document), 1)
+touch_plugin.parentNode.removeChild(touch_plugin);
+shouldBe(window.internals.touchEventHandlerCount(document), 0)
+}
+
+/script
+/body
+script src=""


Modified: trunk/Source/WebKit/chromium/ChangeLog (141356 => 141357)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-31 02:13:12 UTC (rev 141356)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-31 02:15:03 UTC (rev 141357)
@@ -1,3 +1,18 @@
+2013-01-30  Levi Weintraub  le...@chromium.org
+
+[Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
+https://bugs.webkit.org/show_bug.cgi?id=108381
+
+Reviewed by James Robinson.
+
+WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
+touch events. Some plugins make this request more than once, leading to an imbalance in Document's
+touch event handler map, and a stale node pointer when the plugin 

[webkit-changes] [140855] branches/chromium/1364

[leviw]

Title: [140855] branches/chromium/1364








Revision 140855
Author le...@chromium.org
Date 2013-01-25 11:54:27 -0800 (Fri, 25 Jan 2013)


Log Message
Merge 140370
 Event target rects on the top level document shouldn't be clipped.
 https://bugs.webkit.org/show_bug.cgi?id=107339
 
 Reviewed by James Robinson.
 
 Source/WebCore:
 
 clippedOverflowRectForRepaint clips the top-level RenderView to the viewport, which
 is wrong for generating event target rects, as the result will not extend to the bounds
 of the document on pages that scroll. Changing the top-level view to use documentRect
 instead.
 
 Tests updated to cover bug: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html
 platform/chromium/fast/events/touch/compositor-touch-hit-rects.html
 
 * page/scrolling/ScrollingCoordinator.cpp:
 (WebCore::accumulateRendererTouchEventTargetRects): Use converToRootView instead of
 a loop around convertToContaining view. This is not a change in behavior.
 (WebCore::accumulateDocumentEventTargetRects): Switch to use documentRect instead of
 clippedOverflowRectForRepaint for the top-level Document, and use converToRootView
 to put rects in the coordinates of the top-level document.
 
 LayoutTests:
 
 Updating existing tests to cover this issue.
 
 * platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
 * platform/chromium/fast/events/touch/compositor-touch-hit-rects.html:
 * platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt:
 * platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html:
 * platform/chromium/fast/events/touch/resources/frame-with-document-touch-handler.html: Added.
 * platform/chromium/TestExpectations:
 

TBR=le...@chromium.org

Modified Paths

branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations
branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html
branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt
branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html
branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp




Diff

Modified: branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations (140854 => 140855)

--- branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations	2013-01-25 19:51:57 UTC (rev 140854)
+++ branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations	2013-01-25 19:54:27 UTC (rev 140855)
@@ -3922,6 +3922,9 @@
 
 webkit.org/b/98275 media/event-queue-crash.html [ Skip ]
 
+# Needs rebaselining on after webkit.org/b/107339
+webkit.org/b/107339 [ Mac Android Win ] platform/chromium/fast/events/touch/compositor-touch-hit-rects.html [ Pass Failure ]
+
 # Requires rebaselining after https://bugs.webkit.org/show_bug.cgi?id=11645
 webkit.org/b/11645 [ Mac Android ] fast/table/025.html [ Failure ]
 


Modified: branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html (140854 => 140855)

--- branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html	2013-01-25 19:51:57 UTC (rev 140854)
+++ branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html	2013-01-25 19:54:27 UTC (rev 140855)
@@ -23,6 +23,9 @@
 #tests {
 	font: 10px Ahem;
 }
+body {
+	height: 1000px;
+}
 /style
 /head
 body
@@ -76,17 +79,23 @@
 	return a.top - b.top;
 }
 
-function logRects(id) {
+function testElementWithId(id)
+{
 	element = document.getElementById(id);
 	element.addEventListener('touchstart', listener, false);
+	logRects(id);
+	element.removeEventListener('touchstart', listener, false);
+}
+
+function logRects(testName) {
+
 	rects = window.internals.touchEventTargetClientRects(document);
 	var sortedRects = new Array();
 	for (var i = 0; i  rects.length; ++i)
 		sortedRects[i] = rects[i];
 	sortedRects.sort(sortRects);
 	for (var i = 0; i  rects.length; ++i)
-		log(id + [ + i + ]: ( + sortedRects[i].left + ,  + sortedRects[i].top + ,  + sortedRects[i].width + ,  + sortedRects[i].height + ));
-	element.removeEventListener('touchstart', listener, false);
+		log(testName + [ + i + ]: ( + sortedRects[i].left + ,  + sortedRects[i].top + ,  + sortedRects[i].width + ,  + sortedRects[i].height + ));
 }
 
 function runTest() {
@@ -94,14 +103,17 @@
 		return;
 
 	window.testRunner.dumpAsText();
-	logRects(normalFlow);
-	logRects(absoluteChildContainer);
-	logRects(relativeChildContainer);
-	logRects(overhangingContainer);
-	logRects(transformedChildContainer);
-	logRects(continuation);
-	logRects(inlineAbsoluteChildContainer);
+	testElementWithId(normalFlow);
+	testElementWithId(absoluteChildContainer);
+	testElementWithId(relativeChildContainer);
+	testElementWithId(overhangingContainer);
+	testElementWithId(transformedChildContainer);
+	

[webkit-changes] [140866] trunk/LayoutTests

[leviw]

Title: [140866] trunk/LayoutTests








Revision 140866
Author le...@chromium.org
Date 2013-01-25 14:28:43 -0800 (Fri, 25 Jan 2013)


Log Message
Unreviewed gardening. Updating baselines following r140192.

* platform/chromium-mac-lion/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
* platform/chromium-mac-snowleopard/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
* platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
* platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/chromium-win-xp/fast/regions: Removed.
* platform/chromium-win/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt
trunk/LayoutTests/platform/chromium-mac-lion/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png
trunk/LayoutTests/platform/chromium-win/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png
trunk/LayoutTests/platform/mac/TestExpectations


Removed Paths

trunk/LayoutTests/platform/chromium-win-xp/fast/regions/




Diff

Modified: trunk/LayoutTests/ChangeLog (140865 => 140866)

--- trunk/LayoutTests/ChangeLog	2013-01-25 22:22:08 UTC (rev 140865)
+++ trunk/LayoutTests/ChangeLog	2013-01-25 22:28:43 UTC (rev 140866)
@@ -1,3 +1,16 @@
+2013-01-25  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Updating baselines following r140192.
+
+* platform/chromium-mac-lion/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
+* platform/chromium-mac-snowleopard/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
+* platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
+* platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
+* platform/chromium-win-xp/fast/regions: Removed.
+* platform/chromium-win/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
+* platform/chromium/TestExpectations:
+* platform/mac/TestExpectations:
+
 2013-01-25  Eric Carlson  eric.carl...@apple.com
 
 Adding a text track should not make controls visible


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (140865 => 140866)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-25 22:22:08 UTC (rev 140865)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-25 22:28:43 UTC (rev 140866)
@@ -3888,11 +3888,6 @@
 # Requires rebaselining after https://bugs.webkit.org/show_bug.cgi?id=11645
 webkit.org/b/11645 [ Mac Android ] fast/table/025.html [ Failure ]
 
-# Rebaseline required after https://webkit.org/b/107208
-Bug(leviw) [ Mac Android Win ] fast/regions/overflow-moving-below-floats-in-variable-width-regions.html [ Pass Failure ImageOnlyFailure ]
-Bug(leviw) [ Mac Android Win ] fast/regions/overflow-size-change-in-variable-width-regions.html [ Pass Failure ImageOnlyFailure ]
-Bug(leviw) [ Mac Android Win ] fast/regions/overflow-size-change-with-stacking-context.html [ Pass Failure ImageOnlyFailure ]
-
 # Rebaseline required after https://bugs.webkit.org/show_bug.cgi?id=101177
 webkit.org/b/101177 svg/dynamic-updates/SVGUseElement-dom-requiredFeatures.html [ ImageOnlyFailure Pass ]
 webkit.org/b/101177 svg/repaint/inner-svg-change-viewBox.svg [ ImageOnlyFailure Pass ]


Modified: trunk/LayoutTests/platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt (140865 => 140866)

--- trunk/LayoutTests/platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt	2013-01-25 22:22:08 UTC (rev 140865)
+++ trunk/LayoutTests/platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt	2013-01-25 22:28:43 UTC (rev 140866)
@@ -22,8 +22,8 @@
 layer at (54,56) size 293x243 clip at (55,57) size 291x241 scrollWidth 500
   RenderBlock {DIV} at (48,51) size 294x243 [border: (1px solid #008000)]
 RenderBlock {DIV} at (1,1) size 500x18
-  RenderText {#text} at (-1

[webkit-changes] [140370] trunk

[leviw]

Title: [140370] trunk








Revision 140370
Author le...@chromium.org
Date 2013-01-21 16:31:57 -0800 (Mon, 21 Jan 2013)


Log Message
Event target rects on the top level document shouldn't be clipped.
https://bugs.webkit.org/show_bug.cgi?id=107339

Reviewed by James Robinson.

Source/WebCore:

clippedOverflowRectForRepaint clips the top-level RenderView to the viewport, which
is wrong for generating event target rects, as the result will not extend to the bounds
of the document on pages that scroll. Changing the top-level view to use documentRect
instead.

Tests updated to cover bug: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html
platform/chromium/fast/events/touch/compositor-touch-hit-rects.html

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::accumulateRendererTouchEventTargetRects): Use converToRootView instead of
a loop around convertToContaining view. This is not a change in behavior.
(WebCore::accumulateDocumentEventTargetRects): Switch to use documentRect instead of
clippedOverflowRectForRepaint for the top-level Document, and use converToRootView
to put rects in the coordinates of the top-level document.

LayoutTests:

Updating existing tests to cover this issue.

* platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
* platform/chromium/fast/events/touch/compositor-touch-hit-rects.html:
* platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt:
* platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html:
* platform/chromium/fast/events/touch/resources/frame-with-document-touch-handler.html: Added.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html
trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt
trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html
trunk/LayoutTests/platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp


Added Paths

trunk/LayoutTests/platform/chromium/fast/events/touch/resources/frame-with-document-touch-handler.html




Diff

Modified: trunk/LayoutTests/ChangeLog (140369 => 140370)

--- trunk/LayoutTests/ChangeLog	2013-01-22 00:27:39 UTC (rev 140369)
+++ trunk/LayoutTests/ChangeLog	2013-01-22 00:31:57 UTC (rev 140370)
@@ -1,3 +1,19 @@
+2013-01-21  Levi Weintraub  le...@chromium.org
+
+Event target rects on the top level document shouldn't be clipped.
+https://bugs.webkit.org/show_bug.cgi?id=107339
+
+Reviewed by James Robinson.
+
+Updating existing tests to cover this issue.
+
+* platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
+* platform/chromium/fast/events/touch/compositor-touch-hit-rects.html:
+* platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt:
+* platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html:
+* platform/chromium/fast/events/touch/resources/frame-with-document-touch-handler.html: Added.
+* platform/chromium/TestExpectations:
+
 2013-01-21  Nico Weber  tha...@chromium.org
 
 [chromium] Update expectations.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (140369 => 140370)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-22 00:27:39 UTC (rev 140369)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-22 00:31:57 UTC (rev 140370)
@@ -3907,6 +3907,9 @@
 
 webkit.org/b/98275 media/event-queue-crash.html [ Skip ]
 
+# Needs rebaselining on after webkit.org/b/107339
+webkit.org/b/107339 [ Mac Android Win ] platform/chromium/fast/events/touch/compositor-touch-hit-rects.html [ Pass Failure ]
+
 # Requires rebaselining after https://bugs.webkit.org/show_bug.cgi?id=11645
 webkit.org/b/11645 [ Mac Android ] fast/table/025.html [ Failure ]
 


Modified: trunk/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html (140369 => 140370)

--- trunk/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html	2013-01-22 00:27:39 UTC (rev 140369)
+++ trunk/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html	2013-01-22 00:31:57 UTC (rev 140370)
@@ -23,6 +23,9 @@
 #tests {
 	font: 10px Ahem;
 }
+body {
+	height: 1000px;
+}
 /style
 /head
 body
@@ -76,17 +79,23 @@
 	return a.top - b.top;
 }
 
-function logRects(id) {
+function testElementWithId(id)
+{
 	element = document.getElementById(id);
 	element.addEventListener('touchstart', listener, false);
+	logRects(id);
+	element.removeEventListener('touchstart', listener, false);
+}
+
+function logRects(testName) {
+
 	rects = 

[webkit-changes] [140374] trunk/LayoutTests

[leviw]

Title: [140374] trunk/LayoutTests








Revision 140374
Author le...@chromium.org
Date 2013-01-21 17:39:17 -0800 (Mon, 21 Jan 2013)


Log Message
Unreviewed gardening. Updating expectations for Mac platforms after r140370.

* platform/chromium-mac-snowleopard/platform/chromium/fast/events: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/events/
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch/
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (140373 => 140374)

--- trunk/LayoutTests/ChangeLog	2013-01-22 01:04:37 UTC (rev 140373)
+++ trunk/LayoutTests/ChangeLog	2013-01-22 01:39:17 UTC (rev 140374)
@@ -1,3 +1,11 @@
+2013-01-21  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Updating expectations for Mac platforms after r140370.
+
+* platform/chromium-mac-snowleopard/platform/chromium/fast/events: Added.
+* platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch: Added.
+* platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
+
 2013-01-21  Nico Weber  tha...@chromium.org
 
 [chromium] Unreviewed, update baselines after r140358. See also bug 107476.


Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt (0 => 140374)

--- trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt	2013-01-22 01:39:17 UTC (rev 140374)
@@ -0,0 +1,5 @@
+This test validates that touch hit tests rects are created in the coordinates of the outermost view, not their containing view. This test only works in DumpRenderTree.
+[0]: (10, 46, 285, 135)
+[1]: (60, 110, 50, 50)
+[2]: (420, 170, 50, 50)
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140192] trunk

[leviw]

 256px;
+  left: 200px;
+  background: green;
+  border: 1px solid black;
+}
+/style
+/head
+body
+div id=layer/div
+/body
\ No newline at end of file


Added: trunk/LayoutTests/fast/sub-pixel/sub-pixel-root-layer.html (0 => 140192)

--- trunk/LayoutTests/fast/sub-pixel/sub-pixel-root-layer.html	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/sub-pixel-root-layer.html	2013-01-18 20:21:57 UTC (rev 140192)
@@ -0,0 +1,35 @@
+!DOCTYPE html
+html
+head
+style
+#list {
+width: 639px;
+}
+.item {
+  width: 256px;
+  margin: 8px auto;
+}
+.icon {
+  display: block;
+  width: 256px;
+  height: 256px;
+  border: 1px solid red;
+  background-color: red;
+}
+#layer {
+  position: relative;
+  top: -258px;
+  width: 256px;
+  height: 256px;
+  background: green;
+  border: 1px solid black;
+}
+/style
+/head
+body
+div id=list
+div class=itemimg class=icon style=-webkit-transform: scaleX(-1);
+  div id=layer/div
+/div
+/div
+/body
\ No newline at end of file


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (140191 => 140192)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-18 19:58:16 UTC (rev 140191)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-18 20:21:57 UTC (rev 140192)
@@ -3910,6 +3910,11 @@
 # Requires rebaselining after https://bugs.webkit.org/show_bug.cgi?id=11645
 webkit.org/b/11645 [ Mac Android ] fast/table/025.html [ Failure ]
 
+# Rebaseline required after https://webkit.org/b/107208
+Bug(leviw) [ Mac Android Win ] fast/regions/overflow-moving-below-floats-in-variable-width-regions.html [ Pass Failure ImageOnlyFailure ]
+Bug(leviw) [ Mac Android Win ] fast/regions/overflow-size-change-in-variable-width-regions.html [ Pass Failure ImageOnlyFailure ]
+Bug(leviw) [ Mac Android Win ] fast/regions/overflow-size-change-with-stacking-context.html [ Pass Failure ImageOnlyFailure ]
+
 # Rebaseline required after https://bugs.webkit.org/show_bug.cgi?id=101177
 webkit.org/b/101177 svg/dynamic-updates/SVGUseElement-dom-requiredFeatures.html [ ImageOnlyFailure Pass ]
 webkit.org/b/101177 svg/repaint/inner-svg-change-viewBox.svg [ ImageOnlyFailure Pass ]


Modified: trunk/LayoutTests/platform/chromium-linux/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-linux/fast/regions/overflow-size-change-in-variable-width-regions-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-linux/fast/regions/overflow-size-change-with-stacking-context-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt (140191 => 140192)

--- trunk/LayoutTests/platform/chromium-win/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt	2013-01-18 19:58:16 UTC (rev 140191)
+++ trunk/LayoutTests/platform/chromium-win/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt	2013-01-18 20:21:57 UTC (rev 140192)
@@ -22,8 +22,8 @@
 layer at (54,56) size 293x245 clip at (55,57) size 291x243 scrollWidth 500
   RenderBlock {DIV} at (48,51) size 294x245 [border: (1px solid #008000)]
 RenderBlock {DIV} at (1,1) size 500x20
-  RenderText {#text} at (-13,0) size 270x19
-text run at (-13,0) width 270: Clipped line of text that should not be visible.
+  RenderText {#text} at (-12,0) size 270x19
+text run at (-12,0) width 270: Clipped line of text that should not be visible.
 RenderBlock {P} at (1,44) size 291x80
   RenderText {#text} at (0,0) size 291x79
 text run at (0,0) width 291: These lines will not spill out of the regions.
@@ -37,8 +37,8 @@
 text run at (0,40) width 291: These lines will not spill out of the regions.
 text run at (0,60) width 252: These lines will not spill out of the regions.
 RenderBlock {DIV} at (1,224) size 500x20
-  RenderText {#text} at (-23,0) size 270x19
-text run at (-23,0) width 270: Clipped line of text that should not be visible.
+  RenderText {#text} at (-22,0) size 270x19
+text run at (-22,0) width 270: Clipped line of text that should not be visible.
   Regions for flow 'flow1'
 RenderRegion {DIV} #region1
 RenderRegion {DIV} #region2


Modified: trunk/LayoutTests/platform/chromium-win/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt (140191 => 140192)

--- trunk/LayoutTests/platform/chromium-win/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt	2013-01-18 19:58:16 UTC (rev 140191)
+++ trunk/LayoutTests/platform/chromium-win/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt	2013-01-18 20:21:57 UTC (rev 140192)
@@ -20,30 +20,30 @@
 layer at (41,6) size 218x391 clip at (42,7) size 216x389 scrollWidth 500

[webkit-changes] [139892] trunk/LayoutTests

[leviw]

Title: [139892] trunk/LayoutTests








Revision 139892
Author le...@chromium.org
Date 2013-01-16 10:23:16 -0800 (Wed, 16 Jan 2013)


Log Message
Unreveiwed gardening. Updating expectations following r139865.

* platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png
trunk/LayoutTests/platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (139891 => 139892)

--- trunk/LayoutTests/ChangeLog	2013-01-16 18:02:46 UTC (rev 139891)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 18:23:16 UTC (rev 139892)
@@ -1,3 +1,14 @@
+2013-01-16  Levi Weintraub  le...@chromium.org
+
+Unreveiwed gardening. Updating expectations following r139865.
+
+* platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
+* platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
+* platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
+* platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
+* platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
+* platform/chromium/TestExpectations:
+
 2013-01-16  Andrey Adaikin  aand...@chromium.org
 
 Web Inspector: array grouping does not work for float number keys


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139891 => 139892)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 18:02:46 UTC (rev 139891)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 18:23:16 UTC (rev 139892)
@@ -4092,9 +4092,6 @@
 
 webkit.org/b/104993 [ XP ] fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html [ Failure ]
 
-# Need rebaseline
-webkit.org/b/106983 fast/forms/time/time-appearance-basic.html [ Failure ]
-
 webkit.org/b/106518 compositing/iframes/iframe-content-flipping.html [ ImageOnlyFailure ]
 webkit.org/b/106518 platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html [ ImageOnlyFailure ]
 


Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139893] trunk/LayoutTests

[leviw]

Title: [139893] trunk/LayoutTests








Revision 139893
Author le...@chromium.org
Date 2013-01-16 10:32:23 -0800 (Wed, 16 Jan 2013)


Log Message
Unreviewed gardening. Marking several tests as crashing on Debug builds following
r139853.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139892 => 139893)

--- trunk/LayoutTests/ChangeLog	2013-01-16 18:23:16 UTC (rev 139892)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 18:32:23 UTC (rev 139893)
@@ -1,5 +1,12 @@
 2013-01-16  Levi Weintraub  le...@chromium.org
 
+Unreviewed gardening. Marking several tests as crashing on Debug builds following
+r139853.
+
+* platform/chromium/TestExpectations:
+
+2013-01-16  Levi Weintraub  le...@chromium.org
+
 Unreveiwed gardening. Updating expectations following r139865.
 
 * platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139892 => 139893)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 18:23:16 UTC (rev 139892)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 18:32:23 UTC (rev 139893)
@@ -4382,3 +4382,7 @@
 webkit.org/b/106858 [ SnowLeopard Debug ] scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ ImageOnlyFailure ]
 webkit.org/b/106858 [ Mac Debug ] scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ ImageOnlyFailure ]
 
+webkit.org/b/107033 [ Debug ] fast/frames/valid.html [ Crash ]
+webkit.org/b/107033 [ Debug ] fast/events/form-iframe-target-before-load-crash.html [ Crash ]
+webkit.org/b/107033 [ Debug ] fast/events/before-unload-with-subframes.html [ Crash ]
+webkit.org/b/107033 [ Debug ] fast/css/stylesheet-enable-first-alternate-link.html [ Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139917] trunk

[leviw]

Title: [139917] trunk








Revision 139917
Author le...@chromium.org
Date 2013-01-16 13:33:01 -0800 (Wed, 16 Jan 2013)


Log Message
Unreviewed, rolling out r139853.
http://trac.webkit.org/changeset/139853
https://bugs.webkit.org/show_bug.cgi?id=107049

Broke the ChromeOS ppapi_unittests (Requested by leviw on
#webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2013-01-16

Source/WebCore: 

* inspector/Inspector.json:
* inspector/InspectorInstrumentation.cpp:
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
* inspector/InspectorPageAgent.cpp:
* inspector/InspectorPageAgent.h:
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.frameDetached):
* loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::clear):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::startTimer):
(WebCore::NavigationScheduler::cancel):
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):

LayoutTests: 

* inspector-protocol/page/frameScheduledNavigation-expected.txt: Removed.
* inspector-protocol/page/frameScheduledNavigation.html: Removed.
* inspector-protocol/page/frameStartedLoading-expected.txt: Removed.
* inspector-protocol/page/frameStartedLoading.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js
trunk/Source/WebCore/loader/NavigationScheduler.cpp
trunk/Source/WebCore/loader/ProgressTracker.cpp


Removed Paths

trunk/LayoutTests/inspector-protocol/page/




Diff

Modified: trunk/LayoutTests/ChangeLog (139916 => 139917)

--- trunk/LayoutTests/ChangeLog	2013-01-16 21:23:34 UTC (rev 139916)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 21:33:01 UTC (rev 139917)
@@ -1,3 +1,17 @@
+2013-01-16  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r139853.
+http://trac.webkit.org/changeset/139853
+https://bugs.webkit.org/show_bug.cgi?id=107049
+
+Broke the ChromeOS ppapi_unittests (Requested by leviw on
+#webkit).
+
+* inspector-protocol/page/frameScheduledNavigation-expected.txt: Removed.
+* inspector-protocol/page/frameScheduledNavigation.html: Removed.
+* inspector-protocol/page/frameStartedLoading-expected.txt: Removed.
+* inspector-protocol/page/frameStartedLoading.html: Removed.
+
 2013-01-16  Florin Malita  fmal...@chromium.org
 
 [Chromium] Unreviewed gardening.


Modified: trunk/Source/WebCore/ChangeLog (139916 => 139917)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 21:23:34 UTC (rev 139916)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 21:33:01 UTC (rev 139917)
@@ -1,3 +1,30 @@
+2013-01-16  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r139853.
+http://trac.webkit.org/changeset/139853
+https://bugs.webkit.org/show_bug.cgi?id=107049
+
+Broke the ChromeOS ppapi_unittests (Requested by leviw on
+#webkit).
+
+* inspector/Inspector.json:
+* inspector/InspectorInstrumentation.cpp:
+(WebCore):
+* inspector/InspectorInstrumentation.h:
+(InspectorInstrumentation):
+* inspector/InspectorPageAgent.cpp:
+* inspector/InspectorPageAgent.h:
+* inspector/front-end/ResourceTreeModel.js:
+(WebInspector.PageDispatcher.prototype.frameDetached):
+* loader/NavigationScheduler.cpp:
+(WebCore::NavigationScheduler::clear):
+(WebCore::NavigationScheduler::timerFired):
+(WebCore::NavigationScheduler::startTimer):
+(WebCore::NavigationScheduler::cancel):
+* loader/ProgressTracker.cpp:
+(WebCore::ProgressTracker::progressStarted):
+(WebCore::ProgressTracker::finalProgressComplete):
+
 2013-01-16  Kenneth Russell  k...@google.com
 
 Simplify validation and data copying in WebGLBuffer


Modified: trunk/Source/WebCore/inspector/Inspector.json (139916 => 139917)

--- trunk/Source/WebCore/inspector/Inspector.json	2013-01-16 21:23:34 UTC (rev 139916)
+++ trunk/Source/WebCore/inspector/Inspector.json	2013-01-16 21:33:01 UTC (rev 139917)
@@ -494,39 +494,6 @@
 { name: frameId, $ref: Network.FrameId, description: Id of the frame that has been detached. }
 ],
 hidden: true
-},
-{
-name: frameStartedLoading,
-description: Fired when frame has started loading.,
-parameters: [
-{ name: frameId, $ref: Network.FrameId, description: Id of the frame that has starte

[webkit-changes] [139748] trunk/LayoutTests

[leviw]

Title: [139748] trunk/LayoutTests








Revision 139748
Author le...@chromium.org
Date 2013-01-15 09:50:55 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed gardening. Marking the deferred version of
fast/images/zoomed-offset-size.html as slow.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139747 => 139748)

--- trunk/LayoutTests/ChangeLog	2013-01-15 17:24:04 UTC (rev 139747)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 17:50:55 UTC (rev 139748)
@@ -1,3 +1,10 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking the deferred version of
+fast/images/zoomed-offset-size.html as slow.
+
+* platform/chromium/TestExpectations:
+
 2013-01-15  Florin Malita  fmal...@chromium.org
 
 [Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139747 => 139748)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-15 17:24:04 UTC (rev 139747)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-15 17:50:55 UTC (rev 139748)
@@ -97,6 +97,7 @@
 webkit.org/b/106606 platform/chromium/virtual/gpu/fast/canvas/webgl/context-release-upon-reload.html [ Pass Slow ]
 webkit.org/b/106853 [ Debug ] media/track/track-css-cue-lifetime.html [ Pass Timeout ]
 webkit.org/b/106855 [ Debug ] fast/images/zoomed-offset-size.html [ Pass Slow ]
+webkit.org/b/106855 [ Debug ] platform/chromium/virtual/deferred/fast/images/zoomed-offset-size.html [ Pass Slow ]
 
 # These tests started being slow when we switched to DRT.
 webkit.org/b/90488 [ Debug ] inspector [ Pass Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139795] trunk/Tools

[leviw]

Title: [139795] trunk/Tools








Revision 139795
Author le...@chromium.org
Date 2013-01-15 14:46:47 -0800 (Tue, 15 Jan 2013)


Log Message
[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=106904

Reverting 139794. It broke the build. It appears that a header file,
WebTextDirection.h, was left out.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner::setTitleTextDirection):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveTitle):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp




Diff

Modified: trunk/Tools/ChangeLog (139794 => 139795)

--- trunk/Tools/ChangeLog	2013-01-15 22:30:54 UTC (rev 139794)
+++ trunk/Tools/ChangeLog	2013-01-15 22:46:47 UTC (rev 139795)
@@ -1,3 +1,29 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
+https://bugs.webkit.org/show_bug.cgi?id=106904
+
+Reverting 139794. It broke the build. It appears that a header file,
+WebTextDirection.h, was left out.
+
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+(DRTTestRunner::DRTTestRunner):
+(DRTTestRunner::reset):
+* DumpRenderTree/chromium/DRTTestRunner.h:
+(DRTTestRunner::setTitleTextDirection):
+* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
+(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
+(WebTestRunner::TestRunner::TestRunner):
+(WebTestRunner::TestRunner::reset):
+(WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
+(TestRunner):
+* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
+(WebTestRunner::WebTestProxyBase::didReceiveTitle):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::didReceiveTitle):
+
 2013-01-15  Jochen Eisinger  joc...@chromium.org
 
 [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139794 => 139795)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 22:30:54 UTC (rev 139794)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 22:46:47 UTC (rev 139795)
@@ -146,6 +146,7 @@
 // Shared properties.
 // webHistoryItemCount is used by tests in LayoutTests\http\tests\history
 bindProperty(webHistoryItemCount, m_webHistoryItemCount);
+bindProperty(titleTextDirection, m_titleTextDirection);
 bindProperty(interceptPostMessage, m_interceptPostMessage);
 }
 
@@ -385,6 +386,7 @@
 TestRunner::reset();
 m_waitUntilDone = false;
 m_webHistoryItemCount.set(0);
+m_titleTextDirection.set(ltr);
 m_interceptPostMessage.set(false);
 
 if (m_closeRemainingWindows)


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h (139794 => 139795)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h	2013-01-15 22:30:54 UTC (rev 139794)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h	2013-01-15 22:46:47 UTC (rev 139795)
@@ -44,6 +44,7 @@
 
 #include TestRunner/src/TestRunner.h
 #include WebTask.h
+#include WebTextDirection.h
 #include platform/WebArrayBufferView.h
 #include platform/WebString.h
 #include platform/WebURL.h
@@ -156,6 +157,10 @@
 void setWorkQueueFrozen(bool frozen) { m_workQueue.setFrozen(frozen); }
 
 void setShowDebugLayerTree(bool value) { m_showDebugLayerTree = value; }
+void setTitleTextDirection(WebKit::WebTextDirection dir)
+{
+m_titleTextDirection.set(dir == WebKit::WebTextDirectionLeftToRight ? ltr : rtl);
+}
 
 bool shouldInterceptPostMessage()
 {
@@ -242,6 +247,9 @@
 // Bound variable counting the number of 

[webkit-changes] [139799] trunk

[leviw]

Title: [139799] trunk








Revision 139799
Author le...@chromium.org
Date 2013-01-15 15:40:29 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed, rolling out r139790.
http://trac.webkit.org/changeset/139790
https://bugs.webkit.org/show_bug.cgi?id=106948

The patch is failing its own test.

Source/_javascript_Core: 

* bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.

Source/WebCore: 

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::runScript):

LayoutTests: 

* fast/dom/MutationObserver/parser-mutations-expected.txt: Removed.
* fast/dom/MutationObserver/parser-mutations.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/html/parser/HTMLScriptRunner.cpp


Removed Paths

trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt
trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139798 => 139799)

--- trunk/LayoutTests/ChangeLog	2013-01-15 23:21:34 UTC (rev 139798)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 23:40:29 UTC (rev 139799)
@@ -1,3 +1,14 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed, rolling out r139790.
+http://trac.webkit.org/changeset/139790
+https://bugs.webkit.org/show_bug.cgi?id=106948
+
+The patch is failing its own test.
+
+* fast/dom/MutationObserver/parser-mutations-expected.txt: Removed.
+* fast/dom/MutationObserver/parser-mutations.html: Removed.
+
 2013-01-15  Emil A Eklund  e...@chromium.org
 
 REGRESSION (r121599): incorrect border scaling when zoomed


Deleted: trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt (139798 => 139799)

--- trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt	2013-01-15 23:21:34 UTC (rev 139798)
+++ trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt	2013-01-15 23:40:29 UTC (rev 139799)
@@ -1,6 +0,0 @@
-PASS mutations.length is 6
-PASS mutations[1].type is childList
-PASS mutations[1].target.tagName is BODY
-PASS mutations[1].addedNodes.length is 1
-PASS mutations[1].addedNodes[0].tagName is P
-Mutation records should be delivered for all parser mutations after the above script.


Deleted: trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html (139798 => 139799)

--- trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html	2013-01-15 23:21:34 UTC (rev 139798)
+++ trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html	2013-01-15 23:40:29 UTC (rev 139799)
@@ -1,27 +0,0 @@
-!DOCTYPE html
-
-body
-script src=""
-
-script
-if (window.testRunner)
-testRunner.dumpAsText();
-
-var observer = new WebKitMutationObserver(function(mutations, observer) {
-window.mutations = mutations;
-});
-observer.observe(document.body, {childList: true, subtree:true});
-/script
-
-p
-Mutation records should be delivered for all parser mutations after the above script.
-/p
-
-script
-shouldBe('mutations.length', '6');
-shouldBeEqualToString('mutations[1].type', 'childList');
-shouldBeEqualToString('mutations[1].target.tagName', 'BODY');
-shouldBe('mutations[1].addedNodes.length', '1');
-shouldBeEqualToString('mutations[1].addedNodes[0].tagName', 'P');
-/script
-/body
\ No newline at end of file


Modified: trunk/Source/_javascript_Core/ChangeLog (139798 => 139799)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-15 23:21:34 UTC (rev 139798)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-15 23:40:29 UTC (rev 139799)
@@ -1,3 +1,13 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed, rolling out r139790.
+http://trac.webkit.org/changeset/139790
+https://bugs.webkit.org/show_bug.cgi?id=106948
+
+The patch is failing its own test.
+
+* bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.
+
 2013-01-15  Zan Dobersek  zandober...@gmail.com
 
 [Autotools] Unify _javascript_Core sources list, regardless of target OS


Modified: trunk/Source/WebCore/ChangeLog (139798 => 139799)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 23:21:34 UTC (rev 139798)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 23:40:29 UTC (rev 139799)
@@ -1,3 +1,24 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed, rolling out r139790.
+

[webkit-changes] [139821] trunk

[leviw]

Title: [139821] trunk








Revision 139821
Author le...@chromium.org
Date 2013-01-15 18:39:17 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed, rolling out r139792.
http://trac.webkit.org/changeset/139792
https://bugs.webkit.org/show_bug.cgi?id=106970

Broke the windows build.

Source/_javascript_Core: 

* bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.

Tools: 

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::notifyDone):
(DRTTestRunner::reset):
(DRTTestRunner::setAlwaysAcceptCookies):
(DRTTestRunner::setWindowIsKey):
(DRTTestRunner::pathToLocalResource):
(DRTTestRunner::setPOSIXLocale):
(InvokeCallbackTask):
(InvokeCallbackTask::InvokeCallbackTask):
(InvokeCallbackTask::runIfValid):
(DRTTestRunner::setBackingScaleFactor):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
(DRTTestRunner::taskList):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::setDatabaseQuota):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setDatabaseQuota):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setPendingExtraData):
(WebViewHost::setDeviceScaleFactor):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139820 => 139821)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-16 02:38:07 UTC (rev 139820)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-16 02:39:17 UTC (rev 139821)
@@ -1,3 +1,13 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed, rolling out r139792.
+http://trac.webkit.org/changeset/139792
+https://bugs.webkit.org/show_bug.cgi?id=106970
+
+Broke the windows build.
+
+* bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.
+
 2013-01-15  Pratik Solanki  psola...@apple.com
 
 Use MADV_FREE_REUSABLE to return JIT memory to OS


Modified: trunk/Tools/ChangeLog (139820 => 139821)

--- trunk/Tools/ChangeLog	2013-01-16 02:38:07 UTC (rev 139820)
+++ trunk/Tools/ChangeLog	2013-01-16 02:39:17 UTC (rev 139821)
@@ -1,3 +1,40 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed, rolling out r139792.
+http://trac.webkit.org/changeset/139792
+https://bugs.webkit.org/show_bug.cgi?id=106970
+
+Broke the windows build.
+
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+(DRTTestRunner::DRTTestRunner):
+(DRTTestRunner::notifyDone):
+(DRTTestRunner::reset):
+(DRTTestRunner::setAlwaysAcceptCookies):
+(DRTTestRunner::setWindowIsKey):
+(DRTTestRunner::pathToLocalResource):
+(DRTTestRunner::setPOSIXLocale):
+(InvokeCallbackTask):
+(InvokeCallbackTask::InvokeCallbackTask):
+(InvokeCallbackTask::runIfValid):
+(DRTTestRunner::setBackingScaleFactor):
+* DumpRenderTree/chromium/DRTTestRunner.h:
+(DRTTestRunner):
+(DRTTestRunner::taskList):
+* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
+(WebTestRunner::WebTestDelegate::setDatabaseQuota):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
+(WebTestRunner::TestRunner::TestRunner):
+(WebTestRunner::TestRunner::reset):
+(WebTestRunner::TestRunner::setDatabaseQuota):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
+(TestRunner):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::setPendingExtraData):
+(WebViewHost::setDeviceScaleFactor):
+* DumpRenderTree/chromium/WebViewHost.h:
+(WebViewHost):
+
 2013-01-15  Ryosuke Niwa  rn...@webkit.org
 
 Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139820 => 139821)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-16 02:38:07 UTC (rev 139820)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-16 02:39:17 UTC (rev 139821)
@@ -68,6 +68,7 @@
 #include webkit/support/webkit_support.h
 #include algorithm
 #include cctype
+#include clocale
 #include cstdlib
 #include limits
 #include sstream
@@ -115,6 +116,7 @@
 #endif
 bindMethod(notifyDone, DRTTestRunner::notifyDone);
 

[webkit-changes] [139620] branches/chromium/1364

[leviw]

Title: [139620] branches/chromium/1364








Revision 139620
Author le...@chromium.org
Date 2013-01-14 09:40:35 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139479
 RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
 https://bugs.webkit.org/show_bug.cgi?id=106047
 
 Reviewed by Simon Fraser.
 
 Source/WebCore:
 
 Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState.
 This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap
 pixel-snapped later when a translation occurred between two sub-pixel containers.
 
 Test: fast/layers/geometry-map-transform-state-translation-mismatch.html
 
 * platform/graphics/transforms/TransformState.h:
 (WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new quad. Note: this
 implementation only works properly when only tracking a quad.
 * platform/graphics/transforms/TransformState.cpp:
 (WebCore::TransformState::applyTransform): apply integral translations to the accumulatedOffset
 for performance and consistency with RenderGeometryMap.
 
 LayoutTests:
 
 * fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
 * fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.
 

TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11880024

Modified Paths

branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.cpp
branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.h


Added Paths

branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt
branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html




Diff

Copied: branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt (from rev 139479, trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt) (0 => 139620)

--- branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt	2013-01-14 17:40:35 UTC (rev 139620)
@@ -0,0 +1,2 @@
+This tests that RenderGeometryMap and TransformState both avoid pixel snapping prior to applying translation-only transforms. The test passes if it doesn't assert on Debug.
+


Copied: branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html (from rev 139479, trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html) (0 => 139620)

--- branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html	2013-01-14 17:40:35 UTC (rev 139620)
@@ -0,0 +1,33 @@
+!DOCTYPE html
+html
+style
+.wrapper {
+  width: 200px;
+  margin-left: 101.7px;
+}
+
+.content {
+  background: rgba(255, 0, 0, 0.2);
+  -webkit-transform: translateZ(0);
+  width: 100px;
+}
+
+.inner {
+  background: rgba(0, 0, 255, 0.2);
+  position: relative;
+  left: -6.25px;   
+}
+/style
+script
+if (window.testRunner)
+	testRunner.dumpAsText();
+/script
+body
+div id=descriptionThis tests that RenderGeometryMap and TransformState both avoid pixel snapping prior to applying translation-only transforms.
+The test passes if it doesn't assert on Debug./div
+div class=wrapper
+div class=content
+div class=inner/div
+/div
+/div
+/body


Modified: branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.cpp (139619 => 139620)

--- branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.cpp	2013-01-14 17:30:59 UTC (rev 139619)
+++ branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.cpp	2013-01-14 17:40:35 UTC (rev 139620)
@@ -111,6 +111,11 @@
 if (wasClamped)
 *wasClamped = false;
 
+if (transformFromContainer.isIntegerTranslation()) {
+move(LayoutSize(transformFromContainer.e(), transformFromContainer.f()), accumulate);
+return;
+}
+
 applyAccumulatedOffset();
 
 // If we have an accumulated transform from last time, multiply in this transform


Modified: branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.h (139619 => 139620)

--- branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.h	2013-01-14 17:30:59 UTC (rev 139619)
+++ branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.h	2013-01-14 17:40:35 UTC (rev 139620)
@@ -73,7 +73,14 @@
 
 TransformState operator=(const TransformState);
 
-void setQuad(const FloatQuad quad) { m_lastPlanarQuad = quad; }
+void 

[webkit-changes] [139624] trunk/LayoutTests

[leviw]

Title: [139624] trunk/LayoutTests








Revision 139624
Author le...@chromium.org
Date 2013-01-14 10:28:46 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Marking editing/spelling/spellcheck-sequencenum.html
as flaky on Chromium Win Debug bots.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139623 => 139624)

--- trunk/LayoutTests/ChangeLog	2013-01-14 18:08:27 UTC (rev 139623)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 18:28:46 UTC (rev 139624)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking editing/spelling/spellcheck-sequencenum.html
+as flaky on Chromium Win Debug bots.
+
+* platform/chromium/TestExpectations:
+
 2013-01-14  Stephen Chenney  schen...@chromium.org
 
 Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139623 => 139624)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 18:08:27 UTC (rev 139623)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 18:28:46 UTC (rev 139624)
@@ -4500,3 +4500,4 @@
 Bug(schenney) fast/css/continuationCrash.html [ ImageOnlyFailure ]
 Bug(schenney) fast/text/international/hindi-spacing.html [ ImageOnlyFailure Pass ]
 
+webkit.org/b/106806 [ Win Debug ] editing/spelling/spellcheck-sequencenum.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139626] trunk/LayoutTests

[leviw]

Title: [139626] trunk/LayoutTests








Revision 139626
Author le...@chromium.org
Date 2013-01-14 10:57:23 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Marking fast/dom/HTMLTemplateElement/inertContents.html
as flaky on Chromium Debug bots.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139625 => 139626)

--- trunk/LayoutTests/ChangeLog	2013-01-14 18:51:13 UTC (rev 139625)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 18:57:23 UTC (rev 139626)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking fast/dom/HTMLTemplateElement/inertContents.html
+as flaky on Chromium Debug bots.
+
+* platform/chromium/TestExpectations:
+
 2013-01-14  Michael Pruett  mich...@68k.org
 
 IndexedDB: Fix test for error message in storage/indexeddb/transaction-complete-workers.html


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139625 => 139626)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 18:51:13 UTC (rev 139625)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 18:57:23 UTC (rev 139626)
@@ -4501,3 +4501,4 @@
 Bug(schenney) fast/text/international/hindi-spacing.html [ ImageOnlyFailure Pass ]
 
 webkit.org/b/106806 [ Win Debug ] editing/spelling/spellcheck-sequencenum.html [ Pass Failure ]
+webkit.org/b/106810 [ Debug ] fast/dom/HTMLTemplateElement/inertContents.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139637] trunk/LayoutTests

[leviw]

Title: [139637] trunk/LayoutTests








Revision 139637
Author le...@chromium.org
Date 2013-01-14 11:55:41 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Removing entry for editing/spelling/spellcheck-sequencenum.html
in Chromium test expectations. Tony fixed the issue in r139636.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139636 => 139637)

--- trunk/LayoutTests/ChangeLog	2013-01-14 19:53:42 UTC (rev 139636)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 19:55:41 UTC (rev 139637)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Removing entry for editing/spelling/spellcheck-sequencenum.html
+in Chromium test expectations. Tony fixed the issue in r139636.
+
+* platform/chromium/TestExpectations:
+
 2013-01-14  Tony Chang  t...@chromium.org
 
 Layout Test editing/spelling/spellcheck-sequencenum.html is flaky on Debug Win Chromium Bot


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139636 => 139637)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 19:53:42 UTC (rev 139636)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 19:55:41 UTC (rev 139637)
@@ -4500,5 +4500,4 @@
 Bug(schenney) fast/css/continuationCrash.html [ ImageOnlyFailure ]
 Bug(schenney) fast/text/international/hindi-spacing.html [ ImageOnlyFailure Pass ]
 
-webkit.org/b/106806 [ Win Debug ] editing/spelling/spellcheck-sequencenum.html [ Pass Failure ]
 webkit.org/b/106810 [ Debug ] fast/dom/HTMLTemplateElement/inertContents.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139676] trunk/LayoutTests

[leviw]

Title: [139676] trunk/LayoutTests








Revision 139676
Author le...@chromium.org
Date 2013-01-14 15:44:10 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Marking fast/borders/outline-alpha-inline.html as failing image results.
Likely Stephen Schenney's skia changes are to blame.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139675 => 139676)

--- trunk/LayoutTests/ChangeLog	2013-01-14 23:13:13 UTC (rev 139675)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 23:44:10 UTC (rev 139676)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking fast/borders/outline-alpha-inline.html as failing image results.
+Likely Stephen Schenney's skia changes are to blame.
+
+* platform/chromium/TestExpectations:
+
 2013-01-14  Huang Dongsung  luxte...@company100.net
 
 [TexMap] Use a premuliplied color in TextureMapperGL.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139675 => 139676)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 23:13:13 UTC (rev 139675)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 23:44:10 UTC (rev 139676)
@@ -4365,3 +4365,4 @@
 Bug(schenney) svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg [ ImageOnlyFailure ]
 
 webkit.org/b/106810 [ Debug ] fast/dom/HTMLTemplateElement/inertContents.html [ Pass Failure ]
+webkit.org/b/106833 fast/borders/outline-alpha-inline.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139677] trunk/LayoutTests

[leviw]

Title: [139677] trunk/LayoutTests








Revision 139677
Author le...@chromium.org
Date 2013-01-14 15:49:00 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Marking fast/image/zoomed-offset-size.html as slow on debug.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139676 => 139677)

--- trunk/LayoutTests/ChangeLog	2013-01-14 23:44:10 UTC (rev 139676)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 23:49:00 UTC (rev 139677)
@@ -1,5 +1,11 @@
 2013-01-14  Levi Weintraub  le...@chromium.org
 
+Unreviewed gardening. Marking fast/image/zoomed-offset-size.html as slow on debug.
+
+* platform/chromium/TestExpectations:
+
+2013-01-14  Levi Weintraub  le...@chromium.org
+
 Unreviewed gardening. Marking fast/borders/outline-alpha-inline.html as failing image results.
 Likely Stephen Schenney's skia changes are to blame.
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139676 => 139677)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 23:44:10 UTC (rev 139676)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 23:49:00 UTC (rev 139677)
@@ -96,6 +96,7 @@
 webkit.org/b/106606 fast/canvas/webgl/context-release-upon-reload.html [ Pass Slow ]
 webkit.org/b/106606 platform/chromium/virtual/gpu/fast/canvas/webgl/context-release-upon-reload.html [ Pass Slow ]
 crbug.com/24182 [ Debug ] media/track/track-css-cue-lifetime.html [ Pass Timeout ]
+crbug.com/24182 [ Debug ] fast/images/zoomed-offset-size.html [ Pass Slow ]
 
 # These tests started being slow when we switched to DRT.
 webkit.org/b/90488 [ Debug ] inspector [ Pass Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139684] trunk/LayoutTests

[leviw]

Title: [139684] trunk/LayoutTests








Revision 139684
Author le...@chromium.org
Date 2013-01-14 16:12:51 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Fixing Mac results for fast/repaint/overhanging-float-detach-repaint.html.

* platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
* platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (139683 => 139684)

--- trunk/LayoutTests/ChangeLog	2013-01-15 00:10:05 UTC (rev 139683)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 00:12:51 UTC (rev 139684)
@@ -1,3 +1,11 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Fixing Mac results for fast/repaint/overhanging-float-detach-repaint.html.
+
+* platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
+* platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
+* platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
+
 2013-01-14  Nate Chapin  jap...@chromium.org
 
 Enable reuse of cached main resources


Added: trunk/LayoutTests/platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139694] trunk

[leviw]

Title: [139694] trunk








Revision 139694
Author le...@chromium.org
Date 2013-01-14 17:22:59 -0800 (Mon, 14 Jan 2013)


Log Message
Source/WebCore: Rolling out r139683. It broke a bunch of webkit_unit_tests.

Source/WebKit/win: Rolling out r139683. It broke a bunch of webkit_unit_tests. 

Modified Paths

trunk/LayoutTests/http/tests/inspector/resource-har-pages-expected.txt
trunk/LayoutTests/http/tests/loading/redirect-methods-expected.txt
trunk/LayoutTests/http/tests/misc/favicon-loads-with-images-disabled-expected.txt
trunk/LayoutTests/http/tests/misc/link-rel-icon-beforeload-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/MainResourceLoader.cpp
trunk/Source/WebCore/loader/MainResourceLoader.h
trunk/Source/WebCore/loader/cache/CachedRawResource.cpp
trunk/Source/WebCore/loader/cache/CachedRawResource.h
trunk/Source/WebCore/loader/cache/CachedResource.cpp
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in
trunk/Source/autotools/symbols.filter


Removed Paths

trunk/LayoutTests/http/tests/cache/cached-main-resource-expected.txt
trunk/LayoutTests/http/tests/cache/cached-main-resource.html
trunk/LayoutTests/http/tests/cache/resources/cacheable-iframe.php




Diff

Deleted: trunk/LayoutTests/http/tests/cache/cached-main-resource-expected.txt (139693 => 139694)

--- trunk/LayoutTests/http/tests/cache/cached-main-resource-expected.txt	2013-01-15 01:19:14 UTC (rev 139693)
+++ trunk/LayoutTests/http/tests/cache/cached-main-resource-expected.txt	2013-01-15 01:22:59 UTC (rev 139694)
@@ -1,2 +0,0 @@
-PASS
- 


Deleted: trunk/LayoutTests/http/tests/cache/cached-main-resource.html (139693 => 139694)

--- trunk/LayoutTests/http/tests/cache/cached-main-resource.html	2013-01-15 01:19:14 UTC (rev 139693)
+++ trunk/LayoutTests/http/tests/cache/cached-main-resource.html	2013-01-15 01:22:59 UTC (rev 139694)
@@ -1,24 +0,0 @@
-html
-body _onload_=setTimeout(removeAndReload, 0);
-div id=result/div
-script
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-
-function removeAndReload()
-{
-document.body.removeChild(document.getElementById(iframe));
-var newIframe = document.createElement(iframe);
-newIframe.src = ""
-document.body.appendChild(newIframe);
-var fromCache = internals.isLoadingFromMemoryCache(newIframe.src);
-document.getElementById(result).appendChild(document.createTextNode(fromCache ? PASS : FAIL));
-if (window.testRunner)
-testRunner.notifyDone();
-}
-/script
-iframe id=iframe src=""
-/body
-/html


Deleted: trunk/LayoutTests/http/tests/cache/resources/cacheable-iframe.php (139693 => 139694)

--- trunk/LayoutTests/http/tests/cache/resources/cacheable-iframe.php	2013-01-15 01:19:14 UTC (rev 139693)
+++ trunk/LayoutTests/http/tests/cache/resources/cacheable-iframe.php	2013-01-15 01:22:59 UTC (rev 139694)
@@ -1,11 +0,0 @@
-?php
-require_once '../../resources/portabilityLayer.php';
-
-$max_age = 12 * 31 * 24 * 60 * 60; //one year
-$expires = gmdate(DATE_RFC1123, time() + $max_age);
-
-header('Cache-Control: public, max-age=' . $max_age);
-header('Expires: ' . $expires);
-header('Content-Type: text/html');
-exit();
-?


Modified: trunk/LayoutTests/http/tests/inspector/resource-har-pages-expected.txt (139693 => 139694)

--- trunk/LayoutTests/http/tests/inspector/resource-har-pages-expected.txt	2013-01-15 01:19:14 UTC (rev 139693)
+++ trunk/LayoutTests/http/tests/inspector/resource-har-pages-expected.txt	2013-01-15 01:22:59 UTC (rev 139694)
@@ -1,5 +1,6 @@
 Tests conversion of Inspector's resource representation into HAR format.
 
+Page reloaded.
 {
 0 : {
 id : string
@@ -27,5 +28,4 @@
 page: page_1 url: http://127.0.0.1:8000/inspector/resources/har-pages-navigation-target.html
 page: page_1 url: http://127.0.0.1:8000/inspector/resources/source1.js
 page: page_1 url: http://127.0.0.1:8000/resources/redirect.php?url=""
-Page reloaded.
 


Modified: trunk/LayoutTests/http/tests/loading/redirect-methods-expected.txt (139693 => 139694)

--- trunk/LayoutTests/http/tests/loading/redirect-methods-expected.txt	2013-01-15 01:19:14 UTC (rev 139693)
+++ trunk/LayoutTests/http/tests/loading/redirect-methods-expected.txt	2013-01-15 01:22:59 UTC (rev 139694)
@@ -42,11 +42,11 @@
 http://127.0.0.1:8000/loading/resources/redirect-methods-form.html - didReceiveResponse NSURLResponse http://127.0.0.1:8000/loading/resources/redirect-methods-form.html, http status code 200
 frame 1 - didCancelClientRedirectForFrame
 frame 1 - didCommitLoadForFrame

[webkit-changes] [139695] trunk/Source/WebCore

[leviw]

Title: [139695] trunk/Source/WebCore








Revision 139695
Author le...@chromium.org
Date 2013-01-14 17:31:34 -0800 (Mon, 14 Jan 2013)


Log Message
Rolling out r139678. This triggered a number of WebAudio crashes on Debug bots.

* platform/audio/chromium/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139694 => 139695)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 01:22:59 UTC (rev 139694)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 01:31:34 UTC (rev 139695)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Rolling out r139678. This triggered a number of WebAudio crashes on Debug bots.
+
+* platform/audio/chromium/AudioDestinationChromium.cpp:
+(WebCore::AudioDestinationChromium::AudioDestinationChromium):
+
 2013-01-09  Levi Weintraub le...@chromium.org
 
 Rolling out r139683. It broke a bunch of webkit_unit_tests.


Modified: trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp (139694 => 139695)

--- trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp	2013-01-15 01:22:59 UTC (rev 139694)
+++ trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp	2013-01-15 01:31:34 UTC (rev 139695)
@@ -66,7 +66,8 @@
 if (m_callbackBufferSize + renderBufferSize  fifoSize)
 return;
 
-m_audioDevice = adoptPtr(WebKit::Platform::current()-createAudioDevice(m_callbackBufferSize, numberOfInputChannels, numberOfOutputChannels, sampleRate, this));
+// FIXME: switch to new API (with input channels) once chromium supports it.
+m_audioDevice = adoptPtr(WebKit::Platform::current()-createAudioDevice(m_callbackBufferSize, numberOfOutputChannels, sampleRate, this));
 ASSERT(m_audioDevice);
 
 // Create a FIFO to handle the possibility of the callback size






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139696] trunk

[leviw]

Title: [139696] trunk








Revision 139696
Author le...@chromium.org
Date 2013-01-14 17:36:32 -0800 (Mon, 14 Jan 2013)


Log Message
Source/WebCore: Rolling out r139618. Appears to be causing sporadic crashes on Debug bots.

* Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack):
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readyState):
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/MediaStreamTrack.idl:

LayoutTests: Speculatively rolling out r139618. Appears to be causing sporadic crashes on Debug bots.

* fast/mediastream/MediaStreamTrack-expected.txt:
* fast/mediastream/MediaStreamTrack.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt
trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (139695 => 139696)

--- trunk/LayoutTests/ChangeLog	2013-01-15 01:31:34 UTC (rev 139695)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 01:36:32 UTC (rev 139696)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Speculatively rolling out r139618. Appears to be causing sporadic crashes on Debug bots.
+
+* fast/mediastream/MediaStreamTrack-expected.txt:
+* fast/mediastream/MediaStreamTrack.html:
+
 2013-01-14  Dima Gorbik  dgor...@apple.com
 
 Implement element type selectors for the WebVTT ::cue pseudo class


Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt (139695 => 139696)

--- trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt	2013-01-15 01:31:34 UTC (rev 139695)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt	2013-01-15 01:36:32 UTC (rev 139696)
@@ -4,13 +4,9 @@
 
 
 PASS getUserMedia succeeded.
-PASS track.readyState is live
 PASS Track onmute callback succeeded.
-PASS track.readyState is muted
 PASS Track onunmute callback succeeded.
-PASS track.readyState is live
 PASS Track onended callback succeeded.
-PASS track.readyState is ended
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html (139695 => 139696)

--- trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html	2013-01-15 01:31:34 UTC (rev 139695)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html	2013-01-15 01:36:32 UTC (rev 139696)
@@ -34,24 +34,18 @@
 function onTrackEnded() {
 testPassed('Track onended callback succeeded.');
 
-shouldBeEqualToString('track.readyState', 'ended');
-
 finishJSTest();
 }
 
 function onTrackUnmute() {
 testPassed('Track onunmute callback succeeded.');
 
-shouldBeEqualToString('track.readyState', 'live');
-
 stream.stop();
 }
 
 function onTrackMute() {
 testPassed('Track onmute callback succeeded.');
 
-shouldBeEqualToString('track.readyState', 'muted');
-
 track.enabled = true;
 }
 
@@ -61,8 +55,6 @@
 stream = s;
 track = stream.getVideoTracks()[0];
 
-shouldBeEqualToString('track.readyState', 'live');
-
 track._onunmute_ = onTrackUnmute;
 track._onmute_ = onTrackMute;
 track._onended_ = onTrackEnded;


Modified: trunk/Source/WebCore/ChangeLog (139695 => 139696)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 01:31:34 UTC (rev 139695)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 01:36:32 UTC (rev 139696)
@@ -1,5 +1,16 @@
 2013-01-14  Levi Weintraub  le...@chromium.org
 
+Rolling out r139618. Appears to be causing sporadic crashes on Debug bots.
+
+* Modules/mediastream/MediaStream.cpp:
+(WebCore::processTrack):
+* Modules/mediastream/MediaStreamTrack.cpp:
+(WebCore::MediaStreamTrack::readyState):
+* Modules/mediastream/MediaStreamTrack.h:
+* Modules/mediastream/MediaStreamTrack.idl:
+
+2013-01-14  Levi Weintraub  le...@chromium.org
+
 Rolling out r139678. This triggered a number of WebAudio crashes on Debug bots.
 
 * platform/audio/chromium/AudioDestinationChromium.cpp:


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp (139695 => 139696)

--- trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp	2013-01-15 01:31:34 UTC (rev 139695)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp	2013-01-15 01:36:32 UTC (rev 139696)
@@ -48,7 +48,7 @@
 
 static void processTrack(MediaStreamTrack* track, MediaStreamSourceVector sourceVector)
 {
-if (track-ended())
+if (track-readyState() == MediaStreamTrack::ENDED)
 return;
 
 MediaStreamSource* source = track-component()-source();


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (139695 => 139696)

--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp	

[webkit-changes] [139699] trunk/LayoutTests

[leviw]

Title: [139699] trunk/LayoutTests








Revision 139699
Author le...@chromium.org
Date 2013-01-14 18:06:20 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Adding mac expectatons after r139686.

* platform/chromium-mac/scrollingcoordinator: Added.
* platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac/scrollingcoordinator/
trunk/LayoutTests/platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (139698 => 139699)

--- trunk/LayoutTests/ChangeLog	2013-01-15 01:58:07 UTC (rev 139698)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 02:06:20 UTC (rev 139699)
@@ -1,5 +1,12 @@
 2013-01-14  Levi Weintraub  le...@chromium.org
 
+Unreviewed gardening. Adding mac expectatons after r139686.
+
+* platform/chromium-mac/scrollingcoordinator: Added.
+* platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
+
+2013-01-14  Levi Weintraub  le...@chromium.org
+
 Speculatively rolling out r139618. Appears to be causing sporadic crashes on Debug bots.
 
 * fast/mediastream/MediaStreamTrack-expected.txt:


Added: trunk/LayoutTests/platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139584] trunk/LayoutTests

[leviw]

Title: [139584] trunk/LayoutTests








Revision 139584
Author le...@chromium.org
Date 2013-01-13 22:28:43 -0800 (Sun, 13 Jan 2013)


Log Message
Unreviewed gardening. Marking media/track/track-css-cue-lifetime.html as a flaky timeout on Debug
Chromium bots.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139583 => 139584)

--- trunk/LayoutTests/ChangeLog	2013-01-14 06:05:12 UTC (rev 139583)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 06:28:43 UTC (rev 139584)
@@ -1,3 +1,10 @@
+2013-01-13  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking media/track/track-css-cue-lifetime.html as a flaky timeout on Debug
+Chromium bots.
+
+* platform/chromium/TestExpectations:
+
 2013-01-13  Noel Gordon  noel.gor...@gmail.com
 
 [chromium] Optimize svg/W3C-SVG-1.1/animate-elem-80-t.svg on linux and win


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139583 => 139584)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 06:05:12 UTC (rev 139583)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 06:28:43 UTC (rev 139584)
@@ -96,6 +96,7 @@
 webkit.org/b/106606 fast/canvas/webgl/context-release-upon-reload.html [ Pass Slow ]
 webkit.org/b/106606 platform/chromium/virtual/gpu/fast/canvas/webgl/context-release-upon-reload.html [ Pass Slow ]
 crbug.com/24182 [ Debug ] fast/images/zoomed-offset-size.html [ Pass Slow ]
+crbug.com/24182 [ Debug ] media/track/track-css-cue-lifetime.html [ Pass Timeout ]
 
 # These tests started being slow when we switched to DRT.
 webkit.org/b/90488 [ Debug ] inspector [ Pass Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139554] trunk/LayoutTests

[leviw]

Title: [139554] trunk/LayoutTests








Revision 139554
Author le...@chromium.org
Date 2013-01-12 13:20:51 -0800 (Sat, 12 Jan 2013)


Log Message
Unreviewed gardening. Marking fast/images/zoomed-offset-size.html as slow on Debug Chromium bots.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139553 => 139554)

--- trunk/LayoutTests/ChangeLog	2013-01-12 20:23:21 UTC (rev 139553)
+++ trunk/LayoutTests/ChangeLog	2013-01-12 21:20:51 UTC (rev 139554)
@@ -1,3 +1,9 @@
+2013-01-12  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking fast/images/zoomed-offset-size.html as slow on Debug Chromium bots.
+
+* platform/chromium/TestExpectations:
+
 2013-01-12  Robert Hogan  rob...@webkit.org
 
 Available height should respect min and max height


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139553 => 139554)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-12 20:23:21 UTC (rev 139553)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-12 21:20:51 UTC (rev 139554)
@@ -95,6 +95,7 @@
 crbug.com/24182 [ Debug ] platform/chromium/virtual/gpu/fast/hidpi/image-set-background-dynamic.html [ Pass Slow ]
 webkit.org/b/106606 fast/canvas/webgl/context-release-upon-reload.html [ Pass Slow ]
 webkit.org/b/106606 platform/chromium/virtual/gpu/fast/canvas/webgl/context-release-upon-reload.html [ Pass Slow ]
+crbug.com/24182 [ Debug ] fast/images/zoomed-offset-size.html [ Pass Slow ]
 
 # These tests started being slow when we switched to DRT.
 webkit.org/b/90488 [ Debug ] inspector [ Pass Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139462] branches/chromium/1364

[leviw]

Title: [139462] branches/chromium/1364








Revision 139462
Author le...@chromium.org
Date 2013-01-11 10:59:24 -0800 (Fri, 11 Jan 2013)


Log Message
Merge 139346
 ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views
 https://bugs.webkit.org/show_bug.cgi?id=106383
 
 Reviewed by James Robinson.
 
 Source/WebCore: 
 
 ScrollingCoordinator uses clippedOverflowRectForRepaint(0) to generate the bounds for a renderer's hit
 testing rect. The rect this returns is in the coordinates of its document. This change converts the
 rect to the outermost view's coordinate system using convertToContainingView.
 
 Tests: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html
 
 * page/scrolling/ScrollingCoordinator.cpp:
 (WebCore::accumulateRendererTouchEventTargetRects):
 
 LayoutTests: 
 
 * platform/chromium/fast/events/touch/resources: Added.
 * platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html: Added.
 * platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
 * platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html: Added.
 

TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11865013

Modified Paths

branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp


Added Paths

branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt
branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html




Diff

Copied: branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt (from rev 139346, trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt) (0 => 139462)

--- branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt	2013-01-11 18:59:24 UTC (rev 139462)
@@ -0,0 +1,4 @@
+This test validates that touch hit tests rects are created in the coordinates of the outermost view, not their containing view. This test only works in DumpRenderTree.
+[0]: (60, 110, 50, 50)
+[1]: (420, 170, 50, 50)
+


Copied: branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html (from rev 139346, trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html) (0 => 139462)

--- branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html	2013-01-11 18:59:24 UTC (rev 139462)
@@ -0,0 +1,57 @@
+!DOCTYPE html
+html
+head
+style
+#iframe1 {
+	position: absolute;
+	top: 100px;
+	left: 50px;
+	width: 200px;
+	height: 200px;
+}
+#iframe2 {
+	position: absolute;
+	top: 100px;
+	left: 400px;
+	width: 200px;
+	height: 200px;
+}
+/style
+body _onload_=runTest();
+divThis test validates that touch hit tests rects are created in the coordinates of the outermost view, not their containing view.
+This test only works in DumpRenderTree./div
+div id=console/div
+iframe id=iframe1 src=""
+iframe id=iframe2/iframe
+script
+
+var iframeDocument = document.getElementById(iframe2).contentWindow.document;
+iframeDocument.open('text/html', 'replace');
+iframeDocument.write(!DOCTYPE html\nhtmlbodyiframe src="" style=\position: relative; top: 50px;\/iframe/body);
+iframeDocument.close();
+
+function log(msg) {
+	var span = document.createElement(span);
+	document.getElementById(console).appendChild(span);
+span.innerHTML = msg + 'br /';
+}
+
+function sortRects(a, b) {
+	return a.top - b.top;
+}
+
+function runTest() {
+	if (!window.testRunner)
+		return;
+	window.testRunner.dumpAsText();
+
+	rects = window.internals.touchEventTargetClientRects(document);
+	var sortedRects = new Array();
+	for (var i = 0; i  rects.length; ++i)
+		sortedRects[i] = rects[i];
+	sortedRects.sort(sortRects);
+	for (var i = 0; i  rects.length; ++i)
+		log([ + i + ]: ( + sortedRects[i].left + ,  + sortedRects[i].top + ,  + sortedRects[i].width + ,  + sortedRects[i].height + ));
+}
+/script
+/body


Modified: branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (139461 => 139462)

--- branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2013-01-11 18:57:42 UTC (rev 139461)
+++ branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2013-01-11 18:59:24 UTC (rev 139462)
@@ -185,9 +185,16 @@
 if (parentRect.isEmpty() || renderer-isFloating() || renderer-isPositioned() || renderer-hasTransform()) {
 // FIXME: This method is O(N^2) as it walks the tree to the root for every renderer. RenderGeometryMap would fix this.
 IntRect r = 

[webkit-changes] [139463] trunk/LayoutTests

[leviw]

Title: [139463] trunk/LayoutTests








Revision 139463
Author le...@chromium.org
Date 2013-01-11 11:07:46 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed gardening. Skipping accessibility/corresponding-control-deleted-crash.html on Mac since
it fails without Shadow DOM enabled.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139462 => 139463)

--- trunk/LayoutTests/ChangeLog	2013-01-11 18:59:24 UTC (rev 139462)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 19:07:46 UTC (rev 139463)
@@ -1,3 +1,10 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Skipping accessibility/corresponding-control-deleted-crash.html on Mac since
+it fails without Shadow DOM enabled.
+
+* platform/mac/TestExpectations:
+
 2013-01-11  Xianzhu Wang  wangxian...@chromium.org
 
 RenderLayerCompositor should let ScrollingCoordinator update main thread scrolling reasons after change of layers


Modified: trunk/LayoutTests/platform/mac/TestExpectations (139462 => 139463)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-01-11 18:59:24 UTC (rev 139462)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-01-11 19:07:46 UTC (rev 139463)
@@ -430,6 +430,7 @@
 fast/dom/shadow
 editing/shadow
 inspector/elements/update-shadowdom.html
+accessibility/corresponding-control-deleted-crash.html
 
 # ENABLE(TEMPLATE_ELEMENT) is disabled.
 fast/dom/HTMLTemplateElement






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139468] trunk/LayoutTests

[leviw]

Title: [139468] trunk/LayoutTests








Revision 139468
Author le...@chromium.org
Date 2013-01-11 11:21:55 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/hidpi/image-set-background-dynamic.html
as slow on Debug builds.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139467 => 139468)

--- trunk/LayoutTests/ChangeLog	2013-01-11 19:20:16 UTC (rev 139467)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 19:21:55 UTC (rev 139468)
@@ -1,3 +1,10 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/hidpi/image-set-background-dynamic.html
+as slow on Debug builds.
+
+* platform/chromium/TestExpectations:
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
 [ Chromium ] New Mac rebaselines (some)


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139467 => 139468)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 19:20:16 UTC (rev 139467)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 19:21:55 UTC (rev 139468)
@@ -93,6 +93,7 @@
 webkit.org/b/103744 svg/dom/viewspec-parser-6.html [ Pass Timeout ]
 crbug.com/24182 [ Debug ] platform/chromium/inspector/styles/device-metrics-fit-window.html [ Pass Slow ]
 webkit.org/b/105785 [ Release ] http/tests/inspector/indexeddb [ Pass Slow ]
+crbug.com/24182 [ Debug ] platform/chromium/virtual/gpu/fast/hidpi/image-set-background-dynamic.html [ Pass Slow ]
 
 # These tests started being slow when we switched to DRT.
 webkit.org/b/90488 [ Debug ] inspector [ Pass Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139479] trunk

[leviw]

Title: [139479] trunk








Revision 139479
Author le...@chromium.org
Date 2013-01-11 11:59:48 -0800 (Fri, 11 Jan 2013)


Log Message
RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
https://bugs.webkit.org/show_bug.cgi?id=106047

Reviewed by Simon Fraser.

Source/WebCore:

Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState.
This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap
pixel-snapped later when a translation occurred between two sub-pixel containers.

Test: fast/layers/geometry-map-transform-state-translation-mismatch.html

* platform/graphics/transforms/TransformState.h:
(WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new quad. Note: this
implementation only works properly when only tracking a quad.
* platform/graphics/transforms/TransformState.cpp:
(WebCore::TransformState::applyTransform): apply integral translations to the accumulatedOffset
for performance and consistency with RenderGeometryMap.

LayoutTests:

* fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
* fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/transforms/TransformState.cpp
trunk/Source/WebCore/platform/graphics/transforms/TransformState.h


Added Paths

trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt
trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139478 => 139479)

--- trunk/LayoutTests/ChangeLog	2013-01-11 19:58:00 UTC (rev 139478)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 19:59:48 UTC (rev 139479)
@@ -1,3 +1,13 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
+https://bugs.webkit.org/show_bug.cgi?id=106047
+
+Reviewed by Simon Fraser.
+
+* fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
+* fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
 [Chromium] Mac editing test rebaseline


Added: trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt (0 => 139479)

--- trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt	2013-01-11 19:59:48 UTC (rev 139479)
@@ -0,0 +1,2 @@
+This tests that RenderGeometryMap and TransformState both avoid pixel snapping prior to applying translation-only transforms. The test passes if it doesn't assert on Debug.
+


Added: trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html (0 => 139479)

--- trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html	(rev 0)
+++ trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html	2013-01-11 19:59:48 UTC (rev 139479)
@@ -0,0 +1,33 @@
+!DOCTYPE html
+html
+style
+.wrapper {
+  width: 200px;
+  margin-left: 101.7px;
+}
+
+.content {
+  background: rgba(255, 0, 0, 0.2);
+  -webkit-transform: translateZ(0);
+  width: 100px;
+}
+
+.inner {
+  background: rgba(0, 0, 255, 0.2);
+  position: relative;
+  left: -6.25px;   
+}
+/style
+script
+if (window.testRunner)
+	testRunner.dumpAsText();
+/script
+body
+div id=descriptionThis tests that RenderGeometryMap and TransformState both avoid pixel snapping prior to applying translation-only transforms.
+The test passes if it doesn't assert on Debug./div
+div class=wrapper
+div class=content
+div class=inner/div
+/div
+/div
+/body


Modified: trunk/Source/WebCore/ChangeLog (139478 => 139479)

--- trunk/Source/WebCore/ChangeLog	2013-01-11 19:58:00 UTC (rev 139478)
+++ trunk/Source/WebCore/ChangeLog	2013-01-11 19:59:48 UTC (rev 139479)
@@ -1,3 +1,23 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
+https://bugs.webkit.org/show_bug.cgi?id=106047
+
+Reviewed by Simon Fraser.
+
+Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState.
+This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap
+pixel-snapped later when a translation occurred between two sub-pixel containers.
+
+Test: fast/layers/geometry-map-transform-state-translation-mismatch.html
+
+* platform/graphics/transforms/TransformState.h:
+(WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new 

[webkit-changes] [139489] trunk/LayoutTests

[leviw]

Title: [139489] trunk/LayoutTests








Revision 139489
Author le...@chromium.org
Date 2013-01-11 13:20:43 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
Marking them as crashing in TestExpectations.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139488 => 139489)

--- trunk/LayoutTests/ChangeLog	2013-01-11 21:09:29 UTC (rev 139488)
+++ trunk/LayoutTests/ChangeLog	2013-01-11 21:20:43 UTC (rev 139489)
@@ -1,3 +1,10 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
+Marking them as crashing in TestExpectations.
+
+* platform/chromium/TestExpectations:
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
 [Chromium] More test expectations for Skia changes


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139488 => 139489)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 21:09:29 UTC (rev 139488)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-11 21:20:43 UTC (rev 139489)
@@ -4268,6 +4268,13 @@
 webkit.org/b/106426 [ Win ] inspector/geolocation-watchPosition.html [ Failure Pass ]
 crbug.com/166932 [ Debug ] plugins/embed-attributes-setting.html [ Crash Pass ]
 
+# Broken by Skia flag changes in r139445
+crbug.com/169550 [ Debug ] fast/borders/border-mixed-alpha.html [ Crash ]
+crbug.com/169550 [ Debug ] fast/borders/outline-alpha-block.html [ Crash ]
+crbug.com/169550 [ Debug ] fast/borders/outline-alpha-inline.html [ Crash ]
+crbug.com/169550 [ Debug ] fast/lists/big-list-marker.html [ Crash ]
+crbug.com/169550 [ Debug ] platform/chromium/virtual/deferred/fast/images/icon-decoding.html [ Crash ]
+
 # Transient. Needs rebaseline.
 webkit.org/b/103955 fast/repaint/4774354.html [ ImageOnlyFailure ]
 webkit.org/b/103955 fast/repaint/4776765.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139527] trunk/LayoutTests

[leviw]

Title: [139527] trunk/LayoutTests








Revision 139527
Author le...@chromium.org
Date 2013-01-11 17:40:29 -0800 (Fri, 11 Jan 2013)


Log Message
Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html
as slow on all Chromium platforms.


* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139526 => 139527)

--- trunk/LayoutTests/ChangeLog	2013-01-12 01:35:19 UTC (rev 139526)
+++ trunk/LayoutTests/ChangeLog	2013-01-12 01:40:29 UTC (rev 139527)
@@ -1,3 +1,11 @@
+2013-01-11  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html
+as slow on all Chromium platforms.
+
+
+* platform/chromium/TestExpectations:
+
 2013-01-11  Stephen Chenney  schen...@chromium.org
 
 [Chromium] Fixing the linux layout tests


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139526 => 139527)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-12 01:35:19 UTC (rev 139526)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-12 01:40:29 UTC (rev 139527)
@@ -12,8 +12,7 @@
 webkit.org/b/91666 [ Mac ] editing/pasteboard/emacs-ctrl-k-y-001.html [ Failure Slow ]
 webkit.org/b/91666 [ Mac ] editing/pasteboard/emacs-cntl-y-001.html [ ImageOnlyFailure Slow ]
 webkit.org/b/82097 editing/selection/move-by-word-visually-crash-test-5.html [ Pass Slow ]
-webkit.org/b/79679 [ Debug ] platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html [ Pass Slow ]
-webkit.org/b/79679 [ Mac Release ] platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html [ Pass Slow ]
+webkit.org/b/79679 platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html [ Pass Slow ]
 webkit.org/b/92287 [ Linux Mac Win ] fast/canvas/webgl/context-creation-and-destruction.html [ Pass Timeout Failure ]
 webkit.org/b/92287 [ Linux Mac Win ] platform/chromium/virtual/gpu/fast/canvas/webgl/context-creation-and-destruction.html [ Pass Timeout Failure ]
 crbug.com/24182 [ Debug ] fast/css/large-list-of-rules-crash.html [ Pass Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139345] trunk

[leviw]

Title: [139345] trunk








Revision 139345
Author le...@chromium.org
Date 2013-01-10 11:29:37 -0800 (Thu, 10 Jan 2013)


Log Message
Regression(r137939): Heap-use-after-free in WebCore::accumulateDocumentEventTargetRects
https://bugs.webkit.org/show_bug.cgi?id=106454

Reviewed by James Robinson.

Source/WebCore:

Correctly removing child Documents from their parent's tracked touch handler maps when detaching and
when their last touch event handler is removed.

Test: fast/events/touch/nested-document-with-touch-handler-detached-crash.html

* dom/Document.cpp:
(WebCore::Document::detach):
(WebCore::Document::didRemoveEventTargetNode):

LayoutTests:

* fast/events/touch/nested-document-with-touch-handler-detached-crash.html: Added.
* fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp


Added Paths

trunk/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt
trunk/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139344 => 139345)

--- trunk/LayoutTests/ChangeLog	2013-01-10 19:22:49 UTC (rev 139344)
+++ trunk/LayoutTests/ChangeLog	2013-01-10 19:29:37 UTC (rev 139345)
@@ -1,3 +1,13 @@
+2013-01-10  Levi Weintraub  le...@chromium.org
+
+Regression(r137939): Heap-use-after-free in WebCore::accumulateDocumentEventTargetRects
+https://bugs.webkit.org/show_bug.cgi?id=106454
+
+Reviewed by James Robinson.
+
+* fast/events/touch/nested-document-with-touch-handler-detached-crash.html: Added.
+* fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt: Added.
+
 2013-01-10  Ojan Vafai  o...@chromium.org
 
 Convert fast/css/positioned-overflow-scroll.html to a check-layout.js test


Added: trunk/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt (0 => 139345)

--- trunk/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt	2013-01-10 19:29:37 UTC (rev 139345)
@@ -0,0 +1,2 @@
+
+Test passes if DRT doesn't crash.


Added: trunk/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash.html (0 => 139345)

--- trunk/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash.html	2013-01-10 19:29:37 UTC (rev 139345)
@@ -0,0 +1,15 @@
+!doctype html
+html
+body
+iframe id=testIframe srcdoc=iframe seamless srcdoc=' ' border: 2px solid black/iframe
+divTest passes if DRT doesn't crash./div
+script
+if (window.testRunner)
+	testRunner.dumpAsText();
+
+var testIframe = document.getElementById('testIframe');
+var input = testIframe.contentDocument.createElement('input');
+input.type = RANGE;
+input = 0;
+/script
+/body


Modified: trunk/Source/WebCore/ChangeLog (139344 => 139345)

--- trunk/Source/WebCore/ChangeLog	2013-01-10 19:22:49 UTC (rev 139344)
+++ trunk/Source/WebCore/ChangeLog	2013-01-10 19:29:37 UTC (rev 139345)
@@ -1,3 +1,19 @@
+2013-01-10  Levi Weintraub  le...@chromium.org
+
+Regression(r137939): Heap-use-after-free in WebCore::accumulateDocumentEventTargetRects
+https://bugs.webkit.org/show_bug.cgi?id=106454
+
+Reviewed by James Robinson.
+
+Correctly removing child Documents from their parent's tracked touch handler maps when detaching and
+when their last touch event handler is removed.
+
+Test: fast/events/touch/nested-document-with-touch-handler-detached-crash.html
+
+* dom/Document.cpp:
+(WebCore::Document::detach):
+(WebCore::Document::didRemoveEventTargetNode):
+
 2013-01-10  Nate Chapin  jap...@chromium.org
 
 REGRESSION(r138222): WebDocumentLoaderMac-related leaks seen on Leaks bot


Modified: trunk/Source/WebCore/dom/Document.cpp (139344 => 139345)

--- trunk/Source/WebCore/dom/Document.cpp	2013-01-10 19:22:49 UTC (rev 139344)
+++ trunk/Source/WebCore/dom/Document.cpp	2013-01-10 19:29:37 UTC (rev 139345)
@@ -2117,6 +2117,11 @@
 if (render)
 render-destroy();
 
+#if ENABLE(TOUCH_EVENTS)
+if (m_touchEventTargets  m_touchEventTargets-size()  parentDocument())
+parentDocument()-didRemoveEventTargetNode(this);
+#endif
+
 // This is required, as our Frame might delete itself as soon as it detaches
 // us. However, this violates Node::detach() semantics, as it's never
 // possible to re-attach. Eventually Document::detach() should be renamed,
@@ -5659,11 +5664,11 @@
 #if ENABLE(TOUCH_EVENTS)
 void Document::didRemoveEventTargetNode(Node* handler)
 {
-if 

[webkit-changes] [139346] trunk

[leviw]

Title: [139346] trunk








Revision 139346
Author le...@chromium.org
Date 2013-01-10 11:33:20 -0800 (Thu, 10 Jan 2013)


Log Message
ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views
https://bugs.webkit.org/show_bug.cgi?id=106383

Reviewed by James Robinson.

Source/WebCore: 

ScrollingCoordinator uses clippedOverflowRectForRepaint(0) to generate the bounds for a renderer's hit
testing rect. The rect this returns is in the coordinates of its document. This change converts the
rect to the outermost view's coordinate system using convertToContainingView.

Tests: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::accumulateRendererTouchEventTargetRects):

LayoutTests: 

* platform/chromium/fast/events/touch/resources: Added.
* platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html: Added.
* platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
* platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp


Added Paths

trunk/LayoutTests/platform/chromium/fast/events/touch/resources/
trunk/LayoutTests/platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html
trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt
trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139345 => 139346)

--- trunk/LayoutTests/ChangeLog	2013-01-10 19:29:37 UTC (rev 139345)
+++ trunk/LayoutTests/ChangeLog	2013-01-10 19:33:20 UTC (rev 139346)
@@ -1,5 +1,17 @@
 2013-01-10  Levi Weintraub  le...@chromium.org
 
+ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views
+https://bugs.webkit.org/show_bug.cgi?id=106383
+
+Reviewed by James Robinson.
+
+* platform/chromium/fast/events/touch/resources: Added.
+* platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html: Added.
+* platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
+* platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html: Added.
+
+2013-01-10  Levi Weintraub  le...@chromium.org
+
 Regression(r137939): Heap-use-after-free in WebCore::accumulateDocumentEventTargetRects
 https://bugs.webkit.org/show_bug.cgi?id=106454
 


Added: trunk/LayoutTests/platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html (0 => 139346)

--- trunk/LayoutTests/platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html	(rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html	2013-01-10 19:33:20 UTC (rev 139346)
@@ -0,0 +1,8 @@
+!doctype html
+html
+body
+div id=touchTarget style=width: 50px; height: 50px; background-color: blue; _ontouchstart_=function() { };/div
+script
+document.getElementById(touchTarget).addEventListener(touchstart, function() { }, false);
+/script
+/body
\ No newline at end of file


Added: trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt (0 => 139346)

--- trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt	2013-01-10 19:33:20 UTC (rev 139346)
@@ -0,0 +1,4 @@
+This test validates that touch hit tests rects are created in the coordinates of the outermost view, not their containing view. This test only works in DumpRenderTree.
+[0]: (60, 110, 50, 50)
+[1]: (420, 170, 50, 50)
+


Added: trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html (0 => 139346)

--- trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html	(rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html	2013-01-10 19:33:20 UTC (rev 139346)
@@ -0,0 +1,57 @@
+!DOCTYPE html
+html
+head
+style
+#iframe1 {
+	position: absolute;
+	top: 100px;
+	left: 50px;
+	width: 200px;
+	height: 200px;
+}
+#iframe2 {
+	position: absolute;
+	top: 100px;
+	left: 400px;
+	width: 200px;
+	height: 200px;
+}
+/style
+body _onload_=runTest();
+divThis test validates that touch hit tests rects are created in the coordinates of the outermost view, not their containing view.
+This test only works in DumpRenderTree./div
+div id=console/div
+iframe id=iframe1 src=""
+iframe id=iframe2/iframe
+script
+
+var iframeDocument = document.getElementById(iframe2).contentWindow.document;
+iframeDocument.open('text/html', 'replace');
+iframeDocument.write(!DOCTYPE html\nhtmlbodyiframe 

[webkit-changes] [139115] branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp

[leviw]

Title: [139115] branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp








Revision 139115
Author le...@chromium.org
Date 2013-01-08 14:49:08 -0800 (Tue, 08 Jan 2013)


Log Message
Merge 139017. Requested by yus...@google.com
 Don't use double tap zoom if minimum and maximum page scale is the same
 https://bugs.webkit.org/show_bug.cgi?id=106272
 
 Patch by Yusuf Ozuysal yus...@google.com on 2013-01-07
 Reviewed by James Robinson.
 
 We should only try to computed relevant scale and scrollOffset and start the animation
 if the page is zoomable. This now creates an undesired animation for mobile pages which
 are not zoomable.
 
 * src/WebViewImpl.cpp:
 (WebKit::WebViewImpl::handleGestureEvent):

TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/11821007

Modified Paths

branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp (139114 => 139115)

--- branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-01-08 22:19:12 UTC (rev 139114)
+++ branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-01-08 22:49:08 UTC (rev 139115)
@@ -775,7 +775,7 @@
 break;
 }
 case WebInputEvent::GestureDoubleTap:
-if (m_webSettings-doubleTapToZoomEnabled()) {
+if (m_webSettings-doubleTapToZoomEnabled()  m_minimumPageScaleFactor != m_maximumPageScaleFactor) {
 m_client-cancelScheduledContentIntents();
 animateZoomAroundPoint(WebPoint(event.x, event.y), DoubleTap);
 eventSwallowed = true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [138985] trunk/LayoutTests

[leviw]

Title: [138985] trunk/LayoutTests








Revision 138985
Author le...@chromium.org
Date 2013-01-07 14:02:26 -0800 (Mon, 07 Jan 2013)


Log Message
Unreviewed gardening. Updating test expectations following r138717.

* platform/chromium-linux/platform/chromium/fast/events/touch: Removed.
* platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Removed.
* platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
* platform/chromium-win-xp/platform/chromium/fast/events: Added.
* platform/chromium-win-xp/platform/chromium/fast/events/touch: Added.
* platform/chromium-win-xp/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Added.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt


Added Paths

trunk/LayoutTests/platform/chromium-win-xp/platform/chromium/fast/events/
trunk/LayoutTests/platform/chromium-win-xp/platform/chromium/fast/events/touch/
trunk/LayoutTests/platform/chromium-win-xp/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-linux/platform/chromium/fast/events/touch/




Diff

Modified: trunk/LayoutTests/ChangeLog (138984 => 138985)

--- trunk/LayoutTests/ChangeLog	2013-01-07 21:47:20 UTC (rev 138984)
+++ trunk/LayoutTests/ChangeLog	2013-01-07 22:02:26 UTC (rev 138985)
@@ -1,3 +1,15 @@
+2013-01-07  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Updating test expectations following r138717.
+
+* platform/chromium-linux/platform/chromium/fast/events/touch: Removed.
+* platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Removed.
+* platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
+* platform/chromium-win-xp/platform/chromium/fast/events: Added.
+* platform/chromium-win-xp/platform/chromium/fast/events/touch: Added.
+* platform/chromium-win-xp/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Added.
+* platform/chromium/TestExpectations:
+
 2013-01-07  Dimitri Glazkov  dglaz...@chromium.org
 
 [Chromium] fast/speech/scripted/navigate-away.html is flaky.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (138984 => 138985)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-07 21:47:20 UTC (rev 138984)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-07 22:02:26 UTC (rev 138985)
@@ -4063,7 +4063,6 @@
 
 # Needs baselines
 Bug(thakis) [ Android Release ] fast/forms/zoomed-controls.html [ ImageOnlyFailure ]
-Bug(leviw) [ Android Win Mac Linux ] platform/chromium/fast/events/touch/compositor-touch-hit-rects.html [ Failure ]
 
 # Flaky on win7 since at least r162410
 webkit.org/b/99886 [ Win7 ] fast/dom/shadow/input-with-validation.html [ ImageOnlyFailure Pass ]


Modified: trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt (138984 => 138985)

--- trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt	2013-01-07 21:47:20 UTC (rev 138984)
+++ trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt	2013-01-07 22:02:26 UTC (rev 138985)
@@ -1,45 +1,15 @@
 This tests verifies the hit test regions given to the compositor. It can only be run in DumpRenderTree. The outputted rects should cover the hit test regions of all the listed elements.
 
 normalFlow[0]: (8, 68, 784, 10)
-normalFlow[1]: (8, 68, 784, 10)
-normalFlow[2]: (128, 68, 30, 10)
-normalFlow[3]: (8, 68, 784, 10)
-absoluteChildContainer[0]: (8, 150, 784, 10)
-absoluteChildContainer[1]: (8, 150, 784, 10)
-absoluteChildContainer[2]: (8, 150, 784, 10)
-absoluteChildContainer[3]: (118, 300, 140, 10)
-absoluteChildContainer[4]: (118, 300, 140, 10)
-relativeChildContainer[0]: (8, 250, 784, 10)
-relativeChildContainer[1]: (8, 250, 784, 10)
-relativeChildContainer[2]: (8, 250, 784, 10)
-relativeChildContainer[3]: (128, 450, 140, 10)
-overhangingContainer[0]: (8, 332, 784, 10)
-overhangingContainer[1]: (8, 332, 110, 80)
-overhangingContainer[2]: (8, 332, 110, 80)
-transformedChildContainer[0]: (63, 384, 674, 34)
-transformedChildContainer[1]: (63, 384, 674, 34)
-transformedChildContainer[2]: (8, 396, 784, 10)
-continuation[0]: (108, 460, 110, 10)
-normalFlow[0]: (8, 496, 769, 10)
-normalFlow[1]: (8, 496, 769, 10)
-normalFlow[2]: (128, 496, 30, 10)
-normalFlow[3]: (8, 496, 769, 10)
-absoluteChildContainer[0]: (118, 300, 140, 10)
+absoluteChildContainer[0]: (8, 96, 784, 10)
 absoluteChildContainer[1]: (118, 300, 140, 10)
-absoluteChild

[webkit-changes] [138717] trunk

[leviw]

Title: [138717] trunk








Revision 138717
Author le...@chromium.org
Date 2013-01-03 10:32:01 -0800 (Thu, 03 Jan 2013)


Log Message
Fix incorrect assumption about in-flow descendants of inlines in touch event rect tracking
https://bugs.webkit.org/show_bug.cgi?id=105970

Reviewed by Simon Fraser.

Source/WebCore: 

Correcting the touch event target rect accumulation code to no longer incorrectly assume that
non-block renderers held only normal-flow children. The updated code will always walk the
complete renderer sub-tree, but only do the work of calculating the absolute rect when the
child won't necessarily fall inside its parent (floating, positioned, or transformed).

Tests: platform/chromium/fast/events/touch/compositor-touch-hit-rects.html updated to catch bug.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::accumulateRendererTouchEventTargetRects): Walk all renderer sub-trees. Also keeping
track of the last added parent container rect to avoid adding redundant rectangles.
(WebCore::accumulateDocumentEventTargetRects): Avoiding adding empty rects.

LayoutTests: 

* platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Updating expectations
* platform/chromium/fast/events/touch/compositor-touch-hit-rects.html: Updating test to check previously failing case where
an inline with a touch handler contains a non-normal-flow child. Also, fixing the test since it was incorrectly duplicated.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html
trunk/LayoutTests/platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (138716 => 138717)

--- trunk/LayoutTests/ChangeLog	2013-01-03 18:23:56 UTC (rev 138716)
+++ trunk/LayoutTests/ChangeLog	2013-01-03 18:32:01 UTC (rev 138717)
@@ -1,3 +1,15 @@
+2013-01-02  Levi Weintraub  le...@chromium.org
+
+Fix incorrect assumption about in-flow descendants of inlines in touch event rect tracking
+https://bugs.webkit.org/show_bug.cgi?id=105970
+
+Reviewed by Simon Fraser.
+
+* platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Updating expectations
+* platform/chromium/fast/events/touch/compositor-touch-hit-rects.html: Updating test to check previously failing case where
+an inline with a touch handler contains a non-normal-flow child. Also, fixing the test since it was incorrectly duplicated.
+* platform/chromium/TestExpectations:
+
 2013-01-03  Terry Anderson  tdander...@chromium.org
 
 Unreviewed gardening. Marking webaudio/automatic-pull-node.html as


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (138716 => 138717)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-03 18:23:56 UTC (rev 138716)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-03 18:32:01 UTC (rev 138717)
@@ -4045,6 +4045,7 @@
 
 # Needs baselines
 Bug(thakis) [ Android Release ] fast/forms/zoomed-controls.html [ ImageOnlyFailure ]
+Bug(leviw) [ Android Win Mac Linux ] platform/chromium/fast/events/touch/compositor-touch-hit-rects.html [ Failure ]
 
 # Flaky on win7 since at least r162410
 webkit.org/b/99886 [ Win7 ] fast/dom/shadow/input-with-validation.html [ ImageOnlyFailure Pass ]


Modified: trunk/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html (138716 => 138717)

--- trunk/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html	2013-01-03 18:23:56 UTC (rev 138716)
+++ trunk/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html	2013-01-03 18:32:01 UTC (rev 138717)
@@ -54,112 +54,15 @@
 		divcauses a/div
 		continuation/b
 	/div
-/div
-script
-if (!window.testRunner)
-	return;
-
-window.testRunner.dumpAsText();
-
-function listener() { }
-
-function log(msg) {
-	var span = document.createElement(span);
-	document.getElementById(console).appendChild(span);
-span.innerHTML = msg + 'br /';
-}
-
-function sortRects(a, b) {
-	return a.top - b.top;
-}
-
-function logRects(id) {
-	element = document.getElementById(id);
-	element.addEventListener('touchstart', listener, false);
-	rects = window.internals.touchEventTargetClientRects(document);
-	var sortedRects = new Array();
-	for (var i = 0; i  rects.length; ++i)
-		sortedRects[i] = rects[i];
-	sortedRects.sort(sortRects);
-	for (var i = 0; i  rects.length; ++i)
-		log(id + [ + i + ]: ( + sortedRects[i].left + ,  + sortedRects[i].top + ,  + sortedRects[i].width + ,  + sortedRects[i].height + ));
-	element.removeEventListener('touchstart', listener, false);
-}
-
-logRects(normalFlow);
-logRects(absoluteChild

[webkit-changes] [138739] branches/chromium/1364

[leviw]

Title: [138739] branches/chromium/1364








Revision 138739
Author le...@chromium.org
Date 2013-01-03 14:06:22 -0800 (Thu, 03 Jan 2013)


Log Message
Merge 138717
 Fix incorrect assumption about in-flow descendants of inlines in touch event rect tracking
 https://bugs.webkit.org/show_bug.cgi?id=105970
 
 Reviewed by Simon Fraser.
 
 Source/WebCore: 
 
 Correcting the touch event target rect accumulation code to no longer incorrectly assume that
 non-block renderers held only normal-flow children. The updated code will always walk the
 complete renderer sub-tree, but only do the work of calculating the absolute rect when the
 child won't necessarily fall inside its parent (floating, positioned, or transformed).
 
 Tests: platform/chromium/fast/events/touch/compositor-touch-hit-rects.html updated to catch bug.
 
 * page/scrolling/ScrollingCoordinator.cpp:
 (WebCore::accumulateRendererTouchEventTargetRects): Walk all renderer sub-trees. Also keeping
 track of the last added parent container rect to avoid adding redundant rectangles.
 (WebCore::accumulateDocumentEventTargetRects): Avoiding adding empty rects.
 
 LayoutTests: 
 
 * platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Updating expectations
 * platform/chromium/fast/events/touch/compositor-touch-hit-rects.html: Updating test to check previously failing case where
 an inline with a touch handler contains a non-normal-flow child. Also, fixing the test since it was incorrectly duplicated.
 * platform/chromium/TestExpectations:
 

TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11753015

Modified Paths

branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations
branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html
branches/chromium/1364/LayoutTests/platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt
branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp




Diff

Modified: branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations (138738 => 138739)

--- branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations	2013-01-03 22:05:35 UTC (rev 138738)
+++ branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations	2013-01-03 22:06:22 UTC (rev 138739)
@@ -4012,6 +4012,7 @@
 
 # Needs baselines
 Bug(thakis) [ Android Release ] fast/forms/zoomed-controls.html [ ImageOnlyFailure ]
+Bug(leviw) [ Android Win Mac Linux ] platform/chromium/fast/events/touch/compositor-touch-hit-rects.html [ Failure ]
 
 # Flaky on win7 since at least r162410
 webkit.org/b/99886 [ Win7 ] fast/dom/shadow/input-with-validation.html [ ImageOnlyFailure Pass ]


Modified: branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html (138738 => 138739)

--- branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html	2013-01-03 22:05:35 UTC (rev 138738)
+++ branches/chromium/1364/LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html	2013-01-03 22:06:22 UTC (rev 138739)
@@ -54,112 +54,15 @@
 		divcauses a/div
 		continuation/b
 	/div
-/div
-script
-if (!window.testRunner)
-	return;
-
-window.testRunner.dumpAsText();
-
-function listener() { }
-
-function log(msg) {
-	var span = document.createElement(span);
-	document.getElementById(console).appendChild(span);
-span.innerHTML = msg + 'br /';
-}
-
-function sortRects(a, b) {
-	return a.top - b.top;
-}
-
-function logRects(id) {
-	element = document.getElementById(id);
-	element.addEventListener('touchstart', listener, false);
-	rects = window.internals.touchEventTargetClientRects(document);
-	var sortedRects = new Array();
-	for (var i = 0; i  rects.length; ++i)
-		sortedRects[i] = rects[i];
-	sortedRects.sort(sortRects);
-	for (var i = 0; i  rects.length; ++i)
-		log(id + [ + i + ]: ( + sortedRects[i].left + ,  + sortedRects[i].top + ,  + sortedRects[i].width + ,  + sortedRects[i].height + ));
-	element.removeEventListener('touchstart', listener, false);
-}
-
-logRects(normalFlow);
-logRects(absoluteChildContainer);
-logRects(relativeChildContainer);
-logRects(overhangingContainer);
-logRects(transformedChildContainer);
-logRects(continuation);
-
-var testContainer = document.getElementById(tests);
-testContainer.parentNode.removeChild(testContainer);
-
-/script
-/body
-!DOCTYPE html
-html
-head
-style
-#transformedChild {
-	-webkit-transform: rotate3d(0.2, 1, 0, 35grad);
-}
-#absoluteChild {
-	position: absolute;
-	top: 300px;
-}
-#relativeChild {
-	position: relative;
-	top: 200px;
-}
-#overhangingContainer {
-	height: 10px;
-}
-#overhangingFloatingChild {
-	width: 100px;
-	float: left;
-}
-#tests {
-	font: 10px Ahem;
-}
-/style
-/head
-body
-p id=descriptionThis tests verifies the hit test regions given to the compositor. It can only be run in DumpRenderTree.
-The outputted rects should

[webkit-changes] [138178] trunk/LayoutTests

[leviw]

Title: [138178] trunk/LayoutTests








Revision 138178
Author le...@chromium.org
Date 2012-12-19 09:50:01 -0800 (Wed, 19 Dec 2012)


Log Message
Unreviewed. Fixing incorrect include path and unskipping broken test.

* fast/events/touch/touch-input-element-change-documents.html:
* platform/efl/TestExpectations:
* platform/qt/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (138177 => 138178)

--- trunk/LayoutTests/ChangeLog	2012-12-19 17:49:45 UTC (rev 138177)
+++ trunk/LayoutTests/ChangeLog	2012-12-19 17:50:01 UTC (rev 138178)
@@ -1,3 +1,11 @@
+2012-12-19  Levi Weintraub  le...@chromium.org
+
+Unreviewed. Fixing incorrect include path and unskipping broken test.
+
+* fast/events/touch/touch-input-element-change-documents.html:
+* platform/efl/TestExpectations:
+* platform/qt/TestExpectations:
+
 2012-12-19  Dominic Mazzoni  dmazz...@google.com
 
 Support titleUIElement in chromium DRT


Modified: trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html (138177 => 138178)

--- trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html	2012-12-19 17:49:45 UTC (rev 138177)
+++ trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html	2012-12-19 17:50:01 UTC (rev 138178)
@@ -1,4 +1,4 @@
-script src=""
+script src=""
 div id='container'/div
 script
 description(This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.);


Modified: trunk/LayoutTests/platform/efl/TestExpectations (138177 => 138178)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-12-19 17:49:45 UTC (rev 138177)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-12-19 17:50:01 UTC (rev 138178)
@@ -1728,6 +1728,3 @@
 # Note webkit.org/b/104506, random crashes
 webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes.html [ ImageOnlyFailure Crash ]
 webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes-repaint.html [ ImageOnlyFailure Crash ]
-
-# Failing touch events case
-webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ]


Modified: trunk/LayoutTests/platform/qt/TestExpectations (138177 => 138178)

--- trunk/LayoutTests/platform/qt/TestExpectations	2012-12-19 17:49:45 UTC (rev 138177)
+++ trunk/LayoutTests/platform/qt/TestExpectations	2012-12-19 17:50:01 UTC (rev 138178)
@@ -2272,9 +2272,6 @@
 fast/profiler/apply.html
 http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html
 
-# [Qt] New fast/events/touch/touch-input-element-change-documents.html fails on JSC platforms
-webkit.org/b/104054 fast/events/touch/touch-input-element-change-documents.html
-
 # === #
 #   End of entries merged in from the old Skipped file#
 # === #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [138180] trunk/LayoutTests

[leviw]

Title: [138180] trunk/LayoutTests








Revision 138180
Author le...@chromium.org
Date 2012-12-19 11:20:38 -0800 (Wed, 19 Dec 2012)


Log Message
Unreviewed gardening. The previous rebaseline didn't quite get it right for Mac.

* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png
trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png
trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (138179 => 138180)

--- trunk/LayoutTests/ChangeLog	2012-12-19 18:01:44 UTC (rev 138179)
+++ trunk/LayoutTests/ChangeLog	2012-12-19 19:20:38 UTC (rev 138180)
@@ -1,5 +1,16 @@
 2012-12-19  Levi Weintraub  le...@chromium.org
 
+Unreviewed gardening. The previous rebaseline didn't quite get it right for Mac.
+
+* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
+* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
+* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
+* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
+* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
+* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
+
+2012-12-19  Levi Weintraub  le...@chromium.org
+
 Unreviewed gardening. Updating expectations following r137847.
 
 * platform/chromium-linux-x86/fast/dom/Window: Added.


Modified: trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [138181] trunk

[leviw]

Title: [138181] trunk








Revision 138181
Author le...@chromium.org
Date 2012-12-19 11:22:12 -0800 (Wed, 19 Dec 2012)


Log Message
Correct missing touch event handler de-registration for nested Documents and DOMWindows
https://bugs.webkit.org/show_bug.cgi?id=105384

Reviewed by James Robinson.

Source/WebCore: 

Correcting case by which a nested DOMWindow wouldn't clean up its event handler references
on its Document when removeAllEventListeners was called. Also, correctly propagating this
from a nested Document to its owner Document.

Updating fast/events/touch/touch-handler-count.html to catch this bug.

* dom/Document.cpp:
(WebCore::Document::didRemoveEventTargetNode):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::removeAllEventListeners):

LayoutTests: 

* fast/events/touch/touch-handler-count-expected.txt:
* fast/events/touch/touch-handler-count.html: Adding case of nested DOMWindows with event handlers.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt
trunk/LayoutTests/fast/events/touch/touch-handler-count.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/DOMWindow.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (138180 => 138181)

--- trunk/LayoutTests/ChangeLog	2012-12-19 19:20:38 UTC (rev 138180)
+++ trunk/LayoutTests/ChangeLog	2012-12-19 19:22:12 UTC (rev 138181)
@@ -1,5 +1,15 @@
 2012-12-19  Levi Weintraub  le...@chromium.org
 
+Correct missing touch event handler de-registration for nested Documents and DOMWindows
+https://bugs.webkit.org/show_bug.cgi?id=105384
+
+Reviewed by James Robinson.
+
+* fast/events/touch/touch-handler-count-expected.txt:
+* fast/events/touch/touch-handler-count.html: Adding case of nested DOMWindows with event handlers.
+
+2012-12-19  Levi Weintraub  le...@chromium.org
+
 Unreviewed gardening. The previous rebaseline didn't quite get it right for Mac.
 
 * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:


Modified: trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt (138180 => 138181)

--- trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt	2012-12-19 19:20:38 UTC (rev 138180)
+++ trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt	2012-12-19 19:22:12 UTC (rev 138181)
@@ -71,4 +71,8 @@
 PASS window.internals.touchEventHandlerCount(document) is 2
 PASS window.internals.touchEventHandlerCount(document) is 2
 PASS window.internals.touchEventHandlerCount(document) is 0
+Test that nested Documents' touch handlers are properly removed from their parent Document.
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 1
+PASS window.internals.touchEventHandlerCount(document) is 0
 


Modified: trunk/LayoutTests/fast/events/touch/touch-handler-count.html (138180 => 138181)

--- trunk/LayoutTests/fast/events/touch/touch-handler-count.html	2012-12-19 19:20:38 UTC (rev 138180)
+++ trunk/LayoutTests/fast/events/touch/touch-handler-count.html	2012-12-19 19:22:12 UTC (rev 138181)
@@ -204,5 +204,24 @@
 shouldBe('window.internals.touchEventHandlerCount(document)', '0');
 })();
 
+debug(Test that nested Documents' touch handlers are properly removed from their parent Document.);
+(function() {
+var iframe = document.createElement('iframe');
+var touchtarget = document.getElementById('touchtarget');
+
+shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+touchtarget.appendChild(iframe);
+
+var nestedDocument = iframe.contentWindow.document;
+nestedDocument.open('text/html', 'replace');
+nestedDocument.write(!DOCTYPE html\nhtmlbody _onload_=\window._ontouchstart_ = function() { };\/body);
+nestedDocument.close();
+
+shouldBe('window.internals.touchEventHandlerCount(document)', '1');
+
+touchtarget.removeChild(iframe);
+shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+})();
 /script
 /body


Modified: trunk/Source/WebCore/ChangeLog (138180 => 138181)

--- trunk/Source/WebCore/ChangeLog	2012-12-19 19:20:38 UTC (rev 138180)
+++ trunk/Source/WebCore/ChangeLog	2012-12-19 19:22:12 UTC (rev 138181)
@@ -1,3 +1,21 @@
+2012-12-19  Levi Weintraub  le...@chromium.org
+
+Correct missing touch event handler de-registration for nested Documents and DOMWindows
+https://bugs.webkit.org/show_bug.cgi?id=105384
+
+Reviewed by James Robinson.
+
+Correcting case by which a nested DOMWindow wouldn't clean up its event handler references
+on its Document when removeAllEventListeners was called. Also, correctly propagating this
+from a nested Document to its owner Document.
+
+Updating fast/events/touch/touch-handler-count.html to catch this bug.
+
+* dom/Document.cpp:
+

[webkit-changes] [138186] trunk/LayoutTests

[leviw]

Title: [138186] trunk/LayoutTests








Revision 138186
Author le...@chromium.org
Date 2012-12-19 12:03:12 -0800 (Wed, 19 Dec 2012)


Log Message
Re-skipping touch-input-element-chang-documents.html since it's still
failing on qt and efl.

* platform/efl/TestExpectations:
* platform/qt/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (138185 => 138186)

--- trunk/LayoutTests/ChangeLog	2012-12-19 20:01:53 UTC (rev 138185)
+++ trunk/LayoutTests/ChangeLog	2012-12-19 20:03:12 UTC (rev 138186)
@@ -1,3 +1,11 @@
+2012-12-19  Levi Weintraub  le...@chromium.org
+
+Re-skipping touch-input-element-chang-documents.html since it's still
+failing on qt and efl.
+
+* platform/efl/TestExpectations:
+* platform/qt/TestExpectations:
+
 2012-12-19  Alexis Menard  ale...@webkit.org
 
 Implement CSS parsing for CSS transitions unprefixed.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (138185 => 138186)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-12-19 20:01:53 UTC (rev 138185)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-12-19 20:03:12 UTC (rev 138186)
@@ -1728,3 +1728,6 @@
 # Note webkit.org/b/104506, random crashes
 webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes.html [ ImageOnlyFailure Crash ]
 webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes-repaint.html [ ImageOnlyFailure Crash ]
+
+# Failing touch events case 
+webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ] 


Modified: trunk/LayoutTests/platform/qt/TestExpectations (138185 => 138186)

--- trunk/LayoutTests/platform/qt/TestExpectations	2012-12-19 20:01:53 UTC (rev 138185)
+++ trunk/LayoutTests/platform/qt/TestExpectations	2012-12-19 20:03:12 UTC (rev 138186)
@@ -2272,6 +2272,9 @@
 fast/profiler/apply.html
 http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html
 
+# [Qt] New fast/events/touch/touch-input-element-change-documents.html fails on JSC platforms
+webkit.org/b/104054 fast/events/touch/touch-input-element-change-documents.html
+
 # === #
 #   End of entries merged in from the old Skipped file#
 # === #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [138189] branches/chromium/1364

[leviw]

Title: [138189] branches/chromium/1364








Revision 138189
Author le...@chromium.org
Date 2012-12-19 12:47:05 -0800 (Wed, 19 Dec 2012)


Log Message
Merge 138095
 Input elements with default touch handlers don't update handler counts when changing documents
 https://bugs.webkit.org/show_bug.cgi?id=105334
 
 Reviewed by James Robinson.
 
 Source/WebCore: 
 
 When an Input element with default touch event handlers changes documents, it failed to
 update the touch event handler sets in both the old and new document. This patch fixes this
 case.
 
 Test: fast/events/touch/touch-input-element-change-documents.html
 
 * dom/Document.h:
 (WebCore::Document::didRemoveTouchEventTargetNode) This function makes sense when touch
 handling is enabled, regardless of whether we're tracking the rects.
 * dom/Document.cpp:
 * html/HTMLInputElement.cpp:
 (WebCore::HTMLInputElement::~HTMLInputElement): Switch from didRemoveTouchEventHandler to
 didRemoveTouchEventTargetNode, since we don't care about counts in the destructor.
 (WebCore::HTMLInputElement::updateType): Fixing incorrect indentation.
 (WebCore::HTMLInputElement::didMoveToNewDocument): Adding the node to the new document and
 removing it from the old.
 
 LayoutTests: 
 
 * fast/events/touch/touch-input-element-change-documents-expected.txt: Added.
 * fast/events/touch/touch-input-element-change-documents.html: Added.
 

TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11649024

Modified Paths

branches/chromium/1364/Source/WebCore/dom/Document.cpp
branches/chromium/1364/Source/WebCore/dom/Document.h
branches/chromium/1364/Source/WebCore/html/HTMLInputElement.cpp


Added Paths

branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt
branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html




Diff

Copied: branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt (from rev 138095, trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt) (0 => 138189)

--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt	2012-12-19 20:47:05 UTC (rev 138189)
@@ -0,0 +1,12 @@
+This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 2
+PASS window.internals.touchEventHandlerCount(document) is 3
+PASS window.internals.touchEventHandlerCount(document) is 2
+PASS window.internals.touchEventHandlerCount(document) is 0
+


Copied: branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html (from rev 138095, trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html) (0 => 138189)

--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html	2012-12-19 20:47:05 UTC (rev 138189)
@@ -0,0 +1,30 @@
+script src=""
+div id='container'/div
+script
+description(This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.);
+
+
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+ // There are two touchable Input elements in Audio's shadow DOM when controls are enabled.
+ var input = document.createElement('audio');
+ input.setAttribute(controls, true);
+ var container = document.getElementById('container');
+
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+ container.appendChild(input);
+ shouldBe('window.internals.touchEventHandlerCount(document)', '2');
+
+ input._ontouchend_ = function() { };
+ shouldBe('window.internals.touchEventHandlerCount(document)', '3');
+
+ input._ontouchend_ = null;
+ shouldBe('window.internals.touchEventHandlerCount(document)', '2');
+
+ document.implementation.createDocument(, , null).adoptNode(input);
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+
+/script
+/body


Modified: branches/chromium/1364/Source/WebCore/dom/Document.cpp (138188 => 138189)

--- branches/chromium/1364/Source/WebCore/dom/Document.cpp	2012-12-19 20:45:11 UTC (rev 138188)
+++ branches/chromium/1364/Source/WebCore/dom/Document.cpp	2012-12-19 20:47:05 UTC (rev 138189)
@@ -5654,7 +5654,7 @@
 #endif
 }
 
-#if ENABLE(TOUCH_EVENT_TRACKING)
+#if ENABLE(TOUCH_EVENTS)
 void Document::didRemoveEventTargetNode(Node* handler)
 

[webkit-changes] [138190] branches/chromium/1364

[leviw]

Title: [138190] branches/chromium/1364








Revision 138190
Author le...@chromium.org
Date 2012-12-19 12:48:34 -0800 (Wed, 19 Dec 2012)


Log Message
Merge 138181
 Correct missing touch event handler de-registration for nested Documents and DOMWindows
 https://bugs.webkit.org/show_bug.cgi?id=105384
 
 Reviewed by James Robinson.
 
 Source/WebCore: 
 
 Correcting case by which a nested DOMWindow wouldn't clean up its event handler references
 on its Document when removeAllEventListeners was called. Also, correctly propagating this
 from a nested Document to its owner Document.
 
 Updating fast/events/touch/touch-handler-count.html to catch this bug.
 
 * dom/Document.cpp:
 (WebCore::Document::didRemoveEventTargetNode):
 * page/DOMWindow.cpp:
 (WebCore::DOMWindow::removeAllEventListeners):
 
 LayoutTests: 
 
 * fast/events/touch/touch-handler-count-expected.txt:
 * fast/events/touch/touch-handler-count.html: Adding case of nested DOMWindows with event handlers.
 

TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11635026

Modified Paths

branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt
branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html
branches/chromium/1364/Source/WebCore/dom/Document.cpp
branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp




Diff

Modified: branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt (138189 => 138190)

--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt	2012-12-19 20:47:05 UTC (rev 138189)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt	2012-12-19 20:48:34 UTC (rev 138190)
@@ -71,4 +71,8 @@
 PASS window.internals.touchEventHandlerCount(document) is 2
 PASS window.internals.touchEventHandlerCount(document) is 2
 PASS window.internals.touchEventHandlerCount(document) is 0
+Test that nested Documents' touch handlers are properly removed from their parent Document.
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 1
+PASS window.internals.touchEventHandlerCount(document) is 0
 


Modified: branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html (138189 => 138190)

--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html	2012-12-19 20:47:05 UTC (rev 138189)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html	2012-12-19 20:48:34 UTC (rev 138190)
@@ -204,5 +204,24 @@
 shouldBe('window.internals.touchEventHandlerCount(document)', '0');
 })();
 
+debug(Test that nested Documents' touch handlers are properly removed from their parent Document.);
+(function() {
+var iframe = document.createElement('iframe');
+var touchtarget = document.getElementById('touchtarget');
+
+shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+touchtarget.appendChild(iframe);
+
+var nestedDocument = iframe.contentWindow.document;
+nestedDocument.open('text/html', 'replace');
+nestedDocument.write(!DOCTYPE html\nhtmlbody _onload_=\window._ontouchstart_ = function() { };\/body);
+nestedDocument.close();
+
+shouldBe('window.internals.touchEventHandlerCount(document)', '1');
+
+touchtarget.removeChild(iframe);
+shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+})();
 /script
 /body


Modified: branches/chromium/1364/Source/WebCore/dom/Document.cpp (138189 => 138190)

--- branches/chromium/1364/Source/WebCore/dom/Document.cpp	2012-12-19 20:47:05 UTC (rev 138189)
+++ branches/chromium/1364/Source/WebCore/dom/Document.cpp	2012-12-19 20:48:34 UTC (rev 138190)
@@ -5659,6 +5659,9 @@
 {
 if (m_touchEventTargets.get())
 m_touchEventTargets-removeAll(handler);
+if (handler == this)
+if (Document* parentDocument = this-parentDocument())
+parentDocument-didRemoveEventTargetNode(this);
 }
 #endif
 


Modified: branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp (138189 => 138190)

--- branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp	2012-12-19 20:47:05 UTC (rev 138189)
+++ branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp	2012-12-19 20:48:34 UTC (rev 138190)
@@ -1685,6 +1685,10 @@
 if (DeviceOrientationController* controller = DeviceOrientationController::from(page()))
 controller-removeAllDeviceEventListeners(this);
 #endif
+#if ENABLE(TOUCH_EVENTS)
+if (Document* document = this-document())
+document-didRemoveEventTargetNode(document);
+#endif
 
 removeAllUnloadEventListeners(this);
 removeAllBeforeUnloadEventListeners(this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [138095] trunk

[leviw]

Title: [138095] trunk








Revision 138095
Author le...@chromium.org
Date 2012-12-18 18:04:12 -0800 (Tue, 18 Dec 2012)


Log Message
Input elements with default touch handlers don't update handler counts when changing documents
https://bugs.webkit.org/show_bug.cgi?id=105334

Reviewed by James Robinson.

Source/WebCore: 

When an Input element with default touch event handlers changes documents, it failed to
update the touch event handler sets in both the old and new document. This patch fixes this
case.

Test: fast/events/touch/touch-input-element-change-documents.html

* dom/Document.h:
(WebCore::Document::didRemoveTouchEventTargetNode) This function makes sense when touch
handling is enabled, regardless of whether we're tracking the rects.
* dom/Document.cpp:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement): Switch from didRemoveTouchEventHandler to
didRemoveTouchEventTargetNode, since we don't care about counts in the destructor.
(WebCore::HTMLInputElement::updateType): Fixing incorrect indentation.
(WebCore::HTMLInputElement::didMoveToNewDocument): Adding the node to the new document and
removing it from the old.

LayoutTests: 

* fast/events/touch/touch-input-element-change-documents-expected.txt: Added.
* fast/events/touch/touch-input-element-change-documents.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/html/HTMLInputElement.cpp


Added Paths

trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt
trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html




Diff

Modified: trunk/LayoutTests/ChangeLog (138094 => 138095)

--- trunk/LayoutTests/ChangeLog	2012-12-19 02:02:54 UTC (rev 138094)
+++ trunk/LayoutTests/ChangeLog	2012-12-19 02:04:12 UTC (rev 138095)
@@ -1,3 +1,13 @@
+2012-12-18  Levi Weintraub  le...@chromium.org
+
+Input elements with default touch handlers don't update handler counts when changing documents
+https://bugs.webkit.org/show_bug.cgi?id=105334
+
+Reviewed by James Robinson.
+
+* fast/events/touch/touch-input-element-change-documents-expected.txt: Added.
+* fast/events/touch/touch-input-element-change-documents.html: Added.
+
 2012-12-18  Simon Fraser  simon.fra...@apple.com
 
 Skip two asserting tests in Debug.


Added: trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt (0 => 138095)

--- trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt	2012-12-19 02:04:12 UTC (rev 138095)
@@ -0,0 +1,12 @@
+This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 2
+PASS window.internals.touchEventHandlerCount(document) is 3
+PASS window.internals.touchEventHandlerCount(document) is 2
+PASS window.internals.touchEventHandlerCount(document) is 0
+


Added: trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html (0 => 138095)

--- trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html	(rev 0)
+++ trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html	2012-12-19 02:04:12 UTC (rev 138095)
@@ -0,0 +1,30 @@
+script src=""
+div id='container'/div
+script
+description(This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.);
+
+
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+ // There are two touchable Input elements in Audio's shadow DOM when controls are enabled.
+ var input = document.createElement('audio');
+ input.setAttribute(controls, true);
+ var container = document.getElementById('container');
+
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+ container.appendChild(input);
+ shouldBe('window.internals.touchEventHandlerCount(document)', '2');
+
+ input._ontouchend_ = function() { };
+ shouldBe('window.internals.touchEventHandlerCount(document)', '3');
+
+ input._ontouchend_ = null;
+ shouldBe('window.internals.touchEventHandlerCount(document)', '2');
+
+ document.implementation.createDocument(, , null).adoptNode(input);
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+
+/script
+/body


Modified: trunk/Source/WebCore/ChangeLog (138094 => 138095)

--- trunk/Source/WebCore/ChangeLog	2012-12-19 02:02:54 UTC (rev 138094)
+++ trunk/Source/WebCore/ChangeLog	

[webkit-changes] [132731] trunk

[leviw]

Title: [132731] trunk








Revision 132731
Author le...@chromium.org
Date 2012-10-27 10:18:12 -0700 (Sat, 27 Oct 2012)


Log Message
Background images can incorrectly repeat with sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=94622

Reviewed by Emil A Eklund.

Source/WebCore:

Attempting to better match author expectations when painting tiled background images. When under
the effects of zoom with sub-pixel layout enabled, the drawn size of a rendered element can
differ depending on its location. This change looks at the size of the scaled tiled background
image size, and either ceils or floors that value depending on if tiling that value will
result in us being one pixel or less short of covering the background size. This is a heuristic,
as sub-pixel/zooming isn't specced.

Test: fast/sub-pixel/scaled-background-image.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::applySubPixelHeuristicForTileSize):
(WebCore):
(WebCore::RenderBoxModelObject::calculateFillTileSize):

LayoutTests:

* fast/sub-pixel/scaled-background-image-expected.html: Added.
* fast/sub-pixel/scaled-background-image.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp


Added Paths

trunk/LayoutTests/fast/sub-pixel/scaled-background-image-expected.html
trunk/LayoutTests/fast/sub-pixel/scaled-background-image.html




Diff

Modified: trunk/LayoutTests/ChangeLog (132730 => 132731)

--- trunk/LayoutTests/ChangeLog	2012-10-27 17:15:47 UTC (rev 132730)
+++ trunk/LayoutTests/ChangeLog	2012-10-27 17:18:12 UTC (rev 132731)
@@ -1,3 +1,13 @@
+2012-10-27  Levi Weintraub  le...@chromium.org
+
+Background images can incorrectly repeat with sub-pixel layout
+https://bugs.webkit.org/show_bug.cgi?id=94622
+
+Reviewed by Emil A Eklund.
+
+* fast/sub-pixel/scaled-background-image-expected.html: Added.
+* fast/sub-pixel/scaled-background-image.html: Added.
+
 2012-10-26  Balazs Kelemen  kbal...@webkit.org
 
 [Qt] Pixel tests need rebaseline


Added: trunk/LayoutTests/fast/sub-pixel/scaled-background-image-expected.html (0 => 132731)

--- trunk/LayoutTests/fast/sub-pixel/scaled-background-image-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/scaled-background-image-expected.html	2012-10-27 17:18:12 UTC (rev 132731)
@@ -0,0 +1,18 @@
+html
+head
+style type=text/css
+.norepeat {
+background: url(../images/resources/exif-orientation-7-rl.jpg);
+	border: 5px solid black;
+	margin: 5px;
+	background-size: 124px 63px;
+	width: 124px;
+height: 63px;
+}
+/style
+body
+div class=norepeat/div
+pThis tests that we don't tile background images that are sufficiently close to the renderer size. The background image
+above should not repeat. See a href="" 94622/a./p
+/body
+/html


Added: trunk/LayoutTests/fast/sub-pixel/scaled-background-image.html (0 => 132731)

--- trunk/LayoutTests/fast/sub-pixel/scaled-background-image.html	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/scaled-background-image.html	2012-10-27 17:18:12 UTC (rev 132731)
@@ -0,0 +1,19 @@
+html
+head
+style type=text/css
+.norepeat {
+background: url(../images/resources/exif-orientation-7-rl.jpg);
+	zoom: 1.25;
+	background-size: 99px 50px;
+	border: 4px solid black;
+	margin: 4px;
+	width: 99px;
+height: 50px;
+}
+/style
+body
+div class=norepeat/div
+pThis tests that we don't tile background images that are sufficiently close to the renderer size. The background image
+above should not repeat. See a href="" 94622/a./p
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (132730 => 132731)

--- trunk/Source/WebCore/ChangeLog	2012-10-27 17:15:47 UTC (rev 132730)
+++ trunk/Source/WebCore/ChangeLog	2012-10-27 17:18:12 UTC (rev 132731)
@@ -1,3 +1,24 @@
+2012-10-27  Levi Weintraub  le...@chromium.org
+
+Background images can incorrectly repeat with sub-pixel layout
+https://bugs.webkit.org/show_bug.cgi?id=94622
+
+Reviewed by Emil A Eklund.
+
+Attempting to better match author expectations when painting tiled background images. When under
+the effects of zoom with sub-pixel layout enabled, the drawn size of a rendered element can
+differ depending on its location. This change looks at the size of the scaled tiled background
+image size, and either ceils or floors that value depending on if tiling that value will
+result in us being one pixel or less short of covering the background size. This is a heuristic,
+as sub-pixel/zooming isn't specced.
+
+Test: fast/sub-pixel/scaled-background-image.html
+
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::applySubPixelHeuristicForTileSize):
+(WebCore):
+(WebCore::RenderBoxModelObject::calculateFillTileSize):
+
 2012-10-27  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r132725.


Modified: 

[webkit-changes] [132372] trunk/LayoutTests

[leviw]

Title: [132372] trunk/LayoutTests








Revision 132372
Author le...@chromium.org
Date 2012-10-24 10:56:50 -0700 (Wed, 24 Oct 2012)


Log Message
Unreveiewed gardening. Fixing linter, marking 2 mathml tests as flaky crashers on debug,
and adding passing Lion expectations for a third mathml test.

* platform/chromium/TestExpectations:
* platform/chromium-mac-lion/mathml/presentation/fenced-expected.png: Modified.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations


Added Paths

trunk/LayoutTests/platform/chromium-mac-lion/mathml/presentation/fenced-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (132371 => 132372)

--- trunk/LayoutTests/ChangeLog	2012-10-24 17:55:30 UTC (rev 132371)
+++ trunk/LayoutTests/ChangeLog	2012-10-24 17:56:50 UTC (rev 132372)
@@ -1,3 +1,11 @@
+2012-10-24  Levi Weintraub  le...@chromium.org
+
+Unreveiewed gardening. Fixing linter, marking 2 mathml tests as flaky crashers on debug,
+and adding passing Lion expectations for a third mathml test.
+
+* platform/chromium/TestExpectations:
+* platform/chromium-mac-lion/mathml/presentation/fenced-expected.png: Modified.
+
 2012-10-24  Toni Barzic  tbar...@chromium.org
 
 Crash when trying to write exception message to null console


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132371 => 132372)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 17:55:30 UTC (rev 132371)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 17:56:50 UTC (rev 132372)
@@ -1753,10 +1753,6 @@
 webkit.org/b/98765 [ Android ] http/tests/media/media-source/video-media-source-duration-changed.html
 webkit.org/b/98765 [ Android ] http/tests/media/video-buffered-range-contains-currentTime.html
 
-# [Chromium-Android] Subtitles (and video) do not work on Android
-webkit.org/b/98766 [ Android ] media/track/track-cue-rendering-vertical.html [ Failure ]
-webkit.org/b/98766 [ Android ] media/track/track-cue-rendering-horizontal.html [ Failure ]
-
 # [Chromium-Android] Fullscreen mode is not working correctly
 webkit.org/b/98767 [ Android ] fullscreen/full-screen-iframe-legacy.html [ Failure ]
 
@@ -1989,6 +1985,9 @@
 webkit.org/b/97390 [ Mac ] mathml/presentation/msubsup-base-changed.xhtml [ ImageOnlyFailure Pass ]
 # Once chromium decides to definitely enable MathML, we can delete the old platform/chromium baseline for this:
 webkit.org/b/96960 http/tests/xmlviewer/dumpAsText/mathml.xml [ Pass Failure ]
+# These two tests are flaky crashers on Mac Debug bots
+webkit.org/b/100268 [ Mac Debug ] mathml/presentation/row.xhtml [ Pass Crash ]
+webkit.org/b/100268 [ Mac Debug ] mathml/presentation/mo-stretch.html [ Pass Crash ]
 
 # WebKit update 48796:48820
 # Test #9 throws an exception.
@@ -3986,10 +3985,13 @@
 # css3-conditionals support is not yet enabled.
 webkit.org/b/86146 css3/supports.html
 
- # Require rebaselining after webkit.org/b/97800
- webkit.org/b/89167 media/track/track-cue-rendering-horizontal.html [ Failure ]
- webkit.org/b/89167 media/track/track-cue-rendering-vertical.html [ Failure ]
- webkit.org/b/89167 media/track/track-cue-rendering.html [ Failure ]
+# Require rebaselining after webkit.org/b/97800
+webkit.org/b/89167 media/track/track-cue-rendering-horizontal.html [ Failure ]
+webkit.org/b/89167 media/track/track-cue-rendering-vertical.html [ Failure ]
+webkit.org/b/89167 media/track/track-cue-rendering.html [ Failure ]
+# [Chromium-Android] Subtitles (and video) do not work on Android (Disabled to make linter happy)
+#webkit.org/b/98766 [ Android ] media/track/track-cue-rendering-vertical.html [ Failure ]
+#webkit.org/b/98766 [ Android ] media/track/track-cue-rendering-horizontal.html [ Failure ]
 
 webkit.org/b/98686 editing/pasteboard/data-transfer-items.html [ Failure ]
 


Added: trunk/LayoutTests/platform/chromium-mac-lion/mathml/presentation/fenced-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-lion/mathml/presentation/fenced-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132375] trunk/Source/WebCore

[leviw]

Title: [132375] trunk/Source/WebCore








Revision 132375
Author le...@chromium.org
Date 2012-10-24 11:08:17 -0700 (Wed, 24 Oct 2012)


Log Message
Fixing the Chromium build after typo in r132367.

* WebCore.gypi:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi




Diff

Modified: trunk/Source/WebCore/ChangeLog (132374 => 132375)

--- trunk/Source/WebCore/ChangeLog	2012-10-24 18:02:49 UTC (rev 132374)
+++ trunk/Source/WebCore/ChangeLog	2012-10-24 18:08:17 UTC (rev 132375)
@@ -1,3 +1,9 @@
+2012-10-24  Levi Weintraub  le...@chromium.org
+
+Fixing the Chromium build after typo in r132367.
+
+* WebCore.gypi:
+
 2012-10-24  Nico Weber  tha...@chromium.org
 
 [chromium] Respect image orientation in image dragging code


Modified: trunk/Source/WebCore/WebCore.gypi (132374 => 132375)

--- trunk/Source/WebCore/WebCore.gypi	2012-10-24 18:02:49 UTC (rev 132374)
+++ trunk/Source/WebCore/WebCore.gypi	2012-10-24 18:08:17 UTC (rev 132375)
@@ -328,7 +328,6 @@
 'platform/SearchPopupMenu.h',
 'platform/SharedBuffer.h',
 'platform/SharedBufferChunkReader.h',
-'platform/SharedWorkerStrategy.h',
 'platform/StatsCounter.h',
 'platform/Supplementable.h',
 'platform/SystemTime.h',
@@ -633,6 +632,7 @@
 'rendering/style/StyleVariableData.h',
 'rendering/style/StyleVisualData.h',
 'rendering/svg/SVGResourcesCache.h',
+'workers/SharedWorkerStrategy.h',
 'workers/WorkerRunLoop.h',
 'workers/WorkerThread.h',
 ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132378] trunk/LayoutTests

[leviw]

Title: [132378] trunk/LayoutTests








Revision 132378
Author le...@chromium.org
Date 2012-10-24 11:28:45 -0700 (Wed, 24 Oct 2012)


Log Message
Unreviewed gardening. Marking fast/media/w3c/test_media_queries.html as slow on
Chromium debug bots following r132352. It may still timeout...

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (132377 => 132378)

--- trunk/LayoutTests/ChangeLog	2012-10-24 18:13:57 UTC (rev 132377)
+++ trunk/LayoutTests/ChangeLog	2012-10-24 18:28:45 UTC (rev 132378)
@@ -1,3 +1,10 @@
+2012-10-24  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking fast/media/w3c/test_media_queries.html as slow on
+Chromium debug bots following r132352. It may still timeout...
+
+* platform/chromium/TestExpectations:
+
 2012-10-24  Florin Malita  fmal...@chromium.org
 
 [Chromium] SVG repaint issues


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132377 => 132378)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 18:13:57 UTC (rev 132377)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 18:28:45 UTC (rev 132378)
@@ -84,6 +84,7 @@
 webkit.org/b/65862 storage/indexeddb [ Pass Slow ]
 crbug.com/24182 [ Win Debug ] platform/chromium/virtual/gpu/fast/canvas/canvas-composite-alpha.html [ Pass Slow ]
 webkit.org/b/24182 [ Debug ] fast/dom/css-delete-doc.html [ Pass Slow ]
+webkit.org/b/100272 [ Debug ] fast/media/w3c/test_media_queries.html [ Pass Slow ]
 
 # These tests started being slow when we switched to DRT.
 webkit.org/b/90488 [ Linux Win Debug ] inspector [ Pass Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132400] trunk/LayoutTests

[leviw]

Title: [132400] trunk/LayoutTests








Revision 132400
Author le...@chromium.org
Date 2012-10-24 14:34:16 -0700 (Wed, 24 Oct 2012)


Log Message
Unreviewed gardening. Updating slow expectations for two tests following a Chromium
change. See https://bugs.webkit.org/show_bug.cgi?id=100287

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (132399 => 132400)

--- trunk/LayoutTests/ChangeLog	2012-10-24 21:08:01 UTC (rev 132399)
+++ trunk/LayoutTests/ChangeLog	2012-10-24 21:34:16 UTC (rev 132400)
@@ -1,3 +1,10 @@
+2012-10-24  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Updating slow expectations for two tests following a Chromium
+change. See https://bugs.webkit.org/show_bug.cgi?id=100287
+
+* platform/chromium/TestExpectations:
+
 2012-10-24  Tony Chang  t...@chromium.org
 
 Setting width of a flexitem causes the adjacent flex item to be displayed poorly.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132399 => 132400)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 21:08:01 UTC (rev 132399)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 21:34:16 UTC (rev 132400)
@@ -91,6 +91,10 @@
 webkit.org/b/90488 [ Linux Win Debug ] http/tests/inspector [ Pass Slow ]
 webkit.org/b/90488 [ Linux Win Debug ] http/tests/inspector-enabled [ Pass Slow ]
 
+# Chromium r163873 slowed down these tests
+webkit.org/b/100287 [ Linux Win Mac ] compositing/culling/filter-occlusion-blur-large.html [ Pass Slow ]
+webkit.org/b/66989 transforms/3d/point-mapping/3d-point-mapping-deep.html [ Failure ImageOnlyFailure Slow ]
+
 # The test has been timing out since landed in r130587.
 webkit.org/b/98659 [ Debug ] fast/dom/gc-dom-tree-lifetime.html [ Pass Timeout ]
 
@@ -2920,7 +2924,6 @@
 webkit.org/b/66989 transforms/3d/general/perspective-non-layer.html [ Failure ImageOnlyFailure ]
 webkit.org/b/66989 transforms/3d/general/transform-origin-z-change.html [ Failure ImageOnlyFailure ]
 webkit.org/b/66989 transforms/3d/point-mapping/3d-point-mapping-2.html [ Failure ImageOnlyFailure ]
-webkit.org/b/66989 transforms/3d/point-mapping/3d-point-mapping-deep.html [ Failure ImageOnlyFailure ]
 webkit.org/b/66989 transforms/3d/point-mapping/3d-point-mapping-coplanar.html [ Failure ImageOnlyFailure ]
 
 # We don't seem to load this glyph on windows






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132407] trunk/LayoutTests

[leviw]

Title: [132407] trunk/LayoutTests








Revision 132407
Author le...@chromium.org
Date 2012-10-24 14:58:30 -0700 (Wed, 24 Oct 2012)


Log Message
Unreviewed gardening. Marking 2 more mathml tests as flaky crashers on debug.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (132406 => 132407)

--- trunk/LayoutTests/ChangeLog	2012-10-24 21:54:16 UTC (rev 132406)
+++ trunk/LayoutTests/ChangeLog	2012-10-24 21:58:30 UTC (rev 132407)
@@ -1,3 +1,9 @@
+2012-10-24  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking 2 more mathml tests as flaky crashers on debug.
+
+* platform/chromium/TestExpectations:
+
 2012-10-24  Terry Anderson  tdander...@chromium.org
 
 Handle two-finger tap gestures in the same way as long-press gestures


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132406 => 132407)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 21:54:16 UTC (rev 132406)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 21:58:30 UTC (rev 132407)
@@ -1990,9 +1990,11 @@
 webkit.org/b/97390 [ Mac ] mathml/presentation/msubsup-base-changed.xhtml [ ImageOnlyFailure Pass ]
 # Once chromium decides to definitely enable MathML, we can delete the old platform/chromium baseline for this:
 webkit.org/b/96960 http/tests/xmlviewer/dumpAsText/mathml.xml [ Pass Failure ]
-# These two tests are flaky crashers on Mac Debug bots
+# Some mathml tests are flaky crashers on Mac Debug bots
 webkit.org/b/100268 [ Mac Debug ] mathml/presentation/row.xhtml [ Pass Crash ]
 webkit.org/b/100268 [ Mac Debug ] mathml/presentation/mo-stretch.html [ Pass Crash ]
+webkit.org/b/100268 [ Mac Debug ] mathml/presentation/mroot-pref-width.html [ Pass Crash ]
+webkit.org/b/100268 [ Mac Debug ] mathml/presentation/style-changed.html [ Pass Crash ]
 
 # WebKit update 48796:48820
 # Test #9 throws an exception.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132408] trunk/LayoutTests

[leviw]

Title: [132408] trunk/LayoutTests








Revision 132408
Author le...@chromium.org
Date 2012-10-24 15:00:32 -0700 (Wed, 24 Oct 2012)


Log Message
Unreviewed gardening. Marking the software compositing version of
compositing/tiling/backface-preserve-3d-tiled.html as failing as well.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (132407 => 132408)

--- trunk/LayoutTests/ChangeLog	2012-10-24 21:58:30 UTC (rev 132407)
+++ trunk/LayoutTests/ChangeLog	2012-10-24 22:00:32 UTC (rev 132408)
@@ -1,5 +1,12 @@
 2012-10-24  Levi Weintraub  le...@chromium.org
 
+Unreviewed gardening. Marking the software compositing version of
+compositing/tiling/backface-preserve-3d-tiled.html as failing as well.
+
+* platform/chromium/TestExpectations:
+
+2012-10-24  Levi Weintraub  le...@chromium.org
+
 Unreviewed gardening. Marking 2 more mathml tests as flaky crashers on debug.
 
 * platform/chromium/TestExpectations:


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132407 => 132408)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 21:58:30 UTC (rev 132407)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 22:00:32 UTC (rev 132408)
@@ -2825,6 +2825,7 @@
 webkit.org/b/98315 css3/compositing/blend-mode-property.html [ Failure ]
 webkit.org/b/98315 css3/compositing/should-have-compositing-layer.html [ Failure ]
 webkit.org/b/100205 compositing/tiling/backface-preserve-3d-tiled.html [ Failure ]
+webkit.org/b/100205 platform/chromium/virtual/softwarecompositing/tiling/backface-preserve-3d-tiled.html [ Failure ]
 
 # two regions reftests failing on Chromium
 webkit.org/b/74219 fast/regions/positioned-objects-block-static-spanning-regions-rtl.html [ ImageOnlyFailure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132418] trunk/LayoutTests

[leviw]

Title: [132418] trunk/LayoutTests








Revision 132418
Author le...@chromium.org
Date 2012-10-24 16:18:32 -0700 (Wed, 24 Oct 2012)


Log Message
Unreviewed gardening. Chromium revision 163873 also made
platform/chromium/virtual/gpu/fast/canvas/canvas-incremental-repaint.html slow.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (132417 => 132418)

--- trunk/LayoutTests/ChangeLog	2012-10-24 23:17:36 UTC (rev 132417)
+++ trunk/LayoutTests/ChangeLog	2012-10-24 23:18:32 UTC (rev 132418)
@@ -1,3 +1,10 @@
+2012-10-24  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Chromium revision 163873 also made
+platform/chromium/virtual/gpu/fast/canvas/canvas-incremental-repaint.html slow.
+
+* platform/chromium/TestExpectations:
+
 2012-10-24  Max Vujovic  mvujo...@adobe.com
 
 [CSS Shaders] The mesh should be specified using column, row order


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132417 => 132418)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 23:17:36 UTC (rev 132417)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-24 23:18:32 UTC (rev 132418)
@@ -92,6 +92,7 @@
 webkit.org/b/90488 [ Linux Win Debug ] http/tests/inspector-enabled [ Pass Slow ]
 
 # Chromium r163873 slowed down these tests
+webkit.org/b/100287 [ Linux Win Mac ] platform/chromium/virtual/gpu/fast/canvas/canvas-incremental-repaint.html [ Pass Slow ]
 webkit.org/b/100287 [ Linux Win Mac ] compositing/culling/filter-occlusion-blur-large.html [ Pass Slow ]
 webkit.org/b/66989 transforms/3d/point-mapping/3d-point-mapping-deep.html [ Failure ImageOnlyFailure Slow ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132251] trunk/LayoutTests

[leviw]

Title: [132251] trunk/LayoutTests








Revision 132251
Author le...@chromium.org
Date 2012-10-23 11:45:13 -0700 (Tue, 23 Oct 2012)


Log Message
Unreviewed gardening. css3/filters/blur-filter-page-scroll-self.html is crashing
now as well as generating incorrect image results :(

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (132250 => 132251)

--- trunk/LayoutTests/ChangeLog	2012-10-23 18:42:20 UTC (rev 132250)
+++ trunk/LayoutTests/ChangeLog	2012-10-23 18:45:13 UTC (rev 132251)
@@ -1,3 +1,10 @@
+2012-10-23  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. css3/filters/blur-filter-page-scroll-self.html is crashing
+now as well as generating incorrect image results :(
+
+* platform/chromium/TestExpectations:
+
 2012-10-23  Yael Aharon  yael.aha...@intel.com
 
 [WIN7] Skip fast/media/mq-resolution.html.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132250 => 132251)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-23 18:42:20 UTC (rev 132250)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-23 18:45:13 UTC (rev 132251)
@@ -3588,7 +3588,7 @@
 webkit.org/b/91445 [ Linux ] plugins/embed-attributes-style.html [ ImageOnlyFailure Pass ]
 
 # Fails since creation in r122130
-webkit.org/b/91620 css3/filters/blur-filter-page-scroll-self.html [ ImageOnlyFailure Pass ]
+webkit.org/b/91620 css3/filters/blur-filter-page-scroll-self.html [ ImageOnlyFailure Pass Crash ]
 
 # Needs rebaseline after bug 97217 is fixed
 webkit.org/b/97325 css3/masking/clip-path-circle-relative-overflow.html [ ImageOnlyFailure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132263] trunk/LayoutTests

[leviw]

Title: [132263] trunk/LayoutTests








Revision 132263
Author le...@chromium.org
Date 2012-10-23 14:11:03 -0700 (Tue, 23 Oct 2012)


Log Message
Unreviewed gardening. Properly skipping http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout*
tests, as was the author's intention.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (132262 => 132263)

--- trunk/LayoutTests/ChangeLog	2012-10-23 21:09:54 UTC (rev 132262)
+++ trunk/LayoutTests/ChangeLog	2012-10-23 21:11:03 UTC (rev 132263)
@@ -1,3 +1,10 @@
+2012-10-23  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Properly skipping http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout*
+tests, as was the author's intention.
+
+* platform/chromium/TestExpectations:
+
 2012-10-22  Dirk Schulze  k...@webkit.org
 
 BasicShapePolygon::path takes width instead of height for boundary calculation


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132262 => 132263)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-23 21:09:54 UTC (rev 132262)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-23 21:11:03 UTC (rev 132263)
@@ -985,17 +985,17 @@
 webkit.org/b/98452 [ Linux Win ] fast/text/vertical-rl-rtl-linebreak.html [ Failure ]
 
 # ResourceRequest needs to support setTimeoutInterval
-webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html [ Failure ]
-webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html [ Failure ]
-webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html [ Failure ]
-webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html [ Failure ]
-webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html [ Failure ]
-webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html [ Failure ]
-webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html [ Failure ]
-webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html [ Failure ]
-webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html [ Failure ]
-webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html [ Failure ]
-webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html [ Failure ]
+webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html [ Skip ]
+webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html [ Skip ]
+webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html [ Skip ]
+webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html [ Skip ]
+webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html [ Skip ]
+webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html [ Skip ]
+webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html [ Skip ]
+webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html [ Skip ]
+webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html [ Skip ]
+webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html [ Skip ]
+webkit.org/b/98397 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html [ Skip ]
 
 # -
 # Inspector tests






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132102] trunk/Source/WebCore

[leviw]

Title: [132102] trunk/Source/WebCore








Revision 132102
Author le...@chromium.org
Date 2012-10-22 10:42:24 -0700 (Mon, 22 Oct 2012)


Log Message
Unreviewed Chromium build fix following r132074.

* WebCore.gypi:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi




Diff

Modified: trunk/Source/WebCore/ChangeLog (132101 => 132102)

--- trunk/Source/WebCore/ChangeLog	2012-10-22 17:39:56 UTC (rev 132101)
+++ trunk/Source/WebCore/ChangeLog	2012-10-22 17:42:24 UTC (rev 132102)
@@ -1,3 +1,9 @@
+2012-10-22  Levi Weintraub  le...@chromium.org
+
+Unreviewed Chromium build fix following r132074.
+
+* WebCore.gypi:
+
 2012-10-22  Mario Sanchez Prada  msanc...@igalia.com
 
 [GTK] Don't use deprecated AccessibilityObject methods after r99502


Modified: trunk/Source/WebCore/WebCore.gypi (132101 => 132102)

--- trunk/Source/WebCore/WebCore.gypi	2012-10-22 17:39:56 UTC (rev 132101)
+++ trunk/Source/WebCore/WebCore.gypi	2012-10-22 17:42:24 UTC (rev 132102)
@@ -5535,6 +5535,8 @@
 'platform/network/Credential.cpp',
 'platform/network/CredentialStorage.cpp',
 'platform/network/DNS.h',
+'platform/network/DNSResolveQueue.cpp',
+'platform/network/DNSResolveQueue.h',
 'platform/network/DataURL.cpp',
 'platform/network/DataURL.h',
 'platform/network/FormData.cpp',
@@ -5625,8 +5627,7 @@
 'platform/network/mac/WebCoreURLResponse.mm',
 'platform/network/qt/AuthenticationChallenge.h',
 'platform/network/qt/CredentialStorageQt.cpp',
-'platform/network/qt/DnsPrefetchHelper.cpp',
-'platform/network/qt/DnsPrefetchHelper.h',
+'platform/network/qt/DNSQt.cpp',
 'platform/network/qt/NetworkStateNotifierPrivate.h',
 'platform/network/qt/NetworkStateNotifierQt.cpp',
 'platform/network/qt/ProxyServerQt.cpp',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132124] trunk/LayoutTests

[leviw]

Title: [132124] trunk/LayoutTests








Revision 132124
Author le...@chromium.org
Date 2012-10-22 13:01:12 -0700 (Mon, 22 Oct 2012)


Log Message
Unreviewed gardening. Baselines following r132112.

* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png
trunk/LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (132123 => 132124)

--- trunk/LayoutTests/ChangeLog	2012-10-22 19:56:19 UTC (rev 132123)
+++ trunk/LayoutTests/ChangeLog	2012-10-22 20:01:12 UTC (rev 132124)
@@ -1,3 +1,10 @@
+2012-10-22  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Baselines following r132112.
+
+* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
+* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
+
 2012-10-22  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
 
 [EFL] Rebaseline pixel expectations after r131941 and r131991, part 4.


Modified: trunk/LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt (132123 => 132124)

--- trunk/LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt	2012-10-22 19:56:19 UTC (rev 132123)
+++ trunk/LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt	2012-10-22 20:01:12 UTC (rev 132124)
@@ -1,18 +1,18 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x192
-  RenderBlock {HTML} at (0,0) size 800x192
-RenderBody {BODY} at (8,16) size 784x163
+layer at (0,0) size 800x193
+  RenderBlock {HTML} at (0,0) size 800x193
+RenderBody {BODY} at (8,16) size 784x164
   RenderBlock {P} at (0,0) size 784x20
 RenderText {#text} at (0,0) size 649x19
   text run at (0,0) width 649: This tests horizontal caret movement in vertical writing mode. \\x{3042}\x{308B}\x{3002}\ and \\x{540D}\x{524D}\x{306F}\x{307E}\x{3060}\ must be selected.
-  RenderBlock {DIV} at (0,36) size 72x127
-RenderBlock {P} at (16,0) size 40x127
+  RenderBlock {DIV} at (0,36) size 72x128
+RenderBlock {P} at (16,0) size 40x128
   RenderText {#text} at (0,0) size 39x126
 text run at (0,0) width 126: \x{543E}\x{8F29}\x{306F}\x{732B}\x{3067}\x{3042}\x{308B}\x{3002}
 text run at (20,0) width 124: \x{540D}\x{524D}\x{306F}\x{307E}\x{3060}\x{7121}\x{3044}\x{3002}
-  RenderBlock (anonymous) at (0,163) size 784x0
+  RenderBlock (anonymous) at (0,164) size 784x0
 RenderText {#text} at (0,0) size 0x0
-  RenderBlock {PRE} at (0,176) size 784x0
+  RenderBlock {PRE} at (0,177) size 784x0
 selection start: position 5 of child 0 {#text} of child 1 {P} of child 3 {DIV} of body
 selection end:   position 13 of child 0 {#text} of child 1 {P} of child 3 {DIV} of body






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131921] trunk/LayoutTests

[leviw]

Title: [131921] trunk/LayoutTests








Revision 131921
Author le...@chromium.org
Date 2012-10-19 10:45:28 -0700 (Fri, 19 Oct 2012)


Log Message
Unreviewed gardening. Fixing a lint issue.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (131920 => 131921)

--- trunk/LayoutTests/ChangeLog	2012-10-19 17:43:08 UTC (rev 131920)
+++ trunk/LayoutTests/ChangeLog	2012-10-19 17:45:28 UTC (rev 131921)
@@ -1,3 +1,9 @@
+2012-10-19  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Fixing a lint issue.
+
+* platform/chromium/TestExpectations:
+
 2012-10-19  Chris Fleizach  cfleiz...@apple.com
 
 AX: aria-hidden=false does not work as expected


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (131920 => 131921)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-19 17:43:08 UTC (rev 131920)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-19 17:45:28 UTC (rev 131921)
@@ -3021,7 +3021,6 @@
 webkit.org/b/66953 [ Mac Debug ] animations/animation-direction-reverse.html [ Failure Pass ]
 
 webkit.org/b/72761 accessibility/anonymous-render-block-in-continuation-causes-crash.html [ Pass Timeout ]
-webkit.org/b/77110 [ Win Debug ] accessibility/loading-iframe-sends-notification.html [ Failure Pass ]
 
 webkit.org/b/73514 [ Win ] platform/chromium/compositing/lost-compositor-context-permanently.html [ Pass Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131970] trunk/LayoutTests

[leviw]

Title: [131970] trunk/LayoutTests








Revision 131970
Author le...@chromium.org
Date 2012-10-19 18:16:25 -0700 (Fri, 19 Oct 2012)


Log Message
Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/webgl/array-bounds-clamping.html
failing on Chromium.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (131969 => 131970)

--- trunk/LayoutTests/ChangeLog	2012-10-20 01:07:16 UTC (rev 131969)
+++ trunk/LayoutTests/ChangeLog	2012-10-20 01:16:25 UTC (rev 131970)
@@ -1,3 +1,10 @@
+2012-10-19  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/webgl/array-bounds-clamping.html
+failing on Chromium.
+
+* platform/chromium/TestExpectations:
+
 2012-10-19  Pablo Flouret  pab...@motorola.com
 
 Implement setRangeText() on text controls


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (131969 => 131970)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-20 01:07:16 UTC (rev 131969)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-20 01:16:25 UTC (rev 131970)
@@ -4041,6 +4041,8 @@
 webkit.org/b/61138 http/tests/w3c/webperf/submission/Intel/resource-timing [ Skip ]
 webkit.org/b/99802 [ MountainLion ] fast/forms/text-control-intrinsic-widths.html [ Failure ]
 
+webkit.org/b/99873 platform/chromium/virtual/gpu/fast/canvas/webgl/array-bounds-clamping.html [ Text ]
+
 # These tests are failing already and because of virtual test suite for deferred
 # image decoding they need to be suppressed again.
 webkit.org/b/94240 platform/chromium/virtual/deferred/fast/images/animated-gif-restored-from-bfcache.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131359] trunk

[leviw]

Title: [131359] trunk








Revision 131359
Author le...@chromium.org
Date 2012-10-15 14:29:31 -0700 (Mon, 15 Oct 2012)


Log Message
Regression r130057: incorrect block pref width for alternating InlineFlow and inline Replaced
https://bugs.webkit.org/show_bug.cgi?id=99194

Reviewed by Eric Seidel.

Source/WebCore:

Correctly breaking lines after inline replaced elements that follow inline flows. Previously, alternating
these two types of elements would cause us to increase our preferred width forever.

Test: fast/block/block-with-inline-replaced-children-in-inline-flows.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

LayoutTests:

* fast/block/block-with-inline-replaced-children-in-inline-flows-expected.html: Added.
* fast/block/block-with-inline-replaced-children-in-inline-flows.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp


Added Paths

trunk/LayoutTests/fast/block/block-with-inline-replaced-children-in-inline-flows-expected.html
trunk/LayoutTests/fast/block/block-with-inline-replaced-children-in-inline-flows.html




Diff

Modified: trunk/LayoutTests/ChangeLog (131358 => 131359)

--- trunk/LayoutTests/ChangeLog	2012-10-15 21:27:41 UTC (rev 131358)
+++ trunk/LayoutTests/ChangeLog	2012-10-15 21:29:31 UTC (rev 131359)
@@ -1,3 +1,13 @@
+2012-10-15  Levi Weintraub  le...@chromium.org
+
+Regression r130057: incorrect block pref width for alternating InlineFlow and inline Replaced
+https://bugs.webkit.org/show_bug.cgi?id=99194
+
+Reviewed by Eric Seidel.
+
+* fast/block/block-with-inline-replaced-children-in-inline-flows-expected.html: Added.
+* fast/block/block-with-inline-replaced-children-in-inline-flows.html: Added.
+
 2012-10-15  Emil A Eklund  e...@chromium.org
 
 Revert rounding change in RenderTable::paintObject


Added: trunk/LayoutTests/fast/block/block-with-inline-replaced-children-in-inline-flows-expected.html (0 => 131359)

--- trunk/LayoutTests/fast/block/block-with-inline-replaced-children-in-inline-flows-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/block/block-with-inline-replaced-children-in-inline-flows-expected.html	2012-10-15 21:29:31 UTC (rev 131359)
@@ -0,0 +1,19 @@
+!DOCTYPE html
+html
+style
+span {
+	padding-left: 30px;
+}
+img {
+	width: 50px;
+	height: 50px;
+}
+/style
+body
+divTest for Bugzilla bug:a href="" 99194/a Regression r130057: incorrect block pref width for alternating InlineFlow and inline Replaced./div
+divThis test verifies that we properly calculate block preferred widths when we have repeated inline replaced elements wrapped in InlineFlows./div
+div style=width: 80px; border: 1px solid black;
+span style=img src="" src=""
+/div
+/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/fast/block/block-with-inline-replaced-children-in-inline-flows.html (0 => 131359)

--- trunk/LayoutTests/fast/block/block-with-inline-replaced-children-in-inline-flows.html	(rev 0)
+++ trunk/LayoutTests/fast/block/block-with-inline-replaced-children-in-inline-flows.html	2012-10-15 21:29:31 UTC (rev 131359)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+html
+style
+span  span {
+	padding-left: 30px;
+}
+img {
+	width: 50px;
+	height: 50px;
+}
+/style
+body
+divTest for Bugzilla bug:a href="" 99194/a Regression r130057: incorrect block pref width for alternating InlineFlow and inline Replaced./div
+divThis test verifies that we properly calculate block preferred widths when we have repeated inline replaced elements wrapped in InlineFlows./div
+div style=width: 50px
+span style=float: left; border: 1px solid black;
+span style=img src="" src=""
+/span
+/div
+/body
+/html
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (131358 => 131359)

--- trunk/Source/WebCore/ChangeLog	2012-10-15 21:27:41 UTC (rev 131358)
+++ trunk/Source/WebCore/ChangeLog	2012-10-15 21:29:31 UTC (rev 131359)
@@ -1,3 +1,18 @@
+2012-10-15  Levi Weintraub  le...@chromium.org
+
+Regression r130057: incorrect block pref width for alternating InlineFlow and inline Replaced
+https://bugs.webkit.org/show_bug.cgi?id=99194
+
+Reviewed by Eric Seidel.
+
+Correctly breaking lines after inline replaced elements that follow inline flows. Previously, alternating
+these two types of elements would cause us to increase our preferred width forever.
+
+Test: fast/block/block-with-inline-replaced-children-in-inline-flows.html
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
+
 2012-10-15  Emil A Eklund  e...@chromium.org
 
 Revert rounding change in RenderTable::paintObject


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (131358 => 131359)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2012-10-15 21:27:41 UTC (rev 131358)
+++ 

[webkit-changes] [131228] trunk/LayoutTests

[leviw]

Title: [131228] trunk/LayoutTests








Revision 131228
Author le...@chromium.org
Date 2012-10-12 15:00:45 -0700 (Fri, 12 Oct 2012)


Log Message
Unreviewed gardening. Updating expectations for fast/repaint/repaint-across-writing-mode-boundary.html
and switching the TestExpectations files for ports with SUBPIXEL_LAYOUT disabled to skip the entire
sub-pixel test folder.

* platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium/TestExpectations:
* platform/mac-lion/TestExpectations:
* platform/mac-snowleopard/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt/TestExpectations:
* platform/win-wk2/TestExpectations:
* platform/win-xp/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
* platform/wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png
trunk/LayoutTests/platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png
trunk/LayoutTests/platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-lion/TestExpectations
trunk/LayoutTests/platform/mac-snowleopard/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations
trunk/LayoutTests/platform/qt-4.8/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/win-wk2/TestExpectations
trunk/LayoutTests/platform/win-xp/TestExpectations
trunk/LayoutTests/platform/wincairo/TestExpectations
trunk/LayoutTests/platform/wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (131227 => 131228)

--- trunk/LayoutTests/ChangeLog	2012-10-12 21:53:52 UTC (rev 131227)
+++ trunk/LayoutTests/ChangeLog	2012-10-12 22:00:45 UTC (rev 131228)
@@ -1,3 +1,25 @@
+2012-10-12  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Updating expectations for fast/repaint/repaint-across-writing-mode-boundary.html
+and switching the TestExpectations files for ports with SUBPIXEL_LAYOUT disabled to skip the entire
+sub-pixel test folder.
+
+* platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
+* platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
+* platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
+* platform/chromium/TestExpectations:
+* platform/mac-lion/TestExpectations:
+* platform/mac-snowleopard/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/qt-4.8/TestExpectations:
+* platform/qt/TestExpectations:
+* platform/win-wk2/TestExpectations:
+* platform/win-xp/TestExpectations:
+* platform/win/TestExpectations:
+* platform/wincairo/TestExpectations:
+* platform/wk2/TestExpectations:
+
 2012-10-12  Emil A Eklund  e...@chromium.org
 
 Unreviewed chromium windows rebaseline for r131202.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (131227 => 131228)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-12 21:53:52 UTC (rev 131227)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-12 22:00:45 UTC (rev 131228)
@@ -3543,10 +3543,6 @@
 webkit.org/b/89789 [ Mac ] plugins/embed-attributes-style.html [ ImageOnlyFailure Pass ]
 webkit.org/b/89789 [ Mac ] userscripts/user-script-video-document.html [ Crash Pass ]
 
-# Need rebaseline after bots cycle.
-webkit.org/b/98571 [ Win Mac ] fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html [ Failure Pass ]
-webkit.org/b/98571 [ Win Mac ] fast/repaint/repaint-across-writing-mode-boundary.html [ ImageOnlyFailure Pass ]
-
 # Flaky
 webkit.org/b/89794 [ Mac ] fast/regions/get-regions-by-content2.html [ Crash Pass ]
 


Modified: trunk/LayoutTests/platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/mac/TestExpectations (131227 => 131228)

--- trunk/LayoutTests/platform/mac/TestExpectations	2012-10-12 21:53:52 UTC (rev 131227)
+++ trunk/LayoutTests/platform/mac/TestExpectations	

[webkit-changes] [131231] trunk/Source/WebCore

[leviw]

Title: [131231] trunk/Source/WebCore








Revision 131231
Author le...@chromium.org
Date 2012-10-12 15:16:33 -0700 (Fri, 12 Oct 2012)


Log Message
Remove unnecessary mode identifiers added in r13
https://bugs.webkit.org/show_bug.cgi?id=99208

Reviewed by Emil A Eklund.

Removing unnecessary mode identifiers from coordinate conversion methods. These
were added in http://trac.webkit.org/changeset/13

No new tests. No change in behavior.

* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
* rendering/RenderInline.h:
(RenderInline):
* rendering/RenderObject.h:
(RenderObject):
* rendering/RenderView.h:
(RenderView):
* rendering/svg/RenderSVGForeignObject.h:
(RenderSVGForeignObject):
* rendering/svg/RenderSVGInline.h:
(RenderSVGInline):
* rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
* rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):
* rendering/svg/RenderSVGText.h:
(RenderSVGText):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderBoxModelObject.h
trunk/Source/WebCore/rendering/RenderInline.h
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderView.h
trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h
trunk/Source/WebCore/rendering/svg/RenderSVGInline.h
trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.h
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h
trunk/Source/WebCore/rendering/svg/RenderSVGText.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (131230 => 131231)

--- trunk/Source/WebCore/ChangeLog	2012-10-12 22:04:55 UTC (rev 131230)
+++ trunk/Source/WebCore/ChangeLog	2012-10-12 22:16:33 UTC (rev 131231)
@@ -1,3 +1,36 @@
+2012-10-12  Levi Weintraub  le...@chromium.org
+
+Remove unnecessary mode identifiers added in r13
+https://bugs.webkit.org/show_bug.cgi?id=99208
+
+Reviewed by Emil A Eklund.
+
+Removing unnecessary mode identifiers from coordinate conversion methods. These
+were added in http://trac.webkit.org/changeset/13
+
+No new tests. No change in behavior.
+
+* rendering/RenderBox.h:
+(RenderBox):
+* rendering/RenderBoxModelObject.h:
+(RenderBoxModelObject):
+* rendering/RenderInline.h:
+(RenderInline):
+* rendering/RenderObject.h:
+(RenderObject):
+* rendering/RenderView.h:
+(RenderView):
+* rendering/svg/RenderSVGForeignObject.h:
+(RenderSVGForeignObject):
+* rendering/svg/RenderSVGInline.h:
+(RenderSVGInline):
+* rendering/svg/RenderSVGModelObject.h:
+(RenderSVGModelObject):
+* rendering/svg/RenderSVGRoot.h:
+(RenderSVGRoot):
+* rendering/svg/RenderSVGText.h:
+(RenderSVGText):
+
 2012-10-12  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r131224.


Modified: trunk/Source/WebCore/rendering/RenderBox.h (131230 => 131231)

--- trunk/Source/WebCore/rendering/RenderBox.h	2012-10-12 22:04:55 UTC (rev 131230)
+++ trunk/Source/WebCore/rendering/RenderBox.h	2012-10-12 22:16:33 UTC (rev 131231)
@@ -574,9 +574,9 @@
 
 virtual bool shouldComputeSizeAsReplaced() const { return isReplaced()  !isInlineBlockOrInlineTable(); }
 
-virtual void mapLocalToContainer(RenderLayerModelObject* repaintContainer, TransformState, MapCoordinatesFlags mode = ApplyContainerFlip | SnapOffsetForTransforms, bool* wasFixed = 0) const OVERRIDE;
+virtual void mapLocalToContainer(RenderLayerModelObject* repaintContainer, TransformState, MapCoordinatesFlags = ApplyContainerFlip | SnapOffsetForTransforms, bool* wasFixed = 0) const OVERRIDE;
 virtual const RenderObject* pushMappingToContainer(const RenderLayerModelObject*, RenderGeometryMap) const OVERRIDE;
-virtual void mapAbsoluteToLocalPoint(MapCoordinatesFlags mode, TransformState) const;
+virtual void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState) const;
 
 void paintRootBoxFillLayers(const PaintInfo);
 


Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.h (131230 => 131231)

--- trunk/Source/WebCore/rendering/RenderBoxModelObject.h	2012-10-12 22:04:55 UTC (rev 131230)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.h	2012-10-12 22:16:33 UTC (rev 131231)
@@ -158,7 +158,7 @@
 virtual LayoutUnit lineHeight(bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const = 0;
 virtual LayoutUnit baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const = 0;
 
-virtual void mapAbsoluteToLocalPoint(MapCoordinatesFlags mode, TransformState) const OVERRIDE;
+virtual void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState) const OVERRIDE;
 
 void highQualityRepaintTimerFired(TimerRenderBoxModelObject*);
 


Modified: trunk/Source/WebCore/rendering/RenderInline.h (131230 => 

[webkit-changes] [131000] trunk

[leviw]

Title: [131000] trunk








Revision 131000
Author le...@chromium.org
Date 2012-10-10 19:47:06 -0700 (Wed, 10 Oct 2012)


Log Message
Tests failure on Chromium Mac after r130821
https://bugs.webkit.org/show_bug.cgi?id=98865

Reviewed by Adam Barth.

Source/WebCore:

Updating the check for USE(HARFBUZZ_NG) to check for Mac Chromium, as the HARFBUZZ_NG flag isn't
actually set, despite us using Harfbuzz. This unbreaks Chromium Mac as we diagnose the root
cause of this issue.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):

LayoutTests:

Removing failing test entries.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (130999 => 131000)

--- trunk/LayoutTests/ChangeLog	2012-10-11 02:40:44 UTC (rev 130999)
+++ trunk/LayoutTests/ChangeLog	2012-10-11 02:47:06 UTC (rev 131000)
@@ -1,3 +1,14 @@
+2012-10-10  Levi Weintraub  le...@chromium.org
+
+Tests failure on Chromium Mac after r130821
+https://bugs.webkit.org/show_bug.cgi?id=98865
+
+Reviewed by Adam Barth.
+
+Removing failing test entries.
+
+* platform/chromium/TestExpectations:
+
 2012-10-10  Stephen Chenney  schen...@chromium.org
 
 SVGTextRunRenderingContext changes font data in the glyph page, but it shouldn't


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (130999 => 131000)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-11 02:40:44 UTC (rev 130999)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-11 02:47:06 UTC (rev 131000)
@@ -4018,8 +4018,4 @@
 webkit.org/b/98699 [ Lion ] fast/writing-mode/vertical-subst-font-vert-no-dflt.html [ Crash ]
 webkit.org/b/98811 [ Mac ] fast/transforms/transformed-focused-text-input.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/98867 [ Mac ] fast/lists/003-vertical.html [ ImageOnlyFailure ]
-webkit.org/b/98867 [ Mac ] fast/text/international/vertical-text-glyph-test.html [ Failure ImageOnlyFailure ]
-webkit.org/b/98867 [ Mac ] fast/text/shaping/shaping-selection-rect.html [ Failure ImageOnlyFailure ]
-
 webkit.org/b/98948 [ Linux Debug ] http/tests/media/media-source/video-media-source-play.html [ PASS CRASH ]


Modified: trunk/Source/WebCore/ChangeLog (130999 => 131000)

--- trunk/Source/WebCore/ChangeLog	2012-10-11 02:40:44 UTC (rev 130999)
+++ trunk/Source/WebCore/ChangeLog	2012-10-11 02:47:06 UTC (rev 131000)
@@ -1,3 +1,17 @@
+2012-10-10  Levi Weintraub  le...@chromium.org
+
+Tests failure on Chromium Mac after r130821
+https://bugs.webkit.org/show_bug.cgi?id=98865
+
+Reviewed by Adam Barth.
+
+Updating the check for USE(HARFBUZZ_NG) to check for Mac Chromium, as the HARFBUZZ_NG flag isn't
+actually set, despite us using Harfbuzz. This unbreaks Chromium Mac as we diagnose the root
+cause of this issue.
+
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::setLogicalWidthForTextRun):
+
 2012-10-10  Stephen Chenney  schen...@chromium.org
 
 SVGTextRunRenderingContext changes font data in the glyph page, but it shouldn't


Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (130999 => 131000)

--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2012-10-11 02:40:44 UTC (rev 130999)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2012-10-11 02:47:06 UTC (rev 131000)
@@ -712,7 +712,7 @@
 static inline void setLogicalWidthForTextRun(RootInlineBox* lineBox, BidiRun* run, RenderText* renderer, float xPos, const LineInfo lineInfo,
  GlyphOverflowAndFallbackFontsMap textBoxDataMap, VerticalPositionCache verticalPositionCache, WordMeasurements wordMeasurements)
 {
-#if USE(HARFBUZZ_NG)
+#if !(PLATFORM(CHROMIUM)  OS(DARWIN))
 UNUSED_PARAM(wordMeasurements);
 #endif
 HashSetconst SimpleFontData* fallbackFonts;
@@ -740,7 +740,7 @@
 }
 float measuredWidth = 0;
 
-#if !USE(HARFBUZZ_NG)
+#if !(PLATFORM(CHROMIUM)  OS(DARWIN))
 bool kerningIsEnabled = font.typesettingFeatures()  Kerning;
 
 // Since we don't cache glyph overflows, we need to re-measure the run if






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [130822] trunk/LayoutTests

[leviw]

Title: [130822] trunk/LayoutTests








Revision 130822
Author le...@chromium.org
Date 2012-10-09 15:45:51 -0700 (Tue, 09 Oct 2012)


Log Message
Rolling back unintended change to iframe-copy-on-scroll.html from previous commit.

* compositing/iframes/iframe-copy-on-scroll.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/iframes/iframe-copy-on-scroll.html




Diff

Modified: trunk/LayoutTests/ChangeLog (130821 => 130822)

--- trunk/LayoutTests/ChangeLog	2012-10-09 22:31:12 UTC (rev 130821)
+++ trunk/LayoutTests/ChangeLog	2012-10-09 22:45:51 UTC (rev 130822)
@@ -1,5 +1,11 @@
 2012-10-09  Levi Weintraub  le...@chromium.org
 
+Rolling back unintended change to iframe-copy-on-scroll.html from previous commit.
+
+* compositing/iframes/iframe-copy-on-scroll.html:
+
+2012-10-09  Levi Weintraub  le...@chromium.org
+
 Unreviewed gardening. Updating test expectations after r130811.
 
 * compositing/iframes/iframe-copy-on-scroll.html:


Modified: trunk/LayoutTests/compositing/iframes/iframe-copy-on-scroll.html (130821 => 130822)

--- trunk/LayoutTests/compositing/iframes/iframe-copy-on-scroll.html	2012-10-09 22:31:12 UTC (rev 130821)
+++ trunk/LayoutTests/compositing/iframes/iframe-copy-on-scroll.html	2012-10-09 22:45:51 UTC (rev 130822)
@@ -4,7 +4,7 @@
   style type=text/css media=screen
 .container {
   position: absolute;
-  padding: 10.3px;
+  padding: 10px;
   z-index: 1;
 }
 .composited {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [130322] trunk/Source/WebCore

[leviw]

Title: [130322] trunk/Source/WebCore








Revision 130322
Author le...@chromium.org
Date 2012-10-03 14:29:59 -0700 (Wed, 03 Oct 2012)


Log Message
[Sub-pixel layout] incorrect rendering when painting sub-layers as their own root
https://bugs.webkit.org/show_bug.cgi?id=97484

Reviewed by Eric Seidel.

When in compositing mode, layer painting can be triggered through the backing store. When this
happens, a non-top-level RenderLayer is called to paint as its own root. Normally, we attempt to preserve
the proper sub-pixel accumulation through layers to their children, but since we're not
starting with the top-level layer, we haven't properly accumulated one, and convertToLayerCoords,
another source of correctly getting the sub-pixel offset for a layer, also avoids crawling
past the listed root layer.

When painting a root layer, we're aligned to the surface we're painting to, so we round our
offset to avoid moving objects around.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (130321 => 130322)

--- trunk/Source/WebCore/ChangeLog	2012-10-03 21:22:17 UTC (rev 130321)
+++ trunk/Source/WebCore/ChangeLog	2012-10-03 21:29:59 UTC (rev 130322)
@@ -1,3 +1,23 @@
+2012-10-03  Levi Weintraub  le...@chromium.org
+
+[Sub-pixel layout] incorrect rendering when painting sub-layers as their own root
+https://bugs.webkit.org/show_bug.cgi?id=97484
+
+Reviewed by Eric Seidel.
+
+When in compositing mode, layer painting can be triggered through the backing store. When this
+happens, a non-top-level RenderLayer is called to paint as its own root. Normally, we attempt to preserve
+the proper sub-pixel accumulation through layers to their children, but since we're not
+starting with the top-level layer, we haven't properly accumulated one, and convertToLayerCoords,
+another source of correctly getting the sub-pixel offset for a layer, also avoids crawling
+past the listed root layer.
+
+When painting a root layer, we're aligned to the surface we're painting to, so we round our
+offset to avoid moving objects around.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::paintLayerContents):
+
 2012-10-03  Jeff Timanus  t...@chromium.org
 
 [chromium] Expose settings value to conditionally enable pinch-zoom scaling in the Chromium compositor.  The


Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (130321 => 130322)

--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2012-10-03 21:22:17 UTC (rev 130321)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2012-10-03 21:29:59 UTC (rev 130322)
@@ -3178,6 +3178,8 @@
 calculateRects(rootLayer, region, (localPaintFlags  PaintLayerTemporaryClipRects) ? TemporaryClipRects : PaintingClipRects, paintDirtyRect, layerBounds, damageRect, clipRectToApply, outlineRect,
 IgnoreOverlayScrollbarSize, localPaintFlags  PaintLayerPaintingOverflowContents ? IgnoreOverflowClip : RespectOverflowClip);
 paintOffset = toPoint(layerBounds.location() - renderBoxLocation() + subPixelAccumulation);
+if (this == rootLayer)
+paintOffset = roundedIntPoint(paintOffset);
 }
 
 bool forceBlackText = paintBehavior  PaintBehaviorForceBlackText;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129915] branches/chromium/1271/Source/WebCore/rendering/RenderText.cpp

[leviw]

Title: [129915] branches/chromium/1271/Source/WebCore/rendering/RenderText.cpp








Revision 129915
Author le...@chromium.org
Date 2012-09-28 10:16:02 -0700 (Fri, 28 Sep 2012)


Log Message
Merge 129814 - REGRESSION(r129186): Pressing enter at the end of a line deletes the line
https://bugs.webkit.org/show_bug.cgi?id=97763

Reviewed by Ryosuke Niwa.

r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.

This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).

* rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset):


TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/10983086

Modified Paths

branches/chromium/1271/Source/WebCore/rendering/RenderText.cpp




Diff

Modified: branches/chromium/1271/Source/WebCore/rendering/RenderText.cpp (129914 => 129915)

--- branches/chromium/1271/Source/WebCore/rendering/RenderText.cpp	2012-09-28 17:14:43 UTC (rev 129914)
+++ branches/chromium/1271/Source/WebCore/rendering/RenderText.cpp	2012-09-28 17:16:02 UTC (rev 129915)
@@ -1256,6 +1256,9 @@
 
 void RenderText::setTextWithOffset(PassRefPtrStringImpl text, unsigned offset, unsigned len, bool force)
 {
+if (!force  equal(m_text.impl(), text.get()))
+return;
+
 unsigned oldLen = textLength();
 unsigned newLen = text-length();
 int delta = newLen - oldLen;
@@ -1327,7 +1330,7 @@
 }
 
 m_linesDirty = dirtiedLines;
-setText(text, force);
+setText(text, force || dirtiedLines);
 }
 
 void RenderText::transformText()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129814] trunk/Source/WebCore

[leviw]

Title: [129814] trunk/Source/WebCore








Revision 129814
Author le...@chromium.org
Date 2012-09-27 16:25:05 -0700 (Thu, 27 Sep 2012)


Log Message
REGRESSION(r129186): Pressing enter at the end of a line deletes the line
https://bugs.webkit.org/show_bug.cgi?id=97763

Reviewed by Ryosuke Niwa.

r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.

This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).

* rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderText.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129813 => 129814)

--- trunk/Source/WebCore/ChangeLog	2012-09-27 23:23:53 UTC (rev 129813)
+++ trunk/Source/WebCore/ChangeLog	2012-09-27 23:25:05 UTC (rev 129814)
@@ -1,3 +1,24 @@
+2012-09-27  Levi Weintraub  le...@chromium.org
+
+REGRESSION(r129186): Pressing enter at the end of a line deletes the line
+https://bugs.webkit.org/show_bug.cgi?id=97763
+
+Reviewed by Ryosuke Niwa.
+
+r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
+dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
+this behavior. RenderText::setTextWithOffset is called with a text string identical
+to the current text. It still dirties lines, then calls setText, which has a check
+for the case when the strings are the same and returns early and doesn't mark us as
+needing layout.
+
+This change adds the same early bailing logic in setText to setTextWithOffset, but
+forces setText to work its magic whenever we dirty lines there (and avoid double-
+checking that the strings are equal).
+
+* rendering/RenderText.cpp:
+(WebCore::RenderText::setTextWithOffset):
+
 2012-09-27  Andrew Lo  a...@rim.com
 
 requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)


Modified: trunk/Source/WebCore/rendering/RenderText.cpp (129813 => 129814)

--- trunk/Source/WebCore/rendering/RenderText.cpp	2012-09-27 23:23:53 UTC (rev 129813)
+++ trunk/Source/WebCore/rendering/RenderText.cpp	2012-09-27 23:25:05 UTC (rev 129814)
@@ -1256,6 +1256,9 @@
 
 void RenderText::setTextWithOffset(PassRefPtrStringImpl text, unsigned offset, unsigned len, bool force)
 {
+if (!force  equal(m_text.impl(), text.get()))
+return;
+
 unsigned oldLen = textLength();
 unsigned newLen = text-length();
 int delta = newLen - oldLen;
@@ -1328,7 +1331,7 @@
 }
 
 m_linesDirty = dirtiedLines;
-setText(text, force);
+setText(text, force || dirtiedLines);
 }
 
 void RenderText::transformText()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129818] branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp

[leviw]

Title: [129818] branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp








Revision 129818
Author le...@chromium.org
Date 2012-09-27 16:51:47 -0700 (Thu, 27 Sep 2012)


Log Message
Merge 129814 - REGRESSION(r129186): Pressing enter at the end of a line deletes the line
https://bugs.webkit.org/show_bug.cgi?id=97763

Reviewed by Ryosuke Niwa.

r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.

This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).

* rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset):


TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/10993072

Modified Paths

branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp




Diff

Modified: branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp (129817 => 129818)

--- branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp	2012-09-27 23:39:09 UTC (rev 129817)
+++ branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp	2012-09-27 23:51:47 UTC (rev 129818)
@@ -1253,6 +1253,9 @@
 
 void RenderText::setTextWithOffset(PassRefPtrStringImpl text, unsigned offset, unsigned len, bool force)
 {
+if (!force  equal(m_text.impl(), text.get()))
+return;
+
 unsigned oldLen = textLength();
 unsigned newLen = text-length();
 int delta = newLen - oldLen;
@@ -1324,7 +1327,7 @@
 }
 
 m_linesDirty = dirtiedLines;
-setText(text, force);
+setText(text, force || dirtiedLines);
 }
 
 void RenderText::transformText()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129686] branches/chromium/1271

[leviw]

Title: [129686] branches/chromium/1271








Revision 129686
Author le...@chromium.org
Date 2012-09-26 12:40:33 -0700 (Wed, 26 Sep 2012)


Log Message
Merge 129529 - [chromium] REGRESSION: Incorrect preferred width calculation for table cells
https://bugs.webkit.org/show_bug.cgi?id=97497

Reviewed by Levi Weintraub.

Source/WebCore: 

In fixing bug 93911 r125694 caused a problem with the preferred
width calculations for table cells with a fractional padding
where the logic to ensure that the cell is wide enough for the
content returns different results for cells with a fixed width
and cells with an automatic width.

Test: fast/sub-pixel/table-cells-have-stable-width.html

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
Move the logic that ensures that a cell is wide enough from AutoTableLayout::recalcColumn to RenderBlock::computePreferredLogicalWidths to. This way it also applies to FixedTableLayout which had the same problem.

LayoutTests: 

Added test for cell width calculation and reverted three svg tests to the results prior to r125694.

* fast/sub-pixel/table-cells-have-stable-width-expected.txt: Added.
* fast/sub-pixel/table-cells-have-stable-width.html: Added.
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:


TBR=e...@chromium.org

Modified Paths

branches/chromium/1271/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
branches/chromium/1271/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
branches/chromium/1271/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
branches/chromium/1271/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
branches/chromium/1271/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
branches/chromium/1271/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
branches/chromium/1271/Source/WebCore/rendering/AutoTableLayout.cpp
branches/chromium/1271/Source/WebCore/rendering/RenderBlock.cpp


Added Paths

branches/chromium/1271/LayoutTests/fast/sub-pixel/table-cells-have-stable-width-expected.txt
branches/chromium/1271/LayoutTests/fast/sub-pixel/table-cells-have-stable-width.html




Diff

Copied: branches/chromium/1271/LayoutTests/fast/sub-pixel/table-cells-have-stable-width-expected.txt (from rev 129529, trunk/LayoutTests/fast/sub-pixel/table-cells-have-stable-width-expected.txt) (0 => 129686)

--- branches/chromium/1271/LayoutTests/fast/sub-pixel/table-cells-have-stable-width-expected.txt	(rev 0)
+++ branches/chromium/1271/LayoutTests/fast/sub-pixel/table-cells-have-stable-width-expected.txt	2012-09-26 19:40:33 UTC (rev 129686)
@@ -0,0 +1,6 @@
+PASS Cell in AutoTable has expected size
+PASS Cell in FixedTable has expected size
+Cc:	AutoTableLayout	
+foo
+FixedTableLayout
+Tests that setting the width of an element inside a cell to the computed width of said element does not change the width of the cell itself.


Copied: branches/chromium/1271/LayoutTests/fast/sub-pixel/table-cells-have-stable-width.html (from rev 129529, trunk/LayoutTests/fast/sub-pixel/table-cells-have-stable-width.html) (0 => 129686)

--- branches/chromium/1271/LayoutTests/fast/sub-pixel/table-cells-have-stable-width.html	(rev 0)
+++ branches/chromium/1271/LayoutTests/fast/sub-pixel/table-cells-have-stable-width.html	2012-09-26 19:40:33 UTC (rev 129686)
@@ -0,0 +1,80 @@
+!DOCTYPE html
+html
+head
+style
+#firstCell {
+border-right: 3px solid #e5ecf9;
+width: 12em;
+padding: 0.5em .5em .5em 0;
+font-size: 95%;
+}
+#content {
+position: relative;
+}
+#fixedTable {
+table-layout: fixed;
+}
+#firstFixedCell {
+width: 21.2px;
+margin: 0.3px;
+padding: 0.1px;
+}
+/style
+script src=""
+/head
+
+body
+table width=100% cellpadding=0 cellspacing=0 border=0
+tbody class=collapse 
+tr
+td 

[webkit-changes] [129144] trunk/Source/WebCore

[leviw]

Title: [129144] trunk/Source/WebCore








Revision 129144
Author le...@chromium.org
Date 2012-09-20 11:20:26 -0700 (Thu, 20 Sep 2012)


Log Message
Prevent reading stale data from InlineTextBoxes
https://bugs.webkit.org/show_bug.cgi?id=94750

Reviewed by Eric Seidel.

Text from dirty InlineTextBoxes should never be read or used. This change enforces this
design goal by forcefully zero-ing out the start and length of InlineTextBoxes when 
they're being marked dirty. It also adds asserts to accessors for those members.

This change involves making markDirty virtual. Running the line-layout performance test
as well as profiling resizing the html5 spec showed negligable impact with this change.

No new tests as this doesn't change any proper behavior.

* rendering/InlineBox.h:
(WebCore::InlineBox::markDirty): Making virtual to allow InlineTextBox to overload and
zero out its start and length.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::markDirty): Zeroing out start and length when we mark the box dirty.
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::start): Adding an assert when we hit this case.
(WebCore::InlineTextBox::end): Ditto.
(WebCore::InlineTextBox::len): Ditto.
(WebCore::InlineTextBox::offsetRun): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineBox.h
trunk/Source/WebCore/rendering/InlineTextBox.cpp
trunk/Source/WebCore/rendering/InlineTextBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (129143 => 129144)

--- trunk/Source/WebCore/ChangeLog	2012-09-20 18:11:19 UTC (rev 129143)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 18:20:26 UTC (rev 129144)
@@ -1,3 +1,30 @@
+2012-09-20  Levi Weintraub  le...@chromium.org
+
+Prevent reading stale data from InlineTextBoxes
+https://bugs.webkit.org/show_bug.cgi?id=94750
+
+Reviewed by Eric Seidel.
+
+Text from dirty InlineTextBoxes should never be read or used. This change enforces this
+design goal by forcefully zero-ing out the start and length of InlineTextBoxes when 
+they're being marked dirty. It also adds asserts to accessors for those members.
+
+This change involves making markDirty virtual. Running the line-layout performance test
+as well as profiling resizing the html5 spec showed negligable impact with this change.
+
+No new tests as this doesn't change any proper behavior.
+
+* rendering/InlineBox.h:
+(WebCore::InlineBox::markDirty): Making virtual to allow InlineTextBox to overload and
+zero out its start and length.
+* rendering/InlineTextBox.cpp:
+(WebCore::InlineTextBox::markDirty): Zeroing out start and length when we mark the box dirty.
+* rendering/InlineTextBox.h:
+(WebCore::InlineTextBox::start): Adding an assert when we hit this case.
+(WebCore::InlineTextBox::end): Ditto.
+(WebCore::InlineTextBox::len): Ditto.
+(WebCore::InlineTextBox::offsetRun): Ditto.
+
 2012-09-20  Mike West  mk...@chromium.org
 
 Support paths in Content Security Policy directives.


Modified: trunk/Source/WebCore/rendering/InlineBox.h (129143 => 129144)

--- trunk/Source/WebCore/rendering/InlineBox.h	2012-09-20 18:11:19 UTC (rev 129143)
+++ trunk/Source/WebCore/rendering/InlineBox.h	2012-09-20 18:20:26 UTC (rev 129144)
@@ -262,7 +262,7 @@
 virtual void clearTruncation() { }
 
 bool isDirty() const { return m_bitfields.dirty(); }
-void markDirty(bool dirty = true) { m_bitfields.setDirty(dirty); }
+virtual void markDirty(bool dirty = true) { m_bitfields.setDirty(dirty); }
 
 virtual void dirtyLineBoxes();
 


Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (129143 => 129144)

--- trunk/Source/WebCore/rendering/InlineTextBox.cpp	2012-09-20 18:11:19 UTC (rev 129143)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp	2012-09-20 18:20:26 UTC (rev 129144)
@@ -64,6 +64,15 @@
 InlineBox::destroy(arena);
 }
 
+void InlineTextBox::markDirty(bool dirty)
+{
+if (dirty) {
+m_len = 0;
+m_start = 0;
+}
+InlineBox::markDirty(dirty);
+}
+
 LayoutRect InlineTextBox::logicalOverflowRect() const
 {
 if (knownToHaveNoOverflow() || !gTextBoxesWithOverflow)


Modified: trunk/Source/WebCore/rendering/InlineTextBox.h (129143 => 129144)

--- trunk/Source/WebCore/rendering/InlineTextBox.h	2012-09-20 18:11:19 UTC (rev 129143)
+++ trunk/Source/WebCore/rendering/InlineTextBox.h	2012-09-20 18:20:26 UTC (rev 129144)
@@ -64,17 +64,19 @@
 void setNextTextBox(InlineTextBox* n) { m_nextTextBox = n; }
 void setPreviousTextBox(InlineTextBox* p) { m_prevTextBox = p; }
 
-unsigned start() const { return m_start; }
-unsigned end() const { return m_len ? m_start + m_len - 1 : m_start; }
-unsigned len() const { return m_len; }
+unsigned start() const { ASSERT(!isDirty()); return m_start; }
+unsigned end() const { ASSERT(!isDirty()); return m_len ? m_start + m_len - 1 : m_start; }

[webkit-changes] [129147] branches/chromium/1229/Source/WebCore/rendering

[leviw]

Title: [129147] branches/chromium/1229/Source/WebCore/rendering








Revision 129147
Author le...@chromium.org
Date 2012-09-20 11:27:46 -0700 (Thu, 20 Sep 2012)


Log Message
Merge 129144 - Prevent reading stale data from InlineTextBoxes
https://bugs.webkit.org/show_bug.cgi?id=94750

Reviewed by Eric Seidel.

Text from dirty InlineTextBoxes should never be read or used. This change enforces this
design goal by forcefully zero-ing out the start and length of InlineTextBoxes when 
they're being marked dirty. It also adds asserts to accessors for those members.

This change involves making markDirty virtual. Running the line-layout performance test
as well as profiling resizing the html5 spec showed negligable impact with this change.

No new tests as this doesn't change any proper behavior.

* rendering/InlineBox.h:
(WebCore::InlineBox::markDirty): Making virtual to allow InlineTextBox to overload and
zero out its start and length.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::markDirty): Zeroing out start and length when we mark the box dirty.
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::start): Adding an assert when we hit this case.
(WebCore::InlineTextBox::end): Ditto.
(WebCore::InlineTextBox::len): Ditto.
(WebCore::InlineTextBox::offsetRun): Ditto.


TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/10970020

Modified Paths

branches/chromium/1229/Source/WebCore/rendering/InlineBox.h
branches/chromium/1229/Source/WebCore/rendering/InlineTextBox.cpp
branches/chromium/1229/Source/WebCore/rendering/InlineTextBox.h




Diff

Modified: branches/chromium/1229/Source/WebCore/rendering/InlineBox.h (129146 => 129147)

--- branches/chromium/1229/Source/WebCore/rendering/InlineBox.h	2012-09-20 18:27:15 UTC (rev 129146)
+++ branches/chromium/1229/Source/WebCore/rendering/InlineBox.h	2012-09-20 18:27:46 UTC (rev 129147)
@@ -262,7 +262,7 @@
 virtual void clearTruncation() { }
 
 bool isDirty() const { return m_bitfields.dirty(); }
-void markDirty(bool dirty = true) { m_bitfields.setDirty(dirty); }
+virtual void markDirty(bool dirty = true) { m_bitfields.setDirty(dirty); }
 
 virtual void dirtyLineBoxes();
 


Modified: branches/chromium/1229/Source/WebCore/rendering/InlineTextBox.cpp (129146 => 129147)

--- branches/chromium/1229/Source/WebCore/rendering/InlineTextBox.cpp	2012-09-20 18:27:15 UTC (rev 129146)
+++ branches/chromium/1229/Source/WebCore/rendering/InlineTextBox.cpp	2012-09-20 18:27:46 UTC (rev 129147)
@@ -64,6 +64,15 @@
 InlineBox::destroy(arena);
 }
 
+void InlineTextBox::markDirty(bool dirty)
+{
+if (dirty) {
+m_len = 0;
+m_start = 0;
+}
+InlineBox::markDirty(dirty);
+}
+
 LayoutRect InlineTextBox::logicalOverflowRect() const
 {
 if (knownToHaveNoOverflow() || !gTextBoxesWithOverflow)


Modified: branches/chromium/1229/Source/WebCore/rendering/InlineTextBox.h (129146 => 129147)

--- branches/chromium/1229/Source/WebCore/rendering/InlineTextBox.h	2012-09-20 18:27:15 UTC (rev 129146)
+++ branches/chromium/1229/Source/WebCore/rendering/InlineTextBox.h	2012-09-20 18:27:46 UTC (rev 129147)
@@ -64,17 +64,19 @@
 void setNextTextBox(InlineTextBox* n) { m_nextTextBox = n; }
 void setPreviousTextBox(InlineTextBox* p) { m_prevTextBox = p; }
 
-unsigned start() const { return m_start; }
-unsigned end() const { return m_len ? m_start + m_len - 1 : m_start; }
-unsigned len() const { return m_len; }
+unsigned start() const { ASSERT(!isDirty()); return m_start; }
+unsigned end() const { ASSERT(!isDirty()); return m_len ? m_start + m_len - 1 : m_start; }
+unsigned len() const { ASSERT(!isDirty()); return m_len; }
 
 void setStart(unsigned start) { m_start = start; }
 void setLen(unsigned len) { m_len = len; }
 
-void offsetRun(int d) { m_start += d; }
+void offsetRun(int d) { ASSERT(!isDirty()); m_start += d; }
 
 unsigned short truncation() { return m_truncation; }
 
+virtual void markDirty(bool dirty = true) OVERRIDE;
+
 using InlineBox::hasHyphen;
 using InlineBox::setHasHyphen;
 using InlineBox::canHaveLeadingExpansion;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [129186] trunk/Source/WebCore

[leviw]

Title: [129186] trunk/Source/WebCore








Revision 129186
Author le...@chromium.org
Date 2012-09-20 18:38:05 -0700 (Thu, 20 Sep 2012)


Log Message
Prevent reading stale data from InlineTextBoxes
https://bugs.webkit.org/show_bug.cgi?id=94750

Reviewed by Abhishek Arya.

Text from dirty InlineTextBoxes should never be read or used. This change
enforces this design goal by forcefully zero-ing out the start and length
of InlineTextBoxes when they're being marked dirty. Ideally, we'd also
add asserts to the accessors for this data, but there are still several
places in editing that cause this. https://bugs.webkit.org/show_bug.cgi?id=97264
tracks these cases.

This change involves making markDirty virtual. Running the line-layout
performance test as well as profiling resizing the html5 spec showed
negligable impact with this change.

No new tests as this doesn't change any proper behavior.

* dom/Position.cpp:
(WebCore::Position::downstream): Adding a FIXME.
* rendering/InlineBox.h:
(WebCore::InlineBox::markDirty): Marking virtual to allow InlineTextBox to
overload and zero out its start and length.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::markDirty): Zeroing out the start and length when
we mark the box dirty.
* rendering/InlineTextBox.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset): Adding a FIXME.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Position.cpp
trunk/Source/WebCore/rendering/InlineBox.h
trunk/Source/WebCore/rendering/InlineTextBox.cpp
trunk/Source/WebCore/rendering/InlineTextBox.h
trunk/Source/WebCore/rendering/RenderText.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129185 => 129186)

--- trunk/Source/WebCore/ChangeLog	2012-09-21 01:35:17 UTC (rev 129185)
+++ trunk/Source/WebCore/ChangeLog	2012-09-21 01:38:05 UTC (rev 129186)
@@ -1,3 +1,35 @@
+2012-09-20  Levi Weintraub  le...@chromium.org
+
+Prevent reading stale data from InlineTextBoxes
+https://bugs.webkit.org/show_bug.cgi?id=94750
+
+Reviewed by Abhishek Arya.
+
+Text from dirty InlineTextBoxes should never be read or used. This change
+enforces this design goal by forcefully zero-ing out the start and length
+of InlineTextBoxes when they're being marked dirty. Ideally, we'd also
+add asserts to the accessors for this data, but there are still several
+places in editing that cause this. https://bugs.webkit.org/show_bug.cgi?id=97264
+tracks these cases.
+
+This change involves making markDirty virtual. Running the line-layout
+performance test as well as profiling resizing the html5 spec showed
+negligable impact with this change.
+
+No new tests as this doesn't change any proper behavior.
+
+* dom/Position.cpp:
+(WebCore::Position::downstream): Adding a FIXME.
+* rendering/InlineBox.h:
+(WebCore::InlineBox::markDirty): Marking virtual to allow InlineTextBox to
+overload and zero out its start and length.
+* rendering/InlineTextBox.cpp:
+(WebCore::InlineTextBox::markDirty): Zeroing out the start and length when
+we mark the box dirty.
+* rendering/InlineTextBox.h:
+* rendering/RenderText.cpp:
+(WebCore::RenderText::setTextWithOffset): Adding a FIXME.
+
 2012-09-20  Adam Barth  aba...@webkit.org
 
 Measure how often web pages use Worker and SharedWorker


Modified: trunk/Source/WebCore/dom/Position.cpp (129185 => 129186)

--- trunk/Source/WebCore/dom/Position.cpp	2012-09-21 01:35:17 UTC (rev 129185)
+++ trunk/Source/WebCore/dom/Position.cpp	2012-09-21 01:38:05 UTC (rev 129186)
@@ -718,6 +718,7 @@
 // and upstream() will return the left one.
 // Also, downstream() will return the last position in the last atomic node in boundary for all of the positions
 // in boundary after the last candidate, where endsOfNodeAreVisuallyDistinctPositions(boundary).
+// FIXME: This function should never be called when the line box tree is dirty. See https://bugs.webkit.org/show_bug.cgi?id=97264
 Position Position::downstream(EditingBoundaryCrossingRule rule) const
 {
 Node* startNode = deprecatedNode();


Modified: trunk/Source/WebCore/rendering/InlineBox.h (129185 => 129186)

--- trunk/Source/WebCore/rendering/InlineBox.h	2012-09-21 01:35:17 UTC (rev 129185)
+++ trunk/Source/WebCore/rendering/InlineBox.h	2012-09-21 01:38:05 UTC (rev 129186)
@@ -262,7 +262,7 @@
 virtual void clearTruncation() { }
 
 bool isDirty() const { return m_bitfields.dirty(); }
-void markDirty(bool dirty = true) { m_bitfields.setDirty(dirty); }
+virtual void markDirty(bool dirty = true) { m_bitfields.setDirty(dirty); }
 
 virtual void dirtyLineBoxes();
 


Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (129185 => 129186)

--- trunk/Source/WebCore/rendering/InlineTextBox.cpp	2012-09-21 01:35:17 UTC (rev 129185)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp	2012-09-21 

[webkit-changes] [129033] branches/chromium/1229

[leviw]

Title: [129033] branches/chromium/1229








Revision 129033
Author le...@chromium.org
Date 2012-09-19 12:19:51 -0700 (Wed, 19 Sep 2012)


Log Message
Merge 128346 - Inline repainting can be off-by-one with sub-pixel enabled
https://bugs.webkit.org/show_bug.cgi?id=95882

Reviewed by Eric Seidel.

Source/WebCore: 

With sub-pixel layout enabled, context accumulated from containing renderers is used to properly
pixel snap. Selection repaint rects are stored outside the affected renderers, and are handed to
the embedder without the context to correctly determine the snapped values. This can result in
repaint areas smaller than what's needed.

This could be fixed three ways:
- by changing selection repaint rects to an IntRect and pixel snapping the values before storing
  them outside the render tree. This is the narrowest solution.
- by adapting layout to store pixel snapping hints along with the size/location of the renderer.
  This is the best possible solution, as it would help solve a lot of pixel snapping issues and
  reduce complexity of handling. I eventually intend on implementing this.
- by reverting repaintUsingContainer to IntRects and using pixel snapping when possible, and
  enclosingIntRect where we lack context.

This implements the last solution, as it's the least invasive, but can potentially fix numerous
sub-pixel repaint issues.

Test: fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::repaintIncludingNonCompositingDescendants):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/RenderObject.h:
(RenderObject):
* rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfo::repaint):
(WebCore::RenderBlockSelectionInfo::repaint):

LayoutTests: 

Test that we properly repaint selection gaps inside tables with sub-pixel offsets.

* fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
* fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html: Added.
* platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:


TBR=le...@chromium.org

Modified Paths

branches/chromium/1229/LayoutTests/platform/mac/Skipped
branches/chromium/1229/LayoutTests/platform/mac-lion/Skipped
branches/chromium/1229/LayoutTests/platform/mac-snowleopard/Skipped
branches/chromium/1229/LayoutTests/platform/mac-wk2/Skipped
branches/chromium/1229/LayoutTests/platform/qt/Skipped
branches/chromium/1229/LayoutTests/platform/qt-4.8/Skipped
branches/chromium/1229/LayoutTests/platform/win/Skipped
branches/chromium/1229/LayoutTests/platform/win-wk2/Skipped
branches/chromium/1229/LayoutTests/platform/win-xp/Skipped
branches/chromium/1229/LayoutTests/platform/wincairo/Skipped
branches/chromium/1229/LayoutTests/platform/wk2/Skipped
branches/chromium/1229/Source/WebCore/rendering/RenderBlockLineLayout.cpp
branches/chromium/1229/Source/WebCore/rendering/RenderLayer.cpp
branches/chromium/1229/Source/WebCore/rendering/RenderObject.cpp
branches/chromium/1229/Source/WebCore/rendering/RenderObject.h
branches/chromium/1229/Source/WebCore/rendering/RenderSelectionInfo.h


Added Paths

branches/chromium/1229/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt
branches/chromium/1229/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html
branches/chromium/1229/LayoutTests/platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png




Diff

Copied: branches/chromium/1229/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt (from rev 128346, trunk/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt) (0 => 129033)

--- branches/chromium/1229/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt	(rev 0)
+++ branches/chromium/1229/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt	2012-09-19 19:19:51 UTC (rev 129033)
@@ -0,0 +1,14 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x8
+  RenderBlock {HTML} at (0,0) size 800x8
+RenderBody {BODY} at (8,8) size 784x0
+layer at (8,2) size 321x43
+  RenderTable {TABLE} at (8,1) size 321x44
+RenderTableSection {TBODY} at (0,0) 

[webkit-changes] [128346] trunk

[leviw]

Title: [128346] trunk








Revision 128346
Author le...@chromium.org
Date 2012-09-12 12:17:03 -0700 (Wed, 12 Sep 2012)


Log Message
Inline repainting can be off-by-one with sub-pixel enabled
https://bugs.webkit.org/show_bug.cgi?id=95882

Reviewed by Eric Seidel.

Source/WebCore: 

With sub-pixel layout enabled, context accumulated from containing renderers is used to properly
pixel snap. Selection repaint rects are stored outside the affected renderers, and are handed to
the embedder without the context to correctly determine the snapped values. This can result in
repaint areas smaller than what's needed.

This could be fixed three ways:
- by changing selection repaint rects to an IntRect and pixel snapping the values before storing
  them outside the render tree. This is the narrowest solution.
- by adapting layout to store pixel snapping hints along with the size/location of the renderer.
  This is the best possible solution, as it would help solve a lot of pixel snapping issues and
  reduce complexity of handling. I eventually intend on implementing this.
- by reverting repaintUsingContainer to IntRects and using pixel snapping when possible, and
  enclosingIntRect where we lack context.

This implements the last solution, as it's the least invasive, but can potentially fix numerous
sub-pixel repaint issues.

Test: fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::repaintIncludingNonCompositingDescendants):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/RenderObject.h:
(RenderObject):
* rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfo::repaint):
(WebCore::RenderBlockSelectionInfo::repaint):

LayoutTests: 

Test that we properly repaint selection gaps inside tables with sub-pixel offsets.

* fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
* fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html: Added.
* platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/mac-lion/Skipped
trunk/LayoutTests/platform/mac-snowleopard/Skipped
trunk/LayoutTests/platform/mac-wk2/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt-4.8/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/win-wk2/Skipped
trunk/LayoutTests/platform/win-xp/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderSelectionInfo.h


Added Paths

trunk/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt
trunk/LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html
trunk/LayoutTests/platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (128345 => 128346)

--- trunk/LayoutTests/ChangeLog	2012-09-12 19:02:39 UTC (rev 128345)
+++ trunk/LayoutTests/ChangeLog	2012-09-12 19:17:03 UTC (rev 128346)
@@ -1,3 +1,28 @@
+2012-09-12  Levi Weintraub  le...@chromium.org
+
+Inline repainting can be off-by-one with sub-pixel enabled
+https://bugs.webkit.org/show_bug.cgi?id=95882
+
+Reviewed by Eric Seidel.
+
+Test that we properly repaint selection gaps inside tables with sub-pixel offsets.
+
+* fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
+* fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html: Added.
+* platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
+* platform/chromium/TestExpectations:
+* platform/mac-lion/Skipped:
+* platform/mac-snowleopard/Skipped:
+* platform/mac-wk2/Skipped:
+* platform/mac/Skipped:
+* platform/qt-4.8/Skipped:
+* platform/qt/Skipped:
+* 

[webkit-changes] [128356] trunk/LayoutTests

[leviw]

Title: [128356] trunk/LayoutTests








Revision 128356
Author le...@chromium.org
Date 2012-09-12 13:40:06 -0700 (Wed, 12 Sep 2012)


Log Message
Unreviewed gardening. Updated test expectations following r128346.

* platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png


Property Changed

trunk/LayoutTests/platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (128355 => 128356)

--- trunk/LayoutTests/ChangeLog	2012-09-12 20:35:34 UTC (rev 128355)
+++ trunk/LayoutTests/ChangeLog	2012-09-12 20:40:06 UTC (rev 128356)
@@ -1,3 +1,10 @@
+2012-09-12  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Updated test expectations following r128346.
+
+* platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
+* platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
+
 2012-09-12  Adam Klein  ad...@chromium.org
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png
___

Modified: svn:mime-type
   + image/png




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128360] trunk/LayoutTests

[leviw]

Title: [128360] trunk/LayoutTests








Revision 128360
Author le...@chromium.org
Date 2012-09-12 14:33:54 -0700 (Wed, 12 Sep 2012)


Log Message
More unreviewed gardening after r128346.

* platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png
trunk/LayoutTests/platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (128359 => 128360)

--- trunk/LayoutTests/ChangeLog	2012-09-12 21:21:06 UTC (rev 128359)
+++ trunk/LayoutTests/ChangeLog	2012-09-12 21:33:54 UTC (rev 128360)
@@ -1,3 +1,10 @@
+2012-09-12  Levi Weintraub  le...@chromium.org
+
+More unreviewed gardening after r128346.
+
+* platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
+* platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
+
 2012-09-12  Eric Seidel  e...@webkit.org
 
 Sync html5lib tests with latest sources (and sort the tests alphabetically in runner.html)


Modified: trunk/LayoutTests/platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [125919] trunk/LayoutTests

[leviw]

Title: [125919] trunk/LayoutTests








Revision 125919
Author le...@chromium.org
Date 2012-08-17 11:39:28 -0700 (Fri, 17 Aug 2012)


Log Message
Unreviewed gardening. Updating test expectations after r125794.

* fast/repaint/transform-absolute-child-expected.txt: Added.
* fast/repaint/transform-repaint-descendants-expected.txt: Added.
* platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-linux/fast/repaint/transform-absolute-child-expected.png:
* platform/chromium-linux/fast/repaint/transform-repaint-descendants-expected.png:
* platform/chromium-linux/fast/repaint/transform-translate-expected.png:
* platform/chromium-linux/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
* platform/chromium-linux/fast/transforms/transformed-document-element-expected.png:
* platform/chromium-linux/media/audio-repaint-expected.png:
* platform/chromium-linux/svg/transforms/svg-css-transforms-expected.png:
* platform/chromium-linux/transforms/svg-vs-css-expected.png:
* platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Removed.
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
* platform/chromium-mac/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Removed.
* platform/chromium-win/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
* platform/chromium-win/fast/repaint/transform-absolute-child-expected.png:
* platform/chromium-win/fast/repaint/transform-repaint-descendants-expected.png:
* platform/chromium-win/fast/repaint/transform-translate-expected.png:
* platform/chromium-win/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
* platform/chromium-win/fast/transforms/transformed-document-element-expected.png:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/svg/transforms/svg-css-transforms-expected.png:
* platform/chromium-win/transforms/svg-vs-css-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/fast/sub-pixel: Added.
* platform/chromium/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Added.
* platform/efl/fast/repaint/transform-absolute-child-expected.txt: Removed.
* platform/efl/fast/repaint/transform-repaint-descendants-expected.txt: Removed.
* platform/gtk/fast/repaint/transform-absolute-child-expected.txt: Removed.
* platform/gtk/fast/repaint/transform-repaint-descendants-expected.txt: Removed.
* platform/mac/fast/repaint/transform-absolute-child-expected.txt: Removed.
* platform/qt/fast/repaint/transform-absolute-child-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/repaint/transform-absolute-child-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/repaint/transform-repaint-descendants-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/repaint/transform-translate-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/transforms/transformed-document-element-expected.png
trunk/LayoutTests/platform/chromium-linux/media/audio-repaint-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/transforms/svg-css-transforms-expected.png
trunk/LayoutTests/platform/chromium-linux/transforms/svg-vs-css-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/media/audio-repaint-expected.png
trunk/LayoutTests/platform/chromium-win/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png
trunk/LayoutTests/platform/chromium-win/fast/repaint/transform-absolute-child-expected.png
trunk/LayoutTests/platform/chromium-win/fast/repaint/transform-repaint-descendants-expected.png
trunk/LayoutTests/platform/chromium-win/fast/repaint/transform-translate-expected.png
trunk/LayoutTests/platform/chromium-win/fast/transforms/transformed-document-element-expected.png
trunk/LayoutTests/platform/chromium-win/media/audio-repaint-expected.png
trunk/LayoutTests/platform/chromium-win/svg/transforms/svg-css-transforms-expected.png
trunk/LayoutTests/platform/chromium-win/transforms/svg-vs-css-expected.png


Added Paths

trunk/LayoutTests/fast/repaint/transform-absolute-child-expected.txt
trunk/LayoutTests/fast/repaint/transform-repaint-descendants-expected.txt
trunk/LayoutTests/platform/chromium/fast/sub-pixel/
trunk/LayoutTests/platform/chromium/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png

[webkit-changes] [125836] trunk/LayoutTests

[leviw]

Title: [125836] trunk/LayoutTests








Revision 125836
Author le...@chromium.org
Date 2012-08-16 18:06:14 -0700 (Thu, 16 Aug 2012)


Log Message
Unreviewed gardening.

r125694 incorrectly updated mac expectations for the below test instead of
Chromium Mac. Moving the updated expectations to Chromium and reverting the
incorrect Mac expectations.

* platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt: Added.
* platform/mac/tables/mozilla/bugs/bug55527-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug55527-expected.txt


Added Paths

trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (125835 => 125836)

--- trunk/LayoutTests/ChangeLog	2012-08-17 01:03:08 UTC (rev 125835)
+++ trunk/LayoutTests/ChangeLog	2012-08-17 01:06:14 UTC (rev 125836)
@@ -1,3 +1,14 @@
+2012-08-16  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening.
+
+r125694 incorrectly updated mac expectations for the below test instead of
+Chromium Mac. Moving the updated expectations to Chromium and reverting the
+incorrect Mac expectations.
+
+* platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt: Added.
+* platform/mac/tables/mozilla/bugs/bug55527-expected.txt:
+
 2012-08-16  Adrienne Walker  e...@google.com
 
 [chromium] Mark fast/forms/file/selected-files-from-history-state.html as failing


Added: trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt (0 => 125836)

--- trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt	2012-08-17 01:06:14 UTC (rev 125836)
@@ -0,0 +1,111 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x288
+  RenderBlock {HTML} at (0,0) size 800x288
+RenderBody {BODY} at (8,8) size 784x272 [bgcolor=#FF]
+  RenderTable {TABLE} at (0,0) size 176x272
+RenderTableSection {TBODY} at (0,0) size 176x272
+  RenderTableRow {TR} at (0,0) size 176x34
+RenderTableCell {TD} at (0,0) size 44x34 [border: (1px solid #00)] [r=0 c=0 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+RenderTableCell {TD} at (44,0) size 44x34 [border: (1px solid #00)] [r=0 c=1 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+RenderTableCell {TD} at (88,0) size 44x34 [border: (1px solid #00)] [r=0 c=2 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+RenderTableCell {TD} at (132,0) size 44x34 [border: (1px solid #00)] [r=0 c=3 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+  RenderTableRow {TR} at (0,34) size 176x34
+RenderTableCell {TD} at (0,34) size 44x34 [border: (1px solid #00)] [r=1 c=0 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+RenderTableCell {TD} at (44,34) size 44x34 [border: (1px solid #00)] [r=1 c=1 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+RenderTableCell {TD} at (88,34) size 44x34 [border: (1px solid #00)] [r=1 c=2 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+RenderTableCell {TD} at (132,34) size 44x34 [border: (1px solid #00)] [r=1 c=3 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+  RenderTableRow {TR} at (0,68) size 176x34
+RenderTableCell {TD} at (0,68) size 44x34 [border: (1px solid #00)] [r=2 c=0 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+RenderTableCell {TD} at (44,68) size 44x34 [border: (1px solid #00)] [r=2 c=1 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+RenderTableCell {TD} at (88,68) size 44x34 [border: (1px solid #00)] [r=2 c=2 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+RenderTableCell {TD} at (132,68) size 44x34 [border: (1px solid #00)] [r=2 c=3 rs=1 cs=1]
+  RenderText {#text} at (8,8) size 27x18
+text run at (8,8) width 27: blah
+  RenderTableRow {TR} at (0,102) size 176x34
+RenderTableCell {TD} at (0,102) size 44x34 [border: (1px solid #00)] [r=3 c=0 

[webkit-changes] [125591] trunk

[leviw]

Title: [125591] trunk








Revision 125591
Author le...@chromium.org
Date 2012-08-14 12:45:49 -0700 (Tue, 14 Aug 2012)


Log Message
Accumulating LayoutUnits with floats for determining block preferred width can lead to wrapping
https://bugs.webkit.org/show_bug.cgi?id=93513

Reviewed by Eric Seidel.

Source/WebCore:

Sub-pixel values from floats are subject to small losses in precision when accumulated with
floating point values, as we do in RenderBlock. This patch adds a new method to FractionalLayoutUnit --
ceilToFloat -- which guarantees us a floating point value at least as big as our original LayoutUnit
value, and uses it along with ceiledLayoutUnit to avoid underprovisioning RenderBlock's preferred
widths due to lost precision.

Test: fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::ceilToFloat): Returns a float value the same or larger than the
FractionalLayoutUnit value.
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::epsilon): Now returns 0 when sub-pixel is disabled.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Adding a LayoutUnit::epsilon fudge factor
for fitting floats. This is probably necessary due to precision being lost elsewhere.
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths): Ensure no precision is lost due to conversion
when accumulating our min/max width with floats.

LayoutTests:

Ensuring floats with sub-pixel values don't unnecessarily wrap.

* fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats-expected.txt: Added.
* fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/FractionalLayoutUnit.h
trunk/Source/WebCore/rendering/RenderBlock.cpp


Added Paths

trunk/LayoutTests/fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats-expected.txt
trunk/LayoutTests/fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html




Diff

Modified: trunk/LayoutTests/ChangeLog (125590 => 125591)

--- trunk/LayoutTests/ChangeLog	2012-08-14 19:38:04 UTC (rev 125590)
+++ trunk/LayoutTests/ChangeLog	2012-08-14 19:45:49 UTC (rev 125591)
@@ -1,3 +1,15 @@
+2012-08-14  Levi Weintraub  le...@chromium.org
+
+Accumulating LayoutUnits with floats for determining block preferred width can lead to wrapping
+https://bugs.webkit.org/show_bug.cgi?id=93513
+
+Reviewed by Eric Seidel.
+
+Ensuring floats with sub-pixel values don't unnecessarily wrap.
+
+* fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats-expected.txt: Added.
+* fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html: Added.
+
 2012-08-14  Jer Noble  jer.no...@apple.com
 
 Fullscreen/normal volume sliders don't stay in sync


Added: trunk/LayoutTests/fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats-expected.txt (0 => 125591)

--- trunk/LayoutTests/fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats-expected.txt	2012-08-14 19:45:49 UTC (rev 125591)
@@ -0,0 +1,9 @@
+Support
+Member Center
+This tests that we don't cause an assertion failure on relayout of nested positioned elements. This test pass if we don't cause an assertion failure.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS document.getElementById(support).offsetTop is document.getElementById(membercenter).offsetTop
+


Added: trunk/LayoutTests/fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html (0 => 125591)

--- trunk/LayoutTests/fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html	2012-08-14 19:45:49 UTC (rev 125591)
@@ -0,0 +1,31 @@
+html
+head
+script src=""
+style type=text/css
+#relativeContainer { position:relative; width:980px; height:58px; margin:18px auto 0; z-index:999; font-size:12px; }
+#relativeContainer ul { position:absolute; right:200px; top:1px;  margin:0; }
+#relativeContainer ul li { display:inline; float:left; margin:0 0 0 2.8em; background-color: green;}
+#relativeContainer ul li a { display:block; color:#333; text-decoration:none; padding:.3em 0 .3em 5px; text-shadow: 0 1px 0 #fff; line-height:18px; }
+/style	
+/head
+body
+div id=relativeContainer
+  ul
+li id=supporta href=""
+li id=membercentera href="" Center/a/li
+ /ul
+/div
+p id=description/p
+div id=console/div
+script
+description(This tests that we don't cause an assertion failure on relayout of nested positioned elements. This test pass if we don't cause an assertion failure.);
+
+shouldBe('document.getElementById(support).offsetTop', 'document.getElementById(membercenter).offsetTop');
+
+if (window.testRunner)
+	

[webkit-changes] [125632] trunk/Source/WebCore

[leviw]

Title: [125632] trunk/Source/WebCore








Revision 125632
Author le...@chromium.org
Date 2012-08-14 18:39:20 -0700 (Tue, 14 Aug 2012)


Log Message
r125591 broke tests with SUBPIXEL_LAYOUT disabled
https://bugs.webkit.org/show_bug.cgi?id=94027

Reviewed by Eric Seidel.

The previous patch to fix block preferred widths for subpixel layout broke ports
without the flag enabled. This patch adds a static inline function --
adjustFloatForSubPixelLayout -- that truncates with sub-pixel layout disabled, and
ceil's to the nearest FractionalLayoutUnit when sub-pixel layout is enabled.

A block's max preferred width should be enough to layout the entire line without
wrapping. r125591 addressed a bug whereby converting floats to LayoutUnits with sub-
pixel layout enabled lost precision in certain cases, and could result in a line
being layed out to slightly over the max preferred width of the block.

This patch reverts the behavior when sub-pixel layout is disabled to truncating
sub-pixel values (such as those that originate in Length) when assigning them to
LayoutUnits, and ceiling the length of the entire line to the next largest integer.

Covered by existing tests.

* rendering/RenderBlock.cpp:
(WebCore):
(WebCore::adjustFloatForSubPixelLayout):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (125631 => 125632)

--- trunk/Source/WebCore/ChangeLog	2012-08-15 01:28:54 UTC (rev 125631)
+++ trunk/Source/WebCore/ChangeLog	2012-08-15 01:39:20 UTC (rev 125632)
@@ -1,3 +1,31 @@
+2012-08-14  Levi Weintraub  le...@chromium.org
+
+r125591 broke tests with SUBPIXEL_LAYOUT disabled
+https://bugs.webkit.org/show_bug.cgi?id=94027
+
+Reviewed by Eric Seidel.
+
+The previous patch to fix block preferred widths for subpixel layout broke ports
+without the flag enabled. This patch adds a static inline function --
+adjustFloatForSubPixelLayout -- that truncates with sub-pixel layout disabled, and
+ceil's to the nearest FractionalLayoutUnit when sub-pixel layout is enabled.
+
+A block's max preferred width should be enough to layout the entire line without
+wrapping. r125591 addressed a bug whereby converting floats to LayoutUnits with sub-
+pixel layout enabled lost precision in certain cases, and could result in a line
+being layed out to slightly over the max preferred width of the block.
+
+This patch reverts the behavior when sub-pixel layout is disabled to truncating
+sub-pixel values (such as those that originate in Length) when assigning them to
+LayoutUnits, and ceiling the length of the entire line to the next largest integer.
+
+Covered by existing tests.
+
+* rendering/RenderBlock.cpp:
+(WebCore):
+(WebCore::adjustFloatForSubPixelLayout):
+(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
+
 2012-08-14  Chris Evans  cev...@google.com
 
 Handle the XPath / (root) operator correctly for nodes that aren't attached to the document.


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (125631 => 125632)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2012-08-15 01:28:54 UTC (rev 125631)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2012-08-15 01:39:20 UTC (rev 125632)
@@ -5664,6 +5664,25 @@
 preferredWidth = max(snappedResult, preferredWidth);
 }
 
+// With sub-pixel enabled: When converting between floating point and LayoutUnits
+// we risk losing precision with each conversion. When this occurs while
+// accumulating our preferred widths, we can wind up with a line width that's
+// larger than our maxPreferredWidth due to pure float accumulation.
+//
+// With sub-pixel disabled: values from Lengths or the render tree aren't subject
+// to the same loss of precision, as they're always truncated and stored as
+// integers. We mirror that behavior here to prevent over-allocating our preferred
+// width.
+static inline LayoutUnit adjustFloatForSubPixelLayout(float value)
+{
+#if ENABLE(SUBPIXEL_LAYOUT)
+return ceiledLayoutUnit(value);
+#else
+return static_castint(value);
+#endif
+}
+
+
 void RenderBlock::computeInlinePreferredLogicalWidths()
 {
 float inlineMax = 0;
@@ -5753,9 +5772,9 @@
 Length startMargin = childStyle-marginStart();
 Length endMargin = childStyle-marginEnd();
 if (startMargin.isFixed())
-margins += ceiledLayoutUnit(startMargin.value());
+margins += adjustFloatForSubPixelLayout(startMargin.value());
 if (endMargin.isFixed())
-margins += ceiledLayoutUnit(endMargin.value());
+margins += adjustFloatForSubPixelLayout(endMargin.value());
 childMin += 

[webkit-changes] [125351] trunk

[leviw]

Title: [125351] trunk








Revision 125351
Author le...@chromium.org
Date 2012-08-11 03:44:53 -0700 (Sat, 11 Aug 2012)


Log Message
Source/WebCore: Track block's positioned objects like percent-height descendants
https://bugs.webkit.org/show_bug.cgi?id=89848

Reviewed by Abhishek Arya.

The previous method for tracking a RenderBlock's out-of-flow positioned descendants was error prone,
subject to becoming inconsistent, and in the case of removePositionedObjects, inefficient. This patch
extracts the algorithm used for percent height descendants and re-uses it for positioned objects. This same
method could further be re-used for floats.

This change removes the m_positionedObjects pointer, which brings RenderBlock's size down (yay!).

Test: fast/block/positioning/relayout-nested-positioned-elements-crash-2.html

* rendering/RenderBlock.cpp:
(SameSizeAsRenderBlock):
(WebCore):
(WebCore::removeBlockFromDescendantAndContainerMaps):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromPositionedObjects):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markPositionedObjectsForLayout):
(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertIntoTrackedRendererMaps):
(WebCore::RenderBlock::removeFromTrackedRendererMaps):
(WebCore::RenderBlock::positionedObjects):
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
(WebCore::RenderBlock::removePositionedObjects):
(WebCore::RenderBlock::addPercentHeightDescendant):
(WebCore::RenderBlock::removePercentHeightDescendant):
(WebCore::RenderBlock::percentHeightDescendants):
(WebCore::RenderBlock::checkPositionedObjectsNeedLayout):
* rendering/RenderBlock.h:
(WebCore):
(RenderBlock):
(WebCore::RenderBlock::hasPositionedObjects):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildTo): Changing the fixme to reflect the assumption that the caller
has taken care of updating the positioned renderer maps is a decision not a bug. The ASSERT should help
assure this.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderView.cpp:
(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):

LayoutTests: Track block's positioned objects like percent-height children
https://bugs.webkit.org/show_bug.cgi?id=89848

Reviewed by Abhishek Arya.

Adding another test to confirm that RenderBlock's positioned children lists don't become
inconsistent.

* fast/block/positioning/relayout-nested-positioned-elements-crash-2-expected.txt: Added.
* fast/block/positioning/relayout-nested-positioned-elements-crash-2.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderTableSection.cpp
trunk/Source/WebCore/rendering/RenderView.cpp


Added Paths

trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash-2-expected.txt
trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash-2.html




Diff

Modified: trunk/LayoutTests/ChangeLog (125350 => 125351)

--- trunk/LayoutTests/ChangeLog	2012-08-11 09:37:22 UTC (rev 125350)
+++ trunk/LayoutTests/ChangeLog	2012-08-11 10:44:53 UTC (rev 125351)
@@ -1,3 +1,16 @@
+2012-08-11  Levi Weintraub  le...@chromium.org
+
+Track block's positioned objects like percent-height children
+https://bugs.webkit.org/show_bug.cgi?id=89848
+
+Reviewed by Abhishek Arya.
+
+Adding another test to confirm that RenderBlock's positioned children lists don't become
+inconsistent.
+
+* fast/block/positioning/relayout-nested-positioned-elements-crash-2-expected.txt: Added.
+* fast/block/positioning/relayout-nested-positioned-elements-crash-2.html: Added.
+
 2012-08-10  Arko Saha  a...@motorola.com
 
 Microdata: item with itemprop attribute should not include the item itself in the HTMLPropertiesCollection.


Added: trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash-2-expected.txt (0 => 125351)

--- trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash-2-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash-2-expected.txt	2012-08-11 10:44:53 UTC (rev 125351)
@@ -0,0 +1,4 @@
+Tests that lists in the rendering tree that track positioned objects are kept properly up-to-date through re-layout. 
+PASS. WebKit didn't crash.
+
+


Added: trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash-2.html (0 => 125351)

--- 

[webkit-changes] [124662] trunk/Source/WebCore

[leviw]

Title: [124662] trunk/Source/WebCore








Revision 124662
Author le...@chromium.org
Date 2012-08-03 15:23:42 -0700 (Fri, 03 Aug 2012)


Log Message
Switch mapLocalToContainer to use a flag instead of boolean parameters
https://bugs.webkit.org/show_bug.cgi?id=92927

Reviewed by Dirk Schulze.

Changing mapLocalToContainer to use a uint flag to set the mode of operation. This removes
simplifies the contract, removes boolean arguments and paves the way for an additional mode
for sub-pixel layout support. See https://bugs.webkit.org/show_bug.cgi?id=89238 for the
sub-pixel use case. Other than the new MapLocalToContainerMode enum and MapLocalToContainerFlags
typedef, this change is purely mechanical.

No new tests as this doesn't change current behavior.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToAbsolute):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::mapLocalToContainer):
* rendering/RenderInline.h:
(RenderInline):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::localToAbsolute):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):
* rendering/RenderObject.h:
(RenderObject): Adding the MapLocalToContainerMode enum and MapLocalToContainerFlags unsigned
int, and removing the old ApplyContainerFlipOrNot enum.
* rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
* rendering/RenderView.h:
(RenderView):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::mapLocalToContainer):
* rendering/svg/RenderSVGForeignObject.h:
(RenderSVGForeignObject):
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::mapLocalToContainer):
* rendering/svg/RenderSVGInline.h:
(RenderSVGInline):
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::mapLocalToContainer):
* rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::mapLocalToContainer):
* rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::mapLocalToContainer):
* rendering/svg/RenderSVGText.h:
(RenderSVGText):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::mapLocalToContainer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderGeometryMap.cpp
trunk/Source/WebCore/rendering/RenderInline.cpp
trunk/Source/WebCore/rendering/RenderInline.h
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h
trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGInline.h
trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.h
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h
trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGText.h
trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (124661 => 124662)

--- trunk/Source/WebCore/ChangeLog	2012-08-03 22:06:54 UTC (rev 124661)
+++ trunk/Source/WebCore/ChangeLog	2012-08-03 22:23:42 UTC (rev 124662)
@@ -1,3 +1,65 @@
+2012-08-03  Levi Weintraub  le...@chromium.org
+
+Switch mapLocalToContainer to use a flag instead of boolean parameters
+https://bugs.webkit.org/show_bug.cgi?id=92927
+
+Reviewed by Dirk Schulze.
+
+Changing mapLocalToContainer to use a uint flag to set the mode of operation. This removes
+simplifies the contract, removes boolean arguments and paves the way for an additional mode
+for sub-pixel layout support. See https://bugs.webkit.org/show_bug.cgi?id=89238 for the
+sub-pixel use case. Other than the new MapLocalToContainerMode enum and MapLocalToContainerFlags
+typedef, this change is purely mechanical.
+
+No new tests as this doesn't change current behavior.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::selectionGapRectsForRepaint):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::mapLocalToContainer):
+* rendering/RenderBox.h:
+(RenderBox):
+* rendering/RenderGeometryMap.cpp:
+(WebCore::RenderGeometryMap::mapToAbsolute):
+* rendering/RenderInline.cpp:
+

[webkit-changes] [119893] trunk

[leviw]

Title: [119893] trunk








Revision 119893
Author le...@chromium.org
Date 2012-06-08 22:44:08 -0700 (Fri, 08 Jun 2012)


Log Message
RenderLayer::paintChildLayerIntoColumns doesn't properly pixel snap
https://bugs.webkit.org/show_bug.cgi?id=88554

Reviewed by Darin Adler.

Source/WebCore:

Column handling code in RenderLayer and RenderBlock was improperly clipping and translating
using floats derived from FractionalLayoutUnits without pixel snapping. RenderLayer also
improperly stored render tree offsets in ints instead of LayoutUnits. This corrects this
issue.

Test: fast/sub-pixel/column-clipping.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnContents):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintChildLayerIntoColumns):

LayoutTests:

* fast/sub-pixel/column-clipping-expected.html: Added.
* fast/sub-pixel/column-clipping.html: Added.
* platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-mac/fast/borders/border-antialiasing-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/sub-pixel/column-clipping-expected.html
trunk/LayoutTests/fast/sub-pixel/column-clipping.html




Diff

Modified: trunk/LayoutTests/ChangeLog (119892 => 119893)

--- trunk/LayoutTests/ChangeLog	2012-06-09 05:02:41 UTC (rev 119892)
+++ trunk/LayoutTests/ChangeLog	2012-06-09 05:44:08 UTC (rev 119893)
@@ -1,3 +1,18 @@
+2012-06-08  Levi Weintraub  le...@chromium.org
+
+RenderLayer::paintChildLayerIntoColumns doesn't properly pixel snap
+https://bugs.webkit.org/show_bug.cgi?id=88554
+
+Reviewed by Darin Adler.
+
+* fast/sub-pixel/column-clipping-expected.html: Added.
+* fast/sub-pixel/column-clipping.html: Added.
+* platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
+* platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
+* platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
+* platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
+* platform/chromium/TestExpectations:
+
 2012-06-08  Ryosuke Niwa  rn...@webkit.org
 
 Remove FAIL test expectations from EFL, Mac, and Qt ports' test expectations.


Added: trunk/LayoutTests/fast/sub-pixel/column-clipping-expected.html (0 => 119893)

--- trunk/LayoutTests/fast/sub-pixel/column-clipping-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/column-clipping-expected.html	2012-06-09 05:44:08 UTC (rev 119893)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+html
+style
+.box {
+	width: 10px;
+	height: 10px;
+	background-color: green;
+	border: 1px solid black;
+	position: absolute;
+	top: 0px;
+	left: 0px;
+}
+.shifted {
+	left: 33.5px;
+}
+/style
+body
+div class=box/div
+div class=box shifted/div
+/div
+/body


Added: trunk/LayoutTests/fast/sub-pixel/column-clipping.html (0 => 119893)

--- trunk/LayoutTests/fast/sub-pixel/column-clipping.html	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/column-clipping.html	2012-06-09 05:44:08 UTC (rev 119893)
@@ -0,0 +1,24 @@
+!DOCTYPE html
+html
+style
+body  div {
+	-webkit-column-count: 2;
+	width: 51px;
+	position: absolute;
+	left: 0px;
+	top: 0px;
+}
+div  div {
+	width: 10px;
+	height: 10px;
+	background-color: green;
+	border: 1px solid black;
+	position: relative;
+}
+/style
+body
+div
+	div/div
+	div/div
+/div
+/body


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (119892 => 119893)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-06-09 05:02:41 UTC (rev 119892)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-06-09 05:44:08 UTC (rev 119893)
@@ -3770,6 +3770,10 @@
 // Needs rebaseline after the bots cycle.
 BUG_OJAN WIN MAC : tables/mozilla/bugs/bug131020.html = PASS IMAGE IMAGE+TEXT
 BUGLEVIW LEOPARD LION WIN LINUX : fast/sub-pixel/file-upload-control-at-fractional-offset.html = PASS FAIL MISSING
+BUGLEVIW LEOPARD LION WIN LINUX : fast/borders/border-antialiasing.html = PASS FAIL
+BUGLEVIW LEOPARD LION WIN LINUX : fast/multicol/nested-columns.html = PASS FAIL
+BUGLEVIW