from:"lforschler"

[webkit-changes] [238618] trunk/Tools

2018-11-28 Thread lforschler

Title: [238618] trunk/Tools








Revision 238618
Author lforsch...@apple.com
Date 2018-11-28 09:52:07 -0800 (Wed, 28 Nov 2018)


Log Message
Fix webkitbot hi command.
https://bugs.webkit.org/show_bug.cgi?id=192080

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi.execute):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py




Diff

Modified: trunk/Tools/ChangeLog (238617 => 238618)

--- trunk/Tools/ChangeLog	2018-11-28 17:51:49 UTC (rev 238617)
+++ trunk/Tools/ChangeLog	2018-11-28 17:52:07 UTC (rev 238618)
@@ -1,3 +1,13 @@
+2018-11-28  Lucas Forschler  
+
+Fix webkitbot hi command.
+https://bugs.webkit.org/show_bug.cgi?id=192080
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/tool/bot/irc_command.py:
+(Hi.execute):
+
 2018-11-28  Zalan Bujtas  
 
 [LFC][Quirk] Use non-collapsed vertical margin values when the container is stretched to the size of the ICB.


Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (238617 => 238618)

--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py	2018-11-28 17:51:49 UTC (rev 238617)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py	2018-11-28 17:52:07 UTC (rev 238618)
@@ -117,8 +117,9 @@
 def execute(self, nick, args, tool, sheriff):
 if len(args) and re.match(sheriff.name() + r'_*\s*!\s*', ' '.join(args)):
 return "%s: hi %s!" % (nick, nick)
-if sheriff.name() == 'WKR':  # For some unknown reason, WKR can't use tool.bugs.quips().
-return "You're doing it wrong"
+bypass_quips = ['WKR', 'webkitbot']
+if sheriff.name() in bypass_quips:  # For some unknown reason, WKR/webkitbot can't use tool.bugs.quips().
+return "%s: hi %s!" % (nick, nick)
 quips = tool.bugs.quips()
 quips.append('"Only you can prevent forest fires." -- Smokey the Bear')
 return random.choice(quips)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237810] trunk/Tools

2018-11-05 Thread lforschler

Title: [237810] trunk/Tools








Revision 237810
Author lforsch...@apple.com
Date 2018-11-05 09:47:42 -0800 (Mon, 05 Nov 2018)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=191268
Remove unused bots.

rubber-stamped by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (237809 => 237810)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-11-05 17:43:40 UTC (rev 237809)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-11-05 17:47:42 UTC (rev 237810)
@@ -60,12 +60,6 @@
 { "name": "bot653", "platform": "ios-simulator-12" },
 { "name": "bot654", "platform": "ios-simulator-12" },
 
-{ "name": "bot516", "platform": "win" },
-{ "name": "bot514", "platform": "win" },
-{ "name": "bot507", "platform": "win" },
-{ "name": "bot504", "platform": "win" },
-{ "name": "bot511", "platform": "win" },
-{ "name": "bot501", "platform": "win" },
 { "name": "bot543", "platform": "win" },
 { "name": "bot544", "platform": "win" },
 { "name": "bot545", "platform": "win" },


Modified: trunk/Tools/ChangeLog (237809 => 237810)

--- trunk/Tools/ChangeLog	2018-11-05 17:43:40 UTC (rev 237809)
+++ trunk/Tools/ChangeLog	2018-11-05 17:47:42 UTC (rev 237810)
@@ -1,3 +1,14 @@
+2018-11-05  Lucas Forschler  
+
+https://bugs.webkit.org/show_bug.cgi?id=191268
+Remove unused bots.
+
+rubber-stamped by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
+(WebKitBuildbot):
+
 2018-11-05  Michael Catanzaro  
 
 [WPE][GTK] API test runner fails to respect default build type






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237755] trunk/Tools

2018-11-02 Thread lforschler

Title: [237755] trunk/Tools








Revision 237755
Author lforsch...@apple.com
Date 2018-11-02 15:35:49 -0700 (Fri, 02 Nov 2018)


Log Message
Add Windows 10 archive bots
https://bugs.webkit.org/show_bug.cgi?id=190964

This Change updates the Apple Windows Buildbot configuration.
- Add Windows 10 specific builders and testers for release and debug.
- Refactor Windows -> Windows 7.
- Remove Windows 7 Debug.

Reviewed by Aakash Jain.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (237754 => 237755)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-11-02 22:07:18 UTC (rev 237754)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-11-02 22:35:49 UTC (rev 237755)
@@ -66,6 +66,12 @@
 { "name": "bot504", "platform": "win" },
 { "name": "bot511", "platform": "win" },
 { "name": "bot501", "platform": "win" },
+{ "name": "bot543", "platform": "win" },
+{ "name": "bot544", "platform": "win" },
+{ "name": "bot545", "platform": "win" },
+{ "name": "bot546", "platform": "win" },
+{ "name": "bot547", "platform": "win" },
+{ "name": "bot548", "platform": "win" },
 
 { "name": "wincairo-wkl-release-build-01", "platform": "wincairo" },
 { "name": "wincairo-wkl-release-tests-01", "platform": "wincairo" },
@@ -261,28 +267,39 @@
   "slavenames": ["bot653", "bot654"]
 },
 {
-  "name": "Apple Win Release (Build)", "type": "Build", "builddir": "win-release",
-  "platform": "win", "configuration": "release", "architectures": ["i386"],
-  "triggers": ["win-release-tests"],
-  "slavenames": ["bot514"]
+  "name": "Apple Win 10 Release (Build)", "type": "Build", "builddir": "win10-release",
+  "platform": "win", "configuration": "release", "architectures": ["x86_64"],
+  "triggers": ["win10-release-tests"],
+  "slavenames": ["bot548"]
 },
 {
-  "name": "Apple Win 7 Release (Tests)", "type": "TestWebKit1", "builddir": "win-release-tests",
-  "platform": "win", "configuration": "release", "architectures": ["i386"],
-  "slavenames": ["bot511", "bot501"]
+  "name": "Apple Win 10 Debug (Build)", "type": "Build", "builddir": "win10-debug",
+  "platform": "win", "configuration": "debug", "architectures": ["x86_64"],
+  "triggers": ["win10-debug-tests"],
+  "slavenames": ["bot547"]
 },
 {
-  "name": "Apple Win Debug (Build)", "type": "Build", "builddir": "win-debug",
-  "platform": "win", "configuration": "debug", "architectures": ["i386"],
-  "triggers": ["win-debug-tests"],
-  "slavenames": ["bot516"]
+  "name": "Apple Win 10 Release (Tests)", "type": "TestWebKit1", "builddir": "win10-release-tests",
+  "platform": "win", "configuration": "release", "architectures": ["x86_64"],
+  "slavenames": ["bot546"]
 },
 {
-  "name": "Apple Win 7 Debug (Tests)", "type": "TestWebKit1", "builddir": "win-debug-tests",
-  "platform": "win", "configuration": "debug", "architectures": ["i386"],
-  "slavenames": ["bot507", "bot504"]
+  "name": "Apple Win 10 Debug (Tests)", "type": "TestWebKit1", "builddir": "win10-debug-tests",
+  "platform": "win", "configuration": "debug", "architectures": ["x86_64"],
+  "slavenames": ["bot545"]
 },
 {
+  "name": "Apple Win 7 Release (Build)", "type": "Build", "builddir": "win7-release-i386",
+  "platform": "win", "configuration": "release", "architectures": ["i386"],
+  "triggers": ["win7-release-tests"],
+  "slavenames": ["bot544"]
+},
+{
+  "name": "Apple Win 7 Release (Tests)", "type": "TestWebKit1", "builddir": "win7-release-tests",
+  "platform": "win", "configuration": "release", "architectures": ["i386"],
+  "slavenames": ["bot543"]
+},
+{

[webkit-changes] [235339] trunk/Tools/ChangeLog

2018-08-26 Thread lforschler

Title: [235339] trunk/Tools/ChangeLog








Revision 235339
Author lforsch...@apple.com
Date 2018-08-26 17:48:43 -0700 (Sun, 26 Aug 2018)


Log Message
Open for business.

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (235338 => 235339)

--- trunk/Tools/ChangeLog	2018-08-24 23:33:30 UTC (rev 235338)
+++ trunk/Tools/ChangeLog	2018-08-27 00:48:43 UTC (rev 235339)
@@ -1,3 +1,7 @@
+2018-08-26  Lucas Forschler  
+
+Open svn.webkit.org for commits.
+
 2018-08-24  Myles C. Maxfield  
 
 Unreviewed test fix after r235249






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234663] trunk/Tools

2018-08-07 Thread lforschler

Title: [234663] trunk/Tools








Revision 234663
Author lforsch...@apple.com
Date 2018-08-07 11:46:03 -0700 (Tue, 07 Aug 2018)


Log Message
If there's a Radar in the ChangeLog, webkit-patch upload/create-bug should put the radar in the bug and set InRadar
https://bugs.webkit.org/show_bug.cgi?id=188235

Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.

* Scripts/webkitpy/common/checkout/changelog.py: 
(ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
* Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the new _parse_radar_id functionality
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.add_keyword_to_bug): Add logic to add keywords using the changeform
* Scripts/webkitpy/tool/commands/upload.py:
(Upload): Teach the upload step how to add radar information when creating a new bug.
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/addradar.py: Added.
(AddRadar):
(AddRadar.run): Contains the logic to add the radar information to bugzilla.
* Scripts/webkitpy/tool/steps/createbug.py:
(CreateBug.run): set a "created_new_bug" state when creating a new bugzilla bug.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py
trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
trunk/Tools/Scripts/webkitpy/tool/commands/upload.py
trunk/Tools/Scripts/webkitpy/tool/steps/__init__.py
trunk/Tools/Scripts/webkitpy/tool/steps/createbug.py


Added Paths

trunk/Tools/Scripts/webkitpy/tool/steps/addradar.py




Diff

Modified: trunk/Tools/ChangeLog (234662 => 234663)

--- trunk/Tools/ChangeLog	2018-08-07 18:33:25 UTC (rev 234662)
+++ trunk/Tools/ChangeLog	2018-08-07 18:46:03 UTC (rev 234663)
@@ -1,3 +1,24 @@
+2018-08-07  Lucas Forschler  
+
+If there's a Radar in the ChangeLog, webkit-patch upload/create-bug should put the radar in the bug and set InRadar
+https://bugs.webkit.org/show_bug.cgi?id=188235
+
+Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.
+
+* Scripts/webkitpy/common/checkout/changelog.py: 
+(ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
+* Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the new _parse_radar_id functionality
+* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+(Bugzilla.add_keyword_to_bug): Add logic to add keywords using the changeform
+* Scripts/webkitpy/tool/commands/upload.py:
+(Upload): Teach the upload step how to add radar information when creating a new bug.
+* Scripts/webkitpy/tool/steps/__init__.py:
+* Scripts/webkitpy/tool/steps/addradar.py: Added.
+(AddRadar):
+(AddRadar.run): Contains the logic to add the radar information to bugzilla.
+* Scripts/webkitpy/tool/steps/createbug.py:
+(CreateBug.run): set a "created_new_bug" state when creating a new bugzilla bug.
+
 2018-08-07  Wenson Hsieh  
 
 Post-review feedback after r234614.


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py (234662 => 234663)

--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py	2018-08-07 18:33:25 UTC (rev 234662)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py	2018-08-07 18:46:03 UTC (rev 234663)
@@ -66,6 +66,8 @@
 # e.g. (ChangeLogEntry.touched_functions): Added.
 touched_functions_regexp = r'^\s*\((?P[^)]*)\):'
 
+radar_id_regexp = r'^\s*(-?\d{7,})>?'
+
 # e.g. Reviewed by Darin Adler.
 # (Discard everything after the first period to match more invalid lines.)
 reviewed_by_regexp = r'^\s*((\w+\s+)+and\s+)?(Review|Rubber(\s*|-)stamp)(s|ed)?\s+([a-z]+\s+)*?by\s+(?P.*?)[\.,]?\s*$'
@@ -112,6 +114,19 @@
 self._parse_entry()
 
 @classmethod
+def _parse_radar_id(cls, text):
+if not text:
+return None
+match = re.search(ChangeLogEntry.radar_id_regexp, text, re.MULTILINE | re.IGNORECASE)
+if not match:
+return None
+radar_id = int(match.group('radar_id'))
+if radar_id < 0:
+return None
+
+return radar_id
+
+@classmethod
 def _parse_reviewer_text(cls, text):
 match = re.search(ChangeLogEntry.reviewed_by_regexp, text, re.MULTILINE | re.IGNORECASE)
 if not match:


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py (234662 => 234663)

--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py	2018-08-07 18:33:25 UTC (rev 234662)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py	2018-08-07 18:46:03 UTC (rev 234663)
@@ -407,6 +407,116 @@
 def _contributors(self, names):
 return [CommitterList().contributor_by_name(name) for name in names]
 
+def _assert_fuzzy_radar_match(self, radar_text, expected_radar_id):
+parsed_radar_id = ChangeLogEntry._parse_radar_id(radar_text)
+self

[webkit-changes] [234016] trunk/Tools

2018-07-19 Thread lforschler

Title: [234016] trunk/Tools








Revision 234016
Author lforsch...@apple.com
Date 2018-07-19 16:37:49 -0700 (Thu, 19 Jul 2018)


Log Message
Teach the AWS Lambda to use the [minified]-platforms database

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py
trunk/Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py




Diff

Modified: trunk/Tools/ChangeLog (234015 => 234016)

--- trunk/Tools/ChangeLog	2018-07-19 23:30:11 UTC (rev 234015)
+++ trunk/Tools/ChangeLog	2018-07-19 23:37:49 UTC (rev 234016)
@@ -1,3 +1,15 @@
+2018-07-19  Lucas Forschler  
+
+Teach the AWS Lambda to use the [minified]-platforms database
+https://bugs.webkit.org/show_bug.cgi?id=187817
+
+Reviewed by David Kilzer.
+
+* WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:
+(lambda_handler): Add support for the platforms.webkit.org database
+* WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:
+(lambda_handler): Add support for the minified-platforms.webkit.org database
+
 2018-07-19  Dean Jackson  
 
 Provide an lldb type summary for WebCore::Color


Modified: trunk/Tools/WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py (234015 => 234016)

--- trunk/Tools/WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py	2018-07-19 23:30:11 UTC (rev 234015)
+++ trunk/Tools/WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py	2018-07-19 23:37:49 UTC (rev 234016)
@@ -5,7 +5,8 @@
 
 DAYS_TO_KEEP = 14
 EPOCH_DAY = 86400
-TABLE_NAME = 'archives.webkit.org'
+ARCHIVE_TABLE_NAME = 'archives.webkit.org'
+PLATFORM_TABLE_NAME = 'platforms.webkit.org'
 URL_PREFIX = 'https://s3-us-west-2.amazonaws.com'
 
 dynamodb_client = boto3.client('dynamodb')
@@ -40,7 +41,16 @@
 'expirationTime': {'N': expiration_time},
 }
 print('Item: {}'.format(item))
-dynamodb_client.put_item(TableName=TABLE_NAME, Item=item)
+dynamodb_client.put_item(TableName=ARCHIVE_TABLE_NAME, Item=item)
+
+platform = {
+'identifier': {'S': identifier},
+'creationTime': {'N': creation_time},
+'expirationTime': {'N': expiration_time},
+}
+print('Platform: {}'.format(platform))
+dynamodb_client.put_item(TableName=PLATFORM_TABLE_NAME, Item=platform)
+
 return s3_url
 except Exception as e:
 print(e)


Modified: trunk/Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py (234015 => 234016)

--- trunk/Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py	2018-07-19 23:30:11 UTC (rev 234015)
+++ trunk/Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py	2018-07-19 23:37:49 UTC (rev 234016)
@@ -5,7 +5,8 @@
 
 DAYS_TO_KEEP = 910
 EPOCH_DAY = 86400
-TABLE_NAME = 'minified-archives.webkit.org'
+ARCHIVE_TABLE_NAME = 'minified-archives.webkit.org'
+PLATFORM_TABLE_NAME = 'minified-platforms.webkit.org'
 URL_PREFIX = 'https://s3-us-west-2.amazonaws.com'
 
 dynamodb_client = boto3.client('dynamodb')
@@ -40,7 +41,16 @@
 'expirationTime': {'N': expiration_time},
 }
 print('Item: {}'.format(item))
-dynamodb_client.put_item(TableName=TABLE_NAME, Item=item)
+dynamodb_client.put_item(TableName=ARCHIVE_TABLE_NAME, Item=item)
+
+platform = {
+'identifier': {'S': identifier},
+'creationTime': {'N': creation_time},
+'expirationTime': {'N': expiration_time},
+}
+print('Item: {}'.format(platform))
+dynamodb_client.put_item(TableName=PLATFORM_TABLE_NAME, Item=platform)
+
 return s3_url
 except Exception as e:
 print(e)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [233373] trunk/Tools

2018-06-29 Thread lforschler

Title: [233373] trunk/Tools








Revision 233373
Author lforsch...@apple.com
Date 2018-06-29 15:51:59 -0700 (Fri, 29 Jun 2018)


Log Message
Teach bisect-builds to retrieve supported platforms from the rest api.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/bisect-builds




Diff

Modified: trunk/Tools/ChangeLog (233372 => 233373)

--- trunk/Tools/ChangeLog	2018-06-29 21:17:35 UTC (rev 233372)
+++ trunk/Tools/ChangeLog	2018-06-29 22:51:59 UTC (rev 233373)
@@ -1,3 +1,23 @@
+2018-06-29  Lucas Forschler  
+
+Teach bisect-builds to retrieve supported platforms from the rest api.
+https://bugs.webkit.org/show_bug.cgi?id=187195
+
+This patch updates bisect-builds to use v2_2 of the API. v2_2 adds two api endpoints: /platforms, and /minified-platforms.
+These endpoints scan a dynamoDB database, returning the identifier key for all available platforms.
+The identifier keys are in the format: platform-architecture-configuration.
+
+Reviewed by Aakash Jain.
+
+* Scripts/bisect-builds:
+(get_api_archive_url): refactored from get_api_url.
+(get_platforms): helper function to retrieve from the platforms api.
+(minified_platforms): returns a list of minified platforms currently in the database
+(unminified_platforms): returns a list of unminified platforms currently in the database
+(is_supported_platform): checks if the platform-architecture-configuration combo is supported
+(fetch_revision_list): refactored to use get_api_archive_url
+(get_api_url): Deleted/refactored to get_api_archive_url.
+
 2018-06-29  Keith Miller  
 
 run-jsc should print when jsc exits with non-zero status


Modified: trunk/Tools/Scripts/bisect-builds (233372 => 233373)

--- trunk/Tools/Scripts/bisect-builds	2018-06-29 21:17:35 UTC (rev 233372)
+++ trunk/Tools/Scripts/bisect-builds	2018-06-29 22:51:59 UTC (rev 233373)
@@ -37,10 +37,13 @@
 import tempfile
 import urllib2
 import urlparse
+from webkitpy.common.memoized import memoized
 
-REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2_1/'
-REST_API_ENDPOINT = 'archives/'
-REST_API_MINIFIED_ENDPOINT = 'minified-archives/'
+REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2_2/'
+REST_API_ARCHIVE_ENDPOINT = 'archives/'
+REST_API_MINIFIED_ARCHIVE_ENDPOINT = 'minified-archives/'
+REST_API_PLATFORM_ENDPOINT = 'platforms'
+REST_API_MINIFIED_PLATFORM_ENDPOINT = 'minified-platforms'
 
 
 def bisect_builds(revision_list, start_index, end_index, options):
@@ -62,7 +65,7 @@
 
 
 def download_archive(options, revision):
-api_url = get_api_url(options)
+api_url = get_api_archive_url(options)
 s3_url = get_s3_location_for_revision(api_url, revision)
 print('Archive URL: {}'.format(s3_url))
 command = ['python', '../BuildSlaveSupport/download-built-product', '--{}'.format(options.configuration), '--platform', options.platform, s3_url]
@@ -93,11 +96,11 @@
 #  end bisect helpers 
 
 
-def get_api_url(options, LastEvaluatedKey=None):
+def get_api_archive_url(options, LastEvaluatedKey=None):
 if options.full:
-base_url = urlparse.urljoin(REST_API_URL, REST_API_ENDPOINT)
+base_url = urlparse.urljoin(REST_API_URL, REST_API_ARCHIVE_ENDPOINT)
 else:
-base_url = urlparse.urljoin(REST_API_URL, REST_API_MINIFIED_ENDPOINT)
+base_url = urlparse.urljoin(REST_API_URL, REST_API_MINIFIED_ARCHIVE_ENDPOINT)
 
 api_url = urlparse.urljoin(base_url, '-'.join([options.platform, options.architecture, options.configuration]))
 if LastEvaluatedKey:
@@ -192,27 +195,36 @@
 if command:
 subprocess.call(command)
 return prompt_did_reproduce()
+
+
+def get_platforms(endpoint):
+platform_url = urlparse.urljoin(REST_API_URL, endpoint)
+r = urllib2.urlopen(platform_url)
+data = ""
+platforms = []
+for platform in data.get('Items'):
+platforms.append(str(platform['identifier']['S']))
 
-
+return platforms
+ 
+@memoized
 def minified_platforms():
-# FIXME: query this dynamically from API
-return  ['mac-elcapitan', 'mac-sierra', 'mac-highsierra', 'ios-simulator-10', 'ios-simulator-11']
-
-
+return get_platforms(REST_API_MINIFIED_PLATFORM_ENDPOINT)
+ 
+@memoized
 def unminified_platforms():
-# FIXME: query this dynamically from API
-return ['gtk', 'ios-simulator-10', 'ios-simulator-11', 'mac-elcapitan', 'mac-sierra', 'mac-highsierra', 'win', 'wpe']
-
-
+return get_platforms(REST_API_PLATFORM_ENDPOINT)
+ 
 def is_supported_platform(options):
+platform = '-'.join([options.platform, options.architecture, options.configuration])
 if options.full:
-return options.platform in unminified_platforms()
-return options.platform in minified_platforms()
+return platform in unminified_platforms()
+return platform in minified_platforms()
 
 
 def validate_options(options):
 if not i

[webkit-changes] [233322] trunk/Tools

2018-06-28 Thread lforschler

Title: [233322] trunk/Tools








Revision 233322
Author lforsch...@apple.com
Date 2018-06-28 13:58:20 -0700 (Thu, 28 Jun 2018)


Log Message
Teach Windows EWS bots to use WEBKIT_API_KEY.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/EWSTools/start-queue-win.sh




Diff

Modified: trunk/Tools/ChangeLog (233321 => 233322)

--- trunk/Tools/ChangeLog	2018-06-28 20:52:06 UTC (rev 233321)
+++ trunk/Tools/ChangeLog	2018-06-28 20:58:20 UTC (rev 233322)
@@ -1,3 +1,12 @@
+2018-06-28  Lucas Forschler  
+
+Add Windows support for WEBKIT_API_KEY.
+https://bugs.webkit.org/show_bug.cgi?id=187155
+
+Reviewed by Daniel Bates.
+
+* EWSTools/start-queue-win.sh:
+
 2018-06-28  Aakash Jain  
 
 [ews-build] Add support for WebKitPy-Tests-EWS


Modified: trunk/Tools/EWSTools/start-queue-win.sh (233321 => 233322)

--- trunk/Tools/EWSTools/start-queue-win.sh	2018-06-28 20:52:06 UTC (rev 233321)
+++ trunk/Tools/EWSTools/start-queue-win.sh	2018-06-28 20:58:20 UTC (rev 233322)
@@ -1,7 +1,7 @@
 #!/bin/sh
 
 if [[ $# -lt 4 ]]; then
-echo "Usage: start-queue-win.sh WEBKIT_BUGZILLA_USERNAME WEBKIT_BUGZILLA_PASSWORD BOT_ID RESET_AFTER_ITERATION"
+echo "Usage: start-queue-win.sh WEBKIT_BUGZILLA_USERNAME WEBKIT_BUGZILLA_PASSWORD BOT_ID RESET_AFTER_ITERATION WEBKIT_STATUS_API_KEY"
 exit 1
 fi
 
@@ -9,6 +9,7 @@
 export WEBKIT_BUGZILLA_PASSWORD=$2
 export BOT_ID=$3
 export RESET_AFTER_ITERATION=$4
+export WEBKIT_STATUS_API_KEY=$5
 
 function error_handler()
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [233057] trunk/Tools

2018-06-21 Thread lforschler

Title: [233057] trunk/Tools








Revision 233057
Author lforsch...@apple.com
Date 2018-06-21 13:58:52 -0700 (Thu, 21 Jun 2018)


Log Message
Fix for https://bugs.webkit.org/show_bug.cgi?id=185790

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/bisect-builds




Diff

Modified: trunk/Tools/ChangeLog (233056 => 233057)

--- trunk/Tools/ChangeLog	2018-06-21 20:54:32 UTC (rev 233056)
+++ trunk/Tools/ChangeLog	2018-06-21 20:58:52 UTC (rev 233057)
@@ -1,3 +1,22 @@
+2018-06-21  Lucas Forschler  
+
+bisect-builds --list not showing all builds
+https://bugs.webkit.org/show_bug.cgi?id=185790
+
+The AWS Gateway API call into dynamoDB is limited to returning 1MB of query data. Our archive set has overgrown this limit,
+causing us to retrieve a truncated list of results. Fortunately, when this limit is reached, dynamoDB returns a 
+"LastEvaluatedKey", which can be used to continue the query in another request. 
+
+This patch teaches bisect-build to pass along this key when needed. The backend api was updated from v2 to v2_1 to support
+this new querystring option. Any existing code using v2 will not be affected.
+
+Reviewed by Aakash Jain.
+
+* Scripts/bisect-builds:
+(get_api_url): added optional LastEvaluatedKey argument, which will append the query string to the base api url.
+(fetch_revision_list): Added to allow a recursive call which will query until we retrieve every item requested.
+(main): teach how to use fetch_revision_list.
+
 2018-06-21  Keith Rollin  
 
 check-webkit-style should warn about exported inline functions


Modified: trunk/Tools/Scripts/bisect-builds (233056 => 233057)

--- trunk/Tools/Scripts/bisect-builds	2018-06-21 20:54:32 UTC (rev 233056)
+++ trunk/Tools/Scripts/bisect-builds	2018-06-21 20:58:52 UTC (rev 233057)
@@ -38,7 +38,7 @@
 import urllib2
 import urlparse
 
-REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2/'
+REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2_1/'
 REST_API_ENDPOINT = 'archives/'
 REST_API_MINIFIED_ENDPOINT = 'minified-archives/'
 
@@ -93,7 +93,7 @@
 #  end bisect helpers 
 
 
-def get_api_url(options):
+def get_api_url(options, LastEvaluatedKey=None):
 if options.full:
 base_url = urlparse.urljoin(REST_API_URL, REST_API_ENDPOINT)
 else:
@@ -100,6 +100,10 @@
 base_url = urlparse.urljoin(REST_API_URL, REST_API_MINIFIED_ENDPOINT)
 
 api_url = urlparse.urljoin(base_url, '-'.join([options.platform, options.architecture, options.configuration]))
+if LastEvaluatedKey:
+querystring = urllib2.quote(json.dumps(LastEvaluatedKey))
+api_url += '?ExclusiveStartKey=' + querystring
+
 return api_url
 
 
@@ -223,15 +227,22 @@
 print(revision_list)
 exit(0)
 
-def main(options):
-validate_options(options)
-
-url = ""
+def fetch_revision_list(options, LastEvaluatedKey=None):
+url = "" LastEvaluatedKey)
 r = urllib2.urlopen(url)
 data = ""
-
 revision_list = get_sorted_revisions(data)
 
+if 'LastEvaluatedKey' in data['revisions']:
+LastEvaluatedKey = data['revisions']['LastEvaluatedKey']
+revision_list += fetch_revision_list(options, LastEvaluatedKey)
+
+return revision_list
+
+def main(options):
+validate_options(options)
+revision_list = fetch_revision_list(options)
+
 if options.list:
 print_list_and_exit(revision_list, options)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226411] trunk/Tools

2018-01-04 Thread lforschler

Title: [226411] trunk/Tools








Revision 226411
Author lforsch...@apple.com
Date 2018-01-04 10:58:56 -0800 (Thu, 04 Jan 2018)


Log Message
 Change proxy server setting on master config to reach s3 servers

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (226410 => 226411)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py	2018-01-04 18:49:07 UTC (rev 226410)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py	2018-01-04 18:58:56 UTC (rev 226411)
@@ -32,7 +32,7 @@
 import cStringIO
 import urllib
 
-APPLE_WEBKIT_AWS_PROXY = "http://54.190.50.182:873"
+APPLE_WEBKIT_AWS_PROXY = "http://proxy01.webkit.org:3128"
 S3URL = "https://s3-us-west-2.amazonaws.com/"
 WithProperties = properties.WithProperties
 


Modified: trunk/Tools/ChangeLog (226410 => 226411)

--- trunk/Tools/ChangeLog	2018-01-04 18:49:07 UTC (rev 226410)
+++ trunk/Tools/ChangeLog	2018-01-04 18:58:56 UTC (rev 226411)
@@ -1,3 +1,11 @@
+2018-01-04  Lucas Forschler  
+
+ Change proxy server setting on master config to reach s3 servers
+
+Reviewed by Ling Ho.
+
+* BuildSlaveSupport/build.webkit.org-config/steps.py:
+
 2018-01-03  Wenson Hsieh  
 
 [Attachment Support] Create attachment elements when dropping files on iOS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225556] branches/buildbot-0.9/

2017-12-05 Thread lforschler

Title: [225556] branches/buildbot-0.9/








Revision 225556
Author lforsch...@apple.com
Date 2017-12-05 16:55:23 -0800 (Tue, 05 Dec 2017)


Log Message
New branch for buildbot 0.9 development.

Added Paths

branches/buildbot-0.9/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [223846] trunk/Tools

2017-10-23 Thread lforschler

Title: [223846] trunk/Tools








Revision 223846
Author lforsch...@apple.com
Date 2017-10-23 11:42:09 -0700 (Mon, 23 Oct 2017)


Log Message

Update README to reference WebKit build archives, instead of 'nightly'

Reviewed by Aakash Jain.

* WebKitArchiveSupport/README:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitArchiveSupport/README




Diff

Modified: trunk/Tools/ChangeLog (223845 => 223846)

--- trunk/Tools/ChangeLog	2017-10-23 18:10:15 UTC (rev 223845)
+++ trunk/Tools/ChangeLog	2017-10-23 18:42:09 UTC (rev 223846)
@@ -1,3 +1,12 @@
+2017-10-23  Lucas Forschler  
+
+
+Update README to reference WebKit build archives, instead of 'nightly'
+
+Reviewed by Aakash Jain.
+
+* WebKitArchiveSupport/README:
+
 2017-10-21  Tim Horton  
 
 Turn on ccache for Mac cmake builds by default


Modified: trunk/Tools/WebKitArchiveSupport/README (223845 => 223846)

--- trunk/Tools/WebKitArchiveSupport/README	2017-10-23 18:10:15 UTC (rev 223845)
+++ trunk/Tools/WebKitArchiveSupport/README	2017-10-23 18:42:09 UTC (rev 223846)
@@ -1,4 +1,4 @@
-WebKit nightly archives are not code signed. Please open run-webkit-archive
+WebKit build archives are not code signed. Please open run-webkit-archive
 using the context menu in Finder.
 
 See https://support.apple.com/kb/PH25088 for more details.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [222875] trunk/Tools

2017-10-04 Thread lforschler

Title: [222875] trunk/Tools








Revision 222875
Author lforsch...@apple.com
Date 2017-10-04 13:27:03 -0700 (Wed, 04 Oct 2017)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=177888
WebKitArchiveSupport - add API Gateway to source control
This is a swagger configuration export via AWS API Gateway console.

Rubber-stamped by Alexey Proskuryakov.

* WebKitArchiveSupport/AWS-APIGateway: Added.
* WebKitArchiveSupport/AWS-APIGateway/stage-v2.json: Added.

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/WebKitArchiveSupport/AWS-APIGateway/
trunk/Tools/WebKitArchiveSupport/AWS-APIGateway/stage-v2.json




Diff

Modified: trunk/Tools/ChangeLog (222874 => 222875)

--- trunk/Tools/ChangeLog	2017-10-04 20:23:10 UTC (rev 222874)
+++ trunk/Tools/ChangeLog	2017-10-04 20:27:03 UTC (rev 222875)
@@ -1,3 +1,14 @@
+2017-10-04  Lucas Forschler  
+
+https://bugs.webkit.org/show_bug.cgi?id=177888
+WebKitArchiveSupport - add API Gateway to source control
+This is a swagger configuration export via AWS API Gateway console.
+
+Rubber-stamped by Alexey Proskuryakov.
+
+* WebKitArchiveSupport/AWS-APIGateway: Added.
+* WebKitArchiveSupport/AWS-APIGateway/stage-v2.json: Added.
+
 2017-10-04  Mark Lam  
 
 Add support for using Probe DFG OSR Exit behind a runtime flag.


Added: trunk/Tools/WebKitArchiveSupport/AWS-APIGateway/stage-v2.json (0 => 222875)

--- trunk/Tools/WebKitArchiveSupport/AWS-APIGateway/stage-v2.json	(rev 0)
+++ trunk/Tools/WebKitArchiveSupport/AWS-APIGateway/stage-v2.json	2017-10-04 20:27:03 UTC (rev 222875)
@@ -0,0 +1,282 @@
+{
+  "swagger": "2.0",
+  "info": {
+"version": "2017-09-27T17:03:47Z",
+"title": "archives.webkit.org"
+  },
+  "host": "q1tzqfy48e.execute-api.us-west-2.amazonaws.com",
+  "basePath": "/v2",
+  "schemes": [
+"https"
+  ],
+  "paths": {
+"/archives/{identifier}": {
+  "get": {
+"consumes": [
+  "application/json"
+],
+"produces": [
+  "application/json"
+],
+"parameters": [
+  {
+"name": "identifier",
+"in": "path",
+"required": true,
+"type": "string"
+  }
+],
+"responses": {
+  "200": {
+"description": "200 response",
+"schema": {
+  "$ref": "#/definitions/Empty"
+}
+  }
+},
+"x-amazon-apigateway-integration": {
+  "credentials": "arn:aws:iam::982456631623:role/lambda-s3-execution-role",
+  "responses": {
+"default": {
+  "statusCode": "200",
+  "responseTemplates": {
+"application/json": "{\n\"path\" : \"archives\",\n\"identifier\" : \"$input.params('identifier')\",\n\"revisions\" : $input.json('$')\n}"
+  }
+}
+  },
+  "requestTemplates": {
+"application/json": "{\n\"TableName\": \"archives.webkit.org\",\n\"KeyConditionExpression\": \"identifier = :v1\",\n\"ExpressionAttributeValues\": {\n\":v1\": {\n\"S\": \"$input.params('identifier')\"\n}\n},\n\"ProjectionExpression\": \"revision\"\n}"
+  },
+  "uri": "arn:aws:apigateway:us-west-2:dynamodb:action/Query",
+  "passthroughBehavior": "when_no_templates",
+  "httpMethod": "POST",
+  "type": "aws"
+}
+  }
+},
+"/archives/{identifier}/{revision}": {
+  "get": {
+"consumes": [
+  "application/json"
+],
+"produces": [
+  "application/json"
+],
+"parameters": [
+  {
+"name": "identifier",
+"in": "path",
+"required": true,
+"type": "string"
+  },
+  {
+"name": "revision",
+"in": "path",
+"required": true,
+"type": "string"
+  }
+],
+"responses": {
+  "200": {
+"description": "200 response",
+"schema": {
+  "$ref": "#/definitions/Empty"
+}
+  }
+},
+"x-amazon-apigateway-integration": {
+  "credentials": "arn:aws:iam::982456631623:role/lambda-s3-execution-role",
+  "responses": {
+"default": {
+  "statusCode": "200",
+  "responseTemplates": {
+"application/json": "#set($inputRoot = $input.path('$'))\n{\n\"archive\": [\n#foreach($elem in $inputRoot.Items) {\n\"identifier\": \"$elem.identifier.S\",\n\"revision\": \"$elem.revision.N\",\n\"s3_url\": \"$elem.s3_url.S\"\n}#if($foreach.hasNext),#end\n\t#end\n]\n}"
+  }
+}
+  },
+  "requestTemplates": {
+"application/json": "{\n\"TableName\": \"archives.webkit.org\",\n\"KeyConditionExp

[webkit-changes] [222634] trunk/Tools

2017-09-28 Thread lforschler

Title: [222634] trunk/Tools








Revision 222634
Author lforsch...@apple.com
Date 2017-09-28 14:43:43 -0700 (Thu, 28 Sep 2017)


Log Message
check in AWS Lambda code used for WebKitArchiveSupport
https://bugs.webkit.org/show_bug.cgi?id=177614

Rubber-stamped by Alexey Proskuryakov.

* WebKitArchiveSupport/lambda: Added.
* WebKitArchiveSupport/lambda/delete-minified-s3-archive-from-dynamodb.py: Added.
(lambda_handler):
* WebKitArchiveSupport/lambda/delete-s3-archive-from-dynamodb.py: Added.
(lambda_handler):
* WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py: Added.
(lambda_handler):
* WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py: Added.
(lambda_handler):

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/WebKitArchiveSupport/lambda/
trunk/Tools/WebKitArchiveSupport/lambda/delete-minified-s3-archive-from-dynamodb.py
trunk/Tools/WebKitArchiveSupport/lambda/delete-s3-archive-from-dynamodb.py
trunk/Tools/WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py
trunk/Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py




Diff

Modified: trunk/Tools/ChangeLog (222633 => 222634)

--- trunk/Tools/ChangeLog	2017-09-28 21:31:40 UTC (rev 222633)
+++ trunk/Tools/ChangeLog	2017-09-28 21:43:43 UTC (rev 222634)
@@ -1,3 +1,20 @@
+2017-09-28  Lucas Forschler  
+
+check in AWS Lambda code used for WebKitArchiveSupport
+https://bugs.webkit.org/show_bug.cgi?id=177614
+
+Rubber-stamped by Alexey Proskuryakov.
+
+* WebKitArchiveSupport/lambda: Added.
+* WebKitArchiveSupport/lambda/delete-minified-s3-archive-from-dynamodb.py: Added.
+(lambda_handler):
+* WebKitArchiveSupport/lambda/delete-s3-archive-from-dynamodb.py: Added.
+(lambda_handler):
+* WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py: Added.
+(lambda_handler):
+* WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py: Added.
+(lambda_handler):
+
 2017-09-28  Jiewen Tan  
 
 WeakPtrFactory should allow downcasting


Added: trunk/Tools/WebKitArchiveSupport/lambda/delete-minified-s3-archive-from-dynamodb.py (0 => 222634)

--- trunk/Tools/WebKitArchiveSupport/lambda/delete-minified-s3-archive-from-dynamodb.py	(rev 0)
+++ trunk/Tools/WebKitArchiveSupport/lambda/delete-minified-s3-archive-from-dynamodb.py	2017-09-28 21:43:43 UTC (rev 222634)
@@ -0,0 +1,32 @@
+import boto3
+import json
+import urllib.parse  # pylint: disable=E0611
+
+print('Loading function')
+dynamodb_client = boto3.client('dynamodb')
+table_name = 'minified-archives.webkit.org'
+s3 = boto3.client('s3')
+
+
+def lambda_handler(event, context):
+print("Received event: " + json.dumps(event, indent=2))
+
+key = urllib.parse.unquote_plus(event['Records'][0]['s3']['object']['key'], encoding='utf-8')  # pylint: disable=E1101
+# ex: mac-sierra-x86_64-debug/218331.zip
+
+split_key = key.split('/')
+identifier = split_key[0]   # mac-sierra-x86_64-debug
+filename = split_key[1] # 218331.zip
+revision = filename.split('.')[0]   # 218331
+
+print ("identifier: " + identifier)
+print ("revision: " + revision)
+
+try:
+item = {'identifier': {'S': identifier}, 'revision': {'N': revision}}
+response = dynamodb_client.delete_item(TableName=table_name, Key=item)
+return response
+except Exception as e:
+print(e)
+print('Error deleting item: {}\nfrom database: {}.'.format(item, table_name))
+raise e


Added: trunk/Tools/WebKitArchiveSupport/lambda/delete-s3-archive-from-dynamodb.py (0 => 222634)

--- trunk/Tools/WebKitArchiveSupport/lambda/delete-s3-archive-from-dynamodb.py	(rev 0)
+++ trunk/Tools/WebKitArchiveSupport/lambda/delete-s3-archive-from-dynamodb.py	2017-09-28 21:43:43 UTC (rev 222634)
@@ -0,0 +1,32 @@
+import boto3
+import json
+import urllib.parse  # pylint: disable=E0611
+
+print('Loading function')
+dynamodb_client = boto3.client('dynamodb')
+table_name = 'archives.webkit.org'
+s3 = boto3.client('s3')
+
+
+def lambda_handler(event, context):
+print("Received event: " + json.dumps(event, indent=2))
+
+key = urllib.parse.unquote_plus(event['Records'][0]['s3']['object']['key'], encoding='utf-8')  # pylint: disable=E1101
+# ex: mac-sierra-x86_64-debug/218331.zip
+
+split_key = key.split('/')
+identifier = split_key[0]   # mac-sierra-x86_64-debug
+filename = split_key[1] # 218331.zip
+revision = filename.split('.')[0]   # 218331
+
+print ("identifier: " + identifier)
+print ("revision: " + revision)
+
+try:
+item = {'identifier': {'S': identifier}, 'revision': {'N': revision}}
+response = dynamodb_client.delete_item(TableName=table_name, Key=item)
+return response
+except Exception as e:
+print(e)
+print('Error deleting item: {}\

[webkit-changes] [222582] trunk/Tools

2017-09-27 Thread lforschler

Title: [222582] trunk/Tools








Revision 222582
Author lforsch...@apple.com
Date 2017-09-27 16:18:13 -0700 (Wed, 27 Sep 2017)


Log Message
Add macOS High Sierra and iOS Simulator 11 support to bisect-builds.
https://bugs.webkit.org/show_bug.cgi?id=177578

Reviewed by Alexey Proskuryakov.

* Scripts/bisect-builds:
(minified_platforms):
(unminified_platforms):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/bisect-builds




Diff

Modified: trunk/Tools/ChangeLog (222581 => 222582)

--- trunk/Tools/ChangeLog	2017-09-27 22:59:49 UTC (rev 222581)
+++ trunk/Tools/ChangeLog	2017-09-27 23:18:13 UTC (rev 222582)
@@ -1,3 +1,14 @@
+2017-09-27  Lucas Forschler  
+
+Add macOS High Sierra and iOS Simulator 11 support to bisect-builds.
+https://bugs.webkit.org/show_bug.cgi?id=177578
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/bisect-builds:
+(minified_platforms):
+(unminified_platforms):
+
 2017-09-27  Ryan Haddad  
 
 Update TestResultsServer for High Sierra queues.


Modified: trunk/Tools/Scripts/bisect-builds (222581 => 222582)

--- trunk/Tools/Scripts/bisect-builds	2017-09-27 22:59:49 UTC (rev 222581)
+++ trunk/Tools/Scripts/bisect-builds	2017-09-27 23:18:13 UTC (rev 222582)
@@ -192,12 +192,12 @@
 
 def minified_platforms():
 # FIXME: query this dynamically from API
-return  ['mac-elcapitan', 'mac-sierra', 'ios-simulator-10']
+return  ['mac-elcapitan', 'mac-sierra', 'mac-highsierra', 'ios-simulator-10', 'ios-simulator-11']
 
 
 def unminified_platforms():
 # FIXME: query this dynamically from API
-return ['gtk', 'ios-simulator-10', 'mac-elcapitan', 'mac-sierra', 'win', 'wpe']
+return ['gtk', 'ios-simulator-10', 'ios-simulator-11', 'mac-elcapitan', 'mac-sierra', 'mac-highsierra', 'win', 'wpe']
 
 
 def is_supported_platform(options):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [222558] trunk/Tools

2017-09-27 Thread lforschler

Title: [222558] trunk/Tools








Revision 222558
Author lforsch...@apple.com
Date 2017-09-27 10:12:03 -0700 (Wed, 27 Sep 2017)


Log Message
bisect-builds:add a README to the archive.
https://bugs.webkit.org/show_bug.cgi?id=177376

Reviewed by Alexey Proskuryakov & Jon Davis.

* BuildSlaveSupport/built-product-archive:
(addFilesToArchive): refactor function (was previously addLauncherToArchive)
(createZip): Teach function to add the README
(addLauncherToArchive): Deleted. (refactored to addFilesToArchive)
* BuildSlaveSupport/run-webkit-archive: Deleted. (Moved to WebKitArchiveSupport)
* WebKitArchiveSupport: Added.
* WebKitArchiveSupport/README: Added. README which will be packaged up with the archive.
* WebKitArchiveSupport/run-webkit-archive: Added. (Moved from BuildSlaveSupport)

Modified Paths

trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog


Added Paths

trunk/Tools/WebKitArchiveSupport/
trunk/Tools/WebKitArchiveSupport/README
trunk/Tools/WebKitArchiveSupport/run-webkit-archive


Removed Paths

trunk/Tools/BuildSlaveSupport/run-webkit-archive




Diff

Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (222557 => 222558)

--- trunk/Tools/BuildSlaveSupport/built-product-archive	2017-09-27 17:08:58 UTC (rev 222557)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive	2017-09-27 17:12:03 UTC (rev 222558)
@@ -36,7 +36,8 @@
 _topLevelBuildDirectory = None
 _hostBuildDirectory = None
 
-PATH_TO_LAUNCHER = './Tools/BuildSlaveSupport/run-webkit-archive'
+PATH_TO_LAUNCHER = './Tools/WebKitArchiveSupport/run-webkit-archive'
+PATH_TO_README = './Tools/WebKitArchiveSupport/README'
 
 def main():
 parser = optparse.OptionParser("usage: %prog [options] [action]")
@@ -137,8 +138,8 @@
 
 archiveZip.close()
 
-def addLauncherToArchive(archiveFile):
-command = ['/usr/bin/zip', '-j', archiveFile, PATH_TO_LAUNCHER]
+def addFilesToArchive(archiveFile, pathToLauncher, pathToReadme):
+command = ['/usr/bin/zip', '-j', archiveFile, pathToLauncher, pathToReadme]
 return subprocess.call(command)
 
 def createZip(directoryToZip, configuration, embedParentDirectoryNameOnDarwin=False, minify=False):
@@ -158,7 +159,7 @@
 if embedParentDirectoryNameOnDarwin:
 command += ['--keepParent']
 command += [directoryToZip, archiveFile]
-return subprocess.call(command) or addLauncherToArchive(archiveFile)
+return subprocess.call(command) or addFilesToArchive(archiveFile, PATH_TO_LAUNCHER, PATH_TO_README) 
 elif sys.platform == 'cygwin':
 return subprocess.call(["zip", "-r", archiveFile, "bin32"], cwd=directoryToZip)
 elif sys.platform == 'win32':


Deleted: trunk/Tools/BuildSlaveSupport/run-webkit-archive (222557 => 222558)

--- trunk/Tools/BuildSlaveSupport/run-webkit-archive	2017-09-27 17:08:58 UTC (rev 222557)
+++ trunk/Tools/BuildSlaveSupport/run-webkit-archive	2017-09-27 17:12:03 UTC (rev 222558)
@@ -1,69 +0,0 @@
-#!/usr/bin/env python
-
-# Copyright (C) 2017 Apple Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-#
-# 1.  Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer. 
-# 2.  Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution. 
-# 3.  Neither the name of Apple Inc. ("Apple") nor the names of
-# its contributors may be used to endorse or promote products derived
-# from this software without specific prior written permission. 
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
-# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
-# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
-# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
-# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-import os, platform, subprocess
-
-SAFARI_FOR_WEBKIT_DEVELOPMENT='/Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment'
-
-def check_for_valid_platform():
-if 'Darwin' not in platform.system():
-print('Unsupported OS, exiting.')
-exit(1)
-
-def find_dyld_framework_path(script_path):
-current_directory = os.path.dirname(script_path)
-sub_directories = [name for name in os.listdir(current_directory) if os.path.isdir(

[webkit-changes] [222159] trunk/Tools/ChangeLog

2017-09-18 Thread lforschler

Title: [222159] trunk/Tools/ChangeLog








Revision 222159
Author lforsch...@apple.com
Date 2017-09-18 09:53:33 -0700 (Mon, 18 Sep 2017)


Log Message
Land a patch to verify svn->git update is working.

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (222158 => 222159)

--- trunk/Tools/ChangeLog	2017-09-18 16:26:39 UTC (rev 222158)
+++ trunk/Tools/ChangeLog	2017-09-18 16:53:33 UTC (rev 222159)
@@ -1,3 +1,7 @@
+2017-09-18  Lucas Forschler  
+
+Land a patch to verify svn->git update is working.
+
 2017-09-18  Ms2ger  
 
 Update my status.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [222122] trunk/Tools

2017-09-15 Thread lforschler

Title: [222122] trunk/Tools








Revision 222122
Author lforsch...@apple.com
Date 2017-09-15 17:05:42 -0700 (Fri, 15 Sep 2017)


Log Message
Move run-webkit-archive from Tools/Scripts to Tools/BuildSlaveSupport

Reviewed by Alexey Proskuryakov.

* Scripts/run-webkit-archive: Removed.

Modified Paths

trunk/Tools/ChangeLog


Removed Paths

trunk/Tools/Scripts/run-webkit-archive




Diff

Modified: trunk/Tools/ChangeLog (222121 => 222122)

--- trunk/Tools/ChangeLog	2017-09-16 00:04:16 UTC (rev 222121)
+++ trunk/Tools/ChangeLog	2017-09-16 00:05:42 UTC (rev 222122)
@@ -1,5 +1,13 @@
 2017-09-15  Lucas Forschler  
 
+Move run-webkit-archive from Tools/Scripts to Tools/BuildSlaveSupport
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/run-webkit-archive: Removed.
+
+2017-09-15  Lucas Forschler  
+
 teach build.webkit.org to include run-webkit-archive in the root folder of uploaded macOS archives.
 https://bugs.webkit.org/show_bug.cgi?id=176965
 


Deleted: trunk/Tools/Scripts/run-webkit-archive (222121 => 222122)

--- trunk/Tools/Scripts/run-webkit-archive	2017-09-16 00:04:16 UTC (rev 222121)
+++ trunk/Tools/Scripts/run-webkit-archive	2017-09-16 00:05:42 UTC (rev 222122)
@@ -1,68 +0,0 @@
-#!/usr/bin/env python
-
-# Copyright (C) 2017 Apple Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-#
-# 1.  Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer. 
-# 2.  Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution. 
-# 3.  Neither the name of Apple Inc. ("Apple") nor the names of
-# its contributors may be used to endorse or promote products derived
-# from this software without specific prior written permission. 
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
-# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
-# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
-# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
-# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-import os, platform, subprocess
-
-SAFARI_FOR_WEBKIT_DEVELOPMENT='/Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment'
-
-def check_for_valid_platform():
-if 'Darwin' not in platform.system():
-print('Unsupported OS, exiting.')
-exit(1)
-
-def find_dyld_framework_path(script_path):
-current_directory = os.path.dirname(script_path)
-sub_directories = [name for name in os.listdir(current_directory) if os.path.isdir(name)]
-if 'Debug' in sub_directories:
-return current_directory + '/Debug'
-elif 'Release' in sub_directories:
-return current_directory + '/Release'
-else:
-print('No Release or Debug framework directories found in the current folder, exiting.')
-exit(1)
-
-def run_safari_for_webkit_development():
-subprocess.call(SAFARI_FOR_WEBKIT_DEVELOPMENT)
-
-def set_dyld_framework_path(script_path):
-dyld_path = find_dyld_framework_path(script_path)
-print('Setting DYLD FRAMEWORK and LIBRARY paths to {}'.format(dyld_path))
-os.environ['DYLD_FRAMEWORK_PATH'] = dyld_path
-os.environ['DYLD_LIBRARY_PATH'] = dyld_path
-
-def main():
-script_path = os.path.abspath(__file__)
-check_for_valid_platform()
-set_dyld_framework_path(script_path)
-run_safari_for_webkit_development()
-
-if __name__ == '__main__':
-try:
-main()
-except KeyboardInterrupt:
-exit("Aborting.")
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [222121] trunk/Tools

2017-09-15 Thread lforschler

Title: [222121] trunk/Tools








Revision 222121
Author lforsch...@apple.com
Date 2017-09-15 17:04:16 -0700 (Fri, 15 Sep 2017)


Log Message
teach build.webkit.org to include run-webkit-archive in the root folder of uploaded macOS archives.
https://bugs.webkit.org/show_bug.cgi?id=176965

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/built-product-archive:
(addLauncherToArchive): Helper function to add the launcher script
(createZip): teach function about addLauncherToArchive
* BuildSlaveSupport/run-webkit-archive: Added.
(check_for_valid_platform): Add logic to ensure platform is Darwin
(find_dyld_framework_path): Find the dyld framework path
(run_safari_for_webkit_development): launch SafariForWebKitDevelopment
(set_dyld_framework_path): export the environment for dydl framework path

Modified Paths

trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/run-webkit-archive




Diff

Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (222120 => 222121)

--- trunk/Tools/BuildSlaveSupport/built-product-archive	2017-09-16 00:02:48 UTC (rev 222120)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive	2017-09-16 00:04:16 UTC (rev 222121)
@@ -36,6 +36,7 @@
 _topLevelBuildDirectory = None
 _hostBuildDirectory = None
 
+PATH_TO_LAUNCHER = './Tools/BuildSlaveSupport/run-webkit-archive'
 
 def main():
 parser = optparse.OptionParser("usage: %prog [options] [action]")
@@ -136,6 +137,9 @@
 
 archiveZip.close()
 
+def addLauncherToArchive(archiveFile):
+command = ['/usr/bin/zip', '-j', archiveFile, PATH_TO_LAUNCHER]
+return subprocess.call(command)
 
 def createZip(directoryToZip, configuration, embedParentDirectoryNameOnDarwin=False, minify=False):
 archiveDir = os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", "WebKitBuild"))
@@ -154,7 +158,7 @@
 if embedParentDirectoryNameOnDarwin:
 command += ['--keepParent']
 command += [directoryToZip, archiveFile]
-return subprocess.call(command)
+return subprocess.call(command) or addLauncherToArchive(archiveFile)
 elif sys.platform == 'cygwin':
 return subprocess.call(["zip", "-r", archiveFile, "bin32"], cwd=directoryToZip)
 elif sys.platform == 'win32':


Added: trunk/Tools/BuildSlaveSupport/run-webkit-archive (0 => 222121)

--- trunk/Tools/BuildSlaveSupport/run-webkit-archive	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/run-webkit-archive	2017-09-16 00:04:16 UTC (rev 222121)
@@ -0,0 +1,69 @@
+#!/usr/bin/env python
+
+# Copyright (C) 2017 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer. 
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution. 
+# 3.  Neither the name of Apple Inc. ("Apple") nor the names of
+# its contributors may be used to endorse or promote products derived
+# from this software without specific prior written permission. 
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import os, platform, subprocess
+
+SAFARI_FOR_WEBKIT_DEVELOPMENT='/Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment'
+
+def check_for_valid_platform():
+if 'Darwin' not in platform.system():
+print('Unsupported OS, exiting.')
+exit(1)
+
+def find_dyld_framework_path(script_path):
+current_directory = os.path.dirname(script_path)
+sub_directories = [name for name in os.listdir(current_directory) if os.path.isdir(name)]
+if 'Debug' in sub_directories:
+return current_directory + '/Debug'
+elif 'Release' in sub_directories:
+return current_directory + '/Release'
+else:
+print('No Release or Debug framework directories found in the current folder, exiting.')
+exit(1)
+
+def run_safari_for_webkit_development():
+subprocess.call(SAFARI_FOR_WEBKIT_D

[webkit-changes] [222067] trunk/Tools

2017-09-14 Thread lforschler

Title: [222067] trunk/Tools








Revision 222067
Author lforsch...@apple.com
Date 2017-09-14 17:14:10 -0700 (Thu, 14 Sep 2017)


Log Message
Create a launcher for webkit-archives
https://bugs.webkit.org/show_bug.cgi?id=176964

Reviewed by Aakash Jain.

* Scripts/run-webkit-archive: Added.
(find_dyld_framework_path):
(run_safari_for_webkit_development):
(set_dyld_framework_path):
(main):

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/Scripts/run-webkit-archive




Diff

Modified: trunk/Tools/ChangeLog (222066 => 222067)

--- trunk/Tools/ChangeLog	2017-09-15 00:04:47 UTC (rev 222066)
+++ trunk/Tools/ChangeLog	2017-09-15 00:14:10 UTC (rev 222067)
@@ -1,3 +1,16 @@
+2017-09-14  Lucas Forschler  
+
+Create a launcher for webkit-archives
+https://bugs.webkit.org/show_bug.cgi?id=176964
+
+Reviewed by Aakash Jain.
+
+* Scripts/run-webkit-archive: Added.
+(find_dyld_framework_path):
+(run_safari_for_webkit_development):
+(set_dyld_framework_path):
+(main):
+
 2017-09-14  Alex Christensen  
 
 Add WKUIDelegatePrivate equivalent of WKPageUIClient's drawHeader, drawFooter, headerHeight, and footerHeight


Added: trunk/Tools/Scripts/run-webkit-archive (0 => 222067)

--- trunk/Tools/Scripts/run-webkit-archive	(rev 0)
+++ trunk/Tools/Scripts/run-webkit-archive	2017-09-15 00:14:10 UTC (rev 222067)
@@ -0,0 +1,68 @@
+#!/usr/bin/env python
+
+# Copyright (C) 2017 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer. 
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution. 
+# 3.  Neither the name of Apple Inc. ("Apple") nor the names of
+# its contributors may be used to endorse or promote products derived
+# from this software without specific prior written permission. 
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import os, platform, subprocess
+
+SAFARI_FOR_WEBKIT_DEVELOPMENT='/Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment'
+
+def check_for_valid_platform():
+if 'Darwin' not in platform.system():
+print('Unsupported OS, exiting.')
+exit(1)
+
+def find_dyld_framework_path(script_path):
+current_directory = os.path.dirname(script_path)
+sub_directories = [name for name in os.listdir(current_directory) if os.path.isdir(name)]
+if 'Debug' in sub_directories:
+return current_directory + '/Debug'
+elif 'Release' in sub_directories:
+return current_directory + '/Release'
+else:
+print('No Release or Debug framework directories found in the current folder, exiting.')
+exit(1)
+
+def run_safari_for_webkit_development():
+subprocess.call(SAFARI_FOR_WEBKIT_DEVELOPMENT)
+
+def set_dyld_framework_path(script_path):
+dyld_path = find_dyld_framework_path(script_path)
+print('Setting DYLD FRAMEWORK and LIBRARY paths to {}'.format(dyld_path))
+os.environ['DYLD_FRAMEWORK_PATH'] = dyld_path
+os.environ['DYLD_LIBRARY_PATH'] = dyld_path
+
+def main():
+script_path = os.path.abspath(__file__)
+check_for_valid_platform()
+set_dyld_framework_path(script_path)
+run_safari_for_webkit_development()
+
+if __name__ == '__main__':
+try:
+main()
+except KeyboardInterrupt:
+exit("Aborting.")
\ No newline at end of file
Property changes on: trunk/Tools/Scripts/run-webkit-archive
___


Added: svn:executable
+*
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221985] trunk/Tools

2017-09-13 Thread lforschler

Title: [221985] trunk/Tools








Revision 221985
Author lforsch...@apple.com
Date 2017-09-13 12:54:06 -0700 (Wed, 13 Sep 2017)


Log Message
Compress spindumps on client side before packaging into layout test results zip (mac & ios)
https://bugs.webkit.org/show_bug.cgi?id=176853

Reviewed by Aakash Jain.

* BuildSlaveSupport/test-result-archive:
(main):
(gzip_file): use gzip to compress a file, removing original
(compress_spindumps): find and compress spindumps matching a filter
(archive_test_results): refactor to snake_case
(archiveTestResults): Deleted.

Modified Paths

trunk/Tools/BuildSlaveSupport/test-result-archive
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/test-result-archive (221984 => 221985)

--- trunk/Tools/BuildSlaveSupport/test-result-archive	2017-09-13 18:45:41 UTC (rev 221984)
+++ trunk/Tools/BuildSlaveSupport/test-result-archive	2017-09-13 19:54:06 UTC (rev 221985)
@@ -23,7 +23,7 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-import optparse, os, shutil, subprocess, sys
+import gzip, optparse, os, shutil, subprocess, sys
 
 sourceRootDirectory = os.path.abspath(os.path.join(os.path.dirname(__file__), "..", ".."))
 archiveFile = os.path.join(sourceRootDirectory, "layout-test-results.zip")
@@ -43,9 +43,22 @@
 parser.error("Action is required")
 
 layoutTestResultsDir = os.path.abspath(os.path.join(sourceRootDirectory, "layout-test-results"))
-return archiveTestResults(options.configuration, options.platform, layoutTestResultsDir)
+return archive_test_results(options.configuration, options.platform, layoutTestResultsDir)
 
-def archiveTestResults(configuration, platform, layoutTestResultsDir):
+def gzip_file(root, name):
+with open(os.path.join(root, name), 'rb') as f_in, gzip.open(os.path.join(root, name + '.gz'), 'wb') as f_out:
+shutil.copyfileobj(f_in, f_out)
+os.remove(os.path.join(root, name))
+
+def compress_spindumps(layoutTestResultsDir):
+file_patterns = ('-spindump.txt','-sample.txt')
+for root, dirs, files in os.walk(layoutTestResultsDir):
+for name in files:
+for pattern in file_patterns:
+if pattern in name:
+gzip_file(root, name)
+
+def archive_test_results(configuration, platform, layoutTestResultsDir):
 assert platform in ('mac', 'win', 'gtk', 'wincairo', 'ios', 'wpe')
 
 try:
@@ -64,6 +77,7 @@
 open(os.path.join(layoutTestResultsDir, '.placeholder'), 'w').close()
 
 if platform in ('mac', 'ios'):
+compress_spindumps(layoutTestResultsDir)
 if subprocess.call(["ditto", "-c", "-k", "--sequesterRsrc", "--zlibCompressionLevel", "2", layoutTestResultsDir, archiveFile]):
 return 1
 elif platform in ('win', 'gtk', 'wincairo', 'wpe'):


Modified: trunk/Tools/ChangeLog (221984 => 221985)

--- trunk/Tools/ChangeLog	2017-09-13 18:45:41 UTC (rev 221984)
+++ trunk/Tools/ChangeLog	2017-09-13 19:54:06 UTC (rev 221985)
@@ -1,3 +1,17 @@
+2017-09-13  Lucas Forschler  
+
+Compress spindumps on client side before packaging into layout test results zip (mac & ios)
+https://bugs.webkit.org/show_bug.cgi?id=176853
+
+Reviewed by Aakash Jain.
+
+* BuildSlaveSupport/test-result-archive:
+(main):
+(gzip_file): use gzip to compress a file, removing original
+(compress_spindumps): find and compress spindumps matching a filter
+(archive_test_results): refactor to snake_case
+(archiveTestResults): Deleted.
+
 2017-09-13  Alex Christensen  
 
 Add WKUIDelegatePrivate equivalent of WKPageUIClient's setIsResizable, getWindowFrame, and setWindowFrame






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221895] trunk/Tools

2017-09-11 Thread lforschler

Title: [221895] trunk/Tools








Revision 221895
Author lforsch...@apple.com
Date 2017-09-11 17:10:09 -0700 (Mon, 11 Sep 2017)


Log Message
bisect-builds: add --list option
https://bugs.webkit.org/show_bug.cgi?id=174836

Reviewed by Aakash Jain & Stephanie Lewis.

* Scripts/bisect-builds:
(parse_args): add --list option
(minified_platforms): update supported platform list (add ios simulator)
(print_list_and_exit): helper function to print list and exit

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/bisect-builds




Diff

Modified: trunk/Tools/ChangeLog (221894 => 221895)

--- trunk/Tools/ChangeLog	2017-09-11 23:54:05 UTC (rev 221894)
+++ trunk/Tools/ChangeLog	2017-09-12 00:10:09 UTC (rev 221895)
@@ -1,3 +1,15 @@
+2017-09-11  Lucas Forschler  
+
+bisect-builds: add --list option
+https://bugs.webkit.org/show_bug.cgi?id=174836
+
+Reviewed by Aakash Jain & Stephanie Lewis.
+
+* Scripts/bisect-builds:
+(parse_args): add --list option
+(minified_platforms): update supported platform list (add ios simulator)
+(print_list_and_exit): helper function to print list and exit
+
 2017-09-11  Wenson Hsieh  
 
 [iOS WK2] ExternalSourceDataTransferItemGetAsEntry tests produce inconsistent results on test automation bots


Modified: trunk/Tools/Scripts/bisect-builds (221894 => 221895)

--- trunk/Tools/Scripts/bisect-builds	2017-09-11 23:54:05 UTC (rev 221894)
+++ trunk/Tools/Scripts/bisect-builds	2017-09-12 00:10:09 UTC (rev 221895)
@@ -135,7 +135,8 @@
 
 
 def parse_args(args):
-parser = argparse.ArgumentParser(description='Perform a bisection against existing WebKit archives.')
+helptext = 'bisect-builds is designed to help pinpoint regressions to specific code changes. It does this by bisecting across archives produced by build.webkit.org. Full and "minified" archives are available. Minified archives are significantly smaller, as they have been stripped of dSYMs and other non-essential components.'
+parser = argparse.ArgumentParser(description=helptext)
 parser.add_argument('-c', '--configuration', default='release', help='The configuration to query [release | debug]')
 parser.add_argument('-a', '--architecture', default='x86_64', help='The architecture to query [x86_64 | i386]')
 parser.add_argument('-p', '--platform', default='None', required=True, help='The platform to query [mac-sierra | gtk | ios-simulator | win]')
@@ -142,6 +143,7 @@
 parser.add_argument('-f', '--full', action='', default=False, help='Use full archives containing debug symbols. These are significantly larger files!')
 parser.add_argument('-s', '--start', default=None, type=int, help='The starting revision to bisect.')
 parser.add_argument('-e', '--end', default=None, type=int, help='The ending revision to bisect')
+parser.add_argument('-l', '--list', action='', default=False, help='Display a list of platforms and revisions')
 return parser.parse_args(args)
 
 
@@ -190,7 +192,7 @@
 
 def minified_platforms():
 # FIXME: query this dynamically from API
-return  ['mac-elcapitan', 'mac-sierra']
+return  ['mac-elcapitan', 'mac-sierra', 'ios-simulator-10']
 
 
 def unminified_platforms():
@@ -214,6 +216,12 @@
 print('INFO: pass --full to try against full archives')
 exit(1)
 
+def print_list_and_exit(revision_list, options):
+print('Supported minified platforms: {}'.format(minified_platforms()))
+print('Supported unminified platforms: {}'.format(unminified_platforms()))
+print('{} revisions available for supplied platform: {}-{}-{}:'.format(len(revision_list), options.platform, options.architecture, options.configuration))
+print(revision_list)
+exit(0)
 
 def main(options):
 validate_options(options)
@@ -223,7 +231,10 @@
 data = ""
 
 revision_list = get_sorted_revisions(data)
-
+
+if options.list:
+print_list_and_exit(revision_list, options)
+
 start_index, end_index = get_indices_from_revisions(revision_list, options.start, options.end)
 print('Bisecting between {} and {}'.format(revision_list[start_index], revision_list[end_index]))
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221890] trunk/Tools

2017-09-11 Thread lforschler

Title: [221890] trunk/Tools








Revision 221890
Author lforsch...@apple.com
Date 2017-09-11 16:09:09 -0700 (Mon, 11 Sep 2017)


Log Message
bisect-builds doesn't work due to missing requests module
https://bugs.webkit.org/show_bug.cgi?id=175709

Reviewed by Ryosuke Niwa.

* Scripts/bisect-builds: use urllib2 instead of the requests module.
(get_s3_location_for_revision):
(main):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/bisect-builds




Diff

Modified: trunk/Tools/ChangeLog (221889 => 221890)

--- trunk/Tools/ChangeLog	2017-09-11 23:06:25 UTC (rev 221889)
+++ trunk/Tools/ChangeLog	2017-09-11 23:09:09 UTC (rev 221890)
@@ -1,3 +1,14 @@
+2017-09-11  Lucas Forschler  
+
+bisect-builds doesn't work due to missing requests module
+https://bugs.webkit.org/show_bug.cgi?id=175709
+
+Reviewed by Ryosuke Niwa.
+
+* Scripts/bisect-builds: use urllib2 instead of the requests module.
+(get_s3_location_for_revision):
+(main):
+
 2017-09-11  Filip Pizlo  
 
 WSL Substitution should probably wrap type variables of substituted types rather than just wrapping the whole type


Modified: trunk/Tools/Scripts/bisect-builds (221889 => 221890)

--- trunk/Tools/Scripts/bisect-builds	2017-09-11 23:06:25 UTC (rev 221889)
+++ trunk/Tools/Scripts/bisect-builds	2017-09-11 23:09:09 UTC (rev 221890)
@@ -28,13 +28,14 @@
 
 import argparse
 import bisect
+import json
 import math
 import os
-import requests
 import shutil
 import subprocess
 import sys
 import tempfile
+import urllib2
 import urlparse
 
 REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2/'
@@ -125,8 +126,10 @@
 
 def get_s3_location_for_revision(url, revision):
 url = ''.join([url, str(revision)])
-r = requests.get(url)
-for archive in r.json()['archive']:
+r = urllib2.urlopen(url)
+data = ""
+
+for archive in data['archive']:
 s3_url = archive['s3_url']
 return s3_url
 
@@ -216,9 +219,11 @@
 validate_options(options)
 
 url = ""
-r = requests.get(url)
-revision_list = get_sorted_revisions(r.json())
+r = urllib2.urlopen(url)
+data = ""
 
+revision_list = get_sorted_revisions(data)
+
 start_index, end_index = get_indices_from_revisions(revision_list, options.start, options.end)
 print('Bisecting between {} and {}'.format(revision_list[start_index], revision_list[end_index]))
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221801] trunk/Tools

2017-09-08 Thread lforschler

Title: [221801] trunk/Tools








Revision 221801
Author lforsch...@apple.com
Date 2017-09-08 16:00:54 -0700 (Fri, 08 Sep 2017)


Log Message
bisect-builds doesn't work due to missing requests module
https://bugs.webkit.org/show_bug.cgi?id=175709

Reviewed by Ryosuke Niwa.

* Scripts/bisect-builds: update import to webkitpy.thirdparty.autoinstalled
* Scripts/webkitpy/thirdparty/__init__.py: add logic to install requests module.
(AutoinstallImportHook.find_module):
(AutoinstallImportHook):
(AutoinstallImportHook._install_requests):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_imports):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/bisect-builds
trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py
trunk/Tools/Scripts/webkitpy/thirdparty/__init___unittest.py




Diff

Modified: trunk/Tools/ChangeLog (221800 => 221801)

--- trunk/Tools/ChangeLog	2017-09-08 22:09:17 UTC (rev 221800)
+++ trunk/Tools/ChangeLog	2017-09-08 23:00:54 UTC (rev 221801)
@@ -1,5 +1,20 @@
 2017-09-08  Lucas Forschler  
 
+bisect-builds doesn't work due to missing requests module
+https://bugs.webkit.org/show_bug.cgi?id=175709
+
+Reviewed by Ryosuke Niwa.
+
+* Scripts/bisect-builds: update import to webkitpy.thirdparty.autoinstalled
+* Scripts/webkitpy/thirdparty/__init__.py: add logic to install requests module.
+(AutoinstallImportHook.find_module):
+(AutoinstallImportHook):
+(AutoinstallImportHook._install_requests):
+* Scripts/webkitpy/thirdparty/__init___unittest.py:
+(ThirdpartyTest.test_imports):
+
+2017-09-08  Lucas Forschler  
+
 Test commit to verify trac sync is working.
 
 2017-09-08  Lucas Forschler  


Modified: trunk/Tools/Scripts/bisect-builds (221800 => 221801)

--- trunk/Tools/Scripts/bisect-builds	2017-09-08 22:09:17 UTC (rev 221800)
+++ trunk/Tools/Scripts/bisect-builds	2017-09-08 23:00:54 UTC (rev 221801)
@@ -30,12 +30,12 @@
 import bisect
 import math
 import os
-import requests
 import shutil
 import subprocess
 import sys
 import tempfile
 import urlparse
+import webkitpy.thirdparty.autoinstalled.requests as requests
 
 REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2/'
 REST_API_ENDPOINT = 'archives/'


Modified: trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py (221800 => 221801)

--- trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py	2017-09-08 22:09:17 UTC (rev 221800)
+++ trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py	2017-09-08 23:00:54 UTC (rev 221801)
@@ -106,7 +106,13 @@
 self.install_chromedriver()
 elif '.geckodriver' in fullname:
 self.install_geckodriver()
+elif '.requests' in fullname:
+self._install_requests()
 
+def _install_requests(self):
+self._install("https://pypi.python.org/packages/b0/e1/eab4fc3752e3d240468a8c0b284607899d2fbfb236a56b7377a329aa8d09/requests-2.18.4.tar.gz#md5=081412b2ef79bdc48229891af13f4d82",
+ "requests-2.18.4/requests")
+
 def _install_mechanize(self):
 self._install("http://pypi.python.org/packages/source/m/mechanize/mechanize-0.2.5.tar.gz",
  "mechanize-0.2.5/mechanize")


Modified: trunk/Tools/Scripts/webkitpy/thirdparty/__init___unittest.py (221800 => 221801)

--- trunk/Tools/Scripts/webkitpy/thirdparty/__init___unittest.py	2017-09-08 22:09:17 UTC (rev 221800)
+++ trunk/Tools/Scripts/webkitpy/thirdparty/__init___unittest.py	2017-09-08 23:00:54 UTC (rev 221801)
@@ -63,3 +63,4 @@
 import webkitpy.thirdparty.autoinstalled.mechanize
 import webkitpy.thirdparty.autoinstalled.pylint
 import webkitpy.thirdparty.autoinstalled.pep8
+import webkitpy.thirdparty.autoinstalled.requests






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221792] trunk/Tools/ChangeLog

2017-09-08 Thread lforschler

Title: [221792] trunk/Tools/ChangeLog








Revision 221792
Author lforsch...@apple.com
Date 2017-09-08 11:55:48 -0700 (Fri, 08 Sep 2017)


Log Message
Test commit to verify trac sync is working.

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (221791 => 221792)

--- trunk/Tools/ChangeLog	2017-09-08 18:46:34 UTC (rev 221791)
+++ trunk/Tools/ChangeLog	2017-09-08 18:55:48 UTC (rev 221792)
@@ -1,5 +1,9 @@
 2017-09-08  Lucas Forschler  
 
+Test commit to verify trac sync is working.
+
+2017-09-08  Lucas Forschler  
+
 Test commit to verify git sync is working.
 
 2017-09-08  Lucas Forschler  






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221790] trunk/Tools/ChangeLog

2017-09-08 Thread lforschler

Title: [221790] trunk/Tools/ChangeLog








Revision 221790
Author lforsch...@apple.com
Date 2017-09-08 11:45:06 -0700 (Fri, 08 Sep 2017)


Log Message
Test commit to verify git sync is working.

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (221789 => 221790)

--- trunk/Tools/ChangeLog	2017-09-08 17:25:40 UTC (rev 221789)
+++ trunk/Tools/ChangeLog	2017-09-08 18:45:06 UTC (rev 221790)
@@ -1,5 +1,9 @@
 2017-09-08  Lucas Forschler  
 
+Test commit to verify git sync is working.
+
+2017-09-08  Lucas Forschler  
+
 bisect-builds should not print out extracting command
 https://bugs.webkit.org/show_bug.cgi?id=175632
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221789] trunk/Tools

2017-09-08 Thread lforschler

Title: [221789] trunk/Tools








Revision 221789
Author lforsch...@apple.com
Date 2017-09-08 10:25:40 -0700 (Fri, 08 Sep 2017)


Log Message
bisect-builds should not print out extracting command
https://bugs.webkit.org/show_bug.cgi?id=175632

Reviewed by Alexey Proskuryakov.

* Scripts/bisect-builds:
(extract_archive):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/bisect-builds




Diff

Modified: trunk/Tools/ChangeLog (221788 => 221789)

--- trunk/Tools/ChangeLog	2017-09-08 16:35:45 UTC (rev 221788)
+++ trunk/Tools/ChangeLog	2017-09-08 17:25:40 UTC (rev 221789)
@@ -1,3 +1,13 @@
+2017-09-08  Lucas Forschler  
+
+bisect-builds should not print out extracting command
+https://bugs.webkit.org/show_bug.cgi?id=175632
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/bisect-builds:
+(extract_archive):
+
 2017-09-07  Joseph Pecoraro  
 
 WebKit should claim that it can show responses for a broader range of JSON MIMETypes


Modified: trunk/Tools/Scripts/bisect-builds (221788 => 221789)

--- trunk/Tools/Scripts/bisect-builds	2017-09-08 16:35:45 UTC (rev 221788)
+++ trunk/Tools/Scripts/bisect-builds	2017-09-08 17:25:40 UTC (rev 221789)
@@ -71,7 +71,6 @@
 
 def extract_archive(options):
 command = ['python', '../BuildSlaveSupport/built-product-archive', '--platform', options.platform, '--%s' % options.configuration, 'extract']
-print('Extracting archive: {}'.format(command))
 subprocess.check_call(command)
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221775] trunk/Tools/ChangeLog

2017-09-07 Thread lforschler

Title: [221775] trunk/Tools/ChangeLog








Revision 221775
Author lforsch...@apple.com
Date 2017-09-07 18:49:23 -0700 (Thu, 07 Sep 2017)


Log Message
Test commit after server upgrade from subversion 1.9.5 to 1.9.7

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (221774 => 221775)

--- trunk/Tools/ChangeLog	2017-09-08 01:14:58 UTC (rev 221774)
+++ trunk/Tools/ChangeLog	2017-09-08 01:49:23 UTC (rev 221775)
@@ -1,3 +1,7 @@
+2017-09-07  Lucas Forschler  
+
+Test commit after server upgrade from subversion 1.9.5 to 1.9.7
+
 2017-09-07  Chris Dumez  
 
 [WK2] Add C API to retrieve the originating page of a WKDownload






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221741] trunk/Tools

2017-09-07 Thread lforschler

Title: [221741] trunk/Tools








Revision 221741
Author lforsch...@apple.com
Date 2017-09-07 10:56:27 -0700 (Thu, 07 Sep 2017)


Log Message
bisect-builds started failing with invalid json
https://bugs.webkit.org/show_bug.cgi?id=176478

Once we hit 1000 items in our dynamoDB, we ran into an upper limit on the AWS API Gateway looping mechanism. 
This prevented us from doing a body mapping template to reformat the json. This fix is to simply return the raw json, 
and adjust the json parsing in our code. The AWS rest API has been fixed, and updated to v2. 

This change is for the script which operates against the endpoint.

Reviewed by Aakash Jain.

* Scripts/bisect-builds:
(get_sorted_revisions):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/bisect-builds




Diff

Modified: trunk/Tools/ChangeLog (221740 => 221741)

--- trunk/Tools/ChangeLog	2017-09-07 17:53:50 UTC (rev 221740)
+++ trunk/Tools/ChangeLog	2017-09-07 17:56:27 UTC (rev 221741)
@@ -1,3 +1,19 @@
+2017-09-07  Lucas Forschler  
+
+bisect-builds started failing with invalid json
+https://bugs.webkit.org/show_bug.cgi?id=176478
+
+Once we hit 1000 items in our dynamoDB, we ran into an upper limit on the AWS API Gateway looping mechanism. 
+This prevented us from doing a body mapping template to reformat the json. This fix is to simply return the raw json, 
+and adjust the json parsing in our code. The AWS rest API has been fixed, and updated to v2. 
+
+This change is for the script which operates against the endpoint.
+
+Reviewed by Aakash Jain.
+
+* Scripts/bisect-builds:
+(get_sorted_revisions):
+
 2017-09-07  Filip Pizlo  
 
 [WSL] Rationalize how protocol inheritance deals with type parameters


Modified: trunk/Tools/Scripts/bisect-builds (221740 => 221741)

--- trunk/Tools/Scripts/bisect-builds	2017-09-07 17:53:50 UTC (rev 221740)
+++ trunk/Tools/Scripts/bisect-builds	2017-09-07 17:56:27 UTC (rev 221741)
@@ -37,7 +37,7 @@
 import tempfile
 import urlparse
 
-REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v1/'
+REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2/'
 REST_API_ENDPOINT = 'archives/'
 REST_API_MINIFIED_ENDPOINT = 'minified-archives/'
 
@@ -120,7 +120,7 @@
 
 
 def get_sorted_revisions(revisions_dict):
-revisions = [int(revision['revision']) for revision in revisions_dict['revisions']]
+revisions = [int(item['revision']['N']) for item in revisions_dict['revisions']['Items']]
 return sorted(revisions)
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220537] trunk/Tools

2017-08-10 Thread lforschler

Title: [220537] trunk/Tools








Revision 220537
Author lforsch...@apple.com
Date 2017-08-10 11:57:22 -0700 (Thu, 10 Aug 2017)


Log Message
Fix duplicated code from r220534.

Unreviewed cleanup.

* Scripts/bisect-builds:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/bisect-builds




Diff

Modified: trunk/Tools/ChangeLog (220536 => 220537)

--- trunk/Tools/ChangeLog	2017-08-10 18:47:56 UTC (rev 220536)
+++ trunk/Tools/ChangeLog	2017-08-10 18:57:22 UTC (rev 220537)
@@ -1,3 +1,11 @@
+2017-08-10  Lucas Forschler  
+
+Fix duplicated code in r220534.
+
+Unreviewed cleanup.
+
+* Scripts/bisect-builds:
+
 2017-08-08  Jiewen Tan  
 
 [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS


Modified: trunk/Tools/Scripts/bisect-builds (220536 => 220537)

--- trunk/Tools/Scripts/bisect-builds	2017-08-10 18:47:56 UTC (rev 220536)
+++ trunk/Tools/Scripts/bisect-builds	2017-08-10 18:57:22 UTC (rev 220537)
@@ -240,487 +240,3 @@
 exit("Aborting.")
 finally:
 shutil.rmtree(webkit_output_dir, ignore_errors=True)
-#!/usr/bin/env python
-
-# Copyright (C) 2017 Apple Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-#
-# 1.  Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer. 
-# 2.  Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution. 
-# 3.  Neither the name of Apple Inc. ("Apple") nor the names of
-# its contributors may be used to endorse or promote products derived
-# from this software without specific prior written permission. 
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
-# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
-# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
-# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
-# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-import argparse
-import bisect
-import math
-import os
-import requests
-import shutil
-import subprocess
-import sys
-import tempfile
-import urlparse
-
-REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v1/'
-REST_API_ENDPOINT = 'archives/'
-REST_API_MINIFIED_ENDPOINT = 'minified-archives/'
-
-
-def bisect_builds(revision_list, start_index, end_index, options):
-while True:
-index_to_test = pick_next_build(revision_list, start_index, end_index)
-if index_to_test == None:
-print('No more builds to test...')
-exit(1)
-download_archive(options, revision_list[index_to_test])
-extract_archive(options)
-reproduces = test_archive(options, revision_list[index_to_test])
-
-if reproduces:  # bisect left
-index_to_test -= 1  # We can remove this from the end of the list of builds to test
-bisect_builds(revision_list, start_index, index_to_test, options)
-if not reproduces:  # bisect right
-index_to_test += 1  # We can remove this from the start of the list of builds to test
-bisect_builds(revision_list, index_to_test, end_index, options)
-
-
-def download_archive(options, revision):
-api_url = get_api_url(options)
-s3_url = get_s3_location_for_revision(api_url, revision)
-print('Archive URL: {}'.format(s3_url))
-command = ['python', '../BuildSlaveSupport/download-built-product', '--{}'.format(options.configuration), '--platform', options.platform, s3_url]
-print('Downloading revision: {}'.format(revision))
-subprocess.check_call(command)
-
-
-def extract_archive(options):
-command = ['python', '../BuildSlaveSupport/built-product-archive', '--platform', options.platform, '--%s' % options.configuration, 'extract']
-print('Extracting archive: {}'.format(command))
-subprocess.check_call(command)
-
-
-#  bisect helpers from https://docs.python.org/2/library/bisect.html 
-def find_le(a, x):
-"""Find rightmost value less than or equal to x"""
-i = bisect.bisect_right(a, x)
-if i:
-return i - 1
-raise ValueError
-
-
-def find_ge(a, x):
-"""Find leftmost item greater than or equal to x"""
-i = bisect.bisect_left(a, x)
-if i != len(a):
-return i
-raise ValueError
-#

[webkit-changes] [220534] trunk/Tools

2017-08-10 Thread lforschler

Title: [220534] trunk/Tools








Revision 220534
Author lforsch...@apple.com
Date 2017-08-10 11:22:01 -0700 (Thu, 10 Aug 2017)


Log Message
Write a tool to bisect WebKit builds
https://bugs.webkit.org/show_bug.cgi?id=174596

Reviewed by Dean Johnson and Kocsen Chung.

* Scripts/bisect-builds: Added.
(bisect_builds): main bisection algorithm
(download_archive):download an archive from S3 using existing tools
(extract_archive):extract an archive using existing tools
(find_le):Find rightmost value less than or equal to x
(find_ge):Find leftmost item greater than or equal to x
(get_api_url):generate url for the rest api/database
(get_indices_from_revisions):convert revisions to list indexes for bisection
(get_sorted_revisions):retrieve sorted revision list
(get_s3_location_for_revision):calculate the S3 archive storage location
(parse_args):parse command line arguments
(pick_next_build):compute the next build to bisect
(prompt_did_reproduce):prompt user for direction for bisection
(set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
(test_archive):Platform specific logic to test downloaded archive
(minified_platforms):return a list of minified platforms in the database
(unminified_platforms):return a list of full platforms in the database
(is_supported_platform):check if platform is supported
(validate_options):validate command line options
(main):

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/Scripts/bisect-builds




Diff

Modified: trunk/Tools/ChangeLog (220533 => 220534)

--- trunk/Tools/ChangeLog	2017-08-10 18:17:07 UTC (rev 220533)
+++ trunk/Tools/ChangeLog	2017-08-10 18:22:01 UTC (rev 220534)
@@ -1,5 +1,33 @@
 2017-08-10  Lucas Forschler  
 
+Write a tool to bisect WebKit builds
+https://bugs.webkit.org/show_bug.cgi?id=174596
+
+Reviewed by Dean Johnson and Kocsen Chung.
+
+* Scripts/bisect-builds: Added.
+(bisect_builds): main bisection algorithm
+(download_archive):download an archive from S3 using existing tools
+(extract_archive):extract an archive using existing tools
+(find_le):Find rightmost value less than or equal to x
+(find_ge):Find leftmost item greater than or equal to x
+(get_api_url):generate url for the rest api/database
+(get_indices_from_revisions):convert revisions to list indexes for bisection
+(get_sorted_revisions):retrieve sorted revision list
+(get_s3_location_for_revision):calculate the S3 archive storage location
+(parse_args):parse command line arguments
+(pick_next_build):compute the next build to bisect
+(prompt_did_reproduce):prompt user for direction for bisection
+(set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
+(test_archive):Platform specific logic to test downloaded archive
+(minified_platforms):return a list of minified platforms in the database
+(unminified_platforms):return a list of full platforms in the database
+(is_supported_platform):check if platform is supported
+(validate_options):validate command line options
+(main):
+
+2017-08-10  Lucas Forschler  
+
 Remove bisect-builds script.
 https://bugs.webkit.org/show_bug.cgi?id=175433
 


Added: trunk/Tools/Scripts/bisect-builds (0 => 220534)

--- trunk/Tools/Scripts/bisect-builds	(rev 0)
+++ trunk/Tools/Scripts/bisect-builds	2017-08-10 18:22:01 UTC (rev 220534)
@@ -0,0 +1,726 @@
+#!/usr/bin/env python
+
+# Copyright (C) 2017 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer. 
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution. 
+# 3.  Neither the name of Apple Inc. ("Apple") nor the names of
+# its contributors may be used to endorse or promote products derived
+# from this software without specific prior written permission. 
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+# ON ANY THEORY OF LIABILITY, WHETHER IN CONTR

[webkit-changes] [220533] trunk/Tools

2017-08-10 Thread lforschler

Title: [220533] trunk/Tools








Revision 220533
Author lforsch...@apple.com
Date 2017-08-10 11:17:07 -0700 (Thu, 10 Aug 2017)


Log Message
Remove bisect-builds script.
https://bugs.webkit.org/show_bug.cgi?id=175433

Reviewed by Aakash Jain.

* Scripts/bisect-builds: Removed.

Modified Paths

trunk/Tools/ChangeLog


Removed Paths

trunk/Tools/Scripts/bisect-builds




Diff

Modified: trunk/Tools/ChangeLog (220532 => 220533)

--- trunk/Tools/ChangeLog	2017-08-10 17:04:46 UTC (rev 220532)
+++ trunk/Tools/ChangeLog	2017-08-10 18:17:07 UTC (rev 220533)
@@ -1,3 +1,12 @@
+2017-08-10  Lucas Forschler  
+
+Remove bisect-builds script.
+https://bugs.webkit.org/show_bug.cgi?id=175433
+
+Reviewed by Aakash Jain.
+
+* Scripts/bisect-builds: Removed.
+
 2017-08-10  Michael Catanzaro  
 
 Remove ENABLE_GAMEPAD_DEPRECATED


Deleted: trunk/Tools/Scripts/bisect-builds (220532 => 220533)

--- trunk/Tools/Scripts/bisect-builds	2017-08-10 17:04:46 UTC (rev 220532)
+++ trunk/Tools/Scripts/bisect-builds	2017-08-10 18:17:07 UTC (rev 220533)
@@ -1,504 +0,0 @@
-#!/usr/bin/perl -w
-
-# Copyright (C) 2007-2009, 2011-2015 Apple Inc.  All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-#
-# 1.  Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer. 
-# 2.  Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution. 
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
-# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
-# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
-# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
-# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-# This script attempts to find the point at which a regression (or progression)
-# of behavior occurred by searching WebKit nightly builds.
-
-# To override the location where the nightly builds are downloaded or the path
-# to the Safari web browser, create a ~/.bisect-buildsrc file with one or more of
-# the following lines (use "~/" to specify a path from your home directory):
-#
-# $branch = "branch-name";
-# $nightlyDownloadDirectory = "~/path/to/nightly/downloads";
-# $safariPath = "/path/to/Safari.app";
-
-use strict;
-
-use File::Basename;
-use File::Path;
-use File::Spec;
-use File::Temp qw(tempfile);
-use FindBin;
-use Getopt::Long;
-use Time::HiRes qw(usleep);
-
-use lib $FindBin::Bin;
-use webkitdirs qw(safariPathFromSafariBundle);
-
-use constant {
-PROMPT_RESPONSE_BROKEN => -1,
-PROMPT_RESPONSE_NO => 0,
-PROMPT_RESPONSE_RETRY => 2,
-PROMPT_RESPONSE_YES => 1,
-};
-
-sub createTempFile($);
-sub downloadNightly($$$);
-sub findMacOSXVersion();
-sub findNearestNightlyIndex(\@$$);
-sub findSafariVersion($);
-sub loadSettings();
-sub makeNightlyList();
-sub max($$) { return $_[0] > $_[1] ? $_[0] : $_[1]; }
-sub mountAndRunNightly();
-sub parseRevisions($$;$);
-sub printStatus($$$);
-sub printTracLink($$);
-sub promptForTest($);
-
-loadSettings();
-
-my %validBranches = map { $_ => 1 } qw(feature-branch trunk);
-my $branch = $Settings::branch;
-my $nightlyDownloadDirectory = $Settings::nightlyDownloadDirectory;
-my $safariPath = $Settings::safariPath;
-my $applicationPath;
-
-my @nightlies;
-
-my $isProgression;
-my $localOnly;
-my @revisions;
-my $sanityCheck;
-my $showHelp;
-my $testURL;
-
-# Fix up -r switches in @ARGV
-@ARGV = map { /^(-r)(.+)$/ ? ($1, $2) : $_ } @ARGV;
-
-my $result = GetOptions(
-sharedCommandLineOptions(),
-"b|branch=s" => \$branch,
-"a|application=s"=> \$applicationPath,
-"d|download-directory=s" => \$nightlyDownloadDirectory,
-"h|help" => \$showHelp,
-"l|local!"   => \$localOnly,
-"p|progression!" => \$isProgression,
-"r|revisions=s"  => \&parseRevisions,
-"safari-path=s"  => \$safariPath,
-"s|sanity-check!"=> \$sanityCheck,
-);
-$testURL = shift @ARGV;
-
-$branch = "feature-branch" if $branch eq "feature";
-if (!exists $validBranches{$branch}) {
-print STDERR "ERROR: Invalid branch '$branch'\n";
-$showHelp = 1;
-}
-
-if (!$result || $showHelp || scalar(@ARGV) > 0) {
-print

[webkit-changes] [220283] trunk/Tools

2017-08-04 Thread lforschler

Title: [220283] trunk/Tools








Revision 220283
Author lforsch...@apple.com
Date 2017-08-04 12:03:27 -0700 (Fri, 04 Aug 2017)


Log Message
minification logic is not implemented for ios builds


Reviewed by Dean Johnson

* BuildSlaveSupport/built-product-archive:
(minifyDirectory): refactor minifySource -> minifyDirectory
(archiveBuiltProduct): add ios minification logic
(minifySource): Deleted.

Modified Paths

trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (220282 => 220283)

--- trunk/Tools/BuildSlaveSupport/built-product-archive	2017-08-04 19:01:00 UTC (rev 220282)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive	2017-08-04 19:03:27 UTC (rev 220283)
@@ -173,11 +173,11 @@
 return False
 
 
-def minifySource(platform):
-if platform == 'mac':
+def minifyDirectory(platform, directory):
+if platform == 'mac' or platform == 'ios':
 dir_patterns = ('.dSYM', 'DerivedSources')
 file_patterns = ('.a',)
-for root, dirs, files in os.walk(_configurationBuildDirectory):
+for root, dirs, files in os.walk(directory):
 if any(root.endswith(pattern) for pattern in dir_patterns):
 print 'Removing: {}'.format(root)
 shutil.rmtree(root)
@@ -194,16 +194,18 @@
 combinedDirectory = os.path.join(_topLevelBuildDirectory, 'combined-mac-and-ios')
 removeDirectoryIfExists(combinedDirectory)
 os.makedirs(combinedDirectory)
-
+if minify:
+minifyDirectory(platform, _configurationBuildDirectory)
+minifyDirectory(platform, _hostBuildDirectory)
 if subprocess.call(['/bin/cp', '-pR', _configurationBuildDirectory, combinedDirectory]):
 return 1
 if subprocess.call(['/bin/cp', '-pR', _hostBuildDirectory, combinedDirectory]):
 return 1
 
-return createZip(combinedDirectory, configuration)
+return createZip(combinedDirectory, configuration, minify=minify)
 elif platform == 'mac':
 if minify:
-minifySource(platform)
+minifyDirectory(platform, _configurationBuildDirectory)
 return createZip(_configurationBuildDirectory, configuration, embedParentDirectoryNameOnDarwin=True, minify=minify)
 elif platform == 'win':
 # FIXME: We shouldn't hardcode the assumption of a 32-bit build. See .


Modified: trunk/Tools/ChangeLog (220282 => 220283)

--- trunk/Tools/ChangeLog	2017-08-04 19:01:00 UTC (rev 220282)
+++ trunk/Tools/ChangeLog	2017-08-04 19:03:27 UTC (rev 220283)
@@ -1,3 +1,15 @@
+2017-08-04  Lucas Forschler  
+
+minification logic is not implemented for ios builds
+
+
+Reviewed by Dean Johnson
+
+* BuildSlaveSupport/built-product-archive:
+(minifyDirectory): refactor minifySource -> minifyDirectory
+(archiveBuiltProduct): add ios minification logic
+(minifySource): Deleted.
+
 2017-08-04  Matt Lewis  
 
 Unreviewed, rolling out r220271.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220238] trunk/Tools

2017-08-03 Thread lforschler

Title: [220238] trunk/Tools








Revision 220238
Author lforsch...@apple.com
Date 2017-08-03 16:17:41 -0700 (Thu, 03 Aug 2017)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=174718

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (220237 => 220238)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-08-03 23:11:22 UTC (rev 220237)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-08-03 23:17:41 UTC (rev 220238)
@@ -894,7 +894,7 @@
 if triggers:
 self.addStep(ArchiveBuiltProduct())
 self.addStep(UploadBuiltProduct())
-if platform.startswith('mac'):
+if platform.startswith('mac') or platform.startswith('ios-simulator'):
 self.addStep(ArchiveMinifiedBuiltProduct())
 self.addStep(UploadMinifiedBuiltProduct())
 self.addStep(TransferToS3())


Modified: trunk/Tools/ChangeLog (220237 => 220238)

--- trunk/Tools/ChangeLog	2017-08-03 23:11:22 UTC (rev 220237)
+++ trunk/Tools/ChangeLog	2017-08-03 23:17:41 UTC (rev 220238)
@@ -1,3 +1,13 @@
+2017-08-03  Lucas Forschler  
+
+Enable archive minification on iOS builds
+https://bugs.webkit.org/show_bug.cgi?id=174718
+
+Reviewed by Aakash Jain.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(BuildFactory.__init__):
+
 2017-08-03  Carlos Alberto Lopez Perez  
 
 [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220166] trunk/Tools

2017-08-02 Thread lforschler

Title: [220166] trunk/Tools








Revision 220166
Author lforsch...@apple.com
Date 2017-08-02 18:32:27 -0700 (Wed, 02 Aug 2017)


Log Message


Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (220165 => 220166)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-08-03 01:32:07 UTC (rev 220165)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-08-03 01:32:27 UTC (rev 220166)
@@ -24,6 +24,7 @@
 from committer_auth import CommitterAuth
 import wkbuild
 
+APPLE_WEBKIT_AWS_PROXY = "http://54.190.50.182:873"
 S3URL = "https://s3-us-west-2.amazonaws.com/"
 
 c = BuildmasterConfig = {}
@@ -317,7 +318,12 @@
 haltOnFailure = True
 flunkOnFailure = True
 
+def start(self):
+if 'apple' in self.getProperty('buildername').lower():
+self.slaveEnvironment['HTTPS_PROXY'] = APPLE_WEBKIT_AWS_PROXY  # curl env var to use a proxy
+return shell.ShellCommand.start(self)
 
+
 class RunJavaScriptCoreTests(TestWithFailureCount):
 name = "jscore-test"
 description = ["jscore-tests running"]


Modified: trunk/Tools/ChangeLog (220165 => 220166)

--- trunk/Tools/ChangeLog	2017-08-03 01:32:07 UTC (rev 220165)
+++ trunk/Tools/ChangeLog	2017-08-03 01:32:27 UTC (rev 220166)
@@ -1,3 +1,14 @@
+2017-08-02  Lucas Forschler  
+
+download-built-product should allow for a proxy option
+https://bugs.webkit.org/show_bug.cgi?id=174875
+
+Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
+
+
 2017-08-02  Jonathan Bedard  
 
 check-webkit-style: deleting lines in a file runs the linter on the whole file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219358] trunk/Tools

2017-07-11 Thread lforschler

Title: [219358] trunk/Tools








Revision 219358
Author lforsch...@apple.com
Date 2017-07-11 13:42:11 -0700 (Tue, 11 Jul 2017)


Log Message
Teach build workers to fetch archives from S3.
https://bugs.webkit.org/show_bug.cgi?id=174384

Reviewed by Aakash Jain.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DownloadBuiltProduct):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (219357 => 219358)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-07-11 20:38:11 UTC (rev 219357)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-07-11 20:42:11 UTC (rev 219358)
@@ -24,6 +24,7 @@
 from committer_auth import CommitterAuth
 import wkbuild
 
+S3URL = "https://s3-us-west-2.amazonaws.com/"
 
 c = BuildmasterConfig = {}
 
@@ -309,7 +310,7 @@
 class DownloadBuiltProduct(shell.ShellCommand):
 command = ["python", "./Tools/BuildSlaveSupport/download-built-product",
 WithProperties("--platform=%(platform)s"), WithProperties("--%(configuration)s"),
-WithProperties(c["buildbotURL"] + "archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(got_revision)s.zip")]
+WithProperties(S3URL + "archives.webkit.org/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(got_revision)s.zip")]
 name = "download-built-product"
 description = ["downloading built product"]
 descriptionDone = ["downloaded built product"]


Modified: trunk/Tools/ChangeLog (219357 => 219358)

--- trunk/Tools/ChangeLog	2017-07-11 20:38:11 UTC (rev 219357)
+++ trunk/Tools/ChangeLog	2017-07-11 20:42:11 UTC (rev 219358)
@@ -1,5 +1,15 @@
 2017-07-11  Lucas Forschler  
 
+Teach build workers to fetch archives from S3.
+https://bugs.webkit.org/show_bug.cgi?id=174384
+
+Reviewed by Aakash Jain.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(DownloadBuiltProduct):
+
+2017-07-11  Lucas Forschler  
+
 Configure buildbot to transfer all archives to S3.
 Previously this was Mac only, but it's time to expand!
 https://bugs.webkit.org/show_bug.cgi?id=174378






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219351] trunk/Tools

2017-07-11 Thread lforschler

Title: [219351] trunk/Tools








Revision 219351
Author lforsch...@apple.com
Date 2017-07-11 11:48:08 -0700 (Tue, 11 Jul 2017)


Log Message
Configure buildbot to transfer all archives to S3.
Previously this was Mac only, but it's time to expand!
https://bugs.webkit.org/show_bug.cgi?id=174378

Reviewed by Aakash Jain.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildFactory.__init__):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (219350 => 219351)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-07-11 18:37:47 UTC (rev 219350)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-07-11 18:48:08 UTC (rev 219351)
@@ -885,7 +885,7 @@
 if platform.startswith('mac'):
 self.addStep(ArchiveMinifiedBuiltProduct())
 self.addStep(UploadMinifiedBuiltProduct())
-self.addStep(TransferToS3())
+self.addStep(TransferToS3())
 self.addStep(trigger.Trigger(schedulerNames=triggers))
 
 def pickLatestBuild(builder, requests):


Modified: trunk/Tools/ChangeLog (219350 => 219351)

--- trunk/Tools/ChangeLog	2017-07-11 18:37:47 UTC (rev 219350)
+++ trunk/Tools/ChangeLog	2017-07-11 18:48:08 UTC (rev 219351)
@@ -1,3 +1,14 @@
+2017-07-11  Lucas Forschler  
+
+Configure buildbot to transfer all archives to S3.
+Previously this was Mac only, but it's time to expand!
+https://bugs.webkit.org/show_bug.cgi?id=174378
+
+Reviewed by Aakash Jain.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(BuildFactory.__init__):
+
 2017-07-11  Zan Dobersek  
 
 [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219246] trunk/Tools/ChangeLog

2017-07-06 Thread lforschler

Title: [219246] trunk/Tools/ChangeLog








Revision 219246
Author lforsch...@apple.com
Date 2017-07-06 22:57:34 -0700 (Thu, 06 Jul 2017)


Log Message
Write a support script to enable buildbot to upload to S3
https://bugs.webkit.org/show_bug.cgi?id=174196

Reviewed by Stephanie Lewis.

* BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
(uploadToS3):
(archiveExists):

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (219245 => 219246)

--- trunk/Tools/ChangeLog	2017-07-07 05:53:39 UTC (rev 219245)
+++ trunk/Tools/ChangeLog	2017-07-07 05:57:34 UTC (rev 219246)
@@ -1,5 +1,16 @@
 2017-07-06  Lucas Forschler  
 
+Write a support script to enable buildbot to upload to S3
+https://bugs.webkit.org/show_bug.cgi?id=174196
+
+Reviewed by Stephanie Lewis.
+
+* BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
+(uploadToS3):
+(archiveExists):
+
+2017-07-06  Lucas Forschler  
+
 Enabling uploading archives to S3.
 https://bugs.webkit.org/show_bug.cgi?id=174198
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219240] trunk/Tools

2017-07-06 Thread lforschler

Title: [219240] trunk/Tools








Revision 219240
Author lforsch...@apple.com
Date 2017-07-06 22:10:38 -0700 (Thu, 06 Jul 2017)


Log Message
Enabling uploading archives to S3.
https://bugs.webkit.org/show_bug.cgi?id=174198

Reviewed by Stephanie Lewis.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
(UploadMinifiedBuiltProduct): Upload minified archive to build master
(TransferToS3): Transfer full and minified archives to S3

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3




Diff

Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3 (0 => 219240)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3	2017-07-07 05:10:38 UTC (rev 219240)
@@ -0,0 +1,41 @@
+#!/usr/bin/env python
+import argparse
+import boto3
+import os
+import os.path
+import sys
+
+S3_BUCKET = 'archives.webkit.org'
+S3_MINIFIED_BUCKET = 'minified-archives.webkit.org'
+S3_REGION_PREFIX = 'https://s3-us-west-2.amazonaws.com'
+
+def uploadToS3(archive_path, bucket, identifier, revision):
+print 'Transferring {} to S3...'.format(archive_path)
+key = '/'.join([identifier, revision + '.zip'])
+print '\tS3 Bucket: {}\n\tS3 Key: {}'.format(bucket, key)
+s3.upload_file(archive_path, bucket, key)
+print('\tS3 URL: {}/{}/{}'.format(S3_REGION_PREFIX, bucket, key))
+
+def archiveExists(archive):
+if archive:
+if os.path.exists(archive):
+	return True
+else:
+print 'WARNING: Archive does not exist: {}'.format(archive)
+return False
+	
+parser = argparse.ArgumentParser(add_help=True)
+parser.add_argument('--revision', action="" required=True, help='Revision number for the built archive')
+parser.add_argument('--identifier', action="" required=True, help='S3 destination identifier, in the form of fullPlatform-architecture-configuration. [mac-sierra-x86_64-release]')
+parser.add_argument('--archive', action="" required=True, help='Path to the full size archive. [path/to/123456.zip]')
+args = parser.parse_args()
+
+
+head, tail = os.path.split(str(args.archive))
+minifiedArchive = head + '/minified-' + tail
+s3 = boto3.client('s3')
+
+if archiveExists(args.archive):
+uploadToS3(args.archive, S3_BUCKET, args.identifier, args.revision)
+if archiveExists(minifiedArchive):
+uploadToS3(minifiedArchive, S3_MINIFIED_BUCKET, args.identifier, args.revision)
\ No newline at end of file


Modified: trunk/Tools/ChangeLog (219239 => 219240)

--- trunk/Tools/ChangeLog	2017-07-07 05:08:22 UTC (rev 219239)
+++ trunk/Tools/ChangeLog	2017-07-07 05:10:38 UTC (rev 219240)
@@ -1,3 +1,15 @@
+2017-07-06  Lucas Forschler  
+
+Enabling uploading archives to S3.
+https://bugs.webkit.org/show_bug.cgi?id=174198
+
+Reviewed by Stephanie Lewis.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
+(UploadMinifiedBuiltProduct): Upload minified archive to build master
+(TransferToS3): Transfer full and minified archives to S3
+
 2017-07-05  Yusuke Suzuki  
 
 [WTF] Implement WTF::ThreadGroup






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219235] trunk/Tools

2017-07-06 Thread lforschler

Title: [219235] trunk/Tools








Revision 219235
Author lforsch...@apple.com
Date 2017-07-06 21:13:35 -0700 (Thu, 06 Jul 2017)


Log Message
Enabling uploading archives to S3.
https://bugs.webkit.org/show_bug.cgi?id=174198

Reviewed by Lucas Forschler.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
(UploadMinifiedBuiltProduct): Upload minified archive to build master
(TransferToS3): Transfer full and minified archives to S3

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (219234 => 219235)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-07-07 03:37:17 UTC (rev 219234)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-07-07 04:13:35 UTC (rev 219235)
@@ -129,6 +129,7 @@
 source.SVN.__init__(self, **kwargs)
 self.addFactoryArguments(SVNMirror=SVNMirror)
 
+
 class WaitForSVNServer(shell.ShellCommand):
 name = "wait-for-svn-server"
 command = ["python", "./Tools/BuildSlaveSupport/wait-for-SVN-server.py", "-r", WithProperties("%(revision)s"), "-s", WithProperties("%(SVNMirror)s")]
@@ -141,11 +142,13 @@
 return WARNINGS
 return SUCCESS
 
+
 class InstallWin32Dependencies(shell.Compile):
 description = ["installing dependencies"]
 descriptionDone = ["installed dependencies"]
 command = ["perl", "./Tools/Scripts/update-webkit-auxiliary-libs"]
 
+
 class KillOldProcesses(shell.Compile):
 name = "kill old processes"
 description = ["killing old processes"]
@@ -152,6 +155,7 @@
 descriptionDone = ["killed old processes"]
 command = ["python", "./Tools/BuildSlaveSupport/kill-old-processes", "buildbot"]
 
+
 class CleanBuildIfScheduled(shell.Compile):
 name = "delete WebKitBuild directory"
 description = ["deleting WebKitBuild directory"]
@@ -164,6 +168,7 @@
 return SKIPPED
 return shell.Compile.start(self)
 
+
 class DeleteStaleBuildFiles(shell.Compile):
 name = "delete stale build files"
 description = ["deleting stale build files"]
@@ -176,6 +181,7 @@
 return SKIPPED
 return shell.Compile.start(self)
 
+
 class InstallGtkDependencies(shell.ShellCommand):
 name = "jhbuild"
 description = ["updating gtk dependencies"]
@@ -183,6 +189,7 @@
 command = ["perl", "./Tools/Scripts/update-webkitgtk-libs"]
 haltOnFailure = True
 
+
 class InstallWpeDependencies(shell.ShellCommand):
 name = "jhbuild"
 description = ["updating wpe dependencies"]
@@ -199,6 +206,7 @@
 platform = 'device'
 step.setCommand(step.command + ['--' + platform])
 
+
 class CompileWebKit(shell.Compile):
 command = ["perl", "./Tools/Scripts/build-webkit", WithProperties("--%(configuration)s")]
 env = {'MFLAGS':''}
@@ -248,12 +256,15 @@
 class CompileLLINTCLoop(CompileWebKit):
 command = ["perl", "./Tools/Scripts/build-jsc", "--cloop", WithProperties("--%(configuration)s")]
 
+
 class Compile32bitJSC(CompileWebKit):
 command = ["perl", "./Tools/Scripts/build-jsc", "--32-bit", WithProperties("--%(configuration)s")]
 
+
 class CompileJSCOnly(CompileWebKit):
 command = ["perl", "./Tools/Scripts/build-jsc", WithProperties("--%(configuration)s")]
 
+
 class ArchiveBuiltProduct(shell.ShellCommand):
 command = ["python", "./Tools/BuildSlaveSupport/built-product-archive",
WithProperties("--platform=%(fullPlatform)s"), WithProperties("--%(configuration)s"), "archive"]
@@ -263,6 +274,11 @@
 haltOnFailure = True
 
 
+class ArchiveMinifiedBuiltProduct(ArchiveBuiltProduct):
+command = ["python", "./Tools/BuildSlaveSupport/built-product-archive",
+   WithProperties("--platform=%(fullPlatform)s"), WithProperties("--%(configuration)s"), "archive", "--minify"]
+
+
 class ExtractBuiltProduct(shell.ShellCommand):
 command = ["python", "./Tools/BuildSlaveSupport/built-product-archive",
WithProperties("--platform=%(fullPlatform)s"), WithProperties("--%(configuration)s"), "extract"]
@@ -285,6 +301,11 @@
 transfer.FileUpload.__init__(self, **kwargs)
 
 
+class UploadMinifiedBuiltProduct(UploadBuiltProduct):
+slavesrc = WithProperties("WebKitBuild/minified-%(configuration)s.zip")
+masterdest = WithProperties("archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/minified-%(got_revision)s.zip")
+
+
 class DownloadBuiltProduct(shell.ShellCommand):
 command = ["python", "./Tools/BuildSlaveSupport/download-built-product",
 WithProperties("--platform=%(platform)s"), WithProperties("--%(configuration)s"),
@@ -667,6 +688,7 @@
 
 return [self.name]
 
+
 class RunWebKit1Tests(RunWebKitTests):
 def start(self):
 self.setCommand(self.command + ["--dump-render-tree"])
@@ -673,6 +695,7 @@
 
 return RunWebKitTests.

[webkit-changes] [219222] trunk/Tools/BuildSlaveSupport/built-product-archive

2017-07-06 Thread lforschler

Title: [219222] trunk/Tools/BuildSlaveSupport/built-product-archive








Revision 219222
Author lforsch...@apple.com
Date 2017-07-06 15:50:30 -0700 (Thu, 06 Jul 2017)


Log Message
Update help text.

Modified Paths

trunk/Tools/BuildSlaveSupport/built-product-archive




Diff

Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (219221 => 219222)

--- trunk/Tools/BuildSlaveSupport/built-product-archive	2017-07-06 22:09:11 UTC (rev 219221)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive	2017-07-06 22:50:30 UTC (rev 219222)
@@ -43,7 +43,7 @@
 parser.add_option("--debug", action="" const="debug", dest="configuration")
 parser.add_option("--release", action="" const="release", dest="configuration")
 parser.add_option("--minify", action="" dest="minify", default=False,
-  help="Create a minified archive")
+  help="Create a minified archive by removing files that are not necessary for running applications against the built product, at the cost of complicating debugging.")
   
 options, (action, ) = parser.parse_args()
 if not options.platform:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219110] trunk/Tools

2017-07-03 Thread lforschler

Title: [219110] trunk/Tools








Revision 219110
Author lforsch...@apple.com
Date 2017-07-03 17:16:37 -0700 (Mon, 03 Jul 2017)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=174105

Reviewed by Stephanie Lewis.

* BuildSlaveSupport/built-product-archive:
(main): Add a -minify parser option
(createZip): Pass along the optional Minify argument if requested
(minifySource): This will trim down archives, logic limited to Mac platform.

Modified Paths

trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (219109 => 219110)

--- trunk/Tools/BuildSlaveSupport/built-product-archive	2017-07-04 00:10:29 UTC (rev 219109)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive	2017-07-04 00:16:37 UTC (rev 219110)
@@ -42,7 +42,9 @@
 parser.add_option("--platform", dest="platform")
 parser.add_option("--debug", action="" const="debug", dest="configuration")
 parser.add_option("--release", action="" const="release", dest="configuration")
-
+parser.add_option("--minify", action="" dest="minify", default=False,
+  help="Create a minified archive")
+  
 options, (action, ) = parser.parse_args()
 if not options.platform:
 parser.error("Platform is required")
@@ -64,7 +66,7 @@
 return 1
 
 if action == 'archive':
-return archiveBuiltProduct(options.configuration, genericPlatform, options.platform)
+return archiveBuiltProduct(options.configuration, genericPlatform, options.platform, options.minify)
 else:
 return extractBuiltProduct(options.configuration, genericPlatform)
 
@@ -135,8 +137,10 @@
 archiveZip.close()
 
 
-def createZip(directoryToZip, configuration, embedParentDirectoryNameOnDarwin=False):
+def createZip(directoryToZip, configuration, embedParentDirectoryNameOnDarwin=False, minify=False):
 archiveDir = os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", "WebKitBuild"))
+if minify:
+configuration = 'minified-' + configuration
 archiveFile = os.path.join(archiveDir, configuration + ".zip")
 
 try:
@@ -169,7 +173,21 @@
 return False
 
 
-def archiveBuiltProduct(configuration, platform, fullPlatform):
+def minifySource(platform):
+if platform == 'mac':
+dir_patterns = ('.dSYM', 'DerivedSources')
+file_patterns = ('.a',)
+for root, dirs, files in os.walk(_configurationBuildDirectory):
+if any(root.endswith(pattern) for pattern in dir_patterns):
+print 'Removing: {}'.format(root)
+shutil.rmtree(root)
+for name in files:
+if any(name.endswith(pattern) for pattern in file_patterns):
+print 'Removing: {}'.format(os.path.join(root, name))
+os.remove(os.path.join(root, name))
+
+
+def archiveBuiltProduct(configuration, platform, fullPlatform, minify=False):
 assert platform in ('mac', 'win', 'gtk', 'ios', 'wpe')
 
 if platform == 'ios':
@@ -184,7 +202,9 @@
 
 return createZip(combinedDirectory, configuration)
 elif platform == 'mac':
-return createZip(_configurationBuildDirectory, configuration, embedParentDirectoryNameOnDarwin=True)
+if minify:
+minifySource(platform)
+return createZip(_configurationBuildDirectory, configuration, embedParentDirectoryNameOnDarwin=True, minify=minify)
 elif platform == 'win':
 # FIXME: We shouldn't hardcode the assumption of a 32-bit build. See .
 binDirectory = os.path.join(_configurationBuildDirectory, 'bin32')


Modified: trunk/Tools/ChangeLog (219109 => 219110)

--- trunk/Tools/ChangeLog	2017-07-04 00:10:29 UTC (rev 219109)
+++ trunk/Tools/ChangeLog	2017-07-04 00:16:37 UTC (rev 219110)
@@ -1,3 +1,14 @@
+2017-07-03  Lucas Forschler  
+
+https://bugs.webkit.org/show_bug.cgi?id=174105
+
+Reviewed by Stephanie Lewis.
+
+* BuildSlaveSupport/built-product-archive:
+(main): Add a -minify parser option
+(createZip): Pass along the optional Minify argument if requested
+(minifySource): This will trim down archives, logic limited to Mac platform.
+
 2017-07-03  Matt Rajca  
 
 Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214463] trunk/Tools/ChangeLog

2017-03-28 Thread lforschler

Title: [214463] trunk/Tools/ChangeLog








Revision 214463
Author lforsch...@apple.com
Date 2017-03-27 22:43:48 -0700 (Mon, 27 Mar 2017)


Log Message
Another test v8.

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (214462 => 214463)

--- trunk/Tools/ChangeLog	2017-03-28 05:30:06 UTC (rev 214462)
+++ trunk/Tools/ChangeLog	2017-03-28 05:43:48 UTC (rev 214463)
@@ -1,5 +1,9 @@
 2017-03-27  Lucas Forschler  
 
+Another test v8.
+
+2017-03-27  Lucas Forschler  
+
 Another test v7.
 
 2017-03-27  Lucas Forschler  






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214463] trunk/Tools/ChangeLog

2017-03-28 Thread lforschler

Title: [214463] trunk/Tools/ChangeLog








Revision 214463
Author lforsch...@apple.com
Date 2017-03-27 22:43:48 -0700 (Mon, 27 Mar 2017)


Log Message
Another test v8.

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (214462 => 214463)

--- trunk/Tools/ChangeLog	2017-03-28 05:30:06 UTC (rev 214462)
+++ trunk/Tools/ChangeLog	2017-03-28 05:43:48 UTC (rev 214463)
@@ -1,5 +1,9 @@
 2017-03-27  Lucas Forschler  
 
+Another test v8.
+
+2017-03-27  Lucas Forschler  
+
 Another test v7.
 
 2017-03-27  Lucas Forschler  






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214367] trunk/Tools

2017-03-24 Thread lforschler

Title: [214367] trunk/Tools








Revision 214367
Author lforsch...@apple.com
Date 2017-03-24 12:41:38 -0700 (Fri, 24 Mar 2017)


Log Message
update committer_auth.py to be python 2.7 compliant
https://bugs.webkit.org/show_bug.cgi?id=170063

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
(CommitterAuth.authenticate):
convert e.message to e.args[0]

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/committer_auth.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/committer_auth.py (214366 => 214367)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/committer_auth.py	2017-03-24 19:36:40 UTC (rev 214366)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/committer_auth.py	2017-03-24 19:41:38 UTC (rev 214367)
@@ -56,7 +56,7 @@
 try:
 return self.is_webkit_committer(username) and self.is_webkit_trac_user(username, password)
 except Error, e:
-self.err = e.message
+self.err = e.args[0]
 return False
 
 def is_webkit_committer(self, username):


Modified: trunk/Tools/ChangeLog (214366 => 214367)

--- trunk/Tools/ChangeLog	2017-03-24 19:36:40 UTC (rev 214366)
+++ trunk/Tools/ChangeLog	2017-03-24 19:41:38 UTC (rev 214367)
@@ -1,3 +1,14 @@
+2017-03-24  Lucas Forschler  
+
+update committer_auth.py to be python 2.7 compliant
+https://bugs.webkit.org/show_bug.cgi?id=170063
+
+Reviewed by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
+(CommitterAuth.authenticate):
+convert e.message to e.args[0]
+
 2017-03-24  Srinivasan Vijayaraghavan  
 
 webkitpy: Parse JSON results from run-api-tests






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213479] trunk/Tools

2017-03-06 Thread lforschler

Title: [213479] trunk/Tools








Revision 213479
Author lforsch...@apple.com
Date 2017-03-06 16:20:30 -0800 (Mon, 06 Mar 2017)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=169234
torchmobile.com.cn is no longer a registered domain. These email addresses will bounce, so clean them up.

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (213478 => 213479)

--- trunk/Tools/ChangeLog	2017-03-07 00:09:19 UTC (rev 213478)
+++ trunk/Tools/ChangeLog	2017-03-07 00:20:30 UTC (rev 213479)
@@ -1,3 +1,12 @@
+2017-03-06  Lucas Forschler  
+
+https://bugs.webkit.org/show_bug.cgi?id=169234
+torchmobile.com.cn is no longer a registered domain. These email addresses will bounce, so clean them up.
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2017-03-03  Matt Rajca  
 
 Media: notify clients when the user never plays a media element that was prevented from auto-playing


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (213478 => 213479)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2017-03-07 00:09:19 UTC (rev 213478)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2017-03-07 00:20:30 UTC (rev 213479)
@@ -1119,15 +1119,6 @@
   ],
   "status" : "committer"
},
-   "Charles Wei" : {
-  "emails" : [
- "charles@torchmobile.com.cn"
-  ],
-  "nicks" : [
- "cswei"
-  ],
-  "status" : "committer"
-   },
"Chelsea Pugh" : {
   "emails" : [
  "cp...@apple.com"
@@ -2592,8 +2583,7 @@
},
"Jason Liu" : {
   "emails" : [
- "jasonliuweb...@gmail.com",
- "jason@torchmobile.com.cn"
+ "jasonliuweb...@gmail.com"
   ],
   "nicks" : [
  "jasonliu"
@@ -2973,8 +2963,7 @@
},
"Jonathan Dong" : {
   "emails" : [
- "jonathan.dong.web...@gmail.com",
- "jonathan.d...@torchmobile.com.cn"
+ "jonathan.dong.web...@gmail.com"
   ],
   "expertise" : "The BlackBerry Port",
   "nicks" : [
@@ -3556,8 +3545,7 @@
  "leoy...@rim.com",
  "leoy...@blackberry.com",
  "leoy...@webkit.org",
- "leoyang.web...@gmail.com",
- "leo.y...@torchmobile.com.cn"
+ "leoyang.web...@gmail.com"
   ],
   "expertise" : "The BlackBerry Port",
   "nicks" : [
@@ -3794,8 +3782,7 @@
"Mary Wu" : {
   "emails" : [
  "m...@blackberry.com",
- "wwendy2...@gmail.com",
- "mary...@torchmobile.com.cn"
+ "wwendy2...@gmail.com"
   ],
   "nicks" : [
  "marywu"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213422] trunk/Tools/ChangeLog

2017-03-04 Thread lforschler

Title: [213422] trunk/Tools/ChangeLog








Revision 213422
Author lforsch...@apple.com
Date 2017-03-04 06:52:20 -0800 (Sat, 04 Mar 2017)


Log Message
Test commit against svn.webkit.org after SHA-1 cleanup.

Unreviewed.

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (213421 => 213422)

--- trunk/Tools/ChangeLog	2017-03-04 08:57:56 UTC (rev 213421)
+++ trunk/Tools/ChangeLog	2017-03-04 14:52:20 UTC (rev 213422)
@@ -1,3 +1,9 @@
+2017-03-04  Lucas Forschler  
+
+Test commit against svn.webkit.org after SHA-1 cleanup.
+
+Unreviewed.
+
 2017-03-03  Dean Jackson  
 
 Add WebGPU compile flag and experimental feature flag






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213347] tags/Safari-604.1.8.0.1/

2017-03-02 Thread lforschler

Title: [213347] tags/Safari-604.1.8.0.1/








Revision 213347
Author lforsch...@apple.com
Date 2017-03-02 20:31:04 -0800 (Thu, 02 Mar 2017)


Log Message
Tag Safari-604.1.8.0.1

Added Paths

tags/Safari-604.1.8.0.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212551] trunk/Tools

2017-02-17 Thread lforschler

Title: [212551] trunk/Tools








Revision 212551
Author lforsch...@apple.com
Date 2017-02-17 08:25:56 -0800 (Fri, 17 Feb 2017)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=168442
Move the SVN checkout from http -> https.
Update unit tests.

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CheckOutSource.__init__):
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(SVNMirrorTest.get_SVNMirrorFromConfig):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (212550 => 212551)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-02-17 15:14:49 UTC (rev 212550)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-02-17 16:25:56 UTC (rev 212551)
@@ -123,7 +123,7 @@
 class CheckOutSource(source.SVN):
 mode = "update"
 def __init__(self, SVNMirror, **kwargs):
-kwargs['baseURL'] = SVNMirror or "http://svn.webkit.org/repository/webkit/"
+kwargs['baseURL'] = SVNMirror or "https://svn.webkit.org/repository/webkit/"
 kwargs['defaultBranch'] = "trunk"
 kwargs['mode'] = self.mode
 source.SVN.__init__(self, **kwargs)


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py (212550 => 212551)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py	2017-02-17 15:14:49 UTC (rev 212550)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py	2017-02-17 16:25:56 UTC (rev 212551)
@@ -322,7 +322,7 @@
 SVNMirror = None
 for builder in self.config['builders']:
 if builder['name'] == builderName:
-SVNMirror = builder.pop('SVNMirror', 'http://svn.webkit.org/repository/webkit/')
+SVNMirror = builder.pop('SVNMirror', 'https://svn.webkit.org/repository/webkit/')
 return SVNMirror
 
 def test_CheckOutSource(self):


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js (212550 => 212551)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js	2017-02-17 15:14:49 UTC (rev 212550)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js	2017-02-17 16:25:56 UTC (rev 212551)
@@ -28,7 +28,7 @@
 module("checkout");
 
 test("subversionURLForTest", 1, function() {
-equals(checkout.subversionURLForTest("path/to/test.html"), "http://svn.webkit.org/repository/webkit/trunk/LayoutTests/path/to/test.html");
+equals(checkout.subversionURLForTest("path/to/test.html"), "https://svn.webkit.org/repository/webkit/trunk/LayoutTests/path/to/test.html");
 });
 
 test("rebaseline", 3, function() {


Modified: trunk/Tools/ChangeLog (212550 => 212551)

--- trunk/Tools/ChangeLog	2017-02-17 15:14:49 UTC (rev 212550)
+++ trunk/Tools/ChangeLog	2017-02-17 16:25:56 UTC (rev 212551)
@@ -1,3 +1,17 @@
+2017-02-16  Lucas Forschler  
+
+https://bugs.webkit.org/show_bug.cgi?id=168442
+Move the SVN checkout from http -> https.
+Update unit tests.
+
+Reviewed by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(CheckOutSource.__init__):
+* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
+(SVNMirrorTest.get_SVNMirrorFromConfig):
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
+
 2017-02-16  Commit Queue  
 
 Unreviewed, rolling out r212514.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212396] trunk/Tools

2017-02-15 Thread lforschler

Title: [212396] trunk/Tools








Revision 212396
Author lforsch...@apple.com
Date 2017-02-15 14:42:16 -0800 (Wed, 15 Feb 2017)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=168386
Remove EFL from build.webkit.org

Reviewed by Alex Christensen

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DeleteStaleBuildFiles.start):
(appendCustomBuildFlags):
(RunWebKitTests.start):
(RunBuiltinsTests):
(Factory.__init__):
(TestFactory.__init__):
(loadBuilderConfig):
(InstallEflDependencies): Deleted.
(RunEflAPITests): Deleted.
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
(Analyzer.prototype._triggeringQueue):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.linux-efl img.logo): Deleted.
* BuildSlaveSupport/build.webkit.org-config/templates/root.html:
* BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/templates/root.html
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (212395 => 212396)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2017-02-15 22:36:56 UTC (rev 212395)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2017-02-15 22:42:16 UTC (rev 212396)
@@ -73,9 +73,6 @@
 { "name": "gtk-linux-slave-8", "platform": "gtk" },
 { "name": "gtk-linux-slave-9", "platform": "gtk" },
 
-{ "name": "efl-linux-slave-2", "platform": "efl" },
-{ "name": "efl-linux-slave-3", "platform": "efl" },
-
 { "name": "jsconly-linux-szeged-slave-1", "platform": "jsc-only" },
 { "name": "jsconly-linux-szeged-slave-2", "platform": "jsc-only" },
 { "name": "jsconly-linux-szeged-slave-3", "platform": "jsc-only" }
@@ -310,16 +307,6 @@
   "slavenames": ["wincairo-1", "wincairo-2"]
 },
 {
-  "name": "EFL Linux 64-bit Release WK2", "type": "BuildAndTest", "builddir": "efl-linux-64-release-wk2",
-  "platform": "efl", "configuration": "release", "architectures": ["x86_64"],
-  "slavenames": ["efl-linux-slave-2"]
-},
-{
-  "name": "EFL Linux 64-bit Release WK2 (Perf)", "type": "BuildAndPerfTest", "builddir": "efl-linux-64-release-wk2-perf",
-  "platform": "efl", "configuration": "release", "architectures": ["x86_64"],
-  "slavenames": ["efl-linux-slave-3"]
-},
-{
   "name": "JSCOnly Linux AArch64 Release", "type": "BuildAndRemoteJSCTests", "builddir": "jsconly-linux-aarch64-release",
   "platform": "jsc-only", "configuration": "release", "architectures": ["aarch64"],
   "SVNMirror": "svn://webkit.inf.u-szeged.hu/webkit/",
@@ -341,7 +328,6 @@
 
 "schedulers": [ { "type": "AnyBranchScheduler", "name": "trunk", "change_filter": "trunk_filter", "treeStableTimer": 45.0,
   "builderNames": ["GTK Linux 32-bit Release", "GTK Linux 64-bit Release (Build)", "GTK Linux 64-bit Debug (Build)", "GTK Linux ARM Release",
-   "EFL Linux 64-bit Release WK2", "EFL Linux 64-bit Release WK2 (Perf)",
"JSCOnly Linux AArch64

[webkit-changes] [210510] trunk

2017-01-09 Thread lforschler

Title: [210510] trunk








Revision 210510
Author lforsch...@apple.com
Date 2017-01-09 09:39:14 -0800 (Mon, 09 Jan 2017)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=166839
Add php7 support for macOS.
Tools:

Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/base.py:
(Port._is_darwin_php_version_7):
(Port._debian_php_version):
(Port):
(Port._darwin_php_version):
(Port._apache_config_file_name_for_platform):

LayoutTests:

This patch mirrors the solution that debian uses, by adding a php7 specific apache conf file.

Reviewed by Alexey Proskuryakov.

* http/conf/apache2.4-php7-httpd.conf: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/conf/apache2.4-php7-httpd.conf
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/base.py




Diff

Modified: trunk/LayoutTests/ChangeLog (210509 => 210510)

--- trunk/LayoutTests/ChangeLog	2017-01-09 17:33:15 UTC (rev 210509)
+++ trunk/LayoutTests/ChangeLog	2017-01-09 17:39:14 UTC (rev 210510)
@@ -1,3 +1,13 @@
+2017-01-09  Lucas Forschler  
+
+https://bugs.webkit.org/show_bug.cgi?id=166839
+Add php7 support for macOS.
+This patch mirrors the solution that debian uses, by adding a php7 specific apache conf file.
+
+Reviewed by Alexey Proskuryakov.
+
+* http/conf/apache2.4-php7-httpd.conf: Added.
+
 2017-01-09  Ryan Haddad  
 
 Marking inspector/debugger/breakpoint-action-log.html as flaky on macOS.


Modified: trunk/LayoutTests/http/conf/apache2.4-php7-httpd.conf (210509 => 210510)

--- trunk/LayoutTests/http/conf/apache2.4-php7-httpd.conf	2017-01-09 17:33:15 UTC (rev 210509)
+++ trunk/LayoutTests/http/conf/apache2.4-php7-httpd.conf	2017-01-09 17:39:14 UTC (rev 210510)
@@ -33,7 +33,7 @@
 LoadModule actions_module libexec/apache2/mod_actions.so
 LoadModule alias_module libexec/apache2/mod_alias.so
 LoadModule rewrite_module libexec/apache2/mod_rewrite.so
-LoadModule php5_modulelibexec/apache2/libphp5.so
+LoadModule php7_modulelibexec/apache2/libphp7.so
 
 ServerName 127.0.0.1
 
@@ -123,7 +123,7 @@
 AddHandler send-as-is asis
 
 
-
+
 AddType application/x-httpd-php .php
 AddType application/x-httpd-php .bat
 AddType application/x-httpd-php-source .phps


Modified: trunk/Tools/ChangeLog (210509 => 210510)

--- trunk/Tools/ChangeLog	2017-01-09 17:33:15 UTC (rev 210509)
+++ trunk/Tools/ChangeLog	2017-01-09 17:39:14 UTC (rev 210510)
@@ -1,3 +1,18 @@
+2017-01-09  Lucas Forschler  
+
+https://bugs.webkit.org/show_bug.cgi?id=166839
+Add php7 support for macOS.
+Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/port/base.py:
+(Port._is_darwin_php_version_7):
+(Port._debian_php_version):
+(Port):
+(Port._darwin_php_version):
+(Port._apache_config_file_name_for_platform):
+
 2017-01-06  Gustavo Noronha Silva  
 
 [GTK] Should support key and code properties on keyboard events


Modified: trunk/Tools/Scripts/webkitpy/port/base.py (210509 => 210510)

--- trunk/Tools/Scripts/webkitpy/port/base.py	2017-01-09 17:33:15 UTC (rev 210509)
+++ trunk/Tools/Scripts/webkitpy/port/base.py	2017-01-09 17:39:14 UTC (rev 210510)
@@ -1164,6 +1164,11 @@
 return True
 return False
 
+def _is_darwin_php_version_7(self):
+if self._filesystem.exists("/usr/libexec/apache2/libphp7.so"):
+return True
+return False
+
 # FIXME: This belongs on some platform abstraction instead of Port.
 def _is_redhat_based(self):
 return self._filesystem.exists('/etc/redhat-release')
@@ -1183,6 +1188,11 @@
 return "-php7"
 return ""
 
+def _darwin_php_version(self):
+if self._is_darwin_php_version_7():
+return "-php7"
+return ""
+
 def _fedora_php_version(self):
 if self._is_fedora_php_version_7():
 return "-php7"
@@ -1192,6 +1202,8 @@
 def _apache_config_file_name_for_platform(self, sys_platform):
 if sys_platform == 'cygwin' or sys_platform.startswith('win'):
 return 'apache' + self._apache_version() + '-httpd-win.conf'
+if sys_platform == 'darwin':
+return 'apache' + self._apache_version() + self._darwin_php_version() + '-httpd.conf'
 if sys_platform.startswith('linux'):
 if self._is_redhat_based():
 return 'fedora-httpd-' + self._apache_version() + self._fedora_php_version() + '.conf'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [210509] trunk/LayoutTests/http/conf/apache2.4-php7-httpd.conf

2017-01-09 Thread lforschler

Title: [210509] trunk/LayoutTests/http/conf/apache2.4-php7-httpd.conf








Revision 210509
Author lforsch...@apple.com
Date 2017-01-09 09:33:15 -0800 (Mon, 09 Jan 2017)


Log Message
Create new php7 config, preserving history via svn cp

Added Paths

trunk/LayoutTests/http/conf/apache2.4-php7-httpd.conf




Diff

Copied: trunk/LayoutTests/http/conf/apache2.4-php7-httpd.conf (from rev 210508, trunk/LayoutTests/http/conf/apache2.4-httpd.conf) (0 => 210509)

--- trunk/LayoutTests/http/conf/apache2.4-php7-httpd.conf	(rev 0)
+++ trunk/LayoutTests/http/conf/apache2.4-php7-httpd.conf	2017-01-09 17:33:15 UTC (rev 210509)
@@ -0,0 +1,163 @@
+ServerRoot "/usr"
+
+Mutex file:/tmp/WebKit
+PidFile "/tmp/WebKit/httpd.pid"
+ScoreBoardFile "/tmp/WebKit/httpd.scoreboard"
+
+Timeout 300
+KeepAlive On
+MaxKeepAliveRequests 100
+KeepAliveTimeout 15
+
+MinSpareServers 1
+MaxSpareServers 5
+StartServers 1
+MaxRequestWorkers 150
+MaxConnectionsPerChild 10
+
+LoadModule autoindex_module libexec/apache2/mod_autoindex.so
+LoadModule unixd_module libexec/apache2/mod_unixd.so
+LoadModule access_compat_module libexec/apache2/mod_access_compat.so
+LoadModule authn_core_module libexec/apache2/mod_authn_core.so
+LoadModule authz_core_module libexec/apache2/mod_authz_core.so
+LoadModule authz_host_module libexec/apache2/mod_authz_host.so
+LoadModule include_module libexec/apache2/mod_include.so
+LoadModule log_config_module libexec/apache2/mod_log_config.so
+LoadModule headers_module libexec/apache2/mod_headers.so
+LoadModule ssl_module libexec/apache2/mod_ssl.so
+LoadModule mime_module libexec/apache2/mod_mime.so
+LoadModule asis_module libexec/apache2/mod_asis.so
+LoadModule cgi_module libexec/apache2/mod_cgi.so
+LoadModule negotiation_module libexec/apache2/mod_negotiation.so
+#LoadModule imagemap_module libexec/apache2/mod_imagemap.so
+LoadModule actions_module libexec/apache2/mod_actions.so
+LoadModule alias_module libexec/apache2/mod_alias.so
+LoadModule rewrite_module libexec/apache2/mod_rewrite.so
+LoadModule php5_modulelibexec/apache2/libphp5.so
+
+ServerName 127.0.0.1
+
+
+Options Indexes FollowSymLinks MultiViews ExecCGI Includes
+AllowOverride All
+Order allow,deny
+Allow from all
+
+
+AccessFileName .htaccess
+
+
+Order allow,deny
+Deny from all
+Satisfy All
+
+
+UseCanonicalName On
+HostnameLookups Off
+
+LogLevel warn
+
+ErrorLog "/tmp/WebKit/error_log.txt"
+
+LogFormat "%h %l %u %t \"%r\" %>s %b \"%{Referer}i\" \"%{User-Agent}i\"" combined
+LogFormat "%h %l %u %t \"%r\" %>s %b %D" common
+LogFormat "%{Referer}i -> %U" referer
+LogFormat "%{User-agent}i" agent
+
+ServerSignature On
+
+
+
+
+
+AddLanguage da .dk
+AddLanguage nl .nl
+AddLanguage en .en
+AddLanguage et .ee
+AddLanguage fr .fr
+AddLanguage de .de
+AddLanguage el .el
+AddLanguage he .he
+AddCharset ISO-8859-8 .iso8859-8
+AddLanguage it .it
+AddLanguage ja .ja
+AddCharset ISO-2022-JP .jis
+AddLanguage kr .kr
+AddCharset ISO-2022-KR .iso-kr
+AddLanguage nn .nn
+AddLanguage no .no
+AddLanguage pl .po
+AddCharset ISO-8859-2 .iso-pl
+AddLanguage pt .pt
+AddLanguage pt-br .pt-br
+AddLanguage ltz .lu
+AddLanguage ca .ca
+AddLanguage es .es
+AddLanguage sv .sv
+AddLanguage cs .cz .cs
+AddLanguage ru .ru
+AddLanguage zh-TW .zh-tw
+AddCharset Big5 .Big5.big5
+AddCharset WINDOWS-1251 .cp-1251
+AddCharset CP866.cp866
+AddCharset ISO-8859-5   .iso-ru
+AddCharset KOI8-R   .koi8-r
+AddCharset UCS-2.ucs2
+AddCharset UCS-4.ucs4
+AddCharset UTF-8.utf8
+
+
+LanguagePriority en da nl et fr de el it ja kr no pl pt pt-br ru ltz ca es sv tw
+
+
+AddType application/x-tar .tgz
+
+AddEncoding x-compress .Z
+AddEncoding x-gzip .gz .tgz
+
+AddHandler cgi-script .cgi .pl
+
+AddType text/html .shtml
+AddHandler server-parsed .shtml
+
+AddHandler send-as-is asis
+
+
+
+AddType application/x-httpd-php .php
+AddType application/x-httpd-php .bat
+AddType application/x-httpd-php-source .phps
+
+
+DirectoryIndex index.html index.php
+
+
+php_flag log_errors on
+php_flag short_open_tag on
+
+
+
+RewriteEngine On
+RewriteCond %{REQUEST_METHOD} ^TRACE
+RewriteRule .* - [F]
+
+
+
+ServerName 127.0.0.1
+SSLEngine On
+
+
+#
+# Apple-specific filesystem protection.
+#
+
+Order allow,deny
+Deny from all
+Satisfy All
+
+
+
+Order allow,deny
+Deny from all
+Satisfy All
+


Property changes: trunk/LayoutTests/http/conf/apache2.4-php7-httpd.conf



Added: svn:mergeinfo
+/trunk/LayoutTests/http/conf/apache2.4-httpd.conf:53455
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [204649] trunk/Tools

2016-08-19 Thread lforschler

Title: [204649] trunk/Tools








Revision 204649
Author lforsch...@apple.com
Date 2016-08-19 13:15:49 -0700 (Fri, 19 Aug 2016)


Log Message
Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629

Reviewed by Kocsen Chung.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js (204648 => 204649)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js	2016-08-19 19:44:01 UTC (rev 204648)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js	2016-08-19 20:15:49 UTC (rev 204649)
@@ -49,7 +49,6 @@
 "Apple Yosemite Release WK1 (Tests)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit1},
 "Apple Yosemite Release WK2 (Tests)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
 "Apple Yosemite Release WK2 (Perf)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, performance: true, heading: "Performance"},
-"Apple Yosemite (Leaks)": {platform: Dashboard.Platform.MacOSXYosemite, debug: true, leaks: true},
 "Apple Yosemite JSC": {platform: Dashboard.Platform.MacOSXYosemite, heading: "_javascript_", combinedQueues: {
 "Apple Yosemite 32-bit JSC (BuildAndTest)": {heading: "32-bit JSC (BuildAndTest)"},
 "Apple Yosemite LLINT CLoop (BuildAndTest)": {heading: "LLINT CLoop (BuildAndTest)"},


Modified: trunk/Tools/ChangeLog (204648 => 204649)

--- trunk/Tools/ChangeLog	2016-08-19 19:44:01 UTC (rev 204648)
+++ trunk/Tools/ChangeLog	2016-08-19 20:15:49 UTC (rev 204649)
@@ -1,3 +1,12 @@
+2016-08-19  Lucas Forschler  
+
+Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
+
+Reviewed by Kocsen Chung.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
+(WebKitBuildbot):
+
 2016-08-19  Alexey Proskuryakov  
 
 Partial revert of r203811 - this key is not needed.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [204629] trunk/Tools

2016-08-19 Thread lforschler

Title: [204629] trunk/Tools








Revision 204629
Author lforsch...@apple.com
Date 2016-08-19 00:26:22 -0700 (Fri, 19 Aug 2016)


Log Message
Remove Yosemite Leaks bot from config.json

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (204628 => 204629)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2016-08-19 05:42:03 UTC (rev 204628)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2016-08-19 07:26:22 UTC (rev 204629)
@@ -2,7 +2,6 @@
 "slaves": [ { "name": "test-slave", "platform": "*" },
 
 { "name": "bot139", "platform": "mac-yosemite" },
-{ "name": "bot148", "platform": "mac-yosemite" },
 { "name": "bot155", "platform": "mac-yosemite" },
 { "name": "bot157", "platform": "mac-yosemite" },
 { "name": "bot180", "platform": "mac-yosemite" },
@@ -147,11 +146,6 @@
   "platform": "mac-elcapitan", "configuration": "release", "architectures": ["i386"],
   "slavenames": ["bot419"]
 },
-{ "name": "Apple Yosemite (Leaks)", "type": "TestWebKit1Leaks", "builddir": "yosemite-leaks",
-  "platform": "mac-yosemite", "configuration": "debug", "architectures": ["x86_64"],
-  "additionalArguments": ["--no-retry-failures"],
-  "slavenames": ["bot148"]
-},
 { "name": "Apple Yosemite Release (32-bit Build)", "type": "Build", "builddir": "yosemite-32bit-release",
   "platform": "mac-yosemite", "configuration": "release", "architectures": ["i386"],
   "slavenames": ["bot139"]
@@ -158,7 +152,7 @@
 },
 { "name": "Apple Yosemite Debug (Build)", "type": "Build", "builddir": "yosemite-debug",
   "platform": "mac-yosemite", "configuration": "debug", "architectures": ["x86_64"],
-  "triggers": ["yosemite-debug-tests-jsc", "yosemite-debug-tests-wk1", "yosemite-debug-tests-wk2", "yosemite-leaks"],
+  "triggers": ["yosemite-debug-tests-jsc", "yosemite-debug-tests-wk1", "yosemite-debug-tests-wk2"],
   "slavenames": ["bot180", "bot181"]
 },
 { "name": "Apple Yosemite Debug JSC (Tests)", "type": "TestJSC", "builddir": "yosemite-debug-tests-jsc",
@@ -366,9 +360,6 @@
 { "type": "Triggerable", "name": "elcapitan-leaks",
   "builderNames": ["Apple El Capitan (Leaks)"]
 },
-{ "type": "Triggerable", "name": "yosemite-leaks",
-  "builderNames": ["Apple Yosemite (Leaks)"]
-},
 { "type": "Triggerable", "name": "elcapitan-release-tests-jsc",
   "builderNames": ["Apple El Capitan Release JSC (Tests)"]
 },


Modified: trunk/Tools/ChangeLog (204628 => 204629)

--- trunk/Tools/ChangeLog	2016-08-19 05:42:03 UTC (rev 204628)
+++ trunk/Tools/ChangeLog	2016-08-19 07:26:22 UTC (rev 204629)
@@ -1,3 +1,11 @@
+2016-08-19  Lucas Forschler  
+
+Remove Yosemite Leaks bot from config.json
+
+Reviewed by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
 2016-08-18  Dan Bernstein  
 
 [Cocoa] API::Number needs to be wrapped by an NSNumber






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [203715] trunk/Tools/ChangeLog

2016-07-26 Thread lforschler

Title: [203715] trunk/Tools/ChangeLog








Revision 203715
Author lforsch...@apple.com
Date 2016-07-26 01:06:28 -0700 (Tue, 26 Jul 2016)


Log Message
Test svn.webkit.org functionality after maintenance.

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (203714 => 203715)

--- trunk/Tools/ChangeLog	2016-07-26 07:46:58 UTC (rev 203714)
+++ trunk/Tools/ChangeLog	2016-07-26 08:06:28 UTC (rev 203715)
@@ -1,3 +1,7 @@
+2016-07-26  Lucas Forschler  
+
+Test svn.webkit.org functionality after maintenance.
+
 2016-07-25  Brady Eidson  
 
 Modern IDB: Make sure IndexedDB works from file:// url documents by default






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [203197] trunk/Websites/test-results/

2016-07-13 Thread lforschler

Title: [203197] trunk/Websites/test-results/








Revision 203197
Author lforsch...@apple.com
Date 2016-07-13 15:43:30 -0700 (Wed, 13 Jul 2016)


Log Message
Remove test-results.

Removed Paths

trunk/Websites/test-results/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [203185] trunk/Websites/test-results

2016-07-13 Thread lforschler

Title: [203185] trunk/Websites/test-results








Revision 203185
Author lforsch...@apple.com
Date 2016-07-13 13:33:33 -0700 (Wed, 13 Jul 2016)


Log Message
Update results-safari config.

Added Paths

trunk/Websites/test-results/php.ini
trunk/Websites/test-results/public/api/update-flakiness.php




Diff

Added: trunk/Websites/test-results/php.ini (0 => 203185)

--- trunk/Websites/test-results/php.ini	(rev 0)
+++ trunk/Websites/test-results/php.ini	2016-07-13 20:33:33 UTC (rev 203185)
@@ -0,0 +1 @@
+memory_limit = 256M;
\ No newline at end of file


Added: trunk/Websites/test-results/public/api/update-flakiness.php (0 => 203185)

--- trunk/Websites/test-results/public/api/update-flakiness.php	(rev 0)
+++ trunk/Websites/test-results/public/api/update-flakiness.php	2016-07-13 20:33:33 UTC (rev 203185)
@@ -0,0 +1,18 @@
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [203177] trunk/Websites/test-results

2016-07-13 Thread lforschler

Title: [203177] trunk/Websites/test-results








Revision 203177
Author lforsch...@apple.com
Date 2016-07-13 13:09:23 -0700 (Wed, 13 Jul 2016)


Log Message
Revert 203176.

Modified Paths

trunk/Websites/test-results/config.json
trunk/Websites/test-results/public/admin/builders.php
trunk/Websites/test-results/public/api/report.php
trunk/Websites/test-results/public/include/db.php
trunk/Websites/test-results/public/include/json-shared.php
trunk/Websites/test-results/public/include/test-results.php
trunk/Websites/test-results/public/index.html
trunk/Websites/test-results/public_partition_maintenance


Removed Paths

trunk/Websites/test-results/size-database.sql




Diff

Modified: trunk/Websites/test-results/config.json (203176 => 203177)

--- trunk/Websites/test-results/config.json	2016-07-13 20:04:09 UTC (rev 203176)
+++ trunk/Websites/test-results/config.json	2016-07-13 20:09:23 UTC (rev 203177)
@@ -7,7 +7,7 @@
 "host": "localhost",
 "port": "5432",
 "username": "test-results-user",
-"password": "intr1gue",
+"password": "password",
 "name": "test-results-db"
 },
 "masters": [


Modified: trunk/Websites/test-results/public/admin/builders.php (203176 => 203177)

--- trunk/Websites/test-results/public/admin/builders.php	2016-07-13 20:04:09 UTC (rev 203176)
+++ trunk/Websites/test-results/public/admin/builders.php	2016-07-13 20:09:23 UTC (rev 203177)
@@ -25,7 +25,6 @@
 ));
 
 $page->render_table('name');
-$page->render_form_to_add();
 }
 
 require('../include/admin-footer.php');


Modified: trunk/Websites/test-results/public/api/report.php (203176 => 203177)

--- trunk/Websites/test-results/public/api/report.php	2016-07-13 20:04:09 UTC (rev 203176)
+++ trunk/Websites/test-results/public/api/report.php	2016-07-13 20:09:23 UTC (rev 203177)
@@ -62,7 +62,6 @@
 if (!array_key_exists('file', $_FILES) or !array_key_exists('tmp_name', $_FILES['file']) or count($_FILES['file']['tmp_name']) <= 0)
 exit_with_error('ResultsJSONNotIncluded');
 $json_path = $_FILES['file']['tmp_name'];
-var_dump($_FILES);
 
 $db = connect();
 store_results($db, $master, $builder_name, $build_number, $start_time, $end_time, $revisions, $json_path);


Modified: trunk/Websites/test-results/public/include/db.php (203176 => 203177)

--- trunk/Websites/test-results/public/include/db.php	2016-07-13 20:04:09 UTC (rev 203176)
+++ trunk/Websites/test-results/public/include/db.php	2016-07-13 20:09:23 UTC (rev 203177)
@@ -203,4 +203,4 @@
 
 }
 
-?>
+?>
\ No newline at end of file


Modified: trunk/Websites/test-results/public/include/json-shared.php (203176 => 203177)

--- trunk/Websites/test-results/public/include/json-shared.php	2016-07-13 20:04:09 UTC (rev 203176)
+++ trunk/Websites/test-results/public/include/json-shared.php	2016-07-13 20:09:23 UTC (rev 203177)
@@ -1,5 +1,5 @@
 -ini_set('memory_limit','-1');
+ini_set('memory_limit','1024M');
 
 require_once('db.php');
 


Modified: trunk/Websites/test-results/public/include/test-results.php (203176 => 203177)

--- trunk/Websites/test-results/public/include/test-results.php	2016-07-13 20:04:09 UTC (rev 203176)
+++ trunk/Websites/test-results/public/include/test-results.php	2016-07-13 20:09:23 UTC (rev 203177)
@@ -1,8 +1,6 @@
  ini_set('memory_limit', '1024M');
 
-ini_set('memory_limit', '1024M');
-
 require_once('db.php');
 
 function float_to_time($time_in_float) {


Modified: trunk/Websites/test-results/public/index.html (203176 => 203177)

--- trunk/Websites/test-results/public/index.html	2016-07-13 20:04:09 UTC (rev 203176)
+++ trunk/Websites/test-results/public/index.html	2016-07-13 20:09:23 UTC (rev 203177)
@@ -129,16 +129,7 @@
 webkitRepositoryId = repositoryId;
 }
 var webkitRevision = result.build.revision(webkitRepositoryId);
-
-// FIXME: This code definitely doesn't belong here.
-var safariRepositoryId;
-for (var repositoryId in TestResultsView._repositories) {
-if (TestResultsView._repositories[repositoryId].name == 'Safari')
-safariRepositoryId = repositoryId;
-}
-var safariRevision = result.build.revision(safariRepositoryId);
-
-var resultsPage = webkitRevision ? "http://" + master + "/results/" + builder + "/r" + webkitRevision + '_' + safariRevision + "%20(" + buildNumber + ")/results.html"
+var resultsPage = webkitRevision ? "http://" + master + "/results/" + builder + "/r" + webkitRevision + "%20(" + buildNumber + ")/results.html"
 : '_javascript_:alert("Could no resolve WebKit revision")';
 
 var anchor = element('a', {'href': resultsPage }, [timeIfSlow]);


Modified: trunk/Websites/test-results/public_partition_maintenance (203176 => 203177)

--- trunk/Websites/test-results/public_partition_maintenance	2016-07-13 20:04:09 UTC (rev 203176)
+++ trunk/Websites/test-results/public_partition_maintenance	2016-07-13 20:09:23 UTC (rev 203177)
@@ -1,5 +1,5 @@
 #!/bin/bash
 # NOTE: psql must be available in the p

[webkit-changes] [203176] trunk/Websites/test-results

2016-07-13 Thread lforschler

Title: [203176] trunk/Websites/test-results








Revision 203176
Author lforsch...@apple.com
Date 2016-07-13 13:04:09 -0700 (Wed, 13 Jul 2016)


Log Message
Update command for the results maintenance script.

Modified Paths

trunk/Websites/test-results/config.json
trunk/Websites/test-results/public/admin/builders.php
trunk/Websites/test-results/public/api/report.php
trunk/Websites/test-results/public/include/db.php
trunk/Websites/test-results/public/include/json-shared.php
trunk/Websites/test-results/public/include/test-results.php
trunk/Websites/test-results/public/index.html
trunk/Websites/test-results/public_partition_maintenance


Added Paths

trunk/Websites/test-results/size-database.sql




Diff

Modified: trunk/Websites/test-results/config.json (203175 => 203176)

--- trunk/Websites/test-results/config.json	2016-07-13 20:02:28 UTC (rev 203175)
+++ trunk/Websites/test-results/config.json	2016-07-13 20:04:09 UTC (rev 203176)
@@ -7,7 +7,7 @@
 "host": "localhost",
 "port": "5432",
 "username": "test-results-user",
-"password": "password",
+"password": "intr1gue",
 "name": "test-results-db"
 },
 "masters": [


Modified: trunk/Websites/test-results/public/admin/builders.php (203175 => 203176)

--- trunk/Websites/test-results/public/admin/builders.php	2016-07-13 20:02:28 UTC (rev 203175)
+++ trunk/Websites/test-results/public/admin/builders.php	2016-07-13 20:04:09 UTC (rev 203176)
@@ -25,6 +25,7 @@
 ));
 
 $page->render_table('name');
+$page->render_form_to_add();
 }
 
 require('../include/admin-footer.php');


Modified: trunk/Websites/test-results/public/api/report.php (203175 => 203176)

--- trunk/Websites/test-results/public/api/report.php	2016-07-13 20:02:28 UTC (rev 203175)
+++ trunk/Websites/test-results/public/api/report.php	2016-07-13 20:04:09 UTC (rev 203176)
@@ -62,6 +62,7 @@
 if (!array_key_exists('file', $_FILES) or !array_key_exists('tmp_name', $_FILES['file']) or count($_FILES['file']['tmp_name']) <= 0)
 exit_with_error('ResultsJSONNotIncluded');
 $json_path = $_FILES['file']['tmp_name'];
+var_dump($_FILES);
 
 $db = connect();
 store_results($db, $master, $builder_name, $build_number, $start_time, $end_time, $revisions, $json_path);


Modified: trunk/Websites/test-results/public/include/db.php (203175 => 203176)

--- trunk/Websites/test-results/public/include/db.php	2016-07-13 20:02:28 UTC (rev 203175)
+++ trunk/Websites/test-results/public/include/db.php	2016-07-13 20:04:09 UTC (rev 203176)
@@ -203,4 +203,4 @@
 
 }
 
-?>
\ No newline at end of file
+?>


Modified: trunk/Websites/test-results/public/include/json-shared.php (203175 => 203176)

--- trunk/Websites/test-results/public/include/json-shared.php	2016-07-13 20:02:28 UTC (rev 203175)
+++ trunk/Websites/test-results/public/include/json-shared.php	2016-07-13 20:04:09 UTC (rev 203176)
@@ -1,5 +1,5 @@
 -ini_set('memory_limit','1024M');
+ini_set('memory_limit','-1');
 
 require_once('db.php');
 


Modified: trunk/Websites/test-results/public/include/test-results.php (203175 => 203176)

--- trunk/Websites/test-results/public/include/test-results.php	2016-07-13 20:02:28 UTC (rev 203175)
+++ trunk/Websites/test-results/public/include/test-results.php	2016-07-13 20:04:09 UTC (rev 203176)
@@ -1,6 +1,8 @@
  ini_set('memory_limit', '1024M');
 
+ini_set('memory_limit', '1024M');
+
 require_once('db.php');
 
 function float_to_time($time_in_float) {


Modified: trunk/Websites/test-results/public/index.html (203175 => 203176)

--- trunk/Websites/test-results/public/index.html	2016-07-13 20:02:28 UTC (rev 203175)
+++ trunk/Websites/test-results/public/index.html	2016-07-13 20:04:09 UTC (rev 203176)
@@ -129,7 +129,16 @@
 webkitRepositoryId = repositoryId;
 }
 var webkitRevision = result.build.revision(webkitRepositoryId);
-var resultsPage = webkitRevision ? "http://" + master + "/results/" + builder + "/r" + webkitRevision + "%20(" + buildNumber + ")/results.html"
+
+// FIXME: This code definitely doesn't belong here.
+var safariRepositoryId;
+for (var repositoryId in TestResultsView._repositories) {
+if (TestResultsView._repositories[repositoryId].name == 'Safari')
+safariRepositoryId = repositoryId;
+}
+var safariRevision = result.build.revision(safariRepositoryId);
+
+var resultsPage = webkitRevision ? "http://" + master + "/results/" + builder + "/r" + webkitRevision + '_' + safariRevision + "%20(" + buildNumber + ")/results.html"
 : '_javascript_:alert("Could no resolve WebKit revision")';
 
 var anchor = element('a', {'href': resultsPage }, [timeIfSlow]);


Modified: trunk/Websites/test-results/public_partition_maintenance (203175 => 203176)

--- trunk/Websites/test-results/public_partition_maintenance	2016-07-13 20:02:28 UTC (rev 203175)
+++ trunk/Websites/test-results/public_partition_maintenance	2016-07-13 20:04:09 UTC (rev 203176)
@@ -1,5 +1,5 @@
 #!/bin/bash
 # NOT

[webkit-changes] [203152] trunk/Websites/test-results/init-database.sql

2016-07-12 Thread lforschler

Title: [203152] trunk/Websites/test-results/init-database.sql








Revision 203152
Author lforsch...@apple.com
Date 2016-07-12 22:45:02 -0700 (Tue, 12 Jul 2016)


Log Message
Fix SQL: quote hyphenated string.

Modified Paths

trunk/Websites/test-results/init-database.sql




Diff

Modified: trunk/Websites/test-results/init-database.sql (203151 => 203152)

--- trunk/Websites/test-results/init-database.sql	2016-07-13 04:50:14 UTC (rev 203151)
+++ trunk/Websites/test-results/init-database.sql	2016-07-13 05:45:02 UTC (rev 203152)
@@ -3,6 +3,8 @@
 -- Drop existing schema. WARNING: this will delete all data in the database
 DROP SCHEMA IF EXISTS public CASCADE;
 CREATE SCHEMA public;
+GRANT ALL PRIVILEGES ON ALL TABLES IN SCHEMA public TO "test-results-user";
+GRANT ALL PRIVILEGES ON ALL SEQUENCES IN SCHEMA public TO "test-results-user";
 
 SET search_path TO public;
 SET constraint_exclusion = partition;
@@ -100,8 +102,8 @@
 
 -- Table permissions are not inherited from the parent.
 -- If permissions change on the master be sure to change them on the child also.
-EXECUTE 'ALTER TABLE public.' || quote_ident(_tablename) || ' OWNER TO test-results-user';
-EXECUTE 'GRANT ALL ON TABLE public.' || quote_ident(_tablename) || ' TO test-results-user';
+EXECUTE 'ALTER TABLE public.' || quote_ident(_tablename) || ' OWNER TO "test-results-user"';
+EXECUTE 'GRANT ALL ON TABLE public.' || quote_ident(_tablename) || ' TO "test-results-user"';
 
 -- Indexes are defined per child, so we assign a default index that uses the partition columns
 EXECUTE 'CREATE INDEX ' || quote_ident(_tablename||'_indx1') || ' ON public.' || quote_ident(_tablename) || ' (time, id)';
@@ -172,10 +174,10 @@
 $BODY$
 LANGUAGE plpgsql VOLATILE COST 100;
 
-ALTER FUNCTION public.partition_maintenance(text, text, date) OWNER TO test-results-user;
+ALTER FUNCTION public.partition_maintenance(text, text, date) OWNER TO "test-results-user";
 
-GRANT EXECUTE ON FUNCTION public.partition_maintenance(text, text, date) TO test-results-user;
-GRANT EXECUTE ON FUNCTION public.partition_maintenance(text, text, date) TO test-results-user;
+GRANT EXECUTE ON FUNCTION public.partition_maintenance(text, text, date) TO "test-results-user";
+GRANT EXECUTE ON FUNCTION public.partition_maintenance(text, text, date) TO "test-results-user";
 
 -- The function below is again generic and allows you to pass in the table name of the file you would like to export to the operating system and the name of the compressed file that will contain the exported table.
 -- Helper Function for partition maintenance
@@ -185,11 +187,11 @@
 tablename=${1}
 filename=${2}
 # NOTE: pg_dump must be available in the path.
-/usr/local/bin/pg_dump -U test-results-user -t public."${tablename}" test-results-user | gzip -c > ${filename} ;
+/usr/local/bin/pg_dump -U test-results-user -t public."${tablename}" test-results-db | gzip -c > ${filename} ;
 $BASH$
 LANGUAGE plsh;
 
-ALTER FUNCTION public.export_partition(text, text) OWNER TO test-results-user;
+ALTER FUNCTION public.export_partition(text, text) OWNER TO "test-results-user";
 
-GRANT EXECUTE ON FUNCTION public.export_partition(text, text) TO test-results-user;
-GRANT EXECUTE ON FUNCTION public.export_partition(text, text) TO test-results-user;
\ No newline at end of file
+GRANT EXECUTE ON FUNCTION public.export_partition(text, text) TO "test-results-user";
+GRANT EXECUTE ON FUNCTION public.export_partition(text, text) TO "test-results-user";






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [203148] trunk/Websites/test-results

2016-07-12 Thread lforschler

Title: [203148] trunk/Websites/test-results








Revision 203148
Author lforsch...@apple.com
Date 2016-07-12 20:30:00 -0700 (Tue, 12 Jul 2016)


Log Message
 Mitigate performance degradation of the flakiness dashboard

Rubber-stamped by Dean Johnson.

* init-database.sql:
Rewrite the init-database.sql file to allow for table partitioning, based on insert date.
Some important things to note:
The main results table is unchanged, but will no longer contain any rows.
Partitioned tables will be generated on demand, and will inherit from 'results'
It is possible to query the 'results' table directly, and that will get data from all child tables.
This should keep us from requiring any client side code changes.

* public_partition_maintenance: Added.
Maintenance script which will be called on a nightly schedule to purge expired data.
This data will be exported and compressed to a sub-folder, then dropped from the database.
I'm not sure how big it will be, so we'll likely need to keep an eye on it.

* test-database.sql: Added.
Simple helper function to test that results partitions are created/deleted correctly.

Modified Paths

trunk/Websites/test-results/ChangeLog
trunk/Websites/test-results/init-database.sql


Added Paths

trunk/Websites/test-results/public_partition_maintenance
trunk/Websites/test-results/test-database.sql




Diff

Modified: trunk/Websites/test-results/ChangeLog (203147 => 203148)

--- trunk/Websites/test-results/ChangeLog	2016-07-13 01:25:25 UTC (rev 203147)
+++ trunk/Websites/test-results/ChangeLog	2016-07-13 03:30:00 UTC (rev 203148)
@@ -1,3 +1,25 @@
+2016-07-12  Lucas Forschler  
+
+ Mitigate performance degradation of the flakiness dashboard
+
+Rubber-stamped by Dean Johnson.
+
+* init-database.sql:
+Rewrite the init-database.sql file to allow for table partitioning, based on insert date.
+Some important things to note:
+The main results table is unchanged, but will no longer contain any rows.
+Partitioned tables will be generated on demand, and will inherit from 'results'
+It is possible to query the 'results' table directly, and that will get data from all child tables.
+This should keep us from requiring any client side code changes.
+
+* public_partition_maintenance: Added.
+Maintenance script which will be called on a nightly schedule to purge expired data.
+This data will be exported and compressed to a sub-folder, then dropped from the database.
+I'm not sure how big it will be, so we'll likely need to keep an eye on it.
+
+* test-database.sql: Added.
+Simple helper function to test that results partitions are created/deleted correctly.
+
 2015-11-09  Ryosuke Niwa  
 
 Allow , in the builder name.


Modified: trunk/Websites/test-results/init-database.sql (203147 => 203148)

--- trunk/Websites/test-results/init-database.sql	2016-07-13 01:25:25 UTC (rev 203147)
+++ trunk/Websites/test-results/init-database.sql	2016-07-13 03:30:00 UTC (rev 203148)
@@ -1,11 +1,15 @@
-DROP TABLE results CASCADE;
-DROP TABLE tests CASCADE;
-DROP TABLE build_revisions CASCADE;
-DROP TABLE builds CASCADE;
-DROP TABLE slaves CASCADE;
-DROP TABLE repositories CASCADE;
-DROP TABLE builders CASCADE;
+-- Configuration file for postgres
 
+-- Drop existing schema. WARNING: this will delete all data in the database
+DROP SCHEMA IF EXISTS public CASCADE;
+CREATE SCHEMA public;
+
+SET search_path TO public;
+SET constraint_exclusion = partition;
+SET work_mem='1GB';
+
+CREATE EXTENSION plsh;
+
 CREATE TABLE builders (
 id serial PRIMARY KEY,
 master varchar(64) NOT NULL,
@@ -64,4 +68,128 @@
 CREATE INDEX results_build ON results(build);
 CREATE INDEX results_is_flaky ON results(is_flaky);
 
-SET work_mem='1024MB';
+-- Code specific to the table partitioning functions below were borrowed from:
+-- https://blog.engineyard.com/2013/scaling-postgresql-performance-table-partitioning
+CREATE OR REPLACE FUNCTION
+public.server_partition_function()
+RETURNS TRIGGER AS 
+$BODY$
+DECLARE
+_new_time int;
+_tablename text;
+_startdate text;
+_enddate text;
+_result record;
+BEGIN
+_tablename := 'results_partition_'||CURRENT_DATE;
+
+-- Check if the partition needed for the current record exists
+PERFORM 1
+FROM   pg_catalog.pg_class c
+JOIN   pg_catalog.pg_namespace n ON n.oid = c.relnamespace
+WHERE  c.relkind = 'r'
+ANDc.relname = _tablename
+ANDn.nspname = 'public';
+
+-- If the partition needed does not yet exist, then we create it:
+-- Note that || is string concatenation (joining two strings to make one)
+IF NOT FOUND THEN
+_enddate:=_startdate::timestamp + INTERVAL '1 day';
+EXECUTE 'CREATE TABLE public.' || quote_ident(_tablename) || ' (
+) INHERITS (public.results)';
+
+-- Table permissions are

[webkit-changes] [202543] trunk/Tools/ChangeLog

2016-06-27 Thread lforschler

Title: [202543] trunk/Tools/ChangeLog








Revision 202543
Author lforsch...@apple.com
Date 2016-06-27 23:11:21 -0700 (Mon, 27 Jun 2016)


Log Message
Test commit. Please ignore.

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (202542 => 202543)

--- trunk/Tools/ChangeLog	2016-06-28 06:09:05 UTC (rev 202542)
+++ trunk/Tools/ChangeLog	2016-06-28 06:11:21 UTC (rev 202543)
@@ -1,3 +1,7 @@
+2016-06-27  Lucas Forschler  
+
+Test commit. Please ignore.
+
 2016-06-27  Michael Catanzaro  
 
 [GTK][EFL] Disable subtle-crypto in FeatureList.pm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202213] trunk/Tools

2016-06-19 Thread lforschler

Title: [202213] trunk/Tools








Revision 202213
Author lforsch...@apple.com
Date 2016-06-19 11:26:52 -0700 (Sun, 19 Jun 2016)


Log Message
Fix master.cfg

Unreviewed build fix.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (202212 => 202213)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2016-06-19 18:02:55 UTC (rev 202212)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2016-06-19 18:26:52 UTC (rev 202213)
@@ -221,7 +221,7 @@
 self.setCommand(self.command + ['_ONLY_ACTIVE_ARCH_=NO'])
 # Generating dSYM files is slow, but these are needed to have line numbers in crash reports on testers.
 # Debug builds on Yosemite can't use dSYMs, because crash logs end up unsymbolicated.
-if platform in ('mac', 'ios') and buildOnly and (fullPlatform != "mac-yosemite" || configuration != "debug"):
+if platform in ('mac', 'ios') and buildOnly and (fullPlatform != "mac-yosemite" or configuration != "debug"):
 self.setCommand(self.command + ['DEBUG_INFORMATION_FORMAT=dwarf-with-dsym'])
 
 appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))


Modified: trunk/Tools/ChangeLog (202212 => 202213)

--- trunk/Tools/ChangeLog	2016-06-19 18:02:55 UTC (rev 202212)
+++ trunk/Tools/ChangeLog	2016-06-19 18:26:52 UTC (rev 202213)
@@ -1,5 +1,14 @@
 2016-06-19  Lucas Forschler  
 
+Fix master.cfg
+
+Unreviewed build fix.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(CompileWebKit.start):
+
+2016-06-19  Lucas Forschler  
+
 Test another commit.
 
 Unreviewed.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202212] trunk/Tools/ChangeLog

2016-06-19 Thread lforschler

Title: [202212] trunk/Tools/ChangeLog








Revision 202212
Author lforsch...@apple.com
Date 2016-06-19 11:02:55 -0700 (Sun, 19 Jun 2016)


Log Message
Test another commit.

Unreviewed.

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (202211 => 202212)

--- trunk/Tools/ChangeLog	2016-06-19 17:51:51 UTC (rev 202211)
+++ trunk/Tools/ChangeLog	2016-06-19 18:02:55 UTC (rev 202212)
@@ -1,6 +1,6 @@
 2016-06-19  Lucas Forschler  
 
-Test commit.
+Test another commit.
 
 Unreviewed.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202210] trunk/Tools/ChangeLog

2016-06-19 Thread lforschler

Title: [202210] trunk/Tools/ChangeLog








Revision 202210
Author lforsch...@apple.com
Date 2016-06-19 10:48:54 -0700 (Sun, 19 Jun 2016)


Log Message
Test commit.

Unreviewed.

Modified Paths

trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/ChangeLog (202209 => 202210)

--- trunk/Tools/ChangeLog	2016-06-19 17:35:43 UTC (rev 202209)
+++ trunk/Tools/ChangeLog	2016-06-19 17:48:54 UTC (rev 202210)
@@ -1,6 +1,6 @@
 2016-06-19  Lucas Forschler  
 
-Test another commit.
+Test commit.
 
 Unreviewed.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [202047] trunk/Tools

2016-06-14 Thread lforschler

Title: [202047] trunk/Tools








Revision 202047
Author lforsch...@apple.com
Date 2016-06-14 09:40:47 -0700 (Tue, 14 Jun 2016)


Log Message

Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12

Rubber-stamped by Jessie Berlin.

* Scripts/copy-webkitlibraries-to-product-directory:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory




Diff

Modified: trunk/Tools/ChangeLog (202046 => 202047)

--- trunk/Tools/ChangeLog	2016-06-14 16:32:50 UTC (rev 202046)
+++ trunk/Tools/ChangeLog	2016-06-14 16:40:47 UTC (rev 202047)
@@ -1,3 +1,12 @@
+2016-06-14  Lucas Forschler  
+
+
+Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
+
+Rubber-stamped by Jessie Berlin.
+
+* Scripts/copy-webkitlibraries-to-product-directory:
+
 2016-06-14  Youenn Fablet  
 
 Activate CMake export compile commands option


Modified: trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory (202046 => 202047)

--- trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2016-06-14 16:32:50 UTC (rev 202046)
+++ trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2016-06-14 16:40:47 UTC (rev 202047)
@@ -145,7 +145,8 @@
 } else {
 push(@librariesToCopy, (
 "libWebKitSystemInterfaceYosemite.a",
-"libWebKitSystemInterfaceElCapitan.a"
+"libWebKitSystemInterfaceElCapitan.a",
+"libWebKitSystemInterfaceOSX10.12.a"
 ));
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201819] trunk/Tools

2016-06-08 Thread lforschler

Title: [201819] trunk/Tools








Revision 201819
Author lforsch...@apple.com
Date 2016-06-08 11:47:42 -0700 (Wed, 08 Jun 2016)


Log Message
Reverted changeset 201814.

* Scripts/copy-webkitlibraries-to-product-directory:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory




Diff

Modified: trunk/Tools/ChangeLog (201818 => 201819)

--- trunk/Tools/ChangeLog	2016-06-08 18:46:43 UTC (rev 201818)
+++ trunk/Tools/ChangeLog	2016-06-08 18:47:42 UTC (rev 201819)
@@ -1,3 +1,9 @@
+2016-06-08  Lucas Forschler  
+
+Reverted changeset 201814.
+
+* Scripts/copy-webkitlibraries-to-product-directory:
+
 2016-06-08  Per Arne Vollan  
 
 [Win] Shadow DOM tests are failing.


Modified: trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory (201818 => 201819)

--- trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2016-06-08 18:46:43 UTC (rev 201818)
+++ trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2016-06-08 18:47:42 UTC (rev 201819)
@@ -145,8 +145,7 @@
 } else {
 push(@librariesToCopy, (
 "libWebKitSystemInterfaceYosemite.a",
-"libWebKitSystemInterfaceElCapitan.a",
-"libWebKitSystemInterfaceOSX10.12.a"
+"libWebKitSystemInterfaceElCapitan.a"
 ));
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201815] trunk

2016-06-08 Thread lforschler

Title: [201815] trunk








Revision 201815
Author lforsch...@apple.com
Date 2016-06-08 11:37:13 -0700 (Wed, 08 Jun 2016)


Log Message
Teach cmake about libWebKitSystemInterfaceOSX10.12
Source/WebCore:


Rubber-stamped by Matt Hanson and Alex Christensen.

* PlatformMac.cmake:

Tools:

This patch also removes duplicated logic inside DumpRenderTree/PlatformMac.cmake

Rubber-stamped by Alex Christensen.
 
* DumpRenderTree/PlatformMac.cmake:
* WebKitTestRunner/PlatformMac.cmake:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformMac.cmake
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/PlatformMac.cmake
trunk/Tools/WebKitTestRunner/PlatformMac.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (201814 => 201815)

--- trunk/Source/WebCore/ChangeLog	2016-06-08 18:25:39 UTC (rev 201814)
+++ trunk/Source/WebCore/ChangeLog	2016-06-08 18:37:13 UTC (rev 201815)
@@ -1,3 +1,11 @@
+2016-06-08  Lucas Forschler  
+
+Teach cmake about libWebKitSystemInterfaceOSX10.12
+
+Rubber-stamped by Matt Hanson and Alex Christensen.
+
+* PlatformMac.cmake:
+
 2016-06-08  Rawinder Singh  
 
 [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface


Modified: trunk/Source/WebCore/PlatformMac.cmake (201814 => 201815)

--- trunk/Source/WebCore/PlatformMac.cmake	2016-06-08 18:25:39 UTC (rev 201814)
+++ trunk/Source/WebCore/PlatformMac.cmake	2016-06-08 18:37:13 UTC (rev 201815)
@@ -4,8 +4,10 @@
 set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceMavericks.a)
 elif ("${CURRENT_OSX_VERSION}" MATCHES "10.10")
 set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceYosemite.a)
+elif ("${CURRENT_OSX_VERSION}" MATCHES "10.11")
+set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceElCapitan.a)
 else ()
-set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceElCapitan.a)
+set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceOSX10.12.a)
 endif ()
 link_directories(../../WebKitLibraries)
 


Modified: trunk/Tools/ChangeLog (201814 => 201815)

--- trunk/Tools/ChangeLog	2016-06-08 18:25:39 UTC (rev 201814)
+++ trunk/Tools/ChangeLog	2016-06-08 18:37:13 UTC (rev 201815)
@@ -1,3 +1,13 @@
+2016-06-08  Lucas Forschler  
+
+Teach cmake about libWebKitSystemInterfaceOSX10.12
+This patch also removes duplicated logic inside DumpRenderTree/PlatformMac.cmake
+
+Rubber-stamped by Alex Christensen.
+ 
+* DumpRenderTree/PlatformMac.cmake:
+* WebKitTestRunner/PlatformMac.cmake:
+
 2016-06-07  Lucas Forschler  
 
 


Modified: trunk/Tools/DumpRenderTree/PlatformMac.cmake (201814 => 201815)

--- trunk/Tools/DumpRenderTree/PlatformMac.cmake	2016-06-08 18:25:39 UTC (rev 201814)
+++ trunk/Tools/DumpRenderTree/PlatformMac.cmake	2016-06-08 18:37:13 UTC (rev 201815)
@@ -7,8 +7,10 @@
 set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceMavericks.a)
 elif ("${CURRENT_OSX_VERSION}" MATCHES "10.10")
 set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceYosemite.a)
-else ()
+elif ("${CURRENT_OSX_VERSION}" MATCHES "10.11")
 set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceElCapitan.a)
+else ()
+set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceOSX10.12.a)
 endif ()
 link_directories(../../WebKitLibraries)
 
@@ -26,13 +28,6 @@
 
 add_definitions("-ObjC++ -std=c++11")
 
-if ("${CURRENT_OSX_VERSION}" MATCHES "10.9")
-set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceMavericks.a)
-elif ("${CURRENT_OSX_VERSION}" MATCHES "10.10")
-set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceYosemite.a)
-else ()
-set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceElCapitan.a)
-endif ()
 link_directories(../../WebKitLibraries)
 include_directories(../../WebKitLibraries)
 


Modified: trunk/Tools/WebKitTestRunner/PlatformMac.cmake (201814 => 201815)

--- trunk/Tools/WebKitTestRunner/PlatformMac.cmake	2016-06-08 18:25:39 UTC (rev 201814)
+++ trunk/Tools/WebKitTestRunner/PlatformMac.cmake	2016-06-08 18:37:13 UTC (rev 201815)
@@ -7,8 +7,10 @@
 set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceMavericks.a)
 elif ("${CURRENT_OSX_VERSION}" MATCHES "10.10")
 set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceYosemite.a)
+elif ("${CURRENT_OSX_VERSION}" MATCHES "10.11")
+set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceElCapitan.a)
 else ()
-set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceElCapitan.a)
+set(WEBKITSYSTEMINTERFACE_LIBRARY libWebKitSystemInterfaceOSX10.12.a)
 endif ()
 link_directories(../../WebKitLibraries)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201814] trunk/Tools

2016-06-08 Thread lforschler

Title: [201814] trunk/Tools








Revision 201814
Author lforsch...@apple.com
Date 2016-06-08 11:25:39 -0700 (Wed, 08 Jun 2016)


Log Message

Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12

Rubber-stamped by Jessie Berlin.

* Scripts/copy-webkitlibraries-to-product-directory:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory




Diff

Modified: trunk/Tools/ChangeLog (201813 => 201814)

--- trunk/Tools/ChangeLog	2016-06-08 18:13:20 UTC (rev 201813)
+++ trunk/Tools/ChangeLog	2016-06-08 18:25:39 UTC (rev 201814)
@@ -1,3 +1,12 @@
+2016-06-07  Lucas Forschler  
+
+
+Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
+
+Rubber-stamped by Jessie Berlin.
+
+* Scripts/copy-webkitlibraries-to-product-directory:
+
 2016-06-08  Aakash Jain  
 
 Don't try to cleanup non-existing ios Simulators


Modified: trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory (201813 => 201814)

--- trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2016-06-08 18:13:20 UTC (rev 201813)
+++ trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2016-06-08 18:25:39 UTC (rev 201814)
@@ -145,7 +145,8 @@
 } else {
 push(@librariesToCopy, (
 "libWebKitSystemInterfaceYosemite.a",
-"libWebKitSystemInterfaceElCapitan.a"
+"libWebKitSystemInterfaceElCapitan.a",
+"libWebKitSystemInterfaceOSX10.12.a"
 ));
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198596] trunk/Tools

2016-03-23 Thread lforschler

Title: [198596] trunk/Tools








Revision 198596
Author lforsch...@apple.com
Date 2016-03-23 14:29:33 -0700 (Wed, 23 Mar 2016)


Log Message
Teach kill-old-processes about perl 5.18.

Reviewed by Alexey Proskuryakov

* BuildSlaveSupport/kill-old-processes:
(main):

Modified Paths

trunk/Tools/BuildSlaveSupport/kill-old-processes
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/kill-old-processes (198595 => 198596)

--- trunk/Tools/BuildSlaveSupport/kill-old-processes	2016-03-23 21:20:38 UTC (rev 198595)
+++ trunk/Tools/BuildSlaveSupport/kill-old-processes	2016-03-23 21:29:33 UTC (rev 198596)
@@ -69,6 +69,7 @@
 "make",
 "perl5.12",
 "perl5.16",
+"perl5.18",
 "perl",
 "Problem Reporter",
 "ruby",


Modified: trunk/Tools/ChangeLog (198595 => 198596)

--- trunk/Tools/ChangeLog	2016-03-23 21:20:38 UTC (rev 198595)
+++ trunk/Tools/ChangeLog	2016-03-23 21:29:33 UTC (rev 198596)
@@ -1,3 +1,12 @@
+2016-03-23  Lucas Forschler  
+
+Teach kill-old-processes about perl 5.18.
+
+Reviewed by Alexey Proskuryakov
+
+* BuildSlaveSupport/kill-old-processes:
+(main):
+
 2016-03-22  Keith Rollin  
 
 Unreviewed: add Keith Rollin to the committers list.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197946] branches/safari-601-branch/Tools

2016-03-10 Thread lforschler

Title: [197946] branches/safari-601-branch/Tools








Revision 197946
Author lforsch...@apple.com
Date 2016-03-10 11:26:32 -0800 (Thu, 10 Mar 2016)


Log Message

Unreviewed build fix attempt.

* Scripts/webkitdirs.pm:
(determineBaseProductDir):
(determineConfiguration):
(determineArchitecture):
(determineNumberOfCPUs):
(jscPath):
(visualStudioInstallDir):
(msBuildInstallDir):
(visualStudioVersion):
(determineConfigurationProductDir):
(productDir):
(executableProductDir):
(jscProductDir):
(configuration):
(determineGenerateDsym):
(hasIOSDevelopmentCertificate):
(argumentsForXcode):
(XcodeOptions):
(XcodeOptionString):
(determinePassedConfiguration):
(passedConfiguration):
(checkFrameworks):
(checkForArgumentAndRemoveFromArrayRef):
(prohibitUnknownPort):
(determinePortName):
(portName):
(isEfl):
(isGtk):
(isWinCairo):
(isWin64):
(determineIsWin64):
(determineIsWin64FromArchitecture):
(isCygwin):
(isARM):
(isX86_64):
(isCrossCompilation):
(isAppleMacWebKit):
(isAppleWinWebKit):
(iOSSimulatorDevicesPath):
(createiOSSimulatorDevice):
(willUseIOSDeviceSDK):
(willUseIOSSimulatorSDK):
(isIOSWebKit):
(determineNmPath):
(nmPath):
(splitVersionString):
(determineOSXVersion):
(osXVersion):
(determineIOSVersion):
(iosVersion):
(isWindowsNT):
(debugger):
(determineDebugger):
(appendToEnvironmentVariableList):
(prependToEnvironmentVariableList):
(setUpGuardMallocIfNeeded):
(launcherName):
(checkRequiredSystemConfig):
(determineWindowsSourceDir):
(setupAppleWinEnv):
(setupCygwinEnv):
(buildXCodeProject):
(buildVisualStudioProject):
(isCachedArgumentfileOutOfDate):
(wrapperPrefixIfNeeded):
(canUseNinja):
(canUseNinjaGenerator):
(canUseEclipseNinjaGenerator):
(cmakeGeneratedBuildfile):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):
(cleanCMakeGeneratedProject):
(buildCMakeProjectOrExit):
(cmakeBasedPortName):
(determineIsCMakeBuild):
(isCMakeBuild):
(promptUser):
(setPathForRunningWebKitApp):
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
(argumentsForRunAndDebugMacWebKitApp):
(setupMacWebKitEnvironment):
(setupIOSWebKitEnvironment):
(waitUntilIOSSimulatorDeviceIsInState):
(shutDownIOSSimulatorDevice):
(restartIOSSimulatorDevice):
(relaunchIOSSimulator):
(runIOSWebKitAppInSimulator):
(runIOSWebKitApp):
(execMacWebKitAppForDebugging):
(debugSafari):
(runSafari):
(runMiniBrowser):
(determineIsEfl): Deleted.
(determineIsGtk): Deleted.
(determineIsWinCairo): Deleted.
(willUseIOSDeviceSDKWhenBuilding): Deleted.
(willUseIOSSimulatorSDKWhenBuilding): Deleted.
(shouldTargetWebProcess): Deleted.
(determineShouldTargetWebProcess): Deleted.
(shouldUseXPCServiceForWebProcess): Deleted.
(determineShouldUseXPCServiceForWebProcess): Deleted.
(jhbuildWrapperPrefixIfNeeded): Deleted.
(canUseEclipse): Deleted.

Modified Paths

branches/safari-601-branch/Tools/ChangeLog
branches/safari-601-branch/Tools/Scripts/webkitdirs.pm




Diff

Modified: branches/safari-601-branch/Tools/ChangeLog (197945 => 197946)

--- branches/safari-601-branch/Tools/ChangeLog	2016-03-10 18:39:46 UTC (rev 197945)
+++ branches/safari-601-branch/Tools/ChangeLog	2016-03-10 19:26:32 UTC (rev 197946)
@@ -1,3 +1,112 @@
+2016-03-10  Lucas Forschler  
+
+
+Unreviewed build fix attempt.
+
+* Scripts/webkitdirs.pm:
+(determineBaseProductDir):
+(determineConfiguration):
+(determineArchitecture):
+(determineNumberOfCPUs):
+(jscPath):
+(visualStudioInstallDir):
+(msBuildInstallDir):
+(visualStudioVersion):
+(determineConfigurationProductDir):
+(productDir):
+(executableProductDir):
+(jscProductDir):
+(configuration):
+(determineGenerateDsym):
+(hasIOSDevelopmentCertificate):
+(argumentsForXcode):
+(XcodeOptions):
+(XcodeOptionString):
+(determinePassedConfiguration):
+(passedConfiguration):
+(checkFrameworks):
+(checkForArgumentAndRemoveFromArrayRef):
+(prohibitUnknownPort):
+(determinePortName):
+(portName):
+(isEfl):
+(isGtk):
+(isWinCairo):
+(isWin64):
+(determineIsWin64):
+(determineIsWin64FromArchitecture):
+(isCygwin):
+(isARM):
+(isX86_64):
+(isCrossCompilation):
+(isAppleMacWebKit):
+(isAppleWinWebKit):
+(iOSSimulatorDevicesPath):
+(createiOSSimulatorDevice):
+(willUseIOSDeviceSDK):
+(willUseIOSSimulatorSDK):
+(isIOSWebKit):
+(determineNmPath):
+(nmPath):
+(splitVersionString):
+(determineOSXVersion):
+(osXVersion):
+(determineIOSVersion):
+(iosVersion):
+(isWindowsNT):
+(debugger):
+(determineDebugger):
+(appendToEnvironmentVariableList):
+(prependToEnvironmentVariableList):
+(setUpGuardMallocIfNeeded):
+(launcherName):
+(checkRequiredSystemConfig):
+

[webkit-changes] [197607] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

2016-03-04 Thread lforschler

Title: [197607] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json








Revision 197607
Author lforsch...@apple.com
Date 2016-03-04 19:42:06 -0800 (Fri, 04 Mar 2016)


Log Message
config.json fix to remove duplicate scheduler.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (197606 => 197607)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2016-03-05 03:30:19 UTC (rev 197606)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2016-03-05 03:42:06 UTC (rev 197607)
@@ -357,11 +357,8 @@
   "builderNames": ["Apple iOS 9 Release (Build)"]
 },
 { "type": "PlatformSpecificScheduler", "platform": "ios-simulator-9", "branch": "trunk", "treeStableTimer": 45.0,
-  "builderNames": ["Apple iOS 9 Simulator Release (Build)"]
+  "builderNames": ["Apple iOS 9 Simulator Release (Build)", "Apple iOS 9 Simulator Debug (Build)"]
 },
-{ "type": "PlatformSpecificScheduler", "platform": "ios-simulator-9", "branch": "trunk", "treeStableTimer": 45.0,
-  "builderNames": ["Apple iOS 9 Simulator Debug (Build)"]
-},
 { "type": "PlatformSpecificScheduler", "platform": "win", "branch": "trunk", "treeStableTimer": 45.0,
   "builderNames": ["Apple Win Release (Build)", "Apple Win Debug (Build)"]
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192517] trunk/Websites/bugs.webkit.org

2015-11-17 Thread lforschler

Title: [192517] trunk/Websites/bugs.webkit.org








Revision 192517
Author lforsch...@apple.com
Date 2015-11-17 11:30:14 -0800 (Tue, 17 Nov 2015)


Log Message
Commit working changes from build.webkit.org

Modified Paths

trunk/Websites/bugs.webkit.org/Bugzilla/Util.pm
trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/data/params
trunk/Websites/bugs.webkit.org/jobqueue.pl




Diff

Modified: trunk/Websites/bugs.webkit.org/Bugzilla/Util.pm (192516 => 192517)

--- trunk/Websites/bugs.webkit.org/Bugzilla/Util.pm	2015-11-17 19:11:22 UTC (rev 192516)
+++ trunk/Websites/bugs.webkit.org/Bugzilla/Util.pm	2015-11-17 19:30:14 UTC (rev 192517)
@@ -654,12 +654,17 @@
 sub validate_email_syntax {
 my ($addr) = @_;
 my $match = Bugzilla->params->{'emailregexp'};
-my $ret = ($addr =~ /$match/ && $addr !~ /[\\\(\)<>&,;:"\[\] \t\r\n\P{ASCII}]/);
-if ($ret) {
+# We set the max length to 127 to ensure addresses aren't truncated when
+# inserted into the tokens.eventdata field.
+if ($addr =~ /$match/
+&& $addr !~ /[\\\(\)<>&,;:"\[\] \t\r\n\P{ASCII}]/
+&& length($addr) <= 127)
+{
 # We assume these checks to suffice to consider the address untainted.
 trick_taint($_[0]);
+return 1;
 }
-return $ret ? 1 : 0;
+return 0;
 }
 
 sub validate_date {


Modified: trunk/Websites/bugs.webkit.org/ChangeLog (192516 => 192517)

--- trunk/Websites/bugs.webkit.org/ChangeLog	2015-11-17 19:11:22 UTC (rev 192516)
+++ trunk/Websites/bugs.webkit.org/ChangeLog	2015-11-17 19:30:14 UTC (rev 192517)
@@ -1,3 +1,10 @@
+2015-11-17  Lucas Forschler  
+
+bugs.webkit.org is running with changes that are not checked in.
+Check them in.
+
+Reviewed by Matt Hanson.
+ 
 2015-07-30  Aakash Jain  
 
 Replace Google App Engine with AppScale


Modified: trunk/Websites/bugs.webkit.org/data/params (192516 => 192517)

--- trunk/Websites/bugs.webkit.org/data/params	2015-11-17 19:11:22 UTC (rev 192516)
+++ trunk/Websites/bugs.webkit.org/data/params	2015-11-17 19:30:14 UTC (rev 192517)
@@ -85,7 +85,7 @@
'timetrackinggroup' => '',
'upgrade_notification' => 'latest_stable_release',
'urlbase' => 'https://bugs.webkit.org/',
-   'use_mailer_queue' => 0,
+   'use_mailer_queue' => '1',
'use_see_also' => 1,
'usebugaliases' => '1',
'useclassification' => 0,


Modified: trunk/Websites/bugs.webkit.org/jobqueue.pl (192516 => 192517)

--- trunk/Websites/bugs.webkit.org/jobqueue.pl	2015-11-17 19:11:22 UTC (rev 192516)
+++ trunk/Websites/bugs.webkit.org/jobqueue.pl	2015-11-17 19:30:14 UTC (rev 192517)
@@ -1,4 +1,4 @@
-#!/usr/bin/env perl -w
+#!/usr/bin/perl
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191843] trunk/Tools

2015-10-31 Thread lforschler

Title: [191843] trunk/Tools








Revision 191843
Author lforsch...@apple.com
Date 2015-10-31 10:35:51 -0700 (Sat, 31 Oct 2015)


Log Message
Teach the CompileWebKit step to look for additional arguments.

Unreviewed config change.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (191842 => 191843)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2015-10-31 16:52:39 UTC (rev 191842)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2015-10-31 17:35:51 UTC (rev 191843)
@@ -209,6 +209,10 @@
 platform = self.getProperty('platform')
 buildOnly = self.getProperty('buildOnly')
 architecture = self.getProperty('architecture')
+additionalArguments = self.getProperty('additionalArguments')
+
+if additionalArguments:
+self.setCommand(self.command + additionalArguments)
 if platform in ('mac', 'ios') and architecture:
 self.setCommand(self.command + ['ARCHS=' + architecture])
 if platform == 'ios':


Modified: trunk/Tools/ChangeLog (191842 => 191843)

--- trunk/Tools/ChangeLog	2015-10-31 16:52:39 UTC (rev 191842)
+++ trunk/Tools/ChangeLog	2015-10-31 17:35:51 UTC (rev 191843)
@@ -1,3 +1,12 @@
+2015-10-31  Lucas Forschler  
+
+Teach the CompileWebKit step to look for additional arguments.
+
+Unreviewed config change.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(CompileWebKit.start):
+
 2015-10-30  Anders Carlsson  
 
 Begin work on supporting reply blocks in _WKRemoteObjectRegistry






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191827] trunk/Tools

2015-10-30 Thread lforschler

Title: [191827] trunk/Tools








Revision 191827
Author lforsch...@apple.com
Date 2015-10-30 16:35:25 -0700 (Fri, 30 Oct 2015)


Log Message
Add CMAke builder to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=150738

Reviewed by Alex Christensen.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (191826 => 191827)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2015-10-30 23:20:02 UTC (rev 191826)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2015-10-30 23:35:25 UTC (rev 191827)
@@ -45,6 +45,7 @@
 { "name": "bot162", "platform": "mac-elcapitan" },
 { "name": "bot165", "platform": "mac-elcapitan" },
 { "name": "bot169", "platform": "mac-elcapitan" },
+{ "name": "bot170", "platform": "mac-elcapitan" },
 { "name": "bot173", "platform": "mac-elcapitan" },
 { "name": "bot174", "platform": "mac-elcapitan" },
 { "name": "bot205", "platform": "mac-elcapitan" },
@@ -95,6 +96,11 @@
   "triggers": ["elcapitan-debug-tests-jsc", "elcapitan-debug-tests-wk1", "elcapitan-debug-tests-wk2"],
   "slavenames": ["bot415", "bot416"]
 },
+{ "name": "Apple El Capitan CMake Debug (Build)", "type": "Build", "builddir": "elcapitan-cmake-debug",
+  "platform": "mac-elcapitan", "configuration": "debug", "architectures": ["x86_64"],
+  "additionalArguments": ["--cmake"],
+  "slavenames": ["bot170"]
+},
 { "name": "Apple El Capitan Debug JSC (Tests)", "type": "TestJSC", "builddir": "elcapitan-debug-tests-jsc",
   "platform": "mac-elcapitan", "configuration": "debug", "architectures": ["x86_64"],
   "slavenames": ["bot210"]
@@ -384,7 +390,7 @@
   "builderNames": ["Apple Yosemite Release (Build)", "Apple Yosemite Debug (Build)", "Apple Yosemite LLINT CLoop (BuildAndTest)", "Apple Yosemite 32-bit JSC (BuildAndTest)", "Apple Yosemite Release (32-bit Build)"]
 },
 { "type": "PlatformSpecificScheduler", "platform": "mac-elcapitan", "branch": "trunk", "treeStableTimer": 45.0,
-  "builderNames": ["Apple El Capitan Release (Build)", "Apple El Capitan Debug (Build)", "Apple El Capitan LLINT CLoop (BuildAndTest)", "Apple El Capitan 32-bit JSC (BuildAndTest)", "Apple El Capitan Release (32-bit Build)"]
+  "builderNames": ["Apple El Capitan Release (Build)", "Apple El Capitan Debug (Build)", "Apple El Capitan LLINT CLoop (BuildAndTest)", "Apple El Capitan 32-bit JSC (BuildAndTest)", "Apple El Capitan Release (32-bit Build)", "Apple El Capitan CMake Debug (Build)"]
 },
 { "type": "PlatformSpecificScheduler", "platform": "ios-9", "branch": "trunk", "treeStableTimer": 45.0,
   "builderNames": ["Apple iOS 9 Release (Build)"]


Modified: trunk/Tools/ChangeLog (191826 => 191827)

--- trunk/Tools/ChangeLog	2015-10-30 23:20:02 UTC (rev 191826)
+++ trunk/Tools/ChangeLog	2015-10-30 23:35:25 UTC (rev 191827)
@@ -1,3 +1,12 @@
+2015-10-30  Lucas Forschler  
+
+Add CMAke builder to build.webkit.org
+https://bugs.webkit.org/show_bug.cgi?id=150738
+
+Reviewed by Alex Christensen.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
 2015-10-30  Brent Fulgham  
 
 [Win] build-jsc and run-_javascript_core-tests do not work






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191823] branches/safari-601.1.46-branch/Source

2015-10-30 Thread lforschler

Title: [191823] branches/safari-601.1.46-branch/Source








Revision 191823
Author lforsch...@apple.com
Date 2015-10-30 15:35:22 -0700 (Fri, 30 Oct 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig (191822 => 191823)

--- branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-30 22:33:27 UTC (rev 191822)
+++ branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-30 22:35:22 UTC (rev 191823)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 45;
+MICRO_VERSION = 46;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig (191822 => 191823)

--- branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-30 22:33:27 UTC (rev 191822)
+++ branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-30 22:35:22 UTC (rev 191823)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 45;
+MICRO_VERSION = 46;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (191822 => 191823)

--- branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-30 22:33:27 UTC (rev 191822)
+++ branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-30 22:35:22 UTC (rev 191823)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 45;
+MICRO_VERSION = 46;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig (191822 => 191823)

--- branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-30 22:33:27 UTC (rev 191822)
+++ branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-30 22:35:22 UTC (rev 191823)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 45;
+MICRO_VERSION = 46;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig (191822 => 191823)

--- branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-30 22:33:27 UTC (rev 191822)
+++ branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-30 22:35:22 UTC (rev 191823)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 45;
+MICRO_VERSION = 46;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191822] tags/Safari-601.1.46.45/

2015-10-30 Thread lforschler

Title: [191822] tags/Safari-601.1.46.45/








Revision 191822
Author lforsch...@apple.com
Date 2015-10-30 15:33:27 -0700 (Fri, 30 Oct 2015)


Log Message
New Tag.

Added Paths

tags/Safari-601.1.46.45/




Diff

Property changes: tags/Safari-601.1.46.45



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191820] branches/safari-601-branch/Source

2015-10-30 Thread lforschler

Title: [191820] branches/safari-601-branch/Source








Revision 191820
Author lforsch...@apple.com
Date 2015-10-30 15:30:49 -0700 (Fri, 30 Oct 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig (191819 => 191820)

--- branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-30 22:24:58 UTC (rev 191819)
+++ branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-30 22:30:49 UTC (rev 191820)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 3;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig (191819 => 191820)

--- branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-30 22:24:58 UTC (rev 191819)
+++ branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-30 22:30:49 UTC (rev 191820)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 3;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (191819 => 191820)

--- branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-30 22:24:58 UTC (rev 191819)
+++ branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-30 22:30:49 UTC (rev 191820)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 3;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig (191819 => 191820)

--- branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-30 22:24:58 UTC (rev 191819)
+++ branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-30 22:30:49 UTC (rev 191820)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 3;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig (191819 => 191820)

--- branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-30 22:24:58 UTC (rev 191819)
+++ branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-30 22:30:49 UTC (rev 191820)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 3;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191819] tags/Safari-600.1.3.8/

2015-10-30 Thread lforschler

Title: [191819] tags/Safari-600.1.3.8/








Revision 191819
Author lforsch...@apple.com
Date 2015-10-30 15:24:58 -0700 (Fri, 30 Oct 2015)


Log Message
New Tag.

Added Paths

tags/Safari-600.1.3.8/




Diff

Property changes: tags/Safari-600.1.3.8



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191790] branches/safari-601-branch/LayoutTests

2015-10-30 Thread lforschler

Title: [191790] branches/safari-601-branch/LayoutTests








Revision 191790
Author lforsch...@apple.com
Date 2015-10-30 09:51:19 -0700 (Fri, 30 Oct 2015)


Log Message
Merged r188366.  

Modified Paths

branches/safari-601-branch/LayoutTests/ChangeLog
branches/safari-601-branch/LayoutTests/http/tests/resources/redirect.php




Diff

Modified: branches/safari-601-branch/LayoutTests/ChangeLog (191789 => 191790)

--- branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-30 13:25:26 UTC (rev 191789)
+++ branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-30 16:51:19 UTC (rev 191790)
@@ -1,3 +1,18 @@
+2015-10-30  Lucas Forschler  
+
+Merge r188366
+
+2015-08-12  Alexey Proskuryakov  
+
+http/tests/security/cors-post-redirect-308.html doesn't work properly
+https://bugs.webkit.org/show_bug.cgi?id=147914
+
+Reviewed by Brady Eidson.
+
+* http/tests/resources/redirect.php: Trying to return
+code 308 without a reason phrase results in an internal server error with Apache/2.2.
+While at it, also corrected the script to always set Cache-Control: no-store.
+
 2015-10-29  Lucas Forschler  
 
 Merge r191706. rdar://problem/23319292


Modified: branches/safari-601-branch/LayoutTests/http/tests/resources/redirect.php (191789 => 191790)

--- branches/safari-601-branch/LayoutTests/http/tests/resources/redirect.php	2015-10-30 13:25:26 UTC (rev 191789)
+++ branches/safari-601-branch/LayoutTests/http/tests/resources/redirect.php	2015-10-30 16:51:19 UTC (rev 191790)
@@ -1,20 +1,28 @@
 +function addCacheControl() {
+# Workaround for https://bugs.webkit.org/show_bug.cgi?id=77538
+# Caching redirects results in flakiness in tests that dump loader delegates.
+header("Cache-Control: no-store");
+}
+
 $url = ""
 $refresh = $_GET['refresh'];
 
 if (isset($refresh)) {
 header("HTTP/1.1 200");
 header("Refresh: $refresh; url=""
+addCacheControl();
 return;
 }
 
 $code = $_GET['code'];
 if (!isset($code))
-$code = 302;
-header("HTTP/1.1 $code");
+header("HTTP/1.1 302 Found");
+elseif ($code == 308) {
+# Apache 2.2 (and possibly some newer versions) cannot generate a reason string for code 308, and sends a 500 error instead.
+header("HTTP/1.1 308 Permanent Redirect");
+} else
+header("HTTP/1.1 $code");
 header("Location: $url");
-
-# Workaround for https://bugs.webkit.org/show_bug.cgi?id=77538
-# Caching redirects results in flakiness in tests that dump loader delegates.
-header("Cache-Control: no-store");
+addCacheControl();
 ?>






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191769] branches/safari-601.1.46-branch

2015-10-29 Thread lforschler

Title: [191769] branches/safari-601.1.46-branch








Revision 191769
Author lforsch...@apple.com
Date 2015-10-29 18:31:43 -0700 (Thu, 29 Oct 2015)


Log Message
Merged r191706.  rdar://problem/23319282

Modified Paths

branches/safari-601.1.46-branch/LayoutTests/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/loader/ContentFilter.cpp


Added Paths

branches/safari-601.1.46-branch/LayoutTests/contentfiltering/allow-empty-document-expected.html
branches/safari-601.1.46-branch/LayoutTests/contentfiltering/allow-empty-document.html
branches/safari-601.1.46-branch/LayoutTests/contentfiltering/resources/empty.html




Diff

Modified: branches/safari-601.1.46-branch/LayoutTests/ChangeLog (191768 => 191769)

--- branches/safari-601.1.46-branch/LayoutTests/ChangeLog	2015-10-30 01:28:23 UTC (rev 191768)
+++ branches/safari-601.1.46-branch/LayoutTests/ChangeLog	2015-10-30 01:31:43 UTC (rev 191769)
@@ -1,3 +1,19 @@
+2015-10-29  Lucas Forschler  
+
+Merge r191706. rdar://problem/23319282
+
+2015-10-28  Andy Estes  
+
+[Content Filtering] Crash when allowing a 0-byte resource to load
+https://bugs.webkit.org/show_bug.cgi?id=150644
+
+
+Reviewed by Darin Adler.
+
+* contentfiltering/allow-empty-document-expected.html: Added.
+* contentfiltering/allow-empty-document.html: Added.
+* contentfiltering/resources/empty.html: Added.
+
 2015-10-20  Matthew Hanson  
 
 Merge r191364. rdar://problem/22864960


Copied: branches/safari-601.1.46-branch/LayoutTests/contentfiltering/allow-empty-document-expected.html (from rev 191706, trunk/LayoutTests/contentfiltering/allow-empty-document-expected.html) (0 => 191769)

--- branches/safari-601.1.46-branch/LayoutTests/contentfiltering/allow-empty-document-expected.html	(rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/contentfiltering/allow-empty-document-expected.html	2015-10-30 01:31:43 UTC (rev 191769)
@@ -0,0 +1,2 @@
+
+

Copied: branches/safari-601.1.46-branch/LayoutTests/contentfiltering/allow-empty-document.html (from rev 191706, trunk/LayoutTests/contentfiltering/allow-empty-document.html) (0 => 191769)

--- branches/safari-601.1.46-branch/LayoutTests/contentfiltering/allow-empty-document.html	(rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/contentfiltering/allow-empty-document.html	2015-10-30 01:31:43 UTC (rev 191769)
@@ -0,0 +1,10 @@
+
+
+if (window.internals) {
+var settings = window.internals.mockContentFilterSettings;
+settings.enabled = true;
+settings.decisionPoint = settings.DECISION_POINT_AFTER_FINISHED_ADDING_DATA;
+settings.decision = settings.DECISION_ALLOW;
+}
+
+

Copied: branches/safari-601.1.46-branch/LayoutTests/contentfiltering/resources/empty.html (from rev 191706, trunk/LayoutTests/contentfiltering/resources/empty.html) ( => )

Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
===
--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-10-30 01:28:23 UTC (rev 191768)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-10-30 01:31:43 UTC (rev 191769)
@@ -1,3 +1,20 @@
+2015-10-29  Lucas Forschler  
+
+Merge r191706. rdar://problem/23319282
+
+2015-10-28  Andy Estes  
+
+[Content Filtering] Crash when allowing a 0-byte resource to load
+https://bugs.webkit.org/show_bug.cgi?id=150644
+
+
+Reviewed by Darin Adler.
+
+Test: contentfiltering/allow-empty-document.html
+
+* loader/ContentFilter.cpp:
+(WebCore::ContentFilter::deliverResourceData): resourceBuffer will be null if the resource contained no data.
+
 2015-10-27  Matthew Hanson  
 
 Merge r191636. rdar://problem/23077744


Modified: branches/safari-601.1.46-branch/Source/WebCore/loader/ContentFilter.cpp (191768 => 191769)

--- branches/safari-601.1.46-branch/Source/WebCore/loader/ContentFilter.cpp	2015-10-30 01:28:23 UTC (rev 191768)
+++ branches/safari-601.1.46-branch/Source/WebCore/loader/ContentFilter.cpp	2015-10-30 01:31:43 UTC (rev 191769)
@@ -259,8 +259,8 @@
 void ContentFilter::deliverResourceData(CachedResource& resource)
 {
 ASSERT(resource.dataBufferingPolicy() == BufferData);
-const SharedBuffer& resourceBuffer = *resource.resourceBuffer();
-m_documentLoader.dataReceived(&resource, resourceBuffer.data(), resourceBuffer.size());
+if (auto* resourceBuffer = resource.resourceBuffer())
+m_documentLoader.dataReceived(&resource, resourceBuffer->data(), resourceBuffer->size());
 }
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191752] branches/safari-601-branch

2015-10-29 Thread lforschler

Title: [191752] branches/safari-601-branch








Revision 191752
Author lforsch...@apple.com
Date 2015-10-29 13:51:28 -0700 (Thu, 29 Oct 2015)


Log Message
Merged r191706.  rdar://problem/23319292

Modified Paths

branches/safari-601-branch/LayoutTests/ChangeLog
branches/safari-601-branch/Source/WebCore/ChangeLog
branches/safari-601-branch/Source/WebCore/loader/ContentFilter.cpp


Added Paths

branches/safari-601-branch/LayoutTests/contentfiltering/allow-empty-document-expected.html
branches/safari-601-branch/LayoutTests/contentfiltering/allow-empty-document.html
branches/safari-601-branch/LayoutTests/contentfiltering/resources/empty.html




Diff

Modified: branches/safari-601-branch/LayoutTests/ChangeLog (191751 => 191752)

--- branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-29 20:18:56 UTC (rev 191751)
+++ branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-29 20:51:28 UTC (rev 191752)
@@ -1,3 +1,19 @@
+2015-10-29  Lucas Forschler  
+
+Merge r191706. rdar://problem/23319292
+
+2015-10-28  Andy Estes  
+
+[Content Filtering] Crash when allowing a 0-byte resource to load
+https://bugs.webkit.org/show_bug.cgi?id=150644
+
+
+Reviewed by Darin Adler.
+
+* contentfiltering/allow-empty-document-expected.html: Added.
+* contentfiltering/allow-empty-document.html: Added.
+* contentfiltering/resources/empty.html: Added.
+
 2015-10-26  Matthew Hanson  
 
 Merge r191530. rdar://problem/23206864


Copied: branches/safari-601-branch/LayoutTests/contentfiltering/allow-empty-document-expected.html (from rev 191706, trunk/LayoutTests/contentfiltering/allow-empty-document-expected.html) (0 => 191752)

--- branches/safari-601-branch/LayoutTests/contentfiltering/allow-empty-document-expected.html	(rev 0)
+++ branches/safari-601-branch/LayoutTests/contentfiltering/allow-empty-document-expected.html	2015-10-29 20:51:28 UTC (rev 191752)
@@ -0,0 +1,2 @@
+
+

Copied: branches/safari-601-branch/LayoutTests/contentfiltering/allow-empty-document.html (from rev 191706, trunk/LayoutTests/contentfiltering/allow-empty-document.html) (0 => 191752)

--- branches/safari-601-branch/LayoutTests/contentfiltering/allow-empty-document.html	(rev 0)
+++ branches/safari-601-branch/LayoutTests/contentfiltering/allow-empty-document.html	2015-10-29 20:51:28 UTC (rev 191752)
@@ -0,0 +1,10 @@
+
+
+if (window.internals) {
+var settings = window.internals.mockContentFilterSettings;
+settings.enabled = true;
+settings.decisionPoint = settings.DECISION_POINT_AFTER_FINISHED_ADDING_DATA;
+settings.decision = settings.DECISION_ALLOW;
+}
+
+

Copied: branches/safari-601-branch/LayoutTests/contentfiltering/resources/empty.html (from rev 191706, trunk/LayoutTests/contentfiltering/resources/empty.html) ( => )

Modified: branches/safari-601-branch/Source/WebCore/ChangeLog
===
--- branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-29 20:18:56 UTC (rev 191751)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-29 20:51:28 UTC (rev 191752)
@@ -1,3 +1,20 @@
+2015-10-29  Lucas Forschler  
+
+Merge r191706. rdar://problem/23319292
+
+2015-10-28  Andy Estes  
+
+[Content Filtering] Crash when allowing a 0-byte resource to load
+https://bugs.webkit.org/show_bug.cgi?id=150644
+
+
+Reviewed by Darin Adler.
+
+Test: contentfiltering/allow-empty-document.html
+
+* loader/ContentFilter.cpp:
+(WebCore::ContentFilter::deliverResourceData): resourceBuffer will be null if the resource contained no data.
+
 2015-10-27  Matthew Hanson  
 
 Merge r191636. rdar://problem/23078059


Modified: branches/safari-601-branch/Source/WebCore/loader/ContentFilter.cpp (191751 => 191752)

--- branches/safari-601-branch/Source/WebCore/loader/ContentFilter.cpp	2015-10-29 20:18:56 UTC (rev 191751)
+++ branches/safari-601-branch/Source/WebCore/loader/ContentFilter.cpp	2015-10-29 20:51:28 UTC (rev 191752)
@@ -259,8 +259,8 @@
 void ContentFilter::deliverResourceData(CachedResource& resource)
 {
 ASSERT(resource.dataBufferingPolicy() == BufferData);
-const SharedBuffer& resourceBuffer = *resource.resourceBuffer();
-m_documentLoader.dataReceived(&resource, resourceBuffer.data(), resourceBuffer.size());
+if (auto* resourceBuffer = resource.resourceBuffer())
+m_documentLoader.dataReceived(&resource, resourceBuffer->data(), resourceBuffer->size());
 }
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191747] trunk/Tools

2015-10-29 Thread lforschler

Title: [191747] trunk/Tools








Revision 191747
Author lforsch...@apple.com
Date 2015-10-29 12:39:30 -0700 (Thu, 29 Oct 2015)


Log Message
Teach JSC bots to build 32bit instead of x86_64

Reviewed by Mark Lam.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (191746 => 191747)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2015-10-29 19:35:31 UTC (rev 191746)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2015-10-29 19:39:30 UTC (rev 191747)
@@ -179,7 +179,7 @@
   "slavenames": ["bot136"]
 },
 { "name": "Apple Mavericks 32-bit JSC (BuildAndTest)", "type": "BuildAndTest32bitJSC", "builddir": "mavericks-32bitJSC-debug",
-  "platform": "mac-mavericks", "configuration": "debug", "architectures": ["x86_64"],
+  "platform": "mac-mavericks", "configuration": "debug", "architectures": ["i386"],
   "slavenames": ["bot629"]
 },
 { "name": "Apple Mavericks Release (Build)", "type": "Build", "builddir": "mavericks-release",
@@ -226,7 +226,7 @@
   "slavenames": ["bot186"]
 },
 { "name": "Apple Yosemite 32-bit JSC (BuildAndTest)", "type": "BuildAndTest32bitJSC", "builddir": "yosemite-32bitJSC-debug",
-  "platform": "mac-yosemite", "configuration": "debug", "architectures": ["x86_64"],
+  "platform": "mac-yosemite", "configuration": "debug", "architectures": ["i386"],
   "slavenames": ["bot187"]
 },
 { "name": "Apple Yosemite Release (Build)", "type": "Build", "builddir": "yosemite-release",


Modified: trunk/Tools/ChangeLog (191746 => 191747)

--- trunk/Tools/ChangeLog	2015-10-29 19:35:31 UTC (rev 191746)
+++ trunk/Tools/ChangeLog	2015-10-29 19:39:30 UTC (rev 191747)
@@ -1,3 +1,11 @@
+2015-10-29  Lucas Forschler  
+
+Teach JSC bots to build 32bit instead of x86_64
+
+Reviewed by Mark Lam.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
 2015-10-29  Per Arne Vollan  
 
 [WinCairo] Fall back to AppleWin results in layout tests.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190811] branches/safari-601-branch/Source/WebCore

2015-10-09 Thread lforschler

Title: [190811] branches/safari-601-branch/Source/WebCore








Revision 190811
Author lforsch...@apple.com
Date 2015-10-09 11:41:12 -0700 (Fri, 09 Oct 2015)


Log Message
Merged r189168.  

Modified Paths

branches/safari-601-branch/Source/WebCore/ChangeLog
branches/safari-601-branch/Source/WebCore/page/EventHandler.h




Diff

Modified: branches/safari-601-branch/Source/WebCore/ChangeLog (190810 => 190811)

--- branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-09 18:36:49 UTC (rev 190810)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-09 18:41:12 UTC (rev 190811)
@@ -1,3 +1,15 @@
+2015-10-09  Lucas Forschler  
+
+Merge r189168
+
+2015-08-31  Alexey Proskuryakov  
+
+Build fix.
+
+* page/EventHandler.h:
+(WebCore::EventHandler::immediateActionStage): Don't export an inline function,
+to avoid "weak external symbol" errors.
+
 2015-10-08  Lucas Forschler  
 
 Merge r190602. rdar://problem/22995830


Modified: branches/safari-601-branch/Source/WebCore/page/EventHandler.h (190810 => 190811)

--- branches/safari-601-branch/Source/WebCore/page/EventHandler.h	2015-10-09 18:36:49 UTC (rev 190810)
+++ branches/safari-601-branch/Source/WebCore/page/EventHandler.h	2015-10-09 18:41:12 UTC (rev 190811)
@@ -314,7 +314,7 @@
 bool isHandlingWheelEvent() const { return m_isHandlingWheelEvent; }
 
 WEBCORE_EXPORT void setImmediateActionStage(ImmediateActionStage stage);
-WEBCORE_EXPORT ImmediateActionStage immediateActionStage() const { return m_immediateActionStage; }
+ImmediateActionStage immediateActionStage() const { return m_immediateActionStage; }
 
 private:
 #if ENABLE(DRAG_SUPPORT)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190807] branches/safari-601-branch/LayoutTests/http/tests/cache/disk-cache /disk-cache-last-modified-expected.txt

2015-10-09 Thread lforschler

Title: [190807] branches/safari-601-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-last-modified-expected.txt








Revision 190807
Author lforsch...@apple.com
Date 2015-10-09 10:31:40 -0700 (Fri, 09 Oct 2015)


Log Message
Rebaseline after r190494.

Modified Paths

branches/safari-601-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-last-modified-expected.txt




Diff

Modified: branches/safari-601-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-last-modified-expected.txt (190806 => 190807)

--- branches/safari-601-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-last-modified-expected.txt	2015-10-09 17:30:36 UTC (rev 190806)
+++ branches/safari-601-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-last-modified-expected.txt	2015-10-09 17:31:40 UTC (rev 190807)
@@ -5,7 +5,6 @@
 
 running 3 tests
 
-Testing loads from disk cache
 response headers: {"Last-Modified":"Thu, 01 Jan 2000 00:00:00 GMT"}
 response source: Disk cache
 
@@ -15,26 +14,6 @@
 response headers: {"Last-Modified":"invalid"}
 response source: Network
 
-Testing loads through memory cache (XHR behavior)
-response headers: {"Last-Modified":"Thu, 01 Jan 2000 00:00:00 GMT"}
-response source: Memory cache
-
-response headers: {"Last-Modified":"Thu, 01 Jan 1970 00:00:00 GMT"}
-response source: Network
-
-response headers: {"Last-Modified":"invalid"}
-response source: Network
-
-Testing loads through memory cache (subresource behavior)
-response headers: {"Last-Modified":"Thu, 01 Jan 2000 00:00:00 GMT"}
-response source: Memory cache
-
-response headers: {"Last-Modified":"Thu, 01 Jan 1970 00:00:00 GMT"}
-response source: Network
-
-response headers: {"Last-Modified":"invalid"}
-response source: Network
-
 PASS successfullyParsed is true
 
 TEST COMPLETE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190774] branches/safari-601-branch

2015-10-08 Thread lforschler

Title: [190774] branches/safari-601-branch








Revision 190774
Author lforsch...@apple.com
Date 2015-10-08 19:37:29 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r190602.  rdar://problem/22995830

Modified Paths

branches/safari-601-branch/LayoutTests/ChangeLog
branches/safari-601-branch/Source/WebCore/ChangeLog
branches/safari-601-branch/Source/WebCore/contentextensions/ContentExtensionParser.cpp


Added Paths

branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector-expected.html
branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector.html
branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector.html.json




Diff

Modified: branches/safari-601-branch/LayoutTests/ChangeLog (190773 => 190774)

--- branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-09 02:29:36 UTC (rev 190773)
+++ branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-09 02:37:29 UTC (rev 190774)
@@ -1,5 +1,21 @@
 2015-10-08  Lucas Forschler  
 
+Merge r190602. rdar://problem/22995830
+
+2015-10-05  Alex Christensen  
+
+Invalid CSS Selector for Content Blockers invalidates others
+https://bugs.webkit.org/show_bug.cgi?id=148446
+rdar://problem/22918235
+
+Reviewed by Benjamin Poulain.
+
+* http/tests/contentextensions/invalid-selector-expected.txt: Added.
+* http/tests/contentextensions/invalid-selector.html: Added.
+* http/tests/contentextensions/invalid-selector.html.json: Added.
+
+2015-10-08  Lucas Forschler  
+
 Merge r190375. rdar://problem/22881748
 
 2015-09-30  Myles C. Maxfield  


Copied: branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector-expected.html (from rev 190602, trunk/LayoutTests/http/tests/contentextensions/invalid-selector-expected.html) (0 => 190774)

--- branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector-expected.html	(rev 0)
+++ branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector-expected.html	2015-10-09 02:37:29 UTC (rev 190774)
@@ -0,0 +1 @@
+This text should be visible because the class is an invalid selector.


Copied: branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector.html (from rev 190602, trunk/LayoutTests/http/tests/contentextensions/invalid-selector.html) (0 => 190774)

--- branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector.html	(rev 0)
+++ branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector.html	2015-10-09 02:37:29 UTC (rev 190774)
@@ -0,0 +1,5 @@
+
+This text should not be visible.
+This text should not be visible.
+This text should be visible because the class is an invalid selector.
+


Copied: branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector.html.json (from rev 190602, trunk/LayoutTests/http/tests/contentextensions/invalid-selector.html.json) (0 => 190774)

--- branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector.html.json	(rev 0)
+++ branches/safari-601-branch/LayoutTests/http/tests/contentextensions/invalid-selector.html.json	2015-10-09 02:37:29 UTC (rev 190774)
@@ -0,0 +1,41 @@
+[{
+  "action" : {
+"type" : "css-display-none",
+"selector" : "body{"
+  },
+  "trigger" : {
+"url-filter" : ".*"
+  }
+},{
+  "action" : {
+"type" : "css-display-none",
+"selector" : ".valid-selector"
+  },
+  "trigger" : {
+"url-filter" : ".*"
+  }
+},{
+  "action" : {
+"type" : "css-display-none",
+"selector" : ".body{"
+  },
+  "trigger" : {
+"url-filter" : ".*"
+  }
+},{
+  "action":{
+	 "type":"css-display-none",
+	 "selector":"body{background-image: url(http://127.0.0.1:8000/resources/square100.png)}"
+  },
+  "trigger":{
+	 "url-filter":"html"
+  }
+},{
+  "action" : {
+"type" : "css-display-none",
+"selector" : ".non-universal-valid-selector"
+  },
+  "trigger" : {
+"url-filter" : "invalid-selector\\.html"
+  }
+}]


Modified: branches/safari-601-branch/Source/WebCore/ChangeLog (190773 => 190774)

--- branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-09 02:29:36 UTC (rev 190773)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-09 02:37:29 UTC (rev 190774)
@@ -1,5 +1,26 @@
 2015-10-08  Lucas Forschler  
 
+Merge r190602. rdar://problem/22995830
+
+2015-10-05  Alex Christensen  
+
+Invalid CSS Selector for Content Blockers invalidates others
+https://bugs.webkit.org/show_bug.cgi?id=148446
+rdar://problem/22918235
+
+Reviewed by Benjamin Poulain.
+
+Test: http/tests/contentextensions/invalid-selector.html
+
+* contentextensions/ContentExtensionParser.cpp:
+(WebCore::ContentExtensions::loadTrigger):
+(Web

[webkit-changes] [190772] branches/safari-601-branch/Tools

2015-10-08 Thread lforschler

Title: [190772] branches/safari-601-branch/Tools








Revision 190772
Author lforsch...@apple.com
Date 2015-10-08 19:26:04 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r190358.  rdar://problem/23016109

Modified Paths

branches/safari-601-branch/Tools/ChangeLog
branches/safari-601-branch/Tools/WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj


Added Paths

branches/safari-601-branch/Tools/WebKitLauncher/WebKitLauncher.entitlements




Diff

Modified: branches/safari-601-branch/Tools/ChangeLog (190771 => 190772)

--- branches/safari-601-branch/Tools/ChangeLog	2015-10-09 02:18:18 UTC (rev 190771)
+++ branches/safari-601-branch/Tools/ChangeLog	2015-10-09 02:26:04 UTC (rev 190772)
@@ -1,3 +1,17 @@
+2015-10-08  Lucas Forschler  
+
+Merge r190358. rdar://problem/23016109
+
+2015-09-30  Timothy Hatcher  
+
+Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
+https://bugs.webkit.org/show_bug.cgi?id=149674
+
+Reviewed by Lucas Forschler.
+
+* WebKitLauncher/WebKitLauncher.entitlements: Added.
+* WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
+
 2015-10-08  Andy Estes  
 
 Merge r188150, r188517, r188844, r188845, r188851, r188852, r10, r11, r188988, r189193, r189289, and r190133.


Copied: branches/safari-601-branch/Tools/WebKitLauncher/WebKitLauncher.entitlements (from rev 190358, trunk/Tools/WebKitLauncher/WebKitLauncher.entitlements) (0 => 190772)

--- branches/safari-601-branch/Tools/WebKitLauncher/WebKitLauncher.entitlements	(rev 0)
+++ branches/safari-601-branch/Tools/WebKitLauncher/WebKitLauncher.entitlements	2015-10-09 02:26:04 UTC (rev 190772)
@@ -0,0 +1,8 @@
+
+
+
+
+	com.apple.security.get-task-allow
+	
+
+


Modified: branches/safari-601-branch/Tools/WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj (190771 => 190772)

--- branches/safari-601-branch/Tools/WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj	2015-10-09 02:18:18 UTC (rev 190771)
+++ branches/safari-601-branch/Tools/WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj	2015-10-09 02:26:04 UTC (rev 190772)
@@ -64,6 +64,7 @@
 
 /* Begin PBXFileReference section */
 		1058C7A1FEA54F0111CA2CBB /* Cocoa.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Cocoa.framework; path = /System/Library/Frameworks/Cocoa.framework; sourceTree = ""; };
+		1C48994E1BBC547D00213C1C /* WebKitLauncher.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = WebKitLauncher.entitlements; sourceTree = SOURCE_ROOT; };
 		29B97316FDCFA39411CA2CEA /* main.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = main.m; sourceTree = ""; };
 		5D1067620FE63758002A2868 /* WebKitLauncherURLProtocol.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebKitLauncherURLProtocol.h; sourceTree = ""; };
 		5D1067630FE63758002A2868 /* WebKitLauncherURLProtocol.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = WebKitLauncherURLProtocol.m; sourceTree = ""; };
@@ -177,6 +178,7 @@
 5DA88F7E0FC8176100AB2F62 /* Base.xcconfig */,
 5DA88F7F0FC8176100AB2F62 /* WebKitLauncher.xcconfig */,
 5DA88F800FC8176100AB2F62 /* WebKitNightlyEnabler.xcconfig */,
+1C48994E1BBC547D00213C1C /* WebKitLauncher.entitlements */,
 			);
 			path = Configurations;
 			sourceTree = "";
@@ -384,6 +386,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 5DA88F7F0FC8176100AB2F62 /* WebKitLauncher.xcconfig */;
 			buildSettings = {
+CODE_SIGN_ENTITLEMENTS = WebKitLauncher.entitlements;
 			};
 			name = Debug;
 		};
@@ -391,6 +394,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 5DA88F7F0FC8176100AB2F62 /* WebKitLauncher.xcconfig */;
 			buildSettings = {
+CODE_SIGN_ENTITLEMENTS = WebKitLauncher.entitlements;
 			};
 			name = Release;
 		};






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190771] branches/safari-601-branch

2015-10-08 Thread lforschler

Title: [190771] branches/safari-601-branch








Revision 190771
Author lforsch...@apple.com
Date 2015-10-08 19:18:18 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r189976.  rdar://problem/22824652

Modified Paths

branches/safari-601-branch/LayoutTests/ChangeLog
branches/safari-601-branch/LayoutTests/platform/mac/TestExpectations
branches/safari-601-branch/Source/WebCore/ChangeLog




Diff

Modified: branches/safari-601-branch/LayoutTests/ChangeLog (190770 => 190771)

--- branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-09 02:16:27 UTC (rev 190770)
+++ branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-09 02:18:18 UTC (rev 190771)
@@ -15,6 +15,23 @@
 
 * platform/mac/TestExpectations:
 
+2015-10-08  Lucas Forschler  
+
+Merge r189976. rdar://problem/22824652
+
+2015-09-18  Chris Dumez  
+
+REGRESSION (r182449, Mavericks ONLY): Pages re-open empty after swiping back and scrolling on them
+https://bugs.webkit.org/show_bug.cgi?id=149317
+
+
+Reviewed by Tim Horton.
+
+Skip a couple of PageCache layout tests on Mavericks now that a PageCache
+optimization has been disabled.
+
+* platform/mac/TestExpectations:
+
 2015-10-08  Andy Estes  
 
 Merge r188150, r188517, r188844, r188845, r188851, r188852, r10, r11, r188988, r189193, r189289, and r190133.


Modified: branches/safari-601-branch/LayoutTests/platform/mac/TestExpectations (190770 => 190771)

--- branches/safari-601-branch/LayoutTests/platform/mac/TestExpectations	2015-10-09 02:16:27 UTC (rev 190770)
+++ branches/safari-601-branch/LayoutTests/platform/mac/TestExpectations	2015-10-09 02:18:18 UTC (rev 190771)
@@ -274,6 +274,11 @@
 [ Mavericks ] http/tests/navigation/page-cache-pending-image-load-cache-partition.html [ Skip ]
 [ Mavericks ] http/tests/navigation/page-cache-xhr.html [ Skip ]
 
+# This feature is disabled on Mavericks.
+[ Mavericks ] http/tests/navigation/page-cache-pending-image-load.html [ Skip ]
+[ Mavericks ] http/tests/navigation/page-cache-pending-image-load-cache-partition.html [ Skip ]
+[ Mavericks ] http/tests/navigation/page-cache-xhr.html [ Skip ]
+
 webkit.org/b/68278 http/tests/history/back-with-fragment-change.php [ Failure ]
 
 # Skip because this platform does not support a paging mouse wheel event


Modified: branches/safari-601-branch/Source/WebCore/ChangeLog (190770 => 190771)

--- branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-09 02:16:27 UTC (rev 190770)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-09 02:18:18 UTC (rev 190771)
@@ -18,6 +18,26 @@
 * loader/DocumentLoader.cpp:
 (WebCore::areAllLoadersPageCacheAcceptable):
 
+2015-10-08  Lucas Forschler  
+
+Merge r189976. rdar://problem/22824652
+
+2015-09-18  Chris Dumez  
+
+REGRESSION (r182449, Mavericks ONLY): Pages re-open empty after swiping back and scrolling on them
+https://bugs.webkit.org/show_bug.cgi?id=149317
+
+
+Reviewed by Tim Horton.
+
+Disable on Mavericks a PageCache optimization from r182449 which lets
+into PageCache pages that only have certain types of pending loads
+(images and XHR). This is because it has been determined via bisection
+that this change is the one that introduced the bug on Mavericks.
+
+* loader/DocumentLoader.cpp:
+(WebCore::areAllLoadersPageCacheAcceptable):
+
 2015-10-08  Andy Estes  
 
 Merge r188150, r188517, r188844, r188845, r188851, r188852, r10, r11, r188988, r189193, r189289, and r190133.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190770] branches/safari-601-branch

2015-10-08 Thread lforschler

Title: [190770] branches/safari-601-branch








Revision 190770
Author lforsch...@apple.com
Date 2015-10-08 19:16:27 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r189976.  rdar://problem/22824652

Modified Paths

branches/safari-601-branch/LayoutTests/ChangeLog
branches/safari-601-branch/LayoutTests/platform/mac/TestExpectations
branches/safari-601-branch/Source/WebCore/ChangeLog
branches/safari-601-branch/Source/WebCore/loader/DocumentLoader.cpp




Diff

Modified: branches/safari-601-branch/LayoutTests/ChangeLog (190769 => 190770)

--- branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-09 02:06:54 UTC (rev 190769)
+++ branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-09 02:16:27 UTC (rev 190770)
@@ -1,3 +1,20 @@
+2015-10-08  Lucas Forschler  
+
+Merge r189976. rdar://problem/22824652
+
+2015-09-18  Chris Dumez  
+
+REGRESSION (r182449, Mavericks ONLY): Pages re-open empty after swiping back and scrolling on them
+https://bugs.webkit.org/show_bug.cgi?id=149317
+
+
+Reviewed by Tim Horton.
+
+Skip a couple of PageCache layout tests on Mavericks now that a PageCache
+optimization has been disabled.
+
+* platform/mac/TestExpectations:
+
 2015-10-08  Andy Estes  
 
 Merge r188150, r188517, r188844, r188845, r188851, r188852, r10, r11, r188988, r189193, r189289, and r190133.


Modified: branches/safari-601-branch/LayoutTests/platform/mac/TestExpectations (190769 => 190770)

--- branches/safari-601-branch/LayoutTests/platform/mac/TestExpectations	2015-10-09 02:06:54 UTC (rev 190769)
+++ branches/safari-601-branch/LayoutTests/platform/mac/TestExpectations	2015-10-09 02:16:27 UTC (rev 190770)
@@ -269,6 +269,11 @@
 # Font feature settings is not implemented.
 css3/font-feature-settings-rendering.html
 
+# This feature is disabled on Mavericks.
+[ Mavericks ] http/tests/navigation/page-cache-pending-image-load.html [ Skip ]
+[ Mavericks ] http/tests/navigation/page-cache-pending-image-load-cache-partition.html [ Skip ]
+[ Mavericks ] http/tests/navigation/page-cache-xhr.html [ Skip ]
+
 webkit.org/b/68278 http/tests/history/back-with-fragment-change.php [ Failure ]
 
 # Skip because this platform does not support a paging mouse wheel event


Modified: branches/safari-601-branch/Source/WebCore/ChangeLog (190769 => 190770)

--- branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-09 02:06:54 UTC (rev 190769)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-09 02:16:27 UTC (rev 190770)
@@ -1,3 +1,23 @@
+2015-10-08  Lucas Forschler  
+
+Merge r189976. rdar://problem/22824652
+
+2015-09-18  Chris Dumez  
+
+REGRESSION (r182449, Mavericks ONLY): Pages re-open empty after swiping back and scrolling on them
+https://bugs.webkit.org/show_bug.cgi?id=149317
+
+
+Reviewed by Tim Horton.
+
+Disable on Mavericks a PageCache optimization from r182449 which lets
+into PageCache pages that only have certain types of pending loads
+(images and XHR). This is because it has been determined via bisection
+that this change is the one that introduced the bug on Mavericks.
+
+* loader/DocumentLoader.cpp:
+(WebCore::areAllLoadersPageCacheAcceptable):
+
 2015-10-08  Andy Estes  
 
 Merge r188150, r188517, r188844, r188845, r188851, r188852, r10, r11, r188988, r189193, r189289, and r190133.


Modified: branches/safari-601-branch/Source/WebCore/loader/DocumentLoader.cpp (190769 => 190770)

--- branches/safari-601-branch/Source/WebCore/loader/DocumentLoader.cpp	2015-10-09 02:06:54 UTC (rev 190769)
+++ branches/safari-601-branch/Source/WebCore/loader/DocumentLoader.cpp	2015-10-09 02:16:27 UTC (rev 190770)
@@ -95,6 +95,7 @@
 loader->setDefersLoading(defers);
 }
 
+#if !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
 static bool areAllLoadersPageCacheAcceptable(const ResourceLoaderMap& loaders)
 {
 Vector> loadersCopy;
@@ -114,6 +115,7 @@
 }
 return true;
 }
+#endif
 
 DocumentLoader::DocumentLoader(const ResourceRequest& req, const SubstituteData& substituteData)
 : m_deferMainResourceDataLoad(true)
@@ -286,8 +288,11 @@
 // loading but there are subresource loads during cancellation. This must be done before the
 // frame->stopLoading() call, which may evict the CachedResources, which we rely on to check
 // the type of the resource loads.
+#if !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
+// Disabled on Mavericks because it seems to cause issues (rdar://problem/22521514).
 if (loading && m_committed && !mainResourceLoader() && !m_subresourceLoaders.isEmpty())
 m_subresourceLoadersArePageCacheAcceptable = areAllLoadersPageCacheAcceptable(m_subresourceLoaders);
+#endif
 
 if (m_committed) {
 // Attempt to stop the frame if the document loader is loading, or if it

[webkit-changes] [190768] branches/safari-601-branch/Source/WTF

2015-10-08 Thread lforschler

Title: [190768] branches/safari-601-branch/Source/WTF








Revision 190768
Author lforsch...@apple.com
Date 2015-10-08 18:56:22 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r189633.  rdar://problem/22824646

Modified Paths

branches/safari-601-branch/Source/WTF/ChangeLog
branches/safari-601-branch/Source/WTF/WTF.xcodeproj/project.pbxproj
branches/safari-601-branch/Source/WTF/wtf/OSRandomSource.cpp


Added Paths

branches/safari-601-branch/Source/WTF/wtf/spi/darwin/CommonCryptoSPI.h




Diff

Modified: branches/safari-601-branch/Source/WTF/ChangeLog (190767 => 190768)

--- branches/safari-601-branch/Source/WTF/ChangeLog	2015-10-09 01:50:16 UTC (rev 190767)
+++ branches/safari-601-branch/Source/WTF/ChangeLog	2015-10-09 01:56:22 UTC (rev 190768)
@@ -1,5 +1,27 @@
 2015-10-08  Lucas Forschler  
 
+Merge r189633. rdar://problem/22824646
+
+
+2015-09-11  Keith Miller  
+
+cryptographicallyRandomValuesFromOS should use CCRandomCopyBytes when available.
+https://bugs.webkit.org/show_bug.cgi?id=148439
+
+Reviewed by Alexey Proskuryakov.
+
+Recently, we switched to using arc4random_buf on Darwin but further research indicates that
+arc4random_buf has the same behavior we had before and thus we were just pushing the problem
+further down the stack. CCRandomCopyBytes, however, appears to be more advanced and has much
+better error handling than we had before.
+
+* WTF.xcodeproj/project.pbxproj:
+* wtf/OSRandomSource.cpp:
+(WTF::cryptographicallyRandomValuesFromOS):
+* wtf/spi/darwin/CommonCryptoSPI.h: Added.
+
+2015-10-08  Lucas Forschler  
+
 Merge r188489
 
 2015-08-14  Keith Miller  


Modified: branches/safari-601-branch/Source/WTF/WTF.xcodeproj/project.pbxproj (190767 => 190768)

--- branches/safari-601-branch/Source/WTF/WTF.xcodeproj/project.pbxproj	2015-10-09 01:50:16 UTC (rev 190767)
+++ branches/safari-601-branch/Source/WTF/WTF.xcodeproj/project.pbxproj	2015-10-09 01:56:22 UTC (rev 190768)
@@ -271,6 +271,7 @@
 		CD5497AD15857D0300B5BC30 /* MediaTime.h in Headers */ = {isa = PBXBuildFile; fileRef = CD5497AB15857D0300B5BC30 /* MediaTime.h */; };
 		CE46516E19DB1FB4003ECA05 /* NSMapTableSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE46516D19DB1FB4003ECA05 /* NSMapTableSPI.h */; };
 		CE73E02519DCB7AB00580D5C /* XPCSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE73E02419DCB7AB00580D5C /* XPCSPI.h */; };
+		DE5A09FC1BA36992003D4424 /* CommonCryptoSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = DE5A09FB1BA36992003D4424 /* CommonCryptoSPI.h */; };
 		E15556F518A0CC18006F48FB /* CryptographicUtilities.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E15556F318A0CC18006F48FB /* CryptographicUtilities.cpp */; };
 		E15556F618A0CC18006F48FB /* CryptographicUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = E15556F418A0CC18006F48FB /* CryptographicUtilities.h */; };
 		E4A0AD391A96245500536DF6 /* WorkQueue.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E4A0AD371A96245500536DF6 /* WorkQueue.cpp */; };
@@ -563,6 +564,7 @@
 		CD5497AB15857D0300B5BC30 /* MediaTime.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MediaTime.h; sourceTree = ""; };
 		CE46516D19DB1FB4003ECA05 /* NSMapTableSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NSMapTableSPI.h; sourceTree = ""; };
 		CE73E02419DCB7AB00580D5C /* XPCSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = XPCSPI.h; sourceTree = ""; };
+		DE5A09FB1BA36992003D4424 /* CommonCryptoSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CommonCryptoSPI.h; sourceTree = ""; };
 		E15556F318A0CC18006F48FB /* CryptographicUtilities.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CryptographicUtilities.cpp; sourceTree = ""; };
 		E15556F418A0CC18006F48FB /* CryptographicUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CryptographicUtilities.h; sourceTree = ""; };
 		E4A0AD371A96245500536DF6 /* WorkQueue.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WorkQueue.cpp; sourceTree = ""; };
@@ -1005,6 +1007,7 @@
 		CE73E02319DCB7AB00580D5C /* darwin */ = {
 			isa = PBXGroup;
 			children = (
+DE5A09FB1BA36992003D4424 /* CommonCryptoSPI.h */,
 CE73E02419DCB7AB00580D5C /* XPCSPI.h */,
 			);
 			path = darwin;
@@ -1171,6 +1174,7 @@
 A8A47426151A825B004123FF /* Spectrum.h in Headers */,
 A8A47428151A825B004123FF /* StackBounds.h in Headers */,
 FEDACD3E1630F83F00C69634 /* StackStats.h in Headers */,
+DE5A09FC1BA36992003D4424 /* CommonCryptoSPI.h in Headers */,
 A8A47429151A825B004123FF /* StaticConstructors.h in Headers */,
 A8A4742A151A825B00412

[webkit-changes] [190767] branches/safari-601-branch/Source/WTF

2015-10-08 Thread lforschler

Title: [190767] branches/safari-601-branch/Source/WTF








Revision 190767
Author lforsch...@apple.com
Date 2015-10-08 18:50:16 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r188489.  rdar://problem/22824646

Modified Paths

branches/safari-601-branch/Source/WTF/ChangeLog
branches/safari-601-branch/Source/WTF/wtf/OSRandomSource.cpp




Diff

Modified: branches/safari-601-branch/Source/WTF/ChangeLog (190766 => 190767)

--- branches/safari-601-branch/Source/WTF/ChangeLog	2015-10-09 01:33:05 UTC (rev 190766)
+++ branches/safari-601-branch/Source/WTF/ChangeLog	2015-10-09 01:50:16 UTC (rev 190767)
@@ -1,3 +1,20 @@
+2015-10-08  Lucas Forschler  
+
+Merge r188489
+
+2015-08-14  Keith Miller  
+
+cryptographicallyRandomValuesFromOS should use arc4random_buf on Darwin.
+https://bugs.webkit.org/show_bug.cgi?id=148038
+
+Reviewed by Geoffrey Garen.
+
+Currently, we open a file descriptor to /dev/urandom, which can sometimes
+fail to open. Using arc4random_buf instead should get around this issue.
+
+* wtf/OSRandomSource.cpp:
+(WTF::cryptographicallyRandomValuesFromOS):
+
 2015-07-23  Lucas Forschler  
 
 Merge r187129


Modified: branches/safari-601-branch/Source/WTF/wtf/OSRandomSource.cpp (190766 => 190767)

--- branches/safari-601-branch/Source/WTF/wtf/OSRandomSource.cpp	2015-10-09 01:33:05 UTC (rev 190766)
+++ branches/safari-601-branch/Source/WTF/wtf/OSRandomSource.cpp	2015-10-09 01:50:16 UTC (rev 190767)
@@ -29,7 +29,7 @@
 #include 
 #include 
 
-#if OS(UNIX)
+#if !OS(DARWIN) && OS(UNIX)
 #include 
 #include 
 #include 
@@ -42,6 +42,7 @@
 
 namespace WTF {
 
+#if !OS(DARWIN) && OS(UNIX)
 NEVER_INLINE NO_RETURN_DUE_TO_CRASH static void crashUnableToOpenURandom()
 {
 CRASH();
@@ -51,10 +52,13 @@
 {
 CRASH();
 }
+#endif
 
 void cryptographicallyRandomValuesFromOS(unsigned char* buffer, size_t length)
 {
-#if OS(UNIX)
+#if OS(DARWIN)
+return arc4random_buf(buffer, length);
+#elif OS(UNIX)
 int fd = open("/dev/urandom", O_RDONLY, 0);
 if (fd < 0)
 crashUnableToOpenURandom(); // We need /dev/urandom for this API to work...






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190765] branches/safari-601-branch/Source/JavaScriptCore

2015-10-08 Thread lforschler

Title: [190765] branches/safari-601-branch/Source/_javascript_Core








Revision 190765
Author lforsch...@apple.com
Date 2015-10-08 18:13:55 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r189454.  rdar://problem/22802036

Modified Paths

branches/safari-601-branch/Source/_javascript_Core/API/tests/testapi.c
branches/safari-601-branch/Source/_javascript_Core/ChangeLog
branches/safari-601-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
branches/safari-601-branch/Source/_javascript_Core/interpreter/CallFrame.h
branches/safari-601-branch/Source/_javascript_Core/interpreter/Interpreter.cpp
branches/safari-601-branch/Source/_javascript_Core/interpreter/Interpreter.h
branches/safari-601-branch/Source/_javascript_Core/jit/CCallHelpers.h
branches/safari-601-branch/Source/_javascript_Core/jit/JITExceptions.cpp
branches/safari-601-branch/Source/_javascript_Core/jit/JITExceptions.h
branches/safari-601-branch/Source/_javascript_Core/jit/JITOpcodes.cpp
branches/safari-601-branch/Source/_javascript_Core/jit/JITOpcodes32_64.cpp
branches/safari-601-branch/Source/_javascript_Core/jit/JITOperations.cpp
branches/safari-601-branch/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
branches/safari-601-branch/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
branches/safari-601-branch/Source/_javascript_Core/runtime/VM.h


Added Paths

branches/safari-601-branch/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.cpp
branches/safari-601-branch/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.h




Diff

Copied: branches/safari-601-branch/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.cpp (from rev 189454, trunk/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.cpp) (0 => 190765)

--- branches/safari-601-branch/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.cpp	(rev 0)
+++ branches/safari-601-branch/Source/_javascript_Core/API/tests/PingPongStackOverflowTest.cpp	2015-10-09 01:13:55 UTC (rev 190765)
@@ -0,0 +1,182 @@
+/*
+ * Copyright (C) 2015 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "PingPongStackOverflowTest.h"
+
+#include "InitializeThreading.h"
+#include "JSContextRefPrivate.h"
+#include "_javascript_Core.h"
+#include "Options.h"
+#include 
+
+using JSC::Options;
+
+static JSGlobalContextRef context = nullptr;
+static int nativeRecursionCount = 0;
+
+static bool PingPongStackOverflowObject_hasInstance(JSContextRef context, JSObjectRef constructor, JSValueRef possibleValue, JSValueRef* exception)
+{
+UNUSED_PARAM(context);
+UNUSED_PARAM(constructor);
+
+JSStringRef hasInstanceName = JSStringCreateWithUTF8CString("hasInstance");
+JSValueRef hasInstance = JSObjectGetProperty(context, constructor, hasInstanceName, exception);
+JSStringRelease(hasInstanceName);
+if (!hasInstance)
+return false;
+
+int countAtEntry = nativeRecursionCount++;
+
+JSValueRef result = 0;
+if (nativeRecursionCount < 100) {
+JSObjectRef function = JSValueToObject(context, hasInstance, exception);
+result = JSObjectCallAsFunction(context, function, constructor, 1, &possibleValue, exception);
+} else {
+StringBuilder builder;
+builder.append("dummy.valueOf([0]");
+for (int i = 1; i < 35000; i++) {
+builder.append(", [");
+builder.appendNumber(i);
+builder.append("]");
+}
+builder.append(");");
+
+JSStringRef script = JSStringCreateWithUTF8CString(builder.toString().utf8().data());
+result = JSEvaluateScript(context, script, NULL, NULL, 1, exception);
+JSString

[webkit-changes] [190758] branches/safari-601-branch

2015-10-08 Thread lforschler

Title: [190758] branches/safari-601-branch








Revision 190758
Author lforsch...@apple.com
Date 2015-10-08 16:30:24 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r188148.  rdar://problem/22802049

Modified Paths

branches/safari-601-branch/LayoutTests/ChangeLog
branches/safari-601-branch/Source/WebCore/ChangeLog
branches/safari-601-branch/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp


Added Paths

branches/safari-601-branch/LayoutTests/fast/canvas/gradient-text-with-shadow-expected.txt
branches/safari-601-branch/LayoutTests/fast/canvas/gradient-text-with-shadow.html




Diff

Modified: branches/safari-601-branch/LayoutTests/ChangeLog (190757 => 190758)

--- branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-08 23:19:27 UTC (rev 190757)
+++ branches/safari-601-branch/LayoutTests/ChangeLog	2015-10-08 23:30:24 UTC (rev 190758)
@@ -1,3 +1,23 @@
+2015-10-08  Lucas Forschler  
+
+Merge r188148. rdar://problem/22802036
+
+2015-08-06  Dean Jackson  
+
+Shadows don't draw on fillText when using a gradient fill
+https://bugs.webkit.org/show_bug.cgi?id=147758
+
+
+Reviewed by Myles Maxfield.
+
+New test that exercises shadows on gradient fills. This really
+should be a ref test, but there is a very small rendering difference
+caused by masking, so instead it uses JS to look for pixels of
+the correct color.
+
+* fast/canvas/gradient-text-with-shadow-expected.txt: Added.
+* fast/canvas/gradient-text-with-shadow.html: Added.
+
 2015-10-06  Benjamin Poulain  
 
 We can't use let in JS on the safari-601 branch


Copied: branches/safari-601-branch/LayoutTests/fast/canvas/gradient-text-with-shadow-expected.txt (from rev 188148, trunk/LayoutTests/fast/canvas/gradient-text-with-shadow-expected.txt) (0 => 190758)

--- branches/safari-601-branch/LayoutTests/fast/canvas/gradient-text-with-shadow-expected.txt	(rev 0)
+++ branches/safari-601-branch/LayoutTests/fast/canvas/gradient-text-with-shadow-expected.txt	2015-10-08 23:30:24 UTC (rev 190758)
@@ -0,0 +1 @@
+PASSED


Copied: branches/safari-601-branch/LayoutTests/fast/canvas/gradient-text-with-shadow.html (from rev 188148, trunk/LayoutTests/fast/canvas/gradient-text-with-shadow.html) (0 => 190758)

--- branches/safari-601-branch/LayoutTests/fast/canvas/gradient-text-with-shadow.html	(rev 0)
+++ branches/safari-601-branch/LayoutTests/fast/canvas/gradient-text-with-shadow.html	2015-10-08 23:30:24 UTC (rev 190758)
@@ -0,0 +1,43 @@
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function runTest() {
+
+var canvas = document.querySelector("canvas");
+var context = canvas.getContext('2d');
+
+context.shadowOffsetX = 0;
+context.shadowOffsetY = 10;
+context.shadowBlur = 0;
+context.shadowColor = "rgb(255, 0, 0)";
+
+context.font = "80px sans-serif";
+
+var gradient = context.createLinearGradient(0, 0, 0, 100);
+gradient.addColorStop(0, "blue");
+gradient.addColorStop(1, "blue");
+
+context.fillStyle = gradient;
+context.fillText("hello", 10, 95);
+
+// If we correctly drew the shadow, there will be some
+// red pixels along the bottom line of the canvas.
+
+var buffer = context.getImageData(0, canvas.height - 1, canvas.width, 1);
+var passed = false;
+for (var i = 0; i < canvas.width; ++i) {
+if (buffer.data[i * 4] > 0) {
+passed = true;
+break;
+}
+}
+document.querySelector("p").textContent = passed ? "PASSED" : "FAILED";
+}
+
+window.addEventListener("load", runTest, false);
+
+
+
+
\ No newline at end of file


Modified: branches/safari-601-branch/Source/WebCore/ChangeLog (190757 => 190758)

--- branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-08 23:19:27 UTC (rev 190757)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-08 23:30:24 UTC (rev 190758)
@@ -1,5 +1,30 @@
 2015-10-08  Lucas Forschler  
 
+Merge r188148. rdar://problem/22802036
+
+2015-08-06  Dean Jackson  
+
+Shadows don't draw on fillText when using a gradient fill
+https://bugs.webkit.org/show_bug.cgi?id=147758
+
+
+Reviewed by Myles Maxfield.
+
+Since we use a mask to render a pattern or gradient
+into text, any shadow was being clipped out. Change
+this to draw the shadow before the mask + fill operation,
+using a technique similar to text-shadow.
+
+Test: fast/canvas/gradient-text-with-shadow.html
+
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::CanvasRenderingContext2D::drawTextInternal): Get the current shadow
+style, paint the text with a transformed shadow offset so that we only
+see the shadow and not the text, then combine with the existing pattern/gradient
+fill.
+
+

[webkit-changes] [190751] branches/safari-601-branch/Source/WebInspectorUI

2015-10-08 Thread lforschler

Title: [190751] branches/safari-601-branch/Source/WebInspectorUI








Revision 190751
Author lforsch...@apple.com
Date 2015-10-08 15:25:49 -0700 (Thu, 08 Oct 2015)


Log Message
Merge r189011. rdar://problem/22801999

2015-08-26  Nikita Vasilyev  

Web Inspector: [Regression] [Mavericks]: Undocked Web Inspector toolbar is two different colors and has extra space
https://bugs.webkit.org/show_bug.cgi?id=148510

Make body element transparent and remove extra padding above the toolbar only for OS X Mavericks.

Reviewed by Timothy Hatcher.

* UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
* UserInterface/Views/Main.css:
(body:not(.mavericks)):
(body): Deleted.
* UserInterface/Views/Toolbar.css:
(body:not(.mavericks) .toolbar):
(body.window-inactive:not(.mavericks) .toolbar):
(body.mac-platform:not(.docked, .mavericks) .toolbar):
(.toolbar): Deleted.
(body.window-inactive .toolbar): Deleted.
(body.mac-platform:not(.docked) .toolbar): Deleted.

Modified Paths

branches/safari-601-branch/Source/WebInspectorUI/ChangeLog
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Main.js
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Main.css
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css




Diff

Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (190750 => 190751)

--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-08 22:19:22 UTC (rev 190750)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-08 22:25:49 UTC (rev 190751)
@@ -1,5 +1,31 @@
 2015-10-08  Lucas Forschler  
 
+Merge r189011. rdar://problem/22801999
+
+2015-08-26  Nikita Vasilyev  
+
+Web Inspector: [Regression] [Mavericks]: Undocked Web Inspector toolbar is two different colors and has extra space
+https://bugs.webkit.org/show_bug.cgi?id=148510
+
+Make body element transparent and remove extra padding above the toolbar only for OS X Mavericks.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Base/Main.js:
+(WebInspector.contentLoaded):
+* UserInterface/Views/Main.css:
+(body:not(.mavericks)):
+(body): Deleted.
+* UserInterface/Views/Toolbar.css:
+(body:not(.mavericks) .toolbar):
+(body.window-inactive:not(.mavericks) .toolbar):
+(body.mac-platform:not(.docked, .mavericks) .toolbar):
+(.toolbar): Deleted.
+(body.window-inactive .toolbar): Deleted.
+(body.mac-platform:not(.docked) .toolbar): Deleted.
+
+2015-10-08  Lucas Forschler  
+
 Merge r188173. rdar://problem/22801999
 
 2015-08-07  Nikita Vasilyev  


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Main.js (190750 => 190751)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-10-08 22:19:22 UTC (rev 190750)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-10-08 22:25:49 UTC (rev 190751)
@@ -192,6 +192,8 @@
 document.body.classList.add("nightly-build");
 
 if (WebInspector.Platform.name === "mac") {
+document.body.classList.add(WebInspector.Platform.version.name);
+
 if (WebInspector.Platform.version.release >= 11)
 document.body.classList.add("latest-mac");
 else


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Main.css (190750 => 190751)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Main.css	2015-10-08 22:19:22 UTC (rev 190750)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Main.css	2015-10-08 22:25:49 UTC (rev 190751)
@@ -34,8 +34,6 @@
 font-family: -webkit-system-font, sans-serif;
 font-size: 11px;
 
-background-color: white;
-
 position: absolute;
 top: 0;
 left: 0;
@@ -57,6 +55,10 @@
 tab-size: 4; /* FIXME: This should be controlled by a setting.  */
 }
 
+body:not(.mavericks) {
+background-color: white;
+}
+
 body.docked.bottom {
 border-top: 1px solid rgb(200, 200, 200);
 }


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (190750 => 190751)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-10-08 22:19:22 UTC (rev 190750)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-10-08 22:25:49 UTC (rev 190751)
@@ -29,9 +29,6 @@
 white-space: nowrap;
 overflow: hidden;
 
-background-image: linear-gradient(to bottom, rgb(237, 237, 237), rgb(222, 222, 222));
-box-shadow: inset rgba(255, 255, 255, 0.5) 0 1px 1px;
-
 outline: none;
 
 padding-top: 3px;
@@ -39,12 +36,17 @@
 height: 36px;
 }
 
-body.window-inactive .toolbar {
+body:not(.mavericks) .toolbar {
+background-im

[webkit-changes] [190750] branches/safari-601-branch/Source/WebInspectorUI

2015-10-08 Thread lforschler

Title: [190750] branches/safari-601-branch/Source/WebInspectorUI








Revision 190750
Author lforsch...@apple.com
Date 2015-10-08 15:19:22 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r188173.  rdar://problem/22801999

Modified Paths

branches/safari-601-branch/Source/WebInspectorUI/ChangeLog
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Main.js
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css




Diff

Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (190749 => 190750)

--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-08 22:18:49 UTC (rev 190749)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-08 22:19:22 UTC (rev 190750)
@@ -1,5 +1,44 @@
 2015-10-08  Lucas Forschler  
 
+Merge r188173. rdar://problem/22801999
+
+2015-08-07  Nikita Vasilyev  
+
+Web Inspector: Simplify OS-specific CSS class names
+https://bugs.webkit.org/show_bug.cgi?id=147794
+
+Replace "body:not(.el-capitan)" with ".legacy-mac".
+Replace "body.el-capitan" with ".latest-mac".
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Base/Main.js:
+(WebInspector.contentLoaded):
+* UserInterface/Views/Toolbar.css:
+(body.legacy-mac .toolbar .dashboard-container):
+(body.legacy-mac .toolbar .search-bar > input[type="search"]):
+(body.legacy-mac .toolbar .search-bar > input[type="search"]:focus):
+(body.legacy-mac .toolbar .item.button:active):
+(body.window-inactive.legacy-mac .toolbar .dashboard-container):
+(body.latest-mac .toolbar .dashboard-container):
+(body.latest-mac .toolbar .search-bar > input[type="search"]):
+(body.latest-mac .toolbar .search-bar > input[type="search"]:focus):
+(@media (-webkit-min-device-pixel-ratio: 2)):
+(body.latest-mac .toolbar .item.button:active):
+(body.latest-mac.window-inactive .toolbar .dashboard-container):
+(body:not(.el-capitan) .toolbar .dashboard-container): Deleted.
+(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]): Deleted.
+(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]:focus): Deleted.
+(body:not(.el-capitan) .toolbar .item.button:active): Deleted.
+(body.window-inactive:not(.el-capitan) .toolbar .dashboard-container): Deleted.
+(body.el-capitan .toolbar .dashboard-container): Deleted.
+(body.el-capitan .toolbar .search-bar > input[type="search"]): Deleted.
+(body.el-capitan .toolbar .search-bar > input[type="search"]:focus): Deleted.
+(body.el-capitan .toolbar .item.button:active): Deleted.
+(body.el-capitan.window-inactive .toolbar .dashboard-container): Deleted.
+
+2015-10-08  Lucas Forschler  
+
 Merge r187715. rdar://problem/22801999
 
 2015-08-01  Nikita Vasilyev  


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Main.js (190749 => 190750)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-10-08 22:18:49 UTC (rev 190749)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Main.js	2015-10-08 22:19:22 UTC (rev 190750)
@@ -190,9 +190,14 @@
 document.body.classList.add(WebInspector.Platform.name + "-platform");
 if (WebInspector.Platform.isNightlyBuild)
 document.body.classList.add("nightly-build");
-if (WebInspector.Platform.version.name)
-document.body.classList.add(WebInspector.Platform.version.name);
 
+if (WebInspector.Platform.name === "mac") {
+if (WebInspector.Platform.version.release >= 11)
+document.body.classList.add("latest-mac");
+else
+document.body.classList.add("legacy-mac");
+}
+
 document.body.classList.add(this.debuggableType);
 
 // Create the user interface elements.


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (190749 => 190750)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-10-08 22:18:49 UTC (rev 190749)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-10-08 22:19:22 UTC (rev 190750)
@@ -114,9 +114,9 @@
 margin-left: 4px;
 }
 
-body:not(.el-capitan) .toolbar .item.button,
-body:not(.el-capitan) .toolbar .search-bar > input[type="search"],
-body:not(.el-capitan) .toolbar .dashboard-container {
+body.legacy-mac .toolbar .item.button,
+body.legacy-mac .toolbar .search-bar > input[type="search"],
+body.legacy-mac .toolbar .dashboard-container {
 background-color: hsl(0, 0%, 99%);
 border: 1px solid transparent;
 border-top-color: hsl(0, 0%, 100%);
@@ -124,31 +124,31 @@
 border-radius: 4px;
 }
 
-body:not(.el-capitan) .toolbar .search-bar

[webkit-changes] [190748] branches/safari-601-branch/Source/WebInspectorUI

2015-10-08 Thread lforschler

Title: [190748] branches/safari-601-branch/Source/WebInspectorUI








Revision 190748
Author lforsch...@apple.com
Date 2015-10-08 15:16:03 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r187715.  rdar://problem/22801999

Modified Paths

branches/safari-601-branch/Source/WebInspectorUI/ChangeLog
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Platform.js
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css




Diff

Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (190747 => 190748)

--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-08 22:08:08 UTC (rev 190747)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-08 22:16:03 UTC (rev 190748)
@@ -1,5 +1,42 @@
 2015-10-08  Lucas Forschler  
 
+Merge r187715. rdar://problem/22801999
+
+2015-08-01  Nikita Vasilyev  
+
+Web Inspector: Replace "unknown-mac" CSS class with "el-capitan"
+https://bugs.webkit.org/show_bug.cgi?id=147524
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Base/Platform.js:
+No need to repeat WebInspector.Platform.version.release for every possible case.
+
+* UserInterface/Views/Toolbar.css:
+(body:not(.el-capitan) .toolbar .dashboard-container):
+(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]):
+(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]:focus):
+(body:not(.el-capitan) .toolbar .item.button:active):
+(body.window-inactive:not(.el-capitan) .toolbar .dashboard-container):
+(body.el-capitan .toolbar .dashboard-container):
+(body.el-capitan .toolbar .search-bar > input[type="search"]):
+(body.el-capitan .toolbar .search-bar > input[type="search"]:focus):
+(@media (-webkit-min-device-pixel-ratio: 2)):
+(body.el-capitan .toolbar .item.button:active):
+(body.el-capitan.window-inactive .toolbar .dashboard-container):
+(body:not(.unknown-mac) .toolbar .dashboard-container): Deleted.
+(body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]): Deleted.
+(body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]:focus): Deleted.
+(body:not(.unknown-mac) .toolbar .item.button:active): Deleted.
+(body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container): Deleted.
+(body.unknown-mac .toolbar .dashboard-container): Deleted.
+(body.unknown-mac .toolbar .search-bar > input[type="search"]): Deleted.
+(body.unknown-mac .toolbar .search-bar > input[type="search"]:focus): Deleted.
+(body.unknown-mac .toolbar .item.button:active): Deleted.
+(body.unknown-mac.window-inactive .toolbar .dashboard-container): Deleted.
+
+2015-10-08  Lucas Forschler  
+
 Merge r188378. rdar://problem/22801980
 
 2015-08-12  Joseph Pecoraro  


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Platform.js (190747 => 190748)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Platform.js	2015-10-08 22:08:08 UTC (rev 190747)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Base/Platform.js	2015-10-08 22:16:03 UTC (rev 190748)
@@ -42,22 +42,22 @@
 var osVersionMatch = / Mac OS X (\d+)_(\d+)/.exec(navigator.appVersion);
 if (osVersionMatch && osVersionMatch[1] === "10") {
 WebInspector.Platform.version.base = 10;
+WebInspector.Platform.version.release = parseInt(osVersionMatch[2]);
 switch(osVersionMatch[2]) {
+case "11":
+WebInspector.Platform.version.name = "el-capitan";
+break;
 case "10":
 WebInspector.Platform.version.name = "yosemite";
-WebInspector.Platform.version.release = 10;
 break;
 case "9":
 WebInspector.Platform.version.name = "mavericks";
-WebInspector.Platform.version.release = 9;
 break;
 case "8":
 WebInspector.Platform.version.name = "mountain-lion";
-WebInspector.Platform.version.release = 8;
 break;
 default:
 WebInspector.Platform.version.name = "unknown-mac";
-WebInspector.Platform.version.release = parseInt(osVersionMatch[2]);
 break;
 }
 }


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (190747 => 190748)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-10-08 22:08:08 UTC (rev 190747)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-10-08 22:16:03 UTC (rev 190748)
@@ -114,9 +114,9 @@
 margin-left: 4px;
 }
 
-body:not(.un

[webkit-changes] [190747] branches/safari-601-branch/Source

2015-10-08 Thread lforschler

Title: [190747] branches/safari-601-branch/Source








Revision 190747
Author lforsch...@apple.com
Date 2015-10-08 15:08:08 -0700 (Thu, 08 Oct 2015)


Log Message
Rollout r190745.

Modified Paths

branches/safari-601-branch/Source/WebCore/ChangeLog
branches/safari-601-branch/Source/WebCore/platform/spi/mac/LookupSPI.h
branches/safari-601-branch/Source/WebKit/mac/ChangeLog
branches/safari-601-branch/Source/WebKit/mac/WebView/WebView.mm
branches/safari-601-branch/Source/WebKit2/ChangeLog
branches/safari-601-branch/Source/WebKit2/UIProcess/mac/PageClientImpl.mm
branches/safari-601-branch/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm




Diff

Modified: branches/safari-601-branch/Source/WebCore/ChangeLog (190746 => 190747)

--- branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-08 22:00:46 UTC (rev 190746)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-08 22:08:08 UTC (rev 190747)
@@ -1,5 +1,9 @@
 2015-10-08  Lucas Forschler  
 
+Rollout r190745
+
+2015-10-08  Lucas Forschler  
+
 Merge r188443. rdar://problem/22801969
 
 2015-08-13  Tim Horton  


Modified: branches/safari-601-branch/Source/WebCore/platform/spi/mac/LookupSPI.h (190746 => 190747)

--- branches/safari-601-branch/Source/WebCore/platform/spi/mac/LookupSPI.h	2015-10-08 22:00:46 UTC (rev 190746)
+++ branches/safari-601-branch/Source/WebCore/platform/spi/mac/LookupSPI.h	2015-10-08 22:08:08 UTC (rev 190747)
@@ -42,7 +42,6 @@
 
 + (NSRange)tokenRangeForString:(NSString *)string range:(NSRange)range options:(NSDictionary **)options;
 + (void)showDefinitionForTerm:(NSAttributedString *)term atLocation:(NSPoint)screenPoint options:(NSDictionary *)options;
-+ (void)showDefinitionForTerm:(NSAttributedString *)term relativeToRect:(NSRect)positioningRect ofView:(NSView *)positioningView options:(NSDictionary *)options;
 + (void)hideDefinition;
 
 @end
@@ -51,12 +50,10 @@
 
 #if  __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
 
-@interface LULookupDefinitionModule ()
+@interface LULookupDefinitionModule (AnimationController)
 
 + (id)lookupAnimationControllerForTerm:(NSAttributedString *)term atLocation:(NSPoint)screenPoint options:(NSDictionary *)options;
 
-+ (id)lookupAnimationControllerForTerm:(NSAttributedString *)term relativeToRect:(NSRect)positioningRect ofView:(NSView *)positioningView options:(NSDictionary *)options;
-
 @end
 
 #endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000


Modified: branches/safari-601-branch/Source/WebKit/mac/ChangeLog (190746 => 190747)

--- branches/safari-601-branch/Source/WebKit/mac/ChangeLog	2015-10-08 22:00:46 UTC (rev 190746)
+++ branches/safari-601-branch/Source/WebKit/mac/ChangeLog	2015-10-08 22:08:08 UTC (rev 190747)
@@ -1,5 +1,9 @@
 2015-10-08  Lucas Forschler  
 
+Rollout r190745
+
+2015-10-08  Lucas Forschler  
+
 Merge r188443. rdar://problem/22801969
 
 2015-08-13  Tim Horton  


Modified: branches/safari-601-branch/Source/WebKit/mac/WebView/WebView.mm (190746 => 190747)

--- branches/safari-601-branch/Source/WebKit/mac/WebView/WebView.mm	2015-10-08 22:00:46 UTC (rev 190746)
+++ branches/safari-601-branch/Source/WebKit/mac/WebView/WebView.mm	2015-10-08 22:08:08 UTC (rev 190747)
@@ -8561,7 +8561,12 @@
 if (!dictionaryPopupInfo.attributedString)
 return nil;
 
-if (canLoadLUTermOptionDisableSearchTermIndicator() && canLoadLUNotificationPopoverWillClose() && dictionaryPopupInfo.textIndicator) {
+NSPoint textBaselineOrigin = dictionaryPopupInfo.origin;
+
+// Convert to screen coordinates.
+textBaselineOrigin = [self.window convertRectToScreen:NSMakeRect(textBaselineOrigin.x, textBaselineOrigin.y, 0, 0)].origin;
+
+if (canLoadLUTermOptionDisableSearchTermIndicator() && canLoadLUNotificationPopoverWillClose()) {
 if (!_private->hasInitializedLookupObserver) {
 [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_dictionaryLookupPopoverWillClose:) name:getLUNotificationPopoverWillClose() object:nil];
 _private->hasInitializedLookupObserver = YES;
@@ -8572,17 +8577,9 @@
 mutableOptions = adoptNS([[NSMutableDictionary alloc] init]);
 [mutableOptions setObject:@YES forKey:getLUTermOptionDisableSearchTermIndicator()];
 [self _setTextIndicator:*dictionaryPopupInfo.textIndicator withLifetime:TextIndicatorLifetime::Permanent];
-
-if ([getLULookupDefinitionModuleClass() respondsToSelector:@selector(lookupAnimationControllerForTerm:relativeToRect:ofView:options:)]) {
-FloatRect firstTextRectInViewCoordinates = dictionaryPopupInfo.textIndicator->textRectsInBoundingRectCoordinates()[0];
-firstTextRectInViewCoordinates.moveBy(dictionaryPopupInfo.textIndicator->textBoundingRectInRootViewCoordinates().location());
-return [getLULookupDefinitionModuleClass() lookupAnimationControllerForTerm:dictionaryPopupInfo.attributedString.get() relativeToRect:[self _convertRectFromRootView:firstTextRectInViewCo

[webkit-changes] [190745] branches/safari-601-branch/Source

2015-10-08 Thread lforschler

Title: [190745] branches/safari-601-branch/Source








Revision 190745
Author lforsch...@apple.com
Date 2015-10-08 14:08:45 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r188443.  rdar://problem/22801969

Modified Paths

branches/safari-601-branch/Source/WebCore/ChangeLog
branches/safari-601-branch/Source/WebCore/platform/spi/mac/LookupSPI.h
branches/safari-601-branch/Source/WebKit/mac/ChangeLog
branches/safari-601-branch/Source/WebKit/mac/WebView/WebView.mm
branches/safari-601-branch/Source/WebKit2/ChangeLog
branches/safari-601-branch/Source/WebKit2/UIProcess/mac/PageClientImpl.mm
branches/safari-601-branch/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm




Diff

Modified: branches/safari-601-branch/Source/WebCore/ChangeLog (190744 => 190745)

--- branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-08 20:56:12 UTC (rev 190744)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2015-10-08 21:08:45 UTC (rev 190745)
@@ -1,3 +1,18 @@
+2015-10-08  Lucas Forschler  
+
+Merge r188443. rdar://problem/22801969
+
+2015-08-13  Tim Horton  
+
+Performing a Lookup on wrapped text puts the popover arrow in the wrong place (off to the right)
+https://bugs.webkit.org/show_bug.cgi?id=148012
+
+
+Reviewed by Simon Fraser.
+
+* platform/spi/mac/LookupSPI.h:
+Add some SPI.
+
 2015-10-02  Matthew Hanson  
 
 Merge r190380. rdar://problem/22888962


Modified: branches/safari-601-branch/Source/WebCore/platform/spi/mac/LookupSPI.h (190744 => 190745)

--- branches/safari-601-branch/Source/WebCore/platform/spi/mac/LookupSPI.h	2015-10-08 20:56:12 UTC (rev 190744)
+++ branches/safari-601-branch/Source/WebCore/platform/spi/mac/LookupSPI.h	2015-10-08 21:08:45 UTC (rev 190745)
@@ -42,6 +42,7 @@
 
 + (NSRange)tokenRangeForString:(NSString *)string range:(NSRange)range options:(NSDictionary **)options;
 + (void)showDefinitionForTerm:(NSAttributedString *)term atLocation:(NSPoint)screenPoint options:(NSDictionary *)options;
++ (void)showDefinitionForTerm:(NSAttributedString *)term relativeToRect:(NSRect)positioningRect ofView:(NSView *)positioningView options:(NSDictionary *)options;
 + (void)hideDefinition;
 
 @end
@@ -50,10 +51,12 @@
 
 #if  __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
 
-@interface LULookupDefinitionModule (AnimationController)
+@interface LULookupDefinitionModule ()
 
 + (id)lookupAnimationControllerForTerm:(NSAttributedString *)term atLocation:(NSPoint)screenPoint options:(NSDictionary *)options;
 
++ (id)lookupAnimationControllerForTerm:(NSAttributedString *)term relativeToRect:(NSRect)positioningRect ofView:(NSView *)positioningView options:(NSDictionary *)options;
+
 @end
 
 #endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000


Modified: branches/safari-601-branch/Source/WebKit/mac/ChangeLog (190744 => 190745)

--- branches/safari-601-branch/Source/WebKit/mac/ChangeLog	2015-10-08 20:56:12 UTC (rev 190744)
+++ branches/safari-601-branch/Source/WebKit/mac/ChangeLog	2015-10-08 21:08:45 UTC (rev 190745)
@@ -1,3 +1,22 @@
+2015-10-08  Lucas Forschler  
+
+Merge r188443. rdar://problem/22801969
+
+2015-08-13  Tim Horton  
+
+Performing a Lookup on wrapped text puts the popover arrow in the wrong place (off to the right)
+https://bugs.webkit.org/show_bug.cgi?id=148012
+
+
+Reviewed by Simon Fraser.
+
+* WebView/WebView.mm:
+(-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
+(-[WebView _showDictionaryLookupPopup:]):
+Adopt the new SPI, handing it the first text rect, instead of having it
+guess where to put the popover.
+Also, null-check the TextIndicator.
+
 2015-10-02  Matthew Hanson  
 
 Merge r189122. rdar://problem/22801996


Modified: branches/safari-601-branch/Source/WebKit/mac/WebView/WebView.mm (190744 => 190745)

--- branches/safari-601-branch/Source/WebKit/mac/WebView/WebView.mm	2015-10-08 20:56:12 UTC (rev 190744)
+++ branches/safari-601-branch/Source/WebKit/mac/WebView/WebView.mm	2015-10-08 21:08:45 UTC (rev 190745)
@@ -8561,12 +8561,7 @@
 if (!dictionaryPopupInfo.attributedString)
 return nil;
 
-NSPoint textBaselineOrigin = dictionaryPopupInfo.origin;
-
-// Convert to screen coordinates.
-textBaselineOrigin = [self.window convertRectToScreen:NSMakeRect(textBaselineOrigin.x, textBaselineOrigin.y, 0, 0)].origin;
-
-if (canLoadLUTermOptionDisableSearchTermIndicator() && canLoadLUNotificationPopoverWillClose()) {
+if (canLoadLUTermOptionDisableSearchTermIndicator() && canLoadLUNotificationPopoverWillClose() && dictionaryPopupInfo.textIndicator) {
 if (!_private->hasInitializedLookupObserver) {
 [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_dictionaryLookupPopoverWillClose:) name:getLUNotificationPopoverWillClose() object:nil];
 _private->hasInitializedLo

[webkit-changes] [190744] branches/safari-601-branch/Source/WebInspectorUI

2015-10-08 Thread lforschler

Title: [190744] branches/safari-601-branch/Source/WebInspectorUI








Revision 190744
Author lforsch...@apple.com
Date 2015-10-08 13:56:12 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r188378.  rdar://problem/22801980

Modified Paths

branches/safari-601-branch/Source/WebInspectorUI/ChangeLog
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Models/Script.js
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Models/SourceCode.js
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js




Diff

Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (190743 => 190744)

--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-08 20:53:27 UTC (rev 190743)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-08 20:56:12 UTC (rev 190744)
@@ -1,5 +1,29 @@
 2015-10-08  Lucas Forschler  
 
+Merge r188378. rdar://problem/22801980
+
+2015-08-12  Joseph Pecoraro  
+
+Web Inspector: Sometimes CSS resources don't update after editing via Styles panel
+https://bugs.webkit.org/show_bug.cgi?id=143244
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Models/SourceCode.js:
+(WebInspector.SourceCode.prototype._processContent):
+This code is brittle and we should move off of putting the
+possibly stale content in the Promise result.
+
+* UserInterface/Views/ResourceContentView.js:
+(WebInspector.ResourceContentView.prototype._contentAvailable):
+* UserInterface/Views/SourceCodeTextEditor.js:
+(WebInspector.SourceCodeTextEditor.prototype._contentAvailable):
+* UserInterface/Models/Script.js:
+(WebInspector.Script.prototype.requestScriptSyntaxTree):
+Use the current source code's content.
+
+2015-10-08  Lucas Forschler  
+
 Merge r187052. rdar://problem/22801992
 
 2015-07-20  Joseph Pecoraro  


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Models/Script.js (190743 => 190744)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Models/Script.js	2015-10-08 20:53:27 UTC (rev 190743)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Models/Script.js	2015-10-08 20:56:12 UTC (rev 190744)
@@ -149,7 +149,7 @@
 }
 
 this.requestContent().then(function(parameters) {
-makeSyntaxTreeAndCallCallback(parameters.content);
+makeSyntaxTreeAndCallCallback(parameters.sourceCode.content);
 }).catch(function(error) {
 makeSyntaxTreeAndCallCallback(null);
 });


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Models/SourceCode.js (190743 => 190744)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Models/SourceCode.js	2015-10-08 20:53:27 UTC (rev 190743)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Models/SourceCode.js	2015-10-08 20:56:12 UTC (rev 190744)
@@ -189,8 +189,12 @@
 
 this._ignoreRevisionContentDidChangeEvent = true;
 revision.content = content || null;
-delete this._ignoreRevisionContentDidChangeEvent;
+this._ignoreRevisionContentDidChangeEvent = false;
 
+// FIXME: Returning the content in this promise is misleading. It may not be current content
+// now, and it may become out-dated later on. We should drop content from this promise
+// and require clients to ask for the current contents from the sourceCode in the result.
+
 return Promise.resolve({
 error,
 sourceCode: this,


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js (190743 => 190744)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js	2015-10-08 20:53:27 UTC (rev 190743)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js	2015-10-08 20:56:12 UTC (rev 190744)
@@ -93,7 +93,8 @@
 
 // Content is ready to show, call the public method now.
 console.assert(!this._hasContent());
-this.contentAvailable(parameters.content, parameters.base64Encoded);
+console.assert(parameters.sourceCode === this._resource);
+this.contentAvailable(parameters.sourceCode.content, parameters.base64Encoded);
 },
 
 _contentError: function(error)


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (190743 => 190744)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js	2015-10-08 20:53:27 UTC (rev 190743)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js	2015-10-08 20:56:12 UTC (rev 190744)
@@ -451,7 +451,7 @@

[webkit-changes] [190742] branches/safari-601-branch/Source/WebInspectorUI

2015-10-08 Thread lforschler

Title: [190742] branches/safari-601-branch/Source/WebInspectorUI








Revision 190742
Author lforsch...@apple.com
Date 2015-10-08 13:53:07 -0700 (Thu, 08 Oct 2015)


Log Message
Merged r187052.  rdar://problem/22801992

Modified Paths

branches/safari-601-branch/Source/WebInspectorUI/ChangeLog
branches/safari-601-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js




Diff

Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (190741 => 190742)

--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-08 20:24:25 UTC (rev 190741)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-08 20:53:07 UTC (rev 190742)
@@ -1,3 +1,22 @@
+2015-10-08  Lucas Forschler  
+
+Merge r187052. rdar://problem/22801992
+
+2015-07-20  Joseph Pecoraro  
+
+Web Inspector: console.assert(false, "Message") message is not visible in console
+https://bugs.webkit.org/show_bug.cgi?id=147130
+
+Reviewed by Timothy Hatcher.
+
+* Localizations/en.lproj/localizedStrings.js:
+* UserInterface/Views/ConsoleMessageView.js:
+(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
+We were forgetting to assign the result of args.concat back into args.
+In re-addressing this, improve the formatting of output if there is
+a string message or not as the second argument to console.assert(), as
+that is the common usage.
+
 2015-10-02  Matthew Hanson  
 
 Merge r188748. rdar://problem/22802023


Modified: branches/safari-601-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (190741 => 190742)

--- branches/safari-601-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2015-10-08 20:24:25 UTC (rev 190741)
+++ branches/safari-601-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2015-10-08 20:53:07 UTC (rev 190742)
@@ -67,7 +67,7 @@
 localizedStrings["Application Cache"] = "Application Cache";
 localizedStrings["Assertion"] = "Assertion";
 localizedStrings["Assertion Failed"] = "Assertion Failed";
-localizedStrings["Assertion failed:"] = "Assertion failed:";
+localizedStrings["Assertion Failed: %s"] = "Assertion Failed: %s";
 localizedStrings["Assertion with message: %s"] = "Assertion with message: %s";
 localizedStrings["Assertive"] = "Assertive";
 localizedStrings["Attribute"] = "Attribute";


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js (190741 => 190742)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js	2015-10-08 20:24:25 UTC (rev 190741)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js	2015-10-08 20:53:07 UTC (rev 190742)
@@ -232,9 +232,13 @@
 break;
 
 case WebInspector.ConsoleMessage.MessageType.Assert:
-var args = [WebInspector.UIString("Assertion failed:")];
-if (this._message.parameters)
-args.concat(this._message.parameters);
+var args = [WebInspector.UIString("Assertion Failed")];
+if (this._message.parameters) {
+if (this._message.parameters[0].type === "string")
+args = [WebInspector.UIString("Assertion Failed: %s")].concat(this._message.parameters);
+else
+args = args.concat(this._message.parameters);
+}
 this._appendFormattedArguments(element, args);
 break;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

1 2 3 4 5 6 7 8 9 10 >

1 - 100 of 3898 matches

Mail list logo