from:"n_wang"

[webkit-changes] [234526] trunk

2018-08-02 Thread n_wang

Title: [234526] trunk








Revision 234526
Author n_w...@apple.com
Date 2018-08-02 16:54:45 -0700 (Thu, 02 Aug 2018)


Log Message
AX: [iOS] add support to return the attributed string under the element
https://bugs.webkit.org/show_bug.cgi?id=188276


Reviewed by Chris Fleizach.

Source/WebCore:

Provided a way on iOS to return the attributed string under the element for 
better performance.

Test: accessibility/ios-simulator/attributed-string-for-element.html

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _stringFromStartMarker:toEndMarker:attributed:]):
(-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):
(-[WebAccessibilityObjectWrapper attributedStringForElement]):

Tools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(attributedStringForElementCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::attributedStringForElement):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::attributedStringForElement):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::attributedStringForElement):

LayoutTests:

* accessibility/ios-simulator/attributed-string-for-element-expected.txt: Added.
* accessibility/ios-simulator/attributed-string-for-element.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp
trunk/Tools/DumpRenderTree/AccessibilityUIElement.h
trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm


Added Paths

trunk/LayoutTests/accessibility/ios-simulator/attributed-string-for-element-expected.txt
trunk/LayoutTests/accessibility/ios-simulator/attributed-string-for-element.html




Diff

Modified: trunk/LayoutTests/ChangeLog (234525 => 234526)

--- trunk/LayoutTests/ChangeLog	2018-08-02 23:48:16 UTC (rev 234525)
+++ trunk/LayoutTests/ChangeLog	2018-08-02 23:54:45 UTC (rev 234526)
@@ -1,3 +1,14 @@
+2018-08-02  Nan Wang  
+
+AX: [iOS] add support to return the attributed string under the element
+https://bugs.webkit.org/show_bug.cgi?id=188276
+
+
+Reviewed by Chris Fleizach.
+
+* accessibility/ios-simulator/attributed-string-for-element-expected.txt: Added.
+* accessibility/ios-simulator/attributed-string-for-element.html: Added.
+
 2018-08-02  Tim Horton  
 
 REGRESSION (r234488): Layout test fast/events/ios/keyboard-scrolling-repeat.html is timing out


Added: trunk/LayoutTests/accessibility/ios-simulator/attributed-string-for-element-expected.txt (0 => 234526)

--- trunk/LayoutTests/accessibility/ios-simulator/attributed-string-for-element-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/ios-simulator/attributed-string-for-element-expected.txt	2018-08-02 23:54:45 UTC (rev 234526)
@@ -0,0 +1,29 @@
+hello world test bold
+This test ensures that attributed string under the element works
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Attributed string: hello {
+UIAccessibilityTokenFontFamily = "Times New Roman";
+UIAccessibilityTokenFontName = "Times New Roman";
+UIAccessibilityTokenFontSize = 16;
+}world{
+UIAccessibilityTokenBold = 1;
+UIAccessibilityTokenFontFamily = "Times New Roman";
+UIAccessibilityTokenFontName = "Times New Roman Bold";
+UIAccessibilityTokenFontSize = 16;
+} test {
+UIAccessibilityTokenFontFamily = "Times New Roman";
+UIAccessibilityTokenFontName = "Times New Roman";
+UIAccessibilityTokenFontSize = 16;
+}bold{
+UIAccessibilityTokenBold = 1;
+UIAccessibilityTokenFontFamily = "Times New Roman";
+UIAccessibilityTokenFontName = "Times New Roman Bold";
+UIAccessibilityTokenFontSize = 16;
+}
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/ios-simulator/attributed-string-for-element.html (0 => 234526)

--- trunk/LayoutTests/accessibility/ios-simulator/attributed-string-for-element.html	(rev 0)
+++ trunk/LayoutTests/accessibility/ios-simulator/attributed-string-for-element.html	2018-08-02 23:54:45 UTC (rev 234526)
@@ -0,0 +1,29 @@
+
+
+
+
+
+hello world test bold
+
+
+
+
+
+
+description("This test ensures that attributed string under the element works");
+
+if

[webkit-changes] [234482] trunk

2018-08-01 Thread n_wang

Title: [234482] trunk








Revision 234482
Author n_w...@apple.com
Date 2018-08-01 15:07:42 -0700 (Wed, 01 Aug 2018)


Log Message
AX: AOM: Add ARIA IDL Attribute Reflection
https://bugs.webkit.org/show_bug.cgi?id=184676


Source/WebCore:

Reviewed by Chris Fleizach.

Test: accessibility/ARIA-reflection.html

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityRole.idl: Added.
* accessibility/AriaAttributes.idl: Added.
* dom/Element.idl:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setAriaReflectionEnabled):
(WebCore::RuntimeEnabledFeatures::ariaReflectionEnabled const):

Source/WebKit:

Added ARIA property string reflection on Element, behind
a new runtime flag. 
Spec: https://w3c.github.io/aria/#idl-interface

Reviewed by Chris Fleizach.

* Shared/WebPreferences.yaml:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAriaReflectionEnabled):
(WKPreferencesGetAriaReflectionEnabled):
* UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WebKitLegacy/mac:

Reviewed by Chris Fleizach.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences ariaReflectionEnabled]):
(-[WebPreferences setAriaReflectionEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Tools:

Reviewed by Chris Fleizach.

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

Reviewed by Chris Fleizach.

* accessibility/ARIA-reflection-expected.txt: Added.
* accessibility/ARIA-reflection.html: Added.
* js/dom/dom-static-property-for-in-iteration.html:
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration.html
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/Element.idl
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/WebKitTestRunner/TestController.cpp


Added Paths

trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt
trunk/LayoutTests/accessibility/ARIA-reflection.html
trunk/Source/WebCore/accessibility/AccessibilityRole.idl
trunk/Source/WebCore/accessibility/AriaAttributes.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (234481 => 234482)

--- trunk/LayoutTests/ChangeLog	2018-08-01 21:46:52 UTC (rev 234481)
+++ trunk/LayoutTests/ChangeLog	2018-08-01 22:07:42 UTC (rev 234482)
@@ -1,3 +1,16 @@
+2018-08-01  Nan Wang  
+
+AX: AOM: Add ARIA IDL Attribute Reflection
+https://bugs.webkit.org/show_bug.cgi?id=184676
+
+
+Reviewed by Chris Fleizach.
+
+* accessibility/ARIA-reflection-expected.txt: Added.
+* accessibility/ARIA-reflection.html: Added.
+* js/dom/dom-static-property-for-in-iteration.html:
+* platform/win/TestExpectations:
+
 2018-08-01  David Fenton  
 
 Layout Test editing/selection/update-selection-by-style-change.html is flaky.


Added: trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt (0 => 234482)

--- trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt	2018-08-01 22:07:42 UTC (rev 234482)
@@ -0,0 +1,388 @@
+This tests ARIA IDL Attribute Reflection.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+
+Test role < - > role
+PASS element[currentProperty] is null
+PASS element.getAttribute(currentAttribute) is null
+element["role"] = data;
+PASS element.getAttribute(currentAttribute) is data
+element.setAttribute("role", otherData);
+PASS element[currentProperty] is otherData
+
+Test ariaActiveDescendant < - > aria-activedescendant
+PASS element[currentProperty] is null
+PASS element.getAttribute(currentAttribute) is null
+element["ariaActiveDescendant"] = data;
+PASS element.getAttribute(currentAttribute) is data
+element.setAttribute("aria-activedescendant", otherData);
+PASS element[currentProperty] is otherData
+
+Test ariaAtomic < - > aria-atomic
+PASS element[currentProperty] is null
+PASS element.getAttribute(currentAttribute) is null
+element["ariaAtomic"] = data;

[webkit-changes] [234275] trunk

2018-07-26 Thread n_wang

Title: [234275] trunk








Revision 234275
Author n_w...@apple.com
Date 2018-07-26 14:34:27 -0700 (Thu, 26 Jul 2018)


Log Message
AX: nothing returned for various previous text marker APIs from one div/p node to another
https://bugs.webkit.org/show_bug.cgi?id=188071

Reviewed by Chris Fleizach.

Source/WebCore:

TextIterator is emitting an extra '\n' at the end of the  node and there's no
corresponding text node in the DOM tree, so we are not able to handle that for
text markers. Fixed it by ignoring the extra '\n' and anchor the text marker to
the previous child text node.

Test: accessibility/mac/text-marker-p-tags.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::traverseToOffsetInRange):

LayoutTests:

* accessibility/mac/text-marker-p-tags-expected.txt: Added.
* accessibility/mac/text-marker-p-tags.html: Added.
* accessibility/mac/text-marker-string-for-document-range-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/mac/text-marker-string-for-document-range-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp


Added Paths

trunk/LayoutTests/accessibility/mac/text-marker-p-tags-expected.txt
trunk/LayoutTests/accessibility/mac/text-marker-p-tags.html




Diff

Modified: trunk/LayoutTests/ChangeLog (234274 => 234275)

--- trunk/LayoutTests/ChangeLog	2018-07-26 21:32:00 UTC (rev 234274)
+++ trunk/LayoutTests/ChangeLog	2018-07-26 21:34:27 UTC (rev 234275)
@@ -1,3 +1,14 @@
+2018-07-26  Nan Wang  
+
+AX: nothing returned for various previous text marker APIs from one div/p node to another
+https://bugs.webkit.org/show_bug.cgi?id=188071
+
+Reviewed by Chris Fleizach.
+
+* accessibility/mac/text-marker-p-tags-expected.txt: Added.
+* accessibility/mac/text-marker-p-tags.html: Added.
+* accessibility/mac/text-marker-string-for-document-range-expected.txt:
+
 2018-07-26  David Fenton  
 
 Layout Test webgl/2.0.0/conformance2/glsl3/compound-assignment-type-combination.html is timing out on mac Debug


Added: trunk/LayoutTests/accessibility/mac/text-marker-p-tags-expected.txt (0 => 234275)

--- trunk/LayoutTests/accessibility/mac/text-marker-p-tags-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/text-marker-p-tags-expected.txt	2018-07-26 21:34:27 UTC (rev 234275)
@@ -0,0 +1,21 @@
+This tests that previous sentence/word/paragraph text marker calls work with p tag elements
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS selectedString is 'Where'
+Previous sentence: Test sentence two
+
+
+Previous word: two
+
+
+Previous paragraph: Test sentence one. Test sentence two
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+Test sentence one. Test sentence two
+
+Where


Added: trunk/LayoutTests/accessibility/mac/text-marker-p-tags.html (0 => 234275)

--- trunk/LayoutTests/accessibility/mac/text-marker-p-tags.html	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/text-marker-p-tags.html	2018-07-26 21:34:27 UTC (rev 234275)
@@ -0,0 +1,67 @@
+
+
+
+
+
+
+
+Test sentence one. Test sentence two
+
+
+Where
+
+
+