[webkit-changes] [147464] trunk/Source/WebCore
Title: [147464] trunk/Source/WebCore
Revision 147464
Author pe...@chromium.org
Date 2013-04-02 11:12:30 -0700 (Tue, 02 Apr 2013)
Log Message
[JSC] Don't create a JSValue if it's not going to be used for nullable attributes
https://bugs.webkit.org/show_bug.cgi?id=112711
Reviewed by Sam Weinig.
When nullable attributes are used, it's possible that we disregard the JSValue
when null should be returned instead. This is a waste, and we should cast the
native type to a JSValue as late as possible.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(NativeValueToLocal):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (147463 => 147464)
--- trunk/Source/WebCore/ChangeLog 2013-04-02 18:10:12 UTC (rev 147463)
+++ trunk/Source/WebCore/ChangeLog 2013-04-02 18:12:30 UTC (rev 147464)
@@ -1,3 +1,33 @@
+2013-04-02 Peter Beverloo pe...@chromium.org
+
+[JSC] Don't create a JSValue if it's not going to be used for nullable attributes
+https://bugs.webkit.org/show_bug.cgi?id=112711
+
+Reviewed by Sam Weinig.
+
+When nullable attributes are used, it's possible that we disregard the JSValue
+when null should be returned instead. This is a waste, and we should cast the
+native type to a JSValue as late as possible.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation):
+(NativeValueToLocal):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::jsTestObjAttrWithGetterException):
+(WebCore::jsTestObjStringAttrWithGetterException):
+(WebCore::jsTestObjWithScriptStateAttributeRaises):
+(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
+(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
+(WebCore::jsTestObjNullableDoubleAttribute):
+(WebCore::jsTestObjNullableLongAttribute):
+(WebCore::jsTestObjNullableBooleanAttribute):
+(WebCore::jsTestObjNullableStringAttribute):
+(WebCore::jsTestObjNullableLongSettableAttribute):
+(WebCore::jsTestObjNullableStringValue):
+* bindings/scripts/test/JS/JSTestTypedefs.cpp:
+(WebCore::jsTestTypedefsAttrWithGetterException):
+(WebCore::jsTestTypedefsStringAttrWithGetterException):
+
2013-04-02 Bem Jones-Bey bjone...@adobe.com
[css exclusions] overflow:hidden undoes shape-outside offsets
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (147463 => 147464)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-04-02 18:10:12 UTC (rev 147463)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-04-02 18:12:30 UTC (rev 147464)
@@ -1823,6 +1823,7 @@
my $name = $attribute-signature-name;
my $type = $attribute-signature-type;
my $isNullable = $attribute-signature-isNullable;
+my $isCachedAttribute = $attribute-signature-extendedAttributes-{CachedAttribute};
$codeGenerator-AssertNotSequenceType($type);
my $getFunctionName = GetAttributeGetterName($interfaceName, $className, $attribute);
my $implGetterFunctionName = $codeGenerator-WK_lcfirst($name);
@@ -1839,7 +1840,7 @@
push(@implContent, UNUSED_PARAM(slotBase);\n);
}
-if ($attribute-signature-extendedAttributes-{CachedAttribute}) {
+if ($isCachedAttribute) {
$needsMarkChildren = 1;
}
@@ -1888,7 +1889,7 @@
push(@implContent, bool isNull = false;\n) if $isNullable;
my $cacheIndex = 0;
-if ($attribute-signature-extendedAttributes-{CachedAttribute}) {
+if ($isCachedAttribute) {
$cacheIndex = $currentCachedAttribute;
$currentCachedAttribute++;
push(@implContent, if (J
[webkit-changes] [146084] trunk/Source/WebCore
Title: [146084] trunk/Source/WebCore
Revision 146084
Author pe...@chromium.org
Date 2013-03-18 10:49:52 -0700 (Mon, 18 Mar 2013)
Log Message
[Chromium] The select element on Android should also switch to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112559
Reviewed by Ojan Vafai.
Following r145959, also update themeChromiumAndroid.css to use the new
flexible box CSS properties. Covered by existing tests.
* css/themeChromiumAndroid.css:
(select[size][multiple]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/themeChromiumAndroid.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (146083 => 146084)
--- trunk/Source/WebCore/ChangeLog 2013-03-18 17:38:16 UTC (rev 146083)
+++ trunk/Source/WebCore/ChangeLog 2013-03-18 17:49:52 UTC (rev 146084)
@@ -1,3 +1,16 @@
+2013-03-18 Peter Beverloo pe...@chromium.org
+
+[Chromium] The select element on Android should also switch to new-flexbox
+https://bugs.webkit.org/show_bug.cgi?id=112559
+
+Reviewed by Ojan Vafai.
+
+Following r145959, also update themeChromiumAndroid.css to use the new
+flexible box CSS properties. Covered by existing tests.
+
+* css/themeChromiumAndroid.css:
+(select[size][multiple]):
+
2013-03-18 Renata Hodovan r...@webkit.org
Assertion faulire in SVGAnimatedPath.
Modified: trunk/Source/WebCore/css/themeChromiumAndroid.css (146083 => 146084)
--- trunk/Source/WebCore/css/themeChromiumAndroid.css 2013-03-18 17:38:16 UTC (rev 146083)
+++ trunk/Source/WebCore/css/themeChromiumAndroid.css 2013-03-18 17:49:52 UTC (rev 146084)
@@ -34,7 +34,7 @@
select[multiple],
select[size][multiple] {
-webkit-appearance: menulist;
--webkit-box-align: center;
+-webkit-align-items: center;
border: 1px solid;
border-radius: initial;
white-space: pre;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144643] trunk/Source/WebKit/chromium
Title: [144643] trunk/Source/WebKit/chromium
Revision 144643
Author pe...@chromium.org
Date 2013-03-04 10:34:15 -0800 (Mon, 04 Mar 2013)
Log Message
[Chromium] Add a new dependency on jsr-305 for Android
https://bugs.webkit.org/show_bug.cgi?id=111340
Unreviewed build fix; new Android dependency. This is
currently breaking gyp generation on the Android bots.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (144642 => 144643)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-03-04 18:23:18 UTC (rev 144642)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-04 18:34:15 UTC (rev 144643)
@@ -1,3 +1,13 @@
+2013-03-04 Peter Beverloo pe...@chromium.org
+
+[Chromium] Add a new dependency on jsr-305 for Android
+https://bugs.webkit.org/show_bug.cgi?id=111340
+
+Unreviewed build fix; new Android dependency. This is
+currently breaking gyp generation on the Android bots.
+
+* DEPS:
+
2013-03-04 Aaron Colwell acolw...@chromium.org
Remove unused return value from SourceBufferPrivate::abort() and WebSourceBuffer::abort().
Modified: trunk/Source/WebKit/chromium/DEPS (144642 => 144643)
--- trunk/Source/WebKit/chromium/DEPS 2013-03-04 18:23:18 UTC (rev 144642)
+++ trunk/Source/WebKit/chromium/DEPS 2013-03-04 18:34:15 UTC (rev 144643)
@@ -197,6 +197,8 @@
From('chromium_deps', 'src/third_party/android_tools'),
'third_party/freetype':
From('chromium_deps', 'src/third_party/freetype'),
+'third_party/jsr-305/src':
+ From('chromium_deps', 'src/third_party/jsr-305/src'),
'tools/android':
Var('chromium_svn') + '/tools/android@' + Var('chromium_rev'),
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144321] branches/chromium/1410/Source/WebKit/chromium
Title: [144321] branches/chromium/1410/Source/WebKit/chromium
Revision 144321
Author pe...@chromium.org
Date 2013-02-28 09:19:55 -0800 (Thu, 28 Feb 2013)
Log Message
Merge 143917
[Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=110481
Patch by Anton Vayvod avay...@chromium.org on 2013-02-25
Reviewed by Julien Chaffraix.
Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection until
we can implement it properly. Previous attempt is at http://trac.webkit.org/changeset/133465
See the discussion of the future implementation at http://crbug.com/156386
* features.gypi: Disable the flag for Android, enable it only for non-Android platforms.
* src/ChromeClientImpl.h: Declaration is now guarded by the flag, not to break Android.
TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/12382019
Modified Paths
branches/chromium/1410/Source/WebKit/chromium/features.gypi
branches/chromium/1410/Source/WebKit/chromium/src/ChromeClientImpl.h
Diff
Modified: branches/chromium/1410/Source/WebKit/chromium/features.gypi (144320 => 144321)
--- branches/chromium/1410/Source/WebKit/chromium/features.gypi 2013-02-28 17:16:56 UTC (rev 144320)
+++ branches/chromium/1410/Source/WebKit/chromium/features.gypi 2013-02-28 17:19:55 UTC (rev 144321)
@@ -94,7 +94,6 @@
'ENABLE_MHTML=1',
'ENABLE_MICRODATA=0',
'ENABLE_MOUSE_CURSOR_SCALE=1',
- 'ENABLE_NAVIGATOR_CONTENT_UTILS=1',
'ENABLE_NOSNIFF=1',
'ENABLE_PAGE_VISIBILITY_API=1',
'ENABLE_PERFORMANCE_TIMELINE=1',
@@ -175,7 +174,7 @@
'ENABLE_ORIENTATION_EVENTS=1',
'ENABLE_PAGE_POPUP=0',
'ENABLE_PRINTING=0',
- 'ENABLE_REGISTER_PROTOCOL_HANDLER=0',
+ 'ENABLE_NAVIGATOR_CONTENT_UTILS=0',
# FIXME: Disable once the linking error has been resolved.
# https://bugs.webkit.org/show_bug.cgi?id=88636
'ENABLE_SHARED_WORKERS=1',
@@ -193,6 +192,7 @@
'ENABLE_INPUT_MULTIPLE_FIELDS_UI=1',
'ENABLE_LEGACY_NOTIFICATIONS=1',
'ENABLE_MEDIA_CAPTURE=0',
+ 'ENABLE_NAVIGATOR_CONTENT_UTILS=1',
'ENABLE_NOTIFICATIONS=1',
'ENABLE_ORIENTATION_EVENTS=0',
'ENABLE_PAGE_POPUP=1',
Modified: branches/chromium/1410/Source/WebKit/chromium/src/ChromeClientImpl.h (144320 => 144321)
--- branches/chromium/1410/Source/WebKit/chromium/src/ChromeClientImpl.h 2013-02-28 17:16:56 UTC (rev 144320)
+++ branches/chromium/1410/Source/WebKit/chromium/src/ChromeClientImpl.h 2013-02-28 17:19:55 UTC (rev 144321)
@@ -256,6 +256,7 @@
#endif
};
+#if ENABLE(NAVIGATOR_CONTENT_UTILS)
class NavigatorContentUtilsClientImpl : public WebCore::NavigatorContentUtilsClient {
public:
static PassOwnPtrNavigatorContentUtilsClientImpl create(WebViewImpl*);
@@ -268,6 +269,7 @@
WebViewImpl* m_webView;
};
+#endif
} // namespace WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143928] branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.cpp
Title: [143928] branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.cpp
Revision 143928
Author pe...@chromium.org
Date 2013-02-25 08:46:59 -0800 (Mon, 25 Feb 2013)
Log Message
Merge 142534
[Text Autosizing] Collect narrow descendants and process them separately. Refactoring for
a change to follow.
https://bugs.webkit.org/show_bug.cgi?id=109054
Preparational change to combine narrow descendants of the same autosizing cluster into
groups by the width difference between the descendant and the block containing all text of
the parent autosizing cluster. The groups will be autosized with the same multiplier.
For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we eventually want to be able to merge them back
together into one (or a few) descendant clusters.
Patch by Anton Vayvod avay...@chromium.org on 2013-02-11
Reviewed by Julien Chaffraix.
No behavioral changes thus no new tests or test changes.
* rendering/TextAutosizer.cpp:
(TextAutosizingClusterInfo): Vector of narrow descendants.
(WebCore::TextAutosizer::processCluster): Process narrow descendants separately.
(WebCore::TextAutosizer::processContainer):
Remember narrow descendants of the parent cluster for later processing.
TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/12315083
Modified Paths
branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.cpp
Diff
Modified: branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.cpp (143927 => 143928)
--- branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.cpp 2013-02-25 16:09:49 UTC (rev 143927)
+++ branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.cpp 2013-02-25 16:46:59 UTC (rev 143928)
@@ -37,6 +37,7 @@
#include algorithm
#include wtf/StdLibExtras.h
+#include wtf/Vector.h
namespace WebCore {
@@ -47,6 +48,7 @@
IntSize minLayoutSize;
};
+// Represents cluster related data. Instances should not persist between calls to processSubtree.
struct TextAutosizingClusterInfo {
explicit TextAutosizingClusterInfo(RenderBlock* root)
: root(root)
@@ -61,6 +63,10 @@
// Upper limit on the difference between the width of the cluster's block containing all
// text and that of a narrow child before the child becomes a separate cluster.
float maxAllowedDifferenceFromTextWidth;
+
+// Descendants of the cluster that are narrower than the block containing all text and must be
+// processed together.
+VectorTextAutosizingClusterInfo narrowDescendants;
};
@@ -150,6 +156,12 @@
}
processContainer(multiplier, container, clusterInfo, subtreeRoot, windowInfo);
+
+VectorTextAutosizingClusterInfo narrowDescendants = clusterInfo.narrowDescendants;
+for (size_t i = 0; i narrowDescendants.size(); ++i) {
+TextAutosizingClusterInfo descendantClusterInfo = narrowDescendants[i];
+processCluster(descendantClusterInfo, descendantClusterInfo.root, descendantClusterInfo.root, windowInfo);
+}
}
void TextAutosizer::processContainer(float multiplier, RenderBlock* container, TextAutosizingClusterInfo clusterInfo, RenderObject* subtreeRoot, const TextAutosizingWindowInfo windowInfo)
@@ -168,9 +180,13 @@
// FIXME: Increase list marker size proportionately.
} else if (isAutosizingContainer(descendant)) {
RenderBlock* descendantBlock = toRenderBlock(descendant);
-if (isAutosizingCluster(descendantBlock, clusterInfo)) {
-TextAutosizingClusterInfo descendantClusterInfo(descendantBlock);
+TextAutosizingClusterInfo descendantClusterInfo(descendantBlock);
+if (isWiderDescendant(descendantBlock, clusterInfo) || isIndependentDescendant(descendantBlock))
processCluster(descendantClusterInfo, descendantBlock, descendantBlock, windowInfo);
+else if (isNarrowDescendant(descendantBlock, clusterInfo)) {
+// Narrow descendants are processed together later to be able to apply the same multiplier
+// to each of them if necessary.
+clusterInfo.narrowDescendants.append(descendantClusterInfo);
} else
processContainer(multiplier, descendantBlock, clusterInfo, descendantBlock, windowInfo);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143930] branches/chromium/1410
Title: [143930] branches/chromium/1410
Revision 143930
Author pe...@chromium.org
Date 2013-02-25 08:52:38 -0800 (Mon, 25 Feb 2013)
Log Message
Merge 142866
[Text Autosizing] Process narrow descendants with the same multiplier for the font size.
https://bugs.webkit.org/show_bug.cgi?id=109573
Source/WebCore:
Patch by Anton Vayvod avay...@chromium.org on 2013-02-14
Reviewed by Julien Chaffraix.
Combine narrow descendants of the same autosizing cluster into a group that is autosized
with the same multiplier.
For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we want them all to share the same multiplier, as
if they were a single cluster.
Test: fast/text-autosizing/narrow-descendants-combined.html
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processClusterInternal):
Common implementation for processCluster() and processCompositeCluster that accepts the
text width and whether the cluster should be autosized as parameters instead of
calculating it inline.
(WebCore::TextAutosizer::processCluster):
Calculates the text width for a single cluster and whether it should be autosized, then
calls processClusterInternal() to apply the multiplier and process the cluster's
descendants.
(WebCore::TextAutosizer::processCompositeCluster):
Calculates the text width for a group of renderers and if the group should be autosized,
then calls processClusterInternal() repeatedly with the same multiplier to apply it and
process all the descendants of the group.
(WebCore::TextAutosizer::clusterShouldBeAutosized):
Calls the multiple renderers version to avoid code duplication.
(WebCore::TextAutosizer::compositeClusterShouldBeAutosized):
The multiple renderers version of clusterShouldBeAutosized.
* rendering/TextAutosizer.h:
Updated method declarations.
LayoutTests:
Test to verify that all narrow descendants of a cluster are autosized with the same
multiplier.
Patch by Anton Vayvod avay...@chromium.org on 2013-02-14
Reviewed by Julien Chaffraix.
* fast/text-autosizing/narrow-descendants-combined-expected.html: Added.
* fast/text-autosizing/narrow-descendants-combined.html: Added.
TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/12326104
Modified Paths
branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.cpp
branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.h
Added Paths
branches/chromium/1410/LayoutTests/fast/text-autosizing/narrow-descendants-combined-expected.html
branches/chromium/1410/LayoutTests/fast/text-autosizing/narrow-descendants-combined.html
Diff
Copied: branches/chromium/1410/LayoutTests/fast/text-autosizing/narrow-descendants-combined-expected.html (from rev 142866, trunk/LayoutTests/fast/text-autosizing/narrow-descendants-combined-expected.html) (0 => 143930)
--- branches/chromium/1410/LayoutTests/fast/text-autosizing/narrow-descendants-combined-expected.html (rev 0)
+++ branches/chromium/1410/LayoutTests/fast/text-autosizing/narrow-descendants-combined-expected.html 2013-02-25 16:52:38 UTC (rev 143930)
@@ -0,0 +1,27 @@
+!DOCTYPE html
+html
+head
+
+meta name=viewport content=width=800
+style
+html { font-size: 16px; }
+body { width: 800px; margin: 0; overflow-y: hidden; }
+/style
+
+/head
+body
+
+div style=font-size: 1.25rem
+div style=width: 320px
+This text should be autosized to 20px computed font-size as it is combined with its narrow siblings and the maximum width is 400px.
+/div
+div style=width: 400px
+This text should be autosized to 20px computed font-size as it is combined with its narrow siblings and the maximum width is 400px.
+/div
+div style=width: 240px
+This text should be autosized to 20px computed font-size as it is combined with its narrow siblings and the maximum width is 400px.
+/div
+/div
+
+/body
+/html
Copied: branches/chromium/1410/LayoutTests/fast/text-autosizing/narrow-descendants-combined.html (from rev 142866, trunk/LayoutTests/fast/text-autosizing/narrow-descendants-combined.html) (0 => 143930)
--- branches/chromium/1410/LayoutTests/fast/text-autosizing/narrow-descendants-combined.html (rev 0)
+++ branches/chromium/1410/LayoutTests/fast/text-autosizing/narrow-descendants-combined.html 2013-02-25 16:52:38 UTC (rev 143930)
@@ -0,0 +1,36 @@
+!DOCTYPE html
+html
+head
+
+meta name=viewport content=width=800
+style
+html { font-size: 16px; }
+body { width: 800px; margin: 0; overflow-y: hidden; }
+/style
+
+script
+if (window.internals) {
+window.internals.settings.setTextAutosizingEnabled(true);
+
[webkit-changes] [143934] branches/chromium/1410
Title: [143934] branches/chromium/1410 Revision 143934 Author pe...@chromium.org Date 2013-02-25 09:05:25 -0800 (Mon, 25 Feb 2013) Log Message Merge 143356 Text Autosizing: prevent oscillation of font sizes during autosizing https://bugs.webkit.org/show_bug.cgi?id=108205 Patch by Tim Volodine timvolod...@chromium.org on 2013-02-19 Reviewed by Kenneth Rohde Christiansen. Source/WebCore: On some websites autosized font-sizes oscillate due to layouts caused by hovering or incremental page loading (and on other sites font sizes do eventually stabilize, but it takes many layouts before they reach a steady size). To prevent all these cases, we no longer allow the autosizing multiplier to change after it has been set (to a value other than 1). This won't always give exactly the same results, but testing on 2000 top sites shows that this makes little difference in practice, and it prevents these very jarring cases. As a happy side-effect, this speeds up layouts as font sizes change less. Test: fast/text-autosizing/oscillation-_javascript_-fontsize-change.html * page/FrameView.cpp: (WebCore::FrameView::setFrameRect): * page/Settings.cpp: (WebCore::Settings::setTextAutosizingFontScaleFactor): * rendering/TextAutosizer.cpp: (WebCore::TextAutosizer::recalculateMultipliers): (WebCore): (WebCore::TextAutosizer::processContainer): * rendering/TextAutosizer.h: (TextAutosizer): LayoutTests: Added overflow-y:hidden to some existing tests, since previously those tests would start off with incorrect multipliers (because mainFrame-view()-layoutSize() is initially 785 instead of 800 as ScrollView wrongly guesses a scrollbar will be needed), and then the multipliers would get corrected on a subsequent layout. Now that we don't allow the multiplier to change after being set, it needs to be right first time. Also added specific oscillation test triggered by _javascript_. * fast/text-autosizing/constrained-height-body-expected.html: * fast/text-autosizing/constrained-height-body.html: * fast/text-autosizing/constrained-then-float-ancestors-expected.html: * fast/text-autosizing/constrained-then-float-ancestors.html: * fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html: * fast/text-autosizing/constrained-then-position-fixed-ancestors.html: * fast/text-autosizing/nested-em-line-height-expected.html: * fast/text-autosizing/nested-em-line-height.html: * fast/text-autosizing/oscillation-_javascript_-fontsize-change-expected.html: Added. * fast/text-autosizing/oscillation-_javascript_-fontsize-change.html: Added. * fast/text-autosizing/simple-paragraph-expected.html: * fast/text-autosizing/simple-paragraph.html: * fast/text-autosizing/span-child-expected.html: * fast/text-autosizing/span-child.html: * fast/text-autosizing/unwrappable-blocks-expected.html: * fast/text-autosizing/unwrappable-blocks.html: * fast/text-autosizing/unwrappable-inlines-expected.html: * fast/text-autosizing/unwrappable-inlines.html: TBR=commit-qu...@webkit.org Review URL: https://codereview.chromium.org/12310107 Modified Paths branches/chromium/1410/LayoutTests/fast/text-autosizing/constrained-height-body-expected.html branches/chromium/1410/LayoutTests/fast/text-autosizing/constrained-height-body.html branches/chromium/1410/LayoutTests/fast/text-autosizing/constrained-then-float-ancestors-expected.html branches/chromium/1410/LayoutTests/fast/text-autosizing/constrained-then-float-ancestors.html branches/chromium/1410/LayoutTests/fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html branches/chromium/1410/LayoutTests/fast/text-autosizing/constrained-then-position-fixed-ancestors.html branches/chromium/1410/LayoutTests/fast/text-autosizing/nested-em-line-height-expected.html branches/chromium/1410/LayoutTests/fast/text-autosizing/nested-em-line-height.html branches/chromium/1410/LayoutTests/fast/text-autosizing/simple-paragraph-expected.html branches/chromium/1410/LayoutTests/fast/text-autosizing/simple-paragraph.html branches/chromium/1410/LayoutTests/fast/text-autosizing/span-child-expected.html branches/chromium/1410/LayoutTests/fast/text-autosizing/span-child.html branches/chromium/1410/LayoutTests/fast/text-autosizing/unwrappable-blocks-expected.html branches/chromium/1410/LayoutTests/fast/text-autosizing/unwrappable-blocks.html branches/chromium/1410/LayoutTests/fast/text-autosizing/unwrappable-inlines-expected.html branches/chromium/1410/LayoutTests/fast/text-autosizing/unwrappable-inlines.html branches/chromium/1410/Source/WebCore/page/FrameView.cpp branches/chromium/1410/Source/WebCore/page/Settings.cpp branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.cpp branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.h Added Paths branches/chromium/1410/LayoutTests/fast/text-autosizing/oscillation-_javascript_-fontsize-change-expected.html
[webkit-changes] [140432] branches/chromium/1364/Source/WebKit/chromium
Title: [140432] branches/chromium/1364/Source/WebKit/chromium Revision 140432 Author pe...@chromium.org Date 2013-01-22 09:24:01 -0800 (Tue, 22 Jan 2013) Log Message Merge 140035 As approved in http://crbug.com/167028 [chromium] Double-tap zoom should take into account accessibility fontScaleFactor https://bugs.webkit.org/show_bug.cgi?id=107123 Patch by John Mellor joh...@chromium.org on 2013-01-17 Reviewed by Adam Barth. Platforms which support Text Autosizing (currently just Chrome for Android) may provide a textAutosizingFontScaleFactor (defaults to 1.0). This value is intended to be chosen by the user to indicate how large they want text to appear, for example Chrome for Android has a Text scaling slider in Settings Accessibility that lets you choose a value in the range 50% - 200% (defaults to 100%*). For text in wide columns that typically gets autosized, this value is applied by multiplying the textAutosizingMultiplier computed for each cluster by the textAutosizingFontScaleFactor. Double-tap zoom will fit the column to the screen (ignoring the textAutosizingFontScaleFactor) since the column is wide. This part already works. For text in narrow columns that doesn't get autosized, the textAutosizingFontScaleFactor is not applied through Text Autosizing, and instead needs to be applied by adjusting the double-tap zoom level. When double-tapping on narrow columns, instead of fitting the column to the screen (which would often zoom in excessively far), the existing logic in computeScaleAndScrollForHitRect applies a maximum zoom level called the legibleScale. This value needs to be multiplied by the textAutosizingFontScaleFactor, so that we zoom in proportionately further on non-autosized narrow columns, hence the effective text size (taking into account zoom) will have increased in proportion to the textAutosizingFontScaleFactor as expected. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::computeScaleAndScrollForHitRect): Multiplies legibleScale (the maximum zoom level) by the textAutosizingFontScaleFactor. * tests/WebFrameTest.cpp: Added WebFrameTest.DivAutoZoomScaleFontScaleFactorTest based on WebFrameTest.DivAutoZoomScaleBoundsTest to test the interaction between textAutosizingFontScaleFactor and the double-tap zoom logic. Also did minor cleanup to WebFrameTest.DivAutoZoomScaleBoundsTest. TBR=commit-qu...@webkit.org Review URL: https://codereview.chromium.org/12045023 Modified Paths branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp branches/chromium/1364/Source/WebKit/chromium/tests/WebFrameTest.cpp Diff Modified: branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp (140431 => 140432) --- branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-01-22 17:17:13 UTC (rev 140431) +++ branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-01-22 17:24:01 UTC (rev 140432) @@ -1128,6 +1128,10 @@ // be allowed to manually pinch zoom in further if they desire. const float defaultScaleWhenAlreadyLegible = m_minimumPageScaleFactor * doubleTapZoomAlreadyLegibleRatio; float legibleScale = deviceScaleFactor(); +#if ENABLE(TEXT_AUTOSIZING) +if (page() page()-settings()) +legibleScale *= page()-settings()-textAutosizingFontScaleFactor(); +#endif if (legibleScale defaultScaleWhenAlreadyLegible) legibleScale = (scale == m_minimumPageScaleFactor) ? defaultScaleWhenAlreadyLegible : m_minimumPageScaleFactor; Modified: branches/chromium/1364/Source/WebKit/chromium/tests/WebFrameTest.cpp (140431 => 140432) --- branches/chromium/1364/Source/WebKit/chromium/tests/WebFrameTest.cpp 2013-01-22 17:17:13 UTC (rev 140431) +++ branches/chromium/1364/Source/WebKit/chromium/tests/WebFrameTest.cpp 2013-01-22 17:24:01 UTC (rev 140432) @@ -38,6 +38,7 @@ #include FrameView.h #include Range.h #include ResourceError.h +#include Settings.h #include URLTestHelpers.h #include WebDataSource.h #include WebDocument.h @@ -451,7 +452,6 @@ webView-resize(WebSize(viewportWidth, viewportHeight)); webView-setPageScaleFactorLimits(1, 4); webView-layout(); -webView-setDeviceScaleFactor(1.5f); WebViewImpl* webViewImpl = static_castWebViewImpl*(webView); webViewImpl-shouldUseAnimateDoubleTapTimeZeroForTesting(true); @@ -463,6 +463,7 @@ // Test double tap scale bounds. // minimumPageScale doubleTapZoomAlreadyLegibleScale deviceDpiScale +webViewImpl-setDeviceScaleFactor(1.5f); setScaleAndScrollAndLayout(webViewImpl, WebPoint(0, 0), (webViewImpl-minimumPageScaleFactor()) * (1 + doubleTapZoomAlreadyLegibleRatio) / 2); simulateDoubleTap(webViewImpl, doubleTapPoint, scale); EXPECT_FLOAT_EQ(webViewImpl-deviceScaleFactor(), scale); @@ -485,7 +486,7 @@ // Zoom in to reset double_tap_zoom_in_effect flag. webViewImpl-applyScrollAndScale(WebSize(), 1.1f); -//
[webkit-changes] [140151] branches/chromium/1364/Source/WebCore/css/themeChromiumAndroid.css
Title: [140151] branches/chromium/1364/Source/WebCore/css/themeChromiumAndroid.css Revision 140151 Author pe...@chromium.org Date 2013-01-18 08:05:01 -0800 (Fri, 18 Jan 2013) Log Message Merge 139087 [Chromium] Modify Android's user agent CSS to not set a border-radius on select elements https://bugs.webkit.org/show_bug.cgi?id=106327 Reviewed by Adam Barth. Android's user agent CSS overrides the style applied to select elements with a @size or @multiple attribute, and then applies (among other things) a border-radius of 5 pixels. While select elements with a larger size or multiple selection should appear as drop-down boxes for now, setting the border radius causes Chromium to skip rendering the background and border, making them hard to read when the page relies on the default styling. This is covered by existing pixel tests. * css/themeChromiumAndroid.css: (select[size][multiple]): TBR=pe...@chromium.org Review URL: https://codereview.chromium.org/12018018 Modified Paths branches/chromium/1364/Source/WebCore/css/themeChromiumAndroid.css Diff Modified: branches/chromium/1364/Source/WebCore/css/themeChromiumAndroid.css (140150 => 140151) --- branches/chromium/1364/Source/WebCore/css/themeChromiumAndroid.css 2013-01-18 15:59:16 UTC (rev 140150) +++ branches/chromium/1364/Source/WebCore/css/themeChromiumAndroid.css 2013-01-18 16:05:01 UTC (rev 140151) @@ -36,6 +36,6 @@ -webkit-appearance: menulist; -webkit-box-align: center; border: 1px solid; -border-radius: 5px; +border-radius: initial; white-space: pre; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [139087] trunk/Source/WebCore
Title: [139087] trunk/Source/WebCore Revision 139087 Author pe...@chromium.org Date 2013-01-08 11:28:34 -0800 (Tue, 08 Jan 2013) Log Message [Chromium] Modify Android's user agent CSS to not set a border-radius on select elements https://bugs.webkit.org/show_bug.cgi?id=106327 Reviewed by Adam Barth. Android's user agent CSS overrides the style applied to select elements with a @size or @multiple attribute, and then applies (among other things) a border-radius of 5 pixels. While select elements with a larger size or multiple selection should appear as drop-down boxes for now, setting the border radius causes Chromium to skip rendering the background and border, making them hard to read when the page relies on the default styling. This is covered by existing pixel tests. * css/themeChromiumAndroid.css: (select[size][multiple]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/themeChromiumAndroid.css Diff Modified: trunk/Source/WebCore/ChangeLog (139086 => 139087) --- trunk/Source/WebCore/ChangeLog 2013-01-08 19:27:30 UTC (rev 139086) +++ trunk/Source/WebCore/ChangeLog 2013-01-08 19:28:34 UTC (rev 139087) @@ -1,3 +1,23 @@ +2013-01-08 Peter Beverloo pe...@chromium.org + +[Chromium] Modify Android's user agent CSS to not set a border-radius on select elements +https://bugs.webkit.org/show_bug.cgi?id=106327 + +Reviewed by Adam Barth. + +Android's user agent CSS overrides the style applied to select +elements with a @size or @multiple attribute, and then applies +(among other things) a border-radius of 5 pixels. While select +elements with a larger size or multiple selection should appear +as drop-down boxes for now, setting the border radius causes +Chromium to skip rendering the background and border, making +them hard to read when the page relies on the default styling. + +This is covered by existing pixel tests. + +* css/themeChromiumAndroid.css: +(select[size][multiple]): + 2013-01-08 Mike West mk...@chromium.org CSP: 'none' should take effect only if no other source _expression_ is present. Modified: trunk/Source/WebCore/css/themeChromiumAndroid.css (139086 => 139087) --- trunk/Source/WebCore/css/themeChromiumAndroid.css 2013-01-08 19:27:30 UTC (rev 139086) +++ trunk/Source/WebCore/css/themeChromiumAndroid.css 2013-01-08 19:28:34 UTC (rev 139087) @@ -36,6 +36,6 @@ -webkit-appearance: menulist; -webkit-box-align: center; border: 1px solid; -border-radius: 5px; +border-radius: initial; white-space: pre; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137904] trunk/Tools
Title: [137904] trunk/Tools Revision 137904 Author pe...@chromium.org Date 2012-12-17 06:40:38 -0800 (Mon, 17 Dec 2012) Log Message Add Anton Vayvod and Tim Volodine as contributors in committers.py https://bugs.webkit.org/show_bug.cgi?id=105025 Unreviewed. Adds two contributors to committers.py. They are initially contributing to the Text Autosizing feature (master bug: 84186). Patch by John Mellor joh...@chromium.org on 2012-12-17 * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (137903 => 137904) --- trunk/Tools/ChangeLog 2012-12-17 14:14:13 UTC (rev 137903) +++ trunk/Tools/ChangeLog 2012-12-17 14:40:38 UTC (rev 137904) @@ -1,3 +1,13 @@ +2012-12-17 John Mellor joh...@chromium.org + +Add Anton Vayvod and Tim Volodine as contributors in committers.py +https://bugs.webkit.org/show_bug.cgi?id=105025 + +Unreviewed. Adds two contributors to committers.py. +They are initially contributing to the Text Autosizing feature (master bug: 84186). + +* Scripts/webkitpy/common/config/committers.py: + 2012-12-17 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com Unreviewed, add myself to committers.py. Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (137903 => 137904) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-12-17 14:14:13 UTC (rev 137903) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-12-17 14:40:38 UTC (rev 137904) @@ -116,6 +116,7 @@ Contributor(Andrei Bucur, abu...@adobe.com, abucur), Contributor(Anne van Kesteren, annevankesteren+web...@gmail.com, annevk), Contributor(Annie Sullivan, sulli...@chromium.org, annie), +Contributor(Anton Vayvod, avay...@chromium.org, avayvod), Contributor(Antoine Quint, grao...@apple.com, graouts), Contributor(Aryeh Gregor, a...@aryeh.name, AryehGregor), Contributor(Balazs Ankes, b...@inf.u-szeged.hu, abalazs), @@ -166,6 +167,7 @@ Contributor(Tab Atkins, [tabatk...@google.com, jackalm...@gmail.com], tabatkins), Contributor(Tamas Czene, [tcz...@inf.u-szeged.hu, czene.ta...@stud.u-szeged.hu], tczene), Contributor(Tien-Ren Chen, trc...@chromium.org, trchen), +Contributor(Tim Volodine, timvolod...@chromium.org, timvolodine), Contributor(WebKit Review Bot, webkit.review@gmail.com, sheriff-bot), Contributor(Web Components Team, webcomponents-bugzi...@chromium.org), Contributor(Wyatt Carss, [wca...@chromium.org, wca...@google.com], wcarss), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136510] trunk/Tools
Title: [136510] trunk/Tools
Revision 136510
Author pe...@chromium.org
Date 2012-12-04 08:25:22 -0800 (Tue, 04 Dec 2012)
Log Message
[Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
https://bugs.webkit.org/show_bug.cgi?id=103758
Reviewed by Eric Seidel.
Lazily initialize the adb command parameters rather than initializing it in the
constructor now that there is an assert if adb is not available on the system and
we're not in a Chromium Android checkout.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._push_file_if_needed):
(ChromiumAndroidDriver._run_adb_command):
(ChromiumAndroidDriver.cmd_line):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver._read_prompt):
(ChromiumAndroidDriver):
(ChromiumAndroidDriver._adb_command):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
Diff
Modified: trunk/Tools/ChangeLog (136509 => 136510)
--- trunk/Tools/ChangeLog 2012-12-04 15:41:44 UTC (rev 136509)
+++ trunk/Tools/ChangeLog 2012-12-04 16:25:22 UTC (rev 136510)
@@ -1,3 +1,24 @@
+2012-12-04 Peter Beverloo pe...@chromium.org
+
+[Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
+https://bugs.webkit.org/show_bug.cgi?id=103758
+
+Reviewed by Eric Seidel.
+
+Lazily initialize the adb command parameters rather than initializing it in the
+constructor now that there is an assert if adb is not available on the system and
+we're not in a Chromium Android checkout.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidDriver.__init__):
+(ChromiumAndroidDriver._push_file_if_needed):
+(ChromiumAndroidDriver._run_adb_command):
+(ChromiumAndroidDriver.cmd_line):
+(ChromiumAndroidDriver._start_once):
+(ChromiumAndroidDriver._read_prompt):
+(ChromiumAndroidDriver):
+(ChromiumAndroidDriver._adb_command):
+
2012-12-03 Ryosuke Niwa rn...@webkit.org
Dromaeo should report individual test result
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (136509 => 136510)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-12-04 15:41:44 UTC (rev 136509)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-12-04 16:25:22 UTC (rev 136510)
@@ -371,7 +371,7 @@
self._has_setup = False
self._original_governors = {}
self._device_serial = port._get_device_serial(worker_number)
-self._adb_command = [port.path_to_adb(), '-s', self._device_serial]
+self._adb_command_base = None
def __del__(self):
self._teardown_performance()
@@ -426,7 +426,7 @@
def _push_file_if_needed(self, host_file, device_file):
assert os.path.exists(host_file)
device_hashes = self._extract_hashes_from_md5sum_output(
-self._port.host.executive.popen(self._adb_command + ['shell', MD5SUM_DEVICE_PATH, device_file],
+self._port.host.executive.popen(self._adb_command() + ['shell', MD5SUM_DEVICE_PATH, device_file],
stdout=subprocess.PIPE).stdout)
host_hashes = self._extract_hashes_from_md5sum_output(
self._port.host.executive.popen(args=['%s_host' % self._md5sum_path, host_file],
@@ -478,7 +478,7 @@
error_handler = self._port._executive.ignore_error
else:
error_handler = None
-result = self._port._executive.run_command(self._adb_command + cmd, error_handler=error_handler)
+result = self._port._executive.run_command(self._adb_command() + cmd, error_handler=error_handler)
# Limit the length to avoid too verbose output of commands like 'adb logcat' and 'cat /data/tombstones/tombstone01'
# whose outputs are normally printed in later logs.
self._log_debug('Run adb result: ' + result[:80])
@@ -548,7 +548,7 @@
def cmd_line(self, pixel_tests, per_test_args):
# The returned command line is used to start _server_process. In our case, it's an interactive 'adb shell'.
# The command line passed to the DRT process is returned by _drt_cmd_line() instead.
-return self._adb_command + ['shell']
+return self._adb_command() + ['shell']
def _file_exists_on_device(self, full_file_path):
assert full_file_path.startswith('/')
@@ -611,7 +611,7 @@
self._log_debug('Starting forwarder')
self._forwarder_process = self._port._server_process_constructor(
-self._port, 'Forwarder', self._adb_command + ['shell', '%s -D %s' % (DEVICE_FORWARDER_PATH, FORWARD_PORTS)])
+self._port, 'Forwarder', self._adb_command() + ['shell', '%s -D %s' % (DEVICE_FORWARDER_PATH, FORWARD_PORTS)])
[webkit-changes] [136515] trunk/Tools
Title: [136515] trunk/Tools
Revision 136515
Author pe...@chromium.org
Date 2012-12-04 09:39:03 -0800 (Tue, 04 Dec 2012)
Log Message
Add the Chromium Android Release (Perf) bot
https://bugs.webkit.org/show_bug.cgi?id=103891
Reviewed by Eric Seidel.
Add configuration for the bot itself. It will be triggered by the Chromium
Android Release builder. When running for Android, the DownloadAndPerfTest
factory will also add the OutputAndroidDeviceStatus step.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DownloadAndPerfTestFactory.__init__):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (136514 => 136515)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-12-04 17:32:01 UTC (rev 136514)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-12-04 17:39:03 UTC (rev 136515)
@@ -62,6 +62,7 @@
{ name: google-linux-perf, platform: chromium-linux },
{ name: google-linux-android, platform: chromium-android },
{ name: google-android-tests, platform: chromium-android },
+{ name: google-android-perf, platform: chromium-android },
{ name: wincairo-1, platform: wincairo },
@@ -298,7 +299,8 @@
{
name: Chromium Android Release, type: Build, builddir: chromium-linux-android,
platform: chromium-android, configuration: release, architectures: [i386],
- triggers: [chromium-android-release-tests], slavenames: [google-linux-android]
+ triggers: [chromium-android-release-tests, chromium-android-release-perf],
+ slavenames: [google-linux-android]
},
{
name: Chromium Android Release (Tests), type: Test, builddir: chromium-android-release-tests,
@@ -306,6 +308,11 @@
slavenames: [google-android-tests]
},
{
+ name: Chromium Android Release (Perf), type: DownloadAndPerfTest, builddir: chromium-android-release-perf,
+ platform: chromium-android, configuration: release, architectures: [i386],
+ slavenames: [google-android-perf]
+},
+{
name: WinCairo Release, type: BuildAndTest, builddir: win-cairo-release,
platform: wincairo, configuration: release, architectures: [i386],
slavenames: [wincairo-1]
@@ -414,6 +421,9 @@
{ type: Triggerable, name: chromium-android-release-tests,
builderNames: [Chromium Android Release (Tests)]
},
+{ type: Triggerable, name: chromium-android-release-perf,
+ builderNames: [Chromium Android Release (Perf)]
+},
{ type: Triggerable, name: gtk-linux-64-release-tests-wk2,
builderNames: [GTK Linux 64-bit Release WK2 (Tests)]
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (136514 => 136515)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-12-04 17:32:01 UTC (rev 136514)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-12-04 17:39:03 UTC (rev 136515)
@@ -854,6 +854,8 @@
Factory.__init__(self, platform, configuration, architectures, False, SVNMirror, **kwargs)
self.addStep(DownloadBuiltProduct())
self.addStep(ExtractBuiltProduct())
+if platform == chromium-android:
+self.addStep(OutputAndroidDeviceStatus())
self.addStep(RunAndUploadPerfTests())
class DownloadAndPerfTestWebKit2Factory(Factory):
Modified: trunk/Tools/ChangeLog (136514 => 136515)
--- trunk/Tools/ChangeLog 2012-12-04 17:32:01 UTC (rev 136514)
+++ trunk/Tools/ChangeLog 2012-12-04 17:39:03 UTC (rev 136515)
@@ -1,5 +1,20 @@
2012-12-04 Peter Beverloo pe...@chromium.org
+Add the Chromium Android Release (Perf) bot
+https://bugs.webkit.org/show_bug.cgi?id=103891
+
+Reviewed by Eric Seidel.
+
+Add configuration for the bot itself. It will be triggered by the Chromium
+Android Release builder. When running for Android, the DownloadAndPerfTest
+factory will also add the OutputAndroidDeviceStatus step.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(DownloadAndPerfTestFactory.__init__):
+
+2012-12-04 Peter Beverloo pe...@chr
[webkit-changes] [136158] trunk/Tools
Title: [136158] trunk/Tools Revision 136158 Author pe...@chromium.org Date 2012-11-29 13:27:32 -0800 (Thu, 29 Nov 2012) Log Message run-perf-tests --chromium-android should not require adb in my path https://bugs.webkit.org/show_bug.cgi?id=103581 Reviewed by Eric Seidel. Remove the need to have adb available in the path for Layout and Performance tests. We'll determine the versions of the adb version in path (if any) and the one provided in the Chromium Android checkout. Unless the adb available in the path is newer, the provided version will be used. Some other minor nits addressed: - The path_to_forwarder/path_to_md5sum should not be in the private overrides section, as they're not overriding anything and are used by the driver. - Make _restart_adb_as_root slightly more robust by waiting for the device to come back online regardless of the output. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.__init__): (ChromiumAndroidPort.check_build): (ChromiumAndroidPort.path_to_adb): (ChromiumAndroidPort): (ChromiumAndroidPort.path_to_forwarder): (ChromiumAndroidPort.path_to_md5sum): (ChromiumAndroidPort._path_to_helper): (ChromiumAndroidPort._determine_adb_version): (ChromiumAndroidPort._get_devices): (ChromiumAndroidDriver.__init__): (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed): (ChromiumAndroidDriver._push_executable): (ChromiumAndroidDriver._restart_adb_as_root): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py Diff Modified: trunk/Tools/ChangeLog (136157 => 136158) --- trunk/Tools/ChangeLog 2012-11-29 21:25:25 UTC (rev 136157) +++ trunk/Tools/ChangeLog 2012-11-29 21:27:32 UTC (rev 136158) @@ -1,3 +1,36 @@ +2012-11-29 Peter Beverloo pe...@chromium.org + +run-perf-tests --chromium-android should not require adb in my path +https://bugs.webkit.org/show_bug.cgi?id=103581 + +Reviewed by Eric Seidel. + +Remove the need to have adb available in the path for Layout and Performance +tests. We'll determine the versions of the adb version in path (if any) and +the one provided in the Chromium Android checkout. Unless the adb available +in the path is newer, the provided version will be used. + +Some other minor nits addressed: +- The path_to_forwarder/path_to_md5sum should not be in the private overrides + section, as they're not overriding anything and are used by the driver. +- Make _restart_adb_as_root slightly more robust by waiting for the device + to come back online regardless of the output. + +* Scripts/webkitpy/layout_tests/port/chromium_android.py: +(ChromiumAndroidPort.__init__): +(ChromiumAndroidPort.check_build): +(ChromiumAndroidPort.path_to_adb): +(ChromiumAndroidPort): +(ChromiumAndroidPort.path_to_forwarder): +(ChromiumAndroidPort.path_to_md5sum): +(ChromiumAndroidPort._path_to_helper): +(ChromiumAndroidPort._determine_adb_version): +(ChromiumAndroidPort._get_devices): +(ChromiumAndroidDriver.__init__): +(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed): +(ChromiumAndroidDriver._push_executable): +(ChromiumAndroidDriver._restart_adb_as_root): + 2012-11-29 Martin Robinson mrobin...@igalia.com [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (136157 => 136158) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-11-29 21:25:25 UTC (rev 136157) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-11-29 21:27:32 UTC (rev 136158) @@ -32,6 +32,7 @@ import os import re import subprocess +import sys import threading import time @@ -43,7 +44,6 @@ _log = logging.getLogger(__name__) - # The root directory for test resources, which has the same structure as the # source root directory of Chromium. # This path is defined in Chromium's base/test/test_support_android.cc. @@ -155,6 +155,9 @@ class ChromiumAndroidPort(chromium.ChromiumPort): port_name = 'chromium-android' +# Avoid initializing the adb path [worker count]+1 times by storing it as a static member. +_adb_path = None + FALLBACK_PATHS = [ 'chromium-android', 'chromium-linux', @@ -208,8 +211,8 @@ def check_build(self, needs_http): result = super(ChromiumAndroidPort, self).check_build(needs_http) -result = self._check_file_exists(self._path_to_md5sum(), 'md5sum utility') and result -result = self._check_file_exists(self._path_to_forwarder(), 'forwarder utility') and result +result = self._check_file_exists(self.path_to_md5sum(), 'md5sum utility') and result +result = self._check_file_exists(self.path_to_forwarder(), 'forwarder utility') and
[webkit-changes] [135552] trunk/Tools
Title: [135552] trunk/Tools
Revision 135552
Author pe...@chromium.org
Date 2012-11-22 18:38:54 -0800 (Thu, 22 Nov 2012)
Log Message
[Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
https://bugs.webkit.org/show_bug.cgi?id=103065
Reviewed by Dirk Pranke.
This addresses two further reliability issues in the Android test running
scripts. Firstly, the run_tests.py script needs to have the --exit_code
argument passed in order to return non-zero codes, which we need for the
build master to distinguish failures from successful runs.
Secondly, it modifies the layout test runner to briefly wait (through
the wait-for-device command) after requesting a device to switch to root
mode. Without this waiting period, commands might get lost and thereby
unexpectedly fail.
* Scripts/run-api-tests:
* Scripts/run-chromium-webkit-unit-tests:
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._restart_adb_as_root):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-api-tests
trunk/Tools/Scripts/run-chromium-webkit-unit-tests
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
Diff
Modified: trunk/Tools/ChangeLog (135551 => 135552)
--- trunk/Tools/ChangeLog 2012-11-23 01:53:02 UTC (rev 135551)
+++ trunk/Tools/ChangeLog 2012-11-23 02:38:54 UTC (rev 135552)
@@ -1,3 +1,26 @@
+2012-11-22 Peter Beverloo pe...@chromium.org
+
+[Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
+https://bugs.webkit.org/show_bug.cgi?id=103065
+
+Reviewed by Dirk Pranke.
+
+This addresses two further reliability issues in the Android test running
+scripts. Firstly, the run_tests.py script needs to have the --exit_code
+argument passed in order to return non-zero codes, which we need for the
+build master to distinguish failures from successful runs.
+
+Secondly, it modifies the layout test runner to briefly wait (through
+the wait-for-device command) after requesting a device to switch to root
+mode. Without this waiting period, commands might get lost and thereby
+unexpectedly fail.
+
+* Scripts/run-api-tests:
+* Scripts/run-chromium-webkit-unit-tests:
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidDriver._setup_test):
+(ChromiumAndroidDriver._restart_adb_as_root):
+
2012-11-22 Simon Hausmann simon.hausm...@digia.com, Pierre Rossi pierre.ro...@digia.com
[Qt] Separate QWidget dependant code into separate WebKitWidgets static library
Modified: trunk/Tools/Scripts/run-api-tests (135551 => 135552)
--- trunk/Tools/Scripts/run-api-tests 2012-11-23 01:53:02 UTC (rev 135551)
+++ trunk/Tools/Scripts/run-api-tests 2012-11-23 02:38:54 UTC (rev 135552)
@@ -83,7 +83,7 @@
# When running TestWebKitAPI for Chromium on Android, defer to the test runner in
# Chromium as we can't execute the binary locally.
if (isChromiumAndroid()) {
-my @runTestCommand = ('build/android/run_tests.py', '--verbose', '--webkit', '--out-directory', sourceDir() . '/out', '-s', 'TestWebKitAPI');
+my @runTestCommand = ('build/android/run_tests.py', '--verbose', '--webkit', '--exit_code', '--out-directory', sourceDir() . '/out', '-s', 'TestWebKitAPI');
if (configuration() eq Release) {
push @runTestCommand, '--release';
}
Modified: trunk/Tools/Scripts/run-chromium-webkit-unit-tests (135551 => 135552)
--- trunk/Tools/Scripts/run-chromium-webkit-unit-tests 2012-11-23 01:53:02 UTC (rev 135551)
+++ trunk/Tools/Scripts/run-chromium-webkit-unit-tests 2012-11-23 02:38:54 UTC (rev 135552)
@@ -38,7 +38,7 @@
# Defer to Android's test runners for running webkit_unit_tests on a device.
if (checkForArgumentAndRemoveFromARGV('--platform=chromium-android')) {
-my @runTestCommand = ('build/android/run_tests.py', '--verbose', '--webkit', '--out-directory', sourceDir() . '/out', '-s', 'webkit_unit_tests');
+my @runTestCommand = ('build/android/run_tests.py', '--verbose', '--webkit', '--exit_code', '--out-directory', sourceDir() . '/out', '-s', 'webkit_unit_tests');
if (configuration() eq Release) {
push @runTestCommand, '--release';
}
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (135551 => 135552)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-11-23 01:53:02 UTC (rev 135551)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-11-23 02:38:54 UTC (rev 135552)
@@ -354,7 +354,7 @@
if self._has_setup:
return
-self._run_adb_command(['root'])
+self._restart_adb_as_root()
self._setup_md5sum_and_push_data_if_needed()
self._has_setup = True
self._setup_performance()
@@ -425,6 +425,15 @@
[webkit-changes] [135406] trunk/Source/WebKit/chromium
Title: [135406] trunk/Source/WebKit/chromium
Revision 135406
Author pe...@chromium.org
Date 2012-11-21 07:55:22 -0800 (Wed, 21 Nov 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (135405 => 135406)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-11-21 15:45:42 UTC (rev 135405)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-21 15:55:22 UTC (rev 135406)
@@ -1,3 +1,9 @@
+2012-11-21 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-11-21 Allan Sandfeld Jensen allan.jen...@digia.com
Disambiguate innerNodeFramePoint and mainFramePoint
Modified: trunk/Source/WebKit/chromium/DEPS (135405 => 135406)
--- trunk/Source/WebKit/chromium/DEPS 2012-11-21 15:45:42 UTC (rev 135405)
+++ trunk/Source/WebKit/chromium/DEPS 2012-11-21 15:55:22 UTC (rev 135406)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '168452'
+ 'chromium_rev': '169021'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135417] trunk/Source/WebKit/chromium
Title: [135417] trunk/Source/WebKit/chromium
Revision 135417
Author pe...@chromium.org
Date 2012-11-21 10:43:21 -0800 (Wed, 21 Nov 2012)
Log Message
[Chromium] webkit_unit_tests should depend on forwarder2 for Android
https://bugs.webkit.org/show_bug.cgi?id=102934
Reviewed by Tony Chang.
Running webkit_unit_tests and TestWebKitAPI in the WebKit tree will defer
to the test runner used by Chromium, which in turn relies on forwarder2.
forwarder2 will eventually be required by layout tests as well.
* WebKitUnitTests.gyp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKitUnitTests.gyp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (135416 => 135417)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-11-21 18:21:19 UTC (rev 135416)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-21 18:43:21 UTC (rev 135417)
@@ -1,3 +1,16 @@
+2012-11-21 Peter Beverloo pe...@chromium.org
+
+[Chromium] webkit_unit_tests should depend on forwarder2 for Android
+https://bugs.webkit.org/show_bug.cgi?id=102934
+
+Reviewed by Tony Chang.
+
+Running webkit_unit_tests and TestWebKitAPI in the WebKit tree will defer
+to the test runner used by Chromium, which in turn relies on forwarder2.
+forwarder2 will eventually be required by layout tests as well.
+
+* WebKitUnitTests.gyp:
+
2012-11-21 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r135409.
Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (135416 => 135417)
--- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-11-21 18:21:19 UTC (rev 135416)
+++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-11-21 18:43:21 UTC (rev 135417)
@@ -119,6 +119,7 @@
'type': 'shared_library',
'dependencies': [
'(chromium_src_dir)/testing/android/native_test.gyp:native_test_native_code',
+'(chromium_src_dir)/tools/android/forwarder2/forwarder.gyp:forwarder2',
],
}],
['OS==mac', {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134920] trunk/Source/WebKit/chromium
Title: [134920] trunk/Source/WebKit/chromium
Revision 134920
Author pe...@chromium.org
Date 2012-11-16 02:47:21 -0800 (Fri, 16 Nov 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (134919 => 134920)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-11-16 10:31:10 UTC (rev 134919)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-16 10:47:21 UTC (rev 134920)
@@ -1,3 +1,9 @@
+2012-11-16 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-11-15 Kentaro Hara hara...@chromium.org
Unreviewed, rolling out r134880.
Modified: trunk/Source/WebKit/chromium/DEPS (134919 => 134920)
--- trunk/Source/WebKit/chromium/DEPS 2012-11-16 10:31:10 UTC (rev 134919)
+++ trunk/Source/WebKit/chromium/DEPS 2012-11-16 10:47:21 UTC (rev 134920)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '167914'
+ 'chromium_rev': '168130'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134924] trunk/Tools
Title: [134924] trunk/Tools
Revision 134924
Author pe...@chromium.org
Date 2012-11-16 03:23:11 -0800 (Fri, 16 Nov 2012)
Log Message
Running TestWebKitAPI and webkit_unit_tests for Chromium Android should defer to the Chromium-sided test runner
https://bugs.webkit.org/show_bug.cgi?id=102245
Reviewed by Tony Chang.
When running TestWebKitAPI and webkit_unit_test for Chromium Android, defer
the actual running part to the test runner which lives on the Chromium side.
Re-implementing or even generalizing the device-interaction part in WebKit
is error prone and not worth the effort.
* Scripts/run-api-tests:
* Scripts/run-chromium-webkit-unit-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-api-tests
trunk/Tools/Scripts/run-chromium-webkit-unit-tests
Diff
Modified: trunk/Tools/ChangeLog (134923 => 134924)
--- trunk/Tools/ChangeLog 2012-11-16 11:11:07 UTC (rev 134923)
+++ trunk/Tools/ChangeLog 2012-11-16 11:23:11 UTC (rev 134924)
@@ -1,3 +1,18 @@
+2012-11-16 Peter Beverloo pe...@chromium.org
+
+Running TestWebKitAPI and webkit_unit_tests for Chromium Android should defer to the Chromium-sided test runner
+https://bugs.webkit.org/show_bug.cgi?id=102245
+
+Reviewed by Tony Chang.
+
+When running TestWebKitAPI and webkit_unit_test for Chromium Android, defer
+the actual running part to the test runner which lives on the Chromium side.
+Re-implementing or even generalizing the device-interaction part in WebKit
+is error prone and not worth the effort.
+
+* Scripts/run-api-tests:
+* Scripts/run-chromium-webkit-unit-tests:
+
2012-11-15 Yury Semikhatsky yu...@chromium.org
Memory instrumentation: add code for reporting stack traces of unknown instrumented objects
Modified: trunk/Tools/Scripts/run-api-tests (134923 => 134924)
--- trunk/Tools/Scripts/run-api-tests 2012-11-16 11:11:07 UTC (rev 134923)
+++ trunk/Tools/Scripts/run-api-tests 2012-11-16 11:23:11 UTC (rev 134924)
@@ -79,6 +79,19 @@
}
setConfiguration();
+
+# When running TestWebKitAPI for Chromium on Android, defer to the test runner in
+# Chromium as we can't execute the binary locally.
+if (isChromiumAndroid()) {
+my @runTestCommand = ('build/android/run_tests.py', '--verbose', '--webkit', '--out-directory', sourceDir() . '/out', '-s', 'TestWebKitAPI');
+if (configuration() eq Release) {
+push @runTestCommand, '--release';
+}
+
+chdir(sourceDir() . '/Source/WebKit/chromium') or die $!;
+exit exitStatus(system(@runTestCommand));
+}
+
buildTestTool() if $build;
setPathForRunningWebKitApp(\%ENV);
my @testsToRun = listAllTests();
Modified: trunk/Tools/Scripts/run-chromium-webkit-unit-tests (134923 => 134924)
--- trunk/Tools/Scripts/run-chromium-webkit-unit-tests 2012-11-16 11:11:07 UTC (rev 134923)
+++ trunk/Tools/Scripts/run-chromium-webkit-unit-tests 2012-11-16 11:23:11 UTC (rev 134924)
@@ -34,7 +34,19 @@
use webkitdirs;
use VCSUtils;
+setConfiguration();
+
+# Defer to Android's test runners for running webkit_unit_tests on a device.
+if (checkForArgumentAndRemoveFromARGV('--platform=chromium-android')) {
+my @runTestCommand = ('build/android/run_tests.py', '--verbose', '--webkit', '--out-directory', sourceDir() . '/out', '-s', 'webkit_unit_tests');
+if (configuration() eq Release) {
+push @runTestCommand, '--release';
+}
+
+chdir(sourceDir() . '/Source/WebKit/chromium') or die $!;
+exit exitStatus(system(@runTestCommand));
+}
+
push(@ARGV, --chromium);
-setConfiguration();
my $pathToBinary = productDir() . /webkit_unit_tests;
exit exitStatus(system ($pathToBinary, @ARGV));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134261] trunk/Tools
Title: [134261] trunk/Tools Revision 134261 Author pe...@chromium.org Date 2012-11-12 11:12:12 -0800 (Mon, 12 Nov 2012) Log Message [Chromium-Android] Restart the device's shell in root before pushing data https://bugs.webkit.org/show_bug.cgi?id=101944 Reviewed by Adam Barth. Setting up md5sum and pushing the executable, fonts and test resources was unintentionally being done prior to executing the adb root command, which restarts the device's shell to be root. Since test data is still being pushed to /data/local/tmp, writing to which requires root access, devices not running as root would throw a ScriptError. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidDriver._setup_test): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py Diff Modified: trunk/Tools/ChangeLog (134260 => 134261) --- trunk/Tools/ChangeLog 2012-11-12 19:10:10 UTC (rev 134260) +++ trunk/Tools/ChangeLog 2012-11-12 19:12:12 UTC (rev 134261) @@ -1,3 +1,19 @@ +2012-11-12 Peter Beverloo pe...@chromium.org + +[Chromium-Android] Restart the device's shell in root before pushing data +https://bugs.webkit.org/show_bug.cgi?id=101944 + +Reviewed by Adam Barth. + +Setting up md5sum and pushing the executable, fonts and test resources was +unintentionally being done prior to executing the adb root command, +which restarts the device's shell to be root. Since test data is still +being pushed to /data/local/tmp, writing to which requires root access, +devices not running as root would throw a ScriptError. + +* Scripts/webkitpy/layout_tests/port/chromium_android.py: +(ChromiumAndroidDriver._setup_test): + 2012-11-12 Allan Sandfeld Jensen allan.jen...@digia.com [Qt] Support ResourceRequest's setTimeoutInterval Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (134260 => 134261) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-11-12 19:10:10 UTC (rev 134260) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-11-12 19:12:12 UTC (rev 134261) @@ -354,10 +354,11 @@ if self._has_setup: return +self._run_adb_command(['root']) self._setup_md5sum_and_push_data_if_needed() self._has_setup = True -self._run_adb_command(['root']) self._setup_performance() + # Required by webkit_support::GetWebKitRootDirFilePath(). # Other directories will be created automatically by adb push. self._run_adb_command(['shell', 'mkdir', '-p', DEVICE_SOURCE_ROOT_DIR + 'chrome']) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133778] trunk/Tools
Title: [133778] trunk/Tools
Revision 133778
Author pe...@chromium.org
Date 2012-11-07 10:33:31 -0800 (Wed, 07 Nov 2012)
Log Message
Don't show the Android tester in garden-o-matic yet
https://bugs.webkit.org/show_bug.cgi?id=101476
Reviewed by Adam Barth.
The Android tester just started running layout tests, and doesn't upload its
results yet. Don't show it for now. This exception will be removed once it
has a baseline of greenness.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (133777 => 133778)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2012-11-07 18:29:27 UTC (rev 133777)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2012-11-07 18:33:31 UTC (rev 133778)
@@ -89,11 +89,13 @@
// that the gardener only need to look at garden-o-matic and never at the waterfall. Not really sure who
// watches the GPU bots.
// The 10.8 Tests bot is really an FYI bot at this point
+// WebKit Android doesn't upload its results yet.
return builderName.indexOf('GPU') == -1
builderName.indexOf('deps') == -1
builderName.indexOf('ASAN') == -1
builderName.indexOf('Content Shell') == -1
- builderName.indexOf('Mac10.8 Tests') == -1;
+ builderName.indexOf('Mac10.8 Tests') == -1
+ builderName.indexOf('WebKit Android') == -1;
},
},
'gtk' : {
Modified: trunk/Tools/ChangeLog (133777 => 133778)
--- trunk/Tools/ChangeLog 2012-11-07 18:29:27 UTC (rev 133777)
+++ trunk/Tools/ChangeLog 2012-11-07 18:33:31 UTC (rev 133778)
@@ -1,3 +1,17 @@
+2012-11-07 Peter Beverloo pe...@chromium.org
+
+Don't show the Android tester in garden-o-matic yet
+https://bugs.webkit.org/show_bug.cgi?id=101476
+
+Reviewed by Adam Barth.
+
+The Android tester just started running layout tests, and doesn't upload its
+results yet. Don't show it for now. This exception will be removed once it
+has a baseline of greenness.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
+(.):
+
2012-11-07 Balazs Kelemen kbal...@webkit.org
WebKitTestRunner flakily hangs when running pixel tests on Qt
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133580] trunk/LayoutTests
Title: [133580] trunk/LayoutTests Revision 133580 Author pe...@chromium.org Date 2012-11-06 03:17:24 -0800 (Tue, 06 Nov 2012) Log Message [Chromium-Android] Skip a number of crashing tests. Unreviewed rebaselining. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (133579 => 133580) --- trunk/LayoutTests/ChangeLog 2012-11-06 10:49:51 UTC (rev 133579) +++ trunk/LayoutTests/ChangeLog 2012-11-06 11:17:24 UTC (rev 133580) @@ -1,3 +1,11 @@ +2012-11-06 Peter Beverloo pe...@chromium.org + +[Chromium-Android] Skip a number of crashing tests. + +Unreviewed rebaselining. + +* platform/chromium/TestExpectations: + 2012-11-06 Shinya Kawanaka shin...@chromium.org [Shadow] Using isUnknownPseudoElement() for shadow pseudo id seems confusing Modified: trunk/LayoutTests/platform/chromium/TestExpectations (133579 => 133580) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-06 10:49:51 UTC (rev 133579) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-06 11:17:24 UTC (rev 133580) @@ -1706,7 +1706,6 @@ webkit.org/b/98763 [ Android ] platform/chromium/virtual/softwarecompositing/rtl/rtl-absolute.html [ ImageOnlyFailure ] webkit.org/b/98763 [ Android ] platform/chromium/virtual/softwarecompositing/rtl/rtl-overflow-invalidation.html [ ImageOnlyFailure ] - # [Chromium-Android] Some compositing tests have a blue mock scrollbar instead of an actual one webkit.org/b/98816 [ Android ] compositing/rtl/rtl-absolute-overflow-scrolled.html [ ImageOnlyFailure ] webkit.org/b/98816 [ Android ] compositing/rtl/rtl-absolute-overflow.html [ ImageOnlyFailure ] @@ -1881,6 +1880,17 @@ # [Chromium-Android] Some frame-related tests are timing out webkit.org/b/98900 [ Android ] fast/dom/frame-loading-via-document-write.html [ Timeout Pass ] +# [Chromium-Android] A lot of layout tests related to composited 3D transforms/perspective elements are crashing +webkit.org/b/101330 [ Android ] platform/chromium/virtual/threaded/compositing/visibility/visibility-composited-transforms.html [ Skip ] +webkit.org/b/101330 [ Android ] platform/chromium/virtual/threaded/compositing/visibility/visibility-composited.html [ Skip ] +webkit.org/b/101330 [ Android ] platform/chromium/virtual/softwarecompositing/overflow/image-load-overflow-scrollbars.html [ Skip ] +webkit.org/b/101330 [ Android ] platform/chromium/virtual/softwarecompositing/overflow/theme-affects-visual-overflow.html [ Skip ] +webkit.org/b/101330 [ Android ] platform/chromium/virtual/softwarecompositing/overflow/overflow-auto-with-touch-no-overflow.html [ Skip ] +webkit.org/b/101330 [ Android ] platform/chromium/virtual/threaded/compositing/visibility/layer-visible-content.html [ Skip ] +webkit.org/b/101330 [ Android ] compositing/overflow/image-load-overflow-scrollbars.html [ Skip ] +webkit.org/b/101330 [ Android ] compositing/overflow/theme-affects-visual-overflow.html [ Skip ] +webkit.org/b/101330 [ Android ] compositing/overflow/overflow-auto-with-touch-no-overflow.html [ Skip ] + # Need rebaseline webkit.org/b/101186 fast/forms/date/date-appearance-basic.html [ ImageOnlyFailure ] webkit.org/b/101186 fast/forms/date/date-appearance-l10n.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133586] trunk/LayoutTests
Title: [133586] trunk/LayoutTests Revision 133586 Author pe...@chromium.org Date 2012-11-06 04:33:50 -0800 (Tue, 06 Nov 2012) Log Message [Chromium] There shouldn't be linting errors about our TestExpectation files Unreviewed test expectation update. A number of linting errors were being displayed, partially because of my recent additions. Fix them. * platform/chromium-android/TestExpectations: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-android/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (133585 => 133586) --- trunk/LayoutTests/ChangeLog 2012-11-06 12:14:29 UTC (rev 133585) +++ trunk/LayoutTests/ChangeLog 2012-11-06 12:33:50 UTC (rev 133586) @@ -1,3 +1,15 @@ +2012-11-06 Peter Beverloo pe...@chromium.org + +[Chromium] There shouldn't be linting errors about our TestExpectation files + +Unreviewed test expectation update. + +A number of linting errors were being displayed, partially because of my +recent additions. Fix them. + +* platform/chromium-android/TestExpectations: +* platform/chromium/TestExpectations: + 2012-11-06 Shinya Kawanaka shin...@chromium.org [Qt] Disable all tests fast/dom/shadow Modified: trunk/LayoutTests/platform/chromium/TestExpectations (133585 => 133586) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-06 12:14:29 UTC (rev 133585) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-06 12:33:50 UTC (rev 133586) @@ -3850,10 +3850,10 @@ webkit.org/b/96835 platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage.html [ Failure Pass ] webkit.org/b/96834 platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers.html [ ImageOnlyFailure Pass ] -webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/visibility/visibility-composited-transforms.html [ ImageOnlyFailure Pass ] +webkit.org/b/98086 [ Win Mac Linux ] platform/chromium/virtual/threaded/compositing/visibility/visibility-composited-transforms.html [ ImageOnlyFailure Pass ] webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-video-layer.html [ ImageOnlyFailure Pass ] -webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/visibility/visibility-composited.html [ ImageOnlyFailure Pass ] -webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/visibility/layer-visible-content.html [ ImageOnlyFailure Pass ] +webkit.org/b/98086 [ Win Mac Linux ] platform/chromium/virtual/threaded/compositing/visibility/visibility-composited.html [ ImageOnlyFailure Pass ] +webkit.org/b/98086 [ Win Mac Linux ] platform/chromium/virtual/threaded/compositing/visibility/layer-visible-content.html [ ImageOnlyFailure Pass ] webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/webgl/webgl-nonpremultiplied-blend.html [ Crash Pass ] webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/webgl/webgl-no-alpha.html [ Crash Pass ] webkit.org/b/98086 platform/chromium/virtual/threaded/compositing/webgl/webgl-reflection.html [ Crash Pass ] Modified: trunk/LayoutTests/platform/chromium-android/TestExpectations (133585 => 133586) --- trunk/LayoutTests/platform/chromium-android/TestExpectations 2012-11-06 12:14:29 UTC (rev 133585) +++ trunk/LayoutTests/platform/chromium-android/TestExpectations 2012-11-06 12:33:50 UTC (rev 133586) @@ -84,7 +84,6 @@ fast/forms/date-multiple-fields [ WontFix ] fast/forms/month-multiple-fields [ WontFix ] fast/forms/time-multiple-fields [ WontFix ] -fast/forms/week-multiple-fields [ WontFix ] # Page popup UI is for desktop platforms platform/chromium/fast/forms/page-popup [ WontFix ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133642] trunk/Source
Title: [133642] trunk/Source
Revision 133642
Author pe...@chromium.org
Date 2012-11-06 11:04:26 -0800 (Tue, 06 Nov 2012)
Log Message
[Chromium] Enable the _javascript_ i18n API for Android
https://bugs.webkit.org/show_bug.cgi?id=101357
Reviewed by Adam Barth.
Source/WebCore:
Remove the conditional dependency on the v8-i18n API. The library is now
always available in a Chromium for Android checkout.
* WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
Enable the _javascript_ i18n API for Chromium on Android. This adds a
grand total of 18.7 KiB of data to the content shell apk.
* features.gypi:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
Diff
Modified: trunk/Source/WebCore/ChangeLog (133641 => 133642)
--- trunk/Source/WebCore/ChangeLog 2012-11-06 19:03:31 UTC (rev 133641)
+++ trunk/Source/WebCore/ChangeLog 2012-11-06 19:04:26 UTC (rev 133642)
@@ -1,3 +1,15 @@
+2012-11-06 Peter Beverloo pe...@chromium.org
+
+[Chromium] Enable the _javascript_ i18n API for Android
+https://bugs.webkit.org/show_bug.cgi?id=101357
+
+Reviewed by Adam Barth.
+
+Remove the conditional dependency on the v8-i18n API. The library is now
+always available in a Chromium for Android checkout.
+
+* WebCore.gyp/WebCore.gyp:
+
2012-11-06 Adam Barth aba...@webkit.org
ScriptWrappable should work for more than just Node
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (133641 => 133642)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-11-06 19:03:31 UTC (rev 133641)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-11-06 19:04:26 UTC (rev 133642)
@@ -2033,6 +2033,7 @@
'WEBKIT_IMPLEMENTATION=1',
],
'dependencies': [
+'(chromium_src_dir)/third_party/v8-i18n/build/all.gyp:v8-i18n',
'webcore_prerequisites',
],
# This is needed for mac because of webkit_system_interface. It'd be nice
@@ -2130,11 +2131,6 @@
'-fno-strict-aliasing',
],
}, { # OS!=android
- 'dependencies': [
-# Android doesn't have this third party repository, so can't
-# include it. It's not used by Android in any case.
-'(chromium_src_dir)/third_party/v8-i18n/build/all.gyp:v8-i18n',
- ],
'sources/': [['exclude', 'Android\\.cpp$']]
}],
['OS!=mac', {
Modified: trunk/Source/WebKit/chromium/ChangeLog (133641 => 133642)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-11-06 19:03:31 UTC (rev 133641)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-06 19:04:26 UTC (rev 133642)
@@ -1,3 +1,15 @@
+2012-11-06 Peter Beverloo pe...@chromium.org
+
+[Chromium] Enable the _javascript_ i18n API for Android
+https://bugs.webkit.org/show_bug.cgi?id=101357
+
+Reviewed by Adam Barth.
+
+Enable the _javascript_ i18n API for Chromium on Android. This adds a
+grand total of 18.7 KiB of data to the content shell apk.
+
+* features.gypi:
+
2012-11-06 Stephen White senorbla...@chromium.org
Unreviewed. Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/features.gypi (133641 => 133642)
--- trunk/Source/WebKit/chromium/features.gypi 2012-11-06 19:03:31 UTC (rev 133641)
+++ trunk/Source/WebKit/chromium/features.gypi 2012-11-06 19:04:26 UTC (rev 133642)
@@ -77,6 +77,7 @@
'ENABLE_INPUT_TYPE_MONTH=1',
'ENABLE_INPUT_TYPE_TIME=1',
'ENABLE_JAVASCRIPT_DEBUGGER=1',
+ 'ENABLE_JAVASCRIPT_I18N_API=1',
'ENABLE_LEGACY_CSS_VENDOR_PREFIXES=0',
'ENABLE_LEGACY_VIEWPORT_ADAPTION=1',
'ENABLE_LEGACY_VENDOR_PREFIXES=0',
@@ -158,7 +159,6 @@
'ENABLE_INPUT_SPEECH=0',
'ENABLE_INPUT_TYPE_COLOR=0',
'ENABLE_INPUT_TYPE_WEEK=0',
- 'ENABLE_JAVASCRIPT_I18N_API=0',
'ENABLE_LEGACY_NOTIFICATIONS=0',
'ENABLE_MEDIA_CAPTURE=1',
'ENABLE_MEDIA_STREAM=0',
@@ -183,7 +183,6 @@
'ENABLE_INPUT_TYPE_COLOR=1',
'ENABLE_INPUT_TYPE_WEEK=1',
'ENABLE_INPUT_MULTIPLE_FIELDS_UI=1',
- 'ENABLE_JAVASCRIPT_I18N_API=1',
'ENABLE_LEGACY_NOTIFICATIONS=1',
'ENABLE_MEDIA_CAPTURE=0',
'ENABLE_MEDIA_STREAM=1',
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133506] trunk/Tools
Title: [133506] trunk/Tools Revision 133506 Author pe...@chromium.org Date 2012-11-05 11:21:39 -0800 (Mon, 05 Nov 2012) Log Message The layout test runner shouldn't wait for data if stdout/stderr have been closed https://bugs.webkit.org/show_bug.cgi?id=101233 Reviewed by Dirk Pranke. Trying to read the file descriptor for the stdout or stderr pipes when DumpRenderTree has crashed during a Chromium Android layout test-run, which uses FIFOs for communication, causes the File.fileno() method to raise a ValueError. Return early if either of the pipes has already been closed. * Scripts/webkitpy/layout_tests/port/server_process.py: (ServerProcess._wait_for_data_and_update_buffers_using_select): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py Diff Modified: trunk/Tools/ChangeLog (133505 => 133506) --- trunk/Tools/ChangeLog 2012-11-05 19:17:13 UTC (rev 133505) +++ trunk/Tools/ChangeLog 2012-11-05 19:21:39 UTC (rev 133506) @@ -1,3 +1,18 @@ +2012-11-05 Peter Beverloo pe...@chromium.org + +The layout test runner shouldn't wait for data if stdout/stderr have been closed +https://bugs.webkit.org/show_bug.cgi?id=101233 + +Reviewed by Dirk Pranke. + +Trying to read the file descriptor for the stdout or stderr pipes when DumpRenderTree +has crashed during a Chromium Android layout test-run, which uses FIFOs for +communication, causes the File.fileno() method to raise a ValueError. Return early +if either of the pipes has already been closed. + +* Scripts/webkitpy/layout_tests/port/server_process.py: +(ServerProcess._wait_for_data_and_update_buffers_using_select): + 2012-11-05 Dirk Pranke dpra...@chromium.org webkit-patch rebaseline is broken Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py (133505 => 133506) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py 2012-11-05 19:17:13 UTC (rev 133505) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py 2012-11-05 19:21:39 UTC (rev 133506) @@ -226,6 +226,11 @@ return output def _wait_for_data_and_update_buffers_using_select(self, deadline, stopping=False): +if self._proc.stdout.closed or self._proc.stderr.closed: +# If the process crashed and is using FIFOs, like Chromium Android, the +# stdout and stderr pipes will be closed. +return + out_fd = self._proc.stdout.fileno() err_fd = self._proc.stderr.fileno() select_fds = (out_fd, err_fd) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133299] trunk/Tools
return stdout.strip()
+
+def device_type(self):
+return self._run_adb_command(['shell', 'getprop', 'ro.build.product'])
+
+def device_build(self):
+return self._run_adb_command(['shell', 'getprop', 'ro.build.id'])
+
+def device_fingerprint(self):
+return self._run_adb_command(['shell', 'getprop', 'ro.build.fingerprint'])
+
+def battery_level(self):
+return self._run_adb_command(['shell', 'cat', '/sys/class/power_supply/battery/capacity'])
+
+def battery_temperature(self):
+temperature = self._run_adb_command(['shell', 'dumpsys', 'battery'])
+re_temperature = re.compile('temperature:\s+(\d+)')
+return re_temperature.findall(temperature)[0]
+
+def username(self):
+username = self._run_adb_command(['shell', 'id'])
+re_username = re.compile('uid=\d+\((.+?)\)')
+return re_username.findall(username)[0]
+
+
+def main():
+devices = GetAttachedDevices()
+for device_serial in devices:
+device_status = AndroidDeviceStatus(device_serial)
+
+print 'Device %s (%s)' % (device_serial, device_status.device_type())
+print ' Build: %s (%s)' % (device_status.device_build(), device_status.device_fingerprint())
+print ' Battery: %s%%' % device_status.battery_level()
+print ' Battery temp: %s' % device_status.battery_temperature()
+print ' Username: %s' % device_status.username()
+print ''
+
+
+if __name__ == '__main__':
+sys.exit(main())
Property changes on: trunk/Tools/BuildSlaveSupport/chromium/output-android-device-status
___
Added: svn:executable
Modified: trunk/Tools/ChangeLog (133298 => 133299)
--- trunk/Tools/ChangeLog 2012-11-02 15:10:32 UTC (rev 133298)
+++ trunk/Tools/ChangeLog 2012-11-02 15:16:04 UTC (rev 133299)
@@ -1,3 +1,34 @@
+2012-11-02 Peter Beverloo pe...@chromium.org
+
+Output Android's device status before running tests on the bots
+https://bugs.webkit.org/show_bug.cgi?id=100944
+
+Reviewed by Dirk Pranke.
+
+This adds a new step to the build master which will be run prior to the
+actual tests-suites on the Chromium Android tester, and soon the Chromium
+Android Perf bot. For each attached device, it outputs the build
+information, battery level, battery temperature and username.
+
+The Android tester currently is very flaky, and this will help tremendously
+in being able to figure out what's wrong with the bot.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(OutputAndroidDeviceStatus):
+(TestFactory.__init__):
+* BuildSlaveSupport/chromium/output-android-device-status: Added.
+(GetAttachedDevices):
+(AndroidDeviceStatus):
+(AndroidDeviceStatus.__init__):
+(AndroidDeviceStatus._run_adb_command):
+(AndroidDeviceStatus.device_type):
+(AndroidDeviceStatus.device_build):
+(AndroidDeviceStatus.device_fingerprint):
+(AndroidDeviceStatus.battery_level):
+(AndroidDeviceStatus.battery_temperature):
+(AndroidDeviceStatus.username):
+(main):
+
2012-11-02 Jocelyn Turcotte jocelyn.turco...@digia.com
[Qt] WTR: Make sure that eventSender.mouseDown sends a press event for the second press
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133200] trunk/Tools
Title: [133200] trunk/Tools Revision 133200 Author pe...@chromium.org Date 2012-11-01 11:40:29 -0700 (Thu, 01 Nov 2012) Log Message [Chromium-Android] Apache doesn't properly clean up ipc semaphores after a layout test run https://bugs.webkit.org/show_bug.cgi?id=100950 Reviewed by Dirk Pranke. When a test run would fail to complete due to an exception in one of the workers, the HTTP server wouldn't get a chance to gracefully shut down. This caused too much IPC semaphores to be left on the server, causing Apache to fail to start in subsequent runs. By unifying the Android-specific code with other ports, we no longer fail to call the ChromiumPort/Base setup_test_run() and clean_up_test_run() methods either. Furthermore, the number_of_servers argument for starting the HTTP server is now available as well. Because not all tests require an HTTP server, it's not guaranteed that it will be started. Android depends on this, so add a new method to Port and override it for Android: requires_http_server(). * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: (LayoutTestRunner.run_tests): * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._run_tests): * Scripts/webkitpy/layout_tests/port/base.py: (Port.to.requires_http_server): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_dont_require_http_server): * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.requires_http_server): (ChromiumAndroidPort.start_http_server): * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: (ChromiumAndroidPortTest.test_must_require_http_server): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py Diff Modified: trunk/Tools/ChangeLog (133199 => 133200) --- trunk/Tools/ChangeLog 2012-11-01 18:37:23 UTC (rev 133199) +++ trunk/Tools/ChangeLog 2012-11-01 18:40:29 UTC (rev 133200) @@ -1,3 +1,38 @@ +2012-11-01 Peter Beverloo pe...@chromium.org + +[Chromium-Android] Apache doesn't properly clean up ipc semaphores after a layout test run +https://bugs.webkit.org/show_bug.cgi?id=100950 + +Reviewed by Dirk Pranke. + +When a test run would fail to complete due to an exception in one of +the workers, the HTTP server wouldn't get a chance to gracefully shut +down. This caused too much IPC semaphores to be left on the server, +causing Apache to fail to start in subsequent runs. + +By unifying the Android-specific code with other ports, we no longer +fail to call the ChromiumPort/Base setup_test_run() and clean_up_test_run() +methods either. Furthermore, the number_of_servers argument for starting +the HTTP server is now available as well. + +Because not all tests require an HTTP server, it's not guaranteed that +it will be started. Android depends on this, so add a new method to Port +and override it for Android: requires_http_server(). + +* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: +(LayoutTestRunner.run_tests): +* Scripts/webkitpy/layout_tests/controllers/manager.py: +(Manager._run_tests): +* Scripts/webkitpy/layout_tests/port/base.py: +(Port.to.requires_http_server): +* Scripts/webkitpy/layout_tests/port/base_unittest.py: +(PortTest.test_dont_require_http_server): +* Scripts/webkitpy/layout_tests/port/chromium_android.py: +(ChromiumAndroidPort.requires_http_server): +(ChromiumAndroidPort.start_http_server): +* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: +(ChromiumAndroidPortTest.test_must_require_http_server): + 2012-11-01 Adam Roben aro...@webkit.org Crash beneath WKRelease after failed load in MiniBrowser Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py (133199 => 133200) --- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py 2012-11-01 18:37:23 UTC (rev 133199) +++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py 2012-11-01 18:40:29 UTC (rev 133200) @@ -126,7 +126,7 @@ all_shards = locked_shards + unlocked_shards self._remaining_locked_shards = locked_shards -if locked_shards and self._options.http: +if self._port.requires_http_server() or (locked_shards and self._options.http): self.start_servers_with_lock(2 * min(num_workers, len(locked_shards))) num_workers = min(num_workers, len(all_shards)) @@ -252,7 +252,7 @@ index
[webkit-changes] [131394] trunk/Source/WebKit/chromium
Title: [131394] trunk/Source/WebKit/chromium
Revision 131394
Author pe...@chromium.org
Date 2012-10-15 18:20:18 -0700 (Mon, 15 Oct 2012)
Log Message
[Chromium] The default target for Android builds should be all instead of All
https://bugs.webkit.org/show_bug.cgi?id=98879
Reviewed by Adam Barth.
The default gyp target for Android builds is being overridden in Chromium's
envsetup_functions.sh to All (whereas the rest of Chromium and WebKit use all),
because Android wants to use a different list of main targets. There is
no need to do this for the WebKit project, and it's breaking ninja.
* gyp_webkit:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/gyp_webkit
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (131393 => 131394)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-10-16 01:17:47 UTC (rev 131393)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-16 01:20:18 UTC (rev 131394)
@@ -1,3 +1,17 @@
+2012-10-15 Peter Beverloo pe...@chromium.org
+
+[Chromium] The default target for Android builds should be all instead of All
+https://bugs.webkit.org/show_bug.cgi?id=98879
+
+Reviewed by Adam Barth.
+
+The default gyp target for Android builds is being overridden in Chromium's
+envsetup_functions.sh to All (whereas the rest of Chromium and WebKit use all),
+because Android wants to use a different list of main targets. There is
+no need to do this for the WebKit project, and it's breaking ninja.
+
+* gyp_webkit:
+
2012-10-15 Kent Tamura tk...@chromium.org
LocaleMacTest.formatDate is failing on Mac 10.8
Modified: trunk/Source/WebKit/chromium/gyp_webkit (131393 => 131394)
--- trunk/Source/WebKit/chromium/gyp_webkit 2012-10-16 01:17:47 UTC (rev 131393)
+++ trunk/Source/WebKit/chromium/gyp_webkit 2012-10-16 01:20:18 UTC (rev 131394)
@@ -89,6 +89,11 @@
else:
args.remove('--no-envsetup-recursion')
+# Chromium's Android configuration uses the All target instead of all, as it
+# uses a different list of dependencies. WebKit needs to use all for Ninja to work.
+if 'default_target=All' in os.environ.get('GYP_GENERATOR_FLAGS', ''):
+ args.append('-Gdefault_target=all')
+
# Add includes.
args.extend(['-I' + i for i in additional_include_files(args)])
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [131399] trunk/Source/WebKit/chromium
Title: [131399] trunk/Source/WebKit/chromium Revision 131399 Author pe...@chromium.org Date 2012-10-15 19:46:15 -0700 (Mon, 15 Oct 2012) Log Message [Chromium] Enable FAST_MOBILE_SCROLLING for Android https://bugs.webkit.org/show_bug.cgi?id=99401 Reviewed by Adam Barth. * features.gypi: Add the define to the Android-only section. Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/features.gypi Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (131398 => 131399) --- trunk/Source/WebKit/chromium/ChangeLog 2012-10-16 02:36:11 UTC (rev 131398) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-16 02:46:15 UTC (rev 131399) @@ -1,3 +1,12 @@ +2012-10-15 Peter Beverloo pe...@chromium.org + +[Chromium] Enable FAST_MOBILE_SCROLLING for Android +https://bugs.webkit.org/show_bug.cgi?id=99401 + +Reviewed by Adam Barth. + +* features.gypi: Add the define to the Android-only section. + 2012-10-15 Sheriff Bot webkit.review@gmail.com Unreviewed. Rolled DEPS. Modified: trunk/Source/WebKit/chromium/features.gypi (131398 => 131399) --- trunk/Source/WebKit/chromium/features.gypi 2012-10-16 02:36:11 UTC (rev 131398) +++ trunk/Source/WebKit/chromium/features.gypi 2012-10-16 02:46:15 UTC (rev 131399) @@ -151,6 +151,7 @@ 'ENABLE_ACCELERATED_OVERFLOW_SCROLLING=1', 'ENABLE_CALENDAR_PICKER=0', 'ENABLE_DATALIST_ELEMENT=0', + 'ENABLE_FAST_MOBILE_SCROLLING=1', 'ENABLE_INPUT_SPEECH=0', 'ENABLE_INPUT_TYPE_COLOR=0', 'ENABLE_JAVASCRIPT_I18N_API=0', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130904] trunk/LayoutTests
Title: [130904] trunk/LayoutTests Revision 130904 Author pe...@chromium.org Date 2012-10-10 08:18:21 -0700 (Wed, 10 Oct 2012) Log Message [Chromium-Android] Another batch of TestExpectation updates for Android https://bugs.webkit.org/show_bug.cgi?id=98909 Unreviewed test expectation update. Many of the failures were actually ImageOnlyFailure, which isn't part of the Failure state. This also includes a number of new expected results, mostly focusing on crashing and timing out tests. * platform/chromium-android/TestExpectations: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-android/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (130903 => 130904) --- trunk/LayoutTests/ChangeLog 2012-10-10 15:04:46 UTC (rev 130903) +++ trunk/LayoutTests/ChangeLog 2012-10-10 15:18:21 UTC (rev 130904) @@ -1,3 +1,17 @@ +2012-10-10 Peter Beverloo pe...@chromium.org + +[Chromium-Android] Another batch of TestExpectation updates for Android +https://bugs.webkit.org/show_bug.cgi?id=98909 + +Unreviewed test expectation update. + +Many of the failures were actually ImageOnlyFailure, which isn't part +of the Failure state. This also includes a number of new expected +results, mostly focusing on crashing and timing out tests. + +* platform/chromium-android/TestExpectations: +* platform/chromium/TestExpectations: + 2012-10-10 Kent Tamura tk...@chromium.org [Chromium] Layout Test platform/chromium/fast/forms/*/*-suggestion-picker-*-operations.html are flaky Modified: trunk/LayoutTests/platform/chromium/TestExpectations (130903 => 130904) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-10 15:04:46 UTC (rev 130903) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-10 15:18:21 UTC (rev 130904) @@ -1573,112 +1573,146 @@ # - # Composited/HW content have the red and blue channels inverted in DRT on Chromium Android -webkit.org/b/98647 [ Android ] animations/additive-transform-animations.html [ Failure ] -webkit.org/b/98647 [ Android ] platform/chromium/compositing/render-surface-alpha-blending.html [ Failure ] -webkit.org/b/98647 [ Android ] platform/chromium/compositing/huge-layer-rotated.html [ Failure ] -webkit.org/b/98647 [ Android ] platform/chromium/compositing/child-layer-3d-sorting.html [ Failure ] -webkit.org/b/98647 [ Android ] platform/chromium/compositing/3d-corners.html [ Failure ] -webkit.org/b/98647 [ Android ] fast/repaint/block-selection-gap-in-composited-layer.html [ Failure ] -webkit.org/b/98647 [ Android ] fast/css/transform-default-parameter.html [ Failure ] -webkit.org/b/98647 [ Android ] fast/canvas/canvas-toDataURL-webp.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/backface-visibility/backface-visibility-3d.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/backface-visibility/backface-visibility-image.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/backface-visibility/backface-visibility-non3d.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/backface-visibility/backface-visibility-webgl.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/color-matching/image-color-matching.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/color-matching/pdf-image-match.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/culling/filter-occlusion-blur-large.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/culling/filter-occlusion-blur.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/direct-image-compositing.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/generated-content.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/geometry/clipping-foreground.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/geometry/composited-html-size.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/geometry/fixed-in-composited.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/geometry/fixed-position.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/geometry/flipped-writing-mode.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/geometry/layer-due-to-layer-children-deep.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/geometry/outline-change.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/geometry/repaint-foreground-layer.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/geometry/transfrom-origin-on-zero-size-layer.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/iframes/iframe-in-composited-layer.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/iframes/invisible-iframe.html [ Failure ] -webkit.org/b/98647 [ Android ] compositing/iframes/invisible-nested-iframe.html [ Failure ] -webk
[webkit-changes] [130799] trunk/LayoutTests
Title: [130799] trunk/LayoutTests Revision 130799 Author pe...@chromium.org Date 2012-10-09 13:06:18 -0700 (Tue, 09 Oct 2012) Log Message [Chromium] More TestExpectation updates for Android https://bugs.webkit.org/show_bug.cgi?id=98818 Unreviewed test expectation updates. List more failures (all with bugs assigned) in the TestExpectation file for Android. Move an older block around, considering we may want to re-triage it. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (130798 => 130799) --- trunk/LayoutTests/ChangeLog 2012-10-09 19:55:59 UTC (rev 130798) +++ trunk/LayoutTests/ChangeLog 2012-10-09 20:06:18 UTC (rev 130799) @@ -1,3 +1,15 @@ +2012-10-09 Peter Beverloo pe...@chromium.org + +[Chromium] More TestExpectation updates for Android +https://bugs.webkit.org/show_bug.cgi?id=98818 + +Unreviewed test expectation updates. + +List more failures (all with bugs assigned) in the TestExpectation file for +Android. Move an older block around, considering we may want to re-triage it. + +* platform/chromium/TestExpectations: + 2012-10-09 Julien Chaffraix jchaffr...@webkit.org Unreviewed Chromium gardening. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (130798 => 130799) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-09 19:55:59 UTC (rev 130798) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-09 20:06:18 UTC (rev 130799) @@ -1586,17 +1586,89 @@ webkit.org/b/98647 [ Android ] fast/repaint/block-selection-gap-in-composited-layer.html [ Failure ] webkit.org/b/98647 [ Android ] fast/css/transform-default-parameter.html [ Failure ] webkit.org/b/98647 [ Android ] fast/canvas/canvas-toDataURL-webp.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/backface-visibility/backface-visibility-3d.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/backface-visibility/backface-visibility-image.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/backface-visibility/backface-visibility-non3d.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/backface-visibility/backface-visibility-webgl.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/color-matching/image-color-matching.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/color-matching/pdf-image-match.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/culling/filter-occlusion-blur-large.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/culling/filter-occlusion-blur.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/direct-image-compositing.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/generated-content.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/geometry/clipping-foreground.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/geometry/composited-html-size.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/geometry/fixed-in-composited.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/geometry/fixed-position.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/geometry/flipped-writing-mode.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/geometry/layer-due-to-layer-children-deep.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/geometry/outline-change.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/geometry/repaint-foreground-layer.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/geometry/transfrom-origin-on-zero-size-layer.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/iframes/iframe-in-composited-layer.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/iframes/invisible-iframe.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/iframes/invisible-nested-iframe.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/images/direct-image-background-color.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/images/truncated-direct-png-image.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/masks/direct-image-mask.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/masks/mask-of-clipped-layer.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/overflow/scrollbars-with-clipped-owner.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/reflections/animation-inside-reflection.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/reflections/deeply-nested-reflections.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/reflections/simple-composited-reflections.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/sibling-positioning.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/transitions/scale-transition-no-start.html [ Failure ] +webkit.org/b/98647 [ Android ] compositing/visibility/visi
[webkit-changes] [130771] trunk/LayoutTests
Title: [130771] trunk/LayoutTests Revision 130771 Author pe...@chromium.org Date 2012-10-09 09:21:05 -0700 (Tue, 09 Oct 2012) Log Message [Chromium] Test expectation updates for Android https://bugs.webkit.org/show_bug.cgi?id=98786 Unreviewed test expectation update. Update the test expectations for Android. Nineteen bugs were filed, which are all blocking bug 96398. * platform/chromium-android/TestExpectations: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-android/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (130770 => 130771) --- trunk/LayoutTests/ChangeLog 2012-10-09 16:03:50 UTC (rev 130770) +++ trunk/LayoutTests/ChangeLog 2012-10-09 16:21:05 UTC (rev 130771) @@ -1,3 +1,16 @@ +2012-10-09 Peter Beverloo pe...@chromium.org + +[Chromium] Test expectation updates for Android +https://bugs.webkit.org/show_bug.cgi?id=98786 + +Unreviewed test expectation update. + +Update the test expectations for Android. Nineteen bugs were filed, +which are all blocking bug 96398. + +* platform/chromium-android/TestExpectations: +* platform/chromium/TestExpectations: + 2012-10-09 Raphael Kubo da Costa raphael.kubo.da.co...@intel.com [EFL] Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (130770 => 130771) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-09 16:03:50 UTC (rev 130770) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-09 16:21:05 UTC (rev 130771) @@ -1568,6 +1568,192 @@ # END MAC PORT TESTS # - +# - +# ANDROID PORT TESTS +# +# These tests look like actual failures and need to be triaged. The master bug +# for this is https://bugs.webkit.org/show_bug.cgi?id=96398 +# - + +# Composited/HW content have the red and blue channels inverted in DRT on Chromium Android +webkit.org/b/98647 [ Android ] animations/additive-transform-animations.html [ Failure ] +webkit.org/b/98647 [ Android ] platform/chromium/compositing/render-surface-alpha-blending.html [ Failure ] +webkit.org/b/98647 [ Android ] platform/chromium/compositing/huge-layer-rotated.html [ Failure ] +webkit.org/b/98647 [ Android ] platform/chromium/compositing/child-layer-3d-sorting.html [ Failure ] +webkit.org/b/98647 [ Android ] platform/chromium/compositing/3d-corners.html [ Failure ] +webkit.org/b/98647 [ Android ] fast/repaint/block-selection-gap-in-composited-layer.html [ Failure ] +webkit.org/b/98647 [ Android ] fast/css/transform-default-parameter.html [ Failure ] +webkit.org/b/98647 [ Android ] fast/canvas/canvas-toDataURL-webp.html [ Failure ] + +# [Chromium-Android] Some compositor tests have half a pixel offset +webkit.org/b/98762 [ Android ] platform/chromium/compositing/lost-compositor-context.html [ Failure ] +webkit.org/b/98762 [ Android ] platform/chromium/compositing/lost-compositor-context-twice.html [ Failure ] +webkit.org/b/98762 [ Android ] platform/chromium/compositing/lost-compositor-context-permanently.html [ Failure ] +webkit.org/b/98762 [ Android ] fast/layers/no-clipping-overflow-hidden-added-after-transition.html [ Failure ] + +# [Chromium-Android] Two tests don't display a scrollbar, while they probably should +webkit.org/b/98763 [ Android ] platform/chromium/compositing/layout-width-change.html [ Failure ] +webkit.org/b/98763 [ Android ] platform/chromium/compositing/img-layer-grow.html [ Failure ] + +# [Chromium-Android] Video does not yet work on Android +webkit.org/b/98765 [ Android ] media/video-zoom.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-zoom-controls.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-transformed.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-timeupdate-during-playback.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-playing-and-pause.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-no-audio.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-layer-crash.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-frame-accurate-seek.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-empty-source.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-display-toggle.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-controls-rendering.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-colorspace-yuv422.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-colorspace-yuv420.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-canvas-alpha.html [ Failure ] +webkit.org/b/98765 [ Android ] media/video-aspect-ratio.html [ Failure ] +webkit.org/b/98765 [ Android ] media/media-load-even
[webkit-changes] [129522] trunk/Tools
Title: [129522] trunk/Tools
Revision 129522
Author pe...@chromium.org
Date 2012-09-25 10:10:32 -0700 (Tue, 25 Sep 2012)
Log Message
[Chromium] Android's build archives have grown from 38M to 102M in 11 days
https://bugs.webkit.org/show_bug.cgi?id=97336
Reviewed by Adam Barth.
Each WebKit target results in four APKs in the out/{Debug,Release}/ directory,
while we really only need one. Ignoring the unsigned APKs removes six from
the archive will make sure that we only archive a single APK per target,
bringing its size back to rougly 40 megabytes.
* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
Modified Paths
trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (129521 => 129522)
--- trunk/Tools/BuildSlaveSupport/built-product-archive 2012-09-25 17:08:01 UTC (rev 129521)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive 2012-09-25 17:10:32 UTC (rev 129522)
@@ -169,7 +169,7 @@
'BuildLog.htm', '*.obj', '*.pdb', '*.pch', '*.tlog', '*.lastbuildstate']
if fullPlatform and fullPlatform == 'chromium-android':
-ignorePatterns.extend(['*.so', '*-unaligned.apk'])
+ignorePatterns.extend(['*.so', '*-unaligned.apk', '*-unsigned.apk'])
removeDirectoryIfExists(thinDirectory)
copyBuildFiles(configurationBuildDirectory, thinDirectory, ignorePatterns)
Modified: trunk/Tools/ChangeLog (129521 => 129522)
--- trunk/Tools/ChangeLog 2012-09-25 17:08:01 UTC (rev 129521)
+++ trunk/Tools/ChangeLog 2012-09-25 17:10:32 UTC (rev 129522)
@@ -1,3 +1,18 @@
+2012-09-25 Peter Beverloo pe...@chromium.org
+
+[Chromium] Android's build archives have grown from 38M to 102M in 11 days
+https://bugs.webkit.org/show_bug.cgi?id=97336
+
+Reviewed by Adam Barth.
+
+Each WebKit target results in four APKs in the out/{Debug,Release}/ directory,
+while we really only need one. Ignoring the unsigned APKs removes six from
+the archive will make sure that we only archive a single APK per target,
+bringing its size back to rougly 40 megabytes.
+
+* BuildSlaveSupport/built-product-archive:
+(archiveBuiltProduct):
+
2012-09-25 Tommy Widenflycht tom...@google.com
MediaStream API: Update getUserMedia to match the latest specification
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129369] trunk/Websites/bugs.webkit.org
Title: [129369] trunk/Websites/bugs.webkit.org Revision 129369 Author pe...@chromium.org Date 2012-09-24 08:33:42 -0700 (Mon, 24 Sep 2012) Log Message Allow robots to index bugs on Bugzilla https://bugs.webkit.org/show_bug.cgi?id=95688 Reviewed by Eric Seidel. This allows robots to access show_bug.cgi, thus granting them access to index contents and discussion on WebKit bugs. All other pages, except for the site index itself, still have indexing disabled. * robots.txt: Modified Paths trunk/Websites/bugs.webkit.org/ChangeLog trunk/Websites/bugs.webkit.org/robots.txt Diff Modified: trunk/Websites/bugs.webkit.org/ChangeLog (129368 => 129369) --- trunk/Websites/bugs.webkit.org/ChangeLog 2012-09-24 15:09:03 UTC (rev 129368) +++ trunk/Websites/bugs.webkit.org/ChangeLog 2012-09-24 15:33:42 UTC (rev 129369) @@ -1,3 +1,16 @@ +2012-09-24 Peter Beverloo pe...@chromium.org + +Allow robots to index bugs on Bugzilla +https://bugs.webkit.org/show_bug.cgi?id=95688 + +Reviewed by Eric Seidel. + +This allows robots to access show_bug.cgi, thus granting them access to +index contents and discussion on WebKit bugs. All other pages, except +for the site index itself, still have indexing disabled. + +* robots.txt: + 2012-07-13 Ojan Vafai o...@chromium.org PrettyPatch.rb complains about missing checksum for new pixel results Modified: trunk/Websites/bugs.webkit.org/robots.txt (129368 => 129369) --- trunk/Websites/bugs.webkit.org/robots.txt 2012-09-24 15:09:03 UTC (rev 129368) +++ trunk/Websites/bugs.webkit.org/robots.txt 2012-09-24 15:33:42 UTC (rev 129369) @@ -1,3 +1,5 @@ User-agent: * Allow: /index.cgi +Allow: /show_bug.cgi Disallow: / +Crawl-delay: 20 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129394] trunk/Source/WebCore
Title: [129394] trunk/Source/WebCore
Revision 129394
Author pe...@chromium.org
Date 2012-09-24 11:42:22 -0700 (Mon, 24 Sep 2012)
Log Message
Android's mock scrollbars shows up as a difference in layout test results
https://bugs.webkit.org/show_bug.cgi?id=96382
Reviewed by Adam Barth.
Remove the exceptions made for layout tests in Android's scrollbar theme.
This will make our actual scrollbars show up in layout test pixel results,
bringing the tests closer to what we actually ship.
An important difference with other platforms is that scrollbars do not
take any width on Android, they're rendered on top of the content. Therefore
each test that has a visible scrollbar does not just need a new pixel
result, but will also need a new text result. This will be handled as part
of a larger rebaselining process.
Will be exercised by every layout test that has a scrollbar.
* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb):
* platform/chromium/ScrollbarThemeChromiumAndroid.h:
(ScrollbarThemeChromiumAndroid):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (129393 => 129394)
--- trunk/Source/WebCore/ChangeLog 2012-09-24 18:39:24 UTC (rev 129393)
+++ trunk/Source/WebCore/ChangeLog 2012-09-24 18:42:22 UTC (rev 129394)
@@ -1,3 +1,29 @@
+2012-09-24 Peter Beverloo pe...@chromium.org
+
+Android's mock scrollbars shows up as a difference in layout test results
+https://bugs.webkit.org/show_bug.cgi?id=96382
+
+Reviewed by Adam Barth.
+
+Remove the exceptions made for layout tests in Android's scrollbar theme.
+This will make our actual scrollbars show up in layout test pixel results,
+bringing the tests closer to what we actually ship.
+
+An important difference with other platforms is that scrollbars do not
+take any width on Android, they're rendered on top of the content. Therefore
+each test that has a visible scrollbar does not just need a new pixel
+result, but will also need a new text result. This will be handled as part
+of a larger rebaselining process.
+
+Will be exercised by every layout test that has a scrollbar.
+
+* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
+(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
+(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
+(WebCore::ScrollbarThemeChromiumAndroid::hasThumb):
+* platform/chromium/ScrollbarThemeChromiumAndroid.h:
+(ScrollbarThemeChromiumAndroid):
+
2012-09-24 Sean Wang xuewen.w...@torchmobile.com.cn
[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp (129393 => 129394)
--- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp 2012-09-24 18:39:24 UTC (rev 129393)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp 2012-09-24 18:42:22 UTC (rev 129394)
@@ -26,7 +26,6 @@
#include config.h
#include ScrollbarThemeChromiumAndroid.h
-#include LayoutTestSupport.h
#include PlatformContextSkia.h
#include PlatformMouseEvent.h
#include PlatformSupport.h
@@ -50,21 +49,12 @@
int ScrollbarThemeChromiumAndroid::scrollbarThickness(ScrollbarControlSize controlSize)
{
-if (isRunningLayoutTest()) {
-// Match Chromium-Linux for DumpRenderTree, so the layout test results
-// can be shared. The width of scrollbar down arrow should equal the
-// width of the vertical scrollbar.
-IntSize scrollbarSize = PlatformSupport::getThemePartSize(PlatformSupport::PartScrollbarDownArrow);
-return scrollbarSize.width();
-}
-
return scrollbarWidth + scrollbarMargin;
}
bool ScrollbarThemeChromiumAndroid::usesOverlayScrollbars() const
{
-// In layout test mode, match Chromium-Linux.
-return !isRunningLayoutTest();
+return true;
}
int ScrollbarThemeChromiumAndroid::thumbPosition(ScrollbarThemeClient* scrollbar)
@@ -92,8 +82,7 @@
bool ScrollbarThemeChromiumAndroid::hasThumb(ScrollbarThemeClient* scrollbar)
{
-// In layout test mode, match Chromium-Linux.
-return !isRunningLayoutTest();
+return true;
}
IntRect ScrollbarThemeChromiumAndroid::backButtonRect(ScrollbarThemeClient*, ScrollbarPart, bool)
@@ -157,12 +146,4 @@
fillSmoothEdgedRect(context, thumbRect, Color(128, 128, 128, 128));
}
-void ScrollbarThemeChromiumAndroid::paintScrollbarBackground(GraphicsContext* context, ScrollbarThemeClient* scrollbar)
-{
-// Paint
[webkit-changes] [129216] trunk/Source/WebKit/chromium
Title: [129216] trunk/Source/WebKit/chromium
Revision 129216
Author pe...@chromium.org
Date 2012-09-21 05:16:30 -0700 (Fri, 21 Sep 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (129215 => 129216)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-21 12:08:06 UTC (rev 129215)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-21 12:16:30 UTC (rev 129216)
@@ -1,3 +1,9 @@
+2012-09-21 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-09-21 Keishi Hattori kei...@webkit.org
Add datalist suggestions into DateTimeChooserParameters
Modified: trunk/Source/WebKit/chromium/DEPS (129215 => 129216)
--- trunk/Source/WebKit/chromium/DEPS 2012-09-21 12:08:06 UTC (rev 129215)
+++ trunk/Source/WebKit/chromium/DEPS 2012-09-21 12:16:30 UTC (rev 129216)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '157829'
+ 'chromium_rev': '157963'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129221] trunk
Title: [129221] trunk
Revision 129221
Author pe...@chromium.org
Date 2012-09-21 06:36:14 -0700 (Fri, 21 Sep 2012)
Log Message
Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
https://bugs.webkit.org/show_bug.cgi?id=97227
Reviewed by Tony Chang.
Source/WebKit/chromium:
Remove all fifo-related code together with the io_stream_forwarder_android
target defined in WebKitUnitTests.gyp.
* WebKitUnitTests.gyp:
* tests/ForwardIOStreamsAndroid.cpp: Removed.
* tests/ForwardIOStreamsAndroid.h: Removed.
* tests/RunAllTests.cpp:
(main):
Tools:
We switched Chromium to using FIFOs in order to achieve better consistency,
which was done by Marcus in r157541. Remove all custom WebKit code in
favor of Chromium's implementation.
Remove more FIFO code in the test runner itself, including the code in
DumpRenderTree that invoked it. We can now switch to Chromium's brand
new FIFO-creating code, which is being set-up for all test targets build
for Android, including DumpRenderTree, TestWebKitAPI and webkit_unit_tests.
This also changes the ChromiumAndroidDriver._remove_all_pipes method to
delete the files individually. rm would fail if one of the earlier files
does not exist, and the -f argument doesn't seem to be reliable.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._get_external_storage):
(ChromiumAndroidDriver._drt_cmd_line):
(ChromiumAndroidDriver._remove_all_pipes):
(ChromiumAndroidDriver.stop):
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKitUnitTests.gyp
trunk/Source/WebKit/chromium/tests/RunAllTests.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp
Removed Paths
trunk/Source/WebKit/chromium/tests/ForwardIOStreamsAndroid.cpp
trunk/Source/WebKit/chromium/tests/ForwardIOStreamsAndroid.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (129220 => 129221)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-21 13:16:17 UTC (rev 129220)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-21 13:36:14 UTC (rev 129221)
@@ -1,3 +1,19 @@
+2012-09-20 Peter Beverloo pe...@chromium.org
+
+Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
+https://bugs.webkit.org/show_bug.cgi?id=97227
+
+Reviewed by Tony Chang.
+
+Remove all fifo-related code together with the io_stream_forwarder_android
+target defined in WebKitUnitTests.gyp.
+
+* WebKitUnitTests.gyp:
+* tests/ForwardIOStreamsAndroid.cpp: Removed.
+* tests/ForwardIOStreamsAndroid.h: Removed.
+* tests/RunAllTests.cpp:
+(main):
+
2012-09-21 Peter Beverloo pe...@chromium.org
Unreviewed. Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (129220 => 129221)
--- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-09-21 13:16:17 UTC (rev 129220)
+++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-09-21 13:36:14 UTC (rev 129221)
@@ -119,7 +119,6 @@
'type': 'shared_library',
'dependencies': [
'(chromium_src_dir)/testing/android/native_test.gyp:native_test_native_code',
-'io_stream_forwarder_android',
],
}],
],
@@ -202,20 +201,6 @@
'(android_app_abi)',
],
}],
-},
-# FIXME: When the Android test runner framework in Chromium has stabilized enough,
-# we should switch to using that and will no longer need the stream forwarding.
-# https://bugs.webkit.org/show_bug.cgi?id=96764
-{
-'target_name': 'io_stream_forwarder_android',
-'type': 'static_library',
-'sources': [
-'tests/ForwardIOStreamsAndroid.cpp',
-'tests/ForwardIOStreamsAndroid.h',
-],
-'dependencies': [
-'../../WebCore/WebCore.gyp/WebCore.gyp:webcore',
-],
}],
}],
['clang==1', {
Deleted: trunk/Source/WebKit/chromium/tests/ForwardIOStreamsAndroid.cpp (129220 => 129221)
--- trunk/Source/WebKit/chromium/tests/ForwardIOStreamsAndroid.cpp 2012-09-21 13:16:17 UTC (rev 129220)
+++ trunk/Source/WebKit/chromium/tests/ForwardIOStreamsAndroid.cpp 2012-09-21 13:36:14 UTC (rev 129221)
@@ -1,125 +0,0 @@
-/*
- * Copyright (C) 2012 Google Inc. All rights
[webkit-changes] [129226] trunk/Tools
Title: [129226] trunk/Tools
Revision 129226
Author pe...@chromium.org
Date 2012-09-21 07:25:23 -0700 (Fri, 21 Sep 2012)
Log Message
[Chromium] Switch back to a fixed fifo path for Android
https://bugs.webkit.org/show_bug.cgi?id=97230
Reviewed by Tony Chang.
Because not all external storage cards will be formated using a file
system that supports named pipes, Chromium has been changed to creating
the pipes in a temporary folder on the internal storage. Adapt this in
WebKit so we can continue to run layout tests.
This also includes an *unreviewed* fix for a breakage in the webkitpy
tests I made in r129221. Two lines and related to this code, so I decided
to include it in this change.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._update_version):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (129225 => 129226)
--- trunk/Tools/ChangeLog 2012-09-21 14:11:27 UTC (rev 129225)
+++ trunk/Tools/ChangeLog 2012-09-21 14:25:23 UTC (rev 129226)
@@ -1,3 +1,24 @@
+2012-09-21 Peter Beverloo pe...@chromium.org
+
+[Chromium] Switch back to a fixed fifo path for Android
+https://bugs.webkit.org/show_bug.cgi?id=97230
+
+Reviewed by Tony Chang.
+
+Because not all external storage cards will be formated using a file
+system that supports named pipes, Chromium has been changed to creating
+the pipes in a temporary folder on the internal storage. Adapt this in
+WebKit so we can continue to run layout tests.
+
+This also includes an *unreviewed* fix for a breakage in the webkitpy
+tests I made in r129221. Two lines and related to this code, so I decided
+to include it in this change.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidDriver.__init__):
+(ChromiumAndroidDriver._setup_test):
+(ChromiumAndroidDriver._update_version):
+
2012-09-20 Peter Beverloo pe...@chromium.org
Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (129225 => 129226)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-09-21 14:11:27 UTC (rev 129225)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-09-21 14:25:23 UTC (rev 129226)
@@ -56,6 +56,9 @@
DEVICE_DRT_DIR = DEVICE_SOURCE_ROOT_DIR + 'drt/'
DEVICE_FORWARDER_PATH = DEVICE_DRT_DIR + 'forwarder'
+# Path on the device where the test framework will create the fifo pipes.
+DEVICE_FIFO_PATH = '/data/data/org.chromium.native_test/files/'
+
DRT_APP_PACKAGE = 'org.chromium.native_test'
DRT_ACTIVITY_FULL_NAME = DRT_APP_PACKAGE + '/.ChromeNativeTestActivity'
DRT_APP_CACHE_DIR = DEVICE_DRT_DIR + 'cache/'
@@ -311,9 +314,9 @@
def __init__(self, port, worker_number, pixel_tests, no_timeout=False):
super(ChromiumAndroidDriver, self).__init__(port, worker_number, pixel_tests, no_timeout)
self._cmd_line = None
-self._in_fifo_path = ''
-self._out_fifo_path = ''
-self._err_fifo_path = ''
+self._in_fifo_path = DEVICE_FIFO_PATH + 'stdin.fifo'
+self._out_fifo_path = DEVICE_FIFO_PATH + 'test.fifo'
+self._err_fifo_path = DEVICE_FIFO_PATH + 'stderr.fifo'
self._read_stdout_process = None
self._read_stderr_process = None
self._forwarder_process = None
@@ -321,7 +324,6 @@
self._original_governors = {}
self._device_serial = port._get_device_serial(worker_number)
self._adb_command = ['adb', '-s', self._device_serial]
-self._external_storage = ''
def __del__(self):
self._teardown_performance()
@@ -343,11 +345,6 @@
if self._has_setup:
return
-# Set up the fifo paths used for getting DumpRenderTree's output.
-self._in_fifo_path = self._get_external_storage() + '/native_tests/stdin.fifo'
-self._out_fifo_path = self._get_external_storage() + '/native_tests/test.fifo'
-self._err_fifo_path = self._get_external_storage() + '/native_tests/stderr.fifo'
-
self._setup_md5sum_and_push_data_if_needed()
self._has_setup = True
self._run_adb_command(['root'])
@@ -429,12 +426,6 @@
def _update_version(self, dir, version):
self._run_adb_command(['shell', 'echo %d %sVERSION' % (version, dir)])
-def _get_external_storage(self):
-if not self._external_storage:
-self._external_storage = self._run_adb_command(['shell', 'echo', '$EXTERNAL_STORAGE']).splitlines()[0]
-assert self._external_storage, 'Unable to find $EXTERNAL_STORAGE'
-return self._external_s
[webkit-changes] [129128] trunk/LayoutTests
Title: [129128] trunk/LayoutTests Revision 129128 Author pe...@chromium.org Date 2012-09-20 07:01:23 -0700 (Thu, 20 Sep 2012) Log Message [chromium] Skip tests that will be broken by an upcoming V8 roll. https://bugs.webkit.org/show_bug.cgi?id=97206 Unreviewed preemptive gardening. These three tests will be broken by an upcoming V8 roll. I plan on rebaselining them along with webkit.org/b/94332. Patch by Mike West mk...@google.com on 2012-09-20 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (129127 => 129128) --- trunk/LayoutTests/ChangeLog 2012-09-20 13:25:12 UTC (rev 129127) +++ trunk/LayoutTests/ChangeLog 2012-09-20 14:01:23 UTC (rev 129128) @@ -1,3 +1,15 @@ +2012-09-20 Mike West mk...@google.com + +[chromium] Skip tests that will be broken by an upcoming V8 roll. +https://bugs.webkit.org/show_bug.cgi?id=97206 + +Unreviewed preemptive gardening. + +These three tests will be broken by an upcoming V8 roll. I plan on +rebaselining them along with webkit.org/b/94332. + +* platform/chromium/TestExpectations: + 2012-09-20 Csaba Osztrogonác o...@webkit.org [Qt] Enable CSS regions by default Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129127 => 129128) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-20 13:25:12 UTC (rev 129127) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-20 14:01:23 UTC (rev 129128) @@ -99,6 +99,12 @@ # TEMPORARILY SKIPPED TESTS # - +# Rolling in a V8 change that will break these tests. We'll update with the new +# test expectations along with the change that this roll will enable. +webkit.org/b/94332 http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html [ Failure Skip ] +webkit.org/b/94332 http/tests/security/contentSecurityPolicy/eval-blocked.html [ Failure Skip ] +webkit.org/b/94332 http/tests/security/contentSecurityPolicy/function-constructor-blocked.html [ Failure Skip ] + # Fails due to different window.close() rules. We need to decide whether we # ever expect to pass this. crbug.com/24189 fast/dom/open-and-close-by-DOM.html [ Failure ImageOnlyFailure Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128901] trunk/Source/WebKit/chromium
Title: [128901] trunk/Source/WebKit/chromium
Revision 128901
Author pe...@chromium.org
Date 2012-09-18 09:21:10 -0700 (Tue, 18 Sep 2012)
Log Message
Roll chromium DEPS to r157342
https://bugs.webkit.org/show_bug.cgi?id=96963
Patch by Terry Anderson tdander...@chromium.org on 2012-09-18
Reviewed by Stephen White.
Roll chromium DEPS to r157342. Also include the top-level directory
google_apis as a dependency, which was required for r157130.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (128900 => 128901)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-18 16:13:11 UTC (rev 128900)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-18 16:21:10 UTC (rev 128901)
@@ -1,3 +1,15 @@
+2012-09-18 Terry Anderson tdander...@chromium.org
+
+Roll chromium DEPS to r157342
+https://bugs.webkit.org/show_bug.cgi?id=96963
+
+Reviewed by Stephen White.
+
+Roll chromium DEPS to r157342. Also include the top-level directory
+google_apis as a dependency, which was required for r157130.
+
+* DEPS:
+
2012-09-17 Brian Anderson briander...@chromium.org
[chromium] Add rendering commit statistics
Modified: trunk/Source/WebKit/chromium/DEPS (128900 => 128901)
--- trunk/Source/WebKit/chromium/DEPS 2012-09-18 16:13:11 UTC (rev 128900)
+++ trunk/Source/WebKit/chromium/DEPS 2012-09-18 16:21:10 UTC (rev 128901)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '157063'
+ 'chromium_rev': '157342'
}
deps = {
@@ -91,6 +91,8 @@
'cc':
Var('chromium_svn')+'/cc@'+Var('chromium_rev'),
+ 'google_apis':
+Var('chromium_svn')+'/google_apis@' + Var('chromium_rev'),
'gpu':
Var('chromium_svn')+'/gpu@'+Var('chromium_rev'),
'ipc':
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128581] trunk/Tools
Title: [128581] trunk/Tools
Revision 128581
Author pe...@chromium.org
Date 2012-09-14 03:58:24 -0700 (Fri, 14 Sep 2012)
Log Message
The runtime/unsigned category should be valid in the cpp style-checker.
https://bugs.webkit.org/show_bug.cgi?id=96748
Reviewed by Csaba Osztrogonác.
This is causing the webkitpy tests to fail because it's not listed in the
category array. Furthermore, change an int to long because it's
throwing a double error in one of the earlier asserts.
* Scripts/webkitpy/style/checkers/cpp.py:
(CppChecker):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_names):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (128580 => 128581)
--- trunk/Tools/ChangeLog 2012-09-14 10:41:35 UTC (rev 128580)
+++ trunk/Tools/ChangeLog 2012-09-14 10:58:24 UTC (rev 128581)
@@ -1,3 +1,19 @@
+2012-09-14 Peter Beverloo pe...@chromium.org
+
+The runtime/unsigned category should be valid in the cpp style-checker.
+https://bugs.webkit.org/show_bug.cgi?id=96748
+
+Reviewed by Csaba Osztrogonác.
+
+This is causing the webkitpy tests to fail because it's not listed in the
+category array. Furthermore, change an int to long because it's
+throwing a double error in one of the earlier asserts.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(CppChecker):
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+(WebKitStyleTest.test_names):
+
2012-09-13 Kenneth Rohde Christiansen kenn...@webkit.org
Evas_Object* is a ref'ed structure, so tread it as such
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (128580 => 128581)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2012-09-14 10:41:35 UTC (rev 128580)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2012-09-14 10:58:24 UTC (rev 128581)
@@ -3600,6 +3600,7 @@
'runtime/sizeof',
'runtime/string',
'runtime/threadsafe_fn',
+'runtime/unsigned',
'runtime/virtual',
'whitespace/blank_line',
'whitespace/braces',
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (128580 => 128581)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2012-09-14 10:41:35 UTC (rev 128580)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2012-09-14 10:58:24 UTC (rev 128581)
@@ -4457,7 +4457,7 @@
'length_' + name_underscore_error_message)
self.assert_lint('unsigned _length;',
'_length' + name_underscore_error_message)
-self.assert_lint('unsigned int _length;',
+self.assert_lint('unsigned long _length;',
'_length' + name_underscore_error_message)
self.assert_lint('unsigned long long _length;',
'_length' + name_underscore_error_message)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128628] trunk
Title: [128628] trunk
Revision 128628
Author pe...@chromium.org
Date 2012-09-14 10:37:44 -0700 (Fri, 14 Sep 2012)
Log Message
[Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=96687
Reviewed by Tony Chang.
Android's DumpRenderTree currently supports these arguments, implemented
as part of TestShellAndroid:
http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
They're used by the layout test runner to get the STDOUT and STDERR while
a layout test run is in process, which is a safer alternative to parsing
all the logcat output manually. The implementation can be seen here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
This patch generalizes parsing of and applying the effects of these arguments
so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
After this patch, this will make it possible to pull out the output-reading
code from Android's layout test port and generalize it so it can be re-used
in the new test-runner for the other two test suites.
This has no effect when compiling and running these tests as part of Chromium
code, which has a much more advanced test-runner that does parse complete log
output, but also directly depends on code licensed under Apache 2.
Source/WebKit/chromium:
* WebKit.gypi:
* tests/ForwardIOStreamsAndroid.cpp: Added.
(WebKit):
(WebKit::maybeInitIOStreamForwardingForAndroid):
* tests/ForwardIOStreamsAndroid.h: Added.
(WebKit):
* tests/RunAllTests.cpp:
(main):
Tools:
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit):
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKitUnitTests.gyp
trunk/Source/WebKit/chromium/tests/RunAllTests.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp
trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp
Added Paths
trunk/Source/WebKit/chromium/tests/ForwardIOStreamsAndroid.cpp
trunk/Source/WebKit/chromium/tests/ForwardIOStreamsAndroid.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (128627 => 128628)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-14 17:28:11 UTC (rev 128627)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-14 17:37:44 UTC (rev 128628)
@@ -1,3 +1,38 @@
+2012-09-14 Peter Beverloo pe...@chromium.org
+
+[Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
+https://bugs.webkit.org/show_bug.cgi?id=96687
+
+Reviewed by Tony Chang.
+
+Android's DumpRenderTree currently supports these arguments, implemented
+as part of TestShellAndroid:
+http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
+
+They're used by the layout test runner to get the STDOUT and STDERR while
+a layout test run is in process, which is a safer alternative to parsing
+all the logcat output manually. The implementation can be seen here:
+http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
+
+This patch generalizes parsing of and applying the effects of these arguments
+so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
+After this patch, this will make it possible to pull out the output-reading
+code from Android's layout test port and generalize it so it can be re-used
+in the new test-runner for the other two test suites.
+
+This has no effect when compiling and running these tests as part of Chromium
+code, which has a much more advanced test-runner that does parse complete log
+output, but also directly depends on code licensed under Apache 2.
+
+* WebKit.gypi:
+* tests/ForwardIOStreamsAndroid.cpp: Added.
+(WebKit):
+(WebKit::maybeInitIOStreamForwardingForAndroid):
+* tests/ForwardIOStreamsAndroid.h: Added.
+(WebKit):
+* tests/RunAllTests.cpp:
+(main):
+
2012-09-14 Keishi Hattori kei...@webkit.org
Make time input lang attribute aware for testing
Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (128627 => 128628)
--- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-09-14 17:28:11 UTC (rev 128627)
+++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-09-14 17:37:44 UTC (rev 128628)
@@ -126,6 +126,7 @@
'type': 'shared_library',
'dependencies': [
'(chromium_src_dir)/testing/android/native_test.gyp:native_test_native_code',
+'io_stream_forwarder_a
[webkit-changes] [128632] trunk/Tools
Title: [128632] trunk/Tools
Revision 128632
Author pe...@chromium.org
Date 2012-09-14 11:26:16 -0700 (Fri, 14 Sep 2012)
Log Message
[Chromium] Build fix for DumpRenderTree following r128628
https://bugs.webkit.org/show_bug.cgi?id=96808
Reviewed by Tony Chang.
When building DumpRenderTree from the Chromium project, a compile error
shows up because including the header ForwardIOStreamsAndroid.h cannot
be located. TestWebKitAPI does this correctly.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
Diff
Modified: trunk/Tools/ChangeLog (128631 => 128632)
--- trunk/Tools/ChangeLog 2012-09-14 18:20:47 UTC (rev 128631)
+++ trunk/Tools/ChangeLog 2012-09-14 18:26:16 UTC (rev 128632)
@@ -1,3 +1,16 @@
+2012-09-14 Peter Beverloo pe...@chromium.org
+
+[Chromium] Build fix for DumpRenderTree following r128628
+https://bugs.webkit.org/show_bug.cgi?id=96808
+
+Reviewed by Tony Chang.
+
+When building DumpRenderTree from the Chromium project, a compile error
+shows up because including the header ForwardIOStreamsAndroid.h cannot
+be located. TestWebKitAPI does this correctly.
+
+* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
+
2012-09-14 Dana Jansens dan...@chromium.org
Change cc-b...@google.com watchlist to cc-b...@chromium.org
Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (128631 => 128632)
--- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-09-14 18:20:47 UTC (rev 128631)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-09-14 18:26:16 UTC (rev 128632)
@@ -292,6 +292,14 @@
'copy_TestNetscapePlugIn',
'(chromium_src_dir)/third_party/mesa/mesa.gyp:osmesa',
],
+# FIXME: Remove when the io_stream_forwarder_android target is deprecated.
+'conditions': [
+['inside_chromium_build==1', {
+'include_dirs': [
+'(source_dir)/WebKit/chromium/',
+],
+}],
+],
'copies': [{
'destination': '(PRODUCT_DIR)',
'files': [
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128164] trunk/Tools
Title: [128164] trunk/Tools
Revision 128164
Author pe...@chromium.org
Date 2012-09-11 03:10:06 -0700 (Tue, 11 Sep 2012)
Log Message
Recognize the --chromium-android argument in run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=96369
Reviewed by Jochen Eisinger.
Chromium for the Android platform cannot determine the platform based on
the host itself, so we'll use the --chromium-android argument as the build
master passes to run-webkit-tests. Make sure the layout test runner
can pick the right port when doing so.
* Scripts/run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/factory.py:
(port_options):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-tests
trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (128163 => 128164)
--- trunk/Tools/ChangeLog 2012-09-11 10:06:58 UTC (rev 128163)
+++ trunk/Tools/ChangeLog 2012-09-11 10:10:06 UTC (rev 128164)
@@ -1,3 +1,19 @@
+2012-09-11 Peter Beverloo pe...@chromium.org
+
+Recognize the --chromium-android argument in run-webkit-tests
+https://bugs.webkit.org/show_bug.cgi?id=96369
+
+Reviewed by Jochen Eisinger.
+
+Chromium for the Android platform cannot determine the platform based on
+the host itself, so we'll use the --chromium-android argument as the build
+master passes to run-webkit-tests. Make sure the layout test runner
+can pick the right port when doing so.
+
+* Scripts/run-webkit-tests:
+* Scripts/webkitpy/layout_tests/port/factory.py:
+(port_options):
+
2012-09-11 Simon Hausmann simon.hausm...@nokia.com
[QT] Fix build with newer qmake from Qt 5
Modified: trunk/Tools/Scripts/run-webkit-tests (128163 => 128164)
--- trunk/Tools/Scripts/run-webkit-tests 2012-09-11 10:06:58 UTC (rev 128163)
+++ trunk/Tools/Scripts/run-webkit-tests 2012-09-11 10:10:06 UTC (rev 128164)
@@ -112,10 +112,12 @@
push(@ARGV, --gtk);
} elsif (isEfl()) {
push(@ARGV, --efl);
+} elsif (isChromiumAndroid()) {
+push(@ARGV, --chromium-android);
} elsif (isChromium()) {
-push(@ARGV, --chromium)
+push(@ARGV, --chromium);
} elsif (isWinCairo()) {
-push(@ARGV, --wincairo)
+push(@ARGV, --wincairo);
}
my $harnessPath = File::Spec-catfile(relativeScriptsDir(), $harnessName);
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py (128163 => 128164)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py 2012-09-11 10:06:58 UTC (rev 128163)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py 2012-09-11 10:10:06 UTC (rev 128164)
@@ -46,8 +46,10 @@
help='Set the configuration to Release'),
optparse.make_option('--platform', action='',
help=help_strings.get('platform', 'Platform/Port being tested (e.g., mac-lion)')),
-optparse.make_option(--chromium, action="" const='chromium', dest='platform',
+optparse.make_option('--chromium', action='', const='chromium', dest='platform',
help='Alias for --platform=chromium'),
+optparse.make_option('--chromium-android', action='', const='chromium-android', dest='platform',
+help='Alias for --platform=chromium-android'),
optparse.make_option('--efl', action='', const='efl', dest=platform,
help='Alias for --platform=efl'),
optparse.make_option('--gtk', action='', const='gtk', dest=platform,
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py (128163 => 128164)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py 2012-09-11 10:06:58 UTC (rev 128163)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py 2012-09-11 10:10:06 UTC (rev 128164)
@@ -31,6 +31,7 @@
from webkitpy.tool.mocktool import MockOptions
from webkitpy.common.system.systemhost_mock import MockSystemHost
+from webkitpy.layout_tests.port import chromium_android
from webkitpy.layout_tests.port import chromium_linux
from webkitpy.layout_tests.port import chromium_mac
from webkitpy.layout_tests.port import chromium_win
@@ -85,6 +86,11 @@
self.assert_port(port_name='chromium', os_name='linux', os_version='lucid',
cls=chromium_linux.ChromiumLinuxPort)
+def test_chromium_android(self):
+self.assert_port(port_name='chromium-android', cls=chromium_android.ChromiumAndroidPort)
+# NOTE: We can't check for port_name=chromium here, as this will append the host's
+# operating system, whereas host!=target for Android.
+
def test_chromium_win(self):
self.assert_port(port_name='chromium-win-xp', cls=chromium_win.ChromiumWinPort)
self.assert_port(port_name='chromium-win', os_name='win', os_version='xp',
___
webkit-changes mailing list
webkit-changes
[webkit-changes] [128168] trunk/Source/WebKit/chromium
Title: [128168] trunk/Source/WebKit/chromium
Revision 128168
Author pe...@chromium.org
Date 2012-09-11 03:50:48 -0700 (Tue, 11 Sep 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (128167 => 128168)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-11 10:34:22 UTC (rev 128167)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-11 10:50:48 UTC (rev 128168)
@@ -1,3 +1,9 @@
+2012-09-11 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-09-11 Keishi Hattori kei...@webkit.org
Create Localizer factory method for LocaleMac
Modified: trunk/Source/WebKit/chromium/DEPS (128167 => 128168)
--- trunk/Source/WebKit/chromium/DEPS 2012-09-11 10:34:22 UTC (rev 128167)
+++ trunk/Source/WebKit/chromium/DEPS 2012-09-11 10:50:48 UTC (rev 128168)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '155215'
+ 'chromium_rev': '155883'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128170] trunk/Tools
Title: [128170] trunk/Tools Revision 128170 Author pe...@chromium.org Date 2012-09-11 04:26:26 -0700 (Tue, 11 Sep 2012) Log Message Don't ignore .pak files when making an archive for Android https://bugs.webkit.org/show_bug.cgi?id=96375 Reviewed by Jochen Eisinger. The .pak files do need to be pushed to the device, which is currently preventing the layout test runner from correctly pushing all files. * BuildSlaveSupport/built-product-archive: (archiveBuiltProduct): Modified Paths trunk/Tools/BuildSlaveSupport/built-product-archive trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (128169 => 128170) --- trunk/Tools/BuildSlaveSupport/built-product-archive 2012-09-11 11:21:52 UTC (rev 128169) +++ trunk/Tools/BuildSlaveSupport/built-product-archive 2012-09-11 11:26:26 UTC (rev 128170) @@ -169,7 +169,7 @@ 'BuildLog.htm', '*.obj', '*.pdb', '*.pch', '*.tlog', '*.lastbuildstate'] if fullPlatform and fullPlatform == 'chromium-android': -ignorePatterns.extend(['*.so', '*.pak', '*-unaligned.apk']) +ignorePatterns.extend(['*.so', '*-unaligned.apk']) removeDirectoryIfExists(thinDirectory) copyBuildFiles(configurationBuildDirectory, thinDirectory, ignorePatterns) Modified: trunk/Tools/ChangeLog (128169 => 128170) --- trunk/Tools/ChangeLog 2012-09-11 11:21:52 UTC (rev 128169) +++ trunk/Tools/ChangeLog 2012-09-11 11:26:26 UTC (rev 128170) @@ -1,3 +1,16 @@ +2012-09-11 Peter Beverloo pe...@chromium.org + +Don't ignore .pak files when making an archive for Android +https://bugs.webkit.org/show_bug.cgi?id=96375 + +Reviewed by Jochen Eisinger. + +The .pak files do need to be pushed to the device, which is currently +preventing the layout test runner from correctly pushing all files. + +* BuildSlaveSupport/built-product-archive: +(archiveBuiltProduct): + 2012-09-11 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128194] trunk/Tools
Title: [128194] trunk/Tools
Revision 128194
Author pe...@chromium.org
Date 2012-09-11 09:40:47 -0700 (Tue, 11 Sep 2012)
Log Message
Make sure that md5sum is not setup on non-Chromium Android platforms.
https://bugs.webkit.org/show_bug.cgi?id=96393
Patch by Philippe Liard pli...@google.com on 2012-09-11
Reviewed by Adam Barth.
Previously md5sum was setup in ChromiumAndroidDriver's constructor
which is also invoked on non-Chromium Android platforms. The following patch
moves this logic to _startup_test() which is guaranteed to be invoked
only on Android.
This also updates the prompt unit test in chromium_android_unittest.py.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
(ChromiumAndroidDriver._setup_test):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (128193 => 128194)
--- trunk/Tools/ChangeLog 2012-09-11 16:08:22 UTC (rev 128193)
+++ trunk/Tools/ChangeLog 2012-09-11 16:40:47 UTC (rev 128194)
@@ -1,3 +1,22 @@
+2012-09-11 Philippe Liard pli...@google.com
+
+Make sure that md5sum is not setup on non-Chromium Android platforms.
+https://bugs.webkit.org/show_bug.cgi?id=96393
+
+Reviewed by Adam Barth.
+
+Previously md5sum was setup in ChromiumAndroidDriver's constructor
+which is also invoked on non-Chromium Android platforms. The following patch
+moves this logic to _startup_test() which is guaranteed to be invoked
+only on Android.
+
+This also updates the prompt unit test in chromium_android_unittest.py.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidDriver.__init__):
+(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
+(ChromiumAndroidDriver._setup_test):
+
2012-09-11 Raphael Kubo da Costa rak...@webkit.org
[EFL] Rewrite the EFL-related Find modules
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (128193 => 128194)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-09-11 16:08:22 UTC (rev 128193)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-09-11 16:40:47 UTC (rev 128194)
@@ -309,8 +309,6 @@
class ChromiumAndroidDriver(driver.Driver):
-_data_already_pushed_for_worker = sets.Set()
-
def __init__(self, port, worker_number, pixel_tests, no_timeout=False):
super(ChromiumAndroidDriver, self).__init__(port, worker_number, pixel_tests, no_timeout)
self._cmd_line = None
@@ -324,30 +322,28 @@
self._original_governors = {}
self._device_serial = port._get_device_serial(worker_number)
self._adb_command = ['adb', '-s', self._device_serial]
-self._setup_md5sum()
-if not worker_number in ChromiumAndroidDriver._data_already_pushed_for_worker:
-self._push_executable()
-self._push_fonts()
-self._push_test_resources()
-ChromiumAndroidDriver._data_already_pushed_for_worker.add(worker_number)
def __del__(self):
self._teardown_performance()
super(ChromiumAndroidDriver, self).__del__()
-def _setup_md5sum(self):
+def _setup_md5sum_and_push_data_if_needed(self):
self._md5sum_path = self._port._build_path_with_configuration(self._port.get_option('configuration'), MD5SUM_DEVICE_FILE_NAME)
assert os.path.exists(self._md5sum_path)
-if self._file_exists_on_device(MD5SUM_DEVICE_PATH):
-return
-if not self._push_to_device(self._md5sum_path, MD5SUM_DEVICE_PATH):
-_log.error('Could not push md5sum to device')
+if not self._file_exists_on_device(MD5SUM_DEVICE_PATH):
+if not self._push_to_device(self._md5sum_path, MD5SUM_DEVICE_PATH):
+_log.error('Could not push md5sum to device')
+self._push_executable()
+self._push_fonts()
+self._push_test_resources()
+
def _setup_test(self):
if self._has_setup:
return
+self._setup_md5sum_and_push_data_if_needed()
self._has_setup = True
self._run_adb_command(['root'])
self._setup_performance()
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py (128193 => 128194)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py 2012-09-11 16:08:22 UTC (rev 128193)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py 2012-09-11 16:40:47 UTC (rev 128194)
@@ -240,7 +240,7 @@
self.driver._server_process = driver_unittest.MockServerProcess(lines=['root@android:/ # '])
self.assertEquals(self.driver._read_prompt(time.time() + 1), None)
[webkit-changes] [127847] trunk/Tools
Title: [127847] trunk/Tools
Revision 127847
Author pe...@chromium.org
Date 2012-09-07 02:20:07 -0700 (Fri, 07 Sep 2012)
Log Message
Introduce the Chromium Android Release (Tests) bot
https://bugs.webkit.org/show_bug.cgi?id=95980
Reviewed by Adam Barth.
This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
which will be running layout tests on actual Android devices. Right now,
four Galaxy Nexus phones are attached.
* BuildSlaveSupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (127846 => 127847)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-09-07 08:58:36 UTC (rev 127846)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-09-07 09:20:07 UTC (rev 127847)
@@ -291,6 +291,11 @@
slavenames: [google-linux-android]
},
{
+ name: Chromium Android Release (Tests), type: Test, builddir: chromium-android-release-tests,
+ platform: chromium-android, configuration: release, architectures: [i386],
+ slavenames: [google-android-tests]
+},
+{
name: WinCairo Release, type: BuildAndTest, builddir: win-cairo-release,
platform: wincairo, configuration: release, architectures: [i386],
slavenames: [wincairo-1]
@@ -398,6 +403,9 @@
{ type: Triggerable, name: chromium-linux-perf-tests,
builderNames: [Chromium Linux Release (Perf)]
},
+{ type: Triggerable, name: chromium-android-release-tests,
+ builderNames: [Chromium Android Release (Tests)]
+},
{ type: Triggerable, name: gtk-linux-64-release-tests-wk2,
builderNames: [GTK Linux 64-bit Release WK2 (Tests)]
}
Modified: trunk/Tools/ChangeLog (127846 => 127847)
--- trunk/Tools/ChangeLog 2012-09-07 08:58:36 UTC (rev 127846)
+++ trunk/Tools/ChangeLog 2012-09-07 09:20:07 UTC (rev 127847)
@@ -1,3 +1,16 @@
+2012-09-06 Peter Beverloo pe...@chromium.org
+
+Introduce the Chromium Android Release (Tests) bot
+https://bugs.webkit.org/show_bug.cgi?id=95980
+
+Reviewed by Adam Barth.
+
+This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
+which will be running layout tests on actual Android devices. Right now,
+four Galaxy Nexus phones are attached.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
2012-09-06 James Robinson jam...@chromium.org
[chromium] Use WebCompositorSupport functions instead of WebCompositor statics
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127875] trunk/Tools
Title: [127875] trunk/Tools
Revision 127875
Author pe...@chromium.org
Date 2012-09-07 09:06:23 -0700 (Fri, 07 Sep 2012)
Log Message
Add the google-android-tests build slave to the master's config
https://bugs.webkit.org/show_bug.cgi?id=96113
Reviewed by Csaba Osztrogonác.
* BuildSlaveSupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (127874 => 127875)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-09-07 16:05:12 UTC (rev 127874)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-09-07 16:06:23 UTC (rev 127875)
@@ -65,6 +65,7 @@
{ name: google-linux-2, platform: chromium-linux },
{ name: google-linux-perf, platform: chromium-linux },
{ name: google-linux-android, platform: chromium-android },
+{ name: google-android-tests, platform: chromium-android },
{ name: wincairo-1, platform: wincairo },
Modified: trunk/Tools/ChangeLog (127874 => 127875)
--- trunk/Tools/ChangeLog 2012-09-07 16:05:12 UTC (rev 127874)
+++ trunk/Tools/ChangeLog 2012-09-07 16:06:23 UTC (rev 127875)
@@ -1,3 +1,12 @@
+2012-09-07 Peter Beverloo pe...@chromium.org
+
+Add the google-android-tests build slave to the master's config
+https://bugs.webkit.org/show_bug.cgi?id=96113
+
+Reviewed by Csaba Osztrogonác.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
2012-09-07 Sudarsana Nagineni sudarsana.nagin...@linux.intel.com
[WK2] [EFL] Set theme for WebKit2 API test runner
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127895] trunk/Tools
Title: [127895] trunk/Tools
Revision 127895
Author pe...@chromium.org
Date 2012-09-07 11:17:37 -0700 (Fri, 07 Sep 2012)
Log Message
Actually trigger the Android Tester
https://bugs.webkit.org/show_bug.cgi?id=96118
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (127894 => 127895)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-09-07 18:11:17 UTC (rev 127894)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-09-07 18:17:37 UTC (rev 127895)
@@ -289,7 +289,7 @@
{
name: Chromium Android Release, type: Build, builddir: chromium-linux-android,
platform: chromium-android, configuration: release, architectures: [i386],
- slavenames: [google-linux-android]
+ triggers: [chromium-android-release-tests], slavenames: [google-linux-android]
},
{
name: Chromium Android Release (Tests), type: Test, builddir: chromium-android-release-tests,
Modified: trunk/Tools/ChangeLog (127894 => 127895)
--- trunk/Tools/ChangeLog 2012-09-07 18:11:17 UTC (rev 127894)
+++ trunk/Tools/ChangeLog 2012-09-07 18:17:37 UTC (rev 127895)
@@ -1,3 +1,12 @@
+2012-09-07 Peter Beverloo pe...@chromium.org
+
+Actually trigger the Android Tester
+https://bugs.webkit.org/show_bug.cgi?id=96118
+
+Reviewed by Adam Barth.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
2012-09-07 Dominic Mazzoni dmazz...@google.com
New time input needs accessibility
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127714] trunk/Source/WebKit/chromium
Title: [127714] trunk/Source/WebKit/chromium Revision 127714 Author pe...@chromium.org Date 2012-09-06 02:46:42 -0700 (Thu, 06 Sep 2012) Log Message [Chromium] Chromium Mac build fix after revision r127711 https://bugs.webkit.org/show_bug.cgi?id=95958 Unreviewed build fix. This is a clear typo in the source file, so changing the function to call locationModifiersFromWindowsKeyCode instead. * src/mac/WebInputEventFactory.mm: (WebKit::WebInputEventFactory::keyboardEvent): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (127713 => 127714) --- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:42:09 UTC (rev 127713) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:46:42 UTC (rev 127714) @@ -1,3 +1,16 @@ +2012-09-06 Peter Beverloo pe...@chromium.org + +[Chromium] Chromium Mac build fix after revision r127711 +https://bugs.webkit.org/show_bug.cgi?id=95958 + +Unreviewed build fix. + +This is a clear typo in the source file, so changing the function to +call locationModifiersFromWindowsKeyCode instead. + +* src/mac/WebInputEventFactory.mm: +(WebKit::WebInputEventFactory::keyboardEvent): + 2012-09-06 Raymes Khoury ray...@chromium.org Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents Modified: trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm (127713 => 127714) --- trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm 2012-09-06 09:42:09 UTC (rev 127713) +++ trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm 2012-09-06 09:46:42 UTC (rev 127714) @@ -608,7 +608,7 @@ int windowsKeyCode = windowsKeyCodeForKeyEvent(event); result.windowsKeyCode = WebKeyboardEvent::windowsKeyCodeWithoutLocation(windowsKeyCode); -result.modifiers |= WebKeyboardEvent::locationModifiersFromKeyCode(windowsKeyCode); +result.modifiers |= WebKeyboardEvent::locationModifiersFromWindowsKeyCode(windowsKeyCode); result.nativeKeyCode = [event keyCode]; NSString* textStr = textFromEvent(event); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127717] trunk/Source/WebKit/chromium
Title: [127717] trunk/Source/WebKit/chromium
Revision 127717
Author pe...@chromium.org
Date 2012-09-06 02:54:50 -0700 (Thu, 06 Sep 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127716 => 127717)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:52:27 UTC (rev 127716)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-06 09:54:50 UTC (rev 127717)
@@ -1,3 +1,9 @@
+2012-09-06 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-09-06 Dana Jansens dan...@chromium.org
[chromium] Add a copy() method to CCRenderPass
Modified: trunk/Source/WebKit/chromium/DEPS (127716 => 127717)
--- trunk/Source/WebKit/chromium/DEPS 2012-09-06 09:52:27 UTC (rev 127716)
+++ trunk/Source/WebKit/chromium/DEPS 2012-09-06 09:54:50 UTC (rev 127717)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '154695'
+ 'chromium_rev': '155144'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127590] trunk/Source/WebKit/chromium
Title: [127590] trunk/Source/WebKit/chromium
Revision 127590
Author pe...@chromium.org
Date 2012-09-05 07:23:54 -0700 (Wed, 05 Sep 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127589 => 127590)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-05 14:18:14 UTC (rev 127589)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-05 14:23:54 UTC (rev 127590)
@@ -1,3 +1,9 @@
+2012-09-05 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-09-04 Ilya Tikhonovsky loi...@chromium.org
Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers.
Modified: trunk/Source/WebKit/chromium/DEPS (127589 => 127590)
--- trunk/Source/WebKit/chromium/DEPS 2012-09-05 14:18:14 UTC (rev 127589)
+++ trunk/Source/WebKit/chromium/DEPS 2012-09-05 14:23:54 UTC (rev 127590)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '154695'
+ 'chromium_rev': '154940'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127591] trunk/Source/WebKit/chromium
Title: [127591] trunk/Source/WebKit/chromium
Revision 127591
Author pe...@chromium.org
Date 2012-09-05 07:36:47 -0700 (Wed, 05 Sep 2012)
Log Message
Unreviewed, rolling out r127590.
http://trac.webkit.org/changeset/127590
Broke the Chromium bots because of a compile error in the compositor.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127590 => 127591)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-05 14:23:54 UTC (rev 127590)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-05 14:36:47 UTC (rev 127591)
@@ -1,5 +1,14 @@
2012-09-05 Peter Beverloo pe...@chromium.org
+Unreviewed, rolling out r127590.
+http://trac.webkit.org/changeset/127590
+
+Broke the Chromium bots because of a compile error in the compositor.
+
+* DEPS:
+
+2012-09-05 Peter Beverloo pe...@chromium.org
+
Unreviewed. Rolled DEPS.
* DEPS:
Modified: trunk/Source/WebKit/chromium/DEPS (127590 => 127591)
--- trunk/Source/WebKit/chromium/DEPS 2012-09-05 14:23:54 UTC (rev 127590)
+++ trunk/Source/WebKit/chromium/DEPS 2012-09-05 14:36:47 UTC (rev 127591)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '154940'
+ 'chromium_rev': '154695'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127471] trunk/Source/WebCore
Title: [127471] trunk/Source/WebCore Revision 127471 Author pe...@chromium.org Date 2012-09-04 09:50:47 -0700 (Tue, 04 Sep 2012) Log Message [chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium https://bugs.webkit.org/show_bug.cgi?id=95744 Patch by Koji Ishii kojii...@gmail.com on 2012-09-04 Unreviewed build fix, verified by Scott Graham. The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant because '/opentype/' was already included to webcore_remaining. It was not only redundant but also breaks incremental linking. No new tests are required because no behavior changes. Patch by Koji Ishii kojii...@gmail.com on 2012-09-04 * WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gyp/WebCore.gyp Diff Modified: trunk/Source/WebCore/ChangeLog (127470 => 127471) --- trunk/Source/WebCore/ChangeLog 2012-09-04 15:47:25 UTC (rev 127470) +++ trunk/Source/WebCore/ChangeLog 2012-09-04 16:50:47 UTC (rev 127471) @@ -1,3 +1,19 @@ +2012-09-04 Koji Ishii kojii...@gmail.com + +[chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium +https://bugs.webkit.org/show_bug.cgi?id=95744 + +Patch by Koji Ishii kojii...@gmail.com on 2012-09-04 +Unreviewed build fix, verified by Scott Graham. + +The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant +because '/opentype/' was already included to webcore_remaining. +It was not only redundant but also breaks incremental linking. + +No new tests are required because no behavior changes. + +* WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform. + 2012-09-04 Otto Derek Cheung otche...@rim.com [BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (127470 => 127471) --- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-09-04 15:47:25 UTC (rev 127470) +++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-09-04 16:50:47 UTC (rev 127471) @@ -1843,10 +1843,6 @@ 'sources/': [ ['exclude', 'Posix\\.cpp$'], -['include', 'platform/graphics/opentype/OpenTypeTypes\\.h$'], -['include', 'platform/graphics/opentype/OpenTypeVerticalData\\.cpp$'], -['include', 'platform/graphics/opentype/OpenTypeVerticalData\\.h$'], - # The Chromium Win currently uses GlyphPageTreeNodeChromiumWin.cpp from # platform/graphics/chromium, included by regex above, instead. ['exclude', 'platform/graphics/skia/FontCacheSkia\\.cpp$'], ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127428] trunk/Source/WebKit/chromium
Title: [127428] trunk/Source/WebKit/chromium
Revision 127428
Author pe...@chromium.org
Date 2012-09-03 09:50:49 -0700 (Mon, 03 Sep 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127427 => 127428)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-03 16:34:08 UTC (rev 127427)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-03 16:50:49 UTC (rev 127428)
@@ -1,3 +1,9 @@
+2012-09-03 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-09-03 Tommy Widenflycht tom...@google.com
MediaStream API: Add Ice-related functionality to RTCPeerConnection
Modified: trunk/Source/WebKit/chromium/DEPS (127427 => 127428)
--- trunk/Source/WebKit/chromium/DEPS 2012-09-03 16:34:08 UTC (rev 127427)
+++ trunk/Source/WebKit/chromium/DEPS 2012-09-03 16:50:49 UTC (rev 127428)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '154424'
+ 'chromium_rev': '154695'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [126980] trunk/Source/WebKit/chromium
Title: [126980] trunk/Source/WebKit/chromium
Revision 126980
Author pe...@chromium.org
Date 2012-08-29 03:46:24 -0700 (Wed, 29 Aug 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (126979 => 126980)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-29 10:31:25 UTC (rev 126979)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-29 10:46:24 UTC (rev 126980)
@@ -1,3 +1,9 @@
+2012-08-29 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-08-29 Dominic Mazzoni dmazz...@google.com
AX: Canvas should have a distinct role
Modified: trunk/Source/WebKit/chromium/DEPS (126979 => 126980)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-29 10:31:25 UTC (rev 126979)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-29 10:46:24 UTC (rev 126980)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '153466'
+ 'chromium_rev': '153869'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [126424] trunk/Source/WebKit/chromium
Title: [126424] trunk/Source/WebKit/chromium
Revision 126424
Author pe...@chromium.org
Date 2012-08-23 07:55:28 -0700 (Thu, 23 Aug 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (126423 => 126424)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-23 13:33:55 UTC (rev 126423)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-23 14:55:28 UTC (rev 126424)
@@ -1,3 +1,9 @@
+2012-08-23 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-08-22 Alec Flett alecfl...@chromium.org
IndexedDB: tests for injection/extraction of idb keys
Modified: trunk/Source/WebKit/chromium/DEPS (126423 => 126424)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-23 13:33:55 UTC (rev 126423)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-23 14:55:28 UTC (rev 126424)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '152728'
+ 'chromium_rev': '152985'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [126148] trunk/Source/WebKit/chromium
Title: [126148] trunk/Source/WebKit/chromium
Revision 126148
Author pe...@chromium.org
Date 2012-08-21 02:49:38 -0700 (Tue, 21 Aug 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (126147 => 126148)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-21 08:54:32 UTC (rev 126147)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-21 09:49:38 UTC (rev 126148)
@@ -1,3 +1,9 @@
+2012-08-21 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-08-20 Kent Tamura tk...@chromium.org
[Chromium-win] Use native digits in parsing/formatting dates in the textfield part of input[type=date]
Modified: trunk/Source/WebKit/chromium/DEPS (126147 => 126148)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-21 08:54:32 UTC (rev 126147)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-21 09:49:38 UTC (rev 126148)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '152373'
+ 'chromium_rev': '152525'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125904] trunk/Source/WebKit/chromium
Title: [125904] trunk/Source/WebKit/chromium
Revision 125904
Author pe...@chromium.org
Date 2012-08-17 08:23:35 -0700 (Fri, 17 Aug 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125903 => 125904)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-17 15:22:35 UTC (rev 125903)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-17 15:23:35 UTC (rev 125904)
@@ -1,3 +1,9 @@
+2012-08-17 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-08-17 Pavel Feldman pfeld...@chromium.org
Web Inspector: load panels code on demand
Modified: trunk/Source/WebKit/chromium/DEPS (125903 => 125904)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-17 15:22:35 UTC (rev 125903)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-17 15:23:35 UTC (rev 125904)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '151892'
+ 'chromium_rev': '152079'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125780] trunk/Source/WebKit/chromium
Title: [125780] trunk/Source/WebKit/chromium
Revision 125780
Author pe...@chromium.org
Date 2012-08-16 08:23:25 -0700 (Thu, 16 Aug 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125779 => 125780)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-16 14:58:17 UTC (rev 125779)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-16 15:23:25 UTC (rev 125780)
@@ -1,3 +1,9 @@
+2012-08-16 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-08-16 Keishi Hattori kei...@webkit.org
DOMWindowPagePopup needs to be installed before loading the html inside the page popup
Modified: trunk/Source/WebKit/chromium/DEPS (125779 => 125780)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-16 14:58:17 UTC (rev 125779)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-16 15:23:25 UTC (rev 125780)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '151836'
+ 'chromium_rev': '151892'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125792] trunk
Title: [125792] trunk Revision 125792 Author pe...@chromium.org Date 2012-08-16 10:45:15 -0700 (Thu, 16 Aug 2012) Log Message [Chromium] Pass the --strip-binary argument to the apk test generator https://bugs.webkit.org/show_bug.cgi?id=94224 Reviewed by Adam Barth. The native test generator currently relies on the $STRIP environment variable to be available, which it shouldn't do. Instead, pass it as an argument to the script. The $STRIP variable is being deprecated. Source/WebKit/chromium: * WebKitUnitTests.gyp: Tools: * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKitUnitTests.gyp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (125791 => 125792) --- trunk/Source/WebKit/chromium/ChangeLog 2012-08-16 17:33:29 UTC (rev 125791) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-16 17:45:15 UTC (rev 125792) @@ -1,3 +1,16 @@ +2012-08-16 Peter Beverloo pe...@chromium.org + +[Chromium] Pass the --strip-binary argument to the apk test generator +https://bugs.webkit.org/show_bug.cgi?id=94224 + +Reviewed by Adam Barth. + +The native test generator currently relies on the $STRIP environment +variable to be available, which it shouldn't do. Instead, pass it as an +argument to the script. The $STRIP variable is being deprecated. + +* WebKitUnitTests.gyp: + 2012-08-16 James Robinson jam...@chromium.org [chromium] Remove alwaysReserveTextures code - it doesn't do anything Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (125791 => 125792) --- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-16 17:33:29 UTC (rev 125791) +++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-16 17:45:15 UTC (rev 125792) @@ -178,6 +178,7 @@ '@(input_jars_paths)', '--output', '(PRODUCT_DIR)/webkit_unit_tests_apk', +'--strip-binary=(android_strip)', '--ant-args', '-DANDROID_SDK=(android_sdk)', '--ant-args', Modified: trunk/Tools/ChangeLog (125791 => 125792) --- trunk/Tools/ChangeLog 2012-08-16 17:33:29 UTC (rev 125791) +++ trunk/Tools/ChangeLog 2012-08-16 17:45:15 UTC (rev 125792) @@ -1,3 +1,17 @@ +2012-08-16 Peter Beverloo pe...@chromium.org + +[Chromium] Pass the --strip-binary argument to the apk test generator +https://bugs.webkit.org/show_bug.cgi?id=94224 + +Reviewed by Adam Barth. + +The native test generator currently relies on the $STRIP environment +variable to be available, which it shouldn't do. Instead, pass it as an +argument to the script. The $STRIP variable is being deprecated. + +* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: +* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: + 2012-08-16 Xiaobo Wang xbw...@torchmobile.com.cn [BlackBerry] Update format of JS console message to keep consistent with other ports. Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (125791 => 125792) --- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-08-16 17:33:29 UTC (rev 125791) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-08-16 17:45:15 UTC (rev 125792) @@ -495,6 +495,7 @@ '@(input_jars_paths)', '--output', '(PRODUCT_DIR)/DumpRenderTree_apk', +'--strip-binary=(android_strip)', '--ant-args', '-DANDROID_SDK=(android_sdk)', '--ant-args', Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp (125791 => 125792) --- trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp 2012-08-16 17:33:29 UTC (rev 125791) +++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp 2012-08-16 17:45:15 UTC (rev 125792) @@ -138,6 +138,7 @@ '@(input_jars_paths)', '--output', '(PRODUCT_DIR)/TestWebKitAPI_apk', +'--strip-binary=(android_strip)', '--ant-args', '-DANDROID_SDK=(android_sdk)', '--ant-args', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125665] trunk/Source/WebKit/chromium
Title: [125665] trunk/Source/WebKit/chromium
Revision 125665
Author pe...@chromium.org
Date 2012-08-15 04:02:00 -0700 (Wed, 15 Aug 2012)
Log Message
[Chromium] Roll WebKit Chromium DEPS to r151672
https://bugs.webkit.org/show_bug.cgi?id=94091
Unreviewed DEPS roll.
This also adds the new dependency on third_party/skia/gyp/, as was
introduced in Chromium's revision 151463.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125664 => 125665)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-15 10:45:51 UTC (rev 125664)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-15 11:02:00 UTC (rev 125665)
@@ -1,3 +1,15 @@
+2012-08-15 Peter Beverloo pe...@chromium.org
+
+[Chromium] Roll WebKit Chromium DEPS to r151672
+https://bugs.webkit.org/show_bug.cgi?id=94091
+
+Unreviewed DEPS roll.
+
+This also adds the new dependency on third_party/skia/gyp/, as was
+introduced in Chromium's revision 151463.
+
+* DEPS:
+
2012-08-14 Keishi Hattori kei...@webkit.org
Share common code between calendar picker and color suggestion picker
Modified: trunk/Source/WebKit/chromium/DEPS (125664 => 125665)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-15 10:45:51 UTC (rev 125664)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-15 11:02:00 UTC (rev 125665)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '151462'
+ 'chromium_rev': '151672'
}
deps = {
@@ -58,6 +58,8 @@
From('chromium_deps', 'src/third_party/skia/src'),
'third_party/skia/include':
From('chromium_deps', 'src/third_party/skia/include'),
+ 'third_party/skia/gyp':
+From('chromium_deps', 'src/third_party/skia/gyp'),
# testing
'testing':
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125683] trunk/Tools
Title: [125683] trunk/Tools Revision 125683 Author pe...@chromium.org Date 2012-08-15 10:59:08 -0700 (Wed, 15 Aug 2012) Log Message Fix a warning in TestWebKitAPI's MediaTime test-suite https://bugs.webkit.org/show_bug.cgi?id=94096 Reviewed by Adam Barth. This warning is visible when building the file with certain GCC versions, including the one used by Chromium for Android. The warning is visible in the cr-android build bot output: MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90 * TestWebKitAPI/Tests/WTF/MediaTime.cpp: (TestWebKitAPI::TEST): Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp Diff Modified: trunk/Tools/ChangeLog (125682 => 125683) --- trunk/Tools/ChangeLog 2012-08-15 16:58:02 UTC (rev 125682) +++ trunk/Tools/ChangeLog 2012-08-15 17:59:08 UTC (rev 125683) @@ -1,3 +1,19 @@ +2012-08-15 Peter Beverloo pe...@chromium.org + +Fix a warning in TestWebKitAPI's MediaTime test-suite +https://bugs.webkit.org/show_bug.cgi?id=94096 + +Reviewed by Adam Barth. + +This warning is visible when building the file with certain GCC versions, +including the one used by Chromium for Android. The warning is visible in +the cr-android build bot output: + +MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90 + +* TestWebKitAPI/Tests/WTF/MediaTime.cpp: +(TestWebKitAPI::TEST): + 2012-08-15 Kevin Funk kevin.f...@kdab.com Fix the 'git log' call in VCSUtils.pm for Windows Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp (125682 => 125683) --- trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp 2012-08-15 16:58:02 UTC (rev 125682) +++ trunk/Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp 2012-08-15 17:59:08 UTC (rev 125683) @@ -149,7 +149,7 @@ EXPECT_EQ(MediaTime(3, 2).toDouble(), 1.5); EXPECT_EQ(MediaTime(1, 1 16).toFloat(), 1 / pow(2.0f, 16.0f)); EXPECT_EQ(MediaTime(1, 1 30).toDouble(), 1 / pow(2.0, 30.0)); -EXPECT_EQ(MediaTime::createWithDouble(M_PI, 1 30), MediaTime(3373259426, 1 30)); +EXPECT_EQ(MediaTime::createWithDouble(M_PI, 1 30), MediaTime(3373259426U, 1 30)); EXPECT_EQ(MediaTime::createWithFloat(INFINITY), MediaTime::positiveInfiniteTime()); EXPECT_EQ(MediaTime::createWithFloat(-INFINITY), MediaTime::negativeInfiniteTime()); EXPECT_EQ(MediaTime::createWithFloat(NAN), MediaTime::invalidTime()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125538] trunk
Title: [125538] trunk
Revision 125538
Author pe...@chromium.org
Date 2012-08-14 04:02:21 -0700 (Tue, 14 Aug 2012)
Log Message
[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841
Unreviewed build fix.
APK generation was broken as the configuration file assumed compilation
would only occur in the Chromium tree. Pass the path to Chromium's source
base directory as a property to ant.
Source/WebKit/chromium:
* WebKitUnitTests.gyp:
Tools:
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKitUnitTests.gyp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125537 => 125538)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-14 10:24:07 UTC (rev 125537)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-14 11:02:21 UTC (rev 125538)
@@ -1,3 +1,16 @@
+2012-08-14 Peter Beverloo pe...@chromium.org
+
+[Chromium] Fix apk generation for the Android platform
+https://bugs.webkit.org/show_bug.cgi?id=93841
+
+Unreviewed build fix.
+
+APK generation was broken as the configuration file assumed compilation
+would only occur in the Chromium tree. Pass the path to Chromium's source
+base directory as a property to ant.
+
+* WebKitUnitTests.gyp:
+
2012-08-13 Tom Sepez tse...@chromium.org
[chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (125537 => 125538)
--- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-14 10:24:07 UTC (rev 125537)
+++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-14 11:02:21 UTC (rev 125538)
@@ -147,6 +147,13 @@
'input_jars_paths': [
'(PRODUCT_DIR)/lib.java/chromium_base.jar',
],
+'conditions': [
+['inside_chromium_build==1', {
+'ant_build_to_chromium_src': '(ant_build_out)/../../',
+}, {
+'ant_build_to_chromium_src': '(chromium_src_dir)',
+}],
+],
},
# Part of the following was copied from (chromium_src_dir)/build/apk_test.gpyi.
# Not including it because gyp include doesn't support variable in path or under
@@ -183,6 +190,8 @@
'-DANDROID_TOOLCHAIN=(android_toolchain)',
'--ant-args',
'-DPRODUCT_DIR=(ant_build_out)',
+'--ant-args',
+'-DCHROMIUM_SRC=(ant_build_to_chromium_src)',
'--sdk-build=(sdk_build)',
'--app_abi',
'(android_app_abi)',
Modified: trunk/Tools/ChangeLog (125537 => 125538)
--- trunk/Tools/ChangeLog 2012-08-14 10:24:07 UTC (rev 125537)
+++ trunk/Tools/ChangeLog 2012-08-14 11:02:21 UTC (rev 125538)
@@ -1,3 +1,17 @@
+2012-08-14 Peter Beverloo pe...@chromium.org
+
+[Chromium] Fix apk generation for the Android platform
+https://bugs.webkit.org/show_bug.cgi?id=93841
+
+Unreviewed build fix.
+
+APK generation was broken as the configuration file assumed compilation
+would only occur in the Chromium tree. Pass the path to Chromium's source
+base directory as a property to ant.
+
+* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
+* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
+
2012-08-14 Sergio Villar Senin svil...@igalia.com
[GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails next test
Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (125537 => 125538)
--- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-08-14 10:24:07 UTC (rev 125537)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-08-14 11:02:21 UTC (rev 125538)
@@ -464,6 +464,13 @@
'(PRODUCT_DIR)/lib.java/chromium_net.jar',
'(PRODUCT_DIR)/lib.java/chromium_media.jar',
],
+'conditions': [
+['inside_chromium_build==1', {
+'ant_build_to_chromium_src': '(ant_build_out)/../../',
+}, {
+'ant_build_to_chromium_src': '(chromium_src_dir)',
+}],
+],
},
# Part of the following was copied from (chromium_src_dir)/build/apk_test.gpyi.
# N
[webkit-changes] [125542] trunk/Source/WebKit/chromium
Title: [125542] trunk/Source/WebKit/chromium
Revision 125542
Author pe...@chromium.org
Date 2012-08-14 04:32:46 -0700 (Tue, 14 Aug 2012)
Log Message
[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841
Unreviewed build fix (step 2).
The path from webkit_unit_tests isn't robust enough. Use the same
convention as the Chromium side, i.e. walk up from the ant_build_out path.
One-line Android-only gyp change.
* WebKitUnitTests.gyp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKitUnitTests.gyp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125541 => 125542)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-14 11:28:25 UTC (rev 125541)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-14 11:32:46 UTC (rev 125542)
@@ -3,6 +3,19 @@
[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841
+Unreviewed build fix (step 2).
+
+The path from webkit_unit_tests isn't robust enough. Use the same
+convention as the Chromium side, i.e. walk up from the ant_build_out path.
+One-line Android-only gyp change.
+
+* WebKitUnitTests.gyp:
+
+2012-08-14 Peter Beverloo pe...@chromium.org
+
+[Chromium] Fix apk generation for the Android platform
+https://bugs.webkit.org/show_bug.cgi?id=93841
+
Unreviewed build fix.
APK generation was broken as the configuration file assumed compilation
Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (125541 => 125542)
--- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-14 11:28:25 UTC (rev 125541)
+++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-14 11:32:46 UTC (rev 125542)
@@ -151,7 +151,7 @@
['inside_chromium_build==1', {
'ant_build_to_chromium_src': '(ant_build_out)/../../',
}, {
-'ant_build_to_chromium_src': '(chromium_src_dir)',
+'ant_build_to_chromium_src': '(ant_build_out)/../../Source/WebKit/chromium',
}],
],
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125559] trunk/Source/WebKit/chromium
Title: [125559] trunk/Source/WebKit/chromium
Revision 125559
Author pe...@chromium.org
Date 2012-08-14 07:00:40 -0700 (Tue, 14 Aug 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125558 => 125559)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-14 13:53:14 UTC (rev 125558)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-14 14:00:40 UTC (rev 125559)
@@ -1,5 +1,11 @@
2012-08-14 Peter Beverloo pe...@chromium.org
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
+2012-08-14 Peter Beverloo pe...@chromium.org
+
[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841
Modified: trunk/Source/WebKit/chromium/DEPS (125558 => 125559)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-14 13:53:14 UTC (rev 125558)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-14 14:00:40 UTC (rev 125559)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '151257'
+ 'chromium_rev': '151462'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125561] trunk
Title: [125561] trunk
Revision 125561
Author pe...@chromium.org
Date 2012-08-14 07:26:14 -0700 (Tue, 14 Aug 2012)
Log Message
[Chromium] Remove unneeded build logic for Android
https://bugs.webkit.org/show_bug.cgi?id=93962
Reviewed by Dimitri Glazkov.
The Android SDK and NDK have been checked in to the Chromium tree, which
allows WebKit to leverage those as well. They will already be pulled in
through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
environment variable, the envsetup.sh will set the project files up
appropriately for us.
Source/WebKit/chromium:
* DEPS:
Tools:
* Scripts/webkitdirs.pm:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
trunk/Source/WebKit/chromium/gyp_webkit
trunk/Tools/ChangeLog
trunk/Tools/Scripts/update-webkit-chromium
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125560 => 125561)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-14 14:05:48 UTC (rev 125560)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-14 14:26:14 UTC (rev 125561)
@@ -1,5 +1,20 @@
2012-08-14 Peter Beverloo pe...@chromium.org
+[Chromium] Remove unneeded build logic for Android
+https://bugs.webkit.org/show_bug.cgi?id=93962
+
+Reviewed by Dimitri Glazkov.
+
+The Android SDK and NDK have been checked in to the Chromium tree, which
+allows WebKit to leverage those as well. They will already be pulled in
+through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
+environment variable, the envsetup.sh will set the project files up
+appropriately for us.
+
+* DEPS:
+
+2012-08-14 Peter Beverloo pe...@chromium.org
+
Unreviewed. Rolled DEPS.
* DEPS:
Modified: trunk/Source/WebKit/chromium/DEPS (125560 => 125561)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-14 14:05:48 UTC (rev 125560)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-14 14:26:14 UTC (rev 125561)
@@ -181,8 +181,6 @@
'android': {
'third_party/android_tools':
From('chromium_deps', 'src/third_party/android_tools'),
-'third_party/aosp':
- From('chromium_deps', 'src/third_party/aosp'),
'third_party/freetype':
From('chromium_deps', 'src/third_party/freetype'),
'tools/android':
Modified: trunk/Source/WebKit/chromium/gyp_webkit (125560 => 125561)
--- trunk/Source/WebKit/chromium/gyp_webkit 2012-08-14 14:05:48 UTC (rev 125560)
+++ trunk/Source/WebKit/chromium/gyp_webkit 2012-08-14 14:26:14 UTC (rev 125561)
@@ -87,9 +87,6 @@
envsetup_location = os.path.join(chrome_src, 'build', 'android', 'envsetup.sh')
exit(subprocess.call(['bash', '-c', 'source %s python gyp_webkit --no-envsetup-recursion %s' % (envsetup_location, ' '.join(args))]))
else:
- # FIXME: v8 requires the CXX_target variable to determine whether -m32 should be
- # set. The current Android build set-up is not sustainable and breaks too often.
- os.environ['CXX_target'] = glob.glob('%s/*-g++' % os.environ.get('ANDROID_TOOLCHAIN'))[0]
args.remove('--no-envsetup-recursion')
# Add includes.
Modified: trunk/Tools/ChangeLog (125560 => 125561)
--- trunk/Tools/ChangeLog 2012-08-14 14:05:48 UTC (rev 125560)
+++ trunk/Tools/ChangeLog 2012-08-14 14:26:14 UTC (rev 125561)
@@ -1,3 +1,18 @@
+2012-08-14 Peter Beverloo pe...@chromium.org
+
+[Chromium] Remove unneeded build logic for Android
+https://bugs.webkit.org/show_bug.cgi?id=93962
+
+Reviewed by Dimitri Glazkov.
+
+The Android SDK and NDK have been checked in to the Chromium tree, which
+allows WebKit to leverage those as well. They will already be pulled in
+through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
+environment variable, the envsetup.sh will set the project files up
+appropriately for us.
+
+* Scripts/webkitdirs.pm:
+
2012-08-14 Sergio Villar Senin svil...@igalia.com
[WK2] [GTK] Plugin tests failing in WK2 bot
Modified: trunk/Tools/Scripts/update-webkit-chromium (125560 => 125561)
--- trunk/Tools/Scripts/update-webkit-chromium 2012-08-14 14:05:48 UTC (rev 125560)
+++ trunk/Tools/Scripts/update-webkit-chromium 2012-08-14 14:26:14 UTC (rev 125561)
@@ -1,5 +1,4 @@
#!/usr/bin/perl -w
-
# Copyright (C) 2009 Google Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
@@ -59,26 +58,10 @@
--spec=solutions=[{'name':'./','url':None}]) == 0 or die $!;
}
-# When building WebKit's Chromium port for Android, we need the Android NDK as
-# it will allow us to cross-compile all sources to the target architecture.
+# When building Chromium for Android, the envsetup.sh script needs to be
+# executed prior to project file generation. We need to tell gyp_webkit to do
+# that, as it's a Chromium file and may not be availabl
[webkit-changes] [125420] trunk/Source/WebKit/chromium
Title: [125420] trunk/Source/WebKit/chromium
Revision 125420
Author pe...@chromium.org
Date 2012-08-13 08:50:37 -0700 (Mon, 13 Aug 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125419 => 125420)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-13 14:54:09 UTC (rev 125419)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-13 15:50:37 UTC (rev 125420)
@@ -1,3 +1,9 @@
+2012-08-13 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-08-13 Sheriff Bot webkit.review@gmail.com
Unreviewed. Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/DEPS (125419 => 125420)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-13 14:54:09 UTC (rev 125419)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-13 15:50:37 UTC (rev 125420)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '151251'
+ 'chromium_rev': '151257'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125422] trunk
Title: [125422] trunk Revision 125422 Author pe...@chromium.org Date 2012-08-13 09:40:45 -0700 (Mon, 13 Aug 2012) Log Message [Chromium] Fix apk generation for the Android platform https://bugs.webkit.org/show_bug.cgi?id=93841 Reviewed by Dimitri Glazkov. APK generation was broken as the configuration file assumed compilation would only occur in the Chromium tree. Pass the path to Chromium's source base directory as a property to ant. Source/WebKit/chromium: * WebKitUnitTests.gyp: Tools: * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKitUnitTests.gyp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (125421 => 125422) --- trunk/Source/WebKit/chromium/ChangeLog 2012-08-13 16:36:43 UTC (rev 125421) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-13 16:40:45 UTC (rev 125422) @@ -1,5 +1,18 @@ 2012-08-13 Peter Beverloo pe...@chromium.org +[Chromium] Fix apk generation for the Android platform +https://bugs.webkit.org/show_bug.cgi?id=93841 + +Reviewed by Dimitri Glazkov. + +APK generation was broken as the configuration file assumed compilation +would only occur in the Chromium tree. Pass the path to Chromium's source +base directory as a property to ant. + +* WebKitUnitTests.gyp: + +2012-08-13 Peter Beverloo pe...@chromium.org + Unreviewed. Rolled DEPS. * DEPS: Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (125421 => 125422) --- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-13 16:36:43 UTC (rev 125421) +++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-13 16:40:45 UTC (rev 125422) @@ -183,6 +183,8 @@ '-DANDROID_TOOLCHAIN=(android_toolchain)', '--ant-args', '-DPRODUCT_DIR=(ant_build_out)', +'--ant-args', +'-DCHROMIUM_SRC=(chromium_src_dir)', '--sdk-build=(sdk_build)', '--app_abi', '(android_app_abi)', Modified: trunk/Tools/ChangeLog (125421 => 125422) --- trunk/Tools/ChangeLog 2012-08-13 16:36:43 UTC (rev 125421) +++ trunk/Tools/ChangeLog 2012-08-13 16:40:45 UTC (rev 125422) @@ -1,3 +1,17 @@ +2012-08-13 Peter Beverloo pe...@chromium.org + +[Chromium] Fix apk generation for the Android platform +https://bugs.webkit.org/show_bug.cgi?id=93841 + +Reviewed by Dimitri Glazkov. + +APK generation was broken as the configuration file assumed compilation +would only occur in the Chromium tree. Pass the path to Chromium's source +base directory as a property to ant. + +* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: +* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: + 2012-08-13 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com [WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (125421 => 125422) --- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-08-13 16:36:43 UTC (rev 125421) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-08-13 16:40:45 UTC (rev 125422) @@ -500,6 +500,8 @@ '-DANDROID_TOOLCHAIN=(android_toolchain)', '--ant-args', '-DPRODUCT_DIR=(ant_build_out)', +'--ant-args', +'-DCHROMIUM_SRC=(chromium_src_dir)', '--sdk-build=(sdk_build)', '--app_abi', '(android_app_abi)', Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp (125421 => 125422) --- trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp 2012-08-13 16:36:43 UTC (rev 125421) +++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp 2012-08-13 16:40:45 UTC (rev 125422) @@ -143,6 +143,8 @@ '-DANDROID_TOOLCHAIN=(android_toolchain)', '--ant-args', '-DPRODUCT_DIR=(ant_build_out)', +'--ant-args', +'-DCHROMIUM_SRC=(chromium_src_dir)', '--sdk-build=(sdk_build)', '--app_abi', '(android_app_abi)', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125164] trunk/Source/WebKit/chromium
Title: [125164] trunk/Source/WebKit/chromium
Revision 125164
Author pe...@chromium.org
Date 2012-08-09 04:34:52 -0700 (Thu, 09 Aug 2012)
Log Message
[Chromium] Pull in the android_tools directory for Android
https://bugs.webkit.org/show_bug.cgi?id=84843
Reviewed by Jochen Eisinger.
Pull in the android_tools directory for Chromium Android checkouts. This
repository, living in Chromium's, contains checked in versions of the
Android NDK and SDK meant to make builds and updates easier.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125163 => 125164)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-09 11:00:56 UTC (rev 125163)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-09 11:34:52 UTC (rev 125164)
@@ -1,3 +1,16 @@
+2012-08-09 Peter Beverloo pe...@chromium.org
+
+[Chromium] Pull in the android_tools directory for Android
+https://bugs.webkit.org/show_bug.cgi?id=84843
+
+Reviewed by Jochen Eisinger.
+
+Pull in the android_tools directory for Chromium Android checkouts. This
+repository, living in Chromium's, contains checked in versions of the
+Android NDK and SDK meant to make builds and updates easier.
+
+* DEPS:
+
2012-08-08 Shane Stephens shanesteph...@google.com
Compile flag for CSS Hierarchies
Modified: trunk/Source/WebKit/chromium/DEPS (125163 => 125164)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-09 11:00:56 UTC (rev 125163)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-09 11:34:52 UTC (rev 125164)
@@ -179,12 +179,14 @@
From('chromium_deps', 'src/third_party/openssl'),
},
'android': {
+'third_party/android_tools':
+ From('chromium_deps', 'src/third_party/android_tools'),
+'third_party/aosp':
+ From('chromium_deps', 'src/third_party/aosp'),
+'third_party/freetype':
+ From('chromium_deps', 'src/third_party/freetype'),
'tools/android':
Var('chromium_svn') + '/tools/android@' + Var('chromium_rev'),
-'third_party/freetype':
- From('chromium_deps', 'src/third_party/freetype'),
-'third_party/aosp':
- From('chromium_deps', 'src/third_party/aosp'),
},
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125171] trunk/Source/WebKit/chromium
Title: [125171] trunk/Source/WebKit/chromium
Revision 125171
Author pe...@chromium.org
Date 2012-08-09 07:05:45 -0700 (Thu, 09 Aug 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125170 => 125171)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-09 14:03:31 UTC (rev 125170)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-09 14:05:45 UTC (rev 125171)
@@ -1,3 +1,9 @@
+2012-08-09 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-08-09 Keishi Hattori kei...@webkit.org
Page popups can show up at wrong locations
Modified: trunk/Source/WebKit/chromium/DEPS (125170 => 125171)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-09 14:03:31 UTC (rev 125170)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-09 14:05:45 UTC (rev 125171)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '150169'
+ 'chromium_rev': '150781'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125173] trunk/Source/WebKit/chromium
Title: [125173] trunk/Source/WebKit/chromium
Revision 125173
Author pe...@chromium.org
Date 2012-08-09 08:05:18 -0700 (Thu, 09 Aug 2012)
Log Message
Unreviewed, rolling out r125171.
http://trac.webkit.org/changeset/125171
Broke the Chromium Android build.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (125172 => 125173)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-08-09 14:17:17 UTC (rev 125172)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-09 15:05:18 UTC (rev 125173)
@@ -1,5 +1,14 @@
2012-08-09 Peter Beverloo pe...@chromium.org
+Unreviewed, rolling out r125171.
+http://trac.webkit.org/changeset/125171
+
+Broke the Chromium Android build.
+
+* DEPS:
+
+2012-08-09 Peter Beverloo pe...@chromium.org
+
Unreviewed. Rolled DEPS.
* DEPS:
Modified: trunk/Source/WebKit/chromium/DEPS (125172 => 125173)
--- trunk/Source/WebKit/chromium/DEPS 2012-08-09 14:17:17 UTC (rev 125172)
+++ trunk/Source/WebKit/chromium/DEPS 2012-08-09 15:05:18 UTC (rev 125173)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '150781'
+ 'chromium_rev': '150169'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125038] trunk/Tools
Title: [125038] trunk/Tools Revision 125038 Author pe...@chromium.org Date 2012-08-08 08:18:25 -0700 (Wed, 08 Aug 2012) Log Message Introduce cr-android bots in the EWS system https://bugs.webkit.org/show_bug.cgi?id=93472 Reviewed by Adam Barth. This adds the queue to the EWS scripts. Two builders are ready to be attached to the queue. All webkitpy tests pass with this change applied. * QueueStatusServer/model/queues.py: (Queue): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (ChromiumAndroidEWS): * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: (EarlyWarningSytemTest.test_builder_ewses): Modified Paths trunk/Tools/ChangeLog trunk/Tools/QueueStatusServer/model/queues.py trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py Diff Modified: trunk/Tools/ChangeLog (125037 => 125038) --- trunk/Tools/ChangeLog 2012-08-08 15:10:14 UTC (rev 125037) +++ trunk/Tools/ChangeLog 2012-08-08 15:18:25 UTC (rev 125038) @@ -1,3 +1,20 @@ +2012-08-08 Peter Beverloo pe...@chromium.org + +Introduce cr-android bots in the EWS system +https://bugs.webkit.org/show_bug.cgi?id=93472 + +Reviewed by Adam Barth. + +This adds the queue to the EWS scripts. Two builders are ready to be +attached to the queue. All webkitpy tests pass with this change applied. + +* QueueStatusServer/model/queues.py: +(Queue): +* Scripts/webkitpy/tool/commands/earlywarningsystem.py: +(ChromiumAndroidEWS): +* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: +(EarlyWarningSytemTest.test_builder_ewses): + 2012-08-08 Carlos Garcia Campos cgar...@igalia.com Unreviewed. Fix GTK+ build with GTK2 after r121475. Modified: trunk/Tools/QueueStatusServer/model/queues.py (125037 => 125038) --- trunk/Tools/QueueStatusServer/model/queues.py 2012-08-08 15:10:14 UTC (rev 125037) +++ trunk/Tools/QueueStatusServer/model/queues.py 2012-08-08 15:18:25 UTC (rev 125038) @@ -40,6 +40,7 @@ commit-queue, style-queue, chromium-ews, # aka cr-linux-ews +cr-android-ews, qt-ews, qt-wk2-ews, gtk-ews, Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py (125037 => 125038) --- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2012-08-08 15:10:14 UTC (rev 125037) +++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2012-08-08 15:18:25 UTC (rev 125038) @@ -192,6 +192,13 @@ name = cr-win-ews +class ChromiumAndroidEWS(AbstractChromiumEWS): +name = cr-android-ews +watchers = AbstractChromiumEWS.watchers + [ +peter+...@chromium.org, +] + + class MacEWS(AbstractEarlyWarningSystem): name = mac-ews port_name = mac Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (125037 => 125038) --- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2012-08-08 15:10:14 UTC (rev 125037) +++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2012-08-08 15:18:25 UTC (rev 125038) @@ -82,6 +82,7 @@ def test_builder_ewses(self): self._test_builder_ews(MacEWS()) self._test_builder_ews(ChromiumWindowsEWS()) +self._test_builder_ews(ChromiumAndroidEWS()) self._test_builder_ews(QtEWS()) self._test_builder_ews(QtWK2EWS()) self._test_builder_ews(GtkEWS()) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125049] trunk/Tools
Title: [125049] trunk/Tools
Revision 125049
Author pe...@chromium.org
Date 2012-08-08 10:38:18 -0700 (Wed, 08 Aug 2012)
Log Message
The cr-android EWS should actually be building Chromium for Android
https://bugs.webkit.org/show_bug.cgi?id=93489
Reviewed by Adam Barth.
The cr-android EWS bots should be building Chromium for Android, which
requires some additional flags to Chromium's default configuration.
* Scripts/webkitdirs.pm:
(buildChromium):
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(ChromiumAndroidPort):
(ChromiumAndroidPort.update_webkit_command):
(ChromiumAndroidPort.build_webkit_command):
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_chromium_android_port):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(ChromiumAndroidEWS):
* Scripts/webkitpy/tool/steps/update_unittest.py:
(UpdateTest.test_update_command_non_interactive):
(UpdateTest.test_update_command_interactive):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/Scripts/webkitpy/common/config/ports.py
trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py
trunk/Tools/Scripts/webkitpy/tool/steps/update_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (125048 => 125049)
--- trunk/Tools/ChangeLog 2012-08-08 17:31:12 UTC (rev 125048)
+++ trunk/Tools/ChangeLog 2012-08-08 17:38:18 UTC (rev 125049)
@@ -1,3 +1,28 @@
+2012-08-08 Peter Beverloo pe...@chromium.org
+
+The cr-android EWS should actually be building Chromium for Android
+https://bugs.webkit.org/show_bug.cgi?id=93489
+
+Reviewed by Adam Barth.
+
+The cr-android EWS bots should be building Chromium for Android, which
+requires some additional flags to Chromium's default configuration.
+
+* Scripts/webkitdirs.pm:
+(buildChromium):
+* Scripts/webkitpy/common/config/ports.py:
+(DeprecatedPort.port):
+(ChromiumAndroidPort):
+(ChromiumAndroidPort.update_webkit_command):
+(ChromiumAndroidPort.build_webkit_command):
+* Scripts/webkitpy/common/config/ports_unittest.py:
+(DeprecatedPortTest.test_chromium_android_port):
+* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+(ChromiumAndroidEWS):
+* Scripts/webkitpy/tool/steps/update_unittest.py:
+(UpdateTest.test_update_command_non_interactive):
+(UpdateTest.test_update_command_interactive):
+
2012-08-08 Alexey Proskuryakov a...@apple.com
[WK2] MiniBrowser crashes on window.open()
Modified: trunk/Tools/Scripts/webkitdirs.pm (125048 => 125049)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-08-08 17:31:12 UTC (rev 125048)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-08-08 17:38:18 UTC (rev 125049)
@@ -2579,7 +2579,9 @@
# We might need to update DEPS or re-run GYP if things have changed.
if (checkForArgumentAndRemoveFromArrayRef(--update-chromium, \@options)) {
-system(perl, Tools/Scripts/update-webkit-chromium, --force) == 0 or die $!;
+my @updateCommand = (perl, Tools/Scripts/update-webkit-chromium, --force);
+push @updateCommand, --chromium-android if isChromiumAndroid();
+system(@updateCommand) == 0 or die $!;
}
my $result = 1;
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (125048 => 125049)
--- trunk/Tools/Scripts/webkitpy/common/config/ports.py 2012-08-08 17:31:12 UTC (rev 125048)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py 2012-08-08 17:38:18 UTC (rev 125049)
@@ -59,6 +59,7 @@
def port(port_name):
ports = {
chromium: ChromiumPort,
+chromium-android: ChromiumAndroidPort,
chromium-xvfb: ChromiumXVFBPort,
gtk: GtkPort,
mac: MacPort,
@@ -193,6 +194,20 @@
return None
+class ChromiumAndroidPort(ChromiumPort):
+port_flag_name = chromium-android
+
+def update_webkit_command(self, non_interactive=False):
+command = super(ChromiumAndroidPort, self).update_webkit_command(non_interactive=non_interactive)
+command.append(--chromium-android)
+return command
+
+def build_webkit_command(self, build_style=None):
+command = super(ChromiumAndroidPort, self).build_webkit_command(build_style=build_style)
+command.append(--chromium-android)
+return command
+
+
class ChromiumXVFBPort(ChromiumPort):
port_flag_name = chromium-xvfb
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py (125048 => 125049)
--- trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py 2012-08-08 17:31:12 UTC (rev 125048)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py 2012-08-08 17:38:18 UTC (rev 125049)
@@ -59,6 +59,10 @@
self.assertEquals(ChromiumPort().build_webkit_command(build_style=debug), DeprecatedPort().script_shell_command(
[webkit-changes] [125066] trunk/Tools
trunk/Tools/BuildSlaveSupport/built-product-archive 2012-08-08 19:11:37 UTC (rev 125066)
@@ -51,14 +51,15 @@
parser.error(Action is required)
return 1
-if not determineWebKitBuildDirectory(options.platform, options.configuration):
+genericPlatform = options.platform.split('-', 1)[0]
+if not determineWebKitBuildDirectory(genericPlatform, options.configuration):
print sys.stderr, Could not determine build directory
return 1
if action == 'archive':
-return archiveBuiltProduct(options.configuration, options.platform)
+return archiveBuiltProduct(options.configuration, genericPlatform, options.platform)
else:
-return extractBuiltProduct(options.configuration, options.platform)
+return extractBuiltProduct(options.configuration, genericPlatform)
def determineWebKitBuildDirectory(platform, configuration):
@@ -116,7 +117,7 @@
return subprocess.call([zip, -y, -r, archiveFile, .], cwd=directoryToZip)
-def archiveBuiltProduct(configuration, platform):
+def archiveBuiltProduct(configuration, platform, fullPlatform):
assert platform in ('mac', 'win', 'qt', 'gtk', 'efl', 'chromium')
configurationBuildDirectory = os.path.join(_buildDirectory, configuration.title())
@@ -164,10 +165,14 @@
elif platform == 'chromium':
thinDirectory = os.path.join(configurationBuildDirectory, thin)
+ignorePatterns = ['.svn', '*.a', '*.d', '*.dSYM', '*.o', '*.ilk', '*.lib', '*.idb',
+ 'BuildLog.htm', '*.obj', '*.pdb', '*.pch', '*.tlog', '*.lastbuildstate']
+
+if fullPlatform and fullPlatform == 'chromium-android':
+ignorePatterns.extend(['*.so', '*.pak', '*-unaligned.apk'])
+
removeDirectoryIfExists(thinDirectory)
-copyBuildFiles(configurationBuildDirectory, thinDirectory,
-['.svn', '*.a', '*.d', '*.dSYM', '*.o', '*.ilk', '*.lib', '*.idb', 'BuildLog.htm', '*.obj',
-'*.pdb', '*.pch', '*.tlog', '*.lastbuildstate'])
+copyBuildFiles(configurationBuildDirectory, thinDirectory, ignorePatterns)
if createZip(thinDirectory, configuration):
return 1
Modified: trunk/Tools/ChangeLog (125065 => 125066)
--- trunk/Tools/ChangeLog 2012-08-08 19:09:07 UTC (rev 125065)
+++ trunk/Tools/ChangeLog 2012-08-08 19:11:37 UTC (rev 125066)
@@ -1,3 +1,36 @@
+2012-08-08 Peter Beverloo pe...@chromium.org
+
+Buildmaster changes in preparation of a Chromium Android tester
+https://bugs.webkit.org/show_bug.cgi?id=92251
+
+Reviewed by Adam Barth.
+
+Slightly update the build master's configuration in preparation of adding
+a Chromium Android tester.
+
+The change in built-product-archive is required as the out/ directory
+for Android has a number of unstripped .so binaries and unaligned APKs,
+causing the default release.zip file to be 2.7 gigabytes. By excluding
+these file types, the file is only 59.7 megabytes. We can't disable
+them for all of Chromium, as Mac and Linux do use their .so files.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(ArchiveBuiltProduct): Pass the full platform name instead of just the
+generic type, i.e. chromium-android instead of chromium.
+(ExtractBuiltProduct): Dito, stay consistent for this script.
+(RunUnitTests): Pass --chromium-android as well as --chromium. Since we
+now read the full platform name, stay on the safe side with 'win'
+even though there (as far as I know) is no win-* platform.
+(RunChromiumWebKitUnitTests): Dito. The platform wasn't being passed
+at all, but we'll be needing different handling here.
+(unitTestsSupported): Next to refactoring work required, as we'll be
+running this test on a device, there is no reason to disable this
+in the master's configuration.
+* BuildSlaveSupport/built-product-archive:
+(main): Determine the generic platform.
+(archiveBuiltProduct): Use an identical set of ignorePatterns, but
+extend the list with .so, .pak and -unaligned.apk for Android.
+
2012-08-08 Adam Barth aba...@webkit.org
Unreviewed. Stop running tests on the mac-ews while we wait for more
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [125075] trunk/Websites/planet.webkit.org
Title: [125075] trunk/Websites/planet.webkit.org Revision 125075 Author pe...@chromium.org Date 2012-08-08 12:39:00 -0700 (Wed, 08 Aug 2012) Log Message Remove several non-updated blogs from Planet WebKit https://bugs.webkit.org/show_bug.cgi?id=92973 Reviewed by Eric Seidel. Adam Treat's blog was last updated in 2009. Justin Haygood's blog was last updated in 2008. Mike Smith seems to have moved to Google+ entirely. Pierre-Luc Beaudoin's blog is unavailable, cached copy says the last (non-WebKit specific update) was in 2010. Cameron Zwarich' summer of JSC no longer exists. Anthony Ricaud's blog was last updated in 2009. * config.ini: Modified Paths trunk/Websites/planet.webkit.org/ChangeLog trunk/Websites/planet.webkit.org/config.ini Diff Modified: trunk/Websites/planet.webkit.org/ChangeLog (125074 => 125075) --- trunk/Websites/planet.webkit.org/ChangeLog 2012-08-08 19:33:58 UTC (rev 125074) +++ trunk/Websites/planet.webkit.org/ChangeLog 2012-08-08 19:39:00 UTC (rev 125075) @@ -1,3 +1,19 @@ +2012-08-08 Peter Beverloo pe...@chromium.org + +Remove several non-updated blogs from Planet WebKit +https://bugs.webkit.org/show_bug.cgi?id=92973 + +Reviewed by Eric Seidel. + +Adam Treat's blog was last updated in 2009. +Justin Haygood's blog was last updated in 2008. +Mike Smith seems to have moved to Google+ entirely. +Pierre-Luc Beaudoin's blog is unavailable, cached copy says the last (non-WebKit specific update) was in 2010. +Cameron Zwarich' summer of JSC no longer exists. +Anthony Ricaud's blog was last updated in 2009. + +* config.ini: + 2012-08-07 Bruno de Oliveira Abinader bruno.abina...@basyskom.com Add Bruno Abinader's blog feed to Planet WebKit Modified: trunk/Websites/planet.webkit.org/config.ini (125074 => 125075) --- trunk/Websites/planet.webkit.org/config.ini 2012-08-08 19:33:58 UTC (rev 125074) +++ trunk/Websites/planet.webkit.org/config.ini 2012-08-08 19:39:00 UTC (rev 125075) @@ -82,10 +82,6 @@ # natively knows about. Look at fancy-examples/index.html.tmpl # for the flip-side of this. -[http://www.kdedevelopers.org/blog/105/feed] -name = Adam Treat -filter = webkit - [http://www.atoker.com/blog/category/webkit/feed/] name = Alp Toker nick = alp @@ -98,10 +94,6 @@ name = Holger Freyther nick = zecke -[http://blog.justinhaygood.com/category/webkit/feed/] -name = Justin Haygood -nick = jhaygood - [http://www.politreco.com/tag/webkit/feed/] name = Lucas De Marchi @@ -109,11 +101,6 @@ name = Leandro Pereira nick = acidx -[http://sideshowbarker.net/feed/] -name = Michael(tm) Smith -nick = MikeSmith -filter = webkit - [http://webkit.org/blog/feed/] name = Surfinrsquo; Safari @@ -130,16 +117,6 @@ nick = bfulgham filter = webkit -[http://blog.squidy.info/category/webkit/feed/en/] -name = Pierre-Luc Beaudoin -nick = pierlux - -[http://summerofjsc.blogspot.com/feeds/posts/default] -name = Cameron Zwarich - -[http://hanblog.info/blog/feed/category/WebKit/atom] -name = Anthony Ricaud - [http://blog.chromium.org/feeds/posts/default?alt=rss] name = The Chromium Blog filter = webkit ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124457] trunk
Title: [124457] trunk Revision 124457 Author pe...@chromium.org Date 2012-08-02 08:09:11 -0700 (Thu, 02 Aug 2012) Log Message [Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI https://bugs.webkit.org/show_bug.cgi?id=92858 Reviewed by Adam Barth. Now that the sdk_build variable is available, we can remove these two differences as well. This goes together with Adam's bug 90920. After this patch, the whole Tools/ directory will be unforked :-). Source/WebKit/chromium: * WebKitUnitTests.gyp: Tools: * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKitUnitTests.gyp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (124456 => 124457) --- trunk/Source/WebKit/chromium/ChangeLog 2012-08-02 15:01:14 UTC (rev 124456) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-08-02 15:09:11 UTC (rev 124457) @@ -1,3 +1,17 @@ +2012-08-02 Peter Beverloo pe...@chromium.org + +[Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI +https://bugs.webkit.org/show_bug.cgi?id=92858 + +Reviewed by Adam Barth. + +Now that the sdk_build variable is available, we can remove these two differences +as well. This goes together with Adam's bug 90920. + +After this patch, the whole Tools/ directory will be unforked :-). + +* WebKitUnitTests.gyp: + 2012-08-02 Alexei Filippov alex...@chromium.org Web Inspector: count RenderStyle objects in the native memory profiler Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (124456 => 124457) --- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-02 15:01:14 UTC (rev 124456) +++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-08-02 15:09:11 UTC (rev 124457) @@ -173,7 +173,7 @@ '(PRODUCT_DIR)/webkit_unit_tests_apk', '--ant-args', '-DPRODUCT_DIR=(ant_build_out)', -'--ant-compile', +'--sdk-build=(sdk_build)', '--app_abi', '(android_app_abi)', ], Modified: trunk/Tools/ChangeLog (124456 => 124457) --- trunk/Tools/ChangeLog 2012-08-02 15:01:14 UTC (rev 124456) +++ trunk/Tools/ChangeLog 2012-08-02 15:09:11 UTC (rev 124457) @@ -1,3 +1,17 @@ +2012-08-02 Peter Beverloo pe...@chromium.org + +[Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI +https://bugs.webkit.org/show_bug.cgi?id=92858 + +Reviewed by Adam Barth. + +Now that the sdk_build variable is available, we can remove these two differences +as well. This goes together with Adam's bug 90920. + +After this patch, the whole Tools/ directory will be unforked :-). + +* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: + 2012-08-02 Zoltan Arvai zar...@inf.u-szeged.hu [Qt] MSVC specific buildfix for DRT. Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp (124456 => 124457) --- trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp 2012-08-02 15:01:14 UTC (rev 124456) +++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp 2012-08-02 15:09:11 UTC (rev 124457) @@ -133,7 +133,7 @@ '(PRODUCT_DIR)/TestWebKitAPI_apk', '--ant-args', '-DPRODUCT_DIR=(ant_build_out)', -'--ant-compile', +'--sdk-build=(sdk_build)', '--app_abi', '(android_app_abi)', ], ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124478] trunk/Source
Title: [124478] trunk/Source Revision 124478 Author pe...@chromium.org Date 2012-08-02 10:40:27 -0700 (Thu, 02 Aug 2012) Log Message [Chromium] Add a stub for WebView::getTouchHighlightQuads() https://bugs.webkit.org/show_bug.cgi?id=92997 Reviewed by Adam Barth. Chrome on Android will be using this method for the link preview implementation, discussion about which is available in Bug 79150. Since that system is fairly big, will require refactoring, and the unavailable APIs are blocking API compatibility, add a stub for now. Together with the WebView API, also add the WebTouchCandidatesInfo structure which is being used by it. Source/Platform: * Platform.gypi: List WebTouchCandidatesInfo.h * chromium/public/WebTouchCandidatesInfo.h: Added. (WebKit): (WebTouchCandidatesInfo): (WebKit::WebTouchCandidatesInfo::WebTouchCandidatesInfo): Source/WebKit/chromium: * public/WebView.h: (WebKit): (WebView): * src/WebViewImpl.cpp: (WebKit): (WebKit::WebViewImpl::getTouchHighlightQuads): * src/WebViewImpl.h: (WebViewImpl): Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/Platform.gypi trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebView.h trunk/Source/WebKit/chromium/src/WebViewImpl.cpp trunk/Source/WebKit/chromium/src/WebViewImpl.h Added Paths trunk/Source/Platform/chromium/public/WebTouchCandidatesInfo.h Diff Modified: trunk/Source/Platform/ChangeLog (124477 => 124478) --- trunk/Source/Platform/ChangeLog 2012-08-02 17:36:59 UTC (rev 124477) +++ trunk/Source/Platform/ChangeLog 2012-08-02 17:40:27 UTC (rev 124478) @@ -1,3 +1,24 @@ +2012-08-02 Peter Beverloo pe...@chromium.org + +[Chromium] Add a stub for WebView::getTouchHighlightQuads() +https://bugs.webkit.org/show_bug.cgi?id=92997 + +Reviewed by Adam Barth. + +Chrome on Android will be using this method for the link preview +implementation, discussion about which is available in Bug 79150. Since +that system is fairly big, will require refactoring, and the unavailable +APIs are blocking API compatibility, add a stub for now. + +Together with the WebView API, also add the WebTouchCandidatesInfo +structure which is being used by it. + +* Platform.gypi: List WebTouchCandidatesInfo.h +* chromium/public/WebTouchCandidatesInfo.h: Added. +(WebKit): +(WebTouchCandidatesInfo): +(WebKit::WebTouchCandidatesInfo::WebTouchCandidatesInfo): + 2012-08-02 Tommy Widenflycht tom...@google.com MediaStream API: Add RTCPeerConnectionHandler infrastructure Modified: trunk/Source/Platform/Platform.gypi (124477 => 124478) --- trunk/Source/Platform/Platform.gypi 2012-08-02 17:36:59 UTC (rev 124477) +++ trunk/Source/Platform/Platform.gypi 2012-08-02 17:40:27 UTC (rev 124478) @@ -127,6 +127,7 @@ 'chromium/public/WebString.h', 'chromium/public/WebThread.h', 'chromium/public/WebThreadSafeData.h', +'chromium/public/WebTouchCandidatesInfo.h', 'chromium/public/WebTransformationMatrix.h', 'chromium/public/WebTransformAnimationCurve.h', 'chromium/public/WebTransformKeyframe.h', Added: trunk/Source/Platform/chromium/public/WebTouchCandidatesInfo.h (0 => 124478) --- trunk/Source/Platform/chromium/public/WebTouchCandidatesInfo.h (rev 0) +++ trunk/Source/Platform/chromium/public/WebTouchCandidatesInfo.h 2012-08-02 17:40:27 UTC (rev 124478) @@ -0,0 +1,54 @@ +/* + * Copyright (C) 2012 Google Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS AS IS AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#ifndef WebTouchCandidatesInfo_h +#define WebTouchCandidatesInfo_h +
[webkit-changes] [124372] trunk
Title: [124372] trunk
Revision 124372
Author pe...@chromium.org
Date 2012-08-01 15:12:23 -0700 (Wed, 01 Aug 2012)
Log Message
[Text Autosizing] Provide an API for influencing the font scale factor
https://bugs.webkit.org/show_bug.cgi?id=92882
Reviewed by Adam Barth.
Source/WebCore:
Add the font scale factor to settings, and provide an API in
window.internal.settings to change it from layout tests.
The font scale factor applied to Text Autosizing influences the sizing
of text, and will influence the scaling of boosted blocks once the
implementation progresses. For Android, it will be set to the font size
chosen in the user's system-wide preferences.
Test: fast/text-autosizing/font-scale-factor.html
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore):
(WebCore::Settings::setTextAutosizingFontScaleFactor):
* page/Settings.h:
(Settings):
(WebCore::Settings::textAutosizingFontScaleFactor):
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processBlock):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setTextAutosizingFontScaleFactor):
(WebCore):
* testing/InternalSettings.h:
(Backup):
(InternalSettings):
* testing/InternalSettings.idl:
Source/WebKit/chromium:
Add an API to change Text Autosizing's font scale factor.
The font scale factor applied to Text Autosizing influences the sizing
of text, and will influence the scaling of boosted blocks once the
implementation progresses. For Android, it will be set to the font size
chosen in the user's system-wide preferences.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setTextAutosizingFontScaleFactor):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
LayoutTests:
Add a basic test. More usable tests should be added later, as it's
really hard to test this accurately in this phase of the implementation,
and Text Autosizing is still subject to various bugs.
The font scale factor applied to Text Autosizing influences the sizing
of text, and will influence the scaling of boosted blocks once the
implementation progresses. For Android, it will be set to the font size
chosen in the user's system-wide preferences.
* fast/text-autosizing/font-scale-factor-expected.html: Added.
* fast/text-autosizing/font-scale-factor.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/rendering/TextAutosizer.cpp
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Source/WebCore/testing/InternalSettings.idl
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h
Added Paths
trunk/LayoutTests/fast/text-autosizing/font-scale-factor-expected.html
trunk/LayoutTests/fast/text-autosizing/font-scale-factor.html
Diff
Modified: trunk/LayoutTests/ChangeLog (124371 => 124372)
--- trunk/LayoutTests/ChangeLog 2012-08-01 21:34:13 UTC (rev 124371)
+++ trunk/LayoutTests/ChangeLog 2012-08-01 22:12:23 UTC (rev 124372)
@@ -1,3 +1,22 @@
+2012-08-01 Peter Beverloo pe...@chromium.org
+
+[Text Autosizing] Provide an API for influencing the font scale factor
+https://bugs.webkit.org/show_bug.cgi?id=92882
+
+Reviewed by Adam Barth.
+
+Add a basic test. More usable tests should be added later, as it's
+really hard to test this accurately in this phase of the implementation,
+and Text Autosizing is still subject to various bugs.
+
+The font scale factor applied to Text Autosizing influences the sizing
+of text, and will influence the scaling of boosted blocks once the
+implementation progresses. For Android, it will be set to the font size
+chosen in the user's system-wide preferences.
+
+* fast/text-autosizing/font-scale-factor-expected.html: Added.
+* fast/text-autosizing/font-scale-factor.html: Added.
+
2012-08-01 Mike West mk...@chromium.org
CSP should correctly block plugin resources rendered in PluginDocuments.
Added: trunk/LayoutTests/fast/text-autosizing/font-scale-factor-expected.html (0 => 124372)
--- trunk/LayoutTests/fast/text-autosizing/font-scale-factor-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text-autosizing/font-scale-factor-expected.html 2012-08-01 22:12:23 UTC (rev 124372)
@@ -0,0 +1,15 @@
+html
+ head
+meta name=viewport content=width=800 /
+style
+ body {
+width: 800px;
+margin: 0px;
+ }
+/style
+ /head
+ body
+!-- FIXME: The line-height and margin-top shouldn't need to be changed here. The margins are a bug. See http://wkbug.com/91660. --
+p style=font-size: 5rem; line-height: 0.30; margin: 2.20rem
[webkit-changes] [124219] trunk/Tools
Title: [124219] trunk/Tools
Revision 124219
Author pe...@chromium.org
Date 2012-07-31 10:26:50 -0700 (Tue, 31 Jul 2012)
Log Message
[Chromium] Don't use ninja for building Chromium for Android
https://bugs.webkit.org/show_bug.cgi?id=92764
Reviewed by Adam Barth.
When Ninja projects files are generated (which will be done for Android),
make sure that the Android builder doesn't unintentionally switch to
using Ninja. We should make that switch at a predetermined time.
* Scripts/webkitdirs.pm:
(buildChromium):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (124218 => 124219)
--- trunk/Tools/ChangeLog 2012-07-31 17:21:01 UTC (rev 124218)
+++ trunk/Tools/ChangeLog 2012-07-31 17:26:50 UTC (rev 124219)
@@ -1,3 +1,17 @@
+2012-07-31 Peter Beverloo pe...@chromium.org
+
+[Chromium] Don't use ninja for building Chromium for Android
+https://bugs.webkit.org/show_bug.cgi?id=92764
+
+Reviewed by Adam Barth.
+
+When Ninja projects files are generated (which will be done for Android),
+make sure that the Android builder doesn't unintentionally switch to
+using Ninja. We should make that switch at a predetermined time.
+
+* Scripts/webkitdirs.pm:
+(buildChromium):
+
2012-07-31 Thiago Marcos P. Santos thiago.san...@intel.com
Add a mechanism to dump the stack trace in case of a crash
Modified: trunk/Tools/Scripts/webkitdirs.pm (124218 => 124219)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-07-31 17:21:01 UTC (rev 124218)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-07-31 17:26:50 UTC (rev 124219)
@@ -2589,7 +2589,7 @@
} elsif (isCygwin() || isWindows()) {
# Windows build - builds the root visual studio solution.
$result = buildChromiumVisualStudioProject(Source/WebKit/chromium/All.sln, $clean);
-} elsif (isChromiumNinja()) {
+} elsif (isChromiumNinja() !isChromiumAndroid()) {
$result = buildChromiumNinja(all, $clean, @options);
} elsif (isLinux() || isChromiumAndroid() || isChromiumMacMake()) {
# Linux build - build using make.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [123854] trunk/Source/WebKit/chromium
Title: [123854] trunk/Source/WebKit/chromium
Revision 123854
Author pe...@chromium.org
Date 2012-07-27 02:32:24 -0700 (Fri, 27 Jul 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (123853 => 123854)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-27 09:26:24 UTC (rev 123853)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-27 09:32:24 UTC (rev 123854)
@@ -1,3 +1,9 @@
+2012-07-27 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-07-27 Alec Flett alecfl...@chromium.org
IndexedDB: inject index keys on cursor/objectstore/index get success handlers
Modified: trunk/Source/WebKit/chromium/DEPS (123853 => 123854)
--- trunk/Source/WebKit/chromium/DEPS 2012-07-27 09:26:24 UTC (rev 123853)
+++ trunk/Source/WebKit/chromium/DEPS 2012-07-27 09:32:24 UTC (rev 123854)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '148290'
+ 'chromium_rev': '148724'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [123861] trunk/Source/WebKit/chromium
Title: [123861] trunk/Source/WebKit/chromium
Revision 123861
Author pe...@chromium.org
Date 2012-07-27 04:04:06 -0700 (Fri, 27 Jul 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (123860 => 123861)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-27 10:47:15 UTC (rev 123860)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-27 11:04:06 UTC (rev 123861)
@@ -1,3 +1,9 @@
+2012-07-27 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-07-27 Oli Lan oli...@chromium.org
[chromium] Fix issues in visiblePositionForWindowPoint (offscreen points / iframes).
Modified: trunk/Source/WebKit/chromium/DEPS (123860 => 123861)
--- trunk/Source/WebKit/chromium/DEPS 2012-07-27 10:47:15 UTC (rev 123860)
+++ trunk/Source/WebKit/chromium/DEPS 2012-07-27 11:04:06 UTC (rev 123861)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '148724'
+ 'chromium_rev': '148739'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [123440] trunk/Source/WebCore
Title: [123440] trunk/Source/WebCore Revision 123440 Author pe...@chromium.org Date 2012-07-24 01:55:18 -0700 (Tue, 24 Jul 2012) Log Message [Chromium] Build fix for Android after r123424 https://bugs.webkit.org/show_bug.cgi?id=92082 Unreviewed build fix. Mark removed the PlatformSupport.h header from ScrollbarThemeChromiumAndroid.cpp in r123424, while there still are two references left to another method and a constant. Re-add the include directive. * platform/chromium/ScrollbarThemeChromiumAndroid.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (123439 => 123440) --- trunk/Source/WebCore/ChangeLog 2012-07-24 08:44:58 UTC (rev 123439) +++ trunk/Source/WebCore/ChangeLog 2012-07-24 08:55:18 UTC (rev 123440) @@ -1,3 +1,16 @@ +2012-07-24 Peter Beverloo pe...@chromium.org + +[Chromium] Build fix for Android after r123424 +https://bugs.webkit.org/show_bug.cgi?id=92082 + +Unreviewed build fix. + +Mark removed the PlatformSupport.h header from ScrollbarThemeChromiumAndroid.cpp +in r123424, while there still are two references left to another method and a +constant. Re-add the include directive. + +* platform/chromium/ScrollbarThemeChromiumAndroid.cpp: + 2012-07-24 Kentaro Hara hara...@chromium.org [JSC] REGRESSION(r122912): CodeGeneratorJS.pm generates wrong code Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp (123439 => 123440) --- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp 2012-07-24 08:44:58 UTC (rev 123439) +++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp 2012-07-24 08:55:18 UTC (rev 123440) @@ -29,6 +29,7 @@ #include LayoutTestSupport.h #include PlatformContextSkia.h #include PlatformMouseEvent.h +#include PlatformSupport.h #include Scrollbar.h #include TransformationMatrix.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [123445] trunk/Source/WebKit/chromium
Title: [123445] trunk/Source/WebKit/chromium
Revision 123445
Author pe...@chromium.org
Date 2012-07-24 02:25:06 -0700 (Tue, 24 Jul 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (123444 => 123445)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-24 09:21:37 UTC (rev 123444)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-24 09:25:06 UTC (rev 123445)
@@ -1,3 +1,9 @@
+2012-07-24 Peter Beverloo pe...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-07-23 Mark Pilgrim pilg...@chromium.org
[Chromium] Move layoutTestMode to WebCore
Modified: trunk/Source/WebKit/chromium/DEPS (123444 => 123445)
--- trunk/Source/WebKit/chromium/DEPS 2012-07-24 09:21:37 UTC (rev 123444)
+++ trunk/Source/WebKit/chromium/DEPS 2012-07-24 09:25:06 UTC (rev 123445)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '147759'
+ 'chromium_rev': '148048'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [123455] trunk/Tools
Title: [123455] trunk/Tools Revision 123455 Author pe...@chromium.org Date 2012-07-24 04:23:03 -0700 (Tue, 24 Jul 2012) Log Message Update a few Chromium Android contributors in committers.py https://bugs.webkit.org/show_bug.cgi?id=92090 Reviewed by Kent Tamura. Add Sami Kyostila, who has been doing significant work on Chromium's compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and remove John Grabowski who changed projects, and add my webkit.org alias. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (123454 => 123455) --- trunk/Tools/ChangeLog 2012-07-24 11:18:12 UTC (rev 123454) +++ trunk/Tools/ChangeLog 2012-07-24 11:23:03 UTC (rev 123455) @@ -1,3 +1,16 @@ +2012-07-24 Peter Beverloo pe...@chromium.org + +Update a few Chromium Android contributors in committers.py +https://bugs.webkit.org/show_bug.cgi?id=92090 + +Reviewed by Kent Tamura. + +Add Sami Kyostila, who has been doing significant work on Chromium's +compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and +remove John Grabowski who changed projects, and add my webkit.org alias. + +* Scripts/webkitpy/common/config/committers.py: + 2012-07-24 Pierre Rossi pierre.ro...@gmail.com [Qt] Enable touch slider when touch events are enabled Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (123454 => 123455) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-07-24 11:18:12 UTC (rev 123454) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-07-24 11:23:03 UTC (rev 123455) @@ -139,8 +139,7 @@ Contributor(Jing Zhao, jingz...@chromium.org), Contributor(John Bates, [jba...@google.com, jba...@chromium.org], jbates), Contributor(John Bauman, [jbau...@chromium.org, jbau...@google.com], jbauman), -Contributor(John Grabowski, j...@chromium.org), -Contributor(John Mellor, joh...@chromium.org), +Contributor(John Mellor, joh...@chromium.org, johnme), Contributor(Kulanthaivel Palanichamy, kulanthai...@codeaurora.org, kvel), Contributor(uMichael Br\u00fcning, michael.brun...@nokia.com, mibrunin), Contributor(Mihai Balan, miba...@adobe.com, miChou), @@ -153,11 +152,12 @@ Contributor(Radar WebKit Bug Importer, webkit-bug-impor...@group.apple.com), Contributor(Raul Hudea, rhu...@adobe.com, rhudea), Contributor(Roland Takacs, rtak...@inf.u-szeged.hu, rtakacs), +Contributor(uSami Ky\u00f6stil\u00e4, skyos...@chromium.org, skyostil), Contributor(Szilard Ledan-Muntean, szle...@inf.u-szeged.hu, szledan), Contributor(Tab Atkins, [tabatk...@google.com, jackalm...@gmail.com], tabatkins), Contributor(Tamas Czene, [tcz...@inf.u-szeged.hu, czene.ta...@stud.u-szeged.hu], tczene), Contributor(Terry Anderson, tdander...@chromium.org, tdanderson), -Contributor(Tien-Ren Chen, trc...@chromium.org), +Contributor(Tien-Ren Chen, trc...@chromium.org, trchen), Contributor(Tom Hudson, tomhud...@google.com), Contributor(WebKit Review Bot, webkit.review@gmail.com, sheriff-bot), Contributor(Wyatt Carss, [wca...@chromium.org, wca...@google.com], wcarss), @@ -343,7 +343,7 @@ Committer(Pam Greene, p...@chromium.org, pamg), Committer(Patrick Gansterer, [par...@paroga.com, par...@webkit.org], paroga), Committer(Pavel Podivilov, podivi...@chromium.org, podivilov), -Committer(Peter Beverloo, [pe...@chromium.org, bever...@google.com], beverloo), +Committer(Peter Beverloo, [pe...@chromium.org, pe...@webkit.org, bever...@google.com], beverloo), Committer(Peter Kasting, [pkast...@google.com, pkast...@chromium.org], pkasting), Committer(Peter Varga, [pva...@webkit.org, pva...@inf.u-szeged.hu], stampho), Committer(Philip Rogers, [p...@google.com, p...@chromium.org], pdr), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [123457] trunk/Tools
Title: [123457] trunk/Tools
Revision 123457
Author pe...@chromium.org
Date 2012-07-24 04:37:15 -0700 (Tue, 24 Jul 2012)
Log Message
[Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
https://bugs.webkit.org/show_bug.cgi?id=92097
Unreviewed build fix.
WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
but TestDelegate.h forward declares it as a class.
* DumpRenderTree/chromium/TestRunner/TestDelegate.h:
(WebKit):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/TestDelegate.h
Diff
Modified: trunk/Tools/ChangeLog (123456 => 123457)
--- trunk/Tools/ChangeLog 2012-07-24 11:33:43 UTC (rev 123456)
+++ trunk/Tools/ChangeLog 2012-07-24 11:37:15 UTC (rev 123457)
@@ -1,3 +1,16 @@
+2012-07-24 Peter Beverloo pe...@chromium.org
+
+[Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
+https://bugs.webkit.org/show_bug.cgi?id=92097
+
+Unreviewed build fix.
+
+WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
+but TestDelegate.h forward declares it as a class.
+
+* DumpRenderTree/chromium/TestRunner/TestDelegate.h:
+(WebKit):
+
2012-07-23 Oswald Buddenhagen oswald.buddenha...@nokia.com
[Qt] Fix compilation against namespaced Qt
Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/TestDelegate.h (123456 => 123457)
--- trunk/Tools/DumpRenderTree/chromium/TestRunner/TestDelegate.h 2012-07-24 11:33:43 UTC (rev 123456)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/TestDelegate.h 2012-07-24 11:37:15 UTC (rev 123457)
@@ -35,7 +35,7 @@
#include wtf/Vector.h
namespace WebKit {
-class WebContextMenuData;
+struct WebContextMenuData;
}
class TestDelegate {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [123507] trunk/Tools
Title: [123507] trunk/Tools
Revision 123507
Author pe...@chromium.org
Date 2012-07-24 12:40:26 -0700 (Tue, 24 Jul 2012)
Log Message
Android-chromium layout tests failing with GPU related crash
https://bugs.webkit.org/show_bug.cgi?id=92126
Reviewed by Adam Barth.
Remove support for the --enable-hardware-gpu flag from run_webkit_tests,
as it's not being used by any port anymore, and neither is being passed
on to the test runner. Instead, append the flag directly to DRT for the
Chromium Android port, which does rely on this functionality.
The ChromiumAndroidUnitTest tests didn't catch this as the property was
set to True, but it's unable to detect whether they'll actually be used.
No occurrances of --enable-hardware-gpu exist in either Tools/Scripts/
or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_attributes):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
Diff
Modified: trunk/Tools/ChangeLog (123506 => 123507)
--- trunk/Tools/ChangeLog 2012-07-24 19:32:52 UTC (rev 123506)
+++ trunk/Tools/ChangeLog 2012-07-24 19:40:26 UTC (rev 123507)
@@ -1,3 +1,27 @@
+2012-07-24 Peter Beverloo pe...@chromium.org
+
+Android-chromium layout tests failing with GPU related crash
+https://bugs.webkit.org/show_bug.cgi?id=92126
+
+Reviewed by Adam Barth.
+
+Remove support for the --enable-hardware-gpu flag from run_webkit_tests,
+as it's not being used by any port anymore, and neither is being passed
+on to the test runner. Instead, append the flag directly to DRT for the
+Chromium Android port, which does rely on this functionality.
+
+The ChromiumAndroidUnitTest tests didn't catch this as the property was
+set to True, but it's unable to detect whether they'll actually be used.
+No occurrances of --enable-hardware-gpu exist in either Tools/Scripts/
+or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidPort.__init__):
+* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
+(ChromiumAndroidPortTest.test_attributes):
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+(parse_args):
+
2012-07-24 Alexander Shalamov alexander.shala...@intel.com
[WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (123506 => 123507)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-07-24 19:32:52 UTC (rev 123506)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-07-24 19:40:26 UTC (rev 123507)
@@ -161,7 +161,7 @@
self._options.additional_drt_flag.append('--encode-binary')
# The Chromium port for Android always uses the hardware GPU path.
-self._options.enable_hardware_gpu = True
+self._options.additional_drt_flag.append('--enable-hardware-gpu')
# Shard ref tests so that they run together to avoid repeatedly driver restarts.
self._options.shard_ref_tests = True
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py (123506 => 123507)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py 2012-07-24 19:32:52 UTC (rev 123506)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py 2012-07-24 19:40:26 UTC (rev 123507)
@@ -48,7 +48,6 @@
def test_attributes(self):
port = self.make_port()
-self.assertTrue(port.get_option('enable_hardware_gpu'))
self.assertEquals(port.baseline_path(), port._webkit_baseline_path('chromium-android'))
def test_default_timeout_ms(self):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (123506 => 123507)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-07-24 19:32:52 UTC (rev 123506)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-07-24 19:40:26 UTC (rev 123507)
@@ -246,10 +246,6 @@
action=""
default=False,
help=Use hardware accelerated painting of composited pages),
-optparse.make_option(--enable-hardware-gpu,
-action=""
-default=False,
-help=Run graphics tests on real GPU hardware vs software),
optparse.make_option(--per-tile-painting,
action=&
[webkit-changes] [123325] trunk/Source/WebKit/chromium
Title: [123325] trunk/Source/WebKit/chromium
Revision 123325
Author pe...@chromium.org
Date 2012-07-23 03:36:19 -0700 (Mon, 23 Jul 2012)
Log Message
[Chromium] Buildfix for fixing gclient on the Chromium Windows bot
https://bugs.webkit.org/show_bug.cgi?id=91977
Unreviewed build fix.
Add the tools/isolate directory to the Windows checkout as these files
currently are missing during gyp generation. maruel introduced the need
for these in this isolate refactoring, specifically this Chromium CL:
http://src.chromium.org/viewvc/chrome?view=revrevision=147689
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (123324 => 123325)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-23 10:05:19 UTC (rev 123324)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-23 10:36:19 UTC (rev 123325)
@@ -1,3 +1,17 @@
+2012-07-23 Peter Beverloo pe...@chromium.org
+
+[Chromium] Buildfix for fixing gclient on the Chromium Windows bot
+https://bugs.webkit.org/show_bug.cgi?id=91977
+
+Unreviewed build fix.
+
+Add the tools/isolate directory to the Windows checkout as these files
+currently are missing during gyp generation. maruel introduced the need
+for these in this isolate refactoring, specifically this Chromium CL:
+http://src.chromium.org/viewvc/chrome?view=revrevision=147689
+
+* DEPS:
+
2012-07-22 Kent Tamura tk...@chromium.org
[Chromium-Mac] Fix a build error.
Modified: trunk/Source/WebKit/chromium/DEPS (123324 => 123325)
--- trunk/Source/WebKit/chromium/DEPS 2012-07-23 10:05:19 UTC (rev 123324)
+++ trunk/Source/WebKit/chromium/DEPS 2012-07-23 10:36:19 UTC (rev 123325)
@@ -155,6 +155,8 @@
From('chromium_deps', 'src/third_party/nss'),
'third_party/perl':
From('chromium_deps', 'src/third_party/perl'),
+'tools/isolate':
+ Var('chromium_svn')+'/tools/isolate@'+Var('chromium_rev'),
# Dependencies used by libjpeg-turbo
'third_party/yasm/binaries':
From('chromium_deps', 'src/third_party/yasm/binaries'),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [122610] trunk/Source/WebCore
Title: [122610] trunk/Source/WebCore
Revision 122610
Author pe...@chromium.org
Date 2012-07-13 11:45:16 -0700 (Fri, 13 Jul 2012)
Log Message
[Chromium] Make the v8 i18n API dependency conditional for Android, disable strict aliasing
https://bugs.webkit.org/show_bug.cgi?id=91240
Reviewed by Adam Barth.
Disable the v8 internationalization API for Chromium Android, as it's
disabled and not always available in checkouts. Furthermore, disable
strict aliasing for the webkit_remaining target, similar to what
x11-based builds are doing (see the webcore_prerequisites target).
* WebCore.gyp/WebCore.gyp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
Diff
Modified: trunk/Source/WebCore/ChangeLog (122609 => 122610)
--- trunk/Source/WebCore/ChangeLog 2012-07-13 18:43:19 UTC (rev 122609)
+++ trunk/Source/WebCore/ChangeLog 2012-07-13 18:45:16 UTC (rev 122610)
@@ -1,3 +1,17 @@
+2012-07-13 Peter Beverloo pe...@chromium.org
+
+[Chromium] Make the v8 i18n API dependency conditional for Android, disable strict aliasing
+https://bugs.webkit.org/show_bug.cgi?id=91240
+
+Reviewed by Adam Barth.
+
+Disable the v8 internationalization API for Chromium Android, as it's
+disabled and not always available in checkouts. Furthermore, disable
+strict aliasing for the webkit_remaining target, similar to what
+x11-based builds are doing (see the webcore_prerequisites target).
+
+* WebCore.gyp/WebCore.gyp:
+
2012-07-13 Kentaro Hara hara...@chromium.org
[CallWith=XXX] arguments should be placed at the head of method arguments
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (122609 => 122610)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-07-13 18:43:19 UTC (rev 122609)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-07-13 18:45:16 UTC (rev 122610)
@@ -1892,7 +1892,6 @@
],
'dependencies': [
'webcore_prerequisites',
-'(chromium_src_dir)/third_party/v8-i18n/build/all.gyp:v8-i18n',
],
# This is needed for mac because of webkit_system_interface. It'd be nice
# if this hard dependency could be split off the rest.
@@ -2027,6 +2026,20 @@
['exclude', 'Gtk\\.cpp$'],
],
}],
+['OS==android', {
+ 'cflags': [
+# WebCore does not work with strict aliasing enabled.
+# https://bugs.webkit.org/show_bug.cgi?id=25864
+'-fno-strict-aliasing',
+ ],
+}, { # OS!=android
+ 'dependencies': [
+# Android doesn't have this third party repository, so can't
+# include it. It's not used by Android in any case.
+'(chromium_src_dir)/third_party/v8-i18n/build/all.gyp:v8-i18n',
+ ],
+ 'sources/': [['exclude', 'Android\\.cpp$']]
+}],
['OS!=mac', {
'sources/': [['exclude', 'Mac\\.(cpp|mm?)$']]
}],
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [122472] trunk/Source/WebKit/chromium
Title: [122472] trunk/Source/WebKit/chromium
Revision 122472
Author pe...@chromium.org
Date 2012-07-12 09:52:08 -0700 (Thu, 12 Jul 2012)
Log Message
[Chromium] Enable building APKs for TestWebKitAPI and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90989
Reviewed by Adam Barth.
Add dependencies on the webkit_unit_tests_apk and TestWebKitAPI_apk
targets for Android, making sure that we're generating the packages.
* All.gyp:
Modified Paths
trunk/Source/WebKit/chromium/All.gyp
trunk/Source/WebKit/chromium/ChangeLog
Diff
Modified: trunk/Source/WebKit/chromium/All.gyp (122471 => 122472)
--- trunk/Source/WebKit/chromium/All.gyp 2012-07-12 16:44:28 UTC (rev 122471)
+++ trunk/Source/WebKit/chromium/All.gyp 2012-07-12 16:52:08 UTC (rev 122472)
@@ -47,7 +47,9 @@
'conditions': [
['OS==android', {
'dependencies': [
+'WebKitUnitTests.gyp:webkit_unit_tests_apk',
'../../../Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:DumpRenderTree_apk',
+'../../../Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:TestWebKitAPI_apk',
],
}],
],
Modified: trunk/Source/WebKit/chromium/ChangeLog (122471 => 122472)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-12 16:44:28 UTC (rev 122471)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-12 16:52:08 UTC (rev 122472)
@@ -1,3 +1,15 @@
+2012-07-12 Peter Beverloo pe...@chromium.org
+
+[Chromium] Enable building APKs for TestWebKitAPI and webkit_unit_tests
+https://bugs.webkit.org/show_bug.cgi?id=90989
+
+Reviewed by Adam Barth.
+
+Add dependencies on the webkit_unit_tests_apk and TestWebKitAPI_apk
+targets for Android, making sure that we're generating the packages.
+
+* All.gyp:
+
2012-07-12 Leandro Gracia Gil leandrogra...@chromium.org
[Chromium] Remove unrequired API in WebSurroundingText.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [122220] trunk/Source/WebKit/chromium
Title: [10] trunk/Source/WebKit/chromium
Revision 10
Author pe...@chromium.org
Date 2012-07-10 06:31:26 -0700 (Tue, 10 Jul 2012)
Log Message
Unreviewed, rolling out r122207.
http://trac.webkit.org/changeset/122207
https://bugs.webkit.org/show_bug.cgi?id=90874
Broke the cr-windows bot (Requested by beverloo on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-07-10
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (122219 => 10)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-07-10 13:22:27 UTC (rev 122219)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-07-10 13:31:26 UTC (rev 10)
@@ -1,3 +1,13 @@
+2012-07-10 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r122207.
+http://trac.webkit.org/changeset/122207
+https://bugs.webkit.org/show_bug.cgi?id=90874
+
+Broke the cr-windows bot (Requested by beverloo on #webkit).
+
+* DEPS:
+
2012-07-10 Jochen Eisinger joc...@chromium.org
Unreviewed. Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/DEPS (122219 => 10)
--- trunk/Source/WebKit/chromium/DEPS 2012-07-10 13:22:27 UTC (rev 122219)
+++ trunk/Source/WebKit/chromium/DEPS 2012-07-10 13:31:26 UTC (rev 10)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '145845'
+ 'chromium_rev': '145569'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [121304] trunk/Source/WebKit/chromium
Title: [121304] trunk/Source/WebKit/chromium
Revision 121304
Author pe...@chromium.org
Date 2012-06-26 17:06:19 -0700 (Tue, 26 Jun 2012)
Log Message
[Chromium] Decrease the number of conditional blocks in features.gypi
https://bugs.webkit.org/show_bug.cgi?id=90013
Reviewed by Adam Barth.
Consolidate two Android-specific and accelerated-compositing-specific
conditional blocks into other blocks which serve an identical purpose.
* features.gypi:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (121303 => 121304)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-27 00:00:52 UTC (rev 121303)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-27 00:06:19 UTC (rev 121304)
@@ -1,3 +1,15 @@
+2012-06-26 Peter Beverloo pe...@chromium.org
+
+[Chromium] Decrease the number of conditional blocks in features.gypi
+https://bugs.webkit.org/show_bug.cgi?id=90013
+
+Reviewed by Adam Barth.
+
+Consolidate two Android-specific and accelerated-compositing-specific
+conditional blocks into other blocks which serve an identical purpose.
+
+* features.gypi:
+
2012-06-26 Dave Tu d...@chromium.org
[chromium] Expose rendering statistics to WebWidget.
Modified: trunk/Source/WebKit/chromium/features.gypi (121303 => 121304)
--- trunk/Source/WebKit/chromium/features.gypi 2012-06-27 00:00:52 UTC (rev 121303)
+++ trunk/Source/WebKit/chromium/features.gypi 2012-06-27 00:06:19 UTC (rev 121304)
@@ -137,6 +137,7 @@
'ENABLE_CALENDAR_PICKER=0',
'ENABLE_FONT_BOOSTING=1',
'ENABLE_INPUT_SPEECH=0',
+ 'ENABLE_INPUT_TYPE_COLOR=0',
'ENABLE_INPUT_TYPE_DATETIME=1',
'ENABLE_INPUT_TYPE_DATETIMELOCAL=1',
'ENABLE_INPUT_TYPE_MONTH=1',
@@ -157,11 +158,12 @@
'WTF_USE_NATIVE_FULLSCREEN_VIDEO=1',
],
'enable_touch_icon_loading': 1,
- }, {
+ }, { # OS!=android
'feature_defines': [
'ENABLE_CALENDAR_PICKER=1',
'ENABLE_FONT_BOOSTING=0',
'ENABLE_INPUT_SPEECH=1',
+ 'ENABLE_INPUT_TYPE_COLOR=1',
'ENABLE_JAVASCRIPT_I18N_API=1',
'ENABLE_LEGACY_NOTIFICATIONS=1',
'ENABLE_MEDIA_CAPTURE=0',
@@ -174,24 +176,11 @@
'ENABLE_WEB_AUDIO=1',
],
}],
- ['OS==android', {
-'feature_defines': [
- 'ENABLE_INPUT_TYPE_COLOR=0',
-],
- }, {
-'feature_defines': [
- 'ENABLE_INPUT_TYPE_COLOR=1',
-],
- }],
['use_accelerated_compositing==1', {
'feature_defines': [
- 'WTF_USE_ACCELERATED_COMPOSITING=1',
'ENABLE_3D_RENDERING=1',
-],
- }],
- ['use_accelerated_compositing==1', {
-'feature_defines': [
'ENABLE_ACCELERATED_2D_CANVAS=1',
+ 'WTF_USE_ACCELERATED_COMPOSITING=1',
],
}],
# Mac OS X uses Accelerate.framework FFT by default instead of FFmpeg.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [121028] trunk
Title: [121028] trunk
Revision 121028
Author pe...@chromium.org
Date 2012-06-22 09:20:33 -0700 (Fri, 22 Jun 2012)
Log Message
[Chromium] Disable c++0x compatibility warnings in _javascript_Core.gyp when building for Android
https://bugs.webkit.org/show_bug.cgi?id=88853
Reviewed by Steve Block.
The Android exclusions were necessary to fix a gyp generation error, as
the gcc_version variable wasn't being defined for Android. Remove these
exceptions when Chromium is able to define the gcc_version variable.
Source/_javascript_Core:
* _javascript_Core.gyp/_javascript_Core.gyp:
Source/WebCore:
* WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
* WebKit.gyp:
* WebKitUnitTests.gyp:
Source/WTF:
* WTF.gyp/WTF.gyp:
Tools:
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.gyp/WTF.gyp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/WebKitUnitTests.gyp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (121027 => 121028)
--- trunk/Source/_javascript_Core/ChangeLog 2012-06-22 16:00:48 UTC (rev 121027)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-06-22 16:20:33 UTC (rev 121028)
@@ -1,3 +1,16 @@
+2012-06-22 Peter Beverloo pe...@chromium.org
+
+[Chromium] Disable c++0x compatibility warnings in _javascript_Core.gyp when building for Android
+https://bugs.webkit.org/show_bug.cgi?id=88853
+
+Reviewed by Steve Block.
+
+The Android exclusions were necessary to fix a gyp generation error, as
+the gcc_version variable wasn't being defined for Android. Remove these
+exceptions when Chromium is able to define the gcc_version variable.
+
+* _javascript_Core.gyp/_javascript_Core.gyp:
+
2012-06-21 Filip Pizlo fpi...@apple.com
op_resolve_global should not prevent DFG inlining
Modified: trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp (121027 => 121028)
--- trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp 2012-06-22 16:00:48 UTC (rev 121027)
+++ trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp 2012-06-22 16:20:33 UTC (rev 121028)
@@ -47,7 +47,7 @@
],
},
'conditions': [
-['os_posix == 1 and OS != mac and OS != android and gcc_version==46', {
+['os_posix == 1 and OS != mac and gcc_version==46', {
'target_defaults': {
# Disable warnings about c++0x compatibility, as some names (such as nullptr) conflict
# with upcoming c++0x types.
Modified: trunk/Source/WTF/ChangeLog (121027 => 121028)
--- trunk/Source/WTF/ChangeLog 2012-06-22 16:00:48 UTC (rev 121027)
+++ trunk/Source/WTF/ChangeLog 2012-06-22 16:20:33 UTC (rev 121028)
@@ -1,3 +1,16 @@
+2012-06-22 Peter Beverloo pe...@chromium.org
+
+[Chromium] Disable c++0x compatibility warnings in _javascript_Core.gyp when building for Android
+https://bugs.webkit.org/show_bug.cgi?id=88853
+
+Reviewed by Steve Block.
+
+The Android exclusions were necessary to fix a gyp generation error, as
+the gcc_version variable wasn't being defined for Android. Remove these
+exceptions when Chromium is able to define the gcc_version variable.
+
+* WTF.gyp/WTF.gyp:
+
2012-06-18 Gustavo Noronha Silva gustavo.noro...@collabora.com
Causes crashes in LLVMPipe
Modified: trunk/Source/WTF/WTF.gyp/WTF.gyp (121027 => 121028)
--- trunk/Source/WTF/WTF.gyp/WTF.gyp 2012-06-22 16:00:48 UTC (rev 121027)
+++ trunk/Source/WTF/WTF.gyp/WTF.gyp 2012-06-22 16:20:33 UTC (rev 121028)
@@ -44,7 +44,7 @@
],
},
'conditions': [
-['os_posix == 1 and OS != mac and OS != android and gcc_version==46', {
+['os_posix == 1 and OS != mac and gcc_version==46', {
'target_defaults': {
# Disable warnings about c++0x compatibility, as some names (such as nullptr) conflict
# with upcoming c++0x types.
Modified: trunk/Source/WebCore/ChangeLog (121027 => 121028)
--- trunk/Source/WebCore/ChangeLog 2012-06-22 16:00:48 UTC (rev 121027)
+++ trunk/Source/WebCore/ChangeLog 2012-06-22 16:20:33 UTC (rev 121028)
@@ -1,3 +1,16 @@
+2012-06-22 Peter Beverloo pe...@chromium.org
+
+[Chromium] Disable c++0x compatibility warnings in _javascript_Core.gyp when building for Android
+https://bugs.webkit.org/show_bug.cgi?id=88853
+
+Reviewed by Steve Block.
+
+The Android exclusions were necessary to fix a gyp generation error, as
+the gcc_version variable wasn't being defined for Android. Remove these
+exceptions when Chromium is able to define the gcc_v
[webkit-changes] [120213] trunk/Source/WebKit/chromium
Title: [120213] trunk/Source/WebKit/chromium
Revision 120213
Author pe...@chromium.org
Date 2012-06-13 08:29:34 -0700 (Wed, 13 Jun 2012)
Log Message
[Chromium] Fix Clang build with USE(NATIVE_FULLSCREEN_VIDEO)=1
https://bugs.webkit.org/show_bug.cgi?id=88987
Reviewed by Simon Hausmann.
The enterFullscreen method is declared as const by MediaPlayerPrivateInterface,
so this one should be declared as such as well.
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120212 => 120213)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-13 15:15:44 UTC (rev 120212)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-13 15:29:34 UTC (rev 120213)
@@ -1,3 +1,20 @@
+2012-06-13 Peter Beverloo pe...@chromium.org
+
+[Chromium] Fix Clang build with USE(NATIVE_FULLSCREEN_VIDEO)=1
+https://bugs.webkit.org/show_bug.cgi?id=88987
+
+Reviewed by Simon Hausmann.
+
+The enterFullscreen method is declared as const by MediaPlayerPrivateInterface,
+so this one should be declared as such as well.
+
+Patch by Evgeniy Stepanov euge...@google.com
+
+* src/WebMediaPlayerClientImpl.cpp:
+(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
+* src/WebMediaPlayerClientImpl.h:
+(WebMediaPlayerClientImpl):
+
2012-06-13 MORITA Hajime morr...@google.com
REGRESSION(r118098): content element does not render distributed children when cloned from another document
Modified: trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp (120212 => 120213)
--- trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp 2012-06-13 15:15:44 UTC (rev 120212)
+++ trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp 2012-06-13 15:29:34 UTC (rev 120213)
@@ -370,7 +370,7 @@
}
#if USE(NATIVE_FULLSCREEN_VIDEO)
-void WebMediaPlayerClientImpl::enterFullscreen()
+void WebMediaPlayerClientImpl::enterFullscreen() const
{
if (m_webMediaPlayer)
m_webMediaPlayer-enterFullscreen();
Modified: trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h (120212 => 120213)
--- trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h 2012-06-13 15:15:44 UTC (rev 120212)
+++ trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h 2012-06-13 15:29:34 UTC (rev 120213)
@@ -139,7 +139,7 @@
virtual unsigned audioDecodedByteCount() const;
virtual unsigned videoDecodedByteCount() const;
#if USE(NATIVE_FULLSCREEN_VIDEO)
-virtual void enterFullscreen();
+virtual void enterFullscreen() const;
virtual void exitFullscreen();
virtual bool canEnterFullscreen() const;
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119987] trunk/Source/WebCore
Title: [119987] trunk/Source/WebCore
Revision 119987
Author pe...@chromium.org
Date 2012-06-11 11:13:57 -0700 (Mon, 11 Jun 2012)
Log Message
[Chromium] Theme updates for Android in menu list rendering and selection backgrounds
https://bugs.webkit.org/show_bug.cgi?id=88775
Reviewed by Adam Barth.
For Chrome on Android, use the width of the scrollbar down arrow instead
of the scrollbar's width for determining the arrow padding to apply for
menu list rendering, as WebKit isn't drawing a scrollbar (thus width=0).
Furthermore, change the default active selection background color to be
equal to the tap highlighting color.
These changes should be covered by existing layout tests.
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):
(WebCore): Retrieve the scrollbar down arrow's size via PlatformSupport.
* rendering/RenderThemeChromiumAndroid.h: Override the menuListArrowPadding
and platformActiveSelectionBackgroundColor methods, and add a static
static RGBA32 color for the default active selection bg color.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::menuListArrowPadding): Default to
the scrollbar thickness, not changing behavior for non-Android.
(WebCore::RenderThemeChromiumSkia::menuListInternalPadding): Instead
of polling the scrollbar thickness, call menuListArrowPadding().
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia): Add the menuListArrowPadding() as a protected method.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.cpp
trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.h
trunk/Source/WebCore/rendering/RenderThemeChromiumSkia.cpp
trunk/Source/WebCore/rendering/RenderThemeChromiumSkia.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (119986 => 119987)
--- trunk/Source/WebCore/ChangeLog 2012-06-11 17:39:41 UTC (rev 119986)
+++ trunk/Source/WebCore/ChangeLog 2012-06-11 18:13:57 UTC (rev 119987)
@@ -1,3 +1,33 @@
+2012-06-11 Peter Beverloo pe...@chromium.org
+
+[Chromium] Theme updates for Android in menu list rendering and selection backgrounds
+https://bugs.webkit.org/show_bug.cgi?id=88775
+
+Reviewed by Adam Barth.
+
+For Chrome on Android, use the width of the scrollbar down arrow instead
+of the scrollbar's width for determining the arrow padding to apply for
+menu list rendering, as WebKit isn't drawing a scrollbar (thus width=0).
+
+Furthermore, change the default active selection background color to be
+equal to the tap highlighting color.
+
+These changes should be covered by existing layout tests.
+
+* rendering/RenderThemeChromiumAndroid.cpp:
+(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):
+(WebCore): Retrieve the scrollbar down arrow's size via PlatformSupport.
+* rendering/RenderThemeChromiumAndroid.h: Override the menuListArrowPadding
+and platformActiveSelectionBackgroundColor methods, and add a static
+static RGBA32 color for the default active selection bg color.
+* rendering/RenderThemeChromiumSkia.cpp:
+(WebCore::RenderThemeChromiumSkia::menuListArrowPadding): Default to
+the scrollbar thickness, not changing behavior for non-Android.
+(WebCore::RenderThemeChromiumSkia::menuListInternalPadding): Instead
+of polling the scrollbar thickness, call menuListArrowPadding().
+* rendering/RenderThemeChromiumSkia.h:
+(RenderThemeChromiumSkia): Add the menuListArrowPadding() as a protected method.
+
2012-06-11 David Barr davidb...@chromium.org
Add css3-images image-resolution (dppx only)
Modified: trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.cpp (119986 => 119987)
--- trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.cpp 2012-06-11 17:39:41 UTC (rev 119986)
+++ trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.cpp 2012-06-11 18:13:57 UTC (rev 119987)
@@ -99,4 +99,12 @@
#endif
}
+int RenderThemeChromiumAndroid::menuListArrowPadding() const
+{
+// We cannot use the scrollbar thickness here, as it's width is 0 on Android.
+// Instead, use the width of the scrollbar down arrow.
+IntSize scrollbarSize = PlatformSupport::getThemePartSize(PlatformSupport::PartScrollbarDownArrow);
+return scrollbarSize.width();
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.h (119986 => 119987)
--- trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.h 2012-06-11 17:39:41 UTC (rev 119986)
+++ trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.h 2012-06-11 18:13:57 UTC (rev 119987)
@@ -41,7 +41,7 @@
virtual bool delegatesMenuListRendering() const OVERRIDE { return true; }
-virtual bool paintMediaFullscreenButton(RenderObject*, const PaintInfo, const IntRect);
+vir
[webkit-changes] [119813] trunk/Source/WebKit/chromium
Title: [119813] trunk/Source/WebKit/chromium Revision 119813 Author pe...@chromium.org Date 2012-06-08 02:09:23 -0700 (Fri, 08 Jun 2012) Log Message [Chromium] Re-enable SHARED_WORKERS for Android until a build fix has been resolved. https://bugs.webkit.org/show_bug.cgi?id=88637 Unreviewed build fix. Linking content_shell on the Chromium side fails due to an unresolved call to WebSharedWorker::create(). Since this blocks WebKit rolls, temporarily re-enable the feature until this has been solved. * features.gypi: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/features.gypi Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (119812 => 119813) --- trunk/Source/WebKit/chromium/ChangeLog 2012-06-08 08:29:43 UTC (rev 119812) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-08 09:09:23 UTC (rev 119813) @@ -1,3 +1,16 @@ +2012-06-08 Peter Beverloo pe...@chromium.org + +[Chromium] Re-enable SHARED_WORKERS for Android until a build fix has been resolved. +https://bugs.webkit.org/show_bug.cgi?id=88637 + +Unreviewed build fix. + +Linking content_shell on the Chromium side fails due to an unresolved +call to WebSharedWorker::create(). Since this blocks WebKit rolls, +temporarily re-enable the feature until this has been solved. + +* features.gypi: + 2012-06-07 Nico Weber tha...@chromium.org [chromium/mac] Improve deviceDPI, rect, and availableRect computation Modified: trunk/Source/WebKit/chromium/features.gypi (119812 => 119813) --- trunk/Source/WebKit/chromium/features.gypi 2012-06-08 08:29:43 UTC (rev 119812) +++ trunk/Source/WebKit/chromium/features.gypi 2012-06-08 09:09:23 UTC (rev 119813) @@ -148,7 +148,9 @@ 'ENABLE_ORIENTATION_EVENTS=1', 'ENABLE_OVERFLOW_SCROLLING=1', 'ENABLE_PAGE_POPUP=0', - 'ENABLE_SHARED_WORKERS=0', + # FIXME: Disable once the linking error has been resolved. + # https://bugs.webkit.org/show_bug.cgi?id=88636 + 'ENABLE_SHARED_WORKERS=1', 'ENABLE_WEB_AUDIO=0', 'WTF_USE_NATIVE_FULLSCREEN_VIDEO=1', ], ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119743] trunk/Source/WebCore
Title: [119743] trunk/Source/WebCore Revision 119743 Author pe...@chromium.org Date 2012-06-07 11:46:51 -0700 (Thu, 07 Jun 2012) Log Message Buildfix for ENABLE_OVERFLOW_SCROLLING=0 (though defined) https://bugs.webkit.org/show_bug.cgi?id=88564 Reviewed by Adam Barth. Where ENABLE(X) mandates that X both has to be defined and evaluates to true as a lone preprocessor statement, there were two places in the CSS property and value input files where only was checked whether is has been defined. This also goes against other #ifdefs in those files. * css/CSSPropertyNames.in: * css/CSSValueKeywords.in: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/CSSValueKeywords.in Diff Modified: trunk/Source/WebCore/ChangeLog (119742 => 119743) --- trunk/Source/WebCore/ChangeLog 2012-06-07 18:37:39 UTC (rev 119742) +++ trunk/Source/WebCore/ChangeLog 2012-06-07 18:46:51 UTC (rev 119743) @@ -1,3 +1,18 @@ +2012-06-07 Peter Beverloo pe...@chromium.org + +Buildfix for ENABLE_OVERFLOW_SCROLLING=0 (though defined) +https://bugs.webkit.org/show_bug.cgi?id=88564 + +Reviewed by Adam Barth. + +Where ENABLE(X) mandates that X both has to be defined and evaluates to +true as a lone preprocessor statement, there were two places in the CSS +property and value input files where only was checked whether is has +been defined. This also goes against other #ifdefs in those files. + +* css/CSSPropertyNames.in: +* css/CSSValueKeywords.in: + 2012-06-07 Ami Fischman fisch...@chromium.org Plumb CORS attribute information from HTMLMediaElement to media players so it can be used Modified: trunk/Source/WebCore/css/CSSPropertyNames.in (119742 => 119743) --- trunk/Source/WebCore/css/CSSPropertyNames.in 2012-06-07 18:37:39 UTC (rev 119742) +++ trunk/Source/WebCore/css/CSSPropertyNames.in 2012-06-07 18:46:51 UTC (rev 119743) @@ -390,6 +390,6 @@ #if defined(ENABLE_DASHBOARD_SUPPORT) ENABLE_DASHBOARD_SUPPORT -webkit-dashboard-region #endif -#if defined(ENABLE_OVERFLOW_SCROLLING) +#if defined(ENABLE_OVERFLOW_SCROLLING) ENABLE_OVERFLOW_SCROLLING -webkit-overflow-scrolling #endif Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (119742 => 119743) --- trunk/Source/WebCore/css/CSSValueKeywords.in 2012-06-07 18:37:39 UTC (rev 119742) +++ trunk/Source/WebCore/css/CSSValueKeywords.in 2012-06-07 18:46:51 UTC (rev 119743) @@ -820,7 +820,7 @@ manual // auto -#if defined(ENABLE_OVERFLOW_SCROLLING) +#if defined(ENABLE_OVERFLOW_SCROLLING) ENABLE_OVERFLOW_SCROLLING // -webkit-overflow-scrolling // auto touch ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119749] trunk/Source/WebKit/chromium
Title: [119749] trunk/Source/WebKit/chromium
Revision 119749
Author pe...@chromium.org
Date 2012-06-07 13:07:59 -0700 (Thu, 07 Jun 2012)
Log Message
[Chromium] features.gypi should have the correct definitions for Android
https://bugs.webkit.org/show_bug.cgi?id=88533
Reviewed by Adam Barth.
Make all features which are enabled on Android but disabled on other platforms,
or are disabled on Android while enabled on other platforms, conditional. This
also means that the selection of code compiled for Android will slightly change.
This change also removes the enable_viewport variable as the value of this is
no longer respected by WebKit - it's enabled by default for all of Chromium.
Furthermore, ENABLE_OVERFLOW_SCROLLING is now listed in features.gypi again.
* features.gypi:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (119748 => 119749)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-07 20:06:57 UTC (rev 119748)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-07 20:07:59 UTC (rev 119749)
@@ -1,3 +1,20 @@
+2012-06-07 Peter Beverloo pe...@chromium.org
+
+[Chromium] features.gypi should have the correct definitions for Android
+https://bugs.webkit.org/show_bug.cgi?id=88533
+
+Reviewed by Adam Barth.
+
+Make all features which are enabled on Android but disabled on other platforms,
+or are disabled on Android while enabled on other platforms, conditional. This
+also means that the selection of code compiled for Android will slightly change.
+
+This change also removes the enable_viewport variable as the value of this is
+no longer respected by WebKit - it's enabled by default for all of Chromium.
+Furthermore, ENABLE_OVERFLOW_SCROLLING is now listed in features.gypi again.
+
+* features.gypi:
+
2012-06-07 Dana Jansens dan...@chromium.org
[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
Modified: trunk/Source/WebKit/chromium/features.gypi (119748 => 119749)
--- trunk/Source/WebKit/chromium/features.gypi 2012-06-07 20:06:57 UTC (rev 119748)
+++ trunk/Source/WebKit/chromium/features.gypi 2012-06-07 20:07:59 UTC (rev 119749)
@@ -63,29 +63,18 @@
'ENABLE_ICONDATABASE=0',
'ENABLE_IFRAME_SEAMLESS=1',
'ENABLE_INDEXED_DATABASE=1',
- 'ENABLE_INPUT_SPEECH=1',
'ENABLE_INPUT_TYPE_DATE=1',
- 'ENABLE_INPUT_TYPE_DATETIME=0',
- 'ENABLE_INPUT_TYPE_DATETIMELOCAL=0',
- 'ENABLE_INPUT_TYPE_MONTH=0',
- 'ENABLE_INPUT_TYPE_TIME=0',
- 'ENABLE_INPUT_TYPE_WEEK=0',
'ENABLE_JAVASCRIPT_DEBUGGER=1',
- 'ENABLE_JAVASCRIPT_I18N_API=1',
'ENABLE_LEGACY_CSS_VENDOR_PREFIXES=0',
- 'ENABLE_LEGACY_NOTIFICATIONS=1',
'ENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1',
'ENABLE_LINK_PREFETCH=1',
'ENABLE_LINK_PRERENDER=1',
'ENABLE_MEDIA_SOURCE=1',
'ENABLE_MEDIA_STATISTICS=1',
- 'ENABLE_MEDIA_STREAM=1',
'ENABLE_METER_TAG=1',
'ENABLE_MHTML=1',
'ENABLE_MICRODATA=0',
'ENABLE_MUTATION_OBSERVERS=(enable_mutation_observers)',
- 'ENABLE_NOTIFICATIONS=1',
- 'ENABLE_ORIENTATION_EVENTS=0',
'ENABLE_PAGE_VISIBILITY_API=1',
'ENABLE_POINTER_LOCK=1',
'ENABLE_PROGRESS_TAG=1',
@@ -96,7 +85,6 @@
'ENABLE_SANDBOX=1',
'ENABLE_SCRIPTED_SPEECH=1',
'ENABLE_SHADOW_DOM=1',
- 'ENABLE_SHARED_WORKERS=1',
'ENABLE_SMOOTH_SCROLLING=1',
'ENABLE_SQL_DATABASE=1',
'ENABLE_STYLE_SCOPED=1',
@@ -133,7 +121,6 @@
'use_accelerated_compositing%': 1,
'enable_skia_text%': 1,
'enable_svg%': 1,
- 'enable_viewport%': 0,
'enable_touch_events%': 1,
'enable_touch_icon_loading%' : 0,
'enable_mutation_observers%': 1,
@@ -147,17 +134,44 @@
'feature_defines': [
'ENABLE_CALENDAR_PICKER=0',
'ENABLE_FONT_BOOSTING=1',
+ 'ENABLE_INPUT_SPEECH=0',
+ 'ENABLE_INPUT_TYPE_DATETIME=1',
+ 'ENABLE_INPUT_TYPE_DATETIMELOCAL=1',
+ 'ENABLE_INPUT_TYPE_MONTH=1',
+ 'ENABLE_INPUT_TYPE_TIME=1',
+ 'ENABLE_INPUT_TYPE_WEEK=1',
+ 'ENABLE_JAVASCRIPT_I18N_API=0',
+ 'ENABLE_LEGACY_NOTIFICATIONS=0',
'ENABLE_MEDIA_CAPTURE=1',
+ 'ENABLE_MEDIA_STREAM=0',
+ 'ENABLE_NOTIFICATIONS=0',
+ 'ENABLE_ORIENTATION_EVENTS=1',
+ 'ENABLE_OVERFLOW_SCROLLING=1',
'ENABLE_PAGE_POPUP=0',
+ 'ENABLE_SHARED_WORKERS=0',
'ENABLE_WEB_AUDIO=0',
'WTF_USE_NATIVE_FULLSCREEN_VIDEO=1',
],
+'enable_touch_icon_loading': 1,
}, {
'feature_defines': [
'ENABLE_CALENDAR_PICKER=1',
'ENABLE_FONT_BOOSTING=0',
+ 'ENABLE_INPUT_SPEECH=1',
+ 'ENABLE_INPUT_TYPE_DATETIME=0',
+ 'ENABLE_INPUT_TYPE_DATETIMEL
[webkit-changes] [119077] trunk
Title: [119077] trunk
Revision 119077
Author pe...@chromium.org
Date 2012-05-31 02:22:45 -0700 (Thu, 31 May 2012)
Log Message
[Chromium] Automatically install 64-bit linker for Android
https://bugs.webkit.org/show_bug.cgi?id=79780
Reviewed by Adam Barth.
Source/WebKit/chromium:
Change the Android-specific dependencies to inherit their revision from
Chromium's DEPS file, like many other dependencies do, solving the
versioning problem that we're running in to right now. These are listed
in Chromium's main DEPS file starting Chromium r139529.
* DEPS:
Tools:
Change the update-webkit-chromium script to check whether the 64-bit
linker needs to be installed as part of the update process. The actual
code for doing these checks and installing it has been added to the
webkitdirs.pm script.
The linker itself is part of the third_party/aosp repository, which
will be pulled in through the DEPS change.
* Scripts/update-webkit-chromium:
* Scripts/webkitdirs.pm:
(chromiumInstall64BitAndroidLinkerIfNeeded):
(chromiumReplaceAndroidLinkerIfNeeded):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
trunk/Tools/ChangeLog
trunk/Tools/Scripts/update-webkit-chromium
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (119076 => 119077)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-05-31 09:02:02 UTC (rev 119076)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-05-31 09:22:45 UTC (rev 119077)
@@ -1,3 +1,17 @@
+2012-05-30 Peter Beverloo pe...@chromium.org
+
+[Chromium] Automatically install 64-bit linker for Android
+https://bugs.webkit.org/show_bug.cgi?id=79780
+
+Reviewed by Adam Barth.
+
+Change the Android-specific dependencies to inherit their revision from
+Chromium's DEPS file, like many other dependencies do, solving the
+versioning problem that we're running in to right now. These are listed
+in Chromium's main DEPS file starting Chromium r139529.
+
+* DEPS:
+
2012-05-31 Yoshifumi Inoue yo...@chromium.org
Build fix for Chromium Linux (Tests) after r119073.
Modified: trunk/Source/WebKit/chromium/DEPS (119076 => 119077)
--- trunk/Source/WebKit/chromium/DEPS 2012-05-31 09:02:02 UTC (rev 119076)
+++ trunk/Source/WebKit/chromium/DEPS 2012-05-31 09:22:45 UTC (rev 119077)
@@ -167,10 +167,12 @@
From('chromium_deps', 'src/third_party/openssl'),
},
'android': {
+'tools/android':
+ Var('chromium_svn') + '/tools/android@' + Var('chromium_rev'),
'third_party/freetype':
- 'https://git.chromium.org/chromium/src/third_party/freetype.git',
-'tools/android':
- Var('chromium_svn')+'/tools/android@'+Var('chromium_rev'),
+ From('chromium_deps', 'src/third_party/freetype'),
+'third_party/aosp':
+ From('chromium_deps', 'src/third_party/aosp'),
},
}
Modified: trunk/Tools/ChangeLog (119076 => 119077)
--- trunk/Tools/ChangeLog 2012-05-31 09:02:02 UTC (rev 119076)
+++ trunk/Tools/ChangeLog 2012-05-31 09:22:45 UTC (rev 119077)
@@ -1,3 +1,23 @@
+2012-05-30 Peter Beverloo pe...@chromium.org
+
+[Chromium] Automatically install 64-bit linker for Android
+https://bugs.webkit.org/show_bug.cgi?id=79780
+
+Reviewed by Adam Barth.
+
+Change the update-webkit-chromium script to check whether the 64-bit
+linker needs to be installed as part of the update process. The actual
+code for doing these checks and installing it has been added to the
+webkitdirs.pm script.
+
+The linker itself is part of the third_party/aosp repository, which
+will be pulled in through the DEPS change.
+
+* Scripts/update-webkit-chromium:
+* Scripts/webkitdirs.pm:
+(chromiumInstall64BitAndroidLinkerIfNeeded):
+(chromiumReplaceAndroidLinkerIfNeeded):
+
2012-05-30 Stephanie Lewis sle...@apple.com
https://bugs.webkit.org/show_bug.cgi?id=87803
Modified: trunk/Tools/Scripts/update-webkit-chromium (119076 => 119077)
--- trunk/Tools/Scripts/update-webkit-chromium 2012-05-31 09:02:02 UTC (rev 119076)
+++ trunk/Tools/Scripts/update-webkit-chromium 2012-05-31 09:22:45 UTC (rev 119077)
@@ -55,7 +55,7 @@
# If .gclient configuration file doesn't exist, create it.
print Configuring gclient...\n;
system($gclientPath,
- config,
+ config,
--spec=solutions=[{'name':'./','url':None}]) == 0 or die $!;
}
@@ -72,7 +72,13 @@
die Couldn't extract the Android NDK. if $result;
}
-$ENV{ANDROID_NDK_ROOT} = sourceDir() . /Source/WebKit/chromium/android-ndk-r7b;
+my $androidNdkRoot = sourceDir() . /Source/WebKit/chromium/android-ndk-r7b;
+
+# Attempt to replace the NDK's linker with a 64-bit version if the host
+# OS is Linux. This will significantly speed up link times.
+chromiumInstall64BitAndroidLinkerIfNeeded($androidNdkRoot) if isLinux();
