[webkit-changes] [147323] trunk/Source/WebCore
Title: [147323] trunk/Source/WebCore
Revision 147323
Author pfeld...@chromium.org
Date 2013-04-01 07:03:47 -0700 (Mon, 01 Apr 2013)
Log Message
Web Inspector: Go to line dialog has 0 height, viewport dialogs have empty gaps.
https://bugs.webkit.org/show_bug.cgi?id=113702
Reviewed by Yury Semikhatsky.
* inspector/front-end/DOMExtension.js:
(Element.prototype.measurePreferredSize):
* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._innerShow):
* inspector/front-end/ViewportControl.js:
(WebInspector.ViewportControl.prototype.refresh):
* inspector/front-end/dialog.css:
(.dialog-contents):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DOMExtension.js
trunk/Source/WebCore/inspector/front-end/Popover.js
trunk/Source/WebCore/inspector/front-end/ViewportControl.js
trunk/Source/WebCore/inspector/front-end/dialog.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (147322 => 147323)
--- trunk/Source/WebCore/ChangeLog 2013-04-01 12:52:13 UTC (rev 147322)
+++ trunk/Source/WebCore/ChangeLog 2013-04-01 14:03:47 UTC (rev 147323)
@@ -1,3 +1,19 @@
+2013-04-01 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: Go to line dialog has 0 height, viewport dialogs have empty gaps.
+https://bugs.webkit.org/show_bug.cgi?id=113702
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DOMExtension.js:
+(Element.prototype.measurePreferredSize):
+* inspector/front-end/Popover.js:
+(WebInspector.Popover.prototype._innerShow):
+* inspector/front-end/ViewportControl.js:
+(WebInspector.ViewportControl.prototype.refresh):
+* inspector/front-end/dialog.css:
+(.dialog-contents):
+
2013-04-01 Andrey Lushnikov lushni...@chromium.org
Web Inspector: [DTE] Convertion between text and coordinates
Modified: trunk/Source/WebCore/inspector/front-end/DOMExtension.js (147322 => 147323)
--- trunk/Source/WebCore/inspector/front-end/DOMExtension.js 2013-04-01 12:52:13 UTC (rev 147322)
+++ trunk/Source/WebCore/inspector/front-end/DOMExtension.js 2013-04-01 14:03:47 UTC (rev 147323)
@@ -245,15 +245,16 @@
}
/**
+ * @param {Element} containerElement
* @return {Size}
*/
-Element.prototype.measurePreferredSize = function()
+Element.prototype.measurePreferredSize = function(containerElement)
{
-document.body.appendChild(this);
+containerElement.appendChild(this);
this.positionAt(0, 0);
var result = new Size(this.offsetWidth, this.offsetHeight);
this.positionAt(undefined, undefined);
-document.body.removeChild(this);
+this.removeSelf();
return result;
}
Modified: trunk/Source/WebCore/inspector/front-end/Popover.js (147322 => 147323)
--- trunk/Source/WebCore/inspector/front-end/Popover.js 2013-04-01 12:52:13 UTC (rev 147322)
+++ trunk/Source/WebCore/inspector/front-end/Popover.js 2013-04-01 14:03:47 UTC (rev 147323)
@@ -94,7 +94,7 @@
WebInspector.Popover._popover = this;
// Temporarily attach in order to measure preferred dimensions.
-var preferredSize = view ? view.measurePreferredSize() : this.contentElement.measurePreferredSize();
+var preferredSize = view ? view.measurePreferredSize() : this.contentElement.measurePreferredSize(this._contentDiv);
preferredWidth = preferredWidth || preferredSize.width;
preferredHeight = preferredHeight || preferredSize.height;
Modified: trunk/Source/WebCore/inspector/front-end/ViewportControl.js (147322 => 147323)
--- trunk/Source/WebCore/inspector/front-end/ViewportControl.js 2013-04-01 12:52:13 UTC (rev 147322)
+++ trunk/Source/WebCore/inspector/front-end/ViewportControl.js 2013-04-01 14:03:47 UTC (rev 147323)
@@ -87,7 +87,7 @@
if (!this._rowHeight) {
var firstElement = this._provider.itemElement(0);
-this._rowHeight = firstElement.measurePreferredSize().height;
+this._rowHeight = firstElement.measurePreferredSize(this._contentElement).height;
}
var visibleFrom = this.element.scrollTop;
@@ -95,6 +95,7 @@
this._firstVisibleIndex = Math.floor(visibleFrom / this._rowHeight);
this._lastVisibleIndex = Math.min(Math.ceil(visibleTo / this._rowHeight), itemCount) - 1;
+
this._topGapElement.style.height = (this._rowHeight * this._firstVisibleIndex) + px;
this._bottomGapElement.style.height = (this._rowHeight * (itemCount - this._lastVisibleIndex - 1)) + px;
Modified: trunk/Source/WebCore/inspector/front-end/dialog.css (147322 => 147323)
--- trunk/Source/WebCore/inspector/front-end/dialog.css 2013-04-01 12:52:13 UTC (rev 147322)
+++ trunk/Source/WebCore/inspector/front-end/dialog.css 2013-04-01 14:03:47 UTC (rev 147323)
@@ -17,8 +17,6 @@
.dialog-contents {
width: 100%;
-height: 100%;
-
font-size: 11px;
font-family: 'Lucida Grande', sans-serif;
}
___
[webkit-changes] [147331] trunk/Source/WebCore
Title: [147331] trunk/Source/WebCore
Revision 147331
Author pfeld...@chromium.org
Date 2013-04-01 09:14:31 -0700 (Mon, 01 Apr 2013)
Log Message
Web Inspector: follow up to r147323, popover is empty on network panel.
Not reviewed.
* inspector/front-end/DOMExtension.js:
(Element.prototype.measurePreferredSize):
* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._innerShow):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DOMExtension.js
trunk/Source/WebCore/inspector/front-end/Popover.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (147330 => 147331)
--- trunk/Source/WebCore/ChangeLog 2013-04-01 16:01:01 UTC (rev 147330)
+++ trunk/Source/WebCore/ChangeLog 2013-04-01 16:14:31 UTC (rev 147331)
@@ -1,3 +1,13 @@
+2013-04-01 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: follow up to r147323, popover is empty on network panel.
+Not reviewed.
+
+* inspector/front-end/DOMExtension.js:
+(Element.prototype.measurePreferredSize):
+* inspector/front-end/Popover.js:
+(WebInspector.Popover.prototype._innerShow):
+
2013-04-01 Dmitry Zvorygin zvory...@chromium.org
Web Inspector: Exception in console on attempt to filter _javascript_ messages.
Modified: trunk/Source/WebCore/inspector/front-end/DOMExtension.js (147330 => 147331)
--- trunk/Source/WebCore/inspector/front-end/DOMExtension.js 2013-04-01 16:01:01 UTC (rev 147330)
+++ trunk/Source/WebCore/inspector/front-end/DOMExtension.js 2013-04-01 16:14:31 UTC (rev 147331)
@@ -245,11 +245,12 @@
}
/**
- * @param {Element} containerElement
+ * @param {Element=} containerElement
* @return {Size}
*/
Element.prototype.measurePreferredSize = function(containerElement)
{
+containerElement = containerElement || document.body;
containerElement.appendChild(this);
this.positionAt(0, 0);
var result = new Size(this.offsetWidth, this.offsetHeight);
Modified: trunk/Source/WebCore/inspector/front-end/Popover.js (147330 => 147331)
--- trunk/Source/WebCore/inspector/front-end/Popover.js 2013-04-01 16:01:01 UTC (rev 147330)
+++ trunk/Source/WebCore/inspector/front-end/Popover.js 2013-04-01 16:14:31 UTC (rev 147331)
@@ -94,7 +94,7 @@
WebInspector.Popover._popover = this;
// Temporarily attach in order to measure preferred dimensions.
-var preferredSize = view ? view.measurePreferredSize() : this.contentElement.measurePreferredSize(this._contentDiv);
+var preferredSize = view ? view.measurePreferredSize() : this.contentElement.measurePreferredSize();
preferredWidth = preferredWidth || preferredSize.width;
preferredHeight = preferredHeight || preferredSize.height;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [147341] branches/chromium/1410
Title: [147341] branches/chromium/1410
Revision 147341
Author pfeld...@chromium.org
Date 2013-04-01 11:00:27 -0700 (Mon, 01 Apr 2013)
Log Message
Revert 140817 Web Inspector: [Styles] Editing a property value ...
BUG=225346
Web Inspector: [Styles] Editing a property value containing a trimmed data: URL breaks the style
https://bugs.webkit.org/show_bug.cgi?id=107936
Reviewed by Yury Semikhatsky.
Source/WebCore:
Restore the original CSS property value before editing.
Test: inspector/styles/edit-value-with-trimmed-url.html
* inspector/front-end/StylesSidebarPane.js:
LayoutTests:
* inspector/styles/edit-value-with-trimmed-url-expected.txt: Added.
* inspector/styles/edit-value-with-trimmed-url.html: Added.
TBR=apav...@chromium.org
Review URL: https://codereview.chromium.org/13084008
Modified Paths
branches/chromium/1410/Source/WebCore/inspector/front-end/StylesSidebarPane.js
Removed Paths
branches/chromium/1410/LayoutTests/inspector/styles/edit-value-with-trimmed-url-expected.txt
branches/chromium/1410/LayoutTests/inspector/styles/edit-value-with-trimmed-url.html
Diff
Deleted: branches/chromium/1410/LayoutTests/inspector/styles/edit-value-with-trimmed-url-expected.txt (147340 => 147341)
--- branches/chromium/1410/LayoutTests/inspector/styles/edit-value-with-trimmed-url-expected.txt 2013-04-01 17:57:19 UTC (rev 147340)
+++ branches/chromium/1410/LayoutTests/inspector/styles/edit-value-with-trimmed-url-expected.txt 2013-04-01 18:00:27 UTC (rev 147341)
@@ -1,7 +0,0 @@
-Tests that editing a CSS property value in the Styles pane restores the original, non-trimmed value text. Bug 107936.
-
-Viewing 'background' value in Styles:
-transparent url(data:image/png;base64,iVBORw0KGgoNSUhEUgEBCAIAAACQd1PeGXRFW…9iZSBJbWFnZVJlYWR5ccllPA5JREFUeNpiYGBgAAgwAAAEAAGbA+oJAElFTkSuQmCC) repeat-y 50% top
-Editing 'background' value in Styles:
-transparent url(data:image/png;base64,iVBORw0KGgoNSUhEUgEBCAIAAACQd1PeGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPA5JREFUeNpiYGBgAAgwAAAEAAGbA+oJAElFTkSuQmCC) repeat-y 50% top
-
Deleted: branches/chromium/1410/LayoutTests/inspector/styles/edit-value-with-trimmed-url.html (147340 => 147341)
--- branches/chromium/1410/LayoutTests/inspector/styles/edit-value-with-trimmed-url.html 2013-04-01 17:57:19 UTC (rev 147340)
+++ branches/chromium/1410/LayoutTests/inspector/styles/edit-value-with-trimmed-url.html 2013-04-01 18:00:27 UTC (rev 147341)
@@ -1,36 +0,0 @@
-html
-head
-script src=""
-script src=""
-script
-
-function test()
-{
-WebInspector.showPanel(elements);
-InspectorTest.selectNodeAndWaitForStyles(inspected, step1);
-
-function step1()
-{
-var treeElement = InspectorTest.getElementStylePropertyTreeItem(background);
-InspectorTest.addResult(Viewing 'background' value in Styles:);
-InspectorTest.addResult(treeElement.valueElement.textContent);
-
-treeElement.startEditing(treeElement.valueElement);
-InspectorTest.addResult(Editing 'background' value in Styles:);
-InspectorTest.addResult(treeElement.valueElement.textContent);
-InspectorTest.completeTest();
-}
-}
-
-/script
-/head
-
-body _onload_=runTest()
-p
-Tests that editing a CSS property value in the Styles pane restores the original, non-trimmed value text. a href="" 107936/a.
-/p
-
-div id=inspected style=background: transparent url(data:image/png;base64,iVBORw0KGgoNSUhEUgEBCAIAAACQd1PeGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPA5JREFUeNpiYGBgAAgwAAAEAAGbA+oJAElFTkSuQmCC) repeat-y 50% top /
-
-/body
-/html
Modified: branches/chromium/1410/Source/WebCore/inspector/front-end/StylesSidebarPane.js (147340 => 147341)
--- branches/chromium/1410/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2013-04-01 17:57:19 UTC (rev 147340)
+++ branches/chromium/1410/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2013-04-01 18:00:27 UTC (rev 147341)
@@ -2089,14 +2089,10 @@
selectElement = selectElement.enclosingNodeOrSelfWithClass(webkit-css-property) || selectElement.enclosingNodeOrSelfWithClass(value);
var isEditingName = selectElement === this.nameElement;
-if (!isEditingName) {
-if (selectElement !== this.valueElement) {
-// Click in the LI - start editing value.
-isEditingName = false;
-selectElement = this.valueElement;
-}
-
-this.valueElement.textContent = this.value;
+if (!isEditingName selectElement !== this.valueElement) {
+// Double-click in the LI - start editing value.
+isEditingName = false;
+selectElement = this.valueElement;
}
if (WebInspector.isBeingEdited(selectElement))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [147272] branches/chromium/1453
Title: [147272] branches/chromium/1453
Revision 147272
Author pfeld...@chromium.org
Date 2013-03-29 22:12:00 -0700 (Fri, 29 Mar 2013)
Log Message
Merge 147028 REGRESSION (r146588): Cannot correctly display Chi...
BUG=223503
REGRESSION (r146588): Cannot correctly display Chinese SNS Renren
https://bugs.webkit.org/show_bug.cgi?id=113142
Patch by Sergey Ryazanov se...@chromium.org on 2013-03-27
Reviewed by Pavel Feldman.
Source/WebCore:
Changed CSS grammar to be equivalent to pre-r146588.
CSS error reporting disabled to prevent message overflow.
* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::isLoggingErrors):
LayoutTests:
* TestExpectations:
* fast/css/parsing-error-recovery.html:
TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/13382002
Modified Paths
branches/chromium/1453/LayoutTests/TestExpectations
branches/chromium/1453/LayoutTests/fast/css/parsing-error-recovery.html
branches/chromium/1453/Source/WebCore/css/CSSGrammar.y.in
branches/chromium/1453/Source/WebCore/css/CSSParser.cpp
Diff
Modified: branches/chromium/1453/LayoutTests/TestExpectations (147271 => 147272)
--- branches/chromium/1453/LayoutTests/TestExpectations 2013-03-30 04:51:31 UTC (rev 147271)
+++ branches/chromium/1453/LayoutTests/TestExpectations 2013-03-30 05:12:00 UTC (rev 147272)
@@ -7,3 +7,6 @@
# pending implementation completion and feature enabling
webkit.org/b/109570 media/track/regions-webvtt [ Skip ]
+
+# pending CSS grammar refactoring
+webkit.org/b/113401 inspector/console/console-css-warnings.html [ Skip ]
Modified: branches/chromium/1453/LayoutTests/fast/css/parsing-error-recovery.html (147271 => 147272)
--- branches/chromium/1453/LayoutTests/fast/css/parsing-error-recovery.html 2013-03-30 04:51:31 UTC (rev 147271)
+++ branches/chromium/1453/LayoutTests/fast/css/parsing-error-recovery.html 2013-03-30 05:12:00 UTC (rev 147272)
@@ -41,6 +41,13 @@
display:none;
}
+.malformed3 {
+;*display:_expression_(function(){})
+}
+#test5 {
+display:none;
+}
+
/* Successfully parsed */
#last {
display:block;
@@ -52,6 +59,7 @@
div class=to_be_hidden id=test2FAIL: Test 2/div
div class=to_be_hidden id=test3FAIL: Test 3/div
div class=to_be_hidden id=test4FAIL: Test 4/div
+ div class=to_be_hidden id=test5FAIL: Test 5/div
div class=to_be_shown id=lastPASS/div
/body
/html
Modified: branches/chromium/1453/Source/WebCore/css/CSSGrammar.y.in (147271 => 147272)
--- branches/chromium/1453/Source/WebCore/css/CSSGrammar.y.in 2013-03-30 04:51:31 UTC (rev 147271)
+++ branches/chromium/1453/Source/WebCore/css/CSSGrammar.y.in 2013-03-30 05:12:00 UTC (rev 147272)
@@ -2033,12 +2033,9 @@
;
errors:
-error {
-$$ = parser-currentLocation();
+error error_location {
+$$ = $2;
}
- | errors error {
-$$ = $1;
-}
;
error_location: {
Modified: branches/chromium/1453/Source/WebCore/css/CSSParser.cpp (147271 => 147272)
--- branches/chromium/1453/Source/WebCore/css/CSSParser.cpp 2013-03-30 04:51:31 UTC (rev 147271)
+++ branches/chromium/1453/Source/WebCore/css/CSSParser.cpp 2013-03-30 05:12:00 UTC (rev 147272)
@@ -11298,7 +11298,8 @@
bool CSSParser::isLoggingErrors()
{
-return m_logErrors;
+// FIXME: return logging back (https://bugs.webkit.org/show_bug.cgi?id=113401).
+return false;
}
void CSSParser::logError(const String message, int lineNumber)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [147273] branches/chromium/1453/Source/WebCore/inspector/front-end/ timelinePanel.css
Title: [147273] branches/chromium/1453/Source/WebCore/inspector/front-end/timelinePanel.css
Revision 147273
Author pfeld...@chromium.org
Date 2013-03-29 22:20:26 -0700 (Fri, 29 Mar 2013)
Log Message
Merge 146849 Web Inspector: [Timeline] Records sidebar is clipped.
BUG=222683
Web Inspector: [Timeline] Records sidebar is clipped.
https://bugs.webkit.org/show_bug.cgi?id=113177
Reviewed by Pavel Feldman.
Analysis: depending on CSS injection order sidebar rule that overwrites
bottom property may win.
Fix: make timeline-specific rule important.
* inspector/front-end/timelinePanel.css:
(.timeline .sidebar): Make bottom value important.
TBR=eus...@chromium.org
Review URL: https://codereview.chromium.org/13383002
Modified Paths
branches/chromium/1453/Source/WebCore/inspector/front-end/timelinePanel.css
Diff
Modified: branches/chromium/1453/Source/WebCore/inspector/front-end/timelinePanel.css (147272 => 147273)
--- branches/chromium/1453/Source/WebCore/inspector/front-end/timelinePanel.css 2013-03-30 05:12:00 UTC (rev 147272)
+++ branches/chromium/1453/Source/WebCore/inspector/front-end/timelinePanel.css 2013-03-30 05:20:26 UTC (rev 147273)
@@ -42,7 +42,7 @@
.timeline .sidebar {
overflow-y: hidden;
min-height: 100%;
-bottom: auto;
+bottom: auto !important;
}
.timeline.split-view-vertical .split-view-resizer {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145816] trunk/Source/WebCore
Title: [145816] trunk/Source/WebCore
Revision 145816
Author pfeld...@chromium.org
Date 2013-03-14 08:50:00 -0700 (Thu, 14 Mar 2013)
Log Message
Web Inspector: keep deprecated function stubs in InspectorFrontendHost.
https://bugs.webkit.org/show_bug.cgi?id=112347
Reviewed by Vsevolod Vlasov.
In order to open older front-ends in newer hosts, we need to keep stubs
for deprecated functions. Longer term, we need to wrap all calls to InspectorFrontendHost in the front-end.
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::canInspectWorkers):
(WebCore):
(WebCore::InspectorFrontendHost::hiddenPanels):
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp
trunk/Source/WebCore/inspector/InspectorFrontendHost.h
trunk/Source/WebCore/inspector/InspectorFrontendHost.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (145815 => 145816)
--- trunk/Source/WebCore/ChangeLog 2013-03-14 15:31:33 UTC (rev 145815)
+++ trunk/Source/WebCore/ChangeLog 2013-03-14 15:50:00 UTC (rev 145816)
@@ -1,3 +1,21 @@
+2013-03-14 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: keep deprecated function stubs in InspectorFrontendHost.
+https://bugs.webkit.org/show_bug.cgi?id=112347
+
+Reviewed by Vsevolod Vlasov.
+
+In order to open older front-ends in newer hosts, we need to keep stubs
+for deprecated functions. Longer term, we need to wrap all calls to InspectorFrontendHost in the front-end.
+
+* inspector/InspectorFrontendHost.cpp:
+(WebCore::InspectorFrontendHost::canInspectWorkers):
+(WebCore):
+(WebCore::InspectorFrontendHost::hiddenPanels):
+* inspector/InspectorFrontendHost.h:
+(InspectorFrontendHost):
+* inspector/InspectorFrontendHost.idl:
+
2013-03-14 Vladislav Kaznacheev kaznach...@chromium.org
Fixed styles pane visibility when docked to right.
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (145815 => 145816)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2013-03-14 15:31:33 UTC (rev 145815)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2013-03-14 15:50:00 UTC (rev 145816)
@@ -321,6 +321,21 @@
return m_client m_client-isUnderTest();
}
+bool InspectorFrontendHost::canSaveAs()
+{
+return false;
+}
+
+bool InspectorFrontendHost::canInspectWorkers()
+{
+return false;
+}
+
+String InspectorFrontendHost::hiddenPanels()
+{
+return ;
+}
+
} // namespace WebCore
#endif // ENABLE(INSPECTOR)
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.h (145815 => 145816)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2013-03-14 15:31:33 UTC (rev 145815)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2013-03-14 15:50:00 UTC (rev 145816)
@@ -93,6 +93,10 @@
bool isUnderTest();
+bool canInspectWorkers();
+bool canSaveAs();
+String hiddenPanels();
+
private:
#if ENABLE(CONTEXT_MENUS)
friend class FrontendMenuProvider;
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (145815 => 145816)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2013-03-14 15:31:33 UTC (rev 145815)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2013-03-14 15:50:00 UTC (rev 145816)
@@ -72,4 +72,9 @@
[Conditional=FILE_SYSTEM] DOMFileSystem isolatedFileSystem(in DOMString fileSystemId, in DOMString registeredName);
boolean isUnderTest();
+
+// Deprecated
+boolean canInspectWorkers();
+boolean canSaveAs();
+DOMString hiddenPanels();
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145817] trunk/LayoutTests
Title: [145817] trunk/LayoutTests Revision 145817 Author pfeld...@chromium.org Date 2013-03-14 09:02:45 -0700 (Thu, 14 Mar 2013) Log Message Not reviewed: chromium expectations updated. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (145816 => 145817) --- trunk/LayoutTests/ChangeLog 2013-03-14 15:50:00 UTC (rev 145816) +++ trunk/LayoutTests/ChangeLog 2013-03-14 16:02:45 UTC (rev 145817) @@ -1,3 +1,9 @@ +2013-03-14 Pavel Feldman pfeld...@chromium.org + +Not reviewed: chromium expectations updated. + +* platform/chromium/TestExpectations: + 2013-03-14 Xabier Rodriguez Calvar calva...@igalia.com [GStreamer] Stopping playback of html5 media when receiving a higher priority audio event needs implementation Modified: trunk/LayoutTests/platform/chromium/TestExpectations (145816 => 145817) --- trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-14 15:50:00 UTC (rev 145816) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-14 16:02:45 UTC (rev 145817) @@ -3597,7 +3597,7 @@ webkit.org/b/90003 [ Win Debug ] fast/js/repeat-cached-vm-reentry.html [ Pass Timeout ] # Flaky -webkit.org/b/90430 inspector/timeline/timeline-receive-response-event.html [ Pass Timeout ] +webkit.org/b/90430 inspector/timeline/timeline-receive-response-event.html [ Pass Failure Timeout ] crbug.com/135709 platform/chromium/compositing/scrollbars/custom-composited-different-track-parts.html [ ImageOnlyFailure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145872] trunk/LayoutTests
Title: [145872] trunk/LayoutTests Revision 145872 Author pfeld...@chromium.org Date 2013-03-14 21:47:50 -0700 (Thu, 14 Mar 2013) Log Message Not reviewed: Chromium TestExpectations cleanup prepared by kbr@ * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (145871 => 145872) --- trunk/LayoutTests/ChangeLog 2013-03-15 04:25:27 UTC (rev 145871) +++ trunk/LayoutTests/ChangeLog 2013-03-15 04:47:50 UTC (rev 145872) @@ -1,3 +1,9 @@ +2013-03-14 Pavel Feldman pfeld...@chromium.org + +Not reviewed: Chromium TestExpectations cleanup prepared by kbr@ + +* platform/chromium/TestExpectations: + 2013-03-14 Shezan Baig sba...@bloomberg.net Backspace/delete at start of table cell shouldn't step out of cell Modified: trunk/LayoutTests/platform/chromium/TestExpectations (145871 => 145872) --- trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-15 04:25:27 UTC (rev 145871) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-15 04:47:50 UTC (rev 145872) @@ -594,8 +594,6 @@ http/tests/security/storage-blocking-strengthened-shared-worker.html [ WontFix ] storage/indexeddb/basics-shared-workers.html [ WontFix ] -webkit.org/b/110401 [ Lion Win7 Debug ] http/tests/security/feed-urls-from-remote.html [ Timeout ] - # test_shell does not support message ports webkit.org/b/74459 fast/workers/termination-with-port-messages.html webkit.org/b/74459 fast/workers/worker-cloneport.html @@ -1576,13 +1574,11 @@ webkit.org/b/110138 compositing/geometry/limit-layer-bounds-fixed.html [ Failure ] webkit.org/b/110138 platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed.html [ Failure ] -webkit.org/b/110079 [ Win Debug ] storage/websql/sql-data-types.html [ Crash ] - # Newly introduced Reftest fails on Chrome/Mac webkit.org/b/110203 [ MountainLion ] fast/multicol/seamless-flowed-through-columns.html [ ImageOnlyFailure ] # Test fails for some reason. -webkit.org/b/110296 [ Linux Lion MountainLion ] fast/multicol/newmulticol/column-rules-fixed-height.html [ ImageOnlyFailure ] +webkit.org/b/110296 [ Linux MountainLion ] fast/multicol/newmulticol/column-rules-fixed-height.html [ ImageOnlyFailure ] webkit.org/b/110377 [ MountainLion ] fast/multicol/newmulticol/layers-in-multicol.html [ ImageOnlyFailure ] webkit.org/b/110377 [ MountainLion ] fast/multicol/newmulticol/float-paginate-complex.html [ ImageOnlyFailure ] webkit.org/b/110377 [ MountainLion ] fast/multicol/newmulticol/float-paginate.html [ ImageOnlyFailure ] @@ -2394,9 +2390,6 @@ crbug.com/60651 fast/canvas/webgl/uniform-location.html [ Failure Timeout ] crbug.com/60651 platform/chromium/virtual/gpu/fast/canvas/webgl/uniform-location.html [ Failure Timeout ] -# This will fail in Chromium until the patch is upstreamed to ANGLE -webkit.org/b/98977 fast/canvas/webgl/array-bounds-clamping.html [ Failure ] - # Flaky since r68438:r68445 or before that. webkit.org/b/46693 [ Mac ] fast/repaint/repaint-svg-after-style-change.html [ Failure ] @@ -3348,9 +3341,6 @@ webkit.org/b/ [ Win ] http/tests/xmlhttprequest/redirect-cross-origin-post.html [ Failure Pass ] -crbug.com/121442 [ Linux Debug ] plugins/iframe-shims.html [ Crash ] -crbug.com/121442 [ Linux Release ] plugins/iframe-shims.html [ Crash Pass ] - webkit.org/b/83219 [ Lion MountainLion ] fonts/cursive.html [ Failure ImageOnlyFailure Pass ] webkit.org/b/83324 [ Win Debug ] fast/js/cross-global-object-inline-global-var.html [ Failure Pass ] @@ -3620,9 +3610,6 @@ webkit.org/b/91183 http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html [ Failure Pass ] webkit.org/b/91183 http/tests/w3c/webperf/approved/HighResolutionTime/test_cross_frame_start.html [ Failure Pass ] -# Fails on Mac 10.7 -webkit.org/b/91255 [ Lion ] fast/multicol/table-vertical-align.html [ Failure ] - # Fails since creation in 122663 webkit.org/b/91372 [ Win ] css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ] @@ -3736,7 +3723,6 @@ webkit.org/b/94492 [ Win ] css3/filters/custom/filter-repaint-custom-rotated.html [ ImageOnlyFailure ] webkit.org/b/106044 [ Win7 ] css3/filters/effect-invert.html [ ImageOnlyFailure Pass ] -webkit.org/b/106044 [ XP ] css3/filters/effect-invert.html [ ImageOnlyFailure ] webkit.org/b/95581 http/tests/xmlhttprequest/zero-length-response.html [ Pass Timeout ] webkit.org/b/95581 http/tests/misc/_javascript_-url-stop-loaders.html [ Pass Timeout ] @@ -3922,7 +3908,6 @@ webkit.org/b/96833 svg/carto.net/selectionlist.svg [ ImageOnlyFailure Pass ] webkit.org/b/96549 [ Android ] platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html [ ImageOnlyFailure ] -webkit.org/b/96628 [ Lion Debug ] fast/frames/calculate-order.html [ Failure ] webkit.org/b/96550 http/tests/media/media-source/seek-to-end-after-duration-change.html [
[webkit-changes] [145705] trunk/LayoutTests
Title: [145705] trunk/LayoutTests Revision 145705 Author pfeld...@chromium.org Date 2013-03-13 05:20:46 -0700 (Wed, 13 Mar 2013) Log Message Not reviewed: chromium baselines. * platform/chromium-linux/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt: Removed. * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/chromium-linux/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (145704 => 145705) --- trunk/LayoutTests/ChangeLog 2013-03-13 12:18:06 UTC (rev 145704) +++ trunk/LayoutTests/ChangeLog 2013-03-13 12:20:46 UTC (rev 145705) @@ -1,3 +1,10 @@ +2013-03-13 Pavel Feldman pfeld...@chromium.org + +Not reviewed: chromium baselines. + +* platform/chromium-linux/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt: Removed. +* platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt: Removed. + 2013-03-13 Ádám Kallai ka...@inf.u-szeged.hu [Qt] Unreviewed gardening. Unskip now passing compositing tests. Deleted: trunk/LayoutTests/platform/chromium-linux/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt (145704 => 145705) --- trunk/LayoutTests/platform/chromium-linux/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt 2013-03-13 12:18:06 UTC (rev 145704) +++ trunk/LayoutTests/platform/chromium-linux/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt 2013-03-13 12:20:46 UTC (rev 145705) @@ -1,14 +0,0 @@ -CONSOLE MESSAGE: Blocked a frame with origin http://127.0.0.1:8000 from accessing a frame with origin http://localhost:8000. Protocols, domains, and ports must match. -CONSOLE MESSAGE: Blocked a frame with origin http://127.0.0.1:8000 from accessing a frame with origin http://localhost:8000. Protocols, domains, and ports must match. -CONSOLE MESSAGE: Blocked a frame with origin http://127.0.0.1:8000 from accessing a frame with origin http://localhost:8000. Protocols, domains, and ports must match. - - - -Frame: 'main' - -This test passes as long as the word 'FAIL' and an accompanying message do not appear in the frame below. - - -Frame: 'aFrame' - -Inner iframe. Deleted: trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt (145704 => 145705) --- trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt 2013-03-13 12:18:06 UTC (rev 145704) +++ trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom-expected.txt 2013-03-13 12:20:46 UTC (rev 145705) @@ -1,17 +0,0 @@ -CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe.html from frame with URL http://127.0.0.1:8000/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom.html. Domains, protocols and ports must match. - -CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe.html from frame with URL http://127.0.0.1:8000/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom.html. Domains, protocols and ports must match. - -CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe.html from frame with URL http://127.0.0.1:8000/security/_javascript_URL/_javascript_URL-execution-context-frame-location-htmldom.html. Domains, protocols and ports must match. - - - - -Frame: 'main' - -This test passes as long as the word 'FAIL' and an accompanying message do not appear in the frame below. - - -Frame: 'aFrame' - -Inner iframe. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145712] trunk/Source
Title: [145712] trunk/Source
Revision 145712
Author pfeld...@chromium.org
Date 2013-03-13 06:38:33 -0700 (Wed, 13 Mar 2013)
Log Message
Web Inspector: convert workers inspection into capability
https://bugs.webkit.org/show_bug.cgi?id=112251
Reviewed by Vsevolod Vlasov.
Source/WebCore:
It should be up to backend
* inspector/Inspector.json:
* inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
* inspector/InspectorFrontendClientLocal.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::canInspectWorkers):
(WebCore):
* inspector/InspectorWorkerAgent.h:
(InspectorWorkerAgent):
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/Settings.js:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):
Source/WebKit/chromium:
* src/InspectorFrontendClientImpl.cpp:
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorFrontendClient.h
trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h
trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp
trunk/Source/WebCore/inspector/InspectorFrontendHost.h
trunk/Source/WebCore/inspector/InspectorFrontendHost.idl
trunk/Source/WebCore/inspector/InspectorWorkerAgent.cpp
trunk/Source/WebCore/inspector/InspectorWorkerAgent.h
trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/externs.js
trunk/Source/WebCore/inspector/front-end/inspector.js
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp
trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (145711 => 145712)
--- trunk/Source/WebCore/ChangeLog 2013-03-13 13:36:28 UTC (rev 145711)
+++ trunk/Source/WebCore/ChangeLog 2013-03-13 13:38:33 UTC (rev 145712)
@@ -1,3 +1,31 @@
+2013-03-13 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: convert workers inspection into capability
+https://bugs.webkit.org/show_bug.cgi?id=112251
+
+Reviewed by Vsevolod Vlasov.
+
+It should be up to backend
+
+* inspector/Inspector.json:
+* inspector/InspectorFrontendClient.h:
+(InspectorFrontendClient):
+* inspector/InspectorFrontendClientLocal.h:
+* inspector/InspectorFrontendHost.cpp:
+* inspector/InspectorFrontendHost.h:
+(InspectorFrontendHost):
+* inspector/InspectorFrontendHost.idl:
+* inspector/InspectorWorkerAgent.cpp:
+(WebCore::InspectorWorkerAgent::canInspectWorkers):
+(WebCore):
+* inspector/InspectorWorkerAgent.h:
+(InspectorWorkerAgent):
+* inspector/front-end/InspectorFrontendHostStub.js:
+* inspector/front-end/Settings.js:
+* inspector/front-end/externs.js:
+* inspector/front-end/inspector.js:
+(WebInspector.doLoadedDone):
+
2013-03-13 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com
[EFL] Start using evas object directly in Widget class
Modified: trunk/Source/WebCore/inspector/Inspector.json (145711 => 145712)
--- trunk/Source/WebCore/inspector/Inspector.json 2013-03-13 13:36:28 UTC (rev 145711)
+++ trunk/Source/WebCore/inspector/Inspector.json 2013-03-13 13:38:33 UTC (rev 145712)
@@ -3378,6 +3378,13 @@
]
},
{
+name: canInspectWorkers,
+description: Tells whether browser supports workers inspection.,
+returns: [
+{ name: result, type: boolean, description: True if browser has workers support. }
+]
+},
+{
name: connectToWorker,
parameters: [
{ name: workerId, type: integer }
Modified: trunk/Source/WebCore/inspector/InspectorFrontendClient.h (145711 => 145712)
--- trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2013-03-13 13:36:28 UTC (rev 145711)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2013-03-13 13:38:33 UTC (rev 145712)
@@ -66,7 +66,6 @@
virtual bool canSave() = 0;
virtual void save(const WTF::String url, const WTF::String content, bool forceSaveAs) = 0;
virtual void append(const WTF::String url, const WTF::String content) = 0;
-virtual bool canInspectWorkers() = 0;
virtual void inspectedURLChanged(const String) = 0;
Modified: trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h (145711 => 145712)
--- trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h 2013-03-13 13:36:28 UTC (rev
[webkit-changes] [145716] trunk/LayoutTests
Title: [145716] trunk/LayoutTests Revision 145716 Author pfeld...@chromium.org Date 2013-03-13 07:14:22 -0700 (Wed, 13 Mar 2013) Log Message Not reviewed: chromium baselines. * platform/chromium-linux/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-setAttribute-expected.txt: Removed. * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-getAttribute-value-expected.txt: * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-htmldom-expected.txt: * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-setAttribute-expected.txt: * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-setAttributeNS-expected.txt: * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-setAttributeNode-expected.txt: * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-setAttributeNodeNS-expected.txt: * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-getAttribute-value-expected.txt: * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-htmldom-expected.txt: * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-setAttribute-expected.txt: Removed. * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-setAttributeNS-expected.txt: * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-setAttributeNode-expected.txt: * platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-getAttribute-value-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-htmldom-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-setAttribute-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-setAttributeNS-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-setAttributeNode-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-setAttributeNodeNS-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-getAttribute-value-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-htmldom-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-setAttributeNS-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-setAttributeNode-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-setAttributeNodeNS-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-linux/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-setAttribute-expected.txt trunk/LayoutTests/platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-setAttribute-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (145715 => 145716) --- trunk/LayoutTests/ChangeLog 2013-03-13 14:13:30 UTC (rev 145715) +++ trunk/LayoutTests/ChangeLog 2013-03-13 14:14:22 UTC (rev 145716) @@ -2,6 +2,24 @@ Not reviewed: chromium baselines. +* platform/chromium-linux/http/tests/security/_javascript_URL/_javascript_URL-execution-context-iframe-src-setAttribute-expected.txt: Removed. +* platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-getAttribute-value-expected.txt: +* platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-htmldom-expected.txt: +* platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-setAttribute-expected.txt: +* platform/chromium-win/http/tests/security/_javascript_URL/_javascript_URL-execution-context-frame-src-setAttributeNS-expected.txt: +*
[webkit-changes] [145717] trunk/Source
Title: [145717] trunk/Source Revision 145717 Author pfeld...@chromium.org Date 2013-03-13 07:17:45 -0700 (Wed, 13 Mar 2013) Log Message Web Inspector: get rid of hiddenPanels filter https://bugs.webkit.org/show_bug.cgi?id=112252 Reviewed by Vsevolod Vlasov. Source/WebCore: * WebCore.order: * inspector/InspectorFrontendClient.h: (InspectorFrontendClient): * inspector/InspectorFrontendHost.cpp: * inspector/InspectorFrontendHost.h: (InspectorFrontendHost): * inspector/InspectorFrontendHost.idl: * inspector/front-end/InspectorFrontendHostStub.js: * inspector/front-end/externs.js: * inspector/front-end/inspector.js: (WebInspector._panelDescriptors): * testing/Internals.cpp: Source/WebKit/chromium: * src/InspectorFrontendClientImpl.cpp: * src/InspectorFrontendClientImpl.h: (InspectorFrontendClientImpl): Source/WebKit/efl: * WebCoreSupport/InspectorClientEfl.cpp: * WebCoreSupport/InspectorClientEfl.h: (InspectorFrontendClientEfl): Source/WebKit/gtk: * WebCoreSupport/InspectorClientGtk.cpp: * WebCoreSupport/InspectorClientGtk.h: (InspectorFrontendClient): Source/WebKit/mac: * WebCoreSupport/WebInspectorClient.h: (WebInspectorFrontendClient): * WebCoreSupport/WebInspectorClient.mm: * WebKit.order: Source/WebKit/qt: * WebCoreSupport/InspectorClientQt.cpp: (WebCore): * WebCoreSupport/InspectorClientQt.h: (InspectorFrontendClientQt): Source/WebKit/win: * WebCoreSupport/WebInspectorClient.cpp: * WebCoreSupport/WebInspectorClient.h: (WebInspectorFrontendClient): Source/WebKit2: * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: * WebProcess/WebCoreSupport/WebInspectorFrontendClient.h: (WebInspectorFrontendClient): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.order trunk/Source/WebCore/inspector/InspectorFrontendClient.h trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp trunk/Source/WebCore/inspector/InspectorFrontendHost.h trunk/Source/WebCore/inspector/InspectorFrontendHost.idl trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js trunk/Source/WebCore/inspector/front-end/View.js trunk/Source/WebCore/inspector/front-end/externs.js trunk/Source/WebCore/inspector/front-end/inspector.js trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm trunk/Source/WebKit/mac/WebKit.order trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.h Diff Modified: trunk/Source/WebCore/ChangeLog (145716 => 145717) --- trunk/Source/WebCore/ChangeLog 2013-03-13 14:14:22 UTC (rev 145716) +++ trunk/Source/WebCore/ChangeLog 2013-03-13 14:17:45 UTC (rev 145717) @@ -1,5 +1,25 @@ 2013-03-13 Pavel Feldman pfeld...@chromium.org +Web Inspector: get rid of hiddenPanels filter +https://bugs.webkit.org/show_bug.cgi?id=112252 + +Reviewed by Vsevolod Vlasov. + +* WebCore.order: +* inspector/InspectorFrontendClient.h: +(InspectorFrontendClient): +* inspector/InspectorFrontendHost.cpp: +* inspector/InspectorFrontendHost.h: +(InspectorFrontendHost): +* inspector/InspectorFrontendHost.idl: +* inspector/front-end/InspectorFrontendHostStub.js: +* inspector/front-end/externs.js: +* inspector/front-end/inspector.js: +(WebInspector._panelDescriptors): +* testing/Internals.cpp: + +2013-03-13 Pavel Feldman pfeld...@chromium.org + Web Inspector: convert workers inspection into capability https://bugs.webkit.org/show_bug.cgi?id=112251 Modified: trunk/Source/WebCore/WebCore.order (145716 => 145717) --- trunk/Source/WebCore/WebCore.order 2013-03-13 14:14:22 UTC (rev 145716) +++ trunk/Source/WebCore/WebCore.order 2013-03-13 14:17:45 UTC (rev 145717) @@ -27139,7 +27139,6 @@ __ZN3WTF6VectorINS_6RefPtrIN7WebCore14InspectorValueEEELm0EE14expandCapacityEm __ZNK7WebCore14InspectorArray9writeJSONEPN3WTF6VectorItLm0EEE
[webkit-changes] [145487] trunk/LayoutTests
Title: [145487] trunk/LayoutTests Revision 145487 Author pfeld...@chromium.org Date 2013-03-11 23:20:46 -0700 (Mon, 11 Mar 2013) Log Message Not reviewed: Chromium expectations updated. * platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png: * platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png trunk/LayoutTests/platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (145486 => 145487) --- trunk/LayoutTests/ChangeLog 2013-03-12 06:20:19 UTC (rev 145486) +++ trunk/LayoutTests/ChangeLog 2013-03-12 06:20:46 UTC (rev 145487) @@ -1,3 +1,10 @@ +2013-03-11 Pavel Feldman pfeld...@chromium.org + +Not reviewed: Chromium expectations updated. + +* platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png: +* platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png: + 2013-03-11 Jochen Eisinger joc...@chromium.org Don't create multiple user gesture indicators when forwarding events to sub frames Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145488] trunk/LayoutTests
Title: [145488] trunk/LayoutTests
Revision 145488
Author pfeld...@chromium.org
Date 2013-03-11 23:26:22 -0700 (Mon, 11 Mar 2013)
Log Message
Not reviewed: Chromium expectations updated.
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Removed.
* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt:
* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt
trunk/LayoutTests/platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt
Removed Paths
trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt
trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (145487 => 145488)
--- trunk/LayoutTests/ChangeLog 2013-03-12 06:20:46 UTC (rev 145487)
+++ trunk/LayoutTests/ChangeLog 2013-03-12 06:26:22 UTC (rev 145488)
@@ -2,6 +2,15 @@
Not reviewed: Chromium expectations updated.
+* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
+* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Removed.
+* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt:
+* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
+
+2013-03-11 Pavel Feldman pfeld...@chromium.org
+
+Not reviewed: Chromium expectations updated.
+
* platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png:
* platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png:
Deleted: trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt (145487 => 145488)
--- trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt 2013-03-12 06:20:46 UTC (rev 145487)
+++ trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt 2013-03-12 06:26:22 UTC (rev 145488)
@@ -1,75 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x341
- RenderBlock {HTML} at (0,0) size 800x341
-RenderBody {BODY} at (8,8) size 784x325
- RenderBlock (anonymous) at (0,0) size 784x245
-RenderText {#text} at (0,0) size 0x0
- RenderBlock {DIV} at (0,245) size 784x80
-RenderText {#text} at (0,0) size 250x19
- text run at (0,0) width 250: Rendering horizontal line-positioned cues.
-RenderBR {BR} at (250,0) size 0x19
-RenderText {#text} at (0,20) size 151x19
- text run at (0,20) width 151: EVENT(canplaythrough)
-RenderBR {BR} at (151,20) size 0x19
-RenderText {#text} at (0,40) size 103x19
- text run at (0,40) width 103: EVENT(seeked)
-RenderBR {BR} at (103,40) size 0x19
-RenderText {#text} at (0,60) size 97x19
- text run at (0,60) width 97: END OF TEST
-RenderBR {BR} at (97,60) size 0x19
-layer at (8,8) size 320x240
- RenderVideo {VIDEO} at (0,0) size 320x240
-layer at (8,8) size 320x240
- RenderFlexibleBox {DIV} at (0,0) size 320x240
-RenderBlock {DIV} at (0,205) size 320x35
-layer at (8,8) size 320x205
- RenderBlock (relative positioned) {DIV} at (0,0) size 320x205 [color=#FF]
-layer at (8,8) size 320x15 scrollHeight 17
- RenderBlock (positioned) {DIV} at (0,0) size 320x15
-RenderInline {DIV} at (0,0) size 280x19 [bgcolor=#00CC]
- RenderText {#text} at (22,0) size 276x15
-text run at (22,0) width 276: Cue 1: should be positioned at the top of the video.
-layer at (8,27) size 320x15 scrollHeight 17
- RenderBlock (positioned) {DIV} at (0,19) size 320x15
-RenderInline {DIV} at (0,0) size 308x19 [bgcolor=#00CC]
- RenderText {#text} at (8,0) size 304x15
-text run at (8,0) width 304: Cue 2: should be the second cue and not overlap cue 1.
-layer at (8,46) size 320x15 scrollHeight 17
- RenderBlock (positioned) {DIV} at (0,38) size 320x15
-RenderInline {DIV} at (0,0) size 304x19 [bgcolor=#00CC]
- RenderText {#text} at (10,0) size 300x15
-text run at (10,0) width 300: Cue 3: should become the third line from top to bottom.
-layer at (8,103) size 320x15 scrollHeight 17
- RenderBlock (positioned) {DIV} at (0,95) size 320x15
-RenderInline {DIV} at (0,0) size 294x19 [bgcolor=#00CC]
- RenderText {#text} at (15,0) size 290x15
-text run at (15,0) width 290: Cue 4: should be fixed positioned around the middle.
-layer at (8,194) size 320x15 scrollHeight 17
- RenderBlock (positioned) {DIV} at (0,186) size 320x15
-RenderInline {DIV} at (0,0) size
[webkit-changes] [145507] trunk/LayoutTests
Title: [145507] trunk/LayoutTests Revision 145507 Author pfeld...@chromium.org Date 2013-03-12 02:52:03 -0700 (Tue, 12 Mar 2013) Log Message Not reviewed: chromium gardening. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (145506 => 145507) --- trunk/LayoutTests/ChangeLog 2013-03-12 09:41:46 UTC (rev 145506) +++ trunk/LayoutTests/ChangeLog 2013-03-12 09:52:03 UTC (rev 145507) @@ -1,3 +1,9 @@ +2013-03-12 Pavel Feldman pfeld...@chromium.org + +Not reviewed: chromium gardening. + +* platform/chromium/TestExpectations: + 2013-03-12 Mike West mk...@chromium.org XSSAuditor should send only one console error when blocking a page. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (145506 => 145507) --- trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-12 09:41:46 UTC (rev 145506) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-12 09:52:03 UTC (rev 145507) @@ -4469,12 +4469,12 @@ # Subtle pixel difference in debug only. webkit.org/b/112058 [ Debug SnowLeopard ] svg/custom/foreign-object-skew.svg [ Failure ] -# r145472 broke 8 compositing tests (animations refactoring?) -webkit.org/b/112102 [ Mac Win Linux ] compositing/masks/direct-image-mask.html [ ImageOnlyFailure ] -webkit.org/b/112102 [ Mac Win Linux ] compositing/masks/layer-mask-placement.html [ ImageOnlyFailure ] -webkit.org/b/112102 [ Mac Win Linux ] compositing/masks/mask-of-clipped-layer.html [ ImageOnlyFailure ] -webkit.org/b/112102 [ Mac Win Linux ] compositing/masks/masked-ancestor.html [ ImageOnlyFailure ] -webkit.org/b/112102 [ Mac Win Linux ] compositing/masks/multiple-masks.html [ ImageOnlyFailure ] -webkit.org/b/112102 [ Mac Win Linux ] compositing/reflections/masked-reflection-on-composited.html [ ImageOnlyFailure ] -webkit.org/b/112102 [ Mac Win Linux ] compositing/reflections/nested-reflection-mask-change.html [ ImageOnlyFailure ] -webkit.org/b/112102 [ Mac Win Linux ] compositing/text-on-scaled-surface.html [ ImageOnlyFailure ] +# Compositor mask shader busted by highp change +crbug.com/183581 [ Mac Win Linux ] compositing/masks/direct-image-mask.html [ ImageOnlyFailure ] +crbug.com/183581 [ Mac Win Linux ] compositing/masks/layer-mask-placement.html [ ImageOnlyFailure ] +crbug.com/183581 [ Mac Win Linux ] compositing/masks/mask-of-clipped-layer.html [ ImageOnlyFailure ] +crbug.com/183581 [ Mac Win Linux ] compositing/masks/masked-ancestor.html [ ImageOnlyFailure ] +crbug.com/183581 [ Mac Win Linux ] compositing/masks/multiple-masks.html [ ImageOnlyFailure ] +crbug.com/183581 [ Mac Win Linux ] compositing/reflections/masked-reflection-on-composited.html [ ImageOnlyFailure ] +crbug.com/183581 [ Mac Win Linux ] compositing/reflections/nested-reflection-mask-change.html [ ImageOnlyFailure ] +crbug.com/183581 [ Mac Win Linux ] compositing/text-on-scaled-surface.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145557] trunk/Source/WebCore
Title: [145557] trunk/Source/WebCore Revision 145557 Author pfeld...@chromium.org Date 2013-03-12 10:26:13 -0700 (Tue, 12 Mar 2013) Log Message Not reviewed: removing GtkVersioning from chromium targets. * WebCore.gypi: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi Diff Modified: trunk/Source/WebCore/ChangeLog (145556 => 145557) --- trunk/Source/WebCore/ChangeLog 2013-03-12 17:04:24 UTC (rev 145556) +++ trunk/Source/WebCore/ChangeLog 2013-03-12 17:26:13 UTC (rev 145557) @@ -1,3 +1,9 @@ +2013-03-12 Pavel Feldman pfeld...@chromium.org + +Not reviewed: removing GtkVersioning from chromium targets. + +* WebCore.gypi: + 2013-03-12 Marja Hölttä ma...@chromium.org [V8] Store main world and non-main world templates separately. Modified: trunk/Source/WebCore/WebCore.gypi (145556 => 145557) --- trunk/Source/WebCore/WebCore.gypi 2013-03-12 17:04:24 UTC (rev 145556) +++ trunk/Source/WebCore/WebCore.gypi 2013-03-12 17:26:13 UTC (rev 145557) @@ -4391,7 +4391,6 @@ 'platform/gtk/GRefPtrGtk.h', 'platform/gtk/GtkPluginWidget.cpp', 'platform/gtk/GtkPluginWidget.h', -'platform/gtk/GtkVersioning.h', 'platform/gtk/KURLGtk.cpp', 'platform/gtk/LanguageGtk.cpp', 'platform/gtk/LocalizedStringsGtk.cpp', ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145371] trunk/Source/WebCore
Title: [145371] trunk/Source/WebCore Revision 145371 Author pfeld...@chromium.org Date 2013-03-11 09:07:41 -0700 (Mon, 11 Mar 2013) Log Message Web Inspector: fix styles toolbar in the vertical mode. Not reviewed: swapped two lines. * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._splitVertically): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/ElementsPanel.js Diff Modified: trunk/Source/WebCore/ChangeLog (145370 => 145371) --- trunk/Source/WebCore/ChangeLog 2013-03-11 15:59:24 UTC (rev 145370) +++ trunk/Source/WebCore/ChangeLog 2013-03-11 16:07:41 UTC (rev 145371) @@ -1,3 +1,11 @@ +2013-03-11 Pavel Feldman pfeld...@chromium.org + +Web Inspector: fix styles toolbar in the vertical mode. +Not reviewed: swapped two lines. + +* inspector/front-end/ElementsPanel.js: +(WebInspector.ElementsPanel.prototype._splitVertically): + 2013-03-11 Andrey Lushnikov lushni...@chromium.org Web Inspector: [CodeMirror] add token highlight feature Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (145370 => 145371) --- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2013-03-11 15:59:24 UTC (rev 145370) +++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2013-03-11 16:07:41 UTC (rev 145371) @@ -1126,8 +1126,8 @@ var splitView = new WebInspector.SplitView(true, StylesPaneSplitRatio, 0.5); splitView.show(compositePane.bodyElement); +this.sidebarPanes.styles.show(splitView.firstElement()); splitView.firstElement().appendChild(this.sidebarPanes.styles.titleElement); -this.sidebarPanes.styles.show(splitView.firstElement()); this.sidebarPanes.metrics.show(splitView.secondElement()); splitView.secondElement().appendChild(this.sidebarPanes.computedStyle.titleElement); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145476] trunk/LayoutTests
Title: [145476] trunk/LayoutTests Revision 145476 Author pfeld...@chromium.org Date 2013-03-11 22:00:00 -0700 (Mon, 11 Mar 2013) Log Message Not reviewed: Chromium rebaselines. * platform/chromium/compositing/overflow/composited-scrolling-paint-phases-expected.txt: * platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt: * platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/compositing/overflow/composited-scrolling-paint-phases-expected.txt trunk/LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt trunk/LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (145475 => 145476) --- trunk/LayoutTests/ChangeLog 2013-03-12 04:58:55 UTC (rev 145475) +++ trunk/LayoutTests/ChangeLog 2013-03-12 05:00:00 UTC (rev 145476) @@ -1,3 +1,11 @@ +2013-03-11 Pavel Feldman pfeld...@chromium.org + +Not reviewed: Chromium rebaselines. + +* platform/chromium/compositing/overflow/composited-scrolling-paint-phases-expected.txt: +* platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt: +* platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt: + 2013-03-11 Takashi Sakamoto ta...@google.com [CSS] shadow from radius has wrong render in webkit Modified: trunk/LayoutTests/platform/chromium/compositing/overflow/composited-scrolling-paint-phases-expected.txt (145475 => 145476) --- trunk/LayoutTests/platform/chromium/compositing/overflow/composited-scrolling-paint-phases-expected.txt 2013-03-12 04:58:55 UTC (rev 145475) +++ trunk/LayoutTests/platform/chromium/compositing/overflow/composited-scrolling-paint-phases-expected.txt 2013-03-12 05:00:00 UTC (rev 145476) @@ -45,7 +45,6 @@ (GraphicsLayer (position 0.00 10.00) (bounds 80.00 10.00) - (contentsOpaque 1) (drawsContent 1) (paintingPhases GraphicsLayerPaintBackground Modified: trunk/LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt (145475 => 145476) --- trunk/LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt 2013-03-12 04:58:55 UTC (rev 145475) +++ trunk/LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt 2013-03-12 05:00:00 UTC (rev 145476) @@ -45,7 +45,6 @@ (GraphicsLayer (position 0.00 10.00) (bounds 80.00 10.00) - (contentsOpaque 1) (drawsContent 1) (paintingPhases GraphicsLayerPaintBackground Modified: trunk/LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt (145475 => 145476) --- trunk/LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt 2013-03-12 04:58:55 UTC (rev 145475) +++ trunk/LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt 2013-03-12 05:00:00 UTC (rev 145476) @@ -45,7 +45,6 @@ (GraphicsLayer (position 0.00 10.00) (bounds 80.00 10.00) - (contentsOpaque 1) (drawsContent 1) (paintingPhases GraphicsLayerPaintBackground ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145478] trunk/LayoutTests
Title: [145478] trunk/LayoutTests Revision 145478 Author pfeld...@chromium.org Date 2013-03-11 22:10:33 -0700 (Mon, 11 Mar 2013) Log Message Not reviewed: Chromium rebaselines. * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed. * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed. * platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed. * platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed. * platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed. * platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed. * platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed. * platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed. * platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed. * platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed. * platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Renamed from LayoutTests/platform/chromium-linux/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt. * platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Renamed from LayoutTests/platform/chromium-linux/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt trunk/LayoutTests/platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-linux/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt trunk/LayoutTests/platform/chromium-linux/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt trunk/LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt trunk/LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt trunk/LayoutTests/platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt trunk/LayoutTests/platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt trunk/LayoutTests/platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt trunk/LayoutTests/platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (145477 => 145478) --- trunk/LayoutTests/ChangeLog 2013-03-12 05:10:03 UTC (rev 145477) +++ trunk/LayoutTests/ChangeLog 2013-03-12 05:10:33 UTC (rev 145478) @@ -2,6 +2,23 @@ Not reviewed: Chromium rebaselines. +* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed. +* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed. +* platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed. +* platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed. +* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed. +* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed. +*
[webkit-changes] [145479] trunk/LayoutTests
Title: [145479] trunk/LayoutTests Revision 145479 Author pfeld...@chromium.org Date 2013-03-11 22:23:08 -0700 (Mon, 11 Mar 2013) Log Message Not reviewed: Chromium expectations updated. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (145478 => 145479) --- trunk/LayoutTests/ChangeLog 2013-03-12 05:10:33 UTC (rev 145478) +++ trunk/LayoutTests/ChangeLog 2013-03-12 05:23:08 UTC (rev 145479) @@ -1,5 +1,11 @@ 2013-03-11 Pavel Feldman pfeld...@chromium.org +Not reviewed: Chromium expectations updated. + +* platform/chromium/TestExpectations: + +2013-03-11 Pavel Feldman pfeld...@chromium.org + Not reviewed: Chromium rebaselines. * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (145478 => 145479) --- trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-12 05:10:33 UTC (rev 145478) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-12 05:23:08 UTC (rev 145479) @@ -4471,3 +4471,13 @@ # Subtle pixel difference in debug only. webkit.org/b/112058 [ Debug SnowLeopard ] svg/custom/foreign-object-skew.svg [ Failure ] + +# r145472 broke 8 compositing tests (animations refactoring?) +webkit.org/b/112102 [ Mac Win Linux ] compositing/masks/direct-image-mask.html [ ImageOnlyFailure ] +webkit.org/b/112102 [ Mac Win Linux ] compositing/masks/layer-mask-placement.html [ ImageOnlyFailure ] +webkit.org/b/112102 [ Mac Win Linux ] compositing/masks/mask-of-clipped-layer.html [ ImageOnlyFailure ] +webkit.org/b/112102 [ Mac Win Linux ] compositing/masks/masked-ancestor.html [ ImageOnlyFailure ] +webkit.org/b/112102 [ Mac Win Linux ] compositing/masks/multiple-masks.html [ ImageOnlyFailure ] +webkit.org/b/112102 [ Mac Win Linux ] compositing/reflections/masked-reflection-on-composited.html [ ImageOnlyFailure ] +webkit.org/b/112102 [ Mac Win Linux ] compositing/reflections/nested-reflection-mask-change.html [ ImageOnlyFailure ] +webkit.org/b/112102 [ Mac Win Linux ] compositing/text-on-scaled-surface.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144295] trunk
Title: [144295] trunk
Revision 144295
Author pfeld...@chromium.org
Date 2013-02-28 04:28:19 -0800 (Thu, 28 Feb 2013)
Log Message
Web Inspector: class console-formatted-string renamed to console-formatted- ?
https://bugs.webkit.org/show_bug.cgi?id=110881
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._renderPropertyPreview):
LayoutTests:
* http/tests/inspector/console-test.js:
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessages):
* inspector/console/console-object-preview-expected.txt:
* inspector/console/console-object-preview.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/console-test.js
trunk/LayoutTests/inspector/console/console-object-preview-expected.txt
trunk/LayoutTests/inspector/console/console-object-preview.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
Diff
Modified: trunk/LayoutTests/ChangeLog (144294 => 144295)
--- trunk/LayoutTests/ChangeLog 2013-02-28 12:28:00 UTC (rev 144294)
+++ trunk/LayoutTests/ChangeLog 2013-02-28 12:28:19 UTC (rev 144295)
@@ -1,3 +1,15 @@
+2013-02-28 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: class console-formatted-string renamed to console-formatted- ?
+https://bugs.webkit.org/show_bug.cgi?id=110881
+
+Reviewed by Vsevolod Vlasov.
+
+* http/tests/inspector/console-test.js:
+(initialize_ConsoleTest.InspectorTest.dumpConsoleMessages):
+* inspector/console/console-object-preview-expected.txt:
+* inspector/console/console-object-preview.html:
+
2013-02-28 Takashi Toyoshima toyos...@chromium.org
Unreviewed gardening, update expectation
Modified: trunk/LayoutTests/http/tests/inspector/console-test.js (144294 => 144295)
--- trunk/LayoutTests/http/tests/inspector/console-test.js 2013-02-28 12:28:00 UTC (rev 144294)
+++ trunk/LayoutTests/http/tests/inspector/console-test.js 2013-02-28 12:28:19 UTC (rev 144295)
@@ -6,17 +6,26 @@
WebInspector.drawer.immediatelyFinishAnimation();
}
-InspectorTest.dumpConsoleMessages = function(printOriginatingCommand)
+InspectorTest.dumpConsoleMessages = function(printOriginatingCommand, dumpClassNames)
{
var result = [];
var messages = WebInspector.consoleView._visibleMessages;
for (var i = 0; i messages.length; ++i) {
var element = messages[i].toMessageElement();
-InspectorTest.addResult(element.textContent.replace(/\u200b/g, ));
+
+if (dumpClassNames) {
+var classNames = [];
+for (var node = element.firstChild; node; node = node.traverseNextNode(element)) {
+if (node.nodeType === Node.ELEMENT_NODE node.className)
+classNames.push(node.className);
+}
+}
+
+InspectorTest.addResult(element.textContent.replace(/\u200b/g, ) + (dumpClassNames ? + classNames.join( ) : ));
if (printOriginatingCommand messages[i].originatingCommand) {
- var originatingElement = messages[i].originatingCommand.toMessageElement();
- InspectorTest.addResult(Originating from: + originatingElement.textContent.replace(/\u200b/g, ));
- }
+var originatingElement = messages[i].originatingCommand.toMessageElement();
+InspectorTest.addResult(Originating from: + originatingElement.textContent.replace(/\u200b/g, ));
+}
}
return result;
}
Modified: trunk/LayoutTests/inspector/console/console-object-preview-expected.txt (144294 => 144295)
--- trunk/LayoutTests/inspector/console/console-object-preview-expected.txt 2013-02-28 12:28:00 UTC (rev 144294)
+++ trunk/LayoutTests/inspector/console/console-object-preview-expected.txt 2013-02-28 12:28:19 UTC (rev 144295)
@@ -18,22 +18,22 @@
CONSOLE MESSAGE: line 53: 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144,145,146,147,148,149
Tests that console produces instant previews for arrays and objects.
-Mutating object in a loop console-object-preview.html:9
-Object {a: 0, b: 0, c: 0} console-object-preview.html:13
-Object {a: 0, b: 0, c: 1} console-object-preview.html:13
-Object {a: 0, b: 0, c: 2} console-object-preview.html:13
-Mutating array in a loop console-object-preview.html:16
-[0, 0, 0] console-object-preview.html:20
-[0, 0, 1] console-object-preview.html:20
-[0, 0, 2] console-object-preview.html:20
-Object with many properties console-object-preview.html:23
-Object {property_0: 0, property_1: 1, property_2: 2,
[webkit-changes] [143701] trunk/Source/WebCore
Title: [143701] trunk/Source/WebCore
Revision 143701
Author pfeld...@chromium.org
Date 2013-02-22 00:59:11 -0800 (Fri, 22 Feb 2013)
Log Message
Web Inspector: allow opting out from vertical split in the dock-to-right mode
https://bugs.webkit.org/show_bug.cgi?id=110564
Reviewed by Vsevolod Vlasov.
* English.lproj/localizedStrings.js:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._splitVertically):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/SettingsScreen.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (143700 => 143701)
--- trunk/Source/WebCore/ChangeLog 2013-02-22 08:55:18 UTC (rev 143700)
+++ trunk/Source/WebCore/ChangeLog 2013-02-22 08:59:11 UTC (rev 143701)
@@ -1,3 +1,19 @@
+2013-02-22 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: allow opting out from vertical split in the dock-to-right mode
+https://bugs.webkit.org/show_bug.cgi?id=110564
+
+Reviewed by Vsevolod Vlasov.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/ElementsPanel.js:
+(WebInspector.ElementsPanel.prototype._splitVertically):
+* inspector/front-end/ScriptsPanel.js:
+* inspector/front-end/Settings.js:
+(WebInspector.Settings):
+* inspector/front-end/SettingsScreen.js:
+(WebInspector.GenericSettingsTab):
+
2013-02-21 Claudio Saavedra csaave...@igalia.com
[GTK] Control+Shift+Up/Down selection works backwards
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (143700 => 143701)
--- trunk/Source/WebCore/English.lproj/localizedStrings.js 2013-02-22 08:55:18 UTC (rev 143700)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js 2013-02-22 08:59:11 UTC (rev 143701)
@@ -871,3 +871,4 @@
localizedStrings[Send WebSocket Handshake] = Send WebSocket Handshake;
localizedStrings[Receive WebSocket Handshake] = Receive WebSocket Handshake;
localizedStrings[Destroy WebSocket] = Destroy WebSocket;
+localizedStrings[Split panels vertically when docked to right] = Split panels vertically when docked to right;
Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (143700 => 143701)
--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2013-02-22 08:55:18 UTC (rev 143700)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2013-02-22 08:59:11 UTC (rev 143701)
@@ -96,6 +96,7 @@
this.sidebarPanes.metrics.addEventListener(metrics edited, this._metricsPaneEdited, this);
WebInspector.dockController.addEventListener(WebInspector.DockController.Events.DockSideChanged, this._dockSideChanged.bind(this));
+WebInspector.settings.splitVerticallyWhenDockedToRight.addChangeListener(this._dockSideChanged.bind(this));
this._dockSideChanged();
this._popoverHelper = new WebInspector.PopoverHelper(this.element, this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
@@ -1096,23 +1097,24 @@
_dockSideChanged: function()
{
var dockSide = WebInspector.dockController.dockSide();
-this._setVerticalSplit(dockSide !== WebInspector.DockController.State.DockedToRight);
+var vertically = dockSide === WebInspector.DockController.State.DockedToRight WebInspector.settings.splitVerticallyWhenDockedToRight.get();
+this._splitVertically(vertically);
},
/**
- * @param {boolean} vertical
+ * @param {boolean} vertically
*/
-_setVerticalSplit: function(vertical)
+_splitVertically: function(vertically)
{
-if (this.sidebarPaneView vertical === this.splitView.isVertical())
+if (this.sidebarPaneView vertically === !this.splitView.isVertical())
return;
if (this.sidebarPaneView)
this.sidebarPaneView.detach();
-this.splitView.setVertical(vertical);
+this.splitView.setVertical(!vertically);
-if (vertical) {
+if (!vertically) {
this.sidebarPaneView = new WebInspector.SidebarPaneStack();
for (var pane in this.sidebarPanes)
this.sidebarPaneView.addPane(this.sidebarPanes[pane]);
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (143700 => 143701)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2013-02-22 08:55:18 UTC (rev 143700)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2013-02-22 08:59:11 UTC (rev 143701)
@@ -150,6 +150,7 @@
this._installDebuggerSidebarController();
[webkit-changes] [143605] branches/chromium/1410/Source/WebCore/inspector/ InspectorDebuggerAgent.cpp
Title: [143605] branches/chromium/1410/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
Revision 143605
Author pfeld...@chromium.org
Date 2013-02-21 08:30:28 -0800 (Thu, 21 Feb 2013)
Log Message
Merge 143334
Web Inspector: release backtrace object group on each step.
https://bugs.webkit.org/show_bug.cgi?id=110223
Reviewed by Pavel Feldman.
* inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
TBR=podivi...@chromium.org
Review URL: https://codereview.chromium.org/12316038
Modified Paths
branches/chromium/1410/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
Diff
Modified: branches/chromium/1410/Source/WebCore/inspector/InspectorDebuggerAgent.cpp (143604 => 143605)
--- branches/chromium/1410/Source/WebCore/inspector/InspectorDebuggerAgent.cpp 2013-02-21 16:19:47 UTC (rev 143604)
+++ branches/chromium/1410/Source/WebCore/inspector/InspectorDebuggerAgent.cpp 2013-02-21 16:30:28 UTC (rev 143605)
@@ -60,7 +60,7 @@
static const char pauseOnExceptionsState[] = pauseOnExceptionsState;
};
-const char* InspectorDebuggerAgent::backtraceObjectGroup = backtrace-object-group;
+const char* InspectorDebuggerAgent::backtraceObjectGroup = backtrace;
InspectorDebuggerAgent::InspectorDebuggerAgent(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* inspectorState, InjectedScriptManager* injectedScriptManager)
: InspectorBaseAgentInspectorDebuggerAgent(Debugger, instrumentingAgents, inspectorState)
@@ -455,6 +455,7 @@
{
if (!assertPaused(errorString))
return;
+m_injectedScriptManager-releaseObjectGroup(InspectorDebuggerAgent::backtraceObjectGroup);
scriptDebugServer().stepOverStatement();
}
@@ -462,6 +463,7 @@
{
if (!assertPaused(errorString))
return;
+m_injectedScriptManager-releaseObjectGroup(InspectorDebuggerAgent::backtraceObjectGroup);
scriptDebugServer().stepIntoStatement();
m_listener-stepInto();
}
@@ -470,6 +472,7 @@
{
if (!assertPaused(errorString))
return;
+m_injectedScriptManager-releaseObjectGroup(InspectorDebuggerAgent::backtraceObjectGroup);
scriptDebugServer().stepOutOfFunction();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143567] trunk/Source/WebCore
Title: [143567] trunk/Source/WebCore
Revision 143567
Author pfeld...@chromium.org
Date 2013-02-20 23:33:23 -0800 (Wed, 20 Feb 2013)
Log Message
Web Inspector: debugger buttons are scrolled along with the sidebar content.
https://bugs.webkit.org/show_bug.cgi?id=110434
Reviewed by Vsevolod Vlasov.
* inspector/front-end/scriptsPanel.css:
(div.sidebar-pane-stack#scripts-debug-sidebar-contents, #scripts-sidebar-stack-pane):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/scriptsPanel.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (143566 => 143567)
--- trunk/Source/WebCore/ChangeLog 2013-02-21 07:21:48 UTC (rev 143566)
+++ trunk/Source/WebCore/ChangeLog 2013-02-21 07:33:23 UTC (rev 143567)
@@ -1,3 +1,13 @@
+2013-02-20 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: debugger buttons are scrolled along with the sidebar content.
+https://bugs.webkit.org/show_bug.cgi?id=110434
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/scriptsPanel.css:
+(div.sidebar-pane-stack#scripts-debug-sidebar-contents, #scripts-sidebar-stack-pane):
+
2013-02-20 Wei James james@intel.com
ChannelMergerNode may need check for deferred updating of output channels
Modified: trunk/Source/WebCore/inspector/front-end/scriptsPanel.css (143566 => 143567)
--- trunk/Source/WebCore/inspector/front-end/scriptsPanel.css 2013-02-21 07:21:48 UTC (rev 143566)
+++ trunk/Source/WebCore/inspector/front-end/scriptsPanel.css 2013-02-21 07:33:23 UTC (rev 143567)
@@ -304,11 +304,7 @@
-webkit-mask-position: -16px -16px;
}
-#scripts-sidebar-stack-pane {
-overflow: auto;
+div.sidebar-pane-stack#scripts-debug-sidebar-contents, #scripts-sidebar-stack-pane {
top: 23px;
+overflow: auto;
}
-
-div.sidebar-pane-stack#scripts-debug-sidebar-contents {
-top: 23px;
-}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143179] trunk
Title: [143179] trunk
Revision 143179
Author pfeld...@chromium.org
Date 2013-02-18 02:28:08 -0800 (Mon, 18 Feb 2013)
Log Message
Web Inspector: allow 0 as a formatted parameter in console message.
https://bugs.webkit.org/show_bug.cgi?id=110096
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.append):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
LayoutTests:
* inspector/console/console-format.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/console-format-expected.txt
trunk/LayoutTests/inspector/console/console-format.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
Diff
Modified: trunk/LayoutTests/ChangeLog (143178 => 143179)
--- trunk/LayoutTests/ChangeLog 2013-02-18 10:20:08 UTC (rev 143178)
+++ trunk/LayoutTests/ChangeLog 2013-02-18 10:28:08 UTC (rev 143179)
@@ -1,3 +1,12 @@
+2013-02-18 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: allow 0 as a formatted parameter in console message.
+https://bugs.webkit.org/show_bug.cgi?id=110096
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/console/console-format.html:
+
2013-02-18 Ádám Kallai ka...@inf.u-szeged.hu
[Qt] Unreviewed gardening. Skipped failing tests.
Modified: trunk/LayoutTests/inspector/console/console-format-expected.txt (143178 => 143179)
--- trunk/LayoutTests/inspector/console/console-format-expected.txt 2013-02-18 10:20:08 UTC (rev 143178)
+++ trunk/LayoutTests/inspector/console/console-format-expected.txt 2013-02-18 10:28:08 UTC (rev 143179)
@@ -1,6 +1,7 @@
CONSOLE MESSAGE: line 20: test,test2,,,test4,
CONSOLE MESSAGE: line 21: %o
CONSOLE MESSAGE: line 22: %O
+CONSOLE MESSAGE: line 23: Test for zero %f in formatter
CONSOLE MESSAGE: line 54: /^url\(\s*(?:(?:(?:[^\\\]|(?:\\[\da-f]{1,6}\s?|\.))*|'(?:[^\\\']|(?:\\[\da-f]{1,6}\s?|\.))*')|(?:[!#$%*-~\w]|(?:\\[\da-f]{1,6}\s?|\.))*)\s*\)/i
CONSOLE MESSAGE: line 55: /^url\(\s*(?:(?:(?:[^\\\]|(?:\\[\da-f]{1,6}\s?|\.))*|'(?:[^\\\']|(?:\\[\da-f]{1,6}\s?|\.))*')|(?:[!#$%*-~\w]|(?:\\[\da-f]{1,6}\s?|\.))*)\s*\)/i
CONSOLE MESSAGE: line 54: /foo\\bar\sbaz/i
@@ -56,6 +57,7 @@
Array[10] console-format.html:20
Array[10] console-format.html:21
Array[10] console-format.html:22
+Test for zero 0 in formatter console-format.html:23
/^url\(\s*(?:(?:(?:[^\\\]|(?:\\[\da-f]{1,6}\s?|\.))*|'(?:[^\\\']|(?:\\[\da-f]{1,6}\s?|\.))*')|(?:[!#$%*-~\w]|(?:\\[\da-f]{1,6}\s?|\.))*)\s*\)/i console-format.html:54
[/^url\(\s*(?:(?:(?:[^\\\]|(?:\\[\da-f]{1,6}\s?|\…?:[!#$%*-~\w]|(?:\\[\da-f]{1,6}\s?|\.))*)\s*\)/i] console-format.html:55
globals[0]
Modified: trunk/LayoutTests/inspector/console/console-format.html (143178 => 143179)
--- trunk/LayoutTests/inspector/console/console-format.html 2013-02-18 10:20:08 UTC (rev 143178)
+++ trunk/LayoutTests/inspector/console/console-format.html 2013-02-18 10:28:08 UTC (rev 143179)
@@ -20,7 +20,7 @@
console.log(array);
console.log(%o, array);
console.log(%O, array);
-
+console.log(Test for zero \%f\ in formatter, 0);
// Populate Globals
var regex1 = /^url\(\s*(?:(?:(?:[^\\\]|(?:\\[\da-f]{1,6}\s?|\.))*|'(?:[^\\\']|(?:\\[\da-f]{1,6}\s?|\.))*')|(?:[!#$%*-~\w]|(?:\\[\da-f]{1,6}\s?|\.))*)\s*\)/i;
var regex2 = new RegExp(foobar\\sbaz, i);
Modified: trunk/Source/WebCore/ChangeLog (143178 => 143179)
--- trunk/Source/WebCore/ChangeLog 2013-02-18 10:20:08 UTC (rev 143178)
+++ trunk/Source/WebCore/ChangeLog 2013-02-18 10:28:08 UTC (rev 143179)
@@ -1,3 +1,14 @@
+2013-02-18 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: allow 0 as a formatted parameter in console message.
+https://bugs.webkit.org/show_bug.cgi?id=110096
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/ConsoleMessage.js:
+(WebInspector.ConsoleMessageImpl.prototype.append):
+(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
+
2013-02-18 Ilya Tikhonovsky loi...@chromium.org
Unreviewed speculative fix for Chromium Mac.
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js (143178 => 143179)
--- trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js 2013-02-18 10:20:08 UTC (rev 143178)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js 2013-02-18 10:28:08 UTC (rev 143179)
@@ -548,8 +548,8 @@
{
if (b instanceof Node)
a.appendChild(b);
-else if (b) {
-var toAppend = WebInspector.linkifyStringAsFragment(b.toString());
+else if (typeof b !== undefined) {
+var toAppend = WebInspector.linkifyStringAsFragment(String(b));
if (currentStyle) {
var wrapper = document.createElement('span');
for (var key in currentStyle)
[webkit-changes] [143182] trunk/LayoutTests
Title: [143182] trunk/LayoutTests
Revision 143182
Author pfeld...@chromium.org
Date 2013-02-18 02:31:19 -0800 (Mon, 18 Feb 2013)
Log Message
Follow up to r143112, fixing tests.
Not reviewed.
* inspector/elements/insert-node-expected.txt:
* inspector/elements/insert-node.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/elements/insert-node-expected.txt
trunk/LayoutTests/inspector/elements/insert-node.html
Diff
Modified: trunk/LayoutTests/ChangeLog (143181 => 143182)
--- trunk/LayoutTests/ChangeLog 2013-02-18 10:30:06 UTC (rev 143181)
+++ trunk/LayoutTests/ChangeLog 2013-02-18 10:31:19 UTC (rev 143182)
@@ -1,5 +1,13 @@
2013-02-18 Pavel Feldman pfeld...@chromium.org
+Follow up to r143112, fixing tests.
+Not reviewed.
+
+* inspector/elements/insert-node-expected.txt:
+* inspector/elements/insert-node.html:
+
+2013-02-18 Pavel Feldman pfeld...@chromium.org
+
Web Inspector: allow 0 as a formatted parameter in console message.
https://bugs.webkit.org/show_bug.cgi?id=110096
Modified: trunk/LayoutTests/inspector/elements/insert-node-expected.txt (143181 => 143182)
--- trunk/LayoutTests/inspector/elements/insert-node-expected.txt 2013-02-18 10:30:06 UTC (rev 143181)
+++ trunk/LayoutTests/inspector/elements/insert-node-expected.txt 2013-02-18 10:31:19 UTC (rev 143182)
@@ -49,7 +49,7 @@
div id=child2/div
div id=child3/div
div id=child-after/div
- div style=display: none; id=child-with-textText/div
+ div id=child-with-text style=display: none;Text/div
/div
Success: child text is bound
@@ -64,7 +64,7 @@
First text
/div
div id=child-after/div
- div style=display: none; id=child-with-textText/div
+ div id=child-with-text style=display: none;Text/div
/div
Success: child text is bound
Modified: trunk/LayoutTests/inspector/elements/insert-node.html (143181 => 143182)
--- trunk/LayoutTests/inspector/elements/insert-node.html 2013-02-18 10:30:06 UTC (rev 143181)
+++ trunk/LayoutTests/inspector/elements/insert-node.html 2013-02-18 10:31:19 UTC (rev 143182)
@@ -33,9 +33,9 @@
{
var container = document.getElementById(container);
var child = document.createElement(div);
-child.style.display = none;
+child.setAttribute(id, child-with-text);
+child.setAttribute(style, display: none;);
child.innerText = Text;
-child.setAttribute(id, child-with-text);
container.appendChild(child);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143224] trunk/Source/WebCore
Title: [143224] trunk/Source/WebCore
Revision 143224
Author pfeld...@chromium.org
Date 2013-02-18 08:41:30 -0800 (Mon, 18 Feb 2013)
Log Message
Web Inspector: hide vertical-sidebar-split in dock-to-right mode behind single experimental flag.
https://bugs.webkit.org/show_bug.cgi?id=110119
Reviewed by Vsevolod Vlasov.
Removed context menus, made it toggle automatically upon dock orientation change.
* inspector/front-end/DockController.js:
(WebInspector.DockController.prototype._toggleDockState):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._sidebarContextMenuEventFired):
(WebInspector.ElementsPanel.prototype._dockSideChanged):
(WebInspector.ElementsPanel.prototype._setVerticalSplit):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._dockSideChanged):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/inspector.css:
* inspector/front-end/scriptsPanel.css:
(#scripts-sidebar-stack-pane):
(div.sidebar-pane-stack#scripts-debug-sidebar-contents):
* inspector/front-end/tabbedPane.css:
(.tabbed-pane):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DockController.js
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/inspector.css
trunk/Source/WebCore/inspector/front-end/scriptsPanel.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (143223 => 143224)
--- trunk/Source/WebCore/ChangeLog 2013-02-18 16:34:41 UTC (rev 143223)
+++ trunk/Source/WebCore/ChangeLog 2013-02-18 16:41:30 UTC (rev 143224)
@@ -1,3 +1,32 @@
+2013-02-18 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: hide vertical-sidebar-split in dock-to-right mode behind single experimental flag.
+https://bugs.webkit.org/show_bug.cgi?id=110119
+
+Reviewed by Vsevolod Vlasov.
+
+Removed context menus, made it toggle automatically upon dock orientation change.
+
+* inspector/front-end/DockController.js:
+(WebInspector.DockController.prototype._toggleDockState):
+* inspector/front-end/ElementsPanel.js:
+(WebInspector.ElementsPanel):
+(WebInspector.ElementsPanel.prototype._sidebarContextMenuEventFired):
+(WebInspector.ElementsPanel.prototype._dockSideChanged):
+(WebInspector.ElementsPanel.prototype._setVerticalSplit):
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel):
+(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
+(WebInspector.ScriptsPanel.prototype._dockSideChanged):
+* inspector/front-end/Settings.js:
+(WebInspector.ExperimentsSettings):
+* inspector/front-end/inspector.css:
+* inspector/front-end/scriptsPanel.css:
+(#scripts-sidebar-stack-pane):
+(div.sidebar-pane-stack#scripts-debug-sidebar-contents):
+* inspector/front-end/tabbedPane.css:
+(.tabbed-pane):
+
2013-02-18 ChangSeok Oh shivami...@gmail.com
[GTK] Fix nits for configuration
Modified: trunk/Source/WebCore/inspector/front-end/DockController.js (143223 => 143224)
--- trunk/Source/WebCore/inspector/front-end/DockController.js 2013-02-18 16:34:41 UTC (rev 143223)
+++ trunk/Source/WebCore/inspector/front-end/DockController.js 2013-02-18 16:41:30 UTC (rev 143224)
@@ -30,6 +30,7 @@
/**
* @constructor
+ * @extends {WebInspector.Object}
*/
WebInspector.DockController = function()
{
@@ -50,6 +51,10 @@
Undocked: undocked
}
+WebInspector.DockController.Events = {
+DockSideChanged: DockSideChanged
+}
+
WebInspector.DockController.prototype = {
/**
* @return {Element}
@@ -84,6 +89,7 @@
else
WebInspector.userMetrics.WindowUndocked.record();
this._updateUI();
+this.dispatchEventToListeners(WebInspector.DockController.Events.DockSideChanged, this._dockSide);
},
/**
@@ -182,7 +188,9 @@
case undock: action = "" break;
}
InspectorFrontendHost.requestSetDockSide(action);
-}
+},
+
+__proto__: WebInspector.Object.prototype
}
/**
Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (143223 => 143224)
--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2013-02-18 16:34:41 UTC (rev 143223)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2013-02-18 16:41:30 UTC (rev 143224)
@@ -95,14 +95,9 @@
this.sidebarPanes.styles.addEventListener(style property toggled, this._stylesPaneEdited, this);
this.sidebarPanes.metrics.addEventListener(metrics edited, this._metricsPaneEdited, this);
-this._splitDirectionSetting = WebInspector.settings.createSetting(this.name +
[webkit-changes] [143227] trunk/Source/WebCore
Title: [143227] trunk/Source/WebCore
Revision 143227
Author pfeld...@chromium.org
Date 2013-02-18 08:54:19 -0800 (Mon, 18 Feb 2013)
Log Message
Web Inspector: Disable hiding the debugger when it is below the source code
https://bugs.webkit.org/show_bug.cgi?id=110106
Patch by Vladislav Kaznacheev kaznach...@chromium.org on 2013-02-18
Reviewed by Pavel Feldman.
When the Split horizontally option is checked in the Sources panel the button responsible for the sidebar
visibility is hidden and the sidebar is force-shown. Also set the Split sidebar option default to true.
No new tests.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/scriptsPanel.css:
(.split-view-horizontal #scripts-debug-sidebar-resizer-widget):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/scriptsPanel.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (143226 => 143227)
--- trunk/Source/WebCore/ChangeLog 2013-02-18 16:49:46 UTC (rev 143226)
+++ trunk/Source/WebCore/ChangeLog 2013-02-18 16:54:19 UTC (rev 143227)
@@ -1,3 +1,20 @@
+2013-02-18 Vladislav Kaznacheev kaznach...@chromium.org
+
+Web Inspector: Disable hiding the debugger when it is below the source code
+https://bugs.webkit.org/show_bug.cgi?id=110106
+
+Reviewed by Pavel Feldman.
+
+When the Split horizontally option is checked in the Sources panel the button responsible for the sidebar
+visibility is hidden and the sidebar is force-shown. Also set the Split sidebar option default to true.
+
+No new tests.
+
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel):
+* inspector/front-end/scriptsPanel.css:
+(.split-view-horizontal #scripts-debug-sidebar-resizer-widget):
+
2013-02-18 Bear Travis betra...@adobe.com
[CSS Exclusions] Support outside-shape layout for shape-inside property
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (143226 => 143227)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2013-02-18 16:49:46 UTC (rev 143226)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2013-02-18 16:54:19 UTC (rev 143227)
@@ -120,9 +120,6 @@
this.sidebarPanes.workerList = new WebInspector.WorkersSidebarPane(WebInspector.workerManager);
}
-WebInspector.dockController.addEventListener(WebInspector.DockController.Events.DockSideChanged, this._dockSideChanged.bind(this));
-this._dockSideChanged();
-
this.sidebarPanes.callstack.registerShortcuts(this.registerShortcuts.bind(this));
this.registerShortcuts(WebInspector.ScriptsPanelDescriptor.ShortcutKeys.EvaluateSelectionInConsole, this._evaluateSelectionInConsole.bind(this));
this.registerShortcuts(WebInspector.ScriptsPanelDescriptor.ShortcutKeys.GoToMember, this._showOutlineDialog.bind(this));
@@ -152,6 +149,9 @@
this._installDebuggerSidebarController();
+WebInspector.dockController.addEventListener(WebInspector.DockController.Events.DockSideChanged, this._dockSideChanged.bind(this));
+this._dockSideChanged();
+
this._sourceFramesByUISourceCode = new Map();
this._updateDebuggerButtons();
this._pauseOnExceptionStateChanged();
@@ -1174,6 +1174,8 @@
this.sidebarElement.appendChild(this.debugToolbar);
} else {
+this._showDebuggerSidebar();
+
this.sidebarPaneView = new WebInspector.SplitView(true, this.name + PanelSplitSidebarRatio, 0.5);
var group1 = new WebInspector.SidebarPaneStack();
Modified: trunk/Source/WebCore/inspector/front-end/scriptsPanel.css (143226 => 143227)
--- trunk/Source/WebCore/inspector/front-end/scriptsPanel.css 2013-02-18 16:49:46 UTC (rev 143226)
+++ trunk/Source/WebCore/inspector/front-end/scriptsPanel.css 2013-02-18 16:54:19 UTC (rev 143227)
@@ -264,6 +264,11 @@
border: none;
}
+.split-view-horizontal button.status-bar-item.scripts-debugger-show-hide-button,
+.split-view-horizontal #scripts-debug-sidebar-resizer-widget {
+display: none;
+}
+
button.status-bar-item.scripts-debugger-show-hide-button:active {
top: 1px;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [142976] trunk/Source/WebCore
Title: [142976] trunk/Source/WebCore
Revision 142976
Author pfeld...@chromium.org
Date 2013-02-15 02:37:39 -0800 (Fri, 15 Feb 2013)
Log Message
Web Inspector: make component-based compile-front-end happy
https://bugs.webkit.org/show_bug.cgi?id=109798
Reviewed by Vsevolod Vlasov.
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setVariableValue):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/compile-front-end.py:
* inspector/front-end/AuditResultView.js:
* inspector/front-end/CPUProfileView.js:
* inspector/front-end/DataGrid.js:
* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.loadTimelineFromURL):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptExterns.js
trunk/Source/WebCore/inspector/InjectedScriptSource.js
trunk/Source/WebCore/inspector/compile-front-end.py
trunk/Source/WebCore/inspector/front-end/AuditResultView.js
trunk/Source/WebCore/inspector/front-end/CPUProfileView.js
trunk/Source/WebCore/inspector/front-end/DataGrid.js
trunk/Source/WebCore/inspector/front-end/InspectorFrontendAPI.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (142975 => 142976)
--- trunk/Source/WebCore/ChangeLog 2013-02-15 10:29:12 UTC (rev 142975)
+++ trunk/Source/WebCore/ChangeLog 2013-02-15 10:37:39 UTC (rev 142976)
@@ -1,3 +1,22 @@
+2013-02-14 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: make component-based compile-front-end happy
+https://bugs.webkit.org/show_bug.cgi?id=109798
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/Inspector.json:
+* inspector/InspectorDebuggerAgent.cpp:
+(WebCore::InspectorDebuggerAgent::setVariableValue):
+* inspector/InspectorDebuggerAgent.h:
+(InspectorDebuggerAgent):
+* inspector/compile-front-end.py:
+* inspector/front-end/AuditResultView.js:
+* inspector/front-end/CPUProfileView.js:
+* inspector/front-end/DataGrid.js:
+* inspector/front-end/InspectorFrontendAPI.js:
+(InspectorFrontendAPI.loadTimelineFromURL):
+
2013-02-14 Alexander Pavlov apav...@chromium.org
Web Inspector: Implement tracking of active stylesheets in the frontend
Modified: trunk/Source/WebCore/inspector/InjectedScriptExterns.js (142975 => 142976)
--- trunk/Source/WebCore/inspector/InjectedScriptExterns.js 2013-02-15 10:29:12 UTC (rev 142975)
+++ trunk/Source/WebCore/inspector/InjectedScriptExterns.js 2013-02-15 10:37:39 UTC (rev 142976)
@@ -88,9 +88,8 @@
* @param {string} variableName
* @param {*} newValue
*/
-InjectedScriptHost.prototype.setFunctionVariableValue = function(fun, scopeNumber, variableName, newValue) {}
+InjectedScriptHost.prototype.setFunctionVariableValue = function(fun, scopeNumber, variableName, newValue) { }
-
/**
* @constructor
*/
Modified: trunk/Source/WebCore/inspector/InjectedScriptSource.js (142975 => 142976)
--- trunk/Source/WebCore/inspector/InjectedScriptSource.js 2013-02-15 10:29:12 UTC (rev 142975)
+++ trunk/Source/WebCore/inspector/InjectedScriptSource.js 2013-02-15 10:37:39 UTC (rev 142976)
@@ -604,13 +604,13 @@
setVariableValue: function(topCallFrame, callFrameId, functionObjectId, scopeNumber, variableName, newValueJsonString)
{
var setter;
-if (callFrameId) {
-var callFrame = this._callFrameForId(topCallFrame, String(callFrameId));
+if (typeof callFrameId === string) {
+var callFrame = this._callFrameForId(topCallFrame, callFrameId);
if (!callFrame)
return Could not find call frame with given id;
setter = callFrame.setVariableValue.bind(callFrame);
} else {
-var parsedFunctionId = this._parseObjectId(String(functionObjectId));
+var parsedFunctionId = this._parseObjectId(/** @type {string} */(functionObjectId));
var func = this._objectForId(parsedFunctionId);
if (typeof func !== function)
return Cannot resolve function by id.;
Modified: trunk/Source/WebCore/inspector/compile-front-end.py (142975 => 142976)
--- trunk/Source/WebCore/inspector/compile-front-end.py 2013-02-15 10:29:12 UTC (rev 142975)
+++ trunk/Source/WebCore/inspector/compile-front-end.py 2013-02-15 10:37:39 UTC (rev 142976)
@@ -126,6 +126,7 @@
DataGrid.js,
DefaultTextEditor.js,
Dialog.js,
+DockController.js,
Drawer.js,
EmptyView.js,
GoToLineDialog.js,
@@ -329,7 +330,7 @@
},
{
name: profiler,
-dependencies: [components],
+dependencies: [components, workers],
sources: [
BottomUpProfileDataGridTree.js,
CPUProfileView.js,
@@ -354,19 +355,12 @@
},
{
name: host_stub,
-dependencies: [ui],
+dependencies: [components, profiler, timeline],
[webkit-changes] [142660] branches/chromium/1364/Source/WebCore/inspector/front-end/ CallStackSidebarPane.js
Title: [142660] branches/chromium/1364/Source/WebCore/inspector/front-end/CallStackSidebarPane.js
Revision 142660
Author pfeld...@chromium.org
Date 2013-02-12 13:07:11 -0800 (Tue, 12 Feb 2013)
Log Message
Merge 142127
Web Inspector: break details are only rendered upon first debugger pause.
https://bugs.webkit.org/show_bug.cgi?id=109193
Reviewed by Vsevolod Vlasov.
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
TBR=pfeld...@chromium.org
Review URL: https://codereview.chromium.org/12225145
Modified Paths
branches/chromium/1364/Source/WebCore/inspector/front-end/CallStackSidebarPane.js
Diff
Modified: branches/chromium/1364/Source/WebCore/inspector/front-end/CallStackSidebarPane.js (142659 => 142660)
--- branches/chromium/1364/Source/WebCore/inspector/front-end/CallStackSidebarPane.js 2013-02-12 21:06:07 UTC (rev 142659)
+++ branches/chromium/1364/Source/WebCore/inspector/front-end/CallStackSidebarPane.js 2013-02-12 21:07:11 UTC (rev 142660)
@@ -40,6 +40,7 @@
update: function(callFrames)
{
this.bodyElement.removeChildren();
+delete this._statusMessageElement;
this.placards = [];
if (!callFrames) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [142661] branches/chromium/1364
Title: [142661] branches/chromium/1364
Revision 142661
Author pfeld...@chromium.org
Date 2013-02-12 13:15:42 -0800 (Tue, 12 Feb 2013)
Log Message
Merge 142128
Web Inspector: [Regression] Map.size() returns negative values.
https://bugs.webkit.org/show_bug.cgi?id=109174
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/utilities.js:
LayoutTests:
* inspector/map-expected.txt:
* inspector/map.html:
TBR=vse...@chromium.org
Review URL: https://codereview.chromium.org/12208136
Modified Paths
branches/chromium/1364/LayoutTests/inspector/map-expected.txt
branches/chromium/1364/LayoutTests/inspector/map.html
branches/chromium/1364/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: branches/chromium/1364/LayoutTests/inspector/map-expected.txt (142660 => 142661)
--- branches/chromium/1364/LayoutTests/inspector/map-expected.txt 2013-02-12 21:07:11 UTC (rev 142660)
+++ branches/chromium/1364/LayoutTests/inspector/map-expected.txt 2013-02-12 21:15:42 UTC (rev 142661)
@@ -5,96 +5,120 @@
First map:
key1 : undefined
key2 : undefined
+size : 0
Second map:
key1 : undefined
key2 : undefined
+size : 0
Dumping maps:
First map:
key1 : 2
key2 : undefined
+size : 1
Second map:
key1 : undefined
key2 : undefined
+size : 0
Dumping maps:
First map:
key1 : 1
key2 : undefined
+size : 1
Second map:
key1 : undefined
key2 : undefined
+size : 0
Dumping maps:
First map:
key1 : 1
key2 : undefined
+size : 1
Second map:
key1 : 1
key2 : undefined
+size : 1
Dumping maps:
First map:
key1 : 1
key2 : undefined
+size : 1
Second map:
key1 : 2
key2 : undefined
+size : 1
Dumping maps:
First map:
key1 : 1
key2 : 2
+size : 2
Second map:
key1 : 2
key2 : undefined
+size : 1
Dumping maps:
First map:
key1 : 1
key2 : 2
+size : 2
Second map:
key1 : 2
key2 : 1
+size : 2
Dumping maps:
First map:
key1 : 1
key2 : undefined
+size : 1
Second map:
key1 : 2
key2 : 1
+size : 2
Dumping maps:
First map:
key1 : 1
key2 : undefined
+size : 1
Second map:
key1 : 2
key2 : undefined
+size : 1
Dumping maps:
First map:
key1 : 1
key2 : undefined
+size : 1
Second map:
key1 : 2
key2 : undefined
+size : 1
Dumping maps:
First map:
key1 : undefined
key2 : undefined
+size : 0
Second map:
key1 : 2
key2 : undefined
+size : 1
Dumping maps:
First map:
key1 : undefined
key2 : undefined
+size : 0
Second map:
key1 : undefined
key2 : undefined
+size : 0
Modified: branches/chromium/1364/LayoutTests/inspector/map.html (142660 => 142661)
--- branches/chromium/1364/LayoutTests/inspector/map.html 2013-02-12 21:07:11 UTC (rev 142660)
+++ branches/chromium/1364/LayoutTests/inspector/map.html 2013-02-12 21:15:42 UTC (rev 142661)
@@ -11,9 +11,11 @@
InspectorTest.addResult( First map:);
InspectorTest.addResult(key1 : + map1.get(key1));
InspectorTest.addResult(key2 : + map1.get(key2));
+InspectorTest.addResult(size : + map1.size());
InspectorTest.addResult( Second map:);
InspectorTest.addResult(key1 : + map2.get(key1));
InspectorTest.addResult(key2 : + map2.get(key2));
+InspectorTest.addResult(size : + map2.size());
InspectorTest.addResult();
}
Modified: branches/chromium/1364/Source/WebCore/inspector/front-end/utilities.js (142660 => 142661)
--- branches/chromium/1364/Source/WebCore/inspector/front-end/utilities.js 2013-02-12 21:07:11 UTC (rev 142660)
+++ branches/chromium/1364/Source/WebCore/inspector/front-end/utilities.js 2013-02-12 21:15:42 UTC (rev 142661)
@@ -705,9 +705,11 @@
remove: function(key)
{
var result = this._map[key.__identifier];
+if (!result)
+return undefined;
+--this._size;
delete this._map[key.__identifier];
---this._size;
-return result ? result[1] : undefined;
+return result[1];
},
/**
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [142450] trunk/Source/WebCore
Title: [142450] trunk/Source/WebCore
Revision 142450
Author pfeld...@chromium.org
Date 2013-02-11 03:49:43 -0800 (Mon, 11 Feb 2013)
Log Message
Web Inspector: highlight DOM nodes on hover while debugging
https://bugs.webkit.org/show_bug.cgi?id=109355
Reviewed by Vsevolod Vlasov.
Along with showing the popover, highlight the remote object as node.
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (142449 => 142450)
--- trunk/Source/WebCore/ChangeLog 2013-02-11 11:42:07 UTC (rev 142449)
+++ trunk/Source/WebCore/ChangeLog 2013-02-11 11:49:43 UTC (rev 142450)
@@ -1,3 +1,17 @@
+2013-02-11 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: highlight DOM nodes on hover while debugging
+https://bugs.webkit.org/show_bug.cgi?id=109355
+
+Reviewed by Vsevolod Vlasov.
+
+Along with showing the popover, highlight the remote object as node.
+
+* inspector/front-end/ObjectPopoverHelper.js:
+(WebInspector.ObjectPopoverHelper.prototype.):
+(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
+(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):
+
2013-02-11 Andrey Lushnikov lushni...@chromium.org
Web Inspector: displaying whitespace characters is broken
Modified: trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js (142449 => 142450)
--- trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js 2013-02-11 11:42:07 UTC (rev 142449)
+++ trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js 2013-02-11 11:49:43 UTC (rev 142450)
@@ -106,8 +106,9 @@
popoverContentElement.textContent = \ + popoverContentElement.textContent + \;
popover.show(popoverContentElement, anchorElement);
} else {
+if (result.subtype === node)
+result.highlightAsDOMNode();
popoverContentElement = document.createElement(div);
-
this._titleElement = document.createElement(div);
this._titleElement.className = source-frame-popover-title monospace;
this._titleElement.textContent = result.description;
@@ -134,6 +135,7 @@
_onHideObjectPopover: function()
{
+WebInspector.domAgent.hideDOMNodeHighlight();
if (this._linkifier) {
this._linkifier.reset();
delete this._linkifier;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [142080] branches/chromium/1364/Source/WebCore/inspector/InspectorOverlay. cpp
Title: [142080] branches/chromium/1364/Source/WebCore/inspector/InspectorOverlay.cpp Revision 142080 Author pfeld...@chromium.org Date 2013-02-07 01:03:35 -0800 (Thu, 07 Feb 2013) Log Message Merge 141772 Web Inspector: take page scale factor into account when updating overlay. https://bugs.webkit.org/show_bug.cgi?id=108831 Reviewed by Vsevolod Vlasov. Otherwise, the ports that use page scale factor have broken overlay. * inspector/InspectorOverlay.cpp: (WebCore::InspectorOverlay::update): TBR=pfeld...@chromium.org Review URL: https://codereview.chromium.org/12217060 Modified Paths branches/chromium/1364/Source/WebCore/inspector/InspectorOverlay.cpp Diff Modified: branches/chromium/1364/Source/WebCore/inspector/InspectorOverlay.cpp (142079 => 142080) --- branches/chromium/1364/Source/WebCore/inspector/InspectorOverlay.cpp 2013-02-07 09:01:49 UTC (rev 142079) +++ branches/chromium/1364/Source/WebCore/inspector/InspectorOverlay.cpp 2013-02-07 09:03:35 UTC (rev 142080) @@ -285,6 +285,8 @@ IntSize viewportSize = enclosingIntRect(view-visibleContentRect()).size(); IntSize frameViewFullSize = enclosingIntRect(view-visibleContentRect(true)).size(); IntSize size = m_size.isEmpty() ? frameViewFullSize : m_size; +overlayPage()-setPageScaleFactor(m_page-pageScaleFactor(), IntPoint()); +size.scale(m_page-pageScaleFactor()); overlayView-resize(size); // Clear canvas and paint things. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [142085] branches/chromium/1364
Title: [142085] branches/chromium/1364
Revision 142085
Author pfeld...@chromium.org
Date 2013-02-07 01:37:42 -0800 (Thu, 07 Feb 2013)
Log Message
Merge 140539
Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
https://bugs.webkit.org/show_bug.cgi?id=107523
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::isUnderTest):
(WebCore):
(WebCore::InspectorController::evaluateForTestInFrontend):
* inspector/InspectorController.h:
(InspectorController):
* inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::isUnderTest):
(WebCore):
* inspector/InspectorFrontendClientLocal.h:
(InspectorFrontendClientLocal):
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::isUnderTest):
(WebCore):
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/DOMExtension.js:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.canInspectWorkers):
(.WebInspector.InspectorFrontendHostStub.prototype.isUnderTest):
* inspector/front-end/TestController.js:
(.invokeMethod):
(WebInspector.evaluateForTestInFrontend):
* inspector/front-end/externs.js:
Source/WebKit/chromium:
* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::isUnderTest):
(WebDevToolsFrontendClient):
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::isUnderTest):
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):
Tools:
* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::isUnderTest):
(DRTDevToolsClient::call):
* DumpRenderTree/chromium/DRTDevToolsClient.h:
(DRTDevToolsClient):
TBR=pfeld...@chromium.org
Review URL: https://codereview.chromium.org/12224049
Modified Paths
branches/chromium/1364/Source/WebCore/WebCore.exp.in
branches/chromium/1364/Source/WebCore/inspector/InspectorController.cpp
branches/chromium/1364/Source/WebCore/inspector/InspectorController.h
branches/chromium/1364/Source/WebCore/inspector/InspectorFrontendClient.h
branches/chromium/1364/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp
branches/chromium/1364/Source/WebCore/inspector/InspectorFrontendClientLocal.h
branches/chromium/1364/Source/WebCore/inspector/InspectorFrontendHost.cpp
branches/chromium/1364/Source/WebCore/inspector/InspectorFrontendHost.h
branches/chromium/1364/Source/WebCore/inspector/InspectorFrontendHost.idl
branches/chromium/1364/Source/WebCore/inspector/front-end/DOMExtension.js
branches/chromium/1364/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js
branches/chromium/1364/Source/WebCore/inspector/front-end/TestController.js
branches/chromium/1364/Source/WebCore/inspector/front-end/externs.js
branches/chromium/1364/Source/WebKit/chromium/public/WebDevToolsFrontendClient.h
branches/chromium/1364/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp
branches/chromium/1364/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h
branches/chromium/1364/Tools/DumpRenderTree/chromium/DRTDevToolsClient.cpp
branches/chromium/1364/Tools/DumpRenderTree/chromium/DRTDevToolsClient.h
Diff
Modified: branches/chromium/1364/Source/WebCore/WebCore.exp.in (142084 => 142085)
--- branches/chromium/1364/Source/WebCore/WebCore.exp.in 2013-02-07 09:24:51 UTC (rev 142084)
+++ branches/chromium/1364/Source/WebCore/WebCore.exp.in 2013-02-07 09:37:42 UTC (rev 142085)
@@ -2363,6 +2363,7 @@
__ZN7WebCore24InspectorInstrumentation17s_frontendCounterE
__ZN7WebCore24InspectorInstrumentation18didCancelFrameImplEPNS_19InstrumentingAgentsE
__ZN7WebCore24InspectorInstrumentation26instrumentingAgentsForPageEPNS_4PageE
+__ZN7WebCore28InspectorFrontendClientLocal11isUnderTestEv
__ZN7WebCore28InspectorFrontendClientLocal11showConsoleEv
__ZN7WebCore28InspectorFrontendClientLocal12moveWindowByEff
__ZN7WebCore28InspectorFrontendClientLocal12openInNewTabERKN3WTF6StringE
Modified: branches/chromium/1364/Source/WebCore/inspector/InspectorController.cpp (142084 => 142085)
--- branches/chromium/1364/Source/WebCore/inspector/InspectorController.cpp 2013-02-07 09:24:51 UTC (rev 142084)
+++ branches/chromium/1364/Source/WebCore/inspector/InspectorController.cpp 2013-02-07 09:37:42 UTC (rev 142085)
@@ -86,6 +86,7 @@
, m_overlay(InspectorOverlay::create(page, inspectorClient))
, m_page(page)
, m_inspectorClient(inspectorClient)
+, m_isUnderTest(false)
{
OwnPtrInspectorAgent inspectorAgentPtr(InspectorAgent::create(page, m_injectedScriptManager.get(), m_instrumentingAgents.get(), m_state.get()));
m_inspectorAgent = inspectorAgentPtr.get();
@@ -298,8 +299,14 @@
[webkit-changes] [142127] trunk/Source/WebCore
Title: [142127] trunk/Source/WebCore
Revision 142127
Author pfeld...@chromium.org
Date 2013-02-07 08:25:43 -0800 (Thu, 07 Feb 2013)
Log Message
Web Inspector: break details are only rendered upon first debugger pause.
https://bugs.webkit.org/show_bug.cgi?id=109193
Reviewed by Vsevolod Vlasov.
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (142126 => 142127)
--- trunk/Source/WebCore/ChangeLog 2013-02-07 16:22:49 UTC (rev 142126)
+++ trunk/Source/WebCore/ChangeLog 2013-02-07 16:25:43 UTC (rev 142127)
@@ -1,3 +1,13 @@
+2013-02-07 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: break details are only rendered upon first debugger pause.
+https://bugs.webkit.org/show_bug.cgi?id=109193
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/CallStackSidebarPane.js:
+(WebInspector.CallStackSidebarPane.prototype.update):
+
2013-02-07 Gavin Peters gav...@chromium.org
Unreviewed, rolling out r142118.
Modified: trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js (142126 => 142127)
--- trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js 2013-02-07 16:22:49 UTC (rev 142126)
+++ trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js 2013-02-07 16:25:43 UTC (rev 142127)
@@ -40,6 +40,7 @@
update: function(callFrames)
{
this.bodyElement.removeChildren();
+delete this._statusMessageElement;
this.placards = [];
if (!callFrames) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141979] trunk/Source/WebCore
Title: [141979] trunk/Source/WebCore
Revision 141979
Author pfeld...@chromium.org
Date 2013-02-06 02:11:54 -0800 (Wed, 06 Feb 2013)
Log Message
Web Inspector: file selector list jumps as I type or move Up/Down
https://bugs.webkit.org/show_bug.cgi?id=108933
Reviewed by Vsevolod Vlasov.
Missing return was scheduling extra updates.
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
(WebInspector.FilteredItemSelectionDialog.prototype._updateSelection):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (141978 => 141979)
--- trunk/Source/WebCore/ChangeLog 2013-02-06 09:54:56 UTC (rev 141978)
+++ trunk/Source/WebCore/ChangeLog 2013-02-06 10:11:54 UTC (rev 141979)
@@ -1,3 +1,18 @@
+2013-02-06 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: file selector list jumps as I type or move Up/Down
+https://bugs.webkit.org/show_bug.cgi?id=108933
+
+Reviewed by Vsevolod Vlasov.
+
+Missing return was scheduling extra updates.
+
+* inspector/front-end/FilteredItemSelectionDialog.js:
+(WebInspector.FilteredItemSelectionDialog):
+(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
+(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
+(WebInspector.FilteredItemSelectionDialog.prototype._updateSelection):
+
2013-02-06 Kentaro Hara hara...@chromium.org
[V8] Pass an Isolate to remaining GetTemplate()s
Modified: trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js (141978 => 141979)
--- trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2013-02-06 09:54:56 UTC (rev 141978)
+++ trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2013-02-06 10:11:54 UTC (rev 141979)
@@ -60,7 +60,6 @@
this._itemElementsContainer = this._viewportControl.element;
this._itemElementsContainer.addStyleClass(container);
this._itemElementsContainer.addStyleClass(monospace);
-this._itemElementsContainer.addEventListener(mousemove, this._onMouseMove.bind(this), false);
this._itemElementsContainer.addEventListener(click, this._onClick.bind(this), false);
this.element.appendChild(this._itemElementsContainer);
@@ -113,8 +112,6 @@
onEnter: function()
{
-if (typeof this._selectedIndexInFiltered !== number)
-return;
this._delegate.selectItem(this._filteredItems[this._selectedIndexInFiltered], this._promptElement.value.trim());
},
@@ -225,7 +222,7 @@
var camelCaseScoringRegex = query ? this._createScoringRegex(query, ignoreCase, true) : null;
var underscoreScoringRegex = query ? this._createScoringRegex(query, ignoreCase, false) : null;
-var oldSelectedAbsoluteIndex = this._filteredItems[this._selectedIndexInFiltered];
+var oldSelectedAbsoluteIndex = this._selectedIndexInFiltered ? this._filteredItems[this._selectedIndexInFiltered] : null;
this._filteredItems = [];
this._selectedIndexInFiltered = 0;
@@ -286,45 +283,48 @@
}
}
this._viewportControl.refresh();
-this._updateSelection(this._selectedIndexInFiltered);
+this._updateSelection(this._selectedIndexInFiltered, false);
},
_onKeyDown: function(event)
{
-if (typeof this._selectedIndexInFiltered === number) {
-var newSelectedIndex = this._selectedIndexInFiltered;
+var newSelectedIndex = this._selectedIndexInFiltered;
-function updateSelection(makeLast)
-{
-this._viewportControl.scrollItemIntoView(newSelectedIndex, makeLast);
-this._updateSelection(newSelectedIndex);
-event.consume(true);
-}
-
-switch (event.keyCode) {
-case WebInspector.KeyboardShortcut.Keys.Down.code:
-if (++newSelectedIndex = this._filteredItems.length)
-newSelectedIndex = this._filteredItems.length - 1;
-updateSelection.call(this, true);
-break;
-case WebInspector.KeyboardShortcut.Keys.Up.code:
-if (--newSelectedIndex 0)
-newSelectedIndex = 0;
-updateSelection.call(this, false);
-break;
-case WebInspector.KeyboardShortcut.Keys.PageDown.code:
-newSelectedIndex = Math.min(newSelectedIndex + this._viewportControl.rowsPerViewport(), this._filteredItems.length - 1);
-updateSelection.call(this, true);
-break;
-case WebInspector.KeyboardShortcut.Keys.PageUp.code:
-newSelectedIndex =
[webkit-changes] [141989] trunk/Source/WebCore
Title: [141989] trunk/Source/WebCore Revision 141989 Author pfeld...@chromium.org Date 2013-02-06 05:04:47 -0800 (Wed, 06 Feb 2013) Log Message Follow up to r141979: do not consume Home/End. Not reviewed. * inspector/front-end/FilteredItemSelectionDialog.js: (WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js Diff Modified: trunk/Source/WebCore/ChangeLog (141988 => 141989) --- trunk/Source/WebCore/ChangeLog 2013-02-06 13:03:15 UTC (rev 141988) +++ trunk/Source/WebCore/ChangeLog 2013-02-06 13:04:47 UTC (rev 141989) @@ -1,3 +1,11 @@ +2013-02-06 Pavel Feldman pfeld...@chromium.org + +Follow up to r141979: do not consume Home/End. +Not reviewed. + +* inspector/front-end/FilteredItemSelectionDialog.js: +(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown): + 2013-02-06 Vsevolod Vlasov vse...@chromium.org Web Inspector: Remove show script folders setting Modified: trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js (141988 => 141989) --- trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2013-02-06 13:03:15 UTC (rev 141988) +++ trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2013-02-06 13:04:47 UTC (rev 141989) @@ -313,14 +313,6 @@ this._updateSelection(newSelectedIndex, false); event.consume(true); break; -case WebInspector.KeyboardShortcut.Keys.Home.code: -this._updateSelection(0, false); -event.consume(true); -break; -case WebInspector.KeyboardShortcut.Keys.End.code: -this._updateSelection(this._filteredItems.length - 1, true); -event.consume(true); -break; default: if (event.keyIdentifier !== Shift event.keyIdentifier !== Ctrl event.keyIdentifier !== Meta event.keyIdentifier !== Left event.keyIdentifier !== Right) this._scheduleFilter(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141751] trunk/Source/WebCore
Title: [141751] trunk/Source/WebCore
Revision 141751
Author pfeld...@chromium.org
Date 2013-02-04 02:46:48 -0800 (Mon, 04 Feb 2013)
Log Message
Web Inspector: make tabbed pane header a relayout boundary.
https://bugs.webkit.org/show_bug.cgi?id=108650
Reviewed by Alexander Pavlov.
Otherwise, its measure width routine causes total reflow.
* inspector/front-end/tabbedPane.css:
(.tabbed-pane-header):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/tabbedPane.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (141750 => 141751)
--- trunk/Source/WebCore/ChangeLog 2013-02-04 10:27:27 UTC (rev 141750)
+++ trunk/Source/WebCore/ChangeLog 2013-02-04 10:46:48 UTC (rev 141751)
@@ -1,3 +1,15 @@
+2013-02-04 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: make tabbed pane header a relayout boundary.
+https://bugs.webkit.org/show_bug.cgi?id=108650
+
+Reviewed by Alexander Pavlov.
+
+Otherwise, its measure width routine causes total reflow.
+
+* inspector/front-end/tabbedPane.css:
+(.tabbed-pane-header):
+
2013-02-04 Hayato Ito hay...@chromium.org
Split InspectorCSSOMWrappers out from StyleResolver.h into its own file.
Modified: trunk/Source/WebCore/inspector/front-end/tabbedPane.css (141750 => 141751)
--- trunk/Source/WebCore/inspector/front-end/tabbedPane.css 2013-02-04 10:27:27 UTC (rev 141750)
+++ trunk/Source/WebCore/inspector/front-end/tabbedPane.css 2013-02-04 10:46:48 UTC (rev 141751)
@@ -47,6 +47,8 @@
.tabbed-pane-header {
height: 23px;
border-bottom: 1px solid rgb(163, 163, 163);
+overflow: hidden;
+width: 100%;
}
.tabbed-pane-header-contents {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141772] trunk/Source/WebCore
Title: [141772] trunk/Source/WebCore Revision 141772 Author pfeld...@chromium.org Date 2013-02-04 08:42:23 -0800 (Mon, 04 Feb 2013) Log Message Web Inspector: take page scale factor into account when updating overlay. https://bugs.webkit.org/show_bug.cgi?id=108831 Reviewed by Vsevolod Vlasov. Otherwise, the ports that use page scale factor have broken overlay. * inspector/InspectorOverlay.cpp: (WebCore::InspectorOverlay::update): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorOverlay.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (141771 => 141772) --- trunk/Source/WebCore/ChangeLog 2013-02-04 15:56:52 UTC (rev 141771) +++ trunk/Source/WebCore/ChangeLog 2013-02-04 16:42:23 UTC (rev 141772) @@ -1,3 +1,15 @@ +2013-02-04 Pavel Feldman pfeld...@chromium.org + +Web Inspector: take page scale factor into account when updating overlay. +https://bugs.webkit.org/show_bug.cgi?id=108831 + +Reviewed by Vsevolod Vlasov. + +Otherwise, the ports that use page scale factor have broken overlay. + +* inspector/InspectorOverlay.cpp: +(WebCore::InspectorOverlay::update): + 2013-02-04 Dan Carney dcar...@google.com [v8] explicit isolate parameter for MakeWeak calls Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (141771 => 141772) --- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2013-02-04 15:56:52 UTC (rev 141771) +++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2013-02-04 16:42:23 UTC (rev 141772) @@ -285,6 +285,8 @@ IntSize viewportSize = enclosingIntRect(view-visibleContentRect()).size(); IntSize frameViewFullSize = enclosingIntRect(view-visibleContentRect(true)).size(); IntSize size = m_size.isEmpty() ? frameViewFullSize : m_size; +overlayPage()-setPageScaleFactor(m_page-pageScaleFactor(), IntPoint()); +size.scale(m_page-pageScaleFactor()); overlayView-resize(size); // Clear canvas and paint things. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141579] trunk/Source/WebCore
Title: [141579] trunk/Source/WebCore
Revision 141579
Author pfeld...@chromium.org
Date 2013-02-01 04:23:56 -0800 (Fri, 01 Feb 2013)
Log Message
Web Inspector: Follow up to r141260: fixing renamed style.
Not reviewed.
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._onClick):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (141578 => 141579)
--- trunk/Source/WebCore/ChangeLog 2013-02-01 12:16:51 UTC (rev 141578)
+++ trunk/Source/WebCore/ChangeLog 2013-02-01 12:23:56 UTC (rev 141579)
@@ -1,3 +1,13 @@
+2013-02-01 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: Follow up to r141260: fixing renamed style.
+Not reviewed.
+
+* inspector/front-end/FilteredItemSelectionDialog.js:
+(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
+(WebInspector.FilteredItemSelectionDialog.prototype._onClick):
+(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
+
2013-02-01 Alexis Menard ale...@webkit.org
Enable unprefixed CSS transitions by default.
Modified: trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js (141578 => 141579)
--- trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2013-02-01 12:16:51 UTC (rev 141578)
+++ trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2013-02-01 12:23:56 UTC (rev 141579)
@@ -150,7 +150,7 @@
itemElement._titleSuffixElement = itemElement.createChild(span);
itemElement._titleSuffixElement.textContent = this._delegate.itemSuffixAt(index);
itemElement._subtitleElement = itemElement.createChild(div, filtered-item-list-dialog-subtitle);
-itemElement._subtitleElement.textContent = this._delegate.itemSubtitleAt(index);
+itemElement._subtitleElement.textContent = this._delegate.itemSubtitleAt(index) || \u200B;
itemElement._index = index;
var key = this._delegate.itemKeyAt(index);
@@ -285,7 +285,7 @@
_onClick: function(event)
{
-var itemElement = event.target.enclosingNodeOrSelfWithClass(item);
+var itemElement = event.target.enclosingNodeOrSelfWithClass(filtered-item-list-dialog-item);
if (!itemElement)
return;
this._delegate.selectItem(itemElement._index, this._promptElement.value.trim());
@@ -298,7 +298,7 @@
return;
this._lastMouseX = event.pageX;
this._lastMouseY = event.pageY;
-var itemElement = event.target.enclosingNodeOrSelfWithClass(item);
+var itemElement = event.target.enclosingNodeOrSelfWithClass(filtered-item-list-dialog-item);
if (!itemElement)
return;
this._updateSelection(itemElement._index);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141594] trunk
Title: [141594] trunk
Revision 141594
Author pfeld...@chromium.org
Date 2013-02-01 07:46:32 -0800 (Fri, 01 Feb 2013)
Log Message
Web Inspector: relax goto file matching again.
https://bugs.webkit.org/show_bug.cgi?id=108346
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change brings back behavior introduced in r116244.
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems.compareFunction):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
(WebInspector.FilteredItemSelectionDialog.prototype.itemElement):
(WebInspector.OpenResourceDialog):
* inspector/front-end/utilities.js:
(String.regexSpecialCharacters):
(String.prototype.escapeForRegExp):
LayoutTests:
* inspector/filtered-item-selection-dialog-filtering-expected.txt:
* inspector/filtered-item-selection-dialog-filtering.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt
trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js
trunk/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: trunk/LayoutTests/ChangeLog (141593 => 141594)
--- trunk/LayoutTests/ChangeLog 2013-02-01 15:43:25 UTC (rev 141593)
+++ trunk/LayoutTests/ChangeLog 2013-02-01 15:46:32 UTC (rev 141594)
@@ -1,3 +1,13 @@
+2013-02-01 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: relax goto file matching again.
+https://bugs.webkit.org/show_bug.cgi?id=108346
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/filtered-item-selection-dialog-filtering-expected.txt:
+* inspector/filtered-item-selection-dialog-filtering.html:
+
2013-02-01 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Navigator should not create tree elements for uiSourceCodes unless neededm should populate folders on expand only.
Modified: trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt (141593 => 141594)
--- trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt 2013-02-01 15:43:25 UTC (rev 141593)
+++ trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt 2013-02-01 15:46:32 UTC (rev 141594)
@@ -1,75 +1,48 @@
Check to see that FilteredItemSelectionDialog uses proper regex to filter results.
-{
-input : [a,bc]
-output : [a,bc]
-query :
-title : Empty query matches everything
-}
-{
-input : [abc,acB]
-output : [acB]
-query : aB
-title : Case sensitive matching
-}
-{
-input : [abc,bac,a_B]
-output : [abc]
-query : ab
-title : Case insensitive matching
-}
-{
-input : [div .visible,div . visible ]
-output : [div .visible]
-query : d.v
-title : Spaces in the input
-}
-{
-input : [abab,abaa,caab,baac,fooaab]
-output : [caab,fooaab]
-query : aab
-title : Duplicate symbols in query
-}
-{
-input : [abab,abaa,caab,baac,fooaab]
-output : [caab,fooaab]
-query : *aab
-title : Star in query
-}
-{
-input : [abab,abaa,caab,aqb,fooaab]
-output : [caab,aqb,fooaab]
-query : a?b
-title : Question in query
-}
-{
-input : [^[]{}()\\.$*+?|,0123456789abcdef]
-output : [^[]{}()\\.$*+?|]
-query : ^[]{}()\.$*+?|
-title : Dangerous input escaping
-}
-{
-input : [fooBarBaz,FooBarBaz,Foo_Bar_Baz,foo_bar_baz,foobarbaz,foobarBaz,afooBarBaz,aFooBarBaz,a fooBarBaz,fooBorBaz,fooBorCaz]
-output : [fooBarBaz,afooBarBaz,a fooBarBaz]
-query : fBaB
-title : Camel case matching
-}
-{
-input : [foOBarBaz,FoOBarBaz,FoO_Bar_Baz,foO_bar_baz,foObarbaz,foObarBaz,afoOBarBaz,aFoOBarBaz,a foOBarBaz,foOBorBaz,foOBorCaz]
-output : [foO_bar_baz]
-query : fO_ba_b
-title : Underscore matching
-}
-{
-input : [foo_bar,FB,foobar,fBar]
-output : [FB,fBar]
-query : fb
-title : Case insensitive matching
-}
-{
-input : [foo_bar,FOO_BAR,Foo_Bar,fOo_bAr]
-output : [foo_bar,FOO_BAR,Foo_Bar,fOo_bAr]
-query : f_b
-title : Case insensitive underscore matching
-}
+Empty query matches everything
+Query:
+Input:[a,bc]
+Output:[a,bc]
+
+Case sensitive matching
+Query:aB
+Input:[abc,acB]
+Output:[abc,acB]
+
+Case insensitive matching
+Query:ab
+Input:[abc,bac,a_B]
+Output:[a_B,abc]
+
+Duplicate symbols in query
+Query:aab
+Input:[abab,abaa,caab,baac,fooaab]
+Output:[abab,caab,fooaab]
+
+Dangerous input escaping
+Query:^[]{}()\\.$*+?|
+Input:[^[]{}()\\.$*+?|,0123456789abcdef]
+Output:[^[]{}()\\.$*+?|]
+
+Camel case matching
+Query:fBaB
[webkit-changes] [141607] trunk
Title: [141607] trunk
Revision 141607
Author pfeld...@chromium.org
Date 2013-02-01 10:49:10 -0800 (Fri, 01 Feb 2013)
Log Message
Web Inspector: [file selector dialog] for mixed case queries, score uppercase letters only when assessing camelcase.
https://bugs.webkit.org/show_bug.cgi?id=108639
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):
LayoutTests:
* inspector/filtered-item-selection-dialog-filtering-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js
Diff
Modified: trunk/LayoutTests/ChangeLog (141606 => 141607)
--- trunk/LayoutTests/ChangeLog 2013-02-01 18:45:27 UTC (rev 141606)
+++ trunk/LayoutTests/ChangeLog 2013-02-01 18:49:10 UTC (rev 141607)
@@ -1,3 +1,12 @@
+2013-02-01 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: [file selector dialog] for mixed case queries, score uppercase letters only when assessing camelcase.
+https://bugs.webkit.org/show_bug.cgi?id=108639
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/filtered-item-selection-dialog-filtering-expected.txt:
+
2013-02-01 Robert Hogan rob...@webkit.org
Padding in a parent inline preceding an empty inline child should be counted towards width
Modified: trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt (141606 => 141607)
--- trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt 2013-02-01 18:45:27 UTC (rev 141606)
+++ trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt 2013-02-01 18:49:10 UTC (rev 141607)
@@ -9,7 +9,7 @@
Case sensitive matching
Query:aB
Input:[abc,acB]
-Output:[abc,acB]
+Output:[acB,abc]
Case insensitive matching
Query:ab
@@ -29,7 +29,7 @@
Camel case matching
Query:fBaB
Input:[fooBarBaz,FooBarBaz,Foo_Bar_Baz,foo_bar_baz,foobarbaz,foobarBaz,afooBarBaz,aFooBarBaz,a fooBarBaz,fooBorBaz,fooBorCaz]
-Output:[fooBarBaz,foo_bar_baz,foobarBaz,foobarbaz,FooBarBaz,Foo_Bar_Baz,a fooBarBaz,aFooBarBaz,afooBarBaz]
+Output:[fooBarBaz,FooBarBaz,Foo_Bar_Baz,a fooBarBaz,aFooBarBaz,afooBarBaz,foo_bar_baz,foobarBaz,foobarbaz]
Underscore matching
Query:fO_ba_b
Modified: trunk/Source/WebCore/ChangeLog (141606 => 141607)
--- trunk/Source/WebCore/ChangeLog 2013-02-01 18:45:27 UTC (rev 141606)
+++ trunk/Source/WebCore/ChangeLog 2013-02-01 18:49:10 UTC (rev 141607)
@@ -1,3 +1,13 @@
+2013-02-01 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: [file selector dialog] for mixed case queries, score uppercase letters only when assessing camelcase.
+https://bugs.webkit.org/show_bug.cgi?id=108639
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/FilteredItemSelectionDialog.js:
+(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):
+
2013-02-01 Robert Hogan rob...@webkit.org
Padding in a parent inline preceding an empty inline child should be counted towards width
Modified: trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js (141606 => 141607)
--- trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2013-02-01 18:45:27 UTC (rev 141606)
+++ trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2013-02-01 18:49:10 UTC (rev 141607)
@@ -190,12 +190,14 @@
/**
* @param {string} query
+ * @param {boolean} ignoreCase
* @param {boolean} camelCase
* @return {RegExp}
*/
-_createScoringRegex: function(query, camelCase)
+_createScoringRegex: function(query, ignoreCase, camelCase)
{
-query = query.toUpperCase();
+if (!camelCase || (camelCase ignoreCase))
+query = query.toUpperCase();
var regexString = ;
for (var i = 0; i query.length; ++i) {
var c = query.charAt(i);
@@ -220,8 +222,8 @@
var ignoreCase = (query === query.toLowerCase());
var filterRegex = query ? this._createSearchRegex(query) : null;
-var camelCaseScoringRegex = query ? this._createScoringRegex(query, true) : null;
-var underscoreScoringRegex = query ? this._createScoringRegex(query, false) : null;
+var camelCaseScoringRegex = query ? this._createScoringRegex(query, ignoreCase, true) : null;
+var underscoreScoringRegex = query ? this._createScoringRegex(query, ignoreCase, false) : null;
var oldSelectedAbsoluteIndex = this._filteredItems[this._selectedIndexInFiltered];
this._filteredItems = [];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141613] trunk/Source/WebCore
Title: [141613] trunk/Source/WebCore
Revision 141613
Author pfeld...@chromium.org
Date 2013-02-01 11:07:46 -0800 (Fri, 01 Feb 2013)
Log Message
Web Inspector: make console object state hint non-active
https://bugs.webkit.org/show_bug.cgi?id=108642
Reviewed by Vsevolod Vlasov.
Otherwise it seems like an active element user could click.
* inspector/front-end/inspector.css:
(.object-info-state-note):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (141612 => 141613)
--- trunk/Source/WebCore/ChangeLog 2013-02-01 19:04:43 UTC (rev 141612)
+++ trunk/Source/WebCore/ChangeLog 2013-02-01 19:07:46 UTC (rev 141613)
@@ -1,3 +1,15 @@
+2013-02-01 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: make console object state hint non-active
+https://bugs.webkit.org/show_bug.cgi?id=108642
+
+Reviewed by Vsevolod Vlasov.
+
+Otherwise it seems like an active element user could click.
+
+* inspector/front-end/inspector.css:
+(.object-info-state-note):
+
2013-02-01 Rashmi Shyamasundar rashmi...@samsung.com
Zero size gradient should paint nothing on canvas
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (141612 => 141613)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2013-02-01 19:04:43 UTC (rev 141612)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2013-02-01 19:07:46 UTC (rev 141613)
@@ -1214,24 +1214,21 @@
.object-info-state-note {
display: none;
-width: 12px;
-height: 12px;
+width: 11px;
+height: 11px;
background-color: rgb(179, 203, 247);
color: white;
text-align: center;
-border-radius: 5px;
+border-radius: 3px;
line-height: 13px;
-margin: 0 8px;
+margin: 0 6px;
+font-size: 9px;
}
.object-info-state-note::before {
content: i;
}
-.object-info-state-note:hover {
-background-color: rgb(52, 115, 231);
-}
-
.section.expanded .object-info-state-note {
display: inline-block;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141411] trunk/Source/WebCore
Title: [141411] trunk/Source/WebCore
Revision 141411
Author pfeld...@chromium.org
Date 2013-01-31 06:05:06 -0800 (Thu, 31 Jan 2013)
Log Message
Web Inspector: highlight backend languages as scripts
https://bugs.webkit.org/show_bug.cgi?id=108336
Reviewed by Vsevolod Vlasov.
Most languages have structure similar to js, so enabling default highlighter for them won't hurt.
* inspector/front-end/FileSystemWorkspaceProvider.js:
(WebInspector.FileSystemWorkspaceProvider.prototype._contentTypeForPath):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (141410 => 141411)
--- trunk/Source/WebCore/ChangeLog 2013-01-31 13:48:12 UTC (rev 141410)
+++ trunk/Source/WebCore/ChangeLog 2013-01-31 14:05:06 UTC (rev 141411)
@@ -1,3 +1,15 @@
+2013-01-31 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: highlight backend languages as scripts
+https://bugs.webkit.org/show_bug.cgi?id=108336
+
+Reviewed by Vsevolod Vlasov.
+
+Most languages have structure similar to js, so enabling default highlighter for them won't hurt.
+
+* inspector/front-end/FileSystemWorkspaceProvider.js:
+(WebInspector.FileSystemWorkspaceProvider.prototype._contentTypeForPath):
+
2013-01-31 Andrey Adaikin aand...@chromium.org
Web Inspector: [Profiles] show launcher view upon deleting last profile type's header
Modified: trunk/Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js (141410 => 141411)
--- trunk/Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js 2013-01-31 13:48:12 UTC (rev 141410)
+++ trunk/Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js 2013-01-31 14:05:06 UTC (rev 141411)
@@ -44,6 +44,8 @@
this._isolatedFileSystemModel.mapping().addEventListener(WebInspector.FileSystemMapping.Events.FileSystemRemoved, this._fileSystemRemoved, this);
}
+WebInspector.FileSystemWorkspaceProvider._scriptExtensions = [js, java, cc, cpp, h, cs, py, php].keySet();
+
WebInspector.FileSystemWorkspaceProvider.prototype = {
/**
* @param {string} uri
@@ -120,7 +122,7 @@
if (extensionIndex !== -1)
extension = fileName.substring(extensionIndex + 1);
var contentType = WebInspector.resourceTypes.Other;
-if (extension === js)
+if (WebInspector.FileSystemWorkspaceProvider._scriptExtensions[extension])
return WebInspector.resourceTypes.Script;
if (extension === css)
return WebInspector.resourceTypes.Stylesheet;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141260] trunk/Source/WebCore
Title: [141260] trunk/Source/WebCore
Revision 141260
Author pfeld...@chromium.org
Date 2013-01-30 06:03:32 -0800 (Wed, 30 Jan 2013)
Log Message
Web Inspector: beautify file selector dialog to render as two rows
https://bugs.webkit.org/show_bug.cgi?id=108335
Reviewed by Vsevolod Vlasov.
Go-to-file is now rendered in two rows.
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype.focus):
(WebInspector.FilteredItemSelectionDialog.prototype.renderAsTwoRows):
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.OpenResourceDialog.show):
* inspector/front-end/ViewportControl.js:
(WebInspector.ViewportControl):
(WebInspector.ViewportControl.prototype.refresh):
* inspector/front-end/filteredItemSelectionDialog.css:
(.filtered-item-list-dialog input):
(.filtered-item-list-dialog div.progress):
(.filtered-item-list-dialog div.container):
(.filtered-item-list-dialog-item):
(.filtered-item-list-dialog-subtitle):
(.filtered-item-list-dialog-item.one-row .filtered-item-list-dialog-subtitle):
(.filtered-item-list-dialog-item.two-rows):
(.filtered-item-list-dialog-item.selected):
(.filtered-item-list-dialog-item span.highlight):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js
trunk/Source/WebCore/inspector/front-end/ViewportControl.js
trunk/Source/WebCore/inspector/front-end/filteredItemSelectionDialog.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (141259 => 141260)
--- trunk/Source/WebCore/ChangeLog 2013-01-30 13:59:04 UTC (rev 141259)
+++ trunk/Source/WebCore/ChangeLog 2013-01-30 14:03:32 UTC (rev 141260)
@@ -1,5 +1,34 @@
2013-01-30 Pavel Feldman pfeld...@chromium.org
+Web Inspector: beautify file selector dialog to render as two rows
+https://bugs.webkit.org/show_bug.cgi?id=108335
+
+Reviewed by Vsevolod Vlasov.
+
+Go-to-file is now rendered in two rows.
+
+* inspector/front-end/FilteredItemSelectionDialog.js:
+(WebInspector.FilteredItemSelectionDialog):
+(WebInspector.FilteredItemSelectionDialog.prototype.focus):
+(WebInspector.FilteredItemSelectionDialog.prototype.renderAsTwoRows):
+(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
+(WebInspector.OpenResourceDialog.show):
+* inspector/front-end/ViewportControl.js:
+(WebInspector.ViewportControl):
+(WebInspector.ViewportControl.prototype.refresh):
+* inspector/front-end/filteredItemSelectionDialog.css:
+(.filtered-item-list-dialog input):
+(.filtered-item-list-dialog div.progress):
+(.filtered-item-list-dialog div.container):
+(.filtered-item-list-dialog-item):
+(.filtered-item-list-dialog-subtitle):
+(.filtered-item-list-dialog-item.one-row .filtered-item-list-dialog-subtitle):
+(.filtered-item-list-dialog-item.two-rows):
+(.filtered-item-list-dialog-item.selected):
+(.filtered-item-list-dialog-item span.highlight):
+
+2013-01-30 Pavel Feldman pfeld...@chromium.org
+
Web Inspector: migrate file selection dialog to the viewport.
https://bugs.webkit.org/show_bug.cgi?id=108313
Modified: trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js (141259 => 141260)
--- trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2013-01-30 13:59:04 UTC (rev 141259)
+++ trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2013-01-30 14:03:32 UTC (rev 141260)
@@ -43,7 +43,7 @@
xhr.send(null);
this.element = document.createElement(div);
-this.element.className = js-outline-dialog;
+this.element.className = filtered-item-list-dialog;
this.element.addEventListener(keydown, this._onKeyDown.bind(this), false);
var styleElement = this.element.createChild(style);
styleElement.type = text/css;
@@ -93,7 +93,7 @@
focus: function()
{
WebInspector.setCurrentFocusElement(this._promptElement);
-if (this._filteredItems.length !this._viewportControl.lastVisibleIndex())
+if (this._filteredItems.length this._viewportControl.lastVisibleIndex() === -1)
this._viewportControl.refresh();
},
@@ -106,6 +106,11 @@
clearTimeout(this._filterTimer);
},
+renderAsTwoRows: function()
+{
+this._renderAsTwoRows = true;
+},
+
onEnter: function()
{
if (typeof this._selectedIndexInFiltered !== number)
@@ -139,12 +144,12 @@
_createItemElement: function(index)
{
var itemElement = document.createElement(div);
-itemElement.className = item;
+itemElement.className = filtered-item-list-dialog-item + (this._renderAsTwoRows ? two-rows : one-row);
itemElement._titleElement = itemElement.createChild(span);
[webkit-changes] [140965] trunk
Title: [140965] trunk
Revision 140965
Author pfeld...@chromium.org
Date 2013-01-28 04:45:24 -0800 (Mon, 28 Jan 2013)
Log Message
Web Inspector: SourceURL and SourceMappingURL together in evalled code
https://bugs.webkit.org/show_bug.cgi?id=107939
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Resolve map's sources URLs wrt script URL in case sourceMap is defined as data:.
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
* inspector/front-end/ParsedURL.js:
(WebInspector.ParsedURL.completeURL):
* inspector/front-end/SourceMap.js:
(WebInspector.SourceMap.prototype._parseMap):
LayoutTests:
* http/tests/inspector/compiler-script-mapping-expected.txt:
* http/tests/inspector/compiler-script-mapping.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-script-mapping-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js
trunk/Source/WebCore/inspector/front-end/DebuggerScriptMapping.js
trunk/Source/WebCore/inspector/front-end/ParsedURL.js
trunk/Source/WebCore/inspector/front-end/SourceMap.js
Diff
Modified: trunk/LayoutTests/ChangeLog (140964 => 140965)
--- trunk/LayoutTests/ChangeLog 2013-01-28 12:22:14 UTC (rev 140964)
+++ trunk/LayoutTests/ChangeLog 2013-01-28 12:45:24 UTC (rev 140965)
@@ -1,3 +1,13 @@
+2013-01-28 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: SourceURL and SourceMappingURL together in evalled code
+https://bugs.webkit.org/show_bug.cgi?id=107939
+
+Reviewed by Vsevolod Vlasov.
+
+* http/tests/inspector/compiler-script-mapping-expected.txt:
+* http/tests/inspector/compiler-script-mapping.html:
+
2013-01-28 Zoltan Arvai zar...@inf.u-szeged.hu
[Qt] Unreviewed rebaseline after r140821.
Modified: trunk/LayoutTests/http/tests/inspector/compiler-script-mapping-expected.txt (140964 => 140965)
--- trunk/LayoutTests/http/tests/inspector/compiler-script-mapping-expected.txt 2013-01-28 12:22:14 UTC (rev 140964)
+++ trunk/LayoutTests/http/tests/inspector/compiler-script-mapping-expected.txt 2013-01-28 12:45:24 UTC (rev 140965)
@@ -2,20 +2,75 @@
Running: testSimpleMap
+example.js === example.js
+0 === 0
+9 === 9
+example.js === example.js
+0 === 0
+13 === 13
+example.js === example.js
+0 === 0
+25 === 25
+example.js === example.js
+2 === 2
+4 === 4
+example.js === example.js
+2 === 2
+11 === 11
+example.js === example.js
+2 === 2
+24 === 24
+0 === 0
+0 === 0
+0 === 0
+17 === 17
+0 === 0
+18 === 18
+0 === 0
+29 === 29
+0 === 0
+29 === 29
Running: testNoMappingEntry
+example.js === example.js
+0 === 0
+0 === 0
+example.js === example.js
+0 === 0
+2 === 2
Running: testEmptyLine
+example.js === example.js
+0 === 0
+0 === 0
+3 === 3
+1 === 1
Running: testSections
+source1.js === source1.js
+0 === 0
+0 === 0
+source1.js === source1.js
+2 === 2
+1 === 1
+source2.js === source2.js
+0 === 0
+0 === 0
+source2.js === source2.js
+2 === 2
+1 === 1
Running: testResolveSourceMapURL
+http://example.com/map.json === http://example.com/map.json
+http://example.com/map.json === http://example.com/map.json
+http://example.com/scripts/../maps/map.json === http://example.com/scripts/../maps/map.json
Running: testCompilerScriptMapping
Running: testCompilerScriptMappingWhenResourceWasLoadedAfterSource
Running: testInlinedSourceMap
+source content === source content
Running: testSourceMapCouldNotBeLoaded
compiled.js
Modified: trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html (140964 => 140965)
--- trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html 2013-01-28 12:22:14 UTC (rev 140964)
+++ trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html 2013-01-28 12:45:24 UTC (rev 140965)
@@ -23,16 +23,16 @@
function checkMapping(compiledLineNumber, compiledColumnNumber, sourceURL, sourceLineNumber, sourceColumnNumber, mapping)
{
var entry = mapping.findEntry(compiledLineNumber, compiledColumnNumber);
-InspectorTest.assertEquals(sourceURL, entry[2]);
-InspectorTest.assertEquals(sourceLineNumber, entry[3]);
-InspectorTest.assertEquals(sourceColumnNumber, entry[4]);
+InspectorTest.addResult(sourceURL + === + entry[2]);
+InspectorTest.addResult(sourceLineNumber + === + entry[3]);
+InspectorTest.addResult(sourceColumnNumber + === + entry[4]);
}
function checkReverseMapping(compiledLineNumber, compiledColumnNumber, sourceURL, sourceLineNumber, mapping)
{
var entry = mapping.findEntryReversed(sourceURL, sourceLineNumber);
-InspectorTest.assertEquals(compiledLineNumber, entry[0]);
-InspectorTest.assertEquals(compiledColumnNumber, entry[1]);
+InspectorTest.addResult(compiledLineNumber + === + entry[0]);
+
[webkit-changes] [140805] trunk/Source/WebCore
Title: [140805] trunk/Source/WebCore
Revision 140805
Author pfeld...@chromium.org
Date 2013-01-25 02:24:16 -0800 (Fri, 25 Jan 2013)
Log Message
Web Inspector: inspector slows down pages with many anonymous scripts.
https://bugs.webkit.org/show_bug.cgi?id=107928
Reviewed by Alexander Pavlov.
The problem was that workspace code introduced n^2 complexity for unique URI calculation.
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.prototype.uniqueURI):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SimpleWorkspaceProvider.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (140804 => 140805)
--- trunk/Source/WebCore/ChangeLog 2013-01-25 10:18:08 UTC (rev 140804)
+++ trunk/Source/WebCore/ChangeLog 2013-01-25 10:24:16 UTC (rev 140805)
@@ -1,3 +1,16 @@
+2013-01-25 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: inspector slows down pages with many anonymous scripts.
+https://bugs.webkit.org/show_bug.cgi?id=107928
+
+Reviewed by Alexander Pavlov.
+
+The problem was that workspace code introduced n^2 complexity for unique URI calculation.
+
+* inspector/front-end/SimpleWorkspaceProvider.js:
+(WebInspector.SimpleWorkspaceProvider):
+(WebInspector.SimpleWorkspaceProvider.prototype.uniqueURI):
+
2013-01-25 Jussi Kukkonen jussi.kukko...@intel.com
[CMake][EFL] Build ThirdParty/leveldb when IndexedDB is enabled
Modified: trunk/Source/WebCore/inspector/front-end/SimpleWorkspaceProvider.js (140804 => 140805)
--- trunk/Source/WebCore/inspector/front-end/SimpleWorkspaceProvider.js 2013-01-25 10:18:08 UTC (rev 140804)
+++ trunk/Source/WebCore/inspector/front-end/SimpleWorkspaceProvider.js 2013-01-25 10:24:16 UTC (rev 140805)
@@ -38,6 +38,7 @@
this._workspace = workspace;
/** @type {Object.string, WebInspector.ContentProvider} */
this._contentProviders = {};
+this._lastUniqueSuffix = 0;
}
/**
@@ -129,8 +130,8 @@
uniqueURI: function(uri)
{
var uniqueURI = uri;
-for (var i = 1; this._contentProviders[uniqueURI]; ++i)
-uniqueURI = uri + ( + i + );
+while (this._contentProviders[uniqueURI])
+uniqueURI = uri + ( + (++this._lastUniqueSuffix) + );
return uniqueURI;
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [140539] trunk
Title: [140539] trunk Revision 140539 Author pfeld...@chromium.org Date 2013-01-23 09:57:26 -0800 (Wed, 23 Jan 2013) Log Message Web Inspector: only allow evaluateForTestInFrontend for front-ends under test. https://bugs.webkit.org/show_bug.cgi?id=107523 Reviewed by Yury Semikhatsky. Source/WebCore: * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::isUnderTest): (WebCore): (WebCore::InspectorController::evaluateForTestInFrontend): * inspector/InspectorController.h: (InspectorController): * inspector/InspectorFrontendClient.h: (InspectorFrontendClient): * inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::canAttachWindow): (WebCore::InspectorFrontendClientLocal::isUnderTest): (WebCore): * inspector/InspectorFrontendClientLocal.h: (InspectorFrontendClientLocal): * inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::isUnderTest): (WebCore): * inspector/InspectorFrontendHost.h: (InspectorFrontendHost): * inspector/InspectorFrontendHost.idl: * inspector/front-end/DOMExtension.js: * inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.canInspectWorkers): (.WebInspector.InspectorFrontendHostStub.prototype.isUnderTest): * inspector/front-end/TestController.js: (.invokeMethod): (WebInspector.evaluateForTestInFrontend): * inspector/front-end/externs.js: Source/WebKit/chromium: * public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::isUnderTest): (WebDevToolsFrontendClient): * src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::isUnderTest): * src/InspectorFrontendClientImpl.h: (InspectorFrontendClientImpl): Tools: * DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::isUnderTest): (DRTDevToolsClient::call): * DumpRenderTree/chromium/DRTDevToolsClient.h: (DRTDevToolsClient): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/inspector/InspectorController.cpp trunk/Source/WebCore/inspector/InspectorController.h trunk/Source/WebCore/inspector/InspectorFrontendClient.h trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp trunk/Source/WebCore/inspector/InspectorFrontendHost.h trunk/Source/WebCore/inspector/InspectorFrontendHost.idl trunk/Source/WebCore/inspector/front-end/DOMExtension.js trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js trunk/Source/WebCore/inspector/front-end/TestController.js trunk/Source/WebCore/inspector/front-end/externs.js trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebDevToolsFrontendClient.h trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTDevToolsClient.cpp trunk/Tools/DumpRenderTree/chromium/DRTDevToolsClient.h Diff Modified: trunk/Source/WebCore/ChangeLog (140538 => 140539) --- trunk/Source/WebCore/ChangeLog 2013-01-23 17:45:36 UTC (rev 140538) +++ trunk/Source/WebCore/ChangeLog 2013-01-23 17:57:26 UTC (rev 140539) @@ -1,3 +1,40 @@ +2013-01-22 Pavel Feldman pfeld...@chromium.org + +Web Inspector: only allow evaluateForTestInFrontend for front-ends under test. +https://bugs.webkit.org/show_bug.cgi?id=107523 + +Reviewed by Yury Semikhatsky. + +* inspector/InspectorController.cpp: +(WebCore::InspectorController::InspectorController): +(WebCore::InspectorController::isUnderTest): +(WebCore): +(WebCore::InspectorController::evaluateForTestInFrontend): +* inspector/InspectorController.h: +(InspectorController): +* inspector/InspectorFrontendClient.h: +(InspectorFrontendClient): +* inspector/InspectorFrontendClientLocal.cpp: +(WebCore::InspectorFrontendClientLocal::canAttachWindow): +(WebCore::InspectorFrontendClientLocal::isUnderTest): +(WebCore): +* inspector/InspectorFrontendClientLocal.h: +(InspectorFrontendClientLocal): +* inspector/InspectorFrontendHost.cpp: +(WebCore::InspectorFrontendHost::isUnderTest): +(WebCore): +* inspector/InspectorFrontendHost.h: +(InspectorFrontendHost): +* inspector/InspectorFrontendHost.idl: +* inspector/front-end/DOMExtension.js: +* inspector/front-end/InspectorFrontendHostStub.js: +(.WebInspector.InspectorFrontendHostStub.prototype.canInspectWorkers): +(.WebInspector.InspectorFrontendHostStub.prototype.isUnderTest): +* inspector/front-end/TestController.js: +(.invokeMethod): +(WebInspector.evaluateForTestInFrontend): +* inspector/front-end/externs.js: + 2013-01-23 Andrey Lushnikov
[webkit-changes] [140553] trunk/Source/WebKit/win
Title: [140553] trunk/Source/WebKit/win Revision 140553 Author pfeld...@chromium.org Date 2013-01-23 10:53:57 -0800 (Wed, 23 Jan 2013) Log Message Follow up to 140539, adding exports for Win build. Not reviewed. * WebKit.vcproj/WebKitExports.def.in: Modified Paths trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in Diff Modified: trunk/Source/WebKit/win/ChangeLog (140552 => 140553) --- trunk/Source/WebKit/win/ChangeLog 2013-01-23 18:52:26 UTC (rev 140552) +++ trunk/Source/WebKit/win/ChangeLog 2013-01-23 18:53:57 UTC (rev 140553) @@ -1,3 +1,11 @@ +2013-01-23 Pavel Feldman pfeld...@chromium.org + +Follow up to 140539, adding exports for Win build. + +Not reviewed. + +* WebKit.vcproj/WebKitExports.def.in: + 2013-01-22 Anders Carlsson ander...@apple.com Use a platforom strategy for local storage Modified: trunk/Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in (140552 => 140553) --- trunk/Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in 2013-01-23 18:52:26 UTC (rev 140552) +++ trunk/Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in 2013-01-23 18:53:57 UTC (rev 140553) @@ -206,6 +206,7 @@ ?doDispatchMessageOnFrontendPage@InspectorClient@WebCore@@SA_NPAVPage@2@ABVString@WTF@@@Z ?frontendLoaded@InspectorFrontendClientLocal@WebCore@@UAEXXZ ?getProperty@Settings@InspectorFrontendClientLocal@WebCore@@UAE?AVString@WTF@@ABV45@@Z +?isUnderTest@InspectorFrontendClientLocal@WebCore@@UAE_NXZ ?moveWindowBy@InspectorFrontendClientLocal@WebCore@@UAEXMM@Z ?openInNewTab@InspectorFrontendClientLocal@WebCore@@UAEXABVString@WTF@@@Z ?requestSetDockSide@InspectorFrontendClientLocal@WebCore@@UAEXW4DockSide@InspectorFrontendClient@2@@Z ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [140122] trunk/Source/WebCore
Title: [140122] trunk/Source/WebCore
Revision 140122
Author pfeld...@chromium.org
Date 2013-01-18 04:08:12 -0800 (Fri, 18 Jan 2013)
Log Message
Web Inspector: do not use localeCompare unless necessary
https://bugs.webkit.org/show_bug.cgi?id=107242
Reviewed by Vsevolod Vlasov.
Saving on performance here.
* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.selectorComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.sourceComparator):
* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable.prototype._sortCookies.compareTo):
(WebInspector.CookiesTable.prototype._sortCookies):
* inspector/front-end/DirectoryContentView.js:
(.nameCompare):
(.typeCompare):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.Entry.compare):
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView.EntryTreeElement.prototype._directoryContentReceived):
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
* inspector/front-end/NetworkRequest.js:
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes.comparator):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
* inspector/front-end/utilities.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CSSSelectorProfileView.js
trunk/Source/WebCore/inspector/front-end/CookiesTable.js
trunk/Source/WebCore/inspector/front-end/DirectoryContentView.js
trunk/Source/WebCore/inspector/front-end/FileSystemModel.js
trunk/Source/WebCore/inspector/front-end/FileSystemView.js
trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js
trunk/Source/WebCore/inspector/front-end/NetworkRequest.js
trunk/Source/WebCore/inspector/front-end/ScriptsSearchScope.js
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
trunk/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (140121 => 140122)
--- trunk/Source/WebCore/ChangeLog 2013-01-18 12:04:54 UTC (rev 140121)
+++ trunk/Source/WebCore/ChangeLog 2013-01-18 12:08:12 UTC (rev 140122)
@@ -1,3 +1,36 @@
+2013-01-18 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: do not use localeCompare unless necessary
+https://bugs.webkit.org/show_bug.cgi?id=107242
+
+Reviewed by Vsevolod Vlasov.
+
+Saving on performance here.
+
+* inspector/front-end/CSSSelectorProfileView.js:
+(WebInspector.CSSSelectorProfileView.prototype._sortProfile.selectorComparator):
+(WebInspector.CSSSelectorProfileView.prototype._sortProfile.sourceComparator):
+* inspector/front-end/CookiesTable.js:
+(WebInspector.CookiesTable.prototype._sortCookies.compareTo):
+(WebInspector.CookiesTable.prototype._sortCookies):
+* inspector/front-end/DirectoryContentView.js:
+(.nameCompare):
+(.typeCompare):
+* inspector/front-end/FileSystemModel.js:
+(WebInspector.FileSystemModel.Entry.compare):
+* inspector/front-end/FileSystemView.js:
+(WebInspector.FileSystemView.EntryTreeElement.prototype._directoryContentReceived):
+* inspector/front-end/FilteredItemSelectionDialog.js:
+(WebInspector.OpenResourceDialog.compareFunction):
+(WebInspector.OpenResourceDialog):
+* inspector/front-end/NetworkRequest.js:
+* inspector/front-end/ScriptsSearchScope.js:
+(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes.comparator):
+(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
+* inspector/front-end/StylesSidebarPane.js:
+(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
+* inspector/front-end/utilities.js:
+
2013-01-18 Andrey Lushnikov lushni...@chromium.org
Web Inspector: fix Closure r2388 warnings
Modified: trunk/Source/WebCore/inspector/front-end/CSSSelectorProfileView.js (140121 => 140122)
--- trunk/Source/WebCore/inspector/front-end/CSSSelectorProfileView.js 2013-01-18 12:04:54 UTC (rev 140121)
+++ trunk/Source/WebCore/inspector/front-end/CSSSelectorProfileView.js 2013-01-18 12:08:12 UTC (rev 140122)
@@ -195,7 +195,7 @@
function selectorComparator(a, b)
{
-var result = b.rawData.selector.localeCompare(a.rawData.selector);
+var result = b.rawData.selector.compareTo(a.rawData.selector);
return sortAscending ? -result : result;
}
@@ -203,7 +203,7 @@
{
var aRawData = a.rawData;
var bRawData = b.rawData;
-var result = bRawData.url.localeCompare(aRawData.url);
+var result = bRawData.url.compareTo(aRawData.url);
[webkit-changes] [139980] trunk
Title: [139980] trunk Revision 139980 Author pfeld...@chromium.org Date 2013-01-17 08:15:33 -0800 (Thu, 17 Jan 2013) Log Message Web Inspector: fix DefaultTextEditor's broken backspace https://bugs.webkit.org/show_bug.cgi?id=107130 Patch by Andrey Lushnikov lushni...@chromium.org on 2013-01-17 Reviewed by Pavel Feldman. Source/WebCore: Remove css position: relative; style from webkit-line-content class, which somehow brakes editing experience. Remove height: 100% from text-editor-overlay-highlight class and cast necessary height via inserting nbsp; into overlay span elements. No new tests: no change in behaviour. * inspector/front-end/DefaultTextEditor.js: (WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight): * inspector/front-end/textEditor.css: (.text-editor-overlay-highlight): LayoutTests: Fix test expected results to correspond to changes. * inspector/editor/text-editor-highlight-regexp-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js trunk/Source/WebCore/inspector/front-end/textEditor.css Diff Modified: trunk/LayoutTests/ChangeLog (139979 => 139980) --- trunk/LayoutTests/ChangeLog 2013-01-17 15:54:18 UTC (rev 139979) +++ trunk/LayoutTests/ChangeLog 2013-01-17 16:15:33 UTC (rev 139980) @@ -1,3 +1,14 @@ +2013-01-17 Andrey Lushnikov lushni...@chromium.org + +Web Inspector: fix DefaultTextEditor's broken backspace +https://bugs.webkit.org/show_bug.cgi?id=107130 + +Reviewed by Pavel Feldman. + +Fix test expected results to correspond to changes. + +* inspector/editor/text-editor-highlight-regexp-expected.txt: + 2013-01-17 Zan Dobersek zdober...@igalia.com Unreviewed GTK gardening. Modified: trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt (139979 => 139980) --- trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt 2013-01-17 15:54:18 UTC (rev 139979) +++ trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt 2013-01-17 16:15:33 UTC (rev 139980) @@ -17,11 +17,11 @@ div class=inner-container tabindex=0 div class=webkit-line-contentfoo();/div -div class=webkit-line-contentfoo_1; foor; foo_;span class=some-css-class text-editor-overlay-highlight style=margin-left: -127px; width: 37px;/spanspan class=some-css-class text-editor-overlay-highlight style=margin-left: -36px; width: 37px;/span/div +div class=webkit-line-contentfoo_1; foor; foo_;span class=some-css-class text-editor-overlay-highlight style=margin-left: -127px; width: 37px;nbsp;/spanspan class=some-css-class text-editor-overlay-highlight style=margin-left: -36px; width: 37px;nbsp;/span/div div class=webkit-line-contentfoo_/div div class=webkit-line-contentglobal_foo/div div class=webkit-line-contentglobal_foo2/div -div class=webkit-line-contentsome_other_foo_Xspan class=some-css-class text-editor-overlay-highlight style=margin-left: -36px; width: 37px;/span/div/div +div class=webkit-line-contentsome_other_foo_Xspan class=some-css-class text-editor-overlay-highlight style=margin-left: -36px; width: 37px;nbsp;/span/div/div Remove highlight for regexp /foo_./ Modified: trunk/Source/WebCore/ChangeLog (139979 => 139980) --- trunk/Source/WebCore/ChangeLog 2013-01-17 15:54:18 UTC (rev 139979) +++ trunk/Source/WebCore/ChangeLog 2013-01-17 16:15:33 UTC (rev 139980) @@ -1,3 +1,21 @@ +2013-01-17 Andrey Lushnikov lushni...@chromium.org + +Web Inspector: fix DefaultTextEditor's broken backspace +https://bugs.webkit.org/show_bug.cgi?id=107130 + +Reviewed by Pavel Feldman. + +Remove css position: relative; style from webkit-line-content class, which +somehow brakes editing experience. Remove height: 100% from text-editor-overlay-highlight +class and cast necessary height via inserting nbsp; into overlay span elements. + +No new tests: no change in behaviour. + +* inspector/front-end/DefaultTextEditor.js: +(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight): +* inspector/front-end/textEditor.css: +(.text-editor-overlay-highlight): + 2013-01-16 Vsevolod Vlasov vse...@chromium.org Web Inspector: Introduce FileSystemWorkspaceProvider to allow showing files from file system in workspace. Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (139979 => 139980) --- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2013-01-17 15:54:18 UTC (rev 139979) +++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2013-01-17 16:15:33 UTC (rev 139980) @@ -1981,6 +1981,7 @@ highlight.style.marginLeft = (metrics[i].left - highlight.offsetLeft - extraWidth) + px; highlight.style.width = (metrics[i].width + extraWidth * 2) + px; +
[webkit-changes] [139879] trunk
Title: [139879] trunk
Revision 139879
Author pfeld...@chromium.org
Date 2013-01-16 07:13:10 -0800 (Wed, 16 Jan 2013)
Log Message
Web Inspector: fix text-editor-highlight-regexp test
https://bugs.webkit.org/show_bug.cgi?id=107006
Patch by Andrey Lushnikov lushni...@chromium.org on 2013-01-16
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Use 'height: 100%' instead of pixel values on highlight spans to bring in some platform independency in test expectations.
No new tests: no changes in behaviour.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._measureRegex):
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
* inspector/front-end/textEditor.css:
(.text-editor-overlay-highlight):
(.webkit-line-content):
LayoutTests:
Fixing test expectations: no more height style.
* inspector/editor/text-editor-highlight-regexp-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
trunk/Source/WebCore/inspector/front-end/textEditor.css
Diff
Modified: trunk/LayoutTests/ChangeLog (139878 => 139879)
--- trunk/LayoutTests/ChangeLog 2013-01-16 15:06:46 UTC (rev 139878)
+++ trunk/LayoutTests/ChangeLog 2013-01-16 15:13:10 UTC (rev 139879)
@@ -1,3 +1,14 @@
+2013-01-16 Andrey Lushnikov lushni...@chromium.org
+
+Web Inspector: fix text-editor-highlight-regexp test
+https://bugs.webkit.org/show_bug.cgi?id=107006
+
+Reviewed by Vsevolod Vlasov.
+
+Fixing test expectations: no more height style.
+
+* inspector/editor/text-editor-highlight-regexp-expected.txt:
+
2013-01-16 Zan Dobersek zdober...@igalia.com
Unreviewed GTK gardening.
Modified: trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt (139878 => 139879)
--- trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt 2013-01-16 15:06:46 UTC (rev 139878)
+++ trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt 2013-01-16 15:13:10 UTC (rev 139879)
@@ -17,11 +17,11 @@
div class=inner-container tabindex=0
div class=webkit-line-contentfoo();/div
-div class=webkit-line-contentfoo_1; foor; foo_;span class=some-css-class text-editor-overlay-highlight style=margin-left: -127px; width: 37px; height: 14px;/spanspan class=some-css-class text-editor-overlay-highlight style=margin-left: -36px; width: 37px; height: 14px;/span/div
+div class=webkit-line-contentfoo_1; foor; foo_;span class=some-css-class text-editor-overlay-highlight style=margin-left: -127px; width: 37px;/spanspan class=some-css-class text-editor-overlay-highlight style=margin-left: -36px; width: 37px;/span/div
div class=webkit-line-contentfoo_/div
div class=webkit-line-contentglobal_foo/div
div class=webkit-line-contentglobal_foo2/div
-div class=webkit-line-contentsome_other_foo_Xspan class=some-css-class text-editor-overlay-highlight style=margin-left: -36px; width: 37px; height: 14px;/span/div/div
+div class=webkit-line-contentsome_other_foo_Xspan class=some-css-class text-editor-overlay-highlight style=margin-left: -36px; width: 37px;/span/div/div
Remove highlight for regexp /foo_./
Modified: trunk/Source/WebCore/ChangeLog (139878 => 139879)
--- trunk/Source/WebCore/ChangeLog 2013-01-16 15:06:46 UTC (rev 139878)
+++ trunk/Source/WebCore/ChangeLog 2013-01-16 15:13:10 UTC (rev 139879)
@@ -1,3 +1,21 @@
+2013-01-16 Andrey Lushnikov lushni...@chromium.org
+
+Web Inspector: fix text-editor-highlight-regexp test
+https://bugs.webkit.org/show_bug.cgi?id=107006
+
+Reviewed by Vsevolod Vlasov.
+
+Use 'height: 100%' instead of pixel values on highlight spans to bring in some platform independency in test expectations.
+
+No new tests: no changes in behaviour.
+
+* inspector/front-end/DefaultTextEditor.js:
+(WebInspector.TextEditorMainPanel.prototype._measureRegex):
+(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
+* inspector/front-end/textEditor.css:
+(.text-editor-overlay-highlight):
+(.webkit-line-content):
+
2013-01-16 Jocelyn Turcotte jocelyn.turco...@digia.com
[Qt] Use the shared HistoryItem serialization for QWebHistory
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (139878 => 139879)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2013-01-16 15:06:46 UTC (rev 139878)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2013-01-16 15:13:10 UTC (rev 139879)
@@ -1944,7 +1944,7 @@
* @param {Element} lineRow
* @param {string} line
* @param {RegExp} regex
- * @return {Array.{left: number, width: number, height: number}}
+ * @return {Array.{left: number, width: number}}
*/
_measureRegex: function(lineRow, line, regex)
{
@@
[webkit-changes] [139881] trunk/LayoutTests
Title: [139881] trunk/LayoutTests
Revision 139881
Author pfeld...@chromium.org
Date 2013-01-16 07:26:14 -0800 (Wed, 16 Jan 2013)
Log Message
Web Inspector: create helper InspectorTest method to dump editor HTML
https://bugs.webkit.org/show_bug.cgi?id=107007
Patch by Andrey Lushnikov lushni...@chromium.org on 2013-01-16
Reviewed by Pavel Feldman.
Add helper method to dump textEditor HTML.
* inspector/editor/editor-test.js:
(initialize_EditorTests.InspectorTest.dumpEditorHTML): Added.
* inspector/editor/text-editor-highlight-regexp.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/editor/editor-test.js
trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp.html
Diff
Modified: trunk/LayoutTests/ChangeLog (139880 => 139881)
--- trunk/LayoutTests/ChangeLog 2013-01-16 15:20:24 UTC (rev 139880)
+++ trunk/LayoutTests/ChangeLog 2013-01-16 15:26:14 UTC (rev 139881)
@@ -1,3 +1,16 @@
+2013-01-16 Andrey Lushnikov lushni...@chromium.org
+
+Web Inspector: create helper InspectorTest method to dump editor HTML
+https://bugs.webkit.org/show_bug.cgi?id=107007
+
+Reviewed by Pavel Feldman.
+
+Add helper method to dump textEditor HTML.
+
+* inspector/editor/editor-test.js:
+(initialize_EditorTests.InspectorTest.dumpEditorHTML): Added.
+* inspector/editor/text-editor-highlight-regexp.html:
+
2013-01-16 Andrey Kosyakov ca...@chromium.org
Web Inspector: [Extensions API] remove inspectedWindow.onReset event
Modified: trunk/LayoutTests/inspector/editor/editor-test.js (139880 => 139881)
--- trunk/LayoutTests/inspector/editor/editor-test.js 2013-01-16 15:20:24 UTC (rev 139880)
+++ trunk/LayoutTests/inspector/editor/editor-test.js 2013-01-16 15:26:14 UTC (rev 139881)
@@ -69,6 +69,13 @@
}
};
+InspectorTest.dumpEditorHTML = function(textEditor, mainPanelOnly)
+{
+var element = mainPanelOnly ? textEditor._mainPanel.element : textEditor.element;
+var dumpedHTML = element.innerHTML.replace(/div/g, \ndiv);
+InspectorTest.addResult(dumpedHTML);
+};
+
InspectorTest.getLineElement = function(textEditor, lineNumber)
{
return textEditor._mainPanel.chunkForLine(lineNumber).expandedLineRow(lineNumber);
Modified: trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp.html (139880 => 139881)
--- trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp.html 2013-01-16 15:20:24 UTC (rev 139880)
+++ trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp.html 2013-01-16 15:26:14 UTC (rev 139881)
@@ -20,13 +20,13 @@
var textEditor = InspectorTest.createTestEditor();
textEditor.setText(text.join(\n));
InspectorTest.addResult(\nBefore highlight);
-InspectorTest.addResult(textEditor._mainPanel.element.innerHTML.replace(/div/g, \ndiv));
+InspectorTest.dumpEditorHTML(textEditor, true);
textEditor.highlightRegex(/foo_./, some-css-class);
InspectorTest.addResult(\nAdd highlight for regexp /foo_./);
-InspectorTest.addResult(textEditor._mainPanel.element.innerHTML.replace(/div/g, \ndiv));
+InspectorTest.dumpEditorHTML(textEditor, true);
InspectorTest.addResult(\nRemove highlight for regexp /foo_./);
textEditor.removeRegexHighlight(/foo_./);
-InspectorTest.addResult(textEditor._mainPanel.element.innerHTML.replace(/div/g, \ndiv));
+InspectorTest.dumpEditorHTML(textEditor, true);
next();
},
]);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [139733] branches/chromium/1312/Source/WebCore/inspector/ InspectorOverlayPage.html
Title: [139733] branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html Revision 139733 Author pfeld...@chromium.org Date 2013-01-15 03:29:48 -0800 (Tue, 15 Jan 2013) Log Message Merge 135732 Not reviewed: follow up for r135720, fixing node highlight. * inspector/InspectorOverlayPage.html: TBR=pfeld...@chromium.org BUG=169722 Review URL: https://codereview.chromium.org/11881050 Modified Paths branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html Diff Modified: branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html (139732 => 139733) --- branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html 2013-01-15 10:45:04 UTC (rev 139732) +++ branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html 2013-01-15 11:29:48 UTC (rev 139733) @@ -344,9 +344,9 @@ document.getElementById(tag-name).textContent = elementInfo.tagName; document.getElementById(node-id).textContent = elementInfo.idValue ? # + elementInfo.idValue : ; var className = elementInfo.className; -if (className.length 50) +if (className className.length 50) className = className.substring(0, 50) + \u2026; -document.getElementById(class-name).textContent = className; +document.getElementById(class-name).textContent = className || ; document.getElementById(node-width).textContent = elementInfo.nodeWidth; document.getElementById(node-height).textContent = elementInfo.nodeHeight; var elementTitle = document.getElementById(element-title); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [139602] branches/chromium/1364
Title: [139602] branches/chromium/1364
Revision 139602
Author pfeld...@chromium.org
Date 2013-01-14 03:53:47 -0800 (Mon, 14 Jan 2013)
Log Message
Merge 139416
Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap
https://bugs.webkit.org/show_bug.cgi?id=106555
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Wrong ::enable was made virtual in the InspectorDebuggerAgent.
Test: inspector/debugger/debugger-scripts-reload.html
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):
* inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/debugger-scripts-reload-expected.txt: Added.
* inspector/debugger/debugger-scripts-reload.html: Added.
TBR=pfeld...@chromium.org
BUG=169437
Review URL: https://codereview.chromium.org/11876015
Modified Paths
branches/chromium/1364/LayoutTests/http/tests/inspector/debugger-test.js
branches/chromium/1364/Source/WebCore/inspector/InspectorDebuggerAgent.h
branches/chromium/1364/Source/WebCore/inspector/PageDebuggerAgent.cpp
branches/chromium/1364/Source/WebCore/inspector/PageDebuggerAgent.h
Added Paths
branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt
branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload.html
Diff
Modified: branches/chromium/1364/LayoutTests/http/tests/inspector/debugger-test.js (139601 => 139602)
--- branches/chromium/1364/LayoutTests/http/tests/inspector/debugger-test.js 2013-01-14 11:10:36 UTC (rev 139601)
+++ branches/chromium/1364/LayoutTests/http/tests/inspector/debugger-test.js 2013-01-14 11:53:47 UTC (rev 139602)
@@ -284,7 +284,7 @@
var scripts = [];
for (var scriptId in WebInspector.debuggerModel._scripts) {
var script = WebInspector.debuggerModel._scripts[scriptId];
-if (filter(script))
+if (!filter || filter(script))
scripts.push(script);
}
return scripts;
Copied: branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt (from rev 139416, trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt) (0 => 139602)
--- branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt (rev 0)
+++ branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt 2013-01-14 11:53:47 UTC (rev 139602)
@@ -0,0 +1,7 @@
+Tests that scripts list is cleared upon page reload.
+
+Debugger was enabled.
+Dummy script found: dummyScript.js
+Page reloaded.
+Debugger was disabled.
+
Copied: branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload.html (from rev 139416, trunk/LayoutTests/inspector/debugger/debugger-scripts-reload.html) (0 => 139602)
--- branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload.html (rev 0)
+++ branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload.html 2013-01-14 11:53:47 UTC (rev 139602)
@@ -0,0 +1,51 @@
+html
+head
+script src=""
+script src=""
+
+script
+
+function test()
+{
+InspectorTest.evaluateInPage(function foo() {} //@ sourceURL=dummyScript.js, step1);
+
+function step1()
+{
+InspectorTest.startDebuggerTest(step2);
+}
+
+function step2()
+{
+InspectorTest.queryScripts(function(script) { step3({ data: script }) });
+WebInspector.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.ParsedScriptSource, step3);
+}
+
+function step3(event)
+{
+var script = event.data;
+if (script.sourceURL.indexOf(dummyScript.js) !== -1) {
+InspectorTest.addResult(Dummy script found: + script.sourceURL);
+// Let scripts dispatch and reload.
+setTimeout(InspectorTest.reloadPage.bind(InspectorTest, afterReload), 0);
+}
+}
+
+function afterReload()
+{
+var scripts = InspectorTest.queryScripts();
+for (var i = 0; i scripts.length; ++i) {
+if (scripts[i].sourceURL.indexOf(dummyScript.js) !== -1)
+InspectorTest.addResult(FAILED: dummy script found after navigation);
+}
+InspectorTest.completeDebuggerTest();
+}
+
+}
+/script
+/head
+body _onload_=runTest()
+p
+Tests that scripts list is cleared upon page reload.
+/p
+/body
+/html
Modified: branches/chromium/1364/Source/WebCore/inspector/InspectorDebuggerAgent.h (139601 => 139602)
--- branches/chromium/1364/Source/WebCore/inspector/InspectorDebuggerAgent.h 2013-01-14 11:10:36 UTC (rev 139601)
+++ branches/chromium/1364/Source/WebCore/inspector/InspectorDebuggerAgent.h 2013-01-14 11:53:47 UTC (rev 139602)
@@ -71,9 +71,6 @@
virtual void
[webkit-changes] [139603] branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css
Title: [139603] branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css
Revision 139603
Author pfeld...@chromium.org
Date 2013-01-14 03:57:50 -0800 (Mon, 14 Jan 2013)
Log Message
Merge 139413
Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
https://bugs.webkit.org/show_bug.cgi?id=106560
Reviewed by Vsevolod Vlasov.
* src/js/devTools.css:
(body.dock-to-bottom.platform-mac #toolbar):
TBR=pfeld...@chromium.org
BUG=169438
Review URL: https://codereview.chromium.org/11878018
Modified Paths
branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css
Diff
Modified: branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css (139602 => 139603)
--- branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css 2013-01-14 11:53:47 UTC (rev 139602)
+++ branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css 2013-01-14 11:57:50 UTC (rev 139603)
@@ -3,10 +3,13 @@
}
body.dock-to-bottom #toolbar {
-border-top-color: white;
cursor: default; /* overriden */
}
+body.dock-to-bottom.platform-mac #toolbar {
+border-top-color: white;
+}
+
/* Chrome theme overrides */
body.platform-windows #toolbar, body.platform-windows.inactive #toolbar {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [139413] trunk/Source/WebKit/chromium
Title: [139413] trunk/Source/WebKit/chromium
Revision 139413
Author pfeld...@chromium.org
Date 2013-01-11 00:33:06 -0800 (Fri, 11 Jan 2013)
Log Message
Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
https://bugs.webkit.org/show_bug.cgi?id=106560
Reviewed by Vsevolod Vlasov.
* src/js/devTools.css:
(body.dock-to-bottom.platform-mac #toolbar):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/devTools.css
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (139412 => 139413)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-01-11 07:54:11 UTC (rev 139412)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-11 08:33:06 UTC (rev 139413)
@@ -1,3 +1,13 @@
+2013-01-11 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
+https://bugs.webkit.org/show_bug.cgi?id=106560
+
+Reviewed by Vsevolod Vlasov.
+
+* src/js/devTools.css:
+(body.dock-to-bottom.platform-mac #toolbar):
+
2013-01-10 Noel Gordon noel.gor...@gmail.com
[chromium] Disable PNG and ICO image webkit-unit-tests after r139347
Modified: trunk/Source/WebKit/chromium/src/js/devTools.css (139412 => 139413)
--- trunk/Source/WebKit/chromium/src/js/devTools.css 2013-01-11 07:54:11 UTC (rev 139412)
+++ trunk/Source/WebKit/chromium/src/js/devTools.css 2013-01-11 08:33:06 UTC (rev 139413)
@@ -3,10 +3,13 @@
}
body.dock-to-bottom #toolbar {
-border-top-color: white;
cursor: default; /* overriden */
}
+body.dock-to-bottom.platform-mac #toolbar {
+border-top-color: white;
+}
+
/* Chrome theme overrides */
body.platform-windows #toolbar, body.platform-windows.inactive #toolbar {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [139416] trunk
Title: [139416] trunk
Revision 139416
Author pfeld...@chromium.org
Date 2013-01-11 01:45:03 -0800 (Fri, 11 Jan 2013)
Log Message
Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap
https://bugs.webkit.org/show_bug.cgi?id=106555
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Wrong ::enable was made virtual in the InspectorDebuggerAgent.
Test: inspector/debugger/debugger-scripts-reload.html
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):
* inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/debugger-scripts-reload-expected.txt: Added.
* inspector/debugger/debugger-scripts-reload.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/debugger-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h
trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp
trunk/Source/WebCore/inspector/PageDebuggerAgent.h
Added Paths
trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt
trunk/LayoutTests/inspector/debugger/debugger-scripts-reload.html
Diff
Modified: trunk/LayoutTests/ChangeLog (139415 => 139416)
--- trunk/LayoutTests/ChangeLog 2013-01-11 08:42:42 UTC (rev 139415)
+++ trunk/LayoutTests/ChangeLog 2013-01-11 09:45:03 UTC (rev 139416)
@@ -1,3 +1,15 @@
+2013-01-11 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap
+https://bugs.webkit.org/show_bug.cgi?id=106555
+
+Reviewed by Vsevolod Vlasov.
+
+* http/tests/inspector/debugger-test.js:
+(initialize_DebuggerTest):
+* inspector/debugger/debugger-scripts-reload-expected.txt: Added.
+* inspector/debugger/debugger-scripts-reload.html: Added.
+
2013-01-11 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Refactoring, move NetworkWorkspaceProvider to NetworkUISourceCodeProvider.js and rename its parent to SimpleWorkspaceProvider.
Modified: trunk/LayoutTests/http/tests/inspector/debugger-test.js (139415 => 139416)
--- trunk/LayoutTests/http/tests/inspector/debugger-test.js 2013-01-11 08:42:42 UTC (rev 139415)
+++ trunk/LayoutTests/http/tests/inspector/debugger-test.js 2013-01-11 09:45:03 UTC (rev 139416)
@@ -284,7 +284,7 @@
var scripts = [];
for (var scriptId in WebInspector.debuggerModel._scripts) {
var script = WebInspector.debuggerModel._scripts[scriptId];
-if (filter(script))
+if (!filter || filter(script))
scripts.push(script);
}
return scripts;
Added: trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt (0 => 139416)
--- trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt 2013-01-11 09:45:03 UTC (rev 139416)
@@ -0,0 +1,7 @@
+Tests that scripts list is cleared upon page reload.
+
+Debugger was enabled.
+Dummy script found: dummyScript.js
+Page reloaded.
+Debugger was disabled.
+
Property changes on: trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/inspector/debugger/debugger-scripts-reload.html (0 => 139416)
--- trunk/LayoutTests/inspector/debugger/debugger-scripts-reload.html (rev 0)
+++ trunk/LayoutTests/inspector/debugger/debugger-scripts-reload.html 2013-01-11 09:45:03 UTC (rev 139416)
@@ -0,0 +1,51 @@
+html
+head
+script src=""
+script src=""
+
+script
+
+function test()
+{
+InspectorTest.evaluateInPage(function foo() {} //@ sourceURL=dummyScript.js, step1);
+
+function step1()
+{
+InspectorTest.startDebuggerTest(step2);
+}
+
+function step2()
+{
+InspectorTest.queryScripts(function(script) { step3({ data: script }) });
+WebInspector.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.ParsedScriptSource, step3);
+}
+
+function step3(event)
+{
+var script = event.data;
+if (script.sourceURL.indexOf(dummyScript.js) !== -1) {
+InspectorTest.addResult(Dummy script found: + script.sourceURL);
+// Let scripts dispatch and reload.
+setTimeout(InspectorTest.reloadPage.bind(InspectorTest, afterReload), 0);
+}
+}
+
+function afterReload()
+{
+var scripts = InspectorTest.queryScripts();
+for (var i = 0; i scripts.length; ++i) {
+if (scripts[i].sourceURL.indexOf(dummyScript.js) !== -1)
+InspectorTest.addResult(FAILED: dummy script found after navigation);
[webkit-changes] [139314] branches/chromium/1364/Source/WebCore/inspector/front-end/ inspector.css
Title: [139314] branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.css
Revision 139314
Author pfeld...@chromium.org
Date 2013-01-10 06:01:08 -0800 (Thu, 10 Jan 2013)
Log Message
Merge 138166
Web Inspector: default font on mac is Monaco (should do be Menlo)
https://bugs.webkit.org/show_bug.cgi?id=105435
Reviewed by Alexander Pavlov.
Regressed when I introduced mountain lion modifier in the inspector.css.
* inspector/front-end/inspector.css:
(body.platform-mac .monospace, body.platform-mac .source-code):
(body.platform-mac.platform-mac-tiger .source-code):
TBR=pfeld...@chromium.org
Review URL: https://codereview.chromium.org/11823053
Modified Paths
branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.css
Diff
Modified: branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.css (139313 => 139314)
--- branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.css 2013-01-10 13:46:39 UTC (rev 139313)
+++ branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.css 2013-01-10 14:01:08 UTC (rev 139314)
@@ -874,16 +874,16 @@
}
body.platform-mac .monospace, body.platform-mac .source-code {
-font-family: Monaco, monospace;
-}
-
-/* Keep .platform-mac to make the rule more specific than the general one above. */
-body.platform-mac.platform-mac-snowleopard .monospace,
-body.platform-mac.platform-mac-snowleopard .source-code {
font-size: 11px !important;
font-family: Menlo, monospace;
}
+body.platform-mac.platform-mac-tiger .monospace,
+body.platform-mac.platform-mac-tiger .source-code {
+font-size: 10px !important;
+font-family: Monaco, monospace;
+}
+
body.platform-windows .monospace, body.platform-windows .source-code {
font-size: 12px !important;
font-family: Consolas, Lucida Console, monospace;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138236] trunk/Source
Title: [138236] trunk/Source
Revision 138236
Author pfeld...@chromium.org
Date 2012-12-20 01:39:32 -0800 (Thu, 20 Dec 2012)
Log Message
Web Inspector: introduce Page.captureScreenshot
https://bugs.webkit.org/show_bug.cgi?id=105315
Reviewed by Yury Semikhatsky.
Source/WebCore:
It will be primarily used by the automation clients, but maybe we find a good place
for it in the front-end as well.
* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::captureScreenshot):
(InspectorClient):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::captureScreenshot):
(WebCore):
* inspector/InspectorPageAgent.h:
Source/WebKit/chromium:
Introduces a way for browser to handle protocol commands:
embedder will ask WebKit whether it should override the command
result and will get a hint value. Based on that hint, browser
will prepare the data and ask WebKit again to patch this data in.
* public/WebDevToolsAgent.h:
(WebDevToolsAgent):
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::captureScreenshot):
(WebKit):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(BrowserDataHintStringValues):
(WebKit):
(WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
(WebKit::WebDevToolsAgentImpl::captureScreenshot):
(WebKit::browserHintToString):
(WebKit::browserHintFromString):
(WebKit::WebDevToolsAgentImpl::sendMessageToFrontend):
(WebKit::WebDevToolsAgent::shouldPatchWithBrowserData):
(WebKit::WebDevToolsAgent::patchWithBrowserData):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorClient.h
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDevToolsAgent.h
trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp
trunk/Source/WebKit/chromium/src/InspectorClientImpl.h
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138235 => 138236)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 09:18:09 UTC (rev 138235)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 09:39:32 UTC (rev 138236)
@@ -1,3 +1,22 @@
+2012-12-19 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: introduce Page.captureScreenshot
+https://bugs.webkit.org/show_bug.cgi?id=105315
+
+Reviewed by Yury Semikhatsky.
+
+It will be primarily used by the automation clients, but maybe we find a good place
+for it in the front-end as well.
+
+* inspector/Inspector.json:
+* inspector/InspectorClient.h:
+(WebCore::InspectorClient::captureScreenshot):
+(InspectorClient):
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::captureScreenshot):
+(WebCore):
+* inspector/InspectorPageAgent.h:
+
2012-12-19 Carlos Garcia Campos cgar...@igalia.com
Make order iterator member stack allocated in RenderFlexibleBox
Modified: trunk/Source/WebCore/inspector/Inspector.json (138235 => 138236)
--- trunk/Source/WebCore/inspector/Inspector.json 2012-12-20 09:18:09 UTC (rev 138235)
+++ trunk/Source/WebCore/inspector/Inspector.json 2012-12-20 09:39:32 UTC (rev 138236)
@@ -456,6 +456,14 @@
{ name: visible, type: boolean, description: True for showing compositing borders. }
],
hidden: true
+},
+{
+name: captureScreenshot,
+description: Capture page screenshot.,
+returns: [
+{ name: data, type: string, description: Base64-encoded image data (PNG). }
+],
+hidden: true
}
],
events: [
Modified: trunk/Source/WebCore/inspector/InspectorClient.h (138235 => 138236)
--- trunk/Source/WebCore/inspector/InspectorClient.h 2012-12-20 09:18:09 UTC (rev 138235)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2012-12-20 09:39:32 UTC (rev 138236)
@@ -81,6 +81,8 @@
virtual void getAllocatedObjects(HashSetconst void*) { }
virtual void dumpUncountedAllocatedObjects(const HashMapconst void*, size_t) { }
+virtual bool captureScreenshot(String*) { return false; }
+
static bool doDispatchMessageOnFrontendPage(Page* frontendPage, const String message);
};
Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (138235 => 138236)
--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-12-20 09:18:09 UTC (rev 138235)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-12-20 09:39:32 UTC (rev 138236)
@@ -1048,7 +1048,7 @@
GeolocationController* controller = GeolocationController::from(m_page);
GeolocationPosition* position = 0;
if
[webkit-changes] [138166] trunk/Source/WebCore
Title: [138166] trunk/Source/WebCore
Revision 138166
Author pfeld...@chromium.org
Date 2012-12-19 08:23:36 -0800 (Wed, 19 Dec 2012)
Log Message
Web Inspector: default font on mac is Monaco (should do be Menlo)
https://bugs.webkit.org/show_bug.cgi?id=105435
Reviewed by Alexander Pavlov.
Regressed when I introduced mountain lion modifier in the inspector.css.
* inspector/front-end/inspector.css:
(body.platform-mac .monospace, body.platform-mac .source-code):
(body.platform-mac.platform-mac-tiger .source-code):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (138165 => 138166)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 16:09:46 UTC (rev 138165)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 16:23:36 UTC (rev 138166)
@@ -1,3 +1,16 @@
+2012-12-19 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: default font on mac is Monaco (should do be Menlo)
+https://bugs.webkit.org/show_bug.cgi?id=105435
+
+Reviewed by Alexander Pavlov.
+
+Regressed when I introduced mountain lion modifier in the inspector.css.
+
+* inspector/front-end/inspector.css:
+(body.platform-mac .monospace, body.platform-mac .source-code):
+(body.platform-mac.platform-mac-tiger .source-code):
+
2012-12-19 Hayato Ito hay...@chromium.org
Expose WebKitShadowRoot constructor to DOMWindow.
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (138165 => 138166)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-12-19 16:09:46 UTC (rev 138165)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-12-19 16:23:36 UTC (rev 138166)
@@ -874,16 +874,16 @@
}
body.platform-mac .monospace, body.platform-mac .source-code {
-font-family: Monaco, monospace;
-}
-
-/* Keep .platform-mac to make the rule more specific than the general one above. */
-body.platform-mac.platform-mac-snowleopard .monospace,
-body.platform-mac.platform-mac-snowleopard .source-code {
font-size: 11px !important;
font-family: Menlo, monospace;
}
+body.platform-mac.platform-mac-tiger .monospace,
+body.platform-mac.platform-mac-tiger .source-code {
+font-size: 10px !important;
+font-family: Monaco, monospace;
+}
+
body.platform-windows .monospace, body.platform-windows .source-code {
font-size: 12px !important;
font-family: Consolas, Lucida Console, monospace;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137912] trunk/Source
Title: [137912] trunk/Source
Revision 137912
Author pfeld...@chromium.org
Date 2012-12-17 08:35:55 -0800 (Mon, 17 Dec 2012)
Log Message
Web Inspector: [chromium] make toolbar render with Mountain Lion-friendly colors
https://bugs.webkit.org/show_bug.cgi?id=105177
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/UIUtils.js:
(WebInspector.platformFlavor):
* inspector/front-end/inspector.css:
(#toolbar):
(body.dock-to-bottom #toolbar):
(.toolbar-item):
Source/WebKit/chromium:
* src/js/devTools.css:
(body.dock-to-bottom #toolbar):
(body.undocked.platform-mac-leopard #toolbar):
(body.undocked.platform-mac-leopard.inactive #toolbar):
(body.undocked.platform-mac-snowleopard #toolbar):
(body.undocked.platform-mac-snowleopard.inactive #toolbar):
(body.undocked.platform-mac-mountain-lion #toolbar):
(body.undocked.platform-mac-mountain-lion.inactive #toolbar):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/UIUtils.js
trunk/Source/WebCore/inspector/front-end/inspector.css
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/devTools.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (137911 => 137912)
--- trunk/Source/WebCore/ChangeLog 2012-12-17 16:31:14 UTC (rev 137911)
+++ trunk/Source/WebCore/ChangeLog 2012-12-17 16:35:55 UTC (rev 137912)
@@ -1,3 +1,17 @@
+2012-12-17 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: [chromium] make toolbar render with Mountain Lion-friendly colors
+https://bugs.webkit.org/show_bug.cgi?id=105177
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/UIUtils.js:
+(WebInspector.platformFlavor):
+* inspector/front-end/inspector.css:
+(#toolbar):
+(body.dock-to-bottom #toolbar):
+(.toolbar-item):
+
2012-12-17 Andreas Kling akl...@apple.com
Attribute: Remove unused constructor and isNull().
Modified: trunk/Source/WebCore/inspector/front-end/UIUtils.js (137911 => 137912)
--- trunk/Source/WebCore/inspector/front-end/UIUtils.js 2012-12-17 16:31:14 UTC (rev 137911)
+++ trunk/Source/WebCore/inspector/front-end/UIUtils.js 2012-12-17 16:35:55 UTC (rev 137912)
@@ -747,7 +747,9 @@
WindowsVista: windows-vista,
MacTiger: mac-tiger,
MacLeopard: mac-leopard,
-MacSnowLeopard: mac-snowleopard
+MacSnowLeopard: mac-snowleopard,
+MacLion: mac-lion,
+MacMountainLion: mac-mountain-lion
}
WebInspector.platformFlavor = function()
@@ -771,8 +773,13 @@
case 5:
return WebInspector.PlatformFlavor.MacLeopard;
case 6:
+return WebInspector.PlatformFlavor.MacSnowLeopard;
+case 7:
+return WebInspector.PlatformFlavor.MacLion;
+case 8:
+return WebInspector.PlatformFlavor.MacMountainLion;
default:
-return WebInspector.PlatformFlavor.MacSnowLeopard;
+return ;
}
}
}
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (137911 => 137912)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-12-17 16:31:14 UTC (rev 137911)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-12-17 16:35:55 UTC (rev 137912)
@@ -55,6 +55,7 @@
height: 26px;
background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(191, 191, 191)), to(rgb(151, 151, 151)));
padding-top: 1px;
+padding-left: 5px;
border-bottom: 1px solid rgb(80, 80, 80);
-webkit-box-orient: horizontal;
-webkit-background-origin: padding;
@@ -83,7 +84,6 @@
padding-top: 0;
border-top: 1px solid rgb(100, 100, 100);
cursor: ns-resize;
-padding-left: 0;
}
body.dock-to-bottom.port-qt #toolbar {
@@ -96,7 +96,7 @@
.toolbar-item {
margin: 0;
-padding: 0 6px;
+padding-right: 6px;
background-color: transparent;
border-style: none;
border-color: transparent;
Modified: trunk/Source/WebKit/chromium/ChangeLog (137911 => 137912)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-17 16:31:14 UTC (rev 137911)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-17 16:35:55 UTC (rev 137912)
@@ -1,3 +1,19 @@
+2012-12-17 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: [chromium] make toolbar render with Mountain Lion-friendly colors
+https://bugs.webkit.org/show_bug.cgi?id=105177
+
+Reviewed by Vsevolod Vlasov.
+
+* src/js/devTools.css:
+(body.dock-to-bottom #toolbar):
+(body.undocked.platform-mac-leopard #toolbar):
+(body.undocked.platform-mac-leopard.inactive #toolbar):
+(body.undocked.platform-mac-snowleopard #toolbar):
+(body.undocked.platform-mac-snowleopard.inactive #toolbar):
+(body.undocked.platform-mac-mountain-lion #toolbar):
+(body.undocked.platform-mac-mountain-lion.inactive #toolbar):
+
2012-12-16
[webkit-changes] [137283] trunk/Source/WebCore
Title: [137283] trunk/Source/WebCore
Revision 137283
Author pfeld...@chromium.org
Date 2012-12-11 04:00:05 -0800 (Tue, 11 Dec 2012)
Log Message
Web Inspector: add more horizontal spacing for toolbar items in docked to bottom mode
https://bugs.webkit.org/show_bug.cgi?id=104655
Reviewed by Alexander Pavlov.
Drive-by increase height to 26px.
* inspector/front-end/inspector.css:
(#toolbar):
(body:not(.show-toolbar-icons) .toolbar-item):
(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable):
(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable.toggled-on):
(body.show-toolbar-icons.dock-to-bottom .toolbar-item.toggleable):
(#toolbar-dropdown-arrow):
(#main):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (137282 => 137283)
--- trunk/Source/WebCore/ChangeLog 2012-12-11 11:45:04 UTC (rev 137282)
+++ trunk/Source/WebCore/ChangeLog 2012-12-11 12:00:05 UTC (rev 137283)
@@ -1,3 +1,21 @@
+2012-12-11 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: add more horizontal spacing for toolbar items in docked to bottom mode
+https://bugs.webkit.org/show_bug.cgi?id=104655
+
+Reviewed by Alexander Pavlov.
+
+Drive-by increase height to 26px.
+
+* inspector/front-end/inspector.css:
+(#toolbar):
+(body:not(.show-toolbar-icons) .toolbar-item):
+(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable):
+(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable.toggled-on):
+(body.show-toolbar-icons.dock-to-bottom .toolbar-item.toggleable):
+(#toolbar-dropdown-arrow):
+(#main):
+
2012-12-11 Keishi Hattori kei...@webkit.org
Use histogram enumeration in Calendar Picker so we can get stats on UI usage
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (137282 => 137283)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-12-11 11:45:04 UTC (rev 137282)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-12-11 12:00:05 UTC (rev 137283)
@@ -52,7 +52,7 @@
top: 0;
left: 0;
right: 0;
-height: 24px;
+height: 26px;
background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(191, 191, 191)), to(rgb(151, 151, 151)));
padding-top: 1px;
border-bottom: 1px solid rgb(80, 80, 80);
@@ -103,17 +103,25 @@
}
body:not(.show-toolbar-icons) .toolbar-item {
-height: 22px;
+height: 24px;
}
+body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable {
+padding: 0 12px;
+}
+
+body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable.toggled-on {
+padding: 0 10px;
+}
+
body.show-toolbar-icons .toolbar-item.toggleable {
padding-top: 4px;
padding-bottom: 4px;
}
body.show-toolbar-icons.dock-to-bottom .toolbar-item.toggleable {
- margin: 1px 0;
- padding-bottom: 2px;
+margin: 1px 0;
+padding-bottom: 2px;
}
.toolbar-item.toggleable.toggled-on {
@@ -142,10 +150,6 @@
display: inline-block;
}
-body.show-toolbar-icons #main {
-top: 24px;
-}
-
body.dock-to-bottom .toolbar-icon.custom-toolbar-icon {
background-position-x: -32px;
}
@@ -200,7 +204,7 @@
margin: 0;
/* A line height of 0 allows precise text positioning using padding. */
line-height: 0;
-padding: 10px 6px 11px;
+padding: 11px 6px 11px;
}
#toolbar-dropdown-arrow.dropdown-visible {
@@ -540,7 +544,7 @@
#main {
position: absolute;
z-index: 1;
-top: 24px;
+top: 26px;
left: 0;
right: 0;
bottom: 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137288] trunk/Source/WebCore
Title: [137288] trunk/Source/WebCore
Revision 137288
Author pfeld...@chromium.org
Date 2012-12-11 04:15:53 -0800 (Tue, 11 Dec 2012)
Log Message
Not reviewed: follow up to r137283: reduce inspector toolbar spacing 1px.
* inspector/front-end/inspector.css:
(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable):
(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable.toggled-on):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (137287 => 137288)
--- trunk/Source/WebCore/ChangeLog 2012-12-11 12:15:35 UTC (rev 137287)
+++ trunk/Source/WebCore/ChangeLog 2012-12-11 12:15:53 UTC (rev 137288)
@@ -1,3 +1,11 @@
+2012-12-11 Pavel Feldman pfeld...@chromium.org
+
+Not reviewed: follow up to r137283: reduce inspector toolbar spacing 1px.
+
+* inspector/front-end/inspector.css:
+(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable):
+(body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable.toggled-on):
+
2012-12-11 Kent Tamura tk...@chromium.org
Refactoring: Rename Element::shouldMatchReadOnlySelector and shouldMatchReadWriteSelector
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (137287 => 137288)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-12-11 12:15:35 UTC (rev 137287)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-12-11 12:15:53 UTC (rev 137288)
@@ -107,11 +107,11 @@
}
body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable {
-padding: 0 12px;
+padding: 0 11px;
}
body.dock-to-bottom:not(.show-toolbar-icons) .toolbar-item.toggleable.toggled-on {
-padding: 0 10px;
+padding: 0 9px;
}
body.show-toolbar-icons .toolbar-item.toggleable {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137292] trunk/Source/WebCore
Title: [137292] trunk/Source/WebCore
Revision 137292
Author pfeld...@chromium.org
Date 2012-12-11 04:45:14 -0800 (Tue, 11 Dec 2012)
Log Message
Web Inspector: follow up to r136974: do not process shortcuts while editing
https://bugs.webkit.org/show_bug.cgi?id=104440
Reviewed by Alexander Pavlov.
Currently, typing H while editing node results in corresponding shortcut processing.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.handleShortcut):
(WebInspector.ElementsTreeElement.prototype.onenter):
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
(WebInspector.ElementsTreeElement.prototype.dispose):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
(WebInspector.ElementsTreeElement.prototype._editingCancelled):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (137291 => 137292)
--- trunk/Source/WebCore/ChangeLog 2012-12-11 12:27:40 UTC (rev 137291)
+++ trunk/Source/WebCore/ChangeLog 2012-12-11 12:45:14 UTC (rev 137292)
@@ -1,3 +1,21 @@
+2012-12-11 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: follow up to r136974: do not process shortcuts while editing
+https://bugs.webkit.org/show_bug.cgi?id=104440
+
+Reviewed by Alexander Pavlov.
+
+Currently, typing H while editing node results in corresponding shortcut processing.
+
+* inspector/front-end/ElementsTreeOutline.js:
+(WebInspector.ElementsTreeOutline):
+(WebInspector.ElementsTreeOutline.prototype.handleShortcut):
+(WebInspector.ElementsTreeElement.prototype.onenter):
+(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
+(WebInspector.ElementsTreeElement.prototype.dispose):
+(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
+(WebInspector.ElementsTreeElement.prototype._editingCancelled):
+
2012-12-11 Ken Kania kka...@chromium.org
[Inspector] Add command for dispatching mouse events.
Modified: trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (137291 => 137292)
--- trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-12-11 12:27:40 UTC (rev 137291)
+++ trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-12-11 12:45:14 UTC (rev 137292)
@@ -57,7 +57,6 @@
this._rootDOMNode = null;
this._selectDOMNode = null;
this._eventSupport = new WebInspector.Object();
-this._editing = false;
this._visible = false;
@@ -166,11 +165,6 @@
this._selectedNodeChanged();
},
-get editing()
-{
-return this._editing;
-},
-
update: function()
{
var selectedNode = this.selectedTreeElement ? this.selectedTreeElement.representedObject : null;
@@ -559,7 +553,7 @@
}
}
-if (event.keyCode === WebInspector.KeyboardShortcut.Keys.H.code) {
+if (!treeElement._editing event.keyCode === WebInspector.KeyboardShortcut.Keys.H.code) {
WebInspector.cssModel.toggleInlineVisibility(node.id);
return;
}
@@ -1088,7 +1082,7 @@
{
// On Enter or Return start editing the first attribute
// or create a new attribute on the selected element.
-if (this.treeOutline.editing)
+if (this._editing)
return false;
this._startEditing();
@@ -1319,7 +1313,7 @@
}
config.customFinishHandler = handleKeyDownEvents.bind(this);
-
+
this._editing = WebInspector.startEditing(attribute, config);
window.getSelection().setBaseAndExtent(elementForSelection, 0, elementForSelection, 1);
@@ -1439,7 +1433,7 @@
function dispose()
{
-this._editing = false;
+delete this._editing;
// Remove editor.
this.listItemElement.removeChild(this._htmlEditElement);
@@ -1465,7 +1459,7 @@
_attributeEditingCommitted: function(element, newText, oldText, attributeName, moveDirection)
{
-this._editing = false;
+delete this._editing;
var treeOutline = this.treeOutline;
/**
@@ -1528,7 +1522,7 @@
_tagNameEditingCommitted: function(element, newText, oldText, tagName, moveDirection)
{
-this._editing = false;
+delete this._editing;
var self = this;
function cancel()
@@ -1584,7 +1578,7 @@
*/
_textNodeEditingCommitted: function(textNode, element, newText)
{
-this._editing = false;
+delete this._editing;
function callback()
{
@@ -1599,7 +1593,7 @@
*/
_editingCancelled: function(element, context)
{
-this._editing = false;
+delete this._editing;
// Need to restore attributes structure.
[webkit-changes] [137121] trunk
Title: [137121] trunk
Revision 137121
Author pfeld...@chromium.org
Date 2012-12-10 01:38:33 -0800 (Mon, 10 Dec 2012)
Log Message
Web Inspector: console broken? - console.dirxml behaves like console.log
https://bugs.webkit.org/show_bug.cgi?id=104245
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Do not generate preview for dirxml.
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
LayoutTests:
* inspector/console/console-dirxml-expected.txt:
* inspector/console/console-dirxml.html:
* platform/chromium/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/console-dirxml-expected.txt
trunk/LayoutTests/inspector/console/console-dirxml.html
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
Diff
Modified: trunk/LayoutTests/ChangeLog (137120 => 137121)
--- trunk/LayoutTests/ChangeLog 2012-12-10 09:29:47 UTC (rev 137120)
+++ trunk/LayoutTests/ChangeLog 2012-12-10 09:38:33 UTC (rev 137121)
@@ -1,3 +1,14 @@
+2012-12-10 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: console broken? - console.dirxml behaves like console.log
+https://bugs.webkit.org/show_bug.cgi?id=104245
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/console/console-dirxml-expected.txt:
+* inspector/console/console-dirxml.html:
+* platform/chromium/TestExpectations:
+
2012-12-10 Christophe Dumez christophe.du...@intel.com
Unreviewed EFL gardening.
Modified: trunk/LayoutTests/inspector/console/console-dirxml-expected.txt (137120 => 137121)
--- trunk/LayoutTests/inspector/console/console-dirxml-expected.txt 2012-12-10 09:29:47 UTC (rev 137120)
+++ trunk/LayoutTests/inspector/console/console-dirxml-expected.txt 2012-12-10 09:38:33 UTC (rev 137121)
@@ -2,10 +2,12 @@
CONSOLE MESSAGE: line 13: [object DocumentFragment]
CONSOLE MESSAGE: line 14: [object HTMLParagraphElement]
CONSOLE MESSAGE: line 15: [object HTMLParagraphElement]
+CONSOLE MESSAGE: line 16: [object HTMLDocument],[object DocumentFragment],[object HTMLSpanElement]
Tests that console logging dumps proper messages.
#document console-dirxml.html:12
#document-fragment console-dirxml.html:13
p/p console-dirxml.html:14
-Array[1] console-dirxml.html:15
+[p] console-dirxml.html:15
+[#document, #document-fragment, span/span] console-dirxml.html:16
Modified: trunk/LayoutTests/inspector/console/console-dirxml.html (137120 => 137121)
--- trunk/LayoutTests/inspector/console/console-dirxml.html 2012-12-10 09:29:47 UTC (rev 137120)
+++ trunk/LayoutTests/inspector/console/console-dirxml.html 2012-12-10 09:38:33 UTC (rev 137121)
@@ -4,7 +4,7 @@
script src=""
script
-function onload()
+function logToConsole()
{
var fragment = document.createDocumentFragment();
fragment.appendChild(document.createElement(p));
@@ -13,19 +13,23 @@
console.dirxml(fragment);
console.dirxml(fragment.firstChild);
console.log([fragment.firstChild]);
-
-runTest();
+console.dirxml([document, fragment, document.createElement(span)]);
}
function test()
{
-InspectorTest.dumpConsoleMessages();
-InspectorTest.completeTest();
+InspectorTest.evaluateInPage(logToConsole());
+InspectorTest.runAfterPendingDispatches(callback);
+function callback()
+{
+InspectorTest.dumpConsoleMessages();
+InspectorTest.completeTest();
+}
}
/script
/head
-body _onload_=onload()
+body _onload_=runTest()
p
Tests that console logging dumps proper messages.
/p
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137120 => 137121)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-10 09:29:47 UTC (rev 137120)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-10 09:38:33 UTC (rev 137121)
@@ -3595,7 +3595,7 @@
webkit.org/b/91372 [ Win ] css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ]
# Fails on Win
-webkit.org/b/93624 inspector/console/console-format-collections.html [ Failure Pass ]
+webkit.org/b/93624 [ Win ] inspector/console/console-format-collections.html [ Failure Pass ]
# Started failing around r122770
webkit.org/b/91445 [ Linux ] plugins/embed-attributes-style.html [ ImageOnlyFailure Pass ]
Modified: trunk/Source/WebCore/ChangeLog (137120 => 137121)
--- trunk/Source/WebCore/ChangeLog 2012-12-10 09:29:47 UTC (rev 137120)
+++ trunk/Source/WebCore/ChangeLog 2012-12-10 09:38:33 UTC (rev 137121)
@@ -1,3 +1,15 @@
+2012-12-10 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: console broken? - console.dirxml behaves like console.log
+https://bugs.webkit.org/show_bug.cgi?id=104245
+
+Reviewed by Vsevolod Vlasov.
+
+Do not generate preview for dirxml.
+
+* inspector/front-end/ConsoleMessage.js:
+
[webkit-changes] [137133] trunk/Source/WebCore
Title: [137133] trunk/Source/WebCore Revision 137133 Author pfeld...@chromium.org Date 2012-12-10 03:47:16 -0800 (Mon, 10 Dec 2012) Log Message Web Inspector: adds an option to remove toolbar icons. https://bugs.webkit.org/show_bug.cgi?id=95654 Reviewed by Vsevolod Vlasov. - removes compact mode in favor or dock-to-bottom - introduces setting for hiding toolbar icons * inspector/front-end/DockController.js: (WebInspector.DockController.prototype._toggleDockState): * inspector/front-end/Settings.js: (WebInspector.ExperimentsSettings): * inspector/front-end/Toolbar.js: (WebInspector.Toolbar.prototype.setDockedToBottom): (WebInspector.Toolbar.prototype._toolbarDragStart): (WebInspector.Toolbar.prototype._toolbarDrag): * inspector/front-end/helpScreen.css: (body.dock-to-bottom .help-content): * inspector/front-end/inspector.css: (body.dock-to-bottom #toolbar): (body.no-toolbar-icons #toolbar): (body.dock-to-bottom.port-qt #toolbar): (body.dock-to-bottom.inactive #toolbar): (body.no-toolbar-icons .toolbar-item.toggleable): (body.dock-to-bottom .toolbar-item.toggleable): (body.dock-to-bottom .toolbar-icon): (body.no-toolbar-icons .toolbar-icon): (body.no-toolbar-icons #main): (body.dock-to-bottom .toolbar-icon.custom-toolbar-icon): (body.dock-to-bottom .toolbar-item:active .toolbar-icon): (body.dock-to-bottom .toolbar-label): (body.dock-to-bottom #search-toolbar-label): (body.no-toolbar-icons .toolbar-label): (body.no-toolbar-icons #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item.toggleable:hover): (body.no-toolbar-icons #toolbar-dropdown .toolbar-label): (body.no-toolbar-icons #toolbar-dropdown .toolbar-item): (body.dock-to-bottom .toolbar-item.resources .toolbar-icon): (body.dock-to-bottom .toolbar-item.network .toolbar-icon): (body.dock-to-bottom .toolbar-item.scripts .toolbar-icon): (body.dock-to-bottom .toolbar-item.timeline .toolbar-icon): (body.dock-to-bottom .toolbar-item.profiles .toolbar-icon): (body.dock-to-bottom .toolbar-item.audits .toolbar-icon): (body.dock-to-bottom .toolbar-item.console .toolbar-icon): (body.dock-to-bottom.port-qt .toolbar-item.close-left, body.dock-to-bottom.port-qt .toolbar-item.close-right): (body.dock-to-bottom #main): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Source/WebCore/inspector/front-end/DockController.js trunk/Source/WebCore/inspector/front-end/Settings.js trunk/Source/WebCore/inspector/front-end/SettingsScreen.js trunk/Source/WebCore/inspector/front-end/Toolbar.js trunk/Source/WebCore/inspector/front-end/helpScreen.css trunk/Source/WebCore/inspector/front-end/inspector.css trunk/Source/WebCore/inspector/front-end/inspector.html Diff Modified: trunk/Source/WebCore/ChangeLog (137132 => 137133) --- trunk/Source/WebCore/ChangeLog 2012-12-10 11:39:42 UTC (rev 137132) +++ trunk/Source/WebCore/ChangeLog 2012-12-10 11:47:16 UTC (rev 137133) @@ -1,3 +1,53 @@ +2012-12-08 Pavel Feldman pfeld...@chromium.org + +Web Inspector: adds an option to remove toolbar icons. +https://bugs.webkit.org/show_bug.cgi?id=95654 + +Reviewed by Vsevolod Vlasov. + +- removes compact mode in favor or dock-to-bottom +- introduces setting for hiding toolbar icons + +* inspector/front-end/DockController.js: +(WebInspector.DockController.prototype._toggleDockState): +* inspector/front-end/Settings.js: +(WebInspector.ExperimentsSettings): +* inspector/front-end/Toolbar.js: +(WebInspector.Toolbar.prototype.setDockedToBottom): +(WebInspector.Toolbar.prototype._toolbarDragStart): +(WebInspector.Toolbar.prototype._toolbarDrag): +* inspector/front-end/helpScreen.css: +(body.dock-to-bottom .help-content): +* inspector/front-end/inspector.css: +(body.dock-to-bottom #toolbar): +(body.no-toolbar-icons #toolbar): +(body.dock-to-bottom.port-qt #toolbar): +(body.dock-to-bottom.inactive #toolbar): +(body.no-toolbar-icons .toolbar-item.toggleable): +(body.dock-to-bottom .toolbar-item.toggleable): +(body.dock-to-bottom .toolbar-icon): +(body.no-toolbar-icons .toolbar-icon): +(body.no-toolbar-icons #main): +(body.dock-to-bottom .toolbar-icon.custom-toolbar-icon): +(body.dock-to-bottom .toolbar-item:active .toolbar-icon): +(body.dock-to-bottom .toolbar-label): +(body.dock-to-bottom #search-toolbar-label): +(body.no-toolbar-icons .toolbar-label): +(body.no-toolbar-icons #toolbar-dropdown): +(#toolbar-dropdown .scrollable-content): +(#toolbar-dropdown .toolbar-item.toggleable:hover): +(body.no-toolbar-icons #toolbar-dropdown .toolbar-label): +(body.no-toolbar-icons #toolbar-dropdown .toolbar-item): +(body.dock-to-bottom .toolbar-item.resources .toolbar-icon): +(body.dock-to-bottom
[webkit-changes] [137154] trunk/Source/WebCore
Title: [137154] trunk/Source/WebCore Revision 137154 Author pfeld...@chromium.org Date 2012-12-10 07:20:30 -0800 (Mon, 10 Dec 2012) Log Message Web Inspector: remove the Overrides / Settings context menu from gear icon https://bugs.webkit.org/show_bug.cgi?id=104546 Reviewed by Alexander Pavlov. It sounds like too many people don't like the way it works. Bringing things back: overrides will be a tab in settings for now. Moving present behavior to under experiment. * inspector/front-end/OverridesView.js: (WebInspector.OverridesView): * inspector/front-end/Settings.js: (WebInspector.ExperimentsSettings): * inspector/front-end/SettingsScreen.js: (WebInspector.OverridesSettingsTab): (WebInspector.SettingsController): (WebInspector.SettingsController.prototype.get statusBarItem): (WebInspector.SettingsController.prototype._mouseDown.showSettings): (WebInspector.SettingsController.prototype._mouseDown): (WebInspector.SettingsController.prototype._mouseUp): * inspector/front-end/helpScreen.css: (#settings-screen .tabbed-pane-header): (#settings-screen .tabbed-pane-header-tabs): (#settings-screen .tabbed-pane-header-tab): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/OverridesView.js trunk/Source/WebCore/inspector/front-end/Settings.js trunk/Source/WebCore/inspector/front-end/SettingsScreen.js trunk/Source/WebCore/inspector/front-end/helpScreen.css Diff Modified: trunk/Source/WebCore/ChangeLog (137153 => 137154) --- trunk/Source/WebCore/ChangeLog 2012-12-10 15:16:10 UTC (rev 137153) +++ trunk/Source/WebCore/ChangeLog 2012-12-10 15:20:30 UTC (rev 137154) @@ -1,3 +1,29 @@ +2012-12-10 Pavel Feldman pfeld...@chromium.org + +Web Inspector: remove the Overrides / Settings context menu from gear icon +https://bugs.webkit.org/show_bug.cgi?id=104546 + +Reviewed by Alexander Pavlov. + +It sounds like too many people don't like the way it works. Bringing things back: overrides will be a tab in settings for now. +Moving present behavior to under experiment. + +* inspector/front-end/OverridesView.js: +(WebInspector.OverridesView): +* inspector/front-end/Settings.js: +(WebInspector.ExperimentsSettings): +* inspector/front-end/SettingsScreen.js: +(WebInspector.OverridesSettingsTab): +(WebInspector.SettingsController): +(WebInspector.SettingsController.prototype.get statusBarItem): +(WebInspector.SettingsController.prototype._mouseDown.showSettings): +(WebInspector.SettingsController.prototype._mouseDown): +(WebInspector.SettingsController.prototype._mouseUp): +* inspector/front-end/helpScreen.css: +(#settings-screen .tabbed-pane-header): +(#settings-screen .tabbed-pane-header-tabs): +(#settings-screen .tabbed-pane-header-tab): + 2012-12-10 Kent Tamura tk...@chromium.org Visual order of empty value placeholder in INPUT_MULTIPLE_FIELDS_UI is wrong in RTL Modified: trunk/Source/WebCore/inspector/front-end/OverridesView.js (137153 => 137154) --- trunk/Source/WebCore/inspector/front-end/OverridesView.js 2012-12-10 15:16:10 UTC (rev 137153) +++ trunk/Source/WebCore/inspector/front-end/OverridesView.js 2012-12-10 15:20:30 UTC (rev 137154) @@ -52,6 +52,7 @@ headerTitle.appendChild(document.createTextNode(WebInspector.UIString(Overrides))); var container = paneContent.createChild(div, help-container-wrapper).createChild(div, settings-tab help-content help-container); +this.containerElement = container; appendBlockTo(container, this._createUserAgentControl()); if (Capabilities.canOverrideDeviceMetrics) appendBlockTo(container, this._createDeviceMetricsControl()); Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (137153 => 137154) --- trunk/Source/WebCore/inspector/front-end/Settings.js 2012-12-10 15:16:10 UTC (rev 137153) +++ trunk/Source/WebCore/inspector/front-end/Settings.js 2012-12-10 15:20:30 UTC (rev 137154) @@ -206,6 +206,7 @@ this.sass = this._createExperiment(sass, Support for Sass); this.codemirror = this._createExperiment(codemirror, Use CodeMirror editor); this.cssRegions = this._createExperiment(cssRegions, CSS Regions Support); +this.showOverridesInDrawer = this._createExperiment(showOverridesInDrawer, Show Overrides in drawer); this._cleanUpSetting(); } Modified: trunk/Source/WebCore/inspector/front-end/SettingsScreen.js (137153 => 137154) --- trunk/Source/WebCore/inspector/front-end/SettingsScreen.js 2012-12-10 15:16:10 UTC (rev 137153) +++ trunk/Source/WebCore/inspector/front-end/SettingsScreen.js 2012-12-10 15:20:30 UTC (rev 137154) @@ -49,6 +49,8 @@ this._tabbedPane.element.insertBefore(settingsLabelElement, this._tabbedPane.element.firstChild); this._tabbedPane.element.appendChild(this._createCloseButton()); this._tabbedPane.appendTab(WebInspector.SettingsScreen.Tabs.General,
[webkit-changes] [137160] trunk/Source/WebCore
Title: [137160] trunk/Source/WebCore
Revision 137160
Author pfeld...@chromium.org
Date 2012-12-10 08:18:20 -0800 (Mon, 10 Dec 2012)
Log Message
Web Inspector: fix front-end compilation warnings
https://bugs.webkit.org/show_bug.cgi?id=104557
Reviewed by Alexander Pavlov.
Corresponding annotations added.
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightNode):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration.prototype.):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.highlightDOMNode):
* inspector/front-end/DOMPresentationUtils.js:
(WebInspector.DOMPresentationUtils.linkifyNodeReference):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/Toolbar.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/InspectorDOMAgent.h
trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
trunk/Source/WebCore/inspector/front-end/DOMAgent.js
trunk/Source/WebCore/inspector/front-end/DOMPresentationUtils.js
trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
trunk/Source/WebCore/inspector/front-end/Toolbar.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (137159 => 137160)
--- trunk/Source/WebCore/ChangeLog 2012-12-10 16:10:57 UTC (rev 137159)
+++ trunk/Source/WebCore/ChangeLog 2012-12-10 16:18:20 UTC (rev 137160)
@@ -1,3 +1,30 @@
+2012-12-10 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: fix front-end compilation warnings
+https://bugs.webkit.org/show_bug.cgi?id=104557
+
+Reviewed by Alexander Pavlov.
+
+Corresponding annotations added.
+
+* inspector/Inspector.json:
+* inspector/InspectorDOMAgent.cpp:
+(WebCore::InspectorDOMAgent::highlightNode):
+* inspector/InspectorDOMAgent.h:
+(InspectorDOMAgent):
+* inspector/front-end/CSSStyleModel.js:
+(WebInspector.CSSStyleDeclaration.prototype.):
+(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
+* inspector/front-end/ConsoleMessage.js:
+(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):
+* inspector/front-end/DOMAgent.js:
+(WebInspector.DOMAgent.prototype.highlightDOMNode):
+* inspector/front-end/DOMPresentationUtils.js:
+(WebInspector.DOMPresentationUtils.linkifyNodeReference):
+* inspector/front-end/ObjectPropertiesSection.js:
+(WebInspector.ObjectPropertyTreeElement.prototype.update):
+* inspector/front-end/Toolbar.js:
+
2012-12-10 Zeno Albisser z...@webkit.org
[Qt] MediaPlayerQTKit broken after switching QPainter to raster engine.
Modified: trunk/Source/WebCore/inspector/Inspector.json (137159 => 137160)
--- trunk/Source/WebCore/inspector/Inspector.json 2012-12-10 16:10:57 UTC (rev 137159)
+++ trunk/Source/WebCore/inspector/Inspector.json 2012-12-10 16:18:20 UTC (rev 137160)
@@ -1867,9 +1867,9 @@
{
name: highlightNode,
parameters: [
+{ name: highlightConfig, $ref: HighlightConfig, description: A descriptor for the highlight appearance. },
{ name: nodeId, $ref: NodeId, optional: true, description: Identifier of the node to highlight. },
-{ name: objectId, $ref: Runtime.RemoteObjectId, optional: true, description: _javascript_ object id of the node to be highlighted. },
-{ name: highlightConfig, $ref: HighlightConfig, description: A descriptor for the highlight appearance. }
+{ name: objectId, $ref: Runtime.RemoteObjectId, optional: true, description: _javascript_ object id of the node to be highlighted. }
],
description: Highlights DOM node with given id or with the given _javascript_ object wrapper. Either nodeId or objectId must be specified.
},
Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (137159 => 137160)
--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2012-12-10 16:10:57 UTC (rev 137159)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2012-12-10 16:18:20 UTC (rev 137160)
@@ -1072,7 +1072,7 @@
m_overlay-highlightRect(adoptPtr(new IntRect(x, y, width, height)), *highlightConfig);
}
-void InspectorDOMAgent::highlightNode(ErrorString* errorString, const int* nodeId, const String* objectId, const RefPtrInspectorObject highlightInspectorObject)
+void InspectorDOMAgent::highlightNode(ErrorString*
[webkit-changes] [137091] trunk
Title: [137091] trunk
Revision 137091
Author pfeld...@chromium.org
Date 2012-12-09 11:28:23 -0800 (Sun, 09 Dec 2012)
Log Message
Web Inspector: do not treat object as equal to itself when logging to console
https://bugs.webkit.org/show_bug.cgi?id=104487
Reviewed by Alexander Pavlov.
Source/WebCore:
Otherwise, mutating object in a loop results in the repeat count update instead of generation of the new preview.
Test: inspector/console/console-object-preview.html
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::isEqual):
LayoutTests:
* inspector/console/console-object-preview-expected.txt: Added.
* inspector/console/console-object-preview.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/ConsoleMessage.cpp
Added Paths
trunk/LayoutTests/inspector/console/console-object-preview-expected.txt
trunk/LayoutTests/inspector/console/console-object-preview.html
Diff
Modified: trunk/LayoutTests/ChangeLog (137090 => 137091)
--- trunk/LayoutTests/ChangeLog 2012-12-09 19:28:23 UTC (rev 137090)
+++ trunk/LayoutTests/ChangeLog 2012-12-09 19:28:23 UTC (rev 137091)
@@ -1,3 +1,13 @@
+2012-12-09 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: do not treat object as equal to itself when logging to console
+https://bugs.webkit.org/show_bug.cgi?id=104487
+
+Reviewed by Alexander Pavlov.
+
+* inspector/console/console-object-preview-expected.txt: Added.
+* inspector/console/console-object-preview.html: Added.
+
2012-12-09 Joanmarie Diggs jdi...@igalia.com
[GTK] accessibility/canvas-fallback-content.html is failing
Added: trunk/LayoutTests/inspector/console/console-object-preview-expected.txt (0 => 137091)
--- trunk/LayoutTests/inspector/console/console-object-preview-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/console/console-object-preview-expected.txt 2012-12-09 19:28:23 UTC (rev 137091)
@@ -0,0 +1,39 @@
+CONSOLE MESSAGE: line 9: Mutating object in a loop
+CONSOLE MESSAGE: line 13: [object Object]
+CONSOLE MESSAGE: line 13: [object Object]
+CONSOLE MESSAGE: line 13: [object Object]
+CONSOLE MESSAGE: line 16: Mutating array in a loop
+CONSOLE MESSAGE: line 20: 0,0,0
+CONSOLE MESSAGE: line 20: 0,0,1
+CONSOLE MESSAGE: line 20: 0,0,2
+CONSOLE MESSAGE: line 23: Object with many properties
+CONSOLE MESSAGE: line 28: [object Object]
+CONSOLE MESSAGE: line 30: Array with many properties
+CONSOLE MESSAGE: line 35: 0,1
+CONSOLE MESSAGE: line 37: Object with proto
+CONSOLE MESSAGE: line 40: [object Object]
+CONSOLE MESSAGE: line 42: Sparse array
+CONSOLE MESSAGE: line 45: ,,50,,,
+CONSOLE MESSAGE: line 47: Dense array with indexes and propeties
+CONSOLE MESSAGE: line 53: 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144,145,146,147,148,149
+Tests that console produces instant previews for arrays and objects.
+
+Mutating object in a loop console-object-preview.html:9
+Object {a: 0, b: 0, c: 0} console-object-preview.html:13
+Object {a: 0, b: 0, c: 1} console-object-preview.html:13
+Object {a: 0, b: 0, c: 2} console-object-preview.html:13
+Mutating array in a loop console-object-preview.html:16
+[0, 0, 0] console-object-preview.html:20
+[0, 0, 1] console-object-preview.html:20
+[0, 0, 2] console-object-preview.html:20
+Object with many properties console-object-preview.html:23
+Object {property_0: 0, property_1: 1, property_2: 2, property_3: 3, property_4: 4…} console-object-preview.html:28
+Array with many properties console-object-preview.html:30
+[0, 1, property_0: 0, property_1: 1, property_2: 2, property_3: 3, property_4: 4…] console-object-preview.html:35
+Object with proto console-object-preview.html:37
+Object {d: 1, a: 0, b: 0, c: 2} console-object-preview.html:40
+Sparse array console-object-preview.html:42
+[50: 50] console-object-preview.html:45
+Dense array with indexes and propeties console-object-preview.html:47
+[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99…] console-object-preview.html:53
+
Added:
[webkit-changes] [136949] trunk
Title: [136949] trunk Revision 136949 Author pfeld...@chromium.org Date 2012-12-07 06:13:33 -0800 (Fri, 07 Dec 2012) Log Message Web Inspector: provide a way to reload page with given script preprocessor. https://bugs.webkit.org/show_bug.cgi?id=80992 Reviewed by Yury Semikhatsky. Source/WebCore: This change introduces a way to inject 'preprocessor' script that would process each _javascript_ file before it gets into the VM for compilation. That way inspector can expose capabilities such as assessing code coverage or tracing all the calls. Preprocessor script is stored in the page agent where it waits for reload to happen. Upon reload, ScriptDebugServer is using it to patch the script sources. Test: inspector/debugger/debugger-script-preprocessor.html * bindings/js/ScriptDebugServer.h: (WebCore::ScriptDebugServer::setScriptPreprocessor): (ScriptDebugServer): * bindings/v8/DebuggerScript.js: * bindings/v8/ScriptDebugServer.cpp: (ScriptDebugServer::ScriptPreprocessor): (WebCore::ScriptDebugServer::ScriptPreprocessor::ScriptPreprocessor): (WebCore::ScriptDebugServer::ScriptPreprocessor::preprocessSourceCode): (WebCore::ScriptDebugServer::ScriptPreprocessor::~ScriptPreprocessor): (WebCore): (WebCore::ScriptDebugServer::~ScriptDebugServer): (WebCore::ScriptDebugServer::setScriptSource): (WebCore::ScriptDebugServer::setScriptPreprocessor): (WebCore::ScriptDebugServer::handleV8DebugEvent): * bindings/v8/ScriptDebugServer.h: (ScriptDebugServer): * bindings/v8/custom/V8InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::createInjectedScript): * inspector/Inspector.json: * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): * inspector/InspectorDebuggerAgent.h: (InspectorDebuggerAgent): * inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::reload): (WebCore::InspectorPageAgent::frameNavigated): * inspector/InspectorPageAgent.h: (WebCore::InspectorPageAgent::page): (WebCore::InspectorPageAgent::scriptPreprocessor): (InspectorPageAgent): * inspector/PageDebuggerAgent.cpp: (WebCore::PageDebuggerAgent::create): (WebCore::PageDebuggerAgent::PageDebuggerAgent): (WebCore::PageDebuggerAgent::startListeningScriptDebugServer): (WebCore::PageDebuggerAgent::stopListeningScriptDebugServer): (WebCore::PageDebuggerAgent::injectedScriptForEval): (WebCore::PageDebuggerAgent::didClearMainFrameWindowObject): (WebCore): * inspector/PageDebuggerAgent.h: (WebCore): (PageDebuggerAgent): LayoutTests: * http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.hardReloadPage): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest._innerReloadPage): * inspector/debugger/debugger-script-preprocessor-expected.txt: Added. * inspector/debugger/debugger-script-preprocessor.html: Added. * platform/chromium/inspector/debugger/debugger-script-preprocessor-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/inspector-test.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/ScriptDebugServer.h trunk/Source/WebCore/bindings/v8/DebuggerScript.js trunk/Source/WebCore/bindings/v8/ScriptDebugServer.cpp trunk/Source/WebCore/bindings/v8/ScriptDebugServer.h trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptManager.cpp trunk/Source/WebCore/inspector/Inspector.json trunk/Source/WebCore/inspector/InspectorController.cpp trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp trunk/Source/WebCore/inspector/InspectorPageAgent.cpp trunk/Source/WebCore/inspector/InspectorPageAgent.h trunk/Source/WebCore/inspector/InstrumentingAgents.h trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp trunk/Source/WebCore/inspector/PageDebuggerAgent.h Diff Modified: trunk/LayoutTests/ChangeLog (136948 => 136949) --- trunk/LayoutTests/ChangeLog 2012-12-07 13:22:52 UTC (rev 136948) +++ trunk/LayoutTests/ChangeLog 2012-12-07 14:13:33 UTC (rev 136949) @@ -1,3 +1,18 @@ +2012-10-03 Pavel Feldman pfeld...@chromium.org + +Web Inspector: provide a way to reload page with given script preprocessor. +https://bugs.webkit.org/show_bug.cgi?id=80992 + +Reviewed by Yury Semikhatsky. + +* http/tests/inspector/inspector-test.js: +(initialize_InspectorTest.InspectorTest.hardReloadPage): +(initialize_InspectorTest.InspectorTest.reloadPage): +(initialize_InspectorTest.InspectorTest._innerReloadPage): +* inspector/debugger/debugger-script-preprocessor-expected.txt: Added. +* inspector/debugger/debugger-script-preprocessor.html: Added. +* platform/chromium/inspector/debugger/debugger-script-preprocessor-expected.txt: Added. + 2012-12-07 Alexander Pavlov apav...@chromium.org Web Inspector: the Sources column is always empty in CSS selector profiles Modified:
[webkit-changes] [136703] trunk
Title: [136703] trunk
Revision 136703
Author pfeld...@chromium.org
Date 2012-12-05 09:41:01 -0800 (Wed, 05 Dec 2012)
Log Message
Web Inspector: Don't include error message text in the editor buffer.
https://bugs.webkit.org/show_bug.cgi?id=103932
Reviewed by Alexander Pavlov.
Source/WebCore:
Skip entire decoration content when collecting dirty regions.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDOM):
LayoutTests:
* inspector/editor/editor-test.js:
(initialize_EditorTests.InspectorTest.getLineElement):
(initialize_EditorTests):
* inspector/editor/text-editor-type-over-decoration-expected.txt: Added.
* inspector/editor/text-editor-type-over-decoration.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/editor/editor-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
Added Paths
trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration-expected.txt
trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration.html
Diff
Modified: trunk/LayoutTests/ChangeLog (136702 => 136703)
--- trunk/LayoutTests/ChangeLog 2012-12-05 17:34:04 UTC (rev 136702)
+++ trunk/LayoutTests/ChangeLog 2012-12-05 17:41:01 UTC (rev 136703)
@@ -1,3 +1,16 @@
+2012-12-05 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: Don't include error message text in the editor buffer.
+https://bugs.webkit.org/show_bug.cgi?id=103932
+
+Reviewed by Alexander Pavlov.
+
+* inspector/editor/editor-test.js:
+(initialize_EditorTests.InspectorTest.getLineElement):
+(initialize_EditorTests):
+* inspector/editor/text-editor-type-over-decoration-expected.txt: Added.
+* inspector/editor/text-editor-type-over-decoration.html: Added.
+
2012-12-05 Zan Dobersek zandober...@gmail.com
Unreviewed GTK gardening.
Modified: trunk/LayoutTests/inspector/editor/editor-test.js (136702 => 136703)
--- trunk/LayoutTests/inspector/editor/editor-test.js 2012-12-05 17:34:04 UTC (rev 136702)
+++ trunk/LayoutTests/inspector/editor/editor-test.js 2012-12-05 17:41:01 UTC (rev 136703)
@@ -50,4 +50,9 @@
}
};
+InspectorTest.getLineElement = function(textEditor, lineNumber)
+{
+return textEditor._mainPanel.chunkForLine(lineNumber).expandedLineRow(lineNumber);
+};
+
}
Added: trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration-expected.txt (0 => 136703)
--- trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration-expected.txt 2012-12-05 17:41:01 UTC (rev 136703)
@@ -0,0 +1,26 @@
+This test checks that typing over the decoration does not collect decoration text as a part of damaged DOM.
+
+Chunk model
+Chunk [0] 0:10 (expanded)
+Editor DOM
+[0] div class=webkit-line-content0/div
+[1] div class=webkit-line-content1/div
+[2] div class=webkit-line-content2/div
+[3] div class=webkit-line-content3/div
+[4] div class=webkit-line-content4/div
+[5:6] div class=webkit-line-content5div class=webkit-line-decorationsspanDecoration content/span/div/div
+[6] div class=webkit-line-content6/div
+[7] div class=webkit-line-content7/div
+[8] div class=webkit-line-content8/div
+[9] div class=webkit-line-content9/div
+Editor DOM
+[0] div class=webkit-line-content0/div
+[1] div class=webkit-line-content1/div
+[2] div class=webkit-line-content2/div
+[3] div class=webkit-line-content3/div
+[4] div class=webkit-line-content4a5/div
+[5] div class=webkit-line-content6/div
+[6] div class=webkit-line-content7/div
+[7] div class=webkit-line-content8/div
+[8] div class=webkit-line-content9/div
+
Added: trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration.html (0 => 136703)
--- trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration.html (rev 0)
+++ trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration.html 2012-12-05 17:41:01 UTC (rev 136703)
@@ -0,0 +1,35 @@
+html
+head
+script src=""
+script src=""
+script
+
+function test()
+{
+var textEditor = InspectorTest.createTestEditor(10);
+var textModel = textEditor._textModel;
+
+InspectorTest.dumpEditorChunks(textEditor);
+var decorationElement = document.createElement(span);
+decorationElement.textContent = Decoration content;
+textEditor.addDecoration(5, decorationElement);
+InspectorTest.dumpEditorDOM(textEditor);
+
+// Insert Enter before the decoration
+var lineRowElement = InspectorTest.getLineElement(textEditor, 5);
+lineRowElement.parentElement.insertBefore(document.createTextNode(a), lineRowElement);
+textEditor._mainPanel._applyDomUpdates({start:4, end:5});
+InspectorTest.dumpEditorDOM(textEditor);
+
[webkit-changes] [136144] trunk/Source/WebCore
Title: [136144] trunk/Source/WebCore
Revision 136144
Author pfeld...@chromium.org
Date 2012-11-29 11:59:14 -0800 (Thu, 29 Nov 2012)
Log Message
Web Inspector: Console: hovering node wrappers in object tree should highlight them on the page
https://bugs.webkit.org/show_bug.cgi?id=101150
Reviewed by Vsevolod Vlasov.
- Introduced a way to highlight nodes by object id in addition to node id.
- Decorated nodes in the object tree outline and added on-hover highlighting.
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightNode):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.highlightDOMNode):
* inspector/front-end/DOMPresentationUtils.js:
(WebInspector.DOMPresentationUtils.createSpansForNodeTitle):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype._mouseMove):
(WebInspector.ObjectPropertyTreeElement.prototype._mouseOut):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.highlightAsDOMNode):
(WebInspector.RemoteObject.prototype.hideDOMNodeHighlight):
* inspector/front-end/TestController.js:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.css:
(.console-formatted-node:hover):
* inspector/front-end/utilities.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/InspectorDOMAgent.h
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
trunk/Source/WebCore/inspector/front-end/DOMAgent.js
trunk/Source/WebCore/inspector/front-end/DOMPresentationUtils.js
trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
trunk/Source/WebCore/inspector/front-end/RemoteObject.js
trunk/Source/WebCore/inspector/front-end/TestController.js
trunk/Source/WebCore/inspector/front-end/externs.js
trunk/Source/WebCore/inspector/front-end/inspector.css
trunk/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (136143 => 136144)
--- trunk/Source/WebCore/ChangeLog 2012-11-29 19:28:14 UTC (rev 136143)
+++ trunk/Source/WebCore/ChangeLog 2012-11-29 19:59:14 UTC (rev 136144)
@@ -1,3 +1,37 @@
+2012-11-29 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: Console: hovering node wrappers in object tree should highlight them on the page
+https://bugs.webkit.org/show_bug.cgi?id=101150
+
+Reviewed by Vsevolod Vlasov.
+
+- Introduced a way to highlight nodes by object id in addition to node id.
+- Decorated nodes in the object tree outline and added on-hover highlighting.
+
+* inspector/Inspector.json:
+* inspector/InspectorDOMAgent.cpp:
+(WebCore::InspectorDOMAgent::highlightNode):
+* inspector/InspectorDOMAgent.h:
+(InspectorDOMAgent):
+* inspector/front-end/ConsoleMessage.js:
+(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):
+* inspector/front-end/DOMAgent.js:
+(WebInspector.DOMAgent.prototype.highlightDOMNode):
+* inspector/front-end/DOMPresentationUtils.js:
+(WebInspector.DOMPresentationUtils.createSpansForNodeTitle):
+* inspector/front-end/ObjectPropertiesSection.js:
+(WebInspector.ObjectPropertyTreeElement.prototype.update):
+(WebInspector.ObjectPropertyTreeElement.prototype._mouseMove):
+(WebInspector.ObjectPropertyTreeElement.prototype._mouseOut):
+* inspector/front-end/RemoteObject.js:
+(WebInspector.RemoteObject.prototype.highlightAsDOMNode):
+(WebInspector.RemoteObject.prototype.hideDOMNodeHighlight):
+* inspector/front-end/TestController.js:
+* inspector/front-end/externs.js:
+* inspector/front-end/inspector.css:
+(.console-formatted-node:hover):
+* inspector/front-end/utilities.js:
+
2012-11-29 Dan Bernstein m...@apple.com
rdar://problem/12771885 Support ruby-position: {before, after}
Modified: trunk/Source/WebCore/inspector/Inspector.json (136143 => 136144)
--- trunk/Source/WebCore/inspector/Inspector.json 2012-11-29 19:28:14 UTC (rev 136143)
+++ trunk/Source/WebCore/inspector/Inspector.json 2012-11-29 19:59:14 UTC (rev 136144)
@@ -1858,10 +1858,11 @@
{
name: highlightNode,
parameters: [
-{ name: nodeId, $ref: NodeId, description: Identifier of the node to highlight. },
+{ name: nodeId, $ref: NodeId, optional: true, description: Identifier of the node to highlight. },
+{ name: objectId, $ref: Runtime.RemoteObjectId, optional: true, description: _javascript_ object id of the node to be
[webkit-changes] [136145] trunk/Source/WebCore
Title: [136145] trunk/Source/WebCore
Revision 136145
Author pfeld...@chromium.org
Date 2012-11-29 12:06:37 -0800 (Thu, 29 Nov 2012)
Log Message
Web Inspector: introduce fast case for within-chunk edit
https://bugs.webkit.org/show_bug.cgi?id=103545
Reviewed by Vsevolod Vlasov.
Special-casing edits within the chunk for faster operation.
* inspector/front-end/DOMExtension.js:
(removeSubsequentNodes):
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DOMExtension.js
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (136144 => 136145)
--- trunk/Source/WebCore/ChangeLog 2012-11-29 19:59:14 UTC (rev 136144)
+++ trunk/Source/WebCore/ChangeLog 2012-11-29 20:06:37 UTC (rev 136145)
@@ -1,5 +1,19 @@
2012-11-29 Pavel Feldman pfeld...@chromium.org
+Web Inspector: introduce fast case for within-chunk edit
+https://bugs.webkit.org/show_bug.cgi?id=103545
+
+Reviewed by Vsevolod Vlasov.
+
+Special-casing edits within the chunk for faster operation.
+
+* inspector/front-end/DOMExtension.js:
+(removeSubsequentNodes):
+* inspector/front-end/DefaultTextEditor.js:
+(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
+
+2012-11-29 Pavel Feldman pfeld...@chromium.org
+
Web Inspector: Console: hovering node wrappers in object tree should highlight them on the page
https://bugs.webkit.org/show_bug.cgi?id=101150
Modified: trunk/Source/WebCore/inspector/front-end/DOMExtension.js (136144 => 136145)
--- trunk/Source/WebCore/inspector/front-end/DOMExtension.js 2012-11-29 19:59:14 UTC (rev 136144)
+++ trunk/Source/WebCore/inspector/front-end/DOMExtension.js 2012-11-29 20:06:37 UTC (rev 136145)
@@ -195,6 +195,18 @@
this.parentElement.removeChild(this);
}
+/**
+ * @param {Node} fromNode
+ * @param {Node} toNode
+ */
+function removeSubsequentNodes(fromNode, toNode)
+{
+for (var node = fromNode; node node !== toNode; ) {
+var nodeToRemove = node;
+node = node.nextSibling;
+nodeToRemove.remove();
+}
+}
/**
* @constructor
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (136144 => 136145)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-29 19:59:14 UTC (rev 136144)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-29 20:06:37 UTC (rev 136145)
@@ -2415,13 +2415,28 @@
// Remove damaged chunks from DOM and from textChunks model.
var lastUndamagedChunk = firstDamagedChunkNumber 0 ? this._textChunks[firstDamagedChunkNumber - 1] : null;
var firstUndamagedChunk = lastDamagedChunkNumber + 1 this._textChunks.length ? this._textChunks[lastDamagedChunkNumber + 1] : null;
+
var removeDOMFromNode = lastUndamagedChunk ? lastUndamagedChunk.lastElement().nextSibling : this._container.firstChild;
var removeDOMToNode = firstUndamagedChunk ? firstUndamagedChunk.firstElement() : null;
-for (var node = removeDOMFromNode; node node !== removeDOMToNode; ) {
-var nodeToRemove = node;
-node = node.nextSibling;
-nodeToRemove.remove();
+
+// Fast case - patch single expanded chunk that did not grow / shrink during edit.
+if (!linesDiff firstDamagedChunk === lastDamagedChunk firstDamagedChunk._expandedLineRows) {
+var lastUndamagedLineRow = lastDamagedChunk.expandedLineRow(oldRange.startLine - 1);
+var firstUndamagedLineRow = firstDamagedChunk.expandedLineRow(oldRange.endLine + 1);
+var localRemoveDOMFromNode = lastUndamagedLineRow ? lastUndamagedLineRow.nextSibling : removeDOMFromNode;
+var localRemoveDOMToNode = firstUndamagedLineRow || removeDOMToNode;
+removeSubsequentNodes(localRemoveDOMFromNode, localRemoveDOMToNode);
+for (var i = newRange.startLine; i newRange.endLine + 1; ++i) {
+var row = firstDamagedChunk._createRow(i);
+firstDamagedChunk._expandedLineRows[i - firstDamagedChunk.startLine] = row;
+this._container.insertBefore(row, localRemoveDOMToNode);
+}
+firstDamagedChunk.updateCollapsedLineRow();
+this._assertDOMMatchesTextModel();
+return;
}
+
+removeSubsequentNodes(removeDOMFromNode, removeDOMToNode);
this._textChunks.splice(firstDamagedChunkNumber, lastDamagedChunkNumber - firstDamagedChunkNumber + 1);
// Compute damaged chunks span
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136187] trunk/Source/WebCore
Title: [136187] trunk/Source/WebCore
Revision 136187
Author pfeld...@chromium.org
Date 2012-11-29 17:06:47 -0800 (Thu, 29 Nov 2012)
Log Message
Web Inspector: optimize repaint regions upon text editing
https://bugs.webkit.org/show_bug.cgi?id=103674
Reviewed by Vsevolod Vlasov.
There is a lot happening that makes repaint area larger than it should be,
namely unnecessary tabbed pane and navigator updates.
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._updateScriptTitle):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype.set title):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NavigatorView.js
trunk/Source/WebCore/inspector/front-end/TabbedPane.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (136186 => 136187)
--- trunk/Source/WebCore/ChangeLog 2012-11-30 01:02:12 UTC (rev 136186)
+++ trunk/Source/WebCore/ChangeLog 2012-11-30 01:06:47 UTC (rev 136187)
@@ -1,3 +1,18 @@
+2012-11-29 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: optimize repaint regions upon text editing
+https://bugs.webkit.org/show_bug.cgi?id=103674
+
+Reviewed by Vsevolod Vlasov.
+
+There is a lot happening that makes repaint area larger than it should be,
+namely unnecessary tabbed pane and navigator updates.
+
+* inspector/front-end/NavigatorView.js:
+(WebInspector.NavigatorView.prototype._updateScriptTitle):
+* inspector/front-end/TabbedPane.js:
+(WebInspector.TabbedPaneTab.prototype.set title):
+
2012-11-29 KyungTae Kim ktf@samsung.com
Unused parameters on plugins/npapi.cpp
Modified: trunk/Source/WebCore/inspector/front-end/NavigatorView.js (136186 => 136187)
--- trunk/Source/WebCore/inspector/front-end/NavigatorView.js 2012-11-30 01:02:12 UTC (rev 136186)
+++ trunk/Source/WebCore/inspector/front-end/NavigatorView.js 2012-11-30 01:06:47 UTC (rev 136187)
@@ -479,6 +479,8 @@
set titleText(titleText)
{
+if (this._titleText === titleText)
+return;
this._titleText = titleText || ;
if (this.titleElement)
this.titleElement.textContent = this._titleText;
Modified: trunk/Source/WebCore/inspector/front-end/TabbedPane.js (136186 => 136187)
--- trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2012-11-30 01:02:12 UTC (rev 136186)
+++ trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2012-11-30 01:06:47 UTC (rev 136187)
@@ -598,6 +598,8 @@
set title(title)
{
+if (title === this._title)
+return;
this._title = title;
if (this._titleElement)
this._titleElement.textContent = title;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136040] branches/chromium/1312
Title: [136040] branches/chromium/1312
Revision 136040
Author pfeld...@chromium.org
Date 2012-11-28 12:12:38 -0800 (Wed, 28 Nov 2012)
Log Message
Merge 134053 - Web Inspector: wrong output for empty object {}
https://bugs.webkit.org/show_bug.cgi?id=101356
Reviewed by Vsevolod Vlasov.
Changed preview formatting to iterate over enumerable properties only + visit the prototypes.
Source/WebCore:
* inspector/InjectedScriptSource.js:
(.):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
LayoutTests:
* inspector/console/command-line-api-expected.txt:
* inspector/console/command-line-api-inspect-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
TBR=pfeld...@chromium.org
BUG=162570
Review URL: https://chromiumcodereview.appspot.com/11415185
Modified Paths
branches/chromium/1312/LayoutTests/inspector/console/command-line-api-expected.txt
branches/chromium/1312/LayoutTests/inspector/console/command-line-api-inspect-expected.txt
branches/chromium/1312/LayoutTests/inspector/console/console-format-collections-expected.txt
branches/chromium/1312/LayoutTests/inspector/console/console-format-expected.txt
branches/chromium/1312/LayoutTests/inspector/console/console-format.html
branches/chromium/1312/LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt
branches/chromium/1312/Source/WebCore/inspector/InjectedScriptSource.js
branches/chromium/1312/Source/WebCore/inspector/front-end/ConsoleMessage.js
Added Paths
branches/chromium/1312/LayoutTests/platform/chromium/inspector/console/command-line-api-inspect-expected.txt
Diff
Modified: branches/chromium/1312/LayoutTests/inspector/console/command-line-api-expected.txt (136039 => 136040)
--- branches/chromium/1312/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-28 20:05:47 UTC (rev 136039)
+++ branches/chromium/1312/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-28 20:12:38 UTC (rev 136040)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1020: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
+CONSOLE MESSAGE: line 1029: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
Tests that command line api works.
Modified: branches/chromium/1312/LayoutTests/inspector/console/command-line-api-inspect-expected.txt (136039 => 136040)
--- branches/chromium/1312/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-28 20:05:47 UTC (rev 136039)
+++ branches/chromium/1312/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-28 20:12:38 UTC (rev 136040)
@@ -14,26 +14,26 @@
WebInspector.inspect called with: Database
WebInspector.inspect's hints are: [databaseId]
-inspect(db) = Database
+inspect(db) = Database {version: 1.0, transaction: function, readTransaction: function, changeVersion: function}
Running: testRevealDatabase2
WebInspector.inspect called with: Database
WebInspector.inspect's hints are: [databaseId]
-inspect(db2) = Database
+inspect(db2) = Database {version: 1.0, transaction: function, readTransaction: function, changeVersion: function}
Running: testRevealLocalStorage
WebInspector.inspect called with: Storage
WebInspector.inspect's hints are: [domStorageId]
-inspect(localStorage) = Storage
+inspect(localStorage) = Storage {}
Running: testRevealSessionStorage
WebInspector.inspect called with: Storage
WebInspector.inspect's hints are: [domStorageId]
-inspect(sessionStorage) = Storage
+inspect(sessionStorage) = Storage {}
Modified: branches/chromium/1312/LayoutTests/inspector/console/console-format-collections-expected.txt (136039 => 136040)
--- branches/chromium/1312/LayoutTests/inspector/console/console-format-collections-expected.txt 2012-11-28 20:05:47 UTC (rev 136039)
+++ branches/chromium/1312/LayoutTests/inspector/console/console-format-collections-expected.txt 2012-11-28 20:12:38 UTC (rev 136040)
@@ -27,12 +27,12 @@
Array[2] console-format-collections.html:41
NonArrayWithLength console-format-collections.html:44
Arguments[2] console-format-collections.html:51
-[select] console-format-collections.html:15
- console-format-collections.html:19
-[option, option, selectedIndex: 0] console-format-collections.html:23
- console-format-collections.html:27
- console-format-collections.html:31
-[input, input] console-format-collections.html:35
+[select, item: function] console-format-collections.html:15
+[script, script, script, item: function, namedItem: function] console-format-collections.html:19
+[option, option, selectedIndex: 0, remove: function, add: function, item: function, namedItem: function] console-format-collections.html:23
+[html, head, script, script, script,
[webkit-changes] [136044] branches/chromium/1312
Title: [136044] branches/chromium/1312
Revision 136044
Author pfeld...@chromium.org
Date 2012-11-28 12:32:37 -0800 (Wed, 28 Nov 2012)
Log Message
Merge 135720 - Web Inspector: object preview does not render node id, className; logs too many functions for jQuery.
https://bugs.webkit.org/show_bug.cgi?id=103222
Reviewed by Yury Semikhatsky.
Source/WebCore:
- Added node class name and id into the preview
- Now keeps track of properties separately from array indexes.
* inspector/InjectedScriptSource.js:
(.):
* inspector/InspectorOverlayPage.html:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):
LayoutTests:
* inspector/console/command-line-api-expected.txt:
* inspector/console/command-line-api-inspect-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/elements/event-listener-sidebar-expected.txt:
* inspector/elements/event-listeners-about-blank-expected.txt:
* platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Removed.
* platform/chromium/inspector/console/command-line-api-inspect-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
TBR=pfeld...@chromium.org
BUG=135720
Review URL: https://chromiumcodereview.appspot.com/11434008
Modified Paths
branches/chromium/1312/LayoutTests/inspector/console/command-line-api-expected.txt
branches/chromium/1312/LayoutTests/inspector/console/command-line-api-inspect-expected.txt
branches/chromium/1312/LayoutTests/inspector/console/console-dir-expected.txt
branches/chromium/1312/LayoutTests/inspector/console/console-format-collections-expected.txt
branches/chromium/1312/LayoutTests/inspector/console/console-format-expected.txt
branches/chromium/1312/LayoutTests/inspector/elements/event-listener-sidebar-expected.txt
branches/chromium/1312/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt
branches/chromium/1312/LayoutTests/platform/chromium/inspector/console/command-line-api-inspect-expected.txt
branches/chromium/1312/LayoutTests/platform/chromium/inspector/console/console-dir-expected.txt
branches/chromium/1312/LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt
branches/chromium/1312/Source/WebCore/inspector/InjectedScriptSource.js
branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html
branches/chromium/1312/Source/WebCore/inspector/front-end/ConsoleMessage.js
Diff
Modified: branches/chromium/1312/LayoutTests/inspector/console/command-line-api-expected.txt (136043 => 136044)
--- branches/chromium/1312/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-28 20:30:07 UTC (rev 136043)
+++ branches/chromium/1312/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-28 20:32:37 UTC (rev 136044)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1029: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
+CONSOLE MESSAGE: line 1047: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
Tests that command line api works.
Modified: branches/chromium/1312/LayoutTests/inspector/console/command-line-api-inspect-expected.txt (136043 => 136044)
--- branches/chromium/1312/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-28 20:30:07 UTC (rev 136043)
+++ branches/chromium/1312/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-28 20:32:37 UTC (rev 136044)
@@ -4,7 +4,7 @@
Running: testRevealElement
-WebInspector.inspect called with: p
+WebInspector.inspect called with: p#p1
WebInspector.inspect's hints are: []
inspect($('#p1')) =
Selected node id: 'p1'.
Modified: branches/chromium/1312/LayoutTests/inspector/console/console-dir-expected.txt (136043 => 136044)
--- branches/chromium/1312/LayoutTests/inspector/console/console-dir-expected.txt 2012-11-28 20:30:07 UTC (rev 136043)
+++ branches/chromium/1312/LayoutTests/inspector/console/console-dir-expected.txt 2012-11-28 20:32:37 UTC (rev 136044)
@@ -12,7 +12,7 @@
__proto__: Array[0] console-dir.html:9
NodeList[1]
-0: html
+0: html
constructor: NodeListConstructor
length: 1
__proto__: NodeListPrototype console-dir.html:10
Modified: branches/chromium/1312/LayoutTests/inspector/console/console-format-collections-expected.txt (136043 => 136044)
--- branches/chromium/1312/LayoutTests/inspector/console/console-format-collections-expected.txt 2012-11-28 20:30:07 UTC (rev 136043)
+++ branches/chromium/1312/LayoutTests/inspector/console/console-format-collections-expected.txt 2012-11-28 20:32:37 UTC (rev 136044)
@@ -27,12 +27,12 @@
[webkit-changes] [135712] trunk
Title: [135712] trunk
Revision 135712
Author pfeld...@chromium.org
Date 2012-11-26 06:01:44 -0800 (Mon, 26 Nov 2012)
Log Message
Web Inspector: object preview does not render node id, className; logs too many functions for jQuery.
https://bugs.webkit.org/show_bug.cgi?id=103222
Reviewed by Yury Semikhatsky.
Source/WebCore:
- Added node class name and id into the preview
- Now keeps track of properties separately from array indexes.
* inspector/InjectedScriptSource.js:
(.):
* inspector/InspectorOverlayPage.html:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):
LayoutTests:
* inspector/console/command-line-api-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/elements/event-listener-sidebar-expected.txt:
* inspector/elements/event-listeners-about-blank-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/command-line-api-expected.txt
trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt
trunk/LayoutTests/inspector/console/console-dir-expected.txt
trunk/LayoutTests/inspector/console/console-format-collections-expected.txt
trunk/LayoutTests/inspector/console/console-format-expected.txt
trunk/LayoutTests/inspector/elements/event-listener-sidebar-expected.txt
trunk/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium/inspector/console/command-line-api-inspect-expected.txt
trunk/LayoutTests/platform/chromium/inspector/console/console-dir-expected.txt
trunk/LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptSource.js
trunk/Source/WebCore/inspector/InspectorOverlayPage.html
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
Removed Paths
trunk/LayoutTests/platform/chromium-linux/inspector/console/console-format-collections-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (135711 => 135712)
--- trunk/LayoutTests/ChangeLog 2012-11-26 13:55:16 UTC (rev 135711)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 14:01:44 UTC (rev 135712)
@@ -1,3 +1,17 @@
+2012-11-26 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: object preview does not render node id, className; logs too many functions for jQuery.
+https://bugs.webkit.org/show_bug.cgi?id=103222
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/console/command-line-api-expected.txt:
+* inspector/console/console-dir-expected.txt:
+* inspector/console/console-format-expected.txt:
+* inspector/elements/event-listener-sidebar-expected.txt:
+* inspector/elements/event-listeners-about-blank-expected.txt:
+* platform/chromium/inspector/console/console-dir-expected.txt:
+
2012-11-26 Eugene Klyuchnikov eus...@chromium.org
Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.
Modified: trunk/LayoutTests/inspector/console/command-line-api-expected.txt (135711 => 135712)
--- trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 13:55:16 UTC (rev 135711)
+++ trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 14:01:44 UTC (rev 135712)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1040: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
+CONSOLE MESSAGE: line 1054: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
Tests that command line api works.
Modified: trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt (135711 => 135712)
--- trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 13:55:16 UTC (rev 135711)
+++ trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 14:01:44 UTC (rev 135712)
@@ -4,7 +4,7 @@
Running: testRevealElement
-WebInspector.inspect called with: p
+WebInspector.inspect called with: p#p1
WebInspector.inspect's hints are: []
inspect($('#p1')) =
Selected node id: 'p1'.
Modified: trunk/LayoutTests/inspector/console/console-dir-expected.txt (135711 => 135712)
--- trunk/LayoutTests/inspector/console/console-dir-expected.txt 2012-11-26 13:55:16 UTC (rev 135711)
+++ trunk/LayoutTests/inspector/console/console-dir-expected.txt 2012-11-26 14:01:44 UTC (rev 135712)
@@ -12,7 +12,7 @@
__proto__: Array[0] console-dir.html:9
NodeList[1]
-0: html
+0: html
constructor: NodeListConstructor
length: 1
__proto__: NodeListPrototype console-dir.html:10
Modified:
[webkit-changes] [135714] trunk/LayoutTests
Title: [135714] trunk/LayoutTests Revision 135714 Author pfeld...@chromium.org Date 2012-11-26 06:10:41 -0800 (Mon, 26 Nov 2012) Log Message Not reviewed: rolling out accidental TestExpectations change. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135713 => 135714) --- trunk/LayoutTests/ChangeLog 2012-11-26 14:06:58 UTC (rev 135713) +++ trunk/LayoutTests/ChangeLog 2012-11-26 14:10:41 UTC (rev 135714) @@ -1,3 +1,9 @@ +2012-11-26 'Pavel Feldman' pfeld...@chromium.org + +Not reviewed: rolling out accidental TestExpectations change. + +* platform/chromium/TestExpectations: + 2012-11-26 Pavel Feldman pfeld...@chromium.org Web Inspector: object preview does not render node id, className; logs too many functions for jQuery. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135713 => 135714) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 14:06:58 UTC (rev 135713) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 14:10:41 UTC (rev 135714) @@ -3679,7 +3679,7 @@ webkit.org/b/91372 [ Win ] css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ] # Fails on Win -webkit.org/b/93624 [ Win ] inspector/console/console-format-collections.html [ Failure Pass ] +webkit.org/b/93624 [ Win Linux ] inspector/console/console-format-collections.html [ Failure Pass ] # Started failing around r122770 webkit.org/b/91445 [ Linux ] plugins/embed-attributes-style.html [ ImageOnlyFailure Pass ] @@ -4247,6 +4247,8 @@ webkit.org/b/103154 [ Win7 SnowLeopard Lion Linux Debug ] fast/frames/frame-unload-crash2.html [ Pass Timeout ] webkit.org/b/103148 [ Lion ] fast/text/large-text-composed-char.html [ ImageOnlyFailure ] webkit.org/b/103148 [ Lion ] fast/text/text-letter-spacing.html [ ImageOnlyFailure ] +webkit.org/b/103161 [ Linux Win ] inspector/console/command-line-api-inspect.html [ Pass Failure ] +webkit.org/b/103161 [ Linux Win ] inspector/runtime/runtime-localStorage-getProperties.html [ Pass Failure ] webkit.org/b/103148 [ Linux Win Mac ] svg/batik/text/textPosition2.svg [ ImageOnlyFailure ] webkit.org/b/103181 [ Win7 ] http/tests/local/drag-over-remote-content.html [ Pass Crash Timeout ] webkit.org/b/103183 [ Win7 SnowLeopard ] media/video-seek-past-end-playing.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135716] trunk
Title: [135716] trunk
Revision 135716
Author pfeld...@chromium.org
Date 2012-11-26 06:46:14 -0800 (Mon, 26 Nov 2012)
Log Message
Not reviewed: rolling out r135714 and r135712 for breaking debug tests.
Source/WebCore:
* inspector/InjectedScriptSource.js:
(.):
* inspector/InspectorOverlayPage.html:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
LayoutTests:
* inspector/console/command-line-api-expected.txt:
* inspector/console/command-line-api-inspect-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/elements/event-listener-sidebar-expected.txt:
* inspector/elements/event-listeners-about-blank-expected.txt:
* platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Copied from LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt.
* platform/chromium/inspector/console/command-line-api-inspect-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/command-line-api-expected.txt
trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt
trunk/LayoutTests/inspector/console/console-dir-expected.txt
trunk/LayoutTests/inspector/console/console-format-collections-expected.txt
trunk/LayoutTests/inspector/console/console-format-expected.txt
trunk/LayoutTests/inspector/elements/event-listener-sidebar-expected.txt
trunk/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt
trunk/LayoutTests/platform/chromium/inspector/console/command-line-api-inspect-expected.txt
trunk/LayoutTests/platform/chromium/inspector/console/console-dir-expected.txt
trunk/LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptSource.js
trunk/Source/WebCore/inspector/InspectorOverlayPage.html
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
Added Paths
trunk/LayoutTests/platform/chromium-linux/inspector/console/console-format-collections-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (135715 => 135716)
--- trunk/LayoutTests/ChangeLog 2012-11-26 14:36:05 UTC (rev 135715)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 14:46:14 UTC (rev 135716)
@@ -1,5 +1,21 @@
2012-11-26 'Pavel Feldman' pfeld...@chromium.org
+Not reviewed: rolling out r135714 and r135712 for breaking debug tests.
+
+* inspector/console/command-line-api-expected.txt:
+* inspector/console/command-line-api-inspect-expected.txt:
+* inspector/console/console-dir-expected.txt:
+* inspector/console/console-format-collections-expected.txt:
+* inspector/console/console-format-expected.txt:
+* inspector/elements/event-listener-sidebar-expected.txt:
+* inspector/elements/event-listeners-about-blank-expected.txt:
+* platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Copied from LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt.
+* platform/chromium/inspector/console/command-line-api-inspect-expected.txt:
+* platform/chromium/inspector/console/console-dir-expected.txt:
+* platform/chromium/inspector/console/console-format-collections-expected.txt:
+
+2012-11-26 'Pavel Feldman' pfeld...@chromium.org
+
Not reviewed: rolling out accidental TestExpectations change.
* platform/chromium/TestExpectations:
Modified: trunk/LayoutTests/inspector/console/command-line-api-expected.txt (135715 => 135716)
--- trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 14:36:05 UTC (rev 135715)
+++ trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 14:46:14 UTC (rev 135716)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1054: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
+CONSOLE MESSAGE: line 1040: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
Tests that command line api works.
Modified: trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt (135715 => 135716)
--- trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 14:36:05 UTC (rev 135715)
+++ trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 14:46:14 UTC (rev 135716)
@@ -4,7 +4,7 @@
Running: testRevealElement
-WebInspector.inspect called with: p#p1
+WebInspector.inspect called with: p
WebInspector.inspect's hints are: []
inspect($('#p1')) =
Selected node id: 'p1'.
Modified:
[webkit-changes] [135720] trunk
Title: [135720] trunk Revision 135720 Author pfeld...@chromium.org Date 2012-11-26 07:17:17 -0800 (Mon, 26 Nov 2012) Log Message Web Inspector: object preview does not render node id, className; logs too many functions for jQuery. https://bugs.webkit.org/show_bug.cgi?id=103222 Reviewed by Yury Semikhatsky. Source/WebCore: - Added node class name and id into the preview - Now keeps track of properties separately from array indexes. * inspector/InjectedScriptSource.js: (.): * inspector/InspectorOverlayPage.html: * inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview): (WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview): LayoutTests: * inspector/console/command-line-api-expected.txt: * inspector/console/command-line-api-inspect-expected.txt: * inspector/console/console-dir-expected.txt: * inspector/console/console-format-collections-expected.txt: * inspector/console/console-format-expected.txt: * inspector/elements/event-listener-sidebar-expected.txt: * inspector/elements/event-listeners-about-blank-expected.txt: * platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Removed. * platform/chromium/inspector/console/command-line-api-inspect-expected.txt: * platform/chromium/inspector/console/console-dir-expected.txt: * platform/chromium/inspector/console/console-format-collections-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/console/command-line-api-expected.txt trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt trunk/LayoutTests/inspector/console/console-dir-expected.txt trunk/LayoutTests/inspector/console/console-format-collections-expected.txt trunk/LayoutTests/inspector/console/console-format-expected.txt trunk/LayoutTests/inspector/elements/event-listener-sidebar-expected.txt trunk/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt trunk/LayoutTests/platform/chromium/inspector/console/command-line-api-inspect-expected.txt trunk/LayoutTests/platform/chromium/inspector/console/console-dir-expected.txt trunk/LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InjectedScriptSource.js trunk/Source/WebCore/inspector/InspectorOverlayPage.html trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js Removed Paths trunk/LayoutTests/platform/chromium-linux/inspector/console/console-format-collections-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (135719 => 135720) --- trunk/LayoutTests/ChangeLog 2012-11-26 15:03:36 UTC (rev 135719) +++ trunk/LayoutTests/ChangeLog 2012-11-26 15:17:17 UTC (rev 135720) @@ -1,3 +1,22 @@ +2012-11-26 Pavel Feldman pfeld...@chromium.org + +Web Inspector: object preview does not render node id, className; logs too many functions for jQuery. +https://bugs.webkit.org/show_bug.cgi?id=103222 + +Reviewed by Yury Semikhatsky. + +* inspector/console/command-line-api-expected.txt: +* inspector/console/command-line-api-inspect-expected.txt: +* inspector/console/console-dir-expected.txt: +* inspector/console/console-format-collections-expected.txt: +* inspector/console/console-format-expected.txt: +* inspector/elements/event-listener-sidebar-expected.txt: +* inspector/elements/event-listeners-about-blank-expected.txt: +* platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Removed. +* platform/chromium/inspector/console/command-line-api-inspect-expected.txt: +* platform/chromium/inspector/console/console-dir-expected.txt: +* platform/chromium/inspector/console/console-format-collections-expected.txt: + 2012-11-26 Florin Malita fmal...@chromium.org RenderSVGResourceContainer does not clear cached data on removal Modified: trunk/LayoutTests/inspector/console/command-line-api-expected.txt (135719 => 135720) --- trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 15:03:36 UTC (rev 135719) +++ trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 15:17:17 UTC (rev 135720) @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 1040: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s) +CONSOLE MESSAGE: line 1058: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s) Tests that command line api works. Modified: trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt (135719 => 135720) --- trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 15:03:36 UTC (rev 135719) +++ trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 15:17:17 UTC (rev 135720) @@ -4,7 +4,7 @@ Running: testRevealElement
[webkit-changes] [135732] trunk/Source/WebCore
Title: [135732] trunk/Source/WebCore Revision 135732 Author pfeld...@chromium.org Date 2012-11-26 08:50:10 -0800 (Mon, 26 Nov 2012) Log Message Not reviewed: follow up for r135720, fixing node highlight. * inspector/InspectorOverlayPage.html: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorOverlayPage.html Diff Modified: trunk/Source/WebCore/ChangeLog (135731 => 135732) --- trunk/Source/WebCore/ChangeLog 2012-11-26 16:40:24 UTC (rev 135731) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 16:50:10 UTC (rev 135732) @@ -1,3 +1,9 @@ +2012-11-26 'Pavel Feldman' pfeld...@chromium.org + +Not reviewed: follow up for r135720, fixing node highlight. + +* inspector/InspectorOverlayPage.html: + 2012-11-26 Viatcheslav Ostapenko v.ostape...@samsung.com [EFL] Crashes in compositing layout tests with AC on. Modified: trunk/Source/WebCore/inspector/InspectorOverlayPage.html (135731 => 135732) --- trunk/Source/WebCore/inspector/InspectorOverlayPage.html 2012-11-26 16:40:24 UTC (rev 135731) +++ trunk/Source/WebCore/inspector/InspectorOverlayPage.html 2012-11-26 16:50:10 UTC (rev 135732) @@ -344,9 +344,9 @@ document.getElementById(tag-name).textContent = elementInfo.tagName; document.getElementById(node-id).textContent = elementInfo.idValue ? # + elementInfo.idValue : ; var className = elementInfo.className; -if (className.length 50) +if (className className.length 50) className = className.substring(0, 50) + \u2026; -document.getElementById(class-name).textContent = className; +document.getElementById(class-name).textContent = className || ; document.getElementById(node-width).textContent = elementInfo.nodeWidth; document.getElementById(node-height).textContent = elementInfo.nodeHeight; var elementTitle = document.getElementById(element-title); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135574] trunk
Title: [135574] trunk
Revision 135574
Author pfeld...@chromium.org
Date 2012-11-23 02:14:24 -0800 (Fri, 23 Nov 2012)
Log Message
Web Inspector: ctrl+end in editor does not select the last symbol.
https://bugs.webkit.org/show_bug.cgi?id=103078
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: inspector/editor/text-editor-selection.html
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._handleScrollChanged):
(WebInspector.DefaultTextEditor.prototype.overrideViewportForTest):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorChunkedPanel.prototype._scrollTop):
(WebInspector.TextEditorChunkedPanel.prototype._clientHeight):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
LayoutTests:
* inspector/editor/editor-test.js: Added.
(initialize_EditorTests.InspectorTest.createTestEditor):
(initialize_EditorTests.InspectorTest.dumpEditorChunks):
(initialize_EditorTests):
* inspector/editor/text-editor-selection-expected.txt: Added.
* inspector/editor/text-editor-selection.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
trunk/Source/WebCore/inspector/front-end/TextEditorModel.js
Added Paths
trunk/LayoutTests/inspector/editor/editor-test.js
trunk/LayoutTests/inspector/editor/text-editor-selection-expected.txt
trunk/LayoutTests/inspector/editor/text-editor-selection.html
Diff
Modified: trunk/LayoutTests/ChangeLog (135573 => 135574)
--- trunk/LayoutTests/ChangeLog 2012-11-23 09:57:25 UTC (rev 135573)
+++ trunk/LayoutTests/ChangeLog 2012-11-23 10:14:24 UTC (rev 135574)
@@ -1,3 +1,17 @@
+2012-11-22 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: ctrl+end in editor does not select the last symbol.
+https://bugs.webkit.org/show_bug.cgi?id=103078
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/editor/editor-test.js: Added.
+(initialize_EditorTests.InspectorTest.createTestEditor):
+(initialize_EditorTests.InspectorTest.dumpEditorChunks):
+(initialize_EditorTests):
+* inspector/editor/text-editor-selection-expected.txt: Added.
+* inspector/editor/text-editor-selection.html: Added.
+
2012-11-23 Yury Semikhatsky yu...@chromium.org
Unreviewed. Updated test expectations.
Added: trunk/LayoutTests/inspector/editor/editor-test.js (0 => 135574)
--- trunk/LayoutTests/inspector/editor/editor-test.js (rev 0)
+++ trunk/LayoutTests/inspector/editor/editor-test.js 2012-11-23 10:14:24 UTC (rev 135574)
@@ -0,0 +1,24 @@
+function initialize_EditorTests()
+{
+
+InspectorTest.createTestEditor = function(lineCount, clientHeight, chunkSize)
+{
+var textEditor = new WebInspector.DefaultTextEditor(, new WebInspector.TextEditorDelegate());
+textEditor.overrideViewportForTest(0, clientHeight || 100, chunkSize || 10);
+textEditor.show(WebInspector.inspectorView.element);
+var textModel = textEditor._textModel;
+var lines = [];
+for (var i = 0; i lineCount; ++i)
+lines.push(Line + i);
+textModel.setText(lines.join(\n));
+return textEditor;
+};
+
+InspectorTest.dumpEditorChunks = function(textEditor)
+{
+var chunks = textEditor._mainPanel._textChunks;
+for (var i = 0; i chunks.length; ++i)
+InspectorTest.addResult(Chunk [ + i + ] + chunks[i].startLine + : + chunks[i].endLine + ( + (chunks[i]._expanded ? expanded : collapsed) + ));
+};
+
+}
Property changes on: trunk/LayoutTests/inspector/editor/editor-test.js
___
Added: svn:eol-style
Added: trunk/LayoutTests/inspector/editor/text-editor-selection-expected.txt (0 => 135574)
--- trunk/LayoutTests/inspector/editor/text-editor-selection-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/editor/text-editor-selection-expected.txt 2012-11-23 10:14:24 UTC (rev 135574)
@@ -0,0 +1,22 @@
+This test checks the text editor selection calculation.
+
+Chunk [0] 0:9 (expanded)
+Chunk [1] 9:18 (collapsed)
+Chunk [2] 18:27 (collapsed)
+Chunk [3] 27:34 (collapsed)
+
+Running: testSelectionAtStartOfCollapsedChunk
+{startLine:27,startColumn:0,endLine:27,endColumn:0}
+
+Running: testSelectionAtEndOfCollapsedChunk
+{startLine:33,startColumn:7,endLine:33,endColumn:7}
+
+Running: testSelectionAtMiddleOfCollapsedChunk
+{startLine:29,startColumn:4,endLine:30,endColumn:6}
+
+Running: testSelectionAtStartAndEndOfExpandedRows
+{startLine:3,startColumn:0,endLine:4,endColumn:6}
+
+Running: testSelectionAtMiddleOfExpandedRows
+{startLine:3,startColumn:3,endLine:4,endColumn:4}
+
Property changes on: trunk/LayoutTests/inspector/editor/text-editor-selection-expected.txt
[webkit-changes] [135606] trunk
Title: [135606] trunk
Revision 135606
Author pfeld...@chromium.org
Date 2012-11-23 07:01:35 -0800 (Fri, 23 Nov 2012)
Log Message
Web Inspector: damaging last chunk does not remove its garbage from DOM
https://bugs.webkit.org/show_bug.cgi?id=103132
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Removing everything between undamaged chunks, not registered chunk rows.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
(WebInspector.TextEditorMainChunk.prototype.firstElement):
(WebInspector.TextEditorMainChunk.prototype.lastElement):
LayoutTests:
* inspector/editor/editor-test.js:
(initialize_EditorTests.InspectorTest.createTestEditor):
(initialize_EditorTests.InspectorTest.dumpEditorChunks):
(initialize_EditorTests.InspectorTest.dumpEditorModel):
(initialize_EditorTests.InspectorTest.dumpEditorDOM):
(initialize_EditorTests):
* inspector/editor/text-editor-remove-chunks-from-dom-expected.txt: Added.
* inspector/editor/text-editor-remove-chunks-from-dom.html: Added.
* inspector/editor/text-editor-selection-expected.txt:
* inspector/editor/text-editor-selection.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/editor/editor-test.js
trunk/LayoutTests/inspector/editor/text-editor-selection-expected.txt
trunk/LayoutTests/inspector/editor/text-editor-selection.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
Added Paths
trunk/LayoutTests/inspector/editor/text-editor-remove-chunks-from-dom-expected.txt
trunk/LayoutTests/inspector/editor/text-editor-remove-chunks-from-dom.html
Diff
Modified: trunk/LayoutTests/ChangeLog (135605 => 135606)
--- trunk/LayoutTests/ChangeLog 2012-11-23 14:55:46 UTC (rev 135605)
+++ trunk/LayoutTests/ChangeLog 2012-11-23 15:01:35 UTC (rev 135606)
@@ -1,3 +1,21 @@
+2012-11-23 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: damaging last chunk does not remove its garbage from DOM
+https://bugs.webkit.org/show_bug.cgi?id=103132
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/editor/editor-test.js:
+(initialize_EditorTests.InspectorTest.createTestEditor):
+(initialize_EditorTests.InspectorTest.dumpEditorChunks):
+(initialize_EditorTests.InspectorTest.dumpEditorModel):
+(initialize_EditorTests.InspectorTest.dumpEditorDOM):
+(initialize_EditorTests):
+* inspector/editor/text-editor-remove-chunks-from-dom-expected.txt: Added.
+* inspector/editor/text-editor-remove-chunks-from-dom.html: Added.
+* inspector/editor/text-editor-selection-expected.txt:
+* inspector/editor/text-editor-selection.html:
+
2012-11-23 Kent Tamura tk...@chromium.org
Correct input[type=number] value sanitization for user-input
Modified: trunk/LayoutTests/inspector/editor/editor-test.js (135605 => 135606)
--- trunk/LayoutTests/inspector/editor/editor-test.js 2012-11-23 14:55:46 UTC (rev 135605)
+++ trunk/LayoutTests/inspector/editor/editor-test.js 2012-11-23 15:01:35 UTC (rev 135606)
@@ -3,22 +3,51 @@
InspectorTest.createTestEditor = function(lineCount, clientHeight, chunkSize)
{
+WebInspector.debugDefaultTextEditor = true;
var textEditor = new WebInspector.DefaultTextEditor(, new WebInspector.TextEditorDelegate());
textEditor.overrideViewportForTest(0, clientHeight || 100, chunkSize || 10);
textEditor.show(WebInspector.inspectorView.element);
var textModel = textEditor._textModel;
var lines = [];
for (var i = 0; i lineCount; ++i)
-lines.push(Line + i);
+lines.push(i);
textModel.setText(lines.join(\n));
return textEditor;
};
InspectorTest.dumpEditorChunks = function(textEditor)
{
+InspectorTest.addResult(Chunk model);
var chunks = textEditor._mainPanel._textChunks;
for (var i = 0; i chunks.length; ++i)
InspectorTest.addResult(Chunk [ + i + ] + chunks[i].startLine + : + chunks[i].endLine + ( + (chunks[i]._expanded ? expanded : collapsed) + ));
};
+InspectorTest.dumpEditorModel = function(textEditor)
+{
+InspectorTest.addResult(Text model);
+var textModel = textEditor._textModel;
+for (var i = 0; i textModel.linesCount; ++i) {
+var prefix = [ + i + ];
+while (prefix.length 10)
+prefix += ;
+InspectorTest.addResult(prefix + textModel.line(i));
+}
+};
+
+InspectorTest.dumpEditorDOM = function(textEditor)
+{
+InspectorTest.addResult(Editor DOM);
+var element = textEditor._mainPanel._container;
+for (var node = element.firstChild; node; node = node.nextSibling) {
+if (node._chunk)
+var prefix = [ + node._chunk.startLine + : + node._chunk.endLine + ];
+else
+var prefix = [ + node.lineNumber + ];
+while
[webkit-changes] [135541] trunk/Source/WebCore
Title: [135541] trunk/Source/WebCore
Revision 135541
Author pfeld...@chromium.org
Date 2012-11-22 14:30:02 -0800 (Thu, 22 Nov 2012)
Log Message
Web Inspector: evaluate on hover regressed with the editor change
https://bugs.webkit.org/show_bug.cgi?id=103063
Reviewed by Vsevolod Vlasov.
We are no longer mutating the editor's dom from outside.
* inspector/front-end/DOMExtension.js:
(Element.prototype.remove):
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.highlightRangesWithStyleClass):
(WebInspector.DefaultTextEditor.prototype.highlightExpression):
(WebInspector.DefaultTextEditor.prototype.hideHighlightedExpression):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype._getPopoverAnchor):
(WebInspector._javascript_SourceFrame.prototype._onHidePopover):
(WebInspector._javascript_SourceFrame.prototype._highlightExpression):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DOMExtension.js
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (135540 => 135541)
--- trunk/Source/WebCore/ChangeLog 2012-11-22 22:14:52 UTC (rev 135540)
+++ trunk/Source/WebCore/ChangeLog 2012-11-22 22:30:02 UTC (rev 135541)
@@ -1,3 +1,23 @@
+2012-11-22 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: evaluate on hover regressed with the editor change
+https://bugs.webkit.org/show_bug.cgi?id=103063
+
+Reviewed by Vsevolod Vlasov.
+
+We are no longer mutating the editor's dom from outside.
+
+* inspector/front-end/DOMExtension.js:
+(Element.prototype.remove):
+* inspector/front-end/DefaultTextEditor.js:
+(WebInspector.DefaultTextEditor.prototype.highlightRangesWithStyleClass):
+(WebInspector.DefaultTextEditor.prototype.highlightExpression):
+(WebInspector.DefaultTextEditor.prototype.hideHighlightedExpression):
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame.prototype._getPopoverAnchor):
+(WebInspector._javascript_SourceFrame.prototype._onHidePopover):
+(WebInspector._javascript_SourceFrame.prototype._highlightExpression):
+
2012-09-26 Gustavo Noronha Silva g...@gnome.org
[GTK] Split SVG from WebCore to work-around make limitation
Modified: trunk/Source/WebCore/inspector/front-end/DOMExtension.js (135540 => 135541)
--- trunk/Source/WebCore/inspector/front-end/DOMExtension.js 2012-11-22 22:14:52 UTC (rev 135540)
+++ trunk/Source/WebCore/inspector/front-end/DOMExtension.js 2012-11-22 22:30:02 UTC (rev 135541)
@@ -200,6 +200,13 @@
return this.scrollTop + this.clientHeight === this.scrollHeight;
}
+Element.prototype.remove = function()
+{
+if (this.parentElement)
+this.parentElement.removeChild(this);
+}
+
+
/**
* @constructor
* @param {number} width
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (135540 => 135541)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-22 22:14:52 UTC (rev 135540)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-22 22:30:02 UTC (rev 135541)
@@ -591,6 +591,67 @@
this._freeCachedElements();
},
+/**
+ * @param {Element} element
+ * @param {Array.Object} resultRanges
+ * @param {string} styleClass
+ * @param {Array.Object=} changes
+ */
+highlightRangesWithStyleClass: function(element, resultRanges, styleClass, changes)
+{
+this._mainPanel.beginDomUpdates();
+WebInspector.highlightRangesWithStyleClass(element, resultRanges, styleClass, changes);
+this._mainPanel.endDomUpdates();
+},
+
+/**
+ * @param {Element} element
+ * @param {Object} skipClasses
+ * @param {Object} skipTokens
+ * @return {Element}
+ */
+highlightExpression: function(element, skipClasses, skipTokens)
+{
+// Collect tokens belonging to evaluated _expression_.
+var tokens = [ element ];
+var token = element.previousSibling;
+while (token (skipClasses[token.className] || skipTokens[token.textContent.trim()])) {
+tokens.push(token);
+token = token.previousSibling;
+}
+tokens.reverse();
+
+// Wrap them with highlight element.
+this._mainPanel.beginDomUpdates();
+var parentElement = element.parentElement;
+var nextElement = element.nextSibling;
+var container = document.createElement(span);
+for (var i = 0; i tokens.length; ++i)
+container.appendChild(tokens[i]);
+parentElement.insertBefore(container, nextElement);
+this._mainPanel.endDomUpdates();
+return container;
+},
+
+/**
+ * @param {Element} highlightElement
+ */
+
[webkit-changes] [135386] trunk
Title: [135386] trunk
Revision 135386
Author pfeld...@chromium.org
Date 2012-11-21 04:37:04 -0800 (Wed, 21 Nov 2012)
Log Message
Web Inspector: reparenting view does not detach from the previous parent.
https://bugs.webkit.org/show_bug.cgi?id=102902
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/View.js:
(WebInspector.View.prototype.show):
LayoutTests:
* inspector/view-events.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/view-events-expected.txt
trunk/LayoutTests/inspector/view-events.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/View.js
Diff
Modified: trunk/LayoutTests/ChangeLog (135385 => 135386)
--- trunk/LayoutTests/ChangeLog 2012-11-21 12:30:47 UTC (rev 135385)
+++ trunk/LayoutTests/ChangeLog 2012-11-21 12:37:04 UTC (rev 135386)
@@ -1,3 +1,12 @@
+2012-11-21 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: reparenting view does not detach from the previous parent.
+https://bugs.webkit.org/show_bug.cgi?id=102902
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/view-events.html:
+
2012-11-21 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed gardening, unskip now passing tests.
Modified: trunk/LayoutTests/inspector/view-events-expected.txt (135385 => 135386)
--- trunk/LayoutTests/inspector/view-events-expected.txt 2012-11-21 12:30:47 UTC (rev 135385)
+++ trunk/LayoutTests/inspector/view-events-expected.txt 2012-11-21 12:37:04 UTC (rev 135386)
@@ -191,3 +191,22 @@
Parent.willHide()
Child.detach()
+Running: testShowDetachesFromPrevious
+Parent1()
+Parent2()
+Child()
+Parent1.show()
+ Parent1.wasShown()
+ Parent1.onResize()
+Parent2.show()
+ Parent2.wasShown()
+ Parent2.onResize()
+Child.show()
+ Child.wasShown()
+ Child.onResize()
+Child.show()
+Child.detach()
+ Child.willHide()
+ Child.wasShown()
+ Child.onResize()
+
Modified: trunk/LayoutTests/inspector/view-events.html (135385 => 135386)
--- trunk/LayoutTests/inspector/view-events.html 2012-11-21 12:30:47 UTC (rev 135385)
+++ trunk/LayoutTests/inspector/view-events.html 2012-11-21 12:37:04 UTC (rev 135386)
@@ -287,6 +287,18 @@
parentView.detachOnWillHide = childView;
parentView.detach();
next();
+},
+
+function testShowDetachesFromPrevious(next)
+{
+var parentView1 = new TestView(Parent1);
+var parentView2 = new TestView(Parent2);
+var childView = new TestView(Child);
+parentView1.show(WebInspector.inspectorView.element);
+parentView2.show(WebInspector.inspectorView.element);
+childView.show(parentView1.element);
+childView.show(parentView2.element);
+next();
}
]);
}
Modified: trunk/Source/WebCore/ChangeLog (135385 => 135386)
--- trunk/Source/WebCore/ChangeLog 2012-11-21 12:30:47 UTC (rev 135385)
+++ trunk/Source/WebCore/ChangeLog 2012-11-21 12:37:04 UTC (rev 135386)
@@ -1,3 +1,13 @@
+2012-11-21 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: reparenting view does not detach from the previous parent.
+https://bugs.webkit.org/show_bug.cgi?id=102902
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/View.js:
+(WebInspector.View.prototype.show):
+
2012-11-21 Ilya Tikhonovsky loi...@chromium.org
Web Inspector: NMI add instrumentation to widely used ActiveDOMObjects. XMLHttpRequest, Prerenderer, HTMLMediaElement and DOMTimer.
Modified: trunk/Source/WebCore/inspector/front-end/View.js (135385 => 135386)
--- trunk/Source/WebCore/inspector/front-end/View.js 2012-11-21 12:30:47 UTC (rev 135385)
+++ trunk/Source/WebCore/inspector/front-end/View.js 2012-11-21 12:37:04 UTC (rev 135386)
@@ -166,6 +166,9 @@
// Update view hierarchy
if (this.element.parentElement !== parentElement) {
+if (this.element.parentElement)
+this.detach();
+
var currentParent = parentElement;
while (currentParent !currentParent.__view)
currentParent = currentParent.parentElement;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135483] trunk/Source/WebCore
Title: [135483] trunk/Source/WebCore
Revision 135483
Author pfeld...@chromium.org
Date 2012-11-21 23:41:12 -0800 (Wed, 21 Nov 2012)
Log Message
Web Inspector: simplify the _updateChunksForRanges routine
https://bugs.webkit.org/show_bug.cgi?id=102927
Reviewed by Vsevolod Vlasov.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
(WebInspector.TextEditorMainChunk.prototype.detachFromDOM):
(WebInspector.TextEditorMainChunk.prototype.anchorElement):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
trunk/Source/WebCore/inspector/front-end/TextEditorModel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (135482 => 135483)
--- trunk/Source/WebCore/ChangeLog 2012-11-22 07:35:09 UTC (rev 135482)
+++ trunk/Source/WebCore/ChangeLog 2012-11-22 07:41:12 UTC (rev 135483)
@@ -1,3 +1,16 @@
+2012-11-21 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: simplify the _updateChunksForRanges routine
+https://bugs.webkit.org/show_bug.cgi?id=102927
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/DefaultTextEditor.js:
+(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
+(WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
+(WebInspector.TextEditorMainChunk.prototype.detachFromDOM):
+(WebInspector.TextEditorMainChunk.prototype.anchorElement):
+
2012-11-21 Kentaro Hara hara...@chromium.org
[V8] WebCoreStringResourceBase should be located in V8StringResource.h
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (135482 => 135483)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-22 07:35:09 UTC (rev 135482)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-22 07:41:12 UTC (rev 135483)
@@ -2155,9 +2155,6 @@
editInfo = new WebInspector.DefaultTextEditor.EditInfo(range, lines.join(\n));
}
-if (this._textModel.copyRange(editInfo.range) === editInfo.text)
-return; // Noop
-
var selection = this._getSelection(collectLinesFromNode);
// Unindent after block
@@ -2311,98 +2308,47 @@
*/
_updateChunksForRanges: function(oldRange, newRange)
{
-// Update the chunks in range: firstChunkNumber = index = lastChunkNumber
-var firstChunkNumber = this._chunkNumberForLine(oldRange.startLine);
-var lastChunkNumber = firstChunkNumber;
-while (lastChunkNumber + 1 this._textChunks.length) {
-if (this._textChunks[lastChunkNumber + 1].startLine oldRange.endLine)
+var firstDamagedChunkNumber = this._chunkNumberForLine(oldRange.startLine);
+var lastDamagedChunkNumber = firstDamagedChunkNumber;
+while (lastDamagedChunkNumber + 1 this._textChunks.length) {
+if (this._textChunks[lastDamagedChunkNumber + 1].startLine oldRange.endLine)
break;
-++lastChunkNumber;
+++lastDamagedChunkNumber;
}
-var startLine = this._textChunks[firstChunkNumber].startLine;
-var linesCount = this._textChunks[lastChunkNumber].startLine + this._textChunks[lastChunkNumber].linesCount - startLine;
+var firstDamagedChunk = this._textChunks[firstDamagedChunkNumber];
+var lastDamagedChunk = this._textChunks[lastDamagedChunkNumber];
+
var linesDiff = newRange.linesCount - oldRange.linesCount;
-linesCount += linesDiff;
+// First, detect chunks that have not been modified and simply shift them.
if (linesDiff) {
-// Lines shifted, update the line numbers of the chunks below.
-for (var chunkNumber = lastChunkNumber + 1; chunkNumber this._textChunks.length; ++chunkNumber)
+for (var chunkNumber = lastDamagedChunkNumber + 1; chunkNumber this._textChunks.length; ++chunkNumber)
this._textChunks[chunkNumber].startLine += linesDiff;
}
-var firstLineRow;
-if (firstChunkNumber) {
-var chunk = this._textChunks[firstChunkNumber - 1];
-firstLineRow = chunk.expanded ? chunk.expandedLineRow(chunk.startLine + chunk.linesCount - 1) : chunk.element;
-firstLineRow = firstLineRow.nextSibling;
-} else
-firstLineRow = this._container.firstChild;
+// Compute damaged chunks span
+var startLine = firstDamagedChunk.startLine;
+var endLine = lastDamagedChunk.endLine + linesDiff;
-// Most frequent case: a chunk remained the same.
-for (var chunkNumber = firstChunkNumber; chunkNumber = lastChunkNumber; ++chunkNumber) {
-var chunk = this._textChunks[chunkNumber];
-if (chunk.startLine + chunk.linesCount this._textModel.linesCount)
-
[webkit-changes] [135284] branches/chromium/1312/Source/WebCore/inspector
Title: [135284] branches/chromium/1312/Source/WebCore/inspector
Revision 135284
Author pfeld...@chromium.org
Date 2012-11-20 08:26:45 -0800 (Tue, 20 Nov 2012)
Log Message
Merge 134577 - Web Inspector: highlight is not updating as one edits CSS properties
https://bugs.webkit.org/show_bug.cgi?id=102191
Reviewed by Alexander Pavlov.
We should update highlight upon layout / style recalculation.
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didRecalculateStyleImpl):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::didScroll):
(WebCore):
(WebCore::InspectorPageAgent::didRecalculateStyle):
* inspector/InspectorPageAgent.h:
TBR=pfeld...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11413088
Modified Paths
branches/chromium/1312/Source/WebCore/inspector/InspectorInstrumentation.cpp
branches/chromium/1312/Source/WebCore/inspector/InspectorPageAgent.cpp
branches/chromium/1312/Source/WebCore/inspector/InspectorPageAgent.h
Diff
Modified: branches/chromium/1312/Source/WebCore/inspector/InspectorInstrumentation.cpp (135283 => 135284)
--- branches/chromium/1312/Source/WebCore/inspector/InspectorInstrumentation.cpp 2012-11-20 16:20:52 UTC (rev 135283)
+++ branches/chromium/1312/Source/WebCore/inspector/InspectorInstrumentation.cpp 2012-11-20 16:26:45 UTC (rev 135284)
@@ -557,6 +557,8 @@
return;
if (InspectorResourceAgent* resourceAgent = instrumentingAgents-inspectorResourceAgent())
resourceAgent-didRecalculateStyle();
+if (InspectorPageAgent* pageAgent = instrumentingAgents-inspectorPageAgent())
+pageAgent-didRecalculateStyle();
}
void InspectorInstrumentation::didScheduleStyleRecalculationImpl(InstrumentingAgents* instrumentingAgents, Document* document)
Modified: branches/chromium/1312/Source/WebCore/inspector/InspectorPageAgent.cpp (135283 => 135284)
--- branches/chromium/1312/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-11-20 16:20:52 UTC (rev 135283)
+++ branches/chromium/1312/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-11-20 16:26:45 UTC (rev 135284)
@@ -330,7 +330,8 @@
, m_frontend(0)
, m_overlay(overlay)
, m_lastScriptIdentifier(0)
-, m_didLoadEventFire(false)
+, m_enabled(false)
+, m_isFirstLayoutAfterOnLoad(false)
, m_geolocationOverridden(false)
{
}
@@ -371,12 +372,14 @@
void InspectorPageAgent::enable(ErrorString*)
{
+m_enabled = true;
m_state-setBoolean(PageAgentState::pageAgentEnabled, true);
m_instrumentingAgents-setInspectorPageAgent(this);
}
void InspectorPageAgent::disable(ErrorString*)
{
+m_enabled = false;
m_state-setBoolean(PageAgentState::pageAgentEnabled, false);
m_instrumentingAgents-setInspectorPageAgent(0);
@@ -776,7 +779,7 @@
void InspectorPageAgent::domContentEventFired()
{
-m_didLoadEventFire = true;
+m_isFirstLayoutAfterOnLoad = true;
m_frontend-domContentEventFired(currentTime());
}
@@ -882,7 +885,7 @@
void InspectorPageAgent::didPaint(GraphicsContext* context, const LayoutRect rect)
{
-if (!m_state-getBoolean(PageAgentState::showPaintRects))
+if (!m_enabled || !m_state-getBoolean(PageAgentState::showPaintRects))
return;
static int colorSelector = 0;
@@ -899,23 +902,35 @@
void InspectorPageAgent::didLayout()
{
-if (!m_didLoadEventFire)
+bool isFirstLayout = m_isFirstLayoutAfterOnLoad;
+if (isFirstLayout)
+m_isFirstLayoutAfterOnLoad = false;
+
+if (!m_enabled)
return;
-m_didLoadEventFire = false;
-int currentWidth = static_castint(m_state-getLong(PageAgentState::pageAgentScreenWidthOverride));
-int currentHeight = static_castint(m_state-getLong(PageAgentState::pageAgentScreenHeightOverride));
+if (isFirstLayout) {
+int currentWidth = static_castint(m_state-getLong(PageAgentState::pageAgentScreenWidthOverride));
+int currentHeight = static_castint(m_state-getLong(PageAgentState::pageAgentScreenHeightOverride));
-if (currentWidth currentHeight)
-m_client-autoZoomPageToFitWidth();
+if (currentWidth currentHeight)
+m_client-autoZoomPageToFitWidth();
+}
m_overlay-update();
}
void InspectorPageAgent::didScroll()
{
-m_overlay-update();
+if (m_enabled)
+m_overlay-update();
}
+void InspectorPageAgent::didRecalculateStyle()
+{
+if (m_enabled)
+m_overlay-update();
+}
+
PassRefPtrTypeBuilder::Page::Frame InspectorPageAgent::buildObjectForFrame(Frame* frame)
{
RefPtrTypeBuilder::Page::Frame frameObject = TypeBuilder::Page::Frame::create()
Modified:
[webkit-changes] [135285] trunk/Source/WebCore
Title: [135285] trunk/Source/WebCore Revision 135285 Author pfeld...@chromium.org Date 2012-11-20 08:31:36 -0800 (Tue, 20 Nov 2012) Log Message Web Inspector: simplify? damaged region computation in the editor https://bugs.webkit.org/show_bug.cgi?id=102688 Reviewed by Vsevolod Vlasov. This change simplifies the damaged region computation. Drive-by make _getSelection work properly. * inspector/front-end/DefaultTextEditor.js: (WebInspector.DefaultTextEditor): (WebInspector.DefaultTextEditor.prototype._handleCut): (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber.compareLineRowOffsetTops): (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber): (WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var): (WebInspector.TextEditorMainPanel.prototype.handleEnterKey): (WebInspector.TextEditorMainPanel.prototype._paintLineChunks): (WebInspector.TextEditorMainPanel.prototype._getSelection): (WebInspector.TextEditorMainPanel.prototype._restoreSelection): (WebInspector.TextEditorMainPanel.prototype._selectionToPosition): (WebInspector.TextEditorMainPanel.prototype._positionToSelection): (WebInspector.TextEditorMainPanel.prototype._handleMutations): (WebInspector.TextEditorMainPanel.prototype._collectDirtyLines): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnSelection): (WebInspector.TextEditorMainPanel.prototype._assertDOMMatchesTextModel): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges): (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDOM): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype.addDecoration): (WebInspector.TextEditorMainChunk.prototype.get endLine): (WebInspector.TextEditorMainChunk.prototype.lineRowContainingLine): (WebInspector.TextEditorMainChunk.prototype.expandedLineRow): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js Diff Modified: trunk/Source/WebCore/ChangeLog (135284 => 135285) --- trunk/Source/WebCore/ChangeLog 2012-11-20 16:26:45 UTC (rev 135284) +++ trunk/Source/WebCore/ChangeLog 2012-11-20 16:31:36 UTC (rev 135285) @@ -1,3 +1,37 @@ +2012-11-19 Pavel Feldman pfeld...@chromium.org + +Web Inspector: simplify? damaged region computation in the editor +https://bugs.webkit.org/show_bug.cgi?id=102688 + +Reviewed by Vsevolod Vlasov. + +This change simplifies the damaged region computation. Drive-by make _getSelection work properly. + +* inspector/front-end/DefaultTextEditor.js: +(WebInspector.DefaultTextEditor): +(WebInspector.DefaultTextEditor.prototype._handleCut): +(WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber.compareLineRowOffsetTops): +(WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber): +(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var): +(WebInspector.TextEditorMainPanel.prototype.handleEnterKey): +(WebInspector.TextEditorMainPanel.prototype._paintLineChunks): +(WebInspector.TextEditorMainPanel.prototype._getSelection): +(WebInspector.TextEditorMainPanel.prototype._restoreSelection): +(WebInspector.TextEditorMainPanel.prototype._selectionToPosition): +(WebInspector.TextEditorMainPanel.prototype._positionToSelection): +(WebInspector.TextEditorMainPanel.prototype._handleMutations): +(WebInspector.TextEditorMainPanel.prototype._collectDirtyLines): +(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): +(WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnSelection): +(WebInspector.TextEditorMainPanel.prototype._assertDOMMatchesTextModel): +(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges): +(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDOM): +(WebInspector.TextEditorMainChunk): +(WebInspector.TextEditorMainChunk.prototype.addDecoration): +(WebInspector.TextEditorMainChunk.prototype.get endLine): +(WebInspector.TextEditorMainChunk.prototype.lineRowContainingLine): +(WebInspector.TextEditorMainChunk.prototype.expandedLineRow): + 2012-11-19 Erik Arvidsson a...@chromium.org Remove historical enums from ExceptionCode.h Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (135284 => 135285) --- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-20 16:26:45 UTC (rev 135284) +++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-20 16:31:36 UTC (rev 135285) @@ -93,6 +93,7 @@ this._gutterPanel.element.addEventListener(mousewheel, forwardWheelEvent.bind(this), false); this.element.addEventListener(keydown, this._handleKeyDown.bind(this), false); +this.element.addEventListener(cut,
[webkit-changes] [135297] branches/chromium/1312/Source/WebCore/inspector/front-end/ ObjectPropertiesSection.js
Title: [135297] branches/chromium/1312/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
Revision 135297
Author pfeld...@chromium.org
Date 2012-11-20 10:42:21 -0800 (Tue, 20 Nov 2012)
Log Message
Merge 134595 - Web Inspector: context menu on ObjectPropertyTreeElement's values is masked by the section.
https://bugs.webkit.org/show_bug.cgi?id=102212
Reviewed by Vsevolod Vlasov.
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype.enableContextMenu):
TBR=pfeld...@chromium.org
BUG=161156
Review URL: https://chromiumcodereview.appspot.com/11416111
Modified Paths
branches/chromium/1312/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
Diff
Modified: branches/chromium/1312/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js (135296 => 135297)
--- branches/chromium/1312/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js 2012-11-20 18:40:36 UTC (rev 135296)
+++ branches/chromium/1312/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js 2012-11-20 18:42:21 UTC (rev 135297)
@@ -53,7 +53,7 @@
WebInspector.ObjectPropertiesSection.prototype = {
enableContextMenu: function()
{
-this.element.addEventListener(contextmenu, this._contextMenuEventFired.bind(this), true);
+this.element.addEventListener(contextmenu, this._contextMenuEventFired.bind(this), false);
},
_contextMenuEventFired: function(event)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135298] branches/chromium/1312/Source/WebCore/inspector/front-end/ ElementsTreeOutline.js
Title: [135298] branches/chromium/1312/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
Revision 135298
Author pfeld...@chromium.org
Date 2012-11-20 10:46:35 -0800 (Tue, 20 Nov 2012)
Log Message
Merge 134605 - Web Inspector: Reveal in Element Panel doesn't work if Elements panel hasn't been opened
https://bugs.webkit.org/show_bug.cgi?id=102219
Reviewed by Alexander Pavlov.
Force elements module load upon context menu invocation.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
TBR=pfeld...@chromium.org
BUG=161156
Review URL: https://chromiumcodereview.appspot.com/11414088
Modified Paths
branches/chromium/1312/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
Diff
Modified: branches/chromium/1312/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (135297 => 135298)
--- branches/chromium/1312/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-11-20 18:42:21 UTC (rev 135297)
+++ branches/chromium/1312/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-11-20 18:46:35 UTC (rev 135298)
@@ -487,6 +487,8 @@
function focusElement()
{
+// Force elements module load.
+WebInspector.showPanel(elements);
WebInspector.domAgent.inspectElement(treeElement.representedObject.id);
}
var contextMenu = new WebInspector.ContextMenu(event);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134577] trunk/Source/WebCore
Title: [134577] trunk/Source/WebCore
Revision 134577
Author pfeld...@chromium.org
Date 2012-11-14 01:57:24 -0800 (Wed, 14 Nov 2012)
Log Message
Web Inspector: highlight is not updating as one edits CSS properties
https://bugs.webkit.org/show_bug.cgi?id=102191
Reviewed by Alexander Pavlov.
We should update highlight upon layout / style recalculation.
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didRecalculateStyleImpl):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::didScroll):
(WebCore):
(WebCore::InspectorPageAgent::didRecalculateStyle):
* inspector/InspectorPageAgent.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (134576 => 134577)
--- trunk/Source/WebCore/ChangeLog 2012-11-14 09:54:14 UTC (rev 134576)
+++ trunk/Source/WebCore/ChangeLog 2012-11-14 09:57:24 UTC (rev 134577)
@@ -1,3 +1,27 @@
+2012-11-14 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: highlight is not updating as one edits CSS properties
+https://bugs.webkit.org/show_bug.cgi?id=102191
+
+Reviewed by Alexander Pavlov.
+
+We should update highlight upon layout / style recalculation.
+
+* inspector/InspectorInstrumentation.cpp:
+(WebCore):
+(WebCore::InspectorInstrumentation::didRecalculateStyleImpl):
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::InspectorPageAgent):
+(WebCore::InspectorPageAgent::enable):
+(WebCore::InspectorPageAgent::disable):
+(WebCore::InspectorPageAgent::domContentEventFired):
+(WebCore::InspectorPageAgent::didPaint):
+(WebCore::InspectorPageAgent::didLayout):
+(WebCore::InspectorPageAgent::didScroll):
+(WebCore):
+(WebCore::InspectorPageAgent::didRecalculateStyle):
+* inspector/InspectorPageAgent.h:
+
2012-11-14 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r134566.
Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (134576 => 134577)
--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2012-11-14 09:54:14 UTC (rev 134576)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2012-11-14 09:57:24 UTC (rev 134577)
@@ -557,6 +557,8 @@
return;
if (InspectorResourceAgent* resourceAgent = instrumentingAgents-inspectorResourceAgent())
resourceAgent-didRecalculateStyle();
+if (InspectorPageAgent* pageAgent = instrumentingAgents-inspectorPageAgent())
+pageAgent-didRecalculateStyle();
}
void InspectorInstrumentation::didScheduleStyleRecalculationImpl(InstrumentingAgents* instrumentingAgents, Document* document)
Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (134576 => 134577)
--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-11-14 09:54:14 UTC (rev 134576)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-11-14 09:57:24 UTC (rev 134577)
@@ -331,7 +331,8 @@
, m_frontend(0)
, m_overlay(overlay)
, m_lastScriptIdentifier(0)
-, m_didLoadEventFire(false)
+, m_enabled(false)
+, m_isFirstLayoutAfterOnLoad(false)
, m_geolocationOverridden(false)
{
}
@@ -364,6 +365,7 @@
void InspectorPageAgent::enable(ErrorString*)
{
+m_enabled = true;
m_state-setBoolean(PageAgentState::pageAgentEnabled, true);
bool scriptExecutionDisabled = m_state-getBoolean(PageAgentState::pageAgentScriptExecutionDisabled);
setScriptExecutionDisabled(0, scriptExecutionDisabled);
@@ -374,6 +376,7 @@
void InspectorPageAgent::disable(ErrorString*)
{
+m_enabled = false;
m_state-setBoolean(PageAgentState::pageAgentEnabled, false);
m_instrumentingAgents-setInspectorPageAgent(0);
@@ -788,7 +791,7 @@
void InspectorPageAgent::domContentEventFired()
{
-m_didLoadEventFire = true;
+m_isFirstLayoutAfterOnLoad = true;
m_frontend-domContentEventFired(currentTime());
}
@@ -894,7 +897,7 @@
void InspectorPageAgent::didPaint(GraphicsContext* context, const LayoutRect rect)
{
-if (!m_state-getBoolean(PageAgentState::showPaintRects))
+if (!m_enabled || !m_state-getBoolean(PageAgentState::showPaintRects))
return;
static int colorSelector = 0;
@@ -911,23 +914,35 @@
void InspectorPageAgent::didLayout()
{
-if (!m_didLoadEventFire)
+bool isFirstLayout = m_isFirstLayoutAfterOnLoad;
+if (isFirstLayout)
+m_isFirstLayoutAfterOnLoad = false;
+
+if (!m_enabled)
[webkit-changes] [134589] trunk/LayoutTests
Title: [134589] trunk/LayoutTests Revision 134589 Author pfeld...@chromium.org Date 2012-11-14 03:21:49 -0800 (Wed, 14 Nov 2012) Log Message Not reviewed: proper baselines for inspector's timeline-timer-fired-from-eval-call-site. * inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt Added Paths trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (134588 => 134589) --- trunk/LayoutTests/ChangeLog 2012-11-14 11:14:20 UTC (rev 134588) +++ trunk/LayoutTests/ChangeLog 2012-11-14 11:21:49 UTC (rev 134589) @@ -1,3 +1,9 @@ +2012-11-14 Pavel Feldman pfeld...@chromium.org + +Not reviewed: proper baselines for inspector's timeline-timer-fired-from-eval-call-site. + +* inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt: + 2012-11-14 Kenneth Rohde Christiansen kenn...@webkit.org Clean up use of adjustWindowRect Modified: trunk/LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt (134588 => 134589) --- trunk/LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt 2012-11-14 11:14:20 UTC (rev 134588) +++ trunk/LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt 2012-11-14 11:21:49 UTC (rev 134589) @@ -1,5 +1,5 @@ Tests the Timeline API instrumentation of a TimerFired events inside evaluated scripts. -TimerFire fromEval.js:2 -TimerFire fromEval.js:1 +TimerFire :2 +TimerFire :1 Copied: trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt (from rev 134588, trunk/LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt) (0 => 134589) --- trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt 2012-11-14 11:21:49 UTC (rev 134589) @@ -0,0 +1,5 @@ +Tests the Timeline API instrumentation of a TimerFired events inside evaluated scripts. + +TimerFire fromEval.js:2 +TimerFire fromEval.js:1 + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134591] trunk/Source/WebCore
Title: [134591] trunk/Source/WebCore
Revision 134591
Author pfeld...@chromium.org
Date 2012-11-14 03:32:35 -0800 (Wed, 14 Nov 2012)
Log Message
Web Inspector: use last selection as complementary signal when applying DOM changes to the text model.
https://bugs.webkit.org/show_bug.cgi?id=101905
Reviewed by Vsevolod Vlasov.
Currently we use heuristics for detecting damaged model range upon DOM mutation.
This change adds signals from the last selection and keyboard events in order to
further improve the heuristics quality.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor):
(WebInspector.DefaultTextEditor.EditInfo):
(WebInspector.DefaultTextEditor.prototype._handleTextInput):
(WebInspector.DefaultTextEditor.prototype._handleKeyDown):
(WebInspector.DefaultTextEditor.prototype.lastSelection):
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnSelection):
(WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnDiff):
(WebInspector.TextEditorMainPanel.prototype._closingBlockOffset):
(WebInspector.TextEditorMainPanel.prototype._handleSelectionChange):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextRange.prototype.compareTo):
(WebInspector.TextRange.prototype.shift):
(WebInspector.TextEditorModel.endsWithBracketRegex.):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
trunk/Source/WebCore/inspector/front-end/TextEditorModel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (134590 => 134591)
--- trunk/Source/WebCore/ChangeLog 2012-11-14 11:24:53 UTC (rev 134590)
+++ trunk/Source/WebCore/ChangeLog 2012-11-14 11:32:35 UTC (rev 134591)
@@ -1,3 +1,31 @@
+2012-11-13 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: use last selection as complementary signal when applying DOM changes to the text model.
+https://bugs.webkit.org/show_bug.cgi?id=101905
+
+Reviewed by Vsevolod Vlasov.
+
+Currently we use heuristics for detecting damaged model range upon DOM mutation.
+This change adds signals from the last selection and keyboard events in order to
+further improve the heuristics quality.
+
+* inspector/front-end/DefaultTextEditor.js:
+(WebInspector.DefaultTextEditor):
+(WebInspector.DefaultTextEditor.EditInfo):
+(WebInspector.DefaultTextEditor.prototype._handleTextInput):
+(WebInspector.DefaultTextEditor.prototype._handleKeyDown):
+(WebInspector.DefaultTextEditor.prototype.lastSelection):
+(WebInspector.DefaultTextEditor.prototype.wasShown):
+(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
+(WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnSelection):
+(WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnDiff):
+(WebInspector.TextEditorMainPanel.prototype._closingBlockOffset):
+(WebInspector.TextEditorMainPanel.prototype._handleSelectionChange):
+* inspector/front-end/TextEditorModel.js:
+(WebInspector.TextRange.prototype.compareTo):
+(WebInspector.TextRange.prototype.shift):
+(WebInspector.TextEditorModel.endsWithBracketRegex.):
+
2012-11-14 Dan Carney dcar...@google.com
[V8] use toV8Fast in all relevant Node getters
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (134590 => 134591)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-14 11:24:53 UTC (rev 134590)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-14 11:32:35 UTC (rev 134591)
@@ -93,11 +93,23 @@
this._gutterPanel.element.addEventListener(mousewheel, forwardWheelEvent.bind(this), false);
this.element.addEventListener(keydown, this._handleKeyDown.bind(this), false);
+this.element.addEventListener(textInput, this._handleTextInput.bind(this), false);
this.element.addEventListener(contextmenu, this._contextMenu.bind(this), true);
this._registerShortcuts();
}
+/**
+ * @constructor
+ * @param {WebInspector.TextRange} range
+ * @param {string} text
+ */
+WebInspector.DefaultTextEditor.EditInfo = function(range, text)
+{
+this.range = range;
+this.text = text;
+}
+
WebInspector.DefaultTextEditor.prototype = {
/**
* @param {string} mimeType
@@ -397,13 +409,21 @@
return true;
},
+_handleTextInput: function(e)
+{
+this._mainPanel._textInputData = e.data;
+},
+
_handleKeyDown: function(e)
{
var shortcutKey = WebInspector.KeyboardShortcut.makeKeyFromEvent(e);
var handler = this._shortcuts[shortcutKey];
-if (handler handler())
+if (handler handler()) {
e.consume(true);
+return;
+}
+this._mainPanel._keyDownCode = e.keyCode;
},
[webkit-changes] [134595] trunk/Source/WebCore
Title: [134595] trunk/Source/WebCore
Revision 134595
Author pfeld...@chromium.org
Date 2012-11-14 05:14:42 -0800 (Wed, 14 Nov 2012)
Log Message
Web Inspector: context menu on ObjectPropertyTreeElement's values is masked by the section.
https://bugs.webkit.org/show_bug.cgi?id=102212
Reviewed by Vsevolod Vlasov.
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype.enableContextMenu):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (134594 => 134595)
--- trunk/Source/WebCore/ChangeLog 2012-11-14 12:39:09 UTC (rev 134594)
+++ trunk/Source/WebCore/ChangeLog 2012-11-14 13:14:42 UTC (rev 134595)
@@ -1,3 +1,13 @@
+2012-11-14 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: context menu on ObjectPropertyTreeElement's values is masked by the section.
+https://bugs.webkit.org/show_bug.cgi?id=102212
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/ObjectPropertiesSection.js:
+(WebInspector.ObjectPropertiesSection.prototype.enableContextMenu):
+
2012-11-09 Ilya Tikhonovsky loi...@chromium.org
Web Inspector: NMI add instrumentation for WebAudo related stuff.
Modified: trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js (134594 => 134595)
--- trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js 2012-11-14 12:39:09 UTC (rev 134594)
+++ trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js 2012-11-14 13:14:42 UTC (rev 134595)
@@ -53,7 +53,7 @@
WebInspector.ObjectPropertiesSection.prototype = {
enableContextMenu: function()
{
-this.element.addEventListener(contextmenu, this._contextMenuEventFired.bind(this), true);
+this.element.addEventListener(contextmenu, this._contextMenuEventFired.bind(this), false);
},
_contextMenuEventFired: function(event)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134605] trunk/Source/WebCore
Title: [134605] trunk/Source/WebCore
Revision 134605
Author pfeld...@chromium.org
Date 2012-11-14 07:12:08 -0800 (Wed, 14 Nov 2012)
Log Message
Web Inspector: Reveal in Element Panel doesn't work if Elements panel hasn't been opened
https://bugs.webkit.org/show_bug.cgi?id=102219
Reviewed by Alexander Pavlov.
Force elements module load upon context menu invocation.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (134604 => 134605)
--- trunk/Source/WebCore/ChangeLog 2012-11-14 14:52:25 UTC (rev 134604)
+++ trunk/Source/WebCore/ChangeLog 2012-11-14 15:12:08 UTC (rev 134605)
@@ -1,3 +1,16 @@
+2012-11-14 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: Reveal in Element Panel doesn't work if Elements panel hasn't been opened
+https://bugs.webkit.org/show_bug.cgi?id=102219
+
+Reviewed by Alexander Pavlov.
+
+Force elements module load upon context menu invocation.
+
+* inspector/front-end/ElementsTreeOutline.js:
+(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
+(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
+
2012-11-14 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r134523.
Modified: trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (134604 => 134605)
--- trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-11-14 14:52:25 UTC (rev 134604)
+++ trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-11-14 15:12:08 UTC (rev 134605)
@@ -487,6 +487,8 @@
function focusElement()
{
+// Force elements module load.
+WebInspector.showPanel(elements);
WebInspector.domAgent.inspectElement(treeElement.representedObject.id);
}
var contextMenu = new WebInspector.ContextMenu(event);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134627] trunk/Source/WebCore
Title: [134627] trunk/Source/WebCore
Revision 134627
Author pfeld...@chromium.org
Date 2012-11-14 10:48:59 -0800 (Wed, 14 Nov 2012)
Log Message
Web Inspector: keep track of mutation observers and disconnect them upon upload
https://bugs.webkit.org/show_bug.cgi?id=102239
Reviewed by Vsevolod Vlasov.
Otherwise we hit memory leaks.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype._wasShown):
(WebInspector.TextEditorMainPanel.prototype._willHide):
(WebInspector.TextEditorMainPanel.prototype._attachMutationObserver):
(WebInspector.TextEditorMainPanel.prototype._detachMutationObserver):
* inspector/front-end/utilities.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
trunk/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (134626 => 134627)
--- trunk/Source/WebCore/ChangeLog 2012-11-14 18:43:21 UTC (rev 134626)
+++ trunk/Source/WebCore/ChangeLog 2012-11-14 18:48:59 UTC (rev 134627)
@@ -1,3 +1,21 @@
+2012-11-14 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: keep track of mutation observers and disconnect them upon upload
+https://bugs.webkit.org/show_bug.cgi?id=102239
+
+Reviewed by Vsevolod Vlasov.
+
+Otherwise we hit memory leaks.
+
+* inspector/front-end/DefaultTextEditor.js:
+(WebInspector.DefaultTextEditor.prototype.wasShown):
+(WebInspector.DefaultTextEditor.prototype.willHide):
+(WebInspector.TextEditorMainPanel.prototype._wasShown):
+(WebInspector.TextEditorMainPanel.prototype._willHide):
+(WebInspector.TextEditorMainPanel.prototype._attachMutationObserver):
+(WebInspector.TextEditorMainPanel.prototype._detachMutationObserver):
+* inspector/front-end/utilities.js:
+
2012-11-14 Sergio Villar Senin svil...@igalia.com
[Qt] Use a node image if there is no drag image set for DragDrop
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (134626 => 134627)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-14 18:43:21 UTC (rev 134626)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-14 18:48:59 UTC (rev 134627)
@@ -560,7 +560,7 @@
this._boundSelectionChangeListener = this._mainPanel._handleSelectionChange.bind(this._mainPanel);
document.addEventListener(selectionchange, this._boundSelectionChangeListener, false);
-this._mainPanel._attachMutationObserver();
+this._mainPanel._wasShown();
},
_handleFocused: function()
@@ -571,7 +571,7 @@
willHide: function()
{
-this._mainPanel._detachMutationObserver();
+this._mainPanel._willHide();
document.removeEventListener(selectionchange, this._boundSelectionChangeListener, false);
delete this._boundSelectionChangeListener;
@@ -1239,16 +1239,34 @@
}
WebInspector.TextEditorMainPanel.prototype = {
+_wasShown: function()
+{
+this._isShowing = true;
+this._attachMutationObserver();
+},
+
+_willHide: function()
+{
+this._detachMutationObserver();
+this._isShowing = false;
+},
+
_attachMutationObserver: function()
{
+if (!this._isShowing)
+return;
+
if (this._mutationObserver)
this._mutationObserver.disconnect();
-this._mutationObserver = new WebKitMutationObserver(this._handleMutations.bind(this));
+this._mutationObserver = new NonLeakingMutationObserver(this._handleMutations.bind(this));
this._mutationObserver.observe(this._container, { subtree: true, childList: true, characterData: true });
},
_detachMutationObserver: function()
{
+if (!this._isShowing)
+return;
+
if (this._mutationObserver) {
this._mutationObserver.disconnect();
delete this._mutationObserver;
Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (134626 => 134627)
--- trunk/Source/WebCore/inspector/front-end/utilities.js 2012-11-14 18:43:21 UTC (rev 134626)
+++ trunk/Source/WebCore/inspector/front-end/utilities.js 2012-11-14 18:48:59 UTC (rev 134627)
@@ -866,3 +866,46 @@
xhr.send(null);
window.eval(xhr.responseText + \n//@ sourceURL= + scriptName);
}
+
+
+/**
+ * Mutation observers leak memory. Keep track of them and disconnect
+ * on unload.
+ * @constructor
+ * @param {function(Array.WebKitMutation)} handler
+ */
+function NonLeakingMutationObserver(handler)
+{
+this._observer = new WebKitMutationObserver(handler);
+NonLeakingMutationObserver._instances.push(this);
+}
+
+NonLeakingMutationObserver._instances = [];
+
+NonLeakingMutationObserver.prototype = {
+/**
+ * @param {Element} element
+ * @param {Object}
[webkit-changes] [134745] trunk/Source/WebCore
Title: [134745] trunk/Source/WebCore
Revision 134745
Author pfeld...@chromium.org
Date 2012-11-14 22:57:37 -0800 (Wed, 14 Nov 2012)
Log Message
Not reviewed: fixing inspector tests under Qt.
* inspector/front-end/TestController.js:
* inspector/front-end/utilities.js:
(.):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TestController.js
trunk/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (134744 => 134745)
--- trunk/Source/WebCore/ChangeLog 2012-11-15 06:51:10 UTC (rev 134744)
+++ trunk/Source/WebCore/ChangeLog 2012-11-15 06:57:37 UTC (rev 134745)
@@ -1,3 +1,11 @@
+2012-11-14 Pavel Feldman pfeld...@chromium.org
+
+Not reviewed: fixing inspector tests under Qt.
+
+* inspector/front-end/TestController.js:
+* inspector/front-end/utilities.js:
+(.):
+
2012-11-14 Kentaro Hara hara...@chromium.org
Unreviewed. Rebaselined run-bindings-tests.
Modified: trunk/Source/WebCore/inspector/front-end/TestController.js (134744 => 134745)
--- trunk/Source/WebCore/inspector/front-end/TestController.js 2012-11-15 06:51:10 UTC (rev 134744)
+++ trunk/Source/WebCore/inspector/front-end/TestController.js 2012-11-15 06:57:37 UTC (rev 134745)
@@ -45,6 +45,7 @@
WebInspector.evaluateForTestInFrontend = function(callId, script)
{
+WebInspector.isUnderTest = true;
function invokeMethod()
{
try {
Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (134744 => 134745)
--- trunk/Source/WebCore/inspector/front-end/utilities.js 2012-11-15 06:51:10 UTC (rev 134744)
+++ trunk/Source/WebCore/inspector/front-end/utilities.js 2012-11-15 06:57:37 UTC (rev 134745)
@@ -878,6 +878,13 @@
{
this._observer = new WebKitMutationObserver(handler);
NonLeakingMutationObserver._instances.push(this);
+if (!window.testRunner !WebInspector.isUnderTest !NonLeakingMutationObserver._unloadListener) {
+NonLeakingMutationObserver._unloadListener = function() {
+while (NonLeakingMutationObserver._instances.length)
+NonLeakingMutationObserver._instances[NonLeakingMutationObserver._instances.length - 1].disconnect();
+};
+window.addEventListener(unload, NonLeakingMutationObserver._unloadListener, false);
+}
}
NonLeakingMutationObserver._instances = [];
@@ -902,10 +909,3 @@
}
}
-if (!window.testRunner) {
-window.addEventListener(unload, function() {
-while (NonLeakingMutationObserver._instances.length)
-NonLeakingMutationObserver._instances[NonLeakingMutationObserver._instances.length - 1].disconnect();
-}, false);
-}
-
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134379] trunk/Source/WebCore
Title: [134379] trunk/Source/WebCore
Revision 134379
Author pfeld...@chromium.org
Date 2012-11-13 00:34:35 -0800 (Tue, 13 Nov 2012)
Log Message
Web Inspector: migrate text editor to mutation observers
https://bugs.webkit.org/show_bug.cgi?id=101841
Reviewed by Vsevolod Vlasov.
Otherwise, we miss notifications on the removed lines.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._wasShown):
(WebInspector.TextEditorMainPanel.prototype._willHide):
(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
(WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
(WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._handleMutations.else.get if):
(WebInspector.TextEditorMainPanel.prototype._handleMutations):
(WebInspector.TextEditorMainPanel.prototype._collectDirtyLines):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
* inspector/front-end/externs.js:
(WebKitMutation):
(WebKitMutationObserver.prototype.observe):
(WebKitMutationObserver.prototype.disconnect):
* inspector/front-end/textEditor.css:
(.debug-fadeout):
(@-webkit-keyframes debug-fadeout):
(to):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
trunk/Source/WebCore/inspector/front-end/externs.js
trunk/Source/WebCore/inspector/front-end/textEditor.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (134378 => 134379)
--- trunk/Source/WebCore/ChangeLog 2012-11-13 08:33:08 UTC (rev 134378)
+++ trunk/Source/WebCore/ChangeLog 2012-11-13 08:34:35 UTC (rev 134379)
@@ -1,3 +1,39 @@
+2012-11-13 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: migrate text editor to mutation observers
+https://bugs.webkit.org/show_bug.cgi?id=101841
+
+Reviewed by Vsevolod Vlasov.
+
+Otherwise, we miss notifications on the removed lines.
+
+* inspector/front-end/DefaultTextEditor.js:
+(WebInspector.DefaultTextEditor.prototype.wasShown):
+(WebInspector.DefaultTextEditor.prototype.willHide):
+(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
+(WebInspector.TextEditorMainPanel):
+(WebInspector.TextEditorMainPanel.prototype._wasShown):
+(WebInspector.TextEditorMainPanel.prototype._willHide):
+(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
+(WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
+(WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
+(WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
+(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
+(WebInspector.TextEditorMainPanel.prototype._paintLine):
+(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
+(WebInspector.TextEditorMainPanel.prototype._handleMutations.else.get if):
+(WebInspector.TextEditorMainPanel.prototype._handleMutations):
+(WebInspector.TextEditorMainPanel.prototype._collectDirtyLines):
+(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
+* inspector/front-end/externs.js:
+(WebKitMutation):
+(WebKitMutationObserver.prototype.observe):
+(WebKitMutationObserver.prototype.disconnect):
+* inspector/front-end/textEditor.css:
+(.debug-fadeout):
+(@-webkit-keyframes debug-fadeout):
+(to):
+
2012-11-13 Gabor Rapcsanyi rga...@webkit.org
Optimize RGBAToRGBA8 packing/unpacking functions with NEON intrinsics in GraphicsContext3D
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (134378 => 134379)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-13 08:33:08 UTC (rev 134378)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-13 08:34:35 UTC (rev 134379)
@@ -581,6 +581,7 @@
this._boundSelectionChangeListener = this._handleSelectionChange.bind(this);
document.addEventListener(selectionchange, this._boundSelectionChangeListener, false);
+this._mainPanel._attachMutationObserver();
},
_handleFocused: function()
@@ -591,6 +592,7 @@
willHide: function()
{
+this._mainPanel._detachMutationObserver();
document.removeEventListener(selectionchange, this._boundSelectionChangeListener, false);
delete this._boundSelectionChangeListener;
@@ -877,7 +879,7 @@
{
delete this._repaintAllTimer;
[webkit-changes] [134382] trunk
Title: [134382] trunk
Revision 134382
Author pfeld...@chromium.org
Date 2012-11-13 00:48:42 -0800 (Tue, 13 Nov 2012)
Log Message
Web Inspector: move indentation logic into TextEditorModel
https://bugs.webkit.org/show_bug.cgi?id=101842
Reviewed by Vsevolod Vlasov.
Source/WebCore:
I'd like to move as much headless logic into the TextEditorModel as possible.
Drive by: removed some dead code, converted getter into function and moved undo
mark state into the model as well.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.editRange):
(WebInspector.DefaultTextEditor.prototype._syncDecorationsForLine):
(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.isDecorated):
(WebInspector.TextEditorMainChunk.prototype.set expanded):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
LayoutTests:
* inspector/editor/indentation.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/editor/indentation.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
trunk/Source/WebCore/inspector/front-end/TextEditorModel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (134381 => 134382)
--- trunk/LayoutTests/ChangeLog 2012-11-13 08:42:47 UTC (rev 134381)
+++ trunk/LayoutTests/ChangeLog 2012-11-13 08:48:42 UTC (rev 134382)
@@ -1,3 +1,12 @@
+2012-11-13 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: move indentation logic into TextEditorModel
+https://bugs.webkit.org/show_bug.cgi?id=101842
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/editor/indentation.html:
+
2012-11-13 Takashi Sakamoto ta...@google.com
Crash when replacing parts of text inputs with content: url(...)
Modified: trunk/LayoutTests/inspector/editor/indentation.html (134381 => 134382)
--- trunk/LayoutTests/inspector/editor/indentation.html 2012-11-13 08:42:47 UTC (rev 134381)
+++ trunk/LayoutTests/inspector/editor/indentation.html 2012-11-13 08:48:42 UTC (rev 134382)
@@ -11,8 +11,6 @@
var model = new WebInspector.TextEditorModel();
model.setText(src);
-function noop() {}
-var textEditorMainPanel = new WebInspector.TextEditorMainPanel(null, model, '', noop, noop, noop, noop);
var selection;
function dumpTextModel(msg)
@@ -22,19 +20,19 @@
InspectorTest.addResult('Selection ' + selection.startLine + ',' + selection.startColumn + ' ' + selection.endLine + ',' + selection.endColumn + '\n');
}
-selection = textEditorMainPanel._indentLines(new WebInspector.TextRange(0, 0, 1, 0));
+selection = model.indentLines(new WebInspector.TextRange(0, 0, 1, 0));
dumpTextModel(After indenting first fully selected line);
-selection = textEditorMainPanel._indentLines(new WebInspector.TextRange(0, 5, 1, 0));
+selection = model.indentLines(new WebInspector.TextRange(0, 5, 1, 0));
dumpTextModel(After indenting first partially selected line);
-selection = textEditorMainPanel._unindentLines(new WebInspector.TextRange(0, 0, 2, 0));
+selection = model.unindentLines(new WebInspector.TextRange(0, 0, 2, 0));
dumpTextModel(After unindenting two fully selected lines);
-selection = textEditorMainPanel._unindentLines(new WebInspector.TextRange(0, 5, 1, 6));
+selection = model.unindentLines(new WebInspector.TextRange(0, 5, 1, 6));
dumpTextModel(After unindenting two partially selected lines (bug 97462));
-selection = textEditorMainPanel._unindentLines(new WebInspector.TextRange(0, 0, 2, 3));
+selection = model.unindentLines(new WebInspector.TextRange(0, 0, 2, 3));
dumpTextModel(After unindenting three partially selected lines);
InspectorTest.completeTest();
Modified: trunk/Source/WebCore/ChangeLog (134381 => 134382)
--- trunk/Source/WebCore/ChangeLog 2012-11-13 08:42:47 UTC (rev 134381)
+++ trunk/Source/WebCore/ChangeLog 2012-11-13 08:48:42 UTC (rev 134382)
@@ -1,3 +1,28 @@
+2012-11-13 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: move indentation logic into TextEditorModel
+https://bugs.webkit.org/show_bug.cgi?id=101842
+
+Reviewed by Vsevolod Vlasov.
+
+I'd like to move as much headless logic into the TextEditorModel as possible.
+Drive by: removed some dead code, converted getter into function and moved undo
+mark state into the model as well.
+
+* inspector/front-end/DefaultTextEditor.js:
+(WebInspector.DefaultTextEditor.prototype.editRange):
+(WebInspector.DefaultTextEditor.prototype._syncDecorationsForLine):
+
