[webkit-changes] [146512] trunk/Source/Platform

2013-03-21 Thread pilgrim
Title: [146512] trunk/Source/Platform








Revision 146512
Author pilg...@chromium.org
Date 2013-03-21 13:49:06 -0700 (Thu, 21 Mar 2013)


Log Message
[Chromium] Removed unused WEBKIT_USE_NEW_WEBFILESYSTEMTYPE flag
https://bugs.webkit.org/show_bug.cgi?id=112931

Reviewed by Adam Barth.

Migration complete; flag no longer needed.

* chromium/public/WebFileSystemType.h:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebFileSystemType.h




Diff

Modified: trunk/Source/Platform/ChangeLog (146511 => 146512)

--- trunk/Source/Platform/ChangeLog	2013-03-21 20:43:58 UTC (rev 146511)
+++ trunk/Source/Platform/ChangeLog	2013-03-21 20:49:06 UTC (rev 146512)
@@ -1,3 +1,14 @@
+2013-03-21  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Removed unused WEBKIT_USE_NEW_WEBFILESYSTEMTYPE flag
+https://bugs.webkit.org/show_bug.cgi?id=112931
+
+Reviewed by Adam Barth.
+
+Migration complete; flag no longer needed.
+
+* chromium/public/WebFileSystemType.h:
+
 2013-03-21  Anton Muhin  ant...@chromium.org
 
 Unreviewed, rolling out r146483.


Modified: trunk/Source/Platform/chromium/public/WebFileSystemType.h (146511 => 146512)

--- trunk/Source/Platform/chromium/public/WebFileSystemType.h	2013-03-21 20:43:58 UTC (rev 146511)
+++ trunk/Source/Platform/chromium/public/WebFileSystemType.h	2013-03-21 20:49:06 UTC (rev 146512)
@@ -31,12 +31,8 @@
 #ifndef WebFileSystemType_h
 #define WebFileSystemType_h
 
-// TODO(pilgrim) Clean up everything around this ifdef
-#define WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
-
 namespace WebKit {
 
-#ifdef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
 enum WebFileSystemType {
 WebFileSystemTypeTemporary,
 WebFileSystemTypePersistent,
@@ -47,7 +43,6 @@
 // Indicates a non-sandboxed filesystem.
 WebFileSystemTypeExternal,
 };
-#endif // WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
 
 } // namespace WebKit
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [146251] trunk/Source/Platform

2013-03-19 Thread pilgrim
Title: [146251] trunk/Source/Platform








Revision 146251
Author pilg...@chromium.org
Date 2013-03-19 13:34:15 -0700 (Tue, 19 Mar 2013)


Log Message
[Chromium] Flip WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
https://bugs.webkit.org/show_bug.cgi?id=112726

Reviewed by Adam Barth.

Now that all embedders respect this ifdef, we can safely define it
to get everything to use the new top-level WebFileSystemType enum.

* chromium/public/WebFileSystemType.h:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebFileSystemType.h




Diff

Modified: trunk/Source/Platform/ChangeLog (146250 => 146251)

--- trunk/Source/Platform/ChangeLog	2013-03-19 20:30:34 UTC (rev 146250)
+++ trunk/Source/Platform/ChangeLog	2013-03-19 20:34:15 UTC (rev 146251)
@@ -1,3 +1,15 @@
+2013-03-19  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Flip WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
+https://bugs.webkit.org/show_bug.cgi?id=112726
+
+Reviewed by Adam Barth.
+
+Now that all embedders respect this ifdef, we can safely define it
+to get everything to use the new top-level WebFileSystemType enum.
+
+* chromium/public/WebFileSystemType.h:
+
 2013-03-19  James Robinson  jam...@chromium.org
 
 [chromium] Remove deprecated/unused bits of WebLayerTreeView


Modified: trunk/Source/Platform/chromium/public/WebFileSystemType.h (146250 => 146251)

--- trunk/Source/Platform/chromium/public/WebFileSystemType.h	2013-03-19 20:30:34 UTC (rev 146250)
+++ trunk/Source/Platform/chromium/public/WebFileSystemType.h	2013-03-19 20:34:15 UTC (rev 146251)
@@ -31,8 +31,8 @@
 #ifndef WebFileSystemType_h
 #define WebFileSystemType_h
 
-// TODO(pilgrim) Uncomment this once all embedders have been updated to use this new enum
-// #define WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
+// TODO(pilgrim) Clean up everything around this ifdef
+#define WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
 
 namespace WebKit {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [146299] trunk

2013-03-19 Thread pilgrim
Title: [146299] trunk








Revision 146299
Author pilg...@chromium.org
Date 2013-03-19 21:08:49 -0700 (Tue, 19 Mar 2013)


Log Message
[Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
https://bugs.webkit.org/show_bug.cgi?id=112754

Reviewed by Darin Fisher.

Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
now that it's always defined.

Source/WebKit/chromium:

* public/WebCommonWorkerClient.h:
(WebCommonWorkerClient):
* public/WebFrame.h:
(WebFrame):
* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::openFileSystem):
(WebKit::WebFrameClient::deleteFileSystem):
* src/LocalFileSystemChromium.cpp:
(WebCore):
(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::deleteFileSystem):
* src/WebFrameImpl.cpp:
* src/WebFrameImpl.h:
(WebFrameImpl):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::openFileSystem):
* src/WebWorkerClientImpl.h:
* src/WorkerFileSystemCallbacksBridge.cpp:
* src/WorkerFileSystemCallbacksBridge.h:
(WorkerFileSystemCallbacksBridge):

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebCommonWorkerClient.h
trunk/Source/WebKit/chromium/public/WebFrame.h
trunk/Source/WebKit/chromium/public/WebFrameClient.h
trunk/Source/WebKit/chromium/src/LocalFileSystemChromium.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.h
trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.h
trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp
trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (146298 => 146299)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-20 04:00:45 UTC (rev 146298)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-20 04:08:49 UTC (rev 146299)
@@ -1,3 +1,35 @@
+2013-03-19  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
+https://bugs.webkit.org/show_bug.cgi?id=112754
+
+Reviewed by Darin Fisher.
+
+Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
+now that it's always defined.
+
+* public/WebCommonWorkerClient.h:
+(WebCommonWorkerClient):
+* public/WebFrame.h:
+(WebFrame):
+* public/WebFrameClient.h:
+(WebFrameClient):
+(WebKit::WebFrameClient::openFileSystem):
+(WebKit::WebFrameClient::deleteFileSystem):
+* src/LocalFileSystemChromium.cpp:
+(WebCore):
+(WebCore::openFileSystemHelper):
+(WebCore::LocalFileSystem::deleteFileSystem):
+* src/WebFrameImpl.cpp:
+* src/WebFrameImpl.h:
+(WebFrameImpl):
+* src/WebWorkerClientImpl.cpp:
+(WebKit::WebWorkerClientImpl::openFileSystem):
+* src/WebWorkerClientImpl.h:
+* src/WorkerFileSystemCallbacksBridge.cpp:
+* src/WorkerFileSystemCallbacksBridge.h:
+(WorkerFileSystemCallbacksBridge):
+
 2013-03-19  Kenneth Russell  k...@google.com
 
 Unreviewed, rolling out r146277.


Modified: trunk/Source/WebKit/chromium/public/WebCommonWorkerClient.h (146298 => 146299)

--- trunk/Source/WebKit/chromium/public/WebCommonWorkerClient.h	2013-03-20 04:00:45 UTC (rev 146298)
+++ trunk/Source/WebKit/chromium/public/WebCommonWorkerClient.h	2013-03-20 04:08:49 UTC (rev 146299)
@@ -60,11 +60,7 @@
 }
 
 // Called on the main webkit thread before opening a file system.
-#ifdef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
 virtual void openFileSystem(WebFileSystemType, long long size, bool create, WebFileSystemCallbacks*)
-#else
-virtual void openFileSystem(WebFileSystem::Type, long long size, bool create, WebFileSystemCallbacks*)
-#endif
 {
 WEBKIT_ASSERT_NOT_REACHED();
 }


Modified: trunk/Source/WebKit/chromium/public/WebFrame.h (146298 => 146299)

--- trunk/Source/WebKit/chromium/public/WebFrame.h	2013-03-20 04:00:45 UTC (rev 146298)
+++ trunk/Source/WebKit/chromium/public/WebFrame.h	2013-03-20 04:08:49 UTC (rev 146299)
@@ -291,7 +291,6 @@
 // be calling this API.
 virtual v8::Localv8::Context mainWorldScriptContext() const = 0;
 
-#ifdef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
 // Creates an instance of file system object.
 virtual v8::Handlev8::Value createFileSystem(WebFileSystemType,
 const WebString name,
@@ -308,24 +307,6 @@
 const WebString fileSystemRootURL,
 const WebString filePath,
 bool isDirectory) = 0;
-#else
-// Creates an instance of file system object.
-virtual v8::Handlev8::Value createFileSystem(WebFileSystem::Type,
-const WebString name,
-const WebString roo

[webkit-changes] [146111] trunk

2013-03-18 Thread pilgrim
Title: [146111] trunk








Revision 146111
Author pilg...@chromium.org
Date 2013-03-18 13:26:25 -0700 (Mon, 18 Mar 2013)


Log Message
[Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
https://bugs.webkit.org/show_bug.cgi?id=112571

Reviewed by Adam Barth.

Source/Platform:

New top-level enum (not tied to WebFileSystem class) will allow
easier refactoring of filesystem methods within the Platform/
directory. (All changes are behind an #ifdef so we can sync
required changes in embedders.)

* chromium/public/WebFileSystemType.h: new file
(WebKit):

* Platform.gypi:
* chromium/public/WebFileSystem.h:
* chromium/public/WebFileSystemType.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
(WebKit):

Source/WebKit/chromium:

Update function declarations for new WebFileSystemType enum. (All
changes are behind an #ifdef so we can sync required changes in embedders.)

* public/WebCommonWorkerClient.h:
(WebCommonWorkerClient):
(WebKit::WebCommonWorkerClient::openFileSystem):
* public/WebFrame.h:
(WebFrame):
* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::openFileSystem):
(WebKit::WebFrameClient::deleteFileSystem):
* src/LocalFileSystemChromium.cpp:
(WebCore):
(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::deleteFileSystem):
* src/WebFrameImpl.cpp:
(WebKit):
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit::WebFrameImpl::createFileEntry):
* src/WebFrameImpl.h:
(WebFrameImpl):
* src/WebWorkerClientImpl.cpp:
(WebKit):
(WebKit::WebWorkerClientImpl::openFileSystem):
* src/WebWorkerClientImpl.h:
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit):
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
* src/WorkerFileSystemCallbacksBridge.h:
(WorkerFileSystemCallbacksBridge):

Tools:

Update function declarations for new WebFileSystemType enum. (All
changes are behind an #ifdef so we can sync required changes in embedders.)

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::openFileSystem):
(WebViewHost::deleteFileSystem):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/Platform/chromium/public/WebFileSystem.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebCommonWorkerClient.h
trunk/Source/WebKit/chromium/public/WebFrame.h
trunk/Source/WebKit/chromium/public/WebFrameClient.h
trunk/Source/WebKit/chromium/src/LocalFileSystemChromium.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.h
trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.h
trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp
trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h


Added Paths

trunk/Source/Platform/chromium/public/WebFileSystemType.h




Diff

Modified: trunk/Source/Platform/ChangeLog (146110 => 146111)

--- trunk/Source/Platform/ChangeLog	2013-03-18 20:25:46 UTC (rev 146110)
+++ trunk/Source/Platform/ChangeLog	2013-03-18 20:26:25 UTC (rev 146111)
@@ -1,3 +1,23 @@
+2013-03-18  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
+https://bugs.webkit.org/show_bug.cgi?id=112571
+
+Reviewed by Adam Barth.
+
+New top-level enum (not tied to WebFileSystem class) will allow
+easier refactoring of filesystem methods within the Platform/
+directory. (All changes are behind an #ifdef so we can sync
+required changes in embedders.)
+
+* chromium/public/WebFileSystemType.h: new file
+(WebKit):
+
+* Platform.gypi:
+* chromium/public/WebFileSystem.h:
+* chromium/public/WebFileSystemType.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
+(WebKit):
+
 2013-03-17  Dana Jansens  dan...@chromium.org
 
 [chromium] Remove the zoom filter operation ifdef


Modified: trunk/Source/Platform/Platform.gypi (146110 => 146111)

--- trunk/Source/Platform/Platform.gypi	2013-03-18 20:25:46 UTC (rev 146110)
+++ trunk/Source/Platform/Platform.gypi	2013-03-18 20:26:25 UTC (rev 146111)
@@ -60,6 +60,7 @@
 'chromium/public/WebFileSystem.h',
 'chromium/public/WebFileSystemCallbacks.h',
 'chromium/public/WebFileSystemEntry.h',
+'chromium/public/WebFileSystemType.h',
 'chromium/public/WebFileUtilities.h',
 'chromium/public/WebFilterOperation.h',
 'chromium/public/WebFilterOperations.h',


Modified: trunk/Source/Platform/chromium/public/WebFileSystem.h (146110 => 146111)


[webkit-changes] [145452] trunk/Source

2013-03-11 Thread pilgrim
Title: [145452] trunk/Source








Revision 145452
Author pilg...@chromium.org
Date 2013-03-11 18:13:50 -0700 (Mon, 11 Mar 2013)


Log Message
[Chromium] Move WebFileSystemCallbacks to Platform/
https://bugs.webkit.org/show_bug.cgi?id=112049

Reviewed by Adam Barth.

In preparation for moving filesystem-related methods from
WebFrameClient to Platform.

Source/Platform:

* Platform.gypi:
* chromium/public/WebFileError.h: Copied from Source/WebKit/chromium/public/WebFileError.h.
(WebKit):
* chromium/public/WebFileSystemCallbacks.h: Copied from Source/WebKit/chromium/public/WebFileSystemCallbacks.h.
(WebKit):
(WebFileSystemCallbacks):
(WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
(WebKit::WebFileSystemCallbacks::~WebFileSystemCallbacks):
* chromium/public/WebFileSystemEntry.h: Copied from Source/WebKit/chromium/public/WebFileSystemEntry.h.
(WebKit):
(WebKit::WebFileSystemEntry::WebFileSystemEntry):
(WebFileSystemEntry):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebFileError.h:
* public/WebFileSystemCallbacks.h:
* public/WebFileSystemEntry.h:
* public/WebFileWriterClient.h:
* src/AssertMatchingEnums.cpp:
* src/AsyncFileWriterChromium.h:
* src/LocalFileSystemChromium.cpp:
* src/WebFileSystemCallbacksImpl.cpp:
* src/WebFileSystemCallbacksImpl.h:
* src/WebSharedWorkerImpl.cpp:
* src/WebWorkerClientImpl.cpp:
* src/WorkerFileSystemCallbacksBridge.cpp:
* src/WorkerFileSystemCallbacksBridge.h:
* src/WorkerFileWriterCallbacksBridge.h:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/WebFileError.h
trunk/Source/WebKit/chromium/public/WebFileSystemCallbacks.h
trunk/Source/WebKit/chromium/public/WebFileSystemEntry.h
trunk/Source/WebKit/chromium/public/WebFileWriterClient.h
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
trunk/Source/WebKit/chromium/src/AsyncFileWriterChromium.h
trunk/Source/WebKit/chromium/src/LocalFileSystemChromium.cpp
trunk/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp
trunk/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.h
trunk/Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp
trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp
trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h
trunk/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.h


Added Paths

trunk/Source/Platform/chromium/public/WebFileError.h
trunk/Source/Platform/chromium/public/WebFileSystemCallbacks.h
trunk/Source/Platform/chromium/public/WebFileSystemEntry.h




Diff

Modified: trunk/Source/Platform/ChangeLog (145451 => 145452)

--- trunk/Source/Platform/ChangeLog	2013-03-12 01:12:11 UTC (rev 145451)
+++ trunk/Source/Platform/ChangeLog	2013-03-12 01:13:50 UTC (rev 145452)
@@ -1,3 +1,26 @@
+2013-03-11  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move WebFileSystemCallbacks to Platform/
+https://bugs.webkit.org/show_bug.cgi?id=112049
+
+Reviewed by Adam Barth.
+
+In preparation for moving filesystem-related methods from
+WebFrameClient to Platform.
+
+* Platform.gypi:
+* chromium/public/WebFileError.h: Copied from Source/WebKit/chromium/public/WebFileError.h.
+(WebKit):
+* chromium/public/WebFileSystemCallbacks.h: Copied from Source/WebKit/chromium/public/WebFileSystemCallbacks.h.
+(WebKit):
+(WebFileSystemCallbacks):
+(WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
+(WebKit::WebFileSystemCallbacks::~WebFileSystemCallbacks):
+* chromium/public/WebFileSystemEntry.h: Copied from Source/WebKit/chromium/public/WebFileSystemEntry.h.
+(WebKit):
+(WebKit::WebFileSystemEntry::WebFileSystemEntry):
+(WebFileSystemEntry):
+
 2013-03-11  James Robinson  jam...@chromium.org
 
 [chromium] Use SkMatrix44 instead of WebTransformationMatrix in animation APIs


Modified: trunk/Source/Platform/Platform.gypi (145451 => 145452)

--- trunk/Source/Platform/Platform.gypi	2013-03-12 01:12:11 UTC (rev 145451)
+++ trunk/Source/Platform/Platform.gypi	2013-03-12 01:13:50 UTC (rev 145452)
@@ -55,8 +55,11 @@
 'chromium/public/WebDragData.h',
 'chromium/public/WebExternalTextureLayer.h',
 'chromium/public/WebExternalTextureLayerClient.h',
+'chromium/public/WebFileError.h',
 'chromium/public/WebFileInfo.h',
 'chromium/public/WebFileSystem.h',
+'chromium/public/WebFileSystemCallbacks.h',
+'chromium/public/WebFileSystemEntry.h',
 'chromium/public/WebFileUtilities.h',
 'chromium/public/WebFilterOperation.h',
 'chromium/public/WebFilterOperations.h',


Copied: trunk/Source/Platform/chromium/public/WebFileError.h (from rev 145451, trunk/Source/WebKit/chromium/public/WebFileError.h) (0 =&g

[webkit-changes] [145099] trunk/Source/WebKit/chromium

2013-03-07 Thread pilgrim
Title: [145099] trunk/Source/WebKit/chromium








Revision 145099
Author pilg...@chromium.org
Date 2013-03-07 10:37:33 -0800 (Thu, 07 Mar 2013)


Log Message
[Chromium] Update some #includes for WebVideoFrame.h
https://bugs.webkit.org/show_bug.cgi?id=111739

Reviewed by James Robinson.

In anticipation of removing WebVideoFrame.h from WK/chromium/public/.

* public/WebMediaPlayer.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebMediaPlayer.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (145098 => 145099)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-07 18:35:02 UTC (rev 145098)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-07 18:37:33 UTC (rev 145099)
@@ -1,3 +1,14 @@
+2013-03-07  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Update some #includes for WebVideoFrame.h
+https://bugs.webkit.org/show_bug.cgi?id=111739
+
+Reviewed by James Robinson.
+
+In anticipation of removing WebVideoFrame.h from WK/chromium/public/.
+
+* public/WebMediaPlayer.h:
+
 2013-03-07  Dana Jansens  dan...@chromium.org
 
 [chromium] Remove WebView's sharedGraphicsContext3D method.


Modified: trunk/Source/WebKit/chromium/public/WebMediaPlayer.h (145098 => 145099)

--- trunk/Source/WebKit/chromium/public/WebMediaPlayer.h	2013-03-07 18:35:02 UTC (rev 145098)
+++ trunk/Source/WebKit/chromium/public/WebMediaPlayer.h	2013-03-07 18:37:33 UTC (rev 145099)
@@ -33,9 +33,9 @@
 
 #include ../../../Platform/chromium/public/WebCanvas.h
 #include ../../../Platform/chromium/public/WebString.h
+#include ../../../Platform/chromium/public/WebVideoFrame.h
 #include WebMediaSource.h
 #include WebTimeRange.h
-#include WebVideoFrame.h
 
 namespace WebKit {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [145102] trunk/Source/WebKit/chromium

2013-03-07 Thread pilgrim
Title: [145102] trunk/Source/WebKit/chromium








Revision 145102
Author pilg...@chromium.org
Date 2013-03-07 10:47:11 -0800 (Thu, 07 Mar 2013)


Log Message
[Chromium] Remove WK/chromium/public/WebWorkerRunLoop.h
https://bugs.webkit.org/show_bug.cgi?id=111740

Reviewed by James Robinson.

No longer needed; all references have been updated to new version
in top-level Platform/ directory.

* public/WebWorkerRunLoop.h: Removed.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog


Removed Paths

trunk/Source/WebKit/chromium/public/WebWorkerRunLoop.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (145101 => 145102)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-07 18:45:21 UTC (rev 145101)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-07 18:47:11 UTC (rev 145102)
@@ -1,3 +1,15 @@
+2013-03-07  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove WK/chromium/public/WebWorkerRunLoop.h
+https://bugs.webkit.org/show_bug.cgi?id=111740
+
+Reviewed by James Robinson.
+
+No longer needed; all references have been updated to new version
+in top-level Platform/ directory.
+
+* public/WebWorkerRunLoop.h: Removed.
+
 2013-03-07  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed.  Rolled Chromium DEPS to r186592.  Requested by


Deleted: trunk/Source/WebKit/chromium/public/WebWorkerRunLoop.h (145101 => 145102)

--- trunk/Source/WebKit/chromium/public/WebWorkerRunLoop.h	2013-03-07 18:45:21 UTC (rev 145101)
+++ trunk/Source/WebKit/chromium/public/WebWorkerRunLoop.h	2013-03-07 18:47:11 UTC (rev 145102)
@@ -1,25 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
- * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
- * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include ../../../Platform/chromium/public/WebWorkerRunLoop.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [145108] trunk/Source/WebKit/chromium

2013-03-07 Thread pilgrim
Title: [145108] trunk/Source/WebKit/chromium








Revision 145108
Author pilg...@chromium.org
Date 2013-03-07 11:13:39 -0800 (Thu, 07 Mar 2013)


Log Message
[Chromium] Update some #includes for WebFileInfo.h in WK/chromium/src/
https://bugs.webkit.org/show_bug.cgi?id=111741

Reviewed by James Robinson.

In preparation for removing WK/chromium/public/WebFileInfo.h.

* src/AssertMatchingEnums.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (145107 => 145108)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-07 19:07:20 UTC (rev 145107)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-07 19:13:39 UTC (rev 145108)
@@ -1,5 +1,16 @@
 2013-03-07  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Update some #includes for WebFileInfo.h in WK/chromium/src/
+https://bugs.webkit.org/show_bug.cgi?id=111741
+
+Reviewed by James Robinson.
+
+In preparation for removing WK/chromium/public/WebFileInfo.h.
+
+* src/AssertMatchingEnums.cpp:
+
+2013-03-07  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Remove WK/chromium/public/WebWorkerRunLoop.h
 https://bugs.webkit.org/show_bug.cgi?id=111740
 


Modified: trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp (145107 => 145108)

--- trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp	2013-03-07 19:07:20 UTC (rev 145107)
+++ trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp	2013-03-07 19:13:39 UTC (rev 145108)
@@ -90,7 +90,6 @@
 #include WebCursorInfo.h
 #include WebEditingAction.h
 #include WebFileError.h
-#include WebFileInfo.h
 #include WebFontDescription.h
 #if ENABLE(REQUEST_AUTOCOMPLETE)
 #include WebFormElement.h
@@ -121,6 +120,7 @@
 #include WebTextCheckingType.h
 #include WebView.h
 #include public/WebClipboard.h
+#include public/WebFileInfo.h
 #include public/WebFileSystem.h
 #include public/WebFilterOperation.h
 #include public/WebMediaStreamSource.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [145109] trunk/Source/WebKit/chromium

2013-03-07 Thread pilgrim
Title: [145109] trunk/Source/WebKit/chromium








Revision 145109
Author pilg...@chromium.org
Date 2013-03-07 11:18:05 -0800 (Thu, 07 Mar 2013)


Log Message
[Chromium] Remove WK/chromium/public/WebStorageArea.h
https://bugs.webkit.org/show_bug.cgi?id=111744

Reviewed by James Robinson.

File moved to new Platform/ directory. All references have already
been updated (including downstream).

* public/WebStorageArea.h: Removed.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog


Removed Paths

trunk/Source/WebKit/chromium/public/WebStorageArea.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (145108 => 145109)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-07 19:13:39 UTC (rev 145108)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-07 19:18:05 UTC (rev 145109)
@@ -1,5 +1,17 @@
 2013-03-07  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Remove WK/chromium/public/WebStorageArea.h
+https://bugs.webkit.org/show_bug.cgi?id=111744
+
+Reviewed by James Robinson.
+
+File moved to new Platform/ directory. All references have already
+been updated (including downstream).
+
+* public/WebStorageArea.h: Removed.
+
+2013-03-07  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Update some #includes for WebFileInfo.h in WK/chromium/src/
 https://bugs.webkit.org/show_bug.cgi?id=111741
 


Deleted: trunk/Source/WebKit/chromium/public/WebStorageArea.h (145108 => 145109)

--- trunk/Source/WebKit/chromium/public/WebStorageArea.h	2013-03-07 19:13:39 UTC (rev 145108)
+++ trunk/Source/WebKit/chromium/public/WebStorageArea.h	2013-03-07 19:18:05 UTC (rev 145109)
@@ -1,31 +0,0 @@
-/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include ../../../Platform/chromium/public/WebStorageArea.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [145125] trunk/Source/WebKit/chromium

2013-03-07 Thread pilgrim
Title: [145125] trunk/Source/WebKit/chromium








Revision 145125
Author pilg...@chromium.org
Date 2013-03-07 13:18:53 -0800 (Thu, 07 Mar 2013)


Log Message
[Chromium] Update some #includes for WebMessagePortChannel.h
https://bugs.webkit.org/show_bug.cgi?id=111752

Reviewed by James Robinson.

In anticipation of removing
WK/chromium/public/WebMessagePortChannel.h (once all downstream
references have been updated)

* public/WebDOMMessageEvent.h:
* public/WebFrame.h:
* public/WebSharedWorkerClient.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h
trunk/Source/WebKit/chromium/public/WebFrame.h
trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (145124 => 145125)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-07 21:08:21 UTC (rev 145124)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-07 21:18:53 UTC (rev 145125)
@@ -1,5 +1,20 @@
 2013-03-07  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Update some #includes for WebMessagePortChannel.h
+https://bugs.webkit.org/show_bug.cgi?id=111752
+
+Reviewed by James Robinson.
+
+In anticipation of removing
+WK/chromium/public/WebMessagePortChannel.h (once all downstream
+references have been updated)
+
+* public/WebDOMMessageEvent.h:
+* public/WebFrame.h:
+* public/WebSharedWorkerClient.h:
+
+2013-03-07  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Remove WK/chromium/public/WebStorageArea.h
 https://bugs.webkit.org/show_bug.cgi?id=111744
 


Modified: trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h (145124 => 145125)

--- trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h	2013-03-07 21:08:21 UTC (rev 145124)
+++ trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h	2013-03-07 21:18:53 UTC (rev 145125)
@@ -30,8 +30,8 @@
 #ifndef WebDOMMessageEvent_h
 #define WebDOMMessageEvent_h
 
+#include ../../../Platform/chromium/public/WebMessagePortChannel.h
 #include WebDOMEvent.h
-#include WebMessagePortChannel.h
 #include WebSerializedScriptValue.h
 
 #if WEBKIT_IMPLEMENTATION


Modified: trunk/Source/WebKit/chromium/public/WebFrame.h (145124 => 145125)

--- trunk/Source/WebKit/chromium/public/WebFrame.h	2013-03-07 21:08:21 UTC (rev 145124)
+++ trunk/Source/WebKit/chromium/public/WebFrame.h	2013-03-07 21:18:53 UTC (rev 145125)
@@ -33,10 +33,10 @@
 
 #include ../../../Platform/chromium/public/WebCanvas.h
 #include ../../../Platform/chromium/public/WebFileSystem.h
+#include ../../../Platform/chromium/public/WebMessagePortChannel.h
 #include ../../../Platform/chromium/public/WebReferrerPolicy.h
 #include ../../../Platform/chromium/public/WebURL.h
 #include WebIconURL.h
-#include WebMessagePortChannel.h
 #include WebNode.h
 #include WebURLLoaderOptions.h
 


Modified: trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h (145124 => 145125)

--- trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h	2013-03-07 21:08:21 UTC (rev 145124)
+++ trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h	2013-03-07 21:18:53 UTC (rev 145125)
@@ -31,8 +31,8 @@
 #ifndef WebSharedWorkerClient_h
 #define WebSharedWorkerClient_h
 
+#include ../../../Platform/chromium/public/WebMessagePortChannel.h
 #include WebCommonWorkerClient.h
-#include WebMessagePortChannel.h
 
 namespace WebKit {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [145144] trunk/Tools

2013-03-07 Thread pilgrim
Title: [145144] trunk/Tools








Revision 145144
Author pilg...@chromium.org
Date 2013-03-07 15:42:31 -0800 (Thu, 07 Mar 2013)


Log Message
[Chromium] Update #include for WebStorageNamespace.h
https://bugs.webkit.org/show_bug.cgi?id=111748

Reviewed by Adam Barth.

In anticipation of removing
WK/chromium/public/WebStorageNamespace.h (once downstream
references have been updated)

* DumpRenderTree/chromium/WebViewHost.cpp:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp




Diff

Modified: trunk/Tools/ChangeLog (145143 => 145144)

--- trunk/Tools/ChangeLog	2013-03-07 23:11:22 UTC (rev 145143)
+++ trunk/Tools/ChangeLog	2013-03-07 23:42:31 UTC (rev 145144)
@@ -1,3 +1,16 @@
+2013-03-07  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Update #include for WebStorageNamespace.h
+https://bugs.webkit.org/show_bug.cgi?id=111748
+
+Reviewed by Adam Barth.
+
+In anticipation of removing
+WK/chromium/public/WebStorageNamespace.h (once downstream
+references have been updated)
+
+* DumpRenderTree/chromium/WebViewHost.cpp:
+
 2013-03-07  Dirk Pranke  dpra...@chromium.org
 
 run-perf-tests fails due to svn_revision not working on a pure git clone


Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp (145143 => 145144)

--- trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp	2013-03-07 23:11:22 UTC (rev 145143)
+++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp	2013-03-07 23:42:31 UTC (rev 145144)
@@ -53,7 +53,6 @@
 #include WebRange.h
 #include WebScreenInfo.h
 #include WebSerializedScriptValue.h
-#include WebStorageNamespace.h
 #include WebUserGestureIndicator.h
 #include WebView.h
 #include WebWindowFeatures.h
@@ -67,6 +66,7 @@
 #include public/WebDragData.h
 #include public/WebRect.h
 #include public/WebSize.h
+#include public/WebStorageNamespace.h
 #include public/WebThread.h
 #include public/WebURLRequest.h
 #include public/WebURLResponse.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [144198] trunk/Source/Platform

2013-02-27 Thread pilgrim
Title: [144198] trunk/Source/Platform








Revision 144198
Author pilg...@chromium.org
Date 2013-02-27 09:02:20 -0800 (Wed, 27 Feb 2013)


Log Message
[Chromium] Remove unused WebKitPlatformSupport class
https://bugs.webkit.org/show_bug.cgi?id=110982

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

* chromium/public/Platform.h:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/Platform.h




Diff

Modified: trunk/Source/Platform/ChangeLog (144197 => 144198)

--- trunk/Source/Platform/ChangeLog	2013-02-27 16:59:21 UTC (rev 144197)
+++ trunk/Source/Platform/ChangeLog	2013-02-27 17:02:20 UTC (rev 144198)
@@ -1,3 +1,14 @@
+2013-02-27  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove unused WebKitPlatformSupport class
+https://bugs.webkit.org/show_bug.cgi?id=110982
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 82948.
+
+* chromium/public/Platform.h:
+
 2013-02-26  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r144129.


Modified: trunk/Source/Platform/chromium/public/Platform.h (144197 => 144198)

--- trunk/Source/Platform/chromium/public/Platform.h	2013-02-27 16:59:21 UTC (rev 144197)
+++ trunk/Source/Platform/chromium/public/Platform.h	2013-02-27 17:02:20 UTC (rev 144198)
@@ -501,11 +501,6 @@
 virtual ~Platform() { }
 };
 
-class WebKitPlatformSupport : public Platform {
-protected:
-~WebKitPlatformSupport() { }
-};
-
 } // namespace WebKit
 
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [143846] trunk/Source/WebKit/chromium

2013-02-23 Thread pilgrim
Title: [143846] trunk/Source/WebKit/chromium








Revision 143846
Author pilg...@chromium.org
Date 2013-02-23 11:57:05 -0800 (Sat, 23 Feb 2013)


Log Message
[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110605

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

* public/WebKit.h:
(WebKit):
* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebKit.h
trunk/Source/WebKit/chromium/src/WebKit.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (143845 => 143846)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-23 18:37:50 UTC (rev 143845)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-23 19:57:05 UTC (rev 143846)
@@ -1,3 +1,19 @@
+2013-02-23  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
+https://bugs.webkit.org/show_bug.cgi?id=110605
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 82948.
+
+* public/WebKit.h:
+(WebKit):
+* src/WebKit.cpp:
+(WebKit::initialize):
+(WebKit::initializeWithoutV8):
+(WebKit::webKitPlatformSupport):
+
 2013-02-22  David Dorwin  ddor...@chromium.org
 
 [chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached


Modified: trunk/Source/WebKit/chromium/public/WebKit.h (143845 => 143846)

--- trunk/Source/WebKit/chromium/public/WebKit.h	2013-02-23 18:37:50 UTC (rev 143845)
+++ trunk/Source/WebKit/chromium/public/WebKit.h	2013-02-23 19:57:05 UTC (rev 143846)
@@ -31,32 +31,30 @@
 #ifndef WebKit_h
 #define WebKit_h
 
-#include ../../../Platform/chromium/public/WebCommon.h
+#include ../../../Platform/chromium/public/Platform.h
 
 namespace WebKit {
 
-class WebKitPlatformSupport;
-
 // Must be called on the thread that will be the main WebKit thread before
-// using any other WebKit APIs. The provided WebKitPlatformSupport; must be
+// using any other WebKit APIs. The provided Platform; must be
 // non-null and must remain valid until the current thread calls shutdown.
-WEBKIT_EXPORT void initialize(WebKitPlatformSupport*);
+WEBKIT_EXPORT void initialize(Platform*);
 
 // Must be called on the thread that will be the main WebKit thread before
-// using any other WebKit APIs. The provided WebKitPlatformSupport; must be
+// using any other WebKit APIs. The provided Platform; must be
 // non-null and must remain valid until the current thread calls shutdown.
 //
 // This is a special variant of initialize that does not intitialize V8.
-WEBKIT_EXPORT void initializeWithoutV8(WebKitPlatformSupport*);
+WEBKIT_EXPORT void initializeWithoutV8(Platform*);
 
-// Once shutdown, the WebKitPlatformSupport passed to initialize will no longer
+// Once shutdown, the Platform passed to initialize will no longer
 // be accessed. No other WebKit objects should be in use when this function is
 // called. Any background threads created by WebKit are promised to be
 // terminated by the time this function returns.
 WEBKIT_EXPORT void shutdown();
 
-// Returns the WebKitPlatformSupport instance passed to initialize.
-WEBKIT_EXPORT WebKitPlatformSupport* webKitPlatformSupport();
+// Returns the Platform instance passed to initialize.
+WEBKIT_EXPORT Platform* webKitPlatformSupport();
 
 // Alters the rendering of content to conform to a fixed set of rules.
 WEBKIT_EXPORT void setLayoutTestMode(bool);


Modified: trunk/Source/WebKit/chromium/src/WebKit.cpp (143845 => 143846)

--- trunk/Source/WebKit/chromium/src/WebKit.cpp	2013-02-23 18:37:50 UTC (rev 143845)
+++ trunk/Source/WebKit/chromium/src/WebKit.cpp	2013-02-23 19:57:05 UTC (rev 143846)
@@ -91,7 +91,7 @@
 // Doing so may cause hard to reproduce crashes.
 static bool s_webKitInitialized = false;
 
-static WebKitPlatformSupport* s_webKitPlatformSupport = 0;
+static Platform* s_webKitPlatformSupport = 0;
 
 static bool generateEntropy(unsigned char* buffer, size_t length)
 {
@@ -109,7 +109,7 @@
 }
 #endif
 
-void initialize(WebKitPlatformSupport* webKitPlatformSupport)
+void initialize(Platform* webKitPlatformSupport)
 {
 initializeWithoutV8(webKitPlatformSupport);
 
@@ -128,7 +128,7 @@
 }
 }
 
-void initializeWithoutV8(WebKitPlatformSupport* webKitPlatformSupport)
+void initializeWithoutV8(Platform* webKitPlatformSupport)
 {
 ASSERT(!s_webKitInitialized);
 s_webKitInitialized = true;
@@ -189,7 +189,7 @@
 WebPrerenderingSupport::shutdown();
 }
 
-WebKitPlatformSupport* webKitPlatformSupport()
+Platform* webKitPlatformSupport()
 {
 return s_webKitPlatformSupport;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman

[webkit-changes] [143734] trunk/Source/WebKit/chromium

2013-02-22 Thread pilgrim
Title: [143734] trunk/Source/WebKit/chromium








Revision 143734
Author pilg...@chromium.org
Date 2013-02-22 08:41:20 -0800 (Fri, 22 Feb 2013)


Log Message
[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110605

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

* public/WebKit.h:
(WebKit):
* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebKit.h
trunk/Source/WebKit/chromium/src/WebKit.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (143733 => 143734)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-22 16:33:54 UTC (rev 143733)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-22 16:41:20 UTC (rev 143734)
@@ -1,3 +1,19 @@
+2013-02-22  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
+https://bugs.webkit.org/show_bug.cgi?id=110605
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 82948.
+
+* public/WebKit.h:
+(WebKit):
+* src/WebKit.cpp:
+(WebKit::initialize):
+(WebKit::initializeWithoutV8):
+(WebKit::webKitPlatformSupport):
+
 2013-02-22  Andrey Kosyakov  ca...@chromium.org
 
 Web Inspector: [Chromium] add a browser test for frames on timeline


Modified: trunk/Source/WebKit/chromium/public/WebKit.h (143733 => 143734)

--- trunk/Source/WebKit/chromium/public/WebKit.h	2013-02-22 16:33:54 UTC (rev 143733)
+++ trunk/Source/WebKit/chromium/public/WebKit.h	2013-02-22 16:41:20 UTC (rev 143734)
@@ -35,28 +35,28 @@
 
 namespace WebKit {
 
-class WebKitPlatformSupport;
+class Platform;
 
 // Must be called on the thread that will be the main WebKit thread before
-// using any other WebKit APIs. The provided WebKitPlatformSupport; must be
+// using any other WebKit APIs. The provided Platform; must be
 // non-null and must remain valid until the current thread calls shutdown.
-WEBKIT_EXPORT void initialize(WebKitPlatformSupport*);
+WEBKIT_EXPORT void initialize(Platform*);
 
 // Must be called on the thread that will be the main WebKit thread before
-// using any other WebKit APIs. The provided WebKitPlatformSupport; must be
+// using any other WebKit APIs. The provided Platform; must be
 // non-null and must remain valid until the current thread calls shutdown.
 //
 // This is a special variant of initialize that does not intitialize V8.
-WEBKIT_EXPORT void initializeWithoutV8(WebKitPlatformSupport*);
+WEBKIT_EXPORT void initializeWithoutV8(Platform*);
 
-// Once shutdown, the WebKitPlatformSupport passed to initialize will no longer
+// Once shutdown, the Platform passed to initialize will no longer
 // be accessed. No other WebKit objects should be in use when this function is
 // called. Any background threads created by WebKit are promised to be
 // terminated by the time this function returns.
 WEBKIT_EXPORT void shutdown();
 
-// Returns the WebKitPlatformSupport instance passed to initialize.
-WEBKIT_EXPORT WebKitPlatformSupport* webKitPlatformSupport();
+// Returns the Platform instance passed to initialize.
+WEBKIT_EXPORT Platform* webKitPlatformSupport();
 
 // Alters the rendering of content to conform to a fixed set of rules.
 WEBKIT_EXPORT void setLayoutTestMode(bool);


Modified: trunk/Source/WebKit/chromium/src/WebKit.cpp (143733 => 143734)

--- trunk/Source/WebKit/chromium/src/WebKit.cpp	2013-02-22 16:33:54 UTC (rev 143733)
+++ trunk/Source/WebKit/chromium/src/WebKit.cpp	2013-02-22 16:41:20 UTC (rev 143734)
@@ -91,7 +91,7 @@
 // Doing so may cause hard to reproduce crashes.
 static bool s_webKitInitialized = false;
 
-static WebKitPlatformSupport* s_webKitPlatformSupport = 0;
+static Platform* s_webKitPlatformSupport = 0;
 
 static bool generateEntropy(unsigned char* buffer, size_t length)
 {
@@ -109,7 +109,7 @@
 }
 #endif
 
-void initialize(WebKitPlatformSupport* webKitPlatformSupport)
+void initialize(Platform* webKitPlatformSupport)
 {
 initializeWithoutV8(webKitPlatformSupport);
 
@@ -128,7 +128,7 @@
 }
 }
 
-void initializeWithoutV8(WebKitPlatformSupport* webKitPlatformSupport)
+void initializeWithoutV8(Platform* webKitPlatformSupport)
 {
 ASSERT(!s_webKitInitialized);
 s_webKitInitialized = true;
@@ -189,7 +189,7 @@
 WebPrerenderingSupport::shutdown();
 }
 
-WebKitPlatformSupport* webKitPlatformSupport()
+Platform* webKitPlatformSupport()
 {
 return s_webKitPlatformSupport;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [143674] trunk/Source/WebKit/chromium

2013-02-21 Thread pilgrim
Title: [143674] trunk/Source/WebKit/chromium








Revision 143674
Author pilg...@chromium.org
Date 2013-02-21 17:40:21 -0800 (Thu, 21 Feb 2013)


Log Message
[Chromium] Remove chromium/public/platform directory
https://bugs.webkit.org/show_bug.cgi?id=110471

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

* WebKit.gyp:
* public/platform: Removed.
* public/platform/WebKitPlatformSupport.h: Removed.
* public/platform/android: Removed.
* public/platform/default: Removed.
* public/platform/linux: Removed.
* public/platform/mac: Removed.
* public/platform/win: Removed.
* src/WebKit.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/WebKit.cpp


Removed Paths

trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (143673 => 143674)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-22 01:27:56 UTC (rev 143673)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-22 01:40:21 UTC (rev 143674)
@@ -1,3 +1,22 @@
+2013-02-21  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove chromium/public/platform directory
+https://bugs.webkit.org/show_bug.cgi?id=110471
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 82948.
+
+* WebKit.gyp:
+* public/platform: Removed.
+* public/platform/WebKitPlatformSupport.h: Removed.
+* public/platform/android: Removed.
+* public/platform/default: Removed.
+* public/platform/linux: Removed.
+* public/platform/mac: Removed.
+* public/platform/win: Removed.
+* src/WebKit.cpp:
+
 2013-02-21  Dirk Pranke  dpra...@chromium.org
 
 [chromium] support the lucid version of freetype on precise in DRT


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (143673 => 143674)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2013-02-22 01:27:56 UTC (rev 143673)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2013-02-22 01:40:21 UTC (rev 143674)
@@ -291,7 +291,6 @@
 'public/mac/WebSandboxSupport.h',
 'public/mac/WebScreenInfoFactory.h',
 'public/mac/WebSubstringUtil.h',
-'public/platform/WebKitPlatformSupport.h',
 'public/win/WebInputEventFactory.h',
 'public/win/WebSandboxSupport.h',
 'public/win/WebScreenInfoFactory.h',


Deleted: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (143673 => 143674)

--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-22 01:27:56 UTC (rev 143673)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-22 01:40:21 UTC (rev 143674)
@@ -1,31 +0,0 @@
-/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include ../../../../Platform/chromium/public/Platform.h


Modified: trunk/Source/WebKit/chromium/src/WebKit.cpp (143673 => 143674)

--- trunk/Source/WebKit/chromium/src/WebKit.cpp	2013-02-22 01:27:56 UTC (rev 143673)
+++ trunk/Source/WebKit/chromium/src/WebKit.cpp	2013-02-22 01:40:21 UTC (rev 143674)
@@ -42,7 +42,6 @@
 #include V8Binding.h
 #include V8RecursionScope.h
 #include WebSocket.h
-#include platform/WebKitPlatformSupport.h
 #include v8.h
 #include public/Platform.h
 #include public/WebPrerender

[webkit-changes] [143473] trunk/Source/WebKit/chromium

2013-02-20 Thread pilgrim
Title: [143473] trunk/Source/WebKit/chromium








Revision 143473
Author pilg...@chromium.org
Date 2013-02-20 10:21:39 -0800 (Wed, 20 Feb 2013)


Log Message
[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Adam Barth.

Now that https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
(WebKit):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (143472 => 143473)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-20 18:10:22 UTC (rev 143472)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-20 18:21:39 UTC (rev 143473)
@@ -1,3 +1,20 @@
+2013-02-20  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove idbFactory from WebKitPlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=106457
+
+Reviewed by Adam Barth.
+
+Now that https://codereview.chromium.org/12230054 has landed, the
+idbFactory method is no longer needed. (Embedders must now call
+the new setIDBFactory method upon initialization.) Part of a
+larger refactoring series; see tracking bug 82948.
+
+* public/platform/WebKitPlatformSupport.h:
+(WebKit):
+* src/IDBFactoryBackendProxy.cpp:
+(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
+
 2013-02-20  Mark Lam  mark@apple.com
 
 Rename DatabaseBackend to DatabaseBackendBase.


Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (143472 => 143473)

--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-20 18:10:22 UTC (rev 143472)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-20 18:21:39 UTC (rev 143473)
@@ -35,15 +35,7 @@
 
 namespace WebKit {
 
-class WebIDBFactory; // FIXME: Does this belong in platform?
-
-// FIXME: Eventually all these API will need to move to WebKit::Platform.
 class WebKitPlatformSupport : public Platform {
-public:
-// Indexed Database 
-
-virtual WebIDBFactory* idbFactory() { return 0; }
-
 protected:
 ~WebKitPlatformSupport() { }
 };


Modified: trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp (143472 => 143473)

--- trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp	2013-02-20 18:10:22 UTC (rev 143472)
+++ trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp	2013-02-20 18:21:39 UTC (rev 143473)
@@ -53,7 +53,6 @@
 #include WorkerLoaderProxy.h
 #include WorkerScriptController.h
 #include WorkerThread.h
-#include platform/WebKitPlatformSupport.h
 #include public/WebVector.h
 
 
@@ -75,10 +74,8 @@
 
 IDBFactoryBackendProxy::IDBFactoryBackendProxy()
 {
-if (s_webIDBFactory)
-m_webIDBFactory = s_webIDBFactory;
-else
-m_webIDBFactory = webKitPlatformSupport()-idbFactory();
+ASSERT(s_webIDBFactory);
+m_webIDBFactory = s_webIDBFactory;
 }
 
 IDBFactoryBackendProxy::~IDBFactoryBackendProxy()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [143496] trunk/Source

2013-02-20 Thread pilgrim
Title: [143496] trunk/Source








Revision 143496
Author pilg...@chromium.org
Date 2013-02-20 13:31:15 -0800 (Wed, 20 Feb 2013)


Log Message
[Chromium] Move WebKitPlatformSupport declaration to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=110262

Reviewed by Adam Barth.

In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.

Source/Platform:

* chromium/public/Platform.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/Platform.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h




Diff

Modified: trunk/Source/Platform/ChangeLog (143495 => 143496)

--- trunk/Source/Platform/ChangeLog	2013-02-20 21:28:08 UTC (rev 143495)
+++ trunk/Source/Platform/ChangeLog	2013-02-20 21:31:15 UTC (rev 143496)
@@ -1,3 +1,19 @@
+2013-02-20  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move WebKitPlatformSupport declaration to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=110262
+
+Reviewed by Adam Barth.
+
+In preparation for removing WebKitPlatformSupport.h entirely (once
+downstream references to that file have been updated). Part of a
+larger refactoring series; see tracking bug 82948.
+
+* chromium/public/Platform.h:
+(WebKitPlatformSupport):
+(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
+(WebKit):
+
 2013-02-19  Adrienne Walker  e...@chromium.org
 
 Unreviewed, rolling out r143382 and r143401.


Modified: trunk/Source/Platform/chromium/public/Platform.h (143495 => 143496)

--- trunk/Source/Platform/chromium/public/Platform.h	2013-02-20 21:28:08 UTC (rev 143495)
+++ trunk/Source/Platform/chromium/public/Platform.h	2013-02-20 21:31:15 UTC (rev 143496)
@@ -485,6 +485,11 @@
 virtual ~Platform() { }
 };
 
+class WebKitPlatformSupport : public Platform {
+protected:
+~WebKitPlatformSupport() { }
+};
+
 } // namespace WebKit
 
 #endif


Modified: trunk/Source/WebKit/chromium/ChangeLog (143495 => 143496)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-20 21:28:08 UTC (rev 143495)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-20 21:31:15 UTC (rev 143496)
@@ -1,5 +1,18 @@
 2013-02-20  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Move WebKitPlatformSupport declaration to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=110262
+
+Reviewed by Adam Barth.
+
+In preparation for removing WebKitPlatformSupport.h entirely (once
+downstream references to that file have been updated). Part of a
+larger refactoring series; see tracking bug 82948.
+
+* public/platform/WebKitPlatformSupport.h:
+
+2013-02-20  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Remove idbFactory from WebKitPlatformSupport
 https://bugs.webkit.org/show_bug.cgi?id=106457
 


Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (143495 => 143496)

--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-20 21:28:08 UTC (rev 143495)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-20 21:31:15 UTC (rev 143496)
@@ -28,18 +28,4 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WebKitPlatformSupport_h
-#define WebKitPlatformSupport_h
-
 #include ../../../../Platform/chromium/public/Platform.h
-
-namespace WebKit {
-
-class WebKitPlatformSupport : public Platform {
-protected:
-~WebKitPlatformSupport() { }
-};
-
-} // namespace WebKit
-
-#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [143382] trunk/Source/WebKit/chromium

2013-02-19 Thread pilgrim
Title: [143382] trunk/Source/WebKit/chromium








Revision 143382
Author pilg...@chromium.org
Date 2013-02-19 14:02:47 -0800 (Tue, 19 Feb 2013)


Log Message
[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Kentaro Hara.

Now that https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
(WebKit):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (143381 => 143382)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-19 21:53:57 UTC (rev 143381)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-19 22:02:47 UTC (rev 143382)
@@ -1,3 +1,20 @@
+2013-02-19  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove idbFactory from WebKitPlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=106457
+
+Reviewed by Kentaro Hara.
+
+Now that https://codereview.chromium.org/12230054 has landed, the
+idbFactory method is no longer needed. (Embedders must now call
+the new setIDBFactory method upon initialization.) Part of a
+larger refactoring series; see tracking bug 82948.
+
+* public/platform/WebKitPlatformSupport.h:
+(WebKit):
+* src/IDBFactoryBackendProxy.cpp:
+(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
+
 2013-02-19  Alexandre Elias  ael...@chromium.org
 
 [chromium] Fix races in double-tap zoom minimum scale policy


Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (143381 => 143382)

--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-19 21:53:57 UTC (rev 143381)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-19 22:02:47 UTC (rev 143382)
@@ -35,15 +35,7 @@
 
 namespace WebKit {
 
-class WebIDBFactory; // FIXME: Does this belong in platform?
-
-// FIXME: Eventually all these API will need to move to WebKit::Platform.
 class WebKitPlatformSupport : public Platform {
-public:
-// Indexed Database 
-
-virtual WebIDBFactory* idbFactory() { return 0; }
-
 protected:
 ~WebKitPlatformSupport() { }
 };


Modified: trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp (143381 => 143382)

--- trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp	2013-02-19 21:53:57 UTC (rev 143381)
+++ trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp	2013-02-19 22:02:47 UTC (rev 143382)
@@ -53,7 +53,6 @@
 #include WorkerLoaderProxy.h
 #include WorkerScriptController.h
 #include WorkerThread.h
-#include platform/WebKitPlatformSupport.h
 #include public/WebVector.h
 
 
@@ -75,10 +74,8 @@
 
 IDBFactoryBackendProxy::IDBFactoryBackendProxy()
 {
-if (s_webIDBFactory)
-m_webIDBFactory = s_webIDBFactory;
-else
-m_webIDBFactory = webKitPlatformSupport()-idbFactory();
+ASSERT(s_webIDBFactory);
+m_webIDBFactory = s_webIDBFactory;
 }
 
 IDBFactoryBackendProxy::~IDBFactoryBackendProxy()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [143401] trunk/Source

2013-02-19 Thread pilgrim
Title: [143401] trunk/Source








Revision 143401
Author pilg...@chromium.org
Date 2013-02-19 16:14:25 -0800 (Tue, 19 Feb 2013)


Log Message
[Chromium] Move WebKitPlatformSupport declaration to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=110262

Reviewed by Adam Barth.

In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.

Source/Platform:

* chromium/public/Platform.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/Platform.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h




Diff

Modified: trunk/Source/Platform/ChangeLog (143400 => 143401)

--- trunk/Source/Platform/ChangeLog	2013-02-20 00:13:26 UTC (rev 143400)
+++ trunk/Source/Platform/ChangeLog	2013-02-20 00:14:25 UTC (rev 143401)
@@ -1,3 +1,19 @@
+2013-02-19  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move WebKitPlatformSupport declaration to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=110262
+
+Reviewed by Adam Barth.
+
+In preparation for removing WebKitPlatformSupport.h entirely (once
+downstream references to that file have been updated). Part of a
+larger refactoring series; see tracking bug 82948.
+
+* chromium/public/Platform.h:
+(WebKitPlatformSupport):
+(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
+(WebKit):
+
 2013-02-19  Tommy Widenflycht  tom...@google.com
 
 WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter


Modified: trunk/Source/Platform/chromium/public/Platform.h (143400 => 143401)

--- trunk/Source/Platform/chromium/public/Platform.h	2013-02-20 00:13:26 UTC (rev 143400)
+++ trunk/Source/Platform/chromium/public/Platform.h	2013-02-20 00:14:25 UTC (rev 143401)
@@ -485,6 +485,11 @@
 virtual ~Platform() { }
 };
 
+class WebKitPlatformSupport : public Platform {
+protected:
+~WebKitPlatformSupport() { }
+};
+
 } // namespace WebKit
 
 #endif


Modified: trunk/Source/WebKit/chromium/ChangeLog (143400 => 143401)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-20 00:13:26 UTC (rev 143400)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-20 00:14:25 UTC (rev 143401)
@@ -1,5 +1,18 @@
 2013-02-19  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Move WebKitPlatformSupport declaration to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=110262
+
+Reviewed by Adam Barth.
+
+In preparation for removing WebKitPlatformSupport.h entirely (once
+downstream references to that file have been updated). Part of a
+larger refactoring series; see tracking bug 82948.
+
+* public/platform/WebKitPlatformSupport.h:
+
+2013-02-19  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Remove idbFactory from WebKitPlatformSupport
 https://bugs.webkit.org/show_bug.cgi?id=106457
 


Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (143400 => 143401)

--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-20 00:13:26 UTC (rev 143400)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-20 00:14:25 UTC (rev 143401)
@@ -28,18 +28,4 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WebKitPlatformSupport_h
-#define WebKitPlatformSupport_h
-
 #include ../../../../Platform/chromium/public/Platform.h
-
-namespace WebKit {
-
-class WebKitPlatformSupport : public Platform {
-protected:
-~WebKitPlatformSupport() { }
-};
-
-} // namespace WebKit
-
-#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [142896] trunk/Source

2013-02-14 Thread pilgrim
Title: [142896] trunk/Source








Revision 142896
Author pilg...@chromium.org
Date 2013-02-14 11:31:47 -0800 (Thu, 14 Feb 2013)


Log Message
[Chromium] Move PlatformMessagePortChannel to WebCore
https://bugs.webkit.org/show_bug.cgi?id=109845

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* dom/default/chromium: Added.
* dom/default/chromium/PlatformMessagePortChannelChromium.cpp: Added.
(WebCore):
(WebCore::MessagePortChannel::create):
(WebCore::MessagePortChannel::createChannel):
(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::~MessagePortChannel):
(WebCore::MessagePortChannel::entangleIfOpen):
(WebCore::MessagePortChannel::disentangle):
(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::MessagePortChannel::tryGetMessageFromRemote):
(WebCore::MessagePortChannel::close):
(WebCore::MessagePortChannel::isConnectedTo):
(WebCore::MessagePortChannel::hasPendingActivity):
(WebCore::MessagePortChannel::locallyEntangledPort):
(WebCore::PlatformMessagePortChannel::create):
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
(WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel):
(WebCore::PlatformMessagePortChannel::createChannel):
(WebCore::PlatformMessagePortChannel::messageAvailable):
(WebCore::PlatformMessagePortChannel::entangleIfOpen):
(WebCore::PlatformMessagePortChannel::disentangle):
(WebCore::PlatformMessagePortChannel::postMessageToRemote):
(WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
(WebCore::PlatformMessagePortChannel::close):
(WebCore::PlatformMessagePortChannel::isConnectedTo):
(WebCore::PlatformMessagePortChannel::hasPendingActivity):
(WebCore::PlatformMessagePortChannel::setEntangledChannel):
(WebCore::PlatformMessagePortChannel::webChannelRelease):
* dom/default/chromium/PlatformMessagePortChannelChromium.h: Added.
(WebKit):
(WebCore):
(PlatformMessagePortChannel):

Source/WebKit/chromium:

* WebKit.gyp:
* src/PlatformMessagePortChannel.cpp: Removed.
* src/PlatformMessagePortChannel.h: Removed.
* src/SharedWorkerRepository.cpp:
* src/WebDOMMessageEvent.cpp:
* src/WebFrameImpl.cpp:
* src/WebSharedWorkerImpl.cpp:
* src/WebWorkerClientImpl.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp
trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp
trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp


Added Paths

trunk/Source/WebCore/dom/default/chromium/
trunk/Source/WebCore/dom/default/chromium/PlatformMessagePortChannelChromium.cpp
trunk/Source/WebCore/dom/default/chromium/PlatformMessagePortChannelChromium.h


Removed Paths

trunk/Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp
trunk/Source/WebKit/chromium/src/PlatformMessagePortChannel.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (142895 => 142896)

--- trunk/Source/WebCore/ChangeLog	2013-02-14 19:22:10 UTC (rev 142895)
+++ trunk/Source/WebCore/ChangeLog	2013-02-14 19:31:47 UTC (rev 142896)
@@ -1,3 +1,48 @@
+2013-02-14  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move PlatformMessagePortChannel to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=109845
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 106829.
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+* dom/default/chromium: Added.
+* dom/default/chromium/PlatformMessagePortChannelChromium.cpp: Added.
+(WebCore):
+(WebCore::MessagePortChannel::create):
+(WebCore::MessagePortChannel::createChannel):
+(WebCore::MessagePortChannel::MessagePortChannel):
+(WebCore::MessagePortChannel::~MessagePortChannel):
+(WebCore::MessagePortChannel::entangleIfOpen):
+(WebCore::MessagePortChannel::disentangle):
+(WebCore::MessagePortChannel::postMessageToRemote):
+(WebCore::MessagePortChannel::tryGetMessageFromRemote):
+(WebCore::MessagePortChannel::close):
+(WebCore::MessagePortChannel::isConnectedTo):
+(WebCore::MessagePortChannel::hasPendingActivity):
+(WebCore::MessagePortChannel::locallyEntangledPort):
+(WebCore::PlatformMessagePortChannel::create):
+(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
+(WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel):
+(WebCore::PlatformMessagePortChannel::createChannel):
+(WebCore::PlatformMessagePortChannel::messageAvailable):
+(WebCore::PlatformMessagePortChannel::entangleIfOpen):
+(WebCore::PlatformMessagePortChannel::disentan

[webkit-changes] [141896] trunk/Source/WebKit/chromium

2013-02-05 Thread pilgrim
Title: [141896] trunk/Source/WebKit/chromium








Revision 141896
Author pilg...@chromium.org
Date 2013-02-05 09:42:47 -0800 (Tue, 05 Feb 2013)


Log Message
[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Adam Barth.

Now that https://codereview.chromium.org/12181010/ has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
(WebKit):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (141895 => 141896)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-05 17:21:39 UTC (rev 141895)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-05 17:42:47 UTC (rev 141896)
@@ -1,3 +1,20 @@
+2013-02-05  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove idbFactory from WebKitPlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=106457
+
+Reviewed by Adam Barth.
+
+Now that https://codereview.chromium.org/12181010/ has landed, the
+idbFactory method is no longer needed. (Embedders must now call
+the new setIDBFactory method upon initialization.) Part of a
+larger refactoring series; see tracking bug 82948.
+
+* public/platform/WebKitPlatformSupport.h:
+(WebKit):
+* src/IDBFactoryBackendProxy.cpp:
+(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
+
 2013-02-05  Kentaro Hara  hara...@chromium.org
 
 Unreviewed, rolling out r141865.


Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (141895 => 141896)

--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-05 17:21:39 UTC (rev 141895)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-02-05 17:42:47 UTC (rev 141896)
@@ -35,15 +35,7 @@
 
 namespace WebKit {
 
-class WebIDBFactory; // FIXME: Does this belong in platform?
-
-// FIXME: Eventually all these API will need to move to WebKit::Platform.
 class WebKitPlatformSupport : public Platform {
-public:
-// Indexed Database 
-
-virtual WebIDBFactory* idbFactory() { return 0; }
-
 protected:
 ~WebKitPlatformSupport() { }
 };


Modified: trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp (141895 => 141896)

--- trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp	2013-02-05 17:21:39 UTC (rev 141895)
+++ trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp	2013-02-05 17:42:47 UTC (rev 141896)
@@ -53,7 +53,6 @@
 #include WorkerLoaderProxy.h
 #include WorkerScriptController.h
 #include WorkerThread.h
-#include platform/WebKitPlatformSupport.h
 #include public/WebVector.h
 
 
@@ -75,10 +74,8 @@
 
 IDBFactoryBackendProxy::IDBFactoryBackendProxy()
 {
-if (s_webIDBFactory)
-m_webIDBFactory = s_webIDBFactory;
-else
-m_webIDBFactory = webKitPlatformSupport()-idbFactory();
+ASSERT(s_webIDBFactory);
+m_webIDBFactory = s_webIDBFactory;
 }
 
 IDBFactoryBackendProxy::~IDBFactoryBackendProxy()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [141784] trunk/Source

2013-02-04 Thread pilgrim
Title: [141784] trunk/Source








Revision 141784
Author pilg...@chromium.org
Date 2013-02-04 10:52:03 -0800 (Mon, 04 Feb 2013)


Log Message
[Chromium] Move IDBFactoryBackendInterface to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108638

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

* Modules/indexeddb/chromium: Added.
* Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Added.
(WebCore):
(WebCore::setIDBFactoryBackendInterfaceCreateFunction):
(WebCore::IDBFactoryBackendInterface::create):
* Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Added.
(WebCore):
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

Source/WebKit/chromium:

* WebKit.gyp:
* src/AssertMatchingEnums.cpp:
* src/IDBFactoryBackendInterface.cpp: Removed.
* src/IDBFactoryBackendProxy.h:
* src/WebKit.cpp:
(WebKit::initializeWithoutV8):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.h
trunk/Source/WebKit/chromium/src/WebKit.cpp


Added Paths

trunk/Source/WebCore/Modules/indexeddb/chromium/
trunk/Source/WebCore/Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp
trunk/Source/WebCore/Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h


Removed Paths

trunk/Source/WebKit/chromium/src/IDBFactoryBackendInterface.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141783 => 141784)

--- trunk/Source/WebCore/ChangeLog	2013-02-04 18:43:03 UTC (rev 141783)
+++ trunk/Source/WebCore/ChangeLog	2013-02-04 18:52:03 UTC (rev 141784)
@@ -1,3 +1,22 @@
+2013-02-04  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move IDBFactoryBackendInterface to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=108638
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 106829.
+
+* Modules/indexeddb/chromium: Added.
+* Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Added.
+(WebCore):
+(WebCore::setIDBFactoryBackendInterfaceCreateFunction):
+(WebCore::IDBFactoryBackendInterface::create):
+* Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Added.
+(WebCore):
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+
 2013-02-04  Abhishek Arya  infe...@chromium.org
 
 Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.


Copied: trunk/Source/WebCore/Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp (from rev 141783, trunk/Source/WebKit/chromium/src/IDBFactoryBackendInterface.cpp) (0 => 141784)

--- trunk/Source/WebCore/Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp	(rev 0)
+++ trunk/Source/WebCore/Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp	2013-02-04 18:52:03 UTC (rev 141784)
@@ -0,0 +1,52 @@
+/*
+ * Copyright (C) 2010 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * 3.  Neither the name of Apple Computer, Inc. (Apple) nor the names of
+ * its contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS AS IS AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+#include config.h
+#include IDBFactoryBackendInterfaceChromium.h
+
+#if ENABLE(INDEXED_DATABASE)
+
+namespace WebCore {
+
+static IDBFactoryBackendInterfaceCreate* s_idbFactoryBackendInterfaceCreateFunction = 0;
+
+void setIDBFactoryBackendInterfaceCreateFu

[webkit-changes] [141818] trunk/Source

2013-02-04 Thread pilgrim
Title: [141818] trunk/Source








Revision 141818
Author pilg...@chromium.org
Date 2013-02-04 14:49:08 -0800 (Mon, 04 Feb 2013)


Log Message
[Chromium] Move WorkerContextProxy to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108847

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* workers/chromium: Added.
* workers/chromium/WorkerContextProxyChromium.cpp: Added.
(WebCore):
(WebCore::setWorkerContextProxyCreateFunction):
(WebCore::WorkerContextProxy::create):
* workers/chromium/WorkerContextProxyChromium.h: Added.
(WebCore):

Source/WebKit/chromium:

* WebKit.gyp:
* src/WebKit.cpp:
(WebKit::initializeWithoutV8):
* src/WorkerContextProxy.cpp: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/WebKit.cpp


Added Paths

trunk/Source/WebCore/workers/chromium/
trunk/Source/WebCore/workers/chromium/WorkerContextProxyChromium.cpp
trunk/Source/WebCore/workers/chromium/WorkerContextProxyChromium.h


Removed Paths

trunk/Source/WebKit/chromium/src/WorkerContextProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141817 => 141818)

--- trunk/Source/WebCore/ChangeLog	2013-02-04 22:39:16 UTC (rev 141817)
+++ trunk/Source/WebCore/ChangeLog	2013-02-04 22:49:08 UTC (rev 141818)
@@ -1,3 +1,22 @@
+2013-02-04  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move WorkerContextProxy to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=108847
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 106829.
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+* workers/chromium: Added.
+* workers/chromium/WorkerContextProxyChromium.cpp: Added.
+(WebCore):
+(WebCore::setWorkerContextProxyCreateFunction):
+(WebCore::WorkerContextProxy::create):
+* workers/chromium/WorkerContextProxyChromium.h: Added.
+(WebCore):
+
 2013-02-04  Dima Gorbik  dgor...@apple.com
 
 WebVTT i, b and u elements should have default styles


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (141817 => 141818)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2013-02-04 22:39:16 UTC (rev 141817)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2013-02-04 22:49:08 UTC (rev 141818)
@@ -153,6 +153,7 @@
   '../svg/properties',
   '../../ThirdParty/glu',
   '../workers',
+  '../workers/chromium',
   '../xml',
   '../xml/parser',
 ],


Modified: trunk/Source/WebCore/WebCore.gypi (141817 => 141818)

--- trunk/Source/WebCore/WebCore.gypi	2013-02-04 22:39:16 UTC (rev 141817)
+++ trunk/Source/WebCore/WebCore.gypi	2013-02-04 22:49:08 UTC (rev 141818)
@@ -2646,6 +2646,8 @@
 'workers/WorkerScriptLoader.h',
 'workers/WorkerScriptLoaderClient.h',
 'workers/WorkerThread.cpp',
+'workers/chromium/WorkerContextProxyChromium.cpp',
+'workers/chromium/WorkerContextProxyChromium.h',
 'xml/parser/CharacterReferenceParserInlines.h',
 'xml/parser/MarkupTokenBase.h',
 'xml/parser/MarkupTokenizerBase.h',


Copied: trunk/Source/WebCore/workers/chromium/WorkerContextProxyChromium.cpp (from rev 141817, trunk/Source/WebKit/chromium/src/WorkerContextProxy.cpp) (0 => 141818)

--- trunk/Source/WebCore/workers/chromium/WorkerContextProxyChromium.cpp	(rev 0)
+++ trunk/Source/WebCore/workers/chromium/WorkerContextProxyChromium.cpp	2013-02-04 22:49:08 UTC (rev 141818)
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2012 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO,

[webkit-changes] [141382] trunk/Source

2013-01-31 Thread pilgrim
Title: [141382] trunk/Source








Revision 141382
Author pilg...@chromium.org
Date 2013-01-31 00:05:11 -0800 (Thu, 31 Jan 2013)


Log Message
[Chromium] Move MediaPlayerPrivateChromium to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108415

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/MediaPlayerPrivateChromium.cpp: Added.
(WebCore):
(WebCore::MediaPlayerPrivate::registerMediaEngine): call
registerMediaEngine through static function pointer that was set
during WebKit initializeWithoutV8
(WebCore::MediaPlayerPrivate::setMediaEngineRegisterSelfFunction):
new setter function that takes a function pointer that is used by registerMediaEngine
* platform/graphics/chromium/MediaPlayerPrivateChromium.h:
(WebCore):
(MediaPlayerPrivate):

Source/WebKit/chromium:

* WebKit.gyp:
* src/MediaPlayerPrivateChromium.cpp: Removed.
* src/WebKit.cpp:
(WebKit::initializeWithoutV8): call new setter function in
WebCore::MediaPlayerPrivate

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/graphics/chromium/MediaPlayerPrivateChromium.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/WebKit.cpp


Added Paths

trunk/Source/WebCore/platform/graphics/chromium/MediaPlayerPrivateChromium.cpp


Removed Paths

trunk/Source/WebKit/chromium/src/MediaPlayerPrivateChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141381 => 141382)

--- trunk/Source/WebCore/ChangeLog	2013-01-31 08:00:54 UTC (rev 141381)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 08:05:11 UTC (rev 141382)
@@ -1,3 +1,24 @@
+2013-01-31  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move MediaPlayerPrivateChromium to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=108415
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 106829.
+
+* WebCore.gypi:
+* platform/graphics/chromium/MediaPlayerPrivateChromium.cpp: Added.
+(WebCore):
+(WebCore::MediaPlayerPrivate::registerMediaEngine): call
+registerMediaEngine through static function pointer that was set
+during WebKit initializeWithoutV8
+(WebCore::MediaPlayerPrivate::setMediaEngineRegisterSelfFunction):
+new setter function that takes a function pointer that is used by registerMediaEngine
+* platform/graphics/chromium/MediaPlayerPrivateChromium.h:
+(WebCore):
+(MediaPlayerPrivate):
+
 2013-01-30  Patrick Gansterer  par...@webkit.org
 
 Port DragImageWin.cpp to WinCE


Modified: trunk/Source/WebCore/WebCore.gypi (141381 => 141382)

--- trunk/Source/WebCore/WebCore.gypi	2013-01-31 08:00:54 UTC (rev 141381)
+++ trunk/Source/WebCore/WebCore.gypi	2013-01-31 08:05:11 UTC (rev 141382)
@@ -3895,6 +3895,7 @@
 'platform/graphics/chromium/ImageFrameGenerator.h',
 'platform/graphics/chromium/LazyDecodingPixelRef.cpp',
 'platform/graphics/chromium/LazyDecodingPixelRef.h',
+'platform/graphics/chromium/MediaPlayerPrivateChromium.cpp',
 'platform/graphics/chromium/MediaPlayerPrivateChromium.h',
 'platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp',
 'platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h',


Copied: trunk/Source/WebCore/platform/graphics/chromium/MediaPlayerPrivateChromium.cpp (from rev 141381, trunk/Source/WebKit/chromium/src/MediaPlayerPrivateChromium.cpp) (0 => 141382)

--- trunk/Source/WebCore/platform/graphics/chromium/MediaPlayerPrivateChromium.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/graphics/chromium/MediaPlayerPrivateChromium.cpp	2013-01-31 08:05:11 UTC (rev 141382)
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2009 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CON

[webkit-changes] [141474] trunk/Source

2013-01-31 Thread pilgrim
Title: [141474] trunk/Source








Revision 141474
Author pilg...@chromium.org
Date 2013-01-31 13:18:16 -0800 (Thu, 31 Jan 2013)


Log Message
[Chromium] Move LocalizedStrings to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108488

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

* WebCore.gypi:
* platform/chromium/LocalizedStringsChromium.cpp: Copied from Source/WebKit/chromium/src/LocalizedStrings.cpp.
(WebCore::imageTitle):

Source/WebKit/chromium:

* WebKit.gyp:
* src/LocalizedStrings.cpp: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp


Added Paths

trunk/Source/WebCore/platform/chromium/LocalizedStringsChromium.cpp


Removed Paths

trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141473 => 141474)

--- trunk/Source/WebCore/ChangeLog	2013-01-31 21:14:58 UTC (rev 141473)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 21:18:16 UTC (rev 141474)
@@ -1,3 +1,16 @@
+2013-01-31  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move LocalizedStrings to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=108488
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 106829.
+
+* WebCore.gypi:
+* platform/chromium/LocalizedStringsChromium.cpp: Copied from Source/WebKit/chromium/src/LocalizedStrings.cpp.
+(WebCore::imageTitle):
+
 2013-01-31  Enrica Casucci  enr...@apple.com
 
 WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.


Modified: trunk/Source/WebCore/WebCore.gypi (141473 => 141474)

--- trunk/Source/WebCore/WebCore.gypi	2013-01-31 21:14:58 UTC (rev 141473)
+++ trunk/Source/WebCore/WebCore.gypi	2013-01-31 21:18:16 UTC (rev 141474)
@@ -3692,6 +3692,7 @@
 'platform/chromium/KeyboardCodes.h',
 'platform/chromium/LanguageChromium.cpp',
 'platform/chromium/LinkHashChromium.cpp',
+'platform/chromium/LocalizedStringsChromium.cpp',
 'platform/chromium/MemoryUsageSupportChromium.cpp',
 'platform/chromium/MIMETypeRegistryChromium.cpp',
 'platform/chromium/PageClientChromium.h',


Copied: trunk/Source/WebCore/platform/chromium/LocalizedStringsChromium.cpp (from rev 141473, trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp) (0 => 141474)

--- trunk/Source/WebCore/platform/chromium/LocalizedStringsChromium.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/chromium/LocalizedStringsChromium.cpp	2013-01-31 21:18:16 UTC (rev 141474)
@@ -0,0 +1,614 @@
+/*
+ * Copyright (C) 2009 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include config.h
+#include LocalizedStrings.h
+
+#include DateTimeFormat.h
+#include IntSize.h
+#include NotImplemented.h
+
+#include public/Platform.h
+#include public/WebLocalizedString.h
+#include public/WebString.h
+#include wtf/text/StringBuilder.h
+#include wtf/text/WTFString.h
+
+using WebKit::WebLocalizedString;
+using WebKit::WebString;
+
+namespace WebCore {
+
+static String query(WebLocalizedString::Name name)
+{
+return WebKit::Platform::current()-queryLocalizedString(name);
+}
+
+static String query(WebLocalizedString::Name name, const WebString parameter)
+{
+return WebKit::Platform::current()-queryLocalizedSt

[webkit-changes] [140767] trunk/Tools/Scripts/webkitpy/common/config/committers.py

2013-01-24 Thread pilgrim
Title: [140767] trunk/Tools/Scripts/webkitpy/common/config/committers.py








Revision 140767
Author pilg...@chromium.org
Date 2013-01-24 19:18:58 -0800 (Thu, 24 Jan 2013)


Log Message
Add Mark Pilgrim as committer

Modified Paths

trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (140766 => 140767)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-01-25 03:13:29 UTC (rev 140766)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-01-25 03:18:58 UTC (rev 140767)
@@ -359,6 +359,7 @@
 Committer(Marcus Voltis Bulach, bul...@chromium.org),
 Committer(Mario Sanchez Prada, [ma...@webkit.org, mario.pr...@samsung.com], msanchez),
 Committer(Mark Lam, mark@apple.com, mlam),
+Committer(Mark Pilgrim, pilg...@chromium.org, pilgrim_google),
 Committer(Mary Wu, [mary...@torchmobile.com.cn, wwendy2...@gmail.com], marywu),
 Committer(Matt Delaney, mdela...@apple.com),
 Committer(Matt Falkenhagen, fal...@chromium.org, falken),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [140565] trunk/Tools

2013-01-23 Thread pilgrim
Title: [140565] trunk/Tools








Revision 140565
Author pilg...@chromium.org
Date 2013-01-23 11:55:35 -0800 (Wed, 23 Jan 2013)


Log Message
[Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
https://bugs.webkit.org/show_bug.cgi?id=107145

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/DRTDevToolsClient.h:
* DumpRenderTree/chromium/DRTTestRunner.cpp:
* DumpRenderTree/chromium/DRTTestRunner.h:
* DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
* DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
* DumpRenderTree/chromium/MockWebSpeechInputController.h:
* DumpRenderTree/chromium/NotificationPresenter.cpp:
* DumpRenderTree/chromium/TestNavigationController.h:
* DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
* DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/EventSender.h:
* DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
* DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
* DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
* DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
* DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
* DumpRenderTree/chromium/TestShell.cpp:
* DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
* DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
* DumpRenderTree/chromium/WebViewHost.cpp:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTDevToolsAgent.cpp
trunk/Tools/DumpRenderTree/chromium/DRTDevToolsAgent.h
trunk/Tools/DumpRenderTree/chromium/DRTDevToolsClient.h
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/MockWebPrerenderingSupport.h
trunk/Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp
trunk/Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h
trunk/Tools/DumpRenderTree/chromium/NotificationPresenter.cpp
trunk/Tools/DumpRenderTree/chromium/TestNavigationController.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/GamepadController.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h
trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm
trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp
trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp




Diff

Modified: trunk/Tools/ChangeLog (140564 => 140565)

--- trunk/Tools/ChangeLog	2013-01-23 19:49:52 UTC (rev 140564)
+++ trunk/Tools/ChangeLog	2013-01-23 19:55:35 UTC (rev 140565)
@@ -1,3 +1,44 @@
+2013-01-23  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
+https://bugs.webkit.org/show_bug.cgi?id=107145
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 82948.
+
+* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
+* DumpRenderTree/chromium/DRTDevToolsAgent.h:
+* DumpRenderTree/chromium/DRTDevToolsClient.h:
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+* DumpRenderTree/chromium/DRTTestRunner.h:
+* DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
+* DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
+* DumpRenderTree/chrom

[webkit-changes] [140578] trunk/Source/WebKit/chromium

2013-01-23 Thread pilgrim
Title: [140578] trunk/Source/WebKit/chromium








Revision 140578
Author pilg...@chromium.org
Date 2013-01-23 13:20:06 -0800 (Wed, 23 Jan 2013)


Log Message
[Chromium] Fix some #includes to headers in chromium/public/platform/ that have been moved to the new Platform directory
https://bugs.webkit.org/show_bug.cgi?id=107722

Reviewed by Darin Fisher.

These headers just redirect to the new versions, so call the new
versions directly.

* src/linux/WebFontInfo.cpp:
* src/mac/WebSubstringUtil.mm:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp
trunk/Source/WebKit/chromium/src/mac/WebSubstringUtil.mm




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (140577 => 140578)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-23 21:15:29 UTC (rev 140577)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-23 21:20:06 UTC (rev 140578)
@@ -1,5 +1,18 @@
 2013-01-23  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Fix some #includes to headers in chromium/public/platform/ that have been moved to the new Platform directory
+https://bugs.webkit.org/show_bug.cgi?id=107722
+
+Reviewed by Darin Fisher.
+
+These headers just redirect to the new versions, so call the new
+versions directly.
+
+* src/linux/WebFontInfo.cpp:
+* src/mac/WebSubstringUtil.mm:
+
+2013-01-23  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Fix some #includes for WebSerializedScriptValue
 https://bugs.webkit.org/show_bug.cgi?id=107697
 


Modified: trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp (140577 => 140578)

--- trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp	2013-01-23 21:15:29 UTC (rev 140577)
+++ trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp	2013-01-23 21:20:06 UTC (rev 140578)
@@ -32,8 +32,8 @@
 #include WebFontInfo.h
 
 #include WebFontRenderStyle.h
-#include platform/linux/WebFontFamily.h
 #include fontconfig/fontconfig.h
+#include public/linux/WebFontFamily.h
 #include string.h
 #include unicode/utf16.h
 


Modified: trunk/Source/WebKit/chromium/src/mac/WebSubstringUtil.mm (140577 => 140578)

--- trunk/Source/WebKit/chromium/src/mac/WebSubstringUtil.mm	2013-01-23 21:15:29 UTC (rev 140577)
+++ trunk/Source/WebKit/chromium/src/mac/WebSubstringUtil.mm	2013-01-23 21:20:06 UTC (rev 140578)
@@ -47,7 +47,7 @@
 #include RenderStyle.h
 #include TextIterator.h
 #include WebFrameImpl.h
-#include platform/WebRect.h
+#include public/WebRect.h
 
 using namespace WebCore;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [140586] trunk/Source/WebKit/chromium

2013-01-23 Thread pilgrim
Title: [140586] trunk/Source/WebKit/chromium








Revision 140586
Author pilg...@chromium.org
Date 2013-01-23 13:56:20 -0800 (Wed, 23 Jan 2013)


Log Message
[Chromium] Remove WebArrayBufferView and WebSerializedScriptValue from chromium/public/platform/
https://bugs.webkit.org/show_bug.cgi?id=107720

Reviewed by Darin Fisher.

These headers have been moved to chromium/public/ and all
references downstream were changed in
https://codereview.chromium.org/11946050/.
No DEPS roll necessary because it's already above 177695.

* WebKit.gyp:
* public/platform/WebArrayBufferView.h: Removed.
* public/platform/WebSerializedScriptValue.h: Removed.
* src/DeliveredIntentClientImpl.cpp:
* src/IDBCallbacksProxy.cpp:
* src/IDBCursorBackendProxy.cpp:
* src/WebArrayBufferView.cpp:
* src/WebBindings.cpp:
* src/WebDOMCustomEvent.cpp:
* src/WebDOMMessageEvent.cpp:
* src/WebFrameImpl.cpp:
* src/WebHistoryItem.cpp:
* src/WebIDBCallbacksImpl.cpp:
* src/WebIntent.cpp:
* src/WebIntentRequest.cpp:
* src/WebSerializedScriptValue.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/DeliveredIntentClientImpl.cpp
trunk/Source/WebKit/chromium/src/IDBCallbacksProxy.cpp
trunk/Source/WebKit/chromium/src/IDBCursorBackendProxy.cpp
trunk/Source/WebKit/chromium/src/WebArrayBufferView.cpp
trunk/Source/WebKit/chromium/src/WebBindings.cpp
trunk/Source/WebKit/chromium/src/WebDOMCustomEvent.cpp
trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebHistoryItem.cpp
trunk/Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp
trunk/Source/WebKit/chromium/src/WebIntent.cpp
trunk/Source/WebKit/chromium/src/WebIntentRequest.cpp
trunk/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp


Removed Paths

trunk/Source/WebKit/chromium/public/platform/WebArrayBufferView.h
trunk/Source/WebKit/chromium/public/platform/WebSerializedScriptValue.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (140585 => 140586)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-23 21:55:54 UTC (rev 140585)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-23 21:56:20 UTC (rev 140586)
@@ -1,5 +1,34 @@
 2013-01-23  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Remove WebArrayBufferView and WebSerializedScriptValue from chromium/public/platform/
+https://bugs.webkit.org/show_bug.cgi?id=107720
+
+Reviewed by Darin Fisher.
+
+These headers have been moved to chromium/public/ and all
+references downstream were changed in
+https://codereview.chromium.org/11946050/.
+No DEPS roll necessary because it's already above 177695.
+
+* WebKit.gyp:
+* public/platform/WebArrayBufferView.h: Removed.
+* public/platform/WebSerializedScriptValue.h: Removed.
+* src/DeliveredIntentClientImpl.cpp:
+* src/IDBCallbacksProxy.cpp:
+* src/IDBCursorBackendProxy.cpp:
+* src/WebArrayBufferView.cpp:
+* src/WebBindings.cpp:
+* src/WebDOMCustomEvent.cpp:
+* src/WebDOMMessageEvent.cpp:
+* src/WebFrameImpl.cpp:
+* src/WebHistoryItem.cpp:
+* src/WebIDBCallbacksImpl.cpp:
+* src/WebIntent.cpp:
+* src/WebIntentRequest.cpp:
+* src/WebSerializedScriptValue.cpp:
+
+2013-01-23  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Fix some #includes to headers in chromium/public/platform/ that have been moved to the new Platform directory
 https://bugs.webkit.org/show_bug.cgi?id=107722
 


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (140585 => 140586)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-23 21:55:54 UTC (rev 140585)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-23 21:56:20 UTC (rev 140586)
@@ -298,7 +298,6 @@
 'public/mac/WebSandboxSupport.h',
 'public/mac/WebScreenInfoFactory.h',
 'public/mac/WebSubstringUtil.h',
-'public/platform/WebArrayBufferView.h',
 'public/platform/WebAudioBus.h',
 'public/platform/WebAudioDevice.h',
 'public/platform/WebCanvas.h',
@@ -321,7 +320,6 @@
 'public/platform/WebPrivatePtr.h',
 'public/platform/WebRect.h',
 'public/platform/WebReferrerPolicy.h',
-'public/platform/WebSerializedScriptValue.h',
 'public/platform/WebSize.h',
 'public/platform/WebSocketStreamError.h',
 'public/platform/WebSocketStreamHandle.h',


Deleted: trunk/Source/WebKit/chromium/public/platform/WebArrayBufferView.h (140585 => 140586)

--- trunk/Source/WebKit/chromium/public/platform/WebArrayBufferView.h	2013-01-23 21:55:54 UTC (rev 140585)
+++ trunk/Source/WebKit/chromium/public/platform/WebArrayBufferView.h	2013-01-23 21:56:20 UTC (rev 140586)
@@ -1,29 +0,0 @@
-/*
- * Copyright (C) 2011 G

[webkit-changes] [140653] trunk/Tools

2013-01-23 Thread pilgrim
Title: [140653] trunk/Tools








Revision 140653
Author pilg...@chromium.org
Date 2013-01-23 21:52:09 -0800 (Wed, 23 Jan 2013)


Log Message
[Chromium] Give webkit_support a chance to reset state between layout test runs
https://bugs.webkit.org/show_bug.cgi?id=107132

Reviewed by Adam Barth.

We currently only have need for this on OS(ANDROID), but now it
would be useful to have a hook for resetting state on all
platforms. Will soon be using this for IDBFactory initialization.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp




Diff

Modified: trunk/Tools/ChangeLog (140652 => 140653)

--- trunk/Tools/ChangeLog	2013-01-24 05:49:31 UTC (rev 140652)
+++ trunk/Tools/ChangeLog	2013-01-24 05:52:09 UTC (rev 140653)
@@ -1,3 +1,17 @@
+2013-01-23  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Give webkit_support a chance to reset state between layout test runs
+https://bugs.webkit.org/show_bug.cgi?id=107132
+
+Reviewed by Adam Barth.
+
+We currently only have need for this on OS(ANDROID), but now it
+would be useful to have a hook for resetting state on all
+platforms. Will soon be using this for IDBFactory initialization.
+
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
+
 2013-01-23  Alan Cutter  alancut...@chromium.org
 
 QueueStatusServer crashes in production on next-patch


Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (140652 => 140653)

--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2013-01-24 05:49:31 UTC (rev 140652)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2013-01-24 05:52:09 UTC (rev 140653)
@@ -334,9 +334,6 @@
 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
 m_notificationPresenter-reset();
 #endif
-#if OS(ANDROID)
-webkit_support::ReleaseMediaResources();
-#endif
 m_drtDevToolsAgent-reset();
 if (m_drtDevToolsClient)
 m_drtDevToolsClient-reset();
@@ -346,6 +343,8 @@
 webView()-mainFrame()-clearOpener();
 WebTestingSupport::resetInternalsObject(webView()-mainFrame());
 WebCache::clear();
+
+webkit_support::ResetTestEnvironment();
 }
 
 void TestShell::loadURL(const WebURL url)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [139897] trunk/Source/WebKit/chromium

2013-01-16 Thread pilgrim
Title: [139897] trunk/Source/WebKit/chromium








Revision 139897
Author pilg...@chromium.org
Date 2013-01-16 11:04:23 -0800 (Wed, 16 Jan 2013)


Log Message
[Chromium] Move WebArrayBufferView and WebSerializedScriptValue out of public/platform/
https://bugs.webkit.org/show_bug.cgi?id=106863

Reviewed by Adam Barth.

These are not being moved into the new top-level Platform
directory, so into public they go.

* WebKit.gyp:
* public/WebArrayBufferView.h: Added.
(v8):
(WebKit):
(WebArrayBufferView):
(WebKit::WebArrayBufferView::~WebArrayBufferView):
(WebKit::WebArrayBufferView::WebArrayBufferView):
* public/WebSerializedScriptValue.h: Added.
(v8):
(WebKit):
(WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::~WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::operator=):
(WebKit::WebSerializedScriptValue::isNull):
* public/platform/WebArrayBufferView.h:
* public/platform/WebSerializedScriptValue.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/platform/WebArrayBufferView.h
trunk/Source/WebKit/chromium/public/platform/WebSerializedScriptValue.h


Added Paths

trunk/Source/WebKit/chromium/public/WebArrayBufferView.h
trunk/Source/WebKit/chromium/public/WebSerializedScriptValue.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (139896 => 139897)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-16 18:44:18 UTC (rev 139896)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-16 19:04:23 UTC (rev 139897)
@@ -1,3 +1,31 @@
+2013-01-16  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move WebArrayBufferView and WebSerializedScriptValue out of public/platform/
+https://bugs.webkit.org/show_bug.cgi?id=106863
+
+Reviewed by Adam Barth.
+
+These are not being moved into the new top-level Platform
+directory, so into public they go.
+
+* WebKit.gyp:
+* public/WebArrayBufferView.h: Added.
+(v8):
+(WebKit):
+(WebArrayBufferView):
+(WebKit::WebArrayBufferView::~WebArrayBufferView):
+(WebKit::WebArrayBufferView::WebArrayBufferView):
+* public/WebSerializedScriptValue.h: Added.
+(v8):
+(WebKit):
+(WebSerializedScriptValue):
+(WebKit::WebSerializedScriptValue::~WebSerializedScriptValue):
+(WebKit::WebSerializedScriptValue::WebSerializedScriptValue):
+(WebKit::WebSerializedScriptValue::operator=):
+(WebKit::WebSerializedScriptValue::isNull):
+* public/platform/WebArrayBufferView.h:
+* public/platform/WebSerializedScriptValue.h:
+
 2013-01-16  Chris Hopman  cjhop...@chromium.org
 
 [Chromium] Remove hardcoded chromium_*.jar in gyp files


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (139896 => 139897)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-16 18:44:18 UTC (rev 139896)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-16 19:04:23 UTC (rev 139897)
@@ -100,6 +100,7 @@
 'public/WebAnimationController.h',
 'public/WebApplicationCacheHostClient.h',
 'public/WebArrayBuffer.h',
+'public/WebArrayBufferView.h',
 'public/WebAudioSourceProvider.h',
 'public/WebAudioSourceProviderClient.h',
 'public/WebAutofillClient.h',
@@ -246,6 +247,7 @@
 'public/WebSecurityOrigin.h',
 'public/WebSecurityPolicy.h',
 'public/WebSelectElement.h',
+'public/WebSerializedScriptValue.h',
 'public/WebSettings.h',
 'public/WebSharedWorkerClient.h',
 'public/WebSharedWorker.h',


Copied: trunk/Source/WebKit/chromium/public/WebArrayBufferView.h (from rev 139896, trunk/Source/WebKit/chromium/public/platform/WebArrayBufferView.h) (0 => 139897)

--- trunk/Source/WebKit/chromium/public/WebArrayBufferView.h	(rev 0)
+++ trunk/Source/WebKit/chromium/public/WebArrayBufferView.h	2013-01-16 19:04:23 UTC (rev 139897)
@@ -0,0 +1,76 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * 3.  Neither the name of Apple Computer, Inc. (Apple) nor the names of
+ * its contributors may be used to endorse or promote products derived
+ * from this software without specific prior written p

[webkit-changes] [139774] trunk/Source

2013-01-15 Thread pilgrim
Title: [139774] trunk/Source








Revision 139774
Author pilg...@chromium.org
Date 2013-01-15 12:46:19 -0800 (Tue, 15 Jan 2013)


Log Message
[Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=106899

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

* WebCore.gypi:
* platform/network/chromium/SocketStreamHandle.cpp: Copied from Source/WebKit/chromium/src/SocketStreamHandle.cpp.
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
* platform/network/chromium/SocketStreamHandleInternal.h: Copied from Source/WebKit/chromium/src/SocketStreamHandleInternal.h.

Source/WebKit/chromium:

* WebKit.gyp:
* src/SocketStreamHandle.cpp: Removed.
* src/SocketStreamHandleInternal.h: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp


Added Paths

trunk/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp
trunk/Source/WebCore/platform/network/chromium/SocketStreamHandleInternal.h


Removed Paths

trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp
trunk/Source/WebKit/chromium/src/SocketStreamHandleInternal.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139773 => 139774)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 20:44:25 UTC (rev 139773)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 20:46:19 UTC (rev 139774)
@@ -1,3 +1,22 @@
+2013-01-15  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform
+https://bugs.webkit.org/show_bug.cgi?id=106899
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 106829.
+
+* WebCore.gypi:
+* platform/network/chromium/SocketStreamHandle.cpp: Copied from Source/WebKit/chromium/src/SocketStreamHandle.cpp.
+(WebCore::SocketStreamHandleInternal::send):
+(WebCore::SocketStreamHandleInternal::didOpenStream):
+(WebCore::SocketStreamHandleInternal::didSendData):
+(WebCore::SocketStreamHandleInternal::didReceiveData):
+(WebCore::SocketStreamHandleInternal::didClose):
+(WebCore::SocketStreamHandleInternal::didFail):
+* platform/network/chromium/SocketStreamHandleInternal.h: Copied from Source/WebKit/chromium/src/SocketStreamHandleInternal.h.
+
 2013-01-15  Ojan Vafai  o...@chromium.org
 
 RenderText::computePreferredLogicalWidths does not need to be public


Modified: trunk/Source/WebCore/WebCore.gypi (139773 => 139774)

--- trunk/Source/WebCore/WebCore.gypi	2013-01-15 20:44:25 UTC (rev 139773)
+++ trunk/Source/WebCore/WebCore.gypi	2013-01-15 20:46:19 UTC (rev 139774)
@@ -4436,7 +4436,9 @@
 'platform/network/chromium/ResourceResponse.cpp',
 'platform/network/chromium/ResourceResponse.h',
 'platform/network/chromium/SocketStreamError.h',
+'platform/network/chromium/SocketStreamHandle.cpp',
 'platform/network/chromium/SocketStreamHandle.h',
+'platform/network/chromium/SocketStreamHandleInternal.h',
 'platform/network/curl/AuthenticationChallenge.h',
 'platform/network/curl/CookieJarCurl.cpp',
 'platform/network/curl/DNSCurl.cpp',


Copied: trunk/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp (from rev 139773, trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp) (0 => 139774)

--- trunk/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp	2013-01-15 20:46:19 UTC (rev 139774)
@@ -0,0 +1,215 @@
+/*
+ * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, TH

[webkit-changes] [139652] trunk/Source

2013-01-14 Thread pilgrim
Title: [139652] trunk/Source








Revision 139652
Author pilg...@chromium.org
Date 2013-01-14 13:21:37 -0800 (Mon, 14 Jan 2013)


Log Message
[Chromium] Move AudioDestinationChromium into WebCore
https://bugs.webkit.org/show_bug.cgi?id=106803

Reviewed by Adam Barth.

This doesn't really belong in WebKit/chromium/src since it defines
things directly in the WebCore namespace.

Source/WebCore:

* WebCore.gypi:
* platform/audio/chromium/AudioDestinationChromium.cpp: Added.
(WebCore):
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::~AudioDestinationChromium):
(WebCore::AudioDestinationChromium::start):
(WebCore::AudioDestinationChromium::stop):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationChromium::render):
(WebCore::AudioDestinationChromium::provideInput):
* platform/audio/chromium/AudioDestinationChromium.h: Added.
(WebCore):
(AudioDestinationChromium):
(WebCore::AudioDestinationChromium::isPlaying):
(WebCore::AudioDestinationChromium::sampleRate):

Source/WebKit/chromium:

* WebKit.gyp:
* src/AudioDestinationChromium.cpp: Removed.
* src/AudioDestinationChromium.h: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp


Added Paths

trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp
trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.h


Removed Paths

trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp
trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139651 => 139652)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 21:16:15 UTC (rev 139651)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 21:21:37 UTC (rev 139652)
@@ -1,3 +1,30 @@
+2013-01-14  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move AudioDestinationChromium into WebCore
+https://bugs.webkit.org/show_bug.cgi?id=106803
+
+Reviewed by Adam Barth.
+
+This doesn't really belong in WebKit/chromium/src since it defines
+things directly in the WebCore namespace.
+
+* WebCore.gypi:
+* platform/audio/chromium/AudioDestinationChromium.cpp: Added.
+(WebCore):
+(WebCore::AudioDestination::create):
+(WebCore::AudioDestinationChromium::AudioDestinationChromium):
+(WebCore::AudioDestinationChromium::~AudioDestinationChromium):
+(WebCore::AudioDestinationChromium::start):
+(WebCore::AudioDestinationChromium::stop):
+(WebCore::AudioDestination::hardwareSampleRate):
+(WebCore::AudioDestinationChromium::render):
+(WebCore::AudioDestinationChromium::provideInput):
+* platform/audio/chromium/AudioDestinationChromium.h: Added.
+(WebCore):
+(AudioDestinationChromium):
+(WebCore::AudioDestinationChromium::isPlaying):
+(WebCore::AudioDestinationChromium::sampleRate):
+
 2013-01-14  Adrian Perez de Castro  ape...@igalia.com
 
 [GTK] Fix indentation for GStreamer supported MIME types list


Modified: trunk/Source/WebCore/WebCore.gypi (139651 => 139652)

--- trunk/Source/WebCore/WebCore.gypi	2013-01-14 21:16:15 UTC (rev 139651)
+++ trunk/Source/WebCore/WebCore.gypi	2013-01-14 21:21:37 UTC (rev 139652)
@@ -3616,6 +3616,8 @@
 'platform/audio/ZeroPole.cpp',
 'platform/audio/ZeroPole.h',
 'platform/audio/chromium/AudioBusChromium.cpp',
+'platform/audio/chromium/AudioDestinationChromium.cpp',
+'platform/audio/chromium/AudioDestinationChromium.h',
 'platform/audio/mac/AudioBusMac.mm',
 'platform/audio/mac/AudioDestinationMac.cpp',
 'platform/audio/mac/AudioDestinationMac.h',


Copied: trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp (from rev 139650, trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp) (0 => 139652)

--- trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp	2013-01-14 21:21:37 UTC (rev 139652)
@@ -0,0 +1,160 @@
+/*
+ * Copyright (C) 2010 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * 3.  Neither the name of Apple Computer, Inc. (Apple) nor the names of
+ * its contrib

[webkit-changes] [139698] trunk/Source

2013-01-14 Thread pilgrim
Title: [139698] trunk/Source








Revision 139698
Author pilg...@chromium.org
Date 2013-01-14 17:58:07 -0800 (Mon, 14 Jan 2013)


Log Message
[Chromium] Move BlobRegistryProxy into WebCore
https://bugs.webkit.org/show_bug.cgi?id=106831

Reviewed by Adam Barth.

Part of a larger refactoring series to remove layering violations
in Chromium. See tracking bug 106829.

Source/WebCore:

* WebCore.gypi:
* platform/network/chromium/BlobRegistryProxy.cpp: Added.
(WebCore):
(WebCore::blobRegistry):
(WebCore::BlobRegistryProxy::BlobRegistryProxy):
(WebCore::BlobRegistryProxy::registerBlobURL):
(WebCore::BlobRegistryProxy::unregisterBlobURL):
* platform/network/chromium/BlobRegistryProxy.h: Added.
(WebCore):
(BlobRegistryProxy):
(WebCore::BlobRegistryProxy::loadResourceSynchronously):
(WebCore::BlobRegistryProxy::~BlobRegistryProxy):

Source/WebKit/chromium:

* WebKit.gyp:
* src/BlobRegistryProxy.cpp: Removed.
* src/BlobRegistryProxy.h: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp


Added Paths

trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp
trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.h


Removed Paths

trunk/Source/WebKit/chromium/src/BlobRegistryProxy.cpp
trunk/Source/WebKit/chromium/src/BlobRegistryProxy.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139697 => 139698)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 01:40:54 UTC (rev 139697)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 01:58:07 UTC (rev 139698)
@@ -1,3 +1,26 @@
+2013-01-14  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move BlobRegistryProxy into WebCore
+https://bugs.webkit.org/show_bug.cgi?id=106831
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series to remove layering violations
+in Chromium. See tracking bug 106829.
+
+* WebCore.gypi:
+* platform/network/chromium/BlobRegistryProxy.cpp: Added.
+(WebCore):
+(WebCore::blobRegistry):
+(WebCore::BlobRegistryProxy::BlobRegistryProxy):
+(WebCore::BlobRegistryProxy::registerBlobURL):
+(WebCore::BlobRegistryProxy::unregisterBlobURL):
+* platform/network/chromium/BlobRegistryProxy.h: Added.
+(WebCore):
+(BlobRegistryProxy):
+(WebCore::BlobRegistryProxy::loadResourceSynchronously):
+(WebCore::BlobRegistryProxy::~BlobRegistryProxy):
+
 2013-01-14  Levi Weintraub  le...@chromium.org
 
 Rolling out r139618. Appears to be causing sporadic crashes on Debug bots.


Modified: trunk/Source/WebCore/WebCore.gypi (139697 => 139698)

--- trunk/Source/WebCore/WebCore.gypi	2013-01-15 01:40:54 UTC (rev 139697)
+++ trunk/Source/WebCore/WebCore.gypi	2013-01-15 01:58:07 UTC (rev 139698)
@@ -4424,6 +4424,8 @@
 'platform/network/cf/SocketStreamHandleCFNet.cpp',
 'platform/network/chromium/AuthenticationChallenge.h',
 'platform/network/chromium/AuthenticationChallengeChromium.cpp',
+'platform/network/chromium/BlobRegistryProxy.cpp',
+'platform/network/chromium/BlobRegistryProxy.h',
 'platform/network/chromium/CookieJarChromium.cpp',
 'platform/network/chromium/DNSChromium.cpp',
 'platform/network/chromium/ResourceError.h',


Copied: trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp (from rev 139697, trunk/Source/WebKit/chromium/src/BlobRegistryProxy.cpp) (0 => 139698)

--- trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp	2013-01-15 01:58:07 UTC (rev 139698)
@@ -0,0 +1,86 @@
+/*
+ * Copyright (C) 2010 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIA

[webkit-changes] [139711] trunk/Source/WebCore

2013-01-14 Thread pilgrim
Title: [139711] trunk/Source/WebCore








Revision 139711
Author pilg...@chromium.org
Date 2013-01-14 21:15:31 -0800 (Mon, 14 Jan 2013)


Log Message
[Chromium] Use explicit WebKit prefixes in BlobRegistryProxy
https://bugs.webkit.org/show_bug.cgi?id=106859

Reviewed by Adam Barth.

As requested in https://bugs.webkit.org/show_bug.cgi?id=106831#c2

* platform/network/chromium/BlobRegistryProxy.cpp:
(WebCore::BlobRegistryProxy::registerBlobURL):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139710 => 139711)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 05:06:50 UTC (rev 139710)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 05:15:31 UTC (rev 139711)
@@ -1,3 +1,15 @@
+2013-01-14  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Use explicit WebKit prefixes in BlobRegistryProxy
+https://bugs.webkit.org/show_bug.cgi?id=106859
+
+Reviewed by Adam Barth.
+
+As requested in https://bugs.webkit.org/show_bug.cgi?id=106831#c2
+
+* platform/network/chromium/BlobRegistryProxy.cpp:
+(WebCore::BlobRegistryProxy::registerBlobURL):
+
 2013-01-14  Max Vujovic  mvujo...@adobe.com
 
 [ANGLE] Update ANGLE in WebKit


Modified: trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp (139710 => 139711)

--- trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp	2013-01-15 05:06:50 UTC (rev 139710)
+++ trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp	2013-01-15 05:15:31 UTC (rev 139711)
@@ -44,9 +44,6 @@
 #include wtf/MainThread.h
 #include wtf/StdLibExtras.h
 
-// We are part of the WebKit implementation.
-using namespace WebKit;
-
 namespace WebCore {
 
 BlobRegistry blobRegistry()
@@ -64,7 +61,7 @@
 void BlobRegistryProxy::registerBlobURL(const KURL url, PassOwnPtrBlobData blobData)
 {
 if (m_webBlobRegistry) {
-WebBlobData webBlobData(blobData);
+WebKit::WebBlobData webBlobData(blobData);
 m_webBlobRegistry-registerBlobURL(url, webBlobData);
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [139713] trunk/Source/WebKit/chromium

2013-01-14 Thread pilgrim
Title: [139713] trunk/Source/WebKit/chromium








Revision 139713
Author pilg...@chromium.org
Date 2013-01-14 21:17:36 -0800 (Mon, 14 Jan 2013)


Log Message
[Chromium] Remove unused public/platform/WebColorName.h
https://bugs.webkit.org/show_bug.cgi?id=106865

Reviewed by Adam Barth.

This file is no longer referenced anywhere in WebKit or Chromium.

* public/platform/WebColorName.h: Removed.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog


Removed Paths

trunk/Source/WebKit/chromium/public/platform/WebColorName.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (139712 => 139713)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-15 05:16:20 UTC (rev 139712)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-15 05:17:36 UTC (rev 139713)
@@ -1,5 +1,16 @@
 2013-01-14  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Remove unused public/platform/WebColorName.h
+https://bugs.webkit.org/show_bug.cgi?id=106865
+
+Reviewed by Adam Barth.
+
+This file is no longer referenced anywhere in WebKit or Chromium.
+
+* public/platform/WebColorName.h: Removed.
+
+2013-01-14  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Move BlobRegistryProxy into WebCore
 https://bugs.webkit.org/show_bug.cgi?id=106831
 


Deleted: trunk/Source/WebKit/chromium/public/platform/WebColorName.h (139712 => 139713)

--- trunk/Source/WebKit/chromium/public/platform/WebColorName.h	2013-01-15 05:16:20 UTC (rev 139712)
+++ trunk/Source/WebKit/chromium/public/platform/WebColorName.h	2013-01-15 05:17:36 UTC (rev 139713)
@@ -1,29 +0,0 @@
-/*
- * Copyright (C) 2012 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1.  Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2.  Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS AS IS AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-// FIXME: This is logically part of the WebKit client API and doesn't belong in platform. This is a forwarding header to avoid requiring a two-sided commit.
-// As soon as all chromium code is updated for the new location of this header, remove this.
-
-#include ../WebColorName.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [139246] trunk/Source/WebKit/chromium

2013-01-09 Thread pilgrim
Title: [139246] trunk/Source/WebKit/chromium








Revision 139246
Author pilg...@chromium.org
Date 2013-01-09 15:12:19 -0800 (Wed, 09 Jan 2013)


Log Message
[Chromium] Remove stray references to WebKitPlatformSupport.h
https://bugs.webkit.org/show_bug.cgi?id=106493

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

* src/SharedWorkerRepository.cpp:
* tests/RunAllTests.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp
trunk/Source/WebKit/chromium/tests/RunAllTests.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (139245 => 139246)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-09 23:00:52 UTC (rev 139245)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-09 23:12:19 UTC (rev 139246)
@@ -1,5 +1,17 @@
 2013-01-09  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Remove stray references to WebKitPlatformSupport.h
+https://bugs.webkit.org/show_bug.cgi?id=106493
+
+Reviewed by James Robinson.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/SharedWorkerRepository.cpp:
+* tests/RunAllTests.cpp:
+
+2013-01-09  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Update some #includes in WebKit/chromium/public/ for new Platform directory
 https://bugs.webkit.org/show_bug.cgi?id=106227
 


Modified: trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp (139245 => 139246)

--- trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2013-01-09 23:00:52 UTC (rev 139245)
+++ trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2013-01-09 23:12:19 UTC (rev 139246)
@@ -49,7 +49,6 @@
 #include WebKit.h
 #include WebSharedWorker.h
 #include WebSharedWorkerRepository.h
-#include platform/WebKitPlatformSupport.h
 #include WorkerScriptLoader.h
 #include WorkerScriptLoaderClient.h
 


Modified: trunk/Source/WebKit/chromium/tests/RunAllTests.cpp (139245 => 139246)

--- trunk/Source/WebKit/chromium/tests/RunAllTests.cpp	2013-01-09 23:00:52 UTC (rev 139245)
+++ trunk/Source/WebKit/chromium/tests/RunAllTests.cpp	2013-01-09 23:12:19 UTC (rev 139246)
@@ -36,7 +36,7 @@
 #include base/test/test_suite.h
 
 #include WebKit.h
-#include platform/WebKitPlatformSupport.h
+#include public/Platform.h
 #include webkit/support/webkit_support.h
 
 #if defined(WEBKIT_DLL_UNITTEST)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [139277] trunk/Tools

2013-01-09 Thread pilgrim
Title: [139277] trunk/Tools








Revision 139277
Author pilg...@chromium.org
Date 2013-01-09 19:44:28 -0800 (Wed, 09 Jan 2013)


Log Message
[Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=106520

Reviewed by James Robinson.

Part of a larger refactoring series. See tracking bug 82948.

* DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h
trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm




Diff

Modified: trunk/Tools/ChangeLog (139276 => 139277)

--- trunk/Tools/ChangeLog	2013-01-10 03:42:58 UTC (rev 139276)
+++ trunk/Tools/ChangeLog	2013-01-10 03:44:28 UTC (rev 139277)
@@ -1,3 +1,15 @@
+2013-01-09  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=106520
+
+Reviewed by James Robinson.
+
+Part of a larger refactoring series. See tracking bug 82948.
+
+* DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
+* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
+
 2013-01-09  Julie Parent  jpar...@chromium.org
 
 Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state


Modified: trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h (139276 => 139277)

--- trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h	2013-01-10 03:42:58 UTC (rev 139276)
+++ trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h	2013-01-10 03:44:28 UTC (rev 139277)
@@ -30,7 +30,7 @@
 #ifndef WebThemeEngineDRTMac_h
 #define WebThemeEngineDRTMac_h
 
-#include third_party/WebKit/Source/WebKit/chromium/public/platform/mac/WebThemeEngine.h
+#include third_party/WebKit/Source/Platform/chromium/public/mac/WebThemeEngine.h
 
 class WebThemeEngineDRTMac : public WebKit::WebThemeEngine {
 public:


Modified: trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm (139276 => 139277)

--- trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm	2013-01-10 03:42:58 UTC (rev 139276)
+++ trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm	2013-01-10 03:44:28 UTC (rev 139277)
@@ -31,8 +31,8 @@
 #include WebThemeEngineDRTMac.h
 
 #include skia/ext/skia_utils_mac.h
-#include third_party/WebKit/Source/WebKit/chromium/public/platform/WebCanvas.h
-#include third_party/WebKit/Source/WebKit/chromium/public/platform/WebRect.h
+#include third_party/WebKit/Source/Platform/chromium/public/WebCanvas.h
+#include third_party/WebKit/Source/Platform/chromium/public/WebRect.h
 #import AppKit/NSAffineTransform.h
 #import AppKit/NSGraphicsContext.h
 #import AppKit/NSScroller.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [138798] trunk/Source/WebKit/chromium

2013-01-04 Thread pilgrim
Title: [138798] trunk/Source/WebKit/chromium








Revision 138798
Author pilg...@chromium.org
Date 2013-01-04 07:37:19 -0800 (Fri, 04 Jan 2013)


Log Message
[Chromium] Update some #includes to use headers in the new Platform directory
https://bugs.webkit.org/show_bug.cgi?id=106092

Reviewed by Kentaro Hara.

Working towards getting rid of legacy header files in
WebKit/chromium/public/ and WebKit/chromium/public/platform/

* src/AsyncFileSystemChromium.cpp:
* src/StorageAreaProxy.cpp:
* src/StorageNamespaceProxy.cpp:
* src/WebFileSystemCallbacksImpl.cpp:
* src/WebGraphicsContext3D.cpp:
* src/WebIDBCursorImpl.h:
* src/WebIDBDatabaseCallbacksImpl.cpp:
* src/WebIDBDatabaseCallbacksImpl.h:
* src/WebIDBDatabaseError.cpp:
* src/WebIDBDatabaseImpl.h:
* src/WebIDBIndexImpl.h:
* src/WebIDBKeyPath.cpp:
* src/WebIDBMetadata.cpp:
* src/WebIDBObjectStoreImpl.h:
* src/WebWorkerClientImpl.cpp:
* src/WebWorkerRunLoop.cpp:
* src/WorkerFileSystemCallbacksBridge.cpp:
* tests/AssociatedURLLoaderTest.cpp:
* tests/FrameTestHelpers.cpp:
* tests/PopupMenuTest.cpp:
* tests/URLTestHelpers.cpp:
* tests/WebFrameTest.cpp:
* tests/WebPageNewSerializerTest.cpp:
* tests/WebPageSerializerTest.cpp:
* tests/WebURLRequestTest.cpp:
* tests/WebURLResponseTest.cpp:
* tests/WebUnitTests.h:
* tests/WebViewTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AsyncFileSystemChromium.cpp
trunk/Source/WebKit/chromium/src/StorageAreaProxy.cpp
trunk/Source/WebKit/chromium/src/StorageNamespaceProxy.cpp
trunk/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp
trunk/Source/WebKit/chromium/src/WebGraphicsContext3D.cpp
trunk/Source/WebKit/chromium/src/WebIDBCursorImpl.h
trunk/Source/WebKit/chromium/src/WebIDBDatabaseCallbacksImpl.cpp
trunk/Source/WebKit/chromium/src/WebIDBDatabaseCallbacksImpl.h
trunk/Source/WebKit/chromium/src/WebIDBDatabaseError.cpp
trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.h
trunk/Source/WebKit/chromium/src/WebIDBIndexImpl.h
trunk/Source/WebKit/chromium/src/WebIDBKeyPath.cpp
trunk/Source/WebKit/chromium/src/WebIDBMetadata.cpp
trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h
trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebWorkerRunLoop.cpp
trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp
trunk/Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp
trunk/Source/WebKit/chromium/tests/FrameTestHelpers.cpp
trunk/Source/WebKit/chromium/tests/PopupMenuTest.cpp
trunk/Source/WebKit/chromium/tests/URLTestHelpers.cpp
trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp
trunk/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp
trunk/Source/WebKit/chromium/tests/WebPageSerializerTest.cpp
trunk/Source/WebKit/chromium/tests/WebURLRequestTest.cpp
trunk/Source/WebKit/chromium/tests/WebURLResponseTest.cpp
trunk/Source/WebKit/chromium/tests/WebUnitTests.h
trunk/Source/WebKit/chromium/tests/WebViewTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (138797 => 138798)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-04 15:25:35 UTC (rev 138797)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-04 15:37:19 UTC (rev 138798)
@@ -1,3 +1,42 @@
+2013-01-04  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Update some #includes to use headers in the new Platform directory
+https://bugs.webkit.org/show_bug.cgi?id=106092
+
+Reviewed by Kentaro Hara.
+
+Working towards getting rid of legacy header files in
+WebKit/chromium/public/ and WebKit/chromium/public/platform/
+
+* src/AsyncFileSystemChromium.cpp:
+* src/StorageAreaProxy.cpp:
+* src/StorageNamespaceProxy.cpp:
+* src/WebFileSystemCallbacksImpl.cpp:
+* src/WebGraphicsContext3D.cpp:
+* src/WebIDBCursorImpl.h:
+* src/WebIDBDatabaseCallbacksImpl.cpp:
+* src/WebIDBDatabaseCallbacksImpl.h:
+* src/WebIDBDatabaseError.cpp:
+* src/WebIDBDatabaseImpl.h:
+* src/WebIDBIndexImpl.h:
+* src/WebIDBKeyPath.cpp:
+* src/WebIDBMetadata.cpp:
+* src/WebIDBObjectStoreImpl.h:
+* src/WebWorkerClientImpl.cpp:
+* src/WebWorkerRunLoop.cpp:
+* src/WorkerFileSystemCallbacksBridge.cpp:
+* tests/AssociatedURLLoaderTest.cpp:
+* tests/FrameTestHelpers.cpp:
+* tests/PopupMenuTest.cpp:
+* tests/URLTestHelpers.cpp:
+* tests/WebFrameTest.cpp:
+* tests/WebPageNewSerializerTest.cpp:
+* tests/WebPageSerializerTest.cpp:
+* tests/WebURLRequestTest.cpp:
+* tests/WebURLResponseTest.cpp:
+* tests/WebUnitTests.h:
+* tests/WebViewTest.cpp:
+
 2013-01-04  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed.  Rolled DEPS.


Modified: trunk/Source/WebKit/chromium/src/AsyncFileSystemChromium.cpp (138797 => 138798)

--- trunk/Source/WebKit/chromium/src/AsyncFileSystemChromium.cpp	2013-01-04 15:25:35 UTC (rev 138797)
+++

[webkit-changes] [138742] trunk/Source/WebKit/chromium

2013-01-03 Thread pilgrim
Title: [138742] trunk/Source/WebKit/chromium








Revision 138742
Author pilg...@chromium.org
Date 2013-01-03 14:26:02 -0800 (Thu, 03 Jan 2013)


Log Message
[Chromium] Remove all references to sharedWorkerRepository()
https://bugs.webkit.org/show_bug.cgi?id=104704

Reviewed by Adam Barth.

Now that Chromium calls setSharedWorkerRepository upon
initializing WebKit (
https://codereview.chromium.org/10990121/ and
https://codereview.chromium.org/11576028/ ) and no longer
tries to override sharedWorkerRepository, it is safe to remove
all references to this function.

* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):
* src/SharedWorkerRepository.cpp:
(WebKit::sharedWorkerRepository):
(WebCore::SharedWorkerRepository::isAvailable):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (138741 => 138742)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-03 22:23:40 UTC (rev 138741)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-03 22:26:02 UTC (rev 138742)
@@ -1,3 +1,24 @@
+2013-01-03  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove all references to sharedWorkerRepository()
+https://bugs.webkit.org/show_bug.cgi?id=104704
+
+Reviewed by Adam Barth.
+
+Now that Chromium calls setSharedWorkerRepository upon
+initializing WebKit (
+https://codereview.chromium.org/10990121/ and
+https://codereview.chromium.org/11576028/ ) and no longer
+tries to override sharedWorkerRepository, it is safe to remove
+all references to this function.
+
+* public/platform/WebKitPlatformSupport.h:
+(WebKit):
+(WebKit::WebKitPlatformSupport::idbFactory):
+* src/SharedWorkerRepository.cpp:
+(WebKit::sharedWorkerRepository):
+(WebCore::SharedWorkerRepository::isAvailable):
+
 2013-01-03  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Add a missing state to RTCPeerConnection


Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (138741 => 138742)

--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-01-03 22:23:40 UTC (rev 138741)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2013-01-03 22:26:02 UTC (rev 138742)
@@ -36,7 +36,6 @@
 namespace WebKit {
 
 class WebIDBFactory; // FIXME: Does this belong in platform?
-class WebSharedWorkerRepository; // FIXME: Does this belong in platform?
 
 // FIXME: Eventually all these API will need to move to WebKit::Platform.
 class WebKitPlatformSupport : public Platform {
@@ -45,11 +44,6 @@
 
 virtual WebIDBFactory* idbFactory() { return 0; }
 
-
-// Shared Workers --
-
-virtual WebSharedWorkerRepository* sharedWorkerRepository() { return 0; }
-
 protected:
 ~WebKitPlatformSupport() { }
 };


Modified: trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp (138741 => 138742)

--- trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2013-01-03 22:23:40 UTC (rev 138741)
+++ trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2013-01-03 22:26:02 UTC (rev 138742)
@@ -69,15 +69,8 @@
 
 static WebSharedWorkerRepository* sharedWorkerRepository()
 {
-WebSharedWorkerRepository* repository;
-
-repository = s_sharedWorkerRepository;
-if (!repository) {
-repository = webKitPlatformSupport()-sharedWorkerRepository();
-setSharedWorkerRepository(repository);
-}
-
-return repository;
+// Will only be non-zero if the embedder has set the shared worker repository upon initialization. Nothing in WebKit sets this.
+return s_sharedWorkerRepository;
 }
 
 }
@@ -218,8 +211,6 @@
 
 bool SharedWorkerRepository::isAvailable()
 {
-// Allow the WebKitPlatformSupport to determine if SharedWorkers
-// are available.
 return WebKit::sharedWorkerRepository();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [138673] trunk/Source/WebKit/chromium

2013-01-02 Thread pilgrim
Title: [138673] trunk/Source/WebKit/chromium








Revision 138673
Author pilg...@chromium.org
Date 2013-01-02 16:08:50 -0800 (Wed, 02 Jan 2013)


Log Message
[Chromium] Add Platform/chromium to include_dirs
https://bugs.webkit.org/show_bug.cgi?id=105955

Reviewed by James Robinson.

Currently the headers in WebKit/chromium/public/Web*.h can not
include headers from the new Platform/chromium/ directory with the
#include public/WebFoo.h syntax, because the include_dirs for
dependent builds (like Chromium-within-WebKit) do not include the
new Platform/chromium/ directory. This patch adds that capability
without managing to break anything else.

* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (138672 => 138673)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-02 23:56:48 UTC (rev 138672)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-03 00:08:50 UTC (rev 138673)
@@ -1,3 +1,19 @@
+2013-01-02  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Add Platform/chromium to include_dirs
+https://bugs.webkit.org/show_bug.cgi?id=105955
+
+Reviewed by James Robinson.
+
+Currently the headers in WebKit/chromium/public/Web*.h can not
+include headers from the new Platform/chromium/ directory with the
+#include public/WebFoo.h syntax, because the include_dirs for
+dependent builds (like Chromium-within-WebKit) do not include the
+new Platform/chromium/ directory. This patch adds that capability
+without managing to break anything else.
+
+* WebKit.gyp:
+
 2013-01-02  Alec Flett  alecfl...@chromium.org
 
 IndexedDB: Use non-const buffers in put() to avoid copies


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (138672 => 138673)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-02 23:56:48 UTC (rev 138672)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2013-01-03 00:08:50 UTC (rev 138673)
@@ -854,6 +854,11 @@
 ],
 }],
 ],
+'direct_dependent_settings': {
+'include_dirs': [
+'../../Platform/chromium/',
+],
+},
 'target_conditions': [
 ['OS==android', {
 'sources/': [
@@ -902,6 +907,7 @@
 'include_dirs': [
 'public',
 '../../WebCore/testing/v8', # for WebCoreTestSupport.h, needed to link in window.internals code.
+'../../Platform/chromium/',
 ],
 'sources': [
 'src/WebTestingSupport.cpp',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [138215] trunk/Source/WebKit/chromium

2012-12-19 Thread pilgrim
Title: [138215] trunk/Source/WebKit/chromium








Revision 138215
Author pilg...@chromium.org
Date 2012-12-19 21:23:07 -0800 (Wed, 19 Dec 2012)


Log Message
[Chromium] Remove all references to sharedWorkerRepository()
https://bugs.webkit.org/show_bug.cgi?id=104704

Reviewed by Darin Fisher.

Now that Chromium calls setSharedWorkerRepository upon
initializing WebKit (
https://codereview.chromium.org/10990121/ and
https://codereview.chromium.org/11576028/ ) and no longer
tries to override sharedWorkerRepository, it is safe to remove
all references to this function.

* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):
* src/SharedWorkerRepository.cpp:
(WebKit::sharedWorkerRepository):
(WebCore::SharedWorkerRepository::isAvailable):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (138214 => 138215)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-20 04:07:42 UTC (rev 138214)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-20 05:23:07 UTC (rev 138215)
@@ -1,3 +1,24 @@
+2012-12-19  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove all references to sharedWorkerRepository()
+https://bugs.webkit.org/show_bug.cgi?id=104704
+
+Reviewed by Darin Fisher.
+
+Now that Chromium calls setSharedWorkerRepository upon
+initializing WebKit (
+https://codereview.chromium.org/10990121/ and
+https://codereview.chromium.org/11576028/ ) and no longer
+tries to override sharedWorkerRepository, it is safe to remove
+all references to this function.
+
+* public/platform/WebKitPlatformSupport.h:
+(WebKit):
+(WebKit::WebKitPlatformSupport::idbFactory):
+* src/SharedWorkerRepository.cpp:
+(WebKit::sharedWorkerRepository):
+(WebCore::SharedWorkerRepository::isAvailable):
+
 2012-12-19  Alexis Menard  ale...@webkit.org
 
 Implement CSS parsing for CSS transitions unprefixed.


Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (138214 => 138215)

--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2012-12-20 04:07:42 UTC (rev 138214)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2012-12-20 05:23:07 UTC (rev 138215)
@@ -36,7 +36,6 @@
 namespace WebKit {
 
 class WebIDBFactory; // FIXME: Does this belong in platform?
-class WebSharedWorkerRepository; // FIXME: Does this belong in platform?
 
 // FIXME: Eventually all these API will need to move to WebKit::Platform.
 class WebKitPlatformSupport : public Platform {
@@ -45,11 +44,6 @@
 
 virtual WebIDBFactory* idbFactory() { return 0; }
 
-
-// Shared Workers --
-
-virtual WebSharedWorkerRepository* sharedWorkerRepository() { return 0; }
-
 protected:
 ~WebKitPlatformSupport() { }
 };


Modified: trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp (138214 => 138215)

--- trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2012-12-20 04:07:42 UTC (rev 138214)
+++ trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2012-12-20 05:23:07 UTC (rev 138215)
@@ -69,15 +69,8 @@
 
 static WebSharedWorkerRepository* sharedWorkerRepository()
 {
-WebSharedWorkerRepository* repository;
-
-repository = s_sharedWorkerRepository;
-if (!repository) {
-repository = webKitPlatformSupport()-sharedWorkerRepository();
-setSharedWorkerRepository(repository);
-}
-
-return repository;
+// Will only be non-zero if the embedder has set the shared worker repository upon initialization. Nothing in WebKit sets this.
+return s_sharedWorkerRepository;
 }
 
 }
@@ -218,8 +211,6 @@
 
 bool SharedWorkerRepository::isAvailable()
 {
-// Allow the WebKitPlatformSupport to determine if SharedWorkers
-// are available.
 return WebKit::sharedWorkerRepository();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [138221] trunk/Source/WebKit/chromium

2012-12-19 Thread pilgrim
Title: [138221] trunk/Source/WebKit/chromium








Revision 138221
Author pilg...@chromium.org
Date 2012-12-19 21:44:24 -0800 (Wed, 19 Dec 2012)


Log Message
[Chromium] add setIDBFactory method for embedders to call
https://bugs.webkit.org/show_bug.cgi?id=105465

Reviewed by Darin Fisher.

This is step 1 of getting rid of WebKitPlatform::idbFactory. This
adds a setter for embedders to call upon initialization, which (if
set) will be used instead of calling the idbFactory()
method. Eventually the idbFactory() method will go away, and this
setter will be the only way to initialize the Indexed Database API.

* public/WebIDBFactory.h:
(WebKit):
* src/IDBFactoryBackendProxy.cpp:
(WebKit):
(WebKit::setIDBFactory):
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBFactory.h
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (138220 => 138221)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-20 05:39:39 UTC (rev 138220)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-20 05:44:24 UTC (rev 138221)
@@ -1,3 +1,23 @@
+2012-12-19  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] add setIDBFactory method for embedders to call
+https://bugs.webkit.org/show_bug.cgi?id=105465
+
+Reviewed by Darin Fisher.
+
+This is step 1 of getting rid of WebKitPlatform::idbFactory. This
+adds a setter for embedders to call upon initialization, which (if
+set) will be used instead of calling the idbFactory()
+method. Eventually the idbFactory() method will go away, and this
+setter will be the only way to initialize the Indexed Database API.
+
+* public/WebIDBFactory.h:
+(WebKit):
+* src/IDBFactoryBackendProxy.cpp:
+(WebKit):
+(WebKit::setIDBFactory):
+(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
+
 2012-12-19  Rachel Blum  gr...@chromium.org
 
 [Chromium] Check Document now should work with continuous check off


Modified: trunk/Source/WebKit/chromium/public/WebIDBFactory.h (138220 => 138221)

--- trunk/Source/WebKit/chromium/public/WebIDBFactory.h	2012-12-20 05:39:39 UTC (rev 138220)
+++ trunk/Source/WebKit/chromium/public/WebIDBFactory.h	2012-12-20 05:44:24 UTC (rev 138221)
@@ -63,6 +63,9 @@
 virtual void deleteDatabase(const WebString name, WebIDBCallbacks*, const WebSecurityOrigin, WebFrame*, const WebString dataDir) { WEBKIT_ASSERT_NOT_REACHED(); }
 };
 
+// Initializes IndexedDB support.
+WEBKIT_EXPORT void setIDBFactory(WebIDBFactory*);
+
 } // namespace WebKit
 
 #endif // WebIDBFactory_h


Modified: trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp (138220 => 138221)

--- trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp	2012-12-20 05:39:39 UTC (rev 138220)
+++ trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp	2012-12-20 05:44:24 UTC (rev 138221)
@@ -61,14 +61,24 @@
 
 namespace WebKit {
 
+static WebIDBFactory* s_webIDBFactory = 0;
+
+void setIDBFactory(WebIDBFactory* factory)
+{
+s_webIDBFactory = factory;
+}
+
 PassRefPtrIDBFactoryBackendInterface IDBFactoryBackendProxy::create()
 {
 return adoptRef(new IDBFactoryBackendProxy());
 }
 
 IDBFactoryBackendProxy::IDBFactoryBackendProxy()
-: m_webIDBFactory(webKitPlatformSupport()-idbFactory())
 {
+if (s_webIDBFactory)
+m_webIDBFactory = s_webIDBFactory;
+else
+m_webIDBFactory = webKitPlatformSupport()-idbFactory();
 }
 
 IDBFactoryBackendProxy::~IDBFactoryBackendProxy()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [138225] trunk/Source

2012-12-19 Thread pilgrim
Title: [138225] trunk/Source








Revision 138225
Author pilg...@chromium.org
Date 2012-12-19 21:52:36 -0800 (Wed, 19 Dec 2012)


Log Message
[Chromium] Remove idbFactory from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=105460

Reviewed by Darin Fisher.

Part of a larger refactoring series; see tracking bug 82948.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/PlatformSupport.h: Removed.
* storage/chromium: Removed.
* storage/chromium/IDBFactoryBackendInterface.cpp: Removed.

Source/WebKit/chromium:

* WebKit.gyp:
* src/IDBFactoryBackendInterface.cpp: Added.
(WebCore):
(WebCore::IDBFactoryBackendInterface::create):
* src/PlatformSupport.cpp: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp


Added Paths

trunk/Source/WebKit/chromium/src/IDBFactoryBackendInterface.cpp


Removed Paths

trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/storage/chromium/IDBFactoryBackendInterface.cpp
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (138224 => 138225)

--- trunk/Source/WebCore/ChangeLog	2012-12-20 05:50:34 UTC (rev 138224)
+++ trunk/Source/WebCore/ChangeLog	2012-12-20 05:52:36 UTC (rev 138225)
@@ -1,3 +1,18 @@
+2012-12-19  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove idbFactory from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=105460
+
+Reviewed by Darin Fisher.
+
+Part of a larger refactoring series; see tracking bug 82948.
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+* platform/chromium/PlatformSupport.h: Removed.
+* storage/chromium: Removed.
+* storage/chromium/IDBFactoryBackendInterface.cpp: Removed.
+
 2012-12-19  Eric Carlson  eric.carl...@apple.com
 
 Crash in TextTrack::trackIndexRelativeToRenderedTracks()


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (138224 => 138225)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-12-20 05:50:34 UTC (rev 138224)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-12-20 05:52:36 UTC (rev 138225)
@@ -144,7 +144,6 @@
   '../rendering/style',
   '../rendering/svg',
   '../storage',
-  '../storage/chromium',
   '../svg',
   '../svg/animation',
   '../svg/graphics',


Modified: trunk/Source/WebCore/WebCore.gypi (138224 => 138225)

--- trunk/Source/WebCore/WebCore.gypi	2012-12-20 05:50:34 UTC (rev 138224)
+++ trunk/Source/WebCore/WebCore.gypi	2012-12-20 05:52:36 UTC (rev 138225)
@@ -2579,7 +2579,6 @@
 'storage/StorageTrackerClient.h',
 'storage/StorageTracker.cpp',
 'storage/StorageTracker.h',
-'storage/chromium/IDBFactoryBackendInterface.cpp',
 'workers/AbstractWorker.cpp',
 'workers/AbstractWorker.h',
 'workers/DedicatedWorkerContext.cpp',
@@ -3653,7 +3652,6 @@
 'platform/chromium/PasteboardChromium.cpp',
 'platform/chromium/PlatformKeyboardEventChromium.cpp',
 'platform/chromium/PlatformScreenChromium.cpp',
-'platform/chromium/PlatformSupport.h',
 'platform/chromium/PlatformThemeChromiumDefault.cpp',
 'platform/chromium/PlatformThemeChromiumDefault.h',
 'platform/chromium/PlatformWidget.h',


Deleted: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (138224 => 138225)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-12-20 05:50:34 UTC (rev 138224)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-12-20 05:52:36 UTC (rev 138225)
@@ -1,52 +0,0 @@
-/*
- * Copyright (c) 2010, Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUEN

[webkit-changes] [137926] trunk/Tools

2012-12-17 Thread pilgrim
Title: [137926] trunk/Tools








Revision 137926
Author pilg...@chromium.org
Date 2012-12-17 11:32:26 -0800 (Mon, 17 Dec 2012)


Log Message
Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=105054

Reviewed by Jochen Eisinger.

Part of a refactoring series; see tracking bug 82948.

* DumpRenderTree/chromium/NotificationPresenter.cpp:
(NotificationPresenter::show):
* DumpRenderTree/chromium/Task.cpp:
(postTask):
* DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/NotificationPresenter.cpp
trunk/Tools/DumpRenderTree/chromium/Task.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp




Diff

Modified: trunk/Tools/ChangeLog (137925 => 137926)

--- trunk/Tools/ChangeLog	2012-12-17 19:21:05 UTC (rev 137925)
+++ trunk/Tools/ChangeLog	2012-12-17 19:32:26 UTC (rev 137926)
@@ -1,3 +1,18 @@
+2012-12-17  Mark Pilgrim  pilg...@chromium.org
+
+Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=105054
+
+Reviewed by Jochen Eisinger.
+
+Part of a refactoring series; see tracking bug 82948.
+
+* DumpRenderTree/chromium/NotificationPresenter.cpp:
+(NotificationPresenter::show):
+* DumpRenderTree/chromium/Task.cpp:
+(postTask):
+* DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
+
 2012-12-17  Emil A Eklund  e...@chromium.org
 
 Clamp values in LayoutUnit::operator/ when SATURATED_LAYOUT_ARITHMETIC is enabled


Modified: trunk/Tools/DumpRenderTree/chromium/NotificationPresenter.cpp (137925 => 137926)

--- trunk/Tools/DumpRenderTree/chromium/NotificationPresenter.cpp	2012-12-17 19:21:05 UTC (rev 137925)
+++ trunk/Tools/DumpRenderTree/chromium/NotificationPresenter.cpp	2012-12-17 19:32:26 UTC (rev 137926)
@@ -34,13 +34,13 @@
 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
 
 #include WebKit.h
-#include platform/WebKitPlatformSupport.h
 #include WebNotification.h
 #include WebNotificationPermissionCallback.h
 #include WebSecurityOrigin.h
 #include platform/WebString.h
 #include platform/WebURL.h
 #include googleurl/src/gurl.h
+#include public/Platform.h
 #include wtf/text/CString.h
 #include wtf/text/WTFString.h
 
@@ -111,7 +111,7 @@
 WTF::String id(identifier.data(), identifier.length());
 m_activeNotifications.set(id, notification);
 
-webKitPlatformSupport()-callOnMainThread(deferredDisplayDispatch, new WebNotification(notification));
+Platform::current()-callOnMainThread(deferredDisplayDispatch, new WebNotification(notification));
 return true;
 }
 


Modified: trunk/Tools/DumpRenderTree/chromium/Task.cpp (137925 => 137926)

--- trunk/Tools/DumpRenderTree/chromium/Task.cpp	2012-12-17 19:21:05 UTC (rev 137925)
+++ trunk/Tools/DumpRenderTree/chromium/Task.cpp	2012-12-17 19:32:26 UTC (rev 137926)
@@ -33,8 +33,8 @@
 
 #include WebKit.h
 #include WebTask.h
-#include platform/WebKitPlatformSupport.h
 #include webkit/support/webkit_support.h
+#include public/Platform.h
 #include wtf/OwnPtr.h
 #include wtf/PassOwnPtr.h
 
@@ -70,7 +70,7 @@
 
 void postTask(WebTask* task)
 {
-webKitPlatformSupport()-callOnMainThread(invokeTask, static_castvoid*(task));
+Platform::current()-callOnMainThread(invokeTask, static_castvoid*(task));
 }
 
 void postDelayedTask(WebTask* task, long long ms)


Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp (137925 => 137926)

--- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp	2012-12-17 19:21:05 UTC (rev 137925)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp	2012-12-17 19:32:26 UTC (rev 137926)
@@ -34,10 +34,10 @@
 #include WebTestDelegate.h
 #include WebTouchPoint.h
 #include platform/WebGraphicsContext3D.h
-#include platform/WebKitPlatformSupport.h
 #include public/WebCompositorSupport.h
 #include public/WebExternalTextureLayer.h
 #include public/WebExternalTextureLayerClient.h
+#include public/Platform.h
 #include wtf/Assertions.h
 #include wtf/OwnPtr.h
 #include wtf/PassOwnPtr.h
@@ -291,7 +291,7 @@
 bool WebTestPluginImpl::initialize(WebPluginContainer* container)
 {
 WebGraphicsContext3D::Attributes attrs;
-m_context = webKitPlatformSupport()-createOffscreenGraphicsContext3D(attrs);
+m_context = Platform::current()-createOffscreenGraphicsContext3D(attrs);
 if (!m_context)
 return false;
 
@@ -301,7 +301,7 @@
 if (!initScene())
 return false;
 
-m_layer = adoptPtr(webKitPlatformSupport()-compositorSupport()-createExternalTextureLayer(this));
+m_layer = adoptPtr(Platform::current()-compositorSupport()-createExternalTextureLayer(this));
 m_container = container;
 m_container-setWebLayer(m_layer-layer());
 m_container-requestTouchEventType(m_touch

[webkit-changes] [137490] trunk/Source/WebKit/chromium

2012-12-12 Thread pilgrim
Title: [137490] trunk/Source/WebKit/chromium








Revision 137490
Author pilg...@chromium.org
Date 2012-12-12 11:32:12 -0800 (Wed, 12 Dec 2012)


Log Message
[Chromium] Remove all references to sharedWorkerRepository()
https://bugs.webkit.org/show_bug.cgi?id=104704

Reviewed by James Robinson.

Now that Chromium calls setSharedWorkerRepository upon
initializing WebKit (
https://chromiumcodereview.appspot.com/10990121/ ) and no longer
tries to override sharedWorkerRepository, it is safe to remove
all references to this function.

* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):
* src/SharedWorkerRepository.cpp:
(WebKit::sharedWorkerRepository):
(WebCore::SharedWorkerRepository::isAvailable):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (137489 => 137490)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-12 19:27:35 UTC (rev 137489)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-12 19:32:12 UTC (rev 137490)
@@ -1,3 +1,23 @@
+2012-12-12  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove all references to sharedWorkerRepository()
+https://bugs.webkit.org/show_bug.cgi?id=104704
+
+Reviewed by James Robinson.
+
+Now that Chromium calls setSharedWorkerRepository upon
+initializing WebKit (
+https://chromiumcodereview.appspot.com/10990121/ ) and no longer
+tries to override sharedWorkerRepository, it is safe to remove
+all references to this function.
+
+* public/platform/WebKitPlatformSupport.h:
+(WebKit):
+(WebKit::WebKitPlatformSupport::idbFactory):
+* src/SharedWorkerRepository.cpp:
+(WebKit::sharedWorkerRepository):
+(WebCore::SharedWorkerRepository::isAvailable):
+
 2012-12-12  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Change the data channel descriptor pattern to a handler pattern


Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (137489 => 137490)

--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2012-12-12 19:27:35 UTC (rev 137489)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2012-12-12 19:32:12 UTC (rev 137490)
@@ -36,7 +36,6 @@
 namespace WebKit {
 
 class WebIDBFactory; // FIXME: Does this belong in platform?
-class WebSharedWorkerRepository; // FIXME: Does this belong in platform?
 
 // FIXME: Eventually all these API will need to move to WebKit::Platform.
 class WebKitPlatformSupport : public Platform {
@@ -45,11 +44,6 @@
 
 virtual WebIDBFactory* idbFactory() { return 0; }
 
-
-// Shared Workers --
-
-virtual WebSharedWorkerRepository* sharedWorkerRepository() { return 0; }
-
 protected:
 ~WebKitPlatformSupport() { }
 };


Modified: trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp (137489 => 137490)

--- trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2012-12-12 19:27:35 UTC (rev 137489)
+++ trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2012-12-12 19:32:12 UTC (rev 137490)
@@ -69,15 +69,8 @@
 
 static WebSharedWorkerRepository* sharedWorkerRepository()
 {
-WebSharedWorkerRepository* repository;
-
-repository = s_sharedWorkerRepository;
-if (!repository) {
-repository = webKitPlatformSupport()-sharedWorkerRepository();
-setSharedWorkerRepository(repository);
-}
-
-return repository;
+// Will only be non-zero if the embedder has set the shared worker repository upon initialization. Nothing in WebKit sets this.
+return s_sharedWorkerRepository;
 }
 
 }
@@ -218,8 +211,6 @@
 
 bool SharedWorkerRepository::isAvailable()
 {
-// Allow the WebKitPlatformSupport to determine if SharedWorkers
-// are available.
 return WebKit::sharedWorkerRepository();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [137327] trunk/Source

2012-12-11 Thread pilgrim
Title: [137327] trunk/Source








Revision 137327
Author pilg...@chromium.org
Date 2012-12-11 09:38:28 -0800 (Tue, 11 Dec 2012)


Log Message
[Chromium] Clean up unused interfaces in PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=104674

Reviewed by Darin Fisher.

Source/WebCore:

Part of a refactoring series. See tracking bug 82948. Also, there
were some function declarations that were supposed to be removed
as part of bug 102699 but got left out of the final patch.

* platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
* src/PlatformSupport.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (137326 => 137327)

--- trunk/Source/WebCore/ChangeLog	2012-12-11 17:34:15 UTC (rev 137326)
+++ trunk/Source/WebCore/ChangeLog	2012-12-11 17:38:28 UTC (rev 137327)
@@ -1,3 +1,18 @@
+2012-12-11  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Clean up unused interfaces in PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=104674
+
+Reviewed by Darin Fisher.
+
+Part of a refactoring series. See tracking bug 82948. Also, there
+were some function declarations that were supposed to be removed
+as part of bug 102699 but got left out of the final patch.
+
+* platform/chromium/PlatformSupport.h:
+(WebCore):
+(PlatformSupport):
+
 2012-12-11  Joone Hur  joone@intel.com, Gustavo Noronha Silva  gustavo.noro...@collabora.com
 
 [GTK] Update GraphicsLayerClutter


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (137326 => 137327)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-12-11 17:34:15 UTC (rev 137326)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-12-11 17:38:28 UTC (rev 137327)
@@ -31,42 +31,12 @@
 #ifndef PlatformSupport_h
 #define PlatformSupport_h
 
-#if ENABLE(WEB_AUDIO)
-#include AudioBus.h
-#endif
-
-#include FileSystem.h
-#include ImageSource.h
-#include LinkHash.h
-#include PluginData.h
-
 #include wtf/Forward.h
-#include wtf/HashSet.h
-#include wtf/PassRefPtr.h
-#include wtf/Vector.h
 
-typedef struct NPObject NPObject;
-typedef struct _NPP NPP_t;
-typedef NPP_t* NPP;
-
 namespace WebCore {
 
-class Color;
-class Cursor;
-class Document;
-class Frame;
-class GeolocationServiceBridge;
-class GeolocationServiceChromium;
-class GraphicsContext;
-class Image;
 class IDBFactoryBackendInterface;
-class IntRect;
-class KURL;
-class SerializedScriptValue;
-class Widget;
 
-struct FontRenderStyle;
-
 // PlatformSupport an interface to the embedding layer that lets the embedder
 // supply implementations for Platform functionality that WebCore cannot access
 // directly (for example, because WebCore is in a sandbox).
@@ -75,28 +45,6 @@
 public:
 // IndexedDB --
 static PassRefPtrIDBFactoryBackendInterface idbFactory();
-
-// Theming 
-#if OS(WINDOWS)  !ENABLE(DEFAULT_RENDER_THEME)
-static void paintButton(
-GraphicsContext*, int part, int state, int classicState, const IntRect);
-static void paintMenuList(
-GraphicsContext*, int part, int state, int classicState, const IntRect);
-static void paintScrollbarArrow(
-GraphicsContext*, int state, int classicState, const IntRect);
-static void paintScrollbarThumb(
-GraphicsContext*, int part, int state, int classicState, const IntRect);
-static void paintScrollbarTrack(
-GraphicsContext*, int part, int state, int classicState, const IntRect, const IntRect alignRect);
-static void paintSpinButton(
-GraphicsContext*, int part, int state, int classicState, const IntRect);
-static void paintTextField(
-GraphicsContext*, int part, int state, int classicState, const IntRect, const Color, bool fillContentArea, bool drawEdges);
-static void paintTrackbar(
-GraphicsContext*, int part, int state, int classicState, const IntRect);
-static void paintProgressBar(
-GraphicsContext*, const IntRect barRect, const IntRect valueRect, bool determinate, double animatedSeconds);
-#endif
 };
 
 } // namespace WebCore


Modified: trunk/Source/WebKit/chromium/ChangeLog (137326 => 137327)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-11 17:34:15 UTC (rev 137326)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-11 17:38:28 UTC (rev 137327)
@@ -1,3 +1,15 @@
+2012-12-11  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Clean up unused interfaces in PlatformSupport
+https://bugs.w

[webkit-changes] [137177] trunk/Source

2012-12-10 Thread pilgrim
Title: [137177] trunk/Source








Revision 137177
Author pilg...@chromium.org
Date 2012-12-10 10:22:28 -0800 (Mon, 10 Dec 2012)


Log Message
[Chromium] Move getPluginsList out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96507

Reviewed by Darin Fisher.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::getPluginList):
* chromium/public/WebPluginListBuilder.h: Added.
(WebKit):
(WebPluginListBuilder):

Source/WebCore:

* WebCore.gypi:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* plugins/chromium/PluginDataChromium.cpp:
(WebCore::PluginCache::plugins):
* plugins/chromium/PluginListBuilder.cpp: Added.
(WebKit):
(WebKit::PluginListBuilder::addPlugin):
(WebKit::PluginListBuilder::addMediaTypeToLastPlugin):
(WebKit::PluginListBuilder::addFileExtensionToLastMediaType):
* plugins/chromium/PluginListBuilder.h: Added.
(WebKit):
(PluginListBuilder):
(WebKit::PluginListBuilder::PluginListBuilder):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebPluginListBuilder.h:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::idbFactory):
* src/WebPluginListBuilderImpl.cpp: Removed.
* src/WebPluginListBuilderImpl.h: Removed.

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/Platform/chromium/public/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/plugins/chromium/PluginDataChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/WebPluginListBuilder.h
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp


Added Paths

trunk/Source/Platform/chromium/public/WebPluginListBuilder.h
trunk/Source/WebCore/plugins/chromium/PluginListBuilder.cpp
trunk/Source/WebCore/plugins/chromium/PluginListBuilder.h


Removed Paths

trunk/Source/WebKit/chromium/src/WebPluginListBuilderImpl.cpp
trunk/Source/WebKit/chromium/src/WebPluginListBuilderImpl.h




Diff

Modified: trunk/Source/Platform/ChangeLog (137176 => 137177)

--- trunk/Source/Platform/ChangeLog	2012-12-10 18:21:31 UTC (rev 137176)
+++ trunk/Source/Platform/ChangeLog	2012-12-10 18:22:28 UTC (rev 137177)
@@ -1,3 +1,21 @@
+2012-12-10  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move getPluginsList out of PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=96507
+
+Reviewed by Darin Fisher.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* Platform.gypi:
+* chromium/public/Platform.h:
+(WebKit):
+(Platform):
+(WebKit::Platform::getPluginList):
+* chromium/public/WebPluginListBuilder.h: Added.
+(WebKit):
+(WebPluginListBuilder):
+
 2012-12-08  Gavin Peters  gav...@chromium.org
 
 Add status events on link rel=prerender elements.


Modified: trunk/Source/Platform/Platform.gypi (137176 => 137177)

--- trunk/Source/Platform/Platform.gypi	2012-12-10 18:21:31 UTC (rev 137176)
+++ trunk/Source/Platform/Platform.gypi	2012-12-10 18:22:28 UTC (rev 137177)
@@ -95,6 +95,7 @@
 'chromium/public/WebMessagePortChannelClient.h',
 'chromium/public/WebMimeRegistry.h',
 'chromium/public/WebNonCopyable.h',
+'chromium/public/WebPluginListBuilder.h',
 'chromium/public/WebPoint.h',
 'chromium/public/WebPrerender.h',
 'chromium/public/WebPrerenderingSupport.h',


Modified: trunk/Source/Platform/chromium/public/Platform.h (137176 => 137177)

--- trunk/Source/Platform/chromium/public/Platform.h	2012-12-10 18:21:31 UTC (rev 137176)
+++ trunk/Source/Platform/chromium/public/Platform.h	2012-12-10 18:22:28 UTC (rev 137177)
@@ -60,6 +60,7 @@
 class WebMediaStreamCenterClient;
 class WebMessagePortChannel;
 class WebMimeRegistry;
+class WebPluginListBuilder;
 class WebRTCPeerConnectionHandler;
 class WebRTCPeerConnectionHandlerClient;
 class WebSandboxSupport;
@@ -237,6 +238,13 @@
 virtual void cacheMetadata(const WebURL, double responseTime, const char* data, size_t dataSize) { }
 
 
+// Plugins -
+
+// If refresh is true, then cached information should not be used to
+// satisfy this call.
+virtual void getPluginList(bool refresh, WebPluginListBuilder*) { }
+
+
 // Resources ---
 
 // Returns a localized string resource (with substitution parameters).


Copied: trunk/Source/Platform/chromium/public/WebPluginListBuilder.h (from rev 137175, trunk/Source/WebKit/chromium/public/WebPluginListBuilder.h) (0 => 137177)

--- trunk/Sou

[webkit-changes] [137201] trunk/Source

2012-12-10 Thread pilgrim
Title: [137201] trunk/Source








Revision 137201
Author pilg...@chromium.org
Date 2012-12-10 13:33:18 -0800 (Mon, 10 Dec 2012)


Log Message
[Chromium][Win] Remove theme-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=102699

Reviewed by Adam Barth.

Call theme engine directly instead of going through
PlatformSupport. Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::RenderThemeChromiumWin::paintSliderThumb):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::pluginScriptableObject):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumWin.cpp
trunk/Source/WebCore/rendering/RenderThemeChromiumWin.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (137200 => 137201)

--- trunk/Source/WebCore/ChangeLog	2012-12-10 21:22:44 UTC (rev 137200)
+++ trunk/Source/WebCore/ChangeLog	2012-12-10 21:33:18 UTC (rev 137201)
@@ -1,3 +1,28 @@
+2012-12-10  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium][Win] Remove theme-related functions from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=102699
+
+Reviewed by Adam Barth.
+
+Call theme engine directly instead of going through
+PlatformSupport. Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* platform/chromium/ScrollbarThemeChromiumWin.cpp:
+(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
+(WebCore::ScrollbarThemeChromiumWin::paintButton):
+* rendering/RenderThemeChromiumWin.cpp:
+(WebCore):
+(WebCore::RenderThemeChromiumWin::paintButton):
+(WebCore::RenderThemeChromiumWin::paintSliderTrack):
+(WebCore::RenderThemeChromiumWin::paintSliderThumb):
+(WebCore::RenderThemeChromiumWin::paintMenuList):
+(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
+(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
+(WebCore::RenderThemeChromiumWin::paintProgressBar):
+
 2012-12-10  Dean Jackson  d...@apple.com
 
 Support for CSS widows and orphans


Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumWin.cpp (137200 => 137201)

--- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumWin.cpp	2012-12-10 21:22:44 UTC (rev 137200)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumWin.cpp	2012-12-10 21:33:18 UTC (rev 137201)
@@ -34,9 +34,11 @@
 #include LayoutTestSupport.h
 #include PlatformContextSkia.h
 #include PlatformMouseEvent.h
-#include PlatformSupport.h
 #include Scrollbar.h
 #include SystemInfo.h
+#include public/Platform.h
+#include public/WebRect.h
+#include public/win/WebThemeEngine.h
 
 namespace WebCore {
 
@@ -104,14 +106,10 @@
 
 IntRect alignRect = trackRect(scrollbar, false);
 
+WebKit::WebCanvas* canvas = gc-platformContext()-canvas();
 // Draw the track area before/after the thumb on the scroll bar.
-PlatformSupport::paintScrollbarTrack(
-gc,
-partId,
-getThemeState(scrollbar, partType),
-getClassicThemeState(scrollbar, partType),
-rect,
-alignRect);
+WebKit::Platform::current()-themeEngine()-paintScrollbarTrack(canvas, partId, getThemeState(scrollbar, partType), getClassicThemeState(scrollbar, partType), WebKit::WebRect(rect), WebKit::WebRect(alignRect));
+
 }
 
 void ScrollbarThemeChromiumWin::paintButton(GraphicsContext* gc, ScrollbarThemeClient* scrollbar, const IntRect rect, ScrollbarPart part)
@@ -124,33 +122,21 @@
 else
 partId = horz ? DFCS_SCROLLRIGHT : DFCS_SCROLLDOWN;
 
+WebKit::WebCanvas* canvas = gc-platformContext()-canvas();
 // Draw the thumb (the box you drag in the scroll bar to scroll).
-PlatformSupport::paintScrollbarArrow(
-gc,
-getThemeArrowState(scrollbar, part),
-partId | getClassicThemeState(scrollbar, part),
-rect);
+WebKit::Platform::current()-themeEngine()-paintScrollbarArrow(canvas, getThemeArrowState(scrollbar, part), partId | getClassicThemeState(scrollbar, part), WebKit::WebRect(rect));
 }
 
 void ScrollbarThemeChromiumWin::paintThumb(GraphicsContext* gc, ScrollbarThemeClient* scrollbar, const I

[webkit-changes] [136951] trunk/Source/WebKit/chromium

2012-12-07 Thread pilgrim
Title: [136951] trunk/Source/WebKit/chromium








Revision 136951
Author pilg...@chromium.org
Date 2012-12-07 06:47:44 -0800 (Fri, 07 Dec 2012)


Log Message
[Chromium] Move WorkerContextProxy::create out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=104151

Reviewed by Kentaro Hara.

Doesn't really solve the layering violation as much as kick it
down the road a bit. Part of a refactoring series; see tracking
bug 82948.

* WebKit.gyp:
* src/PlatformSupport.cpp:
(WebCore):
* src/WorkerContextProxy.cpp: Added.
(WebCore):
(WebCore::WebCore::WorkerContextProxy::create):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp


Added Paths

trunk/Source/WebKit/chromium/src/WorkerContextProxy.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (136950 => 136951)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-07 14:30:58 UTC (rev 136950)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-07 14:47:44 UTC (rev 136951)
@@ -1,3 +1,21 @@
+2012-12-07  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move WorkerContextProxy::create out of PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=104151
+
+Reviewed by Kentaro Hara.
+
+Doesn't really solve the layering violation as much as kick it
+down the road a bit. Part of a refactoring series; see tracking
+bug 82948.
+
+* WebKit.gyp:
+* src/PlatformSupport.cpp:
+(WebCore):
+* src/WorkerContextProxy.cpp: Added.
+(WebCore):
+(WebCore::WebCore::WorkerContextProxy::create):
+
 2012-12-07  Ilya Tikhonovsky  loi...@chromium.org
 
 Unreviewed roll crhomium to r171707.


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (136950 => 136951)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-12-07 14:30:58 UTC (rev 136950)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-12-07 14:47:44 UTC (rev 136951)
@@ -661,6 +661,7 @@
 'src/WorkerAsyncFileSystemChromium.h',
 'src/WorkerAsyncFileWriterChromium.cpp',
 'src/WorkerAsyncFileWriterChromium.h',
+'src/WorkerContextProxy.cpp',
 'src/WorkerFileSystemCallbacksBridge.cpp',
 'src/WorkerFileSystemCallbacksBridge.h',
 'src/WorkerFileWriterCallbacksBridge.cpp',


Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (136950 => 136951)

--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-12-07 14:30:58 UTC (rev 136950)
+++ trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-12-07 14:47:44 UTC (rev 136951)
@@ -46,7 +46,6 @@
 #include WebScreenInfo.h
 #include WebViewClient.h
 #include WebViewImpl.h
-#include WebWorkerClientImpl.h
 #include platform/WebAudioBus.h
 #include platform/WebData.h
 #include platform/WebDragData.h
@@ -205,15 +204,4 @@
 
 #endif
 
-// These are temporary methods that the WebKit layer can use to call to the
-// Glue layer. Once the Glue layer moves entirely into the WebKit layer, these
-// methods will be deleted.
-
-#if ENABLE(WORKERS)
-WorkerContextProxy* WorkerContextProxy::create(Worker* worker)
-{
-return WebWorkerClientImpl::createWorkerContextProxy(worker);
-}
-#endif
-
 } // namespace WebCore


Added: trunk/Source/WebKit/chromium/src/WorkerContextProxy.cpp (0 => 136951)

--- trunk/Source/WebKit/chromium/src/WorkerContextProxy.cpp	(rev 0)
+++ trunk/Source/WebKit/chromium/src/WorkerContextProxy.cpp	2012-12-07 14:47:44 UTC (rev 136951)
@@ -0,0 +1,49 @@
+/*
+ * Copyright (C) 2012 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABIL

[webkit-changes] [136735] trunk/Source

2012-12-05 Thread pilgrim
Title: [136735] trunk/Source








Revision 136735
Author pilg...@chromium.org
Date 2012-12-05 12:30:16 -0800 (Wed, 05 Dec 2012)


Log Message
[Chromium][Win] Remove theme-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=102699

Reviewed by Adam Barth.

Call theme engine directly instead of going through
PlatformSupport. Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::RenderThemeChromiumWin::paintSliderThumb):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::pluginScriptableObject):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumWin.cpp
trunk/Source/WebCore/rendering/RenderThemeChromiumWin.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (136734 => 136735)

--- trunk/Source/WebCore/ChangeLog	2012-12-05 20:28:07 UTC (rev 136734)
+++ trunk/Source/WebCore/ChangeLog	2012-12-05 20:30:16 UTC (rev 136735)
@@ -1,3 +1,28 @@
+2012-12-05  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium][Win] Remove theme-related functions from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=102699
+
+Reviewed by Adam Barth.
+
+Call theme engine directly instead of going through
+PlatformSupport. Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* platform/chromium/ScrollbarThemeChromiumWin.cpp:
+(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
+(WebCore::ScrollbarThemeChromiumWin::paintButton):
+* rendering/RenderThemeChromiumWin.cpp:
+(WebCore):
+(WebCore::RenderThemeChromiumWin::paintButton):
+(WebCore::RenderThemeChromiumWin::paintSliderTrack):
+(WebCore::RenderThemeChromiumWin::paintSliderThumb):
+(WebCore::RenderThemeChromiumWin::paintMenuList):
+(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
+(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
+(WebCore::RenderThemeChromiumWin::paintProgressBar):
+
 2012-12-05  Stephen White  senorbla...@chromium.org
 
 Unreviewed, rolling out r136609.


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (136734 => 136735)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-12-05 20:28:07 UTC (rev 136734)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-12-05 20:30:16 UTC (rev 136735)
@@ -78,28 +78,6 @@
 
 // Plugin -
 static bool plugins(bool refresh, VectorPluginInfo*);
-
-// Theming 
-#if OS(WINDOWS)  !ENABLE(DEFAULT_RENDER_THEME)
-static void paintButton(
-GraphicsContext*, int part, int state, int classicState, const IntRect);
-static void paintMenuList(
-GraphicsContext*, int part, int state, int classicState, const IntRect);
-static void paintScrollbarArrow(
-GraphicsContext*, int state, int classicState, const IntRect);
-static void paintScrollbarThumb(
-GraphicsContext*, int part, int state, int classicState, const IntRect);
-static void paintScrollbarTrack(
-GraphicsContext*, int part, int state, int classicState, const IntRect, const IntRect alignRect);
-static void paintSpinButton(
-GraphicsContext*, int part, int state, int classicState, const IntRect);
-static void paintTextField(
-GraphicsContext*, int part, int state, int classicState, const IntRect, const Color, bool fillContentArea, bool drawEdges);
-static void paintTrackbar(
-GraphicsContext*, int part, int state, int classicState, const IntRect);
-static void paintProgressBar(
-GraphicsContext*, const IntRect barRect, const IntRect valueRect, bool determinate, double animatedSeconds);
-#endif
 };
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumWin.cpp (136734 => 136735)

--- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumWin.cpp	2012-12-05 20:28:07 UTC (rev 136734)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromi

[webkit-changes] [136741] trunk/Source/WebKit/chromium

2012-12-05 Thread pilgrim
Title: [136741] trunk/Source/WebKit/chromium








Revision 136741
Author pilg...@chromium.org
Date 2012-12-05 12:49:21 -0800 (Wed, 05 Dec 2012)


Log Message
[Chromium] Move WorkerContextProxy::create out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=104151

Reviewed by Adam Barth.

Doesn't really solve the layering violation as much as kick it
down the road a bit. Part of a refactoring series; see tracking
bug 82948.

* WebKit.gyp:
* src/PlatformSupport.cpp:
(WebCore):
* src/WorkerContextProxy.cpp: Added.
(WebCore):
(WebCore::WebCore::WorkerContextProxy::create):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp


Added Paths

trunk/Source/WebKit/chromium/src/WorkerContextProxy.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (136740 => 136741)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-05 20:47:34 UTC (rev 136740)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-05 20:49:21 UTC (rev 136741)
@@ -1,5 +1,23 @@
 2012-12-05  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Move WorkerContextProxy::create out of PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=104151
+
+Reviewed by Adam Barth.
+
+Doesn't really solve the layering violation as much as kick it
+down the road a bit. Part of a refactoring series; see tracking
+bug 82948.
+
+* WebKit.gyp:
+* src/PlatformSupport.cpp:
+(WebCore):
+* src/WorkerContextProxy.cpp: Added.
+(WebCore):
+(WebCore::WebCore::WorkerContextProxy::create):
+
+2012-12-05  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium][Win] Remove theme-related functions from PlatformSupport
 https://bugs.webkit.org/show_bug.cgi?id=102699
 


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (136740 => 136741)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-12-05 20:47:34 UTC (rev 136740)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-12-05 20:49:21 UTC (rev 136741)
@@ -661,6 +661,7 @@
 'src/WorkerAsyncFileSystemChromium.h',
 'src/WorkerAsyncFileWriterChromium.cpp',
 'src/WorkerAsyncFileWriterChromium.h',
+'src/WorkerContextProxy.cpp',
 'src/WorkerFileSystemCallbacksBridge.cpp',
 'src/WorkerFileSystemCallbacksBridge.h',
 'src/WorkerFileWriterCallbacksBridge.cpp',


Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (136740 => 136741)

--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-12-05 20:47:34 UTC (rev 136740)
+++ trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-12-05 20:49:21 UTC (rev 136741)
@@ -46,7 +46,6 @@
 #include WebScreenInfo.h
 #include WebViewClient.h
 #include WebViewImpl.h
-#include WebWorkerClientImpl.h
 #include platform/WebAudioBus.h
 #include platform/WebData.h
 #include platform/WebDragData.h
@@ -92,15 +91,4 @@
 return true;  // FIXME: There is no need for this function to return a value.
 }
 
-// These are temporary methods that the WebKit layer can use to call to the
-// Glue layer. Once the Glue layer moves entirely into the WebKit layer, these
-// methods will be deleted.
-
-#if ENABLE(WORKERS)
-WorkerContextProxy* WorkerContextProxy::create(Worker* worker)
-{
-return WebWorkerClientImpl::createWorkerContextProxy(worker);
-}
-#endif
-
 } // namespace WebCore


Added: trunk/Source/WebKit/chromium/src/WorkerContextProxy.cpp (0 => 136741)

--- trunk/Source/WebKit/chromium/src/WorkerContextProxy.cpp	(rev 0)
+++ trunk/Source/WebKit/chromium/src/WorkerContextProxy.cpp	2012-12-05 20:49:21 UTC (rev 136741)
@@ -0,0 +1,49 @@
+/*
+ * Copyright (C) 2012 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO,

[webkit-changes] [136057] trunk/Source

2012-11-28 Thread pilgrim
Title: [136057] trunk/Source








Revision 136057
Author pilg...@chromium.org
Date 2012-11-28 14:35:36 -0800 (Wed, 28 Nov 2012)


Log Message
[Chromium][Win] Remove ensureFontLoaded from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97696

Reviewed by Adam Barth.

Move ensureFontLoaded() from PlatformSupport to
FontPlatformDataChromiumWin. Part of a refactoring series; see
tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::fontContainsCharacter):
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::drawGlyphsWin):
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::scriptFontProperties):
(WebCore):
(WebCore::FontPlatformData::ensureFontLoaded):
* platform/graphics/chromium/FontPlatformDataChromiumWin.h:
(FontPlatformData):
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::getGlyphIndices):
(WebCore::fillBMPGlyphs):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/UniscribeHelperTextRun.cpp:
(WebCore::UniscribeHelperTextRun::tryToPreloadFont):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::paintSkiaText):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp
trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp
trunk/Source/WebCore/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp
trunk/Source/WebCore/platform/graphics/chromium/FontPlatformDataChromiumWin.h
trunk/Source/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp
trunk/Source/WebCore/platform/graphics/chromium/SimpleFontDataChromiumWin.cpp
trunk/Source/WebCore/platform/graphics/chromium/UniscribeHelperTextRun.cpp
trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (136056 => 136057)

--- trunk/Source/WebCore/ChangeLog	2012-11-28 22:21:47 UTC (rev 136056)
+++ trunk/Source/WebCore/ChangeLog	2012-11-28 22:35:36 UTC (rev 136057)
@@ -1,3 +1,39 @@
+2012-11-28  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium][Win] Remove ensureFontLoaded from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97696
+
+Reviewed by Adam Barth.
+
+Move ensureFontLoaded() from PlatformSupport to
+FontPlatformDataChromiumWin. Part of a refactoring series; see
+tracking bug 82948.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* platform/graphics/chromium/FontCacheChromiumWin.cpp:
+(WebCore::fontContainsCharacter):
+* platform/graphics/chromium/FontChromiumWin.cpp:
+(WebCore::drawGlyphsWin):
+* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
+(WebCore::FontPlatformData::scriptFontProperties):
+(WebCore):
+(WebCore::FontPlatformData::ensureFontLoaded):
+* platform/graphics/chromium/FontPlatformDataChromiumWin.h:
+(FontPlatformData):
+* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
+(WebCore::getGlyphIndices):
+(WebCore::fillBMPGlyphs):
+* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
+(WebCore::SimpleFontData::platformInit):
+(WebCore::SimpleFontData::determinePitch):
+(WebCore::SimpleFontData::platformBoundsForGlyph):
+(WebCore::SimpleFontData::platformWidthForGlyph):
+* platform/graphics/chromium/UniscribeHelperTextRun.cpp:
+(WebCore::UniscribeHelperTextRun::tryToPreloadFont):
+* platform/graphics/skia/SkiaFontWin.cpp:
+(WebCore::paintSkiaText):
+
 2012-11-28  pe...@outlook.com  pe...@outlook.com
 
 [WinCairo] Crash when requesting favicon.


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (136056 => 136057)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-11-28 22:21:47 UTC (rev 136056)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-11-28 22:35:36 UTC (rev 136057)
@@ -49,10 +49,6 @@
 typedef struct _NPP NPP_t;
 typedef NPP_t* NPP;
 
-#if OS(WINDOWS)
-typedef struct HFONT__* HFONT;
-#endif
-
 namespace WebCore {
 
 class Color;
@@ -77,11 +73,6 @@
 
 class PlatformSupport {
 public:
-// Font ---
-#if OS(WINDOWS)
-static bool ensureFontLoaded(HFONT);
-#endif
-
 // IndexedDB --
 

[webkit-changes] [136059] trunk/Source

2012-11-28 Thread pilgrim
Title: [136059] trunk/Source








Revision 136059
Author pilg...@chromium.org
Date 2012-11-28 14:39:12 -0800 (Wed, 28 Nov 2012)


Log Message
[Chromium] Remove pluginsScriptableObject from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=103542

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* plugins/PluginViewBase.h:
(PluginViewBase):
(WebCore::PluginViewBase::scriptableObject):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/plugins/PluginViewBase.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (136058 => 136059)

--- trunk/Source/WebCore/ChangeLog	2012-11-28 22:37:06 UTC (rev 136058)
+++ trunk/Source/WebCore/ChangeLog	2012-11-28 22:39:12 UTC (rev 136059)
@@ -1,3 +1,20 @@
+2012-11-28  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove pluginsScriptableObject from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=103542
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* bindings/v8/ScriptController.cpp:
+(WebCore::ScriptController::createScriptInstanceForWidget):
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* plugins/PluginViewBase.h:
+(PluginViewBase):
+(WebCore::PluginViewBase::scriptableObject):
+
 2012-11-28  Otto Derek Cheung  otche...@rim.com
 
 [BlackBerry] CookieJarBlackBerry will use document settings for cookiesEnabled


Modified: trunk/Source/WebCore/bindings/v8/ScriptController.cpp (136058 => 136059)

--- trunk/Source/WebCore/bindings/v8/ScriptController.cpp	2012-11-28 22:37:06 UTC (rev 136058)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.cpp	2012-11-28 22:39:12 UTC (rev 136059)
@@ -47,9 +47,7 @@
 #include NPV8Object.h
 #include Node.h
 #include NotImplemented.h
-#include npruntime_impl.h
-#include npruntime_priv.h
-#include PlatformSupport.h
+#include PluginViewBase.h
 #include ScriptCallStack.h
 #include ScriptCallStackFactory.h
 #include ScriptRunner.h
@@ -67,6 +65,8 @@
 #include V8NPObject.h
 #include V8RecursionScope.h
 #include Widget.h
+#include npruntime_impl.h
+#include npruntime_priv.h
 #include wtf/CurrentTime.h
 #include wtf/StdLibExtras.h
 #include wtf/StringExtras.h
@@ -521,10 +521,10 @@
 {
 ASSERT(widget);
 
-if (widget-isFrameView())
+if (!widget-isPluginViewBase())
 return 0;
 
-NPObject* npObject = PlatformSupport::pluginScriptableObject(widget);
+NPObject* npObject = static_castPluginViewBase*(widget)-scriptableObject();
 
 if (!npObject)
 return 0;


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (136058 => 136059)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-11-28 22:37:06 UTC (rev 136058)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-11-28 22:39:12 UTC (rev 136059)
@@ -78,7 +78,6 @@
 
 // Plugin -
 static bool plugins(bool refresh, VectorPluginInfo*);
-static NPObject* pluginScriptableObject(Widget*);
 
 // Theming 
 #if OS(WINDOWS)  !ENABLE(DEFAULT_RENDER_THEME)


Modified: trunk/Source/WebCore/plugins/PluginViewBase.h (136058 => 136059)

--- trunk/Source/WebCore/plugins/PluginViewBase.h	2012-11-28 22:37:06 UTC (rev 136058)
+++ trunk/Source/WebCore/plugins/PluginViewBase.h	2012-11-28 22:39:12 UTC (rev 136059)
@@ -30,11 +30,16 @@
 #include Widget.h
 #include wtf/text/WTFString.h
 
+#if USE(V8)
+struct NPObject;
+#endif
+#if USE(JSC)
 namespace JSC {
 class ExecState;
 class JSGlobalObject;
 class JSObject;
 }
+#endif
 
 namespace WebCore {
 
@@ -48,7 +53,12 @@
 virtual PlatformLayer* platformLayer() const { return 0; }
 #endif
 
+#if USE(V8)
+virtual NPObject* scriptableObject() { return 0; }
+#endif
+#if USE(JSC)
 virtual JSC::JSObject* scriptObject(JSC::JSGlobalObject*) { return 0; }
+#endif
 virtual void storageBlockingStateChanged() { }
 virtual void privateBrowsingStateChanged(bool) { }
 virtual bool getFormValue(String) { return false; }


Modified: trunk/Source/WebKit/chromium/ChangeLog (136058 => 136059)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-11-28 22:37:06 UTC (rev 136058)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-11-28 22:39:12 UTC (rev 136059)
@@ -1,5 +1,19 @@
 2012-11-28  Mar

[webkit-changes] [134936] trunk/Source/WebCore

2012-11-16 Thread pilgrim
Title: [134936] trunk/Source/WebCore








Revision 134936
Author pilg...@chromium.org
Date 2012-11-16 05:35:47 -0800 (Fri, 16 Nov 2012)


Log Message
Expand PlatformCookieJar interface to allow for other ports
https://bugs.webkit.org/show_bug.cgi?id=102456

Reviewed by Adam Barth.

Add firstParty and cookieURL arguments to several functions to
prepare for integrating Chromium port into new PlatformCookieJar
interface.

* loader/CookieJar.cpp:
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
* platform/network/PlatformCookieJar.h:
(WebCore):
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
* platform/network/curl/CookieJarCurl.cpp:
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
* platform/network/mac/CookieJarMac.mm:
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
* platform/network/qt/CookieJarQt.cpp:
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
* platform/network/win/CookieJarWin.cpp:
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/CookieJar.cpp
trunk/Source/WebCore/platform/network/PlatformCookieJar.h
trunk/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp
trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp
trunk/Source/WebCore/platform/network/mac/CookieJarMac.mm
trunk/Source/WebCore/platform/network/qt/CookieJarQt.cpp
trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp
trunk/Source/WebCore/platform/network/win/CookieJarWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (134935 => 134936)

--- trunk/Source/WebCore/ChangeLog	2012-11-16 13:32:18 UTC (rev 134935)
+++ trunk/Source/WebCore/ChangeLog	2012-11-16 13:35:47 UTC (rev 134936)
@@ -1,3 +1,45 @@
+2012-11-16  Mark Pilgrim  pilg...@chromium.org
+
+Expand PlatformCookieJar interface to allow for other ports
+https://bugs.webkit.org/show_bug.cgi?id=102456
+
+Reviewed by Adam Barth.
+
+Add firstParty and cookieURL arguments to several functions to
+prepare for integrating Chromium port into new PlatformCookieJar
+interface.
+
+* loader/CookieJar.cpp:
+(WebCore::cookiesEnabled):
+(WebCore::cookieRequestHeaderFieldValue):
+(WebCore::getRawCookies):
+* platform/network/PlatformCookieJar.h:
+(WebCore):
+* platform/network/cf/CookieJarCFNet.cpp:
+(WebCore::cookieRequestHeaderFieldValue):
+(WebCore::cookiesEnabled):
+(WebCore::getRawCookies):
+* platform/network/curl/CookieJarCurl.cpp:
+(WebCore::cookieRequestHeaderFieldValue):
+(WebCore::cookiesEnabled):
+(WebCore::getRawCookies):
+* platform/network/mac/CookieJarMac.mm:
+(WebCore::cookieRequestHeaderFieldValue):
+(WebCore::cookiesEnabled):
+(WebCore::getRawCookies):
+* platform/network/qt/CookieJarQt.cpp:
+(WebCore::cookieRequestHeaderFieldValue):
+(WebCore::cookiesEnabled):
+(WebCore::getRawCookies):
+* platform/network/soup/CookieJarSoup.cpp:
+(WebCore::cookieRequestHeaderFieldValue):
+(WebCore::cookiesEnabled):
+(WebCore::getRawCookies):
+* platform/network/win/CookieJarWin.cpp:
+(WebCore::cookieRequestHeaderFieldValue):
+(WebCore::cookiesEnabled):
+(WebCore::getRawCookies):
+
 2012-11-16  Julien Chaffraix  jchaffr...@webkit.org
 
 RenderGrid should have a function to resolve grid position


Modified: trunk/Source/WebCore/loader/CookieJar.cpp (134935 => 134936)

--- trunk/Source/WebCore/loader/CookieJar.cpp	2012-11-16 13:32:18 UTC (rev 134935)
+++ trunk/Source/WebCore/loader/CookieJar.cpp	2012-11-16 13:35:47 UTC (rev 134936)
@@ -61,17 +61,17 @@
 
 bool cookiesEnabled(const Document* document)
 {
-return cookiesEnabled(networkingContext(document));
+return cookiesEnabled(networkingContext(document), document-firstPartyForCookies(), document-cookieURL());
 }
 
 String cookieRequestHeaderFieldValue(const Document* document, const KURL url)
 {
-return cookieRequestHeaderFieldValue(networkingContext(document), url);
+return cookieRequestHeaderFieldValue(networkingContext(document), document-firstPartyForCookies(), url);
 }
 
 bool getRawCookies(const Document* document, const KURL url, VectorCookie cookies)
 {
-return getRawCookies(networkingContext(document), url, cookies);
+return getRawCookies(networkingContext(document), document-firstPartyForCookies(), url, cookies);
 }
 
 void deleteCookie(const Document* document, const KU

[webkit-changes] [134973] trunk/Source

2012-11-16 Thread pilgrim
Title: [134973] trunk/Source








Revision 134973
Author pilg...@chromium.org
Date 2012-11-16 11:02:04 -0800 (Fri, 16 Nov 2012)


Log Message
[Chromium] Remove cookie-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=99340

Reviewed by Adam Barth.

Move cookie-related functions out of PlatformSupport and implement
new PlatformCookieJar interface via NetworkContext.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* loader/CookieJar.cpp:
* loader/chromium/CookieJarChromium.cpp: Removed.
* platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):
* platform/network/NetworkingContext.h:
(WebKit):
(NetworkingContext):
* platform/network/chromium/CookieJarChromium.cpp: Copied from Source/WebCore/loader/chromium/CookieJarChromium.cpp.
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):

Source/WebKit/chromium:

* WebKit.gyp:
* src/FrameNetworkingContextImpl.cpp: Added.
(WebKit):
(WebKit::FrameNetworkingContextImpl::cookieJar):
* src/FrameNetworkingContextImpl.h:
(FrameNetworkingContextImpl):
* src/PlatformSupport.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/loader/CookieJar.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/network/NetworkingContext.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/FrameNetworkingContextImpl.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp


Added Paths

trunk/Source/WebCore/platform/network/chromium/CookieJarChromium.cpp
trunk/Source/WebKit/chromium/src/FrameNetworkingContextImpl.cpp


Removed Paths

trunk/Source/WebCore/loader/chromium/CookieJarChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (134972 => 134973)

--- trunk/Source/WebCore/ChangeLog	2012-11-16 18:57:45 UTC (rev 134972)
+++ trunk/Source/WebCore/ChangeLog	2012-11-16 19:02:04 UTC (rev 134973)
@@ -1,3 +1,34 @@
+2012-11-16  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove cookie-related functions from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=99340
+
+Reviewed by Adam Barth.
+
+Move cookie-related functions out of PlatformSupport and implement
+new PlatformCookieJar interface via NetworkContext.
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+* loader/CookieJar.cpp:
+* loader/chromium/CookieJarChromium.cpp: Removed.
+* platform/chromium/PlatformSupport.h:
+(WebCore):
+(PlatformSupport):
+* platform/network/NetworkingContext.h:
+(WebKit):
+(NetworkingContext):
+* platform/network/chromium/CookieJarChromium.cpp: Copied from Source/WebCore/loader/chromium/CookieJarChromium.cpp.
+(WebCore::setCookiesFromDOM):
+(WebCore::cookiesForDOM):
+(WebCore::cookieRequestHeaderFieldValue):
+(WebCore::cookiesEnabled):
+(WebCore::getRawCookies):
+(WebCore::deleteCookie):
+(WebCore::getHostnamesWithCookies):
+(WebCore::deleteCookiesForHostname):
+(WebCore::deleteAllCookies):
+
 2012-11-16  Byungwoo Lee  bw80@samsung.com
 
 Fix assertion bug of build fix r134961


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (134972 => 134973)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-11-16 18:57:45 UTC (rev 134972)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-11-16 19:02:04 UTC (rev 134973)
@@ -2116,7 +2116,6 @@
 ['exclude', 'inspector/InspectorFrontendClientLocal\\.cpp$'],
 ['exclude', 'inspector/_javascript_[^/]*\\.cpp$'],
 ['exclude', 'loader/UserStyleSheetLoader\\.cpp$'],
-['exclude', 'loader/CookieJar\\.cpp$'],
 ['exclude', 'loader/appcache/'],
 ['exclude', 'loader/archive/cf/LegacyWebArchiveMac\\.mm$'],
 ['exclude', 'loader/archive/cf/LegacyWebArchive\\.cpp$'],


Modified: trunk/Source/WebCore/WebCore.gypi (134972 => 134973)

--- trunk/Source/WebCore/WebCore.gypi	2012-11-16 18:57:45 UTC (rev 134972)
+++ trunk/Source/WebCore/WebCore.gypi	2012-11-16 19:02:04 UTC (rev 134973)
@@ -3049,7 +3049,6 @@
 'loader/cache/MemoryCache.cpp',
 'loader/cf/ResourceLoaderCFNet.cpp',
 'loader/chromium/CachedRawResourceChromium.cpp',
-'loader/chromium/CookieJarChromium.cpp',
 'loader/chromium/DocumentThreadableLoaderChromium.cpp',
 'loader/chromium/ResourceLoaderChromium.cpp',
 'loader/chromium/SubresourceLoaderChromium.cpp',
@@ -5584,6 +5583,7 @@
 'platform/network/cf/SocketStreamHandleCFNet.cpp',
 'platform/network

[webkit-changes] [135013] trunk/Source

2012-11-16 Thread pilgrim
Title: [135013] trunk/Source








Revision 135013
Author pilg...@chromium.org
Date 2012-11-16 15:52:37 -0800 (Fri, 16 Nov 2012)


Log Message
[Chromium] Remove cookie-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=99340

Reviewed by Adam Barth.

Move cookie-related functions out of PlatformSupport and implement
new PlatformCookieJar interface via NetworkContext.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* loader/CookieJar.cpp:
* loader/chromium/CookieJarChromium.cpp: Removed.
* platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):
* platform/network/NetworkingContext.h:
(WebKit):
(NetworkingContext):
* platform/network/chromium/CookieJarChromium.cpp: Copied from Source/WebCore/loader/chromium/CookieJarChromium.cpp.
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):

Source/WebKit/chromium:

* WebKit.gyp:
* src/FrameNetworkingContextImpl.cpp: Added.
(WebKit):
(WebKit::FrameNetworkingContextImpl::cookieJar):
* src/FrameNetworkingContextImpl.h:
(FrameNetworkingContextImpl):
* src/PlatformSupport.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/loader/CookieJar.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/network/NetworkingContext.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/FrameNetworkingContextImpl.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp


Added Paths

trunk/Source/WebCore/platform/network/chromium/CookieJarChromium.cpp
trunk/Source/WebKit/chromium/src/FrameNetworkingContextImpl.cpp


Removed Paths

trunk/Source/WebCore/loader/chromium/CookieJarChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (135012 => 135013)

--- trunk/Source/WebCore/ChangeLog	2012-11-16 23:47:35 UTC (rev 135012)
+++ trunk/Source/WebCore/ChangeLog	2012-11-16 23:52:37 UTC (rev 135013)
@@ -1,3 +1,34 @@
+2012-11-16  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove cookie-related functions from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=99340
+
+Reviewed by Adam Barth.
+
+Move cookie-related functions out of PlatformSupport and implement
+new PlatformCookieJar interface via NetworkContext.
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+* loader/CookieJar.cpp:
+* loader/chromium/CookieJarChromium.cpp: Removed.
+* platform/chromium/PlatformSupport.h:
+(WebCore):
+(PlatformSupport):
+* platform/network/NetworkingContext.h:
+(WebKit):
+(NetworkingContext):
+* platform/network/chromium/CookieJarChromium.cpp: Copied from Source/WebCore/loader/chromium/CookieJarChromium.cpp.
+(WebCore::setCookiesFromDOM):
+(WebCore::cookiesForDOM):
+(WebCore::cookieRequestHeaderFieldValue):
+(WebCore::cookiesEnabled):
+(WebCore::getRawCookies):
+(WebCore::deleteCookie):
+(WebCore::getHostnamesWithCookies):
+(WebCore::deleteCookiesForHostname):
+(WebCore::deleteAllCookies):
+
 2012-11-16  Pablo Flouret  pab...@motorola.com
 
 [JSC] Don't sanitize window.onerror information on crossorigin-enabled scripts


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (135012 => 135013)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-11-16 23:47:35 UTC (rev 135012)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-11-16 23:52:37 UTC (rev 135013)
@@ -2116,7 +2116,6 @@
 ['exclude', 'inspector/InspectorFrontendClientLocal\\.cpp$'],
 ['exclude', 'inspector/_javascript_[^/]*\\.cpp$'],
 ['exclude', 'loader/UserStyleSheetLoader\\.cpp$'],
-['exclude', 'loader/CookieJar\\.cpp$'],
 ['exclude', 'loader/appcache/'],
 ['exclude', 'loader/archive/cf/LegacyWebArchiveMac\\.mm$'],
 ['exclude', 'loader/archive/cf/LegacyWebArchive\\.cpp$'],


Modified: trunk/Source/WebCore/WebCore.gypi (135012 => 135013)

--- trunk/Source/WebCore/WebCore.gypi	2012-11-16 23:47:35 UTC (rev 135012)
+++ trunk/Source/WebCore/WebCore.gypi	2012-11-16 23:52:37 UTC (rev 135013)
@@ -3049,7 +3049,6 @@
 'loader/cache/MemoryCache.cpp',
 'loader/cf/ResourceLoaderCFNet.cpp',
 'loader/chromium/CachedRawResourceChromium.cpp',
-'loader/chromium/CookieJarChromium.cpp',
 'loader/chromium/DocumentThreadableLoaderChromium.cpp',
 'loader/chromium/ResourceLoaderChromium.cpp',
 'loader/chromium/SubresourceLoaderChromium.cpp',
@@ -5584,6 +5583,7 @@
 'platform/network/cf/SocketStreamHandle

[webkit-changes] [132419] trunk/Source

2012-10-24 Thread pilgrim
Title: [132419] trunk/Source








Revision 132419
Author pilg...@chromium.org
Date 2012-10-24 16:19:45 -0700 (Wed, 24 Oct 2012)


Log Message
[Chromium] Remove screen-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97474

Reviewed by Adam Barth.

Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

Source/Platform:

* Platform.gypi:
* chromium/public/WebScreenInfo.h: Added.
(WebKit):
(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):

Source/WebCore:

* WebCore.gypi:
* platform/Widget.h:
* platform/chromium/PageClientChromium.h: Copied from Source/WebCore/platform/chromium/PlatformWidget.h.
(PageClientChromium):
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::toPlatformPageClient):
(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* public/WebScreenInfo.h:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::screenInfo):
(WebKit):
* src/ChromeClientImpl.h:
(WebKit):
(WebKit::ChromeClientImpl::platformPageClient):
(ChromeClientImpl):
* src/PlatformSupport.cpp:
(WebCore):
* src/WebPagePopupImpl.cpp:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/Widget.h
trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebScreenInfo.h
trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp
trunk/Source/WebKit/chromium/src/ChromeClientImpl.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp


Added Paths

trunk/Source/Platform/chromium/public/WebScreenInfo.h
trunk/Source/WebCore/platform/chromium/PageClientChromium.h




Diff

Modified: trunk/Source/Platform/ChangeLog (132418 => 132419)

--- trunk/Source/Platform/ChangeLog	2012-10-24 23:18:32 UTC (rev 132418)
+++ trunk/Source/Platform/ChangeLog	2012-10-24 23:19:45 UTC (rev 132419)
@@ -1,3 +1,23 @@
+2012-10-24  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove screen-related functions from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97474
+
+Reviewed by Adam Barth.
+
+Screen-related functions like screenHorizontalDPI that
+used to be on PlatformSupport are now accessed through a new
+PlatformPageClient attached to Widget in WebCore-land, which is
+implemented by ChromeClientImpl in WebKit-land, which proxies
+calls to WebWidgetClient, which is actually implemented in
+Chromium-land.
+
+* Platform.gypi:
+* chromium/public/WebScreenInfo.h: Added.
+(WebKit):
+(WebScreenInfo):
+(WebKit::WebScreenInfo::WebScreenInfo):
+
 2012-10-23  David Reveman  reve...@chromium.org
 
 [Chromium] Add CHROMIUM_texture_from_image extension support.


Modified: trunk/Source/Platform/Platform.gypi (132418 => 132419)

--- trunk/Source/Platform/Platform.gypi	2012-10-24 23:18:32 UTC (rev 132418)
+++ trunk/Source/Platform/Platform.gypi	2012-10-24 23:19:45 UTC (rev 132419)
@@ -119,6 +119,7 @@
 'chromium/public/WebRect.h',
 'chromium/public/WebReferrerPolicy.h',
 'chromium/public/WebRenderingStats.h',
+'chromium/public/WebScreenInfo.h',
 'chromium/public/WebScrollbar.h',
 'chromium/public/WebScrollbarLayer.h',
 'chromium/public/WebScrollbarThemeGeometry.h',


Copied: trunk/Source/Platform/chromium/public/WebScreenInfo.h (from rev 132417, trunk/Source/WebKit/chromium/public/WebScreenInfo.h) (0 => 132419)

--- trunk/Source/Platform/chromium/public/WebScreenInfo.h	(rev 0)
+++ trunk/Source/Platform/chromium/public/WebScreenInfo.h	2012-10-24 23:19:45 UTC (rev 132419)
@@ -0,0 +1,82 @@
+/*
+ * Copyright (C) 2009 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * 

[webkit-changes] [130530] trunk/Source/WebKit/chromium

2012-10-05 Thread pilgrim
Title: [130530] trunk/Source/WebKit/chromium








Revision 130530
Author pilg...@chromium.org
Date 2012-10-05 11:09:14 -0700 (Fri, 05 Oct 2012)


Log Message
[Chromium] Update some more #includes for Platform/ directory
https://bugs.webkit.org/show_bug.cgi?id=98534

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

* src/WebFormElement.cpp:
* src/WebFrameImpl.cpp:
* src/WebGeolocationClientMock.cpp:
* src/WebGeolocationError.cpp:
* src/WebGeolocationPermissionRequest.cpp:
* src/WebHistoryItem.cpp:
* src/WebHitTestResult.cpp:
* src/WebIDBTransactionImpl.h:
* src/WebIconLoadingCompletionImpl.h:
* src/WebImageDecoder.cpp:
* src/WebImageSkia.cpp:
* src/WebInputElement.cpp:
* src/WebKit.cpp:
* src/WebLabelElement.cpp:
* src/WebMediaStreamRegistry.cpp:
* src/WebNode.cpp:
* src/WebNotification.cpp:
* src/WebOptionElement.cpp:
* src/WebPageSerializer.cpp:
* src/WebPageSerializerImpl.cpp:
* src/WebPageSerializerImpl.h:
* src/WebPluginListBuilderImpl.cpp:
* src/WebPluginLoadObserver.h:
* src/WebPopupMenuImpl.cpp:
* src/WebPopupMenuImpl.h:
* src/WebRange.cpp:
* src/WebRegularExpression.cpp:
* src/WebScriptController.cpp:
* src/WebSecurityOrigin.cpp:
* src/WebSecurityPolicy.cpp:
* src/WebSelectElement.cpp:
* src/WebSerializedScriptValue.cpp:
* src/WebSessionDescriptionDescriptor.cpp:
* src/WebSettingsImpl.cpp:
* src/WebSocketImpl.cpp:
* src/WebSocketImpl.h:
* src/WebStorageEventDispatcherImpl.cpp:
* src/WebSurroundingText.cpp:
* src/WebURLLoadTiming.cpp:
* src/WorkerAsyncFileWriterChromium.cpp:
* src/WorkerFileSystemCallbacksBridge.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFormElement.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebGeolocationClientMock.cpp
trunk/Source/WebKit/chromium/src/WebGeolocationError.cpp
trunk/Source/WebKit/chromium/src/WebGeolocationPermissionRequest.cpp
trunk/Source/WebKit/chromium/src/WebHistoryItem.cpp
trunk/Source/WebKit/chromium/src/WebHitTestResult.cpp
trunk/Source/WebKit/chromium/src/WebIDBTransactionImpl.h
trunk/Source/WebKit/chromium/src/WebIconLoadingCompletionImpl.h
trunk/Source/WebKit/chromium/src/WebImageDecoder.cpp
trunk/Source/WebKit/chromium/src/WebImageSkia.cpp
trunk/Source/WebKit/chromium/src/WebInputElement.cpp
trunk/Source/WebKit/chromium/src/WebKit.cpp
trunk/Source/WebKit/chromium/src/WebLabelElement.cpp
trunk/Source/WebKit/chromium/src/WebMediaStreamRegistry.cpp
trunk/Source/WebKit/chromium/src/WebNode.cpp
trunk/Source/WebKit/chromium/src/WebNotification.cpp
trunk/Source/WebKit/chromium/src/WebOptionElement.cpp
trunk/Source/WebKit/chromium/src/WebPageSerializer.cpp
trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp
trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.h
trunk/Source/WebKit/chromium/src/WebPluginListBuilderImpl.cpp
trunk/Source/WebKit/chromium/src/WebPluginLoadObserver.h
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h
trunk/Source/WebKit/chromium/src/WebRange.cpp
trunk/Source/WebKit/chromium/src/WebRegularExpression.cpp
trunk/Source/WebKit/chromium/src/WebScriptController.cpp
trunk/Source/WebKit/chromium/src/WebSecurityOrigin.cpp
trunk/Source/WebKit/chromium/src/WebSecurityPolicy.cpp
trunk/Source/WebKit/chromium/src/WebSelectElement.cpp
trunk/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp
trunk/Source/WebKit/chromium/src/WebSessionDescriptionDescriptor.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSocketImpl.cpp
trunk/Source/WebKit/chromium/src/WebSocketImpl.h
trunk/Source/WebKit/chromium/src/WebStorageEventDispatcherImpl.cpp
trunk/Source/WebKit/chromium/src/WebSurroundingText.cpp
trunk/Source/WebKit/chromium/src/WebURLLoadTiming.cpp
trunk/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.cpp
trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (130529 => 130530)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-10-05 18:08:44 UTC (rev 130529)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-10-05 18:09:14 UTC (rev 130530)
@@ -1,3 +1,54 @@
+2012-10-05  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Update some more #includes for Platform/ directory
+https://bugs.webkit.org/show_bug.cgi?id=98534
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/WebFormElement.cpp:
+* src/WebFrameImpl.cpp:
+* src/WebGeolocationClientMock.cpp:
+* src/WebGeolocationError.cpp:
+* src/WebGeolocationPermissionRequest.cpp:
+* src/WebHistoryItem.cpp:
+* src/WebHitTestResult.cpp:
+* src/WebIDBTransactionImpl.h:
+* src/WebIconLoadingCompletionImpl.h:
+* src/WebImageDecoder.cpp:
+* src/WebImageSkia.cpp:
+* src/WebInputElement.cpp:
+* src/WebKit.cpp:
+* 

[webkit-changes] [130448] trunk/Source/WebKit/chromium

2012-10-04 Thread pilgrim
Title: [130448] trunk/Source/WebKit/chromium








Revision 130448
Author pilg...@chromium.org
Date 2012-10-04 19:30:19 -0700 (Thu, 04 Oct 2012)


Log Message
[Chromium] Update some #includes for Platform directory
https://bugs.webkit.org/show_bug.cgi?id=98440

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

* src/ApplicationCacheHost.cpp:
* src/AssociatedURLLoader.h:
* src/AsyncFileWriterChromium.cpp:
* src/AudioDestinationChromium.h:
* src/AutofillPopupMenuClient.cpp:
* src/ChromeClientImpl.cpp:
* src/ContextMenuClientImpl.cpp:
* src/DeliveredIntentClientImpl.h:
* src/DragClientImpl.cpp:
* src/DragScrollTimer.h:
* src/FrameLoaderClientImpl.cpp:
* src/InspectorClientImpl.cpp:
* src/InspectorClientImpl.h:
* src/InspectorFrontendClientImpl.cpp:
* src/NotificationPresenterImpl.cpp:
* src/PageWidgetDelegate.h:
* src/SocketStreamHandle.cpp:
* src/SocketStreamHandleInternal.h:
* src/SpeechInputClientImpl.cpp:
* src/StorageAreaProxy.cpp:
* src/StorageNamespaceProxy.cpp:
* src/UserMediaClientImpl.cpp:
* src/WebAccessibilityObject.cpp:
* src/WebAnimationControllerImpl.cpp:
* src/WebCommon.cpp:
* src/WebDOMEventListenerPrivate.h:
* src/WebDOMMessageEvent.cpp:
* src/WebDOMStringList.cpp:
* src/WebDataSourceImpl.cpp:
* src/WebDatabase.cpp:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsAgentImpl.h:
* src/WebDocument.cpp:
* src/WebDocumentType.cpp:
* src/WebDragData.cpp:
* src/WebElement.cpp:
* src/WebEntities.cpp:
* src/WebFileChooserCompletionImpl.h:
* src/WebFileSystemCallbacksImpl.cpp:
* src/WebFontImpl.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp
trunk/Source/WebKit/chromium/src/AssociatedURLLoader.h
trunk/Source/WebKit/chromium/src/AsyncFileWriterChromium.cpp
trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h
trunk/Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp
trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp
trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp
trunk/Source/WebKit/chromium/src/DeliveredIntentClientImpl.h
trunk/Source/WebKit/chromium/src/DragClientImpl.cpp
trunk/Source/WebKit/chromium/src/DragScrollTimer.h
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp
trunk/Source/WebKit/chromium/src/InspectorClientImpl.h
trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp
trunk/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp
trunk/Source/WebKit/chromium/src/PageWidgetDelegate.h
trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp
trunk/Source/WebKit/chromium/src/SocketStreamHandleInternal.h
trunk/Source/WebKit/chromium/src/SpeechInputClientImpl.cpp
trunk/Source/WebKit/chromium/src/StorageAreaProxy.cpp
trunk/Source/WebKit/chromium/src/StorageNamespaceProxy.cpp
trunk/Source/WebKit/chromium/src/UserMediaClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp
trunk/Source/WebKit/chromium/src/WebAnimationControllerImpl.cpp
trunk/Source/WebKit/chromium/src/WebCommon.cpp
trunk/Source/WebKit/chromium/src/WebDOMEventListenerPrivate.h
trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp
trunk/Source/WebKit/chromium/src/WebDOMStringList.cpp
trunk/Source/WebKit/chromium/src/WebDataSourceImpl.cpp
trunk/Source/WebKit/chromium/src/WebDatabase.cpp
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h
trunk/Source/WebKit/chromium/src/WebDocument.cpp
trunk/Source/WebKit/chromium/src/WebDocumentType.cpp
trunk/Source/WebKit/chromium/src/WebDragData.cpp
trunk/Source/WebKit/chromium/src/WebElement.cpp
trunk/Source/WebKit/chromium/src/WebEntities.cpp
trunk/Source/WebKit/chromium/src/WebFileChooserCompletionImpl.h
trunk/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp
trunk/Source/WebKit/chromium/src/WebFontImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (130447 => 130448)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-10-05 02:26:11 UTC (rev 130447)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-10-05 02:30:19 UTC (rev 130448)
@@ -1,3 +1,53 @@
+2012-10-04  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Update some #includes for Platform directory
+https://bugs.webkit.org/show_bug.cgi?id=98440
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/ApplicationCacheHost.cpp:
+* src/AssociatedURLLoader.h:
+* src/AsyncFileWriterChromium.cpp:
+* src/AudioDestinationChromium.h:
+* src/AutofillPopupMenuClient.cpp:
+* src/ChromeClientImpl.cpp:
+* src/ContextMenuClientImpl.cpp:
+* src/DeliveredIntentClientImpl.h:
+* src/DragClientImpl.cpp:
+* src/DragScrollTimer.h:
+* src/FrameLoaderClientImpl.cpp:
+* src/InspectorClientImpl.cpp:
+* src/InspectorClientImpl.h:
+* src/InspectorFrontendClientImpl.cpp:
+* 

[webkit-changes] [129792] trunk/Source

2012-09-27 Thread pilgrim
Title: [129792] trunk/Source








Revision 129792
Author pilg...@chromium.org
Date 2012-09-27 12:48:58 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Move UNIX-specific theme functions out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96516

Reviewed by Adam Barth.

Call WebThemeEngine functions and use WebThemeEngine enums
directly from the new Platform/ directly; remove all
intermediate functions and enums and conversion functions from
PlatformSupport.
Part of a refactoring series; see tracking bug 82948.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumLinux.cpp:
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::getWebThemeState):
(WebCore):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp
trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.cpp
trunk/Source/WebCore/rendering/RenderThemeChromiumLinux.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129791 => 129792)

--- trunk/Source/WebCore/ChangeLog	2012-09-27 19:44:29 UTC (rev 129791)
+++ trunk/Source/WebCore/ChangeLog	2012-09-27 19:48:58 UTC (rev 129792)
@@ -1,3 +1,46 @@
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move UNIX-specific theme functions out of PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=96516
+
+Reviewed by Adam Barth.
+
+Call WebThemeEngine functions and use WebThemeEngine enums
+directly from the new Platform/ directly; remove all
+intermediate functions and enums and conversion functions from
+PlatformSupport.
+Part of a refactoring series; see tracking bug 82948.
+
+* WebCore.gyp/WebCore.gyp:
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* platform/chromium/ScrollbarThemeChromiumLinux.cpp:
+(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
+(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
+(WebCore::ScrollbarThemeChromiumLinux::paintButton):
+(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
+(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
+(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
+* rendering/RenderThemeChromiumAndroid.cpp:
+(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
+(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):
+* rendering/RenderThemeChromiumLinux.cpp:
+(WebCore::getWebThemeState):
+(WebCore):
+(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
+(WebCore::RenderThemeChromiumLinux::paintCheckbox):
+(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
+(WebCore::RenderThemeChromiumLinux::paintRadio):
+(WebCore::RenderThemeChromiumLinux::setRadioSize):
+(WebCore::RenderThemeChromiumLinux::paintButton):
+(WebCore::RenderThemeChromiumLinux::paintTextField):
+(WebCore::RenderThemeChromiumLinux::paintMenuList):
+(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
+(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
+(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
+(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
+(WebCore::RenderThemeChromiumLinux::paintProgressBar):
+
 2012-09-27  Bear Travis  betra...@adobe.com
 
 [

[webkit-changes] [129799] trunk/Source

2012-09-27 Thread pilgrim
Title: [129799] trunk/Source








Revision 129799
Author pilg...@chromium.org
Date 2012-09-27 14:25:48 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97817

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948. We're calling WebThemeEngine directly now instead of proxying through PlatformSupport.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore):
(WebCore::ScrollbarThemeChromiumMac::paint):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:
* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129798 => 129799)

--- trunk/Source/WebCore/ChangeLog	2012-09-27 21:03:47 UTC (rev 129798)
+++ trunk/Source/WebCore/ChangeLog	2012-09-27 21:25:48 UTC (rev 129799)
@@ -1,3 +1,19 @@
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97817
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948. We're calling WebThemeEngine directly now instead of proxying through PlatformSupport.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* platform/chromium/ScrollbarThemeChromiumMac.mm:
+(WebCore::scrollbarStateToThemeState):
+(WebCore):
+(WebCore::ScrollbarThemeChromiumMac::paint):
+
 2012-09-27  Erik Arvidsson  a...@chromium.org
 
 Fix issue with ClassList which was hitting an assert in debug mode


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (129798 => 129799)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-27 21:03:47 UTC (rev 129798)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-27 21:25:48 UTC (rev 129799)
@@ -127,39 +127,6 @@
 GraphicsContext*, int part, int state, int classicState, const IntRect);
 static void paintProgressBar(
 GraphicsContext*, const IntRect barRect, const IntRect valueRect, bool determinate, double animatedSeconds);
-#elif OS(DARWIN)
-enum ThemePaintState {
-StateDisabled,
-StateInactive,
-StateActive,
-StatePressed,
-};
-
-enum ThemePaintSize {
-SizeRegular,
-SizeSmall,
-};
-
-enum ThemePaintScrollbarOrientation {
-ScrollbarOrientationHorizontal,
-ScrollbarOrientationVertical,
-};
-
-enum ThemePaintScrollbarParent {
-ScrollbarParentScrollView,
-ScrollbarParentRenderLayer,
-};
-
-struct ThemePaintScrollbarInfo {
-ThemePaintScrollbarOrientation orientation;
-ThemePaintScrollbarParent parent;
-int maxValue;
-int currentValue;
-int visibleSize;
-int totalSize;
-};
-
-static void paintScrollbarThumb(GraphicsContext*, ThemePaintState, ThemePaintSize, const IntRect, const ThemePaintScrollbarInfo);
 #endif
 };
 


Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm (129798 => 129799)

--- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm	2012-09-27 21:03:47 UTC (rev 129798)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm	2012-09-27 21:25:48 UTC (rev 129799)
@@ -33,11 +33,13 @@
 #include LocalCurrentGraphicsContext.h
 #include NSScrollerImpDetails.h
 #include PlatformContextSkia.h
-#include PlatformSupport.h
 #include ScrollAnimatorMac.h
 #include ScrollView.h
 #include skia/ext/skia_utils_mac.h
 #include Carbon/Carbon.h
+#include public/Platform.h
+#include public/WebRect.h
+#include public/mac/WebThemeEngine.h
 
 namespace WebCore {
 
@@ -58,16 +60,16 @@
 {
 }
 
-static PlatformSupport::ThemePaintState scrollbarStateToThemeState(ScrollbarThemeClient* scrollbar)
+static WebKit::WebThemeEngine::State scrollbarStateToThemeState(ScrollbarThemeClient* scrollbar)
 {
 if (!scrollbar-enabled())
-return PlatformSupport::StateDisabled;
+return WebKit::WebThemeEngine::StateDisabled;
 if (!scrollbar-isScrollableAreaActive())
-return PlatformSupport::StateInactive;
+return WebKit::WebThemeEngine::StateInactive;
 if (scrollbar-pressedPart() == ThumbPart)
-return PlatformSupport::StatePressed;
+return WebKit::WebThemeEngine::StatePressed;
 
-return PlatformSupport::StateActive;
+return WebKit::WebThemeEngine::StateActive;
 }
 
 static void scrollbarPainterPaintTrack(Scrollb

[webkit-changes] [129825] trunk/Source

2012-09-27 Thread pilgrim
Title: [129825] trunk/Source








Revision 129825
Author pilg...@chromium.org
Date 2012-09-27 17:31:12 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Remove screen-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97474

Reviewed by Adam Barth.

Source/Platform:

Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

* Platform.gypi:
* chromium/public/WebScreenInfo.h: Added.
(WebKit):
(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):

Source/WebCore:

Part of a refactoring series. See tracking bug 82948.
Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

* WebCore.gypi:
* platform/Widget.h:
* platform/chromium/PageClientChromium.h: Copied from Source/WebCore/platform/chromium/PlatformWidget.h.
(PageClientChromium):
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::toPlatformPageClient):
(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

* public/WebScreenInfo.h:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::screenInfo):
(WebKit):
* src/ChromeClientImpl.h:
(WebKit):
(WebKit::ChromeClientImpl::platformPageClient):
(ChromeClientImpl):
* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/Widget.h
trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebScreenInfo.h
trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp
trunk/Source/WebKit/chromium/src/ChromeClientImpl.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp


Added Paths

trunk/Source/Platform/chromium/public/WebScreenInfo.h
trunk/Source/WebCore/platform/chromium/PageClientChromium.h




Diff

Modified: trunk/Source/Platform/ChangeLog (129824 => 129825)

--- trunk/Source/Platform/ChangeLog	2012-09-28 00:26:14 UTC (rev 129824)
+++ trunk/Source/Platform/ChangeLog	2012-09-28 00:31:12 UTC (rev 129825)
@@ -1,3 +1,23 @@
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove screen-related functions from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97474
+
+Reviewed by Adam Barth.
+
+Screen-related functions like screenHorizontalDPI that
+used to be on PlatformSupport are now accessed through a new
+PlatformPageClient attached to Widget in WebCore-land, which is
+implemented by ChromeClientImpl in WebKit-land, which proxies
+calls to WebWidgetClient, which is actually implemented in
+Chromium-land.
+
+* Platform.gypi:
+* chromium/public/WebScreenInfo.h: Added.
+(WebKit):
+(WebScreenInfo):
+(WebKit::WebScreenInfo::WebScreenInfo):
+
 2012-09-27  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data


Modified: trunk/Source/Platform/Platform.gypi (129824 => 129825)

--- trunk/Source/Platform/Platform.gypi	2012-09-28 00:26:14 UTC (rev 129824)
+++ trunk/Source/Platform/Platform.gypi	2012-09-28 00:31:12 UTC (rev 129825)
@@ -116,6 +116,7 @@
 'chromium/public/WebRect.h',
 'chromium/public/WebReferrerPolicy.h',
 'chromium/public/WebRenderingStats.h',
+'chromium/public/WebScreenInfo.h',
 'chromium/public/WebScrollbar.h',
 'chromium/public/WebScrollbarLayer.h',
 'chromium/public/WebScrollbarThemeGeometry.h',


Copied: trunk/Source/Platform/chromium/public/WebScreenInfo.h (from rev 129824, trunk/Source/WebKit/chromium/public/WebScreenInfo.h) (0 => 129825)

--- trunk/Source/Platform/chromium/public/WebScreenInfo.h	(rev 0)
+++ trunk/Source/Platform/chromium/public/WebScreenInfo.h	2012-09-28 00:31:12

[webkit-changes] [129833] trunk/Source/WebKit/chromium

2012-09-27 Thread pilgrim
Title: [129833] trunk/Source/WebKit/chromium








Revision 129833
Author pilg...@chromium.org
Date 2012-09-27 19:37:49 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Remove unused PlatformSupport reference in WebFrameImpl
https://bugs.webkit.org/show_bug.cgi?id=97842

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/WebFrameImpl.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129832 => 129833)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 02:36:03 UTC (rev 129832)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 02:37:49 UTC (rev 129833)
@@ -1,5 +1,16 @@
 2012-09-27  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Remove unused PlatformSupport reference in WebFrameImpl
+https://bugs.webkit.org/show_bug.cgi?id=97842
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/WebFrameImpl.cpp:
+
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Remove screen-related functions from PlatformSupport
 https://bugs.webkit.org/show_bug.cgi?id=97474
 


Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (129832 => 129833)

--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp	2012-09-28 02:36:03 UTC (rev 129832)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp	2012-09-28 02:37:49 UTC (rev 129833)
@@ -116,7 +116,6 @@
 #include PageOverlay.h
 #include Performance.h
 #include PlatformMessagePortChannel.h
-#include PlatformSupport.h
 #include PluginDocument.h
 #include PrintContext.h
 #include RenderBox.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129834] trunk/Source/WebCore

2012-09-27 Thread pilgrim
Title: [129834] trunk/Source/WebCore








Revision 129834
Author pilg...@chromium.org
Date 2012-09-27 19:40:27 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Remove unused PlatformSupport reference in ClipboardChromium
https://bugs.webkit.org/show_bug.cgi?id=97840

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* platform/chromium/ClipboardChromium.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129833 => 129834)

--- trunk/Source/WebCore/ChangeLog	2012-09-28 02:37:49 UTC (rev 129833)
+++ trunk/Source/WebCore/ChangeLog	2012-09-28 02:40:27 UTC (rev 129834)
@@ -1,3 +1,14 @@
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove unused PlatformSupport reference in ClipboardChromium
+https://bugs.webkit.org/show_bug.cgi?id=97840
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/ClipboardChromium.cpp:
+
 2012-09-27  Kent Tamura  tk...@chromium.org
 
 DateTimeNumericFieldElement should use Localizer functions.


Modified: trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp (129833 => 129834)

--- trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp	2012-09-28 02:37:49 UTC (rev 129833)
+++ trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp	2012-09-28 02:40:27 UTC (rev 129834)
@@ -45,7 +45,6 @@
 #include Image.h
 #include MIMETypeRegistry.h
 #include NamedNodeMap.h
-#include PlatformSupport.h
 #include Range.h
 #include RenderImage.h
 #include StringCallback.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129835] trunk/Source/WebKit/chromium

2012-09-27 Thread pilgrim
Title: [129835] trunk/Source/WebKit/chromium








Revision 129835
Author pilg...@chromium.org
Date 2012-09-27 19:55:58 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Clean up includes in AudioDestinationChromium
https://bugs.webkit.org/show_bug.cgi?id=97845

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/AudioDestinationChromium.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129834 => 129835)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 02:40:27 UTC (rev 129834)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 02:55:58 UTC (rev 129835)
@@ -1,5 +1,16 @@
 2012-09-27  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Clean up includes in AudioDestinationChromium
+https://bugs.webkit.org/show_bug.cgi?id=97845
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/AudioDestinationChromium.cpp:
+
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Remove unused PlatformSupport reference in WebFrameImpl
 https://bugs.webkit.org/show_bug.cgi?id=97842
 


Modified: trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp (129834 => 129835)

--- trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp	2012-09-28 02:40:27 UTC (rev 129834)
+++ trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp	2012-09-28 02:55:58 UTC (rev 129835)
@@ -29,14 +29,9 @@
 #include config.h
 
 #if ENABLE(WEB_AUDIO)
-
 #include AudioDestinationChromium.h
-
 #include AudioFIFO.h
 #include AudioPullFIFO.h
-#include WebKit.h
-#include platform/WebKitPlatformSupport.h
-
 #include public/Platform.h
 
 using namespace WebKit;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129836] trunk/Source/WebKit/chromium

2012-09-27 Thread pilgrim
Title: [129836] trunk/Source/WebKit/chromium








Revision 129836
Author pilg...@chromium.org
Date 2012-09-27 19:57:21 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Clean up includes in SocketStreamHandle
https://bugs.webkit.org/show_bug.cgi?id=97843

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/SocketStreamHandle.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129835 => 129836)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 02:55:58 UTC (rev 129835)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 02:57:21 UTC (rev 129836)
@@ -1,5 +1,16 @@
 2012-09-27  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Clean up includes in SocketStreamHandle
+https://bugs.webkit.org/show_bug.cgi?id=97843
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/SocketStreamHandle.cpp:
+
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Clean up includes in AudioDestinationChromium
 https://bugs.webkit.org/show_bug.cgi?id=97845
 


Modified: trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp (129835 => 129836)

--- trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp	2012-09-28 02:55:58 UTC (rev 129835)
+++ trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp	2012-09-28 02:57:21 UTC (rev 129836)
@@ -38,9 +38,8 @@
 #include NotImplemented.h
 #include SocketStreamHandleClient.h
 #include platform/WebData.h
-#include WebKit.h
-#include platform/WebKitPlatformSupport.h
 #include platform/WebSocketStreamHandle.h
+#include public/Platform.h
 #include wtf/PassOwnPtr.h
 
 using namespace WebKit;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129837] trunk/Source/WebCore

2012-09-27 Thread pilgrim
Title: [129837] trunk/Source/WebCore








Revision 129837
Author pilg...@chromium.org
Date 2012-09-27 19:59:36 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium][Android] Remove unused PlatformSupport reference in ScrollbarThemeChromiumAndroid
https://bugs.webkit.org/show_bug.cgi?id=97846

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129836 => 129837)

--- trunk/Source/WebCore/ChangeLog	2012-09-28 02:57:21 UTC (rev 129836)
+++ trunk/Source/WebCore/ChangeLog	2012-09-28 02:59:36 UTC (rev 129837)
@@ -1,5 +1,16 @@
 2012-09-27  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium][Android] Remove unused PlatformSupport reference in ScrollbarThemeChromiumAndroid
+https://bugs.webkit.org/show_bug.cgi?id=97846
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
+
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Remove unused PlatformSupport reference in ClipboardChromium
 https://bugs.webkit.org/show_bug.cgi?id=97840
 


Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp (129836 => 129837)

--- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp	2012-09-28 02:57:21 UTC (rev 129836)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp	2012-09-28 02:59:36 UTC (rev 129837)
@@ -28,7 +28,6 @@
 
 #include PlatformContextSkia.h
 #include PlatformMouseEvent.h
-#include PlatformSupport.h
 #include Scrollbar.h
 #include TransformationMatrix.h
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129838] trunk/Source/WebKit/chromium

2012-09-27 Thread pilgrim
Title: [129838] trunk/Source/WebKit/chromium








Revision 129838
Author pilg...@chromium.org
Date 2012-09-27 20:01:35 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Clean up includes in PaintAggregator
https://bugs.webkit.org/show_bug.cgi?id=97848

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/painting/PaintAggregator.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129837 => 129838)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 02:59:36 UTC (rev 129837)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 03:01:35 UTC (rev 129838)
@@ -1,5 +1,16 @@
 2012-09-27  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Clean up includes in PaintAggregator
+https://bugs.webkit.org/show_bug.cgi?id=97848
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/painting/PaintAggregator.cpp:
+
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Clean up includes in SocketStreamHandle
 https://bugs.webkit.org/show_bug.cgi?id=97843
 


Modified: trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp (129837 => 129838)

--- trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp	2012-09-28 02:59:36 UTC (rev 129837)
+++ trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp	2012-09-28 03:01:35 UTC (rev 129838)
@@ -30,10 +30,7 @@
 
 #include config.h
 #include PaintAggregator.h
-
-#include WebKit.h
-#include platform/WebKitPlatformSupport.h
-
+#include public/Platform.h
 using namespace WebCore;
 
 namespace WebKit {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129839] trunk/Source/WebKit/chromium

2012-09-27 Thread pilgrim
Title: [129839] trunk/Source/WebKit/chromium








Revision 129839
Author pilg...@chromium.org
Date 2012-09-27 20:03:29 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Clean up includes in ColorChooserUIController
https://bugs.webkit.org/show_bug.cgi?id=97849

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/ColorChooserUIController.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ColorChooserUIController.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129838 => 129839)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 03:01:35 UTC (rev 129838)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 03:03:29 UTC (rev 129839)
@@ -1,5 +1,16 @@
 2012-09-27  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Clean up includes in ColorChooserUIController
+https://bugs.webkit.org/show_bug.cgi?id=97849
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/ColorChooserUIController.cpp:
+
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Clean up includes in PaintAggregator
 https://bugs.webkit.org/show_bug.cgi?id=97848
 


Modified: trunk/Source/WebKit/chromium/src/ColorChooserUIController.cpp (129838 => 129839)

--- trunk/Source/WebKit/chromium/src/ColorChooserUIController.cpp	2012-09-28 03:01:35 UTC (rev 129838)
+++ trunk/Source/WebKit/chromium/src/ColorChooserUIController.cpp	2012-09-28 03:03:29 UTC (rev 129839)
@@ -36,8 +36,8 @@
 #include LocalizedStrings.h
 #include PickerCommon.h
 #include WebColorChooser.h
-#include platform/WebColor.h
-#include platform/WebKitPlatformSupport.h
+#include public/Platform.h
+#include public/WebColor.h
 #include public/WebLocalizedString.h
 
 namespace WebKit {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129840] trunk/Source/WebCore

2012-09-27 Thread pilgrim
Title: [129840] trunk/Source/WebCore








Revision 129840
Author pilg...@chromium.org
Date 2012-09-27 20:05:39 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Remove unused PlatformSupport reference in FontCacheSkia
https://bugs.webkit.org/show_bug.cgi?id=97850

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* platform/graphics/skia/FontCacheSkia.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129839 => 129840)

--- trunk/Source/WebCore/ChangeLog	2012-09-28 03:03:29 UTC (rev 129839)
+++ trunk/Source/WebCore/ChangeLog	2012-09-28 03:05:39 UTC (rev 129840)
@@ -1,5 +1,16 @@
 2012-09-27  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Remove unused PlatformSupport reference in FontCacheSkia
+https://bugs.webkit.org/show_bug.cgi?id=97850
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/graphics/skia/FontCacheSkia.cpp:
+
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium][Android] Remove unused PlatformSupport reference in ScrollbarThemeChromiumAndroid
 https://bugs.webkit.org/show_bug.cgi?id=97846
 


Modified: trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp (129839 => 129840)

--- trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp	2012-09-28 03:03:29 UTC (rev 129839)
+++ trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp	2012-09-28 03:05:39 UTC (rev 129840)
@@ -30,20 +30,16 @@
 
 #include config.h
 #include FontCache.h
-
 #include Font.h
 #include FontDescription.h
 #include FontFamily.h
 #include FontPlatformData.h
 #include Logging.h
 #include NotImplemented.h
-#include PlatformSupport.h
 #include SimpleFontData.h
-
 #include SkPaint.h
 #include SkTypeface.h
 #include SkUtils.h
-
 #include unicode/locid.h
 #include wtf/Assertions.h
 #include wtf/text/AtomicString.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129841] trunk/Source/WebKit/chromium

2012-09-27 Thread pilgrim
Title: [129841] trunk/Source/WebKit/chromium








Revision 129841
Author pilg...@chromium.org
Date 2012-09-27 20:14:37 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Clean up includes in DateTimeChooserImpl
https://bugs.webkit.org/show_bug.cgi?id=97847

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/DateTimeChooserImpl.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129840 => 129841)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 03:05:39 UTC (rev 129840)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 03:14:37 UTC (rev 129841)
@@ -1,5 +1,16 @@
 2012-09-27  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Clean up includes in DateTimeChooserImpl
+https://bugs.webkit.org/show_bug.cgi?id=97847
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/DateTimeChooserImpl.cpp:
+
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Clean up includes in ColorChooserUIController
 https://bugs.webkit.org/show_bug.cgi?id=97849
 


Modified: trunk/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp (129840 => 129841)

--- trunk/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp	2012-09-28 03:05:39 UTC (rev 129840)
+++ trunk/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp	2012-09-28 03:14:37 UTC (rev 129841)
@@ -43,7 +43,7 @@
 #include NotImplemented.h
 #include PickerCommon.h
 #include RenderTheme.h
-#include platform/WebKitPlatformSupport.h
+#include public/Platform.h
 #include public/WebLocalizedString.h
 
 using namespace WTF::Unicode;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129843] trunk/Source/WebCore

2012-09-27 Thread pilgrim
Title: [129843] trunk/Source/WebCore








Revision 129843
Author pilg...@chromium.org
Date 2012-09-27 20:41:50 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Remove unused PlatformSupport reference in DraggedIsolatedFileSystem
https://bugs.webkit.org/show_bug.cgi?id=97851

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129842 => 129843)

--- trunk/Source/WebCore/ChangeLog	2012-09-28 03:15:28 UTC (rev 129842)
+++ trunk/Source/WebCore/ChangeLog	2012-09-28 03:41:50 UTC (rev 129843)
@@ -1,3 +1,14 @@
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove unused PlatformSupport reference in DraggedIsolatedFileSystem
+https://bugs.webkit.org/show_bug.cgi?id=97851
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:
+
 2012-09-27  Andrew Lo  a...@rim.com
 
 requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)


Modified: trunk/Source/WebCore/Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp (129842 => 129843)

--- trunk/Source/WebCore/Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp	2012-09-28 03:15:28 UTC (rev 129842)
+++ trunk/Source/WebCore/Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp	2012-09-28 03:41:50 UTC (rev 129843)
@@ -34,7 +34,6 @@
 #if ENABLE(FILE_SYSTEM)
 
 #include DOMFileSystem.h
-#include PlatformSupport.h
 #include ScriptExecutionContext.h
 #include SecurityOrigin.h
 #include Supplementable.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129845] trunk/Source/WebKit/chromium

2012-09-27 Thread pilgrim
Title: [129845] trunk/Source/WebKit/chromium








Revision 129845
Author pilg...@chromium.org
Date 2012-09-27 20:57:52 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Remove unused PlatformSupport reference in ChromeClientImpl
https://bugs.webkit.org/show_bug.cgi?id=97853

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/ChromeClientImpl.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129844 => 129845)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 03:51:25 UTC (rev 129844)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 03:57:52 UTC (rev 129845)
@@ -1,5 +1,16 @@
 2012-09-27  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Remove unused PlatformSupport reference in ChromeClientImpl
+https://bugs.webkit.org/show_bug.cgi?id=97853
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/ChromeClientImpl.cpp:
+
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Clean up includes in DateTimeChooserImpl
 https://bugs.webkit.org/show_bug.cgi?id=97847
 


Modified: trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp (129844 => 129845)

--- trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp	2012-09-28 03:51:25 UTC (rev 129844)
+++ trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp	2012-09-28 03:57:52 UTC (rev 129845)
@@ -63,7 +63,6 @@
 #include Page.h
 #include PagePopupDriver.h
 #include PlatformScreen.h
-#include PlatformSupport.h
 #include PopupContainer.h
 #include PopupMenuChromium.h
 #include RenderWidget.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129846] trunk/Source/WebKit/chromium

2012-09-27 Thread pilgrim
Title: [129846] trunk/Source/WebKit/chromium








Revision 129846
Author pilg...@chromium.org
Date 2012-09-27 21:04:44 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Update comment in WebFrameClient to point to new userAgent() function
https://bugs.webkit.org/show_bug.cgi?id=97854

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

* public/WebFrameClient.h:
(WebFrameClient):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebFrameClient.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129845 => 129846)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 03:57:52 UTC (rev 129845)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 04:04:44 UTC (rev 129846)
@@ -1,5 +1,17 @@
 2012-09-27  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Update comment in WebFrameClient to point to new userAgent() function
+https://bugs.webkit.org/show_bug.cgi?id=97854
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* public/WebFrameClient.h:
+(WebFrameClient):
+
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Remove unused PlatformSupport reference in ChromeClientImpl
 https://bugs.webkit.org/show_bug.cgi?id=97853
 


Modified: trunk/Source/WebKit/chromium/public/WebFrameClient.h (129845 => 129846)

--- trunk/Source/WebKit/chromium/public/WebFrameClient.h	2012-09-28 03:57:52 UTC (rev 129845)
+++ trunk/Source/WebKit/chromium/public/WebFrameClient.h	2012-09-28 04:04:44 UTC (rev 129846)
@@ -411,7 +411,7 @@
 
 // Asks the embedder if a specific user agent should be used for the given
 // URL. Non-empty strings indicate an override should be used. Otherwise,
-// WebKitPlatformSupport::userAgent() will be called to provide one.
+// Platform::current()-userAgent() will be called to provide one.
 virtual WebString userAgentOverride(WebFrame*, const WebURL url) { return WebString(); }
 
 protected:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129850] trunk/Source/WebKit/chromium

2012-09-27 Thread pilgrim
Title: [129850] trunk/Source/WebKit/chromium








Revision 129850
Author pilg...@chromium.org
Date 2012-09-27 22:03:10 -0700 (Thu, 27 Sep 2012)


Log Message
[Chromium] Update WebVector.h references
https://bugs.webkit.org/show_bug.cgi?id=97855

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* src/ApplicationCacheHost.cpp:
* src/AudioDestinationChromium.h:
* src/AutofillPopupMenuClient.cpp:
* src/CompositionUnderlineBuilder.h:
* src/CompositionUnderlineVectorBuilder.h:
* src/ContextMenuClientImpl.cpp:
* src/ExternalPopupMenu.cpp:
* src/FrameLoaderClientImpl.cpp:
* src/PlatformSupport.cpp:
* src/WebDataSourceImpl.cpp:
* src/WebDragData.cpp:
* src/WebFileChooserCompletionImpl.h:
* src/WebFileSystemCallbacksImpl.h:
* src/WebFrameImpl.cpp:
* src/WebHistoryItem.cpp:
* src/WebIDBKeyPath.cpp:
* src/WebIDBMetadata.cpp:
* src/WebNode.cpp:
* src/WebPageSerializer.cpp:
* src/WebPageSerializerImpl.cpp:
* src/WebTextCheckingCompletionImpl.cpp:
* src/WorkerFileSystemCallbacksBridge.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp
trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h
trunk/Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp
trunk/Source/WebKit/chromium/src/CompositionUnderlineBuilder.h
trunk/Source/WebKit/chromium/src/CompositionUnderlineVectorBuilder.h
trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp
trunk/Source/WebKit/chromium/src/ExternalPopupMenu.cpp
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
trunk/Source/WebKit/chromium/src/WebDataSourceImpl.cpp
trunk/Source/WebKit/chromium/src/WebDragData.cpp
trunk/Source/WebKit/chromium/src/WebFileChooserCompletionImpl.h
trunk/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.h
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebHistoryItem.cpp
trunk/Source/WebKit/chromium/src/WebIDBKeyPath.cpp
trunk/Source/WebKit/chromium/src/WebIDBMetadata.cpp
trunk/Source/WebKit/chromium/src/WebNode.cpp
trunk/Source/WebKit/chromium/src/WebPageSerializer.cpp
trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp
trunk/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.cpp
trunk/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (129849 => 129850)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 04:27:43 UTC (rev 129849)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-28 05:03:10 UTC (rev 129850)
@@ -1,5 +1,37 @@
 2012-09-27  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Update WebVector.h references
+https://bugs.webkit.org/show_bug.cgi?id=97855
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/ApplicationCacheHost.cpp:
+* src/AudioDestinationChromium.h:
+* src/AutofillPopupMenuClient.cpp:
+* src/CompositionUnderlineBuilder.h:
+* src/CompositionUnderlineVectorBuilder.h:
+* src/ContextMenuClientImpl.cpp:
+* src/ExternalPopupMenu.cpp:
+* src/FrameLoaderClientImpl.cpp:
+* src/PlatformSupport.cpp:
+* src/WebDataSourceImpl.cpp:
+* src/WebDragData.cpp:
+* src/WebFileChooserCompletionImpl.h:
+* src/WebFileSystemCallbacksImpl.h:
+* src/WebFrameImpl.cpp:
+* src/WebHistoryItem.cpp:
+* src/WebIDBKeyPath.cpp:
+* src/WebIDBMetadata.cpp:
+* src/WebNode.cpp:
+* src/WebPageSerializer.cpp:
+* src/WebPageSerializerImpl.cpp:
+* src/WebTextCheckingCompletionImpl.cpp:
+* src/WorkerFileSystemCallbacksBridge.h:
+
+2012-09-27  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Update comment in WebFrameClient to point to new userAgent() function
 https://bugs.webkit.org/show_bug.cgi?id=97854
 


Modified: trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp (129849 => 129850)

--- trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp	2012-09-28 04:27:43 UTC (rev 129849)
+++ trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp	2012-09-28 05:03:10 UTC (rev 129850)
@@ -47,7 +47,7 @@
 #include platform/WebURL.h
 #include platform/WebURLError.h
 #include platform/WebURLResponse.h
-#include platform/WebVector.h
+#include public/WebVector.h
 
 using namespace WebKit;
 


Modified: trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h (129849 => 129850)

--- trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h	2012-09-28 04:27:43 UTC (rev 129849)
+++ trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h	2012-09-28 05:03:10 UTC (rev 129850)
@@ -34,7 +34,7 @@
 #include AudioIOCallback.h
 #include AudioSourceProvider.h
 #include platform/WebAudioDevice.h
-#include platform/WebVector.h
+#include public/WebVector.h
 
 namespace WebKit { class WebAudioDevice; }
 


Modified: trunk/Source/WebKit

[webkit-changes] [129673] trunk/Source

2012-09-26 Thread pilgrim
Title: [129673] trunk/Source








Revision 129673
Author pilg...@chromium.org
Date 2012-09-26 11:14:02 -0700 (Wed, 26 Sep 2012)


Log Message
[Chromium][Win] Remove ensureFontLoaded from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97696

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::paintSkiaText):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::ensureFontLoaded):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129672 => 129673)

--- trunk/Source/WebCore/ChangeLog	2012-09-26 18:11:44 UTC (rev 129672)
+++ trunk/Source/WebCore/ChangeLog	2012-09-26 18:14:02 UTC (rev 129673)
@@ -1,3 +1,17 @@
+2012-09-26  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium][Win] Remove ensureFontLoaded from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97696
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* platform/graphics/skia/SkiaFontWin.cpp:
+(WebCore::paintSkiaText):
+
 2012-09-26  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r129654.


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (129672 => 129673)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-26 18:11:44 UTC (rev 129672)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-26 18:14:02 UTC (rev 129673)
@@ -49,10 +49,6 @@
 typedef struct _NPP NPP_t;
 typedef NPP_t* NPP;
 
-#if OS(WINDOWS)
-typedef struct HFONT__* HFONT;
-#endif
-
 namespace WebCore {
 
 class Color;
@@ -86,11 +82,6 @@
 static void deleteCookie(const Document*, const KURL, const String cookieName);
 static bool cookiesEnabled(const Document*);
 
-// Font ---
-#if OS(WINDOWS)
-static bool ensureFontLoaded(HFONT);
-#endif
-
 // IndexedDB --
 static PassRefPtrIDBFactoryBackendInterface idbFactory();
 


Modified: trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp (129672 => 129673)

--- trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp	2012-09-26 18:11:44 UTC (rev 129672)
+++ trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp	2012-09-26 18:14:02 UTC (rev 129673)
@@ -35,7 +35,6 @@
 #include Gradient.h
 #include Pattern.h
 #include PlatformContextSkia.h
-#include PlatformSupport.h
 #include SimpleFontData.h
 #include SkCanvas.h
 #include SkDevice.h
@@ -43,6 +42,9 @@
 #include SkShader.h
 #include SkTemplates.h
 
+#include public/Platform.h
+#include public/win/WebSandboxSupport.h
+
 namespace WebCore {
 
 #if !USE(SKIA_TEXT)
@@ -221,9 +223,15 @@
 SkCanvas* canvas = platformContext-canvas();
 TextDrawingModeFlags textMode = platformContext-getTextDrawingMode();
 // Ensure font load for printing, because PDF device needs it.
-if (canvas-getTopDevice()-getDeviceCapabilities()  SkDevice::kVector_Capability)
-PlatformSupport::ensureFontLoaded(hfont);
+if (canvas-getTopDevice()-getDeviceCapabilities()  SkDevice::kVector_Capability) {
+WebKit::WebSandboxSupport* sandboxSupport = WebKit::Platform::current()-sandboxSupport();
 
+// if there is no sandbox, then we can assume the font
+// was able to be loaded successfully already
+if (sandboxSupport)
+sandboxSupport-ensureFontLoaded(font);
+}
+
 // Filling (if necessary). This is the common case.
 SkPaint paint;
 platformContext-setupPaintForFilling(paint);


Modified: trunk/Source/WebKit/chromium/ChangeLog (129672 => 129673)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-26 18:11:44 UTC (rev 129672)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-26 18:14:02 UTC (rev 129673)
@@ -1,3 +1,15 @@
+2012-09-26  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium][Win] Remove ensureFontLoaded from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97696
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/PlatformSupport.cpp:
+(WebCore::PlatformSupport::ensureFontLoaded):
+
 2012-09-26  Leandro Gracia Gil  leandrogra...@chromium.org
 
 [Chromium] Fix find-in-page corner case for detached frames


Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (129672 => 129673)

--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-09-26 18:11:44 UTC (rev 129672)
+++ trunk/Source/

[webkit-changes] [129429] trunk/Source

2012-09-24 Thread pilgrim
Title: [129429] trunk/Source








Revision 129429
Author pilg...@chromium.org
Date 2012-09-24 16:57:24 -0700 (Mon, 24 Sep 2012)


Log Message
[Chromium][Mac] Remove loadFont from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97360

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/graphics/chromium/CrossProcessFontLoading.mm:

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.mm
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129428 => 129429)

--- trunk/Source/WebCore/ChangeLog	2012-09-24 23:53:11 UTC (rev 129428)
+++ trunk/Source/WebCore/ChangeLog	2012-09-24 23:57:24 UTC (rev 129429)
@@ -1,3 +1,16 @@
+2012-09-24  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium][Mac] Remove loadFont from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97360
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* platform/graphics/chromium/CrossProcessFontLoading.mm:
+
 2012-09-24  Tony Chang  t...@chromium.org
 
 Replace 2 uses of updateLogicalHeight with computeLogicalHeight


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (129428 => 129429)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-24 23:53:11 UTC (rev 129428)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-24 23:57:24 UTC (rev 129429)
@@ -49,15 +49,6 @@
 typedef struct _NPP NPP_t;
 typedef NPP_t* NPP;
 
-#if OS(DARWIN)
-typedef struct CGFont* CGFontRef;
-#ifdef __OBJC__
-@class NSFont;
-#else
-class NSFont;
-#endif
-#endif // OS(DARWIN)
-
 #if OS(WINDOWS)
 typedef struct HFONT__* HFONT;
 #endif
@@ -99,9 +90,6 @@
 #if OS(WINDOWS)
 static bool ensureFontLoaded(HFONT);
 #endif
-#if OS(DARWIN)
-static bool loadFont(NSFont* srcFont, CGFontRef*, uint32_t* fontID);
-#endif
 
 // IndexedDB --
 static PassRefPtrIDBFactoryBackendInterface idbFactory();


Modified: trunk/Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.mm (129428 => 129429)

--- trunk/Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.mm	2012-09-24 23:53:11 UTC (rev 129428)
+++ trunk/Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.mm	2012-09-24 23:57:24 UTC (rev 129429)
@@ -30,8 +30,10 @@
 #import CrossProcessFontLoading.h
 
 #import ../graphics/FontPlatformData.h
-#import PlatformSupport.h
+#include LinkHash.h
 #import AppKit/NSFont.h
+#import public/Platform.h
+#import public/mac/WebSandboxSupport.h
 #import wtf/HashMap.h
 
 namespace WebCore {
@@ -121,15 +123,23 @@
 CGFontRef tmpCGFont;
 uint32_t fontID;
 // Send cross-process request to load font.
-if (!PlatformSupport::loadFont(nsFont, tmpCGFont, fontID))
+WebKit::WebSandboxSupport* sandboxSupport = WebKit::Platform::current()-sandboxSupport();
+if (!sandboxSupport) {
+// This function should only be called in response to an error loading a
+// font due to being blocked by the sandbox.
+// This by definition shouldn't happen if there is no sandbox support.
+ASSERT_NOT_REACHED();
 return 0;
+}
+if (!sandboxSupport-loadFont(nsFont, tmpCGFont, fontID))
+return 0;
 
 RetainPtrCGFontRef cgFont(tmpCGFont);
 // Now that we have the fontID from the browser process, we can consult
 // the ID cache.
 font = fontCacheByFontID().get(fontID);
 if (font)
-// FIXME: PlatformSupport::loadFont() should consult the id cache
+// FIXME: WebSandboxSupport::loadFont() should consult the id cache
 // before activating the font.
 return font;
 


Modified: trunk/Source/WebKit/chromium/ChangeLog (129428 => 129429)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-24 23:53:11 UTC (rev 129428)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-24 23:57:24 UTC (rev 129429)
@@ -1,3 +1,15 @@
+2012-09-24  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium][Mac] Remove loadFont from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97360
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/PlatformSupport.cpp:
+(WebCore):
+
 2012-09-24  Tony Chang  t...@chromium.org
 
 Unreviewed.  Rolled DEPS.


Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (129428 => 129429)

--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-09-24 23:53:11 UTC (rev 129428)
+++ trunk/Source/

[webkit-changes] [129257] trunk/Source

2012-09-21 Thread pilgrim
Title: [129257] trunk/Source








Revision 129257
Author pilg...@chromium.org
Date 2012-09-21 14:43:57 -0700 (Fri, 21 Sep 2012)


Log Message
[Chromium] remove getFontFamilyForCharacters from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96282

Reviewed by Tony Chang.

Migrating away from PlatformSupport. getFontFamilyForCharacters is
moved to FontCache.h and overridden by the two platforms that
need it (Chromium Linux and Blackberry). New files for the overrides.
Part of a larger refactoring series. See tracking bug 82948.

Source/WebCore:

* PlatformBlackBerry.cmake:
* WebCore.gypi:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/graphics/FontCache.h:
(SimpleFontFamily):
(FontCache):
* platform/graphics/blackberry/FontCacheBlackberry.cpp: Added.
(WebCore):
(WebCore::FontCache::getFontFamilyForCharacters):
* platform/graphics/blackberry/skia/PlatformSupport.cpp:
(WebCore):
* platform/graphics/blackberry/skia/PlatformSupport.h:
(PlatformSupport):
* platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::getFontDataForCharacters):
* platform/graphics/chromium/FontCacheChromiumLinux.cpp: Added.
(WebCore):
(WebCore::FontCache::getFontFamilyForCharacters):
* platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::getFontDataForCharacters):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformBlackBerry.cmake
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/graphics/FontCache.h
trunk/Source/WebCore/platform/graphics/blackberry/skia/PlatformSupport.cpp
trunk/Source/WebCore/platform/graphics/blackberry/skia/PlatformSupport.h
trunk/Source/WebCore/platform/graphics/chromium/FontCacheAndroid.cpp
trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp


Added Paths

trunk/Source/WebCore/platform/graphics/blackberry/FontCacheBlackberry.cpp
trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumLinux.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129256 => 129257)

--- trunk/Source/WebCore/ChangeLog	2012-09-21 21:40:49 UTC (rev 129256)
+++ trunk/Source/WebCore/ChangeLog	2012-09-21 21:43:57 UTC (rev 129257)
@@ -1,3 +1,37 @@
+2012-09-21  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] remove getFontFamilyForCharacters from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=96282
+
+Reviewed by Tony Chang.
+
+Migrating away from PlatformSupport. getFontFamilyForCharacters is
+moved to FontCache.h and overridden by the two platforms that
+need it (Chromium Linux and Blackberry). New files for the overrides.
+Part of a larger refactoring series. See tracking bug 82948.
+
+* PlatformBlackBerry.cmake:
+* WebCore.gypi:
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* platform/graphics/FontCache.h:
+(SimpleFontFamily):
+(FontCache):
+* platform/graphics/blackberry/FontCacheBlackberry.cpp: Added.
+(WebCore):
+(WebCore::FontCache::getFontFamilyForCharacters):
+* platform/graphics/blackberry/skia/PlatformSupport.cpp:
+(WebCore):
+* platform/graphics/blackberry/skia/PlatformSupport.h:
+(PlatformSupport):
+* platform/graphics/chromium/FontCacheAndroid.cpp:
+(WebCore::FontCache::getFontDataForCharacters):
+* platform/graphics/chromium/FontCacheChromiumLinux.cpp: Added.
+(WebCore):
+(WebCore::FontCache::getFontFamilyForCharacters):
+* platform/graphics/skia/FontCacheSkia.cpp:
+(WebCore::FontCache::getFontDataForCharacters):
+
 2012-09-21  Chris Fleizach  cfleiz...@apple.com
 
 AX: WebKit exposes incorrect bounds for embedded SVG in HTML


Modified: trunk/Source/WebCore/PlatformBlackBerry.cmake (129256 => 129257)

--- trunk/Source/WebCore/PlatformBlackBerry.cmake	2012-09-21 21:40:49 UTC (rev 129256)
+++ trunk/Source/WebCore/PlatformBlackBerry.cmake	2012-09-21 21:43:57 UTC (rev 129257)
@@ -42,6 +42,7 @@
 
 # Skia font backend sources
 LIST(APPEND WebCore_SOURCES
+platform/graphics/blackberry/FontCacheBlackberry.cpp
 platform/graphics/blackberry/skia/PlatformBridge.cpp
 platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp
 platform/graphics/harfbuzz/FontHarfBuzz.cpp


Modified: trunk/Source/WebCore/WebCore.gypi (129256 => 129257)

--- trunk/Source/WebCore/WebCore.gypi	2012-09-21 21:40:49 UTC (rev 129256)
+++ trunk/Source/WebCore/WebCore.gypi	2012-09-21 21:43:57 UTC (rev 129257)
@@ -4888,6 +4888,7 @@
 'platform/graphics/chromium/DrawingBufferChromium.cpp',
 'platform/graphics/chromium/Extensions3DChromium.h',
 'platform/graphics/chromium/FontCacheAndroid.cpp',
+'platform/graphics

[webkit-changes] [129016] trunk/Source

2012-09-19 Thread pilgrim
Title: [129016] trunk/Source








Revision 129016
Author pilg...@chromium.org
Date 2012-09-19 10:45:55 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] Remove unused popupsAllowed function from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96521

Reviewed by Eric Seidel.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* bindings/v8/NPV8Object.cpp:
(WebCore::v8ObjectToNPObject):
(_NPN_Evaluate):
(_NPN_GetProperty):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/NPV8Object.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129015 => 129016)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 17:45:55 UTC (rev 129016)
@@ -1,3 +1,19 @@
+2012-09-19  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove unused popupsAllowed function from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=96521
+
+Reviewed by Eric Seidel.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* bindings/v8/NPV8Object.cpp:
+(WebCore::v8ObjectToNPObject):
+(_NPN_Evaluate):
+(_NPN_GetProperty):
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
 2012-09-19  Jonathan Dong  jonathan.d...@torchmobile.com.cn
 
 [BlackBerry] Add function playerId() in class PageClientBlackBerry


Modified: trunk/Source/WebCore/bindings/v8/NPV8Object.cpp (129015 => 129016)

--- trunk/Source/WebCore/bindings/v8/NPV8Object.cpp	2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebCore/bindings/v8/NPV8Object.cpp	2012-09-19 17:45:55 UTC (rev 129016)
@@ -28,7 +28,6 @@
 
 #include NPV8Object.h
 
-#include PlatformSupport.h
 #include DOMWindow.h
 #include Frame.h
 #include NPObjectWrapper.h
@@ -296,7 +295,8 @@
 
 bool _NPN_Evaluate(NPP npp, NPObject* npObject, NPString* npScript, NPVariant* result)
 {
-bool popupsAllowed = PlatformSupport::popupsAllowed(npp);
+// FIXME: Give the embedder a way to control this.
+bool popupsAllowed = false;
 return _NPN_EvaluateHelper(npp, popupsAllowed, npObject, npScript, result);
 }
 


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (129015 => 129016)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-19 17:45:55 UTC (rev 129016)
@@ -119,7 +119,6 @@
 // Plugin -
 static bool plugins(bool refresh, VectorPluginInfo*);
 static NPObject* pluginScriptableObject(Widget*);
-static bool popupsAllowed(NPP);
 
 // Screen -
 static int screenHorizontalDPI(Widget*);


Modified: trunk/Source/WebKit/chromium/ChangeLog (129015 => 129016)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 17:45:55 UTC (rev 129016)
@@ -1,3 +1,15 @@
+2012-09-19  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove unused popupsAllowed function from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=96521
+
+Reviewed by Eric Seidel.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/PlatformSupport.cpp:
+(WebCore):
+
 2012-09-19  Kent Tamura  tk...@chromium.org
 
 [Chromium] Fix crash in WebFrameImpl::loadHistoryItem


Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (129015 => 129016)

--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-09-19 17:45:55 UTC (rev 129016)
@@ -566,12 +566,6 @@
 return client-screenInfo().availableRect;
 }
 
-bool PlatformSupport::popupsAllowed(NPP npp)
-{
-// FIXME: Give the embedder a way to control this.
-return false;
-}
-
 #if ENABLE(WORKERS)
 WorkerContextProxy* WorkerContextProxy::create(Worker* worker)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129020] trunk/Source

2012-09-19 Thread pilgrim
Title: [129020] trunk/Source








Revision 129020
Author pilg...@chromium.org
Date 2012-09-19 10:53:48 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] Move notifyJSOutOfMemory out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97116

Reviewed by Adam Barth.

Source/WebCore:

Part of a refactoring series. See tracking bug 82948.

* bindings/v8/V8Binding.cpp:
(WebCore::handleOutOfMemory):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::didExhaustMemoryAvailableForScript):
(FrameLoaderClient):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didExhaustMemoryAvailableForScript):
(WebKit):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/loader/FrameLoaderClient.h
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129019 => 129020)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 17:52:14 UTC (rev 129019)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 17:53:48 UTC (rev 129020)
@@ -1,3 +1,20 @@
+2012-09-19  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move notifyJSOutOfMemory out of PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97116
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* bindings/v8/V8Binding.cpp:
+(WebCore::handleOutOfMemory):
+* loader/FrameLoaderClient.h:
+(WebCore::FrameLoaderClient::didExhaustMemoryAvailableForScript):
+(FrameLoaderClient):
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
 2012-09-18  Dirk Schulze  k...@webkit.org
 
 Implement 'mask-type' for mask


Modified: trunk/Source/WebCore/bindings/v8/V8Binding.cpp (129019 => 129020)

--- trunk/Source/WebCore/bindings/v8/V8Binding.cpp	2012-09-19 17:52:14 UTC (rev 129019)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.cpp	2012-09-19 17:53:48 UTC (rev 129020)
@@ -35,7 +35,8 @@
 #include DOMStringList.h
 #include Element.h
 #include Frame.h
-#include PlatformSupport.h
+#include FrameLoader.h
+#include FrameLoaderClient.h
 #include QualifiedName.h
 #include Settings.h
 #include V8DOMStringList.h
@@ -332,7 +333,7 @@
 frame-script()-windowShell()-destroyGlobal();
 
 #if PLATFORM(CHROMIUM)
-PlatformSupport::notifyJSOutOfMemory(frame);
+frame-loader()-client()-didExhaustMemoryAvailableForScript();
 #endif
 
 if (Settings* settings = frame-settings())


Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (129019 => 129020)

--- trunk/Source/WebCore/loader/FrameLoaderClient.h	2012-09-19 17:52:14 UTC (rev 129019)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h	2012-09-19 17:53:48 UTC (rev 129020)
@@ -278,6 +278,8 @@
 virtual void documentElementAvailable() = 0;
 virtual void didPerformFirstNavigation() const = 0; // Navigation here means a transition from one page to another that ends up in the back/forward list.
 
+virtual void didExhaustMemoryAvailableForScript() { };
+
 #if USE(V8)
 virtual void didCreateScriptContext(v8::Handlev8::Context, int extensionGroup, int worldId) = 0;
 virtual void willReleaseScriptContext(v8::Handlev8::Context, int worldId) = 0;


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (129019 => 129020)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-19 17:52:14 UTC (rev 129019)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-19 17:53:48 UTC (rev 129020)
@@ -113,9 +113,6 @@
 // IndexedDB --
 static PassRefPtrIDBFactoryBackendInterface idbFactory();
 
-// _javascript_ -
-static void notifyJSOutOfMemory(Frame*);
-
 // Plugin -
 static bool plugins(bool refresh, VectorPluginInfo*);
 static NPObject* pluginScriptableObject(Widget*);


Modified: trunk/Source/WebKit/chromium/ChangeLog (129019 => 129020)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 17:52:14 UTC (rev 129019)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-19 17:53:48 UTC (rev 129020)
@@ -1,5 +1,22 @@
 2012-09-19  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Move notifyJSOutOfMemory out of PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97116
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tra

[webkit-changes] [129027] trunk/Source/WebCore

2012-09-19 Thread pilgrim
Title: [129027] trunk/Source/WebCore








Revision 129027
Author pilg...@chromium.org
Date 2012-09-19 11:56:31 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] Remove unused PlatformSupport reference in V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=97117

Reviewed by Ryosuke Niwa.

Part of a refactoring series. See tracking bug 82948.

* bindings/v8/V8DOMWindowShell.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129026 => 129027)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 18:52:18 UTC (rev 129026)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 18:56:31 UTC (rev 129027)
@@ -1,3 +1,14 @@
+2012-09-19  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove unused PlatformSupport reference in V8DOMWindowShell
+https://bugs.webkit.org/show_bug.cgi?id=97117
+
+Reviewed by Ryosuke Niwa.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* bindings/v8/V8DOMWindowShell.cpp:
+
 2012-09-19  Kentaro Hara  hara...@chromium.org
 
 [V8] Remove WorkerContextExecutionProxy::runScript()


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (129026 => 129027)

--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2012-09-19 18:52:18 UTC (rev 129026)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2012-09-19 18:56:31 UTC (rev 129027)
@@ -41,7 +41,6 @@
 #include MemoryUsageSupport.h
 #include Page.h
 #include PageGroup.h
-#include PlatformSupport.h
 #include RuntimeEnabledFeatures.h
 #include ScriptCallStack.h
 #include ScriptCallStackFactory.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129030] trunk/Source/WebCore

2012-09-19 Thread pilgrim
Title: [129030] trunk/Source/WebCore








Revision 129030
Author pilg...@chromium.org
Date 2012-09-19 12:12:49 -0700 (Wed, 19 Sep 2012)


Log Message
[Chromium] Remove unused PlatformSupport reference in V8GCController
https://bugs.webkit.org/show_bug.cgi?id=97118

Reviewed by Ryosuke Niwa.

Part of a refactoring series. See tracking bug 82948.

* bindings/v8/V8GCController.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8GCController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129029 => 129030)

--- trunk/Source/WebCore/ChangeLog	2012-09-19 19:07:39 UTC (rev 129029)
+++ trunk/Source/WebCore/ChangeLog	2012-09-19 19:12:49 UTC (rev 129030)
@@ -1,5 +1,16 @@
 2012-09-19  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Remove unused PlatformSupport reference in V8GCController
+https://bugs.webkit.org/show_bug.cgi?id=97118
+
+Reviewed by Ryosuke Niwa.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* bindings/v8/V8GCController.cpp:
+
+2012-09-19  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Remove unused PlatformSupport reference in V8DOMWindowShell
 https://bugs.webkit.org/show_bug.cgi?id=97117
 


Modified: trunk/Source/WebCore/bindings/v8/V8GCController.cpp (129029 => 129030)

--- trunk/Source/WebCore/bindings/v8/V8GCController.cpp	2012-09-19 19:07:39 UTC (rev 129029)
+++ trunk/Source/WebCore/bindings/v8/V8GCController.cpp	2012-09-19 19:12:49 UTC (rev 129030)
@@ -39,7 +39,6 @@
 #include HTMLNames.h
 #include MemoryUsageSupport.h
 #include MessagePort.h
-#include PlatformSupport.h
 #include RetainedDOMInfo.h
 #include RetainedObjectInfo.h
 #include V8AbstractEventListener.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [128316] trunk/Source/WebCore

2012-09-12 Thread pilgrim
Title: [128316] trunk/Source/WebCore








Revision 128316
Author pilg...@chromium.org
Date 2012-09-12 08:44:18 -0700 (Wed, 12 Sep 2012)


Log Message
[Chromium] Remove unused getProcessMemorySize from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96520

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128315 => 128316)

--- trunk/Source/WebCore/ChangeLog	2012-09-12 15:36:45 UTC (rev 128315)
+++ trunk/Source/WebCore/ChangeLog	2012-09-12 15:44:18 UTC (rev 128316)
@@ -1,3 +1,15 @@
+2012-09-12  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove unused getProcessMemorySize from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=96520
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
 2012-09-12  Roland Takacs  rtak...@inf.u-szeged.hu
 
 [Qt] Segmentation fault when closing QtTestBrowser


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (128315 => 128316)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-12 15:36:45 UTC (rev 128315)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-12 15:44:18 UTC (rev 128316)
@@ -134,10 +134,6 @@
 static IntRect screenRect(Widget*);
 static IntRect screenAvailableRect(Widget*);
 
-// Returns private and shared usage, in bytes. Private bytes is the amount of
-// memory currently allocated to this process that cannot be shared. Returns
-// false on platform specific error conditions.
-static bool getProcessMemorySize(size_t* privateBytes, size_t* sharedBytes);
 // Theming 
 #if OS(WINDOWS)
 static void paintButton(






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [128322] trunk/Source/WebCore

2012-09-12 Thread pilgrim
Title: [128322] trunk/Source/WebCore








Revision 128322
Author pilg...@chromium.org
Date 2012-09-12 09:11:28 -0700 (Wed, 12 Sep 2012)


Log Message
[Chromium] Remove unused allowScriptDespiteSettings function from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96526

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128321 => 128322)

--- trunk/Source/WebCore/ChangeLog	2012-09-12 16:06:55 UTC (rev 128321)
+++ trunk/Source/WebCore/ChangeLog	2012-09-12 16:11:28 UTC (rev 128322)
@@ -1,3 +1,15 @@
+2012-09-12  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove unused allowScriptDespiteSettings function from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=96526
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
 2012-09-12  Dominic Mazzoni  dmazz...@google.com
 
 AX: Refactor most AccessibilityRenderObject code into AccessibilityNodeObject


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (128321 => 128322)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-12 16:06:55 UTC (rev 128321)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-12 16:11:28 UTC (rev 128322)
@@ -118,7 +118,6 @@
 
 // _javascript_ -
 static void notifyJSOutOfMemory(Frame*);
-static bool allowScriptDespiteSettings(const KURL documentURL);
 
 // Plugin -
 static bool plugins(bool refresh, VectorPluginInfo*);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [128337] trunk/Source/WebCore

2012-09-12 Thread pilgrim
Title: [128337] trunk/Source/WebCore








Revision 128337
Author pilg...@chromium.org
Date 2012-09-12 10:39:09 -0700 (Wed, 12 Sep 2012)


Log Message
[Chromium] Remove unused notifyFormStateChanged function in PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96527

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128336 => 128337)

--- trunk/Source/WebCore/ChangeLog	2012-09-12 17:32:37 UTC (rev 128336)
+++ trunk/Source/WebCore/ChangeLog	2012-09-12 17:39:09 UTC (rev 128337)
@@ -1,3 +1,15 @@
+2012-09-12  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove unused notifyFormStateChanged function in PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=96527
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
 2012-09-12  Mihnea Ovidenie  mih...@adobe.com
 
 [CSSRegions]Shrink RenderFlowThread size by using bit flags


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (128336 => 128337)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-12 17:32:37 UTC (rev 128336)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-09-12 17:39:09 UTC (rev 128337)
@@ -110,9 +110,6 @@
 static void getFontFamilyForCharacters(const UChar*, size_t numCharacters, const char* preferredLocale, FontFamily*);
 #endif
 
-// Forms --
-static void notifyFormStateChanged(const Document*);
-
 // IndexedDB --
 static PassRefPtrIDBFactoryBackendInterface idbFactory();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [128087] trunk/Source/WebKit/chromium

2012-09-10 Thread pilgrim
Title: [128087] trunk/Source/WebKit/chromium








Revision 128087
Author pilg...@chromium.org
Date 2012-09-10 12:07:48 -0700 (Mon, 10 Sep 2012)


Log Message
[Chromium] Define new setSharedWorkerRepository function in preparation for removing WebKitPlatformSupport::sharedWorkerRepository()
https://bugs.webkit.org/show_bug.cgi?id=95861

Reviewed by Adam Barth.

Followup patch to Chromium will call this new function, then we can remove all references to the legacy function on WebKitPlatformSupport.

* public/WebSharedWorkerRepository.h:
(WebKit):
* src/SharedWorkerRepository.cpp:
(WebKit):
(WebKit::setSharedWorkerRepository):
(WebKit::sharedWorkerRepository):
(WebCore::SharedWorkerRepository::isAvailable):
(WebCore::SharedWorkerRepository::connect):
(WebCore::SharedWorkerRepository::documentDetached):
(WebCore::SharedWorkerRepository::hasSharedWorkers):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSharedWorkerRepository.h
trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (128086 => 128087)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-10 18:50:54 UTC (rev 128086)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-10 19:07:48 UTC (rev 128087)
@@ -1,3 +1,23 @@
+2012-09-10  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Define new setSharedWorkerRepository function in preparation for removing WebKitPlatformSupport::sharedWorkerRepository()
+https://bugs.webkit.org/show_bug.cgi?id=95861
+
+Reviewed by Adam Barth.
+
+Followup patch to Chromium will call this new function, then we can remove all references to the legacy function on WebKitPlatformSupport.
+
+* public/WebSharedWorkerRepository.h:
+(WebKit):
+* src/SharedWorkerRepository.cpp:
+(WebKit):
+(WebKit::setSharedWorkerRepository):
+(WebKit::sharedWorkerRepository):
+(WebCore::SharedWorkerRepository::isAvailable):
+(WebCore::SharedWorkerRepository::connect):
+(WebCore::SharedWorkerRepository::documentDetached):
+(WebCore::SharedWorkerRepository::hasSharedWorkers):
+
 2012-09-10  Catalin Badea  ba...@adobe.com
 
 webkit build for 64-bit Mac chromium


Modified: trunk/Source/WebKit/chromium/public/WebSharedWorkerRepository.h (128086 => 128087)

--- trunk/Source/WebKit/chromium/public/WebSharedWorkerRepository.h	2012-09-10 18:50:54 UTC (rev 128086)
+++ trunk/Source/WebKit/chromium/public/WebSharedWorkerRepository.h	2012-09-10 19:07:48 UTC (rev 128087)
@@ -54,6 +54,9 @@
 virtual bool hasSharedWorkers(DocumentID) = 0;
 };
 
+// Initializes shared worker support.
+WEBKIT_EXPORT void setSharedWorkerRepository(WebSharedWorkerRepository*);
+
 } // namespace WebKit
 
 #endif // WebSharedWorkerRepository_h


Modified: trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp (128086 => 128087)

--- trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2012-09-10 18:50:54 UTC (rev 128086)
+++ trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2012-09-10 19:07:48 UTC (rev 128087)
@@ -58,6 +58,30 @@
 #include public/WebString.h
 #include public/WebURL.h
 
+namespace WebKit {
+
+WebSharedWorkerRepository* s_sharedWorkerRepository = 0;
+
+void setSharedWorkerRepository(WebSharedWorkerRepository* repository)
+{
+s_sharedWorkerRepository = repository;
+}
+
+static WebSharedWorkerRepository* sharedWorkerRepository()
+{
+WebSharedWorkerRepository* repository;
+
+repository = s_sharedWorkerRepository;
+if (!repository) {
+repository = webKitPlatformSupport()-sharedWorkerRepository();
+setSharedWorkerRepository(repository);
+}
+
+return repository;
+}
+
+}
+
 namespace WebCore {
 
 class Document;
@@ -194,8 +218,9 @@
 
 bool SharedWorkerRepository::isAvailable()
 {
-// Allow the WebKitPlatformSupport to determine if SharedWorkers are available.
-return WebKit::webKitPlatformSupport()-sharedWorkerRepository();
+// Allow the WebKitPlatformSupport to determine if SharedWorkers
+// are available.
+return WebKit::sharedWorkerRepository();
 }
 
 static WebSharedWorkerRepository::DocumentID getId(void* document)
@@ -206,9 +231,11 @@
 
 void SharedWorkerRepository::connect(PassRefPtrSharedWorker worker, PassOwnPtrMessagePortChannel port, const KURL url, const String name, ExceptionCode ec)
 {
+WebKit::WebSharedWorkerRepository* repository = WebKit::sharedWorkerRepository();
+
 // This should not be callable unless there's a SharedWorkerRepository for
 // this context (since isAvailable() should have returned null).
-ASSERT(WebKit::webKitPlatformSupport()-sharedWorkerRepository());
+ASSERT(repository);
 
 // No nested workers (for now) - connect() should only be called from document context.
 ASSERT(worker-scriptExecutionContext()-isDocument());
@@ -223,8 +250,7 @@
 return;
 }
 
-WebKit::webKitPlatfo

[webkit-changes] [127623] trunk/Source

2012-09-05 Thread pilgrim
Title: [127623] trunk/Source








Revision 127623
Author pilg...@chromium.org
Date 2012-09-05 12:04:08 -0700 (Wed, 05 Sep 2012)


Log Message
[Chromium] Remove getRenderStyleForStrike from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=95363

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/linux/WebFontInfo.h: Added.
(WebKit):
(WebFontInfo):
* chromium/public/linux/WebFontRenderStyle.h: Added.
(WebKit):

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::getRenderStyleForStrike):
(WebCore):
(WebCore::FontPlatformData::querySystemForRenderStyle):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):

Source/WebKit/chromium:

* public/linux/WebFontInfo.h:
* public/linux/WebFontRenderStyle.h:
* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/linux/WebFontInfo.h
trunk/Source/WebKit/chromium/public/linux/WebFontRenderStyle.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp


Added Paths

trunk/Source/Platform/chromium/public/linux/WebFontInfo.h
trunk/Source/Platform/chromium/public/linux/WebFontRenderStyle.h




Diff

Modified: trunk/Source/Platform/ChangeLog (127622 => 127623)

--- trunk/Source/Platform/ChangeLog	2012-09-05 19:03:24 UTC (rev 127622)
+++ trunk/Source/Platform/ChangeLog	2012-09-05 19:04:08 UTC (rev 127623)
@@ -1,3 +1,19 @@
+2012-09-05  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove getRenderStyleForStrike from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=95363
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* Platform.gypi:
+* chromium/public/linux/WebFontInfo.h: Added.
+(WebKit):
+(WebFontInfo):
+* chromium/public/linux/WebFontRenderStyle.h: Added.
+(WebKit):
+
 2012-09-05  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Add the local and remote description functionality to RTCPeerConnection


Modified: trunk/Source/Platform/Platform.gypi (127622 => 127623)

--- trunk/Source/Platform/Platform.gypi	2012-09-05 19:03:24 UTC (rev 127622)
+++ trunk/Source/Platform/Platform.gypi	2012-09-05 19:04:08 UTC (rev 127623)
@@ -149,6 +149,8 @@
 'chromium/public/WebWorkerRunLoop.h',
 'chromium/public/android/WebSandboxSupport.h',
 'chromium/public/android/WebThemeEngine.h',
+'chromium/public/linux/WebFontInfo.h',
+'chromium/public/linux/WebFontRenderStyle.h',
 'chromium/public/linux/WebSandboxSupport.h',
 'chromium/public/linux/WebThemeEngine.h',
 'chromium/public/mac/WebSandboxSupport.h',


Copied: trunk/Source/Platform/chromium/public/linux/WebFontInfo.h (from rev 127620, trunk/Source/WebKit/chromium/public/linux/WebFontInfo.h) (0 => 127623)

--- trunk/Source/Platform/chromium/public/linux/WebFontInfo.h	(rev 0)
+++ trunk/Source/Platform/chromium/public/linux/WebFontInfo.h	2012-09-05 19:04:08 UTC (rev 127623)
@@ -0,0 +1,78 @@
+/*
+ * Copyright (C) 2009 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+

[webkit-changes] [126939] trunk/Source

2012-08-28 Thread pilgrim
Title: [126939] trunk/Source








Revision 126939
Author pilg...@chromium.org
Date 2012-08-28 16:30:19 -0700 (Tue, 28 Aug 2012)


Log Message
[Chromium] Remove decodeAudioFileData from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=95250

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/audio/chromium/AudioBusChromium.cpp:
(WebCore::decodeAudioFileData):
(WebCore):
(WebCore::AudioBus::loadPlatformResource):
(WebCore::createBusFromInMemoryAudioFile):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/chromium/AudioBusChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (126938 => 126939)

--- trunk/Source/WebCore/ChangeLog	2012-08-28 23:27:51 UTC (rev 126938)
+++ trunk/Source/WebCore/ChangeLog	2012-08-28 23:30:19 UTC (rev 126939)
@@ -1,3 +1,20 @@
+2012-08-28  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove decodeAudioFileData from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=95250
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/audio/chromium/AudioBusChromium.cpp:
+(WebCore::decodeAudioFileData):
+(WebCore):
+(WebCore::AudioBus::loadPlatformResource):
+(WebCore::createBusFromInMemoryAudioFile):
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
 2012-08-27  Alexandru Chiculita  ach...@adobe.com
 
 [CSS Filters] Filters should render using sRGB until the specification says how it works


Modified: trunk/Source/WebCore/platform/audio/chromium/AudioBusChromium.cpp (126938 => 126939)

--- trunk/Source/WebCore/platform/audio/chromium/AudioBusChromium.cpp	2012-08-28 23:27:51 UTC (rev 126938)
+++ trunk/Source/WebCore/platform/audio/chromium/AudioBusChromium.cpp	2012-08-28 23:30:19 UTC (rev 126939)
@@ -29,43 +29,51 @@
 #include AudioBus.h
 
 #include AudioFileReader.h
-#include PlatformSupport.h
 #include public/Platform.h
+#include public/WebAudioBus.h
 #include wtf/PassOwnPtr.h
 
 namespace WebCore {
 
+PassOwnPtrAudioBus decodeAudioFileData(const char* data, size_t size, double sampleRate)
+{
+WebKit::WebAudioBus webAudioBus;
+if (WebKit::Platform::current()-loadAudioResource(webAudioBus, data, size, sampleRate))
+return webAudioBus.release();
+return nullptr;
+}
+
 PassOwnPtrAudioBus AudioBus::loadPlatformResource(const char* name, float sampleRate)
 {
 const WebKit::WebData resource = WebKit::Platform::current()-loadResource(name);
 if (resource.isEmpty())
 return nullptr;
-
+
 // FIXME: the sampleRate parameter is ignored. It should be removed from the API.
-OwnPtrAudioBus audioBus = PlatformSupport::decodeAudioFileData(resource.data(), resource.size(), sampleRate);
+OwnPtrAudioBus audioBus = decodeAudioFileData(resource.data(), resource.size(), sampleRate);
 
 if (!audioBus.get())
 return nullptr;
-
+
 // If the bus is already at the requested sample-rate then return as is.
 if (audioBus-sampleRate() == sampleRate)
 return audioBus.release();
-
+
 return AudioBus::createBySampleRateConverting(audioBus.get(), false, sampleRate);
 }
 
 PassOwnPtrAudioBus createBusFromInMemoryAudioFile(const void* data, size_t dataSize, bool mixToMono, float sampleRate)
 {
 // FIXME: the sampleRate parameter is ignored. It should be removed from the API.
-OwnPtrAudioBus audioBus = PlatformSupport::decodeAudioFileData(static_castconst char*(data), dataSize, sampleRate);
+OwnPtrAudioBus audioBus = decodeAudioFileData(static_castconst char*(data), dataSize, sampleRate);
 if (!audioBus.get())
 return nullptr;
-  
+
 // If the bus needs no conversion then return as is.
 if ((!mixToMono || audioBus-numberOfChannels() == 1)  audioBus-sampleRate() == sampleRate)
 return audioBus.release();
-
-return AudioBus::createBySampleRateConverting(audioBus.get(), mixToMono, sampleRate);
+
+return AudioBus::createBySampleRateConverting(audioBus.get(), mixToMono, sampleRate);
 }
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (126938 => 126939)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-08-28 23:27:51 UTC (rev 126938)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-08-28 23:30:19 UTC (rev 126939)
@@ -133,11 +133,6 @@
 static NPObject* pluginScriptableObject(Widget*);
 static bool popupsAllowed(NPP);
 
-// Resources --
-#if ENABLE(WEB_AUDIO)
-static PassOwnPtrAudioBus decodeAudi

[webkit-changes] [126647] trunk/Source

2012-08-24 Thread pilgrim
Title: [126647] trunk/Source








Revision 126647
Author pilg...@chromium.org
Date 2012-08-24 16:08:42 -0700 (Fri, 24 Aug 2012)


Log Message
[Chromium] Remove visitedLinkHash from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=94965

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/LinkHashChromium.cpp:
(WebCore):
(WebCore::visitedLinkHash):
* platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/LinkHashChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (126646 => 126647)

--- trunk/Source/WebCore/ChangeLog	2012-08-24 23:07:16 UTC (rev 126646)
+++ trunk/Source/WebCore/ChangeLog	2012-08-24 23:08:42 UTC (rev 126647)
@@ -1,3 +1,17 @@
+2012-08-24  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove visitedLinkHash from PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=94965
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/LinkHashChromium.cpp:
+(WebCore):
+(WebCore::visitedLinkHash):
+* platform/chromium/PlatformSupport.h:
+
 2012-08-24  Kevin Ellis  kev...@chromium.org
 
 [chromium] Reduce padding on popup menu entries when used on a touch screen.


Modified: trunk/Source/WebCore/platform/chromium/LinkHashChromium.cpp (126646 => 126647)

--- trunk/Source/WebCore/platform/chromium/LinkHashChromium.cpp	2012-08-24 23:07:16 UTC (rev 126646)
+++ trunk/Source/WebCore/platform/chromium/LinkHashChromium.cpp	2012-08-24 23:08:42 UTC (rev 126647)
@@ -1,10 +1,10 @@
 /*
  * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
- * 
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
- * 
+ *
  * * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  * * Redistributions in binary form must reproduce the above
@@ -14,7 +14,7 @@
  * * Neither the name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
- * 
+ *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
@@ -29,20 +29,59 @@
  */
 
 #include config.h
+#include KURL.h
 #include LinkHash.h
 
-#include PlatformSupport.h
+#if USE(GOOGLEURL)
+#include googleurl/src/url_util.h
+#endif
 
+#include public/Platform.h
+
 namespace WebCore {
 
+// Visited Links --
+
 LinkHash visitedLinkHash(const UChar* url, unsigned length)
 {
-return PlatformSupport::visitedLinkHash(url, length);
+url_canon::RawCanonOutput2048 buffer;
+url_parse::Parsed parsed;
+if (!url_util::Canonicalize(url, length, 0, buffer, parsed))
+return 0; // Invalid URLs are unvisited.
+return WebKit::Platform::current()-visitedLinkHash(buffer.data(), buffer.length());
 }
 
 LinkHash visitedLinkHash(const KURL base, const AtomicString attributeURL)
 {
-return PlatformSupport::visitedLinkHash(base, attributeURL);
+// Resolve the relative URL using googleurl and pass the absolute URL up to
+// the embedder. We could create a GURL object from the base and resolve
+// the relative URL that way, but calling the lower-level functions
+// directly saves us the string allocation in most cases.
+url_canon::RawCanonOutput2048 buffer;
+url_parse::Parsed parsed;
+
+#if USE(GOOGLEURL)
+const CString cstr = base.utf8String();
+const char* data = ""
+int length = cstr.length();
+const url_parse::Parsed srcParsed = base.parsed();
+#else
+// When we're not using GoogleURL, first canonicalize it so we can resolve it
+// below.
+url_canon::RawCanonOutput2048 srcCanon;
+url_parse::Parsed srcParsed;
+String str = base.string();
+if (!url_util::Canonicalize(str.characters(), str.length(), 0, srcCanon, srcParsed))
+return 0;
+const char* data = ""
+int length = srcCanon.length();
+#endif
+
+if (!url_util::ResolveRelative(data, length, srcParsed, attributeURL.characters(),
+   attributeURL.length(), 0, buffer, parsed))
+return 0; // Invalid resolved URL.
+
+return WebKit::Platform::current()-visitedLinkHash(buffer.data(), buffer.length());
 }
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/platform/

[webkit-changes] [123014] trunk/Source

2012-07-18 Thread pilgrim
Title: [123014] trunk/Source








Revision 123014
Author pilg...@chromium.org
Date 2012-07-18 13:51:30 -0700 (Wed, 18 Jul 2012)


Log Message
[Chromium] Call SQLiteFileSystem-related functions directly
https://bugs.webkit.org/show_bug.cgi?id=91631

Reviewed by Adam Barth.

Source/Platform:

Part of a refactoring series. See tracking bug 82948.

* chromium/public/Platform.h:
(Platform):
(WebKit::Platform::databaseOpenFile):
(WebKit::Platform::databaseDeleteFile):
(WebKit::Platform::databaseGetFileAttributes):
(WebKit::Platform::databaseGetFileSize):
(WebKit::Platform::databaseGetSpaceAvailableForOrigin):

Source/WebCore:

Part of a refactoring series. See tracking bug 82948.

* Modules/webdatabase/chromium/QuotaTracker.cpp:
(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::deleteDatabaseFile):
(WebCore::SQLiteFileSystem::getDatabaseFileSize):
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport):
* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/chromium/QuotaTracker.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromium.cpp
trunk/Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp
trunk/Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (123013 => 123014)

--- trunk/Source/Platform/ChangeLog	2012-07-18 20:43:40 UTC (rev 123013)
+++ trunk/Source/Platform/ChangeLog	2012-07-18 20:51:30 UTC (rev 123014)
@@ -1,3 +1,20 @@
+2012-07-18  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Call SQLiteFileSystem-related functions directly
+https://bugs.webkit.org/show_bug.cgi?id=91631
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* chromium/public/Platform.h:
+(Platform):
+(WebKit::Platform::databaseOpenFile):
+(WebKit::Platform::databaseDeleteFile):
+(WebKit::Platform::databaseGetFileAttributes):
+(WebKit::Platform::databaseGetFileSize):
+(WebKit::Platform::databaseGetSpaceAvailableForOrigin):
+
 2012-07-18  Sailesh Agrawal  s...@chromium.org
 
 Chromium Mac: Add TEXTURE_RECTANGLE_ARB support to CCVideoLayerImpl


Modified: trunk/Source/Platform/chromium/public/Platform.h (123013 => 123014)

--- trunk/Source/Platform/chromium/public/Platform.h	2012-07-18 20:43:40 UTC (rev 123013)
+++ trunk/Source/Platform/chromium/public/Platform.h	2012-07-18 20:51:30 UTC (rev 123014)
@@ -68,6 +68,14 @@
 
 class Platform {
 public:
+// HTML5 Database --
+
+#ifdef WIN32
+typedef HANDLE FileHandle;
+#else
+typedef int FileHandle;
+#endif
+
 WEBKIT_EXPORT static void initialize(Platform*);
 WEBKIT_EXPORT static void shutdown();
 WEBKIT_EXPORT static Platform* current();
@@ -104,6 +112,25 @@
 virtual WebBlobRegistry* blobRegistry() { return 0; }
 
 
+// Database 
+
+// Opens a database file; dirHandle should be 0 if the caller does not need
+// a handle to the directory containing this file
+virtual FileHandle databaseOpenFile(const WebString vfsFileName, int desiredFlags) { return FileHandle(); }
+
+// Deletes a database file and returns the error code
+virtual int databaseDeleteFile(const WebString vfsFileName, bool syncDir) { return 0; }
+
+// Returns the attributes of the given database file
+virtual long databaseGetFileAttributes(const WebString vfsFileName) { return 0; }
+
+// Returns the size of the given database file
+virtual long long databaseGetFileSize(const WebString vfsFileName) { return 0; }
+
+// Returns the space available for the given origin
+virtual long long databaseGetSpaceAvailableForOrigin(const WebKit::WebString originIdentifier) { return 0; }
+
+
 // DOM Storage --
 
 // Return a LocalStorage namespace that corresponds to the following path.


Modified: trunk/Source/WebCore/ChangeLog (123013 => 123014)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 20:43:40 UTC (rev 123013)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 20:51:30 UTC (rev 123014)
@@ -1,3 +1,22 @@
+2012-07-18  Mark Pilg

[webkit-changes] [119994] trunk/Source/WebCore

2012-06-11 Thread pilgrim
Title: [119994] trunk/Source/WebCore








Revision 119994
Author pilg...@chromium.org
Date 2012-06-11 11:36:12 -0700 (Mon, 11 Jun 2012)


Log Message
[Chromium] Remove some dead code in PasteboardChromium
https://bugs.webkit.org/show_bug.cgi?id=88782

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.
Leftover detritus from bug 88038.

* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PasteboardChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (119993 => 119994)

--- trunk/Source/WebCore/ChangeLog	2012-06-11 18:35:09 UTC (rev 119993)
+++ trunk/Source/WebCore/ChangeLog	2012-06-11 18:36:12 UTC (rev 119994)
@@ -1,3 +1,16 @@
+2012-06-11  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove some dead code in PasteboardChromium
+https://bugs.webkit.org/show_bug.cgi?id=88782
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+Leftover detritus from bug 88038.
+
+* platform/chromium/PasteboardChromium.cpp:
+(WebCore::Pasteboard::documentFragment):
+
 2012-06-11  Peter Beverloo  pe...@chromium.org
 
 [Chromium] Theme updates for Android in menu list rendering and selection backgrounds


Modified: trunk/Source/WebCore/platform/chromium/PasteboardChromium.cpp (119993 => 119994)

--- trunk/Source/WebCore/platform/chromium/PasteboardChromium.cpp	2012-06-11 18:35:09 UTC (rev 119993)
+++ trunk/Source/WebCore/platform/chromium/PasteboardChromium.cpp	2012-06-11 18:36:12 UTC (rev 119994)
@@ -1,10 +1,10 @@
 /*
  * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
- * 
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
- * 
+ *
  * * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  * * Redistributions in binary form must reproduce the above
@@ -14,7 +14,7 @@
  * * Neither the name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
- * 
+ *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
@@ -186,10 +186,6 @@
 unsigned fragmentEnd = 0;
 WebKit::WebURL url;
 markup = WebKit::Platform::current()-clipboard()-readHTML(buffer, url, fragmentStart, fragmentEnd);
-
-
-//PlatformSupport::clipboardReadHTML(buffer, markup, srcURL, fragmentStart, fragmentEnd);
-
 if (!markup.isEmpty()) {
   RefPtrDocumentFragment fragment =
   createFragmentFromMarkupWithContext(frame-document(), markup, fragmentStart, fragmentEnd, KURL(url), DisallowScriptingContent);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes


[webkit-changes] [119997] trunk/Source

2012-06-11 Thread pilgrim
Title: [119997] trunk/Source








Revision 119997
Author pilg...@chromium.org
Date 2012-06-11 11:54:52 -0700 (Mon, 11 Jun 2012)


Log Message
[Chromium] Call shared timer functions directly
https://bugs.webkit.org/show_bug.cgi?id=88781

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/SharedTimerChromium.cpp:
(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireInterval):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/chromium/SharedTimerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (119996 => 119997)

--- trunk/Source/WebCore/ChangeLog	2012-06-11 18:48:47 UTC (rev 119996)
+++ trunk/Source/WebCore/ChangeLog	2012-06-11 18:54:52 UTC (rev 119997)
@@ -1,3 +1,18 @@
+2012-06-11  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Call shared timer functions directly
+https://bugs.webkit.org/show_bug.cgi?id=88781
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* platform/chromium/SharedTimerChromium.cpp:
+(WebCore::setSharedTimerFiredFunction):
+(WebCore::setSharedTimerFireInterval):
+
 2012-06-11  Pravin D  pravind@gmail.com
 
 Relative pos. input fields in columns vanish when you start typing in them


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (119996 => 119997)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-06-11 18:48:47 UTC (rev 119996)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-06-11 18:54:52 UTC (rev 119997)
@@ -167,10 +167,6 @@
 static IntRect screenRect(Widget*);
 static IntRect screenAvailableRect(Widget*);
 
-// SharedTimers ---
-static void setSharedTimerFiredFunction(void (*func)());
-static void setSharedTimerFireInterval(double);
-
 // Returns private and shared usage, in bytes. Private bytes is the amount of
 // memory currently allocated to this process that cannot be shared. Returns
 // false on platform specific error conditions.


Modified: trunk/Source/WebCore/platform/chromium/SharedTimerChromium.cpp (119996 => 119997)

--- trunk/Source/WebCore/platform/chromium/SharedTimerChromium.cpp	2012-06-11 18:48:47 UTC (rev 119996)
+++ trunk/Source/WebCore/platform/chromium/SharedTimerChromium.cpp	2012-06-11 18:54:52 UTC (rev 119997)
@@ -20,26 +20,24 @@
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include config.h
 #include SharedTimer.h
 
-#include PlatformSupport.h
-
 #include public/Platform.h
 
 namespace WebCore {
 
 void setSharedTimerFiredFunction(void (*f)())
-{   
-PlatformSupport::setSharedTimerFiredFunction(f);
+{
+WebKit::Platform::current()-setSharedTimerFiredFunction(f);
 }
 
 void setSharedTimerFireInterval(double fireTime)
 {
-PlatformSupport::setSharedTimerFireInterval(fireTime);
+WebKit::Platform::current()-setSharedTimerFireInterval(fireTime);
 }
 
 void stopSharedTimer()


Modified: trunk/Source/WebKit/chromium/ChangeLog (119996 => 119997)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-06-11 18:48:47 UTC (rev 119996)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-06-11 18:54:52 UTC (rev 119997)
@@ -1,3 +1,15 @@
+2012-06-11  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Call shared timer functions directly
+https://bugs.webkit.org/show_bug.cgi?id=88781
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/PlatformSupport.cpp:
+(WebCore):
+
 2012-06-11  Amy Ousterhout  aoust...@chromium.org
 
 [Chromium] Removing long WebDeviceOrientation constructor


Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (119996 => 119997)

--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-06-11 18:48:47 UTC (rev 119996)
+++ trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-06-11 18:54:52 UTC (rev 119997)
@@ -371,18 +371,6 @@
 
 #endif // ENABLE(WEB_AUDIO)
 
-// SharedTimers ---
-
-void PlatformSupport::setSharedTimerFiredFunction(void (*func)())
-{
-webKitPlatformSupport()-setSharedTimerFiredFunction(func);
-}
-
-void 

[webkit-changes] [119777] trunk/Source

2012-06-07 Thread pilgrim
Title: [119777] trunk/Source








Revision 119777
Author pilg...@chromium.org
Date 2012-06-07 17:48:40 -0700 (Thu, 07 Jun 2012)


Log Message
[Chromium] Move didStartWorkerRunLoop to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=88562

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
* platform/chromium/PlatformSupport.h:
(WebCore):
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/workers/WorkerThread.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (119776 => 119777)

--- trunk/Source/WebCore/ChangeLog	2012-06-08 00:36:22 UTC (rev 119776)
+++ trunk/Source/WebCore/ChangeLog	2012-06-08 00:48:40 UTC (rev 119777)
@@ -1,3 +1,20 @@
+2012-06-07  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move didStartWorkerRunLoop to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=88562
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* WebCore.gyp/WebCore.gyp:
+* bindings/v8/WorkerScriptController.cpp:
+(WebCore::WorkerScriptController::~WorkerScriptController):
+* platform/chromium/PlatformSupport.h:
+(WebCore):
+* workers/WorkerThread.cpp:
+(WebCore::WorkerThread::workerThread):
+
 2012-06-07  Mike West  mk...@chromium.org
 
 Dropping m_startingLineNumber property from StyledElement.


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (119776 => 119777)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-06-08 00:36:22 UTC (rev 119776)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-06-08 00:48:40 UTC (rev 119777)
@@ -1841,6 +1841,9 @@
 {
   'target_name': 'webcore_remaining',
   'type': 'static_library',
+  'defines': [
+'WEBKIT_IMPLEMENTATION=1',
+  ],
   'dependencies': [
 'webcore_prerequisites',
 '(chromium_src_dir)/third_party/v8-i18n/build/all.gyp:v8-i18n',


Modified: trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp (119776 => 119777)

--- trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp	2012-06-08 00:36:22 UTC (rev 119776)
+++ trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp	2012-06-08 00:48:40 UTC (rev 119777)
@@ -47,6 +47,11 @@
 #include WorkerThread.h
 #include v8.h
 
+#if PLATFORM(CHROMIUM)
+#include public/Platform.h
+#include public/WebWorkerRunLoop.h
+#endif
+
 namespace WebCore {
 
 WorkerScriptController::WorkerScriptController(WorkerContext* workerContext)
@@ -69,7 +74,7 @@
 // The corresponding call to didStartWorkerRunLoop is in
 // WorkerThread::workerThread().
 // See http://webkit.org/b/83104#c14 for why this is here.
-PlatformSupport::didStopWorkerRunLoop(m_workerContext-thread()-runLoop());
+WebKit::Platform::current()-didStopWorkerRunLoop(WebKit::WebWorkerRunLoop(m_workerContext-thread()-runLoop()));
 #endif
 m_proxy.clear();
 m_isolate-Exit();


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (119776 => 119777)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-06-08 00:36:22 UTC (rev 119776)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-06-08 00:48:40 UTC (rev 119777)
@@ -81,7 +81,6 @@
 class KURL;
 class SerializedScriptValue;
 class Widget;
-class WorkerRunLoop;
 
 struct Cookie;
 struct FontRenderStyle;
@@ -331,9 +330,6 @@
 // Visited links --
 static LinkHash visitedLinkHash(const UChar* url, unsigned length);
 static LinkHash visitedLinkHash(const KURL base, const AtomicString attributeURL);
-
-static void didStartWorkerRunLoop(WorkerRunLoop*);
-static void didStopWorkerRunLoop(WorkerRunLoop*);
 };
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/workers/WorkerThread.cpp (119776 => 119777)

--- trunk/Source/WebCore/workers/WorkerThread.cpp	2012-06-08 00:36:22 UTC (rev 119776)
+++ trunk/Source/WebCore/workers/WorkerThread.cpp	2012-06-08 00:48:40 UTC (rev 119777)
@@ -20,7 +20,7 @@
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  *
  */
 
@@ -47,6 +47,11 @@
 #include DatabaseTracker.h
 #endif

[webkit-changes] [119666] trunk/Source

2012-06-06 Thread pilgrim
Title: [119666] trunk/Source








Revision 119666
Author pilg...@chromium.org
Date 2012-06-06 19:40:39 -0700 (Wed, 06 Jun 2012)


Log Message
[Chromium] Move createMessagePortChannel to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85764

Source/Platform:

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::createMessagePortChannel):
* chromium/public/WebMessagePortChannel.h: Added.
(WebKit):
(WebMessagePortChannel):
(WebKit::WebMessagePortChannel::~WebMessagePortChannel):
* chromium/public/WebMessagePortChannelClient.h: Added.
(WebKit):
(WebMessagePortChannelClient):
(WebKit::WebMessagePortChannelClient::~WebMessagePortChannelClient):

Source/WebKit/chromium:

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

* WebKit.gyp:
* public/WebFrame.h:
(WebFrame):
* public/WebMessagePortChannel.h:
* public/WebMessagePortChannelClient.h:
* public/WebSharedWorkerClient.h:
(WebSharedWorkerClient):
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
* src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
* src/PlatformMessagePortChannel.h:
* src/SharedWorkerRepository.cpp:
* src/WebSharedWorkerImpl.cpp:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/Platform/chromium/public/Platform.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/WebFrame.h
trunk/Source/WebKit/chromium/public/WebMessagePortChannel.h
trunk/Source/WebKit/chromium/public/WebMessagePortChannelClient.h
trunk/Source/WebKit/chromium/public/WebSharedWorkerClient.h
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp
trunk/Source/WebKit/chromium/src/PlatformMessagePortChannel.h
trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp
trunk/Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp


Added Paths

trunk/Source/Platform/chromium/public/WebMessagePortChannel.h
trunk/Source/Platform/chromium/public/WebMessagePortChannelClient.h




Diff

Modified: trunk/Source/Platform/ChangeLog (119665 => 119666)

--- trunk/Source/Platform/ChangeLog	2012-06-07 02:39:59 UTC (rev 119665)
+++ trunk/Source/Platform/ChangeLog	2012-06-07 02:40:39 UTC (rev 119666)
@@ -1,3 +1,26 @@
+2012-06-06  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move createMessagePortChannel to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=85764
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* Platform.gypi:
+* chromium/public/Platform.h:
+(WebKit):
+(Platform):
+(WebKit::Platform::createMessagePortChannel):
+* chromium/public/WebMessagePortChannel.h: Added.
+(WebKit):
+(WebMessagePortChannel):
+(WebKit::WebMessagePortChannel::~WebMessagePortChannel):
+* chromium/public/WebMessagePortChannelClient.h: Added.
+(WebKit):
+(WebMessagePortChannelClient):
+(WebKit::WebMessagePortChannelClient::~WebMessagePortChannelClient):
+
 2012-06-05  Mark Pilgrim  pilg...@chromium.org
 
 [Chromium] Move createLocalStorageNamespace to Platform.h


Modified: trunk/Source/Platform/Platform.gypi (119665 => 119666)

--- trunk/Source/Platform/Platform.gypi	2012-06-07 02:39:59 UTC (rev 119665)
+++ trunk/Source/Platform/Platform.gypi	2012-06-07 02:40:39 UTC (rev 119666)
@@ -77,6 +77,8 @@
 'chromium/public/WebMediaStreamDescriptor.h',
 'chromium/public/WebMediaStreamSource.h',
 'chromium/public/WebMediaStreamSourcesRequest.h',
+'chromium/public/WebMessagePortChannel.h',
+'chromium/public/WebMessagePortChannelClient.h',
 'chromium/public/WebMimeRegistry.h',
 'chromium/public/WebNonCopyable.h',
 'chromium/public/WebPeerConnection00Handler.h',


Modified: trunk/Source/Platform/chromium/public/Platform.h (119665 => 119666)

--- trunk/Source/Platform/chromium/public/Platform.h	2012-06-07 02:39:59 UTC (rev 119665)
+++ trunk/Source/Platform/chromium/public/Platform.h	2012-06-07 02:40:39 UTC (rev 119666)
@@ -49,6 +49,7 @@
 class WebFileUtilities;
 class WebMediaStreamCenter;
 class WebMediaStreamCenterClient;
+class WebMessagePortChannel;
 class WebMimeRegistry;
 class WebPeerConnection00Handler;
 class WebPeerConnection00HandlerClient;
@@ -165,6 +166,14 @@
 // false on platform specific error conditions.
 virtual bool processMemorySizesInBytes(size_t* privateBytes, size_t* sharedBytes) { return false; }
 
+
+// Message Ports ---
+
+// Creates a Message Port Channel. This can be called on any thread.
+// The

[webkit-changes] [119258] trunk/Source

2012-06-01 Thread pilgrim
Title: [119258] trunk/Source








Revision 119258
Author pilg...@chromium.org
Date 2012-06-01 11:55:29 -0700 (Fri, 01 Jun 2012)


Log Message
[Chromium] Call clipboard methods directly
https://bugs.webkit.org/show_bug.cgi?id=88038

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* chromium/public/WebClipboard.h:
(WebKit::WebClipboard::sequenceNumber):

Source/WebCore:

* WebCore.gypi:
* platform/Pasteboard.h:
(Pasteboard):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::createFromPasteboard):
* platform/chromium/ChromiumDataObjectItem.cpp:
(WebCore::ChromiumDataObjectItem::getAsFile):
(WebCore::ChromiumDataObjectItem::internalGetAsString):
* platform/chromium/ClipboardUtilitiesChromium.cpp:
(WebCore::currentPasteboardBuffer):
* platform/chromium/ClipboardUtilitiesChromium.h:
(WebCore):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::writeClipboard):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):
* platform/chromium/PasteboardPrivate.h: Removed.
* platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:
* src/PlatformSupport.cpp:
(WebCore::getCookieJar):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebClipboard.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/Pasteboard.h
trunk/Source/WebCore/platform/chromium/ChromiumDataObject.cpp
trunk/Source/WebCore/platform/chromium/ChromiumDataObjectItem.cpp
trunk/Source/WebCore/platform/chromium/ClipboardUtilitiesChromium.cpp
trunk/Source/WebCore/platform/chromium/ClipboardUtilitiesChromium.h
trunk/Source/WebCore/platform/chromium/PasteboardChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp


Removed Paths

trunk/Source/WebCore/platform/chromium/PasteboardPrivate.h




Diff

Modified: trunk/Source/Platform/ChangeLog (119257 => 119258)

--- trunk/Source/Platform/ChangeLog	2012-06-01 18:33:20 UTC (rev 119257)
+++ trunk/Source/Platform/ChangeLog	2012-06-01 18:55:29 UTC (rev 119258)
@@ -1,3 +1,15 @@
+2012-06-01  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Call clipboard methods directly
+https://bugs.webkit.org/show_bug.cgi?id=88038
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* chromium/public/WebClipboard.h:
+(WebKit::WebClipboard::sequenceNumber):
+
 2012-05-31  Shawn Singh  shawnsi...@chromium.org
 
 [chromium] Migrate to WebTransformationMatrix


Modified: trunk/Source/Platform/chromium/public/WebClipboard.h (119257 => 119258)

--- trunk/Source/Platform/chromium/public/WebClipboard.h	2012-06-01 18:33:20 UTC (rev 119257)
+++ trunk/Source/Platform/chromium/public/WebClipboard.h	2012-06-01 18:55:29 UTC (rev 119258)
@@ -33,7 +33,9 @@
 
 #include WebCommon.h
 #include WebData.h
+#include WebImage.h
 #include WebString.h
+#include WebURL.h
 #include WebVector.h
 
 namespace WebKit {
@@ -60,7 +62,7 @@
 
 // Returns an identifier which can be used to determine whether the data
 // contained within the clipboard has changed.
-virtual uint64 sequenceNumber(Buffer) { return 0; }
+virtual uint64_t sequenceNumber(Buffer) { return 0; }
 
 virtual bool isFormatAvailable(Format, Buffer) { return false; }
 


Modified: trunk/Source/WebCore/ChangeLog (119257 => 119258)

--- trunk/Source/WebCore/ChangeLog	2012-06-01 18:33:20 UTC (rev 119257)
+++ trunk/Source/WebCore/ChangeLog	2012-06-01 18:55:29 UTC (rev 119258)
@@ -1,3 +1,38 @@
+2012-06-01  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Call clipboard methods directly
+https://bugs.webkit.org/show_bug.cgi?id=88038
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* WebCore.gypi:
+* platform/Pasteboard.h:
+(Pasteboard):
+* platform/chromium/ChromiumDataObject.cpp:
+(WebCore::ChromiumDataObject::createFromPasteboard):
+* platform/chromium/ChromiumDataObjectItem.cpp:
+(WebCore::ChromiumDataObjectItem::getAsFile):
+(WebCore::ChromiumDataObjectItem::internalGetAsString):
+* platform/chromium/ClipboardUtilitiesChromium.cpp:
+(WebCore::currentPasteboardBuffer):
+* platform/chromium/ClipboardUtilitiesChromium.h:
+(WebCore):
+* platform/chromium/PasteboardChromium.cpp:
+(WebCore::Pasteboard::writeSelection):
+(WebCore::Pasteboard::writePlainText):
+(WebCore::Pasteboard::writeURL):
+   

[webkit-changes] [119024] trunk/Source

2012-05-30 Thread pilgrim
Title: [119024] trunk/Source








Revision 119024
Author pilg...@chromium.org
Date 2012-05-30 19:31:36 -0700 (Wed, 30 May 2012)


Log Message
[Chromium] Call fileUtilities methods directly
https://bugs.webkit.org/show_bug.cgi?id=87852

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
* platform/chromium/FileSystemChromium.cpp:
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::getFileMetadata):
(WebCore::directoryName):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/DragDataChromium.cpp
trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (119023 => 119024)

--- trunk/Source/WebCore/ChangeLog	2012-05-31 02:24:22 UTC (rev 119023)
+++ trunk/Source/WebCore/ChangeLog	2012-05-31 02:31:36 UTC (rev 119024)
@@ -1,3 +1,32 @@
+2012-05-30  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Call fileUtilities methods directly
+https://bugs.webkit.org/show_bug.cgi?id=87852
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/DragDataChromium.cpp:
+(WebCore::DragData::asURL):
+* platform/chromium/FileSystemChromium.cpp:
+(WebCore::deleteFile):
+(WebCore::deleteEmptyDirectory):
+(WebCore::getFileSize):
+(WebCore::getFileModificationTime):
+(WebCore::getFileMetadata):
+(WebCore::directoryName):
+(WebCore::pathByAppendingComponent):
+(WebCore::makeAllDirectories):
+(WebCore::openFile):
+(WebCore::closeFile):
+(WebCore::seekFile):
+(WebCore::truncateFile):
+(WebCore::readFromFile):
+(WebCore::writeToFile):
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
 2012-05-30  Kent Tamura  tk...@chromium.org
 
 Form controls in fieldset disabled should not be focusable.


Modified: trunk/Source/WebCore/platform/chromium/DragDataChromium.cpp (119023 => 119024)

--- trunk/Source/WebCore/platform/chromium/DragDataChromium.cpp	2012-05-31 02:24:22 UTC (rev 119023)
+++ trunk/Source/WebCore/platform/chromium/DragDataChromium.cpp	2012-05-31 02:31:36 UTC (rev 119024)
@@ -38,9 +38,11 @@
 #include KURL.h
 #include NotImplemented.h
 #include PlatformString.h
-#include PlatformSupport.h
 #include markup.h
 
+#include public/Platform.h
+#include public/WebFileUtilities.h
+
 namespace WebCore {
 
 static bool containsHTML(const ChromiumDataObject* dropData)
@@ -60,7 +62,8 @@
 if (m_platformDragData-types().contains(mimeTypeTextURIList))
 m_platformDragData-urlAndTitle(url, title);
 else if (filenamePolicy == ConvertFilenames  containsFiles()) {
-url = ""
+String path = String(WebKit::Platform::current()-fileUtilities()-getAbsolutePath(m_platformDragData-filenames()[0]));
+url = ""
 }
 return url;
 }


Modified: trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp (119023 => 119024)

--- trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp	2012-05-31 02:24:22 UTC (rev 119023)
+++ trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp	2012-05-31 02:31:36 UTC (rev 119024)
@@ -34,27 +34,27 @@
 #include FileMetadata.h
 #include NotImplemented.h
 #include PlatformString.h
-#include PlatformSupport.h
 
 #include public/Platform.h
+#include public/WebFileInfo.h
 #include public/WebFileUtilities.h
 
 namespace WebCore {
 
 bool deleteFile(const String path)
 {
-return PlatformSupport::deleteFile(path);
+return WebKit::Platform::current()-fileUtilities()-deleteFile(path);
 }
 
 bool deleteEmptyDirectory(const String path)
 {
-return PlatformSupport::deleteEmptyDirectory(path);
+return WebKit::Platform::current()-fileUtilities()-deleteEmptyDirectory(path);
 }
 
 bool getFileSize(const String path, long long result)
 {
 FileMetadata metadata;
-if (!PlatformSupport::getFileMetadata(path, metadata))
+if (!getFileMetadata(path, metadata))
 return false;
 result = metadata.length;
 return true;
@@ -63,7 +63,7 @@
 bool getFileModificationTime(const String path, time_t result)
 {
 FileMetadata metadata;
-if (!PlatformSupport::getFileMetadata(path, metadata))
+if (!getFileMetadata(path, met

[webkit-changes] [118873] trunk/Source

2012-05-29 Thread pilgrim
Title: [118873] trunk/Source








Revision 118873
Author pilg...@chromium.org
Date 2012-05-29 18:33:50 -0700 (Tue, 29 May 2012)


Log Message
[Chromium] Move fileExists to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=87531

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* chromium/public/Platform.h:
(WebKit::Platform::fileExists):
(Platform):

Source/WebCore:

* platform/chromium/FileSystemChromium.cpp:
(WebCore::fileExists):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (118872 => 118873)

--- trunk/Source/Platform/ChangeLog	2012-05-30 01:24:51 UTC (rev 118872)
+++ trunk/Source/Platform/ChangeLog	2012-05-30 01:33:50 UTC (rev 118873)
@@ -1,3 +1,16 @@
+2012-05-29  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move fileExists to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=87531
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* chromium/public/Platform.h:
+(WebKit::Platform::fileExists):
+(Platform):
+
 2012-05-29  Shawn Singh  shawnsi...@chromium.org
 
 [chromium] make WebTransformationMatrix object usable by non-webkit code


Modified: trunk/Source/Platform/chromium/public/Platform.h (118872 => 118873)

--- trunk/Source/Platform/chromium/public/Platform.h	2012-05-30 01:24:51 UTC (rev 118872)
+++ trunk/Source/Platform/chromium/public/Platform.h	2012-05-30 01:33:50 UTC (rev 118873)
@@ -106,6 +106,9 @@
 // Must return non-null.
 virtual WebFileSystem* fileSystem() { return 0; }
 
+virtual bool fileExists(const WebString) { return false; }
+
+
 // Gamepad -
 
 virtual void sampleGamepads(WebGamepads into) { into.length = 0; }


Modified: trunk/Source/WebCore/ChangeLog (118872 => 118873)

--- trunk/Source/WebCore/ChangeLog	2012-05-30 01:24:51 UTC (rev 118872)
+++ trunk/Source/WebCore/ChangeLog	2012-05-30 01:33:50 UTC (rev 118873)
@@ -1,3 +1,17 @@
+2012-05-29  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move fileExists to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=87531
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/FileSystemChromium.cpp:
+(WebCore::fileExists):
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
 2012-05-29  Kentaro Hara  hara...@chromium.org
 
 [V8] Rename v8Null() to v8NullWithCheck()


Modified: trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp (118872 => 118873)

--- trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp	2012-05-30 01:24:51 UTC (rev 118872)
+++ trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp	2012-05-30 01:33:50 UTC (rev 118873)
@@ -36,6 +36,8 @@
 #include PlatformString.h
 #include PlatformSupport.h
 
+#include public/Platform.h
+
 namespace WebCore {
 
 bool deleteFile(const String path)
@@ -88,7 +90,7 @@
 
 bool fileExists(const String path)
 {
-return PlatformSupport::fileExists(path);
+return WebKit::Platform::current()-fileExists(path);
 }
 
 PlatformFileHandle openFile(const String path, FileOpenMode mode)


Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (118872 => 118873)

--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-05-30 01:24:51 UTC (rev 118872)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-05-30 01:33:50 UTC (rev 118873)
@@ -123,7 +123,6 @@
 static bool cookiesEnabled(const Document*);
 
 // File ---
-static bool fileExists(const String);
 static bool deleteFile(const String);
 static bool deleteEmptyDirectory(const String);
 static bool getFileMetadata(const String, FileMetadata result);


Modified: trunk/Source/WebKit/chromium/ChangeLog (118872 => 118873)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-05-30 01:24:51 UTC (rev 118872)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-05-30 01:33:50 UTC (rev 118873)
@@ -1,3 +1,15 @@
+2012-05-29  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move fileExists to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=87531
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/PlatformSupport.cpp:
+(WebCore):
+
 2012-05-29  Alec Flett  alecfl...@chromium.org
 
   

[webkit-changes] [118894] trunk/Source

2012-05-29 Thread pilgrim
Title: [118894] trunk/Source








Revision 118894
Author pilg...@chromium.org
Date 2012-05-29 22:08:36 -0700 (Tue, 29 May 2012)


Log Message
[Chromium] Move fileExists to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=87531

Reviewed by Adam Barth.

Call fileExists through fileUtilities(), not directly.

Source/Platform:

* chromium/public/Platform.h:
(Platform):

Source/WebCore:

* platform/chromium/FileSystemChromium.cpp:
(WebCore::fileExists):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (118893 => 118894)

--- trunk/Source/Platform/ChangeLog	2012-05-30 04:37:43 UTC (rev 118893)
+++ trunk/Source/Platform/ChangeLog	2012-05-30 05:08:36 UTC (rev 118894)
@@ -5,6 +5,18 @@
 
 Reviewed by Adam Barth.
 
+Call fileExists through fileUtilities(), not directly.
+
+* chromium/public/Platform.h:
+(Platform):
+
+2012-05-29  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move fileExists to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=87531
+
+Reviewed by Adam Barth.
+
 Part of a refactoring series. See tracking bug 82948.
 
 * chromium/public/Platform.h:


Modified: trunk/Source/Platform/chromium/public/Platform.h (118893 => 118894)

--- trunk/Source/Platform/chromium/public/Platform.h	2012-05-30 04:37:43 UTC (rev 118893)
+++ trunk/Source/Platform/chromium/public/Platform.h	2012-05-30 05:08:36 UTC (rev 118894)
@@ -106,9 +106,7 @@
 // Must return non-null.
 virtual WebFileSystem* fileSystem() { return 0; }
 
-virtual bool fileExists(const WebString) { return false; }
 
-
 // Gamepad -
 
 virtual void sampleGamepads(WebGamepads into) { into.length = 0; }


Modified: trunk/Source/WebCore/ChangeLog (118893 => 118894)

--- trunk/Source/WebCore/ChangeLog	2012-05-30 04:37:43 UTC (rev 118893)
+++ trunk/Source/WebCore/ChangeLog	2012-05-30 05:08:36 UTC (rev 118894)
@@ -1,3 +1,15 @@
+2012-05-29  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move fileExists to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=87531
+
+Reviewed by Adam Barth.
+
+Call fileExists through fileUtilities(), not directly.
+
+* platform/chromium/FileSystemChromium.cpp:
+(WebCore::fileExists):
+
 2012-05-29  Kentaro Hara  hara...@chromium.org
 
 Remove a dummy style sheet from CSSParser::parseFlowThread()


Modified: trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp (118893 => 118894)

--- trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp	2012-05-30 04:37:43 UTC (rev 118893)
+++ trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp	2012-05-30 05:08:36 UTC (rev 118894)
@@ -37,6 +37,7 @@
 #include PlatformSupport.h
 
 #include public/Platform.h
+#include public/WebFileUtilities.h
 
 namespace WebCore {
 
@@ -90,7 +91,7 @@
 
 bool fileExists(const String path)
 {
-return WebKit::Platform::current()-fileExists(path);
+return WebKit::Platform::current()-fileUtilities()-fileExists(path);
 }
 
 PlatformFileHandle openFile(const String path, FileOpenMode mode)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes


[webkit-changes] [118590] trunk/Source

2012-05-25 Thread pilgrim
Title: [118590] trunk/Source








Revision 118590
Author pilg...@chromium.org
Date 2012-05-25 17:22:34 -0700 (Fri, 25 May 2012)


Log Message
[Chomium] Move sandboxSupport to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=87518

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::sandboxSupport):
* chromium/public/android/WebSandboxSupport.h: Added.
(WebKit):
(WebSandboxSupport):
* chromium/public/linux/WebFontFamily.h: Added.
(WebKit):
(WebFontFamily):
* chromium/public/linux/WebSandboxSupport.h: Added.
(WebKit):
(WebSandboxSupport):
* chromium/public/mac/WebSandboxSupport.h: Added.
(WebKit):
(WebSandboxSupport):
* chromium/public/win/WebSandboxSupport.h: Added.
(WebKit):
(WebSandboxSupport):

Source/WebKit/chromium:

* WebKit.gyp:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
* public/platform/android/WebSandboxSupport.h:
* public/platform/linux/WebFontFamily.h:
* public/platform/linux/WebSandboxSupport.h:
* public/platform/mac/WebSandboxSupport.h:
* public/platform/win/WebSandboxSupport.h:
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::ensureFontLoaded):
(WebCore::PlatformSupport::loadFont):
(WebCore::PlatformSupport::getFontFamilyForCharacters):
(WebCore::PlatformSupport::getRenderStyleForStrike):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/Platform/chromium/public/Platform.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/public/platform/android/WebSandboxSupport.h
trunk/Source/WebKit/chromium/public/platform/linux/WebFontFamily.h
trunk/Source/WebKit/chromium/public/platform/linux/WebSandboxSupport.h
trunk/Source/WebKit/chromium/public/platform/mac/WebSandboxSupport.h
trunk/Source/WebKit/chromium/public/platform/win/WebSandboxSupport.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp


Added Paths

trunk/Source/Platform/chromium/public/android/WebSandboxSupport.h
trunk/Source/Platform/chromium/public/linux/WebFontFamily.h
trunk/Source/Platform/chromium/public/linux/WebSandboxSupport.h
trunk/Source/Platform/chromium/public/mac/WebSandboxSupport.h
trunk/Source/Platform/chromium/public/win/WebSandboxSupport.h




Diff

Modified: trunk/Source/Platform/ChangeLog (118589 => 118590)

--- trunk/Source/Platform/ChangeLog	2012-05-26 00:18:27 UTC (rev 118589)
+++ trunk/Source/Platform/ChangeLog	2012-05-26 00:22:34 UTC (rev 118590)
@@ -1,3 +1,33 @@
+2012-05-25  Mark Pilgrim  pilg...@chromium.org
+
+[Chomium] Move sandboxSupport to Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=87518
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* Platform.gypi:
+* chromium/public/Platform.h:
+(WebKit):
+(Platform):
+(WebKit::Platform::sandboxSupport):
+* chromium/public/android/WebSandboxSupport.h: Added.
+(WebKit):
+(WebSandboxSupport):
+* chromium/public/linux/WebFontFamily.h: Added.
+(WebKit):
+(WebFontFamily):
+* chromium/public/linux/WebSandboxSupport.h: Added.
+(WebKit):
+(WebSandboxSupport):
+* chromium/public/mac/WebSandboxSupport.h: Added.
+(WebKit):
+(WebSandboxSupport):
+* chromium/public/win/WebSandboxSupport.h: Added.
+(WebKit):
+(WebSandboxSupport):
+
 2012-05-17  Andrey Kosyakov  ca...@chromium.org
 
 [chromium] add instrumentation for compositing


Modified: trunk/Source/Platform/Platform.gypi (118589 => 118590)

--- trunk/Source/Platform/Platform.gypi	2012-05-26 00:18:27 UTC (rev 118589)
+++ trunk/Source/Platform/Platform.gypi	2012-05-26 00:22:34 UTC (rev 118590)
@@ -112,9 +112,13 @@
 'chromium/public/WebVideoFrame.h',
 'chromium/public/WebVideoFrameProvider.h',
 'chromium/public/WebWorkerRunLoop.h',
+'chromium/public/android/WebSandboxSupport.h',
 'chromium/public/android/WebThemeEngine.h',
+'chromium/public/linux/WebSandboxSupport.h',
 'chromium/public/linux/WebThemeEngine.h',
+'chromium/public/mac/WebSandboxSupport.h',
 'chromium/public/mac/WebThemeEngine.h',
+'chromium/public/win/WebSandboxSupport.h',
 'chromium/public/win/WebThemeEngine.h',
 'chromium/src/Platform.cpp',
 'chromium/src/WebCString.cpp',


Modified: trunk/Source/Platform/chromium/public/Platform.h (118589 => 118590)

--- trunk/Source/Platform/chromium/public/Platform.h	2012-05-26 00:18:27 UTC (rev 118589)
+++ trunk/Source/Platform/chromium/public/Platform.h	2012-05-26 00:22:34 UTC (rev 118590)
@@ -56,6 +56,7 @@
 class WebPeerConnectionHandlerClient;
 class WebURL;
 class Web

  1   2   >