[webkit-changes] [143334] trunk/Source/WebCore
Title: [143334] trunk/Source/WebCore
Revision 143334
Author podivi...@chromium.org
Date 2013-02-19 08:12:47 -0800 (Tue, 19 Feb 2013)
Log Message
Web Inspector: release backtrace object group on each step.
https://bugs.webkit.org/show_bug.cgi?id=110223
Reviewed by Pavel Feldman.
* inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (14 => 143334)
--- trunk/Source/WebCore/ChangeLog 2013-02-19 16:01:52 UTC (rev 14)
+++ trunk/Source/WebCore/ChangeLog 2013-02-19 16:12:47 UTC (rev 143334)
@@ -1,3 +1,16 @@
+2013-02-19 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: release backtrace object group on each step.
+https://bugs.webkit.org/show_bug.cgi?id=110223
+
+Reviewed by Pavel Feldman.
+
+* inspector/InspectorDebuggerAgent.cpp:
+(WebCore):
+(WebCore::InspectorDebuggerAgent::stepOver):
+(WebCore::InspectorDebuggerAgent::stepInto):
+(WebCore::InspectorDebuggerAgent::stepOut):
+
2013-02-19 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r142975.
Modified: trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp (14 => 143334)
--- trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp 2013-02-19 16:01:52 UTC (rev 14)
+++ trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp 2013-02-19 16:12:47 UTC (rev 143334)
@@ -60,7 +60,7 @@
static const char pauseOnExceptionsState[] = pauseOnExceptionsState;
};
-const char* InspectorDebuggerAgent::backtraceObjectGroup = backtrace-object-group;
+const char* InspectorDebuggerAgent::backtraceObjectGroup = backtrace;
InspectorDebuggerAgent::InspectorDebuggerAgent(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* inspectorState, InjectedScriptManager* injectedScriptManager)
: InspectorBaseAgentInspectorDebuggerAgent(Debugger, instrumentingAgents, inspectorState)
@@ -455,6 +455,7 @@
{
if (!assertPaused(errorString))
return;
+m_injectedScriptManager-releaseObjectGroup(InspectorDebuggerAgent::backtraceObjectGroup);
scriptDebugServer().stepOverStatement();
}
@@ -462,6 +463,7 @@
{
if (!assertPaused(errorString))
return;
+m_injectedScriptManager-releaseObjectGroup(InspectorDebuggerAgent::backtraceObjectGroup);
scriptDebugServer().stepIntoStatement();
m_listener-stepInto();
}
@@ -470,6 +472,7 @@
{
if (!assertPaused(errorString))
return;
+m_injectedScriptManager-releaseObjectGroup(InspectorDebuggerAgent::backtraceObjectGroup);
scriptDebugServer().stepOutOfFunction();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137272] trunk/Source/WebCore
Title: [137272] trunk/Source/WebCore Revision 137272 Author podivi...@chromium.org Date 2012-12-11 01:59:40 -0800 (Tue, 11 Dec 2012) Log Message 2012-12-11 Pavel Podivilov podivi...@google.com Remove pango files deleted at r137263 form WebCore.gypi. Unreviewed, gardening. * WebCore.gypi: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi Diff Modified: trunk/Source/WebCore/ChangeLog (137271 => 137272) --- trunk/Source/WebCore/ChangeLog 2012-12-11 09:42:32 UTC (rev 137271) +++ trunk/Source/WebCore/ChangeLog 2012-12-11 09:59:40 UTC (rev 137272) @@ -1,3 +1,11 @@ +2012-12-11 Pavel Podivilov podivi...@google.com + +Remove pango files deleted at r137263 form WebCore.gypi. + +Unreviewed, gardening. + +* WebCore.gypi: + 2012-12-11 Zan Dobersek zandober...@gmail.com [GTK] Feature enabling/disabling should be possible through build-webkit Modified: trunk/Source/WebCore/WebCore.gypi (137271 => 137272) --- trunk/Source/WebCore/WebCore.gypi 2012-12-11 09:42:32 UTC (rev 137271) +++ trunk/Source/WebCore/WebCore.gypi 2012-12-11 09:59:40 UTC (rev 137272) @@ -4045,13 +4045,6 @@ 'platform/graphics/openvg/TiledImageOpenVG.h', 'platform/graphics/openvg/VGUtils.cpp', 'platform/graphics/openvg/VGUtils.h', -'platform/graphics/pango/FontCachePango.cpp', -'platform/graphics/pango/FontCustomPlatformDataPango.cpp', -'platform/graphics/pango/FontPango.cpp', -'platform/graphics/pango/FontPlatformData.h', -'platform/graphics/pango/FontPlatformDataPango.cpp', -'platform/graphics/pango/GlyphPageTreeNodePango.cpp', -'platform/graphics/pango/SimpleFontDataPango.cpp', 'platform/graphics/skia/BitmapImageSingleFrameSkia.cpp', 'platform/graphics/skia/BitmapImageSingleFrameSkia.h', 'platform/graphics/skia/FloatPointSkia.cpp', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137274] trunk/LayoutTests
Title: [137274] trunk/LayoutTests Revision 137274 Author podivi...@chromium.org Date 2012-12-11 02:06:11 -0800 (Tue, 11 Dec 2012) Log Message 2012-12-11 Pavel Podivilov podivi...@google.com [Chromium] Unreviewed, remove platform/blackberry [ WontFix ] from test expectations to make lint happy. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (137273 => 137274) --- trunk/LayoutTests/ChangeLog 2012-12-11 10:02:41 UTC (rev 137273) +++ trunk/LayoutTests/ChangeLog 2012-12-11 10:06:11 UTC (rev 137274) @@ -1,3 +1,10 @@ +2012-12-11 Pavel Podivilov podivi...@google.com + +[Chromium] Unreviewed, remove platform/blackberry [ WontFix ] from test expectations +to make lint happy. + +* platform/chromium/TestExpectations: + 2012-12-11 Zan Dobersek zandober...@gmail.com Unreviewed GTK gardening. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137273 => 137274) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 10:02:41 UTC (rev 137273) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-11 10:06:11 UTC (rev 137274) @@ -896,9 +896,6 @@ # need to implement this. platform/win/inverted-colors/non-composited.html [ WontFix ] -# Test for BlackBerry port only -platform/blackberry [ WontFix ] - # _javascript_Core bindings willfully have different behavior than V8 bindings plugins/npruntime/overrides-all-properties.html [ WontFix ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136828] trunk/LayoutTests
Title: [136828] trunk/LayoutTests Revision 136828 Author podivi...@chromium.org Date 2012-12-06 03:13:33 -0800 (Thu, 06 Dec 2012) Log Message [chromium] Unreviewed, fix baselines for plugins/npp-set-window-called-during-destruction.html on win7. * platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt: Removed. * platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt: Removed. * platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt: * platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt trunk/LayoutTests/platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt trunk/LayoutTests/platform/win/plugins/npp-set-window-called-during-destruction-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (136827 => 136828) --- trunk/LayoutTests/ChangeLog 2012-12-06 10:48:59 UTC (rev 136827) +++ trunk/LayoutTests/ChangeLog 2012-12-06 11:13:33 UTC (rev 136828) @@ -1,3 +1,12 @@ +2012-12-06 Pavel Podivilov podivi...@google.com + +[chromium] Unreviewed, fix baselines for plugins/npp-set-window-called-during-destruction.html on win7. + +* platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt: Removed. +* platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt: Removed. +* platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt: +* platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed. + 2012-12-06 Kent Tamura tk...@chromium.org [Chromium] Test expectation update Deleted: trunk/LayoutTests/platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt (136827 => 136828) --- trunk/LayoutTests/platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt 2012-12-06 10:48:59 UTC (rev 136827) +++ trunk/LayoutTests/platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt 2012-12-06 11:13:33 UTC (rev 136828) @@ -1,4 +0,0 @@ -CONSOLE MESSAGE: line 12: PLUGIN: NPP_New: Could not find a test named npp-set-window-called-during-destruction, maybe its .cpp file wasn't added to the build system? -CONSOLE MESSAGE: line 12: Uncaught TypeError: Object #HTMLEmbedElement has no method 'setWillBeDestroyed' - -This tests whether a NPP_SetWindow is called during plugin destruction. Modified: trunk/LayoutTests/platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt (136827 => 136828) --- trunk/LayoutTests/platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt 2012-12-06 10:48:59 UTC (rev 136827) +++ trunk/LayoutTests/platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt 2012-12-06 11:13:33 UTC (rev 136828) @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: PLUGIN: NPP_New: Could not find a test named npp-set-window-called-during-destruction, maybe its .cpp file wasn't added to the build system? +CONSOLE MESSAGE: line 12: PLUGIN: NPP_New: Could not find a test named npp-set-window-called-during-destruction, maybe its .cpp file wasn't added to the build system? CONSOLE MESSAGE: line 12: Uncaught TypeError: Object #HTMLEmbedElement has no method 'setWillBeDestroyed' This tests whether a NPP_SetWindow is called during plugin destruction. Deleted: trunk/LayoutTests/platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt (136827 => 136828) --- trunk/LayoutTests/platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt 2012-12-06 10:48:59 UTC (rev 136827) +++ trunk/LayoutTests/platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt 2012-12-06 11:13:33 UTC (rev 136828) @@ -1,4 +0,0 @@ -CONSOLE MESSAGE: line 12: PLUGIN: NPP_New: Could not find a test named npp-set-window-called-during-destruction, maybe its .cpp file wasn't added to the build system? -CONSOLE MESSAGE: line 12: Uncaught TypeError: Object #HTMLEmbedElement has no method 'setWillBeDestroyed' - -This tests whether a NPP_SetWindow is called during plugin destruction. Deleted: trunk/LayoutTests/platform/win/plugins/npp-set-window-called-during-destruction-expected.txt (136827 => 136828) --- trunk/LayoutTests/platform/win/plugins/npp-set-window-called-during-destruction-expected.txt 2012-12-06 10:48:59 UTC (rev 136827) +++ trunk/LayoutTests/platform/win/plugins/npp-set-window-called-during-destruction-expected.txt 2012-12-06 11:13:33 UTC (rev 136828) @@ -1,2 +0,0 @@ -CONSOLE MESSAGE: PLUGIN: Success: NPP_SetWindow was calle
[webkit-changes] [133137] trunk/LayoutTests
Title: [133137] trunk/LayoutTests Revision 133137 Author podivi...@chromium.org Date 2012-11-01 01:53:47 -0700 (Thu, 01 Nov 2012) Log Message 2012-11-01 Pavel Podivilov podivi...@google.com [chromium] Unreviewed, remove several tests that started to pass from TestExpectations. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (133136 => 133137) --- trunk/LayoutTests/ChangeLog 2012-11-01 08:04:37 UTC (rev 133136) +++ trunk/LayoutTests/ChangeLog 2012-11-01 08:53:47 UTC (rev 133137) @@ -1,3 +1,9 @@ +2012-11-01 Pavel Podivilov podivi...@google.com + +[chromium] Unreviewed, remove several tests that started to pass from TestExpectations. + +* platform/chromium/TestExpectations: + 2012-10-31 Takashi Sakamoto ta...@google.com [Refactoring] Move initial style setting for ProgressValueElement from attach method to createShadowSubtree method in HTMLProgressElement. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (133136 => 133137) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-01 08:04:37 UTC (rev 133136) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-01 08:53:47 UTC (rev 133137) @@ -2124,10 +2124,6 @@ # New test, added http://trac.webkit.org/changeset/55546 crbug.com/37896 [ Android Linux Win ] fast/multicol/hit-test-above-or-below.html [ Failure ] -# WebKit roll 56197:56239. -# Needs testRunner.setMediaType() (implemented on Qt only) -crbug.com/38656 fast/media/print-restores-previous-mediatype.html [ Failure ] - # Needs testRunner.setViewModeMediaFeature() crbug.com/40680 fast/media/view-mode-media-feature.html crbug.com/40680 fast/media/media-query-list-02.html @@ -3437,7 +3433,6 @@ # Shadow DOM for replaced elements is not rendered correctly yet. webkit.org/b/90860 fast/dom/shadow/shadowdom-for-object-complex-shadow.html [ ImageOnlyFailure ] -webkit.org/b/90860 fast/dom/shadow/shadowdom-for-object-only-shadow.html [ ImageOnlyFailure ] webkit.org/b/90860 fast/dom/shadow/shadowdom-for-object-without-shadow.html [ ImageOnlyFailure ] webkit.org/b/91487 fast/dom/shadow/shadowdom-for-select-complex-shadow.html [ ImageOnlyFailure ] webkit.org/b/91487 fast/dom/shadow/shadowdom-for-select-without-shadow.html [ ImageOnlyFailure ] @@ -3645,7 +3640,7 @@ webkit.org/b/93799 [ Mac ] fast/dom/HTMLMeterElement/meter-optimums.html [ Failure Pass ] -webkit.org/b/93801 [ Lion ] fast/speech/input-appearance-searchandspeech.html [ ImageOnlyFailure Pass ] +webkit.org/b/93801 [ Mac ] fast/speech/input-appearance-searchandspeech.html [ ImageOnlyFailure Pass ] # Flaky webkit.org/b/93938 [ Debug ] fast/forms/range/slider-delete-while-dragging-thumb.html [ Failure Pass ] @@ -3947,6 +3942,7 @@ crbug.com/150010 platform/chromium/virtual/softwarecompositing/culling/filter-occlusion-blur.html [ ImageOnlyFailure ] crbug.com/150010 platform/chromium/virtual/softwarecompositing/flat-with-transformed-child.html [ ImageOnlyFailure ] crbug.com/150010 platform/chromium/virtual/softwarecompositing/masks [ ImageOnlyFailure ] +crbug.com/150010 platform/chromium/virtual/softwarecompositing/masks/layer-mask-placement.html [ Pass ] crbug.com/150010 platform/chromium/virtual/softwarecompositing/masks/mask-of-clipped-layer.html [ Pass ] crbug.com/150010 platform/chromium/virtual/softwarecompositing/reflections [ ImageOnlyFailure ] crbug.com/150010 platform/chromium/virtual/softwarecompositing/reflections/backface-hidden-reflection.html [ Pass ] @@ -4101,9 +4097,6 @@ Bug(senorblanco) http/tests/security/isolatedWorld/global-variables.html [ Crash Pass ] Bug(senorblanco) http/tests/security/isolatedWorld/body-prototype.html [ Crash Pass ] -# Failing since r133095 (which is CSP-related, not calendar-related?) -Bug(senorblanco) platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html [ Failure ] - # Failing since r133069 (maybe debug-only? Update after more results are in) Bug(senorblanco) editing/pasteboard/file-drag-to-editable.html [ Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133002] trunk/LayoutTests
Title: [133002] trunk/LayoutTests Revision 133002 Author podivi...@chromium.org Date 2012-10-31 02:28:11 -0700 (Wed, 31 Oct 2012) Log Message 2012-10-31 Pavel Podivilov podivi...@google.com [chromium] Unreviewed, mark two touchadjustment tests as failing on mac. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (133001 => 133002) --- trunk/LayoutTests/ChangeLog 2012-10-31 09:10:39 UTC (rev 133001) +++ trunk/LayoutTests/ChangeLog 2012-10-31 09:28:11 UTC (rev 133002) @@ -1,3 +1,9 @@ +2012-10-31 Pavel Podivilov podivi...@google.com + +[chromium] Unreviewed, mark two touchadjustment tests as failing on mac. + +* platform/chromium/TestExpectations: + 2012-10-31 Michał Pakuła vel Rutka m.pak...@samsung.com [EFL][DRT] EventSender requires contextClick implementation Modified: trunk/LayoutTests/platform/chromium/TestExpectations (133001 => 133002) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-31 09:10:39 UTC (rev 133001) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-31 09:28:11 UTC (rev 133002) @@ -4122,3 +4122,6 @@ webkit.org/b/100806 [ Win ] fast/css/font-face-unicode-range.html [ Failure ] webkit.org/b/100806 [ Win ] fast/css/font-face-descending-unicode-range.html [ Text ] webkit.org/b/100806 [ Win ] fast/css/font-face-download-error.html [ Text ] + +webkit.org/b/100833 [ Mac ] touchadjustment/html-label.html [ Text ] +webkit.org/b/100833 [ Mac ] touchadjustment/nested-touch.html [ Text ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133003] trunk/LayoutTests
Title: [133003] trunk/LayoutTests Revision 133003 Author podivi...@chromium.org Date 2012-10-31 02:33:33 -0700 (Wed, 31 Oct 2012) Log Message [chromium] Add new baselines for fast/forms/basic-inputs.html and fast/forms/indeterminate.html on linux. * platform/chromium-linux/fast/forms/indeterminate-expected.png: * platform/efl-wk1/fast/forms/indeterminate-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/indeterminate-expected.png. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-linux/fast/forms/indeterminate-expected.png Added Paths trunk/LayoutTests/platform/efl-wk1/fast/ trunk/LayoutTests/platform/efl-wk1/fast/forms/ trunk/LayoutTests/platform/efl-wk1/fast/forms/indeterminate-expected.png Removed Paths trunk/LayoutTests/platform/efl/fast/forms/indeterminate-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (133002 => 133003) --- trunk/LayoutTests/ChangeLog 2012-10-31 09:28:11 UTC (rev 133002) +++ trunk/LayoutTests/ChangeLog 2012-10-31 09:33:33 UTC (rev 133003) @@ -1,5 +1,12 @@ 2012-10-31 Pavel Podivilov podivi...@google.com +[chromium] Add new baselines for fast/forms/basic-inputs.html and fast/forms/indeterminate.html on linux. + +* platform/chromium-linux/fast/forms/indeterminate-expected.png: +* platform/efl-wk1/fast/forms/indeterminate-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/indeterminate-expected.png. + +2012-10-31 Pavel Podivilov podivi...@google.com + [chromium] Unreviewed, mark two touchadjustment tests as failing on mac. * platform/chromium/TestExpectations: Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/indeterminate-expected.png (Binary files differ) Deleted: trunk/LayoutTests/platform/efl/fast/forms/indeterminate-expected.png (Binary files differ) Copied: trunk/LayoutTests/platform/efl-wk1/fast/forms/indeterminate-expected.png (from rev 133002, trunk/LayoutTests/platform/efl/fast/forms/indeterminate-expected.png) (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133028] trunk/Source
Title: [133028] trunk/Source Revision 133028 Author podivi...@chromium.org Date 2012-10-31 07:59:59 -0700 (Wed, 31 Oct 2012) Log Message Unreviewed, rolling out r133016. http://trac.webkit.org/changeset/133016 https://bugs.webkit.org/show_bug.cgi?id=100856 broke compile-webkit on several bots (Requested by podivilov on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2012-10-31 Source/WebCore: * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * dom/DeviceOrientationClient.h: (DeviceOrientationClient): * dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::DeviceOrientationController): (WebCore): (WebCore::DeviceOrientationController::~DeviceOrientationController): (WebCore::DeviceOrientationController::timerFired): (WebCore::DeviceOrientationController::addListener): (WebCore::DeviceOrientationController::removeListener): (WebCore::DeviceOrientationController::removeAllListeners): (WebCore::DeviceOrientationController::suspendEventsForAllListeners): (WebCore::DeviceOrientationController::resumeEventsForAllListeners): (WebCore::DeviceOrientationController::didChangeDeviceOrientation): (WebCore::DeviceOrientationController::supplementName): * dom/DeviceOrientationController.h: (WebCore): (DeviceOrientationController): (WebCore::DeviceOrientationController::isActive): (WebCore::DeviceOrientationController::client): (WebCore::DeviceOrientationController::from): * dom/Document.cpp: (WebCore::Document::suspendActiveDOMObjects): (WebCore::Document::resumeActiveDOMObjects): * loader/EmptyClients.h: (WebCore::EmptyDeviceOrientationClient::startUpdating): (WebCore::EmptyDeviceOrientationClient::stopUpdating): * page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners): * page/DeviceClient.h: Removed. * page/DeviceController.cpp: Removed. * page/DeviceController.h: Removed. Source/WebKit/qt: * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setMockDeviceOrientation): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/DeviceOrientationClient.h trunk/Source/WebCore/dom/DeviceOrientationController.cpp trunk/Source/WebCore/dom/DeviceOrientationController.h trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/loader/EmptyClients.h trunk/Source/WebCore/page/DOMWindow.cpp trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp Removed Paths trunk/Source/WebCore/page/DeviceClient.h trunk/Source/WebCore/page/DeviceController.cpp trunk/Source/WebCore/page/DeviceController.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (133027 => 133028) --- trunk/Source/WebCore/CMakeLists.txt 2012-10-31 14:22:49 UTC (rev 133027) +++ trunk/Source/WebCore/CMakeLists.txt 2012-10-31 14:59:59 UTC (rev 133028) @@ -1710,7 +1710,6 @@ page/ContentSecurityPolicy.cpp page/ContextMenuController.cpp page/Crypto.cpp -page/DeviceController.cpp page/DiagnosticLoggingKeys.cpp page/DOMSecurityPolicy.cpp page/DOMSelection.cpp Modified: trunk/Source/WebCore/ChangeLog (133027 => 133028) --- trunk/Source/WebCore/ChangeLog 2012-10-31 14:22:49 UTC (rev 133027) +++ trunk/Source/WebCore/ChangeLog 2012-10-31 14:59:59 UTC (rev 133028) @@ -1,3 +1,52 @@ +2012-10-31 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r133016. +http://trac.webkit.org/changeset/133016 +https://bugs.webkit.org/show_bug.cgi?id=100856 + +broke compile-webkit on several bots (Requested by podivilov +on #webkit). + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* dom/DeviceOrientationClient.h: +(DeviceOrientationClient): +* dom/DeviceOrientationController.cpp: +(WebCore::DeviceOrientationController::DeviceOrientationController): +(WebCore): +(WebCore::DeviceOrientationController::~DeviceOrientationController): +(WebCore::DeviceOrientationController::timerFired): +(WebCore::DeviceOrientationController::addListener): +(WebCore::DeviceOrientationController::removeListener): +(WebCore::DeviceOrientationController::removeAllListeners): +(WebCore::DeviceOrientationController::suspendEventsForAllListeners): +(WebCore::DeviceOrientationController::resumeEventsForAllListeners): +(WebCore::DeviceOrientationController::didChangeDeviceOrientation): +(W
[webkit-changes] [132779] trunk/LayoutTests
Title: [132779] trunk/LayoutTests Revision 132779 Author podivi...@chromium.org Date 2012-10-29 03:07:16 -0700 (Mon, 29 Oct 2012) Log Message 2012-10-29 Pavel Podivilov podivi...@google.com [Chromium] Test expectation update. Unreviewed, mark recently added audiobuffersource-loop-points.html test as failing on windows. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (132778 => 132779) --- trunk/LayoutTests/ChangeLog 2012-10-29 09:44:33 UTC (rev 132778) +++ trunk/LayoutTests/ChangeLog 2012-10-29 10:07:16 UTC (rev 132779) @@ -1,3 +1,11 @@ +2012-10-29 Pavel Podivilov podivi...@google.com + +[Chromium] Test expectation update. + +Unreviewed, mark recently added audiobuffersource-loop-points.html test as failing on windows. + +* platform/chromium/TestExpectations: + 2012-10-29 Kent Tamura tk...@chromium.org [Chromium] Test expectation update. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132778 => 132779) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-29 09:44:33 UTC (rev 132778) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-10-29 10:07:16 UTC (rev 132779) @@ -4072,3 +4072,4 @@ webkit.org/b/100475 platform/chromium/virtual/softwarecompositing/tiling/tile-cache-zoomed.html [ Failure ] webkit.org/b/100477 [ Win ] platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html [ Failure ] +webkit.org/b/100647 [ Win ] webaudio/audiobuffersource-loop-points.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128061] trunk
Title: [128061] trunk Revision 128061 Author podivi...@chromium.org Date 2012-09-10 07:50:39 -0700 (Mon, 10 Sep 2012) Log Message Web Inspector: support empty entries in source maps. https://bugs.webkit.org/show_bug.cgi?id=96088 Reviewed by Vsevolod Vlasov. Empty entries should be mapped to the compiled script. Source/WebCore: * inspector/front-end/CompilerScriptMapping.js: (WebInspector.CompilerScriptMapping): (WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation): (WebInspector.CompilerScriptMapping.prototype._reset): (WebInspector.SourceMapParser.prototype._parseMap): LayoutTests: * http/tests/inspector/compiler-script-mapping.html: * http/tests/inspector/resources/source-map.json: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html trunk/LayoutTests/http/tests/inspector/resources/source-map.json trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js Diff Modified: trunk/LayoutTests/ChangeLog (128060 => 128061) --- trunk/LayoutTests/ChangeLog 2012-09-10 14:38:00 UTC (rev 128060) +++ trunk/LayoutTests/ChangeLog 2012-09-10 14:50:39 UTC (rev 128061) @@ -1,3 +1,15 @@ +2012-09-10 Pavel Podivilov podivi...@chromium.org + +Web Inspector: support empty entries in source maps. +https://bugs.webkit.org/show_bug.cgi?id=96088 + +Reviewed by Vsevolod Vlasov. + +Empty entries should be mapped to the compiled script. + +* http/tests/inspector/compiler-script-mapping.html: +* http/tests/inspector/resources/source-map.json: + 2012-09-10 Dan Bernstein m...@apple.com REGRESSION (r128006): Three spatial navigation tests are failing Modified: trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html (128060 => 128061) --- trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html 2012-09-10 14:38:00 UTC (rev 128060) +++ trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html 2012-09-10 14:50:39 UTC (rev 128061) @@ -71,6 +71,8 @@ }; var mapping = new WebInspector.SourceMapParser(source-map.json, mappingPayload); checkMapping(0, 0, example.js, 0, 0, mapping); +var entry = mapping.findEntry(0, 1); +InspectorTest.assertEquals(2, entry.length); checkMapping(0, 2, example.js, 0, 2, mapping); next(); }, @@ -131,25 +133,25 @@ script.sourceMapURL = http://localhost:8000/inspector/resources/source-map.json; mapping.addScript(script); -var uiSourceCodeList = mapping.uiSourceCodes(); -InspectorTest.assertEquals(2, uiSourceCodeList.length); -InspectorTest.assertEquals(http://localhost:8000/inspector/resources/source1.js, uiSourceCodeList[0].url); -InspectorTest.assertEquals(http://localhost:8000/inspector/resources/source2.js, uiSourceCodeList[1].url); +var uiSourceCode1 = mapping._uiSourceCodeByURL[http://localhost:8000/inspector/resources/source1.js]; +var uiSourceCode2 = mapping._uiSourceCodeByURL[http://localhost:8000/inspector/resources/source2.js]; +var originalUISourceCode = mapping._originalUISourceCodeForScriptId[script.scriptId]; -InspectorTest.checkUILocation(uiSourceCodeList[0], 4, 4, mapping.rawLocationToUILocation(WebInspector.debuggerModel.createRawLocation(script, 0, 81))); -InspectorTest.checkUILocation(uiSourceCodeList[0], 5, 4, mapping.rawLocationToUILocation(WebInspector.debuggerModel.createRawLocation(script, 0, 93))); -InspectorTest.checkUILocation(uiSourceCodeList[1], 7, 4, mapping.rawLocationToUILocation(WebInspector.debuggerModel.createRawLocation(script, 1, 151))); +InspectorTest.checkUILocation(uiSourceCode1, 4, 4, mapping.rawLocationToUILocation(WebInspector.debuggerModel.createRawLocation(script, 0, 81))); +InspectorTest.checkUILocation(uiSourceCode1, 5, 4, mapping.rawLocationToUILocation(WebInspector.debuggerModel.createRawLocation(script, 0, 93))); +InspectorTest.checkUILocation(uiSourceCode2, 7, 4, mapping.rawLocationToUILocation(WebInspector.debuggerModel.createRawLocation(script, 1, 151))); +InspectorTest.checkUILocation(originalUISourceCode, 1, 200, mapping.rawLocationToUILocation(WebInspector.debuggerModel.createRawLocation(script, 1, 200))); -InspectorTest.checkRawLocation(script, 0, 42, mapping.uiLocationToRawLocation(uiSourceCodeList[0], 3, 10)); -InspectorTest.checkRawLocation(script, 1, 85, mapping.uiLocationToRawLocation(uiSourceCodeList[1], 0, 0)); -InspectorTest.checkRawLocation(script, 1, 110, mapping.uiLocationToRawLocation(uiSourceCodeList[1], 5, 2)); +InspectorTest.checkRawLocation(script, 0, 42, mapping.uiLocationToRawLocation(uiSourceCode1, 3, 10)); +InspectorTest.checkRawLocation(script,
[webkit-changes] [112841] trunk
Title: [112841] trunk
Revision 112841
Author podivi...@chromium.org
Date 2012-04-02 02:29:24 -0700 (Mon, 02 Apr 2012)
Log Message
Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=82768
Reviewed by Yury Semikhatsky.
Source/WebCore:
When UISourceCode is replaced with another in ScriptsPanel, newly added
UISourceCode could already have breakpoints. We should iterate over existing
breakpoints and add them to sidebar pane.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
LayoutTests:
* inspector/debugger/script-formatter-breakpoints-expected.txt:
* inspector/debugger/script-formatter-breakpoints.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints-expected.txt
trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (112840 => 112841)
--- trunk/LayoutTests/ChangeLog 2012-04-02 09:18:01 UTC (rev 112840)
+++ trunk/LayoutTests/ChangeLog 2012-04-02 09:29:24 UTC (rev 112841)
@@ -1,3 +1,13 @@
+2012-04-02 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-print mode.
+https://bugs.webkit.org/show_bug.cgi?id=82768
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/script-formatter-breakpoints-expected.txt:
+* inspector/debugger/script-formatter-breakpoints.html:
+
2012-04-02 Kent Tamura tk...@chromium.org
Add a calendar picker indicator to date-type input fields
Modified: trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints-expected.txt (112840 => 112841)
--- trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints-expected.txt 2012-04-02 09:18:01 UTC (rev 112840)
+++ trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints-expected.txt 2012-04-02 09:29:24 UTC (rev 112841)
@@ -4,12 +4,30 @@
Running: testBreakpointsInOriginalAndFormattedSource
Script execution paused.
+
+Dump breakpoint sidebar pane:
+
+script-formatter-breakpoints.html:11
+var f=0;
Script execution resumed.
Page reloaded.
Navigated to test-navigation.html
Page reloaded.
Navigated back to test page.
+
+Dump breakpoint sidebar pane:
+
Script execution paused.
+
+Dump breakpoint sidebar pane:
+
+script-formatter-breakpoints.html:25
+return 0;
Script execution resumed.
+
+Dump breakpoint sidebar pane:
+
+script-formatter-breakpoints.html:11
+var f=0;
Debugger was disabled.
Modified: trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints.html (112840 => 112841)
--- trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints.html 2012-04-02 09:18:01 UTC (rev 112840)
+++ trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints.html 2012-04-02 09:29:24 UTC (rev 112841)
@@ -39,6 +39,7 @@
function pausedInF1(callFrames)
{
InspectorTest.assertEquals(f1, callFrames[0].functionName);
+dumpBreakpointSidebarPane();
InspectorTest.resumeExecution(resumed);
}
@@ -62,6 +63,7 @@
function didNavigateBack()
{
InspectorTest.addResult(Navigated back to test page.);
+dumpBreakpointSidebarPane();
InspectorTest.showScriptSource(script-formatter-breakpoints.html, didShowFormattedScriptSource);
}
@@ -77,11 +79,26 @@
function pausedInF2(callFrames)
{
InspectorTest.assertEquals(f2, callFrames[0].functionName);
+dumpBreakpointSidebarPane();
panel._toggleFormatSource();
-InspectorTest.resumeExecution(next);
+InspectorTest.resumeExecution(resumedF2);
}
+
+function resumedF2()
+{
+dumpBreakpointSidebarPane();
+next();
+}
}
]);
+
+function dumpBreakpointSidebarPane()
+{
+var paneElement = WebInspector.panels.scripts.sidebarPanes.jsBreakpoints.listElement
+InspectorTest.addResult();
+InspectorTest.addResult(Dump breakpoint sidebar pane:);
+InspectorTest.addResult(InspectorTest.textContentWithLineBreaks(paneElement));
+}
}
/script
Modified: trunk/Source/WebCore/ChangeLog (112840 => 112841)
--- trunk/Source/WebCore/ChangeLog 2012-04-02 09:18:01 UTC (rev 112840)
+++ trunk/Source/WebCore/ChangeLog 2012-04-02 09:29:24 UTC (rev 112841)
@@ -1,3 +1,17 @@
+2012-04-02 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-print mode.
+https://bugs.webkit.org/show_bug.cgi?id=82768
+
+
[webkit-changes] [112875] trunk
Title: [112875] trunk Revision 112875 Author podivi...@chromium.org Date 2012-04-02 06:55:50 -0700 (Mon, 02 Apr 2012) Log Message Web Inspector: refactor UI breakpoint listeners. https://bugs.webkit.org/show_bug.cgi?id=82481 Reviewed by Vsevolod Vlasov. Source/WebCore: Breakpoint-added and breakpoint-removed events are currently dispatched on UISourceCode. That allows us to move handlers that manage SourceFrame's breakpoint decorations from ScriptsPanel to SourceFrame. SourceFrame's Loaded event is removed as it was only used by ScriptsPanel to restore SourceFrame's breakpoints. * inspector/front-end/DebuggerPresentationModel.js: * inspector/front-end/_javascript_SourceFrame.js: (WebInspector._javascript_SourceFrame): (WebInspector._javascript_SourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition): (WebInspector._javascript_SourceFrame.prototype.populateLineGutterContextMenu.): (WebInspector._javascript_SourceFrame.prototype.beforeTextChanged): (WebInspector._javascript_SourceFrame.prototype.didEditContent): (WebInspector._javascript_SourceFrame.prototype._addBreakpointDecoration): (WebInspector._javascript_SourceFrame.prototype._removeBreakpointDecoration): (WebInspector._javascript_SourceFrame.prototype._breakpointAdded): (WebInspector._javascript_SourceFrame.prototype._breakpointRemoved): (WebInspector._javascript_SourceFrame.prototype.onTextViewerContentLoaded): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded): (WebInspector.ScriptsPanel.prototype._uiBreakpointAdded): (WebInspector.ScriptsPanel.prototype._uiBreakpointRemoved): (WebInspector.ScriptsPanel.prototype._createSourceFrame): * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype.onTextViewerContentLoaded): LayoutTests: * http/tests/inspector/debugger-test.js: (initialize_DebuggerTest): * http/tests/inspector/resources-test.js: (initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit): (initialize_ResourceTest.InspectorTest.showResource.showResourceCallback): (initialize_ResourceTest.InspectorTest.showResource): (initialize_ResourceTest): * inspector/debugger/live-edit.html: * inspector/debugger/set-breakpoint.html: * inspector/debugger/source-frame.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/debugger-test.js trunk/LayoutTests/http/tests/inspector/resources-test.js trunk/LayoutTests/inspector/debugger/live-edit.html trunk/LayoutTests/inspector/debugger/set-breakpoint.html trunk/LayoutTests/inspector/debugger/source-frame.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/BreakpointManager.js trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js trunk/Source/WebCore/inspector/front-end/SourceFrame.js Diff Modified: trunk/LayoutTests/ChangeLog (112874 => 112875) --- trunk/LayoutTests/ChangeLog 2012-04-02 13:44:48 UTC (rev 112874) +++ trunk/LayoutTests/ChangeLog 2012-04-02 13:55:50 UTC (rev 112875) @@ -1,3 +1,21 @@ +2012-03-28 Pavel Podivilov podivi...@chromium.org + +Web Inspector: refactor UI breakpoint listeners. +https://bugs.webkit.org/show_bug.cgi?id=82481 + +Reviewed by Vsevolod Vlasov. + +* http/tests/inspector/debugger-test.js: +(initialize_DebuggerTest): +* http/tests/inspector/resources-test.js: +(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit): +(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback): +(initialize_ResourceTest.InspectorTest.showResource): +(initialize_ResourceTest): +* inspector/debugger/live-edit.html: +* inspector/debugger/set-breakpoint.html: +* inspector/debugger/source-frame.html: + 2012-04-02 János Badics jbad...@inf.u-szeged.hu [Qt] Unreviewed gardening. Modified: trunk/LayoutTests/http/tests/inspector/debugger-test.js (112874 => 112875) --- trunk/LayoutTests/http/tests/inspector/debugger-test.js 2012-04-02 13:44:48 UTC (rev 112874) +++ trunk/LayoutTests/http/tests/inspector/debugger-test.js 2012-04-02 13:55:50 UTC (rev 112875) @@ -163,7 +163,7 @@ if (sourceFrame.loaded) callback(sourceFrame); else -sourceFrame.addEventListener(WebInspector.SourceFrame.Events.Loaded, callback.bind(null, sourceFrame)); +InspectorTest.addSniffer(sourceFrame, onTextViewerContentLoaded, callback.bind(null, sourceFrame)); return; } } Modified: trunk/LayoutTests/http/tests/inspector/resources-test.js (112874 => 112875) --- trunk/LayoutTests/http/tests/inspector/resources-test.js 2012-04-02 13:44:48 UTC (rev 112874) +++ trunk/LayoutTests/h
[webkit-changes] [112379] trunk
Title: [112379] trunk
Revision 112379
Author podivi...@chromium.org
Date 2012-03-28 02:58:07 -0700 (Wed, 28 Mar 2012)
Log Message
Web Inspector: breakpoints are not shown in sidebar pane after reload.
https://bugs.webkit.org/show_bug.cgi?id=82351
Reviewed by Pavel Feldman.
Source/WebCore:
When UISourceCode is added to ScriptsPanel, it could already have breakpoints.
We should iterate over existing breakpoints and add them to sidebar pane.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
LayoutTests:
* inspector/debugger/set-breakpoint-expected.txt:
* inspector/debugger/set-breakpoint.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/set-breakpoint-expected.txt
trunk/LayoutTests/inspector/debugger/set-breakpoint.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (112378 => 112379)
--- trunk/LayoutTests/ChangeLog 2012-03-28 09:56:36 UTC (rev 112378)
+++ trunk/LayoutTests/ChangeLog 2012-03-28 09:58:07 UTC (rev 112379)
@@ -1,3 +1,13 @@
+2012-03-28 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: breakpoints are not shown in sidebar pane after reload.
+https://bugs.webkit.org/show_bug.cgi?id=82351
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/set-breakpoint-expected.txt:
+* inspector/debugger/set-breakpoint.html:
+
2012-03-28 Kristóf Kosztyó kkris...@inf.u-szeged.hu
[Qt] REGRESSION(r111480): It made svg/as-image tests assert
Modified: trunk/LayoutTests/inspector/debugger/set-breakpoint-expected.txt (112378 => 112379)
--- trunk/LayoutTests/inspector/debugger/set-breakpoint-expected.txt 2012-03-28 09:56:36 UTC (rev 112378)
+++ trunk/LayoutTests/inspector/debugger/set-breakpoint-expected.txt 2012-03-28 09:58:07 UTC (rev 112379)
@@ -8,6 +8,14 @@
Script execution paused.
Call stack:
0) testFunction (set-breakpoint.html:17)
+
+Dump breakpoint sidebar pane:
+
+set-breakpoint.html:17
+var x = Math.sqrt(10);
+
+Dump breakpoint sidebar pane:
+
Script execution resumed.
Running: testSetBreakpointOnTheLastLine
Modified: trunk/LayoutTests/inspector/debugger/set-breakpoint.html (112378 => 112379)
--- trunk/LayoutTests/inspector/debugger/set-breakpoint.html 2012-03-28 09:56:36 UTC (rev 112378)
+++ trunk/LayoutTests/inspector/debugger/set-breakpoint.html 2012-03-28 09:58:07 UTC (rev 112379)
@@ -39,6 +39,7 @@
{
InspectorTest.addResult(Script execution paused.);
InspectorTest.captureStackTrace(callFrames);
+dumpBreakpointSidebarPane()
InspectorTest.addSniffer(currentSourceFrame, removeBreakpoint, breakpointRemoved);
InspectorTest.removeBreakpoint(currentSourceFrame, 16);
}
@@ -50,6 +51,7 @@
function didResume()
{
+dumpBreakpointSidebarPane()
InspectorTest.addResult(Script execution resumed.);
next();
}
@@ -114,6 +116,14 @@
}
}
]);
+
+function dumpBreakpointSidebarPane()
+{
+var paneElement = WebInspector.panels.scripts.sidebarPanes.jsBreakpoints.listElement
+InspectorTest.addResult();
+InspectorTest.addResult(Dump breakpoint sidebar pane:);
+InspectorTest.addResult(InspectorTest.textContentWithLineBreaks(paneElement));
+}
}
/script
Modified: trunk/Source/WebCore/ChangeLog (112378 => 112379)
--- trunk/Source/WebCore/ChangeLog 2012-03-28 09:56:36 UTC (rev 112378)
+++ trunk/Source/WebCore/ChangeLog 2012-03-28 09:58:07 UTC (rev 112379)
@@ -1,3 +1,16 @@
+2012-03-28 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: breakpoints are not shown in sidebar pane after reload.
+https://bugs.webkit.org/show_bug.cgi?id=82351
+
+Reviewed by Pavel Feldman.
+
+When UISourceCode is added to ScriptsPanel, it could already have breakpoints.
+We should iterate over existing breakpoints and add them to sidebar pane.
+
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
+
2012-03-28 Li Yin li@intel.com
[WebSocket]The Sec-WebSocket-Protocol must not appear more than once in an HTTP response
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (112378 => 112379)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-03-28 09:56:36 UTC (rev 112378)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-03-28 09:58:07 UTC (rev 112379)
@@ -256,6 +256,10 @@
_uiSourceCodeAdded: function(event)
{
var uiSourceCode = /** @type {WebInspector.UISourceCode} */ event.data;
+
+var breakpoints = uiSourceCode.breakpoints();
+for (var lineNumber in breakpoints)
+this._uiBreakpo
[webkit-changes] [112402] trunk
Title: [112402] trunk
Revision 112402
Author podivi...@chromium.org
Date 2012-03-28 08:20:06 -0700 (Wed, 28 Mar 2012)
Log Message
Web Inspector: dispatch console-message-added and console-messages-cleared events on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82463
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Those events are related to specific UISourceCode. See bug 82224 for more details.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.UISourceCodeImpl):
(WebInspector.UISourceCodeImpl.prototype.consoleMessages):
(WebInspector.UISourceCodeImpl.prototype.consoleMessageAdded):
(WebInspector.UISourceCodeImpl.prototype.consoleMessagesCleared):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame):
(WebInspector._javascript_SourceFrame.prototype.beforeTextChanged):
(WebInspector._javascript_SourceFrame.prototype._consoleMessageAdded):
(WebInspector._javascript_SourceFrame.prototype._consoleMessagesCleared):
(WebInspector._javascript_SourceFrame.prototype._onTextViewerContentLoaded):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.breakpoints):
(WebInspector.UISourceCode.prototype.consoleMessages):
LayoutTests:
* inspector/debugger/scripts-panel.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/scripts-panel.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (112401 => 112402)
--- trunk/LayoutTests/ChangeLog 2012-03-28 15:13:51 UTC (rev 112401)
+++ trunk/LayoutTests/ChangeLog 2012-03-28 15:20:06 UTC (rev 112402)
@@ -1,3 +1,12 @@
+2012-03-28 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: dispatch console-message-added and console-messages-cleared events on UISourceCode.
+https://bugs.webkit.org/show_bug.cgi?id=82463
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/debugger/scripts-panel.html:
+
2012-03-28 Yi Shen yi.4.s...@nokia.com
An extra line break is inserted when pasting into a font element.
Modified: trunk/LayoutTests/inspector/debugger/scripts-panel.html (112401 => 112402)
--- trunk/LayoutTests/inspector/debugger/scripts-panel.html 2012-03-28 15:13:51 UTC (rev 112401)
+++ trunk/LayoutTests/inspector/debugger/scripts-panel.html 2012-03-28 15:20:06 UTC (rev 112402)
@@ -23,7 +23,7 @@
}
function createUISouceCode(url)
{
-var uiSourceCode = new WebInspector.UISourceCode(0, url, null, null);
+var uiSourceCode = new WebInspector.UISourceCodeImpl(0, url, null, null);
uiSourceCode.requestContent = function(callback)
{
InspectorTest.addResult(Source requested for + url);
Modified: trunk/Source/WebCore/ChangeLog (112401 => 112402)
--- trunk/Source/WebCore/ChangeLog 2012-03-28 15:13:51 UTC (rev 112401)
+++ trunk/Source/WebCore/ChangeLog 2012-03-28 15:20:06 UTC (rev 112402)
@@ -1,3 +1,33 @@
+2012-03-28 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: dispatch console-message-added and console-messages-cleared events on UISourceCode.
+https://bugs.webkit.org/show_bug.cgi?id=82463
+
+Reviewed by Vsevolod Vlasov.
+
+Those events are related to specific UISourceCode. See bug 82224 for more details.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel):
+(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
+(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
+(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
+(WebInspector.UISourceCodeImpl):
+(WebInspector.UISourceCodeImpl.prototype.consoleMessages):
+(WebInspector.UISourceCodeImpl.prototype.consoleMessageAdded):
+(WebInspector.UISourceCodeImpl.prototype.consoleMessagesCleared):
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame):
+(WebInspector._javascript_SourceFrame.prototype.beforeTextChanged):
+(WebInspector._javascript_SourceFrame.prototype._consoleMessageAdded):
+(WebInspector._javascript_SourceFrame.prototype._consoleMessagesCleared):
+(WebInspector._javascript_SourceFrame.prototype._onTextViewerContentLoaded):
+* inspector/front-end/Script
[webkit-changes] [112236] trunk
Title: [112236] trunk
Revision 112236
Author podivi...@chromium.org
Date 2012-03-27 02:55:18 -0700 (Tue, 27 Mar 2012)
Log Message
Web Inspector: store UIBreakpoints on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82214
Source/WebCore:
This change will allow us to make breakpoint-added and breakpoint-removed events a part of UISourceCode interface.
See bug 82224 for more details.
Reviewed by Vsevolod Vlasov.
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeRemoved):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):
(WebInspector.BreakpointManager.prototype.debuggerReset):
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.addScript):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.UISourceCodeImpl):
(WebInspector.UISourceCodeImpl.prototype.breakpoints):
(WebInspector.UISourceCodeImpl.prototype.breakpointAdded):
(WebInspector.UISourceCodeImpl.prototype.breakpointRemoved):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.get domain):
(WebInspector.UISourceCode.prototype.get folderName):
(WebInspector.UISourceCode.prototype.get fileName):
(WebInspector.UISourceCode.prototype.get displayName):
(WebInspector.UISourceCode.prototype._parseURL):
(WebInspector.UISourceCode.prototype._didRequestContent):
(WebInspector.UISourceCode.prototype.breakpoints):
* inspector/front-end/inspector.html:
LayoutTests:
Reviewed by Vsevolod Vlasov.
* inspector/debugger/breakpoint-manager.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/breakpoint-manager.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/BreakpointManager.js
trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/SnippetsModel.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
trunk/Source/WebCore/inspector/front-end/inspector.html
Diff
Modified: trunk/LayoutTests/ChangeLog (112235 => 112236)
--- trunk/LayoutTests/ChangeLog 2012-03-27 09:48:21 UTC (rev 112235)
+++ trunk/LayoutTests/ChangeLog 2012-03-27 09:55:18 UTC (rev 112236)
@@ -1,3 +1,12 @@
+2012-03-26 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: store UIBreakpoints on UISourceCode.
+https://bugs.webkit.org/show_bug.cgi?id=82214
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/debugger/breakpoint-manager.html:
+
2012-03-27 Szilard Ledan szle...@inf.u-szeged.hu
[Qt] Unskipped 5 passing tests.
Modified: trunk/LayoutTests/inspector/debugger/breakpoint-manager.html (112235 => 112236)
--- trunk/LayoutTests/inspector/debugger/breakpoint-manager.html 2012-03-27 09:48:21 UTC (rev 112235)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-manager.html 2012-03-27 09:55:18 UTC (rev 112236)
@@ -58,7 +58,7 @@
serializedBreakpoints.push(createBreakpoint(a.js, 20, , false));
serializedBreakpoints.push(createBreakpoint(b.js, 3, , true));
-function createUISourceCode(id, url) { return { id: id, url: url }; }
+function createUISourceCode(id, url) { return new WebInspector.UISourceCodeImpl(id, url, null); }
var uiSourceCodeA = createUISourceCode(a.js, a.js);
var uiSourceCodeB = createUISourceCode(b.js, b.js);
Modified: trunk/Source/WebCore/ChangeLog (112235 => 112236)
--- trunk/Source/WebCore/ChangeLog 2012-03-27 09:48:21 UTC (rev 112235)
+++ trunk/Source/WebCore/ChangeLog 2012-03-27 09:55:18 UTC (rev 112236)
@@ -1,3 +1,45 @@
+2012-03-26 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: store UIBreakpoints on UISourceCode.
+https://bugs.webkit.org/show_bug.cgi?id=82214
+
+This change will allow us to make breakpoint-added and breakpoint-removed events a part of UISourceCode interface.
+See bug 82224 for more details.
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/BreakpointManager.js:
+(WebInspector.BreakpointManager.prototype.uiSourceCodeRemoved):
+(WebInspector.BreakpointManager.prototype.setB
[webkit-changes] [112266] trunk
Title: [112266] trunk
Revision 112266
Author podivi...@chromium.org
Date 2012-03-27 07:43:46 -0700 (Tue, 27 Mar 2012)
Log Message
Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82318
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Breakpoint-added and breakpoint-removed events are always related to specific UISourceCode.
See bug 82224 for more details.
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.UISourceCodeImpl.prototype.breakpointAdded):
(WebInspector.UISourceCodeImpl.prototype.breakpointRemoved):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._addBreakpointListeners):
(WebInspector.ScriptsPanel.prototype._removeBreakpointListeners):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
* inspector/front-end/UISourceCode.js:
LayoutTests:
* inspector/debugger/breakpoint-manager.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/breakpoint-manager.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/BreakpointManager.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (112265 => 112266)
--- trunk/LayoutTests/ChangeLog 2012-03-27 14:42:47 UTC (rev 112265)
+++ trunk/LayoutTests/ChangeLog 2012-03-27 14:43:46 UTC (rev 112266)
@@ -1,3 +1,12 @@
+2012-03-27 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.
+https://bugs.webkit.org/show_bug.cgi?id=82318
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/debugger/breakpoint-manager.html:
+
2012-03-27 Alexei Filippov alex...@chromium.org
Web Inspector: Fix missing objects in the dominators view.
Modified: trunk/LayoutTests/inspector/debugger/breakpoint-manager.html (112265 => 112266)
--- trunk/LayoutTests/inspector/debugger/breakpoint-manager.html 2012-03-27 14:42:47 UTC (rev 112265)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-manager.html 2012-03-27 14:43:46 UTC (rev 112266)
@@ -13,15 +13,17 @@
};
var uiBreakpoints = {};
-function breakpointAdded(breakpoint)
+function breakpointAdded(event)
{
+var breakpoint = event.data;
InspectorTest.addResult(breakpointAdded( + [breakpoint.uiSourceCode.id, breakpoint.lineNumber, breakpoint.condition, breakpoint.enabled].join(, ) + ));
var breakpointId = breakpoint.uiSourceCode.id + : + breakpoint.lineNumber;
InspectorTest.assertTrue(!(breakpointId in uiBreakpoints));
uiBreakpoints[breakpointId] = breakpoint.condition + | + breakpoint.enabled;
}
-function breakpointRemoved(breakpoint)
+function breakpointRemoved(event)
{
+var breakpoint = event.data;
InspectorTest.addResult(breakpointRemoved( + [breakpoint.uiSourceCode.id, breakpoint.lineNumber].join(, ) + ));
var breakpointId = breakpoint.uiSourceCode.id + : + breakpoint.lineNumber;
InspectorTest.assertTrue(breakpointId in uiBreakpoints);
@@ -59,15 +61,12 @@
serializedBreakpoints.push(createBreakpoint(b.js, 3, , true));
function createUISourceCode(id, url) { return new WebInspector.UISourceCodeImpl(id, url, null); }
-var uiSourceCodeA = createUISourceCode(a.js, a.js);
-var uiSourceCodeB = createUISourceCode(b.js, b.js);
var scriptMapping = {};
scriptMapping.rawLocationToUILocation = function(rawLocation) { return rawLocation; };
scriptMapping.uiLocationToRawLocation = function(uiSourceCode, lineNumber)
{
-scriptId = uiSourceCode === uiSourceCodeA ? a.js : b.js;
-return { scriptId: scriptId, lineNumber: lineNumber, columnNumber: 0 };
+return { scriptId: uiSourceCode.id, lineNumber: lineNumber, columnNumber: 0 };
}
function createBreakpointManager(breakpoints, scriptMapping)
@@ -76,15 +75,22 @@
uiBreakpoints = {};
debuggerBreakpoints = {};
debuggerModel.removeAllListeners();
-return new WebInspector.BreakpointManager(breakpointStorage, breakpointAdded, breakpointRemoved, debuggerModel, scriptMapping);
+return new WebInspector.BreakpointManager(breakpointStorage, debuggerModel, scriptMapping);
}
+function addUISourceCode(breakpointManager, uiSourceCode)
+{
+uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.BreakpointAdded, breakpoin
[webkit-changes] [112274] trunk/LayoutTests
Title: [112274] trunk/LayoutTests
Revision 112274
Author podivi...@chromium.org
Date 2012-03-27 08:41:04 -0700 (Tue, 27 Mar 2012)
Log Message
Web Inspector: testSourceMapCouldNotBeLoaded logs different error messages on different platforms.
https://bugs.webkit.org/show_bug.cgi?id=82314
Reviewed by Vsevolod Vlasov.
* http/tests/inspector/compiler-script-mapping.html:
* platform/gtk/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html
trunk/LayoutTests/platform/gtk/Skipped
Diff
Modified: trunk/LayoutTests/ChangeLog (112273 => 112274)
--- trunk/LayoutTests/ChangeLog 2012-03-27 15:22:56 UTC (rev 112273)
+++ trunk/LayoutTests/ChangeLog 2012-03-27 15:41:04 UTC (rev 112274)
@@ -1,3 +1,13 @@
+2012-03-27 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: testSourceMapCouldNotBeLoaded logs different error messages on different platforms.
+https://bugs.webkit.org/show_bug.cgi?id=82314
+
+Reviewed by Vsevolod Vlasov.
+
+* http/tests/inspector/compiler-script-mapping.html:
+* platform/gtk/Skipped:
+
2012-03-27 Yury Semikhatsky yu...@chromium.org
Web Inspector: simplify heap profiler front-end
Modified: trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html (112273 => 112274)
--- trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html 2012-03-27 15:22:56 UTC (rev 112273)
+++ trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html 2012-03-27 15:41:04 UTC (rev 112274)
@@ -190,12 +190,14 @@
function testSourceMapCouldNotBeLoaded(next)
{
+WebInspector.settings.sourceMapsEnabled.set(true);
WebInspector.debuggerModel._scripts = [];
var mainScriptMapping = new WebInspector.MainScriptMapping();
mainScriptMapping.addEventListener(WebInspector.MainScriptMapping.Events.UISourceCodeListChanged, uiSourceCodeListChanged);
var script = InspectorTest.createScriptMock(compiled.js, 0, 0, true, );
script.sourceMapURL = http://localhost:8000/inspector/resources/source-map.json_;
+console.error = function() {}; // Error message is platform dependent.
mainScriptMapping.addScript(script);
function uiSourceCodeListChanged(event)
Modified: trunk/LayoutTests/platform/gtk/Skipped (112273 => 112274)
--- trunk/LayoutTests/platform/gtk/Skipped 2012-03-27 15:22:56 UTC (rev 112273)
+++ trunk/LayoutTests/platform/gtk/Skipped 2012-03-27 15:41:04 UTC (rev 112274)
@@ -1633,7 +1633,3 @@
# https://bugs.webkit.org/show_bug.cgi?id=82309
http/tests/xmlhttprequest/basic-auth-default.html
http/tests/xmlhttprequest/re-login-async.html
-
-# https://bugs.webkit.org/show_bug.cgi?id=82314
-http/tests/inspector/compiler-script-mapping.html
-
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [112070] trunk
Title: [112070] trunk
Revision 112070
Author podivi...@chromium.org
Date 2012-03-26 02:55:15 -0700 (Mon, 26 Mar 2012)
Log Message
Web Inspector: move resource loading logic from SourceMapParser to CompilerScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=81897
Reviewed by Vsevolod Vlasov.
Source/WebCore:
SourceMapParser should only deal with payload parsing.
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.addScript):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
(WebInspector.SourceMapPayload):
(WebInspector.SourceMapParser):
(WebInspector.SourceMapParser.prototype.sourceContent):
(WebInspector.SourceMapParser.prototype.findEntry):
(WebInspector.SourceMapParser.prototype.findEntryReversed):
* inspector/front-end/ContentProviders.js:
(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
LayoutTests:
* http/tests/inspector/compiler-script-mapping.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js
trunk/Source/WebCore/inspector/front-end/ContentProviders.js
Diff
Modified: trunk/LayoutTests/ChangeLog (112069 => 112070)
--- trunk/LayoutTests/ChangeLog 2012-03-26 09:36:39 UTC (rev 112069)
+++ trunk/LayoutTests/ChangeLog 2012-03-26 09:55:15 UTC (rev 112070)
@@ -1,3 +1,12 @@
+2012-03-22 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: move resource loading logic from SourceMapParser to CompilerScriptMapping.
+https://bugs.webkit.org/show_bug.cgi?id=81897
+
+Reviewed by Vsevolod Vlasov.
+
+* http/tests/inspector/compiler-script-mapping.html:
+
2012-03-26 Pavel Feldman pfeld...@chromium.org
Reverting r112060, css3/selector3 expectations for chromium.
Modified: trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html (112069 => 112070)
--- trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html 2012-03-26 09:36:39 UTC (rev 112069)
+++ trunk/LayoutTests/http/tests/inspector/compiler-script-mapping.html 2012-03-26 09:55:15 UTC (rev 112070)
@@ -9,17 +9,17 @@
{
function checkMapping(compiledLineNumber, compiledColumnNumber, sourceURL, sourceLineNumber, sourceColumnNumber, mapping)
{
-var sourceLocation = mapping.compiledLocationToSourceLocation(compiledLineNumber, compiledColumnNumber);
-InspectorTest.assertEquals(sourceURL, sourceLocation.sourceURL);
-InspectorTest.assertEquals(sourceLineNumber, sourceLocation.lineNumber);
-InspectorTest.assertEquals(sourceColumnNumber, sourceLocation.columnNumber);
+var entry = mapping.findEntry(compiledLineNumber, compiledColumnNumber);
+InspectorTest.assertEquals(sourceURL, entry[2]);
+InspectorTest.assertEquals(sourceLineNumber, entry[3]);
+InspectorTest.assertEquals(sourceColumnNumber, entry[4]);
}
function checkReverseMapping(compiledLineNumber, compiledColumnNumber, sourceURL, sourceLineNumber, mapping)
{
-var compiledLocation = mapping.sourceLocationToCompiledLocation(sourceURL, sourceLineNumber);
-InspectorTest.assertEquals(compiledLineNumber, compiledLocation[0]);
-InspectorTest.assertEquals(compiledColumnNumber, compiledLocation[1]);
+var entry = mapping.findEntryReversed(sourceURL, sourceLineNumber);
+InspectorTest.assertEquals(compiledLineNumber, entry[0]);
+InspectorTest.assertEquals(compiledColumnNumber, entry[1]);
}
InspectorTest.runTestSuite([
@@ -45,8 +45,7 @@
mappings:AAASA,Q,IAAG,CAACC,CAAD,CAAaC,CAAb,CACZ,CACI,MAAOD,EAAP,CAAoBC,CADxB,CAIA,IAAIC,OAAS;,
sources:[example.js]
};
-var mapping = new WebInspector.SourceMapParser();
-mapping._parseMappingPayload(mappingPayload);
+var mapping = new WebInspector.SourceMapParser(source-map.json, mappingPayload);
checkMapping(0, 9, example.js, 0, 9, mapping);
checkMapping(0, 13, example.js, 0, 13, mapping);
@@ -60,7 +59,6 @@
checkReverseMapping(0, 18, example.js, 2, mapping);
checkReverseMapping(0, 29, example.js, 4, mapping);
checkReverseMapping(0, 29, example.js, 5, mapping);
-InspectorTest.assertTrue(!mapping.sourceLocationToCompiledLocation(example.js, 6));
next();
},
@@ -71,8 +69,7 @@
mappings:,C,CAAE;,
sources:[example.js]
};
-var mapping = new WebInspector.SourceMapParser();
-mapping._parseMappingPayload(mappingPayload);
+var mapping = new WebInspector.SourceMapParser(source-map.json, mappingP
[webkit-changes] [111389] trunk
Title: [111389] trunk
Revision 111389
Author podivi...@chromium.org
Date 2012-03-20 07:01:05 -0700 (Tue, 20 Mar 2012)
Log Message
Web Inspector: support inline source maps.
https://bugs.webkit.org/show_bug.cgi?id=81248
Source/WebCore:
- support optional map.sourcesContent array with sources content
- support data: url as script sourceMapURL, e.g. //@ sourceMappingURL=data:application/json;base64,base64-encoded map
Reviewed by Pavel Feldman.
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.loadSourceCode):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._canonicalizeURL):
LayoutTests:
Reviewed by Pavel Feldman.
* http/tests/inspector/compiler-source-mapping-expected.txt:
* http/tests/inspector/compiler-source-mapping.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
Diff
Modified: trunk/LayoutTests/ChangeLog (111388 => 111389)
--- trunk/LayoutTests/ChangeLog 2012-03-20 12:57:04 UTC (rev 111388)
+++ trunk/LayoutTests/ChangeLog 2012-03-20 14:01:05 UTC (rev 111389)
@@ -1,3 +1,13 @@
+2012-03-15 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: support inline source maps.
+https://bugs.webkit.org/show_bug.cgi?id=81248
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-source-mapping-expected.txt:
+* http/tests/inspector/compiler-source-mapping.html:
+
2012-03-20 Pavel Feldman pfeld...@chromium.org
Web Inspector: treat Uint* external arrays as arrays in console.
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt (111388 => 111389)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt 2012-03-20 12:57:04 UTC (rev 111388)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt 2012-03-20 14:01:05 UTC (rev 111389)
@@ -13,5 +13,7 @@
Running: testCompilerScriptMapping
+Running: testInlinedSourceMap
+
Running: testCompilerSourceMappingCouldNotBeLoaded
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html (111388 => 111389)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2012-03-20 12:57:04 UTC (rev 111388)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2012-03-20 14:01:05 UTC (rev 111389)
@@ -129,6 +129,7 @@
function testCompilerScriptMapping(next)
{
+WebInspector.debuggerModel._scripts = [];
var mapping = new WebInspector.CompilerScriptMapping();
var script = InspectorTest.createScriptMock(compiled.js, 0, 0, true, );
script.sourceMapURL = http://localhost:8000/inspector/resources/source-map.json;
@@ -162,8 +163,39 @@
}
},
+function testInlinedSourceMap(next)
+{
+WebInspector.debuggerModel._scripts = [];
+var mapping = new WebInspector.CompilerScriptMapping();
+var script = InspectorTest.createScriptMock(http://example.com/compiled.js, 0, 0, true, );
+var sourceMap = {
+file:compiled.js,
+mappings:AAASA,Q,IAAG,CAACC,CAAD,CAAaC,CAAb,CACZ,CACI,MAAOD,EAAP,CAAoBC,CADxB,CAIA,IAAIC,OAAS;,
+sources:[source.js],
+sourcesContent:[source content]
+};
+script.sourceMapURL = data:application/json;base64, + btoa(JSON.stringify(sourceMap));
+mapping.addScript(script);
+
+var uiSourceCodeList = mapping.uiSourceCodeList();
+InspectorTest.assertEquals(1, uiSourceCodeList.length);
+InspectorTest.assertEquals(source.js, uiSourceCodeList[0].url);
+
+InspectorTest.checkUILocation(uiSourceCodeList[0], 2, 4, mapping.rawLocationToUILocation(WebInspector.debuggerModel.createRawLocation(script, 0, 18)));
+InspectorTest.checkRawLocation(script, 0, 18, mapping.uiLocationToRawLocation(uiSourceCodeList[0], 2, 4));
+
+uiSourceCodeList[0].requestContent(didRequestContent);
+
+function didRequestContent(mimeType, content)
+{
+InspectorTest.assertEquals(source content, content);
+next();
+}
+},
+
function testCompilerSourceMappingCouldNotBeLoaded(next)
{
+WebInspector.debuggerModel._scripts = [];
var mainScriptMapping = new WebInspector.MainScriptMapping();
mainScriptMapping.addEventListener(WebInspector.MainScriptMapping.Events.UISourceCodeListChanged, uiSourceCodeListChanged);
Modified: trunk/Source/WebCore/
[webkit-changes] [111018] trunk/Source/WebCore
Title: [111018] trunk/Source/WebCore
Revision 111018
Author podivi...@chromium.org
Date 2012-03-16 09:49:45 -0700 (Fri, 16 Mar 2012)
Log Message
Web Inspector: fix exception when hovering over bound function in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=81362
Reviewed by Yury Semikhatsky.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (111017 => 111018)
--- trunk/Source/WebCore/ChangeLog 2012-03-16 16:49:32 UTC (rev 111017)
+++ trunk/Source/WebCore/ChangeLog 2012-03-16 16:49:45 UTC (rev 111018)
@@ -1,3 +1,13 @@
+2012-03-16 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix exception when hovering over bound function in heap profiler.
+https://bugs.webkit.org/show_bug.cgi?id=81362
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
+
2012-03-16 Yoshifumi Inoue yo...@chromium.org
[Forms] The progress element should not be a form-associated element.
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (111017 => 111018)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-16 16:49:32 UTC (rev 111017)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-16 16:49:45 UTC (rev 111018)
@@ -877,6 +877,8 @@
*/
linkifyRawLocation: function(rawLocation, classes)
{
+if (!WebInspector.debuggerModel.scriptForSourceID(rawLocation.scriptId))
+return null;
var anchor = WebInspector.linkifyURLAsNode(, , classes, false);
var liveLocation = this._model.createLiveLocation(rawLocation, this._updateAnchor.bind(this, anchor));
liveLocation.init();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110868] trunk/Source/WebCore
Title: [110868] trunk/Source/WebCore
Revision 110868
Author podivi...@chromium.org
Date 2012-03-15 11:55:39 -0700 (Thu, 15 Mar 2012)
Log Message
Web Inspector: live locations could be disposed twice.
https://bugs.webkit.org/show_bug.cgi?id=81249
Reviewed by Vsevolod Vlasov.
* inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptMapping.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (110867 => 110868)
--- trunk/Source/WebCore/ChangeLog 2012-03-15 18:45:45 UTC (rev 110867)
+++ trunk/Source/WebCore/ChangeLog 2012-03-15 18:55:39 UTC (rev 110868)
@@ -1,3 +1,13 @@
+2012-03-15 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: live locations could be disposed twice.
+https://bugs.webkit.org/show_bug.cgi?id=81249
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/ScriptMapping.js:
+(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
+
2012-03-15 Carlos Garcia Campos cgar...@igalia.com
[GTK] Implement unicode submenu items
Modified: trunk/Source/WebCore/inspector/front-end/ScriptMapping.js (110867 => 110868)
--- trunk/Source/WebCore/inspector/front-end/ScriptMapping.js 2012-03-15 18:45:45 UTC (rev 110867)
+++ trunk/Source/WebCore/inspector/front-end/ScriptMapping.js 2012-03-15 18:55:39 UTC (rev 110868)
@@ -135,7 +135,8 @@
_unregisterLiveLocation: function(scriptId, liveLocation)
{
-this._liveLocationsForScriptId[scriptId].remove(liveLocation);
+if (this._liveLocationsForScriptId[scriptId])
+this._liveLocationsForScriptId[scriptId].remove(liveLocation);
},
_updateLiveLocations: function(scriptIds)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110549] trunk/Source/WebCore
Title: [110549] trunk/Source/WebCore Revision 110549 Author podivi...@chromium.org Date 2012-03-13 02:10:42 -0700 (Tue, 13 Mar 2012) Log Message Web Inspector: move ResourceScriptMapping to a separate file. https://bugs.webkit.org/show_bug.cgi?id=80859 Reviewed by Vsevolod Vlasov. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/compile-front-end.sh: * inspector/front-end/ResourceScriptMapping.js: Copied from Source/WebCore/inspector/front-end/ScriptMapping.js. (WebInspector.ResourceScriptMapping): (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation): (WebInspector.ResourceScriptMapping.prototype.uiSourceCodeList): (WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeListChanged): (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged): (WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode): (WebInspector.ResourceScriptMapping.prototype.setFormatSource): (WebInspector.ResourceScriptMapping.prototype.forceUpdateSourceMapping): (WebInspector.ResourceScriptMapping.prototype.reset): * inspector/front-end/ScriptMapping.js: * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/inspector/compile-front-end.sh trunk/Source/WebCore/inspector/front-end/ScriptMapping.js trunk/Source/WebCore/inspector/front-end/WebKit.qrc trunk/Source/WebCore/inspector/front-end/inspector.html Added Paths trunk/Source/WebCore/inspector/front-end/ResourceScriptMapping.js Diff Modified: trunk/Source/WebCore/ChangeLog (110548 => 110549) --- trunk/Source/WebCore/ChangeLog 2012-03-13 08:56:17 UTC (rev 110548) +++ trunk/Source/WebCore/ChangeLog 2012-03-13 09:10:42 UTC (rev 110549) @@ -1,3 +1,27 @@ +2012-03-12 Pavel Podivilov podivi...@chromium.org + +Web Inspector: move ResourceScriptMapping to a separate file. +https://bugs.webkit.org/show_bug.cgi?id=80859 + +Reviewed by Vsevolod Vlasov. + +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* inspector/compile-front-end.sh: +* inspector/front-end/ResourceScriptMapping.js: Copied from Source/WebCore/inspector/front-end/ScriptMapping.js. +(WebInspector.ResourceScriptMapping): +(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation): +(WebInspector.ResourceScriptMapping.prototype.uiSourceCodeList): +(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeListChanged): +(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged): +(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode): +(WebInspector.ResourceScriptMapping.prototype.setFormatSource): +(WebInspector.ResourceScriptMapping.prototype.forceUpdateSourceMapping): +(WebInspector.ResourceScriptMapping.prototype.reset): +* inspector/front-end/ScriptMapping.js: +* inspector/front-end/WebKit.qrc: +* inspector/front-end/inspector.html: + 2012-03-12 Kentaro Hara hara...@chromium.org Rename OptionsObject to Dictionary Modified: trunk/Source/WebCore/WebCore.gypi (110548 => 110549) --- trunk/Source/WebCore/WebCore.gypi 2012-03-13 08:56:17 UTC (rev 110548) +++ trunk/Source/WebCore/WebCore.gypi 2012-03-13 09:10:42 UTC (rev 110549) @@ -6264,6 +6264,7 @@ 'inspector/front-end/ResourceJSONView.js', 'inspector/front-end/ResourceHTMLView.js', 'inspector/front-end/ResourceResponseView.js', +'inspector/front-end/ResourceScriptMapping.js', 'inspector/front-end/ResourceTimingView.js', 'inspector/front-end/ResourceTreeModel.js', 'inspector/front-end/ResourceUtils.js', Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (110548 => 110549) --- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2012-03-13 08:56:17 UTC (rev 110548) +++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2012-03-13 09:10:42 UTC (rev 110549) @@ -73765,6 +73765,10 @@ /File File + RelativePath=..\inspector\front-end\ResourceScriptMapping.js + +/File +File RelativePath=..\inspector\front-end\ResourceTimingView.js /File Modified: trunk/Source/WebCore/inspector/compile-front-end.sh (110548 => 110549) --- trunk/Source/WebCore/inspector/compile-front-end.sh 2012-03-13 08:56:17 UTC (rev 110548) +++ trunk/Source/WebCore/inspector/compile-front-end.sh 2012-03-13 09:10:42 UTC (rev 110549) @@ -45,7 +45,7 @@ --js Source/WebCore/inspector/front-end/UserMetrics.js \ --js Source/WebCore/inspector/front-end/HandlerRegistry.js \ --js Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js \ ---module jsmodule_sdk:34:jsmodule_common \ +--module jsmodule_sdk:35:jsmodule_common \ --js Source/WebCo
[webkit-changes] [110434] trunk
Title: [110434] trunk
Revision 110434
Author podivi...@chromium.org
Date 2012-03-12 08:56:06 -0700 (Mon, 12 Mar 2012)
Log Message
Web Inspector: DebuggerModel.Location should have scriptId property.
https://bugs.webkit.org/show_bug.cgi?id=80830
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.location):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerModel.prototype.createRawLocation):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessagesToScript):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.locationToPosition):
(WebInspector.ScriptFormatter.positionToLocation):
(WebInspector.FormattedSourceMapping.prototype.originalToFormatted):
(WebInspector.FormattedSourceMapping.prototype.formattedToOriginal):
LayoutTests:
* http/tests/inspector/compiler-source-mapping.html:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* http/tests/inspector/search/search-in-concatenated-script.html:
* http/tests/inspector/search/search-in-script.html:
* inspector/debugger/debugger-scripts.html:
* inspector/debugger/linkifier.html:
* inspector/debugger/raw-source-code.html:
* inspector/debugger/script-formatter.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html
trunk/LayoutTests/http/tests/inspector/debugger-test.js
trunk/LayoutTests/http/tests/inspector/search/search-in-concatenated-script.html
trunk/LayoutTests/http/tests/inspector/search/search-in-script.html
trunk/LayoutTests/inspector/debugger/debugger-scripts.html
trunk/LayoutTests/inspector/debugger/linkifier.html
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/LayoutTests/inspector/debugger/script-formatter.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
trunk/Source/WebCore/inspector/front-end/DebuggerModel.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/ScriptFormatter.js
Diff
Modified: trunk/LayoutTests/ChangeLog (110433 => 110434)
--- trunk/LayoutTests/ChangeLog 2012-03-12 15:50:27 UTC (rev 110433)
+++ trunk/LayoutTests/ChangeLog 2012-03-12 15:56:06 UTC (rev 110434)
@@ -1,3 +1,20 @@
+2012-03-12 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: DebuggerModel.Location should have scriptId property.
+https://bugs.webkit.org/show_bug.cgi?id=80830
+
+Reviewed by Vsevolod Vlasov.
+
+* http/tests/inspector/compiler-source-mapping.html:
+* http/tests/inspector/debugger-test.js:
+(initialize_DebuggerTest):
+* http/tests/inspector/search/search-in-concatenated-script.html:
+* http/tests/inspector/search/search-in-script.html:
+* inspector/debugger/debugger-scripts.html:
+* inspector/debugger/linkifier.html:
+* inspector/debugger/raw-source-code.html:
+* inspector/debugger/script-formatter.html:
+
2012-03-12 Csaba Osztrogonác o...@webkit.org
[Qt] REGRESSION(r110401): fast/table/table-row-compositing-repaint-crash.html asserts
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html (110433 => 110434)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2012-03-12 15:50:27 UTC (rev 110433)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2012-03-12 15:56:06 UTC (rev 110434)
@@ -17,8 +17,8 @@
function checkReverseMapping(compiledLineNumber, compiledColumnNumber, sourceURL, sourceLineNumber, mapping)
{
var compiledLocation = mapping.sourceLocationToCompiledLocation(sourceURL, sourceLineNumber);
-InspectorTest.assert
[webkit-changes] [110445] trunk/Source/WebCore
Title: [110445] trunk/Source/WebCore
Revision 110445
Author podivi...@chromium.org
Date 2012-03-12 10:43:51 -0700 (Mon, 12 Mar 2012)
Log Message
Web Inspector: extract ResourceScriptMapping from MainScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=80834
Reviewed by Vsevolod Vlasov.
* inspector/front-end/ScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype.reset):
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype.uiSourceCodeList):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.setFormatSource):
(WebInspector.MainScriptMapping.prototype.forceUpdateSourceMapping):
(WebInspector.MainScriptMapping.prototype.reset):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptMapping.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (110444 => 110445)
--- trunk/Source/WebCore/ChangeLog 2012-03-12 17:42:36 UTC (rev 110444)
+++ trunk/Source/WebCore/ChangeLog 2012-03-12 17:43:51 UTC (rev 110445)
@@ -1,3 +1,27 @@
+2012-03-12 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: extract ResourceScriptMapping from MainScriptMapping.
+https://bugs.webkit.org/show_bug.cgi?id=80834
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/ScriptMapping.js:
+(WebInspector.ResourceScriptMapping):
+(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
+(WebInspector.ResourceScriptMapping.prototype.reset):
+(WebInspector.MainScriptMapping):
+(WebInspector.MainScriptMapping.prototype.rawLocationToUILocation):
+(WebInspector.MainScriptMapping.prototype.createLiveLocation):
+(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
+(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
+(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
+(WebInspector.MainScriptMapping.prototype.uiSourceCodeList):
+(WebInspector.MainScriptMapping.prototype.addScript):
+(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
+(WebInspector.MainScriptMapping.prototype.setFormatSource):
+(WebInspector.MainScriptMapping.prototype.forceUpdateSourceMapping):
+(WebInspector.MainScriptMapping.prototype.reset):
+
2012-03-12 Pavel Feldman pfeld...@chromium.org
Web Inspector: recognize Float*Array and Int*Array as arrays.
Modified: trunk/Source/WebCore/inspector/front-end/ScriptMapping.js (110444 => 110445)
--- trunk/Source/WebCore/inspector/front-end/ScriptMapping.js 2012-03-12 17:42:36 UTC (rev 110444)
+++ trunk/Source/WebCore/inspector/front-end/ScriptMapping.js 2012-03-12 17:43:51 UTC (rev 110445)
@@ -65,9 +65,9 @@
/**
* @constructor
- * @extends {WebInspector.Object}
+ * @extends {WebInspector.ScriptMapping}
*/
-WebInspector.MainScriptMapping = function()
+WebInspector.ResourceScriptMapping = function()
{
this._rawSourceCodes = [];
this._rawSourceCodeForScriptId = {};
@@ -76,14 +76,9 @@
this._rawSourceCodeForUISourceCode = new Map();
this._formatter = new WebInspector.ScriptFormatter();
this._formatSource = false;
-this._liveLocationsForScriptId = {};
}
-WebInspector.MainScriptMapping.Events = {
-UISourceCodeListChanged: us-source-code-list-changed
-}
-
-WebInspector.MainScriptMapping.prototype = {
+WebInspector.ResourceScriptMapping.prototype = {
/**
* @param {DebuggerAgent.Location} rawLocation
* @return {WebInspector.UILocation}
@@ -107,36 +102,6 @@
},
/**
- * @param {DebuggerAgent.Location} rawLocation
- * @param {function(WebInspector.UILocation)} updateDelegate
- * @return {WebInspector.LiveLocation}
- */
-createLiveLocation: function(rawLocation, updateDelegate)
-{
-return new WebInspector.LiveLocation(this, rawLocation, updateDelegate);
-},
-
-_registerLiveLocation: function(scriptId, liveLocation)
-{
-this._liveLocationsForScriptId[scriptId].push(liveLocation)
-liveLocation._update();
-},
-
-_unregisterLiveLocation: function(scriptId, liveLocation)
-{
-this._liveLocationsForScriptId[scriptId].remove(liveLocation);
-},
-
-_updateLiveLocations: function(scriptIds)
-{
-for (var i = 0; i scriptIds.length; ++i) {
-var liveLocations = this._liveLocationsForScriptId[scr
[webkit-changes] [110043] trunk
Title: [110043] trunk
Revision 110043
Author podivi...@chromium.org
Date 2012-03-07 02:50:51 -0800 (Wed, 07 Mar 2012)
Log Message
Web Inspector: extract source mapping logic from DebuggerPresentationModel to ScriptMappingImpl.
https://bugs.webkit.org/show_bug.cgi?id=80412
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/ScriptMapping.js:
(WebInspector.ScriptMappingImpl):
(WebInspector.ScriptMappingImpl.prototype.rawLocationToUILocation):
(WebInspector.ScriptMappingImpl.prototype.createLiveLocation):
(WebInspector.ScriptMappingImpl.prototype.uiSourceCodeList):
(WebInspector.ScriptMappingImpl.prototype._handleUISourceCodeListChanged):
(WebInspector.ScriptMappingImpl.prototype._uiSourceCodeListChanged):
(WebInspector.ScriptMappingImpl.prototype._bindScriptToRawSourceCode):
(WebInspector.ScriptMappingImpl.prototype.setFormatSource):
(WebInspector.ScriptMappingImpl.prototype.forceUpdateSourceMapping):
(WebInspector.ScriptMappingImpl.prototype.reset):
LayoutTests:
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/callstack-placards-discarded.html:
* inspector/debugger/linkifier.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html
trunk/LayoutTests/inspector/debugger/linkifier.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/BreakpointManager.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/ScriptMapping.js
Diff
Modified: trunk/LayoutTests/ChangeLog (110042 => 110043)
--- trunk/LayoutTests/ChangeLog 2012-03-07 10:47:22 UTC (rev 110042)
+++ trunk/LayoutTests/ChangeLog 2012-03-07 10:50:51 UTC (rev 110043)
@@ -1,3 +1,14 @@
+2012-03-06 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: extract source mapping logic from DebuggerPresentationModel to ScriptMappingImpl.
+https://bugs.webkit.org/show_bug.cgi?id=80412
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/debugger/breakpoint-manager.html:
+* inspector/debugger/callstack-placards-discarded.html:
+* inspector/debugger/linkifier.html:
+
2012-03-07 Jochen Eisinger joc...@chromium.org
Unreviewed, add editing/execCommand baselines for chromium-mac-lion
Modified: trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html (110042 => 110043)
--- trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html 2012-03-07 10:47:22 UTC (rev 110042)
+++ trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html 2012-03-07 10:50:51 UTC (rev 110043)
@@ -21,7 +21,7 @@
InspectorTest.addResult(Received DebuggerPaused event.);
var callFrame = event.data.callFrames[0];
InspectorTest.addResult(Function name: + callFrame._callFrame.functionName);
-var rawSourceCode = WebInspector.debuggerPresentationModel._rawSourceCodeForScriptId[callFrame._callFrame.location.scriptId];
+var rawSourceCode = WebInspector.debuggerPresentationModel._scriptMapping._rawSourceCodeForScriptId[callFrame._callFrame.location.scriptId];
var listeners = rawSourceCode._listeners[WebInspector.RawSourceCode.Events.UISourceCodeListChanged];
InspectorTest.addResult(Listeners length: + listeners.length);
if (previousListenerLength !== undefined listeners.length !== previousListenerLength)
Modified: trunk/LayoutTests/inspector/debugger/linkifier.html (110042 => 110043)
--- trunk/LayoutTests/inspector/debugger/linkifier.html 2012-03-07 10:47:22 UTC (rev 110042)
+++ trunk/LayoutTests/inspector/debugger/linkifier.html 2012-03-07 10:50:51 UTC (rev 110043)
@@ -34,7 +34,7 @@
function debuggerTest()
{
linkifier = WebInspector.debuggerPresentationModel.createLinkifier();
-rawSourceCode = WebInspector.debuggerPresentationModel._rawSourceCodeForURL[WebInspector.inspectedPageURL];
+rawSourceCode = WebInspector.debuggerPresentationModel._scriptMapping._rawSourceCodeForURL[WebInspector.inspectedPageURL];
var count1 = listenersCount(rawSourceCode);
link = linkifier.linkifyLocation(WebInspector.inspectedPageURL, 20, 0, dummy-class);
Modified: trunk/Source/WebCore/ChangeLog (110042 => 110043)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 10:47:22 UTC (rev 110042)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 10:50:51 UTC (rev 110043)
@@ -1,3 +1,25 @@
+2012-03-06 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: extract source mapping logic from DebuggerPresentationModel to ScriptMappingImpl.
+https://bugs.webkit.org/show_bug.cgi?id=80412
+
+Reviewed by Vsevolod Vlasov.
+
+* WebCore.gypi:
+* WebCore.vcproj/WebCore.vcproj:
+* inspector/compile-front-end.sh:
+* inspect
[webkit-changes] [109872] trunk
Title: [109872] trunk
Revision 109872
Author podivi...@chromium.org
Date 2012-03-06 00:10:28 -0800 (Tue, 06 Mar 2012)
Log Message
Web Inspector: stop using RawSourceCode in BreakpointManager.
https://bugs.webkit.org/show_bug.cgi?id=80286
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
* inspector/front-end/ScriptMapping.js: Added.
(WebInspector.ScriptMapping):
(WebInspector.ScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.ScriptMapping.prototype.createLiveLocation):
(WebInspector.ScriptMapping.prototype.uiSourceCodeList):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
LayoutTests:
* inspector/debugger/breakpoint-manager.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/breakpoint-manager.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/inspector/front-end/BreakpointManager.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/WebKit.qrc
trunk/Source/WebCore/inspector/front-end/inspector.html
Added Paths
trunk/Source/WebCore/inspector/front-end/ScriptMapping.js
Diff
Modified: trunk/LayoutTests/ChangeLog (109871 => 109872)
--- trunk/LayoutTests/ChangeLog 2012-03-06 08:04:31 UTC (rev 109871)
+++ trunk/LayoutTests/ChangeLog 2012-03-06 08:10:28 UTC (rev 109872)
@@ -1,3 +1,12 @@
+2012-03-05 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: stop using RawSourceCode in BreakpointManager.
+https://bugs.webkit.org/show_bug.cgi?id=80286
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/debugger/breakpoint-manager.html:
+
2012-03-05 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed gardening. Skip new crashing tests,
Modified: trunk/LayoutTests/inspector/debugger/breakpoint-manager.html (109871 => 109872)
--- trunk/LayoutTests/inspector/debugger/breakpoint-manager.html 2012-03-06 08:04:31 UTC (rev 109871)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-manager.html 2012-03-06 08:10:28 UTC (rev 109872)
@@ -58,35 +58,31 @@
serializedBreakpoints.push(createBreakpoint(a.js, 20, , false));
serializedBreakpoints.push(createBreakpoint(b.js, 3, , true));
-function createUISourceCode(id, url, rawLocationToUILocation, uiLocationToRawLocation)
+function createUISourceCode(id, url) { return { id: id, url: url }; }
+var uiSourceCodeA = createUISourceCode(a.js, a.js);
+var uiSourceCodeB = createUISourceCode(b.js, b.js);
+
+var scriptMapping = {};
+scriptMapping.rawLocationToUILocation = function(rawLocation) { return rawLocation; };
+scriptMapping.uiLocationToRawLocation = function(uiSourceCode, lineNumber)
{
-return {
-id: id,
-url: url,
-rawSourceCode: { rawLocationToUILocation: rawLocationToUILocation, uiLocationToRawLocation: uiLocationToRawLocation }
-};
+scriptId = uiSourceCode === uiSourceCodeA ? a.js : b.js;
+return { scriptId: scriptId, lineNumber: lineNumber, columnNumber: 0 };
}
-var uiSourceCodeA = createUISourceCode(a.js, a.js,
-function(rawLocation) { return rawLocation; },
-function(uiSourceCode, lineNumber) { return { scriptId: a.js, lineNumber: lineNumber, columnNumber: 0 }; });
-var uiSourceCodeB = createUISourceCode(b.js, b.js,
-function(rawLocation) { return rawLocation; },
-function(uiSourceCode, lineNumber) { return { scriptId: b.js, lineNumber: lineNumber, columnNumber: 0 }; });
-
-function createBreakpointManager(breakpoints)
+function createBreakpointManager(breakpoints, scriptMapping)
{
breakpointStorage.set(breakpoints);
uiBreakpoints = {};
debuggerBreakpoints = {};
debuggerModel.removeAllListeners();
-return new WebInspector.BreakpointManager(breakpointStorage, breakpointAdded, breakpointRemoved, debuggerModel);
+return new WebInspector.BreakpointManager(breakpointStorage, breakpointAdded, breakpointRemoved, debuggerModel, scriptMapping);
}
InspectorTest.runTestSuite([
function uiSourceCodeAdded(next)
{
-var breakpointManager = createBreakpointManager(serializedBreakpoints);
+var breakpointManager = createBreakpointManager(serializedBreakpoints, scriptM
[webkit-changes] [109899] trunk
Title: [109899] trunk
Revision 109899
Author podivi...@chromium.org
Date 2012-03-06 04:11:05 -0800 (Tue, 06 Mar 2012)
Log Message
Web Inspector: remove reference to RawSourceCode from UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=80395
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/compile-front-end.sh:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
LayoutTests:
* inspector/debugger/raw-source-code.html:
* inspector/debugger/ui-source-code.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/LayoutTests/inspector/debugger/ui-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/compile-front-end.sh
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (109898 => 109899)
--- trunk/LayoutTests/ChangeLog 2012-03-06 12:09:18 UTC (rev 109898)
+++ trunk/LayoutTests/ChangeLog 2012-03-06 12:11:05 UTC (rev 109899)
@@ -1,3 +1,13 @@
+2012-03-06 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: remove reference to RawSourceCode from UISourceCode.
+https://bugs.webkit.org/show_bug.cgi?id=80395
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/debugger/raw-source-code.html:
+* inspector/debugger/ui-source-code.html:
+
2012-03-06 Ádám Kallai ka...@inf.u-szeged.hu
[Qt] Gardening, skip some failing tests.
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (109898 => 109899)
--- trunk/LayoutTests/inspector/debugger/raw-source-code.html 2012-03-06 12:09:18 UTC (rev 109898)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html 2012-03-06 12:11:05 UTC (rev 109899)
@@ -109,7 +109,6 @@
var uiSourceCode = rawSourceCode.uiSourceCodeList()[0];
InspectorTest.assertEquals(foo.js, uiSourceCode.url);
InspectorTest.assertEquals(true, uiSourceCode.isContentScript);
-InspectorTest.assertEquals(rawSourceCode, uiSourceCode.rawSourceCode);
checkUILocation(uiSourceCode, 0, 5, rawSourceCode.rawLocationToUILocation(createRawLocation(0, 5)));
checkRawLocation(script, 10, 0, rawSourceCode.uiLocationToRawLocation(uiSourceCode, 10, 0));
uiSourceCode.requestContent(didRequestContent);
Modified: trunk/LayoutTests/inspector/debugger/ui-source-code.html (109898 => 109899)
--- trunk/LayoutTests/inspector/debugger/ui-source-code.html 2012-03-06 12:09:18 UTC (rev 109898)
+++ trunk/LayoutTests/inspector/debugger/ui-source-code.html 2012-03-06 12:11:05 UTC (rev 109899)
@@ -17,7 +17,7 @@
InspectorTest.runTestSuite([
function testUISourceCode(next)
{
-var uiSourceCode = new WebInspector.UISourceCode(id, url, null, contentProvider);
+var uiSourceCode = new WebInspector.UISourceCode(id, url, contentProvider);
function didRequestContent(callNumber, mimeType, content)
{
InspectorTest.addResult(Callback + callNumber + is invoked.);
Modified: trunk/Source/WebCore/ChangeLog (109898 => 109899)
--- trunk/Source/WebCore/ChangeLog 2012-03-06 12:09:18 UTC (rev 109898)
+++ trunk/Source/WebCore/ChangeLog 2012-03-06 12:11:05 UTC (rev 109899)
@@ -1,3 +1,25 @@
+2012-03-06 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: remove reference to RawSourceCode from UISourceCode.
+https://bugs.webkit.org/show_bug.cgi?id=80395
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/compile-front-end.sh:
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel):
+(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
+(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
+(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
+(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
+(WebInspector.DebuggerPresentationModel.prototype.set
[webkit-changes] [109905] trunk
Title: [109905] trunk
Revision 109905
Author podivi...@chromium.org
Date 2012-03-06 04:39:33 -0800 (Tue, 06 Mar 2012)
Log Message
Web Inspector: prepare for extracting ScriptMapping implementation from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=80396
Source/WebCore:
Limit RawSourceCode usages to a subset of methods. This subset will be moved to ScriptMapping implementation in a separate change.
Reviewed by Vsevolod Vlasov.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.prototype.createLiveLocation):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._forceUpdateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.PresentationCallFrame):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
LayoutTests:
Reviewed by Vsevolod Vlasov.
* inspector/debugger/callstack-placards-discarded.html:
* inspector/debugger/linkifier.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html
trunk/LayoutTests/inspector/debugger/linkifier.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (109904 => 109905)
--- trunk/LayoutTests/ChangeLog 2012-03-06 12:34:05 UTC (rev 109904)
+++ trunk/LayoutTests/ChangeLog 2012-03-06 12:39:33 UTC (rev 109905)
@@ -1,3 +1,13 @@
+2012-03-06 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: prepare for extracting ScriptMapping implementation from DebuggerPresentationModel.
+https://bugs.webkit.org/show_bug.cgi?id=80396
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/debugger/callstack-placards-discarded.html:
+* inspector/debugger/linkifier.html:
+
2012-03-06 Vsevolod Vlasov vse...@chromium.org
Web Inspector: [Regression] Execution line is not revealed when debugger is stopped if scripts panel was not yet shown.
Modified: trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html (109904 => 109905)
--- trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html 2012-03-06 12:34:05 UTC (rev 109904)
+++ trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html 2012-03-06 12:39:33 UTC (rev 109905)
@@ -21,7 +21,7 @@
InspectorTest.addResult(Received DebuggerPaused event.);
var callFrame = event.data.callFrames[0];
InspectorTest.addResult(Function name: + callFrame._callFrame.functionName);
-var rawSourceCode = callFrame._rawSourceCode;
+var rawSourceCode = WebInspector.debuggerPresentationModel._rawSourceCodeForScriptId[callFrame._callFrame.location.scriptId];
var listeners = rawSourceCode._listeners[WebInspector.RawSourceCode.Events.UISourceCodeListChanged];
InspectorTest.addResult(Listeners length: + listeners.length);
if (previousListenerLength !== undefined listeners.length !== previousListenerLength)
Modified: trunk/LayoutTests/inspector/debugger/linkifier.html (109904 => 109905)
--- trunk/LayoutTests/inspector/debugger/linkifier.html 2012-03-06 12:34:05 UTC (rev 109904)
+++ trunk/LayoutTests/inspector/debugger/linkifier.html 2012-03-06 12:39:33 UTC (rev 109905)
@@ -34,7 +34,7 @@
function debuggerTest()
{
linkifier = WebInspector.debuggerPresentationModel.createLinkifier();
-rawSourceCode = WebInspector.debuggerPresentationModel._rawSourceCodeForScriptWithURL(WebInspector.inspectedPageURL);
+rawSourceCode = WebInspector.debuggerPresentationModel._rawSourceCodeForURL[WebInspector.inspectedPageURL];
var count1 = listenersCount(rawSourceCode);
link = linkifier.linkifyLocation(WebInspector.inspectedPageURL, 20, 0, dummy-class);
Modified: trunk/Source/WebCore/ChangeLog (109904 => 109905)
--- trunk/Source/WebCore/ChangeLog 2012-03-06 12:34:05 UTC (rev 10990
[webkit-changes] [109728] trunk
Title: [109728] trunk
Revision 109728
Author podivi...@chromium.org
Date 2012-03-05 02:01:11 -0800 (Mon, 05 Mar 2012)
Log Message
Web Inspector: fix extensions-resource.html test.
https://bugs.webkit.org/show_bug.cgi?id=80183
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
LayoutTests:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (109727 => 109728)
--- trunk/LayoutTests/ChangeLog 2012-03-05 09:49:15 UTC (rev 109727)
+++ trunk/LayoutTests/ChangeLog 2012-03-05 10:01:11 UTC (rev 109728)
@@ -1,3 +1,12 @@
+2012-03-05 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix extensions-resource.html test.
+https://bugs.webkit.org/show_bug.cgi?id=80183
+
+Reviewed by Vsevolod Vlasov.
+
+* platform/chromium/test_expectations.txt:
+
2012-03-05 Kent Tamura tk...@chromium.org
[Chromium] Rebaseline search-field-cancel.html for r109503.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109727 => 109728)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-05 09:49:15 UTC (rev 109727)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-05 10:01:11 UTC (rev 109728)
@@ -711,8 +711,6 @@
BUGWK78810 LINUX WIN DEBUG SLOW : inspector/debugger/script-formatter-console.html = PASS
-BUGWK80183 LINUX WIN : inspector/extensions/extensions-resources.html = TIMEOUT
-
// -
// Editing tests
// -
Modified: trunk/Source/WebCore/ChangeLog (109727 => 109728)
--- trunk/Source/WebCore/ChangeLog 2012-03-05 09:49:15 UTC (rev 109727)
+++ trunk/Source/WebCore/ChangeLog 2012-03-05 10:01:11 UTC (rev 109728)
@@ -1,3 +1,13 @@
+2012-03-05 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix extensions-resource.html test.
+https://bugs.webkit.org/show_bug.cgi?id=80183
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
+
2012-03-02 Andrey Kosyakov ca...@chromium.org
Add instrumentation for frame start/end on timeline.
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (109727 => 109728)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-05 09:49:15 UTC (rev 109727)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-05 10:01:11 UTC (rev 109728)
@@ -1025,6 +1025,7 @@
_updateAnchor: function(anchor, uiLocation)
{
anchor.preferredPanel = scripts;
+anchor.href = ""
anchor.uiSourceCode = uiLocation.uiSourceCode;
anchor.lineNumber = uiLocation.lineNumber;
this._formatter.formatLiveAnchor(anchor, uiLocation);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109560] trunk
Title: [109560] trunk
Revision 109560
Author podivi...@chromium.org
Date 2012-03-02 05:15:09 -0800 (Fri, 02 Mar 2012)
Log Message
Web Inspector: update execution line using LiveLocation.
https://bugs.webkit.org/show_bug.cgi?id=80143
Reviewed by Vsevolod Vlasov.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.updateExecutionLine):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
Modified Paths
trunk/LayoutTests/inspector/debugger/callstack-placards-discarded-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Diff
Modified: trunk/LayoutTests/inspector/debugger/callstack-placards-discarded-expected.txt (109559 => 109560)
--- trunk/LayoutTests/inspector/debugger/callstack-placards-discarded-expected.txt 2012-03-02 12:59:36 UTC (rev 109559)
+++ trunk/LayoutTests/inspector/debugger/callstack-placards-discarded-expected.txt 2012-03-02 13:15:09 UTC (rev 109560)
@@ -7,13 +7,13 @@
Set timer for test function.
Received DebuggerPaused event.
Function name: testFunction
-Listeners length: 2
+Listeners length: 3
Script execution paused.
Script execution resumed.
Set timer for test function.
Received DebuggerPaused event.
Function name: testFunction
-Listeners length: 2
+Listeners length: 3
Script execution paused.
Script execution resumed.
Debugger was disabled.
Modified: trunk/Source/WebCore/ChangeLog (109559 => 109560)
--- trunk/Source/WebCore/ChangeLog 2012-03-02 12:59:36 UTC (rev 109559)
+++ trunk/Source/WebCore/ChangeLog 2012-03-02 13:15:09 UTC (rev 109560)
@@ -1,3 +1,16 @@
+2012-03-02 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: update execution line using LiveLocation.
+https://bugs.webkit.org/show_bug.cgi?id=80143
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
+(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
+(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.updateExecutionLine):
+(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
+
2012-03-02 Leo Yang leo.y...@torchmobile.com.cn
[BlackBerry] Build fix for LocalizedStringsBlackBerry.cpp
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (109559 => 109560)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-02 12:59:36 UTC (rev 109559)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-02 13:15:09 UTC (rev 109560)
@@ -210,7 +210,6 @@
}
this._restoreBreakpoints(rawSourceCode);
-this._restoreExecutionLine(rawSourceCode);
var uiSourceCodeList = rawSourceCode.uiSourceCodeList();
if (!oldUISourceCodeList.length) {
@@ -238,18 +237,6 @@
},
/**
- * @param {WebInspector.RawSourceCode} rawSourceCode
- */
-_restoreExecutionLine: function(rawSourceCode)
-{
-if (!this._selectedCallFrame || this._selectedCallFrame.rawSourceCode !== rawSourceCode)
-return;
-
-var uiLocation = rawSourceCode.rawLocationToUILocation(this._selectedCallFrame._callFrame.location);
-this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.ExecutionLineChanged, uiLocation);
-},
-
-/**
* @param {WebInspector.UISourceCode} uiSourceCode
* @return {boolean}
*/
@@ -567,6 +554,10 @@
set selectedCallFrame(callFrame)
{
+if (this._executionLineLiveLocation)
+this._executionLineLiveLocation.dispose();
+delete this._executionLineLiveLocation;
+
this._selectedCallFrame = callFrame;
if (!this._selectedCallFrame)
return;
@@ -574,9 +565,12 @@
this._selectedCallFrame.rawSourceCode.forceUpdateSourceMapping();
this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.CallFrameSelected, callFrame);
-var uiLocation = callFrame.rawSourceCode.rawLocationToUILocation(callFrame._callFrame.location);
-if (uiLocation)
+function updateExecutionLine(uiLocation)
+{
this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.ExecutionLineChanged, uiLocation);
+}
+this._executionLineLiveLocation = this._selectedCallFrame.rawSourceCode.createLiveLocation(callFrame._callFrame.location, updateExecutionLine.bind(this));
+this._executionLineLiveLocation.init();
},
get selectedCallFrame()
___
webkit-changes mai
[webkit-changes] [109561] trunk/Source/WebCore
Title: [109561] trunk/Source/WebCore
Revision 109561
Author podivi...@chromium.org
Date 2012-03-02 05:22:12 -0800 (Fri, 02 Mar 2012)
Log Message
Web Inspector: limit RawSourceCode usages to DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=80146
Reviewed by Vsevolod Vlasov.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.uiLocationToRawLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js
trunk/Source/WebCore/inspector/front-end/ScriptsSearchScope.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (109560 => 109561)
--- trunk/Source/WebCore/ChangeLog 2012-03-02 13:15:09 UTC (rev 109560)
+++ trunk/Source/WebCore/ChangeLog 2012-03-02 13:22:12 UTC (rev 109561)
@@ -1,5 +1,22 @@
2012-03-02 Pavel Podivilov podivi...@chromium.org
+Web Inspector: limit RawSourceCode usages to DebuggerPresentationModel.
+https://bugs.webkit.org/show_bug.cgi?id=80146
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel.prototype.uiLocationToRawLocation):
+(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
+(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
+* inspector/front-end/ObjectPopoverHelper.js:
+(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
+(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
+* inspector/front-end/ScriptsSearchScope.js:
+(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
+
+2012-03-02 Pavel Podivilov podivi...@chromium.org
+
Web Inspector: update execution line using LiveLocation.
https://bugs.webkit.org/show_bug.cgi?id=80143
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (109560 => 109561)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-02 13:15:09 UTC (rev 109560)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-02 13:22:12 UTC (rev 109561)
@@ -105,6 +105,17 @@
},
/**
+ * @param {WebInspector.UISourceCode} uiSourceCode
+ * @param {number} lineNumber
+ * @param {number} columnNumber
+ * @return {DebuggerAgent.Location}
+ */
+uiLocationToRawLocation: function(uiSourceCode, lineNumber, columnNumber)
+{
+return uiSourceCode.rawSourceCode.uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber);
+},
+
+/**
* @param {WebInspector.Event} event
*/
_parsedScriptSource: function(event)
@@ -976,37 +987,29 @@
*/
linkifyLocation: function(sourceURL, lineNumber, columnNumber, classes)
{
-var rawSourceCode = this._model._rawSourceCodeForScriptWithURL(sourceURL);
-if (!rawSourceCode)
+var script = this._model._scriptForURLAndLocation(sourceURL, lineNumber, columnNumber);
+if (!script)
return WebInspector.linkifyResourceAsNode(sourceURL, lineNumber, classes);
-
-return this.linkifyRawSourceCode(rawSourceCode, lineNumber, columnNumber, classes);
+var rawLocation = new WebInspector.DebuggerModel.Location(lineNumber, columnNumber);
+rawLocation.scriptId = script.scriptId;
+return this.linkifyRawLocation(rawLocation, classes);
},
/**
- * @param {WebInspector.RawSourceCode} rawSourceCode
- * @param {number=} lineNumber
- * @param {number=} columnNumber
+ * @param {WebInspector.DebuggerModel.Location} rawLocation
* @param {string=} classes
*/
-linkifyRawSourceCode: function(rawSourceCode, lineNumber, columnNumber, classes)
+linkifyRawLocation: function(rawLocation, classes)
{
-var anchor = WebInspector.linkifyURLAsNode(rawSourceCode.url, , classes, false);
-var rawLocation = { lineNumber: lineNumber, columnNumber: columnNumber };
+var anchor = WebInspector.linkifyURLAsNode(, , classes, false);
+var script = WebInspector.debuggerModel.scriptForSourceID(rawLocation.scriptId);
+var rawSourceCode = this._model._rawSourceCodeForScript(script);
var liveLocation = rawSourceCode.createLiveLocation(rawLocation, this._updateAnchor.bind(this, anchor));
liveLocatio
[webkit-changes] [109577] trunk/Source/WebCore
Title: [109577] trunk/Source/WebCore
Revision 109577
Author podivi...@chromium.org
Date 2012-03-02 08:21:24 -0800 (Fri, 02 Mar 2012)
Log Message
Web Inspector: fix fronted compilation.
https://bugs.webkit.org/show_bug.cgi?id=80154
Reviewed by Yury Semikhatsky.
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.scriptForSourceID):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerModel.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/ScriptsSearchScope.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (109576 => 109577)
--- trunk/Source/WebCore/ChangeLog 2012-03-02 15:36:23 UTC (rev 109576)
+++ trunk/Source/WebCore/ChangeLog 2012-03-02 16:21:24 UTC (rev 109577)
@@ -1,3 +1,17 @@
+2012-03-02 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix fronted compilation.
+https://bugs.webkit.org/show_bug.cgi?id=80154
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DebuggerModel.js:
+(WebInspector.DebuggerModel.prototype.scriptForSourceID):
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
+* inspector/front-end/ScriptsSearchScope.js:
+(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
+
2012-03-02 Kaustubh Atrawalkar kaust...@motorola.com
Rename DOMURL to URL in the bindings
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerModel.js (109576 => 109577)
--- trunk/Source/WebCore/inspector/front-end/DebuggerModel.js 2012-03-02 15:36:23 UTC (rev 109576)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerModel.js 2012-03-02 16:21:24 UTC (rev 109577)
@@ -234,11 +234,11 @@
/**
* @param {DebuggerAgent.ScriptId} scriptId
- * @return {WebInspector.Script|undefined}
+ * @return {WebInspector.Script}
*/
scriptForSourceID: function(scriptId)
{
-return this._scripts[scriptId];
+return this._scripts[scriptId] || null;
},
/**
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (109576 => 109577)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-02 15:36:23 UTC (rev 109576)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-02 16:21:24 UTC (rev 109577)
@@ -677,6 +677,7 @@
/**
* @param {string} url
* @param {DebuggerAgent.Location} rawLocation
+ * @return {WebInspector.Script}
*/
_scriptForURLAndLocation: function(url, rawLocation)
{
@@ -987,10 +988,10 @@
*/
linkifyLocation: function(sourceURL, lineNumber, columnNumber, classes)
{
-var script = this._model._scriptForURLAndLocation(sourceURL, lineNumber, columnNumber);
+var rawLocation = new WebInspector.DebuggerModel.Location(lineNumber, columnNumber || 0);
+var script = this._model._scriptForURLAndLocation(sourceURL, rawLocation);
if (!script)
return WebInspector.linkifyResourceAsNode(sourceURL, lineNumber, classes);
-var rawLocation = new WebInspector.DebuggerModel.Location(lineNumber, columnNumber);
rawLocation.scriptId = script.scriptId;
return this.linkifyRawLocation(rawLocation, classes);
},
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsSearchScope.js (109576 => 109577)
--- trunk/Source/WebCore/inspector/front-end/ScriptsSearchScope.js 2012-03-02 15:36:23 UTC (rev 109576)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsSearchScope.js 2012-03-02 16:21:24 UTC (rev 109577)
@@ -144,7 +144,7 @@
*/
createAnchor: function(file, lineNumber, columnNumber)
{
-var uiSourceCode = file;
+var uiSourceCode = /** @type {WebInspector.UISourceCode} */ file;
var rawLocation = WebInspector.debuggerPresentationModel.uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber);
var anchor = this._linkifier.linkifyRawLocation(rawLocation);
anchor.removeChildren();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109323] trunk/Source/WebCore
Title: [109323] trunk/Source/WebCore
Revision 109323
Author podivi...@chromium.org
Date 2012-03-01 00:22:20 -0800 (Thu, 01 Mar 2012)
Log Message
Web Inspector: add UISourceCode.isEditable property.
https://bugs.webkit.org/show_bug.cgi?id=79909
Reviewed by Vsevolod Vlasov.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (109322 => 109323)
--- trunk/Source/WebCore/ChangeLog 2012-03-01 08:05:21 UTC (rev 109322)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 08:22:20 UTC (rev 109323)
@@ -1,3 +1,17 @@
+2012-02-29 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: add UISourceCode.isEditable property.
+https://bugs.webkit.org/show_bug.cgi?id=79909
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
+* inspector/front-end/RawSourceCode.js:
+(WebInspector.RawSourceCode.prototype._createUISourceCode):
+* inspector/front-end/UISourceCode.js:
+(WebInspector.UISourceCode):
+
2012-02-29 Shinya Kawanaka shin...@chromium.org
Fallback elements in non-youngest shadow tree should not be rendered.
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (109322 => 109323)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-01 08:05:21 UTC (rev 109322)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-01 08:22:20 UTC (rev 109323)
@@ -264,11 +264,7 @@
*/
canEditScriptSource: function(uiSourceCode)
{
-if (!WebInspector.debuggerModel.canSetScriptSource() || this._formatSource)
-return false;
-var rawSourceCode = uiSourceCode.rawSourceCode;
-var script = this._scriptForRawSourceCode(rawSourceCode);
-return script !script.lineOffset !script.columnOffset;
+return WebInspector.debuggerModel.canSetScriptSource() uiSourceCode.isEditable;
},
/**
Modified: trunk/Source/WebCore/inspector/front-end/RawSourceCode.js (109322 => 109323)
--- trunk/Source/WebCore/inspector/front-end/RawSourceCode.js 2012-03-01 08:05:21 UTC (rev 109322)
+++ trunk/Source/WebCore/inspector/front-end/RawSourceCode.js 2012-03-01 08:22:20 UTC (rev 109323)
@@ -259,6 +259,8 @@
{
var uiSourceCode = new WebInspector.UISourceCode(id, url, this, contentProvider);
uiSourceCode.isContentScript = this.isContentScript;
+uiSourceCode.isEditable = this._scripts.length === 1 !this._scripts[0].lineOffset !this._scripts[0].columnOffset
+ !this._formatted !this._compilerSourceMapping;
return uiSourceCode;
},
Modified: trunk/Source/WebCore/inspector/front-end/UISourceCode.js (109322 => 109323)
--- trunk/Source/WebCore/inspector/front-end/UISourceCode.js 2012-03-01 08:05:21 UTC (rev 109322)
+++ trunk/Source/WebCore/inspector/front-end/UISourceCode.js 2012-03-01 08:22:20 UTC (rev 109323)
@@ -43,6 +43,7 @@
this._rawSourceCode = rawSourceCode;
this._contentProvider = contentProvider;
this.isContentScript = false;
+this.isEditable = false;
/**
* @type Array.function(string,string)
*/
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109328] trunk
Title: [109328] trunk
Revision 109328
Author podivi...@chromium.org
Date 2012-03-01 02:28:55 -0800 (Thu, 01 Mar 2012)
Log Message
Web Inspector: abstract out the common pattern of creating auto-updated locations.
https://bugs.webkit.org/show_bug.cgi?id=79906
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):
(WebInspector.DebuggerPresentationModel.LinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.createLiveLocation):
(WebInspector.RawSourceCode.LiveLocation):
(WebInspector.RawSourceCode.LiveLocation.prototype.init):
(WebInspector.RawSourceCode.LiveLocation.prototype.dispose):
(WebInspector.RawSourceCode.LiveLocation.prototype._update):
LayoutTests:
* inspector/debugger/linkifier.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/linkifier.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/ScriptsSearchScope.js
Diff
Modified: trunk/LayoutTests/ChangeLog (109327 => 109328)
--- trunk/LayoutTests/ChangeLog 2012-03-01 09:53:57 UTC (rev 109327)
+++ trunk/LayoutTests/ChangeLog 2012-03-01 10:28:55 UTC (rev 109328)
@@ -1,3 +1,12 @@
+2012-02-29 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: abstract out the common pattern of creating auto-updated locations.
+https://bugs.webkit.org/show_bug.cgi?id=79906
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/debugger/linkifier.html:
+
2012-02-29 Shinya Kawanaka shin...@chromium.org
Fallback elements in non-youngest shadow tree should not be rendered.
Modified: trunk/LayoutTests/inspector/debugger/linkifier.html (109327 => 109328)
--- trunk/LayoutTests/inspector/debugger/linkifier.html 2012-03-01 09:53:57 UTC (rev 109327)
+++ trunk/LayoutTests/inspector/debugger/linkifier.html 2012-03-01 10:28:55 UTC (rev 109328)
@@ -43,14 +43,14 @@
InspectorTest.addResult(listeners added on raw source code: + (count2 - count1));
InspectorTest.addResult(original location: + link.textContent);
-InspectorTest.addSniffer(linkifier, _updateAnchor, linkUpdated);
+InspectorTest.addSniffer(linkifier._formatter, formatLiveAnchor, linkUpdated);
WebInspector.debuggerPresentationModel.setFormatSource(true);
}
function linkUpdated()
{
InspectorTest.addResult(pretty printed location: + link.textContent);
-InspectorTest.addSniffer(linkifier, _updateAnchor, linkReverted);
+InspectorTest.addSniffer(linkifier._formatter, formatLiveAnchor, linkReverted);
WebInspector.debuggerPresentationModel.setFormatSource(false);
}
@@ -75,7 +75,7 @@
var listenersArray = listeners[eventTypes];
count += listenersArray.length;
}
-return count;
+return count;
}
}
Modified: trunk/Source/WebCore/ChangeLog (109327 => 109328)
--- trunk/Source/WebCore/ChangeLog 2012-03-01 09:53:57 UTC (rev 109327)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 10:28:55 UTC (rev 109328)
@@ -1,3 +1,28 @@
+2012-02-29 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: abstract out the common pattern of creating auto-updated locations.
+https://bugs.webkit.org/show_bug.cgi?id=79906
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.PresentationCallFrame.prototype.uiLocation):
+(WebInspector.DebuggerPresentationModel.CallFramePlacard):
+(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
+(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):
+(WebInspector.DebuggerPresentationModel.LinkifierFormatter.prototype.formatRawSourceCodeAnchor):
+(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
+(WebInspector.DebuggerPresentationModel.Linkifier):
+(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode):
+(WebInspector.DebuggerPresentationModel.Linkifier.protot
[webkit-changes] [109351] trunk/Source/WebCore
Title: [109351] trunk/Source/WebCore
Revision 109351
Author podivi...@chromium.org
Date 2012-03-01 09:30:47 -0800 (Thu, 01 Mar 2012)
Log Message
Web Inspector: use live location to update console message bubbles.
https://bugs.webkit.org/show_bug.cgi?id=80023
Reviewed by Vsevolod Vlasov.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript.updateLocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessagesToScript):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype._scriptForURLAndLocation):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (109350 => 109351)
--- trunk/Source/WebCore/ChangeLog 2012-03-01 17:15:03 UTC (rev 109350)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 17:30:47 UTC (rev 109351)
@@ -1,3 +1,25 @@
+2012-03-01 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: use live location to update console message bubbles.
+https://bugs.webkit.org/show_bug.cgi?id=80023
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel):
+(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
+(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
+(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript.updateLocation):
+(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
+(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessage):
+(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessagesToScript):
+(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
+(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):
+(WebInspector.DebuggerPresentationModel.prototype._scriptForURLAndLocation):
+(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
+* inspector/front-end/RawSourceCode.js:
+(WebInspector.RawSourceCode):
+
2012-03-01 Vsevolod Vlasov vse...@chromium.org
Web Inspector: [InspectorIndexedDB] Show tooltips with IndexedDB objects meta information
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (109350 => 109351)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-01 17:15:03 UTC (rev 109350)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-03-01 17:30:47 UTC (rev 109351)
@@ -44,6 +44,10 @@
this._breakpointManager = new WebInspector.BreakpointManager(WebInspector.settings.breakpoints, this._breakpointAdded.bind(this), this._breakpointRemoved.bind(this), WebInspector.debuggerModel);
+this._pendingConsoleMessages = {};
+this._consoleMessageLiveLocations = [];
+this._presentationConsoleMessages = [];
+
WebInspector.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.ParsedScriptSource, this._parsedScriptSource, this);
WebInspector.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.FailedToParseScriptSource, this._failedToParseScriptSource, this);
WebInspector.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.DebuggerPaused, this._debuggerPaused, this);
@@ -149,6 +153,8 @@
if (isInlineScript)
this._rawSourceCodeForDocumentURL[script.sourceURL] = rawSourceCode;
+this._addPendingConsoleMessagesToScript(script);
+
if (rawSourceCode.uiSourceCodeList().length)
this._uiSourceCodeListChanged(rawSourceCode, []);
rawSourceCode.addEventListener(WebInspector.RawSourceCode.Events.UISourceCodeListChanged, this._handleUISourceCodeListChanged, this);
@@ -204,7 +210,6 @@
}
this._restoreBreakpoints(rawSourceCode);
-this._restoreConsoleMessages(rawSourceCode);
this._restoreExecutionLine(rawSourceCode);
var uiSourceCodeList = rawSourceCode.uiSourceCodeList();
@@ -235,20 +240,6 @@
/**
* @param {WebInspector.RawSourceCode} rawSour
[webkit-changes] [109210] trunk/Source/WebCore
Title: [109210] trunk/Source/WebCore
Revision 109210
Author podivi...@chromium.org
Date 2012-02-29 07:24:18 -0800 (Wed, 29 Feb 2012)
Log Message
Extended attributes list should go before 'static' and 'const' modifiers in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=79807
Reviewed by Kentaro Hara.
No new tests. Generated code isn't changed.
* bindings/scripts/IDLParser.pm:
(ParseInterface):
* bindings/scripts/IDLStructure.pm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestSupplemental.idl:
* html/DOMURL.idl:
* html/HTMLMediaElement.idl:
* html/HTMLTrackElement.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/IDLParser.pm
trunk/Source/WebCore/bindings/scripts/IDLStructure.pm
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/bindings/scripts/test/TestSupplemental.idl
trunk/Source/WebCore/html/DOMURL.idl
trunk/Source/WebCore/html/HTMLMediaElement.idl
trunk/Source/WebCore/html/HTMLTrackElement.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (109209 => 109210)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 15:13:34 UTC (rev 109209)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 15:24:18 UTC (rev 109210)
@@ -1,3 +1,21 @@
+2012-02-28 Pavel Podivilov podivi...@chromium.org
+
+Extended attributes list should go before 'static' and 'const' modifiers in IDLs.
+https://bugs.webkit.org/show_bug.cgi?id=79807
+
+Reviewed by Kentaro Hara.
+
+No new tests. Generated code isn't changed.
+
+* bindings/scripts/IDLParser.pm:
+(ParseInterface):
+* bindings/scripts/IDLStructure.pm:
+* bindings/scripts/test/TestObj.idl:
+* bindings/scripts/test/TestSupplemental.idl:
+* html/DOMURL.idl:
+* html/HTMLMediaElement.idl:
+* html/HTMLTrackElement.idl:
+
2012-02-28 Yury Semikhatsky yu...@chromium.org
Web Inspector: move DOM counter graphs out of experimental
Modified: trunk/Source/WebCore/bindings/scripts/IDLParser.pm (109209 => 109210)
--- trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2012-02-29 15:13:34 UTC (rev 109209)
+++ trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2012-02-29 15:24:18 UTC (rev 109210)
@@ -326,6 +326,7 @@
my @interfaceMethods = split(/;/, $interfaceData);
foreach my $line (@interfaceMethods) {
+next if $line =~ /^\s*$/;
if ($line =~ /\Wattribute\W/) {
$line =~ /$IDLStructure::interfaceAttributeSelector/;
@@ -361,11 +362,11 @@
$setterException =~ s/\s+//g;
@{$newDataNode-getterExceptions} = split(/,/, $getterException);
@{$newDataNode-setterExceptions} = split(/,/, $setterException);
-} elsif (($line !~ s/^\s*$//g) and ($line !~ /^\s*const/)) {
+} elsif ($line !~ /^\s*($IDLStructure::extendedAttributeSyntax )?const\s+/) {
$line =~ /$IDLStructure::interfaceMethodSelector/ or die Parsing error!\nSource:\n$line\n);
-my $isStatic = defined($1);
-my $methodExtendedAttributes = (defined($2) ? $2 : ); chop($methodExtendedAttributes);
+my $methodExtendedAttributes = (defined($1) ? $1 : ); chop($methodExtendedAttributes);
+my $isStatic = defined($2);
my $methodType = (defined($3) ? $3 : die(Parsing error!\nSource:\n$line\n)));
my $methodName = (defined($4) ? $4 : die(Parsing error!\nSource:\n$line\n)));
my $methodSignature = (defined($5) ? $5 : die(Parsing error!\nSource:\n$line\n)));
@@ -393,7 +394,7 @@
my $arrayRef = $dataNode-functions;
push(@$arrayRef, $newDataNode);
-} elsif ($line =~ /^\s*const/) {
+} else {
$line =~ /$IDLStructure::constantSelector/;
my $constExtendedAttributes = (defined($1) ? $1 : ); chop($constExtendedAttributes);
my $constType = (defined($2) ? $2 : die(Parsing error!\nSource:\n$line\n)));
Modified: trunk/Source/WebCore/bindings/scripts/IDLStructure.pm (109209 => 109210)
--- trunk/Source/WebCore/bindings/scripts/IDLStructure.pm 2012-02-29 15:13:34 UTC (rev 109209)
+++ trunk/Source/WebCore/bindings/scripts/IDLStructure.pm 2012-02-29 15:24:18 UTC (rev 109210)
@@ -96,7 +96,7 @@
# Regular _expression_ based IDL 'syntactical tokenizer' used in the IDLParser
our $moduleSelector = 'module\s*(' . $idlId . '*)\s*{';
our $moduleNSSelector = 'module\s*(' . $idlId . '*)\s*\[ns\s*(' . $idlIdNs . '*)\s*(' . $idlIdNs . '*)\]\s*;';
-our $constantSelector = 'const\s*(' . $extendedAttributeSyntax . ' )?' . $supportedTypes . '\s*(' . $idlType . '*)\s*=\s*(' . $constValue . ')';
+our $constantSelector = '(' . $extendedAttributeSyntax . ' )?const\s+' . $supportedTypes . '\s*(' . $idlType . '*)\s*=\s*(' . $constValue . ')';
our $raisesSelector = 'raises\s*\((' . $idlIdNsList . '*)\s*
[webkit-changes] [107543] trunk/LayoutTests
Title: [107543] trunk/LayoutTests Revision 107543 Author podivi...@chromium.org Date 2012-02-13 01:01:29 -0800 (Mon, 13 Feb 2012) Log Message 2012-02-13 Pavel Podivilov podivi...@chromium.org Unreviewed, remove missing test from expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (107542 => 107543) --- trunk/LayoutTests/ChangeLog 2012-02-13 08:53:26 UTC (rev 107542) +++ trunk/LayoutTests/ChangeLog 2012-02-13 09:01:29 UTC (rev 107543) @@ -1,3 +1,9 @@ +2012-02-13 Pavel Podivilov podivi...@chromium.org + +Unreviewed, remove missing test from expectations. + +* platform/chromium/test_expectations.txt: + 2012-02-13 Adam Barth aba...@webkit.org This test is testing the argument handling behavior of this API. Now Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107542 => 107543) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-13 08:53:26 UTC (rev 107542) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-13 09:01:29 UTC (rev 107543) @@ -1245,9 +1245,6 @@ // Asks for system fonts, which we don't support at all. BUGCR10335 LINUX : fast/css/css2-system-fonts.html = FAIL -// Large fonts have different metrics. -BUGCR10336 LINUX : fast/css/font-face-descriptor-multiple-values.html = FAIL - // Wants Helvetica, Monaco. It's still testing something useful, but we may // need to check in a wrong-looking baseline. Windows looks wrong too. BUGCR10337 LINUX : fast/css/font-face-locally-installed.html = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107546] trunk/LayoutTests
Title: [107546] trunk/LayoutTests
Revision 107546
Author podivi...@chromium.org
Date 2012-02-13 01:31:49 -0800 (Mon, 13 Feb 2012)
Log Message
2012-02-13 Pavel Podivilov podivi...@chromium.org
Unreviewed, add new baseline for font-face-default-font.html on linux.
* platform/chromium-linux/fast/css/font-face-default-font-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-linux/fast/css/font-face-default-font-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (107545 => 107546)
--- trunk/LayoutTests/ChangeLog 2012-02-13 09:30:45 UTC (rev 107545)
+++ trunk/LayoutTests/ChangeLog 2012-02-13 09:31:49 UTC (rev 107546)
@@ -1,3 +1,9 @@
+2012-02-13 Pavel Podivilov podivi...@chromium.org
+
+Unreviewed, add new baseline for font-face-default-font.html on linux.
+
+* platform/chromium-linux/fast/css/font-face-default-font-expected.txt: Added.
+
2012-02-13 Noel Gordon noel.gor...@gmail.com
Rebaseline JPEG image results after r107389
Added: trunk/LayoutTests/platform/chromium-linux/fast/css/font-face-default-font-expected.txt (0 => 107546)
--- trunk/LayoutTests/platform/chromium-linux/fast/css/font-face-default-font-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/fast/css/font-face-default-font-expected.txt 2012-02-13 09:31:49 UTC (rev 107546)
@@ -0,0 +1,20 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x20
+RenderText {#text} at (0,1) size 56x18
+ text run at (0,1) width 56: Test for
+RenderInline {I} at (0,0) size 626x19
+ RenderInline {A} at (0,0) size 323x19 [color=#EE]
+RenderText {#text} at (56,0) size 323x19
+ text run at (56,0) width 323: http://bugs.webkit.org/show_bug.cgi?id=16348
+ RenderText {#text} at (379,0) size 303x19
+text run at (379,0) width 4:
+text run at (383,0) width 299: @font-face does not affect the default style
+RenderText {#text} at (682,1) size 4x18
+ text run at (682,1) width 4: .
+ RenderBlock (anonymous) at (0,36) size 784x19
+RenderText {#text} at (0,0) size 184x18
+ text run at (0,0) width 184: This text should be in Arial.
Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/css/font-face-default-font-expected.txt
___
Added: svn:eol-style
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107550] trunk/LayoutTests
Title: [107550] trunk/LayoutTests Revision 107550 Author podivi...@chromium.org Date 2012-02-13 02:08:57 -0800 (Mon, 13 Feb 2012) Log Message 2012-02-13 Pavel Podivilov podivi...@chromium.org Unreviewed, mark dfg-put-by-id-prototype-check.html as failing in chromium (new test). * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (107549 => 107550) --- trunk/LayoutTests/ChangeLog 2012-02-13 10:08:11 UTC (rev 107549) +++ trunk/LayoutTests/ChangeLog 2012-02-13 10:08:57 UTC (rev 107550) @@ -1,3 +1,9 @@ +2012-02-13 Pavel Podivilov podivi...@chromium.org + +Unreviewed, mark dfg-put-by-id-prototype-check.html as failing in chromium (new test). + +* platform/chromium/test_expectations.txt: + 2012-02-13 Arko Saha a...@motorola.com summary is not keyboard accessible. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107549 => 107550) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-13 10:08:11 UTC (rev 107549) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-13 10:08:57 UTC (rev 107550) @@ -3996,3 +3996,5 @@ BUGWK75478 : fast/html/details-add-summary-4-and-click.html = IMAGE BUGWK75478 : fast/html/details-remove-summary-2-and-click.html = IMAGE BUGWK75478 : fast/html/details-add-summary-9-and-click.html = IMAGE + +BUGV8_1948 : fast/js/dfg-put-by-id-prototype-check.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107563] trunk/LayoutTests
Title: [107563] trunk/LayoutTests Revision 107563 Author podivi...@chromium.org Date 2012-02-13 05:42:56 -0800 (Mon, 13 Feb 2012) Log Message 2012-02-13 Pavel Podivilov podivi...@chromium.org Unreviewed, add IMAGE to two svg/carto.net tests expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (107562 => 107563) --- trunk/LayoutTests/ChangeLog 2012-02-13 13:30:42 UTC (rev 107562) +++ trunk/LayoutTests/ChangeLog 2012-02-13 13:42:56 UTC (rev 107563) @@ -1,3 +1,9 @@ +2012-02-13 Pavel Podivilov podivi...@chromium.org + +Unreviewed, add IMAGE to two svg/carto.net tests expectations. + +* platform/chromium/test_expectations.txt: + 2012-02-13 Pavel Feldman pfeld...@google.com Web Inspector: wrap settings selector text and adding a rule with undoable actions. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107562 => 107563) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-13 13:30:42 UTC (rev 107562) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-13 13:42:56 UTC (rev 107563) @@ -132,8 +132,8 @@ BUGNOEL : svg/W3C-SVG-1.1/struct-image-01-t.svg = IMAGE BUGNOEL : svg/W3C-SVG-1.1/struct-image-02-b.svg = IMAGE BUGNOEL : svg/W3C-SVG-1.1/struct-image-04-t.svg = IMAGE -BUGNOEL : svg/carto.net/scrollbar.svg = IMAGE+TEXT -BUGNOEL : svg/carto.net/selectionlist.svg = IMAGE+TEXT +BUGNOEL : svg/carto.net/scrollbar.svg = IMAGE+TEXT IMAGE +BUGNOEL : svg/carto.net/selectionlist.svg = IMAGE+TEXT IMAGE BUGNOEL : svg/custom/image-rescale-clip.html = IMAGE BUGNOEL : svg/custom/image-rescale-scroll.html = IMAGE BUGNOEL : svg/custom/image-rescale.svg = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107572] trunk/LayoutTests
Title: [107572] trunk/LayoutTests Revision 107572 Author podivi...@chromium.org Date 2012-02-13 07:10:26 -0800 (Mon, 13 Feb 2012) Log Message Unreviewed, add new chromium baselines for font-face-multiple-faces.html. * platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png: * platform/chromium-win/fast/css/font-face-multiple-faces-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png trunk/LayoutTests/platform/chromium-win/fast/css/font-face-multiple-faces-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (107571 => 107572) --- trunk/LayoutTests/ChangeLog 2012-02-13 15:05:17 UTC (rev 107571) +++ trunk/LayoutTests/ChangeLog 2012-02-13 15:10:26 UTC (rev 107572) @@ -1,3 +1,10 @@ +2012-02-13 Pavel Podivilov podivi...@chromium.org + +Unreviewed, add new chromium baselines for font-face-multiple-faces.html. + +* platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png: +* platform/chromium-win/fast/css/font-face-multiple-faces-expected.png: + 2012-02-13 Peter Rybin peter.ry...@gmail.com Web Inspector: In Inspector.json PropertyDescriptor.writable should be declared optional Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/fast/css/font-face-multiple-faces-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107376] trunk/LayoutTests
Title: [107376] trunk/LayoutTests Revision 107376 Author podivi...@chromium.org Date 2012-02-10 00:32:54 -0800 (Fri, 10 Feb 2012) Log Message 2012-02-10 Pavel Podivilov podivi...@chromium.org Unreviewed, gardening, mark editing/spelling/spelling-marker-description.html as failing. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (107375 => 107376) --- trunk/LayoutTests/ChangeLog 2012-02-10 08:21:01 UTC (rev 107375) +++ trunk/LayoutTests/ChangeLog 2012-02-10 08:32:54 UTC (rev 107376) @@ -1,3 +1,9 @@ +2012-02-10 Pavel Podivilov podivi...@chromium.org + +Unreviewed, gardening, mark editing/spelling/spelling-marker-description.html as failing. + +* platform/chromium/test_expectations.txt: + 2012-02-10 Adam Barth aba...@webkit.org Update baselines for svg/batik. These baselines either look quite Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107375 => 107376) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-10 08:21:01 UTC (rev 107375) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-10 08:32:54 UTC (rev 107376) @@ -3998,3 +3998,6 @@ BUGWK78251 DEBUG XP : inspector/elements/edit-dom-actions.html = CRASH BUGWK78251 DEBUG XP : inspector/elements/set-outer-html-body.html = CRASH BUGWK78251 DEBUG XP : inspector/elements/undo-dom-edits.html = CRASH + +// Started to fail after r107349. +BUGWK78331 editing/spelling/spelling-marker-description.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107381] trunk/LayoutTests
Title: [107381] trunk/LayoutTests Revision 107381 Author podivi...@chromium.org Date 2012-02-10 01:13:36 -0800 (Fri, 10 Feb 2012) Log Message 2012-02-10 Pavel Podivilov podivi...@chromium.org Unreviewed, fix error in test_expectations.txt. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (107380 => 107381) --- trunk/LayoutTests/ChangeLog 2012-02-10 09:06:04 UTC (rev 107380) +++ trunk/LayoutTests/ChangeLog 2012-02-10 09:13:36 UTC (rev 107381) @@ -1,3 +1,9 @@ +2012-02-10 Pavel Podivilov podivi...@chromium.org + +Unreviewed, fix error in test_expectations.txt. + +* platform/chromium/test_expectations.txt: + 2012-02-10 Pavel Feldman pfeld...@google.com [Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107380 => 107381) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-10 09:06:04 UTC (rev 107380) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-10 09:13:36 UTC (rev 107381) @@ -3983,4 +3983,4 @@ BUGWK47907 : media/video-empty-source.html = IMAGE+TEXT // Started to fail after r107349. -BUGWK78331 editing/spelling/spelling-marker-description.html = TEXT +BUGWK78331 : editing/spelling/spelling-marker-description.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107387] trunk/LayoutTests
Title: [107387] trunk/LayoutTests
Revision 107387
Author podivi...@chromium.org
Date 2012-02-10 02:02:14 -0800 (Fri, 10 Feb 2012)
Log Message
Unreviewed, rebaseline svg/carto.net/scrollbar-expected.png on chromium mac.
* platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
* platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt:
* platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.txt: Copied from LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt.
* platform/mac/svg/carto.net/scrollbar-expected.png: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png
Added Paths
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.txt
Removed Paths
trunk/LayoutTests/platform/mac/svg/carto.net/scrollbar-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (107386 => 107387)
--- trunk/LayoutTests/ChangeLog 2012-02-10 09:56:08 UTC (rev 107386)
+++ trunk/LayoutTests/ChangeLog 2012-02-10 10:02:14 UTC (rev 107387)
@@ -1,3 +1,13 @@
+2012-02-10 Pavel Podivilov podivi...@chromium.org
+
+Unreviewed, rebaseline svg/carto.net/scrollbar-expected.png on chromium mac.
+
+* platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
+* platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt:
+* platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
+* platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.txt: Copied from LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt.
+* platform/mac/svg/carto.net/scrollbar-expected.png: Removed.
+
2012-02-10 Andrey Kosyakov ca...@chromium.org
Unreviewed test fix following r107373.
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt (107386 => 107387)
--- trunk/LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt 2012-02-10 09:56:08 UTC (rev 107386)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt 2012-02-10 10:02:14 UTC (rev 107387)
@@ -84,15 +84,15 @@
RenderSVGRect {rect} at (39,483) size 89x17 [fill={[type=SOLID] [color=#FF]}] [x=49.00] [y=579.00] [width=110.00] [height=20.00]
RenderSVGRect {rect} at (40,484) size 89x17 [fill={[type=SOLID] [color=#696969]}] [x=51.00] [y=581.00] [width=110.00] [height=20.00]
RenderSVGRect {rect} at (40,484) size 88x16 [fill={[type=SOLID] [color=#DCDCDC]}] [x=50.00] [y=580.00] [width=110.00] [height=20.00]
-RenderSVGText {text} at (66,584) size 78x14 contains 1 chunk(s)
- RenderSVGTSpan {tspan} at (0,0) size 78x14
-RenderSVGInlineText {#text} at (0,0) size 78x14
- chunk 1 (middle anchor) text run 1 at (66.00,595.40) startOffset 0 endOffset 14 width 78.00: Hide Scrollbar
+RenderSVGText {text} at (65,584) size 80x14 contains 1 chunk(s)
+ RenderSVGTSpan {tspan} at (0,0) size 80x14
+RenderSVGInlineText {#text} at (0,0) size 80x14
+ chunk 1 (middle anchor) text run 1 at (65.00,595.40) startOffset 0 endOffset 14 width 80.00: Hide Scrollbar
RenderSVGContainer {g} at (135,483) size 90x18
RenderSVGRect {rect} at (135,483) size 89x17 [fill={[type=SOLID] [color=#FF]}] [x=169.00] [y=579.00] [width=110.00] [height=20.00]
RenderSVGRect {rect} at (136,484) size 89x17 [fill={[type=SOLID] [color=#696969]}] [x=171.00] [y=581.00] [width=110.00] [height=20.00]
RenderSVGRect {rect} at (136,484) size 88x16 [fill={[type=SOLID] [color=#DCDCDC]}] [x=170.00] [y=580.00] [width=110.00] [height=20.00]
-RenderSVGText {text} at (176,584) size 98x14 contains 1 chunk(s)
- RenderSVGTSpan {tspan} at (0,0) size 98x14
-RenderSVGInlineText {#text} at (0,0) size 98x14
- chunk 1 (middle anchor) text run 1 at (176.00,595.40) startOffset 0 endOffset 16 width 98.00: Remove Scrollbar
+RenderSVGText {text} at (174,584) size 102x14 contains 1 chunk(s)
+ RenderSVGTSpan {tspan} at (0,0) size 102x14
+RenderSVGInlineText {#text} at (0,0) size 102x14
+ chunk 1 (middle anchor) text run 1 at (174.38,595.40) startOffset 0 endOffset 16 width 101.25: Remove Scrollbar
Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png
(Binary files differ)
Copied: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/car
[webkit-changes] [107388] trunk/LayoutTests
Title: [107388] trunk/LayoutTests
Revision 107388
Author podivi...@chromium.org
Date 2012-02-10 02:10:18 -0800 (Fri, 10 Feb 2012)
Log Message
Unreviewed, rebaseline svg/carto.net/selectionlist.svg.
* platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt: Removed.
* platform/chromium-win-xp/svg/carto.net/selectionlist-expected.png: Removed.
* platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png
Removed Paths
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/svg/carto.net/selectionlist-expected.png
trunk/LayoutTests/platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (107387 => 107388)
--- trunk/LayoutTests/ChangeLog 2012-02-10 10:02:14 UTC (rev 107387)
+++ trunk/LayoutTests/ChangeLog 2012-02-10 10:10:18 UTC (rev 107388)
@@ -1,5 +1,15 @@
2012-02-10 Pavel Podivilov podivi...@chromium.org
+Unreviewed, rebaseline svg/carto.net/selectionlist.svg.
+
+* platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
+* platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
+* platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt: Removed.
+* platform/chromium-win-xp/svg/carto.net/selectionlist-expected.png: Removed.
+* platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Removed.
+
+2012-02-10 Pavel Podivilov podivi...@chromium.org
+
Unreviewed, rebaseline svg/carto.net/scrollbar-expected.png on chromium mac.
* platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt (107387 => 107388)
--- trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt 2012-02-10 10:02:14 UTC (rev 107387)
+++ trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt 2012-02-10 10:10:18 UTC (rev 107388)
@@ -1,111 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderSVGRoot {svg} at (0,0) size 800x600
-RenderSVGRect {rect} at (0,0) size 800x600 [fill={[type=SOLID] [color=#FF]}] [x=-1000.00] [y=-1000.00] [width=3000.00] [height=3000.00]
-RenderSVGContainer {g} at (39,37) size 691x561
- RenderSVGText {text} at (350,48) size 217x15 contains 1 chunk(s)
-RenderSVGInlineText {#text} at (0,0) size 217x15
- chunk 1 text run 1 at (350.00,60.00) startOffset 0 endOffset 33 width 216.32: Selectionlist/Drop-Down List Demo
- RenderSVGContainer {a} at (273,53) size 93x12
-RenderSVGText {text} at (350,69) size 118x13 contains 1 chunk(s)
- RenderSVGInlineText {#text} at (0,0) size 118x13
-chunk 1 text run 1 at (350.00,80.00) startOffset 0 endOffset 21 width 117.76: Link to Documentation
- RenderSVGText {text} at (350,101) size 282x13 contains 1 chunk(s)
-RenderSVGInlineText {#text} at (0,0) size 282x13
- chunk 1 text run 1 at (350.00,112.00) startOffset 0 endOffset 55 width 281.60: Click on this text to randomly resize the selectionList
- RenderSVGText {text} at (350,116) size 322x13 contains 1 chunk(s)
-RenderSVGInlineText {#text} at (0,0) size 322x13
- chunk 1 text run 1 at (350.00,127.00) startOffset 0 endOffset 62 width 321.28: Click on this text to randomly move the selectionList (x-axis)
- RenderSVGText {text} at (50,464) size 68x13 contains 1 chunk(s)
-RenderSVGInlineText {#text} at (0,0) size 68x13
- chunk 1 text run 1 at (50.00,475.00) startOffset 0 endOffset 12 width 67.84: Butterscotch
- RenderSVGText {text} at (150,389) size 212x13 contains 1 chunk(s)
-RenderSVGInlineText {#text} at (0,0) size 212x13
- chunk 1 text run 1 at (150.00,400.00) startOffset 0 endOffset 38 width 211.20: Loading Rose Image, Please be patient!
- RenderSVGText {text} at (240,736) size 264x28 contains 1 chunk(s)
-RenderSVGInlineText {#text} at (0,0) size 264x13
- chunk 1 text run 1 at (240.00,747.00) startOffset 0 endOffset 38 width 197.12: Click this text to remove the Flowers
- c
[webkit-changes] [107442] trunk/Source/WebCore
Title: [107442] trunk/Source/WebCore
Revision 107442
Author podivi...@chromium.org
Date 2012-02-10 14:20:53 -0800 (Fri, 10 Feb 2012)
Log Message
Fix a few typos in IDL exception names.
https://bugs.webkit.org/show_bug.cgi?id=78356
Reviewed by Adam Barth.
* dom/Node.idl:
* notifications/NotificationCenter.idl:
* page/Navigator.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.idl
trunk/Source/WebCore/notifications/NotificationCenter.idl
trunk/Source/WebCore/page/Navigator.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (107441 => 107442)
--- trunk/Source/WebCore/ChangeLog 2012-02-10 22:19:03 UTC (rev 107441)
+++ trunk/Source/WebCore/ChangeLog 2012-02-10 22:20:53 UTC (rev 107442)
@@ -1,3 +1,14 @@
+2012-02-10 Pavel Podivilov podivi...@chromium.org
+
+Fix a few typos in IDL exception names.
+https://bugs.webkit.org/show_bug.cgi?id=78356
+
+Reviewed by Adam Barth.
+
+* dom/Node.idl:
+* notifications/NotificationCenter.idl:
+* page/Navigator.idl:
+
2012-02-10 Benjamin Poulain bpoul...@apple.com
DefaultLocalizationStrategy::htmlSelectMultipleItems() should use size_t instead of int
Modified: trunk/Source/WebCore/dom/Node.idl (107441 => 107442)
--- trunk/Source/WebCore/dom/Node.idl 2012-02-10 22:19:03 UTC (rev 107441)
+++ trunk/Source/WebCore/dom/Node.idl 2012-02-10 22:20:53 UTC (rev 107442)
@@ -72,7 +72,7 @@
raises(DOMException);
[ObjCLegacyUnnamedParameters, Custom] Node replaceChild(in Node newChild,
in [CustomReturn] Node oldChild)
-raises(DOMExceptionJSC);
+raises(DOMException);
[Custom] Node removeChild(in [CustomReturn] Node oldChild)
raises(DOMException);
[Custom] Node appendChild(in [CustomReturn] Node newChild)
Modified: trunk/Source/WebCore/notifications/NotificationCenter.idl (107441 => 107442)
--- trunk/Source/WebCore/notifications/NotificationCenter.idl 2012-02-10 22:19:03 UTC (rev 107441)
+++ trunk/Source/WebCore/notifications/NotificationCenter.idl 2012-02-10 22:20:53 UTC (rev 107442)
@@ -37,9 +37,9 @@
OmitConstructor
] NotificationCenter {
#if !defined(ENABLE_TEXT_NOTIFICATIONS_ONLY) || !ENABLE_TEXT_NOTIFICATIONS_ONLY
- [V8Custom] Notification createHTMLNotification(in DOMString url) raises(Exception);
+ [V8Custom] Notification createHTMLNotification(in DOMString url) raises(DOMException);
#endif
- [V8Custom] Notification createNotification(in DOMString iconUrl, in DOMString title, in DOMString body) raises(Exception);
+ [V8Custom] Notification createNotification(in DOMString iconUrl, in DOMString title, in DOMString body) raises(DOMException);
int checkPermission();
[Custom] void requestPermission(in VoidCallback callback);
Modified: trunk/Source/WebCore/page/Navigator.idl (107441 => 107442)
--- trunk/Source/WebCore/page/Navigator.idl 2012-02-10 22:19:03 UTC (rev 107441)
+++ trunk/Source/WebCore/page/Navigator.idl 2012-02-10 22:20:53 UTC (rev 107442)
@@ -52,7 +52,7 @@
#if defined(ENABLE_REGISTER_PROTOCOL_HANDLER) ENABLE_REGISTER_PROTOCOL_HANDLER
void registerProtocolHandler(in DOMString scheme, in DOMString url, in DOMString title)
-raises(DomException);
+raises(DOMException);
#endif
#if defined(ENABLE_MEDIA_STREAM) ENABLE_MEDIA_STREAM
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107198] trunk/LayoutTests
Title: [107198] trunk/LayoutTests Revision 107198 Author podivi...@chromium.org Date 2012-02-09 01:42:47 -0800 (Thu, 09 Feb 2012) Log Message 2012-02-09 Pavel Podivilov podivi...@chromium.org Unreviewed, gardening, remove stale chromium expectations for synthetic-bold-transformed. * platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Removed. * platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Removed. * platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png trunk/LayoutTests/platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (107197 => 107198) --- trunk/LayoutTests/ChangeLog 2012-02-09 09:36:24 UTC (rev 107197) +++ trunk/LayoutTests/ChangeLog 2012-02-09 09:42:47 UTC (rev 107198) @@ -1,3 +1,11 @@ +2012-02-09 Pavel Podivilov podivi...@chromium.org + +Unreviewed, gardening, remove stale chromium expectations for synthetic-bold-transformed. + +* platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Removed. +* platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Removed. +* platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Removed. + 2012-02-09 Mike Lawther mikelawt...@chromium.org Unreviewed test_expectations change. Deleted: trunk/LayoutTests/platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png (Binary files differ) Deleted: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png (Binary files differ) Deleted: trunk/LayoutTests/platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107203] trunk/LayoutTests
Title: [107203] trunk/LayoutTests
Revision 107203
Author podivi...@chromium.org
Date 2012-02-09 01:55:51 -0800 (Thu, 09 Feb 2012)
Log Message
Unreviewed, add chromium expectations for new tests added in r107160.
* platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png:
* platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png:
* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt:
* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png
trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png
trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt
Added Paths
trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/line-grid/line-grid-into-columns-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-columns-expected.png
trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.png
trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (107202 => 107203)
--- trunk/LayoutTests/ChangeLog 2012-02-09 09:54:04 UTC (rev 107202)
+++ trunk/LayoutTests/ChangeLog 2012-02-09 09:55:51 UTC (rev 107203)
@@ -1,3 +1,16 @@
+2012-02-09 Pavel Podivilov podivi...@chromium.org
+
+Unreviewed, add chromium expectations for new tests added in r107160.
+
+* platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png:
+* platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png: Added.
+* platform/chromium-mac-leopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
+* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
+* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png:
+* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt:
+* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.png: Added.
+* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.txt: Added.
+
2012-02-09 Shinya Kawanaka shin...@google.com
Disable adding a shadow root to elements having a dynamic built-in shadow root.
Modified: trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png
(Binary files differ)
Added: trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-mac-leopard/fast/line-grid/line-grid-into-columns-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/fast/line-grid/line-grid-into-columns-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-columns-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-columns-expected.png
___
Added: svn:mime-type
Modified: trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt (107202 => 107203)
--- trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt 2012-02-09 09:54:04 UTC (rev 107202)
+++ trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt 2012-02-09 09:55:51 UTC (rev 107203)
@@ -5,7 +5,7 @@
RenderBody {BODY} at (8,8) size 784x569
layer at (8,8) size 784x504
RenderBlock {DIV} at (0,0) size 784x504 [border: (2px solid #FF)]
-RenderBlock {DIV} at (2,2) size 382x1425
+RenderBlock {DIV} at (2,2) size 382x1468
RenderBlock {DIV} at (0,0) size 382x253
RenderText {#text} at (0,18) size 363x62
[webkit-changes] [107253] trunk/LayoutTests
Title: [107253] trunk/LayoutTests Revision 107253 Author podivi...@chromium.org Date 2012-02-09 09:11:06 -0800 (Thu, 09 Feb 2012) Log Message 2012-02-09 Pavel Podivilov podivi...@chromium.org Unreviewed, gardening, more svg fixes. Mark svg/custom/absolute-sized-content-with-resources.xhtml as IMAGE+TEXT and rebaseline svg/carto.net/slider-expected.png. * platform/chromium-linux/svg/carto.net/slider-expected.png: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-linux/svg/carto.net/slider-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (107252 => 107253) --- trunk/LayoutTests/ChangeLog 2012-02-09 17:09:44 UTC (rev 107252) +++ trunk/LayoutTests/ChangeLog 2012-02-09 17:11:06 UTC (rev 107253) @@ -1,5 +1,15 @@ 2012-02-09 Pavel Podivilov podivi...@chromium.org +Unreviewed, gardening, more svg fixes. + +Mark svg/custom/absolute-sized-content-with-resources.xhtml as IMAGE+TEXT and +rebaseline svg/carto.net/slider-expected.png. + +* platform/chromium-linux/svg/carto.net/slider-expected.png: +* platform/chromium/test_expectations.txt: + +2012-02-09 Pavel Podivilov podivi...@chromium.org + Unreviewed, update chromium svg expectations after r107207. * platform/chromium-linux-x86/svg/custom/repaint-stroke-width-changes-expected.png: Removed. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107252 => 107253) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-09 17:09:44 UTC (rev 107252) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-09 17:11:06 UTC (rev 107253) @@ -2098,7 +2098,7 @@ // Regressions from r65229 BUGWK43912 LINUX WIN : svg/custom/grayscale-gradient-mask.svg = CRASH IMAGE -BUGWK43912 LINUX WIN : svg/custom/absolute-sized-content-with-resources.xhtml = IMAGE +BUGWK43912 LINUX WIN : svg/custom/absolute-sized-content-with-resources.xhtml = IMAGE IMAGE+TEXT // Times out frequently since the test was added BUGCR52017 LINUX MAC RELEASE : http/tests/misc/isindex-with-no-form.html = PASS TIMEOUT Modified: trunk/LayoutTests/platform/chromium-linux/svg/carto.net/slider-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107048] trunk/LayoutTests
Title: [107048] trunk/LayoutTests Revision 107048 Author podivi...@chromium.org Date 2012-02-08 00:37:01 -0800 (Wed, 08 Feb 2012) Log Message 2012-02-08 Pavel Podivilov podivi...@chromium.org Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (107047 => 107048) --- trunk/LayoutTests/ChangeLog 2012-02-08 08:29:22 UTC (rev 107047) +++ trunk/LayoutTests/ChangeLog 2012-02-08 08:37:01 UTC (rev 107048) @@ -1,3 +1,9 @@ +2012-02-08 Pavel Podivilov podivi...@chromium.org + +Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt. + +* platform/chromium/test_expectations.txt: + 2012-02-08 Dominic Mazzoni dmazz...@google.com Unreviewed, skipping test that times out or crashes on most platforms. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107047 => 107048) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-08 08:29:22 UTC (rev 107047) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-08 08:37:01 UTC (rev 107048) @@ -3951,7 +3951,6 @@ BUGWK77310 : fast/js/navigator-language.html = PASS TEXT BUGWK77314 WIN MAC : fast/events/touch/send-oncancel-event.html = PASS TEXT -BUGWK77315 WIN MAC : fast/events/touch/touch-gesture-scroll.html = PASS TEXT BUGWK77324 WIN MAC DEBUG SLOW : fast/js/dfg-int32array.html = PASS BUGWK77397 : plugins/crash-restoring-plugin-page-from-page-cache.html = TIMEOUT TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107078] trunk/LayoutTests
Title: [107078] trunk/LayoutTests Revision 107078 Author podivi...@chromium.org Date 2012-02-08 05:00:54 -0800 (Wed, 08 Feb 2012) Log Message 2012-02-08 Pavel Podivilov podivi...@chromium.org Unreviewed, repaint-on-image-bounds-change.svg still has wrong image in chromium. https://bugs.webkit.org/show_bug.cgi?id=78084 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (107077 => 107078) --- trunk/LayoutTests/ChangeLog 2012-02-08 12:59:38 UTC (rev 107077) +++ trunk/LayoutTests/ChangeLog 2012-02-08 13:00:54 UTC (rev 107078) @@ -1,3 +1,10 @@ +2012-02-08 Pavel Podivilov podivi...@chromium.org + +Unreviewed, repaint-on-image-bounds-change.svg still has wrong image in chromium. +https://bugs.webkit.org/show_bug.cgi?id=78084 + +* platform/chromium/test_expectations.txt: + 2012-02-08 Philippe Normand pnorm...@igalia.com Unreviewed, GTK rebaseline and skipping 2 new failing tests. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107077 => 107078) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-08 12:59:38 UTC (rev 107077) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-08 13:00:54 UTC (rev 107078) @@ -4065,3 +4065,5 @@ BUGWK78038 DEBUG : compositing/iframes/invisible-nested-iframe-show.html = PASS CRASH BUGWK78038 DEBUG : compositing/iframes/layout-on-compositing-change.html = PASS CRASH + +BUGWK78084 : svg/custom/repaint-on-image-bounds-change.svg = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107080] trunk/LayoutTests
Title: [107080] trunk/LayoutTests Revision 107080 Author podivi...@chromium.org Date 2012-02-08 06:02:21 -0800 (Wed, 08 Feb 2012) Log Message Unreviewed, update chromium svg expectations after r107067. * platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feImage-change-target-id-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feImage-remove-target-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feImage-target-property-change-expected.png: Added. * platform/chromium-mac-snowleopard/svg/filters/feImage-target-style-change-expected.png: Added. * platform/chromium-win/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added. * platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png: Added. * platform/chromium-win/svg/filters/feImage-multiple-targets-id-change-expected.png: Added. * platform/chromium-win/svg/filters/feImage-target-attribute-change-expected.png: Added. * platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added. * platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added. * platform/chromium-win/svg/filters/feImage-target-inline-style-change-expected.png: Added. * platform/chromium-win/svg/filters/feImage-target-property-change-expected.png: Added. * platform/chromium-win/svg/filters/feImage-target-style-change-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-change-target-id-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-remove-target-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-property-change-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feImage-target-style-change-expected.png trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-animated-transform-on-target-rect-expected.png trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-multiple-targets-id-change-expected.png trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-attribute-change-expected.png trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-inline-style-change-expected.png trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-property-change-expected.png trunk/LayoutTests/platform/chromium-win/svg/filters/feImage-target-style-change-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (107079 => 107080) --- trunk/LayoutTests/ChangeLog 2012-02-08 13:22:33 UTC (rev 107079) +++ trunk/LayoutTests/ChangeLog 2012-02-08 14:02:21 UTC (rev 107080) @@ -1,5 +1,31 @@ 2012-02-08 Pavel Podivilov podivi...@chromium.org +Unreviewed, update chromium svg expectations after r107067. + +* platform/chromium-li
[webkit-changes] [107081] trunk/LayoutTests
Title: [107081] trunk/LayoutTests Revision 107081 Author podivi...@chromium.org Date 2012-02-08 06:06:04 -0800 (Wed, 08 Feb 2012) Log Message 2012-02-08 Pavel Podivilov podivi...@chromium.org Unreviewed, chromium expectations update: mark repaint-on-image-bounds-change.svg as IMAGE+TEXT IMAGE. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (107080 => 107081) --- trunk/LayoutTests/ChangeLog 2012-02-08 14:02:21 UTC (rev 107080) +++ trunk/LayoutTests/ChangeLog 2012-02-08 14:06:04 UTC (rev 107081) @@ -1,5 +1,11 @@ 2012-02-08 Pavel Podivilov podivi...@chromium.org +Unreviewed, chromium expectations update: mark repaint-on-image-bounds-change.svg as IMAGE+TEXT IMAGE. + +* platform/chromium/test_expectations.txt: + +2012-02-08 Pavel Podivilov podivi...@chromium.org + Unreviewed, update chromium svg expectations after r107067. * platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png: Added. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107080 => 107081) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-08 14:02:21 UTC (rev 107080) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-08 14:06:04 UTC (rev 107081) @@ -4046,7 +4046,7 @@ BUGWK78084 : svg/custom/SVGPoint-matrixTransform.svg = IMAGE+TEXT BUGWK78084 : svg/custom/getTransformToElement.svg = IMAGE+TEXT BUGWK78084 : svg/custom/polyline-setattribute-points-null.svg = IMAGE+TEXT -BUGWK78084 : svg/custom/repaint-on-image-bounds-change.svg = IMAGE+TEXT +BUGWK78084 : svg/custom/repaint-on-image-bounds-change.svg = IMAGE+TEXT IMAGE BUGWK78084 : svg/custom/text-ctm.svg = IMAGE+TEXT BUGWK78084 : svg/custom/text-hit-test.svg = IMAGE+TEXT @@ -4065,5 +4065,3 @@ BUGWK78038 DEBUG : compositing/iframes/invisible-nested-iframe-show.html = PASS CRASH BUGWK78038 DEBUG : compositing/iframes/layout-on-compositing-change.html = PASS CRASH - -BUGWK78084 : svg/custom/repaint-on-image-bounds-change.svg = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107084] trunk/LayoutTests
Title: [107084] trunk/LayoutTests Revision 107084 Author podivi...@chromium.org Date 2012-02-08 06:57:37 -0800 (Wed, 08 Feb 2012) Log Message Unreviewed, add chromium expectations for fast/forms/select-overflow-scroll* tests. * platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png: Added. * platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt: Added. * platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png: Added. * platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt: Added. * platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.png: Added. * platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.txt: Added. * platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added. * platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.txt: Added. * platform/chromium-win/fast/forms/select-overflow-scroll-expected.png: Added. * platform/chromium-win/fast/forms/select-overflow-scroll-expected.txt: Added. * platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png: Added. * platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.txt trunk/LayoutTests/platform/chromium-win/fast/forms/select-overflow-scroll-expected.png trunk/LayoutTests/platform/chromium-win/fast/forms/select-overflow-scroll-expected.txt trunk/LayoutTests/platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png trunk/LayoutTests/platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (107083 => 107084) --- trunk/LayoutTests/ChangeLog 2012-02-08 14:49:26 UTC (rev 107083) +++ trunk/LayoutTests/ChangeLog 2012-02-08 14:57:37 UTC (rev 107084) @@ -1,3 +1,20 @@ +2012-02-08 Pavel Podivilov podivi...@chromium.org + +Unreviewed, add chromium expectations for fast/forms/select-overflow-scroll* tests. + +* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png: Added. +* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt: Added. +* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png: Added. +* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt: Added. +* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.png: Added. +* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.txt: Added. +* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added. +* platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.txt: Added. +* platform/chromium-win/fast/forms/select-overflow-scroll-expected.png: Added. +* platform/chromium-win/fast/forms/select-overflow-scroll-expected.txt: Added. +* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png: Added. +* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added. + 2012-02-08 Kaustubh Atrawalkar kaust...@motorola.com Migrate createObjectURL revokeObjectURL to static (Class) methods. Added: trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt (0 => 107084) --- trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt 2012-02-08 14:57:37 UTC (rev 107084) @@ -0,0 +1,8 @@ +layer at (0,0) size 800x600 + RenderView at (0,0) size 800x600 +layer at (0,0
[webkit-changes] [105707] trunk/Source/WebCore
Title: [105707] trunk/Source/WebCore
Revision 105707
Author podivi...@chromium.org
Date 2012-01-24 01:25:38 -0800 (Tue, 24 Jan 2012)
Log Message
Web Inspector: fix sticky DOM breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=64437
Reviewed by Yury Semikhatsky.
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (105706 => 105707)
--- trunk/Source/WebCore/ChangeLog 2012-01-24 09:19:50 UTC (rev 105706)
+++ trunk/Source/WebCore/ChangeLog 2012-01-24 09:25:38 UTC (rev 105707)
@@ -1,3 +1,13 @@
+2012-01-23 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix sticky DOM breakpoints.
+https://bugs.webkit.org/show_bug.cgi?id=64437
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DOMBreakpointsSidebarPane.js:
+(WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
+
2012-01-24 Gregg Tavares g...@google.com
Expose WebGL texture compression methods on WebGLRenderingContext
Modified: trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js (105706 => 105707)
--- trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js 2012-01-24 09:19:50 UTC (rev 105706)
+++ trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js 2012-01-24 09:25:38 UTC (rev 105707)
@@ -60,6 +60,7 @@
WebInspector.DOMBreakpointsSidebarPane.prototype = {
_inspectedURLChanged: function(event)
{
+this._breakpointElements = {};
this._reset();
var url = ""
this._inspectedURL = url.removeURLFragment();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104808] trunk
Title: [104808] trunk
Revision 104808
Author podivi...@chromium.org
Date 2012-01-12 03:54:41 -0800 (Thu, 12 Jan 2012)
Log Message
Web Inspector: make source urls relative to source map url.
https://bugs.webkit.org/show_bug.cgi?id=75968
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._canonicalizeURL):
LayoutTests:
* http/tests/inspector/compiler-source-mapping.html:
* http/tests/inspector/resources/source-map.json:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html
trunk/LayoutTests/http/tests/inspector/resources/source-map.json
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
Diff
Modified: trunk/LayoutTests/ChangeLog (104807 => 104808)
--- trunk/LayoutTests/ChangeLog 2012-01-12 11:52:19 UTC (rev 104807)
+++ trunk/LayoutTests/ChangeLog 2012-01-12 11:54:41 UTC (rev 104808)
@@ -1,3 +1,13 @@
+2012-01-10 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: make source urls relative to source map url.
+https://bugs.webkit.org/show_bug.cgi?id=75968
+
+Reviewed by Yury Semikhatsky.
+
+* http/tests/inspector/compiler-source-mapping.html:
+* http/tests/inspector/resources/source-map.json:
+
2012-01-12 Shinya Kawanaka shin...@google.com
ShadowContentElement should be able to use query.
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html (104807 => 104808)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2012-01-12 11:52:19 UTC (rev 104807)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2012-01-12 11:54:41 UTC (rev 104808)
@@ -119,7 +119,7 @@
function testResolveSourceMappingURL(next)
{
-var func = WebInspector.ClosureCompilerSourceMapping.prototype._resolveSourceMapURL;
+var func = WebInspector.ClosureCompilerSourceMapping.prototype._canonicalizeURL;
InspectorTest.assertEquals(http://example.com/map.json, func(http://example.com/map.json, http://example.com/script.js));
InspectorTest.assertEquals(http://example.com/map.json, func(/map.json, http://example.com/script.js));
InspectorTest.assertEquals(http://example.com/scripts/../maps/map.json, func(../maps/map.json, http://example.com/scripts/script.js));
Modified: trunk/LayoutTests/http/tests/inspector/resources/source-map.json (104807 => 104808)
--- trunk/LayoutTests/http/tests/inspector/resources/source-map.json 2012-01-12 11:52:19 UTC (rev 104807)
+++ trunk/LayoutTests/http/tests/inspector/resources/source-map.json 2012-01-12 11:54:41 UTC (rev 104808)
@@ -1,7 +1,7 @@
{
version:3,
file:compiled.js,
-sourceRoot: http://localhost:8000/inspector/resources,
+sourceRoot: ,
lineCount:2,
mappings:AACAA,MAAAC,iBAAuB,CAAC,MAAD,CAAS,QAAQ,EACxC,CACI,IAAIC,EAASC,QAAAC,cAAsB,CAAC,QAAD,CACnCF,EAAAG,GAAA,CAAY,MACZH,EAAAD,iBAAuB,CAAC,OAAD,CAAUK,WAAV,CAAuB,CAAA,CAAvB,CACvBH,SAAAI,KAAAC,YAAyB,CAACN,CAAD,CAErBO,E,CAAMN,QAAAC,cAAsB,CAAC,KAAD,CAChCK,EAAAJ,GAAA,CAAS,ocACTF;QAAAI,KAAAC,YAAyB,CAACC,CAAD,CAR7B,CADuB,CAYvBH,SAASA,YAAW,CAACI,CAAD,CACpB,CAEIC,CAD8BC,IAAZC,YAClBF,QAAc,CAACD,CAAD,CAFlB,C,CCbAG,QAASA,aAAY,EACrB,EAGAA,YAAAC,UAAAH,OAAA,CAAgCI,QAAQ,EACxC,CACIC,OAAAC,IAAW,CAAC,iBAAD,CADf;,
sources:[source1.js,source2.js],
Modified: trunk/Source/WebCore/ChangeLog (104807 => 104808)
--- trunk/Source/WebCore/ChangeLog 2012-01-12 11:52:19 UTC (rev 104807)
+++ trunk/Source/WebCore/ChangeLog 2012-01-12 11:54:41 UTC (rev 104808)
@@ -1,3 +1,15 @@
+2012-01-10 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: make source urls relative to source map url.
+https://bugs.webkit.org/show_bug.cgi?id=75968
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/CompilerSourceMapping.js:
+(WebInspector.ClosureCompilerSourceMapping):
+(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
+(WebInspector.ClosureCompilerSourceMapping.prototype._canonicalizeURL):
+
2012-01-12 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Fix WebKit build after r104803, by setting ScriptCallStack.h role to private.
Modified: trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js (104807 => 104808)
--- trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js 2012-01-12 11:52:19 UTC (rev 104807)
+++ trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js 2012-01-12 11:54:41 UTC (rev 104808)
@@ -83,7 +83,7 @@
WebInspector.ClosureCompilerSourceMapping.prototype._base64Map[base64Digits.charAt(i)] = i;
}
-this._sourceMappingURL = this._resolveSourceMapURL(sourceMappingURL, scr
[webkit-changes] [104831] trunk
Title: [104831] trunk
Revision 104831
Author podivi...@chromium.org
Date 2012-01-12 09:06:51 -0800 (Thu, 12 Jan 2012)
Log Message
Web Inspector: [JSC] //@ sourceURL is not respected.
https://bugs.webkit.org/show_bug.cgi?id=65532
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/debugger/source-url-comment.html
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::findMagicComment):
(WebCore::ContentSearchUtils::findSourceURL):
(WebCore::ContentSearchUtils::findSourceMapURL):
* inspector/ContentSearchUtils.h:
LayoutTests:
* inspector/debugger/source-url-comment-expected.txt: Added.
* inspector/debugger/source-url-comment.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp
trunk/Source/WebCore/inspector/ContentSearchUtils.cpp
trunk/Source/WebCore/inspector/ContentSearchUtils.h
Added Paths
trunk/LayoutTests/inspector/debugger/source-url-comment-expected.txt
trunk/LayoutTests/inspector/debugger/source-url-comment.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104830 => 104831)
--- trunk/LayoutTests/ChangeLog 2012-01-12 16:42:38 UTC (rev 104830)
+++ trunk/LayoutTests/ChangeLog 2012-01-12 17:06:51 UTC (rev 104831)
@@ -1,3 +1,13 @@
+2012-01-12 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: [JSC] //@ sourceURL is not respected.
+https://bugs.webkit.org/show_bug.cgi?id=65532
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/source-url-comment-expected.txt: Added.
+* inspector/debugger/source-url-comment.html: Added.
+
2012-01-12 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r104805.
Added: trunk/LayoutTests/inspector/debugger/source-url-comment-expected.txt (0 => 104831)
--- trunk/LayoutTests/inspector/debugger/source-url-comment-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/debugger/source-url-comment-expected.txt 2012-01-12 17:06:51 UTC (rev 104831)
@@ -0,0 +1,9 @@
+Tests that evals with sourceURL comment are shown in scripts panel.
+
+Debugger was enabled.
+
+Running: testSourceURLComment
+function keepAlive() {}
+//@ sourceURL=evalURL.js
+Debugger was disabled.
+
Property changes on: trunk/LayoutTests/inspector/debugger/source-url-comment-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/inspector/debugger/source-url-comment.html (0 => 104831)
--- trunk/LayoutTests/inspector/debugger/source-url-comment.html (rev 0)
+++ trunk/LayoutTests/inspector/debugger/source-url-comment.html 2012-01-12 17:06:51 UTC (rev 104831)
@@ -0,0 +1,37 @@
+html
+head
+script src=""
+script src=""
+
+script
+
+function doEval()
+{
+eval(function keepAlive() {}\n//@ sourceURL=evalURL.js);
+}
+
+function test()
+{
+InspectorTest.runDebuggerTestSuite([
+function testSourceURLComment(next)
+{
+InspectorTest.showScriptSource(evalURL.js, didShowScriptSource);
+InspectorTest.evaluateInPage(setTimeout(doEval, 0));
+
+function didShowScriptSource(sourceFrame)
+{
+InspectorTest.addResult(sourceFrame.textModel.text);
+next();
+}
+}
+]);
+};
+
+/script
+
+/head
+
+body _onload_=runTest()
+pTests that evals with sourceURL comment are shown in scripts panel./p
+/body
+/html
Property changes on: trunk/LayoutTests/inspector/debugger/source-url-comment.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (104830 => 104831)
--- trunk/Source/WebCore/ChangeLog 2012-01-12 16:42:38 UTC (rev 104830)
+++ trunk/Source/WebCore/ChangeLog 2012-01-12 17:06:51 UTC (rev 104831)
@@ -1,3 +1,20 @@
+2012-01-12 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: [JSC] //@ sourceURL is not respected.
+https://bugs.webkit.org/show_bug.cgi?id=65532
+
+Reviewed by Pavel Feldman.
+
+Test: inspector/debugger/source-url-comment.html
+
+* bindings/js/ScriptDebugServer.cpp:
+(WebCore::ScriptDebugServer::dispatchDidParseSource):
+* inspector/ContentSearchUtils.cpp:
+(WebCore::ContentSearchUtils::findMagicComment):
+(WebCore::ContentSearchUtils::findSourceURL):
+(WebCore::ContentSearchUtils::findSourceMapURL):
+* inspector/ContentSearchUtils.h:
+
2012-01-12 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed trivial buildfix after r104828.
Modified: trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp (104830 => 104831)
--- trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp 2012-01-12 16:42:38 UTC (rev 104830)
+++ trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp
[webkit-changes] [103795] trunk
Title: [103795] trunk
Revision 103795
Author podivi...@chromium.org
Date 2011-12-29 04:16:05 -0800 (Thu, 29 Dec 2011)
Log Message
Web Inspector: add enable source maps checkbox setting.
https://bugs.webkit.org/show_bug.cgi?id=75311
Reviewed by Pavel Feldman.
Source/WebCore:
When enable source maps is on, all auto detected source maps are silently applied.
* English.lproj/localizedStrings.js:
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
* inspector/front-end/inspector.js:
(WebInspector._toolbarItemClicked):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-debug-expected.txt:
* http/tests/inspector/compiler-source-mapping-debug.html:
* inspector/debugger/raw-source-code.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/SettingsScreen.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/LayoutTests/ChangeLog (103794 => 103795)
--- trunk/LayoutTests/ChangeLog 2011-12-29 11:21:20 UTC (rev 103794)
+++ trunk/LayoutTests/ChangeLog 2011-12-29 12:16:05 UTC (rev 103795)
@@ -1,3 +1,14 @@
+2011-12-28 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: add enable source maps checkbox setting.
+https://bugs.webkit.org/show_bug.cgi?id=75311
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-source-mapping-debug-expected.txt:
+* http/tests/inspector/compiler-source-mapping-debug.html:
+* inspector/debugger/raw-source-code.html:
+
2011-12-28 Alexis Menard alexis.men...@openbossa.org
getComputedStyle for border-color is not implemented.
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt (103794 => 103795)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt 2011-12-29 11:21:20 UTC (rev 103794)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt 2011-12-29 12:16:05 UTC (rev 103795)
@@ -5,6 +5,7 @@
Debugger was enabled.
Running: testSetBreakpoint
+Page reloaded.
Script source was shown.
Script execution paused.
Call stack:
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html (103794 => 103795)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html 2011-12-29 11:21:20 UTC (rev 103794)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html 2011-12-29 12:16:05 UTC (rev 103795)
@@ -13,21 +13,29 @@
function test()
{
+WebInspector.OriginalScript = WebInspector.Script;
+WebInspector.Script = function()
+{
+WebInspector.OriginalScript.apply(this, arguments);
+if (this.sourceURL.indexOf(compiled.js) !== -1)
+this.sourceMapURL = http://localhost:8000/inspector/resources/source-map.json;
+}
+WebInspector.Script.prototype = WebInspector.OriginalScript.prototype;
+
InspectorTest.runDebuggerTestSuite([
function testSetBreakpoint(next)
{
-InspectorTest.showScriptSource(compiled.js, didShowCompiled);
+WebInspector.settings.sourceMapsEnabled.set(true);
+InspectorTest.reloadPage(pageReloaded);
-function didShowCompiled(sourceFrame)
+function pageReloaded()
{
-InspectorTest.addResult(Script source was shown.);
-sourceFrame._uiSourceCode.sourceMapURL = http://localhost:8000/inspector/resources/source-map.json;
-sourceFrame._model.installCompilerSourceMapping(sourceFrame._uiSourceCode);
-InspectorTest.showScriptSource(source1.js, didShowSource1);
+InspectorTest.showScriptSource(source1.js, didS
[webkit-changes] [103805] trunk
Title: [103805] trunk
Revision 103805
Author podivi...@chromium.org
Date 2011-12-29 09:12:45 -0800 (Thu, 29 Dec 2011)
Log Message
Web Inspector: support sourceMappingURL magic comment.
https://bugs.webkit.org/show_bug.cgi?id=75356
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::findSourceMapURL):
* inspector/ContentSearchUtils.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-debug.html:
* http/tests/inspector/resources/compiled.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html
trunk/LayoutTests/http/tests/inspector/resources/compiled.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/ContentSearchUtils.cpp
trunk/Source/WebCore/inspector/ContentSearchUtils.h
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (103804 => 103805)
--- trunk/LayoutTests/ChangeLog 2011-12-29 17:08:05 UTC (rev 103804)
+++ trunk/LayoutTests/ChangeLog 2011-12-29 17:12:45 UTC (rev 103805)
@@ -1,3 +1,13 @@
+2011-12-29 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: support sourceMappingURL magic comment.
+https://bugs.webkit.org/show_bug.cgi?id=75356
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-source-mapping-debug.html:
+* http/tests/inspector/resources/compiled.js:
+
2011-12-23 Alexander Pavlov apav...@chromium.org
Web Inspector: Implement CSS selector profiler
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html (103804 => 103805)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html 2011-12-29 17:08:05 UTC (rev 103804)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html 2011-12-29 17:12:45 UTC (rev 103805)
@@ -13,15 +13,6 @@
function test()
{
-WebInspector.OriginalScript = WebInspector.Script;
-WebInspector.Script = function()
-{
-WebInspector.OriginalScript.apply(this, arguments);
-if (this.sourceURL.indexOf(compiled.js) !== -1)
-this.sourceMapURL = http://localhost:8000/inspector/resources/source-map.json;
-}
-WebInspector.Script.prototype = WebInspector.OriginalScript.prototype;
-
InspectorTest.runDebuggerTestSuite([
function testSetBreakpoint(next)
{
Modified: trunk/LayoutTests/http/tests/inspector/resources/compiled.js (103804 => 103805)
--- trunk/LayoutTests/http/tests/inspector/resources/compiled.js 2011-12-29 17:08:05 UTC (rev 103804)
+++ trunk/LayoutTests/http/tests/inspector/resources/compiled.js 2011-12-29 17:12:45 UTC (rev 103805)
@@ -1,2 +1,3 @@
window.addEventListener(load,function(){var a=document.createElement(button);a.id=test;a.addEventListener(click,handleClick,!0);document.body.appendChild(a);a=document.createElement(div);a.id=ba;
document.body.appendChild(a)});function handleClick(a){(new ClickHandler).handle(a)};function ClickHandler(){}ClickHandler.prototype.handle=function(){console.log(button clicked!)};
+//@ sourceMappingURL=source-map.json
Modified: trunk/Source/WebCore/ChangeLog (103804 => 103805)
--- trunk/Source/WebCore/ChangeLog 2011-12-29 17:08:05 UTC (rev 103804)
+++ trunk/Source/WebCore/ChangeLog 2011-12-29 17:12:45 UTC (rev 103805)
@@ -1,3 +1,16 @@
+2011-12-29 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: support sourceMappingURL magic comment.
+https://bugs.webkit.org/show_bug.cgi?id=75356
+
+Reviewed by Pavel Feldman.
+
+* inspector/ContentSearchUtils.cpp:
+(WebCore::ContentSearchUtils::findSourceMapURL):
+* inspector/ContentSearchUtils.h:
+* inspector/InspectorDebuggerAgent.cpp:
+(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
+
2011-12-29 Alexander Pavlov apav...@chromium.org
Web Inspector: Suggest pop-over doesn't hide on tab switch
Modified: trunk/Source/WebCore/inspector/ContentSearchUtils.cpp (103804 => 103805)
--- trunk/Source/WebCore/inspector/ContentSearchUtils.cpp 2011-12-29 17:08:05 UTC (rev 103804)
+++ trunk/Source/WebCore/inspector/ContentSearchUtils.cpp 2011-12-29 17:12:45 UTC (rev 103805)
@@ -34,6 +34,9 @@
#include InspectorValues.h
#include RegularExpression.h
+#include wtf/BumpPointerAllocator.h
+#include yarr/Yarr.h
+
using namespace st
[webkit-changes] [103532] trunk
Title: [103532] trunk
Revision 103532
Author podivi...@chromium.org
Date 2011-12-22 05:08:26 -0800 (Thu, 22 Dec 2011)
Log Message
Web Inspector: auto detect source map url.
https://bugs.webkit.org/show_bug.cgi?id=74088
Reviewed by Pavel Feldman.
Source/WebCore:
Check to see if X-SourceMap HTTP response header was sent with script resource.
Header value will be used as auto suggestion for source map url in UI.
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
* inspector/front-end/Script.js:
(WebInspector.Script):
LayoutTests:
* inspector/debugger/raw-source-code.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h
trunk/Source/WebCore/inspector/front-end/DebuggerModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/Script.js
Diff
Modified: trunk/LayoutTests/ChangeLog (103531 => 103532)
--- trunk/LayoutTests/ChangeLog 2011-12-22 13:02:36 UTC (rev 103531)
+++ trunk/LayoutTests/ChangeLog 2011-12-22 13:08:26 UTC (rev 103532)
@@ -1,3 +1,12 @@
+2011-12-09 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: auto detect source map url.
+https://bugs.webkit.org/show_bug.cgi?id=74088
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/raw-source-code.html:
+
2011-12-22 Philippe Normand pnorm...@igalia.com
Unreviewed, unskip html5lib/runner.html now passing fine on GTK!
Modified: trunk/Source/WebCore/ChangeLog (103531 => 103532)
--- trunk/Source/WebCore/ChangeLog 2011-12-22 13:02:36 UTC (rev 103531)
+++ trunk/Source/WebCore/ChangeLog 2011-12-22 13:08:26 UTC (rev 103532)
@@ -1,3 +1,26 @@
+2011-12-09 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: auto detect source map url.
+https://bugs.webkit.org/show_bug.cgi?id=74088
+
+Reviewed by Pavel Feldman.
+
+Check to see if X-SourceMap HTTP response header was sent with script resource.
+Header value will be used as auto suggestion for source map url in UI.
+
+* inspector/Inspector.json:
+* inspector/InspectorDebuggerAgent.cpp:
+(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
+(WebCore::InspectorDebuggerAgent::didParseSource):
+* inspector/InspectorDebuggerAgent.h:
+* inspector/front-end/DebuggerModel.js:
+(WebInspector.DebuggerModel.prototype._parsedScriptSource):
+(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
+* inspector/front-end/RawSourceCode.js:
+(WebInspector.RawSourceCode):
+* inspector/front-end/Script.js:
+(WebInspector.Script):
+
2011-12-22 Kentaro Hara hara...@chromium.org
Change the build flow of AppleWebKit to use the [Supplemental] IDL
Modified: trunk/Source/WebCore/inspector/Inspector.json (103531 => 103532)
--- trunk/Source/WebCore/inspector/Inspector.json 2011-12-22 13:02:36 UTC (rev 103531)
+++ trunk/Source/WebCore/inspector/Inspector.json 2011-12-22 13:08:26 UTC (rev 103532)
@@ -2058,7 +2058,8 @@
{ name: startColumn, type: integer, description: Column offset of the script within the resource with given URL. },
{ name: endLine, type: integer, description: Last line of the script. },
{ name: endColumn, type: integer, description: Length of the last line of the script. },
-{ name: isContentScript, type: boolean, optional: true, description: Determines whether this script is a user extension script. }
+{ name: isContentScript, type: boolean, optional: true, description: Determines whether this script is a user extension script. },
+{ name: sourceMapURL, type: string, optional: true, description: URL of source map associated with script (if any). }
],
description: Fired when virtual machine parses script. This event is also fired for all known and uncollected scripts upon enabling debugger.
},
Modified: trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp (103531 => 103532)
--- trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp 2011-12-22 13:02:36 UTC (rev 103531)
+++ trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp 2011-12-22 13:08:26 UTC (rev 103532)
@@ -35,6 +35,7 @@
#include InjectedScript.h
#include InjectedScriptManager.h
#include InspectorFrontend
[webkit-changes] [103534] trunk
Title: [103534] trunk
Revision 103534
Author podivi...@chromium.org
Date 2011-12-22 05:21:52 -0800 (Thu, 22 Dec 2011)
Log Message
Web Inspector: fix source map url resolving.
https://bugs.webkit.org/show_bug.cgi?id=74305
Reviewed by Pavel Feldman.
Source/WebCore:
Also fix the bug with repeated source urls in mapping sections.
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.sources):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._resolveSourceMapURL):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.installCompilerSourceMapping):
* inspector/front-end/utilities.js:
(String.prototype.asParsedURL):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-expected.txt:
* http/tests/inspector/compiler-source-mapping.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: trunk/LayoutTests/ChangeLog (103533 => 103534)
--- trunk/LayoutTests/ChangeLog 2011-12-22 13:10:59 UTC (rev 103533)
+++ trunk/LayoutTests/ChangeLog 2011-12-22 13:21:52 UTC (rev 103534)
@@ -1,3 +1,13 @@
+2011-12-12 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix source map url resolving.
+https://bugs.webkit.org/show_bug.cgi?id=74305
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-source-mapping-expected.txt:
+* http/tests/inspector/compiler-source-mapping.html:
+
2011-12-22 Csaba Osztrogonác o...@webkit.org
XSLT-created HTML documents do not inherit first party for cookies from originally loaded XML.
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt (103533 => 103534)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt 2011-12-22 13:10:59 UTC (rev 103533)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt 2011-12-22 13:21:52 UTC (rev 103534)
@@ -9,5 +9,7 @@
Running: testSections
+Running: testResolveSourceMappingURL
+
Running: testLoad
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html (103533 => 103534)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2011-12-22 13:10:59 UTC (rev 103533)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2011-12-22 13:21:52 UTC (rev 103534)
@@ -97,7 +97,7 @@
offset: { line: 1, column: 0 },
map: {
mappings:,CAEC,
-sources:[source1.js]
+sources:[source1.js, source2.js]
}
}, {
offset: { line: 3, column: 10 },
@@ -109,6 +109,7 @@
]};
var mapping = new WebInspector.ClosureCompilerSourceMapping();
mapping._parseMappingPayload(mappingPayload);
+InspectorTest.assertEquals(2, mapping.sources().length);
checkMapping(0, 0, source1.js, 0, 0, mapping);
checkMapping(0, 1, source1.js, 2, 1, mapping);
checkMapping(2, 10, source2.js, 0, 0, mapping);
@@ -116,6 +117,15 @@
next();
},
+function testResolveSourceMappingURL(next)
+{
+var func = WebInspector.ClosureCompilerSourceMapping.prototype._resolveSourceMapURL;
+InspectorTest.assertEquals(http://example.com/map.json, func(http://example.com/map.json, http://example.com/script.js));
+InspectorTest.assertEquals(http://example.com/map.json, func(/map.json, http://example.com/script.js));
+InspectorTest.assertEquals(http://example.com/scripts/../maps/map.json, func(../maps/map.json, http://example.com/scripts/script.js));
+next();
+},
+
function testLoad(next)
{
var sourceMapping = new WebInspector.ClosureCompilerSourceMapping(http://localhost:8000/inspector/resources/source-map.json);
Modified: trunk/Source/WebCore/ChangeLog (103533 => 103534)
--- trunk/Source/WebCore/ChangeLog 2011-12-22 13:10:59 UTC (rev 103533)
+++ trunk/Source/WebCore/ChangeLog 2011-12-22 13:21:52 UTC (rev 103534)
@@ -1,3 +1,22 @@
+2011-12-12 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix source map url resolving.
+https://bugs.webkit.org/show_bug.cgi?id=74305
+
+Reviewed by Pavel Feldman.
+
+Also fix the bug with repeated source urls in mapping sections.
+
+* inspect
[webkit-changes] [103541] trunk
Title: [103541] trunk
Revision 103541
Author podivi...@chromium.org
Date 2011-12-22 07:19:40 -0800 (Thu, 22 Dec 2011)
Log Message
Web Inspector: add install source map to JS source frame context menu.
https://bugs.webkit.org/show_bug.cgi?id=74181
Reviewed by Pavel Feldman.
Source/WebCore:
Add install source map to source frame context menu when source map url is auto detected.
* English.lproj/localizedStrings.js:
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping.prototype.load):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseSections):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.installCompilerSourceMapping):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector._javascript_SourceFrame.prototype.cancelEditing):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-debug.html:
* http/tests/inspector/compiler-source-mapping.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting.html:
* inspector/debugger/ui-source-code.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html
trunk/LayoutTests/inspector/debugger/scripts-panel.html
trunk/LayoutTests/inspector/debugger/scripts-sorting.html
trunk/LayoutTests/inspector/debugger/ui-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (103540 => 103541)
--- trunk/LayoutTests/ChangeLog 2011-12-22 15:02:00 UTC (rev 103540)
+++ trunk/LayoutTests/ChangeLog 2011-12-22 15:19:40 UTC (rev 103541)
@@ -1,3 +1,16 @@
+2011-12-22 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: add install source map to JS source frame context menu.
+https://bugs.webkit.org/show_bug.cgi?id=74181
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-source-mapping-debug.html:
+* http/tests/inspector/compiler-source-mapping.html:
+* inspector/debugger/scripts-panel.html:
+* inspector/debugger/scripts-sorting.html:
+* inspector/debugger/ui-source-code.html:
+
2011-12-22 Branimir Lambov blam...@google.com
SVG: filter race condition may prevent SVG elements from being re-drawn
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html (103540 => 103541)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html 2011-12-22 15:02:00 UTC (rev 103540)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html 2011-12-22 15:19:40 UTC (rev 103541)
@@ -13,7 +13,6 @@
function test()
{
-
InspectorTest.runDebuggerTestSuite([
function testSetBreakpoint(next)
{
@@ -22,9 +21,9 @@
function didShowCompiled(sourceFrame)
{
InspectorTest.addResult(Script source was shown.);
-sourceFrame._model.setCompilerSourceMapping(sourceFrame._uiSourceCode, http://localhost:8000/inspector/resources/source-map.json);
+sourceFrame._uiSourceCode.sourceMapURL = http://localhost:8000/inspector/resources/source-map.json;
+sourceFrame._model.installCompilerSourceMapping(sourceFrame._uiSourceCode);
InspectorTest.showScriptSource(source1.js, didShowSource1);
-
}
function didShowSource1(sourceFrame)
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html (103540 => 103541)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2011-12-22 15:02:00 UTC (rev 103540)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2011-12-22 15:19:40 UTC (rev 103541)
@@ -94,13 +94,13 @@
{
var mappingPayload = {
sections: [{
-offset: { line: 1, column: 0 },
+offset: { line: 0, column: 0 },
map: {
mappings:,CAEC,
sources:[s
[webkit-changes] [103405] trunk
Title: [103405] trunk
Revision 103405
Author podivi...@chromium.org
Date 2011-12-21 05:52:11 -0800 (Wed, 21 Dec 2011)
Log Message
Web Inspector: auto detect source map url.
https://bugs.webkit.org/show_bug.cgi?id=74088
Reviewed by Pavel Feldman.
Source/WebCore:
Check to see if X-SourceMap HTTP response header was sent with script resource.
Header value will be used as auto suggestion for source map url in UI.
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
* inspector/front-end/Script.js:
(WebInspector.Script):
LayoutTests:
* inspector/debugger/raw-source-code.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h
trunk/Source/WebCore/inspector/front-end/DebuggerModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/Script.js
Diff
Modified: trunk/LayoutTests/ChangeLog (103404 => 103405)
--- trunk/LayoutTests/ChangeLog 2011-12-21 13:48:36 UTC (rev 103404)
+++ trunk/LayoutTests/ChangeLog 2011-12-21 13:52:11 UTC (rev 103405)
@@ -1,3 +1,12 @@
+2011-12-09 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: auto detect source map url.
+https://bugs.webkit.org/show_bug.cgi?id=74088
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/raw-source-code.html:
+
2011-12-21 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed gardening. Update Qt specific expected results.
Modified: trunk/Source/WebCore/ChangeLog (103404 => 103405)
--- trunk/Source/WebCore/ChangeLog 2011-12-21 13:48:36 UTC (rev 103404)
+++ trunk/Source/WebCore/ChangeLog 2011-12-21 13:52:11 UTC (rev 103405)
@@ -1,3 +1,26 @@
+2011-12-09 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: auto detect source map url.
+https://bugs.webkit.org/show_bug.cgi?id=74088
+
+Reviewed by Pavel Feldman.
+
+Check to see if X-SourceMap HTTP response header was sent with script resource.
+Header value will be used as auto suggestion for source map url in UI.
+
+* inspector/Inspector.json:
+* inspector/InspectorDebuggerAgent.cpp:
+(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
+(WebCore::InspectorDebuggerAgent::didParseSource):
+* inspector/InspectorDebuggerAgent.h:
+* inspector/front-end/DebuggerModel.js:
+(WebInspector.DebuggerModel.prototype._parsedScriptSource):
+(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
+* inspector/front-end/RawSourceCode.js:
+(WebInspector.RawSourceCode):
+* inspector/front-end/Script.js:
+(WebInspector.Script):
+
2011-12-21 Pierre Rossi pierre.ro...@gmail.com
[Qt] Mobile theme refinements
Modified: trunk/Source/WebCore/inspector/Inspector.json (103404 => 103405)
--- trunk/Source/WebCore/inspector/Inspector.json 2011-12-21 13:48:36 UTC (rev 103404)
+++ trunk/Source/WebCore/inspector/Inspector.json 2011-12-21 13:52:11 UTC (rev 103405)
@@ -2058,7 +2058,8 @@
{ name: startColumn, type: integer, description: Column offset of the script within the resource with given URL. },
{ name: endLine, type: integer, description: Last line of the script. },
{ name: endColumn, type: integer, description: Length of the last line of the script. },
-{ name: isContentScript, type: boolean, optional: true, description: Determines whether this script is a user extension script. }
+{ name: isContentScript, type: boolean, optional: true, description: Determines whether this script is a user extension script. },
+{ name: sourceMapURL, type: string, optional: true, description: URL of source map associated with script (if any). }
],
description: Fired when virtual machine parses script. This event is also fired for all known and uncollected scripts upon enabling debugger.
},
Modified: trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp (103404 => 103405)
--- trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp 2011-12-21 13:48:36 UTC (rev 103404)
+++ trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp 2011-12-21 13:52:11 UTC (rev 103405)
@@ -35,6 +35,7 @@
#include InjectedScript.h
#include InjectedScriptManager.h
#include InspectorFrontend.h
+#include InspectorPageAgent.h
#include Insp
[webkit-changes] [103408] trunk
Title: [103408] trunk
Revision 103408
Author podivi...@chromium.org
Date 2011-12-21 07:48:44 -0800 (Wed, 21 Dec 2011)
Log Message
Web Inspector: fix source map url resolving.
https://bugs.webkit.org/show_bug.cgi?id=74305
Reviewed by Pavel Feldman.
Source/WebCore:
Also fix the bug with repeated source urls in mapping sections.
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.sources):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._resolveSourceMapURL):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.installCompilerSourceMapping):
* inspector/front-end/utilities.js:
(String.prototype.asParsedURL):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-expected.txt:
* http/tests/inspector/compiler-source-mapping.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: trunk/LayoutTests/ChangeLog (103407 => 103408)
--- trunk/LayoutTests/ChangeLog 2011-12-21 15:28:58 UTC (rev 103407)
+++ trunk/LayoutTests/ChangeLog 2011-12-21 15:48:44 UTC (rev 103408)
@@ -1,3 +1,13 @@
+2011-12-12 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix source map url resolving.
+https://bugs.webkit.org/show_bug.cgi?id=74305
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-source-mapping-expected.txt:
+* http/tests/inspector/compiler-source-mapping.html:
+
2011-12-21 Renata Hodovan r...@webkit.org
New renderer for SVGRectElement
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt (103407 => 103408)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt 2011-12-21 15:28:58 UTC (rev 103407)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt 2011-12-21 15:48:44 UTC (rev 103408)
@@ -9,5 +9,7 @@
Running: testSections
+Running: testResolveSourceMappingURL
+
Running: testLoad
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html (103407 => 103408)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2011-12-21 15:28:58 UTC (rev 103407)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2011-12-21 15:48:44 UTC (rev 103408)
@@ -97,7 +97,7 @@
offset: { line: 1, column: 0 },
map: {
mappings:,CAEC,
-sources:[source1.js]
+sources:[source1.js, source2.js]
}
}, {
offset: { line: 3, column: 10 },
@@ -109,6 +109,7 @@
]};
var mapping = new WebInspector.ClosureCompilerSourceMapping();
mapping._parseMappingPayload(mappingPayload);
+InspectorTest.assertEquals(2, mapping.sources().length);
checkMapping(0, 0, source1.js, 0, 0, mapping);
checkMapping(0, 1, source1.js, 2, 1, mapping);
checkMapping(2, 10, source2.js, 0, 0, mapping);
@@ -116,6 +117,15 @@
next();
},
+function testResolveSourceMappingURL(next)
+{
+var func = WebInspector.ClosureCompilerSourceMapping.prototype._resolveSourceMapURL;
+InspectorTest.assertEquals(http://example.com/map.json, func(http://example.com/map.json, http://example.com/script.js));
+InspectorTest.assertEquals(http://example.com/map.json, func(/map.json, http://example.com/script.js));
+InspectorTest.assertEquals(http://example.com/scripts/../maps/map.json, func(../maps/map.json, http://example.com/scripts/script.js));
+next();
+},
+
function testLoad(next)
{
var sourceMapping = new WebInspector.ClosureCompilerSourceMapping(http://localhost:8000/inspector/resources/source-map.json);
Modified: trunk/Source/WebCore/ChangeLog (103407 => 103408)
--- trunk/Source/WebCore/ChangeLog 2011-12-21 15:28:58 UTC (rev 103407)
+++ trunk/Source/WebCore/ChangeLog 2011-12-21 15:48:44 UTC (rev 103408)
@@ -1,3 +1,22 @@
+2011-12-12 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix source map url resolving.
+https://bugs.webkit.org/show_bug.cgi?id=74305
+
+Reviewed by Pavel Feldman.
+
+Also fix the bug with repeated source urls in mapping sections.
+
+* inspector/front-end/CompilerSour
[webkit-changes] [102003] trunk/Source/WebCore
Title: [102003] trunk/Source/WebCore
Revision 102003
Author podivi...@chromium.org
Date 2011-12-05 08:24:52 -0800 (Mon, 05 Dec 2011)
Log Message
Web Inspector: fix fronted compilation.
https://bugs.webkit.org/show_bug.cgi?id=73831
Reviewed by Yury Semikhatsky.
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMappingPayload):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (102002 => 102003)
--- trunk/Source/WebCore/ChangeLog 2011-12-05 16:17:51 UTC (rev 102002)
+++ trunk/Source/WebCore/ChangeLog 2011-12-05 16:24:52 UTC (rev 102003)
@@ -1,3 +1,13 @@
+2011-12-05 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix fronted compilation.
+https://bugs.webkit.org/show_bug.cgi?id=73831
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/CompilerSourceMapping.js:
+(WebInspector.ClosureCompilerSourceMappingPayload):
+
2011-12-05 Eric Carlson eric.carl...@apple.com
Out-of-band text tracks may only load from same origin as the media element's Document's origin
Modified: trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js (102002 => 102003)
--- trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js 2011-12-05 16:17:51 UTC (rev 102002)
+++ trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js 2011-12-05 16:24:52 UTC (rev 102003)
@@ -62,6 +62,7 @@
WebInspector.ClosureCompilerSourceMappingPayload = function()
{
this.mappings = ;
+this.sourceRoot = ;
this.sources = [];
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101359] trunk
Title: [101359] trunk
Revision 101359
Author podivi...@chromium.org
Date 2011-11-29 04:46:34 -0800 (Tue, 29 Nov 2011)
Log Message
Web Inspector: support concatenated source maps.
https://bugs.webkit.org/show_bug.cgi?id=73138
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.loadSourceCode):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappingPayload):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseSections):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._canonicalizeURL):
* inspector/front-end/inspector.js:
(WebInspector.installSourceMappingForTest):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-expected.txt:
* http/tests/inspector/compiler-source-mapping.html:
* http/tests/inspector/resources/source-map.json:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html
trunk/LayoutTests/http/tests/inspector/resources/source-map.json
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/LayoutTests/ChangeLog (101358 => 101359)
--- trunk/LayoutTests/ChangeLog 2011-11-29 12:40:45 UTC (rev 101358)
+++ trunk/LayoutTests/ChangeLog 2011-11-29 12:46:34 UTC (rev 101359)
@@ -1,3 +1,14 @@
+2011-11-25 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: support concatenated source maps.
+https://bugs.webkit.org/show_bug.cgi?id=73138
+
+Reviewed by Yury Semikhatsky.
+
+* http/tests/inspector/compiler-source-mapping-expected.txt:
+* http/tests/inspector/compiler-source-mapping.html:
+* http/tests/inspector/resources/source-map.json:
+
2011-11-29 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Rebaseline Win SVG results after r101342.
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt (101358 => 101359)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt 2011-11-29 12:40:45 UTC (rev 101358)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt 2011-11-29 12:46:34 UTC (rev 101359)
@@ -7,5 +7,7 @@
Running: testEmptyLine
+Running: testSections
+
Running: testLoad
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html (101358 => 101359)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2011-11-29 12:40:45 UTC (rev 101358)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html 2011-11-29 12:46:34 UTC (rev 101359)
@@ -90,6 +90,32 @@
next();
},
+function testSections(next)
+{
+var mappingPayload = {
+sections: [{
+offset: { line: 1, column: 0 },
+map: {
+mappings:,CAEC,
+sources:[source1.js]
+}
+}, {
+offset: { line: 3, column: 10 },
+map: {
+mappings:,CAEC,
+sources:[source2.js]
+}
+}
+]};
+var mapping = new WebInspector.ClosureCompilerSourceMapping();
+mapping._parseMappingPayload(mappingPayload);
+checkMapping(0, 0, source1.js, 0, 0, mapping);
+checkMapping(0, 1, source1.js, 2, 1, mapping);
+checkMapping(2, 10, source2.js, 0, 0, mapping);
+checkMapping(2, 11, source2.js, 2, 1, mapping);
+next();
+},
+
function testLoad(next)
{
var sourceMapping = new WebInspector.ClosureCompilerSourceMapping(http://localhost:8000/inspector/resources/source-map.json);
@@ -98,8 +124,8 @@
var sources = sourceMapping.sources();
InspectorTest.assertEquals(2, sources.length);
-InspectorTest.assertEquals(source1.js, sources[0]);
-InspectorTest.assertEquals(source2.js, sources[1]);
+InspectorTest.assertEquals(http://localhost:8000/inspector/resources/source1.js, sources[0]);
+InspectorTest.assertEquals(http://localhost:8000/inspector/resources/source2.js, sources[1]);
var sourceCode1 = sourceMapping.loadSourceCode(sourceMapping.sources()[0]);
InspectorTest.assertEquals(0, sourceCode1.indexOf(window.addEventListener));
Modified: trunk/LayoutTests/http/tests/inspector/resources/source-map.json (101358 => 101359)
--- trunk/LayoutTests/http/tests/inspector/resources/source-map.json 2011-11-29 12:40:45 UTC (rev 101358)
+++ trunk/LayoutTest
[webkit-changes] [101128] trunk
Title: [101128] trunk
Revision 101128
Author podivi...@chromium.org
Date 2011-11-24 01:10:20 -0800 (Thu, 24 Nov 2011)
Log Message
Web Inspector: add integration test for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=72730
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/compiler-source-mapping-debug.html
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
* http/tests/inspector/compiler-source-mapping-debug.html: Added.
* http/tests/inspector/resources/source-map.json:
* http/tests/inspector/resources/source1.js:
* http/tests/inspector/resources/source2.js:
(ClickHandler.prototype.handle):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/resources/source-map.json
trunk/LayoutTests/http/tests/inspector/resources/source1.js
trunk/LayoutTests/http/tests/inspector/resources/source2.js
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Added Paths
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html
trunk/LayoutTests/http/tests/inspector/resources/compiled.js
Diff
Modified: trunk/LayoutTests/ChangeLog (101127 => 101128)
--- trunk/LayoutTests/ChangeLog 2011-11-24 08:38:02 UTC (rev 101127)
+++ trunk/LayoutTests/ChangeLog 2011-11-24 09:10:20 UTC (rev 101128)
@@ -1,3 +1,17 @@
+2011-11-23 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: add integration test for compiler source maps.
+https://bugs.webkit.org/show_bug.cgi?id=72730
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
+* http/tests/inspector/compiler-source-mapping-debug.html: Added.
+* http/tests/inspector/resources/source-map.json:
+* http/tests/inspector/resources/source1.js:
+* http/tests/inspector/resources/source2.js:
+(ClickHandler.prototype.handle):
+
2011-11-24 Yury Semikhatsky yu...@chromium.org
Unreviewed. Update test expectations.
Added: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt (0 => 101128)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt 2011-11-24 09:10:20 UTC (rev 101128)
@@ -0,0 +1,15 @@
+CONSOLE MESSAGE: line 2: button clicked!
+Tests installing compiler source map in scripts panel.
+
+
+Debugger was enabled.
+
+Running: testSetBreakpoint
+Script source was shown.
+Script execution paused.
+Call stack:
+0) handleClick (compiled.js:2)
+1) clickButton (compiler-source-mapping-debug.html:11)
+Script execution resumed.
+Debugger was disabled.
+
Property changes on: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html (0 => 101128)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html 2011-11-24 09:10:20 UTC (rev 101128)
@@ -0,0 +1,53 @@
+html
+head
+script src=""
+script src=""
+script src=""
+
+script
+
+function clickButton()
+{
+document.getElementById('test').click();
+}
+
+function test()
+{
+
+InspectorTest.runDebuggerTestSuite([
+function testSetBreakpoint(next)
+{
+InspectorTest.showScriptSource(compiled.js, didShowCompiled);
+
+function didShowCompiled(sourceFrame)
+{
+InspectorTest.addResult(Script source was shown.);
+sourceFrame._model.setCompilerSourceMapping(sourceFrame._uiSourceCode, ht
[webkit-changes] [101069] trunk
Title: [101069] trunk
Revision 101069
Author podivi...@chromium.org
Date 2011-11-23 05:10:27 -0800 (Wed, 23 Nov 2011)
Log Message
Web Inspector: add integration test for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=72730
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/compiler-source-mapping-debug.html
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
* http/tests/inspector/compiler-source-mapping-debug.html: Added.
* http/tests/inspector/resources/source-map.json:
* http/tests/inspector/resources/source1.js:
* http/tests/inspector/resources/source2.js:
(ClickHandler.prototype.handle):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/resources/source-map.json
trunk/LayoutTests/http/tests/inspector/resources/source1.js
trunk/LayoutTests/http/tests/inspector/resources/source2.js
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Added Paths
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html
Diff
Modified: trunk/LayoutTests/ChangeLog (101068 => 101069)
--- trunk/LayoutTests/ChangeLog 2011-11-23 13:03:25 UTC (rev 101068)
+++ trunk/LayoutTests/ChangeLog 2011-11-23 13:10:27 UTC (rev 101069)
@@ -1,3 +1,17 @@
+2011-11-18 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: add integration test for compiler source maps.
+https://bugs.webkit.org/show_bug.cgi?id=72730
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
+* http/tests/inspector/compiler-source-mapping-debug.html: Added.
+* http/tests/inspector/resources/source-map.json:
+* http/tests/inspector/resources/source1.js:
+* http/tests/inspector/resources/source2.js:
+(ClickHandler.prototype.handle):
+
2011-11-23 Scott Graham scot...@chromium.org
Adding gamepad support
Added: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt (0 => 101069)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt 2011-11-23 13:10:27 UTC (rev 101069)
@@ -0,0 +1,15 @@
+CONSOLE MESSAGE: line 2: button clicked!
+Tests installing compiler source map in scripts panel.
+
+
+Debugger was enabled.
+
+Running: testSetBreakpoint
+Script source was shown.
+Script execution paused.
+Call stack:
+0) handleClick (compiled.js:2)
+1) clickButton (compiler-source-mapping-debug.html:11)
+Script execution resumed.
+Debugger was disabled.
+
Property changes on: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html (0 => 101069)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html 2011-11-23 13:10:27 UTC (rev 101069)
@@ -0,0 +1,53 @@
+html
+head
+script src=""
+script src=""
+script src=""
+
+script
+
+function clickButton()
+{
+document.getElementById('test').click();
+}
+
+function test()
+{
+
+InspectorTest.runDebuggerTestSuite([
+function testSetBreakpoint(next)
+{
+InspectorTest.showScriptSource(compiled.js, didShowCompiled);
+
+function didShowCompiled(sourceFrame)
+{
+InspectorTest.addResult(Script source was shown.);
+sourceFrame._model.setCompilerSourceMapping(sourceFrame._uiSourceCode, http://localhost:8000/inspector/resources/source-map.json);
+InspectorTest.showScriptSource(source1.js, didShowSource1);
+
+}
+
+
[webkit-changes] [98893] trunk/Source/WebCore
Title: [98893] trunk/Source/WebCore Revision 98893 Author podivi...@chromium.org Date 2011-10-31 15:52:58 -0700 (Mon, 31 Oct 2011) Log Message Update XMLHttpRequest.send idl declaration to match implementation. https://bugs.webkit.org/show_bug.cgi?id=71121 Reviewed by Adam Barth. * xml/XMLHttpRequest.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/xml/XMLHttpRequest.idl Diff Modified: trunk/Source/WebCore/ChangeLog (98892 => 98893) --- trunk/Source/WebCore/ChangeLog 2011-10-31 22:51:19 UTC (rev 98892) +++ trunk/Source/WebCore/ChangeLog 2011-10-31 22:52:58 UTC (rev 98893) @@ -1,3 +1,12 @@ +2011-10-31 Pavel Podivilov podivi...@chromium.org + +Update XMLHttpRequest.send idl declaration to match implementation. +https://bugs.webkit.org/show_bug.cgi?id=71121 + +Reviewed by Adam Barth. + +* xml/XMLHttpRequest.idl: + 2011-10-31 Anders Carlsson ander...@apple.com More work on making plug-ins work better with transforms Modified: trunk/Source/WebCore/xml/XMLHttpRequest.idl (98892 => 98893) --- trunk/Source/WebCore/xml/XMLHttpRequest.idl 2011-10-31 22:51:19 UTC (rev 98892) +++ trunk/Source/WebCore/xml/XMLHttpRequest.idl 2011-10-31 22:52:58 UTC (rev 98893) @@ -71,10 +71,18 @@ void setRequestHeader(in DOMString header, in DOMString value) raises(DOMException); -// void send(); -// void send(in DOMString data); +[Custom] void send() +raises(DOMException); +[Custom] void send(in ArrayBuffer data) +raises(DOMException); +[Conditional=BLOB, Custom] void send(in Blob data) +raises(DOMException); [Custom] void send(in Document data) raises(DOMException); +[Custom] void send(in DOMString data) +raises(DOMException); +[Custom] void send(in DOMFormData data) +raises(DOMException); void abort(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98617] trunk
Title: [98617] trunk
Revision 98617
Author podivi...@chromium.org
Date 2011-10-27 12:22:31 -0700 (Thu, 27 Oct 2011)
Log Message
Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816
Reviewed by Adam Barth.
Optional parameters in the middle are prohibited by WebIDL spec.
Source/WebCore:
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
* html/canvas/CanvasRenderingContext2D.idl:
* page/DOMWindow.idl:
LayoutTests:
* fast/canvas/canvas-putImageData-expected.txt: expectation was wrong, context.putImageData({}, 0, 0) should throw Type Error.
* fast/canvas/canvas-putImageData.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt
trunk/LayoutTests/fast/canvas/canvas-putImageData.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl
trunk/Source/WebCore/page/DOMWindow.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (98616 => 98617)
--- trunk/LayoutTests/ChangeLog 2011-10-27 19:16:15 UTC (rev 98616)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 19:22:31 UTC (rev 98617)
@@ -1,3 +1,15 @@
+2011-10-27 Pavel Podivilov podivi...@chromium.org
+
+Get rid of optional parameters in the middle in IDLs.
+https://bugs.webkit.org/show_bug.cgi?id=70816
+
+Reviewed by Adam Barth.
+
+Optional parameters in the middle are prohibited by WebIDL spec.
+
+* fast/canvas/canvas-putImageData-expected.txt: expectation was wrong, context.putImageData({}, 0, 0) should throw Type Error.
+* fast/canvas/canvas-putImageData.js:
+
2011-10-27 John Gregg john...@google.com
unreviewed, test expectations
Modified: trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt (98616 => 98617)
--- trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt 2011-10-27 19:16:15 UTC (rev 98616)
+++ trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt 2011-10-27 19:22:31 UTC (rev 98617)
@@ -144,7 +144,7 @@
PASS getPixel(9,9) is [0,128,0,255]
PASS getPixel(1,1) is [0,128,0,255]
PASS getPixel(9,9) is [0,128,0,255]
-PASS context.putImageData({}, 0, 0) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
+PASS context.putImageData({}, 0, 0) threw exception TypeError: Type error.
PASS context.putImageData(buffer, NaN, 0, 0, 0, 0, 0) threw exception Error: NOT_SUPPORTED_ERR: DOM Exception 9.
PASS context.putImageData(buffer, 0, NaN, 0, 0, 0, 0) threw exception Error: NOT_SUPPORTED_ERR: DOM Exception 9.
PASS context.putImageData(buffer, 0, 0, NaN, 0, 0, 0) threw exception Error: NOT_SUPPORTED_ERR: DOM Exception 9.
Modified: trunk/LayoutTests/fast/canvas/canvas-putImageData.js (98616 => 98617)
--- trunk/LayoutTests/fast/canvas/canvas-putImageData.js 2011-10-27 19:16:15 UTC (rev 98616)
+++ trunk/LayoutTests/fast/canvas/canvas-putImageData.js 2011-10-27 19:22:31 UTC (rev 98617)
@@ -201,7 +201,7 @@
pixelShouldBe(9, 9, [0, 128,0,255]);
-shouldThrow(context.putImageData({}, 0, 0), 'Error: TYPE_MISMATCH_ERR: DOM Exception 17');
+shouldThrow(context.putImageData({}, 0, 0), 'TypeError: Type error');
shouldThrow(context.putImageData(buffer, NaN, 0, 0, 0, 0, 0), 'Error: NOT_SUPPORTED_ERR: DOM Exception 9');
shouldThrow(context.putImageData(buffer, 0, NaN, 0, 0, 0, 0), 'Error: NOT_SUPPORTED_ERR: DOM Exception 9');
shouldThrow(context.putImageData(buffer, 0, 0, NaN, 0, 0, 0), 'Error: NOT_SUPPORTED_ERR: DOM Exception 9');
Modified: trunk/Source/WebCore/ChangeLog (98616 => 98617)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 19:16:15 UTC (rev 98616)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 19:22:31 UTC (rev 98617)
@@ -1,3 +1,28 @@
+2011-10-27 Pavel Podivilov podivi...@chromium.org
+
+Get rid of optional parameters in the middle in IDLs.
+https://bugs.webkit.org/show_bug.cgi?id=70816
+
+Reviewed by Adam Barth.
+
+Optional parameters in the middle are prohibited by WebIDL spec.
+
+* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader):
+(GenerateIm
[webkit-changes] [98343] trunk
Title: [98343] trunk
Revision 98343
Author podivi...@chromium.org
Date 2011-10-25 07:22:44 -0700 (Tue, 25 Oct 2011)
Log Message
Web Inspector: keep old source mapping when new one could not be loaded.
https://bugs.webkit.org/show_bug.cgi?id=70729
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):
LayoutTests:
* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (98342 => 98343)
--- trunk/LayoutTests/ChangeLog 2011-10-25 14:04:45 UTC (rev 98342)
+++ trunk/LayoutTests/ChangeLog 2011-10-25 14:22:44 UTC (rev 98343)
@@ -1,3 +1,13 @@
+2011-10-24 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: keep old source mapping when new one could not be loaded.
+https://bugs.webkit.org/show_bug.cgi?id=70729
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/raw-source-code-expected.txt:
+* inspector/debugger/raw-source-code.html:
+
2011-10-25 Sachin Puranik sachin.pura...@motorola.com
Double number step=.5 should be considered valid in input type=number step=.5
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt (98342 => 98343)
--- trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt 2011-10-25 14:04:45 UTC (rev 98342)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt 2011-10-25 14:22:44 UTC (rev 98343)
@@ -15,3 +15,5 @@
Running: testCompilerSourceMapping
+Running: testCompilerSourceMappingCouldNotBeLoaded
+
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (98342 => 98343)
--- trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-25 14:04:45 UTC (rev 98342)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-25 14:22:44 UTC (rev 98343)
@@ -400,6 +400,25 @@
InspectorTest.assertEquals(content of source2.js, content);
next();
}
+},
+
+function testCompilerSourceMappingCouldNotBeLoaded(next)
+{
+var compilerSourceMappingProviderMock = { loadSourceMapping: function(callback) { callback(null); } };
+
+var script = createScriptMock(compiled.js, 0, 0, true, script source);
+var rawSourceCode = createRawSourceCode(script, null);
+var uiSourceCodeList;
+
+waitForSourceMappingEvent(rawSourceCode, checkMapping);
+rawSourceCode.setCompilerSourceMappingProvider(compilerSourceMappingProviderMock);
+
+function checkMapping()
+{
+InspectorTest.assertTrue(false, Should not be reached.);
+}
+
+next();
}
]);
};
Modified: trunk/Source/WebCore/ChangeLog (98342 => 98343)
--- trunk/Source/WebCore/ChangeLog 2011-10-25 14:04:45 UTC (rev 98342)
+++ trunk/Source/WebCore/ChangeLog 2011-10-25 14:22:44 UTC (rev 98343)
@@ -1,3 +1,15 @@
+2011-10-24 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: keep old source mapping when new one could not be loaded.
+https://bugs.webkit.org/show_bug.cgi?id=70729
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/RawSourceCode.js:
+(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
+(WebInspector.RawSourceCode.prototype._updateSourceMapping):
+(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):
+
2011-10-25 Sachin Puranik sachin.pura...@motorola.com
Double number step=.5 should be considered valid in input type=number step=.5
Modified: trunk/Source/WebCore/inspector/front-end/RawSourceCode.js (98342 => 98343)
--- trunk/Source/WebCore/inspector/front-end/RawSourceCode.js 2011-10-25 14:04:45 UTC (rev 98342)
+++ trunk/Source/WebCore/inspector/front-end/RawSourceCode.js 2011-10-25 14:22:44 UTC (rev 98343)
@@ -159,6 +159,8 @@
function didCreateSourceMapping(sourceMapping)
{
this._updatingSourceMapping = false;
+if (!sourceMapping)
+return;
if (!this._updateNeeded)
this._saveSourceMapping(sourceMapping);
else
@@ -187,6 +189,11 @@
*/
function didLoadSourceMapping(compilerSourceMapping)
{
+if (!compilerSourceMapping) {
+delete this._compilerSource
[webkit-changes] [98345] trunk
Title: [98345] trunk
Revision 98345
Author podivi...@chromium.org
Date 2011-10-25 07:26:59 -0700 (Tue, 25 Oct 2011)
Log Message
Web Inspector: fix empty line handling in source maps.
https://bugs.webkit.org/show_bug.cgi?id=70726
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):
LayoutTests:
* inspector/debugger/compiler-source-mapping-expected.txt:
* inspector/debugger/compiler-source-mapping.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt
trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
Diff
Modified: trunk/LayoutTests/ChangeLog (98344 => 98345)
--- trunk/LayoutTests/ChangeLog 2011-10-25 14:24:59 UTC (rev 98344)
+++ trunk/LayoutTests/ChangeLog 2011-10-25 14:26:59 UTC (rev 98345)
@@ -1,3 +1,13 @@
+2011-10-24 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix empty line handling in source maps.
+https://bugs.webkit.org/show_bug.cgi?id=70726
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/compiler-source-mapping-expected.txt:
+* inspector/debugger/compiler-source-mapping.html:
+
2011-10-25 Justin Schuh jsc...@chromium.org
Check for empty string in parseArcFlag
Modified: trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt (98344 => 98345)
--- trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt 2011-10-25 14:24:59 UTC (rev 98344)
+++ trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt 2011-10-25 14:26:59 UTC (rev 98345)
@@ -5,3 +5,5 @@
Running: testNoMappingEntry
+Running: testEmptyLine
+
Modified: trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html (98344 => 98345)
--- trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html 2011-10-25 14:24:59 UTC (rev 98344)
+++ trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html 2011-10-25 14:26:59 UTC (rev 98345)
@@ -73,6 +73,18 @@
checkMapping(0, 0, example.js, 0, 0, mapping);
checkMapping(0, 2, example.js, 0, 2, mapping);
next();
+},
+
+function testEmptyLine(next)
+{
+var mappingPayload = {
+mappings:;;;CACA,
+sources:[example.js]
+};
+var mapping = new WebInspector.ClosureCompilerSourceMapping(mappingPayload);
+checkMapping(0, 0, example.js, 0, 0, mapping);
+checkReverseMapping(3, 1, example.js, 1, mapping);
+next();
}
]);
};
Modified: trunk/Source/WebCore/ChangeLog (98344 => 98345)
--- trunk/Source/WebCore/ChangeLog 2011-10-25 14:24:59 UTC (rev 98344)
+++ trunk/Source/WebCore/ChangeLog 2011-10-25 14:26:59 UTC (rev 98345)
@@ -1,3 +1,13 @@
+2011-10-24 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix empty line handling in source maps.
+https://bugs.webkit.org/show_bug.cgi?id=70726
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/CompilerSourceMapping.js:
+(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):
+
2011-10-25 Justin Schuh jsc...@chromium.org
Check for empty string in parseArcFlag
Modified: trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js (98344 => 98345)
--- trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js 2011-10-25 14:24:59 UTC (rev 98344)
+++ trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js 2011-10-25 14:26:59 UTC (rev 98345)
@@ -151,7 +151,19 @@
var sourceURL = this._sources[0];
var reverseMappings = this._reverseMappingsBySourceURL[sourceURL];
-do {
+while (true) {
+if (stringCharIterator.peek() === ,)
+stringCharIterator.next();
+else {
+while (stringCharIterator.peek() === ;) {
+lineNumber += 1;
+columnNumber = 0;
+stringCharIterator.next();
+}
+if (!stringCharIterator.hasNext())
+break;
+}
+
columnNumber += this._decodeVLQ(stringCharIterator);
if (!this._isSeparator(stringCharIterator.peek())) {
var sourceIndexDelta = this._decodeVLQ(stringCharIterator);
@@ -169,12 +181,7 @@
if (!reverseMappings[sourceLineNumber])
reverseMappings[sourceLineNumber] = [lineNumber, columnNumber];
}
-
-if (stringCharIterator.next() === ;) {
-lineNumber += 1;
-columnNumber = 0;
-}
-} while(stringCharIterator.hasNext());
+}
},
_isSepa
[webkit-changes] [98385] trunk/Source/WebCore
Title: [98385] trunk/Source/WebCore
Revision 98385
Author podivi...@chromium.org
Date 2011-10-25 13:36:54 -0700 (Tue, 25 Oct 2011)
Log Message
Fix several minor problems in idls.
https://bugs.webkit.org/show_bug.cgi?id=70811
Reviewed by Adam Barth.
This patch does not have any effect on generated bindings.
* dom/DataTransferItems.idl:
* page/History.idl:
* storage/IDBIndex.idl:
* xml/XMLHttpRequest.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DataTransferItems.idl
trunk/Source/WebCore/page/History.idl
trunk/Source/WebCore/storage/IDBIndex.idl
trunk/Source/WebCore/xml/XMLHttpRequest.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (98384 => 98385)
--- trunk/Source/WebCore/ChangeLog 2011-10-25 20:30:24 UTC (rev 98384)
+++ trunk/Source/WebCore/ChangeLog 2011-10-25 20:36:54 UTC (rev 98385)
@@ -1,3 +1,17 @@
+2011-10-25 Pavel Podivilov podivi...@chromium.org
+
+Fix several minor problems in idls.
+https://bugs.webkit.org/show_bug.cgi?id=70811
+
+Reviewed by Adam Barth.
+
+This patch does not have any effect on generated bindings.
+
+* dom/DataTransferItems.idl:
+* page/History.idl:
+* storage/IDBIndex.idl:
+* xml/XMLHttpRequest.idl:
+
2011-10-25 Nate Chapin jap...@chromium.org
Make DocumentThreadableLoader a CachedResourceClient.
Modified: trunk/Source/WebCore/dom/DataTransferItems.idl (98384 => 98385)
--- trunk/Source/WebCore/dom/DataTransferItems.idl 2011-10-25 20:30:24 UTC (rev 98384)
+++ trunk/Source/WebCore/dom/DataTransferItems.idl 2011-10-25 20:36:54 UTC (rev 98385)
@@ -38,7 +38,7 @@
#endif
] DataTransferItems {
readonly attribute long length;
-DataTransferItem item(in [Optional=CallWithDefaultValue] unsigned long index) getter;
+DataTransferItem item(in [Optional=CallWithDefaultValue] unsigned long index);
void clear();
void add(in [Optional=CallWithDefaultValue] DOMString data,
Modified: trunk/Source/WebCore/page/History.idl (98384 => 98385)
--- trunk/Source/WebCore/page/History.idl 2011-10-25 20:30:24 UTC (rev 98384)
+++ trunk/Source/WebCore/page/History.idl 2011-10-25 20:36:54 UTC (rev 98385)
@@ -42,9 +42,9 @@
[DoNotCheckDomainSecurity, CallWith=ScriptExecutionContext] void forward();
[DoNotCheckDomainSecurity, CallWith=ScriptExecutionContext] void go(in [Optional=CallWithDefaultValue] long distance);
-[Custom, EnabledAtRuntime] void pushState(in any data, in DOMString title, in optional DOMString url)
+[Custom, EnabledAtRuntime] void pushState(in any data, in DOMString title, in [Optional] DOMString url)
raises(DOMException);
-[Custom, EnabledAtRuntime] void replaceState(in any data, in DOMString title, in optional DOMString url)
+[Custom, EnabledAtRuntime] void replaceState(in any data, in DOMString title, in [Optional] DOMString url)
raises(DOMException);
};
Modified: trunk/Source/WebCore/storage/IDBIndex.idl (98384 => 98385)
--- trunk/Source/WebCore/storage/IDBIndex.idl 2011-10-25 20:30:24 UTC (rev 98384)
+++ trunk/Source/WebCore/storage/IDBIndex.idl 2011-10-25 20:36:54 UTC (rev 98385)
@@ -35,7 +35,7 @@
[CallWith=ScriptExecutionContext] IDBRequest openCursor(in [Optional] IDBKeyRange range, in [Optional] unsigned short direction)
raises (IDBDatabaseException);
-[CallWith=ScriptExecutionContext] IDBRequest openKeyCursor(in [Optional] IDBKeyRange range, in [Optional] unsigned short direction))
+[CallWith=ScriptExecutionContext] IDBRequest openKeyCursor(in [Optional] IDBKeyRange range, in [Optional] unsigned short direction)
raises (IDBDatabaseException);
[CallWith=ScriptExecutionContext] IDBRequest get(in IDBKey key)
raises (IDBDatabaseException);
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.idl (98384 => 98385)
--- trunk/Source/WebCore/xml/XMLHttpRequest.idl 2011-10-25 20:30:24 UTC (rev 98384)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.idl 2011-10-25 20:36:54 UTC (rev 98385)
@@ -64,10 +64,8 @@
attribute boolean withCredentials
setter raises(DOMException);
-// void open(in DOMString method, in DOMString url);
-// void open(in DOMString method, in DOMString url, in boolean async);
-// void open(in DOMString method, in DOMString url, in boolean async, in DOMString user);
-[Custom] void open(in DOMString method, in DOMString url, in boolean async, in DOMString user, in DOMString password)
+
+[Custom] void open(in DOMString method, in DOMString url, in [Optional] boolean async, in [Optional] DOMString user, in [Optional] DOMString password)
raises(DOMException);
void setRequestHeader(in DOMString header, in DOMString value)
___
webkit-changes mailing list
webkit-changes@lists.
[webkit-changes] [98103] trunk/Source/WebCore
Title: [98103] trunk/Source/WebCore
Revision 98103
Author podivi...@chromium.org
Date 2011-10-21 08:56:25 -0700 (Fri, 21 Oct 2011)
Log Message
Web Inspector: first line in file is not highlighted.
https://bugs.webkit.org/show_bug.cgi?id=70504
Reviewed by Pavel Feldman.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._initializeTextViewer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (98102 => 98103)
--- trunk/Source/WebCore/ChangeLog 2011-10-21 15:43:03 UTC (rev 98102)
+++ trunk/Source/WebCore/ChangeLog 2011-10-21 15:56:25 UTC (rev 98103)
@@ -1,3 +1,13 @@
+2011-10-20 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: first line in file is not highlighted.
+https://bugs.webkit.org/show_bug.cgi?id=70504
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/SourceFrame.js:
+(WebInspector.SourceFrame.prototype._initializeTextViewer):
+
2011-10-21 Andreas Kling kl...@webkit.org
Simplify CSSStyleRule::setSelectorText().
Modified: trunk/Source/WebCore/inspector/front-end/SourceFrame.js (98102 => 98103)
--- trunk/Source/WebCore/inspector/front-end/SourceFrame.js 2011-10-21 15:43:03 UTC (rev 98102)
+++ trunk/Source/WebCore/inspector/front-end/SourceFrame.js 2011-10-21 15:56:25 UTC (rev 98103)
@@ -310,7 +310,7 @@
if (typeof this._executionLineNumber === number)
this.setExecutionLine(this._executionLineNumber);
-if (this._lineToHighlight) {
+if (typeof this._lineToHighlight === number) {
this.highlightLine(this._lineToHighlight);
delete this._lineToHighlight;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97952] trunk
Title: [97952] trunk
Revision 97952
Author podivi...@chromium.org
Date 2011-10-20 02:33:02 -0700 (Thu, 20 Oct 2011)
Log Message
Web Inspector: encode source map url as source map page url query parameter.
https://bugs.webkit.org/show_bug.cgi?id=70327
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/CompilerSourceMappingProvider.js:
(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
(WebInspector.CompilerSourceMappingProvider.prototype._sendRequest):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiSourceCodeList):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-provider.html:
* http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider.html
trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMappingProvider.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (97951 => 97952)
--- trunk/LayoutTests/ChangeLog 2011-10-20 09:10:06 UTC (rev 97951)
+++ trunk/LayoutTests/ChangeLog 2011-10-20 09:33:02 UTC (rev 97952)
@@ -1,3 +1,13 @@
+2011-10-18 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: encode source map url as source map page url query parameter.
+https://bugs.webkit.org/show_bug.cgi?id=70327
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-source-mapping-provider.html:
+* http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html:
+
2011-10-20 Yuzo Fujishima y...@google.com
[chromium] Yet another test expectation change for platform/chromium/compositing/zoom-animator-scale-test2.html
Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider.html (97951 => 97952)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider.html 2011-10-20 09:10:06 UTC (rev 97951)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider.html 2011-10-20 09:33:02 UTC (rev 97952)
@@ -9,7 +9,7 @@
InspectorTest.runTestSuite([
function testLoad(next)
{
-var provider = new WebInspector.CompilerSourceMappingProvider(http://localhost:8000/inspector/resources/compiler-source-mapping-provider/app-map);
+var provider = new WebInspector.CompilerSourceMappingProvider(http://localhost:8000/inspector/resources/compiler-source-mapping-provider/app-map.html?sourceMap=app-map);
var sourceMapping;
provider.loadSourceMapping(didLoadSourceMapping);
function didLoadSourceMapping(sourceMappingArg)
Modified: trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html (97951 => 97952)
--- trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html 2011-10-20 09:10:06 UTC (rev 97951)
+++ trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html 2011-10-20 09:33:02 UTC (rev 97952)
@@ -3,7 +3,19 @@
function handleMessage(event)
{
-var url = ""
+var requestId = event.data.id;
+var method = event.data.method;
+if (method === loadSourceMap) {
+var queryParameters = parseQueryString(window.location.toString());
+sendRequest(event, queryParameters.sourceMap);
+} else if (method === loadSourceCode) {
+var sourceCodeURL = event.data.params[0];
+sendRequest(event, sourceCodeURL);
+}
+}
+
+function sendRequest(event, url)
+{
var request = new XMLHttpRequest();
request.open(GET, url, true);
request._onreadystatechange_ = function()
@@ -17,4 +29,16 @@
}
request.send();
}
+
+function parseQueryString(url)
+{
+var query = url.split(?)[1];
+var parameters = query.split();
+var result = {};
+for (var i = 0; i parameters.length; ++i) {
+var parameter = parameters[i].split(=);
+result[parameter[0]] = parameter[1];
+}
+return result;
+}
/script
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (97951 => 97952)
--- trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-20 09:10:06 UTC (rev 97951)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-20 09:33:02 UTC (rev 97952)
@@ -375,7 +375,7 @@
function checkMapping()
{
var sourceMapping = rawSourceCode.sourceMapping;
-
[webkit-changes] [97843] trunk/Source/WebCore
Title: [97843] trunk/Source/WebCore
Revision 97843
Author podivi...@chromium.org
Date 2011-10-19 02:48:28 -0700 (Wed, 19 Oct 2011)
Log Message
Web Inspector: move JS specific popover handling to _javascript_SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=70033
Reviewed by Pavel Feldman.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.get paused):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame):
(WebInspector._javascript_SourceFrame.prototype.shouldShowPopover):
(WebInspector._javascript_SourceFrame.prototype.onShowPopover.showObjectPopover):
(WebInspector._javascript_SourceFrame.prototype.onShowPopover):
(WebInspector._javascript_SourceFrame.prototype.onHidePopover):
(WebInspector._javascript_SourceFrame.prototype._highlightExpression):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype._getPopoverAnchor):
(WebInspector.SourceFrame.prototype.get readOnly):
(WebInspector.SourceFrame.prototype._setReadOnly):
(WebInspector.SourceFrame.prototype.contentChanged):
(WebInspector.SourceFrame.prototype.shouldShowPopover):
(WebInspector.SourceFrame.prototype.onShowPopover):
(WebInspector.SourceFrame.prototype.onHidePopover):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (97842 => 97843)
--- trunk/Source/WebCore/ChangeLog 2011-10-19 09:45:48 UTC (rev 97842)
+++ trunk/Source/WebCore/ChangeLog 2011-10-19 09:48:28 UTC (rev 97843)
@@ -1,3 +1,35 @@
+2011-10-13 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: move JS specific popover handling to _javascript_SourceFrame.
+https://bugs.webkit.org/show_bug.cgi?id=70033
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
+(WebInspector.DebuggerPresentationModel.prototype.get paused):
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame):
+(WebInspector._javascript_SourceFrame.prototype.shouldShowPopover):
+(WebInspector._javascript_SourceFrame.prototype.onShowPopover.showObjectPopover):
+(WebInspector._javascript_SourceFrame.prototype.onShowPopover):
+(WebInspector._javascript_SourceFrame.prototype.onHidePopover):
+(WebInspector._javascript_SourceFrame.prototype._highlightExpression):
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._createSourceFrame):
+(WebInspector.SourceFrameDelegateForScriptsPanel):
+* inspector/front-end/SourceFrame.js:
+(WebInspector.SourceFrame):
+(WebInspector.SourceFrame.prototype.willHide):
+(WebInspector.SourceFrame.prototype._initializeTextViewer):
+(WebInspector.SourceFrame.prototype._getPopoverAnchor):
+(WebInspector.SourceFrame.prototype.get readOnly):
+(WebInspector.SourceFrame.prototype._setReadOnly):
+(WebInspector.SourceFrame.prototype.contentChanged):
+(WebInspector.SourceFrame.prototype.shouldShowPopover):
+(WebInspector.SourceFrame.prototype.onShowPopover):
+(WebInspector.SourceFrame.prototype.onHidePopover):
+
2011-10-19 Tomasz Morawski t.moraw...@samsung.com
[EFL][WK2] Added missing files to build WebKit2 EFL
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (97842 => 97843)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2011-10-19 09:45:48 UTC (rev 97842)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2011-10-19 09:48:28 UTC (rev 97843)
@@ -156,7 +156,7 @@
for (var i = 0; i uiSourceCodeList.length; ++i)
result.push(uiSourceCodeList[i]);
}
-return result;
+return result;
},
/**
@@ -491,6 +491,11 @@
this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.DebuggerResumed);
},
+get paused()
+{
+return !!WebInspector.debuggerModel.debuggerPausedDetails;
+},
+
set selectedCallFrame(callFrame)
{
if (this._selectedCallFrame)
Modified: trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js (97842 => 97843)
[webkit-changes] [97732] trunk
Title: [97732] trunk
Revision 97732
Author podivi...@chromium.org
Date 2011-10-18 02:28:14 -0700 (Tue, 18 Oct 2011)
Log Message
Web Inspector: support displaying multiple sources per single script in ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=69847
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
LayoutTests:
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt
trunk/LayoutTests/inspector/debugger/scripts-panel.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (97731 => 97732)
--- trunk/LayoutTests/ChangeLog 2011-10-18 09:18:18 UTC (rev 97731)
+++ trunk/LayoutTests/ChangeLog 2011-10-18 09:28:14 UTC (rev 97732)
@@ -1,3 +1,13 @@
+2011-10-11 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: support displaying multiple sources per single script in ScriptsPanel.
+https://bugs.webkit.org/show_bug.cgi?id=69847
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/scripts-panel-expected.txt:
+* inspector/debugger/scripts-panel.html:
+
2011-10-18 Kentaro Hara hara...@chromium.org
Unreviewed, rolling out r97697.
Modified: trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt (97731 => 97732)
--- trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt 2011-10-18 09:18:18 UTC (rev 97731)
+++ trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt 2011-10-18 09:28:14 UTC (rev 97732)
@@ -35,5 +35,7 @@
Running: testSourceReplaced
Source requested for foo.js
-Source requested for bar.js
+Source requested for source2.js
+Source requested for source1.js
+Source requested for compiled.js
Modified: trunk/LayoutTests/inspector/debugger/scripts-panel.html (97731 => 97732)
--- trunk/LayoutTests/inspector/debugger/scripts-panel.html 2011-10-18 09:18:18 UTC (rev 97731)
+++ trunk/LayoutTests/inspector/debugger/scripts-panel.html 2011-10-18 09:28:14 UTC (rev 97732)
@@ -17,7 +17,7 @@
model.canEditScriptSource = function() { return true; };
return model;
}
-function addUISouceCode(model, url)
+function createUISouceCode(url)
{
var uiSourceCode = {
url: url,
@@ -29,7 +29,6 @@
messages: []
};
uiSourceCode.__proto__ = WebInspector.Object.prototype;
-model.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.UISourceCodeAdded, uiSourceCode);
return uiSourceCode;
}
@@ -51,9 +50,9 @@
var model = createDebuggerPresentationModelMock();
var panel = new WebInspector.ScriptsPanel(model);
-addUISouceCode(model, foo.js);
-addUISouceCode(model, bar.js);
-addUISouceCode(model, baz.js);
+panel._uiSourceCodeAdded({ data: createUISouceCode(foo.js) });
+panel._uiSourceCodeAdded({ data: createUISouceCode(bar.js) });
+panel._uiSourceCodeAdded({ data: createUISouceCode(baz.js) });
InspectorTest.addResult(Dump files select:);
var select = panel._filesSelectElement;
@@ -78,7 +77,7 @@
var files = [index.html, script1.js, script2.js, script3.js];
for (var i = 0; i files.length; ++i)
-addUISouceCode(model, files[i]);
+panel._uiSourceCodeAdded({ data: createUISouceCode(files[i]) });
function checkCurrentlySelectedFileName(fileName)
{
@@ -165,10 +164,25 @@
var model = createDebuggerPresentationModelMock();
var panel = new WebInspector.ScriptsPanel(model);
-addUISouceCode(model, foo.js);
-var uiSourceCode = addUISouceCode(model, bar.js);
-panel._uiSourceCodeReplaced({ data: { oldUISourceCodeList: [uiSourceCode], uiSourceCodeList: [uiSourceCode] }});
-showSourceFrame(panel, bar.js);
+panel._uiSourceCodeAdded({ data: createUISouceCode(foo.js) });
+var compiledSourceCode = createUISouceCode(compiled.js);
+panel._uiSourceCodeAdded({ data: compiledSourceCode });
+
+InspectorTest.assertEquals(2, panel._filesSelectElement.length);
+
+// Plug compiler source mapping.
+var source1SourceCode = createUISouceCode(source1.js);
+var source2SourceCode = createUISouceCode(source2.js);
+panel._uiSourceCodeReplaced({ data: { oldUISourceCodeList: [compiledSourceCode], uiSourceCodeList: [source1SourceCode, source2SourceCode] }});
+
+InspectorTest.assertEquals(3, panel._filesSelectElement.length);
+showSourceFrame(panel, s
[webkit-changes] [97621] trunk
Title: [97621] trunk
Revision 97621
Author podivi...@chromium.org
Date 2011-10-17 07:53:37 -0700 (Mon, 17 Oct 2011)
Log Message
Web Inspector: fix handling of source mapping entries with no mapping.
https://bugs.webkit.org/show_bug.cgi?id=69941
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):
LayoutTests:
* inspector/debugger/compiler-source-mapping-expected.txt:
* inspector/debugger/compiler-source-mapping.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt
trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
Diff
Modified: trunk/LayoutTests/ChangeLog (97620 => 97621)
--- trunk/LayoutTests/ChangeLog 2011-10-17 14:21:10 UTC (rev 97620)
+++ trunk/LayoutTests/ChangeLog 2011-10-17 14:53:37 UTC (rev 97621)
@@ -1,3 +1,13 @@
+2011-10-12 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix handling of source mapping entries with no mapping.
+https://bugs.webkit.org/show_bug.cgi?id=69941
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/compiler-source-mapping-expected.txt:
+* inspector/debugger/compiler-source-mapping.html:
+
2011-10-17 Kent Tamura tk...@chromium.org
[Chromium] Update test expectations for r97596 and r97602.
Modified: trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt (97620 => 97621)
--- trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt 2011-10-17 14:21:10 UTC (rev 97620)
+++ trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt 2011-10-17 14:53:37 UTC (rev 97621)
@@ -3,3 +3,5 @@
Running: testSimpleMapping
+Running: testNoMappingEntry
+
Modified: trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html (97620 => 97621)
--- trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html 2011-10-17 14:21:10 UTC (rev 97620)
+++ trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html 2011-10-17 14:53:37 UTC (rev 97621)
@@ -61,6 +61,18 @@
InspectorTest.assertTrue(!mapping.sourceLocationToCompiledLocation(example.js, 6));
next();
+},
+
+function testNoMappingEntry(next)
+{
+var mappingPayload = {
+mappings:,C,CAAE;,
+sources:[example.js]
+};
+var mapping = new WebInspector.ClosureCompilerSourceMapping(mappingPayload);
+checkMapping(0, 0, example.js, 0, 0, mapping);
+checkMapping(0, 2, example.js, 0, 2, mapping);
+next();
}
]);
};
Modified: trunk/Source/WebCore/ChangeLog (97620 => 97621)
--- trunk/Source/WebCore/ChangeLog 2011-10-17 14:21:10 UTC (rev 97620)
+++ trunk/Source/WebCore/ChangeLog 2011-10-17 14:53:37 UTC (rev 97621)
@@ -1,3 +1,13 @@
+2011-10-12 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: fix handling of source mapping entries with no mapping.
+https://bugs.webkit.org/show_bug.cgi?id=69941
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/CompilerSourceMapping.js:
+(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):
+
2011-10-17 Mikhail Naganov mnaga...@chromium.org
Web Inspector: [Chromium] Add an ability to look up and explore an object from a heap profile.
Modified: trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js (97620 => 97621)
--- trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js 2011-10-17 14:21:10 UTC (rev 97620)
+++ trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js 2011-10-17 14:53:37 UTC (rev 97621)
@@ -154,23 +154,23 @@
do {
columnNumber += this._decodeVLQ(stringCharIterator);
-if (this._isSeparator(stringCharIterator.peek()))
-continue;
-var sourceIndexDelta = this._decodeVLQ(stringCharIterator);
-if (sourceIndexDelta) {
-sourceIndex += sourceIndexDelta;
-sourceURL = this._sources[sourceIndex];
-reverseMappings = this._reverseMappingsBySourceURL[sourceURL];
+if (!this._isSeparator(stringCharIterator.peek())) {
+var sourceIndexDelta = this._decodeVLQ(stringCharIterator);
+if (sourceIndexDelta) {
+sourceIndex += sourceIndexDelta;
+sourceURL = this._sources[sourceIndex];
+reverseMappings = this._reverseMappingsBySourceURL[sourceURL];
+}
+sourceLineNumber += this._decodeVLQ(stringCharIterator);
+sourceColumnNumber += this._decodeVLQ(stringCharIterator);
+if (!this._isSeparator(stringCh
[webkit-changes] [97250] trunk/LayoutTests
Title: [97250] trunk/LayoutTests Revision 97250 Author podivi...@chromium.org Date 2011-10-12 02:51:24 -0700 (Wed, 12 Oct 2011) Log Message 2011-10-12 Pavel Podivilov podivi...@chromium.org Unreviewed, mark four js tests as failing after v8 roll. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97249 => 97250) --- trunk/LayoutTests/ChangeLog 2011-10-12 09:41:06 UTC (rev 97249) +++ trunk/LayoutTests/ChangeLog 2011-10-12 09:51:24 UTC (rev 97250) @@ -1,3 +1,9 @@ +2011-10-12 Pavel Podivilov podivi...@chromium.org + +Unreviewed, mark four js tests as failing after v8 roll. + +* platform/chromium/test_expectations.txt: + 2011-10-12 Kent Tamura tk...@chromium.org [Chromium] Update test expectations. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97249 => 97250) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-12 09:41:06 UTC (rev 97249) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-12 09:51:24 UTC (rev 97250) @@ -3871,3 +3871,11 @@ BUGCR99899 MAC : fast/frames/sandboxed-iframe-plugins.html = CRASH TEXT PASS // New failures from WebKit r51577 BUGCR29164 WIN LINUX : fast/frames/sandboxed-iframe-plugins.html = TEXT + +// We need to upstream new test expectations for these after fixing some +// V8 bugs. Keeping here until we are sure that the push with the new GC +// stays in. +BUG_RICOW : fast/js/array-functions-non-arrays.html = TEXT +BUG_RICOW : fast/js/array-prototype-properties.html = TEXT +BUG_RICOW : fast/js/kde/RegExp.html = TEXT +BUG_RICOW : fast/js/toString-overrides.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97251] trunk/LayoutTests
Title: [97251] trunk/LayoutTests Revision 97251 Author podivi...@chromium.org Date 2011-10-12 02:58:16 -0700 (Wed, 12 Oct 2011) Log Message 2011-10-12 Pavel Podivilov podivi...@chromium.org Unreviewed, mark fast/css/text-transform-select.html as IMAGE+TEXT on win. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97250 => 97251) --- trunk/LayoutTests/ChangeLog 2011-10-12 09:51:24 UTC (rev 97250) +++ trunk/LayoutTests/ChangeLog 2011-10-12 09:58:16 UTC (rev 97251) @@ -1,5 +1,11 @@ 2011-10-12 Pavel Podivilov podivi...@chromium.org +Unreviewed, mark fast/css/text-transform-select.html as IMAGE+TEXT on win. + +* platform/chromium/test_expectations.txt: + +2011-10-12 Pavel Podivilov podivi...@chromium.org + Unreviewed, mark four js tests as failing after v8 roll. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97250 => 97251) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-12 09:51:24 UTC (rev 97250) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-12 09:58:16 UTC (rev 97251) @@ -3654,7 +3654,8 @@ BUGWK68372 SNOWLEOPARD : svg/animations/svglength-animation-px-to-exs.html = PASS CRASH // New tests for webkit bug 69503. Should be rebaselined once fixed. -BUGWK69503 MAC WIN : fast/css/text-transform-select.html = IMAGE +BUGWK69503 MAC : fast/css/text-transform-select.html = IMAGE +BUGWK69503 WIN : fast/css/text-transform-select.html = IMAGE+TEXT // Tests that are known to fail on Mac10.6 with CPU-Skia graphics. BUGWK68436 SNOWLEOPARD CPU : fast/events/constructors/progress-event-constructor.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97256] trunk/Source/WebKit/chromium
Title: [97256] trunk/Source/WebKit/chromium
Revision 97256
Author podivi...@chromium.org
Date 2011-10-12 06:23:19 -0700 (Wed, 12 Oct 2011)
Log Message
2011-10-12 Pavel Podivilov podivi...@chromium.org
Unreviewed, CCThreadTest.startPostAndWaitOnCondition is flaky on linux.
* tests/CCThreadTest.cpp:
(WebKit::TEST):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (97255 => 97256)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-12 12:50:57 UTC (rev 97255)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-12 13:23:19 UTC (rev 97256)
@@ -1,3 +1,10 @@
+2011-10-12 Pavel Podivilov podivi...@chromium.org
+
+Unreviewed, CCThreadTest.startPostAndWaitOnCondition is flaky on linux.
+
+* tests/CCThreadTest.cpp:
+(WebKit::TEST):
+
2011-10-12 Sheriff Bot webkit.review@gmail.com
Unreviewed. Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp (97255 => 97256)
--- trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp 2011-10-12 12:50:57 UTC (rev 97255)
+++ trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp 2011-10-12 13:23:19 UTC (rev 97256)
@@ -86,13 +86,7 @@
bool hit;
};
-#if OS(WINDOWS) || OS(MAC_OS_X)
-#define MAYBE_startPostAndWaitOnCondition DISABLED_startPostAndWaitOnCondition
-#else
-#define MAYBE_startPostAndWaitOnCondition startPostAndWaitOnCondition
-#endif
-
-TEST(CCThreadTest, MAYBE_startPostAndWaitOnCondition)
+TEST(CCThreadTest, DISABLED_startPostAndWaitOnCondition)
{
OwnPtrWebThread webThread = adoptPtr(webKitPlatformSupport()-createThread(test));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97140] trunk/LayoutTests
Title: [97140] trunk/LayoutTests Revision 97140 Author podivi...@chromium.org Date 2011-10-11 03:35:32 -0700 (Tue, 11 Oct 2011) Log Message 2011-10-11 Pavel Podivilov podivi...@chromium.org Unreviewed, mark two accessibility tests as failing on chromium. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97139 => 97140) --- trunk/LayoutTests/ChangeLog 2011-10-11 10:30:54 UTC (rev 97139) +++ trunk/LayoutTests/ChangeLog 2011-10-11 10:35:32 UTC (rev 97140) @@ -1,5 +1,11 @@ 2011-10-11 Pavel Podivilov podivi...@chromium.org +Unreviewed, mark two accessibility tests as failing on chromium. + +* platform/chromium/test_expectations.txt: + +2011-10-11 Pavel Podivilov podivi...@chromium.org + Unreviewed, rebaseline test expectations after r104864 (chromium). * platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97139 => 97140) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-11 10:30:54 UTC (rev 97139) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-11 10:35:32 UTC (rev 97140) @@ -1002,6 +1002,10 @@ BUGCR10322 SKIP : accessibility/transformed-element.html = TEXT BUGCR10322 SKIP : accessibility/visible-elements.html = TEXT +// Started to fail after r97128. +BUGWK69827 LINUX MAC DEBUG : accessibility/image-map-update-parent-crash.html = TIMEOUT +BUGWK69827 MAC : accessibility/aria-roles.html = TEXT + // - // Test failures with Skia GPU rendering of canvas 2D // - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97145] trunk/Source/WebKit/chromium
Title: [97145] trunk/Source/WebKit/chromium
Revision 97145
Author podivi...@chromium.org
Date 2011-10-11 04:51:23 -0700 (Tue, 11 Oct 2011)
Log Message
2011-10-11 Pavel Podivilov podivi...@chromium.org
Unreviewed, roll chromium revision to pick HTML speech input images update.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (97144 => 97145)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-11 11:34:57 UTC (rev 97144)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-11 11:51:23 UTC (rev 97145)
@@ -1,3 +1,9 @@
+2011-10-11 Pavel Podivilov podivi...@chromium.org
+
+Unreviewed, roll chromium revision to pick HTML speech input images update.
+
+* DEPS:
+
2011-10-11 Antoine Labour pi...@chromium.org
Expose WebLayer::isNull
Modified: trunk/Source/WebKit/chromium/DEPS (97144 => 97145)
--- trunk/Source/WebKit/chromium/DEPS 2011-10-11 11:34:57 UTC (rev 97144)
+++ trunk/Source/WebKit/chromium/DEPS 2011-10-11 11:51:23 UTC (rev 97145)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '104381'
+ 'chromium_rev': '104864'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97151] trunk
Title: [97151] trunk Revision 97151 Author podivi...@chromium.org Date 2011-10-11 07:04:55 -0700 (Tue, 11 Oct 2011) Log Message Web Inspector: implement CompilerSourceMappingProvider. https://bugs.webkit.org/show_bug.cgi?id=69423 Reviewed by Pavel Feldman. Source/WebCore: CompilerSourceMappingProvider implements a cross-domain communication channel for loading source mappings and source files. Front-end page can't send XHRs to source mapping server directly due to SOP restrictions. Instead, we inject an invisible iframe that is loaded from source mapping server and use window.postMessage to communicate with it. iframe has a different origin and thus doesn't have access to front-end window. Test: http/tests/inspector/compiler-source-mapping-provider.html * inspector/front-end/CompilerSourceMappingProvider.js: (WebInspector.CompilerSourceMappingProvider): (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded.didLoadData): (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded): (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping): (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode): (WebInspector.CompilerSourceMappingProvider.prototype._sendRequest): (WebInspector.CompilerSourceMappingProvider.prototype._onMessage): (WebInspector.CompilerSourceMappingProvider.prototype._cancelRequest): * inspector/front-end/inspector.js: (WebInspector.installSourceMappingForTest): LayoutTests: * http/tests/inspector/compiler-source-mapping-provider-expected.txt: Added. * http/tests/inspector/compiler-source-mapping-provider.html: Added. * http/tests/inspector/resources/compiler-source-mapping-provider/app-map: Added. * http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html: Added. * http/tests/inspector/resources/compiler-source-mapping-provider/app.js: Added. (window.onload): (handleClick): * http/tests/inspector/resources/compiler-source-mapping-provider/foo.js: Added. (ClickHandler): (ClickHandler.prototype.handle): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/CompilerSourceMappingProvider.js trunk/Source/WebCore/inspector/front-end/inspector.js Added Paths trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider-expected.txt trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider.html trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/ trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/app.js trunk/LayoutTests/http/tests/inspector/resources/compiler-source-mapping-provider/foo.js Diff Modified: trunk/LayoutTests/ChangeLog (97150 => 97151) --- trunk/LayoutTests/ChangeLog 2011-10-11 13:30:56 UTC (rev 97150) +++ trunk/LayoutTests/ChangeLog 2011-10-11 14:04:55 UTC (rev 97151) @@ -1,3 +1,21 @@ +2011-10-05 Pavel Podivilov podivi...@chromium.org + +Web Inspector: implement CompilerSourceMappingProvider. +https://bugs.webkit.org/show_bug.cgi?id=69423 + +Reviewed by Pavel Feldman. + +* http/tests/inspector/compiler-source-mapping-provider-expected.txt: Added. +* http/tests/inspector/compiler-source-mapping-provider.html: Added. +* http/tests/inspector/resources/compiler-source-mapping-provider/app-map: Added. +* http/tests/inspector/resources/compiler-source-mapping-provider/app-map.html: Added. +* http/tests/inspector/resources/compiler-source-mapping-provider/app.js: Added. +(window.onload): +(handleClick): +* http/tests/inspector/resources/compiler-source-mapping-provider/foo.js: Added. +(ClickHandler): +(ClickHandler.prototype.handle): + 2011-10-11 Mike Reed r...@google.com re-add support for GDI text behind a compile flag Added: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider-expected.txt (0 => 97151) --- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider-expected.txt 2011-10-11 14:04:55 UTC (rev 97151) @@ -0,0 +1,8 @@ +Tests CompilerSourceMappingProvider class. + + +Running: testLoad + +Running: testTimeout +log: Request timed out. + Property changes on: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider-expected.txt ___ Added: svn:eol-style Added: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider.html (0 => 97151) --- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-provider.html (rev 0)
[webkit-changes] [97051] trunk/Source/WebCore
Title: [97051] trunk/Source/WebCore Revision 97051 Author podivi...@chromium.org Date 2011-10-10 03:08:08 -0700 (Mon, 10 Oct 2011) Log Message 2011-10-10 Pavel Podivilov podivi...@chromium.org Unreviewed, attempt to fix chromium mac build after r97034. * platform/ScrollAnimatorNone.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ScrollAnimatorNone.h Diff Modified: trunk/Source/WebCore/ChangeLog (97050 => 97051) --- trunk/Source/WebCore/ChangeLog 2011-10-10 09:54:02 UTC (rev 97050) +++ trunk/Source/WebCore/ChangeLog 2011-10-10 10:08:08 UTC (rev 97051) @@ -1,3 +1,9 @@ +2011-10-10 Pavel Podivilov podivi...@chromium.org + +Unreviewed, attempt to fix chromium mac build after r97034. + +* platform/ScrollAnimatorNone.h: + 2011-10-10 Ilya Tikhonovsky loi...@chromium.org Web Inspector: small memory leak in scripts panel. Modified: trunk/Source/WebCore/platform/ScrollAnimatorNone.h (97050 => 97051) --- trunk/Source/WebCore/platform/ScrollAnimatorNone.h 2011-10-10 09:54:02 UTC (rev 97050) +++ trunk/Source/WebCore/platform/ScrollAnimatorNone.h 2011-10-10 10:08:08 UTC (rev 97051) @@ -150,7 +150,7 @@ double m_desiredTransY; }; -friend class ZoomData; +friend struct ZoomData; void animationTimerFired(TimerScrollAnimatorNone*); void stopAnimationTimerIfNeeded(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97053] trunk/Source/WebKit/chromium
Title: [97053] trunk/Source/WebKit/chromium
Revision 97053
Author podivi...@chromium.org
Date 2011-10-10 04:27:59 -0700 (Mon, 10 Oct 2011)
Log Message
2011-10-10 Pavel Podivilov podivi...@chromium.org
Unreviewed, mark CCThreadTest.startPostAndWaitOnCondition as flaky on win and mac.
* tests/CCThreadTest.cpp:
(WebKit::TEST):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (97052 => 97053)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-10 10:14:25 UTC (rev 97052)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-10 11:27:59 UTC (rev 97053)
@@ -1,3 +1,10 @@
+2011-10-10 Pavel Podivilov podivi...@chromium.org
+
+Unreviewed, mark CCThreadTest.startPostAndWaitOnCondition as flaky on win and mac.
+
+* tests/CCThreadTest.cpp:
+(WebKit::TEST):
+
2011-10-07 Yury Semikhatsky yu...@chromium.org
Web Inspector: allow to start WorkerContext paused
Modified: trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp (97052 => 97053)
--- trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp 2011-10-10 10:14:25 UTC (rev 97052)
+++ trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp 2011-10-10 11:27:59 UTC (rev 97053)
@@ -86,7 +86,13 @@
bool hit;
};
-TEST(CCThreadTest, startPostAndWaitOnCondition)
+#if OS(WINDOWS) || OS(MAC_OS_X)
+#define MAYBE_startPostAndWaitOnCondition DISABLED_startPostAndWaitOnCondition
+#else
+#define MAYBE_startPostAndWaitOnCondition startPostAndWaitOnCondition
+#endif
+
+TEST(CCThreadTest, MAYBE_startPostAndWaitOnCondition)
{
OwnPtrWebThread webThread = adoptPtr(webKitPlatformSupport()-createThread(test));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97056] trunk
Title: [97056] trunk
Revision 97056
Author podivi...@chromium.org
Date 2011-10-10 05:40:19 -0700 (Mon, 10 Oct 2011)
Log Message
Web Inspector: saving _javascript_ after live edit resets scroller position.
https://bugs.webkit.org/show_bug.cgi?id=69340
Source/WebCore:
Do not recreate SourceFrame when content is changed. Instead, update text model in existing SourceFrame.
Reviewed by Yury Semikhatsky.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._setReadOnly):
(WebInspector.SourceFrame.prototype.contentChanged):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.contentChanged):
LayoutTests:
Reviewed by Yury Semikhatsky.
* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/ui-source-code-expected.txt:
* inspector/debugger/ui-source-code.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/LayoutTests/inspector/debugger/scripts-panel.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (97055 => 97056)
--- trunk/LayoutTests/ChangeLog 2011-10-10 11:43:40 UTC (rev 97055)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 12:40:19 UTC (rev 97056)
@@ -1,3 +1,16 @@
+2011-10-06 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: saving _javascript_ after live edit resets scroller position.
+https://bugs.webkit.org/show_bug.cgi?id=69340
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/raw-source-code-expected.txt:
+* inspector/debugger/raw-source-code.html:
+* inspector/debugger/scripts-panel.html:
+* inspector/debugger/ui-source-code-expected.txt:
+* inspector/debugger/ui-source-code.html:
+
2011-10-09 Adam Barth aba...@webkit.org
CSP should log unrecognized directives to the console
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt (97055 => 97056)
--- trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt 2011-10-10 11:43:40 UTC (rev 97055)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt 2011-10-10 12:40:19 UTC (rev 97056)
@@ -7,8 +7,6 @@
Running: testHTMLWithFinishedResource
-Running: testContentEdited
-
Running: testForceUpdateSourceMapping
Running: testFormattingWithFinishedResource
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (97055 => 97056)
--- trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-10 11:43:40 UTC (rev 97055)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-10 12:40:19 UTC (rev 97056)
@@ -181,39 +181,6 @@
}
},
-function testContentEdited(next)
-{
-var script = createScriptMock(foo.js, 0, 0, true, script source);
-var resource = createFinishedResourceMock(script, resource content);
-var rawSourceCode = createRawSourceCode(script, resource);
-
-var sourceMapping = rawSourceCode.sourceMapping;
-var uiSourceCode = sourceMapping.uiSourceCode;
-uiSourceCode.requestContent(didRequestContent);
-
-function didRequestContent(mimeType, content)
-{
-InspectorTest.assertEquals(text/_javascript_, mimeType);
-InspectorTest.assertEquals(resource content, content);
-
-waitForSourceMappingEvent(rawSourceCode, mappingReadyAfterEdit);
-resource.content = edited resource content;
-rawSourceCode.contentEdited();
-}
-
-function mappingReadyAfterEdit()
-{
-rawSourceCode.sourceMapping.uiSourceCode.requestContent(didRequestContentAfterEdit);
-}
-
-function didRequestContentAfterEdit(mimeType, content)
-{
-InspectorTest.assertEquals(mimeType, text/_javascript_);
-InspectorTest.assertEquals(edited resource content, content);
-next();
-}
-},
-
function testForceUpdateSourceMap
[webkit-changes] [97060] trunk/LayoutTests
Title: [97060] trunk/LayoutTests
Revision 97060
Author podivi...@chromium.org
Date 2011-10-10 07:06:25 -0700 (Mon, 10 Oct 2011)
Log Message
2011-10-10 Pavel Podivilov podivi...@chromium.org
Unreviewed, fix test after r97056.
* inspector/debugger/script-formatter-expected.txt:
* inspector/debugger/script-formatter.html:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/script-formatter-expected.txt
trunk/LayoutTests/inspector/debugger/script-formatter.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97059 => 97060)
--- trunk/LayoutTests/ChangeLog 2011-10-10 13:24:59 UTC (rev 97059)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 14:06:25 UTC (rev 97060)
@@ -1,3 +1,11 @@
+2011-10-10 Pavel Podivilov podivi...@chromium.org
+
+Unreviewed, fix test after r97056.
+
+* inspector/debugger/script-formatter-expected.txt:
+* inspector/debugger/script-formatter.html:
+* platform/chromium/test_expectations.txt:
+
2011-10-06 Pavel Podivilov podivi...@chromium.org
Web Inspector: saving _javascript_ after live edit resets scroller position.
Modified: trunk/LayoutTests/inspector/debugger/script-formatter-expected.txt (97059 => 97060)
--- trunk/LayoutTests/inspector/debugger/script-formatter-expected.txt 2011-10-10 13:24:59 UTC (rev 97059)
+++ trunk/LayoutTests/inspector/debugger/script-formatter-expected.txt 2011-10-10 14:06:25 UTC (rev 97060)
@@ -18,18 +18,12 @@
Running: testBreakpointsInOriginalAndFormattedSource
Script execution paused.
-Call stack:
-0) f1 (script-formatter.html:12)
-1) (script-formatter.html:1)
Script execution resumed.
Page reloaded.
Navigated to test-navigation.html
Page reloaded.
Navigated back to test page.
Script execution paused.
-Call stack:
-0) f2 (script-formatter.html:17)
-1) (script-formatter.html:1)
Script execution resumed.
Running: testConsoleMessagesForFormattedScripts
Modified: trunk/LayoutTests/inspector/debugger/script-formatter.html (97059 => 97060)
--- trunk/LayoutTests/inspector/debugger/script-formatter.html 2011-10-10 13:24:59 UTC (rev 97059)
+++ trunk/LayoutTests/inspector/debugger/script-formatter.html 2011-10-10 14:06:25 UTC (rev 97060)
@@ -54,12 +54,12 @@
InspectorTest.showScriptSource(obfuscated.js, didShowScriptSource);
function didShowScriptSource(sourceFrame)
{
-formatter.formatContent(text/_javascript_, sourceFrame._content, didFormatContent);
+formatter.formatContent(text/_javascript_, sourceFrame._textModel.text, didFormatContent);
}
function didFormatContent(content, mapping)
{
-var source = WebInspector.panels.scripts.visibleView._content;
+var source = WebInspector.panels.scripts.visibleView._textModel.text;
var formattedSource = content;
function testMapping(string)
@@ -125,7 +125,7 @@
function pausedInF1(callFrames)
{
-InspectorTest.captureStackTrace(callFrames);
+InspectorTest.assertEquals(f1, callFrames[0].functionName);
InspectorTest.resumeExecution(resumed);
}
@@ -163,7 +163,7 @@
function pausedInF2(callFrames)
{
-InspectorTest.captureStackTrace(callFrames);
+InspectorTest.assertEquals(f2, callFrames[0].functionName);
panel._toggleFormatSource();
InspectorTest.resumeExecution(next);
}
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97059 => 97060)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-10 13:24:59 UTC (rev 97059)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-10 14:06:25 UTC (rev 97060)
@@ -156,7 +156,6 @@
WONTFIX SKIP : http/tests/eventsource/workers = PASS TIMEOUT FAIL
WONTFIX SKIP : http/tests/websocket/tests/hixie76/workers/ = PASS TIMEOUT FAIL
WONTFIX SKIP : http/tests/websocket/tests/hybi/workers/ = PASS TIMEOUT FAIL
-WONTFIX SKIP : inspector/debugger/script-formatter.html = PASS TIMEOUT FAIL
WONTFIX SKIP : http/tests/inspector/network/network-shared-worker.html = PASS TIMEOUT FAIL
WONTFIX SKIP : http/tests/inspector/network/network-worker.html = PASS TIMEOUT FAIL
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97063] trunk
Title: [97063] trunk
Revision 97063
Author podivi...@chromium.org
Date 2011-10-10 09:09:22 -0700 (Mon, 10 Oct 2011)
Log Message
Web Inspector: RawSourceCode could be mapped to multiple sources.
https://bugs.webkit.org/show_bug.cgi?id=68526
Source/WebCore:
Replace SourceMapping.uiSourceCode with SourceMapping.uiSourceCodeList as there could be more
then one UISourceCode associated with a RawSourceCode.
Reviewed by Pavel Feldman.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.PresentationCallFrame.prototype.get url):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiSourceCodeList):
(WebInspector.RawSourceCode.FormattedSourceMapping):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiSourceCodeList):
LayoutTests:
Reviewed by Pavel Feldman.
* inspector/debugger/raw-source-code.html:
* inspector/debugger/scripts-panel.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/LayoutTests/inspector/debugger/scripts-panel.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (97062 => 97063)
--- trunk/LayoutTests/ChangeLog 2011-10-10 14:51:44 UTC (rev 97062)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 16:09:22 UTC (rev 97063)
@@ -1,3 +1,13 @@
+2011-09-28 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: RawSourceCode could be mapped to multiple sources.
+https://bugs.webkit.org/show_bug.cgi?id=68526
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/raw-source-code.html:
+* inspector/debugger/scripts-panel.html:
+
2011-10-10 Zsolt Fehér fehe...@inf.u-szeged.hu
Unreviewed gardening after r96958.
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (97062 => 97063)
--- trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-10 14:51:44 UTC (rev 97062)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-10 16:09:22 UTC (rev 97063)
@@ -106,7 +106,8 @@
var rawSourceCode = createRawSourceCode(script, null);
var sourceMapping = rawSourceCode.sourceMapping;
-var uiSourceCode = sourceMapping.uiSourceCode;
+InspectorTest.assertEquals(1, sourceMapping.uiSourceCodeList().length);
+var uiSourceCode = sourceMapping.uiSourceCodeList()[0];
InspectorTest.assertEquals(foo.js, uiSourceCode.url);
InspectorTest.assertEquals(true, uiSourceCode.isContentScript);
InspectorTest.assertEquals(rawSourceCode, uiSourceCode.rawSourceCode);
@@ -136,7 +137,9 @@
function mappingReady(event)
{
InspectorTest.assertTrue(!event.data.oldSourceCode);
-var uiSourceCode = rawSourceCode.sourceMapping.uiSourceCode;
+var sourceMapping = rawSourceCode.sourceMapping;
+InspectorTest.assertEquals(1, sourceMapping.uiSourceCodeList().length);
+var uiSourceCode = sourceMapping.uiSourceCodeList()[0];
InspectorTest.assertEquals(index.html, uiSourceCode.url);
InspectorTest.assertEquals(false, uiSourceCode.isContentScript);
uiSourceCode.requestContent(didRequestContent);
@@ -161,7 +164,8 @@
var rawSourceCode = createRawSourceCode(script1, resource);
var sourceMapping = rawSourceCode.sourceMapping;
-var uiSourceCode = sourceMapping.uiSourceCode;
+InspectorTest.assertEquals(1, sourceMapping.uiSourceCodeList().length);
+var uiSourceCode = sourceMapping.uiSourceCodeList()[0];
InspectorTest.assertEquals(index.html, uiSourceCode.url);
InspectorTest.assertEquals(false, uiSourceCode.isContentScript);
uiSourceCode.requestContent(didRequestContent);
@@ -195,7 +199,10 @@
function requestC
[webkit-changes] [96924] trunk/Source/WebKit/chromium
Title: [96924] trunk/Source/WebKit/chromium
Revision 96924
Author podivi...@chromium.org
Date 2011-10-07 03:12:15 -0700 (Fri, 07 Oct 2011)
Log Message
2011-10-07 Pavel Podivilov podivi...@chromium.org
Unreviewed, fix mac build after r96909.
* public/WebContentLayer.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebContentLayer.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (96923 => 96924)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-07 09:53:43 UTC (rev 96923)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-07 10:12:15 UTC (rev 96924)
@@ -1,3 +1,9 @@
+2011-10-07 Pavel Podivilov podivi...@chromium.org
+
+Unreviewed, fix mac build after r96909.
+
+* public/WebContentLayer.h:
+
2011-10-07 Anna Cavender ann...@chromium.org
Turn ENABLE_VIDEO_TRACK on for chromium.
Modified: trunk/Source/WebKit/chromium/public/WebContentLayer.h (96923 => 96924)
--- trunk/Source/WebKit/chromium/public/WebContentLayer.h 2011-10-07 09:53:43 UTC (rev 96923)
+++ trunk/Source/WebKit/chromium/public/WebContentLayer.h 2011-10-07 10:12:15 UTC (rev 96924)
@@ -32,7 +32,7 @@
namespace WebKit {
class WebContentLayerClient;
class WebContentLayerImpl;
-class WebFloatRect;
+struct WebFloatRect;
class WebLayerClient;
class WebContentLayer : public WebLayer {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96926] trunk/Source/WebKit/chromium
Title: [96926] trunk/Source/WebKit/chromium
Revision 96926
Author podivi...@chromium.org
Date 2011-10-07 03:54:20 -0700 (Fri, 07 Oct 2011)
Log Message
2011-10-07 Pavel Podivilov podivi...@chromium.org
Unreviewed, revert r96924.
* public/WebContentLayer.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebContentLayer.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (96925 => 96926)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-07 10:19:25 UTC (rev 96925)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-07 10:54:20 UTC (rev 96926)
@@ -1,5 +1,11 @@
2011-10-07 Pavel Podivilov podivi...@chromium.org
+Unreviewed, revert r96924.
+
+* public/WebContentLayer.h:
+
+2011-10-07 Pavel Podivilov podivi...@chromium.org
+
Unreviewed, fix mac build after r96909.
* public/WebContentLayer.h:
Modified: trunk/Source/WebKit/chromium/public/WebContentLayer.h (96925 => 96926)
--- trunk/Source/WebKit/chromium/public/WebContentLayer.h 2011-10-07 10:19:25 UTC (rev 96925)
+++ trunk/Source/WebKit/chromium/public/WebContentLayer.h 2011-10-07 10:54:20 UTC (rev 96926)
@@ -32,7 +32,7 @@
namespace WebKit {
class WebContentLayerClient;
class WebContentLayerImpl;
-struct WebFloatRect;
+class WebFloatRect;
class WebLayerClient;
class WebContentLayer : public WebLayer {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96930] trunk/Source
Title: [96930] trunk/Source
Revision 96930
Author podivi...@chromium.org
Date 2011-10-07 05:17:00 -0700 (Fri, 07 Oct 2011)
Log Message
Unreviewed, rolling out r96879.
http://trac.webkit.org/changeset/96879
https://bugs.webkit.org/show_bug.cgi?id=69618
Broke CCLayerTreeHostTestShortlived1 on chromium mac.
(Requested by podivilov on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-10-07
Source/WebCore:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
Source/WebKit/chromium:
* features.gypi:
* src/WebViewImpl.h:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onEndTest):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96929 => 96930)
--- trunk/Source/WebCore/ChangeLog 2011-10-07 11:35:25 UTC (rev 96929)
+++ trunk/Source/WebCore/ChangeLog 2011-10-07 12:17:00 UTC (rev 96930)
@@ -1,3 +1,14 @@
+2011-10-07 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r96879.
+http://trac.webkit.org/changeset/96879
+https://bugs.webkit.org/show_bug.cgi?id=69618
+
+Broke CCLayerTreeHostTestShortlived1 on chromium mac.
+(Requested by podivilov on #webkit).
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+
2011-10-07 Pavel Feldman pfeld...@google.com
Web Inspector: add ResourcesPanel to the compilation.
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h (96929 => 96930)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h 2011-10-07 11:35:25 UTC (rev 96929)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h 2011-10-07 12:17:00 UTC (rev 96930)
@@ -54,10 +54,9 @@
virtual void applyScrollDelta(const IntSize) = 0;
virtual PassRefPtrGraphicsContext3D createLayerTreeHostContext3D() = 0;
virtual void didRecreateGraphicsContext(bool success) = 0;
-
-// Used in the non-threaded path
+#if !USE(THREADED_COMPOSITING)
virtual void scheduleComposite() = 0;
-
+#endif
protected:
virtual ~CCLayerTreeHostClient() { }
};
Modified: trunk/Source/WebKit/chromium/ChangeLog (96929 => 96930)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-07 11:35:25 UTC (rev 96929)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-07 12:17:00 UTC (rev 96930)
@@ -1,5 +1,20 @@
2011-10-07 Sheriff Bot webkit.review@gmail.com
+Unreviewed, rolling out r96879.
+http://trac.webkit.org/changeset/96879
+https://bugs.webkit.org/show_bug.cgi?id=69618
+
+Broke CCLayerTreeHostTestShortlived1 on chromium mac.
+(Requested by podivilov on #webkit).
+
+* features.gypi:
+* src/WebViewImpl.h:
+* tests/CCLayerTreeHostTest.cpp:
+(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
+(WTF::CCLayerTreeHostTest::onEndTest):
+
+2011-10-07 Sheriff Bot webkit.review@gmail.com
+
Unreviewed, rolling out r96909.
http://trac.webkit.org/changeset/96909
https://bugs.webkit.org/show_bug.cgi?id=69616
Modified: trunk/Source/WebKit/chromium/features.gypi (96929 => 96930)
--- trunk/Source/WebKit/chromium/features.gypi 2011-10-07 11:35:25 UTC (rev 96929)
+++ trunk/Source/WebKit/chromium/features.gypi 2011-10-07 12:17:00 UTC (rev 96930)
@@ -108,6 +108,7 @@
# through GYP_DEFINES.
'variables': {
'use_accelerated_compositing%': 1,
+ 'use_threaded_compositing%': 0,
'enable_svg%': 1,
'enable_touch_events%': 1,
'use_skia_gpu%': 0,
@@ -116,6 +117,7 @@
'enable_css3_flexbox%': 0,
},
'use_accelerated_compositing%': '(use_accelerated_compositing)',
+'use_threaded_compositing%': '(use_threaded_compositing)',
'enable_svg%': '(enable_svg)',
'enable_touch_events%': '(enable_touch_events)',
'use_skia%': '(use_skia)',
@@ -140,6 +142,11 @@
'ENABLE_ACCELERATED_2D_CANVAS=1',
],
}],
+ ['use_accelerated_compositing==1 and use_threaded_compositing==1', {
+'feature_defines': [
+ 'WTF_USE_THREADED_COMPOSITING=1',
+],
+ }],
['touchui==1', {
'enable_touch_icon_loading': 1,
}],
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (96929 => 96930)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-10-07 11:35:25 UTC (rev 96929)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-10-07 12:17:00 UTC (rev 96930)
@@ -223,8 +223,9 @@
virtual void applyScrollDelta(const WebCore::IntSize);
virtual PassRefPtrWebCore::GraphicsContext3D createLayerTreeHostContext3D();
virtual void didRecreateGraphicsContext(bool succes
[webkit-changes] [96937] trunk/Source/WebCore
Title: [96937] trunk/Source/WebCore
Revision 96937
Author podivi...@chromium.org
Date 2011-10-07 07:56:12 -0700 (Fri, 07 Oct 2011)
Log Message
Unreviewed, rolling out r96892.
http://trac.webkit.org/changeset/96892
https://bugs.webkit.org/show_bug.cgi?id=69626
it broke windows canary bots (Requested by podivilov on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-10-07
* WebCore.gyp/scripts/rule_binding.py:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/scripts/rule_binding.py
Diff
Modified: trunk/Source/WebCore/ChangeLog (96936 => 96937)
--- trunk/Source/WebCore/ChangeLog 2011-10-07 14:49:45 UTC (rev 96936)
+++ trunk/Source/WebCore/ChangeLog 2011-10-07 14:56:12 UTC (rev 96937)
@@ -1,3 +1,14 @@
+2011-10-07 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r96892.
+http://trac.webkit.org/changeset/96892
+https://bugs.webkit.org/show_bug.cgi?id=69626
+
+it broke windows canary bots (Requested by podivilov on
+#webkit).
+
+* WebCore.gyp/scripts/rule_binding.py:
+
2011-10-07 Andreas Kling kl...@webkit.org
Shrink StyleInheritedData.
Modified: trunk/Source/WebCore/WebCore.gyp/scripts/rule_binding.py (96936 => 96937)
--- trunk/Source/WebCore/WebCore.gyp/scripts/rule_binding.py 2011-10-07 14:49:45 UTC (rev 96936)
+++ trunk/Source/WebCore/WebCore.gyp/scripts/rule_binding.py 2011-10-07 14:56:12 UTC (rev 96937)
@@ -49,6 +49,7 @@
import os
import shlex
import shutil
+import subprocess
import sys
@@ -123,9 +124,13 @@
command.extend(['--outputHeadersDir', hdir])
command.extend(['--outputDir', cppdir, input])
-# Do it.
-os.execvp('perl', command)
+# Do it. check_call is new in 2.5, so simulate its behavior with call and
+# assert.
+returnCode = subprocess.call(command)
+assert returnCode == 0
+return returnCode
+
if __name__ == '__main__':
-main(sys.argv)
+sys.exit(main(sys.argv))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96585] trunk
Title: [96585] trunk
Revision 96585
Author podivi...@chromium.org
Date 2011-10-04 05:32:51 -0700 (Tue, 04 Oct 2011)
Log Message
Web Inspector: add compiler source mapping support to RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=68891
Reviewed by Pavel Feldman.
Source/WebCore:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
* inspector/front-end/CompilerSourceMappingProvider.js: Added.
(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.get uiSourceCodeList):
(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
* inspector/front-end/UISourceCodeContentProviders.js:
(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
LayoutTests:
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/breakpoint-manager.html
trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/inspector/front-end/BreakpointManager.js
trunk/Source/WebCore/inspector/front-end/ContentProviders.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/WebKit.qrc
trunk/Source/WebCore/inspector/front-end/inspector.html
Added Paths
trunk/Source/WebCore/inspector/front-end/CompilerSourceMappingProvider.js
Diff
Modified: trunk/LayoutTests/ChangeLog (96584 => 96585)
--- trunk/LayoutTests/ChangeLog 2011-10-04 11:37:25 UTC (rev 96584)
+++ trunk/LayoutTests/ChangeLog 2011-10-04 12:32:51 UTC (rev 96585)
@@ -1,3 +1,14 @@
+2011-09-29 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: add compiler source mapping support to RawSourceCode.
+https://bugs.webkit.org/show_bug.cgi?id=68891
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/breakpoint-manager.html:
+* inspector/debugger/raw-source-code-expected.txt:
+* inspector/debugger/raw-source-code.html:
+
2011-10-04 Hans Wennborg h...@chromium.org
[Chromium] Update expectations for svg/W3C-SVG-1.1/pservers-grad-06-b.svg
Modified: trunk/LayoutTests/inspector/debugger/breakpoint-manager.html (96584 => 96585)
--- trunk/LayoutTests/inspector/debugger/breakpoint-manager.html 2011-10-04 11:37:25 UTC (rev 96584)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-manager.html 2011-10-04 12:32:51 UTC (rev 96585)
@@ -69,10 +69,10 @@
var uiSourceCodeA = createUISourceCode(a.js, a.js,
function(rawLocation) { return rawLocation; },
-function(lineNumber, columnNumber) { return { scriptId: a.js, lineNumber: lineNumber, columnNumber: columnNumber }; });
+function(uiSourceCode, lineNumber) { return { scriptId: a.js, lineNumber: lineNumber, columnNumber: 0 }; });
var uiSourceCodeB = createUISourceCode(b.js, b.js,
function(rawLocation) { return rawLocation; },
-function(lineNumber, columnNumber) { return { scriptId: b.js, lineNumber: lineNumber, columnNumber: columnNumber }; });
+function(uiSourceCode, lineNumber) { return { scriptId: b.js, line
[webkit-changes] [96588] trunk/Source/WebCore
Title: [96588] trunk/Source/WebCore Revision 96588 Author podivi...@chromium.org Date 2011-10-04 06:24:01 -0700 (Tue, 04 Oct 2011) Log Message Web Inspector: update call frame location when source mapping is changed. https://bugs.webkit.org/show_bug.cgi?id=68997 Currently we use fake debugger-paused event hack to update execution line and call stack placards when source mapping is changed. - add PresentationCallFrame.createPlacard method to create live placards that are updated on source mapping changes. - remove PresentationCallFrame functionName, isInternalScript, and url getters. - fire execution-line-changed event when selected call frame or source mapping is changed. Reviewed by Pavel Feldman. * inspector/compile-front-end.sh: * inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): * inspector/front-end/CompilerSourceMapping.js: (WebInspector.ClosureCompilerSourceMappingPayload): (WebInspector.ClosureCompilerSourceMapping): (WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings): * inspector/front-end/ContentProviders.js: (WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent): (WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.createPlacard.updatePlacard): (WebInspector.DebuggerPresentationModel.prototype.createPlacard): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._debuggerResumed): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._dispatchExecutionLineChanged): (WebInspector.DebuggerPresentationModel.prototype._debuggerReset): (WebInspector.PresentationCallFrame): (WebInspector.PresentationCallFrame.prototype.get rawSourceCode): (WebInspector.PresentationCallFrame.prototype.uiLocation): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetUILocation): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._executionLineChanged): (WebInspector.ScriptsPanel.prototype._callFrameSelected): * inspector/front-end/externs.js: (WebInspector.displayNameForURL): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/compile-front-end.sh trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js trunk/Source/WebCore/inspector/front-end/ContentProviders.js trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js trunk/Source/WebCore/inspector/front-end/externs.js Diff Modified: trunk/Source/WebCore/ChangeLog (96587 => 96588) --- trunk/Source/WebCore/ChangeLog 2011-10-04 12:58:27 UTC (rev 96587) +++ trunk/Source/WebCore/ChangeLog 2011-10-04 13:24:01 UTC (rev 96588) @@ -1,3 +1,46 @@ +2011-10-04 Pavel Podivilov podivi...@chromium.org + +Web Inspector: update call frame location when source mapping is changed. +https://bugs.webkit.org/show_bug.cgi?id=68997 + +Currently we use fake debugger-paused event hack to update execution line and call stack placards when source mapping is changed. +- add PresentationCallFrame.createPlacard method to create live placards that are updated on source mapping changes. +- remove PresentationCallFrame functionName, isInternalScript, and url getters. +- fire execution-line-changed event when selected call frame or source mapping is changed. + +Reviewed by Pavel Feldman. + +* inspector/compile-front-end.sh: +* inspector/front-end/CallStackSidebarPane.js: +(WebInspector.CallStackSidebarPane.prototype.update): +* inspector/front-end/CompilerSourceMapping.js: +(WebInspector.ClosureCompilerSourceMappingPayload): +(WebInspector.ClosureCompilerSourceMapping): +(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings): +* inspector/front-end/ContentProviders.js: +(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent): +(WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent): +* inspector/front-end/DebuggerPresentationModel.js: +(WebInspector.DebuggerPresentationModel): +(WebInspector.DebuggerPresentationModel.prototype.createPlacard.updatePlacard): +(WebInspector.DebuggerPresentationModel.prototype.createPlacard): +(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): +(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed): +(WebInspector.DebuggerPresentationModel.prototype.
[webkit-changes] [96313] trunk
Title: [96313] trunk Revision 96313 Author podivi...@chromium.org Date 2011-09-29 01:44:57 -0700 (Thu, 29 Sep 2011) Log Message Web Inspector: split SourceFile.js into RawSourceCode.js and UISourceCodeContentProviders.js. https://bugs.webkit.org/show_bug.cgi?id=69068 Reviewed by Yury Semikhatsky. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/RawSourceCode.js: Renamed from Source/WebCore/inspector/front-end/SourceFile.js. (WebInspector.RawSourceCode): Moved from SourceFile.js. (WebInspector.UILocation): Moved from SourceFile.js. * inspector/front-end/UISourceCodeContentProviders.js: Added. Moved ContentProvider implementations from SourceFile.js (WebInspector.ScriptContentProvider): (WebInspector.ScriptContentProvider.prototype.requestContent): (WebInspector.ConcatenatedScriptsContentProvider): (WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent): (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk): (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent): (WebInspector.ResourceContentProvider): (WebInspector.ResourceContentProvider.prototype.requestContent): (WebInspector.StaticContentProvider): (WebInspector.StaticContentProvider.prototype.requestContent): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/inspector/front-end/WebKit.qrc trunk/Source/WebCore/inspector/front-end/inspector.html Added Paths trunk/Source/WebCore/inspector/front-end/ContentProviders.js trunk/Source/WebCore/inspector/front-end/RawSourceCode.js Removed Paths trunk/LayoutTests/inspector/debugger/source-file-expected.txt trunk/Source/WebCore/inspector/front-end/SourceFile.js Diff Deleted: trunk/LayoutTests/inspector/debugger/source-file-expected.txt (96312 => 96313) --- trunk/LayoutTests/inspector/debugger/source-file-expected.txt 2011-09-29 08:36:04 UTC (rev 96312) +++ trunk/LayoutTests/inspector/debugger/source-file-expected.txt 2011-09-29 08:44:57 UTC (rev 96313) @@ -1,13 +0,0 @@ -Tests mapping between raw locations and ui locations. - - -Running: testPlainConvertLocation - -Running: testConcatenatedConvertLocation - -Running: testFormattedConvertLocation - -Running: testConcatenatedFormattedConvertLocation - -Running: testUISourceCodeAdded - Modified: trunk/Source/WebCore/ChangeLog (96312 => 96313) --- trunk/Source/WebCore/ChangeLog 2011-09-29 08:36:04 UTC (rev 96312) +++ trunk/Source/WebCore/ChangeLog 2011-09-29 08:44:57 UTC (rev 96313) @@ -1,3 +1,29 @@ +2011-09-29 Pavel Podivilov podivi...@chromium.org + +Web Inspector: split SourceFile.js into RawSourceCode.js and UISourceCodeContentProviders.js. +https://bugs.webkit.org/show_bug.cgi?id=69068 + +Reviewed by Yury Semikhatsky. + +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* inspector/front-end/RawSourceCode.js: Renamed from Source/WebCore/inspector/front-end/SourceFile.js. +(WebInspector.RawSourceCode): Moved from SourceFile.js. +(WebInspector.UILocation): Moved from SourceFile.js. +* inspector/front-end/UISourceCodeContentProviders.js: Added. Moved ContentProvider implementations from SourceFile.js +(WebInspector.ScriptContentProvider): +(WebInspector.ScriptContentProvider.prototype.requestContent): +(WebInspector.ConcatenatedScriptsContentProvider): +(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent): +(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk): +(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent): +(WebInspector.ResourceContentProvider): +(WebInspector.ResourceContentProvider.prototype.requestContent): +(WebInspector.StaticContentProvider): +(WebInspector.StaticContentProvider.prototype.requestContent): +* inspector/front-end/WebKit.qrc: +* inspector/front-end/inspector.html: + 2011-09-29 Philippe Normand pnorm...@igalia.com [GStreamer] 2 flaky media tests Modified: trunk/Source/WebCore/WebCore.gypi (96312 => 96313) --- trunk/Source/WebCore/WebCore.gypi 2011-09-29 08:36:04 UTC (rev 96312) +++ trunk/Source/WebCore/WebCore.gypi 2011-09-29 08:44:57 UTC (rev 96313) @@ -6225,6 +6225,7 @@ 'inspector/front-end/ConsolePanel.js', 'inspector/front-end/ConsoleView.js', 'inspector/front-end/_javascript_ContextManager.js', +'inspector/front-end/ContentProviders.js', 'inspector/front-end/ContextMenu.js', 'inspector/front-end/CookieItemsView.js', 'inspector/front-end/CookieParser.js', @@ -6288,6 +6289,7 @@ 'inspector/front-end/Profi
[webkit-changes] [96097] trunk
Title: [96097] trunk
Revision 96097
Author podivi...@chromium.org
Date 2011-09-27 05:06:28 -0700 (Tue, 27 Sep 2011)
Log Message
Web Inspector: migrate RawSourceCode clients to SourceMapping class.
https://bugs.webkit.org/show_bug.cgi?id=68524
Source/WebCore:
Clients should use uiSourceCode(), rawLocationToUILocation(), uiLocationToRawLocation() methods of SourceMapping class.
Initially, RawSourceCode may not have associated SourceMapping, so it is natural to extract this methods and associated state to a separate class.
Reviewed by Yury Semikhatsky.
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.PresentationCallFrame.prototype.get url):
(WebInspector.PresentationCallFrame.prototype.sourceLine.sourceMappingUpdated):
(WebInspector.PresentationCallFrame.prototype.sourceLine):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.get sourceMapping):
LayoutTests:
Reviewed by Yury Semikhatsky.
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/raw-source-code.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/breakpoint-manager.html
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/BreakpointManager.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/SourceFile.js
Diff
Modified: trunk/LayoutTests/ChangeLog (96096 => 96097)
--- trunk/LayoutTests/ChangeLog 2011-09-27 11:20:34 UTC (rev 96096)
+++ trunk/LayoutTests/ChangeLog 2011-09-27 12:06:28 UTC (rev 96097)
@@ -1,3 +1,13 @@
+2011-09-21 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: migrate RawSourceCode clients to SourceMapping class.
+https://bugs.webkit.org/show_bug.cgi?id=68524
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/breakpoint-manager.html:
+* inspector/debugger/raw-source-code.html:
+
2011-09-27 Vineet Chaudhary vineet.chaudh...@motorola.com
wrap attribute of textarea element cannot be accessed by _javascript_.
Modified: trunk/LayoutTests/inspector/debugger/breakpoint-manager.html (96096 => 96097)
--- trunk/LayoutTests/inspector/debugger/breakpoint-manager.html 2011-09-27 11:20:34 UTC (rev 96096)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-manager.html 2011-09-27 12:06:28 UTC (rev 96097)
@@ -58,23 +58,22 @@
serializedBreakpoints.push(createBreakpoint(a.js, 20, , false));
serializedBreakpoints.push(createBreakpoint(b.js, 3, , true));
-var uiSourceCodeA = {
-id: a.js,
-url: a.js,
-rawSourceCode: {
-rawLocationToUILocation: function(rawLocation) { return rawLocation; },
-uiLocationToRawLocation: function(lineNumber, columnNumber) { return { scriptId: a.js, lineNumber: lineNumber, columnNumber: columnNumber }; }
-}
-};
-var uiSourceCodeB = {
-id: b.js,
-url: b.js,
-rawSourceCode: {
-rawLocationToUILocation: function(rawLocation) { return rawLocation; },
-uiLocationToRawLocation: function(lineNumber, columnNumber) { return { scriptId: b.js, lineNumber: lineNumber, columnNumber: columnNumber }; }
-}
+function createUISourceCode(id, url, rawLocationToUILocation, uiLocationToRawLocation)
+{
+return {
+id: id,
+url: url,
+rawSourceCode: { sourceMapping : { rawLocationToUILocation: rawLocationToUILocation, uiLocationToRawLocation: uiLocationToRawLocation } }
+};
}
+var uiSourceCodeA = createUISourceCode(a.js, a.js,
+function(rawLocation) { return rawLocation; },
+function(lineNumber, columnNumber) { return { scriptId: a.js, lineNumber: lineNumber, columnNumber: columnNumber }; });
+var uiSourceCodeB = createUISourceCode(b.js, b.js,
+function(rawLocation) { return rawLo
[webkit-changes] [95797] trunk
Title: [95797] trunk
Revision 95797
Author podivi...@chromium.org
Date 2011-09-23 06:17:49 -0700 (Fri, 23 Sep 2011)
Log Message
Web Inspector: skip overlapping scripts when displaying concatenated content.
https://bugs.webkit.org/show_bug.cgi?id=68144
Source/WebCore:
Dynamically appended script tags have wrong offsets and cause troubles building concatenated content.
Reviewed by Pavel Feldman.
* inspector/front-end/SourceFile.js:
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
LayoutTests:
Reviewed by Pavel Feldman.
* inspector/debugger/content-providers-expected.txt:
* inspector/debugger/content-providers.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/content-providers-expected.txt
trunk/LayoutTests/inspector/debugger/content-providers.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SourceFile.js
Diff
Modified: trunk/LayoutTests/ChangeLog (95796 => 95797)
--- trunk/LayoutTests/ChangeLog 2011-09-23 13:04:46 UTC (rev 95796)
+++ trunk/LayoutTests/ChangeLog 2011-09-23 13:17:49 UTC (rev 95797)
@@ -1,3 +1,13 @@
+2011-09-15 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: skip overlapping scripts when displaying concatenated content.
+https://bugs.webkit.org/show_bug.cgi?id=68144
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/content-providers-expected.txt:
+* inspector/debugger/content-providers.html:
+
2011-09-23 Xan Lopez xlo...@igalia.com
[GTK] Rebaseline following r95745, r95725
Modified: trunk/LayoutTests/inspector/debugger/content-providers-expected.txt (95796 => 95797)
--- trunk/LayoutTests/inspector/debugger/content-providers-expected.txt 2011-09-23 13:04:46 UTC (rev 95796)
+++ trunk/LayoutTests/inspector/debugger/content-providers-expected.txt 2011-09-23 13:17:49 UTC (rev 95797)
@@ -2,15 +2,11 @@
Running: testScriptContentProvider
-Request foo.js source.
Running: testConcatenatedScriptsContentProvider
-Request foo.js source.
-Request bar.js source.
-Request baz.js source.
+ scriptfunction foo() { return 0; }/script
+ scriptfunction bar() { return 0; }/script
- scriptfunction foo() { return 0; }/script scriptfunction bar() { return 0; }/script
-
script
function baz()
{
Modified: trunk/LayoutTests/inspector/debugger/content-providers.html (95796 => 95797)
--- trunk/LayoutTests/inspector/debugger/content-providers.html 2011-09-23 13:04:46 UTC (rev 95796)
+++ trunk/LayoutTests/inspector/debugger/content-providers.html 2011-09-23 13:17:49 UTC (rev 95797)
@@ -12,7 +12,6 @@
return {
requestSource: function(callback)
{
-InspectorTest.addResult(Request + id + source.);
callback(source);
},
get lineOffset() { return range[0]; },
@@ -38,9 +37,10 @@
function testConcatenatedScriptsContentProvider(next)
{
var scripts = [];
-scripts.push(createMockScript(baz.js, \nfunction baz()\n{\n return 0;\n}\n, [3, 20]));
-scripts.push(createMockScript(foo.js, function foo() { return 0; }, [1, 10]));
-scripts.push(createMockScript(bar.js, function bar() { return 0; }, [1, 70]));
+scripts.push(createMockScript(1, \nfunction baz()\n{\n return 0;\n}\n, [3, 20]));
+scripts.push(createMockScript(2, function foo() { return 0; }, [0, 10]));
+scripts.push(createMockScript(3, function bar() { return 0; }, [1, 70]));
+scripts.push(createMockScript(4, this should not appear in displayed content, [0, 20]));
var contentProvider = new WebInspector.ConcatenatedScriptsContentProvider(scripts);
function didRequestContent(mimeType, content)
{
Modified: trunk/Source/WebCore/ChangeLog (95796 => 95797)
--- trunk/Source/WebCore/ChangeLog 2011-09-23 13:04:46 UTC (rev 95796)
+++ trunk/Source/WebCore/ChangeLog 2011-09-23 13:17:49 UTC (rev 95797)
@@ -1,3 +1,16 @@
+2011-09-15 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: skip overlapping scripts when displaying concatenated content.
+https://bugs.webkit.org/show_bug.cgi?id=68144
+
+Dynamically appended script tags have wrong offsets and cause troubles building concatenated content.
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/SourceFile.js:
+(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
+(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
+
2011-09-23 Ilya Tikhonovsky loi...@chromium.org
Web Inspector: file open dialog appears when user clicks on the
[webkit-changes] [95522] trunk/Source/WebCore
Title: [95522] trunk/Source/WebCore
Revision 95522
Author podivi...@chromium.org
Date 2011-09-20 02:28:50 -0700 (Tue, 20 Sep 2011)
Log Message
Web Inspector: extract RawSourceCode source mapping logic to helper classes.
https://bugs.webkit.org/show_bug.cgi?id=67789
Reviewed by Pavel Feldman.
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.FormattedSourceMapping):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.get uiSourceCode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SourceFile.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (95521 => 95522)
--- trunk/Source/WebCore/ChangeLog 2011-09-20 08:58:54 UTC (rev 95521)
+++ trunk/Source/WebCore/ChangeLog 2011-09-20 09:28:50 UTC (rev 95522)
@@ -1,3 +1,27 @@
+2011-09-08 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: extract RawSourceCode source mapping logic to helper classes.
+https://bugs.webkit.org/show_bug.cgi?id=67789
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/SourceFile.js:
+(WebInspector.RawSourceCode.prototype.get uiSourceCode):
+(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
+(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
+(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
+(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
+(WebInspector.RawSourceCode.prototype._createSourceMapping):
+(WebInspector.RawSourceCode.prototype._saveSourceMapping):
+(WebInspector.RawSourceCode.PlainSourceMapping):
+(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
+(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
+(WebInspector.RawSourceCode.PlainSourceMapping.prototype.get uiSourceCode):
+(WebInspector.RawSourceCode.FormattedSourceMapping):
+(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
+(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
+(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.get uiSourceCode):
+
2011-09-20 Carlos Garcia Campos cgar...@igalia.com
[GTK] WebProcess shouldn't use the GTK+ API
Modified: trunk/Source/WebCore/inspector/front-end/SourceFile.js (95521 => 95522)
--- trunk/Source/WebCore/inspector/front-end/SourceFile.js 2011-09-20 08:58:54 UTC (rev 95521)
+++ trunk/Source/WebCore/inspector/front-end/SourceFile.js 2011-09-20 09:28:50 UTC (rev 95522)
@@ -67,7 +67,8 @@
get uiSourceCode()
{
-return this._uiSourceCode;
+// FIXME: clients should use sourceMapping directly.
+return this._sourceMapping this._sourceMapping.uiSourceCode;
},
setFormatted: function(formatted)
@@ -91,17 +92,14 @@
rawLocationToUILocation: function(rawLocation)
{
-var location = this._mapping ? this._mapping.originalToFormatted(rawLocation) : rawLocation;
-return new WebInspector.UILocation(this.uiSourceCode, location.lineNumber, location.columnNumber);
+// FIXME: clients should use sourceMapping directly.
+return this._sourceMapping.rawLocationToUILocation(rawLocation);
},
uiLocationToRawLocation: function(lineNumber, columnNumber)
{
-var rawLocation = { lineNumber: lineNumber, columnNumber: columnNumber };
-if (this._mapping)
-rawLocation = this._mapping.formattedToOriginal(rawLocation);
-rawLocation.scriptId = this._scriptForRawLocation(rawLocation.lineNumber, rawLocation.columnNumber).scriptId;
-return rawLocation;
+// FIXME: clients should use sourceMapping directly.
+return this._sourceMapping.uiLocationToRawLocation(lineNumber, columnNumber);
},
_scriptForRawLocation: function(lineNumber, columnNumber)
@@ -160,7
[webkit-changes] [95524] trunk
Title: [95524] trunk
Revision 95524
Author podivi...@chromium.org
Date 2011-09-20 03:22:59 -0700 (Tue, 20 Sep 2011)
Log Message
Web Inspector: implement reverse mapping for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=67850
Source/WebCore:
Implement the mapping from source code to compiled code. It will be used for
setting breakpoints on source code.
Reviewed by Pavel Feldman.
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):
LayoutTests:
Reviewed by Pavel Feldman.
* inspector/debugger/compiler-source-mapping.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (95523 => 95524)
--- trunk/LayoutTests/ChangeLog 2011-09-20 09:41:16 UTC (rev 95523)
+++ trunk/LayoutTests/ChangeLog 2011-09-20 10:22:59 UTC (rev 95524)
@@ -1,3 +1,12 @@
+2011-09-09 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: implement reverse mapping for compiler source maps.
+https://bugs.webkit.org/show_bug.cgi?id=67850
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/compiler-source-mapping.html:
+
2011-09-20 Renata Hodovan r...@webkit.org
[Qt] Add Qt specific expecteds to new tests introduced in r95461.
Modified: trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html (95523 => 95524)
--- trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html 2011-09-20 09:41:16 UTC (rev 95523)
+++ trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html 2011-09-20 10:22:59 UTC (rev 95524)
@@ -14,31 +14,52 @@
InspectorTest.assertEquals(sourceColumnNumber, sourceLocation.columnNumber);
}
+function checkReverseMapping(compiledLineNumber, compiledColumnNumber, sourceURL, sourceLineNumber, mapping)
+{
+var compiledLocation = mapping.sourceLocationToCompiledLocation(sourceURL, sourceLineNumber);
+InspectorTest.assertEquals(compiledLineNumber, compiledLocation.lineNumber);
+InspectorTest.assertEquals(compiledColumnNumber, compiledLocation.columnNumber);
+}
+
InspectorTest.runTestSuite([
function testSimpleMapping(next)
{
-// example.js:
-// 0 1 2 3
-// 012345678901234567890123456789012345
-// function add(variable_x, variable_y)
-// {
-// return variable_x + variable_y;
-// }
-// example-compiled.js:
-// 0 1 2 3
-// 012345678901234567890123456789012345
-// function add(a,b){return a+b};
+/*
+example.js:
+0 1 2 3
+012345678901234567890123456789012345
+function add(variable_x, variable_y)
+{
+return variable_x + variable_y;
+}
+
+var global = foo;
+
+example-compiled.js:
+0 1 2 3
+012345678901234567890123456789012345
+function add(a,b){return a+b}var global=foo;
+*/
var mappingPayload = {
-mappings:AAASA,Q,IAAG,CAACC,CAAD,CAAaC,CAAb,CACZ,CACI,MAAOD,EAAP,CAAoBC,CADxB;,
+mappings:AAASA,Q,IAAG,CAACC,CAAD,CAAaC,CAAb,CACZ,CACI,MAAOD,EAAP,CAAoBC,CADxB,CAIA,IAAIC,OAAS;,
sources:[example.js]
};
var mapping = new WebInspector.ClosureCompilerSourceMapping(mappingPayload);
+
checkMapping(0, 9, example.js, 0, 9, mapping);
checkMapping(0, 13, example.js, 0, 13, mapping);
checkMapping(0, 15, example.js, 0, 25, mapping);
checkMapping(0, 18, example.js, 2, 4, mapping);
checkMapping(0, 25, example.js, 2, 11, mapping);
checkMapping(0, 27, example.js, 2, 24, mapping);
+
+checkReverseMapping(0, 0, example.js, 0, mapping);
+checkReverseMapping(0, 17, example.js, 1, mapping);
+checkReverseMapping(0, 18, example.js, 2, mapping);
+checkReverseMapping(0, 29, example.js, 4, mapping);
+checkReverseMapping(0, 29, example.js, 5, mapping);
+InspectorTest.assertTrue(!mapping.sourceLocationToCompiledLocation(example.js, 6));
+
next();
}
]);
Modified: trunk/
