[webkit-changes] [165826] trunk
Title: [165826] trunk
Revision 165826
Author r...@webkit.org
Date 2014-03-18 11:57:45 -0700 (Tue, 18 Mar 2014)
Log Message
Bad cast with toRenderBox in WebCore::RenderView::repaintViewRectangle
https://bugs.webkit.org/show_bug.cgi?id=129104
Reviewed by Simon Fraser.
Source/WebCore:
We should not cast the renderer of a RenderView's owner to RenderBox
unless we are sure it is one.
Test: plugins/crash-invalid-data-reference.html
* rendering/RenderView.cpp:
(WebCore::RenderView::repaintViewRectangle):
LayoutTests:
* plugins/crash-invalid-data-reference-expected.txt: Added.
* plugins/crash-invalid-data-reference.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderView.cpp
Added Paths
trunk/LayoutTests/plugins/crash-invalid-data-reference-expected.txt
trunk/LayoutTests/plugins/crash-invalid-data-reference.html
Diff
Modified: trunk/LayoutTests/ChangeLog (165825 => 165826)
--- trunk/LayoutTests/ChangeLog 2014-03-18 18:30:45 UTC (rev 165825)
+++ trunk/LayoutTests/ChangeLog 2014-03-18 18:57:45 UTC (rev 165826)
@@ -1,3 +1,13 @@
+2014-03-18 Renata Hodovan rhodovan.u-sze...@partner.samsung.com
+
+Bad cast with toRenderBox in WebCore::RenderView::repaintViewRectangle
+https://bugs.webkit.org/show_bug.cgi?id=129104
+
+Reviewed by Simon Fraser.
+
+* plugins/crash-invalid-data-reference-expected.txt: Added.
+* plugins/crash-invalid-data-reference.html: Added.
+
2014-03-18 Antti Koivisto an...@apple.com
Mutating rules returned by getMatchedCSSRules can result in crash
Added: trunk/LayoutTests/plugins/crash-invalid-data-reference-expected.txt (0 => 165826)
--- trunk/LayoutTests/plugins/crash-invalid-data-reference-expected.txt (rev 0)
+++ trunk/LayoutTests/plugins/crash-invalid-data-reference-expected.txt 2014-03-18 18:57:45 UTC (rev 165826)
@@ -0,0 +1 @@
+This test passes if it doesn't crash in debug. (Bug #129104)
Added: trunk/LayoutTests/plugins/crash-invalid-data-reference.html (0 => 165826)
--- trunk/LayoutTests/plugins/crash-invalid-data-reference.html (rev 0)
+++ trunk/LayoutTests/plugins/crash-invalid-data-reference.html 2014-03-18 18:57:45 UTC (rev 165826)
@@ -0,0 +1,14 @@
+html
+head
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+/script
+/head
+body
+ object data=""
+ div
+ This test passes if it doesn't crash in debug. (Bug #129104)
+ /div
+/body
+/html
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (165825 => 165826)
--- trunk/Source/WebCore/ChangeLog 2014-03-18 18:30:45 UTC (rev 165825)
+++ trunk/Source/WebCore/ChangeLog 2014-03-18 18:57:45 UTC (rev 165826)
@@ -1,3 +1,18 @@
+2014-03-18 Renata Hodovan rhodovan.u-sze...@partner.samsung.com
+
+Bad cast with toRenderBox in WebCore::RenderView::repaintViewRectangle
+https://bugs.webkit.org/show_bug.cgi?id=129104
+
+Reviewed by Simon Fraser.
+
+We should not cast the renderer of a RenderView's owner to RenderBox
+unless we are sure it is one.
+
+Test: plugins/crash-invalid-data-reference.html
+
+* rendering/RenderView.cpp:
+(WebCore::RenderView::repaintViewRectangle):
+
2014-03-18 Andreas Kling akl...@apple.com
Micro-optimize element descendant iterator.
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (165825 => 165826)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2014-03-18 18:30:45 UTC (rev 165825)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2014-03-18 18:57:45 UTC (rev 165826)
@@ -545,9 +545,9 @@
return;
if (auto ownerElement = document().ownerElement()) {
-if (!ownerElement-renderer())
+RenderBox* ownerBox = ownerElement-renderBox();
+if (!ownerBox)
return;
-auto ownerBox = toRenderBox(*ownerElement-renderer());
LayoutRect viewRect = this-viewRect();
#if PLATFORM(IOS)
// Don't clip using the visible rect since clipping is handled at a higher level on iPhone.
@@ -556,8 +556,8 @@
LayoutRect adjustedRect = intersection(repaintRect, viewRect);
#endif
adjustedRect.moveBy(-viewRect.location());
-adjustedRect.moveBy(ownerBox.contentBoxRect().location());
-ownerBox.repaintRectangle(adjustedRect);
+adjustedRect.moveBy(ownerBox-contentBoxRect().location());
+ownerBox-repaintRectangle(adjustedRect);
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [164783] trunk
Title: [164783] trunk
Revision 164783
Author r...@webkit.org
Date 2014-02-27 02:17:22 -0800 (Thu, 27 Feb 2014)
Log Message
Improving containing column block determination
https://bugs.webkit.org/show_bug.cgi?id=125449
Reviewed by Darin Adler.
Source/WebCore:
Making sure that the containing column block of any elements
can not be oneself.
Test: fast/css/crash-on-column-splitting.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::containingColumnsBlock):
(WebCore::RenderBlock::splitFlow):
LayoutTests:
* fast/css/crash-on-column-splitting-expected.txt: Added.
* fast/css/crash-on-column-splitting.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/fast/css/crash-on-column-splitting-expected.txt
trunk/LayoutTests/fast/css/crash-on-column-splitting.html
Diff
Modified: trunk/LayoutTests/ChangeLog (164782 => 164783)
--- trunk/LayoutTests/ChangeLog 2014-02-27 09:16:18 UTC (rev 164782)
+++ trunk/LayoutTests/ChangeLog 2014-02-27 10:17:22 UTC (rev 164783)
@@ -1,3 +1,13 @@
+2014-02-27 Renata Hodovan rhodovan.u-sze...@partner.samsung.com
+
+Improving containing column block determination
+https://bugs.webkit.org/show_bug.cgi?id=125449
+
+Reviewed by Darin Adler.
+
+* fast/css/crash-on-column-splitting-expected.txt: Added.
+* fast/css/crash-on-column-splitting.html: Added.
+
2014-02-27 Xabier Rodriguez Calvar calva...@igalia.com
[GTK] Improve _javascript_ multimedia controls
Added: trunk/LayoutTests/fast/css/crash-on-column-splitting-expected.txt (0 => 164783)
--- trunk/LayoutTests/fast/css/crash-on-column-splitting-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/crash-on-column-splitting-expected.txt 2014-02-27 10:17:22 UTC (rev 164783)
@@ -0,0 +1,7 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderText {#text} at (0,0) size 273x17
+text run at (0,0) width 273: PASS if it does not crash. See bug 125449.
Added: trunk/LayoutTests/fast/css/crash-on-column-splitting.html (0 => 164783)
--- trunk/LayoutTests/fast/css/crash-on-column-splitting.html (rev 0)
+++ trunk/LayoutTests/fast/css/crash-on-column-splitting.html 2014-02-27 10:17:22 UTC (rev 164783)
@@ -0,0 +1,24 @@
+html
+head
+ style type=text/css
+ .c1 { -webkit-column-width: 1px; }
+ /style
+ script
+ function afterload() {
+ document.getElementById(details).setAttribute('class', 'c1');
+ document.body.offsetTop;
+ document.getElementById(legend).style[color] = red;
+ document.body.innerHTML = PASS if it does not crash. See bug 125449.;
+ }
+ /script
+/head
+body _onload_=afterload()
+ b id=legend
+ div class=c1
+ details id=details opena
+summary id=summary style=-webkit-column-span: all;/summary
+ /details
+ /div
+ /b
+/body
+/html
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (164782 => 164783)
--- trunk/Source/WebCore/ChangeLog 2014-02-27 09:16:18 UTC (rev 164782)
+++ trunk/Source/WebCore/ChangeLog 2014-02-27 10:17:22 UTC (rev 164783)
@@ -1,3 +1,19 @@
+2014-02-27 Renata Hodovan rhodovan.u-sze...@partner.samsung.com
+
+Improving containing column block determination
+https://bugs.webkit.org/show_bug.cgi?id=125449
+
+Reviewed by Darin Adler.
+
+Making sure that the containing column block of any elements
+can not be oneself.
+
+Test: fast/css/crash-on-column-splitting.html
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::containingColumnsBlock):
+(WebCore::RenderBlock::splitFlow):
+
2014-02-27 Xabier Rodriguez Calvar calva...@igalia.com
[GTK] Improve _javascript_ multimedia controls
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (164782 => 164783)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-02-27 09:16:18 UTC (rev 164782)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-02-27 10:17:22 UTC (rev 164783)
@@ -465,7 +465,7 @@
RenderBlock* RenderBlock::containingColumnsBlock(bool allowAnonymousColumnBlock)
{
RenderBlock* firstChildIgnoringAnonymousWrappers = 0;
-for (RenderElement* curr = this; curr; curr = curr-parent()) {
+for (RenderElement* curr = parent(); curr; curr = curr-parent()) {
if (!curr-isRenderBlock() || curr-isFloatingOrOutOfFlowPositioned() || curr-isTableCell() || curr-isRoot() || curr-isRenderView() || curr-hasOverflowClip()
|| curr-isInlineBlockOrInlineTable())
return 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [164801] trunk/Tools
Title: [164801] trunk/Tools
Revision 164801
Author r...@webkit.org
Date 2014-02-27 06:03:38 -0800 (Thu, 27 Feb 2014)
Log Message
Unreviewed. Update my email addresses in contributors.json.
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (164800 => 164801)
--- trunk/Tools/ChangeLog 2014-02-27 14:02:41 UTC (rev 164800)
+++ trunk/Tools/ChangeLog 2014-02-27 14:03:38 UTC (rev 164801)
@@ -1,3 +1,9 @@
+2014-02-27 Renata Hodovan rhodovan.u-sze...@partner.samsung.com
+
+Unreviewed. Update my email addresses in contributors.json.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2014-02-27 Alberto Garcia be...@igalia.com
[gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (164800 => 164801)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-02-27 14:02:41 UTC (rev 164800)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-02-27 14:03:38 UTC (rev 164801)
@@ -2134,6 +2134,7 @@
},
Renata Hodovan : {
emails : [
+rhodovan.u-sze...@partner.samsung.com,
r...@webkit.org
],
nicks : [
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [158682] trunk
Title: [158682] trunk
Revision 158682
Author r...@webkit.org
Date 2013-11-05 11:16:38 -0800 (Tue, 05 Nov 2013)
Log Message
ASSERTION FAILED: isHTMLTitleElement(m_titleElement.get()) in WebCore::Document::setTitle
https://bugs.webkit.org/show_bug.cgi?id=122092
Reviewed by Darin Adler.
Source/WebCore:
Remove a bogus assert in Document::setTitle().
m_titleElement can be either of HTMLTitleElement or SVGTitleElement. The assertion was wrong.
Backported from Blink:
https://src.chromium.org/viewvc/blink?revision=158620view=revision
Test: svg/custom/title-assertion.html
* dom/Document.cpp:
(WebCore::Document::setTitle):
* svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedInto):
LayoutTests:
* svg/custom/title-assertion-expected.txt: Added.
* svg/custom/title-assertion.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/svg/SVGTitleElement.cpp
Added Paths
trunk/LayoutTests/svg/custom/title-assertion-expected.txt
trunk/LayoutTests/svg/custom/title-assertion.html
Diff
Modified: trunk/LayoutTests/ChangeLog (158681 => 158682)
--- trunk/LayoutTests/ChangeLog 2013-11-05 18:56:06 UTC (rev 158681)
+++ trunk/LayoutTests/ChangeLog 2013-11-05 19:16:38 UTC (rev 158682)
@@ -1,3 +1,13 @@
+2013-11-05 Renata Hodovan r...@webkit.org
+
+ASSERTION FAILED: isHTMLTitleElement(m_titleElement.get()) in WebCore::Document::setTitle
+https://bugs.webkit.org/show_bug.cgi?id=122092
+
+Reviewed by Darin Adler.
+
+* svg/custom/title-assertion-expected.txt: Added.
+* svg/custom/title-assertion.html: Added.
+
2013-11-05 Martin Robinson mrobin...@igalia.com
[MathML] Poor spacing around delimiters in MathML Torture Test 14
Added: trunk/LayoutTests/svg/custom/title-assertion-expected.txt (0 => 158682)
--- trunk/LayoutTests/svg/custom/title-assertion-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/title-assertion-expected.txt 2013-11-05 19:16:38 UTC (rev 158682)
@@ -0,0 +1,10 @@
+We had a bug that updating document.title caused an assertion failure.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS if any assertion does not fail.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/svg/custom/title-assertion.html (0 => 158682)
--- trunk/LayoutTests/svg/custom/title-assertion.html (rev 0)
+++ trunk/LayoutTests/svg/custom/title-assertion.html 2013-11-05 19:16:38 UTC (rev 158682)
@@ -0,0 +1,15 @@
+!DOCTYPE html
+html
+ script src=""
+ svg
+ titletitle/title
+ /svg
+
+ script
+ document.title = 'New title';
+ description('We had a bug that updating document.title caused an assertion failure.');
+ testPassed('if any assertion does not fail.');
+ /script
+
+ script src=""
+/html
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (158681 => 158682)
--- trunk/Source/WebCore/ChangeLog 2013-11-05 18:56:06 UTC (rev 158681)
+++ trunk/Source/WebCore/ChangeLog 2013-11-05 19:16:38 UTC (rev 158682)
@@ -1,3 +1,23 @@
+2013-11-05 Renata Hodovan r...@webkit.org
+
+ASSERTION FAILED: isHTMLTitleElement(m_titleElement.get()) in WebCore::Document::setTitle
+https://bugs.webkit.org/show_bug.cgi?id=122092
+
+Reviewed by Darin Adler.
+
+Remove a bogus assert in Document::setTitle().
+m_titleElement can be either of HTMLTitleElement or SVGTitleElement. The assertion was wrong.
+
+Backported from Blink:
+https://src.chromium.org/viewvc/blink?revision=158620view=revision
+
+Test: svg/custom/title-assertion.html
+
+* dom/Document.cpp:
+(WebCore::Document::setTitle):
+* svg/SVGTitleElement.cpp:
+(WebCore::SVGTitleElement::insertedInto):
+
2013-11-05 Martin Robinson mrobin...@igalia.com
[MathML] Poor spacing around delimiters in MathML Torture Test 14
Modified: trunk/Source/WebCore/dom/Document.cpp (158681 => 158682)
--- trunk/Source/WebCore/dom/Document.cpp 2013-11-05 18:56:06 UTC (rev 158681)
+++ trunk/Source/WebCore/dom/Document.cpp 2013-11-05 19:16:38 UTC (rev 158682)
@@ -1477,11 +1477,8 @@
// The DOM API has no method of specifying direction, so assume LTR.
updateTitle(StringWithDirection(title, LTR));
-if (m_titleElement) {
-ASSERT(isHTMLTitleElement(m_titleElement.get()));
-if (isHTMLTitleElement(m_titleElement.get()))
-toHTMLTitleElement(m_titleElement.get())-setText(title);
-}
+if (m_titleElement isHTMLTitleElement(m_titleElement.get()))
+toHTMLTitleElement(m_titleElement.get())-setText(title);
}
void Document::setTitleElement(const StringWithDirection title, Element* titleElement)
Modified: trunk/Source/WebCore/svg/SVGTitleElement.cpp (158681 => 158682)
--- trunk/Source/WebCore/svg/SVGTitleElement.cpp 2013-11-05 18:56:06 UTC (rev 158681)
+++
[webkit-changes] [156766] trunk
Title: [156766] trunk
Revision 156766
Author r...@webkit.org
Date 2013-10-02 03:14:51 -0700 (Wed, 02 Oct 2013)
Log Message
HTML listbox is not resized horizontally when zooming
https://bugs.webkit.org/show_bug.cgi?id=20445
Reviewed by Darin Adler.
Source/WebCore:
If any style changes happens on a HTMLSelectElement, we need to set the m_optionsChanged property
of its renderer (RenderListBox) otherwise its size won't follow the changed content.
Test: fast/transforms/listbox-zoom.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::didRecalcStyle):
* html/HTMLSelectElement.h:
LayoutTests:
A test with a zoomed listbox is added to check whether the styleChange is catched.
* fast/transforms/listbox-zoom.html: Added.
* fast/transforms/listbox-zoom-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLSelectElement.cpp
trunk/Source/WebCore/html/HTMLSelectElement.h
Added Paths
trunk/LayoutTests/fast/transforms/listbox-zoom-expected.txt
trunk/LayoutTests/fast/transforms/listbox-zoom.html
Diff
Modified: trunk/LayoutTests/ChangeLog (156765 => 156766)
--- trunk/LayoutTests/ChangeLog 2013-10-02 09:32:42 UTC (rev 156765)
+++ trunk/LayoutTests/ChangeLog 2013-10-02 10:14:51 UTC (rev 156766)
@@ -1,3 +1,15 @@
+2013-10-02 Renata Hodovan r...@webkit.org
+
+HTML listbox is not resized horizontally when zooming
+https://bugs.webkit.org/show_bug.cgi?id=20445
+
+Reviewed by Darin Adler.
+
+A test with a zoomed listbox is added to check whether the styleChange is catched.
+
+* fast/transforms/listbox-zoom.html: Added.
+* fast/transforms/listbox-zoom-expected.txt: Added.
+
2013-10-01 Santosh Mahto santosh...@samsung.com
contenteditable justify commands applied to next paragraph as well
Added: trunk/LayoutTests/fast/transforms/listbox-zoom-expected.txt (0 => 156766)
--- trunk/LayoutTests/fast/transforms/listbox-zoom-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/transforms/listbox-zoom-expected.txt 2013-10-02 10:14:51 UTC (rev 156766)
@@ -0,0 +1,3 @@
+
+The test passes if both dimensions (not only height) of the listbox is resized according to the zoom.
+PASS expected width: 55 width +/-10 allowance.
Added: trunk/LayoutTests/fast/transforms/listbox-zoom.html (0 => 156766)
--- trunk/LayoutTests/fast/transforms/listbox-zoom.html (rev 0)
+++ trunk/LayoutTests/fast/transforms/listbox-zoom.html 2013-10-02 10:14:51 UTC (rev 156766)
@@ -0,0 +1,34 @@
+html
+head
+ script
+ if (window.testRunner)
+ testRunner.dumpAsText()
+
+ function runTest() {
+ document.getElementById('toZoom').style.zoom = 2;
+
+ // Comparing the result to the expectation.
+ var expectedWidth = 55;
+ var realWidth = window.getComputedStyle(document.getElementById(toZoom)).getPropertyCSSValue('width').getFloatValue(CSSPrimitiveValue.CSS_NUMBER);
+ var result = ;
+ if (Math.abs(expectedWidth - realWidth) 10)
+ result = FAIL;
+ else
+ result = PASS;
+ result += expected width: + expectedWidth + width +/-10 allowance.;
+ document.getElementById('result').innerHTML = result;
+ }
+ /script
+/head
+
+body _onload_=runTest()
+
+select id=toZoom MULTIPLE
+ option value=firstfirst
+ option value=secondsecond
+/select
+
+divThe test passes if both dimensions (not only height) of the listbox is resized according to the zoom./div
+div id=result/
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (156765 => 156766)
--- trunk/Source/WebCore/ChangeLog 2013-10-02 09:32:42 UTC (rev 156765)
+++ trunk/Source/WebCore/ChangeLog 2013-10-02 10:14:51 UTC (rev 156766)
@@ -1,3 +1,19 @@
+2013-10-02 Renata Hodovan r...@webkit.org
+
+HTML listbox is not resized horizontally when zooming
+https://bugs.webkit.org/show_bug.cgi?id=20445
+
+Reviewed by Darin Adler.
+
+If any style changes happens on a HTMLSelectElement, we need to set the m_optionsChanged property
+of its renderer (RenderListBox) otherwise its size won't follow the changed content.
+
+Test: fast/transforms/listbox-zoom.html
+
+* html/HTMLSelectElement.cpp:
+(WebCore::HTMLSelectElement::didRecalcStyle):
+* html/HTMLSelectElement.h:
+
2013-10-01 Santosh Mahto santosh...@samsung.com
contenteditable justify commands applied to next paragraph as well
Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (156765 => 156766)
--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2013-10-02 09:32:42 UTC (rev 156765)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2013-10-02 10:14:51 UTC (rev 156766)
@@ -86,6 +86,14 @@
return adoptRef(new HTMLSelectElement(tagName, document, form));
}
+void HTMLSelectElement::didRecalcStyle(Style::Change styleChange)
+{
+// Even though the options didn't necessarily change, we will call setOptionsChangedOnRenderer for its side effect
+
[webkit-changes] [155651] trunk
Title: [155651] trunk
Revision 155651
Author r...@webkit.org
Date 2013-09-12 15:09:25 -0700 (Thu, 12 Sep 2013)
Log Message
[Qt] SHOULD NEVER BE REACHED is touched WebCore::InputType::createStepRange
https://bugs.webkit.org/show_bug.cgi?id=121148
Reviewed by Kent Tamura.
Source/WebCore:
Non-steppable input types must not rendered as slider even if its webkit-apperance style
property is set to slider-vertical/horizontal.
Test: platform/qt/fast/forms/range/slider-crash-on-input.html
* platform/qt/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::paintSliderTrack):
LayoutTests:
Trying to render text input as slider-vertical. Expecting to run without crash.
* platform/qt/fast/forms/range/slider-crash-on-input.html: Added.
* platform/qt/platform/qt/fast/forms/range/slider-crash-on-input-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/RenderThemeQStyle.cpp
Added Paths
trunk/LayoutTests/platform/qt/fast/forms/range/slider-crash-on-input.html
trunk/LayoutTests/platform/qt/platform/qt/fast/forms/range/
trunk/LayoutTests/platform/qt/platform/qt/fast/forms/range/slider-crash-on-input-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (155650 => 155651)
--- trunk/LayoutTests/ChangeLog 2013-09-12 21:40:04 UTC (rev 155650)
+++ trunk/LayoutTests/ChangeLog 2013-09-12 22:09:25 UTC (rev 155651)
@@ -1,3 +1,15 @@
+2013-09-12 Renata Hodovan r...@webkit.org
+
+[Qt] SHOULD NEVER BE REACHED is touched WebCore::InputType::createStepRange
+https://bugs.webkit.org/show_bug.cgi?id=121148
+
+Reviewed by Kent Tamura.
+
+Trying to render text input as slider-vertical. Expecting to run without crash.
+
+* platform/qt/fast/forms/range/slider-crash-on-input.html: Added.
+* platform/qt/platform/qt/fast/forms/range/slider-crash-on-input-expected.txt: Added.
+
2013-09-12 Alexey Proskuryakov a...@apple.com
Canvas fillText and measureText handle ideographic spaces differently
Added: trunk/LayoutTests/platform/qt/fast/forms/range/slider-crash-on-input.html (0 => 155651)
--- trunk/LayoutTests/platform/qt/fast/forms/range/slider-crash-on-input.html (rev 0)
+++ trunk/LayoutTests/platform/qt/fast/forms/range/slider-crash-on-input.html 2013-09-12 22:09:25 UTC (rev 155651)
@@ -0,0 +1,7 @@
+input style=-webkit-appearance:slider-vertical;
+
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+document.body.innerHTML = PASS. WebKit didn't crash.;
+/script
\ No newline at end of file
Added: trunk/LayoutTests/platform/qt/platform/qt/fast/forms/range/slider-crash-on-input-expected.txt (0 => 155651)
--- trunk/LayoutTests/platform/qt/platform/qt/fast/forms/range/slider-crash-on-input-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/platform/qt/fast/forms/range/slider-crash-on-input-expected.txt 2013-09-12 22:09:25 UTC (rev 155651)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.
Modified: trunk/Source/WebCore/ChangeLog (155650 => 155651)
--- trunk/Source/WebCore/ChangeLog 2013-09-12 21:40:04 UTC (rev 155650)
+++ trunk/Source/WebCore/ChangeLog 2013-09-12 22:09:25 UTC (rev 155651)
@@ -1,3 +1,18 @@
+2013-09-12 Renata Hodovan r...@webkit.org
+
+[Qt] SHOULD NEVER BE REACHED is touched WebCore::InputType::createStepRange
+https://bugs.webkit.org/show_bug.cgi?id=121148
+
+Reviewed by Kent Tamura.
+
+Non-steppable input types must not rendered as slider even if its webkit-apperance style
+property is set to slider-vertical/horizontal.
+
+Test: platform/qt/fast/forms/range/slider-crash-on-input.html
+
+* platform/qt/RenderThemeQStyle.cpp:
+(WebCore::RenderThemeQStyle::paintSliderTrack):
+
2013-09-12 Ryosuke Niwa rn...@webkit.org
Qt and Windows build fix.
Modified: trunk/Source/WebCore/platform/qt/RenderThemeQStyle.cpp (155650 => 155651)
--- trunk/Source/WebCore/platform/qt/RenderThemeQStyle.cpp 2013-09-12 21:40:04 UTC (rev 155650)
+++ trunk/Source/WebCore/platform/qt/RenderThemeQStyle.cpp 2013-09-12 22:09:25 UTC (rev 155651)
@@ -433,7 +433,7 @@
// some styles need this to show a highlight on one side of the groove
HTMLInputElement* slider = o-node()-toInputElement();
-if (slider) {
+if (slider slider-isSteppable()) {
p.styleOption.slider.upsideDown = (p.appearance == SliderHorizontalPart) !o-style()-isLeftToRightDirection();
// Use the width as a multiplier in case the slider values are = 1
const int width = r.width() 0 ? r.width() : 100;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [154698] trunk
Title: [154698] trunk
Revision 154698
Author r...@webkit.org
Date 2013-08-27 10:20:28 -0700 (Tue, 27 Aug 2013)
Log Message
Missing null-check of parent renderer in WebCore::HTMLEmbedElement::rendererIsNeeded()
https://bugs.webkit.org/show_bug.cgi?id=120343
Reviewed by Darin Adler.
Source/WebCore:
Null-check the parent renderer of HTMLEmbedElement in WebCore::HTMLEmbedElement::rendererIsNeeded()
and early return.
Test: fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::rendererIsNeeded):
LayoutTests:
Test for the handling of null parent renderer.
* fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash-expected.txt: Added.
* fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLEmbedElement.cpp
Added Paths
trunk/LayoutTests/fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash-expected.txt
trunk/LayoutTests/fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (154697 => 154698)
--- trunk/LayoutTests/ChangeLog 2013-08-27 17:16:03 UTC (rev 154697)
+++ trunk/LayoutTests/ChangeLog 2013-08-27 17:20:28 UTC (rev 154698)
@@ -1,3 +1,15 @@
+2013-08-27 Renata Hodovan r...@webkit.org
+
+Missing null-check of parent renderer in WebCore::HTMLEmbedElement::rendererIsNeeded()
+https://bugs.webkit.org/show_bug.cgi?id=120343
+
+Reviewed by Darin Adler.
+
+Test for the handling of null parent renderer.
+
+* fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash-expected.txt: Added.
+* fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html: Added.
+
2013-08-27 Denis Nomiyama d.nomiy...@samsung.com
[GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation
Added: trunk/LayoutTests/fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash-expected.txt (0 => 154698)
--- trunk/LayoutTests/fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash-expected.txt 2013-08-27 17:20:28 UTC (rev 154698)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.
Added: trunk/LayoutTests/fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html (0 => 154698)
--- trunk/LayoutTests/fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html (rev 0)
+++ trunk/LayoutTests/fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html 2013-08-27 17:20:28 UTC (rev 154698)
@@ -0,0 +1,14 @@
+html
+div style=-webkit-flow-from:thread;
+object
+embed width=100
+/object
+/div
+
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+document.body.innerHTML = PASS. WebKit didn't crash.;
+/script
+/html
Modified: trunk/Source/WebCore/ChangeLog (154697 => 154698)
--- trunk/Source/WebCore/ChangeLog 2013-08-27 17:16:03 UTC (rev 154697)
+++ trunk/Source/WebCore/ChangeLog 2013-08-27 17:20:28 UTC (rev 154698)
@@ -1,3 +1,18 @@
+2013-08-27 Renata Hodovan r...@webkit.org
+
+Missing null-check of parent renderer in WebCore::HTMLEmbedElement::rendererIsNeeded()
+https://bugs.webkit.org/show_bug.cgi?id=120343
+
+Reviewed by Darin Adler.
+
+Null-check the parent renderer of HTMLEmbedElement in WebCore::HTMLEmbedElement::rendererIsNeeded()
+and early return.
+
+Test: fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html
+
+* html/HTMLEmbedElement.cpp:
+(WebCore::HTMLEmbedElement::rendererIsNeeded):
+
2013-08-27 Brent Fulgham bfulg...@apple.com
[Windows] Correct method call for characteristic update.
Modified: trunk/Source/WebCore/html/HTMLEmbedElement.cpp (154697 => 154698)
--- trunk/Source/WebCore/html/HTMLEmbedElement.cpp 2013-08-27 17:16:03 UTC (rev 154697)
+++ trunk/Source/WebCore/html/HTMLEmbedElement.cpp 2013-08-27 17:20:28 UTC (rev 154698)
@@ -186,7 +186,8 @@
// should be ignored and not get a renderer.
ContainerNode* p = parentNode();
if (p p-hasTagName(objectTag)) {
-ASSERT(p-renderer());
+if (!p-renderer())
+return false;
if (!static_castHTMLObjectElement*(p)-useFallbackContent()) {
ASSERT(!p-renderer()-isEmbeddedObject());
return false;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [154476] trunk
Title: [154476] trunk Revision 154476 Author r...@webkit.org Date 2013-08-23 01:28:44 -0700 (Fri, 23 Aug 2013) Log Message Missing null-check in HTMLFormElement::rendererIsNeeded() https://bugs.webkit.org/show_bug.cgi?id=120159 Reviewed by Ryosuke Niwa. Source/WebCore: Null-check parentRenderer in HTMLFormElement::rendererIsNeeded() and early return. Test: fast/forms/missing-parentrenderer-crash.html * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::rendererIsNeeded): LayoutTests: Test for the handling of null parentRederer. * fast/forms/missing-parentrenderer-crash-expected.txt: Added. * fast/forms/missing-parentrenderer-crash.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLFormElement.cpp Added Paths trunk/LayoutTests/fast/forms/missing-parentrenderer-crash-expected.txt trunk/LayoutTests/fast/forms/missing-parentrenderer-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (154475 => 154476) --- trunk/LayoutTests/ChangeLog 2013-08-23 07:19:17 UTC (rev 154475) +++ trunk/LayoutTests/ChangeLog 2013-08-23 08:28:44 UTC (rev 154476) @@ -1,3 +1,15 @@ +2013-08-23 Renata Hodovan r...@webkit.org + +Missing null-check in HTMLFormElement::rendererIsNeeded() +https://bugs.webkit.org/show_bug.cgi?id=120159 + +Reviewed by Ryosuke Niwa. + +Test for the handling of null parentRederer. + +* fast/forms/missing-parentrenderer-crash-expected.txt: Added. +* fast/forms/missing-parentrenderer-crash.html: Added. + 2013-08-23 Zalan Bujtas za...@apple.com MathML: ASSERTION FAILED: !isPreferredLogicalHeightDirty() in RenderMathMLBlock::preferredLogicalHeight() const Added: trunk/LayoutTests/fast/forms/missing-parentrenderer-crash-expected.txt (0 => 154476) --- trunk/LayoutTests/fast/forms/missing-parentrenderer-crash-expected.txt (rev 0) +++ trunk/LayoutTests/fast/forms/missing-parentrenderer-crash-expected.txt 2013-08-23 08:28:44 UTC (rev 154476) @@ -0,0 +1 @@ +PASS. WebKit didn't crash. Added: trunk/LayoutTests/fast/forms/missing-parentrenderer-crash.html (0 => 154476) --- trunk/LayoutTests/fast/forms/missing-parentrenderer-crash.html (rev 0) +++ trunk/LayoutTests/fast/forms/missing-parentrenderer-crash.html 2013-08-23 08:28:44 UTC (rev 154476) @@ -0,0 +1,12 @@ +html +blockquote style=-webkit-flow-from: thread;/ +table/ +form/ + +script +if (window.testRunner) +testRunner.dumpAsText(); + +document.body.innerHTML = PASS. WebKit didn't crash.; +/script +/html Modified: trunk/Source/WebCore/ChangeLog (154475 => 154476) --- trunk/Source/WebCore/ChangeLog 2013-08-23 07:19:17 UTC (rev 154475) +++ trunk/Source/WebCore/ChangeLog 2013-08-23 08:28:44 UTC (rev 154476) @@ -1,3 +1,18 @@ +2013-08-23 Renata Hodovan r...@webkit.org + +Missing null-check in HTMLFormElement::rendererIsNeeded() +https://bugs.webkit.org/show_bug.cgi?id=120159 + +Reviewed by Ryosuke Niwa. + +Null-check parentRenderer in HTMLFormElement::rendererIsNeeded() +and early return. + +Test: fast/forms/missing-parentrenderer-crash.html + +* html/HTMLFormElement.cpp: +(WebCore::HTMLFormElement::rendererIsNeeded): + 2013-08-23 Zalan Bujtas za...@apple.com MathML: ASSERTION FAILED: !isPreferredLogicalHeightDirty() in RenderMathMLBlock::preferredLogicalHeight() const Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (154475 => 154476) --- trunk/Source/WebCore/html/HTMLFormElement.cpp 2013-08-23 07:19:17 UTC (rev 154475) +++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2013-08-23 08:28:44 UTC (rev 154476) @@ -101,6 +101,10 @@ ContainerNode* node = parentNode(); RenderObject* parentRenderer = node-renderer(); + +if (!parentRenderer) +return false; + // FIXME: Shouldn't we also check for table caption (see |formIsTablePart| below). bool parentIsTableElementPart = (parentRenderer-isTable() isHTMLTableElement(node)) || (parentRenderer-isTableRow() node-hasTagName(trTag)) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [154439] trunk
Title: [154439] trunk
Revision 154439
Author r...@webkit.org
Date 2013-08-22 03:14:02 -0700 (Thu, 22 Aug 2013)
Log Message
ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement
https://bugs.webkit.org/show_bug.cgi?id=119672
Reviewed by Darin Adler.
Source/WebCore:
The last extractedStyle parameter of removeInlineStyleFromElement() is not mandatory and it's set
to default 0. This way we have to check its existence before the usage.
Test: editing/execCommand/extracted_style_assert.html
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
LayoutTests:
Test with NULL extractedStyle.
* editing/execCommand/extracted_style_assert-expected.txt: Added.
* editing/execCommand/extracted_style_assert.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ApplyStyleCommand.cpp
Added Paths
trunk/LayoutTests/editing/execCommand/extracted_style_assert-expected.txt
trunk/LayoutTests/editing/execCommand/extracted_style_assert.html
Diff
Modified: trunk/LayoutTests/ChangeLog (154438 => 154439)
--- trunk/LayoutTests/ChangeLog 2013-08-22 09:28:18 UTC (rev 154438)
+++ trunk/LayoutTests/ChangeLog 2013-08-22 10:14:02 UTC (rev 154439)
@@ -1,3 +1,15 @@
+2013-08-22 Renata Hodovan r...@webkit.org
+
+ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement
+https://bugs.webkit.org/show_bug.cgi?id=119672
+
+Reviewed by Darin Adler.
+
+Test with NULL extractedStyle.
+
+* editing/execCommand/extracted_style_assert-expected.txt: Added.
+* editing/execCommand/extracted_style_assert.html: Added.
+
2013-08-08 Sergio Villar Senin svil...@igalia.com
[CSS Grid Layout] Refactor testing code
Added: trunk/LayoutTests/editing/execCommand/extracted_style_assert-expected.txt (0 => 154439)
--- trunk/LayoutTests/editing/execCommand/extracted_style_assert-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/execCommand/extracted_style_assert-expected.txt 2013-08-22 10:14:02 UTC (rev 154439)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.
Added: trunk/LayoutTests/editing/execCommand/extracted_style_assert.html (0 => 154439)
--- trunk/LayoutTests/editing/execCommand/extracted_style_assert.html (rev 0)
+++ trunk/LayoutTests/editing/execCommand/extracted_style_assert.html 2013-08-22 10:14:02 UTC (rev 154439)
@@ -0,0 +1,19 @@
+html
+body
+table
+td
+a/a
+/td
+/table
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+document.designMode = on;
+document.execCommand(SelectAll);
+document.execCommand(CreateLink, 0, 'foo');
+
+document.body.innerHTML = PASS. WebKit didn't crash.;
+/script
+ /body
+/html
Modified: trunk/Source/WebCore/ChangeLog (154438 => 154439)
--- trunk/Source/WebCore/ChangeLog 2013-08-22 09:28:18 UTC (rev 154438)
+++ trunk/Source/WebCore/ChangeLog 2013-08-22 10:14:02 UTC (rev 154439)
@@ -1,3 +1,18 @@
+2013-08-22 Renata Hodovan r...@webkit.org
+
+ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement
+https://bugs.webkit.org/show_bug.cgi?id=119672
+
+Reviewed by Darin Adler.
+
+The last extractedStyle parameter of removeInlineStyleFromElement() is not mandatory and it's set
+to default 0. This way we have to check its existence before the usage.
+
+Test: editing/execCommand/extracted_style_assert.html
+
+* editing/ApplyStyleCommand.cpp:
+(WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
+
2013-08-21 Commit Queue commit-qu...@webkit.org
Unreviewed, rolling out r154416.
Modified: trunk/Source/WebCore/editing/ApplyStyleCommand.cpp (154438 => 154439)
--- trunk/Source/WebCore/editing/ApplyStyleCommand.cpp 2013-08-22 09:28:18 UTC (rev 154438)
+++ trunk/Source/WebCore/editing/ApplyStyleCommand.cpp 2013-08-22 10:14:02 UTC (rev 154439)
@@ -887,8 +887,8 @@
if (isStyledInlineElementToRemove(element.get())) {
if (mode == RemoveNone)
return true;
-ASSERT(extractedStyle);
-extractedStyle-mergeInlineStyleOfElement(element.get(), EditingStyle::OverrideValues);
+if (extractedStyle)
+extractedStyle-mergeInlineStyleOfElement(element.get(), EditingStyle::OverrideValues);
removeNodePreservingChildren(element);
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [153883] trunk
Title: [153883] trunk
Revision 153883
Author r...@webkit.org
Date 2013-08-09 05:08:28 -0700 (Fri, 09 Aug 2013)
Log Message
Missing NULL check in ApplyStyleCommand::applyInlineStyleToNodeRange()
https://bugs.webkit.org/show_bug.cgi?id=119570
Reviewed by Ryosuke Niwa.
Source/WebCore:
The m_mutableStyleSet of EditingStyle can be NULL in ApplyStyleCommand::applyInlineStyleToNodeRange but
this scenario was not checked earlier.
Test: editing/execCommand/null-style-crash.html
* css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict):
* css/StylePropertySet.h:
* css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::addViewportRule):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
* editing/EditingStyle.cpp:
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
LayoutTests:
* editing/execCommand/null-style-crash-expected.txt: Added.
* editing/execCommand/null-style-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ApplyStyleCommand.cpp
Added Paths
trunk/LayoutTests/editing/execCommand/null-style-crash-expected.txt
trunk/LayoutTests/editing/execCommand/null-style-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (153882 => 153883)
--- trunk/LayoutTests/ChangeLog 2013-08-09 10:48:49 UTC (rev 153882)
+++ trunk/LayoutTests/ChangeLog 2013-08-09 12:08:28 UTC (rev 153883)
@@ -1,3 +1,13 @@
+2013-08-09 Renata Hodovan r...@webkit.org
+
+Missing NULL check in ApplyStyleCommand::applyInlineStyleToNodeRange()
+https://bugs.webkit.org/show_bug.cgi?id=119570
+
+Reviewed by Ryosuke Niwa.
+
+* editing/execCommand/null-style-crash-expected.txt: Added.
+* editing/execCommand/null-style-crash.html: Added.
+
2013-08-08 Tim Horton timothy_hor...@apple.com
navigator.plugins has plugins in it when plugins are disabled
Added: trunk/LayoutTests/editing/execCommand/null-style-crash-expected.txt (0 => 153883)
--- trunk/LayoutTests/editing/execCommand/null-style-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/execCommand/null-style-crash-expected.txt 2013-08-09 12:08:28 UTC (rev 153883)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash
Added: trunk/LayoutTests/editing/execCommand/null-style-crash.html (0 => 153883)
--- trunk/LayoutTests/editing/execCommand/null-style-crash.html (rev 0)
+++ trunk/LayoutTests/editing/execCommand/null-style-crash.html 2013-08-09 12:08:28 UTC (rev 153883)
@@ -0,0 +1,24 @@
+!DOCTYPE html
+html
+body
+ table
+ tr
+ td contenteditable=plaintext-only171/td
+ /tr
+ /table
+ script
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+document.designMode = on;
+document.execCommand(SelectAll);
+document.execCommand(CreateLink, true, 'www.google.com');
+
+document.body.innerHTML = PASS. WebKit didn't crash;
+if (window.testRunner)
+testRunner.notifyDone();
+/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (153882 => 153883)
--- trunk/Source/WebCore/ChangeLog 2013-08-09 10:48:49 UTC (rev 153882)
+++ trunk/Source/WebCore/ChangeLog 2013-08-09 12:08:28 UTC (rev 153883)
@@ -1,3 +1,27 @@
+2013-08-09 Renata Hodovan r...@webkit.org
+
+Missing NULL check in ApplyStyleCommand::applyInlineStyleToNodeRange()
+https://bugs.webkit.org/show_bug.cgi?id=119570
+
+Reviewed by Ryosuke Niwa.
+
+The m_mutableStyleSet of EditingStyle can be NULL in ApplyStyleCommand::applyInlineStyleToNodeRange but
+this scenario was not checked earlier.
+
+Test: editing/execCommand/null-style-crash.html
+
+* css/StylePropertySet.cpp:
+(WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict):
+* css/StylePropertySet.h:
+* css/ViewportStyleResolver.cpp:
+(WebCore::ViewportStyleResolver::addViewportRule):
+* editing/ApplyStyleCommand.cpp:
+(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
+* editing/EditingStyle.cpp:
+(WebCore::styleFromMatchedRulesForElement):
+(WebCore::EditingStyle::mergeStyleFromRules):
+(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
+
2013-08-09 Andreas Kling akl...@apple.com
ElementRuleCollector: Use range-based for syntax in rule collection loop.
Modified: trunk/Source/WebCore/editing/ApplyStyleCommand.cpp (153882 => 153883)
--- trunk/Source/WebCore/editing/ApplyStyleCommand.cpp 2013-08-09 10:48:49 UTC (rev 153882)
+++ trunk/Source/WebCore/editing/ApplyStyleCommand.cpp 2013-08-09 12:08:28 UTC (rev 153883)
@@ -771,7 +771,8 @@
// Add to this element's inline style and skip over
[webkit-changes] [153433] trunk
Title: [153433] trunk
Revision 153433
Author r...@webkit.org
Date 2013-07-29 10:45:51 -0700 (Mon, 29 Jul 2013)
Log Message
ASSERT_NOT_REACHED was touched in WebCore::SVGAnimatedType::valueAsString
https://bugs.webkit.org/show_bug.cgi?id=118744
Reviewed by Philip Rogers.
Source/WebCore:
If we have an animateTransform tag that sets the attributeName and attributeType
properties however they are not consistent and we shouldn't try to apply it.
It is already checked and catched in SVGAnimateElement::resetAnimatedType() but
DontApplyAnimation case isn't handled properly. The patch forces an early return
in this case.
Test: svg/animations/attributeNameAndAttributeTypeMissmatch.svg
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::resetAnimatedType):
LayoutTests:
Adding test to check whether attributeName and attributeType are consistent in animateTransform.
* platform/qt/svg/animations/attributeNameAndAttributeTypeMissmatch-expected.txt: Added.
* svg/animations/attributeNameAndAttributeTypeMissmatch.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGAnimateElement.cpp
Added Paths
trunk/LayoutTests/platform/qt/svg/animations/attributeNameAndAttributeTypeMissmatch-expected.txt
trunk/LayoutTests/svg/animations/attributeNameAndAttributeTypeMissmatch.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (153432 => 153433)
--- trunk/LayoutTests/ChangeLog 2013-07-29 17:16:25 UTC (rev 153432)
+++ trunk/LayoutTests/ChangeLog 2013-07-29 17:45:51 UTC (rev 153433)
@@ -1,3 +1,15 @@
+2013-07-29 Renata Hodovan r...@webkit.org
+
+ASSERT_NOT_REACHED was touched in WebCore::SVGAnimatedType::valueAsString
+https://bugs.webkit.org/show_bug.cgi?id=118744
+
+Reviewed by Philip Rogers.
+
+Adding test to check whether attributeName and attributeType are consistent in animateTransform.
+
+* platform/qt/svg/animations/attributeNameAndAttributeTypeMissmatch-expected.txt: Added.
+* svg/animations/attributeNameAndAttributeTypeMissmatch.svg: Added.
+
2013-07-29 Mario Sanchez Prada mario.pr...@samsung.com
[ATK] Implement allAttributes() for AccessibilityUIElement
Added: trunk/LayoutTests/platform/qt/svg/animations/attributeNameAndAttributeTypeMissmatch-expected.txt (0 => 153433)
--- trunk/LayoutTests/platform/qt/svg/animations/attributeNameAndAttributeTypeMissmatch-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/svg/animations/attributeNameAndAttributeTypeMissmatch-expected.txt 2013-07-29 17:45:51 UTC (rev 153433)
@@ -0,0 +1,7 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderSVGRoot {svg} at (10,5) size 243x19
+RenderSVGText {text} at (10,5) size 243x19 contains 1 chunk(s)
+ RenderSVGInlineText {#text} at (0,0) size 243x19
+chunk 1 text run 1 at (10.00,20.00) startOffset 0 endOffset 42 width 243.00: Test passes if it does not crash in debug.
Added: trunk/LayoutTests/svg/animations/attributeNameAndAttributeTypeMissmatch.svg (0 => 153433)
--- trunk/LayoutTests/svg/animations/attributeNameAndAttributeTypeMissmatch.svg (rev 0)
+++ trunk/LayoutTests/svg/animations/attributeNameAndAttributeTypeMissmatch.svg 2013-07-29 17:45:51 UTC (rev 153433)
@@ -0,0 +1,4 @@
+svg xmlns=http://www.w3.org/2000/svg
+animateTransform attributeName=transform attributeType=CSS/animateTransform
+text x=10 y=20Test passes if it does not crash in debug./text
+/svg
Modified: trunk/Source/WebCore/ChangeLog (153432 => 153433)
--- trunk/Source/WebCore/ChangeLog 2013-07-29 17:16:25 UTC (rev 153432)
+++ trunk/Source/WebCore/ChangeLog 2013-07-29 17:45:51 UTC (rev 153433)
@@ -1,3 +1,21 @@
+2013-07-29 Renata Hodovan r...@webkit.org
+
+ASSERT_NOT_REACHED was touched in WebCore::SVGAnimatedType::valueAsString
+https://bugs.webkit.org/show_bug.cgi?id=118744
+
+Reviewed by Philip Rogers.
+
+If we have an animateTransform tag that sets the attributeName and attributeType
+properties however they are not consistent and we shouldn't try to apply it.
+It is already checked and catched in SVGAnimateElement::resetAnimatedType() but
+DontApplyAnimation case isn't handled properly. The patch forces an early return
+in this case.
+
+Test: svg/animations/attributeNameAndAttributeTypeMissmatch.svg
+
+* svg/SVGAnimateElement.cpp:
+(WebCore::SVGAnimateElement::resetAnimatedType):
+
2013-07-29 Allan Sandfeld Jensen allan.jen...@digia.com
REGRESSION(148300) GIFs not reanimated after resumeActiveDOMObjectAndAnimations
Modified: trunk/Source/WebCore/svg/SVGAnimateElement.cpp (153432 => 153433)
--- trunk/Source/WebCore/svg/SVGAnimateElement.cpp 2013-07-29 17:16:25 UTC (rev 153432)
+++ trunk/Source/WebCore/svg/SVGAnimateElement.cpp 2013-07-29 17:45:51 UTC (rev 153433)
@@ -205,6 +205,10 @@
[webkit-changes] [146083] trunk
Title: [146083] trunk
Revision 146083
Author r...@webkit.org
Date 2013-03-18 10:38:16 -0700 (Mon, 18 Mar 2013)
Log Message
Source/WebCore: Assertion faulire in SVGAnimatedPath.
https://bugs.webkit.org/show_bug.cgi?id=106428
Reviewed by Allan Sandfeld Jensen.
The asserts are too restricted. The size must be greater or equal to 1.
Test: svg/animations/animated-path-via-use-debug-crash.svg
* svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):
LayoutTests: Assertion faulire in SVGAnimatedPath
https://bugs.webkit.org/show_bug.cgi?id=106428
Reviewed by Allan Sandfeld Jensen.
* svg/animations/animated-path-via-use-debug-crash.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGAnimatedPath.cpp
Added Paths
trunk/LayoutTests/svg/animations/animated-path-via-use-debug-crash-expected.txt
trunk/LayoutTests/svg/animations/animated-path-via-use-debug-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (146082 => 146083)
--- trunk/LayoutTests/ChangeLog 2013-03-18 17:34:37 UTC (rev 146082)
+++ trunk/LayoutTests/ChangeLog 2013-03-18 17:38:16 UTC (rev 146083)
@@ -1,3 +1,12 @@
+2013-03-18 Renata Hodovan r...@webkit.org
+
+Assertion faulire in SVGAnimatedPath
+https://bugs.webkit.org/show_bug.cgi?id=106428
+
+Reviewed by Allan Sandfeld Jensen.
+
+* svg/animations/animated-path-via-use-debug-crash.svg: Added.
+
2013-03-18 Simon Fraser simon.fra...@apple.com
[Mac] Some tests intermittently asserts in SharedBuffer::releasePurgeableBuffer()
Added: trunk/LayoutTests/svg/animations/animated-path-via-use-debug-crash-expected.txt (0 => 146083)
--- trunk/LayoutTests/svg/animations/animated-path-via-use-debug-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/animations/animated-path-via-use-debug-crash-expected.txt 2013-03-18 17:38:16 UTC (rev 146083)
@@ -0,0 +1 @@
+This test passes if it does not crash. See bug https://bugs.webkit.org/show_bug.cgi?id=106428
Added: trunk/LayoutTests/svg/animations/animated-path-via-use-debug-crash.svg (0 => 146083)
--- trunk/LayoutTests/svg/animations/animated-path-via-use-debug-crash.svg (rev 0)
+++ trunk/LayoutTests/svg/animations/animated-path-via-use-debug-crash.svg 2013-03-18 17:38:16 UTC (rev 146083)
@@ -0,0 +1,14 @@
+svg xmlns:xlink=http://www.w3.org/1999/xlink xmlns=http://www.w3.org/2000/svg
+path id=test d=M 10 10
+animate attributeName=d/animate
+/path
+
+use xlink:href=""
+text x=10 y=20This test passes if it does not crash. See bug https://bugs.webkit.org/show_bug.cgi?id=106428/text
+
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+/script
+/svg
+
Modified: trunk/Source/WebCore/ChangeLog (146082 => 146083)
--- trunk/Source/WebCore/ChangeLog 2013-03-18 17:34:37 UTC (rev 146082)
+++ trunk/Source/WebCore/ChangeLog 2013-03-18 17:38:16 UTC (rev 146083)
@@ -1,3 +1,18 @@
+2013-03-18 Renata Hodovan r...@webkit.org
+
+Assertion faulire in SVGAnimatedPath.
+https://bugs.webkit.org/show_bug.cgi?id=106428
+
+Reviewed by Allan Sandfeld Jensen.
+
+The asserts are too restricted. The size must be greater or equal to 1.
+
+Test: svg/animations/animated-path-via-use-debug-crash.svg
+
+* svg/SVGAnimatedPath.cpp:
+(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
+(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):
+
2013-03-18 Simon Fraser simon.fra...@apple.com
[Mac] Some tests intermittently asserts in SharedBuffer::releasePurgeableBuffer()
Modified: trunk/Source/WebCore/svg/SVGAnimatedPath.cpp (146082 => 146083)
--- trunk/Source/WebCore/svg/SVGAnimatedPath.cpp 2013-03-18 17:34:37 UTC (rev 146082)
+++ trunk/Source/WebCore/svg/SVGAnimatedPath.cpp 2013-03-18 17:38:16 UTC (rev 146083)
@@ -42,7 +42,7 @@
PassOwnPtrSVGAnimatedType SVGAnimatedPathAnimator::startAnimValAnimation(const SVGElementAnimatedPropertyList animatedTypes)
{
-ASSERT(animatedTypes.size() == 1);
+ASSERT(animatedTypes.size() = 1);
SVGAnimatedPathSegListPropertyTearOff* property = castAnimatedPropertyToActualTypeSVGAnimatedPathSegListPropertyTearOff(animatedTypes[0].properties[0].get());
const SVGPathSegList baseValue = property-currentBaseValue();
@@ -72,7 +72,7 @@
void SVGAnimatedPathAnimator::resetAnimValToBaseVal(const SVGElementAnimatedPropertyList animatedTypes, SVGAnimatedType* type)
{
-ASSERT(animatedTypes.size() == 1);
+ASSERT(animatedTypes.size() = 1);
ASSERT(type);
ASSERT(type-type() == m_type);
const SVGPathSegList baseValue = castAnimatedPropertyToActualTypeSVGAnimatedPathSegListPropertyTearOff(animatedTypes[0].properties[0].get())-currentBaseValue();
___
webkit-changes mailing list
[webkit-changes] [140964] trunk/Source/WebKit2
Title: [140964] trunk/Source/WebKit2 Revision 140964 Author r...@webkit.org Date 2013-01-28 04:22:14 -0800 (Mon, 28 Jan 2013) Log Message [Qt][Win][WK2] Build fix after r140957. Rubber-stamped by Csaba Osztrogonác. sys/wait.h is only needed and available on linux therefore it's moved into an ifdef block. * WebProcess/qt/WebProcessMainQt.cpp: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (140963 => 140964) --- trunk/Source/WebKit2/ChangeLog 2013-01-28 12:01:24 UTC (rev 140963) +++ trunk/Source/WebKit2/ChangeLog 2013-01-28 12:22:14 UTC (rev 140964) @@ -1,3 +1,13 @@ +2013-01-28 Renata Hodovan r...@webkit.org + +[Qt][Win][WK2] Build fix after r140957. + +Rubber-stamped by Csaba Osztrogonác. + +sys/wait.h is only needed and available on linux therefore it's moved into an ifdef block. + +* WebProcess/qt/WebProcessMainQt.cpp: + 2013-01-28 Kenneth Rohde Christiansen kenn...@webkit.org [EFL][WK2] Use C API inside ewk_url_response Modified: trunk/Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp (140963 => 140964) --- trunk/Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp 2013-01-28 12:01:24 UTC (rev 140963) +++ trunk/Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp 2013-01-28 12:22:14 UTC (rev 140964) @@ -38,7 +38,6 @@ #include WebCore/RunLoop.h #include errno.h #include runtime/InitializeThreading.h -#include sys/wait.h #include wtf/MainThread.h #if USE(QTKIT) @@ -63,6 +62,7 @@ #if ENABLE(SUID_SANDBOX_LINUX) #include SandboxEnvironmentLinux.h +#include sys/wait.h #endif using namespace WebCore; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138141] trunk
Title: [138141] trunk
Revision 138141
Author r...@webkit.org
Date 2012-12-19 03:56:08 -0800 (Wed, 19 Dec 2012)
Log Message
CSSParser crases, when no context is available, and the value is a valid keyword
https://bugs.webkit.org/show_bug.cgi?id=105275
Reviewed by Tony Chang.
ParserContext could be null even if the keyword is valid. We have to check it.
Source/WebCore:
Test: fast/css/invalid-parsercontext-valid-keyword-crash.svg
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
LayoutTests:
* fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt: Added.
* fast/css/invalid-parsercontext-valid-keyword-crash.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
Added Paths
trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt
trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (138140 => 138141)
--- trunk/LayoutTests/ChangeLog 2012-12-19 11:35:05 UTC (rev 138140)
+++ trunk/LayoutTests/ChangeLog 2012-12-19 11:56:08 UTC (rev 138141)
@@ -1,3 +1,15 @@
+2012-12-19 Renata Hodovan r...@webkit.org
+
+CSSParser crases, when no context is available, and the value is a valid keyword
+https://bugs.webkit.org/show_bug.cgi?id=105275
+
+Reviewed by Tony Chang.
+
+ParserContext could be null even if the keyword is valid. We have to check it.
+
+* fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt: Added.
+* fast/css/invalid-parsercontext-valid-keyword-crash.svg: Added.
+
2012-12-19 Dominik Röttsches dominik.rottsc...@intel.com
[EFL] Unreviewed gardening.
Added: trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt (0 => 138141)
--- trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt 2012-12-19 11:56:08 UTC (rev 138141)
@@ -0,0 +1 @@
+Excellent - did not crash. See bug https://bugs.webkit.org/show_bug.cgi?id=105275
Added: trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash.svg (0 => 138141)
--- trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash.svg (rev 0)
+++ trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash.svg 2012-12-19 11:56:08 UTC (rev 138141)
@@ -0,0 +1,13 @@
+svg xmlns=http://www.w3.org/2000/svg
+!-- This test passes if there is no crash. --
+rect
+ animate attributeName=display to=bevel/animate
+/rect
+
+text x=10 y=20Excellent - did not crash. See bug https://bugs.webkit.org/show_bug.cgi?id=105275/text
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+/script
+/svg
+
Modified: trunk/Source/WebCore/ChangeLog (138140 => 138141)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 11:35:05 UTC (rev 138140)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 11:56:08 UTC (rev 138141)
@@ -1,3 +1,17 @@
+2012-12-19 Renata Hodovan r...@webkit.org
+
+CSSParser crases, when no context is available, and the value is a valid keyword
+https://bugs.webkit.org/show_bug.cgi?id=105275
+
+Reviewed by Tony Chang.
+
+ParserContext could be null even if the keyword is valid. We have to check it.
+
+Test: fast/css/invalid-parsercontext-valid-keyword-crash.svg
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseValue):
+
2012-12-19 Kondapally Kalyan kalyan.kondapa...@intel.com
[EFL][WebGL] Refactor GLXSurface.
Modified: trunk/Source/WebCore/css/CSSParser.cpp (138140 => 138141)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-12-19 11:35:05 UTC (rev 138140)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-12-19 11:56:08 UTC (rev 138141)
@@ -1229,16 +1229,18 @@
return true;
if (parseColorValue(declaration, propertyID, string, important, cssParserMode))
return true;
-if (parseKeywordValue(declaration, propertyID, string, important, contextStyleSheet-parserContext()))
-return true;
-if (parseTranslateTransformValue(declaration, propertyID, string, important))
-return true;
CSSParserContext context(cssParserMode);
if (contextStyleSheet) {
context = contextStyleSheet-parserContext();
context.mode = cssParserMode;
}
+
+if (parseKeywordValue(declaration, propertyID, string, important, context))
+return true;
+if (parseTranslateTransformValue(declaration, propertyID, string, important))
+return true;
+
CSSParser parser(context);
return parser.parseValue(declaration, propertyID, string, important, contextStyleSheet);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [119833] trunk
Title: [119833] trunk Revision 119833 Author r...@webkit.org Date 2012-06-08 08:20:09 -0700 (Fri, 08 Jun 2012) Log Message Adding few already supported features to the FeatureSet in DOMImplementation https://bugs.webkit.org/show_bug.cgi?id=86482 Source/WebCore: Text, Filter and View features are already implemented but they are not added to the SVG11 feature set. This is corrected in this patch. Reviewed by Nikolas Zimmermann. No new testcase is needed because we already have one what checks the svg features via DOMImplementation (svg/custom/svg-features.html). * dom/DOMImplementation.cpp: (WebCore::isSVG11Feature): LayoutTests: Reviewed by Nikolas Zimmermann. * platform/qt-5.0/svg/custom/svg-features-expected.txt: * platform/qt/svg/custom/svg-features-expected.txt: * svg/custom/svg-features-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/svg/custom/svg-features-expected.txt trunk/LayoutTests/platform/qt-5.0/svg/custom/svg-features-expected.txt trunk/LayoutTests/svg/custom/svg-features-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/DOMImplementation.cpp Diff Modified: trunk/LayoutTests/ChangeLog (119832 => 119833) --- trunk/LayoutTests/ChangeLog 2012-06-08 15:13:32 UTC (rev 119832) +++ trunk/LayoutTests/ChangeLog 2012-06-08 15:20:09 UTC (rev 119833) @@ -1,3 +1,14 @@ +2012-06-08 Renata Hodovan r...@webkit.org + +Adding few already supported features to the FeatureSet in DOMImplementation +https://bugs.webkit.org/show_bug.cgi?id=86482 + +Reviewed by Nikolas Zimmermann. + +* platform/qt-5.0/svg/custom/svg-features-expected.txt: +* platform/qt/svg/custom/svg-features-expected.txt: +* svg/custom/svg-features-expected.txt: + 2012-06-07 Vincent Scheib sch...@chromium.org Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing Modified: trunk/LayoutTests/platform/qt/svg/custom/svg-features-expected.txt (119832 => 119833) --- trunk/LayoutTests/platform/qt/svg/custom/svg-features-expected.txt 2012-06-08 15:13:32 UTC (rev 119832) +++ trunk/LayoutTests/platform/qt/svg/custom/svg-features-expected.txt 2012-06-08 15:20:09 UTC (rev 119833) @@ -26,7 +26,7 @@ http://www.w3.org/TR/SVG11/feature#Style, 1.1: true, true http://www.w3.org/TR/SVG11/feature#ViewportAttribute, 1.1: true, true http://www.w3.org/TR/SVG11/feature#Shape, 1.1: true, true -http://www.w3.org/TR/SVG11/feature#Text, 1.1: false, false +http://www.w3.org/TR/SVG11/feature#Text, 1.1: true, true http://www.w3.org/TR/SVG11/feature#BasicText, 1.1: true, true http://www.w3.org/TR/SVG11/feature#PaintAttribute, 1.1: true, true http://www.w3.org/TR/SVG11/feature#BasicPaintAttribute, 1.1: true, true @@ -40,7 +40,7 @@ http://www.w3.org/TR/SVG11/feature#Clip, 1.1: true, true http://www.w3.org/TR/SVG11/feature#BasicClip, 1.1: true, true http://www.w3.org/TR/SVG11/feature#Mask, 1.1: true, true -http://www.w3.org/TR/SVG11/feature#Filter, 1.1: false, false +http://www.w3.org/TR/SVG11/feature#Filter, 1.1: true, true http://www.w3.org/TR/SVG11/feature#BasicFilter, 1.1: true, true http://www.w3.org/TR/SVG11/feature#DocumentEventsAttribute, 1.1: true, true http://www.w3.org/TR/SVG11/feature#GraphicalEventsAttribute, 1.1: true, true @@ -49,7 +49,7 @@ http://www.w3.org/TR/SVG11/feature#Hyperlinking, 1.1: true, true http://www.w3.org/TR/SVG11/feature#XlinkAttribute, 1.1: true, true http://www.w3.org/TR/SVG11/feature#ExternalResourcesRequired, 1.1: true, true -http://www.w3.org/TR/SVG11/feature#View, 1.1: false, false +http://www.w3.org/TR/SVG11/feature#View, 1.1: true, true http://www.w3.org/TR/SVG11/feature#Script, 1.1: true, true http://www.w3.org/TR/SVG11/feature#Animation, 1.1: true, true http://www.w3.org/TR/SVG11/feature#Font, 1.1: false, false Modified: trunk/LayoutTests/platform/qt-5.0/svg/custom/svg-features-expected.txt (119832 => 119833) --- trunk/LayoutTests/platform/qt-5.0/svg/custom/svg-features-expected.txt 2012-06-08 15:13:32 UTC (rev 119832) +++ trunk/LayoutTests/platform/qt-5.0/svg/custom/svg-features-expected.txt 2012-06-08 15:20:09 UTC (rev 119833) @@ -26,7 +26,7 @@ http://www.w3.org/TR/SVG11/feature#Style, 1.1: true, true http://www.w3.org/TR/SVG11/feature#ViewportAttribute, 1.1: true, true http://www.w3.org/TR/SVG11/feature#Shape, 1.1: true, true -http://www.w3.org/TR/SVG11/feature#Text, 1.1: false, false +http://www.w3.org/TR/SVG11/feature#Text, 1.1: true, true http://www.w3.org/TR/SVG11/feature#BasicText, 1.1: true, true http://www.w3.org/TR/SVG11/feature#PaintAttribute, 1.1: true, true http://www.w3.org/TR/SVG11/feature#BasicPaintAttribute, 1.1: true, true @@ -40,7 +40,7 @@ http://www.w3.org/TR/SVG11/feature#Clip, 1.1: true, true http://www.w3.org/TR/SVG11/feature#BasicClip, 1.1: true, true http://www.w3.org/TR/SVG11/feature#Mask, 1.1: true, true -http://www.w3.org/TR/SVG11/feature#Filter, 1.1: false, false
[webkit-changes] [108785] trunk/Source/WebCore
Title: [108785] trunk/Source/WebCore Revision 108785 Author r...@webkit.org Date 2012-02-24 06:31:59 -0800 (Fri, 24 Feb 2012) Log Message External use xlink:href references do not work https://bugs.webkit.org/show_bug.cgi?id=12499 Reviewed by Nikolas Zimmermann. Support external references on use by introducing CachedSVGDocument. CachedSVGDocument is a CachedResource specialized for SVGDocuments. This CachedSVGDocument will be stored for every use element with external reference. This first patch only contains the new classes to test whether it works on every platform. So they aren't used anywhere and just a follow-up patch will bind them into the caching system. No new tests - no change in functionality. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * loader/cache/CachedResource.cpp: (WebCore::defaultPriorityForResourceType): (WebCore::cachedResourceTypeToTargetType): * loader/cache/CachedResource.h: * loader/cache/CachedResourceClient.h: (CachedResourceClient): * loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): (WebCore::CachedResourceLoader::checkInsecureContent): (WebCore::CachedResourceLoader::canRequest): * loader/cache/CachedSVGDocument.cpp: Added. (WebCore): (WebCore::CachedSVGDocument::CachedSVGDocument): (WebCore::CachedSVGDocument::~CachedSVGDocument): (WebCore::CachedSVGDocument::setEncoding): (WebCore::CachedSVGDocument::encoding): (WebCore::CachedSVGDocument::data): * loader/cache/CachedSVGDocument.h: Added. (WebCore): (CachedSVGDocument): (WebCore::CachedSVGDocument::document): (WebCore::CachedSVGDocument::schedule): (CachedSVGDocumentClient): (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient): (WebCore::CachedSVGDocumentClient::expectedType): (WebCore::CachedSVGDocumentClient::resourceClientType): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/loader/cache/CachedResource.cpp trunk/Source/WebCore/loader/cache/CachedResource.h trunk/Source/WebCore/loader/cache/CachedResourceClient.h trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp Added Paths trunk/Source/WebCore/loader/cache/CachedSVGDocument.cpp trunk/Source/WebCore/loader/cache/CachedSVGDocument.h Property Changed trunk/Source/WebCore/loader/cache/CachedResource.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (108784 => 108785) --- trunk/Source/WebCore/CMakeLists.txt 2012-02-24 14:16:55 UTC (rev 108784) +++ trunk/Source/WebCore/CMakeLists.txt 2012-02-24 14:31:59 UTC (rev 108785) @@ -995,6 +995,7 @@ loader/cache/CachedResourceHandle.cpp loader/cache/CachedResourceLoader.cpp loader/cache/CachedScript.cpp +loader/cache/CachedSVGDocument.cpp loader/cache/CachedXSLStyleSheet.cpp loader/cache/MemoryCache.cpp Modified: trunk/Source/WebCore/ChangeLog (108784 => 108785) --- trunk/Source/WebCore/ChangeLog 2012-02-24 14:16:55 UTC (rev 108784) +++ trunk/Source/WebCore/ChangeLog 2012-02-24 14:31:59 UTC (rev 108785) @@ -1,3 +1,51 @@ +2012-02-24 Renata Hodovan r...@webkit.org + +External use xlink:href references do not work +https://bugs.webkit.org/show_bug.cgi?id=12499 + +Reviewed by Nikolas Zimmermann. + +Support external references on use by introducing CachedSVGDocument. +CachedSVGDocument is a CachedResource specialized for SVGDocuments. +This CachedSVGDocument will be stored for every use element with external reference. +This first patch only contains the new classes to test whether it works on every platform. +So they aren't used anywhere and just a follow-up patch will bind them into the caching system. + +No new tests - no change in functionality. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* loader/cache/CachedResource.cpp: +(WebCore::defaultPriorityForResourceType): +(WebCore::cachedResourceTypeToTargetType): +* loader/cache/CachedResource.h: +* loader/cache/CachedResourceClient.h: +(CachedResourceClient): +* loader/cache/CachedResourceLoader.cpp: +(WebCore::createResource): +(WebCore::CachedResourceLoader::checkInsecureContent): +(WebCore::CachedResourceLoader::canRequest): +* loader/cache/CachedSVGDocument.cpp: Added. +(WebCore): +(WebCore::CachedSVGDocument::CachedSVGDocument): +(WebCore::CachedSVGDocument::~CachedSVGDocument): +(WebCore::CachedSVGDocument::setEncoding): +(WebCore::CachedSVGDocument::encoding): +
[webkit-changes] [105039] trunk/Source/WebCore
Title: [105039] trunk/Source/WebCore Revision 105039 Author r...@webkit.org Date 2012-01-16 01:16:40 -0800 (Mon, 16 Jan 2012) Log Message Unreviewed build fix; added WebCore.exp.in changes lost in r105036. * WebCore.exp.in: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in Diff Modified: trunk/Source/WebCore/ChangeLog (105038 => 105039) --- trunk/Source/WebCore/ChangeLog 2012-01-16 08:47:55 UTC (rev 105038) +++ trunk/Source/WebCore/ChangeLog 2012-01-16 09:16:40 UTC (rev 105039) @@ -1,3 +1,9 @@ +2012-01-16 Renata Hodovan r...@webkit.org + +Unreviewed build fix; added WebCore.exp.in changes lost in r105036. + +* WebCore.exp.in: + 2012-01-15 Xinchao He xinchao...@intel.com Add DeviceOrientationEvent.absolute Modified: trunk/Source/WebCore/WebCore.exp.in (105038 => 105039) --- trunk/Source/WebCore/WebCore.exp.in 2012-01-16 08:47:55 UTC (rev 105038) +++ trunk/Source/WebCore/WebCore.exp.in 2012-01-16 09:16:40 UTC (rev 105039) @@ -536,7 +536,7 @@ __ZN7WebCore17CredentialStorage3getERKNS_15ProtectionSpaceE __ZN7WebCore17DOMImplementation13isXMLMIMETypeERKN3WTF6StringE __ZN7WebCore17DOMImplementation14isTextMIMETypeERKN3WTF6StringE -__ZN7WebCore17DeviceOrientation6createEbdbdbd +__ZN7WebCore17DeviceOrientation6createEbdbdbdbb __ZN7WebCore17GlyphPageTreeNode18treeGlyphPageCountEv __ZN7WebCore17HistoryController26saveDocumentAndScrollStateEv __ZN7WebCore17HistoryController33restoreScrollPositionAndViewStateEv ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103401] trunk/Source/WebCore
Title: [103401] trunk/Source/WebCore
Revision 103401
Author r...@webkit.org
Date 2011-12-21 02:20:36 -0800 (Wed, 21 Dec 2011)
Log Message
Fulfill FIXME in HTMLLinkElement.h.
https://bugs.webkit.org/show_bug.cgi?id=74278
Rename isStyleSheetLoading() method to styleSheetIsLoading().
This new one has the correct grammar.
Reviewed by Darin Adler.
No new tests because the functionality remains the same.
* dom/Document.cpp:
(WebCore::Document::recalcStyleSelector):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::styleSheetIsLoading):
(WebCore::HTMLLinkElement::sheetLoaded):
* html/HTMLLinkElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/HTMLLinkElement.cpp
trunk/Source/WebCore/html/HTMLLinkElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (103400 => 103401)
--- trunk/Source/WebCore/ChangeLog 2011-12-21 09:47:45 UTC (rev 103400)
+++ trunk/Source/WebCore/ChangeLog 2011-12-21 10:20:36 UTC (rev 103401)
@@ -1,3 +1,23 @@
+2011-12-21 Renata Hodovan r...@webkit.org
+
+Fulfill FIXME in HTMLLinkElement.h.
+https://bugs.webkit.org/show_bug.cgi?id=74278
+
+Rename isStyleSheetLoading() method to styleSheetIsLoading().
+This new one has the correct grammar.
+
+Reviewed by Darin Adler.
+
+No new tests because the functionality remains the same.
+
+* dom/Document.cpp:
+(WebCore::Document::recalcStyleSelector):
+* html/HTMLLinkElement.cpp:
+(WebCore::HTMLLinkElement::setDisabledState):
+(WebCore::HTMLLinkElement::styleSheetIsLoading):
+(WebCore::HTMLLinkElement::sheetLoaded):
+* html/HTMLLinkElement.h:
+
2011-12-21 Yosifumi Inoue yo...@chromium.org
[Forms] Add OVERRIDE to WebCore/html/*InputType.h
Modified: trunk/Source/WebCore/dom/Document.cpp (103400 => 103401)
--- trunk/Source/WebCore/dom/Document.cpp 2011-12-21 09:47:45 UTC (rev 103400)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-12-21 10:20:36 UTC (rev 103401)
@@ -3096,7 +3096,7 @@
if (linkElement-isDisabled())
continue;
enabledViaScript = linkElement-isEnabledViaScript();
-if (linkElement-isStyleSheetLoading()) {
+if (linkElement-styleSheetIsLoading()) {
// it is loading but we should still decide which style sheet set to use
if (!enabledViaScript !title.isEmpty() m_preferredStylesheetSet.isEmpty()) {
const AtomicString rel = e-getAttribute(relAttr);
Modified: trunk/Source/WebCore/html/HTMLLinkElement.cpp (103400 => 103401)
--- trunk/Source/WebCore/html/HTMLLinkElement.cpp 2011-12-21 09:47:45 UTC (rev 103400)
+++ trunk/Source/WebCore/html/HTMLLinkElement.cpp 2011-12-21 10:20:36 UTC (rev 103401)
@@ -90,7 +90,7 @@
if (oldDisabledState != m_disabledState) {
// If we change the disabled state while the sheet is still loading, then we have to
// perform three checks:
-if (isStyleSheetLoading()) {
+if (styleSheetIsLoading()) {
// Check #1: The sheet becomes disabled while loading.
if (m_disabledState == Disabled)
removePendingSheet();
@@ -333,7 +333,7 @@
m_sheet-checkLoaded();
}
-bool HTMLLinkElement::isStyleSheetLoading() const
+bool HTMLLinkElement::styleSheetIsLoading() const
{
if (m_loading)
return true;
@@ -354,7 +354,7 @@
bool HTMLLinkElement::sheetLoaded()
{
-if (!isStyleSheetLoading()) {
+if (!styleSheetIsLoading()) {
removePendingSheet();
return true;
}
Modified: trunk/Source/WebCore/html/HTMLLinkElement.h (103400 => 103401)
--- trunk/Source/WebCore/html/HTMLLinkElement.h 2011-12-21 09:47:45 UTC (rev 103400)
+++ trunk/Source/WebCore/html/HTMLLinkElement.h 2011-12-21 10:20:36 UTC (rev 103401)
@@ -53,7 +53,7 @@
CSSStyleSheet* sheet() const { return m_sheet.get(); }
-bool isStyleSheetLoading() const;
+bool styleSheetIsLoading() const;
bool isDisabled() const { return m_disabledState == Disabled; }
bool isEnabledViaScript() const { return m_disabledState == EnabledViaScript; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102580] trunk/Source/WebCore
Title: [102580] trunk/Source/WebCore
Revision 102580
Author r...@webkit.org
Date 2011-12-12 07:13:18 -0800 (Mon, 12 Dec 2011)
Log Message
Fulfill FIXME in HTMLLinkElement.h.
https://bugs.webkit.org/show_bug.cgi?id=74278
Rename HTMLLinkElement::isLoading() to isStyleSheetLoading().
Reviewed by Andreas Kling.
No new tests because the functionality remains the same.
* dom/Document.cpp:
(WebCore::Document::recalcStyleSelector):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::isStyleSheetLoading):
(WebCore::HTMLLinkElement::sheetLoaded):
* html/HTMLLinkElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/HTMLLinkElement.cpp
trunk/Source/WebCore/html/HTMLLinkElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (102579 => 102580)
--- trunk/Source/WebCore/ChangeLog 2011-12-12 14:54:34 UTC (rev 102579)
+++ trunk/Source/WebCore/ChangeLog 2011-12-12 15:13:18 UTC (rev 102580)
@@ -1,3 +1,22 @@
+2011-12-12 Renata Hodovan r...@webkit.org
+
+Fulfill FIXME in HTMLLinkElement.h.
+https://bugs.webkit.org/show_bug.cgi?id=74278
+
+Rename HTMLLinkElement::isLoading() to isStyleSheetLoading().
+
+Reviewed by Andreas Kling.
+
+No new tests because the functionality remains the same.
+
+* dom/Document.cpp:
+(WebCore::Document::recalcStyleSelector):
+* html/HTMLLinkElement.cpp:
+(WebCore::HTMLLinkElement::setDisabledState):
+(WebCore::HTMLLinkElement::isStyleSheetLoading):
+(WebCore::HTMLLinkElement::sheetLoaded):
+* html/HTMLLinkElement.h:
+
2011-11-25 Alexander Pavlov apav...@chromium.org
WebKit does not enumerate over CSS properties in HTMLElement.style
Modified: trunk/Source/WebCore/dom/Document.cpp (102579 => 102580)
--- trunk/Source/WebCore/dom/Document.cpp 2011-12-12 14:54:34 UTC (rev 102579)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-12-12 15:13:18 UTC (rev 102580)
@@ -3104,7 +3104,7 @@
if (linkElement-isDisabled())
continue;
enabledViaScript = linkElement-isEnabledViaScript();
-if (linkElement-isLoading()) {
+if (linkElement-isStyleSheetLoading()) {
// it is loading but we should still decide which style sheet set to use
if (!enabledViaScript !title.isEmpty() m_preferredStylesheetSet.isEmpty()) {
const AtomicString rel = e-getAttribute(relAttr);
Modified: trunk/Source/WebCore/html/HTMLLinkElement.cpp (102579 => 102580)
--- trunk/Source/WebCore/html/HTMLLinkElement.cpp 2011-12-12 14:54:34 UTC (rev 102579)
+++ trunk/Source/WebCore/html/HTMLLinkElement.cpp 2011-12-12 15:13:18 UTC (rev 102580)
@@ -90,7 +90,7 @@
if (oldDisabledState != m_disabledState) {
// If we change the disabled state while the sheet is still loading, then we have to
// perform three checks:
-if (isLoading()) {
+if (isStyleSheetLoading()) {
// Check #1: The sheet becomes disabled while loading.
if (m_disabledState == Disabled)
removePendingSheet();
@@ -333,7 +333,7 @@
m_sheet-checkLoaded();
}
-bool HTMLLinkElement::isLoading() const
+bool HTMLLinkElement::isStyleSheetLoading() const
{
if (m_loading)
return true;
@@ -354,7 +354,7 @@
bool HTMLLinkElement::sheetLoaded()
{
-if (!isLoading()) {
+if (!isStyleSheetLoading()) {
removePendingSheet();
return true;
}
Modified: trunk/Source/WebCore/html/HTMLLinkElement.h (102579 => 102580)
--- trunk/Source/WebCore/html/HTMLLinkElement.h 2011-12-12 14:54:34 UTC (rev 102579)
+++ trunk/Source/WebCore/html/HTMLLinkElement.h 2011-12-12 15:13:18 UTC (rev 102580)
@@ -53,8 +53,7 @@
CSSStyleSheet* sheet() const { return m_sheet.get(); }
-// FIXME: This should be renamed isStyleSheetLoading as this is only used for stylesheets.
-bool isLoading() const;
+bool isStyleSheetLoading() const;
bool isDisabled() const { return m_disabledState == Disabled; }
bool isEnabledViaScript() const { return m_disabledState == EnabledViaScript; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101515] trunk/Source/WebCore
Title: [101515] trunk/Source/WebCore
Revision 101515
Author r...@webkit.org
Date 2011-11-30 07:35:57 -0800 (Wed, 30 Nov 2011)
Log Message
MAC build fix after r101507.
Rubber stamped by Csaba Osztrogonac.
* platform/network/SocketStreamHandleClient.h:
(WebCore::SocketStreamHandleClient::didUpdateBufferedAmount):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::didUpdateBufferedAmount):
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didUpdateBufferedAmount):
* websockets/WebSocketChannel.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/SocketStreamHandleClient.h
trunk/Source/WebCore/websockets/WebSocket.cpp
trunk/Source/WebCore/websockets/WebSocket.h
trunk/Source/WebCore/websockets/WebSocketChannel.cpp
trunk/Source/WebCore/websockets/WebSocketChannel.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (101514 => 101515)
--- trunk/Source/WebCore/ChangeLog 2011-11-30 15:32:04 UTC (rev 101514)
+++ trunk/Source/WebCore/ChangeLog 2011-11-30 15:35:57 UTC (rev 101515)
@@ -1,3 +1,18 @@
+2011-11-30 Renata Hodovan r...@webkit.org
+
+MAC build fix after r101507.
+
+Rubber stamped by Csaba Osztrogonac.
+
+* platform/network/SocketStreamHandleClient.h:
+(WebCore::SocketStreamHandleClient::didUpdateBufferedAmount):
+* websockets/WebSocket.cpp:
+(WebCore::WebSocket::didUpdateBufferedAmount):
+* websockets/WebSocket.h:
+* websockets/WebSocketChannel.cpp:
+(WebCore::WebSocketChannel::didUpdateBufferedAmount):
+* websockets/WebSocketChannel.h:
+
2011-11-30 John Knottenbelt jknot...@chromium.org
Remove unnecessary asserts in HTMLTextAreaElement.
Modified: trunk/Source/WebCore/platform/network/SocketStreamHandleClient.h (101514 => 101515)
--- trunk/Source/WebCore/platform/network/SocketStreamHandleClient.h 2011-11-30 15:32:04 UTC (rev 101514)
+++ trunk/Source/WebCore/platform/network/SocketStreamHandleClient.h 2011-11-30 15:35:57 UTC (rev 101515)
@@ -46,7 +46,7 @@
virtual void didOpenSocketStream(SocketStreamHandle*) { }
virtual void didCloseSocketStream(SocketStreamHandle*) { }
virtual void didReceiveSocketStreamData(SocketStreamHandle*, const char* /*data*/, int /*length*/) { }
-virtual void didUpdateBufferedAmount(SocketStreamHandle*, size_t bufferedAmount) { }
+virtual void didUpdateBufferedAmount(SocketStreamHandle*, size_t /*bufferedAmount*/) { }
virtual void didFailSocketStream(SocketStreamHandle*, const SocketStreamError) { }
Modified: trunk/Source/WebCore/websockets/WebSocket.cpp (101514 => 101515)
--- trunk/Source/WebCore/websockets/WebSocket.cpp 2011-11-30 15:32:04 UTC (rev 101514)
+++ trunk/Source/WebCore/websockets/WebSocket.cpp 2011-11-30 15:35:57 UTC (rev 101515)
@@ -507,6 +507,7 @@
void WebSocket::didUpdateBufferedAmount(unsigned long bufferedAmount)
{
+UNUSED_PARAM(bufferedAmount);
LOG(Network, WebSocket %p didUpdateBufferedAmount %lu, this, bufferedAmount);
}
Modified: trunk/Source/WebCore/websockets/WebSocket.h (101514 => 101515)
--- trunk/Source/WebCore/websockets/WebSocket.h 2011-11-30 15:32:04 UTC (rev 101514)
+++ trunk/Source/WebCore/websockets/WebSocket.h 2011-11-30 15:35:57 UTC (rev 101515)
@@ -106,7 +106,7 @@
virtual void didReceiveMessage(const String message);
virtual void didReceiveBinaryData(PassOwnPtrVectorchar );
virtual void didReceiveMessageError();
-virtual void didUpdateBufferedAmount(unsigned long bufferedAmount);
+virtual void didUpdateBufferedAmount(unsigned long);
virtual void didStartClosingHandshake();
virtual void didClose(unsigned long unhandledBufferedAmount, ClosingHandshakeCompletionStatus, unsigned short code, const String reason);
Modified: trunk/Source/WebCore/websockets/WebSocketChannel.cpp (101514 => 101515)
--- trunk/Source/WebCore/websockets/WebSocketChannel.cpp 2011-11-30 15:32:04 UTC (rev 101514)
+++ trunk/Source/WebCore/websockets/WebSocketChannel.cpp 2011-11-30 15:35:57 UTC (rev 101515)
@@ -325,7 +325,7 @@
break;
}
-void WebSocketChannel::didUpdateBufferedAmount(SocketStreamHandle* handle, size_t bufferedAmount)
+void WebSocketChannel::didUpdateBufferedAmount(SocketStreamHandle*, size_t bufferedAmount)
{
if (m_client)
m_client-didUpdateBufferedAmount(bufferedAmount);
Modified: trunk/Source/WebCore/websockets/WebSocketChannel.h (101514 => 101515)
--- trunk/Source/WebCore/websockets/WebSocketChannel.h 2011-11-30 15:32:04 UTC (rev 101514)
+++ trunk/Source/WebCore/websockets/WebSocketChannel.h 2011-11-30 15:35:57 UTC (rev 101515)
@@ -81,7 +81,7 @@
virtual void didOpenSocketStream(SocketStreamHandle*);
virtual void didCloseSocketStream(SocketStreamHandle*);
virtual void didReceiveSocketStreamData(SocketStreamHandle*, const char*, int);
-virtual void didUpdateBufferedAmount(SocketStreamHandle*, size_t bufferedAmount);
[webkit-changes] [101520] trunk/Source/WebCore
Title: [101520] trunk/Source/WebCore
Revision 101520
Author r...@webkit.org
Date 2011-11-30 08:25:21 -0800 (Wed, 30 Nov 2011)
Log Message
CG buildfix after r101517.
Rubber stamped by Zoltan Herczeg.
* rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::fillShape):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGRect.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (101519 => 101520)
--- trunk/Source/WebCore/ChangeLog 2011-11-30 16:15:11 UTC (rev 101519)
+++ trunk/Source/WebCore/ChangeLog 2011-11-30 16:25:21 UTC (rev 101520)
@@ -1,3 +1,12 @@
+2011-11-30 Renata Hodovan r...@webkit.org
+
+CG buildfix after r101517.
+
+Rubber stamped by Zoltan Herczeg.
+
+* rendering/svg/RenderSVGRect.cpp:
+(WebCore::RenderSVGRect::fillShape):
+
2011-11-30 Anna Cavender ann...@chromium.org
Missing RuntimeEnabled check for track
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRect.cpp (101519 => 101520)
--- trunk/Source/WebCore/rendering/svg/RenderSVGRect.cpp 2011-11-30 16:15:11 UTC (rev 101519)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRect.cpp 2011-11-30 16:25:21 UTC (rev 101520)
@@ -99,7 +99,7 @@
void RenderSVGRect::fillShape(GraphicsContext* context) const
{
if (!isPaintingFallback()) {
-#if PLATFORM(MAC) || (PLATFORM(CHROMIUM) OS(MAC_OS_X))
+#if USE(CG)
// FIXME: CG implementation of GraphicsContextCG::fillRect has an own
// shadow drawing method, which draws an extra shadow.
// This is a workaround for switching off the extra shadow.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100980] trunk/LayoutTests
Title: [100980] trunk/LayoutTests Revision 100980 Author r...@webkit.org Date 2011-11-22 00:50:59 -0800 (Tue, 22 Nov 2011) Log Message [Qt] inspector/extensions/extensions-events.html crashing after r100926 https://bugs.webkit.org/show_bug.cgi?id=72932 Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100979 => 100980) --- trunk/LayoutTests/ChangeLog 2011-11-22 08:30:42 UTC (rev 100979) +++ trunk/LayoutTests/ChangeLog 2011-11-22 08:50:59 UTC (rev 100980) @@ -1,3 +1,12 @@ +2011-11-22 Renata Hodovan r...@webkit.org + +[Qt] inspector/extensions/extensions-events.html crashing after r100926 +https://bugs.webkit.org/show_bug.cgi?id=72932 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-11-22 Mario Sanchez Prada msanc...@igalia.com [GTK] platform/gtk/accessibility/name-from-label.html fails Modified: trunk/LayoutTests/platform/qt/Skipped (100979 => 100980) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-22 08:30:42 UTC (rev 100979) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-22 08:50:59 UTC (rev 100980) @@ -2477,3 +2477,7 @@ # [Qt] fast/canvas/canvas-lineWidth.html timeouts intermittently on 64 bit # https://bugs.webkit.org/show_bug.cgi?id=72694 fast/canvas/canvas-lineWidth.html + +# [Qt] inspector/extensions/extensions-events.html crashing after r100926 +# https://bugs.webkit.org/show_bug.cgi?id=72932 +inspector/extensions/extensions-events.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100982] trunk/LayoutTests
Title: [100982] trunk/LayoutTests
Revision 100982
Author r...@webkit.org
Date 2011-11-22 01:19:17 -0800 (Tue, 22 Nov 2011)
Log Message
Unreviewed gardening. Reset test results.
Patch by Feher Zsolt fehe...@inf.u-szeged.hu on 2011-11-22
* platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
* platform/qt-5.0/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
* platform/qt-5.0/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt
trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt
trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt
trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-optional-001-expected.txt
trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-optional-002-expected.txt
trunk/LayoutTests/platform/qt-5.0/fast/multicol/pagination-h-horizontal-bt-expected.txt
trunk/LayoutTests/platform/qt-5.0/fast/multicol/pagination-h-horizontal-tb-expected.txt
trunk/LayoutTests/platform/qt-5.0/fast/multicol/pagination-h-vertical-rl-expected.txt
trunk/LayoutTests/platform/qt-5.0/fast/multicol/pagination-v-horizontal-bt-expected.txt
trunk/LayoutTests/platform/qt-5.0/fast/multicol/pagination-v-vertical-lr-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (100981 => 100982)
--- trunk/LayoutTests/ChangeLog 2011-11-22 09:18:46 UTC (rev 100981)
+++ trunk/LayoutTests/ChangeLog 2011-11-22 09:19:17 UTC (rev 100982)
@@ -1,3 +1,18 @@
+2011-11-22 Feher Zsolt fehe...@inf.u-szeged.hu
+
+Unreviewed gardening. Reset test results.
+
+* platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
+* platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt: Added.
+* platform/qt-5.0/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
+* platform/qt-5.0/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
+* platform/qt-5.0/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
+* platform/qt-5.0/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
+* platform/qt-5.0/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
+* platform/qt-5.0/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
+* platform/qt-5.0/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
+* platform/qt-5.0/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
+
2011-11-22 Renata Hodovan r...@webkit.org
[Qt] inspector/extensions/extensions-events.html crashing after r100926
Added: trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt (0 => 100982)
--- trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt 2011-11-22 09:19:17 UTC (rev 100982)
@@ -0,0 +1,12 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x318
+ RenderBlock {HTML} at (0,0) size 800x318
+RenderBody {BODY} at (8,16) size 784x294
+ RenderBlock {P} at (0,0) size 784x38
+RenderText {#text} at (0,0) size 741x38
+ text run at (0,0) width 741: Test passes if there is a blue and orange square below and there is no vertical gap between the
+ text run at (0,19) width 68: squares.
+ RenderTable {DIV} at (0,54) size 120x240
+RenderBlock {DIV} at (0,0) size 120x120 [border: (10px solid #FF)]
+RenderBlock {DIV} at (0,120) size 120x120 [border: (10px solid #FFA500)]
Added: trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt (0 => 100982)
--- trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt 2011-11-22 09:19:17 UTC (rev 100982)
@@ -0,0 +1,34 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x168
+ RenderBlock {HTML} at (0,0) size 800x168
+RenderTable {BODY} at (8,8) size 784x152
+
[webkit-changes] [100249] trunk/LayoutTests
Title: [100249] trunk/LayoutTests Revision 100249 Author r...@webkit.org Date 2011-11-15 01:13:59 -0800 (Tue, 15 Nov 2011) Log Message [Qt] Two tests are skipped after r100182 and r100239. Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100248 => 100249) --- trunk/LayoutTests/ChangeLog 2011-11-15 09:05:33 UTC (rev 100248) +++ trunk/LayoutTests/ChangeLog 2011-11-15 09:13:59 UTC (rev 100249) @@ -1,3 +1,11 @@ +2011-11-15 Renata Hodovan r...@webkit.org + +[Qt] Two tests are skipped after r100182 and r100239. + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-11-15 Kent Tamura tk...@chromium.org [V8] Fix incorrect handling of _javascript_ properties in DOMStringMap Modified: trunk/LayoutTests/platform/qt/Skipped (100248 => 100249) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-15 09:05:33 UTC (rev 100248) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-15 09:13:59 UTC (rev 100249) @@ -2511,3 +2511,11 @@ # https://bugs.webkit.org/show_bug.cgi?id=72274 inspector/timeline inspector/user-metrics.html + +# [Qt] fast/dom/Window/window-postmessage-arrays.html fails after r100239 +# https://bugs.webkit.org/show_bug.cgi?id=72363 +fast/dom/Window/window-postmessage-arrays.html + +# [Qt] http/tests/security/postMessage/invalid-origin-throws-exception.html fails after r100182 +# https://bugs.webkit.org/show_bug.cgi?id=72364 +http/tests/security/postMessage/invalid-origin-throws-exception.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100250] trunk/LayoutTests
Title: [100250] trunk/LayoutTests
Revision 100250
Author r...@webkit.org
Date 2011-11-15 01:24:01 -0800 (Tue, 15 Nov 2011)
Log Message
[Qt] Platform-specific result for r100157.
Unreviewed, gardening.
Patch by Czene Tamás tcz...@inf.u-szeged.hu on 2011-11-15
* platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png: Added.
* platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png
trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (100249 => 100250)
--- trunk/LayoutTests/ChangeLog 2011-11-15 09:13:59 UTC (rev 100249)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 09:24:01 UTC (rev 100250)
@@ -1,3 +1,12 @@
+2011-11-15 Czene Tamás tcz...@inf.u-szeged.hu
+
+[Qt] Platform-specific result for r100157.
+
+Unreviewed, gardening.
+
+* platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png: Added.
+* platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
+
2011-11-15 Renata Hodovan r...@webkit.org
[Qt] Two tests are skipped after r100182 and r100239.
Added: trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt (0 => 100250)
--- trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt 2011-11-15 09:24:01 UTC (rev 100250)
@@ -0,0 +1,13 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (0,0) size 800x600
+ RenderSVGRoot {svg} at (0,0) size 400x100
+RenderSVGForeignObject {foreignObject} at (0,0) size 100x100
+ RenderBlock {DIV} at (0,0) size 100x100 [bgcolor=#008000]
+RenderText {#text} at (0,0) size 4x21
+ text run at (0,0) width 4:
+RenderSVGForeignObject {foreignObject} at (150,0) size 100x100
+ RenderBlock {DIV} at (0,0) size 100x100 [bgcolor=#008000]
+ RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100254] trunk/LayoutTests
Title: [100254] trunk/LayoutTests Revision 100254 Author r...@webkit.org Date 2011-11-15 01:47:36 -0800 (Tue, 15 Nov 2011) Log Message Unviewed gardening after r100159. Patch by Oliver Varga voli...@inf.u-szeged.hu on 2011-11-15 * platform/qt/fast/dom/Window/window-properties-expected.png: * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-property-descriptors-expected.png: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: * platform/qt/fast/dom/prototype-inheritance-2-expected.png: * platform/qt/fast/dom/prototype-inheritance-2-expected.txt: * platform/qt/fast/js/global-constructors-expected.png: * platform/qt/fast/js/global-constructors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.png trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.png trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.png trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100253 => 100254) --- trunk/LayoutTests/ChangeLog 2011-11-15 09:37:30 UTC (rev 100253) +++ trunk/LayoutTests/ChangeLog 2011-11-15 09:47:36 UTC (rev 100254) @@ -1,3 +1,16 @@ +2011-11-15 Oliver Varga voli...@inf.u-szeged.hu + +Unviewed gardening after r100159. + +* platform/qt/fast/dom/Window/window-properties-expected.png: +* platform/qt/fast/dom/Window/window-properties-expected.txt: +* platform/qt/fast/dom/Window/window-property-descriptors-expected.png: +* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/qt/fast/dom/prototype-inheritance-2-expected.png: +* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: +* platform/qt/fast/js/global-constructors-expected.png: +* platform/qt/fast/js/global-constructors-expected.txt: + 2011-11-14 Alexander Pavlov apav...@chromium.org Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (100253 => 100254) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-15 09:37:30 UTC (rev 100253) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-15 09:47:36 UTC (rev 100254) @@ -1247,6 +1247,13 @@ window.Math.sin [function] window.Math.sqrt [function] window.Math.tan [function] +window.MediaController [object MediaControllerConstructor] +window.MediaController.prototype [object MediaControllerPrototype] +window.MediaController.prototype.addEventListener [function] +window.MediaController.prototype.dispatchEvent [function] +window.MediaController.prototype.pause [function] +window.MediaController.prototype.play [function] +window.MediaController.prototype.removeEventListener [function] window.MediaError [object MediaErrorConstructor] window.MediaError.MEDIA_ERR_ABORTED [number] window.MediaError.MEDIA_ERR_DECODE [number] @@ -2458,7 +2465,6 @@ window.onmousewheel [null] window.onoffline [null] window.ononline [null] -window.onorientationchange [null] window.onpagehide [null] window.onpageshow [null] window.onpause [null] @@ -2492,7 +2498,6 @@ window.onwebkittransitionend [null] window.open [function] window.openDatabase [function] -window.orientation [number] window.outerHeight [number] window.outerWidth [number] window.pageXOffset [number] Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt (100253 => 100254) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-11-15 09:37:30 UTC (rev 100253) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-11-15 09:47:36 UTC (rev 100254) @@ -43,8 +43,6 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'DOMStringMap') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'DOMTokenList') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'Date') is 'object' -PASS typeof Object.getOwnPropertyDescriptor(window, 'DeviceMotionEvent') is 'object' -PASS typeof Object.getOwnPropertyDescriptor(window, 'DeviceOrientationEvent') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window,
[webkit-changes] [98933] trunk/Source/WebCore
Title: [98933] trunk/Source/WebCore
Revision 98933
Author r...@webkit.org
Date 2011-10-31 18:47:17 -0700 (Mon, 31 Oct 2011)
Log Message
[Qt] Build fix after r98853.
Rubber-stamped by Andreas Kling.
* xml/XSLImportRule.cpp:
* xml/XSLImportRule.h:
(WebCore::XSLImportRule::parentStyleSheet):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XSLImportRule.cpp
trunk/Source/WebCore/xml/XSLImportRule.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98932 => 98933)
--- trunk/Source/WebCore/ChangeLog 2011-11-01 01:15:06 UTC (rev 98932)
+++ trunk/Source/WebCore/ChangeLog 2011-11-01 01:47:17 UTC (rev 98933)
@@ -1,3 +1,13 @@
+2011-10-31 Renata Hodovan r...@webkit.org
+
+[Qt] Build fix after r98853.
+
+Rubber-stamped by Andreas Kling.
+
+* xml/XSLImportRule.cpp:
+* xml/XSLImportRule.h:
+(WebCore::XSLImportRule::parentStyleSheet):
+
2011-10-31 Mark Hahnenberg mhahnenb...@apple.com
De-virtualize JSObject::defaultValue
Modified: trunk/Source/WebCore/xml/XSLImportRule.cpp (98932 => 98933)
--- trunk/Source/WebCore/xml/XSLImportRule.cpp 2011-11-01 01:15:06 UTC (rev 98932)
+++ trunk/Source/WebCore/xml/XSLImportRule.cpp 2011-11-01 01:47:17 UTC (rev 98933)
@@ -48,11 +48,6 @@
m_cachedSheet-removeClient(this);
}
-XSLStyleSheet* XSLImportRule::parentStyleSheet() const
-{
-return m_parentStyleSheet;
-}
-
void XSLImportRule::setXSLStyleSheet(const String href, const KURL baseURL, const String sheet)
{
if (m_styleSheet)
Modified: trunk/Source/WebCore/xml/XSLImportRule.h (98932 => 98933)
--- trunk/Source/WebCore/xml/XSLImportRule.h 2011-11-01 01:15:06 UTC (rev 98932)
+++ trunk/Source/WebCore/xml/XSLImportRule.h 2011-11-01 01:47:17 UTC (rev 98933)
@@ -47,7 +47,7 @@
const String href() const { return m_strHref; }
XSLStyleSheet* styleSheet() const { return m_styleSheet.get(); }
-XSLStyleSheet* parentStyleSheet() const;
+XSLStyleSheet* parentStyleSheet() const { return m_parentStyleSheet; }
void setParentStyleSheet(XSLStyleSheet* styleSheet) { m_parentStyleSheet = styleSheet; }
bool isLoading();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97130] trunk/LayoutTests
Title: [97130] trunk/LayoutTests
Revision 97130
Author r...@webkit.org
Date 2011-10-11 00:50:14 -0700 (Tue, 11 Oct 2011)
Log Message
[Qt] Update test expectation after r97109.
Unreviewed gardening.
Patch by Oliver Varga voli...@inf.u-szeged.hu on 2011-10-11
* platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
* platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.png
trunk/LayoutTests/platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97129 => 97130)
--- trunk/LayoutTests/ChangeLog 2011-10-11 07:40:22 UTC (rev 97129)
+++ trunk/LayoutTests/ChangeLog 2011-10-11 07:50:14 UTC (rev 97130)
@@ -1,3 +1,12 @@
+2011-10-11 Oliver Varga voli...@inf.u-szeged.hu
+
+[Qt] Update test expectation after r97109.
+
+Unreviewed gardening.
+
+* platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
+* platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
+
2011-10-11 Dominic Mazzoni dmazz...@google.com
Enable accessibility tests on chromium and update test expectations.
Added: trunk/LayoutTests/platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.txt (0 => 97130)
--- trunk/LayoutTests/platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/fast/css-generated-content/table-parts-before-and-after-expected.txt 2011-10-11 07:50:14 UTC (rev 97130)
@@ -0,0 +1,101 @@
+layer at (0,0) size 784x736
+ RenderView at (0,0) size 784x600
+layer at (0,0) size 784x736
+ RenderBlock {HTML} at (0,0) size 784x736
+RenderBody {BODY} at (8,8) size 768x720
+ RenderBlock {DIV} at (0,0) size 768x120
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: 1
+RenderBlock (anonymous) at (0,40) size 768x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: 22
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: 333
+ RenderBlock {DIV} at (0,120) size 768x120 [color=#FF]
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: 1
+RenderBlock (anonymous) at (0,40) size 768x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: 22
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: 333
+ RenderBlock {DIV} at (0,240) size 768x120
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: 1
+RenderBlock (anonymous) at (0,40) size 768x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: 22
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+
[webkit-changes] [96578] trunk/LayoutTests
Title: [96578] trunk/LayoutTests
Revision 96578
Author r...@webkit.org
Date 2011-10-04 02:30:03 -0700 (Tue, 04 Oct 2011)
Log Message
[Qt] Unreviewed gardening. Update Qt specific expected files after r96498.
Patch by Oliver Varga voli...@inf.u-szeged.hu on 2011-10-04
* platform/qt/svg/filters/feColorMatrix-saturate-expected.png: Added.
* platform/qt/svg/filters/feColorMatrix-saturate-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-saturate-expected.png
trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-saturate-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (96577 => 96578)
--- trunk/LayoutTests/ChangeLog 2011-10-04 09:17:08 UTC (rev 96577)
+++ trunk/LayoutTests/ChangeLog 2011-10-04 09:30:03 UTC (rev 96578)
@@ -1,3 +1,10 @@
+2011-10-04 Oliver Varga voli...@inf.u-szeged.hu
+
+[Qt] Unreviewed gardening. Update Qt specific expected files after r96498.
+
+* platform/qt/svg/filters/feColorMatrix-saturate-expected.png: Added.
+* platform/qt/svg/filters/feColorMatrix-saturate-expected.txt: Added.
+
2011-10-04 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r96491.
Added: trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-saturate-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-saturate-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-saturate-expected.txt (0 => 96578)
--- trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-saturate-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-saturate-expected.txt 2011-10-04 09:30:03 UTC (rev 96578)
@@ -0,0 +1,32 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderSVGRoot {svg} at (0,0) size 250x251
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+ RenderSVGResourceFilter {filter} [id=f1] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feColorMatrix type=SATURATE values=-100.00]
+ [SourceGraphic]
+ RenderSVGResourceFilter {filter} [id=f2] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feColorMatrix type=SATURATE values=0.00]
+ [SourceGraphic]
+ RenderSVGResourceFilter {filter} [id=f3] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feColorMatrix type=SATURATE values=1.00]
+ [SourceGraphic]
+ RenderSVGResourceFilter {filter} [id=f4] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feColorMatrix type=SATURATE values=100.00]
+ [SourceGraphic]
+ RenderSVGResourceLinearGradient {linearGradient} [id=gradient] [gradientUnits=objectBoundingBox] [start=(0,0)] [end=(1,1)]
+RenderSVGGradientStop {stop} [offset=0.00] [color=#EE82EE]
+RenderSVGGradientStop {stop} [offset=0.20] [color=#FF]
+RenderSVGGradientStop {stop} [offset=0.40] [color=#00FF00]
+RenderSVGGradientStop {stop} [offset=0.60] [color=#00]
+RenderSVGGradientStop {stop} [offset=0.80] [color=#FFA500]
+RenderSVGGradientStop {stop} [offset=1.00] [color=#008000]
+RenderSVGPath {rect} at (0,0) size 121x121 [fill={[type=LINEAR-GRADIENT] [id=gradient]}] [x=10.00] [y=10.00] [width=100.00] [height=100.00]
+ [filter=f1] RenderSVGResourceFilter {filter} at (0,0) size 120x120
+RenderSVGPath {rect} at (130,0) size 120x121 [fill={[type=LINEAR-GRADIENT] [id=gradient]}] [x=140.00] [y=10.00] [width=100.00] [height=100.00]
+ [filter=f2] RenderSVGResourceFilter {filter} at (130,0) size 120x120
+RenderSVGPath {rect} at (0,130) size 121x120 [fill={[type=LINEAR-GRADIENT] [id=gradient]}] [x=10.00] [y=140.00] [width=100.00] [height=100.00]
+ [filter=f3] RenderSVGResourceFilter {filter} at (0,130) size 120x120
+RenderSVGPath {rect} at (130,130) size 120x120 [fill={[type=LINEAR-GRADIENT] [id=gradient]}] [x=140.00] [y=140.00] [width=100.00] [height=100.00]
+ [filter=f4] RenderSVGResourceFilter {filter} at (130,130) size 120x120
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96075] trunk/LayoutTests
Title: [96075] trunk/LayoutTests Revision 96075 Author r...@webkit.org Date 2011-09-26 23:43:27 -0700 (Mon, 26 Sep 2011) Log Message [Qt] Skip two tests because they are failing after r96070. Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (96074 => 96075) --- trunk/LayoutTests/ChangeLog 2011-09-27 06:32:10 UTC (rev 96074) +++ trunk/LayoutTests/ChangeLog 2011-09-27 06:43:27 UTC (rev 96075) @@ -1,3 +1,11 @@ +2011-09-26 Renata Hodovan r...@webkit.org + +[Qt] Skip two tests because they are failing after r96070. + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-09-26 Kentaro Hara hara...@chromium.org Implement PopStateEvent.state with SerializedScriptValue and ScriptValue Modified: trunk/LayoutTests/platform/qt/Skipped (96074 => 96075) --- trunk/LayoutTests/platform/qt/Skipped 2011-09-27 06:32:10 UTC (rev 96074) +++ trunk/LayoutTests/platform/qt/Skipped 2011-09-27 06:43:27 UTC (rev 96075) @@ -2377,3 +2377,9 @@ # editing/selection/select-bidi-run.html fails on Qt # https://bugs.webkit.org/show_bug.cgi?id=68854 editing/selection/select-bidi-run.html + +# Two tests fail after r96070 +# https://bugs.webkit.org/show_bug.cgi?id=68872 +fast/loader/stateobjects/pushstate-clears-forward-history.html +fast/frames/frame-dead-region.html + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96077] trunk/LayoutTests
Title: [96077] trunk/LayoutTests
Revision 96077
Author r...@webkit.org
Date 2011-09-27 00:05:21 -0700 (Tue, 27 Sep 2011)
Log Message
[Qt] Add missing test expecteds after r95924.
Unreviewed gardening.
* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png
trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (96076 => 96077)
--- trunk/LayoutTests/ChangeLog 2011-09-27 06:55:34 UTC (rev 96076)
+++ trunk/LayoutTests/ChangeLog 2011-09-27 07:05:21 UTC (rev 96077)
@@ -1,3 +1,12 @@
+2011-09-27 Renata Hodovan r...@webkit.org
+
+[Qt] Add missing test expecteds after r95924.
+
+Unreviewed gardening.
+
+* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
+* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
+
2011-09-26 Ryosuke Niwa rn...@webkit.org
dump-as-markup conversion: editing/deleting/delete-to-end-of-paragraph.html
Added: trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt (0 => 96077)
--- trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt 2011-09-27 07:05:21 UTC (rev 96077)
@@ -0,0 +1,20 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x32
+ RenderBlock {HTML} at (0,0) size 800x32
+RenderBody {BODY} at (8,8) size 784x16
+ RenderRuby (inline) {RUBY} at (0,0) size 64x17
+RenderRubyRun (anonymous) at (0,0) size 64x16
+ RenderRubyBase (anonymous) at (0,0) size 64x16
+RenderBlock (anonymous) at (0,0) size 64x16
+ RenderText {#text} at (0,0) size 64x17
+text run at (0,0) width 64: PASS
+ RenderInline {I} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 0x0
+RenderBlock (anonymous) at (0,16) size 64x0
+ RenderInline {SPAN} at (0,0) size 0x0
+RenderInline {SPAN} at (0,0) size 0x0
+ RenderText {#text} at (0,0) size 0x0
+ RenderText {#text} at (0,0) size 0x0
+RenderBlock (anonymous) at (0,16) size 64x0
+ RenderInline {I} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95949] trunk/LayoutTests
Title: [95949] trunk/LayoutTests Revision 95949 Author r...@webkit.org Date 2011-09-26 07:39:24 -0700 (Mon, 26 Sep 2011) Log Message Unreviewed Qt gardening. https://bugs.webkit.org/show_bug.cgi?id=51639 Patch by Zsolt Fehér fehe...@inf.u-szeged.hu on 2011-09-26 * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (95948 => 95949) --- trunk/LayoutTests/ChangeLog 2011-09-26 13:35:51 UTC (rev 95948) +++ trunk/LayoutTests/ChangeLog 2011-09-26 14:39:24 UTC (rev 95949) @@ -1,3 +1,10 @@ +2011-09-26 Zsolt Fehér fehe...@inf.u-szeged.hu + +Unreviewed Qt gardening. +https://bugs.webkit.org/show_bug.cgi?id=51639 + +* platform/qt/Skipped: + 2011-09-26 Andrey Kosyakov ca...@chromium.org Web Inspector: [Extensions API] allow resources to hook on click on resource links Modified: trunk/LayoutTests/platform/qt/Skipped (95948 => 95949) --- trunk/LayoutTests/platform/qt/Skipped 2011-09-26 13:35:51 UTC (rev 95948) +++ trunk/LayoutTests/platform/qt/Skipped 2011-09-26 14:39:24 UTC (rev 95949) @@ -2369,3 +2369,7 @@ # Fails on non-Chromium bots # https://bugs.webkit.org/show_bug.cgi?id=68278 http/tests/history/back-with-fragment-change.php + +# Test failed after r95885 +# https://bugs.webkit.org/show_bug.cgi?id=51639 +editing/style/justify-without-enclosing-block.xhtml ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95950] trunk/LayoutTests
Title: [95950] trunk/LayoutTests Revision 95950 Author r...@webkit.org Date 2011-09-26 07:45:33 -0700 (Mon, 26 Sep 2011) Log Message Unreviewed Qt gardening. https://bugs.webkit.org/show_bug.cgi?id=68796 Patch by Zsolt Fehér fehe...@inf.u-szeged.hu on 2011-09-26 * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (95949 => 95950) --- trunk/LayoutTests/ChangeLog 2011-09-26 14:39:24 UTC (rev 95949) +++ trunk/LayoutTests/ChangeLog 2011-09-26 14:45:33 UTC (rev 95950) @@ -1,6 +1,13 @@ 2011-09-26 Zsolt Fehér fehe...@inf.u-szeged.hu Unreviewed Qt gardening. +https://bugs.webkit.org/show_bug.cgi?id=68796 + +* platform/qt/Skipped: + +2011-09-26 Zsolt Fehér fehe...@inf.u-szeged.hu + +Unreviewed Qt gardening. https://bugs.webkit.org/show_bug.cgi?id=51639 * platform/qt/Skipped: Modified: trunk/LayoutTests/platform/qt/Skipped (95949 => 95950) --- trunk/LayoutTests/platform/qt/Skipped 2011-09-26 14:39:24 UTC (rev 95949) +++ trunk/LayoutTests/platform/qt/Skipped 2011-09-26 14:45:33 UTC (rev 95950) @@ -2373,3 +2373,7 @@ # Test failed after r95885 # https://bugs.webkit.org/show_bug.cgi?id=51639 editing/style/justify-without-enclosing-block.xhtml + +# Test failed after r95899 +# https://bugs.webkit.org/show_bug.cgi?id=68796 +canvas/philip/tests/2d.drawImage.outsidesource.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95519] trunk/LayoutTests
Title: [95519] trunk/LayoutTests Revision 95519 Author r...@webkit.org Date 2011-09-20 01:05:22 -0700 (Tue, 20 Sep 2011) Log Message [Qt] Two tests fail after r95488 r95489 https://bugs.webkit.org/show_bug.cgi?id=68428 Skip the failing tests. Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (95518 => 95519) --- trunk/LayoutTests/ChangeLog 2011-09-20 07:57:52 UTC (rev 95518) +++ trunk/LayoutTests/ChangeLog 2011-09-20 08:05:22 UTC (rev 95519) @@ -1,3 +1,14 @@ +2011-09-20 Renata Hodovan r...@webkit.org + +[Qt] Two tests fail after r95488 r95489 +https://bugs.webkit.org/show_bug.cgi?id=68428 + +Skip the failing tests. + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-09-19 Ryosuke Niwa rn...@webkit.org Hit testing on margins of body and head elements doesn't recur Modified: trunk/LayoutTests/platform/qt/Skipped (95518 => 95519) --- trunk/LayoutTests/platform/qt/Skipped 2011-09-20 07:57:52 UTC (rev 95518) +++ trunk/LayoutTests/platform/qt/Skipped 2011-09-20 08:05:22 UTC (rev 95519) @@ -2434,3 +2434,7 @@ # Fails on non-Chromium bots # https://bugs.webkit.org/show_bug.cgi?id=68278 http/tests/history/back-with-fragment-change.php + +# [Qt] Two tests fail after fail after r95488 r95489 +http/tests/security/document-all.html +http/tests/security/window-named-proto.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95520] trunk/LayoutTests
Title: [95520] trunk/LayoutTests
Revision 95520
Author r...@webkit.org
Date 2011-09-20 01:36:05 -0700 (Tue, 20 Sep 2011)
Log Message
[Qt] Add Qt specific expecteds to new tests introduced in r95461.
Unreviewed gardening.
* platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
* platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
* platform/qt/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
* platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
* platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
* platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
* platform/qt/fast/table/table-row-before-after-content-around-block-expected.png: Added.
* platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt: Added.
* platform/qt/fast/table/table-row-before-after-content-around-table-expected.png: Added.
* platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.png
trunk/LayoutTests/platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt
trunk/LayoutTests/platform/qt/fast/table/table-cell-before-after-content-around-table-expected.png
trunk/LayoutTests/platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt
trunk/LayoutTests/platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.png
trunk/LayoutTests/platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.txt
trunk/LayoutTests/platform/qt/fast/table/table-row-before-after-content-around-block-expected.png
trunk/LayoutTests/platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt
trunk/LayoutTests/platform/qt/fast/table/table-row-before-after-content-around-table-expected.png
trunk/LayoutTests/platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (95519 => 95520)
--- trunk/LayoutTests/ChangeLog 2011-09-20 08:05:22 UTC (rev 95519)
+++ trunk/LayoutTests/ChangeLog 2011-09-20 08:36:05 UTC (rev 95520)
@@ -1,5 +1,22 @@
2011-09-20 Renata Hodovan r...@webkit.org
+[Qt] Add Qt specific expecteds to new tests introduced in r95461.
+
+Unreviewed gardening.
+
+* platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
+* platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
+* platform/qt/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
+* platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
+* platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
+* platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
+* platform/qt/fast/table/table-row-before-after-content-around-block-expected.png: Added.
+* platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt: Added.
+* platform/qt/fast/table/table-row-before-after-content-around-table-expected.png: Added.
+* platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt: Added.
+
+2011-09-20 Renata Hodovan r...@webkit.org
+
[Qt] Two tests fail after r95488 r95489
https://bugs.webkit.org/show_bug.cgi?id=68428
Added: trunk/LayoutTests/platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt (0 => 95520)
--- trunk/LayoutTests/platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt 2011-09-20 08:36:05 UTC (rev 95520)
@@ -0,0 +1,21 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x64
+ RenderBlock {HTML} at (0,0) size 800x64
+RenderBody {BODY} at (8,8) size 784x48 [color=#FF]
+ RenderBlock {DIV} at (0,0) size 784x48
+RenderTable at (0,0) size 64x16 [color=#00]
+ RenderTableSection (anonymous) at (0,0) size 64x16
+RenderTableRow (anonymous) at (0,0) size 64x16
+
[webkit-changes] [95529] trunk/LayoutTests
Title: [95529] trunk/LayoutTests Revision 95529 Author r...@webkit.org Date 2011-09-20 05:10:31 -0700 (Tue, 20 Sep 2011) Log Message [Qt] Rebase and unskip tests introduced in r95489 and r95488. Unreviewed gardening. * platform/qt/Skipped: * platform/qt/http/tests/security/document-all-expected.txt: Added. * platform/qt/http/tests/security/window-named-proto-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Added Paths trunk/LayoutTests/platform/qt/http/tests/security/document-all-expected.txt trunk/LayoutTests/platform/qt/http/tests/security/window-named-proto-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (95528 => 95529) --- trunk/LayoutTests/ChangeLog 2011-09-20 11:50:26 UTC (rev 95528) +++ trunk/LayoutTests/ChangeLog 2011-09-20 12:10:31 UTC (rev 95529) @@ -1,3 +1,13 @@ +2011-09-20 Renata Hodovan r...@webkit.org + +[Qt] Rebase and unskip tests introduced in r95489 and r95488. + +Unreviewed gardening. + +* platform/qt/Skipped: +* platform/qt/http/tests/security/document-all-expected.txt: Added. +* platform/qt/http/tests/security/window-named-proto-expected.txt: Added. + 2011-09-20 Philippe Normand pnorm...@igalia.com Unreviewed, skip failing fast/files/create-blob-url-crash.html on Modified: trunk/LayoutTests/platform/qt/Skipped (95528 => 95529) --- trunk/LayoutTests/platform/qt/Skipped 2011-09-20 11:50:26 UTC (rev 95528) +++ trunk/LayoutTests/platform/qt/Skipped 2011-09-20 12:10:31 UTC (rev 95529) @@ -2434,7 +2434,3 @@ # Fails on non-Chromium bots # https://bugs.webkit.org/show_bug.cgi?id=68278 http/tests/history/back-with-fragment-change.php - -# [Qt] Two tests fail after fail after r95488 r95489 -http/tests/security/document-all.html -http/tests/security/window-named-proto.html Added: trunk/LayoutTests/platform/qt/http/tests/security/document-all-expected.txt (0 => 95529) --- trunk/LayoutTests/platform/qt/http/tests/security/document-all-expected.txt (rev 0) +++ trunk/LayoutTests/platform/qt/http/tests/security/document-all-expected.txt 2011-09-20 12:10:31 UTC (rev 95529) @@ -0,0 +1,2 @@ +CONSOLE MESSAGE: line 1: TypeError: '[object DOMWindowConstructor]' is not a function (evaluating 'obj.alert.constructor(return document.body.innerHTML)') + Added: trunk/LayoutTests/platform/qt/http/tests/security/window-named-proto-expected.txt (0 => 95529) --- trunk/LayoutTests/platform/qt/http/tests/security/window-named-proto-expected.txt (rev 0) +++ trunk/LayoutTests/platform/qt/http/tests/security/window-named-proto-expected.txt 2011-09-20 12:10:31 UTC (rev 95529) @@ -0,0 +1,2 @@ +CONSOLE MESSAGE: line 1: TypeError: 'null' is not an object (evaluating 'document.body.innerHTML') + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95276] trunk/LayoutTests
Title: [95276] trunk/LayoutTests Revision 95276 Author r...@webkit.org Date 2011-09-16 01:16:30 -0700 (Fri, 16 Sep 2011) Log Message [Qt] Two tests fail after r95201 https://bugs.webkit.org/show_bug.cgi?id=68230 Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (95275 => 95276) --- trunk/LayoutTests/ChangeLog 2011-09-16 07:15:57 UTC (rev 95275) +++ trunk/LayoutTests/ChangeLog 2011-09-16 08:16:30 UTC (rev 95276) @@ -1,3 +1,12 @@ +2011-09-16 Renata Hodovan r...@webkit.org + +[Qt] Two tests fail after r95201 +https://bugs.webkit.org/show_bug.cgi?id=68230 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-09-16 Leo Yang leo.y...@torchmobile.com.cn [Qt] Crash when dragging google maps. Modified: trunk/LayoutTests/platform/qt/Skipped (95275 => 95276) --- trunk/LayoutTests/platform/qt/Skipped 2011-09-16 07:15:57 UTC (rev 95275) +++ trunk/LayoutTests/platform/qt/Skipped 2011-09-16 08:16:30 UTC (rev 95276) @@ -2424,3 +2424,8 @@ # new test introduced in r94828, but fails on Qt. # https://bugs.webkit.org/show_bug.cgi?id=66588 http/tests/security/xssAuditor/script-tag-with-16bit-unicode4.html + +# [Qt] Two tests fail after 95201 +# https://bugs.webkit.org/show_bug.cgi?id=68230 +fast/js/bitops-type-tag.html +fast/js/kde/operators.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95278] trunk/LayoutTests
Title: [95278] trunk/LayoutTests Revision 95278 Author r...@webkit.org Date 2011-09-16 01:26:15 -0700 (Fri, 16 Sep 2011) Log Message [Qt] One test failed after r95203 https://bugs.webkit.org/show_bug.cgi?id=68233 Unreviewed gardening. * platform/qt/Skipped: failed test is skipped. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (95277 => 95278) --- trunk/LayoutTests/ChangeLog 2011-09-16 08:21:47 UTC (rev 95277) +++ trunk/LayoutTests/ChangeLog 2011-09-16 08:26:15 UTC (rev 95278) @@ -1,5 +1,14 @@ 2011-09-16 Renata Hodovan r...@webkit.org +[Qt] One test failed after r95203 +https://bugs.webkit.org/show_bug.cgi?id=68233 + +Unreviewed gardening. + +* platform/qt/Skipped: failed test is skipped. + +2011-09-16 Renata Hodovan r...@webkit.org + [Qt] One test runs out of time after r95091 https://bugs.webkit.org/show_bug.cgi?id=68232 Modified: trunk/LayoutTests/platform/qt/Skipped (95277 => 95278) --- trunk/LayoutTests/platform/qt/Skipped 2011-09-16 08:21:47 UTC (rev 95277) +++ trunk/LayoutTests/platform/qt/Skipped 2011-09-16 08:26:15 UTC (rev 95278) @@ -2434,3 +2434,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=68232 inspector/timeline/timeline-enum-stability.html +# [Qt] One test failed after r95203 +# https://bugs.webkit.org/show_bug.cgi?id=68233 +editing/pasteboard/paste-noscript.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95279] trunk/LayoutTests
Title: [95279] trunk/LayoutTests Revision 95279 Author r...@webkit.org Date 2011-09-16 01:35:55 -0700 (Fri, 16 Sep 2011) Log Message [Qt] Update expecteds of failing tests after r95260 and r95242. Unreviewed gardening. * editing/style/non-inheritable-styles-expected.txt: after r95242. * fast/dom/constructed-objects-prototypes-expected.txt: after r95260. * inspector/styles/styles-new-API-expected.txt: after r95242. * inspector/styles/styles-source-lines-expected.txt: after r95242. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/style/non-inheritable-styles-expected.txt trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt trunk/LayoutTests/inspector/styles/styles-new-API-expected.txt trunk/LayoutTests/inspector/styles/styles-source-lines-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (95278 => 95279) --- trunk/LayoutTests/ChangeLog 2011-09-16 08:26:15 UTC (rev 95278) +++ trunk/LayoutTests/ChangeLog 2011-09-16 08:35:55 UTC (rev 95279) @@ -1,5 +1,16 @@ 2011-09-16 Renata Hodovan r...@webkit.org +[Qt] Update expecteds of failing tests after r95260 and r95242. + +Unreviewed gardening. + +* editing/style/non-inheritable-styles-expected.txt: after r95242. +* fast/dom/constructed-objects-prototypes-expected.txt: after r95260. +* inspector/styles/styles-new-API-expected.txt: after r95242. +* inspector/styles/styles-source-lines-expected.txt: after r95242. + +2011-09-16 Renata Hodovan r...@webkit.org + [Qt] One test failed after r95203 https://bugs.webkit.org/show_bug.cgi?id=68233 Modified: trunk/LayoutTests/editing/style/non-inheritable-styles-expected.txt (95278 => 95279) --- trunk/LayoutTests/editing/style/non-inheritable-styles-expected.txt 2011-09-16 08:26:15 UTC (rev 95278) +++ trunk/LayoutTests/editing/style/non-inheritable-styles-expected.txt 2011-09-16 08:35:55 UTC (rev 95279) @@ -3,6 +3,6 @@ | div | class=class | id=id -| style=border-top-width: 1px; border-right-width: 1px; border-bottom-width: 1px; border-left-width: 1px; border-top-style: solid; border-right-style: solid; border-bottom-style: solid; border-left-style: solid; border-top-color: blue; border-right-color: blue; border-bottom-color: blue; border-left-color: blue; +| style=border-top-width: 1px; border-right-width: 1px; border-bottom-width: 1px; border-left-width: 1px; border-top-style: solid; border-right-style: solid; border-bottom-style: solid; border-left-style: solid; border-top-color: blue; border-right-color: blue; border-bottom-color: blue; border-left-color: blue; border-image: initial; | This should have blue border when its pasted. | This shouldn't have a border.#selection-caret Modified: trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt (95278 => 95279) --- trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2011-09-16 08:26:15 UTC (rev 95278) +++ trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2011-09-16 08:35:55 UTC (rev 95279) @@ -23,6 +23,8 @@ PASS (new inner.Option()).constructor.isInner is true PASS (new inner.PageTransitionEvent()).isInner is true PASS (new inner.PageTransitionEvent()).constructor.isInner is true +PASS (new inner.PopStateEvent()).isInner is true +PASS (new inner.PopStateEvent()).constructor.isInner is true PASS (new inner.ProgressEvent()).isInner is true PASS (new inner.ProgressEvent()).constructor.isInner is true PASS (new inner.WebKitAnimationEvent()).isInner is true Modified: trunk/LayoutTests/inspector/styles/styles-new-API-expected.txt (95278 => 95279) --- trunk/LayoutTests/inspector/styles/styles-new-API-expected.txt 2011-09-16 08:26:15 UTC (rev 95278) +++ trunk/LayoutTests/inspector/styles/styles-new-API-expected.txt 2011-09-16 08:35:55 UTC (rev 95279) @@ -184,6 +184,7 @@ ['border-bottom-style':'solid'] @[undefined-undefined] style ['border-left-style':'solid'] @[undefined-undefined] style ['border-color':'initial'] @[undefined-undefined] style +['border-image':'initial'] @[undefined-undefined] style ['border-top-width':'0px'] @[undefined-undefined] style ['border-right-width':'0px'] @[undefined-undefined] style ['border-bottom-width':'0px'] @[undefined-undefined] style @@ -420,6 +421,7 @@ ['border-bottom-style':'solid'] @[undefined-undefined] style ['border-left-style':'solid'] @[undefined-undefined] style ['border-color':'initial'] @[undefined-undefined] style +['border-image':'initial'] @[undefined-undefined] style ['border-top-width':'1px'] @[undefined-undefined] style ['border-right-width':'1px'] @[undefined-undefined] style ['border-bottom-width':'1px'] @[undefined-undefined] style @@ -443,6 +445,7 @@ ['border-bottom-style':'solid'] @[undefined-undefined] style ['border-left-style':'solid'] @[undefined-undefined] style ['border-color':'initial'] @[undefined-undefined] style +['border-image':'initial'] @[undefined-undefined] style
[webkit-changes] [95022] trunk/LayoutTests
Title: [95022] trunk/LayoutTests Revision 95022 Author r...@webkit.org Date 2011-09-13 01:26:44 -0700 (Tue, 13 Sep 2011) Log Message eventSender.keyDown is unimplemented (WKTR) https://bugs.webkit.org/show_bug.cgi?id=57515 Unreviewed gardening. * platform/qt-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (95021 => 95022) --- trunk/LayoutTests/ChangeLog 2011-09-13 06:57:40 UTC (rev 95021) +++ trunk/LayoutTests/ChangeLog 2011-09-13 08:26:44 UTC (rev 95022) @@ -1,3 +1,12 @@ +2011-09-13 Renata Hodovan r...@webkit.org + +eventSender.keyDown is unimplemented (WKTR) +https://bugs.webkit.org/show_bug.cgi?id=57515 + +Unreviewed gardening. + +* platform/qt-wk2/Skipped: + 2011-09-12 Shinya Kawanaka shin...@google.com [chromium] fast/js/parseInt.html does not fail any more. Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (95021 => 95022) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-09-13 06:57:40 UTC (rev 95021) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-09-13 08:26:44 UTC (rev 95022) @@ -77,6 +77,8 @@ editing/selection/mixed-editability-1.html fast/block/float/float-in-float-hit-testing.html fast/events/updateLayoutForHitTest.html +fast/events/selectstart-by-arrow-keys-prevent-default.html +fast/events/selectstart-by-arrow-keys.html fast/files fast/forms/input-number-events.html fast/forms/input-spinbutton-capturing.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94551] trunk/LayoutTests
Title: [94551] trunk/LayoutTests Revision 94551 Author r...@webkit.org Date 2011-09-05 23:58:07 -0700 (Mon, 05 Sep 2011) Log Message [Qt] Update expecteds after r94545. Unreviewed gardening. * platform/qt/fast/dom/Window/window-properties-expected.png: * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-property-descriptors-expected.png: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: * platform/qt/fast/dom/prototype-inheritance-2-expected.txt: * platform/qt/fast/js/global-constructors-expected.png: * platform/qt/fast/js/global-constructors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.png trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.png trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94550 => 94551) --- trunk/LayoutTests/ChangeLog 2011-09-06 04:52:25 UTC (rev 94550) +++ trunk/LayoutTests/ChangeLog 2011-09-06 06:58:07 UTC (rev 94551) @@ -1,3 +1,17 @@ +2011-09-05 Renata Hodovan r...@webkit.org + +[Qt] Update expecteds after r94545. + +Unreviewed gardening. + +* platform/qt/fast/dom/Window/window-properties-expected.png: +* platform/qt/fast/dom/Window/window-properties-expected.txt: +* platform/qt/fast/dom/Window/window-property-descriptors-expected.png: +* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: +* platform/qt/fast/js/global-constructors-expected.png: +* platform/qt/fast/js/global-constructors-expected.txt: + 2011-09-05 Abhishek Arya infe...@chromium.org Unreviewed. GTK rebaselines for r94541, r94543. Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (94550 => 94551) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-09-06 04:52:25 UTC (rev 94550) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-09-06 06:58:07 UTC (rev 94551) @@ -1172,6 +1172,8 @@ window.HTMLSelectElement.prototype [printed above as window.Element.prototype] window.HTMLSourceElement [object HTMLSourceElementConstructor] window.HTMLSourceElement.prototype [printed above as window.Element.prototype] +window.HTMLSpanElement [object HTMLSpanElementConstructor] +window.HTMLSpanElement.prototype [printed above as window.Element.prototype] window.HTMLStyleElement [object HTMLStyleElementConstructor] window.HTMLStyleElement.prototype [printed above as window.Element.prototype] window.HTMLTableCaptionElement [object HTMLTableCaptionElementConstructor] Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt (94550 => 94551) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-09-06 04:52:25 UTC (rev 94550) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-09-06 06:58:07 UTC (rev 94551) @@ -118,6 +118,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLScriptElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLSelectElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLSourceElement') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLSpanElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLStyleElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLTableCaptionElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLTableCellElement') is 'object' Modified: trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt (94550 => 94551) --- trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt 2011-09-06 04:52:25 UTC (rev 94550) +++ trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt 2011-09-06 06:58:07 UTC (rev 94551) @@ -118,8 +118,6 @@ PASS HTMLDocument from inner.document.forms.testForm.0.ownerDocument PASS HTMLDocumentConstructor from inner.document.forms.testForm.0.ownerDocument.constructor PASS HTMLDocumentPrototype from inner.document.forms.testForm.0.ownerDocument.__proto__ -PASS HTMLElement
[webkit-changes] [94392] trunk/LayoutTests
Title: [94392] trunk/LayoutTests
Revision 94392
Author r...@webkit.org
Date 2011-09-02 01:25:12 -0700 (Fri, 02 Sep 2011)
Log Message
[Qt] Add Qt expecteds for new tests.
Unreviewed gardening.
* platform/qt/fast/borders/border-image-slices-expected.png: Added.
* platform/qt/fast/borders/border-image-slices-expected.txt: Added.
* platform/qt/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/qt/svg/custom/pattern-rotate-gaps-expected.png: Added.
* platform/qt/svg/custom/pattern-rotate-gaps-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.png
trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.txt
trunk/LayoutTests/platform/qt/fast/text/fallback-traits-fixup-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/pattern-rotate-gaps-expected.png
trunk/LayoutTests/platform/qt/svg/custom/pattern-rotate-gaps-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (94391 => 94392)
--- trunk/LayoutTests/ChangeLog 2011-09-02 07:58:05 UTC (rev 94391)
+++ trunk/LayoutTests/ChangeLog 2011-09-02 08:25:12 UTC (rev 94392)
@@ -1,3 +1,15 @@
+2011-09-02 Renata Hodovan r...@webkit.org
+
+[Qt] Add Qt expecteds for new tests.
+
+Unreviewed gardening.
+
+* platform/qt/fast/borders/border-image-slices-expected.png: Added.
+* platform/qt/fast/borders/border-image-slices-expected.txt: Added.
+* platform/qt/fast/text/fallback-traits-fixup-expected.txt: Added.
+* platform/qt/svg/custom/pattern-rotate-gaps-expected.png: Added.
+* platform/qt/svg/custom/pattern-rotate-gaps-expected.txt: Added.
+
2011-09-01 Takashi Toyoshima toyos...@chromium.org
[WebSocket] Implement WebSocket::close() code and reason handling.
Added: trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.txt (0 => 94392)
--- trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.txt 2011-09-02 08:25:12 UTC (rev 94392)
@@ -0,0 +1,17 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (10,10) size 126x126 [border: (21px none #00) (30px none #00) (21px none #00)]
+ RenderText {#text} at (146,130) size 4x22
+text run at (146,130) width 4:
+ RenderBlock {DIV} at (160,10) size 126x126 [border: (21px none #00) (30px none #00) (21px none #00)]
+ RenderText {#text} at (296,130) size 4x22
+text run at (296,130) width 4:
+ RenderBR {BR} at (0,0) size 0x0
+ RenderBlock {DIV} at (10,162) size 126x126 [border: (21px none #00) (30px none #00) (21px none #00)]
+ RenderText {#text} at (146,282) size 4x22
+text run at (146,282) width 4:
+ RenderBlock {DIV} at (160,162) size 126x126 [border: (21px none #00) (30px none #00) (21px none #00)]
+ RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/platform/qt/fast/text/fallback-traits-fixup-expected.txt (0 => 94392)
--- trunk/LayoutTests/platform/qt/fast/text/fallback-traits-fixup-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/fast/text/fallback-traits-fixup-expected.txt 2011-09-02 08:25:12 UTC (rev 94392)
@@ -0,0 +1,31 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x576
+ RenderBlock {P} at (0,0) size 784x22
+RenderText {#text} at (0,0) size 57x22
+ text run at (0,0) width 57: Test for
+RenderInline {I} at (0,0) size 519x22
+ RenderInline {A} at (0,0) size 154x22 [color=#EE]
+RenderText {#text} at (57,0) size 154x22
+ text run at (57,0) width 154: rdar://problem/9528843
+ RenderText {#text} at (211,0) size 365x22
+text run at (211,0) width 4:
+text run at (215,0) width 361: STIX glyphs not rendered on this stackoverflow answer
+RenderText {#text} at (576,0) size 4x22
+ text run at (576,0) width 4: .
+ RenderBlock {P} at (0,38) size 784x42
+RenderText {#text} at (0,15) size 102x22
+ text run at (0,15) width 102: A black circle:
+RenderInline {SPAN} at (0,0) size 8x42
+ RenderText {#text} at (102,0) size 8x42
+text run at (102,0) width 8: \x{26AB}
+
[webkit-changes] [94394] trunk/LayoutTests
Title: [94394] trunk/LayoutTests Revision 94394 Author r...@webkit.org Date 2011-09-02 01:49:24 -0700 (Fri, 02 Sep 2011) Log Message [Qt] Update Qt specific expected files after r94304. Unreviewed gardening. * platform/qt/fast/dom/Window/window-property-descriptors-expected.png: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: * platform/qt/fast/dom/prototype-inheritance-2-expected.png: * platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.png trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94393 => 94394) --- trunk/LayoutTests/ChangeLog 2011-09-02 08:26:19 UTC (rev 94393) +++ trunk/LayoutTests/ChangeLog 2011-09-02 08:49:24 UTC (rev 94394) @@ -1,5 +1,16 @@ 2011-09-02 Renata Hodovan r...@webkit.org +[Qt] Update Qt specific expected files after r94304. + +Unreviewed gardening. + +* platform/qt/fast/dom/Window/window-property-descriptors-expected.png: +* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/qt/fast/dom/prototype-inheritance-2-expected.png: +* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: + +2011-09-02 Renata Hodovan r...@webkit.org + [Qt] Add Qt expecteds for new tests. Unreviewed gardening. Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt (94393 => 94394) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-09-02 08:26:19 UTC (rev 94393) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-09-02 08:49:24 UTC (rev 94394) @@ -341,6 +341,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'defaultStatus') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'defaultstatus') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'description') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'descriptionQuiet') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'devicePixelRatio') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'document') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'encodeURI') is 'object' @@ -477,6 +478,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeNonZero') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeNull') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeTrue') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeTrueQuiet') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeUndefined') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldEvaluateTo') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldThrow') is 'object' Modified: trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt (94393 => 94394) --- trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt 2011-09-02 08:26:19 UTC (rev 94393) +++ trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt 2011-09-02 08:49:24 UTC (rev 94394) @@ -40,12 +40,12 @@ PASS CSSStyleSheet from inner.document.forms.testForm.0.ownerDocument.styleSheets.0 PASS CSSStyleSheetConstructor from inner.document.forms.testForm.0.ownerDocument.styleSheets.0.constructor PASS CSSStyleSheetPrototype from inner.document.forms.testForm.0.ownerDocument.styleSheets.0.__proto__ -PASS CSSValue from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(-webkit-line-box-contain) -PASS CSSValueConstructor from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(-webkit-line-box-contain).constructor +PASS CSSValue from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(border-image-slice) +PASS CSSValueConstructor from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(border-image-slice).constructor PASS CSSValueList from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(-webkit-transition-timing-function) PASS CSSValueListConstructor from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(background-position).constructor PASS CSSValueListPrototype from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(-webkit-transition-timing-function).__proto__ -PASS CSSValuePrototype
[webkit-changes] [94413] trunk/LayoutTests
Title: [94413] trunk/LayoutTests Revision 94413 Author r...@webkit.org Date 2011-09-02 06:09:02 -0700 (Fri, 02 Sep 2011) Log Message [Qt] Two tests are passing after r94324. They are unskipped: fast/events/document-elementFromPoint.html plugins/mouse-events-fixedpos.html Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (94412 => 94413) --- trunk/LayoutTests/ChangeLog 2011-09-02 12:46:47 UTC (rev 94412) +++ trunk/LayoutTests/ChangeLog 2011-09-02 13:09:02 UTC (rev 94413) @@ -1,3 +1,13 @@ +2011-09-02 Renata Hodovan r...@webkit.org + +[Qt] Two tests are passing after r94324. They are unskipped: +fast/events/document-elementFromPoint.html +plugins/mouse-events-fixedpos.html + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-09-02 Alexander Pavlov apav...@chromium.org [Chromium] Unreviewed, update test expectations. Modified: trunk/LayoutTests/platform/qt/Skipped (94412 => 94413) --- trunk/LayoutTests/platform/qt/Skipped 2011-09-02 12:46:47 UTC (rev 94412) +++ trunk/LayoutTests/platform/qt/Skipped 2011-09-02 13:09:02 UTC (rev 94413) @@ -2413,7 +2413,3 @@ fast/multicol/positive-leading.html fast/multicol/overflow-unsplittable.html fast/multicol/overflow-across-columns.html - -# [Qt] Incorrect absolute mouse pointer results after r94259 -fast/events/document-elementFromPoint.html -plugins/mouse-events-fixedpos.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94062] trunk/LayoutTests
Title: [94062] trunk/LayoutTests Revision 94062 Author r...@webkit.org Date 2011-08-30 02:36:11 -0700 (Tue, 30 Aug 2011) Log Message [Qt] Qt Linux Release bot has four failed tests. They are skipped. Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (94061 => 94062) --- trunk/LayoutTests/ChangeLog 2011-08-30 09:28:09 UTC (rev 94061) +++ trunk/LayoutTests/ChangeLog 2011-08-30 09:36:11 UTC (rev 94062) @@ -1,3 +1,12 @@ +2011-08-30 Renata Hodovan r...@webkit.org + +[Qt] Qt Linux Release bot has four failed tests. +They are skipped. + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-08-29 Yury Semikhatsky yu...@chromium.org Return value of window.onerror has inverted semantics Modified: trunk/LayoutTests/platform/qt/Skipped (94061 => 94062) --- trunk/LayoutTests/platform/qt/Skipped 2011-08-30 09:28:09 UTC (rev 94061) +++ trunk/LayoutTests/platform/qt/Skipped 2011-08-30 09:36:11 UTC (rev 94062) @@ -2394,3 +2394,16 @@ # https://bugs.webkit.org/show_bug.cgi?id=67125 fast/dom/constructed-objects-prototypes.html fast/dom/dom-constructors.html + +# [QT] One test failed after r93978 +# https://bugs.webkit.org/show_bug.cgi?id=67185 +inspector/styles/styles-computed-trace.html + +# [Qt] One test failed after r94009 +# https://bugs.webkit.org/show_bug.cgi?id=67186 +css2.1/t0602-c13-inheritance-00-e.html + +# [Qt] Two tests failed after r94037 +# https://bugs.webkit.org/show_bug.cgi?id=67188 +fast/multicol/initial-column-values.html +fast/multicol/inherit-column-values.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93033] trunk/LayoutTests
Title: [93033] trunk/LayoutTests Revision 93033 Author r...@webkit.org Date 2011-08-14 23:57:27 -0700 (Sun, 14 Aug 2011) Log Message [QT]REGRESSION after r93011 https://bugs.webkit.org/show_bug.cgi?id=66212 Unreviewed gardening. * platform/qt-4.8/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-4.8/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (93032 => 93033) --- trunk/LayoutTests/ChangeLog 2011-08-14 23:08:11 UTC (rev 93032) +++ trunk/LayoutTests/ChangeLog 2011-08-15 06:57:27 UTC (rev 93033) @@ -1,3 +1,12 @@ +2011-08-14 Renata Hodovan r...@webkit.org + + [QT]REGRESSION after r93011 + https://bugs.webkit.org/show_bug.cgi?id=66212 + +Unreviewed gardening. + +* platform/qt-4.8/Skipped: + 2011-08-13 Abhishek Arya infe...@chromium.org Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody. Modified: trunk/LayoutTests/platform/qt-4.8/Skipped (93032 => 93033) --- trunk/LayoutTests/platform/qt-4.8/Skipped 2011-08-14 23:08:11 UTC (rev 93032) +++ trunk/LayoutTests/platform/qt-4.8/Skipped 2011-08-15 06:57:27 UTC (rev 93033) @@ -7,3 +7,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=64527 svg/text/lengthAdjust-text-metrics.html http/tests/security/cross-frame-access-put.html + +# Regression after r93011 +fast/css/font-face-opentype.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93039] trunk/Source
Title: [93039] trunk/Source
Revision 93039
Author r...@webkit.org
Date 2011-08-15 04:59:22 -0700 (Mon, 15 Aug 2011)
Log Message
Patch by Oliver Varga varga.oli...@stud.u-szeged.hu on 2011-08-15
Reviewed by Nikolas Zimmermann.
Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025
Source/_javascript_Core:
Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.
* wtf/StdLibExtras.h:
(WTF::binarySearch):
Source/WebCore:
Replace the linear search to binary search on ordered list because
the previous searches from the beginning was not efficient.
Out of index error fixed by Renata Hodovan.
No new tests this is only a performance tweak.
* svg/animation/SVGSMILElement.cpp:
(WebCore::extractTimeFromVector):
(WebCore::SVGSMILElement::findInstanceTime):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/StdLibExtras.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (93038 => 93039)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-15 11:02:10 UTC (rev 93038)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-15 11:59:22 UTC (rev 93039)
@@ -1,3 +1,17 @@
+2011-08-15 Oliver Varga varga.oli...@stud.u-szeged.hu
+
+Reviewed by Nikolas Zimmermann.
+
+Speed up SVGSMILElement::findInstanceTime.
+https://bugs.webkit.org/show_bug.cgi?id=61025
+
+Add a new parameter to StdlibExtras.h::binarySerarch function
+to also handle cases when the array does not contain the key value.
+This is needed for an svg function.
+
+* wtf/StdLibExtras.h:
+(WTF::binarySearch):
+
2011-08-13 Sam Weinig s...@webkit.org
Add back 0xbbadbeef to CRASH to allow for old habits
Modified: trunk/Source/_javascript_Core/wtf/StdLibExtras.h (93038 => 93039)
--- trunk/Source/_javascript_Core/wtf/StdLibExtras.h 2011-08-15 11:02:10 UTC (rev 93038)
+++ trunk/Source/_javascript_Core/wtf/StdLibExtras.h 2011-08-15 11:59:22 UTC (rev 93039)
@@ -123,19 +123,23 @@
return (x + remainderMask) ~remainderMask;
}
+enum BinarySearchMode {
+KeyMustBePresentInArray,
+KeyMustNotBePresentInArray
+};
+
// Binary search algorithm, calls extractKey on pre-sorted elements in array,
// compares result with key (KeyTypes should be comparable with '--', '', '').
-// Optimized for cases where the array contains the key, checked by assertions.
templatetypename ArrayType, typename KeyType, KeyType(*extractKey)(ArrayType*)
-inline ArrayType* binarySearch(ArrayType* array, size_t size, KeyType key)
+inline ArrayType* binarySearch(ArrayType* array, size_t size, KeyType key, BinarySearchMode mode = KeyMustBePresentInArray)
{
-// The array must contain at least one element (pre-condition, array does conatin key).
-// If the array only contains one element, no need to do the comparison.
+// The array must contain at least one element (pre-condition, array does contain key).
+// If the array contains only one element, no need to do the comparison.
while (size 1) {
// Pick an element to check, half way through the array, and read the value.
int pos = (size - 1) 1;
KeyType val = extractKey(array[pos]);
-
+
// If the key matches, success!
if (val == key)
return array[pos];
@@ -149,13 +153,18 @@
array += (pos + 1);
}
-// 'size' should never reach zero.
-ASSERT(size);
+// In case of BinarySearchMode = KeyMustBePresentInArray 'size' should never reach zero.
+if (mode == KeyMustBePresentInArray)
+ASSERT(size);
}
-
-// If we reach this point we've chopped down to one element, no need to check it matches
-ASSERT(size == 1);
-ASSERT(key == extractKey(array[0]));
+
+// In case of BinarySearchMode = KeyMustBePresentInArray if we reach this point
+// we've chopped down to one element, no need to check it matches
+if (mode == KeyMustBePresentInArray) {
+ASSERT(size == 1);
+ASSERT(key == extractKey(array[0]));
+}
+
return array[0];
}
Modified: trunk/Source/WebCore/ChangeLog (93038 => 93039)
--- trunk/Source/WebCore/ChangeLog 2011-08-15 11:02:10 UTC (rev 93038)
+++ trunk/Source/WebCore/ChangeLog 2011-08-15 11:59:22 UTC (rev 93039)
@@ -1,3 +1,20 @@
+2011-08-15 Oliver Varga varga.oli...@stud.u-szeged.hu
+
+Reviewed by Nikolas Zimmermann.
+
+Speed up SVGSMILElement::findInstanceTime.
+https://bugs.webkit.org/show_bug.cgi?id=61025
+
+Replace the linear search to binary search on ordered list because
+the previous searches from the beginning was not efficient.
+Out of index error fixed by Renata Hodovan.
+
+No new tests this is only a
[webkit-changes] [92830] trunk/Source/WebCore
Title: [92830] trunk/Source/WebCore
Revision 92830
Author r...@webkit.org
Date 2011-08-11 01:45:46 -0700 (Thu, 11 Aug 2011)
Log Message
[Qt] Fix WebGL on Windows after r92805
https://bugs.webkit.org/show_bug.cgi?id=66042
WEBGL is temporarly disabled, because it broked the bots.
* features.pri:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.pri
Diff
Modified: trunk/Source/WebCore/ChangeLog (92829 => 92830)
--- trunk/Source/WebCore/ChangeLog 2011-08-11 08:18:27 UTC (rev 92829)
+++ trunk/Source/WebCore/ChangeLog 2011-08-11 08:45:46 UTC (rev 92830)
@@ -1,3 +1,12 @@
+2011-08-11 Renata Hodovan r...@webkit.org
+
+[Qt] Fix WebGL on Windows after r92805
+https://bugs.webkit.org/show_bug.cgi?id=66042
+
+WEBGL is temporarly disabled, because it broked the bots.
+
+* features.pri:
+
2011-08-11 Pavel Feldman pfeld...@google.com
Web Inspector: do not evaluate watch expressions on load.
Modified: trunk/Source/WebCore/features.pri (92829 => 92830)
--- trunk/Source/WebCore/features.pri 2011-08-11 08:18:27 UTC (rev 92829)
+++ trunk/Source/WebCore/features.pri 2011-08-11 08:45:46 UTC (rev 92830)
@@ -122,7 +122,7 @@
}
# WebGL support
-contains(QT_CONFIG, opengl) {
+contains(QT_CONFIG, opengl):!win32-* {
!contains(DEFINES, ENABLE_WEBGL=.): DEFINES += ENABLE_WEBGL=1
} else {
DEFINES += ENABLE_WEBGL=0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92836] trunk/Source/ThirdParty/ANGLE
Title: [92836] trunk/Source/ThirdParty/ANGLE
Revision 92836
Author r...@webkit.org
Date 2011-08-11 03:04:05 -0700 (Thu, 11 Aug 2011)
Log Message
[Qt]Fix warnings after r92805.
Reviewed by Csaba Osztrogonác.
Control reached the end non-void functions.
* src/compiler/ossource_posix.cpp:
(OS_AllocTLSIndex):
(OS_SetTLSValue):
Modified Paths
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (92835 => 92836)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2011-08-11 09:34:16 UTC (rev 92835)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2011-08-11 10:04:05 UTC (rev 92836)
@@ -1,5 +1,17 @@
2011-08-11 Renata Hodovan r...@webkit.org
+[Qt]Fix warnings after r92805.
+
+Reviewed by Csaba Osztrogonác.
+
+Control reached the end non-void functions.
+
+* src/compiler/ossource_posix.cpp:
+(OS_AllocTLSIndex):
+(OS_SetTLSValue):
+
+2011-08-11 Renata Hodovan r...@webkit.org
+
Build fix on Qt Windows 32-bit Release/Debug after r92805.
Unreviewed.
Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp (92835 => 92836)
--- trunk/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp 2011-08-11 09:34:16 UTC (rev 92835)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp 2011-08-11 10:04:05 UTC (rev 92836)
@@ -27,9 +27,7 @@
assert(0 OS_AllocTLSIndex(): Unable to allocate Thread Local Storage);
return false;
}
-else {
-return pPoolIndex;
-}
+return pPoolIndex;
}
@@ -42,8 +40,7 @@
if (pthread_setspecific(nIndex, lpvValue) == 0)
return true;
-else
-return false;
+return false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92666] trunk/LayoutTests
Title: [92666] trunk/LayoutTests Revision 92666 Author r...@webkit.org Date 2011-08-09 00:49:14 -0700 (Tue, 09 Aug 2011) Log Message [Qt]REGRESSION(r22030): It made one test failed. Unreviewed gardening. * platform/qt-4.8/Skipped: Skip the failed test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-4.8/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92665 => 92666) --- trunk/LayoutTests/ChangeLog 2011-08-09 07:14:24 UTC (rev 92665) +++ trunk/LayoutTests/ChangeLog 2011-08-09 07:49:14 UTC (rev 92666) @@ -1,3 +1,11 @@ +2011-08-09 Renata Hodovan r...@webkit.org + +[Qt]REGRESSION(r22030): It made one test failed. + +Unreviewed gardening. + +* platform/qt-4.8/Skipped: Skip the failed test. + 2011-08-08 Kent Tamura tk...@chromium.org [Chromium] Update baseline files for r92585. Modified: trunk/LayoutTests/platform/qt-4.8/Skipped (92665 => 92666) --- trunk/LayoutTests/platform/qt-4.8/Skipped 2011-08-09 07:14:24 UTC (rev 92665) +++ trunk/LayoutTests/platform/qt-4.8/Skipped 2011-08-09 07:49:14 UTC (rev 92666) @@ -7,3 +7,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=64527 svg/text/lengthAdjust-text-metrics.html http/tests/security/cross-frame-access-put.html + +# Regression after r22030 +http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92667] trunk/LayoutTests
Title: [92667] trunk/LayoutTests Revision 92667 Author r...@webkit.org Date 2011-08-09 01:27:45 -0700 (Tue, 09 Aug 2011) Log Message Accidentally added build number as revision number in r92666. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-4.8/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92666 => 92667) --- trunk/LayoutTests/ChangeLog 2011-08-09 07:49:14 UTC (rev 92666) +++ trunk/LayoutTests/ChangeLog 2011-08-09 08:27:45 UTC (rev 92667) @@ -1,6 +1,6 @@ 2011-08-09 Renata Hodovan r...@webkit.org -[Qt]REGRESSION(r22030): It made one test failed. +[Qt]REGRESSION(r92554): It made one test failed. Unreviewed gardening. Modified: trunk/LayoutTests/platform/qt-4.8/Skipped (92666 => 92667) --- trunk/LayoutTests/platform/qt-4.8/Skipped 2011-08-09 07:49:14 UTC (rev 92666) +++ trunk/LayoutTests/platform/qt-4.8/Skipped 2011-08-09 08:27:45 UTC (rev 92667) @@ -8,5 +8,5 @@ svg/text/lengthAdjust-text-metrics.html http/tests/security/cross-frame-access-put.html -# Regression after r22030 +# Regression after r92554 http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90811] trunk/Source
Title: [90811] trunk/Source
Revision 90811
Author r...@webkit.org
Date 2011-07-12 03:14:30 -0700 (Tue, 12 Jul 2011)
Log Message
Patch by Oliver Varga varga.oli...@stud.u-szeged.hu on 2011-07-12
Reviewed by Nikolas Zimmermann.
Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025
Source/_javascript_Core:
Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.
* wtf/StdLibExtras.h:
(WTF::binarySearch):
Source/WebCore:
Replace the linear search to binary search on ordered list because
the previous searches from the beginning was not efficient.
Out of index error fixed by Renata Hodovan.
No new tests this is only a performance tweak.
* svg/animation/SVGSMILElement.cpp:
(WebCore::extractTimeFromVector):
(WebCore::SVGSMILElement::findInstanceTime):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/StdLibExtras.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (90810 => 90811)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-12 08:08:28 UTC (rev 90810)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-12 10:14:30 UTC (rev 90811)
@@ -1,3 +1,17 @@
+2011-07-12 Oliver Varga varga.oli...@stud.u-szeged.hu
+
+Reviewed by Nikolas Zimmermann.
+
+Speed up SVGSMILElement::findInstanceTime.
+https://bugs.webkit.org/show_bug.cgi?id=61025
+
+Add a new parameter to StdlibExtras.h::binarySerarch function
+to also handle cases when the array does not contain the key value.
+This is needed for an svg function.
+
+* wtf/StdLibExtras.h:
+(WTF::binarySearch):
+
2011-07-11 Filip Pizlo fpi...@apple.com
DFG speculative JIT does not guard itself against floating point speculation
Modified: trunk/Source/_javascript_Core/wtf/StdLibExtras.h (90810 => 90811)
--- trunk/Source/_javascript_Core/wtf/StdLibExtras.h 2011-07-12 08:08:28 UTC (rev 90810)
+++ trunk/Source/_javascript_Core/wtf/StdLibExtras.h 2011-07-12 10:14:30 UTC (rev 90811)
@@ -123,19 +123,23 @@
return (x + remainderMask) ~remainderMask;
}
+enum BinarySearchMode {
+KeyMustBePresentInArray,
+KeyMustNotBePresentInArray
+};
+
// Binary search algorithm, calls extractKey on pre-sorted elements in array,
// compares result with key (KeyTypes should be comparable with '--', '', '').
-// Optimized for cases where the array contains the key, checked by assertions.
templatetypename ArrayType, typename KeyType, KeyType(*extractKey)(ArrayType*)
-inline ArrayType* binarySearch(ArrayType* array, size_t size, KeyType key)
+inline ArrayType* binarySearch(ArrayType* array, size_t size, KeyType key, BinarySearchMode mode = KeyMustBePresentInArray)
{
-// The array must contain at least one element (pre-condition, array does conatin key).
-// If the array only contains one element, no need to do the comparison.
+// The array must contain at least one element (pre-condition, array does contain key).
+// If the array contains only one element, no need to do the comparison.
while (size 1) {
// Pick an element to check, half way through the array, and read the value.
int pos = (size - 1) 1;
KeyType val = extractKey(array[pos]);
-
+
// If the key matches, success!
if (val == key)
return array[pos];
@@ -149,13 +153,18 @@
array += (pos + 1);
}
-// 'size' should never reach zero.
-ASSERT(size);
+// In case of BinarySearchMode = KeyMustBePresentInArray 'size' should never reach zero.
+if (mode == KeyMustBePresentInArray)
+ASSERT(size);
}
-
-// If we reach this point we've chopped down to one element, no need to check it matches
-ASSERT(size == 1);
-ASSERT(key == extractKey(array[0]));
+
+// In case of BinarySearchMode = KeyMustBePresentInArray if we reach this point
+// we've chopped down to one element, no need to check it matches
+if (mode == KeyMustBePresentInArray) {
+ASSERT(size == 1);
+ASSERT(key == extractKey(array[0]));
+}
+
return array[0];
}
Modified: trunk/Source/WebCore/ChangeLog (90810 => 90811)
--- trunk/Source/WebCore/ChangeLog 2011-07-12 08:08:28 UTC (rev 90810)
+++ trunk/Source/WebCore/ChangeLog 2011-07-12 10:14:30 UTC (rev 90811)
@@ -1,3 +1,20 @@
+2011-07-12 Oliver Varga varga.oli...@stud.u-szeged.hu
+
+Reviewed by Nikolas Zimmermann.
+
+Speed up SVGSMILElement::findInstanceTime.
+https://bugs.webkit.org/show_bug.cgi?id=61025
+
+Replace the linear search to binary search on ordered list because
+the previous searches from the beginning was not efficient.
+Out of index error fixed by Renata Hodovan.
+
+No new
