from:"slewis"

[webkit-changes] [293934] trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/ osx_chrome_driver.py

2022-05-06 Thread slewis

Title: [293934] trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py








Revision 293934
Author sle...@apple.com
Date 2022-05-06 17:10:13 -0700 (Fri, 06 May 2022)


Log Message
Enable field trial configs when testing Chrome Betas
https://bugs.webkit.org/show_bug.cgi?id=240187

Reviewed by Saam Barati.

* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
(OSXChromeDriverBase):
(OSXChromeDriverBase.launch_args_with_url):
(OSXChromeDriverBase.launch_url):
(OSXChromeCanaryDriver.launch_args_with_url):
(OSXChromeBetaDriver.launch_args_with_url):
(OSXChromeDevDriver._set_chrome_binary_location):
(OSXChromeDevDriver):
(OSXChromeDevDriver.launch_args_with_url):

Canonical link: https://commits.webkit.org/250380@main

Modified Paths

trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py




Diff

Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py (293933 => 293934)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py	2022-05-07 00:08:15 UTC (rev 293933)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py	2022-05-07 00:10:13 UTC (rev 293934)
@@ -10,12 +10,14 @@
 class OSXChromeDriverBase(OSXBrowserDriver):
 app_name = None
 
-def launch_url(self, url, options, browser_build_path, browser_path):
-# FIXME: handle self._browser_path.
-args_with_url = ['--args', '--homepage', url, self._window_size_arg(), '--no-first-run',
+# FIXME: handle self._browser_path.
+def launch_args_with_url(self, url):
+return ['--args', '--homepage', url, self._window_size_arg(), '--no-first-run',
  '--no-default-browser-check', '--disable-extensions']
-self._launch_process(build_dir=browser_build_path, app_name=self.app_name, url="" args=args_with_url)
 
+def launch_url(self, url, options, browser_build_path, browser_path):
+self._launch_process(build_dir=browser_build_path, app_name=self.app_name, url="" args=self.launch_args_with_url(url))
+
 def launch_driver(self, url, options, browser_build_path):
 from selenium import webdriver
 chrome_options = self._create_chrome_options(browser_build_path)
@@ -68,7 +70,10 @@
 def _set_chrome_binary_location(self, options, browser_build_path):
 set_binary_location_impl(options, browser_build_path, self.app_name, self.process_name)
 
+def launch_args_with_url(self, url):
+return super(OSXChromeCanaryDriver, self).launch_args_with_url(url) + ['--enable-field-trial-config']
 
+
 class OSXChromeBetaDriver(OSXChromeDriverBase):
 process_name = 'Google Chrome Beta'
 browser_name = 'chrome-beta'
@@ -78,6 +83,9 @@
 def _set_chrome_binary_location(self, options, browser_build_path):
 set_binary_location_impl(options, browser_build_path, self.app_name, self.process_name)
 
+def launch_args_with_url(self, url):
+return super(OSXChromeBetaDriver, self).launch_args_with_url(url) + ['--enable-field-trial-config']
+
 class OSXChromeDevDriver(OSXChromeDriverBase):
 process_name = 'Google Chrome Dev'
 browser_name = 'chrome-dev'
@@ -86,3 +94,6 @@
 
 def _set_chrome_binary_location(self, options, browser_build_path):
 set_binary_location_impl(options, browser_build_path, self.app_name, self.process_name)
+
+def launch_args_with_url(self, url):
+return super(OSXChromeDevDriver, self).launch_args_with_url(url) + ['--enable-field-trial-config']






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292196] trunk/Tools

2022-03-31 Thread slewis

Title: [292196] trunk/Tools








Revision 292196
Author sle...@apple.com
Date 2022-03-31 19:16:47 -0700 (Thu, 31 Mar 2022)


Log Message
Update Speedometer plan files.
https://bugs.webkit.org/show_bug.cgi?id=238645

Reviewed by Saam Barati.

* Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
* Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan




Diff

Modified: trunk/Tools/ChangeLog (292195 => 292196)

--- trunk/Tools/ChangeLog	2022-04-01 02:13:46 UTC (rev 292195)
+++ trunk/Tools/ChangeLog	2022-04-01 02:16:47 UTC (rev 292196)
@@ -1,3 +1,13 @@
+2022-03-31  Stephanie Lewis  
+
+Update Speedometer plan files.
+https://bugs.webkit.org/show_bug.cgi?id=238645
+
+Reviewed by Saam Barati.
+
+* Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
+* Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan:
+
 2022-03-31  Commit Queue  
 
 Unreviewed, reverting r292183.


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan (292195 => 292196)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan	2022-04-01 02:13:46 UTC (rev 292195)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan	2022-04-01 02:16:47 UTC (rev 292196)
@@ -1 +1 @@
-link speedometer2.1.plan
\ No newline at end of file
+link speedometer2.0.plan
\ No newline at end of file


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan (292195 => 292196)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan	2022-04-01 02:13:46 UTC (rev 292195)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan	2022-04-01 02:16:47 UTC (rev 292196)
@@ -1 +1 @@
-link speedometer2.1.plan
\ No newline at end of file
+link speedometer2.0.plan
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291254] trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans

2022-03-14 Thread slewis

Title: [291254] trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans








Revision 291254
Author sle...@apple.com
Date 2022-03-14 15:13:08 -0700 (Mon, 14 Mar 2022)


Log Message
Update Speedometer plan files.
rdar://89648567 (Use Speedometer 2.1 on perf bots)

Reviewed by NOBODY (OOPS!).

Create speedometer plan files for each version of speedometer.
Symlink shortcuts speedometer and speedometer2 to point at speedometer2.1

* Scripts/webkitpy/benchmark_runner/data/plans/speedometer1.0.plan: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan.
* Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.0.plan: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan.
* Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.1.plan: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan.

T	Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: T	Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan

Added Paths

trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer1.0.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.0.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.1.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan


Removed Paths

trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan




Diff

Deleted: trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan (291253 => 291254)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan	2022-03-14 22:02:04 UTC (rev 291253)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan	2022-03-14 22:13:08 UTC (rev 291254)
@@ -1,9 +0,0 @@
-{
-"timeout": 300,
-"count": 5,
-"svn_source": "https://svn.webkit.org/repository/webkit/trunk/PerformanceTests/Speedometer/@r183695",
-"webserver_benchmark_patch": "data/patches/webserver/Speedometer.patch",
-"webdriver_benchmark_patch": "data/patches/webdriver/Speedometer.patch",
-"entry_point": "Full.html",
-"output_file": "speedometer.result"
-}


Added: trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan (0 => 291254)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan	2022-03-14 22:13:08 UTC (rev 291254)
@@ -0,0 +1 @@
+link speedometer2.1.plan
\ No newline at end of file
Property changes on: trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan
___


Added: svn:special
+*
\ No newline at end of property

Copied: trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer1.0.plan (from rev 291236, trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan) (0 => 291254)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer1.0.plan	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer1.0.plan	2022-03-14 22:13:08 UTC (rev 291254)
@@ -0,0 +1,9 @@
+{
+"timeout": 300,
+"count": 5,
+"svn_source": "https://svn.webkit.org/repository/webkit/trunk/PerformanceTests/Speedometer/@r183695",
+"webserver_benchmark_patch": "data/patches/webserver/Speedometer.patch",
+"webdriver_benchmark_patch": "data/patches/webdriver/Speedometer.patch",
+"entry_point": "Full.html",
+"output_file": "speedometer.result"
+}


Copied: trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.0.plan (from rev 291236, trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan) (0 => 291254)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.0.plan	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.0.plan	2022-03-14 22:13:08 UTC (rev 291254)
@@ -0,0 +1,8 @@
+{
+"timeout": 600,
+"count": 4,
+"svn_source": "https://svn.webkit.org/repository/webkit/trunk/PerformanceTests/Speedometer/@r226694",
+"webserver_benchmark_patch": "data/patches/webserver/Speedometer2.patch",
+"entry_point": "index.html",
+"output_file": "speedometer2.result"
+}


Copied: trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.1.plan (from rev 291236, trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan) (0 => 291254)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.1.plan	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.1.plan	2022-03-14 22:13:08 UTC (rev 291254)
@@ -0,0 +1,8 @@
+{
+"timeout": 600,
+"count": 4,
+"s

[webkit-changes] [284041] trunk/metadata/contributors.json

2021-10-12 Thread slewis

Title: [284041] trunk/metadata/contributors.json








Revision 284041
Author sle...@apple.com
Date 2021-10-12 15:10:10 -0700 (Tue, 12 Oct 2021)


Log Message
Add my github account and personal email

Unreviewed.

* metadata/contributors.json:

Modified Paths

trunk/metadata/contributors.json




Diff

Modified: trunk/metadata/contributors.json (284040 => 284041)

--- trunk/metadata/contributors.json	2021-10-12 22:09:20 UTC (rev 284040)
+++ trunk/metadata/contributors.json	2021-10-12 22:10:10 UTC (rev 284041)
@@ -5947,9 +5947,11 @@
},
{
   "emails" : [
- "sle...@apple.com"
+ "sle...@apple.com",
+ "stephaniele...@gmail.com"
   ],
   "expertise" : "Performance Testing, Tools",
+  "github" : "sundiamonde",
   "name" : "Stephanie Lewis",
   "nicks" : [
  "sundiamonde"
@@ -6956,4 +6958,4 @@
   ],
   "status" : "reviewer"
}
-]
\ No newline at end of file
+]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [272565] trunk/Tools

2021-02-08 Thread slewis

Title: [272565] trunk/Tools








Revision 272565
Author sle...@apple.com
Date 2021-02-08 18:47:27 -0800 (Mon, 08 Feb 2021)


Log Message
 Motionmark failed to start webserver

Reviewed by Dewei Zhu.

* Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
(BenchmarkBuilder.__enter__):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py




Diff

Modified: trunk/Tools/ChangeLog (272564 => 272565)

--- trunk/Tools/ChangeLog	2021-02-09 02:17:03 UTC (rev 272564)
+++ trunk/Tools/ChangeLog	2021-02-09 02:47:27 UTC (rev 272565)
@@ -1,3 +1,12 @@
+2021-02-08  Stephanie Lewis  
+
+ Motionmark failed to start webserver
+
+Reviewed by Dewei Zhu.
+
+* Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
+(BenchmarkBuilder.__enter__):
+
 2021-02-08  Commit Queue  
 
 Unreviewed, reverting r272485.


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py (272564 => 272565)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py	2021-02-09 02:17:03 UTC (rev 272564)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py	2021-02-09 02:47:27 UTC (rev 272565)
@@ -27,7 +27,7 @@
 self._driver = driver
 
 def __enter__(self):
-self._web_root = tempfile.mkdtemp()
+self._web_root = tempfile.mkdtemp(dir="/tmp")
 self._dest = os.path.join(self._web_root, self._name)
 if 'local_copy' in self._plan:
 self._copy_benchmark_to_temp_dir(self._plan['local_copy'])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [245717] trunk/Source

2019-05-23 Thread slewis

Title: [245717] trunk/Source








Revision 245717
Author sle...@apple.com
Date 2019-05-23 14:19:49 -0700 (Thu, 23 May 2019)


Log Message
release builds of webkit cannot be used to generate a dyld shared cache
https://bugs.webkit.org/show_bug.cgi?id=198150


Reviewed by Dan Bernstein.

Restrict the -not_for_dyld_shared_cache linker flag to macosx

Source/WebCore:

* Configurations/WebCore.xcconfig:

Source/WebKit:

* Configurations/WebKit.xcconfig:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/WebKit.xcconfig




Diff

Modified: trunk/Source/WebCore/ChangeLog (245716 => 245717)

--- trunk/Source/WebCore/ChangeLog	2019-05-23 21:17:57 UTC (rev 245716)
+++ trunk/Source/WebCore/ChangeLog	2019-05-23 21:19:49 UTC (rev 245717)
@@ -1,3 +1,15 @@
+2019-05-22  Stephanie Lewis  
+
+release builds of webkit cannot be used to generate a dyld shared cache
+https://bugs.webkit.org/show_bug.cgi?id=198150
+
+
+Reviewed by Dan Bernstein.
+
+Restrict the -not_for_dyld_shared_cache linker flag to macosx
+
+* Configurations/WebCore.xcconfig:
+
 2019-05-23  Zalan Bujtas  
 
 [Hittest] Move hittesting from RenderView to Document


Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (245716 => 245717)

--- trunk/Source/WebCore/Configurations/WebCore.xcconfig	2019-05-23 21:17:57 UTC (rev 245716)
+++ trunk/Source/WebCore/Configurations/WebCore.xcconfig	2019-05-23 21:19:49 UTC (rev 245717)
@@ -175,8 +175,8 @@
 WK_INSTALL_PATH_PREFIX = $(WK_INSTALL_PATH_PREFIX_DEPLOYMENT_$(DEPLOYMENT_LOCATION)$(WK_MACOS_1015)_USE_STAGING_INSTALL_PATH_$(USE_STAGING_INSTALL_PATH));
 WK_INSTALL_PATH_PREFIX_DEPLOYMENT_YES_MACOS_SINCE_1015_USE_STAGING_INSTALL_PATH_YES = $(PLATFORM_OOB_SYSTEM_CONTENT_DIR);
 
-WK_RELOCATABLE_FRAMEWORK_LDFLAGS = $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS_$(WK_RELOCATABLE_FRAMEWORKS));
-WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES = -Wl,-not_for_dyld_shared_cache;
+WK_RELOCATABLE_FRAMEWORK_LDFLAGS = $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS_$(WK_RELOCATABLE_FRAMEWORKS)_$(WK_PLATFORM_NAME));
+WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES_macosx = -Wl,-not_for_dyld_shared_cache;
 
 // Enable InstallAPI support, when built with WEBCORE_ENABLE_INSTALLAPI=YES.
 SUPPORTS_TEXT_BASED_API = $(SUPPORTS_TEXT_BASED_API_$(TARGET_NAME))


Modified: trunk/Source/WebKit/ChangeLog (245716 => 245717)

--- trunk/Source/WebKit/ChangeLog	2019-05-23 21:17:57 UTC (rev 245716)
+++ trunk/Source/WebKit/ChangeLog	2019-05-23 21:19:49 UTC (rev 245717)
@@ -1,3 +1,16 @@
+2019-05-22  Stephanie Lewis  
+
+release builds of webkit cannot be used to generate a dyld shared cache
+https://bugs.webkit.org/show_bug.cgi?id=198150
+
+
+Reviewed by Dan Bernstein.
+
+Restrict the -not_for_dyld_shared_cache linker flag to macosx
+
+* Configurations/WebKit.xcconfig:
+
+
 2019-05-23  Zalan Bujtas  
 
 [Hittest] Move hittesting from RenderView to Document


Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (245716 => 245717)

--- trunk/Source/WebKit/Configurations/WebKit.xcconfig	2019-05-23 21:17:57 UTC (rev 245716)
+++ trunk/Source/WebKit/Configurations/WebKit.xcconfig	2019-05-23 21:19:49 UTC (rev 245717)
@@ -162,8 +162,8 @@
 WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=iphone*11.*] = YES;
 WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=iphone*12.*] = YES;
 
-WK_RELOCATABLE_FRAMEWORK_LDFLAGS = $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS_$(WK_RELOCATABLE_FRAMEWORKS));
-WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES = -Wl,-not_for_dyld_shared_cache;
+WK_RELOCATABLE_FRAMEWORK_LDFLAGS = $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS_$(WK_RELOCATABLE_FRAMEWORKS)_$(WK_PLATFORM_NAME));
+WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES_macosx = -Wl,-not_for_dyld_shared_cache;
 
 WK_HAVE_DEVICE_IDENTITY = $(WK_HAVE_DEVICE_IDENTITY_$(PLATFORM_NAME));
 WK_HAVE_DEVICE_IDENTITY_iphoneos = YES;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [244730] trunk/Tools

2019-04-29 Thread slewis

Title: [244730] trunk/Tools








Revision 244730
Author sle...@apple.com
Date 2019-04-29 02:14:43 -0700 (Mon, 29 Apr 2019)


Log Message
run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
https://bugs.webkit.org/show_bug.cgi?id=197339

Reviewed by Dewei Zhu.

Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
test run for setup steps that are too expensive to do every iteration.

* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner._run_benchmark):
* Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver):
(BrowserDriver.prepare_initial_env):
(BrowserDriver.restore_env_after_all_testing):
* Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
(LinuxBrowserDriver.prepare_initial_env):
(LinuxBrowserDriver.restore_env_after_all_testing):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver.prepare_initial_env):
(OSXBrowserDriver.restore_env_after_all_testing):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py




Diff

Modified: trunk/Tools/ChangeLog (244729 => 244730)

--- trunk/Tools/ChangeLog	2019-04-29 08:36:32 UTC (rev 244729)
+++ trunk/Tools/ChangeLog	2019-04-29 09:14:43 UTC (rev 244730)
@@ -1,3 +1,26 @@
+2019-04-26  Stephanie Lewis  
+
+run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
+https://bugs.webkit.org/show_bug.cgi?id=197339
+
+Reviewed by Dewei Zhu.
+
+Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
+test run for setup steps that are too expensive to do every iteration.
+
+* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
+(BenchmarkRunner._run_benchmark):
+* Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
+(BrowserDriver):
+(BrowserDriver.prepare_initial_env):
+(BrowserDriver.restore_env_after_all_testing):
+* Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
+(LinuxBrowserDriver.prepare_initial_env):
+(LinuxBrowserDriver.restore_env_after_all_testing):
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
+(OSXBrowserDriver.prepare_initial_env):
+(OSXBrowserDriver.restore_env_after_all_testing):
+
 2019-04-28  Andy Estes  
 
 Fix the watchOS engineering build.


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py (244729 => 244730)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py	2019-04-29 08:36:32 UTC (rev 244729)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py	2019-04-29 09:14:43 UTC (rev 244730)
@@ -77,32 +77,36 @@
 def _run_benchmark(self, count, web_root):
 results = []
 debug_outputs = []
-for iteration in xrange(1, count + 1):
-_log.info('Start the iteration {current_iteration} of {iterations} for current benchmark'.format(current_iteration=iteration, iterations=count))
-try:
-self._browser_driver.prepare_env(self._config)
+try:
+self._browser_driver.prepare_initial_env(self._config)
+for iteration in xrange(1, count + 1):
+_log.info('Start the iteration {current_iteration} of {iterations} for current benchmark'.format(current_iteration=iteration, iterations=count))
+try:
+self._browser_driver.prepare_env(self._config)
 
-if 'entry_point' in self._plan:
-result = self._run_one_test(web_root, self._plan['entry_point'])
-debug_outputs.append(result.pop('debugOutput', None))
-assert(result)
-results.append(result)
-elif 'test_files' in self._plan:
-run_result = {}
-for test in self._plan['test_files']:
-result = self._run_one_test(web_root, test)
+if 'entry_point' in self._plan:
+result = self._run_one_test(web_root, self._plan['entry_point'])
+debug_outputs.append(result.pop('debugOutput', None))
 assert(result)
-run_result = self._merge(run_result, result)
-debug_outputs.append(result.pop('debugOutput', None))
+results.append(result)
+elif 'test_files' in self._plan:
+

[webkit-changes] [242653] trunk/Tools

2019-03-08 Thread slewis

Title: [242653] trunk/Tools








Revision 242653
Author sle...@apple.com
Date 2019-03-08 12:52:56 -0800 (Fri, 08 Mar 2019)


Log Message
Ensure old tab state is cleared between iterations of run-benchmark
https://bugs.webkit.org/show_bug.cgi?id=195393


Reviewed by Dewei Zhu.

a) ensure the default to restore state is not set
b) terminate Safari correctly
c) Set the system default to ignore Persistent State in Safari

* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver): fix terminate processes to call terminate before killing.
(OSXBrowserDriver.prepare_env):
(OSXBrowserDriver.restore_env):
(OSXBrowserDriver.close_browsers):
(OSXBrowserDriver._terminate_processes):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
(OSXChromeDriver):
(OSXChromeCanaryDriver):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
(OSXFirefoxDriver):
(OSXFirefoxNightlyDriver):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
(OSXSafariDriver):
(OSXSafariDriver.prepare_env):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py




Diff

Modified: trunk/Tools/ChangeLog (242652 => 242653)

--- trunk/Tools/ChangeLog	2019-03-08 19:54:02 UTC (rev 242652)
+++ trunk/Tools/ChangeLog	2019-03-08 20:52:56 UTC (rev 242653)
@@ -1,3 +1,31 @@
+2019-03-08  Stephanie Lewis  
+
+Ensure old tab state is cleared between iterations of run-benchmark
+https://bugs.webkit.org/show_bug.cgi?id=195393
+
+
+Reviewed by Dewei Zhu.
+
+a) ensure the default to restore state is not set
+b) terminate Safari correctly
+c) Set the system default to ignore Persistent State in Safari
+
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
+(OSXBrowserDriver): fix terminate processes to call terminate before killing.
+(OSXBrowserDriver.prepare_env): 
+(OSXBrowserDriver.restore_env):
+(OSXBrowserDriver.close_browsers):
+(OSXBrowserDriver._terminate_processes):
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
+(OSXChromeDriver):
+(OSXChromeCanaryDriver):
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
+(OSXFirefoxDriver):
+(OSXFirefoxNightlyDriver):
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
+(OSXSafariDriver):
+(OSXSafariDriver.prepare_env):
+
 2019-03-08  Diego Pino Garcia  
 
 [GTK] Several InputMethodFilter tests are failing


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py (242652 => 242653)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py	2019-03-08 19:54:02 UTC (rev 242652)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py	2019-03-08 20:52:56 UTC (rev 242653)
@@ -2,6 +2,7 @@
 import logging
 import os
 import subprocess
+import time
 
 from browser_driver import BrowserDriver
 from webkitpy.benchmark_runner.utils import write_defaults
@@ -13,6 +14,7 @@
 class OSXBrowserDriver(BrowserDriver):
 process_name = None
 platform = 'osx'
+bundle_id = None
 
 def prepare_env(self, config):
 self.close_browsers()
@@ -20,15 +22,15 @@
 CGWarpMouseCursorPosition((10, 0))
 self.updated_dock_animation_defaults = write_defaults('com.apple.dock', 'launchanim', False)
 if self.updated_dock_animation_defaults:
-self._terminate_processes('Dock')
+self._terminate_processes('Dock', 'com.apple.dock')
 
 def restore_env(self):
 if self.updated_dock_animation_defaults:
 write_defaults('com.apple.dock', 'launchanim', True)
-self._terminate_processes('Dock')
+self._terminate_processes('Dock', 'com.apple.dock')
 
 def close_browsers(self):
-self._terminate_processes(self.process_name)
+self._terminate_processes(self.process_name, self.bundle_id)
 
 @classmethod
 def _launch_process(cls, build_dir, app_name, url, args):
@@ -52,9 +54,16 @@
 driver.get(url)
 
 @classmethod
-def _terminate_processes(cls, process_name):
+def _terminate_processes(cls, process_name, bundle_id):
+from AppKit import NSRunningApplication
 _log.info('Closing all processes with name %s' % process_name)
-subprocess.call(['/usr/bin/killall', process_name])
+for app in N

[webkit-changes] [185983] trunk/Source/WebCore

2015-06-25 Thread slewis

Title: [185983] trunk/Source/WebCore








Revision 185983
Author sle...@apple.com
Date 2015-06-25 22:30:37 -0700 (Thu, 25 Jun 2015)


Log Message
Build fix.

Unreviewed.

* platform/audio/DirectConvolver.cpp:
(WebCore::DirectConvolver::process):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/DirectConvolver.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (185982 => 185983)

--- trunk/Source/WebCore/ChangeLog	2015-06-26 03:55:42 UTC (rev 185982)
+++ trunk/Source/WebCore/ChangeLog	2015-06-26 05:30:37 UTC (rev 185983)
@@ -1,3 +1,12 @@
+2015-06-25  Stephanie Lewis  
+
+Build fix.
+
+Unreviewed.
+
+* platform/audio/DirectConvolver.cpp:
+(WebCore::DirectConvolver::process):
+
 2015-06-25  Chris Fleizach  
 
 AX: improve list heuristics (presentational use versus actual lists)


Modified: trunk/Source/WebCore/platform/audio/DirectConvolver.cpp (185982 => 185983)

--- trunk/Source/WebCore/platform/audio/DirectConvolver.cpp	2015-06-26 03:55:42 UTC (rev 185982)
+++ trunk/Source/WebCore/platform/audio/DirectConvolver.cpp	2015-06-26 05:30:37 UTC (rev 185983)
@@ -75,7 +75,10 @@
 
 #if OS(DARWIN)
 #if defined(__ppc__) || defined(__i386__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 conv(inputP - kernelSize + 1, 1, kernelP + kernelSize - 1, -1, destP, 1, framesToProcess, kernelSize);
+#pragma clang diagnostic pop
 #else
 vDSP_conv(inputP - kernelSize + 1, 1, kernelP + kernelSize - 1, -1, destP, 1, framesToProcess, kernelSize);
 #endif // defined(__ppc__) || defined(__i386__)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185242] trunk/Tools

2015-06-05 Thread slewis

Title: [185242] trunk/Tools








Revision 185242
Author sle...@apple.com
Date 2015-06-05 02:11:18 -0700 (Fri, 05 Jun 2015)


Log Message
Streamline run-benchmark browser

Reviewed by Ryosuke Niwa.

Add Caffeinate so computer won't sleep while running.
Remove calls to collect output since we were just dumping to stdout anyway.
Add xpc dyld_path.
Default to system safari.

* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver.launchProcess):
(OSXBrowserDriver.terminateProcesses):
(OSXBrowserDriver):
(OSXBrowserDriver.launchCaffeinateForProcess):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.launchUrl):
(OSXSafariDriver.closeBrowsers):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py




Diff

Modified: trunk/Tools/ChangeLog (185241 => 185242)

--- trunk/Tools/ChangeLog	2015-06-05 06:44:55 UTC (rev 185241)
+++ trunk/Tools/ChangeLog	2015-06-05 09:11:18 UTC (rev 185242)
@@ -1,3 +1,23 @@
+2015-06-05  Stephanie Lewis  
+
+Streamline run-benchmark browser
+
+Reviewed by Ryosuke Niwa.
+
+Add Caffeinate so computer won't sleep while running.
+Remove calls to collect output since we were just dumping to stdout anyway.
+Add xpc dyld_path.
+Default to system safari.
+
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
+(OSXBrowserDriver.launchProcess):
+(OSXBrowserDriver.terminateProcesses):
+(OSXBrowserDriver):
+(OSXBrowserDriver.launchCaffeinateForProcess):
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
+(OSXSafariDriver.launchUrl):
+(OSXSafariDriver.closeBrowsers):
+
 2015-06-04  Benjamin Poulain  
 
 Combine tiny DFAs into slightly larger ones


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py (185241 => 185242)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py	2015-06-05 06:44:55 UTC (rev 185241)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py	2015-06-05 09:11:18 UTC (rev 185242)
@@ -28,7 +28,8 @@
 _log.info('Launching "%s" with url "%s"' % (appPath, url))
 
 # FIXME: May need to be modified for a local build such as setting up DYLD libraries
-subprocess.Popen((['open', '-a', appPath] + args)).communicate()
+args = ['open', '-a', appPath] + args
+cls.launchProcessWithCaffinate(args)
 
 @classmethod
 def terminateProcesses(cls, bundleIdentifier):
@@ -36,3 +37,9 @@
 processes = NSRunningApplication.runningApplicationsWithBundleIdentifier_(bundleIdentifier)
 for process in processes:
 process.terminate()
+
+@classmethod
+def launchProcessWithCaffinate(cls, args, env=None):
+process = subprocess.Popen(args, env=env)
+subprocess.Popen(["/usr/bin/caffeinate", "-disw", str(process.pid)])
+return process


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py (185241 => 185242)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py	2015-06-05 06:44:55 UTC (rev 185241)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py	2015-06-05 09:11:18 UTC (rev 185242)
@@ -22,27 +22,27 @@
 self.safariPreferences = ["-HomePage", "about:blank", "-WarnAboutFraudulentWebsites", "0", "-ExtensionsEnabled", "0", "-ShowStatusBar", "0", "-NewWindowBehavior", "1", "-NewTabBehavior", "1"]
 
 def launchUrl(self, url, browserBuildPath):
-args = ['/Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment']
+args = ['/Applications/Safari.app/Contents/MacOS/Safari']
 env = {}
 if browserBuildPath:
 safariAppInBuildPath = os.path.join(browserBuildPath, 'Safari.app/Contents/MacOS/Safari')
 if os.path.exists(safariAppInBuildPath):
 args = [safariAppInBuildPath]
-env = {'DYLD_FRAMEWORK_PATH': browserBuildPath, 'DYLD_LIBRARY_PATH': browserBuildPath}
+env = {'DYLD_FRAMEWORK_PATH': browserBuildPath, 'DYLD_LIBRARY_PATH': browserBuildPath, '__XPC_DYLD_LIBRARY_PATH': browserBuildPath}
 else:
-_log.info('Could not find Safari.app at %s, using the system SafariForWebKitDevelopment in /Applications instead' % safariAppInBuildPath)
+_log.info('Could not find Safari.app at %s, using the system Safari instead' % safariAppInBuildPath)
 
 args.extend(self.safariPreferences)
 _log.info('Launching safari: %s with url: %s' % (args[0], url))
-self.safariProcess = subprocess.Popen(args, env=env, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subpro

[webkit-changes] [185244] trunk/Tools

2015-06-05 Thread slewis

Title: [185244] trunk/Tools








Revision 185244
Author sle...@apple.com
Date 2015-06-05 02:11:24 -0700 (Fri, 05 Jun 2015)


Log Message
Make the web server more robust to timing issues..

Reviewed by Ryosuke Niwa.

Cleaned up exception handling.
Test server is actually serving pages before returning.
Clean up some style issues.

* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver.__init__):
(SimpleHTTPServerDriver.serve): check output, wait for pages to serve
(SimpleHTTPServerDriver.baseUrl):
(SimpleHTTPServerDriver.fetchResult):
(SimpleHTTPServerDriver.killServer):
(SimpleHTTPServerDriver.getReturnCode):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py




Diff

Modified: trunk/Tools/ChangeLog (185243 => 185244)

--- trunk/Tools/ChangeLog	2015-06-05 09:11:21 UTC (rev 185243)
+++ trunk/Tools/ChangeLog	2015-06-05 09:11:24 UTC (rev 185244)
@@ -1,6 +1,25 @@
 2015-06-05  Stephanie Lewis  
 
+Make the web server more robust to timing issues..
 
+Reviewed by Ryosuke Niwa.
+
+Cleaned up exception handling.
+Test server is actually serving pages before returning.
+Clean up some style issues.
+
+* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
+* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
+(SimpleHTTPServerDriver.__init__):
+(SimpleHTTPServerDriver.serve): check output, wait for pages to serve
+(SimpleHTTPServerDriver.baseUrl): 
+(SimpleHTTPServerDriver.fetchResult):
+(SimpleHTTPServerDriver.killServer):
+(SimpleHTTPServerDriver.getReturnCode):
+
+2015-06-05  Stephanie Lewis  
+
+
 Add errors to run-benchmark exception handling.
 
 Reviewed by Ryosuke Niwa.


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py (185243 => 185244)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py	2015-06-05 09:11:21 UTC (rev 185243)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py	2015-06-05 09:11:24 UTC (rev 185244)
@@ -1,22 +1,28 @@
 #!/usr/bin/env python
 
+import argparse
+import logging
+import sys
+
 from twisted.web import static, server
 from twisted.web.resource import Resource
 from twisted.internet import reactor
-import argparse
-import sys
 
+_log = logging.getLogger(__name__)
 
 class ServerControl(Resource):
 isLeaf = True
 
 def render_GET(self, request):
+_log.info("Serving request %s" % request)
 reactor.stop()
 return ""
 
 def render_POST(self, request):
+_log.info("Serving request %s" % request)
 sys.stdout.write(request.content.getvalue())
 sys.stdout.flush()
+reactor.stop()
 return 'OK'
 
 


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py (185243 => 185244)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py	2015-06-05 09:11:21 UTC (rev 185243)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py	2015-06-05 09:11:24 UTC (rev 185244)
@@ -5,6 +5,7 @@
 import re
 import socket
 import subprocess
+import sys
 import time
 
 from http_server_driver import HTTPServerDriver
@@ -19,23 +20,22 @@
 """
 
 def __init__(self):
-self.serverProcess = None
-self.serverPort = 0
+self.server_process = None
+self.server_port = 0
 # FIXME: This may not be reliable.
 _log.info('Finding the IP address of current machine')
 try:
 self.ip = [ip for ip in socket.gethostbyname_ex(socket.gethostname())[2] if not ip.startswith("127.")][0]
 _log.info('IP of current machine is: %s' % self.ip)
-except:
-_log.error('Cannot get the ip address of current machine')
+except Exception as error:
+_log.error('Cannot get the ip address of current machine - Error: %s' % error)
 raise
 
-def serve(self, webRoot):
-oldWorkingDirectory = os.getcwd()
-os.chdir(os.path.dirname(os.path.abspath(__file__)))
+def serve(self, web_root):
 _log.info('Launching an http server')
-self.serverProcess = subprocess.Popen(['/usr/bin/python', 'http_server/twisted_http_server.py', webRoot], stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-os.chdir(oldWorkingDirectory)
+http_server_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),

[webkit-changes] [185243] trunk/Tools

2015-06-05 Thread slewis

Title: [185243] trunk/Tools








Revision 185243
Author sle...@apple.com
Date 2015-06-05 02:11:21 -0700 (Fri, 05 Jun 2015)


Log Message
Add errors to run-benchmark exception handling.

Reviewed by Ryosuke Niwa.

* Scripts/run-benchmark:
(main):
* Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
(GenericBenchmarkBuilder.prepare):
(GenericBenchmarkBuilder._runCreateScript):
(GenericBenchmarkBuilder._applyPatch):
(GenericBenchmarkBuilder.clean):
* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.__init__):
(BenchmarkRunner.execute):
(BenchmarkRunner):
(BenchmarkRunner.cleanup):
* Scripts/webkitpy/benchmark_runner/generic_factory.py:
(GenericFactory.iterateGetItem):
(GenericFactory.create):
* Scripts/webkitpy/benchmark_runner/utils.py:
(loadModule):
(loadJSONFromFile):
(forceRemove):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-benchmark
trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/generic_factory.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/utils.py




Diff

Modified: trunk/Tools/ChangeLog (185242 => 185243)

--- trunk/Tools/ChangeLog	2015-06-05 09:11:18 UTC (rev 185242)
+++ trunk/Tools/ChangeLog	2015-06-05 09:11:21 UTC (rev 185243)
@@ -1,5 +1,32 @@
 2015-06-05  Stephanie Lewis  
 
+
+Add errors to run-benchmark exception handling.
+
+Reviewed by Ryosuke Niwa.
+
+* Scripts/run-benchmark:
+(main):
+* Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
+(GenericBenchmarkBuilder.prepare):
+(GenericBenchmarkBuilder._runCreateScript):
+(GenericBenchmarkBuilder._applyPatch):
+(GenericBenchmarkBuilder.clean):
+* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
+(BenchmarkRunner.__init__):
+(BenchmarkRunner.execute):
+(BenchmarkRunner):
+(BenchmarkRunner.cleanup):
+* Scripts/webkitpy/benchmark_runner/generic_factory.py:
+(GenericFactory.iterateGetItem):
+(GenericFactory.create):
+* Scripts/webkitpy/benchmark_runner/utils.py:
+(loadModule):
+(loadJSONFromFile):
+(forceRemove):
+
+2015-06-05  Stephanie Lewis  
+
 Streamline run-benchmark browser
 
 Reviewed by Ryosuke Niwa.


Modified: trunk/Tools/Scripts/run-benchmark (185242 => 185243)

--- trunk/Tools/Scripts/run-benchmark	2015-06-05 09:11:18 UTC (rev 185242)
+++ trunk/Tools/Scripts/run-benchmark	2015-06-05 09:11:21 UTC (rev 185243)
@@ -36,8 +36,11 @@
 _log.debug('\toutput file name\t: %s' % args.output)
 _log.debug('\tbuild directory\t: %s' % args.buildDir)
 _log.debug('\tplan name\t: %s', args.plan)
-runner = BenchmarkRunner(args.plan, args.localCopy, args.countOverride, args.buildDir, args.output, args.platform, args.browser)
-return runner.execute()
+try:
+runner = BenchmarkRunner(args.plan, args.localCopy, args.countOverride, args.buildDir, args.output, args.platform, args.browser)
+runner.execute()
+except Exception as error:
+sys.exit("Error occurred running the benchmark: %s" % error)
 
 
 if __name__ == '__main__':


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py (185242 => 185243)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py	2015-06-05 09:11:18 UTC (rev 185242)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py	2015-06-05 09:11:21 UTC (rev 185243)
@@ -31,7 +31,7 @@
 if createScript:
 self._runCreateScript(createScript)
 return self._applyPatch(patch)
-except:
+except Exception:
 self.clean()
 raise
 
@@ -42,7 +42,7 @@
 errorCode = subprocess.call(createScript)
 os.chdir(oldWorkingDirectory)
 if errorCode:
-raise Exception('Cannot create the benchmark', errorCode)
+raise Exception('Cannot create the benchmark - Error: %s' % errorCode)
 
 def _copyBenchmarkToTempDir(self, benchmarkPath):
 shutil.copytree(getPathFromProjectRoot(benchmarkPath), self.dest)
@@ -70,10 +70,10 @@
 errorCode = subprocess.call(['patch', '-p1', '-f', '-i', getPathFromProjectRoot(patch)])
 os.chdir(oldWorkingDirectory)
 if errorCode:
-raise Exception('Cannot apply patch, will skip current benchmarkPath')
+raise Exception('Cannot apply patch, will skip current benchmarkPath - Error: %s' % errorCode)
 return self.webRoot
 
 def clean(self):
-_log.info('Cleanning Benchmark')
+_log.info('Cleaning Benchmark')
 if self.webRoot:
 forceRemove(self.webRoot)


Modified: trunk/Tools/Scripts/webkitpy/benchmar

[webkit-changes] [181129] trunk/LayoutTests

2015-03-05 Thread slewis

Title: [181129] trunk/LayoutTests








Revision 181129
Author sle...@apple.com
Date 2015-03-05 18:58:33 -0800 (Thu, 05 Mar 2015)


Log Message
Mark http/tests/usercontentfilter/character-set-basic-support.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=142376

Unreviewed.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (181128 => 181129)

--- trunk/LayoutTests/ChangeLog	2015-03-06 02:09:14 UTC (rev 181128)
+++ trunk/LayoutTests/ChangeLog	2015-03-06 02:58:33 UTC (rev 181129)
@@ -1,3 +1,12 @@
+2015-03-05  Stephanie Lewis  
+
+Mark http/tests/usercontentfilter/character-set-basic-support.html as failing.
+https://bugs.webkit.org/show_bug.cgi?id=142376
+
+Unreviewed.
+
+* TestExpectations:
+
 2015-03-05  Joseph Pecoraro  
 
 Web Inspector: Follow-up fixes to ObjectTreeBaseTreeElement


Modified: trunk/LayoutTests/TestExpectations (181128 => 181129)

--- trunk/LayoutTests/TestExpectations	2015-03-06 02:09:14 UTC (rev 181128)
+++ trunk/LayoutTests/TestExpectations	2015-03-06 02:58:33 UTC (rev 181129)
@@ -487,3 +487,6 @@
 
 # Content extensions are Mac-WK2-only for now
 http/tests/contentextensions [ Skip ]
+
+# New test fails on all bots
+webkit.org/b/142376 http/tests/usercontentfilter/character-set-basic-support.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [180986] trunk/LayoutTests

2015-03-03 Thread slewis

Title: [180986] trunk/LayoutTests








Revision 180986
Author sle...@apple.com
Date 2015-03-03 20:47:05 -0800 (Tue, 03 Mar 2015)


Log Message
Update TestExpectations after http://trac.webkit.org/changeset/180965 to skip new test on Mavericks.

Unreviewed.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (180985 => 180986)

--- trunk/LayoutTests/ChangeLog	2015-03-04 03:36:10 UTC (rev 180985)
+++ trunk/LayoutTests/ChangeLog	2015-03-04 04:47:05 UTC (rev 180986)
@@ -1,3 +1,11 @@
+2015-03-03  Stephanie Lewis  
+
+Update TestExpectations after http://trac.webkit.org/changeset/180965 to skip new test on Mavericks.
+
+Unreviewed.
+
+* platform/mac/TestExpectations:
+
 2015-03-03  Alexey Proskuryakov  
 
 [Mac] Track localized name follows locale instead of primary language


Modified: trunk/LayoutTests/platform/mac/TestExpectations (180985 => 180986)

--- trunk/LayoutTests/platform/mac/TestExpectations	2015-03-04 03:36:10 UTC (rev 180985)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-03-04 04:47:05 UTC (rev 180986)
@@ -1280,3 +1280,6 @@
 webkit.org/b/142142 media/video-empty-source.html [ Skip ]
 webkit.org/b/142142 media/audio-delete-while-slider-thumb-clicked.html [ Skip ]
 webkit.org/b/142142 media/controls-after-reload.html [ Skip ]
+
+# Test uses Yosemite blurs
+[ Mavericks ] compositing/media-controls-bar-appearance.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [180608] trunk/Source/WebCore

2015-02-24 Thread slewis

Title: [180608] trunk/Source/WebCore








Revision 180608
Author sle...@apple.com
Date 2015-02-24 20:10:54 -0800 (Tue, 24 Feb 2015)


Log Message
Unreviewed ios build fix after http://trac.webkit.org/changeset/180602.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonVM):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (180607 => 180608)

--- trunk/Source/WebCore/ChangeLog	2015-02-25 04:07:06 UTC (rev 180607)
+++ trunk/Source/WebCore/ChangeLog	2015-02-25 04:10:54 UTC (rev 180608)
@@ -1,3 +1,10 @@
+2015-02-24  Stephanie Lewis  
+
+Unreviewed ios build fix after http://trac.webkit.org/changeset/180602.
+
+* bindings/js/JSDOMWindowBase.cpp:
+(WebCore::JSDOMWindowBase::commonVM):
+
 2015-02-24  Simon Fraser  
 
 Use an enum for scrollbar style


Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp (180607 => 180608)

--- trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp	2015-02-25 04:07:06 UTC (rev 180607)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp	2015-02-25 04:10:54 UTC (rev 180608)
@@ -212,7 +212,7 @@
 vm->heap.setEdenActivityCallback(vm->heap.fullActivityCallback());
 #endif
 vm->heap.setIncrementalSweeper(std::make_unique(&vm->heap));
-vm->heap.machineThreads().addCurrentThread();
+vm->heap.machineThreads().addCurrentThread(vm);
 #endif
 initNormalWorldClientData(vm);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [180604] trunk/Source/bmalloc

2015-02-24 Thread slewis

Title: [180604] trunk/Source/bmalloc








Revision 180604
Author sle...@apple.com
Date 2015-02-24 19:02:26 -0800 (Tue, 24 Feb 2015)


Log Message
Rolling out http://trac.webkit.org/changeset/180430 as it causes the PLT to crash.


Unreviewed.

* bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::grow):
* bmalloc/VMHeap.h:
* bmalloc/Zone.cpp:
(bmalloc::Zone::Zone):
(bmalloc::Zone::size): Deleted.
* bmalloc/Zone.h:

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/VMHeap.cpp
trunk/Source/bmalloc/bmalloc/VMHeap.h
trunk/Source/bmalloc/bmalloc/Zone.cpp
trunk/Source/bmalloc/bmalloc/Zone.h




Diff

Modified: trunk/Source/bmalloc/ChangeLog (180603 => 180604)

--- trunk/Source/bmalloc/ChangeLog	2015-02-25 02:31:22 UTC (rev 180603)
+++ trunk/Source/bmalloc/ChangeLog	2015-02-25 03:02:26 UTC (rev 180604)
@@ -1,3 +1,18 @@
+2015-02-24  Stephanie Lewis  
+
+Rolling out http://trac.webkit.org/changeset/180430 as it causes the PLT to crash.
+
+
+Unreviewed.
+
+* bmalloc/VMHeap.cpp:
+(bmalloc::VMHeap::grow):
+* bmalloc/VMHeap.h:
+* bmalloc/Zone.cpp:
+(bmalloc::Zone::Zone):
+(bmalloc::Zone::size): Deleted.
+* bmalloc/Zone.h:
+
 2015-02-24  Geoffrey Garen  
 
 bmalloc: Added a little more abstraction for large objects


Modified: trunk/Source/bmalloc/bmalloc/VMHeap.cpp (180603 => 180604)

--- trunk/Source/bmalloc/bmalloc/VMHeap.cpp	2015-02-25 02:31:22 UTC (rev 180603)
+++ trunk/Source/bmalloc/bmalloc/VMHeap.cpp	2015-02-25 03:02:26 UTC (rev 180604)
@@ -40,7 +40,7 @@
 void VMHeap::grow()
 {
 SuperChunk* superChunk = SuperChunk::create();
-#if BOS(DARWIN)
+#if BPLATFORM(DARWIN)
 m_zone.addSuperChunk(superChunk);
 #endif
 


Modified: trunk/Source/bmalloc/bmalloc/VMHeap.h (180603 => 180604)

--- trunk/Source/bmalloc/bmalloc/VMHeap.h	2015-02-25 02:31:22 UTC (rev 180603)
+++ trunk/Source/bmalloc/bmalloc/VMHeap.h	2015-02-25 03:02:26 UTC (rev 180604)
@@ -35,7 +35,7 @@
 #include "SegregatedFreeList.h"
 #include "SmallChunk.h"
 #include "Vector.h"
-#if BOS(DARWIN)
+#if BPLATFORM(DARWIN)
 #include "Zone.h"
 #endif
 
@@ -65,7 +65,7 @@
 Vector m_smallPages;
 Vector m_mediumPages;
 SegregatedFreeList m_largeObjects;
-#if BOS(DARWIN)
+#if BPLATFORM(DARWIN)
 Zone m_zone;
 #endif
 };


Modified: trunk/Source/bmalloc/bmalloc/Zone.cpp (180603 => 180604)

--- trunk/Source/bmalloc/bmalloc/Zone.cpp	2015-02-25 02:31:22 UTC (rev 180603)
+++ trunk/Source/bmalloc/bmalloc/Zone.cpp	2015-02-25 03:02:26 UTC (rev 180604)
@@ -42,13 +42,6 @@
 memcpy(&result, tmp, sizeof(T));
 }
 
-// Support malloc_zone_from_ptr, which calls size() on each registered zone.
-size_t Zone::size(malloc_zone_t*, const void*)
-{
-// Our zone is not public API, so no pointer can belong to us.
-return 0;
-}
-
 // This function runs inside the leaks process.
 kern_return_t Zone::enumerator(task_t task, void* context, unsigned type_mask, vm_address_t zone_address, memory_reader_t reader, vm_range_recorder_t recorder)
 {
@@ -70,10 +63,9 @@
 
 Zone::Zone()
 {
-malloc_zone_t::size = size;
-malloc_zone_t::zone_name = "WebKit Malloc";
-malloc_zone_t::introspect = &bmalloc::introspect;
-malloc_zone_t::version = 4;
+version = 4;
+zone_name = "WebKit Malloc";
+introspect = &bmalloc::introspect;
 malloc_zone_register(this);
 }
 


Modified: trunk/Source/bmalloc/bmalloc/Zone.h (180603 => 180604)

--- trunk/Source/bmalloc/bmalloc/Zone.h	2015-02-25 02:31:22 UTC (rev 180603)
+++ trunk/Source/bmalloc/bmalloc/Zone.h	2015-02-25 03:02:26 UTC (rev 180604)
@@ -38,7 +38,6 @@
 // Enough capacity to track a 64GB heap, so probably enough for anything.
 static const size_t capacity = 2048;
 
-static size_t size(malloc_zone_t*, const void*);
 static kern_return_t enumerator(task_t, void* context, unsigned type_mask, vm_address_t, memory_reader_t, vm_range_recorder_t);
 
 Zone();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [175223] trunk/LayoutTests

2014-10-27 Thread slewis

Title: [175223] trunk/LayoutTests








Revision 175223
Author sle...@apple.com
Date 2014-10-27 11:31:06 -0700 (Mon, 27 Oct 2014)


Log Message
http/tests/cookies/third-party-cookie-relaxing.html is flaky on bots.
https://bugs.webkit.org/show_bug.cgi?id=138098.

Updated Expectations.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (175222 => 175223)

--- trunk/LayoutTests/ChangeLog	2014-10-27 18:26:08 UTC (rev 175222)
+++ trunk/LayoutTests/ChangeLog	2014-10-27 18:31:06 UTC (rev 175223)
@@ -1,3 +1,12 @@
+2014-10-27  Stephanie Lewis  
+
+http/tests/cookies/third-party-cookie-relaxing.html is flaky on bots.
+https://bugs.webkit.org/show_bug.cgi?id=138098.
+
+Updated Expectations.
+
+* platform/mac-wk1/TestExpectations:
+
 2014-10-27  Piotr Grad  
 
 Some test for multicol were redundant.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (175222 => 175223)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2014-10-27 18:26:08 UTC (rev 175222)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2014-10-27 18:31:06 UTC (rev 175223)
@@ -19,6 +19,10 @@
 webkit.org/b/132421 fast/multicol/fixed-stack.html [ ImageOnlyFailure ]
 [ MountainLion Mavericks ] fast/multicol/fixed-stack.html [ Pass ]
 
+# Failing itermittently on Yosemite Release WK1 bots. 
+webkit.org/b/138098 http/tests/cookies/third-party-cookie-relaxing.html [ Pass Failure ]
+[ MountainLion Mavericks ] http/tests/cookies/third-party-cookie-relaxing.html [ Pass ]
+
 ### END OF (1) Failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167981] trunk/Tools

2014-04-29 Thread slewis

Title: [167981] trunk/Tools








Revision 167981
Author sle...@apple.com
Date 2014-04-29 21:54:07 -0700 (Tue, 29 Apr 2014)


Log Message
 Use JSON::PP in perl scripts instead of JSON.

Rubber stamped by Jessie Berlin.

JSON.pm was removed from our tools setup.

* Scripts/generate-coverage-data:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/generate-coverage-data




Diff

Modified: trunk/Tools/ChangeLog (167980 => 167981)

--- trunk/Tools/ChangeLog	2014-04-30 04:03:55 UTC (rev 167980)
+++ trunk/Tools/ChangeLog	2014-04-30 04:54:07 UTC (rev 167981)
@@ -1,3 +1,13 @@
+2014-04-29  Stephanie Lewis  
+
+ Use JSON::PP in perl scripts instead of JSON.
+
+Rubber stamped by Jessie Berlin.
+
+JSON.pm was removed from our tools setup.
+
+* Scripts/generate-coverage-data:
+
 2014-04-29  Filip Pizlo  
 
 Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)


Modified: trunk/Tools/Scripts/generate-coverage-data (167980 => 167981)

--- trunk/Tools/Scripts/generate-coverage-data	2014-04-30 04:03:55 UTC (rev 167980)
+++ trunk/Tools/Scripts/generate-coverage-data	2014-04-30 04:54:07 UTC (rev 167981)
@@ -34,7 +34,7 @@
 use File::Spec;
 use FindBin;
 use Getopt::Long qw(:config pass_through);
-use JSON;
+use JSON::PP;
 use lib $FindBin::Bin;
 use List::Util qw(sum);
 use List::Util qw(max);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167522] trunk/Source/WebCore

2014-04-18 Thread slewis

Title: [167522] trunk/Source/WebCore








Revision 167522
Author sle...@apple.com
Date 2014-04-18 17:44:47 -0700 (Fri, 18 Apr 2014)


Log Message
Move DOM throttling out of the page throttler

https://bugs.webkit.org/show_bug.cgi?id=131697

Reviewed by Gavin Barraclough.

No new tests since it's not web exposed.

DOM timer throttling is currently part of the page throttler which uses per process
state and per page state to determine when to throttle.  This led us to being overly
conservative when turning DOM throttling off.  It should only respond to view state changes.

Additionally since creating extra page throttlers SVG images caused bugs
in tracking state we'll reserve the page throttler for WebKit2 views.  To avoid regressing
WebKit1 we should move DOM timer throttling back to the page.

* page/Page.cpp:
(WebCore::Page::Page): set DOM timer throttling.
(WebCore::Page::setIsVisuallyIdleInternal): ditto.
(WebCore::Page::hiddenPageDOMTimerThrottlingStateChanged): ditto.
(WebCore::Page::setIsVisible): Update view state masks for WebKit1 to include IsVisibleOrOccluded and IsVisuallyIdle
* page/Page.h:
* page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler): remove DOM timer throttling.
(WebCore::PageThrottler::started): ditto.
(WebCore::PageThrottler::stopped): ditto.
(WebCore::PageThrottler::hiddenPageDOMTimerThrottlingStateChanged): Deleted.
* page/PageThrottler.h:
* page/Settings.cpp:
(WebCore::Settings::setHiddenPageDOMTimerThrottlingEnabled):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/page/PageThrottler.cpp
trunk/Source/WebCore/page/PageThrottler.h
trunk/Source/WebCore/page/Settings.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (167521 => 167522)

--- trunk/Source/WebCore/ChangeLog	2014-04-19 00:33:46 UTC (rev 167521)
+++ trunk/Source/WebCore/ChangeLog	2014-04-19 00:44:47 UTC (rev 167522)
@@ -1,3 +1,36 @@
+2014-04-18  Stephanie Lewis  
+
+Move DOM throttling out of the page throttler
+
+https://bugs.webkit.org/show_bug.cgi?id=131697
+
+Reviewed by Gavin Barraclough.
+
+No new tests since it's not web exposed.
+
+DOM timer throttling is currently part of the page throttler which uses per process 
+state and per page state to determine when to throttle.  This led us to being overly 
+conservative when turning DOM throttling off.  It should only respond to view state changes.
+
+Additionally since creating extra page throttlers SVG images caused bugs 
+in tracking state we'll reserve the page throttler for WebKit2 views.  To avoid regressing 
+WebKit1 we should move DOM timer throttling back to the page.
+
+* page/Page.cpp:
+(WebCore::Page::Page): set DOM timer throttling.
+(WebCore::Page::setIsVisuallyIdleInternal): ditto.
+(WebCore::Page::hiddenPageDOMTimerThrottlingStateChanged): ditto.
+(WebCore::Page::setIsVisible): Update view state masks for WebKit1 to include IsVisibleOrOccluded and IsVisuallyIdle
+* page/Page.h:
+* page/PageThrottler.cpp:
+(WebCore::PageThrottler::PageThrottler): remove DOM timer throttling.
+(WebCore::PageThrottler::started): ditto.
+(WebCore::PageThrottler::stopped): ditto.
+(WebCore::PageThrottler::hiddenPageDOMTimerThrottlingStateChanged): Deleted.
+* page/PageThrottler.h:
+* page/Settings.cpp:
+(WebCore::Settings::setHiddenPageDOMTimerThrottlingEnabled):
+
 2014-04-18  Dean Jackson  
 
 [WebGL] Limit maximum texture sizes on older Intel hardware


Modified: trunk/Source/WebCore/page/Page.cpp (167521 => 167522)

--- trunk/Source/WebCore/page/Page.cpp	2014-04-19 00:33:46 UTC (rev 167521)
+++ trunk/Source/WebCore/page/Page.cpp	2014-04-19 00:44:47 UTC (rev 167522)
@@ -199,7 +199,9 @@
 , m_sessionID(SessionID::defaultSessionID())
 {
 ASSERT(m_editorClient);
-
+
+setTimerThrottlingEnabled(m_viewState & ViewState::IsVisuallyIdle);
+
 if (m_visitedLinkStore)
 m_visitedLinkStore->addPage(*this);
 
@@ -896,6 +898,8 @@
 
 void Page::setIsVisuallyIdleInternal(bool isVisuallyIdle)
 {
+setTimerThrottlingEnabled(isVisuallyIdle);
+
 for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {
 if (frame->document())
 frame->document()->scriptedAnimationControllerSetThrottled(isVisuallyIdle);
@@ -1063,6 +1067,11 @@
 return m_minimumTimerInterval;
 }
 
+void Page::hiddenPageDOMTimerThrottlingStateChanged()
+{
+setTimerThrottlingEnabled(m_viewState & ViewState::IsVisuallyIdle);
+}
+
 void Page::setTimerThrottlingEnabled(bool enabled)
 {
 #if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
@@ -1172,7 +1181,10 @@
 
 void Page::setIsVisible(bool isVisible)
 {
-setViewState(isVisible ? m_viewState | ViewState::IsVisible : m_viewState & ~ViewState::IsVisible);
+if (isVisible)
+se

[webkit-changes] [167523] trunk/Source

2014-04-18 Thread slewis

Title: [167523] trunk/Source








Revision 167523
Author sle...@apple.com
Date 2014-04-18 17:44:50 -0700 (Fri, 18 Apr 2014)


Log Message
We shouldn’t create page throttlers for other pages than WebKit2 pages.

Source/WebCore:
Part of  Visibility state counters are often incorrect
https://bugs.webkit.org/show_bug.cgi?id=131696

Reviewed by Gavin Barraclough.

No new test since not web exposed.

Page throttlers were being created for SVG images and other page instances that
were not accurately tracking the states that enable and disable page throttling.
Make the throttler an unique ptr and only initialize it for WebKit2.

This also fixes an inefficiency where we would throttle a new page on creation because
we assumed it was visible even if that was not the case.

* WebCore.exp.in:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Check page throttler exists.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::started): ditto
* page/Page.cpp:
(WebCore::Page::Page): Don’t automatically create page throttler.
(WebCore::Page::createPageThrottler): Create page throttler.
(WebCore::Page::setViewState): Check page throttler exists.
* page/Page.h:
(WebCore::Page::pageThrottler): Make the page throttler a unique ptr.
* page/PageThrottler.h:
* page/Settings.cpp:
(WebCore::Settings::setHiddenPageDOMTimerThrottlingEnabled): Check page throttler exists.

Source/WebKit2:
Part of  Visibility state counters are often incorrect.
https://bugs.webkit.org/show_bug.cgi?id=131696

Reviewed by Gavin Barraclough.

Page throttlers were being created for SVG images and other page instances that
were not accurately tracking the states that enable and disable page throttling.
Make the throttler an unique ptr and only initialize it for WebKit2.

This also fixes  an inefficiency where we would throttle a new page on creation because
we assumed it was visible even if that was not the case.

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: Check page throttler exists.
(WebKit::NPRuntimeObjectMap::evaluate):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize page throttler for WebKit2 views.
(WebKit::WebPage::mouseEvent): Check page throttler exists.
(WebKit::WebPage::wheelEvent): ditto
(WebKit::WebPage::keyEvent): ditto

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/page/PageThrottler.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (167522 => 167523)

--- trunk/Source/WebCore/ChangeLog	2014-04-19 00:44:47 UTC (rev 167522)
+++ trunk/Source/WebCore/ChangeLog	2014-04-19 00:44:50 UTC (rev 167523)
@@ -1,5 +1,37 @@
 2014-04-18  Stephanie Lewis  
 
+We shouldn’t create page throttlers for other pages than WebKit2 pages.
+Part of  Visibility state counters are often incorrect
+https://bugs.webkit.org/show_bug.cgi?id=131696
+
+Reviewed by Gavin Barraclough.
+
+No new test since not web exposed.
+
+Page throttlers were being created for SVG images and other page instances that
+were not accurately tracking the states that enable and disable page throttling.
+Make the throttler an unique ptr and only initialize it for WebKit2.
+
+This also fixes an inefficiency where we would throttle a new page on creation because 
+we assumed it was visible even if that was not the case.
+
+* WebCore.exp.in:
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::parseAttribute): Check page throttler exists.
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::started): ditto
+* page/Page.cpp:
+(WebCore::Page::Page): Don’t automatically create page throttler.
+(WebCore::Page::createPageThrottler): Create page throttler.
+(WebCore::Page::setViewState): Check page throttler exists.
+* page/Page.h:
+(WebCore::Page::pageThrottler): Make the page throttler a unique ptr.
+* page/PageThrottler.h:
+* page/Settings.cpp: 
+(WebCore::Settings::setHiddenPageDOMTimerThrottlingEnabled): Check page throttler exists.
+
+2014-04-18  Stephanie Lewis  
+
 Move DOM throttling out of the page throttler
 
 https://bugs.webkit.org/show_bug.cgi?id=131697


Modified: trunk/Source/WebCore/WebCore.exp.in (167522 => 167523)

--- trunk/Source/WebCore/WebCore.exp.in	2014-04-19 00:44:47 UTC (rev 167522)
+++ trunk/Source/WebCore/WebCore.exp.in	2014-04-19 00:44:50 UTC (rev 167523)
@@ -1059,6 +1059,7 @@
 __ZN7WebCore4Page18setPageScaleFactorEfRKNS_8IntPointE
 __ZN7WebCore4Page18setTopContentInsetEf
 __ZN7WebCore4Page19addLayoutMilestonesEj
+__ZN7WebCore4Page19crea

[webkit-changes] [166907] trunk/Source/WebKit2

2014-04-07 Thread slewis

Title: [166907] trunk/Source/WebKit2








Revision 166907
Author sle...@apple.com
Date 2014-04-07 20:49:37 -0700 (Mon, 07 Apr 2014)


Log Message
Crash in com.apple.WebKit.Plugin.Development at com.apple.WebKit2: WebKit::PluginControllerProxy::pluginInstanceID

https://bugs.webkit.org/show_bug.cgi?id=131203

Reviewed by Geoff Garen.

pluginController was being removed before accessing the pluginInstanceID.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::removePluginControllerProxy):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166906 => 166907)

--- trunk/Source/WebKit2/ChangeLog	2014-04-08 02:46:49 UTC (rev 166906)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-08 03:49:37 UTC (rev 166907)
@@ -1,3 +1,16 @@
+2014-04-07  Stephanie Lewis  
+
+Crash in com.apple.WebKit.Plugin.Development at com.apple.WebKit2: WebKit::PluginControllerProxy::pluginInstanceID
+
+https://bugs.webkit.org/show_bug.cgi?id=131203
+
+Reviewed by Geoff Garen.
+
+pluginController was being removed before accessing the pluginInstanceID.
+
+* PluginProcess/WebProcessConnection.cpp:
+(WebKit::WebProcessConnection::removePluginControllerProxy):
+
 2014-04-07  Dan Bernstein  
 
 More Mountain Lion build fix.


Modified: trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp (166906 => 166907)

--- trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp	2014-04-08 02:46:49 UTC (rev 166906)
+++ trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp	2014-04-08 03:49:37 UTC (rev 166907)
@@ -85,14 +85,15 @@
 
 void WebProcessConnection::removePluginControllerProxy(PluginControllerProxy* pluginController, Plugin* plugin)
 {
+unsigned pluginInstanceID = pluginController->pluginInstanceID();
 {
-ASSERT(m_pluginControllers.contains(pluginController->pluginInstanceID()));
+ASSERT(m_pluginControllers.contains(pluginInstanceID));
 
-std::unique_ptr pluginControllerUniquePtr = m_pluginControllers.take(pluginController->pluginInstanceID());
+std::unique_ptr pluginControllerUniquePtr = m_pluginControllers.take(pluginInstanceID);
 ASSERT(pluginControllerUniquePtr.get() == pluginController);
 }
 
-pluginDidBecomeHidden(pluginController->pluginInstanceID());
+pluginDidBecomeHidden(pluginInstanceID);
 
 // Invalidate all objects related to this plug-in.
 if (plugin)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166446] trunk/Source/WebCore

2014-03-28 Thread slewis

Title: [166446] trunk/Source/WebCore








Revision 166446
Author sle...@apple.com
Date 2014-03-28 19:46:45 -0700 (Fri, 28 Mar 2014)


Log Message
Unreviewed build fix.

* platform/audio/AudioHardwareListener.cpp:
(WebCore::AudioHardwareListener::create):
(WebCore::AudioHardwareListener::audioHardwareListenerIsSupported): Deleted.
* platform/audio/AudioHardwareListener.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/AudioHardwareListener.cpp
trunk/Source/WebCore/platform/audio/AudioHardwareListener.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (166445 => 166446)

--- trunk/Source/WebCore/ChangeLog	2014-03-29 02:26:53 UTC (rev 166445)
+++ trunk/Source/WebCore/ChangeLog	2014-03-29 02:46:45 UTC (rev 166446)
@@ -1,3 +1,12 @@
+2014-03-28  Stephanie Lewis  
+
+Unreviewed build fix.
+
+* platform/audio/AudioHardwareListener.cpp:
+(WebCore::AudioHardwareListener::create):
+(WebCore::AudioHardwareListener::audioHardwareListenerIsSupported): Deleted.
+* platform/audio/AudioHardwareListener.h:
+
 2014-03-28  Lukasz Bialek  
 
 Refactor cut and copy functions as suggested in FIXME line


Modified: trunk/Source/WebCore/platform/audio/AudioHardwareListener.cpp (166445 => 166446)

--- trunk/Source/WebCore/platform/audio/AudioHardwareListener.cpp	2014-03-29 02:26:53 UTC (rev 166445)
+++ trunk/Source/WebCore/platform/audio/AudioHardwareListener.cpp	2014-03-29 02:46:45 UTC (rev 166446)
@@ -33,12 +33,6 @@
 {
 return adoptRef(new AudioHardwareListener(client));
 }
-
-bool AudioHardwareListener::audioHardwareListenerIsSupported()
-{
-return false;
-};
-
 #endif
 
 AudioHardwareListener::AudioHardwareListener(Client& client)


Modified: trunk/Source/WebCore/platform/audio/AudioHardwareListener.h (166445 => 166446)

--- trunk/Source/WebCore/platform/audio/AudioHardwareListener.h	2014-03-29 02:26:53 UTC (rev 166445)
+++ trunk/Source/WebCore/platform/audio/AudioHardwareListener.h	2014-03-29 02:46:45 UTC (rev 166446)
@@ -46,7 +46,6 @@
 virtual void audioHardwareDidBecomeInactive() = 0;
 };
 
-
 static PassRefPtr create(Client&);
 virtual ~AudioHardwareListener() { }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166441] trunk/Source/WebKit2

2014-03-28 Thread slewis

Title: [166441] trunk/Source/WebKit2








Revision 166441
Author sle...@apple.com
Date 2014-03-28 18:15:44 -0700 (Fri, 28 Mar 2014)


Log Message
Have the plugin process track visibility of it’s plugin and sleep when none
are visible.
Part of  PluginProcess should AppNap when no plugins on active tab.
https://bugs.webkit.org/show_bug.cgi?id=130694

Reviewed by Anders Carlsson.

Currently AppSleep is enabled on the PluginProcess based on web page visibility.
Add visibility tracking to plugins and move the decision to AppSleep into the the
PluginProcess

* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess): Add a new activity for visible plugins
(WebKit::PluginProcess::pluginsForWebProcessDidBecomeVisible): take an activity
 assertion if any web processes have a visible plugin.
(WebKit::PluginProcess::pluginsForWebProcessDidBecomeHidden):
* PluginProcess/PluginProcess.h:
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::removePluginControllerProxy): remove plugin from
visible plugins when destroying it
(WebKit::WebProcessConnection::pluginDidBecomeVisible):
(WebKit::WebProcessConnection::pluginDidBecomeHidden): track which plugins are
visible for each web process
* PluginProcess/WebProcessConnection.h:
* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::windowVisibilityChanged): notify WebProcessConnection
when visibility changed.
* UIProcess/WebContext.h:
* UIProcess/mac/WebContextMac.mm:  instead of tracking plugin app sleep state on the web pref.
and visibility state, just use the web pref.
(WebKit::WebContext::updateProcessSuppressionState):
(WebKit::WebContext::processSuppressionPreferenceIsEnabledForAllContexts):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp
trunk/Source/WebKit2/PluginProcess/PluginProcess.h
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.h
trunk/Source/WebKit2/PluginProcess/mac/PluginControllerProxyMac.mm
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166440 => 166441)

--- trunk/Source/WebKit2/ChangeLog	2014-03-29 00:37:10 UTC (rev 166440)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-29 01:15:44 UTC (rev 166441)
@@ -1,3 +1,38 @@
+2014-03-28  Stephanie Lewis  
+
+Have the plugin process track visibility of it’s plugin and sleep when none
+are visible.
+Part of  PluginProcess should AppNap when no plugins on active tab.
+https://bugs.webkit.org/show_bug.cgi?id=130694
+
+Reviewed by Anders Carlsson.
+
+Currently AppSleep is enabled on the PluginProcess based on web page visibility.
+Add visibility tracking to plugins and move the decision to AppSleep into the the
+PluginProcess
+
+* PluginProcess/PluginProcess.cpp:
+(WebKit::PluginProcess::PluginProcess): Add a new activity for visible plugins
+(WebKit::PluginProcess::pluginsForWebProcessDidBecomeVisible): take an activity
+ assertion if any web processes have a visible plugin.
+(WebKit::PluginProcess::pluginsForWebProcessDidBecomeHidden): 
+* PluginProcess/PluginProcess.h:
+* PluginProcess/WebProcessConnection.cpp: 
+(WebKit::WebProcessConnection::removePluginControllerProxy): remove plugin from 
+visible plugins when destroying it
+(WebKit::WebProcessConnection::pluginDidBecomeVisible):
+(WebKit::WebProcessConnection::pluginDidBecomeHidden): track which plugins are
+visible for each web process
+* PluginProcess/WebProcessConnection.h:
+* PluginProcess/mac/PluginControllerProxyMac.mm:
+(WebKit::PluginControllerProxy::windowVisibilityChanged): notify WebProcessConnection
+when visibility changed.
+* UIProcess/WebContext.h:
+* UIProcess/mac/WebContextMac.mm:  instead of tracking plugin app sleep state on the web pref.
+and visibility state, just use the web pref.
+(WebKit::WebContext::updateProcessSuppressionState):
+(WebKit::WebContext::processSuppressionPreferenceIsEnabledForAllContexts):
+
 2014-03-28  Brian Burg  
 
 Web Replay: add page-level setting to bypass the MemoryCache


Modified: trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp (166440 => 166441)

--- trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp	2014-03-29 00:37:10 UTC (rev 166440)
+++ trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp	2014-03-29 01:15:44 UTC (rev 166441)
@@ -61,6 +61,7 @@
 , m_compositingRenderServerPort(MACH_PORT_NULL)
 #endif
 , m_connectionActivity("PluginProcess connection activity.")
+, m_visiblePluginsActivity("Visible plugins from PluginProcess activity.")
 {
 NetscapePlugin::setSetExceptionFunction(WebProcessConnection::setGlobalException);
 }
@@ -236,6

[webkit-changes] [166443] trunk/Source

2014-03-28 Thread slewis

Title: [166443] trunk/Source








Revision 166443
Author sle...@apple.com
Date 2014-03-28 18:15:49 -0700 (Fri, 28 Mar 2014)


Log Message
Source/WebCore: Rename pluginDidEvaluate to better represent when it’s called.
Part of  PluginProcess should AppNap when no plugins on active tab.

Reviewed by Anders Carlsson.

No new test because it’s just a name change.

* page/PageThrottler.h:
(WebCore::PageThrottler::pluginDidEvaluateWhileAudioIsPlaying):

Source/WebKit2: Stop waking up the web process in the background because of plugin activity.
Part of  PluginProcess should AppNap when no plugins on active tab.

Reviewed by Anders Carlsson.

Plugin activity in the background can constantly wake up web processes.  This is only
necessary when audio is playing to support web apps like Pandora and youtube playing
in the background.  Use a new api in CoreAudio to see if there is audio playing in
the PluginProcess.

* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess): Add a AudioHardwareListener
(WebKit::PluginProcess::createWebProcessConnection): tell web process current state
(WebKit::PluginProcess::audioHardwareDidBecomeActive): respond to audio hardware notifications
(WebKit::PluginProcess::audioHardwareDidBecomeInactive):
* PluginProcess/PluginProcess.h:
* PluginProcess/WebProcessConnection.cpp: tell WebProcess when audio state in PluginProcess
 changes.
(WebKit::WebProcessConnection::audioHardwareDidBecomeActive):
(WebKit::WebProcessConnection::audioHardwareDidBecomeInactive):
* PluginProcess/WebProcessConnection.h:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
 Only invoke pageThrottler activity when playing audio
(WebKit::NPRuntimeObjectMap::evaluate):
* WebProcess/Plugins/Plugin.h: add function to get audio state
(WebKit::Plugin::audioIsPlayingInPluginProcess):
* WebProcess/Plugins/PluginProcessConnection.cpp: store audio state
(WebKit::PluginProcessConnection::PluginProcessConnection):
(WebKit::PluginProcessConnection::didReceiveMessage):
(WebKit::PluginProcessConnection::audioHardwareDidBecomeActive):
(WebKit::PluginProcessConnection::audioHardwareDidBecomeInactive):
* WebProcess/Plugins/PluginProcessConnection.h:
(WebKit::PluginProcessConnection::audioIsPlaying):
* WebProcess/Plugins/PluginProcessConnection.messages.in:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::audioIsPlayingInPluginProcess):
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::audioIsPlayingInPluginProcess):
* WebProcess/Plugins/PluginView.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PageThrottler.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp
trunk/Source/WebKit2/PluginProcess/PluginProcess.h
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.h
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.messages.in
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (166442 => 166443)

--- trunk/Source/WebCore/ChangeLog	2014-03-29 01:15:47 UTC (rev 166442)
+++ trunk/Source/WebCore/ChangeLog	2014-03-29 01:15:49 UTC (rev 166443)
@@ -1,5 +1,17 @@
 2014-03-28  Stephanie Lewis  
 
+Rename pluginDidEvaluate to better represent when it’s called.
+Part of  PluginProcess should AppNap when no plugins on active tab.
+
+Reviewed by Anders Carlsson.
+
+No new test because it’s just a name change.
+
+* page/PageThrottler.h:
+(WebCore::PageThrottler::pluginDidEvaluateWhileAudioIsPlaying):
+
+2014-03-28  Stephanie Lewis  
+
 Notification handler for telling if audio hardware is active.
 https://bugs.webkit.org/show_bug.cgi?id=130743
 


Modified: trunk/Source/WebCore/page/PageThrottler.h (166442 => 166443)

--- trunk/Source/WebCore/page/PageThrottler.h	2014-03-29 01:15:47 UTC (rev 166442)
+++ trunk/Source/WebCore/page/PageThrottler.h	2014-03-29 01:15:49 UTC (rev 166443)
@@ -47,7 +47,7 @@
 void setViewState(ViewState::Flags);
 
 void didReceiveUserInput() { m_hysteresis.impulse(); }
-void pluginDidEvaluate() { m_hysteresis.impulse(); }
+void pluginDidEvaluateWhileAudioIsPlaying() { m_hysteresis.impulse(); }
 std::unique_ptr mediaActivityToken();
 std::unique_ptr pageLoadActivityToken();
 


Modified: trunk/Source/WebKit2/ChangeLog (166442 => 166443)

--- trunk/Source/WebKit2/ChangeLog	2014-03-29 01:15:47 UTC (rev 166442)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-29 01:

[webkit-changes] [166442] trunk/Source/WebCore

2014-03-28 Thread slewis

Title: [166442] trunk/Source/WebCore








Revision 166442
Author sle...@apple.com
Date 2014-03-28 18:15:47 -0700 (Fri, 28 Mar 2014)


Log Message
Notification handler for telling if audio hardware is active.
https://bugs.webkit.org/show_bug.cgi?id=130743

Reviewed by Jer Noble.

Not web-exposed so no easy way to test.

Listen to CoreAudio to see if audio hardware is active in the current process.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/audio/AudioHardwareListener.cpp: Added.
(WebCore::AudioHardwareListener::create):
(WebCore::AudioHardwareListener::AudioHardwareListener):
* platform/audio/AudioHardwareListener.h: Added.
(WebCore::AudioHardwareListener::Client::~Client):
(WebCore::AudioHardwareListener::~AudioHardwareListener):
(WebCore::AudioHardwareListener::isHardwareActive):
* platform/audio/mac/AudioHardwareListenerMac.cpp: Added.
(WebCore::isAudioHardwareProcessRunning):
(WebCore::AudioHardwareListener::create):
(WebCore::AudioHardwareListenerMac::create):
(WebCore::AudioHardwareListenerMac::AudioHardwareListenerMac):
(WebCore::AudioHardwareListenerMac::~AudioHardwareListenerMac):
(WebCore::AudioHardwareListenerMac::setHardwareActive):
* platform/audio/mac/AudioHardwareListenerMac.h: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebCore/platform/audio/AudioHardwareListener.cpp
trunk/Source/WebCore/platform/audio/AudioHardwareListener.h
trunk/Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp
trunk/Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (166441 => 166442)

--- trunk/Source/WebCore/ChangeLog	2014-03-29 01:15:44 UTC (rev 166441)
+++ trunk/Source/WebCore/ChangeLog	2014-03-29 01:15:47 UTC (rev 166442)
@@ -1,3 +1,32 @@
+2014-03-28  Stephanie Lewis  
+
+Notification handler for telling if audio hardware is active.
+https://bugs.webkit.org/show_bug.cgi?id=130743
+
+Reviewed by Jer Noble.
+
+Not web-exposed so no easy way to test.
+
+Listen to CoreAudio to see if audio hardware is active in the current process.
+
+* WebCore.exp.in:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/audio/AudioHardwareListener.cpp: Added.
+(WebCore::AudioHardwareListener::create):
+(WebCore::AudioHardwareListener::AudioHardwareListener):
+* platform/audio/AudioHardwareListener.h: Added.
+(WebCore::AudioHardwareListener::Client::~Client):
+(WebCore::AudioHardwareListener::~AudioHardwareListener):
+(WebCore::AudioHardwareListener::isHardwareActive):
+* platform/audio/mac/AudioHardwareListenerMac.cpp: Added.
+(WebCore::isAudioHardwareProcessRunning):
+(WebCore::AudioHardwareListener::create):
+(WebCore::AudioHardwareListenerMac::create):
+(WebCore::AudioHardwareListenerMac::AudioHardwareListenerMac):
+(WebCore::AudioHardwareListenerMac::~AudioHardwareListenerMac):
+(WebCore::AudioHardwareListenerMac::setHardwareActive):
+* platform/audio/mac/AudioHardwareListenerMac.h: Added.
+
 2014-03-28  James Craig  
 
 Web Inspector: AXI: expose what elements get generic "clickable" status


Modified: trunk/Source/WebCore/WebCore.exp.in (166441 => 166442)

--- trunk/Source/WebCore/WebCore.exp.in	2014-03-29 01:15:44 UTC (rev 166441)
+++ trunk/Source/WebCore/WebCore.exp.in	2014-03-29 01:15:47 UTC (rev 166442)
@@ -849,6 +849,7 @@
 __ZN7WebCore20previousLinePositionERKNS_15VisiblePositionEiNS_12EditableTypeE
 __ZN7WebCore20protocolIsJavaScriptERKN3WTF6StringE
 __ZN7WebCore20toUInt32EnforceRangeEPN3JSC9ExecStateENS0_7JSValueE
+__ZN7WebCore21AudioHardwareListener6createERNS0_6ClientE
 __ZN7WebCore21BackForwardController11itemAtIndexEi
 __ZN7WebCore21BackForwardController6goBackEv
 __ZN7WebCore21BackForwardController9goForwardEv


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (166441 => 166442)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2014-03-29 01:15:44 UTC (rev 166441)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2014-03-29 01:15:47 UTC (rev 166442)
@@ -5505,6 +5505,10 @@
 		CD1E7347167BC78E009A885D /* TextTrackRepresentation.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CD1E7346167BC78E009A885D /* TextTrackRepresentation.cpp */; };
 		CD27F6E51457685A0078207D /* JSMediaController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CD27F6E2145767580078207D /* JSMediaController.cpp */; };
 		CD27F6E7145770D30078207D /* MediaController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CD27F6E6145770D30078207D /* MediaController.cpp */; };
+		CD2F4A2318D89F700063746D /* AudioHardwareListener.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CD2F4A2118D89F700063746D /* AudioHardwareListener.cpp */; };
+		CD2F4A2418D89F700063746D /* AudioHardwareListener.h in Headers */ = {isa

[webkit-changes] [166444] trunk/Source/WebKit2

2014-03-28 Thread slewis

Title: [166444] trunk/Source/WebKit2








Revision 166444
Author sle...@apple.com
Date 2014-03-28 18:15:50 -0700 (Fri, 28 Mar 2014)


Log Message
Don't prevent AppSleep from sync messages.
https://bugs.webkit.org/show_bug.cgi?id=130747.

Reviewed by Anders Carlsson.

We think sync messages only need to happen full throttle when the plugin is visible,
the user is interacting with the plugin, or audio is playing.  Since we already
take assertions for all these cases the assertion in sync messages doesn’t provide
any value.  Since it can keep the PluginProcess awake in other instances remove it.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveSyncMessage):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166443 => 166444)

--- trunk/Source/WebKit2/ChangeLog	2014-03-29 01:15:49 UTC (rev 166443)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-29 01:15:50 UTC (rev 166444)
@@ -1,5 +1,20 @@
 2014-03-28  Stephanie Lewis  
 
+Don't prevent AppSleep from sync messages.
+https://bugs.webkit.org/show_bug.cgi?id=130747.
+
+Reviewed by Anders Carlsson.
+
+We think sync messages only need to happen full throttle when the plugin is visible,
+the user is interacting with the plugin, or audio is playing.  Since we already
+take assertions for all these cases the assertion in sync messages doesn’t provide
+any value.  Since it can keep the PluginProcess awake in other instances remove it.
+
+* PluginProcess/WebProcessConnection.cpp:
+(WebKit::WebProcessConnection::didReceiveSyncMessage):
+
+2014-03-28  Stephanie Lewis  
+
 Stop waking up the web process in the background because of plugin activity.
 Part of  PluginProcess should AppNap when no plugins on active tab.
 


Modified: trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp (166443 => 166444)

--- trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp	2014-03-29 01:15:49 UTC (rev 166443)
+++ trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp	2014-03-29 01:15:50 UTC (rev 166444)
@@ -144,9 +144,6 @@
 
 void WebProcessConnection::didReceiveSyncMessage(IPC::Connection* connection, IPC::MessageDecoder& decoder, std::unique_ptr& replyEncoder)
 {
-// Force all timers to run at full speed when processing a synchronous message
-ActivityAssertion activityAssertion(PluginProcess::shared().connectionActivity());
-
 ConnectionStack::CurrentConnectionPusher currentConnection(ConnectionStack::shared(), connection);
 
 uint64_t destinationID = decoder.destinationID();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [157827] trunk/Tools

2013-10-22 Thread slewis

Title: [157827] trunk/Tools








Revision 157827
Author sle...@apple.com
Date 2013-10-22 16:55:02 -0700 (Tue, 22 Oct 2013)


Log Message
Update the build trigger list for Mavericks.

Unreviewed.

* BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py (157826 => 157827)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py	2013-10-22 23:32:24 UTC (rev 157826)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py	2013-10-22 23:55:02 UTC (rev 157827)
@@ -67,8 +67,9 @@
 ("mac", ["mac"]),
 ("mac-leopard", ["mac-leopard"]),
 ("mac-lion", ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]),
+("mac-mountainlion". ["mac-leopard", "mac-lion", "mac-mountainlion", "mac-snowleopard", "win"]},
 ("mac-snowleopard", ["mac-leopard", "mac-snowleopard"]),
-("mac-wk2", ["mac-lion", "mac-snowleopard", "mac-mountainlion", "win"]),
+("mac-wk2", ["mac-lion", "mac-snowleopard", "mac-mavericks", "mac-mountainlion", "win"]),
 ("objc", ["mac"]),
 ("qt", ["qt"]),
 ("soup", ["gtk"]),


Modified: trunk/Tools/ChangeLog (157826 => 157827)

--- trunk/Tools/ChangeLog	2013-10-22 23:32:24 UTC (rev 157826)
+++ trunk/Tools/ChangeLog	2013-10-22 23:55:02 UTC (rev 157827)
@@ -1,3 +1,12 @@
+2013-10-22  Stephanie Lewis  
+
+Update the build trigger list for Mavericks.
+
+Unreviewed.
+
+* BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
+(_should_file_trigger_build):
+
 2013-10-22  Simon Fraser  
 
 Add Mavericks bots to the dashboard.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [152932] trunk/LayoutTests

2013-07-19 Thread slewis

Title: [152932] trunk/LayoutTests








Revision 152932
Author sle...@apple.com
Date 2013-07-19 16:08:44 -0700 (Fri, 19 Jul 2013)


Log Message
Some compositing tests fail on ML WK2 Debugi
https://bugs.webkit.org/show_bug.cgi?id=118925

Unreviewed.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (152931 => 152932)

--- trunk/LayoutTests/ChangeLog	2013-07-19 22:46:04 UTC (rev 152931)
+++ trunk/LayoutTests/ChangeLog	2013-07-19 23:08:44 UTC (rev 152932)
@@ -1,3 +1,12 @@
+2013-07-19  Stephanie Lewis  
+
+Some compositing tests fail on ML WK2 Debugi
+https://bugs.webkit.org/show_bug.cgi?id=118925
+
+Unreviewed.
+
+* platform/mac-wk2/TestExpectations:
+
 2013-07-19  Roger Fong  
 
 Unreviewed. Skip failing tests to make WinEWS bots happy.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (152931 => 152932)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-07-19 22:46:04 UTC (rev 152931)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-07-19 23:08:44 UTC (rev 152932)
@@ -328,6 +328,26 @@
 webkit.org/b/118490 compositing/patterns/direct-pattern-compositing-size.html [ ImageOnlyFailure ]
 webkit.org/b/118490 compositing/patterns/direct-pattern-compositing.html [ ImageOnlyFailure ]
 
+webkit.org/b/118925 [ Debug ] compositing/background-color/background-color-alpha.html  [ ImageOnlyFailure ]  
+webkit.org/b/118925 [ Debug ] compositing/background-color/background-color-change-to-text.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] compositing/background-color/background-color-composite.html [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] compositing/background-color/background-color-container.html [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] compositing/background-color/background-color-content-clip.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] compositing/background-color/background-color-padding-clip.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] compositing/background-color/background-color-simple.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] compositing/background-color/background-color-text-change.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] compositing/backgrounds/fixed-background-on-descendant.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] compositing/backgrounds/fixed-backgrounds.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] compositing/overlap-blending/children-opacity-huge.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] compositing/overlap-blending/children-opacity-no-overlap.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] css3/filters/custom/effect-custom-transform-parameters.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] fast/layers/no-clipping-overflow-hidden-added-after-transition.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] fast/multicol/mixed-opacity-fixed-test.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] fast/regions/fixed-pos-elem-in-region.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] fast/repaint/region-painting-in-composited-view.html  [ ImageOnlyFailure ]
+webkit.org/b/118925 [ Debug ] svg/repaint/buffered-rendering-static-image.html  [ ImageOnlyFailure ]
+
 ### END OF (1) Classified failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [152936] trunk/Tools

2013-07-19 Thread slewis

Title: [152936] trunk/Tools








Revision 152936
Author sle...@apple.com
Date 2013-07-19 18:32:24 -0700 (Fri, 19 Jul 2013)


Log Message
 pagination wk2 api test failing on ML (118928)

Unreviewed.

Rebaseline pagination test after http://trac.webkit.org/changeset/152911

* TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
(TestWebKitAPI::didLayout):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp




Diff

Modified: trunk/Tools/ChangeLog (152935 => 152936)

--- trunk/Tools/ChangeLog	2013-07-20 00:58:36 UTC (rev 152935)
+++ trunk/Tools/ChangeLog	2013-07-20 01:32:24 UTC (rev 152936)
@@ -9,6 +9,17 @@
 * Scripts/generate-coverage-data: Added --no-build to run-_javascript_core-tests call.
 (generateReport): Moved report generation to a subroutine.
 
+2013-07-19  Stephanie Lewis  
+
+ pagination wk2 api test failing on ML (118928)
+
+Unreviewed.
+
+Rebaseline pagination test after http://trac.webkit.org/changeset/152911
+
+* TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
+(TestWebKitAPI::didLayout):
+
 2013-07-19  Daniel Bates  
 
 Make Perl tools work when using git bisect with Git branch build setup


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp (152935 => 152936)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp	2013-07-20 00:58:36 UTC (rev 152935)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp	2013-07-20 01:32:24 UTC (rev 152936)
@@ -50,7 +50,7 @@
 EXPECT_EQ(expectedPageCount, pageCount);
 
 webView->resizeTo((pageLength * pageCount) + (pageGap * (pageCount - 1)), 500);
-EXPECT_JS_EQ(page, "window.scrollX", "-3800");
+EXPECT_JS_EQ(page, "window.scrollX", "0");
 
 testDone = true;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [152873] trunk/LayoutTests

2013-07-18 Thread slewis

Title: [152873] trunk/LayoutTests








Revision 152873
Author sle...@apple.com
Date 2013-07-18 16:58:17 -0700 (Thu, 18 Jul 2013)


Log Message
Compositing pattern tests fail on Lion WK1 Debug.
https://bugs.webkit.org/show_bug.cgi?id=118870

Unreviewed.

Update Lion expectations after http://trac.webkit.org/changeset/152470

* platform/mac-lion/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-lion/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (152872 => 152873)

--- trunk/LayoutTests/ChangeLog	2013-07-18 23:32:25 UTC (rev 152872)
+++ trunk/LayoutTests/ChangeLog	2013-07-18 23:58:17 UTC (rev 152873)
@@ -237,6 +237,17 @@
 * transitions/transition-transform-translate-calculated-length-crash-expected.txt: Added.
 * transitions/transition-transform-translate-calculated-length-crash.html: Added.
 
+2013-07-18  Stephanie Lewis  
+
+Compositing pattern tests fail on Lion WK1 Debug.
+https://bugs.webkit.org/show_bug.cgi?id=118870
+
+Unreviewed.
+
+Update Lion expectations after http://trac.webkit.org/changeset/152470
+
+* platform/mac-lion/TestExpectations:
+
 2013-07-17  Stephanie Lewis  
 
 Skip crashing MathML tests while waiting for a fix for 


Modified: trunk/LayoutTests/platform/mac-lion/TestExpectations (152872 => 152873)

--- trunk/LayoutTests/platform/mac-lion/TestExpectations	2013-07-18 23:32:25 UTC (rev 152872)
+++ trunk/LayoutTests/platform/mac-lion/TestExpectations	2013-07-18 23:58:17 UTC (rev 152873)
@@ -148,3 +148,11 @@
 http/tests/cache/partitioned-cache-iframe.html
 
 webkit.org/b/118480 fast/text/international/synthesized-italic-vertical-latin.html [ Failure ]
+
+webkit.org/b/118870 [ Debug ] compositing/patterns/direct-pattern-compositing-add-text.html [ ImageOnlyFailure ]
+webkit.org/b/118870 [ Debug ] compositing/patterns/direct-pattern-compositing-contain.html [ ImageOnlyFailure ]
+webkit.org/b/118870 [ Debug ] compositing/patterns/direct-pattern-compositing-cover.html [ ImageOnlyFailure ]
+webkit.org/b/118870 [ Debug ] compositing/patterns/direct-pattern-compositing-padding.html [ ImageOnlyFailure ] 
+webkit.org/b/118870 [ Debug ] compositing/patterns/direct-pattern-compositing-position.html [ ImageOnlyFailure ]
+webkit.org/b/118870 [ Debug ] compositing/patterns/direct-pattern-compositing-size.html [ ImageOnlyFailure ]   
+webkit.org/b/118870 [ Debug ] compositing/patterns/direct-pattern-compositing.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [152822] trunk/LayoutTests

2013-07-17 Thread slewis

Title: [152822] trunk/LayoutTests








Revision 152822
Author sle...@apple.com
Date 2013-07-17 17:30:15 -0700 (Wed, 17 Jul 2013)


Log Message
Skip crashing MathML tests while waiting for a fix for
https://bugs.webkit.org/show_bug.cgi?id=118601

Unreviewed.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (152821 => 152822)

--- trunk/LayoutTests/ChangeLog	2013-07-18 00:23:41 UTC (rev 152821)
+++ trunk/LayoutTests/ChangeLog	2013-07-18 00:30:15 UTC (rev 152822)
@@ -1,3 +1,12 @@
+2013-07-17  Stephanie Lewis  
+
+Skip crashing MathML tests while waiting for a fix for 
+https://bugs.webkit.org/show_bug.cgi?id=118601
+
+Unreviewed.
+
+* platform/mac/TestExpectations:
+
 2013-07-17  Commit Queue  
 
 Unreviewed, rolling out r152701, r152703, r152739, r152754,


Modified: trunk/LayoutTests/platform/mac/TestExpectations (152821 => 152822)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-07-18 00:23:41 UTC (rev 152821)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-07-18 00:30:15 UTC (rev 152822)
@@ -1304,3 +1304,11 @@
 webkit.org/b/118479 fast/repaint/fixed-right-in-page-scale.html [ Pass Crash ]
 
 webkit.org/b/118820 fullscreen/full-screen-iframe-with-max-width-height.html [ Pass Failure ]
+
+webkit.org/b/118601 [ Debug ] mathml/presentation/bug95015.html [ Pass Crash ]
+webkit.org/b/118601 [ Debug ] mathml/presentation/scripts-width.html [ Pass Crash ]
+webkit.org/b/118601 [ Debug ] mathml/presentation/scripts-underover.html [ Pass Crash ]
+webkit.org/b/118601 [ Debug ] mathml/presentation/bug97990.html [ Pass Crash ]
+webkit.org/b/118601 [ Debug ] mathml/presentation/scripts-height.html [ Pass Crash ]
+webkit.org/b/118601 [ Debug ] mathml/presentation/scripts-mrow.html [ Pass Crash ]
+webkit.org/b/118601 [ Debug ] mathml/presentation/scripts-subsup.html [ Pass Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [152808] trunk/LayoutTests

2013-07-17 Thread slewis

Title: [152808] trunk/LayoutTests








Revision 152808
Author sle...@apple.com
Date 2013-07-17 16:02:44 -0700 (Wed, 17 Jul 2013)


Log Message
fullscreen/full-screen-iframe-with-max-width-height.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=118820

Unreviewed.

Label a flaky test as flaky

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (152807 => 152808)

--- trunk/LayoutTests/ChangeLog	2013-07-17 22:14:47 UTC (rev 152807)
+++ trunk/LayoutTests/ChangeLog	2013-07-17 23:02:44 UTC (rev 152808)
@@ -1,3 +1,14 @@
+2013-07-17  Stephanie Lewis  
+
+fullscreen/full-screen-iframe-with-max-width-height.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=118820
+
+Unreviewed.
+
+Label a flaky test as flaky
+
+* platform/mac/TestExpectations:
+
 2013-07-17  Roger Fong  
 
 Unreviewed gardening after r152800.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (152807 => 152808)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-07-17 22:14:47 UTC (rev 152807)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-07-17 23:02:44 UTC (rev 152808)
@@ -1299,3 +1299,5 @@
 webkit.org/b/118269 compositing/geometry/fixed-position-flipped-writing-mode.html
 
 webkit.org/b/118479 fast/repaint/fixed-right-in-page-scale.html [ Pass Crash ]
+
+webkit.org/b/118820 fullscreen/full-screen-iframe-with-max-width-height.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151040] trunk/Source

2013-05-31 Thread slewis

Title: [151040] trunk/Source








Revision 151040
Author sle...@apple.com
Date 2013-05-31 14:44:26 -0700 (Fri, 31 May 2013)


Log Message
Source/WebCore: Update low memory handler to use new memory pressure notifications on new OS versions.


Reviewed by Mark Rowe.

No change in functionality.

* WebCore.exp.in:
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install): Call new API
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac: Update low memory handler to use new memory pressure notifications on new OS versions.


Reviewed by Mark Rowe.

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2: Update low memory handler to use new memory pressure notifications on new OS versions.


Reviewed by Mark Rowe.

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm
trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h
trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (151039 => 151040)

--- trunk/Source/WebCore/ChangeLog	2013-05-31 21:40:33 UTC (rev 151039)
+++ trunk/Source/WebCore/ChangeLog	2013-05-31 21:44:26 UTC (rev 151040)
@@ -201,6 +201,21 @@
 * rendering/RenderTableSection.cpp:
 (WebCore::RenderTableSection::paintObject):
 
+2013-05-31  Stephanie Lewis  
+
+Update low memory handler to use new memory pressure notifications on new OS versions.
+
+
+Reviewed by Mark Rowe.
+
+No change in functionality.
+
+* WebCore.exp.in:
+* platform/mac/MemoryPressureHandlerMac.mm:
+(WebCore::MemoryPressureHandler::install): Call new API
+* platform/mac/WebCoreSystemInterface.h: 
+* platform/mac/WebCoreSystemInterface.mm:
+
 2013-05-30  Rafael Brandao  
 
 Fix double hash lookup in WebSocket::connect loop


Modified: trunk/Source/WebCore/WebCore.exp.in (151039 => 151040)

--- trunk/Source/WebCore/WebCore.exp.in	2013-05-31 21:40:33 UTC (rev 151039)
+++ trunk/Source/WebCore/WebCore.exp.in	2013-05-31 21:44:26 UTC (rev 151040)
@@ -2312,6 +2312,10 @@
 _wkRecommendedScrollerStyle
 #endif
 
+#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+_wkCreateMemoryStatusPressureCriticalDispatchOnMainQueue
+#endif
+
 #if USE(CONTENT_FILTERING)
 _wkFilterAddData
 _wkFilterCreateInstance


Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (151039 => 151040)

--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2013-05-31 21:40:33 UTC (rev 151039)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2013-05-31 21:44:26 UTC (rev 151040)
@@ -70,7 +70,11 @@
 return;
 
 dispatch_async(dispatch_get_main_queue(), ^{
+#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+_cache_event_source = wkCreateMemoryStatusPressureCriticalDispatchOnMainQueue();
+#else
 _cache_event_source = wkCreateVMPressureDispatchOnMainQueue();
+#endif
 if (_cache_event_source) {
 dispatch_set_context(_cache_event_source, this);
 dispatch_source_set_event_handler(_cache_event_source, ^{ memoryPressureHandler().respondToMemoryPressure();});


Modified: trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h (151039 => 151040)

--- trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h	2013-05-31 21:40:33 UTC (rev 151039)
+++ trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h	2013-05-31 21:44:26 UTC (rev 151040)
@@ -334,6 +334,10 @@
 
 #endif
 
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+extern dispatch_source_t (*wkCreateMemoryStatusPressureCriticalDispatchOnMainQueue)(void);
+#endif
+
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
 extern bool (*wkExecutableWasLinkedOnOrBeforeLion)(void);
 #endif


Modified: trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm (151039 => 151040)

--- trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm	2013-05-31 21:40:33 UTC (rev 151039)
+++ trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm	2013-05-31 21:44:26 UTC (rev 151040)
@@ -204,6 +204,10 @@
 dispatch_source_t (*wkCreateVMPressureDispatchOnMainQueue)(void);
 #endif
 
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+dispatch_source_t (*wkCreateMemoryStatusPressureCriticalDispatchOnMainQueue)(void);
+#endif
+
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
 bool (*wkExecutableWasLinkedOnOrBeforeLion)(void);
 #endif


Modified: trunk/Source/WebKit/mac/ChangeLog (151039 => 151040)

--- trunk/Source/WebKit/mac/ChangeLog	2013-05-31 21:40:33 UTC (rev 151039)
+++ trunk/Source/WebKit/mac/ChangeLog	2013-05

[webkit-changes] [149526] trunk/LayoutTests

2013-05-03 Thread slewis

Title: [149526] trunk/LayoutTests








Revision 149526
Author sle...@apple.com
Date 2013-05-03 11:26:47 -0700 (Fri, 03 May 2013)


Log Message
Revert to old results on Lion.

Unreviewed.

Results were updated in (http://trac.webkit.org/changeset/149503) but that is compiled
out on Lion (http://trac.webkit.org/changeset/149510).

* platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (149525 => 149526)

--- trunk/LayoutTests/ChangeLog	2013-05-03 18:08:58 UTC (rev 149525)
+++ trunk/LayoutTests/ChangeLog	2013-05-03 18:26:47 UTC (rev 149526)
@@ -1,3 +1,14 @@
+2013-05-03  Stephanie Lewis  
+
+Revert to old results on Lion.
+
+Unreviewed.
+
+Results were updated in (http://trac.webkit.org/changeset/149503) but that is compiled 
+out on Lion (http://trac.webkit.org/changeset/149510).
+
+* platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt: Added.
+
 2013-05-03  Joone Hur  
 
 Unreviewed EFL gardening.


Added: trunk/LayoutTests/platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt (0 => 149526)

--- trunk/LayoutTests/platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt	2013-05-03 18:26:47 UTC (rev 149526)
@@ -0,0 +1,25 @@
+Test that captions and subtitles menu items are localized.
+
+EVENT(canplaythrough)
+
+*** Set the user language preference.
+RUN(internals.setUserPreferredLanguages(['en']))
+Heading should be labelled 'Subtitles'
+EXPECTED (trackListSection.textContent == 'Subtitles') OK
+
+First item in captions menu should be labelled 'Off'
+EXPECTED (item.textContent == 'Off') OK
+
+Second item in captions menu should be labelled 'Automatic (English)'
+EXPECTED (item.textContent == 'Automatic (English)') OK
+
+Third item in captions menu should be labelled 'English CC'
+EXPECTED (item.textContent == 'English CC'), OBSERVED 'Laugh Track (English-United States)' FAIL
+
+Fourth item in captions menu should be labelled 'Laugh Track (English-United States)'
+EXPECTED (item.textContent == 'Laugh Track (English-United States)'), OBSERVED 'Unknown SDH' FAIL
+
+Fifth item in captions menu should be labelled 'Unknown SDH'
+TypeError: 'undefined' is not an object (evaluating 'item.textContent')
+END OF TEST
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [149481] trunk/LayoutTests

2013-05-01 Thread slewis

Title: [149481] trunk/LayoutTests








Revision 149481
Author sle...@apple.com
Date 2013-05-01 19:38:44 -0700 (Wed, 01 May 2013)


Log Message
Update Lion results after http://trac.webkit.org/projects/webkit/changeset/149474

Unreviewed.

* platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (149480 => 149481)

--- trunk/LayoutTests/ChangeLog	2013-05-02 02:10:25 UTC (rev 149480)
+++ trunk/LayoutTests/ChangeLog	2013-05-02 02:38:44 UTC (rev 149481)
@@ -1,3 +1,11 @@
+2013-05-01  Stephanie Lewis  
+
+Update Lion results after http://trac.webkit.org/projects/webkit/changeset/149474
+
+Unreviewed.
+
+* platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt: Added.
+
 2013-05-01  Enrica Casucci  
 
 text-combine: horizontal does not work properly for some fonts.


Added: trunk/LayoutTests/platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt (0 => 149481)

--- trunk/LayoutTests/platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt	2013-05-02 02:38:44 UTC (rev 149481)
@@ -0,0 +1,23 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 776x584
+  RenderBlock {P} at (0,0) size 18x584
+RenderText {#text} at (0,0) size 18x47
+  text run at (0,0) width 47: "Times: "
+RenderInline {SPAN} at (0,0) size 18x16
+  RenderCombineText {#text} at (0,47) size 18x16
+text run at (0,47) width 16: "\x{FFFC}"
+  RenderBlock {P} at (34,0) size 24x584
+RenderText {#text} at (3,0) size 17x171
+  text run at (3,0) width 171: "Hiragino Mincho Pro: "
+RenderInline {SPAN} at (0,0) size 17x17
+  RenderCombineText {#text} at (3,170) size 17x17
+text run at (3,170) width 16: "\x{FFFC}"
+  RenderBlock {P} at (74,0) size 16x584
+RenderText {#text} at (0,0) size 16x117
+  text run at (0,0) width 117: "STHeitiSC-Light: "
+RenderInline {SPAN} at (0,0) size 16x16
+  RenderCombineText {#text} at (0,117) size 16x16
+text run at (0,117) width 16: "\x{FFFC}"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139254] trunk/LayoutTests

2013-01-09 Thread slewis

Title: [139254] trunk/LayoutTests








Revision 139254
Author sle...@apple.com
Date 2013-01-09 16:32:26 -0800 (Wed, 09 Jan 2013)


Log Message
Rebaseline fast/inline/continuation-outlines-with-layers.html
https://bugs.webkit.org/show_bug.cgi?id=106064.

Unreviewed.

Rebaseline after http://trac.webkit.org/changeset/139223.

* platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (139253 => 139254)

--- trunk/LayoutTests/ChangeLog	2013-01-10 00:27:22 UTC (rev 139253)
+++ trunk/LayoutTests/ChangeLog	2013-01-10 00:32:26 UTC (rev 139254)
@@ -1,3 +1,14 @@
+2013-01-09  Stephanie Lewis  
+
+Rebaseline fast/inline/continuation-outlines-with-layers.html
+https://bugs.webkit.org/show_bug.cgi?id=106064.
+
+Unreviewed.
+
+Rebaseline after http://trac.webkit.org/changeset/139223. 
+
+* platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
+
 2013-01-09  Dimitri Glazkov  
 
 [Chromium] Ascribe a bug to a crash..


Modified: trunk/LayoutTests/platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt (139253 => 139254)

--- trunk/LayoutTests/platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt	2013-01-10 00:27:22 UTC (rev 139253)
+++ trunk/LayoutTests/platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt	2013-01-10 00:32:26 UTC (rev 139254)
@@ -6,55 +6,59 @@
   RenderBlock {DIV} at (0,0) size 784x18
 RenderText {#text} at (0,0) size 160x18
   text run at (0,0) width 160: "Outline ring painting test."
-  RenderBlock {DIV} at (0,34) size 784x94
+  RenderBlock {DIV} at (0,34) size 784x96
 RenderBlock (anonymous) at (0,0) size 784x18
-RenderBlock (anonymous) at (0,36) size 784x22
-  RenderBlock {H3} at (0,0) size 784x22
-RenderText {#text} at (0,0) size 150x22
-  text run at (0,0) width 150: "Bold with margin."
-RenderBlock (anonymous) at (0,76) size 784x18
-  RenderBlock {DIV} at (0,146) size 784x58
+RenderBlock (anonymous) at (0,77) size 784x19
+  RenderBlock {DIV} at (0,148) size 784x59
 RenderBlock (anonymous) at (0,0) size 784x0
-RenderBlock (anonymous) at (0,0) size 784x22
-  RenderBlock {H3} at (0,0) size 784x22
-RenderText {#text} at (0,0) size 150x22
-  text run at (0,0) width 150: "No content before."
-RenderBlock (anonymous) at (0,40) size 784x18
-  RenderBlock {DIV} at (0,220) size 784x58
+RenderBlock (anonymous) at (0,40) size 784x19
+  RenderBlock {DIV} at (0,222) size 784x60
 RenderBlock (anonymous) at (0,0) size 784x18
-RenderBlock (anonymous) at (0,36) size 784x22
-  RenderBlock {H3} at (0,0) size 784x22
-RenderText {#text} at (0,0) size 177x22
-  text run at (0,0) width 177: "But No Content After"
-RenderBlock (anonymous) at (0,76) size 784x0
-  RenderBlock {DIV} at (0,296) size 784x22
+RenderBlock (anonymous) at (0,77) size 784x1
+  RenderBlock {DIV} at (0,300) size 784x23
 RenderBlock (anonymous) at (0,0) size 784x0
-RenderBlock (anonymous) at (0,0) size 784x22
-  RenderBlock {H3} at (0,0) size 784x22
-RenderText {#text} at (0,0) size 216x22
-  text run at (0,0) width 216: "No content before or after."
-RenderBlock (anonymous) at (0,40) size 784x0
+RenderBlock (anonymous) at (0,40) size 784x1
 layer at (8,50) size 98x18
   RenderInline (relative positioned) {SPAN} at (0,0) size 98x18
 RenderText {#text} at (0,0) size 98x18
   text run at (0,0) width 98: "Content before."
-layer at (8,126) size 82x18
+layer at (8,87) size 784x22
+  RenderBlock (anonymous) at (0,36) size 784x23
+RenderBlock {H3} at (0,0) size 784x22
+  RenderText {#text} at (0,0) size 150x22
+text run at (0,0) width 150: "Bold with margin."
+layer at (8,127) size 82x18
   RenderInline (relative positioned) {SPAN} at (0,0) size 82x18
 RenderText {#text} at (0,0) size 82x18
   text run at (0,0) width 82: "Content after"
-layer at (8,162) size 0x0
+layer at (8,164) size 0x0
   RenderInline (relative positioned) {SPAN} at (0,0) size 0x0
-layer at (8,202) size 86x18
+layer at (8,164) size 784x22
+  RenderBlock (anonymous) at (0,0) size 784x22
+RenderBlock {H3} at (0,0) size 784x22
+  RenderText {#text} at (0,0) size 150x22
+text run at (0,0) width 150: "No content before."
+layer at (8,205) size 86x18
   RenderInline (relative positioned) {SPAN} at (0,0) size 86x18
 RenderText {#text} at (0,0) size 86x18
   text run at (0,0) width 86: "Content after."
-layer at (8,236) size 94x18
+layer at (8,239) size 94x18
   RenderInline (relative positioned) {SPAN} at (0,0) size 94x18

[webkit-changes] [139168] trunk/LayoutTests

2013-01-08 Thread slewis

Title: [139168] trunk/LayoutTests








Revision 139168
Author sle...@apple.com
Date 2013-01-08 23:12:00 -0800 (Tue, 08 Jan 2013)


Log Message
Assertion Failure in WebCore::RenderLayerCompositor::updateCompositingLayers.
https://bugs.webkit.org/show_bug.cgi?id=106419.

Unreviewed.

Updated Expectations.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139167 => 139168)

--- trunk/LayoutTests/ChangeLog	2013-01-09 07:09:02 UTC (rev 139167)
+++ trunk/LayoutTests/ChangeLog	2013-01-09 07:12:00 UTC (rev 139168)
@@ -1,3 +1,14 @@
+2013-01-08  Stephanie Lewis  
+
+Assertion Failure in WebCore::RenderLayerCompositor::updateCompositingLayers.
+https://bugs.webkit.org/show_bug.cgi?id=106419.
+
+Unreviewed.
+
+Updated Expectations.
+
+* platform/mac/TestExpectations:
+
 2013-01-08  Noel Gordon  
 
 [chromium] Unreviewed gardening. Update fast/events/touch/compositor-touch-hit-rects on linux


Modified: trunk/LayoutTests/platform/mac/TestExpectations (139167 => 139168)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-01-09 07:09:02 UTC (rev 139167)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-01-09 07:12:00 UTC (rev 139168)
@@ -1280,3 +1280,7 @@
 webkit.org/b/106415 fast/workers/worker-document-leak.html [ Pass Failure ]
 webkit.org/b/106415 fast/workers/worker-lifecycle.html [ Pass Failure ]
 
+webkit.org/b/106419 [ Debug ] dom/html/level2/html/HTMLDocument11.html [ Crash Failure ]
+webkit.org/b/106419 [ Debug ] dom/html/level2/html/HTMLDocument01.html [ Crash Failure ]
+webkit.org/b/106419 [ Debug ] dom/html/level2/html/HTMLBodyElement09.html [ Crash Failure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139160] trunk/LayoutTests

2013-01-08 Thread slewis

Title: [139160] trunk/LayoutTests








Revision 139160
Author sle...@apple.com
Date 2013-01-08 21:30:09 -0800 (Tue, 08 Jan 2013)


Log Message
A couple of fast/workers tests fail after http://trac.webkit.org/projects/webkit/changeset/139145.
https://bugs.webkit.org/show_bug.cgi?id=106415.

Unreviewed.

Updated Expectations.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139159 => 139160)

--- trunk/LayoutTests/ChangeLog	2013-01-09 05:26:12 UTC (rev 139159)
+++ trunk/LayoutTests/ChangeLog	2013-01-09 05:30:09 UTC (rev 139160)
@@ -1,5 +1,16 @@
 2013-01-08  Stephanie Lewis  
 
+A couple of fast/workers tests fail after http://trac.webkit.org/projects/webkit/changeset/139145.
+https://bugs.webkit.org/show_bug.cgi?id=106415.
+
+Unreviewed.
+
+Updated Expectations.
+
+* platform/mac/TestExpectations:
+
+2013-01-08  Stephanie Lewis  
+
 Assertion failure in WebCore::HTMLConstructionSite::HTMLConstructionSite.
 https://bugs.webkit.org/show_bug.cgi?id=106412.
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (139159 => 139160)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-01-09 05:26:12 UTC (rev 139159)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-01-09 05:30:09 UTC (rev 139160)
@@ -1276,4 +1276,7 @@
 webkit.org/b/106412 [ Debug ] editing/pasteboard/paste-noscript-xhtml.xhtml [ Crash ]
 webkit.org/b/106412 [ Debug ] editing/pasteboard/paste-xml.xhtml [ Crash ]
 
+webkit.org/b/106415 fast/workers/worker-close-more.html [ Pass Failure ]
+webkit.org/b/106415 fast/workers/worker-document-leak.html [ Pass Failure ]
+webkit.org/b/106415 fast/workers/worker-lifecycle.html [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139155] trunk/LayoutTests

2013-01-08 Thread slewis

Title: [139155] trunk/LayoutTests








Revision 139155
Author sle...@apple.com
Date 2013-01-08 21:01:16 -0800 (Tue, 08 Jan 2013)


Log Message
Assertion failure in WebCore::HTMLConstructionSite::HTMLConstructionSite.
https://bugs.webkit.org/show_bug.cgi?id=106412.

Unreviewed.

Updating Expectations.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139154 => 139155)

--- trunk/LayoutTests/ChangeLog	2013-01-09 04:46:50 UTC (rev 139154)
+++ trunk/LayoutTests/ChangeLog	2013-01-09 05:01:16 UTC (rev 139155)
@@ -1,3 +1,14 @@
+2013-01-08  Stephanie Lewis  
+
+Assertion failure in WebCore::HTMLConstructionSite::HTMLConstructionSite.
+https://bugs.webkit.org/show_bug.cgi?id=106412.
+
+Unreviewed.  
+
+Updating Expectations.
+
+* platform/mac/TestExpectations:
+
 2013-01-08  Matt Falkenhagen  
 
 Make NodeRenderingContext::parentRenderer and nextRenderer top layer aware


Modified: trunk/LayoutTests/platform/mac/TestExpectations (139154 => 139155)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-01-09 04:46:50 UTC (rev 139154)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-01-09 05:01:16 UTC (rev 139155)
@@ -1269,4 +1269,11 @@
 
 webkit.org/b/106361 [ Debug ] svg/custom/text-use-click-crash.xhtml [ Crash ]
 
-webkit.org/b/106318 fast/events/drag-and-drop-autoscroll.html [ Failure ]
\ No newline at end of file
+webkit.org/b/106318 fast/events/drag-and-drop-autoscroll.html [ Failure ]
+
+webkit.org/b/106412 [ Debug ] editing/style/justify-without-enclosing-block.xhtml [ Crash ]
+webkit.org/b/106412 [ Debug ] editing/execCommand/insert-list-xml.xhtml [ Crash ]
+webkit.org/b/106412 [ Debug ] editing/pasteboard/paste-noscript-xhtml.xhtml [ Crash ]
+webkit.org/b/106412 [ Debug ] editing/pasteboard/paste-xml.xhtml [ Crash ]
+
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132709] trunk/Source/WebKit2

2012-10-26 Thread slewis

Title: [132709] trunk/Source/WebKit2








Revision 132709
Author sle...@apple.com
Date 2012-10-26 16:21:25 -0700 (Fri, 26 Oct 2012)


Log Message
Add pids to WebMemorySampleFiles.
https://bugs.webkit.org/show_bug.cgi?id=100449.

Reviewed by Tim Horton.

Make it easier to associate WebMemorySamples with a process.  Add the pid to the filename and header.

* Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::initializeTimers): Update notification.
(WebKit::WebMemorySampler::stop): Update notification.
(WebKit::WebMemorySampler::writeHeaders): dump pid in the header.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::processDidFinishLaunching): append pid to filename.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebMemorySampler.cpp
trunk/Source/WebKit2/UIProcess/WebContext.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (132708 => 132709)

--- trunk/Source/WebKit2/ChangeLog	2012-10-26 23:03:27 UTC (rev 132708)
+++ trunk/Source/WebKit2/ChangeLog	2012-10-26 23:21:25 UTC (rev 132709)
@@ -1,3 +1,19 @@
+2012-10-26  Stephanie Lewis  
+
+Add pids to WebMemorySampleFiles.
+https://bugs.webkit.org/show_bug.cgi?id=100449.
+
+Reviewed by Tim Horton.
+
+Make it easier to associate WebMemorySamples with a process.  Add the pid to the filename and header.
+
+* Shared/WebMemorySampler.cpp:
+(WebKit::WebMemorySampler::initializeTimers): Update notification.
+(WebKit::WebMemorySampler::stop): Update notification.
+(WebKit::WebMemorySampler::writeHeaders): dump pid in the header.
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::processDidFinishLaunching): append pid to filename.
+
 2012-10-26  Yael Aharon  
 
 [EFL][WK2][AC] Build fix after r132647.


Modified: trunk/Source/WebKit2/Shared/WebMemorySampler.cpp (132708 => 132709)

--- trunk/Source/WebKit2/Shared/WebMemorySampler.cpp	2012-10-26 23:03:27 UTC (rev 132708)
+++ trunk/Source/WebKit2/Shared/WebMemorySampler.cpp	2012-10-26 23:21:25 UTC (rev 132709)
@@ -82,7 +82,7 @@
 void WebMemorySampler::initializeTimers(double interval)
 {
 m_sampleTimer.startRepeating(1);
-printf("Started memory sampler for process %s", processName().utf8().data());
+printf("Started memory sampler for process %s %d", processName().utf8().data(), getpid());
 if (interval > 0) {
 m_stopTimer.startOneShot(interval);
 printf(" for a interval of %g seconds", interval);
@@ -98,7 +98,7 @@
 return;
 m_sampleTimer.stop();
 m_sampleLogFile = 0;
-printf("Stopped memory sampler for process %s\n", processName().utf8().data());
+printf("Stopped memory sampler for process %s %d\n", processName().utf8().data(), getpid());
 // Flush stdout buffer so python script can be guaranteed to read up to this point.
 fflush(stdout);
 m_isRunning = false;
@@ -135,7 +135,7 @@
 
 void WebMemorySampler::writeHeaders()
 {
-String processDetails = "Process: " + processName() + '\n';
+String processDetails = String::format("Process: %s Pid: %d\n", processName().utf8().data(), getpid());
 
 CString utf8String = processDetails.utf8();
 writeToFile(m_sampleLogFile, utf8String.data(), utf8String.length());


Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (132708 => 132709)

--- trunk/Source/WebKit2/UIProcess/WebContext.cpp	2012-10-26 23:03:27 UTC (rev 132708)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp	2012-10-26 23:21:25 UTC (rev 132709)
@@ -497,7 +497,7 @@
 if (m_memorySamplerEnabled) {
 SandboxExtension::Handle sampleLogSandboxHandle;
 double now = WTF::currentTime();
-String sampleLogFilePath = String::format("WebProcess%llu", static_cast(now));
+String sampleLogFilePath = String::format("WebProcess%llupid%d", static_cast(now), process->processIdentifier());
 sampleLogFilePath = SandboxExtension::createHandleForTemporaryFile(sampleLogFilePath, SandboxExtension::WriteOnly, sampleLogSandboxHandle);
 
 process->send(Messages::WebProcess::StartMemorySampler(sampleLogSandboxHandle, sampleLogFilePath, m_memorySamplerInterval), 0);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128864] trunk/Tools

2012-09-18 Thread slewis

Title: [128864] trunk/Tools








Revision 128864
Author sle...@apple.com
Date 2012-09-18 02:11:01 -0700 (Tue, 18 Sep 2012)


Log Message
Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.

Unreviewed.

* DumpRenderTree/mac/DumpRenderTree.mm:
(poseAsClass):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm




Diff

Modified: trunk/Tools/ChangeLog (128863 => 128864)

--- trunk/Tools/ChangeLog	2012-09-18 08:58:53 UTC (rev 128863)
+++ trunk/Tools/ChangeLog	2012-09-18 09:11:01 UTC (rev 128864)
@@ -1,3 +1,12 @@
+2012-09-18  Stephanie Lewis  
+
+Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
+
+Unreviewed.
+
+* DumpRenderTree/mac/DumpRenderTree.mm:
+(poseAsClass):
+
 2012-09-18  Allan Sandfeld Jensen  
 
 Unreviewed update of email addresses for Berlin QtWebKit office.


Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (128863 => 128864)

--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2012-09-18 08:58:53 UTC (rev 128863)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2012-09-18 09:11:01 UTC (rev 128864)
@@ -153,7 +153,7 @@
 
 static WebHistoryItem *prevTestBFItem = nil;  // current b/f item at the end of the previous test
 
-#if __OBJC2__
+#ifdef __OBJC2__
 static void swizzleAllMethods(Class imposter, Class original)
 {
 unsigned int imposterMethodCount;
@@ -192,7 +192,7 @@
 Class imposterClass = objc_getClass(imposter);
 Class originalClass = objc_getClass(original);
 
-#if !__OBJC2__
+#ifndef __OBJC2__
 class_poseAs(imposterClass, originalClass);
 #else
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128843] trunk/LayoutTests

2012-09-17 Thread slewis

Title: [128843] trunk/LayoutTests








Revision 128843
Author sle...@apple.com
Date 2012-09-17 19:55:06 -0700 (Mon, 17 Sep 2012)


Log Message
Rebaseline after http://trac.webkit.org/projects/webkit/changeset/128837.

Unreviewed.

* http/tests/xmlviewer/dumpAsText/mathml-expected.txt:
* platform/mac/accessibility/math-alttext-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/xmlviewer/dumpAsText/mathml-expected.txt
trunk/LayoutTests/platform/mac/accessibility/math-alttext-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (128842 => 128843)

--- trunk/LayoutTests/ChangeLog	2012-09-18 02:25:35 UTC (rev 128842)
+++ trunk/LayoutTests/ChangeLog	2012-09-18 02:55:06 UTC (rev 128843)
@@ -1,3 +1,12 @@
+2012-09-17  Stephanie Lewis  
+
+Rebaseline after http://trac.webkit.org/projects/webkit/changeset/128837.
+
+Unreviewed.
+
+* http/tests/xmlviewer/dumpAsText/mathml-expected.txt:
+* platform/mac/accessibility/math-alttext-expected.txt:
+
 2012-09-17  Shinya Kawanaka   
 
 Unreviewed gardening, more rebaseline after r128811


Modified: trunk/LayoutTests/http/tests/xmlviewer/dumpAsText/mathml-expected.txt (128842 => 128843)

--- trunk/LayoutTests/http/tests/xmlviewer/dumpAsText/mathml-expected.txt	2012-09-18 02:25:35 UTC (rev 128842)
+++ trunk/LayoutTests/http/tests/xmlviewer/dumpAsText/mathml-expected.txt	2012-09-18 02:55:06 UTC (rev 128843)
@@ -1 +1,3 @@
-This tests that xml viewer is not used when there is a tag in MATHML namespace. SUCCESS
+This tests that xml viewer is not used when there is a tag in MATHML namespace. 
+SUCCESS
+


Modified: trunk/LayoutTests/platform/mac/accessibility/math-alttext-expected.txt (128842 => 128843)

--- trunk/LayoutTests/platform/mac/accessibility/math-alttext-expected.txt	2012-09-18 02:25:35 UTC (rev 128842)
+++ trunk/LayoutTests/platform/mac/accessibility/math-alttext-expected.txt	2012-09-18 02:55:06 UTC (rev 128843)
@@ -1,4 +1,10 @@
-Fe1xCoxSb2
+Fe
+1
+x
+Co
+x
+Sb
+2
 This tests that a math element will be exposed like an ARIA math element.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128664] trunk/LayoutTests

2012-09-14 Thread slewis

Title: [128664] trunk/LayoutTests








Revision 128664
Author sle...@apple.com
Date 2012-09-14 15:49:51 -0700 (Fri, 14 Sep 2012)


Log Message
new fast/loader tests from r128645 fail on Mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=96832.

Unreviewed.

Update TestExpectations

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128663 => 128664)

--- trunk/LayoutTests/ChangeLog	2012-09-14 22:49:38 UTC (rev 128663)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 22:49:51 UTC (rev 128664)
@@ -1,3 +1,14 @@
+2012-09-14  Stephanie Lewis  
+
+new fast/loader tests from r128645 fail on Mac-wk2.
+https://bugs.webkit.org/show_bug.cgi?id=96832.
+
+Unreviewed.
+
+Update TestExpectations
+
+* platform/mac-wk2/TestExpectations:
+
 2012-09-14  Ojan Vafai  
 
 Add expectations for tests that depend on other tests running before them.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (128663 => 128664)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-14 22:49:38 UTC (rev 128663)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-14 22:49:51 UTC (rev 128664)
@@ -9,3 +9,6 @@
 // WK2 tests fail image diff
 BUGWK96580 : css3/filters/custom/filter-fallback-to-software.html = IMAGE
 
+// new fast/load tests fail https://bugs.webkit.org/show_bug.cgi?id=96832
+BUGWK96832 : fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html = TEXT
+BUGWK96832 : fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128662] trunk/Tools

2012-09-14 Thread slewis

Title: [128662] trunk/Tools








Revision 128662
Author sle...@apple.com
Date 2012-09-14 15:48:12 -0700 (Fri, 14 Sep 2012)


Log Message
mac-future ignores previous platform TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=96718.

Reviewed by Dirk Pranke.

TestExpectations match an expectation's configuraton against a list of configurations that are
valid for that port.  That list does not contain mac-future so none of the expectations can be
applied.

* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort._generate_all_test_configurations):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py




Diff

Modified: trunk/Tools/ChangeLog (128661 => 128662)

--- trunk/Tools/ChangeLog	2012-09-14 22:47:47 UTC (rev 128661)
+++ trunk/Tools/ChangeLog	2012-09-14 22:48:12 UTC (rev 128662)
@@ -1,3 +1,17 @@
+2012-09-13  Stephanie Lewis  
+
+mac-future ignores previous platform TestExpectations.
+https://bugs.webkit.org/show_bug.cgi?id=96718.
+
+Reviewed by Dirk Pranke.
+
+TestExpectations match an expectation's configuraton against a list of configurations that are 
+valid for that port.  That list does not contain mac-future so none of the expectations can be
+applied.
+
+* Scripts/webkitpy/layout_tests/port/apple.py:
+(ApplePort._generate_all_test_configurations):
+
 2012-09-14  Adam Barth  
 
 Remove webkitPostMessage


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py (128661 => 128662)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py	2012-09-14 22:47:47 UTC (rev 128661)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py	2012-09-14 22:48:12 UTC (rev 128662)
@@ -92,7 +92,8 @@
 
 def _generate_all_test_configurations(self):
 configurations = []
-for port_name in self.VERSION_FALLBACK_ORDER:
+allowed_port_names = self.VERSION_FALLBACK_ORDER + [self.operating_system() + "-future"]
+for port_name in allowed_port_names:
 for build_type in self.ALL_BUILD_TYPES:
 for architecture in self.ARCHITECTURES:
 configurations.append(TestConfiguration(version=self._strip_port_name_prefix(port_name), architecture=architecture, build_type=build_type))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128412] trunk/LayoutTests

2012-09-13 Thread slewis

Title: [128412] trunk/LayoutTests








Revision 128412
Author sle...@apple.com
Date 2012-09-13 00:19:47 -0700 (Thu, 13 Sep 2012)


Log Message
fast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chromium-Mac, GTK, EFL.
https://bugs.webkit.org/show_bug.cgi?id=96594.

Unreviewed.

Update TestExpectations.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128411 => 128412)

--- trunk/LayoutTests/ChangeLog	2012-09-13 07:16:08 UTC (rev 128411)
+++ trunk/LayoutTests/ChangeLog	2012-09-13 07:19:47 UTC (rev 128412)
@@ -1,3 +1,14 @@
+2012-09-13  Stephanie Lewis  
+
+fast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chromium-Mac, GTK, EFL.
+https://bugs.webkit.org/show_bug.cgi?id=96594.
+
+Unreviewed.
+
+Update TestExpectations.
+
+* platform/mac/TestExpectations:
+
 2012-09-12  Kent Tamura  
 
 [Chromium] Test expectation update


Modified: trunk/LayoutTests/platform/mac/TestExpectations (128411 => 128412)

--- trunk/LayoutTests/platform/mac/TestExpectations	2012-09-13 07:16:08 UTC (rev 128411)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2012-09-13 07:19:47 UTC (rev 128412)
@@ -355,3 +355,6 @@
 // (r128375) new test fails on Mac
 BUGWK96583 : fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html = TEXT
 
+// New test added in r128389
+BUGWK96594 : fast/table/bad-replaced-sizing-preferred-logical-widths.html = TEXT
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128406] trunk/LayoutTests

2012-09-12 Thread slewis

Title: [128406] trunk/LayoutTests








Revision 128406
Author sle...@apple.com
Date 2012-09-12 23:44:40 -0700 (Wed, 12 Sep 2012)


Log Message
css3/filters/custom/filter-fallback-to-software.html fails.
https://bugs.webkit.org/show_bug.cgi?id=94372.

Unreviewed.

Update TestExpectations.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128405 => 128406)

--- trunk/LayoutTests/ChangeLog	2012-09-13 05:54:31 UTC (rev 128405)
+++ trunk/LayoutTests/ChangeLog	2012-09-13 06:44:40 UTC (rev 128406)
@@ -1,3 +1,14 @@
+2012-09-12  Stephanie Lewis  
+
+css3/filters/custom/filter-fallback-to-software.html fails.
+https://bugs.webkit.org/show_bug.cgi?id=94372.
+
+Unreviewed.
+
+Update TestExpectations.
+
+* platform/mac-wk2/TestExpectations:
+
 2012-09-12  Yoshifumi Inoue  
 
 New time input needs accessibility


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (128405 => 128406)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-13 05:54:31 UTC (rev 128405)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-13 06:44:40 UTC (rev 128406)
@@ -6,6 +6,6 @@
 
 BUGWK96652 : fast/events/dispatch-message-string-data.html = TEXT
 
-// Debug WK2 tests fail image diff
-BUGWK96580 DEBUG : css3/filters/custom/filter-fallback-to-software.html = IMAGE
+// WK2 tests fail image diff
+BUGWK96580 : css3/filters/custom/filter-fallback-to-software.html = IMAGE
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128396] trunk/LayoutTests

2012-09-12 Thread slewis

Title: [128396] trunk/LayoutTests








Revision 128396
Author sle...@apple.com
Date 2012-09-12 19:20:24 -0700 (Wed, 12 Sep 2012)


Log Message
fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html fails on Mac.
https://bugs.webkit.org/show_bug.cgi?id=96583

Unreviewed.

Update TestExpectations

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128395 => 128396)

--- trunk/LayoutTests/ChangeLog	2012-09-13 02:13:06 UTC (rev 128395)
+++ trunk/LayoutTests/ChangeLog	2012-09-13 02:20:24 UTC (rev 128396)
@@ -1,3 +1,14 @@
+2012-09-12  Stephanie Lewis  
+
+fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html fails on Mac.
+https://bugs.webkit.org/show_bug.cgi?id=96583
+
+Unreviewed.
+
+Update TestExpectations
+
+* platform/mac/TestExpectations:
+
 2012-09-12  Kangil Han  
 
 [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (128395 => 128396)

--- trunk/LayoutTests/platform/mac/TestExpectations	2012-09-13 02:13:06 UTC (rev 128395)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2012-09-13 02:20:24 UTC (rev 128396)
@@ -352,3 +352,6 @@
 
 BUGWK95501 SKIP : http/tests/security/inactive-document-with-empty-security-origin.html = TIMEOUT
 
+// (r128375) new test fails on Mac
+BUGWK96583 : fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html = TEXT
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128392] trunk/LayoutTests

2012-09-12 Thread slewis

Title: [128392] trunk/LayoutTests








Revision 128392
Author sle...@apple.com
Date 2012-09-12 17:52:59 -0700 (Wed, 12 Sep 2012)


Log Message
css3/filters/custom/filter-fallback-to-software.html fails on Debug WK2.
https://bugs.webkit.org/show_bug.cgi?id=94372.

Unreviewed.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128391 => 128392)

--- trunk/LayoutTests/ChangeLog	2012-09-13 00:49:47 UTC (rev 128391)
+++ trunk/LayoutTests/ChangeLog	2012-09-13 00:52:59 UTC (rev 128392)
@@ -1,3 +1,12 @@
+2012-09-12  Stephanie Lewis  
+
+css3/filters/custom/filter-fallback-to-software.html fails on Debug WK2.
+https://bugs.webkit.org/show_bug.cgi?id=94372.
+
+Unreviewed.
+
+* platform/mac-wk2/TestExpectations:
+
 2012-09-12  Julien Chaffraix  
 
 REGRESSION(r122501): replaced elements with percent width are wrongly size when inserted inside an auto-table layout


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (128391 => 128392)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-13 00:49:47 UTC (rev 128391)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-13 00:52:59 UTC (rev 128392)
@@ -6,3 +6,6 @@
 
 BUGWK96652 : fast/events/dispatch-message-string-data.html = TEXT
 
+// Debug WK2 tests fail image diff
+BUGWK96580 DEBUG : css3/filters/custom/filter-fallback-to-software.html = IMAGE
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128391] trunk/Tools

2012-09-12 Thread slewis

Title: [128391] trunk/Tools








Revision 128391
Author sle...@apple.com
Date 2012-09-12 17:49:47 -0700 (Wed, 12 Sep 2012)


Log Message
Reduce parallism on the wk2 testers.
https://bugs.webkit.org/show_bug.cgi?id=95906

Reviewed by Dirk Pranke.

The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
resource contention.  Reducing the number of processes alleviates the issue.

Starting by reducing 25%.

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_child_processes):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py




Diff

Modified: trunk/Tools/ChangeLog (128390 => 128391)

--- trunk/Tools/ChangeLog	2012-09-13 00:43:18 UTC (rev 128390)
+++ trunk/Tools/ChangeLog	2012-09-13 00:49:47 UTC (rev 128391)
@@ -1,3 +1,18 @@
+2012-09-12  Stephanie Lewis  
+
+Reduce parallism on the wk2 testers.
+https://bugs.webkit.org/show_bug.cgi?id=95906
+
+Reviewed by Dirk Pranke.
+
+The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
+resource contention.  Reducing the number of processes alleviates the issue.  
+
+Starting by reducing 25%.
+
+* Scripts/webkitpy/layout_tests/port/mac.py:
+(MacPort.default_child_processes):
+
 2012-09-12  Brady Eidson  
 
 Assert in NetscapePlugin::destroy() with async plugin init


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (128390 => 128391)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py	2012-09-13 00:43:18 UTC (rev 128390)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py	2012-09-13 00:49:47 UTC (rev 128391)
@@ -115,6 +115,12 @@
 
 default_count = super(MacPort, self).default_child_processes()
 
+# FIXME: https://bugs.webkit.org/show_bug.cgi?id=95906  With too many WebProcess WK2 tests get stuck in resource contention.
+# To alleviate the issue reduce the number of running processes
+# Anecdotal evidence suggests that a 4 core/8 core logical machine may run into this, but that a 2 core/4 core logical machine does not.
+if self.get_option('webkit_test_runner') and default_count > 4:
+default_count = int(.75 * default_count)
+
 # Make sure we have enough ram to support that many instances:
 total_memory = self.host.platform.total_bytes_memory()
 bytes_per_drt = 256 * 1024 * 1024  # Assume each DRT needs 256MB to run.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128365] trunk/LayoutTests

2012-09-12 Thread slewis

Title: [128365] trunk/LayoutTests








Revision 128365
Author sle...@apple.com
Date 2012-09-12 14:58:48 -0700 (Wed, 12 Sep 2012)


Log Message
fast/events/dispatch-message-string-data.html fails on mac wk2
https://bugs.webkit.org/show_bug.cgi?id=96552

Unreviewed.

Add to TestExpectations.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128364 => 128365)

--- trunk/LayoutTests/ChangeLog	2012-09-12 21:49:09 UTC (rev 128364)
+++ trunk/LayoutTests/ChangeLog	2012-09-12 21:58:48 UTC (rev 128365)
@@ -1,3 +1,14 @@
+2012-09-12  Stephanie Lewis  
+
+fast/events/dispatch-message-string-data.html fails on mac wk2
+https://bugs.webkit.org/show_bug.cgi?id=96552
+
+Unreviewed.
+
+Add to TestExpectations.
+
+* platform/mac-wk2/TestExpectations:
+
 2012-09-12  Levi Weintraub  
 
 More unreviewed gardening after r128346.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (128364 => 128365)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-12 21:49:09 UTC (rev 128364)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-12 21:58:48 UTC (rev 128365)
@@ -4,3 +4,5 @@
 // All spatial navigation tests fail on Mac WK2
 BUGWK96438 SKIP : fast/spatial-navigation = PASS
 
+BUGWK96652 : fast/events/dispatch-message-string-data.html = TEXT
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128240] trunk/LayoutTests

2012-09-11 Thread slewis

Title: [128240] trunk/LayoutTests








Revision 128240
Author sle...@apple.com
Date 2012-09-11 16:31:22 -0700 (Tue, 11 Sep 2012)


Log Message
Skip spatial-navigation tests on mac-wk2 because they are all failing.
https://bugs.webkit.org/show_bug.cgi?id=96438.

Unreviewed.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128239 => 128240)

--- trunk/LayoutTests/ChangeLog	2012-09-11 23:26:12 UTC (rev 128239)
+++ trunk/LayoutTests/ChangeLog	2012-09-11 23:31:22 UTC (rev 128240)
@@ -1,3 +1,12 @@
+2012-09-11  Stephanie Lewis  
+
+Skip spatial-navigation tests on mac-wk2 because they are all failing.
+https://bugs.webkit.org/show_bug.cgi?id=96438.
+
+Unreviewed.
+
+* platform/mac-wk2/TestExpectations:
+
 2012-09-11  Adam Klein  
 
 Unreviewed, rolling out r128075


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (128239 => 128240)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-11 23:26:12 UTC (rev 128239)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-11 23:31:22 UTC (rev 128240)
@@ -1,2 +1,6 @@
 // This file should contain entries for expectations that are specific
 // to the Apple Mac port running the WebKit2 variant (--webkit-test-runner)
+
+// All spatial navigation tests fail on Mac WK2
+BUGWK96438 SKIP : fast/spatial-navigation = PASS
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [126013] trunk/Tools

2012-08-20 Thread slewis

Title: [126013] trunk/Tools








Revision 126013
Author sle...@apple.com
Date 2012-08-20 02:29:16 -0700 (Mon, 20 Aug 2012)


Log Message
Add mountain lion to build config.
https://bugs.webkit.org/show_bug.cgi?id=94441

Reviewed by Adam Barth.

Add Mountain Lion to the build trigger configurations.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build):
* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest):
(ShouldBuildTest.test_should_build):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/build.py
trunk/Tools/Scripts/webkitpy/common/config/build_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (126012 => 126013)

--- trunk/Tools/ChangeLog	2012-08-20 09:27:22 UTC (rev 126012)
+++ trunk/Tools/ChangeLog	2012-08-20 09:29:16 UTC (rev 126013)
@@ -1,3 +1,18 @@
+2012-08-19  Stephanie Lewis  
+
+Add mountain lion to build config.
+https://bugs.webkit.org/show_bug.cgi?id=94441
+
+Reviewed by Adam Barth.
+
+Add Mountain Lion to the build trigger configurations.
+
+* Scripts/webkitpy/common/config/build.py:
+(_should_file_trigger_build):
+* Scripts/webkitpy/common/config/build_unittest.py:
+(ShouldBuildTest):
+(ShouldBuildTest.test_should_build):
+
 2012-08-17  Kiran Muppala  
 
 Add self to webkit contributors list


Modified: trunk/Tools/Scripts/webkitpy/common/config/build.py (126012 => 126013)

--- trunk/Tools/Scripts/webkitpy/common/config/build.py	2012-08-20 09:27:22 UTC (rev 126012)
+++ trunk/Tools/Scripts/webkitpy/common/config/build.py	2012-08-20 09:29:16 UTC (rev 126013)
@@ -37,7 +37,7 @@
 # and start using it for their bots. Someone familiar with each platform
 # will have to figure out what the right set of directories/patterns is for
 # that platform.
-assert(target_platform in ("mac-leopard", "mac-lion", "mac-snowleopard", "win"))
+assert(target_platform in ("mac-leopard", "mac-lion", "mac-mountainlion", "mac-snowleopard", "win"))
 
 directories = [
 # Directories that shouldn't trigger builds on any bots.
@@ -68,9 +68,9 @@
 ("gtk", ["gtk"]),
 ("mac", ["chromium-mac", "mac"]),
 ("mac-leopard", ["mac-leopard"]),
-("mac-lion", ["mac", "win"]),
+("mac-lion", ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]),
 ("mac-snowleopard", ["mac-leopard", "mac-snowleopard"]),
-("mac-wk2", ["mac-lion", "mac-snowleopard", "win"]),
+("mac-wk2", ["mac-lion", "mac-snowleopard", "mac-mountainlion", "win"]),
 ("objc", ["mac"]),
 ("qt", ["qt"]),
 ("skia", ["chromium"]),


Modified: trunk/Tools/Scripts/webkitpy/common/config/build_unittest.py (126012 => 126013)

--- trunk/Tools/Scripts/webkitpy/common/config/build_unittest.py	2012-08-20 09:27:22 UTC (rev 126012)
+++ trunk/Tools/Scripts/webkitpy/common/config/build_unittest.py	2012-08-20 09:29:16 UTC (rev 126013)
@@ -31,7 +31,7 @@
 (["GNUmakefile.am", "Source/WebCore/GNUmakefile.am"], ["gtk"]),
 (["Websites/bugs.webkit.org/foo", "Source/WebCore/bar"], ["*"]),
 (["Websites/bugs.webkit.org/foo"], []),
-(["Source/_javascript_Core/_javascript_Core.xcodeproj/foo"], ["mac-leopard", "mac-lion", "mac-snowleopard"]),
+(["Source/_javascript_Core/_javascript_Core.xcodeproj/foo"], ["mac-leopard", "mac-lion",  "mac-mountainlion", "mac-snowleopard"]),
 (["Source/_javascript_Core/_javascript_Core.vcproj/foo", "Source/WebKit2/win/WebKit2.vcproj", "Source/WebKit/win/WebKit.sln", "Tools/WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops"], ["win"]),
 (["LayoutTests/platform/mac/foo", "Source/WebCore/bar"], ["*"]),
 (["LayoutTests/foo"], ["*"]),
@@ -41,17 +41,17 @@
 (["LayoutTests/platform/mac-leopard/foo"], ["mac-leopard"]),
 (["LayoutTests/platform/mac-lion/foo"], ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]),
 (["LayoutTests/platform/mac-snowleopard/foo"], ["mac-leopard", "mac-snowleopard"]),
-(["LayoutTests/platform/mac-wk2/Skipped"], ["mac-lion", "mac-snowleopard", "win"]),
-(["LayoutTests/platform/mac/foo"], ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]),
+(["LayoutTests/platform/mac-wk2/Skipped"], ["mac-lion",  "mac-mountainlion", "mac-snowleopard", "win"]),
+(["LayoutTests/platform/mac/foo"], ["mac-leopard", "mac-lion", "mac-mountainlion", "mac-snowleopard", "win"]),
 (["LayoutTests/platform/win-xp/foo"], ["win"]),
 (["LayoutTests/platform/win-wk2/foo"], ["win"]),
 (["LayoutTests/platform/win/foo"], ["win"]),
-(["Source/WebCore.exp.in", "Source/WebKit/mac/WebKit.exp"], ["mac-leopard", "mac-lion", "mac-snowleopard"]),
-(["Source/WebCore/mac/foo"], ["chromium-mac", "mac-leopard", "mac-lion", "mac-snowleopard"]),
+(["Source/WebCore.exp.in", "Source/WebKit/mac/WebKit.exp"], ["mac-leopard", "mac-lion",  "mac-mountainlion",

[webkit-changes] [119546] trunk/Source

2012-06-05 Thread slewis

Title: [119546] trunk/Source








Revision 119546
Author sle...@apple.com
Date 2012-06-05 18:37:09 -0700 (Tue, 05 Jun 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=88370
Memory sampler should trigger low memory signal

Reviewed by Geoff Garen.

Source/WebCore:

No new tests. Verify by running stress test which crashes
in a few minutes without the fix.

Fix assumption in block code.  We could get in a state where timer_event_source
had already been released before the block ran.

* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::holdOff):

Source/WebKit2:

Send low memory signal when running the memory sampler.  We'd
like to test memory that cannot be freed.

* Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::sampleTimerFired):
* Shared/WebMemorySampler.h:
(WebMemorySampler):
* Shared/mac/WebMemorySampler.mac.mm:
(WebKit):
(WebKit::WebMemorySampler::sendMemoryPressureEvent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebMemorySampler.cpp
trunk/Source/WebKit2/Shared/WebMemorySampler.h
trunk/Source/WebKit2/Shared/mac/WebMemorySampler.mac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (119545 => 119546)

--- trunk/Source/WebCore/ChangeLog	2012-06-06 01:10:49 UTC (rev 119545)
+++ trunk/Source/WebCore/ChangeLog	2012-06-06 01:37:09 UTC (rev 119546)
@@ -1,3 +1,19 @@
+2012-06-05  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=88370
+Memory sampler should trigger low memory signal
+
+Reviewed by Geoff Garen.
+
+No new tests. Verify by running stress test which crashes 
+in a few minutes without the fix.
+
+Fix assumption in block code.  We could get in a state where timer_event_source
+had already been released before the block ran.
+
+* platform/mac/MemoryPressureHandlerMac.mm:
+(WebCore::MemoryPressureHandler::holdOff):
+
 2012-06-05  Yoshifumi Inoue  
 
 [Forms] Introduce InputNumber type as an alias of double for replacing it to Decimal


Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (119545 => 119546)

--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2012-06-06 01:10:49 UTC (rev 119545)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2012-06-06 01:37:09 UTC (rev 119546)
@@ -106,9 +106,11 @@
 dispatch_set_context(_timer_event_source, this);
 dispatch_source_set_timer(_timer_event_source, dispatch_time(DISPATCH_TIME_NOW, seconds * NSEC_PER_SEC), DISPATCH_TIME_FOREVER, 1 * s_minimumHoldOffTime);
 dispatch_source_set_event_handler(_timer_event_source, ^{
-dispatch_source_cancel(_timer_event_source);
-dispatch_release(_timer_event_source);
-_timer_event_source = 0;
+if (_timer_event_source) {
+dispatch_source_cancel(_timer_event_source);
+dispatch_release(_timer_event_source);
+_timer_event_source = 0;
+}
 memoryPressureHandler().install();
 });
 dispatch_resume(_timer_event_source);


Modified: trunk/Source/WebKit2/ChangeLog (119545 => 119546)

--- trunk/Source/WebKit2/ChangeLog	2012-06-06 01:10:49 UTC (rev 119545)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-06 01:37:09 UTC (rev 119546)
@@ -1,3 +1,21 @@
+2012-06-04  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=88370
+Memory sampler should trigger low memory signal
+
+Reviewed by Geoff Garen.
+
+Send low memory signal when running the memory sampler.  We'd
+like to test memory that cannot be freed.
+
+* Shared/WebMemorySampler.cpp:
+(WebKit::WebMemorySampler::sampleTimerFired):
+* Shared/WebMemorySampler.h:
+(WebMemorySampler):
+* Shared/mac/WebMemorySampler.mac.mm:
+(WebKit):
+(WebKit::WebMemorySampler::sendMemoryPressureEvent):
+
 2012-06-05  Brady Eidson  
 
  and https://bugs.webkit.org/show_bug.cgi?id=88372


Modified: trunk/Source/WebKit2/Shared/WebMemorySampler.cpp (119545 => 119546)

--- trunk/Source/WebKit2/Shared/WebMemorySampler.cpp	2012-06-06 01:10:49 UTC (rev 119545)
+++ trunk/Source/WebKit2/Shared/WebMemorySampler.cpp	2012-06-06 01:37:09 UTC (rev 119546)
@@ -153,7 +153,8 @@
 
 void WebMemorySampler::sampleTimerFired(Timer*)
 {
-appendCurrentMemoryUsageToFile(m_sampleLogFile); 
+sendMemoryPressureEvent();
+appendCurrentMemoryUsageToFile(m_sampleLogFile);
 }
 
 void WebMemorySampler::stopTimerFired(Timer*)


Modified: trunk/Source/WebKit2/Shared/WebMemorySampler.h (119545 => 119546)

--- trunk/Source/WebKit2/Shared/WebMemorySampler.h	2012-06-06 01:10:49 UTC (rev 119545)
+++ trunk/Source/WebKit2/Shared/WebMemorySampler.h	2012-06-06 01:37:09 UTC (rev 119546)
@@ -89,6 +89,7 @@
 vo

[webkit-changes] [119030] trunk/Tools

2012-05-30 Thread slewis

Title: [119030] trunk/Tools








Revision 119030
Author sle...@apple.com
Date 2012-05-30 20:05:34 -0700 (Wed, 30 May 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=87803
Layout tests often fail trying to stat nonexistent logs

Reviewed by Dirk Pranke.

CrashReporter removes logs using a heuristic to conserve space.  Wrap a
try/catch block around accessing the logs as a precaution.

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs._find_newest_log_darwin):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py
trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (119029 => 119030)

--- trunk/Tools/ChangeLog	2012-05-31 03:05:30 UTC (rev 119029)
+++ trunk/Tools/ChangeLog	2012-05-31 03:05:34 UTC (rev 119030)
@@ -1,3 +1,16 @@
+2012-05-30  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=87803
+Layout tests often fail trying to stat nonexistent logs 
+
+Reviewed by Dirk Pranke.
+
+CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
+try/catch block around accessing the logs as a precaution.
+
+* Scripts/webkitpy/common/system/crashlogs.py:
+(CrashLogs._find_newest_log_darwin):
+
 2012-05-30  Gavin Peters  
 
 Add a LayoutTest for prerender remove after stop.


Modified: trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py (119029 => 119030)

--- trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py	2012-05-31 03:05:30 UTC (rev 119029)
+++ trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py	2012-05-31 03:05:34 UTC (rev 119030)
@@ -56,15 +56,18 @@
 first_line_regex = re.compile(r'^Process:\s+(?P.*) \[(?P\d+)\]$')
 errors = ''
 for path in reversed(sorted(logs)):
-if not newer_than or self._host.filesystem.mtime(path) > newer_than:
-try:
+try:
+if not newer_than or self._host.filesystem.mtime(path) > newer_than:
 f = self._host.filesystem.read_text_file(path)
 match = first_line_regex.match(f[0:f.find('\n')])
 if match and match.group('process_name') == process_name and (pid is None or int(match.group('pid')) == pid):
 return errors + f
-except IOError, e:
-if include_errors:
-errors += "ERROR: Failed to read '%s': %s\n" % (path, str(e))
+except IOError, e:
+if include_errors:
+errors += "ERROR: Failed to read '%s': %s\n" % (path, str(e))
+except OSError, e:
+if include_errors:
+errors += "ERROR: Failed to read '%s': %s\n" % (path, str(e))
 
 if include_errors and errors:
 return errors


Modified: trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py (119029 => 119030)

--- trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py	2012-05-31 03:05:30 UTC (rev 119029)
+++ trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py	2012-05-31 03:05:34 UTC (rev 119030)
@@ -75,6 +75,7 @@
 else:
 self.assertEqual(a.splitlines(), b.splitlines())
 
+
 def test_find_log_darwin(self):
 if not SystemHost().platform.is_mac():
 return
@@ -105,8 +106,17 @@
 self.assertEqual(log, None)
 
 def bad_read(path):
-raise IOError('No such file or directory')
+raise IOError('IOError: No such file or directory')
 
+def bad_mtime(path):
+raise OSError('OSError: No such file or directory')
+
 filesystem.read_text_file = bad_read
 log = crash_logs.find_newest_log("DumpRenderTree", 28531, include_errors=True)
-self.assertTrue('No such file or directory' in log)
+self.assertTrue('IOError: No such file or directory' in log)
+
+filesystem = MockFileSystem(files)
+crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem))
+filesystem.mtime = bad_mtime
+log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0, include_errors=True)
+self.assertTrue('OSError: No such file or directory' in log)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [119018] trunk/Tools

2012-05-30 Thread slewis

Title: [119018] trunk/Tools








Revision 119018
Author sle...@apple.com
Date 2012-05-30 18:51:50 -0700 (Wed, 30 May 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=87717
Unresponsive WebProcesses can be mistaken for WebProcess crashes.

Reviewed by Dirk Pranke.

Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
If there isn't a crash log found for the process add a message saying
the process was unresponsive.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.__init__):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitDriverTest.test_check_for_driver_crash.assert_crash):
(WebKitDriverTest):
(WebKitDriverTest.test_check_for_driver_crash):
* WebKitTestRunner/TestController.cpp:
(WTR):
(WTR::TestController::runTest):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Tools/ChangeLog (119017 => 119018)

--- trunk/Tools/ChangeLog	2012-05-31 01:51:26 UTC (rev 119017)
+++ trunk/Tools/ChangeLog	2012-05-31 01:51:50 UTC (rev 119018)
@@ -1,5 +1,28 @@
 2012-05-30  Stephanie Lewis  
 
+https://bugs.webkit.org/show_bug.cgi?id=87717
+Unresponsive WebProcesses can be mistaken for WebProcess crashes.
+
+Reviewed by Dirk Pranke.
+
+Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
+If there isn't a crash log found for the process add a message saying
+the process was unresponsive.
+
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitDriver.__init__):
+(WebKitDriver._check_for_driver_crash):
+(WebKitDriver.run_test):
+* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+(WebKitDriverTest.test_check_for_driver_crash.assert_crash):
+(WebKitDriverTest):
+(WebKitDriverTest.test_check_for_driver_crash):
+* WebKitTestRunner/TestController.cpp:
+(WTR):
+(WTR::TestController::runTest):
+
+2012-05-30  Stephanie Lewis  
+
 https://bugs.webkit.org/show_bug.cgi?id=87714
 Mac crash logs can take a really long time to be written out.
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (119017 => 119018)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-05-31 01:51:26 UTC (rev 119017)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-05-31 01:51:50 UTC (rev 119018)
@@ -449,6 +449,10 @@
 self._crashed_process_name = None
 self._crashed_pid = None
 
+# WebKitTestRunner can report back subprocesses that became unresponsive
+# This could mean they crashed.
+self._subprocess_was_unresponsive = False
+
 # stderr reading is scoped on a per-test (not per-block) basis, so we store the accumulated
 # stderr output, as well as if we've seen #EOF on this driver instance.
 # FIXME: We should probably remove _read_first_block and _read_optional_image_block and
@@ -513,7 +517,8 @@
 # See http://trac.webkit.org/changeset/65537.
 self._crashed_process_name = self._server_process.name()
 self._crashed_pid = self._server_process.pid()
-elif error_line.startswith("#CRASHED - WebProcess"):
+elif (error_line.startswith("#CRASHED - WebProcess")
+or error_line.startswith("#PROCESS UNRESPONSIVE - WebProcess")):
 # WebKitTestRunner uses this to report that the WebProcess subprocess crashed.
 pid = None
 m = re.search('pid (\d+)', error_line)
@@ -523,6 +528,8 @@
 self._crashed_pid = pid
 # FIXME: delete this after we're sure this code is working :)
 _log.debug('WebProcess crash, pid = %s, error_line = %s' % (str(pid), error_line))
+if error_line.startswith("#PROCESS UNRESPONSIVE - WebProcess"):
+self._subprocess_was_unresponsive = True
 return True
 return self.has_crashed()
 
@@ -581,6 +588,9 @@
 # If we don't find a crash log use a placeholder error message instead.
 if not crash_log:
 crash_log = 'no crash log found for %s:%d.' % (self._crashed_process_name, self._crashed_pid)
+# If we were unresponsive append a message informing there may not have been a crash.
+if self._subprocess_was_unresponsive:
+crash_log += '  Process failed to become responsive before timing out.'
 
 timeout = self._server_process.timed_out
 if timeout:


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py (119017 => 119018)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py	2012-05-31 01:51:26 UTC (rev 119017)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_un

[webkit-changes] [119017] trunk/Tools

2012-05-30 Thread slewis

Title: [119017] trunk/Tools








Revision 119017
Author sle...@apple.com
Date 2012-05-30 18:51:26 -0700 (Wed, 30 May 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=87714
Mac crash logs can take a really long time to be written out.

Reviewed by Dirk Pranke.

Make a second pass looking for crash logs after the tests have completed running.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(use_trac_links_in_results_html):
(Manager.run):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.repository_paths):
(Port.look_for_new_crash_logs):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.look_for_new_crash_logs):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_get_crash_log):
(test_look_for_new_crash_logs):
(test_look_for_new_crash_logs.fake_time_cb):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (119016 => 119017)

--- trunk/Tools/ChangeLog	2012-05-31 01:38:17 UTC (rev 119016)
+++ trunk/Tools/ChangeLog	2012-05-31 01:51:26 UTC (rev 119017)
@@ -1,3 +1,25 @@
+2012-05-30  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=87714
+Mac crash logs can take a really long time to be written out.
+
+Reviewed by Dirk Pranke.
+
+Make a second pass looking for crash logs after the tests have completed running.
+
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(use_trac_links_in_results_html):
+(Manager.run):
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.repository_paths):
+(Port.look_for_new_crash_logs):
+* Scripts/webkitpy/layout_tests/port/mac.py:
+(MacPort.look_for_new_crash_logs):
+* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
+(test_get_crash_log):
+(test_look_for_new_crash_logs):
+(test_look_for_new_crash_logs.fake_time_cb):
+
 2012-05-30  Kevin Ollivier  
 
 [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (119016 => 119017)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2012-05-31 01:38:17 UTC (rev 119016)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2012-05-31 01:51:26 UTC (rev 119017)
@@ -46,6 +46,7 @@
 
 from webkitpy.layout_tests.controllers import manager_worker_broker
 from webkitpy.layout_tests.controllers import worker
+from webkitpy.layout_tests.controllers.test_result_writer import TestResultWriter
 from webkitpy.layout_tests.layout_package import json_layout_results_generator
 from webkitpy.layout_tests.layout_package import json_results_generator
 from webkitpy.layout_tests.models import test_expectations
@@ -106,6 +107,7 @@
 # Use existence of builder_name as a proxy for knowing we're on a bot.
 return port_obj.get_option("builder_name")
 
+
 # FIXME: This should be on the Manager class (since that's the only caller)
 # or split off from Manager onto another helper class, but should not be a free function.
 # Most likely this should be made into its own class, and this super-long function
@@ -909,6 +911,10 @@
 
 end_time = time.time()
 
+# Some crash logs can take a long time to be written out so look
+# for new logs after the test run finishes.
+self._look_for_new_crash_logs(result_summary, start_time)
+self._look_for_new_crash_logs(retry_summary, start_time)
 self._clean_up_run()
 
 self._print_timing_statistics(end_time - start_time, thread_timings, test_timings, individual_test_timings, result_summary)
@@ -970,6 +976,29 @@
 _log.debug("cleaning up port")
 self._port.clean_up_test_run()
 
+def _look_for_new_crash_logs(self, result_summary, start_time):
+"""Since crash logs can take a long time to be written out if the system is
+   under stress do a second pass at the end of the test run.
+
+   result_summary: the results of the test run
+   start_time: time the tests started at.  We're looking for crash
+   logs after that time.
+"""
+crashed_processes = []
+for test, result in result_summary.unexpected_results.iteritems():
+if (result.type != test_expectations.CRASH):
+continue
+for failure in result.failures:
+if not isinstance(failure, test_failures.FailureCrash):
+continue
+crashed_processes.append([test, failure.process_name, failure.pid])
+
+crash_logs = self._port.look_for_new_crash_logs(crashed_processes, start_time)
+if crash_logs:
+for

[webkit-changes] [118860] trunk/Tools

2012-05-29 Thread slewis

Title: [118860] trunk/Tools








Revision 118860
Author sle...@apple.com
Date 2012-05-29 17:03:28 -0700 (Tue, 29 May 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=87720
WebProcess is often killed due to being unresponsive on the bots

Reviewed by Alexey Proskuryakov.

Blind attempt to improve flakiness on the bots by reducing the number
of crashes due to an unresponsive process.  This helped on my personal machine
under stress conditions.  I don't have enough cores to hit the problem
under normal conditions.

* WebKitTestRunner/TestController.cpp:
(WTR):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Tools/ChangeLog (118859 => 118860)

--- trunk/Tools/ChangeLog	2012-05-29 23:46:52 UTC (rev 118859)
+++ trunk/Tools/ChangeLog	2012-05-30 00:03:28 UTC (rev 118860)
@@ -1,3 +1,18 @@
+2012-05-29  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=87720
+WebProcess is often killed due to being unresponsive on the bots
+
+Reviewed by Alexey Proskuryakov.
+
+Blind attempt to improve flakiness on the bots by reducing the number
+of crashes due to an unresponsive process.  This helped on my personal machine
+under stress conditions.  I don't have enough cores to hit the problem
+under normal conditions.
+
+* WebKitTestRunner/TestController.cpp:
+(WTR):
+
 2012-05-29  Dirk Pranke  
 
 webkitpy: rename 'rm' to 'delete' in rebaseline scm output


Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (118859 => 118860)

--- trunk/Tools/WebKitTestRunner/TestController.cpp	2012-05-29 23:46:52 UTC (rev 118859)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp	2012-05-30 00:03:28 UTC (rev 118860)
@@ -49,7 +49,7 @@
 namespace WTR {
 
 static const double defaultLongTimeout = 30;
-static const double defaultShortTimeout = 5;
+static const double defaultShortTimeout = 15;
 static const double defaultNoTimeout = -1;
 
 static WKURLRef blankURL()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118842] trunk/Tools

2012-05-29 Thread slewis

Title: [118842] trunk/Tools








Revision 118842
Author sle...@apple.com
Date 2012-05-29 15:33:35 -0700 (Tue, 29 May 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=87711

Reviewed by Jessie Berlin.

Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
are better maintained.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (118841 => 118842)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-05-29 22:28:15 UTC (rev 118841)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-05-29 22:33:35 UTC (rev 118842)
@@ -3,12 +3,7 @@
 
   
 { "name": "apple-xserve-4", "platform": "mac-snowleopard" },
-{ "name": "apple-xserve-5", "platform": "mac-snowleopard" },
-{ "name": "apple-xserve-6", "platform": "mac-snowleopard" },
-{ "name": "apple-xserve-7", "platform": "mac-snowleopard" },
-{ "name": "apple-xserve-8", "platform": "mac-snowleopard" },	
 { "name": "apple-xserve-9", "platform": "mac-snowleopard" },	
-{ "name": "apple-macpro-7", "platform": "mac-snowleopard" },
 
 { "name": "apple-macpro-3", "platform": "mac-lion" },
 { "name": "apple-macpro-4", "platform": "mac-lion" },
@@ -75,34 +70,16 @@
 
 "builders":   [ { "name": "SnowLeopard Intel Release (Build)", "type": "Build", "builddir": "snowleopard-intel-release",
   "platform": "mac-snowleopard", "configuration": "release", "architectures": ["x86_64"],
-  "triggers": ["snowleopard-intel-release-tests", "snowleopard-intel-release-tests-wk2"],
   "slavenames": ["apple-xserve-4", "test-slave"]
 },
 { "name": "SnowLeopard Intel Debug (Build)", "type": "Build", "builddir": "snowleopard-intel-debug",
   "platform": "mac-snowleopard", "configuration": "debug", "architectures": ["x86_64"],
-  "triggers": ["snowleopard-intel-debug-tests", "snowleopard-intel-debug-tests-wk2"],
   "slavenames": ["apple-xserve-9"]
 },
-{ "name": "SnowLeopard Intel Release (Tests)", "type": "Test", "builddir": "snowleopard-intel-release-tests",
-  "platform": "mac-snowleopard", "configuration": "release", "architectures": ["x86_64"],
-  "slavenames": ["apple-xserve-5", "apple-xserve-6", "test-slave"]
-},
-{ "name": "SnowLeopard Intel Debug (Tests)", "type": "Test", "builddir": "snowleopard-intel-debug-tests",
-  "platform": "mac-snowleopard", "configuration": "debug", "architectures": ["x86_64"],
-  "slavenames": ["apple-xserve-8"]
-},
 { "name": "Lion Leaks", "type": "BuildAndTestLeaks", "builddir": "lion-intel-leaks",
   "platform": "mac-lion", "configuration": "debug", "architectures": ["x86_64"],
   "slavenames": ["apple-macpro-3"]
 },
-{ "name": "SnowLeopard Intel Release (WebKit2 Tests)", "type": "TestWebKit2", "builddir": "snowleopard-intel-release-tests-wk2",
-  "platform": "mac-snowleopard", "configuration": "release", "architectures": ["x86_64"],
-  "slavenames": ["apple-xserve-7", "test-slave"]
-},
-{ "name": "SnowLeopard Intel Debug (WebKit2 Tests)", "type": "TestWebKit2", "builddir": "snowleopard-intel-debug-tests-wk2",
-  "platform": "mac-snowleopard", "configuration": "debug", "architectures": ["x86_64"],
-  "slavenames": ["apple-macpro-7"]
-},
 { "name": "Lion Debug (Build)", "type": "Build", "builddir": "lion-intel-debug",
   "platform": "mac-lion", "configuration": "debug", "architectures": ["x86_64"],
   "triggers": ["lion-intel-debug-tests", "lion-intel-debug-tests-wk2"],
@@ -340,18 +317,6 @@
 { "type": "Triggerable", "name": "lion-intel-debug-tests-wk2",
   "builderNames": ["Lion Debug (WebKit2 Tests)"]
 },
-{ "type": "Triggerable", "name": "snowleopard-intel-release-tests",
-  "builderNames": ["SnowLeopard Intel Release (Tests)"]
-},
-{ "type": "Triggerable", "name": "snowleopard-intel-release-tests-wk2",
-  "builderNames": ["SnowLeopard Intel Release (WebKit2 Tests)"]
-},
-

[webkit-changes] [118753] trunk/LayoutTests

2012-05-29 Thread slewis

Title: [118753] trunk/LayoutTests








Revision 118753
Author sle...@apple.com
Date 2012-05-29 04:36:14 -0700 (Tue, 29 May 2012)


Log Message
Unreviewed, skipping failing test
See https://bugs.webkit.org/show_bug.cgi?id=87728

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (118752 => 118753)

--- trunk/LayoutTests/ChangeLog	2012-05-29 11:22:09 UTC (rev 118752)
+++ trunk/LayoutTests/ChangeLog	2012-05-29 11:36:14 UTC (rev 118753)
@@ -1,5 +1,12 @@
 2012-05-29  Stephanie Lewis  
 
+Unreviewed, skipping failing test
+See https://bugs.webkit.org/show_bug.cgi?id=87728
+
+* platform/mac/Skipped:
+
+2012-05-29  Stephanie Lewis  
+
 Unreviewed, updating results after http://trac.webkit.org/projects/webkit/changeset/118733
 
 * platform/mac/fast/css/text-overflow-input-expected.txt:


Modified: trunk/LayoutTests/platform/mac/Skipped (118752 => 118753)

--- trunk/LayoutTests/platform/mac/Skipped	2012-05-29 11:22:09 UTC (rev 118752)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-05-29 11:36:14 UTC (rev 118753)
@@ -867,3 +867,7 @@
 fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html
 fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba.html
 fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=87728
+http/tests/cache/cancel-in-progress-load.html
+ 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118751] trunk/LayoutTests

2012-05-29 Thread slewis

Title: [118751] trunk/LayoutTests








Revision 118751
Author sle...@apple.com
Date 2012-05-29 04:14:56 -0700 (Tue, 29 May 2012)


Log Message
Unreviewed, updating results after http://trac.webkit.org/projects/webkit/changeset/118733

* platform/mac/fast/css/text-overflow-input-expected.txt:
* platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/mac/fast/forms/placeholder-position-expected.txt:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/search-styled-expected.txt:
* platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/placeholder-position-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt


Added Paths

trunk/LayoutTests/platform/mac/fast/forms/input-placeholder-paint-order-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/textarea/
trunk/LayoutTests/platform/mac/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (118750 => 118751)

--- trunk/LayoutTests/ChangeLog	2012-05-29 11:14:29 UTC (rev 118750)
+++ trunk/LayoutTests/ChangeLog	2012-05-29 11:14:56 UTC (rev 118751)
@@ -1,3 +1,17 @@
+2012-05-29  Stephanie Lewis  
+
+Unreviewed, updating results after http://trac.webkit.org/projects/webkit/changeset/118733
+
+* platform/mac/fast/css/text-overflow-input-expected.txt:
+* platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
+* platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
+* platform/mac/fast/forms/placeholder-position-expected.txt:
+* platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
+* platform/mac/fast/forms/search-styled-expected.txt:
+* platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
+* platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
+* platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
+
 2012-05-29  Kent Tamura  
 
 [Chromium] Update test expectations


Modified: trunk/LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt (118750 => 118751)

--- trunk/LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt	2012-05-29 11:14:29 UTC (rev 118750)
+++ trunk/LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt	2012-05-29 11:14:56 UTC (rev 118751)
@@ -124,18 +124,18 @@
 RenderText {#text} at (520,43) size 4x18
   text run at (520,43) width 4: " "
 RenderBR {BR} at (0,0) size 0x0
-layer at (13,73) size 117x13
-  RenderBlock {DIV} at (3,3) size 117x13
 layer at (13,73) size 117x13 scrollWidth 296
   RenderBlock {DIV} at (3,3) size 117x13 [color=#A9A9A9]
 RenderText {#text} at (0,0) size 296x13
   text run at (0,0) width 296: "Lorem ipsum dolor sit amet, consectetur adipiscing elit"
-layer at (152,73) size 96x13
-  RenderBlock {DIV} at (0,0) size 96x13
+layer at (13,73) size 117x13
+  RenderBlock {DIV} at (3,3) size 117x13
 layer at (152,73) size 96x13 scrollWidth 296
   RenderBlock {DIV} at (11,3) size 96x13 [color=#A9A9A9]
 RenderText {#text} at (0,0) size 296x13
   text run at (0,0) width 296: "Lorem ipsum dolor sit amet, consectetur adipiscing elit"
+layer at (152,73) size 96x13
+  RenderBlock {DIV} at (0,0) size 96x13
 layer at (275,73) size 117x13 scrollWidth 297
   RenderBlock {DIV} at (3,3) size 117x13
 RenderText {#text} at (0,0) size 296x13
@@ -148,18 +148,18 @@
   RenderBlock {DIV} at (3,3) size 117x13
 RenderText {#text} at (0,0) size 340x13
   text run at (0,0) width 340: "\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}"
-layer at (13,96) size 117

[webkit-changes] [118602] trunk/LayoutTests

2012-05-25 Thread slewis

Title: [118602] trunk/LayoutTests








Revision 118602
Author sle...@apple.com
Date 2012-05-25 19:24:53 -0700 (Fri, 25 May 2012)


Log Message
Unreviewed, fix bad copy/paste.

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (118601 => 118602)

--- trunk/LayoutTests/ChangeLog	2012-05-26 02:20:40 UTC (rev 118601)
+++ trunk/LayoutTests/ChangeLog	2012-05-26 02:24:53 UTC (rev 118602)
@@ -25,6 +25,12 @@
 
 2012-05-25  Stephanie Lewis  
 
+Unreviewed, fix bad copy/paste.
+
+* platform/mac/Skipped:
+
+2012-05-25  Stephanie Lewis  
+
 See https://bugs.webkit.org/show_bug.cgi?id=87558
 
 Unreviewed, checking in expected failing results.


Modified: trunk/LayoutTests/platform/mac/Skipped (118601 => 118602)

--- trunk/LayoutTests/platform/mac/Skipped	2012-05-26 02:20:40 UTC (rev 118601)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-05-26 02:24:53 UTC (rev 118602)
@@ -869,5 +869,5 @@
 fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html
 
 # https://bugs.webkit.org/show_bug.cgi?id=87544
-fast/block/inline-children-root-linebox-crash.html asserts after r118567
+fast/block/inline-children-root-linebox-crash.html
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118598] trunk/LayoutTests

2012-05-25 Thread slewis

Title: [118598] trunk/LayoutTests








Revision 118598
Author sle...@apple.com
Date 2012-05-25 18:53:06 -0700 (Fri, 25 May 2012)


Log Message
See https://bugs.webkit.org/show_bug.cgi?id=87558

Unreviewed, checking in expected failing results.

* platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-_javascript_-url-expected.txt: Added.
* platform/mac/http/tests/security/contentSecurityPolicy/_javascript_-url-blocked-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac/http/tests/security/contentSecurityPolicy/
trunk/LayoutTests/platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-_javascript_-url-expected.txt
trunk/LayoutTests/platform/mac/http/tests/security/contentSecurityPolicy/_javascript_-url-blocked-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (118597 => 118598)

--- trunk/LayoutTests/ChangeLog	2012-05-26 01:43:14 UTC (rev 118597)
+++ trunk/LayoutTests/ChangeLog	2012-05-26 01:53:06 UTC (rev 118598)
@@ -1,5 +1,14 @@
 2012-05-25  Stephanie Lewis  
 
+See https://bugs.webkit.org/show_bug.cgi?id=87558
+
+Unreviewed, checking in expected failing results.
+
+* platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-_javascript_-url-expected.txt: Added.
+* platform/mac/http/tests/security/contentSecurityPolicy/_javascript_-url-blocked-expected.txt: Added.
+
+2012-05-25  Stephanie Lewis  
+
 See https://bugs.webkit.org/show_bug.cgi?id=87544
 
 Unreviewed, skipping asserting test 


Added: trunk/LayoutTests/platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-_javascript_-url-expected.txt (0 => 118598)

--- trunk/LayoutTests/platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-_javascript_-url-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-_javascript_-url-expected.txt	2012-05-26 01:53:06 UTC (rev 118598)
@@ -0,0 +1,9 @@
+CONSOLE MESSAGE: Unrecognized Content-Security-Policy directive 'options'.
+
+CONSOLE MESSAGE: Unrecognized Content-Security-Policy directive 'options'.
+
+CONSOLE MESSAGE: Unrecognized Content-Security-Policy directive 'options'.
+
+CONSOLE MESSAGE: Refused to execute _javascript_ URL because it violates the following Content Security Policy directive: "script-src http://127.0.0.1:*".
+
+This test passes if it doesn't alert fail. 


Added: trunk/LayoutTests/platform/mac/http/tests/security/contentSecurityPolicy/_javascript_-url-blocked-expected.txt (0 => 118598)

--- trunk/LayoutTests/platform/mac/http/tests/security/contentSecurityPolicy/_javascript_-url-blocked-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/http/tests/security/contentSecurityPolicy/_javascript_-url-blocked-expected.txt	2012-05-26 01:53:06 UTC (rev 118598)
@@ -0,0 +1,13 @@
+CONSOLE MESSAGE: Unrecognized Content-Security-Policy directive 'allow'.
+
+CONSOLE MESSAGE: Unrecognized Content-Security-Policy directive 'allow'.
+
+CONSOLE MESSAGE: Unrecognized Content-Security-Policy directive 'allow'.
+
+CONSOLE MESSAGE: Refused to execute _javascript_ URL because it violates the following Content Security Policy directive: "script-src 'none'".
+
+CONSOLE MESSAGE: Unrecognized Content-Security-Policy directive 'allow'.
+
+CONSOLE MESSAGE: Unrecognized Content-Security-Policy directive 'allow'.
+
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118595] trunk/LayoutTests

2012-05-25 Thread slewis

Title: [118595] trunk/LayoutTests








Revision 118595
Author sle...@apple.com
Date 2012-05-25 18:21:12 -0700 (Fri, 25 May 2012)


Log Message
See https://bugs.webkit.org/show_bug.cgi?id=87544

Unreviewed, skipping asserting test

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (118594 => 118595)

--- trunk/LayoutTests/ChangeLog	2012-05-26 01:02:19 UTC (rev 118594)
+++ trunk/LayoutTests/ChangeLog	2012-05-26 01:21:12 UTC (rev 118595)
@@ -1,3 +1,11 @@
+2012-05-25  Stephanie Lewis  
+
+See https://bugs.webkit.org/show_bug.cgi?id=87544
+
+Unreviewed, skipping asserting test 
+
+* platform/mac/Skipped:
+
 2012-05-25  Lynn Neir  
 
 Updated tests as a result of implementing TextInputController in DRT for windows, https://bugs.webkit.org/show_bug.cgi?id=32021


Modified: trunk/LayoutTests/platform/mac/Skipped (118594 => 118595)

--- trunk/LayoutTests/platform/mac/Skipped	2012-05-26 01:02:19 UTC (rev 118594)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-05-26 01:21:12 UTC (rev 118595)
@@ -867,3 +867,7 @@
 fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html
 fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba.html
 fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=87544
+fast/block/inline-children-root-linebox-crash.html asserts after r118567
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118462] branches/safari-536-branch/LayoutTests

2012-05-24 Thread slewis

Title: [118462] branches/safari-536-branch/LayoutTests








Revision 118462
Author sle...@apple.com
Date 2012-05-24 19:08:11 -0700 (Thu, 24 May 2012)


Log Message
See https://bugs.webkit.org/show_bug.cgi?id=87182
Unreviewed, checking in expected results for branch.

* platform/mac-wk2/plugins/mouse-events-scaled-iframe-expected.txt:

Modified Paths

branches/safari-536-branch/LayoutTests/ChangeLog
branches/safari-536-branch/LayoutTests/platform/mac-wk2/plugins/mouse-events-scaled-iframe-expected.txt




Diff

Modified: branches/safari-536-branch/LayoutTests/ChangeLog (118461 => 118462)

--- branches/safari-536-branch/LayoutTests/ChangeLog	2012-05-25 01:56:09 UTC (rev 118461)
+++ branches/safari-536-branch/LayoutTests/ChangeLog	2012-05-25 02:08:11 UTC (rev 118462)
@@ -1,3 +1,10 @@
+2012-05-24  Stephanie Lewis  
+
+See https://bugs.webkit.org/show_bug.cgi?id=87182
+Unreviewed, checking in expected results for branch.
+
+* platform/mac-wk2/plugins/mouse-events-scaled-iframe-expected.txt:
+
 2012-05-24  Lucas Forschler  
 
 Merge 118204


Modified: branches/safari-536-branch/LayoutTests/platform/mac-wk2/plugins/mouse-events-scaled-iframe-expected.txt (118461 => 118462)

--- branches/safari-536-branch/LayoutTests/platform/mac-wk2/plugins/mouse-events-scaled-iframe-expected.txt	2012-05-25 01:56:09 UTC (rev 118461)
+++ branches/safari-536-branch/LayoutTests/platform/mac-wk2/plugins/mouse-events-scaled-iframe-expected.txt	2012-05-25 02:08:11 UTC (rev 118462)
@@ -1,5 +1,5 @@
-CONSOLE MESSAGE: PLUGIN: mouseDown at (400, 400)
-CONSOLE MESSAGE: PLUGIN: mouseUp at (400, 400)
+CONSOLE MESSAGE: PLUGIN: mouseDown at (300, 300)
+CONSOLE MESSAGE: PLUGIN: mouseUp at (300, 300)
 CONSOLE MESSAGE: PLUGIN: mouseDown at (200, 200)
 CONSOLE MESSAGE: PLUGIN: mouseUp at (200, 200)
 CONSOLE MESSAGE: PLUGIN: mouseDown at (133, 133)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118334] trunk/LayoutTests

2012-05-24 Thread slewis

Title: [118334] trunk/LayoutTests








Revision 118334
Author sle...@apple.com
Date 2012-05-24 00:44:46 -0700 (Thu, 24 May 2012)


Log Message
See https://bugs.webkit.org/show_bug.cgi?id=87347

Unreviewed, skipping newly flaky test.

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (118333 => 118334)

--- trunk/LayoutTests/ChangeLog	2012-05-24 07:35:05 UTC (rev 118333)
+++ trunk/LayoutTests/ChangeLog	2012-05-24 07:44:46 UTC (rev 118334)
@@ -1,3 +1,11 @@
+2012-05-23  Stephanie Lewis  
+
+See https://bugs.webkit.org/show_bug.cgi?id=87347
+
+Unreviewed, skipping newly flaky test.
+
+* platform/mac/Skipped:
+
 2012-05-24  Christophe Dumez  
 
 [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse


Modified: trunk/LayoutTests/platform/mac/Skipped (118333 => 118334)

--- trunk/LayoutTests/platform/mac/Skipped	2012-05-24 07:35:05 UTC (rev 118333)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-05-24 07:44:46 UTC (rev 118334)
@@ -860,3 +860,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=87208  New test http/tests/cookies/js-get-and-set-http-only-cookie.php fails on Mac, GTK, Qt (87208)
 http/tests/cookies/js-get-and-set-http-only-cookie.php
 
+# https://bugs.webkit.org/show_bug.cgi?id=87347
+fast/frames/flattening/iframe-tiny.html
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118305] trunk/LayoutTests

2012-05-23 Thread slewis

Title: [118305] trunk/LayoutTests








Revision 118305
Author sle...@apple.com
Date 2012-05-23 19:08:49 -0700 (Wed, 23 May 2012)


Log Message
See https://bugs.webkit.org/show_bug.cgi?id=87208

Unreviewed, skipping new test that can have side effects.

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (118304 => 118305)

--- trunk/LayoutTests/ChangeLog	2012-05-24 02:03:04 UTC (rev 118304)
+++ trunk/LayoutTests/ChangeLog	2012-05-24 02:08:49 UTC (rev 118305)
@@ -1,3 +1,11 @@
+2012-05-23  Stephanie Lewis  
+
+See https://bugs.webkit.org/show_bug.cgi?id=87208
+
+Unreviewed, skipping new test that can have side effects.
+
+* platform/mac/Skipped:
+
 2012-05-23  Shinya Kawanaka  
 
 [Shadow] mousewheel event isn't fired on nodes in Shadow DOM.


Modified: trunk/LayoutTests/platform/mac/Skipped (118304 => 118305)

--- trunk/LayoutTests/platform/mac/Skipped	2012-05-24 02:03:04 UTC (rev 118304)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-05-24 02:08:49 UTC (rev 118305)
@@ -857,3 +857,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=87199
 compositing/video/video-poster.html
 
+# https://bugs.webkit.org/show_bug.cgi?id=87208  New test http/tests/cookies/js-get-and-set-http-only-cookie.php fails on Mac, GTK, Qt (87208)
+http/tests/cookies/js-get-and-set-http-only-cookie.php
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118122] trunk/LayoutTests

2012-05-22 Thread slewis

Title: [118122] trunk/LayoutTests








Revision 118122
Author sle...@apple.com
Date 2012-05-22 22:20:24 -0700 (Tue, 22 May 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=87208
Unreviewed, checking in failing results.

* platform/mac/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac/http/tests/cookies/
trunk/LayoutTests/platform/mac/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (118121 => 118122)

--- trunk/LayoutTests/ChangeLog	2012-05-23 05:03:16 UTC (rev 118121)
+++ trunk/LayoutTests/ChangeLog	2012-05-23 05:20:24 UTC (rev 118122)
@@ -1,3 +1,10 @@
+2012-05-22  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=87208
+Unreviewed, checking in failing results.
+
+* platform/mac/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
+
 2012-05-22  MORITA Hajime  
 
 REGRESSION(r116629) tests for

[webkit-changes] [118107] trunk/LayoutTests

2012-05-22 Thread slewis

Title: [118107] trunk/LayoutTests








Revision 118107
Author sle...@apple.com
Date 2012-05-22 20:07:44 -0700 (Tue, 22 May 2012)


Log Message
See https://bugs.webkit.org/show_bug.cgi?id=87199
Unreviewed, add failing test to skipped list.

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (118106 => 118107)

--- trunk/LayoutTests/ChangeLog	2012-05-23 02:58:36 UTC (rev 118106)
+++ trunk/LayoutTests/ChangeLog	2012-05-23 03:07:44 UTC (rev 118107)
@@ -1,3 +1,10 @@
+2012-05-22  Stephanie Lewis  
+
+See https://bugs.webkit.org/show_bug.cgi?id=87199
+Unreviewed, add failing test to skipped list.
+
+* platform/mac/Skipped:
+
 2012-05-22  Jason Liu  
 
 [BlackBerry] Possible to clobber httponly cookie.


Modified: trunk/LayoutTests/platform/mac/Skipped (118106 => 118107)

--- trunk/LayoutTests/platform/mac/Skipped	2012-05-23 02:58:36 UTC (rev 118106)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-05-23 03:07:44 UTC (rev 118107)
@@ -858,3 +858,7 @@
 fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba.html
 fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html
 fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=87199
+compositing/video/video-poster.html
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118106] trunk/LayoutTests

2012-05-22 Thread slewis

Title: [118106] trunk/LayoutTests








Revision 118106
Author sle...@apple.com
Date 2012-05-22 19:58:36 -0700 (Tue, 22 May 2012)


Log Message
Unreviewed, update result missed by http://trac.webkit.org/changeset/117673.

* platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (118105 => 118106)

--- trunk/LayoutTests/ChangeLog	2012-05-23 02:49:58 UTC (rev 118105)
+++ trunk/LayoutTests/ChangeLog	2012-05-23 02:58:36 UTC (rev 118106)
@@ -23,6 +23,12 @@
 
 2012-05-22  Stephanie Lewis  
 
+Unreviewed, update result missed by http://trac.webkit.org/changeset/117673.
+
+* platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt:
+
+2012-05-22  Stephanie Lewis  
+
 See https://bugs.webkit.org/show_bug.cgi?id=87187
  acid3 fails on WebKit2 (87187)
 


Modified: trunk/LayoutTests/platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt (118105 => 118106)

--- trunk/LayoutTests/platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt	2012-05-23 02:49:58 UTC (rev 118105)
+++ trunk/LayoutTests/platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt	2012-05-23 02:58:36 UTC (rev 118106)
@@ -36,6 +36,6 @@
 text run at (0,0) width 326: "Success: document.execCommand(\"Paste\") == true"
 layer at (11,13) size 594x13
   RenderBlock {DIV} at (3,3) size 594x13
-RenderText {#text} at (1,0) size 479x13
-  text run at (1,0) width 479: "This styled text, and link will be pasted into the textfield. All richness should be stripped."
+RenderText {#text} at (0,0) size 479x13
+  text run at (0,0) width 479: "This styled text, and link will be pasted into the textfield. All richness should be stripped."
 caret: position 94 of child 0 {#text} of child 0 {DIV} of {#shadow-root} of child 0 {INPUT} of body






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118101] trunk/LayoutTests

2012-05-22 Thread slewis

Title: [118101] trunk/LayoutTests








Revision 118101
Author sle...@apple.com
Date 2012-05-22 19:30:58 -0700 (Tue, 22 May 2012)


Log Message
See https://bugs.webkit.org/show_bug.cgi?id=87187
 acid3 fails on WebKit2 (87187)

Unreviewed, checking in failing results.

* platform/mac-wk2/http/tests/misc/acid3-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/http/tests/misc/acid3-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (118100 => 118101)

--- trunk/LayoutTests/ChangeLog	2012-05-23 02:19:55 UTC (rev 118100)
+++ trunk/LayoutTests/ChangeLog	2012-05-23 02:30:58 UTC (rev 118101)
@@ -1,3 +1,12 @@
+2012-05-22  Stephanie Lewis  
+
+See https://bugs.webkit.org/show_bug.cgi?id=87187
+ acid3 fails on WebKit2 (87187)
+
+Unreviewed, checking in failing results.
+
+* platform/mac-wk2/http/tests/misc/acid3-expected.txt:
+
 2012-05-22  James Robinson  
 
 Add a Setting to make position:fixed form a new stacking context


Modified: trunk/LayoutTests/platform/mac-wk2/http/tests/misc/acid3-expected.txt (118100 => 118101)

--- trunk/LayoutTests/platform/mac-wk2/http/tests/misc/acid3-expected.txt	2012-05-23 02:19:55 UTC (rev 118100)
+++ trunk/LayoutTests/platform/mac-wk2/http/tests/misc/acid3-expected.txt	2012-05-23 02:30:58 UTC (rev 118101)
@@ -229,7 +229,7 @@
 RenderBody {BODY} at (8,16) size 284x0
   RenderBlock {P} at (0,0) size 284x0
 layer at (17,18) size 80x36
-  RenderBlock (positioned) {A} at (17,18) size 80x36 [color=#FF]
+  RenderBlock (positioned) {A} at (17,18) size 80x36 [color=#FF]
 RenderText {#text} at (0,0) size 71x36
   text run at (0,0) width 67: "YOU SHOULD"
   text run at (0,12) width 71: "NOT SEE THIS"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115952] trunk

2012-05-03 Thread slewis

Title: [115952] trunk








Revision 115952
Author sle...@apple.com
Date 2012-05-03 02:51:56 -0700 (Thu, 03 May 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=85450 unbounded growth of JSDOMWindowShells loading pages in the same window
 REGRESSION (r115083): PLT3 shows linear memory growth and gets slower with each run

Reviewed by Brady Eidson.

The API added for DOMWindowExtension, didCreateGlobalObjectForFrame, would create a global object
for every world, even those that did not need the callback.  This had the side effect of creating a
JSDOMWindowShell that the associated world didn't necessarily know to clean up.  Instead of creating
unnecessary objects change the API to globalObjectIsAvailableForFrame and do not pass the global object
in the API.  The object can be accessed later by those worlds which require it.

Source/WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame): rename API and remove globalObject parameter
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient): ditto
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable): ditto

Tools:

* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
(TestWebKitAPI):
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
(TestWebKitAPI):
(DOMWindowExtensionBasic):
(TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
(TestWebKitAPI::DOMWindowExtensionBasic::globalObjectIsAvailableForFrame):
(TestWebKitAPI::globalObjectIsAvailableForFrameCallback):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (115951 => 115952)

--- trunk/Source/WebKit2/ChangeLog	2012-05-03 09:49:29 UTC (rev 115951)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-03 09:51:56 UTC (rev 115952)
@@ -1,3 +1,24 @@
+2012-05-03  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=85450 unbounded growth of JSDOMWindowShells loading pages in the same window
+ REGRESSION (r115083): PLT3 shows linear memory growth and gets slower with each run
+
+Reviewed by Brady Eidson.
+
+The API added for DOMWindowExtension, didCreateGlobalObjectForFrame, would create a global object
+for every world, even those that did not need the callback.  This had the side effect of creating a
+JSDOMWindowShell that the associated world didn't necessarily know to clean up.  Instead of creating
+unnecessary objects change the API to globalObjectIsAvailableForFrame and do not pass the global object
+in the API.  The object can be accessed later by those worlds which require it.
+
+* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
+* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
+(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame): rename API and remove globalObject parameter
+* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
+(InjectedBundlePageLoaderClient): ditto
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable): ditto
+
 2012-05-02  Alexander Færøy  
 
 Rename deviceDPI to devicePixelRatio


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h (115951 => 115952)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h	2012-05-03 09:49:29 UTC (rev 115951)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h	2012-05-03 09:51:56 UTC (rev 115952)
@@ -103,7 +103,7 @@
 typedef void (*WKBundlePageWillPerformClientRedirectForFrameCallback)(WKBundlePageRef page, WKBundleFrameRef frame, WKURLRef url, double delay, double date, const void *clientInfo);
 typedef void (*WKBundlePageDidHandleOnloadEventsForFrameCallback)(WKBundlePageRef page, WKBundleFrameRef frame, const void *clientInfo);
 typedef bool (*WKBundlePageShouldGoToBackForwardListItemCallback)(WKBundlePageRef page, WKBundleBackForwardListItemRef item, WKTypeRef* userData, const void *clientInfo);
-typedef void (*WKBundlePageDidCreateGlobalObjectForFrameCallback)(WKBundlePageRef page, JSObjectRef globalObject, WKBundleFrameRef, WKBundleScriptWorldRef, const void* clientInfo);
+typedef void (*WKBundlePageGlobalObjectIsAvailable

[webkit-changes] [112948] trunk/Tools

2012-04-02 Thread slewis

Title: [112948] trunk/Tools








Revision 112948
Author sle...@apple.com
Date 2012-04-02 15:05:59 -0700 (Mon, 02 Apr 2012)


Log Message
2012-04-02  Stephanie Lewis  

run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
https://bugs.webkit.org/show_bug.cgi?id=82552

Reviewed by Dirk Pranke.

Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._start):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (112947 => 112948)

--- trunk/Tools/ChangeLog	2012-04-02 21:53:12 UTC (rev 112947)
+++ trunk/Tools/ChangeLog	2012-04-02 22:05:59 UTC (rev 112948)
@@ -1,3 +1,15 @@
+2012-04-02  Stephanie Lewis  
+
+run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
+https://bugs.webkit.org/show_bug.cgi?id=82552
+
+Reviewed by Dirk Pranke.
+
+Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
+
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitDriver._start):
+
 2012-04-02  Dirk Pranke  
 
 NRWT is not printing out the builder it's uploading JSON files for


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (112947 => 112948)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-04-02 21:53:12 UTC (rev 112947)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-04-02 22:05:59 UTC (rev 112948)
@@ -482,6 +482,7 @@
 environment = self._port.setup_environ_for_server(server_name)
 environment['DYLD_LIBRARY_PATH'] = self._port._build_path()
 environment['DYLD_FRAMEWORK_PATH'] = self._port._build_path()
+environment['DYLD_LIBRARY_PATH'] = self._port._build_path()
 # FIXME: We're assuming that WebKitTestRunner checks this DumpRenderTree-named environment variable.
 environment['DUMPRENDERTREE_TEMP'] = str(self._driver_tempdir)
 environment['LOCAL_RESOURCE_ROOT'] = self._port.layout_tests_dir()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112483] trunk

2012-03-28 Thread slewis

Title: [112483] trunk








Revision 112483
Author sle...@apple.com
Date 2012-03-28 18:02:28 -0700 (Wed, 28 Mar 2012)


Log Message
Unreviewed, rolling out r110064.
http://trac.webkit.org/changeset/110064
https://bugs.webkit.org/show_bug.cgi?id=82537

The patch leaks the DOM when audio elements are used
(Requested by sundiamonde on #webkit).

Patch by Sheriff Bot  on 2012-03-28

Source/WebCore: 

* bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):

LayoutTests: 

* platform/gtk/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (112482 => 112483)

--- trunk/LayoutTests/ChangeLog	2012-03-29 00:58:42 UTC (rev 112482)
+++ trunk/LayoutTests/ChangeLog	2012-03-29 01:02:28 UTC (rev 112483)
@@ -1,3 +1,14 @@
+2012-03-28  Sheriff Bot  
+
+Unreviewed, rolling out r110064.
+http://trac.webkit.org/changeset/110064
+https://bugs.webkit.org/show_bug.cgi?id=82537
+
+The patch leaks the DOM when audio elements are used
+(Requested by sundiamonde on #webkit).
+
+* platform/gtk/test_expectations.txt:
+
 2012-03-28  Enrica Casucci  
 
 editing/spelling/spellcheck-async-mutation.html is flakey.


Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (112482 => 112483)

--- trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-03-29 00:58:42 UTC (rev 112482)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-03-29 01:02:28 UTC (rev 112483)
@@ -68,6 +68,7 @@
 BUGWK80129 : fast/frames/flattening/frameset-flattening-advanced.html = PASS TEXT
 BUGWK80129 : fast/frames/flattening/frameset-flattening-subframesets.html = PASS TEXT
 
+BUGWK72698 : media/audio-garbage-collect.html = PASS TEXT
 BUGWK79760 : media/video-poster-blocked-by-willsendrequest.html = PASS TEXT
 
 BUGWK72694 : fast/canvas/canvas-lineWidth.html = PASS TIMEOUT TEXT


Modified: trunk/Source/WebCore/ChangeLog (112482 => 112483)

--- trunk/Source/WebCore/ChangeLog	2012-03-29 00:58:42 UTC (rev 112482)
+++ trunk/Source/WebCore/ChangeLog	2012-03-29 01:02:28 UTC (rev 112483)
@@ -1,3 +1,15 @@
+2012-03-28  Sheriff Bot  
+
+Unreviewed, rolling out r110064.
+http://trac.webkit.org/changeset/110064
+https://bugs.webkit.org/show_bug.cgi?id=82537
+
+The patch leaks the DOM when audio elements are used
+(Requested by sundiamonde on #webkit).
+
+* bindings/js/JSNodeCustom.cpp:
+(WebCore::isReachableFromDOM):
+
 2012-03-28  Alexey Proskuryakov  
 
 [Win] Some Blob tests crash in CFNetwork in advanceCurrentStream(FormStreamFields*)


Modified: trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp (112482 => 112483)

--- trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp	2012-03-29 00:58:42 UTC (rev 112482)
+++ trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp	2012-03-29 01:02:28 UTC (rev 112483)
@@ -116,7 +116,7 @@
 }
 #if ENABLE(VIDEO)
 else if (node->hasTagName(audioTag)) {
-if (!static_cast(node)->hasPendingActivity())
+if (!static_cast(node)->paused())
 return true;
 }
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111977] trunk/Source/WebCore

2012-03-23 Thread slewis

Title: [111977] trunk/Source/WebCore








Revision 111977
Author sle...@apple.com
Date 2012-03-23 22:21:26 -0700 (Fri, 23 Mar 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=81963 WebProcess can get stuck in GC during many low memory signals.
 WebProcess appears to get stuck in its GC handler (81963).
Remove the call to garbage collect  in low memory signal handler.  Did some testing with hitting the low memory handler
during Membuster and we would get back at most 100k - 200k.  That isn't enough to help the system, and in
that state the GC collection can take a substantial amount of time.

Reviewed by Geoff Garen.

Performance Change, no change in behavior.

* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (111976 => 111977)

--- trunk/Source/WebCore/ChangeLog	2012-03-24 04:04:27 UTC (rev 111976)
+++ trunk/Source/WebCore/ChangeLog	2012-03-24 05:21:26 UTC (rev 111977)
@@ -1,3 +1,18 @@
+2012-03-23  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=81963 WebProcess can get stuck in GC during many low memory signals.
+ WebProcess appears to get stuck in its GC handler (81963).
+Remove the call to garbage collect  in low memory signal handler.  Did some testing with hitting the low memory handler
+during Membuster and we would get back at most 100k - 200k.  That isn't enough to help the system, and in 
+that state the GC collection can take a substantial amount of time.
+
+Reviewed by Geoff Garen.
+
+Performance Change, no change in behavior.
+
+* platform/mac/MemoryPressureHandlerMac.mm:
+(WebCore::MemoryPressureHandler::releaseMemory):
+
 2012-03-23  W. James MacLean  
 
 [chromium] CCLayerTreeHostImpl::scrollBegin() should return ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found.


Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (111976 => 111977)

--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2012-03-24 04:04:27 UTC (rev 111976)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2012-03-24 05:21:26 UTC (rev 111977)
@@ -135,8 +135,6 @@
 
 memoryCache()->pruneToPercentage(critical ? 0 : 0.5f);
 
-gcController().garbageCollectNow();
-
 WTF::releaseFastMallocFreeMemory();
 }
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111372] trunk/LayoutTests

2012-03-20 Thread slewis

Title: [111372] trunk/LayoutTests








Revision 111372
Author sle...@apple.com
Date 2012-03-20 01:53:45 -0700 (Tue, 20 Mar 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=81637 fast/dom/Window/timer-resume-on-navigation-back.html times out.
Skips a test that times out.

Unreviewed.

* platform/mac-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (111371 => 111372)

--- trunk/LayoutTests/ChangeLog	2012-03-20 08:32:11 UTC (rev 111371)
+++ trunk/LayoutTests/ChangeLog	2012-03-20 08:53:45 UTC (rev 111372)
@@ -1,3 +1,12 @@
+2012-03-20  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=81637 fast/dom/Window/timer-resume-on-navigation-back.html times out.
+Skips a test that times out.
+
+Unreviewed.
+
+* platform/mac-wk2/Skipped:
+
 2012-03-20  Jason Liu  
 
 [BlackBerry]Cookies shouldn't be set into each of webcore's request and platform's request. And this makes a regression.


Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (111371 => 111372)

--- trunk/LayoutTests/platform/mac-wk2/Skipped	2012-03-20 08:32:11 UTC (rev 111371)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped	2012-03-20 08:53:45 UTC (rev 111372)
@@ -238,6 +238,10 @@
 http/tests/xmlhttprequest/re-login-async.html
 http/tests/xmlhttprequest/workers/abort-exception-assert.html
 
+# [WK2] fast/dom/Window/timer-resume-on-navigation-back.html times out
+# https://bugs.webkit.org/show_bug.cgi?id=81637
+fast/dom/Window/timer-resume-on-navigation-back.html
+
 ### END OF (1) Classified failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111368] trunk/LayoutTests

2012-03-20 Thread slewis

Title: [111368] trunk/LayoutTests








Revision 111368
Author sle...@apple.com
Date 2012-03-20 00:59:07 -0700 (Tue, 20 Mar 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=81634 some SVG Zoom tests fail on Lion WK2 bots

Unreviewed.

Check in new expected (failing?) results.

* platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt
trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt
trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (111367 => 111368)

--- trunk/LayoutTests/ChangeLog	2012-03-20 06:49:27 UTC (rev 111367)
+++ trunk/LayoutTests/ChangeLog	2012-03-20 07:59:07 UTC (rev 111368)
@@ -1,3 +1,16 @@
+2012-03-20  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=81634 some SVG Zoom tests fail on Lion WK2 bots
+
+Unreviewed.
+
+Check in new expected (failing?) results.
+
+* platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
+* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
+* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
+* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
+
 2012-03-19  Zoltan Arvai  
 
 [Qt] New test introduced in r110532 fails on 32 bit.


Modified: trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt (111367 => 111368)

--- trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt	2012-03-20 06:49:27 UTC (rev 111367)
+++ trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt	2012-03-20 07:59:07 UTC (rev 111368)
@@ -1,62 +1,62 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x461
-  RenderBlock {HTML} at (0,0) size 800x461
-RenderBody {BODY} at (3,3) size 137x450 [border: (1px dashed #C0C0C0)]
-  RenderBlock {P} at (1,10) size 135x27
+layer at (0,0) size 800x469
+  RenderBlock {HTML} at (0,0) size 800x469
+RenderBody {BODY} at (4,4) size 140x457 [border: (1px dashed #C0C0C0)]
+  RenderBlock {P} at (1,10) size 138x27
 RenderText {#text} at (0,0) size 135x28
   text run at (0,0) width 133: "The following six blue boxes must"
   text run at (0,9) width 135: "be of the same width. There must be"
   text run at (0,18) width 26: "no red."
-  RenderBlock {P} at (10,46) size 117x27 [bgcolor=#008000] [border: (9px solid #FF)]
+  RenderBlock {P} at (10,46) size 120x27 [bgcolor=#008000] [border: (9px solid #FF)]
 RenderText {#text} at (9,9) size 2x10
   text run at (9,9) width 2: " "
-  RenderBlock {P} at (1,127) size 135x9
+  RenderBlock {P} at (1,128) size 138x9
 RenderText {#text} at (0,0) size 12x10
   text run at (0,0) width 12: "  "
 RenderText {#text} at (0,0) size 0x0
-RenderEmbeddedObject {OBJECT} at (9,0) size 117x43 [bgcolor=#FF] [border: (9px solid #FF)]
-  layer at (0,0) size 99x25
-RenderView at (0,0) size 99x25
-  layer at (0,0) size 99x25
-RenderSVGRoot {svg} at (0,0) size 99x25
-  RenderSVGRect {rect} at (0,0) size 99x25 [stroke={[type=SOLID] [color=#008000] [stroke width=12.00]}] [fill={[type=SOLID] [color=#00FF00]}] [x=0.00] [y=0.00] [width=1000.00] [height=250.00]
-  RenderSVGPath {path} at (14,4) size 71x16 [fill={[type=SOLID] [color=#008000]}] [data="" 500 50 L 150 200 L 850 200 Z"]
-  RenderBlock {P} at (1,190) size 135x9
-RenderEmbeddedObject {OBJECT} at (9,0) size 117x43 [bgcolor=#FF] [border: (9px solid #FF)]
-  layer at (0,0) size 99x25
-RenderView at (0,0) size 99x25
-  layer at (0,0) size 99x25
-RenderSVGRoot {svg} at (0,0) size 99x25
-  RenderSVGRect {rect} at (0,0) size 99x25 [stroke={[type=SOLID] [color=#008000] [stroke width=12.00]}] [fill={[type=SOLID] [color=#00FF00]}] [x=0.00] [y=0.00] [width=1000.00] [height=250.00]
-  RenderSVGPath {path} at (14,4) size 71x16 [fill={[type=SOLID] [color=#008000]}] [data="" 500 50 L 150 200 L 850 200 Z"]
-  RenderTable at (1,253) size 135x44
-RenderTableSection (anonymous) a

[webkit-changes] [111341] trunk/LayoutTests

2012-03-19 Thread slewis

Title: [111341] trunk/LayoutTests








Revision 111341
Author sle...@apple.com
Date 2012-03-19 20:27:27 -0700 (Mon, 19 Mar 2012)


Log Message
	http://bugs.webkit.org/show_bug.cgi?id=81618
fast/workers/storage/use-same-database-in-page-and-workers.html times out on the lion bots
parser test that times out waiting for notifyDone

Unreviewed.

Skip test that times out on the Lion WK1 bots.

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (111340 => 111341)

--- trunk/LayoutTests/ChangeLog	2012-03-20 03:22:34 UTC (rev 111340)
+++ trunk/LayoutTests/ChangeLog	2012-03-20 03:27:27 UTC (rev 111341)
@@ -1,5 +1,17 @@
 2012-03-19  Stephanie Lewis  
 
+	http://bugs.webkit.org/show_bug.cgi?id=81618
+fast/workers/storage/use-same-database-in-page-and-workers.html times out on the lion bots
+parser test that times out waiting for notifyDone
+
+Unreviewed.
+
+Skip test that times out on the Lion WK1 bots.
+
+* platform/mac/Skipped:
+
+2012-03-19  Stephanie Lewis  
+
 https://bugs.webkit.org/show_bug.cgi?id=81620 tables/mozilla/bugs/bug27038-* fail on Lion Bots.
 
 Unreviewed.


Modified: trunk/LayoutTests/platform/mac/Skipped (111340 => 111341)

--- trunk/LayoutTests/platform/mac/Skipped	2012-03-20 03:22:34 UTC (rev 111340)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-03-20 03:27:27 UTC (rev 111341)
@@ -598,3 +598,8 @@
 http/tests/media/video-buffering-repaints-controls.html
 http/tests/media/video-useragent.html
 media/audio-garbage-collect.html
+ 
+# parser test that times out waiting for notifyDone
+# http://bugs.webkit.org/show_bug.cgi?id=81618
+fast/workers/storage/use-same-database-in-page-and-workers.html
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111339] trunk/LayoutTests

2012-03-19 Thread slewis

Title: [111339] trunk/LayoutTests








Revision 111339
Author sle...@apple.com
Date 2012-03-19 20:17:10 -0700 (Mon, 19 Mar 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=81620 tables/mozilla/bugs/bug27038-* fail on Lion Bots.

Unreviewed.

Check in new expected (failing?) results.

* platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (111338 => 111339)

--- trunk/LayoutTests/ChangeLog	2012-03-20 03:14:24 UTC (rev 111338)
+++ trunk/LayoutTests/ChangeLog	2012-03-20 03:17:10 UTC (rev 111339)
@@ -1,3 +1,14 @@
+2012-03-19  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=81620 tables/mozilla/bugs/bug27038-* fail on Lion Bots.
+
+Unreviewed.
+
+Check in new expected (failing?) results.
+
+* platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
+* platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:
+
 2012-03-19  Tim Horton  
 
 [WK2] http/tests/websocket/tests/hixie76/frame-lengths.html times out on mac-wk2


Modified: trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt (111338 => 111339)

--- trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt	2012-03-20 03:14:24 UTC (rev 111338)
+++ trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt	2012-03-20 03:17:10 UTC (rev 111339)
@@ -4,9 +4,9 @@
   RenderBlock {HTML} at (0,0) size 800x600
 RenderBody {BODY} at (8,8) size 784x584
   RenderTable {TABLE} at (0,0) size 64x584
-RenderTableSection {THEAD} at (0,0) size 64x24
-  RenderTableRow {TR} at (0,2) size 64x20
-RenderTableCell {TD} at (2,2) size 60x20 [r=0 c=0 rs=1 cs=1]
+RenderTableSection {THEAD} at (0,0) size 64x536
+  RenderTableRow {TR} at (0,2) size 64x532
+RenderTableCell {TD} at (2,258) size 60x20 [r=0 c=0 rs=1 cs=1]
   RenderText {#text} at (1,1) size 58x18
 text run at (1,1) width 58: "THEAD"
 RenderTableSection {TFOOT} at (0,560) size 64x24
@@ -14,8 +14,8 @@
 RenderTableCell {TD} at (2,2) size 60x20 [r=0 c=0 rs=1 cs=1]
   RenderText {#text} at (1,1) size 56x18
 text run at (1,1) width 56: "TFOOT"
-RenderTableSection {TBODY} at (0,24) size 64x536
-  RenderTableRow {TR} at (0,2) size 64x532
-RenderTableCell {TD} at (2,258) size 60x20 [r=0 c=0 rs=1 cs=1]
+RenderTableSection {TBODY} at (0,536) size 64x24
+  RenderTableRow {TR} at (0,2) size 64x20
+RenderTableCell {TD} at (2,2) size 60x20 [r=0 c=0 rs=1 cs=1]
   RenderText {#text} at (1,1) size 57x18
 text run at (1,1) width 57: "TBODY"


Modified: trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt (111338 => 111339)

--- trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt	2012-03-20 03:14:24 UTC (rev 111338)
+++ trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt	2012-03-20 03:17:10 UTC (rev 111339)
@@ -27,9 +27,9 @@
 RenderText {#text} at (0,0) size 265x18
   text run at (0,0) width 265: "TABLE 2 - with 'height' style on TABLE"
   RenderTable {TABLE} at (0,172) size 69x584 [border: (3px solid #00)]
-RenderTableSection {THEAD} at (3,3) size 63x24
-  RenderTableRow {TR} at (0,2) size 63x20
-RenderTableCell {TD} at (2,2) size 59x20 [r=0 c=0 rs=1 cs=1]
+RenderTableSection {THEAD} at (3,3) size 63x530
+  RenderTableRow {TR} at (0,2) size 63x526
+RenderTableCell {TD} at (2,255) size 59x20 [r=0 c=0 rs=1 cs=1]
   RenderText {#text} at (1,1) size 56x18
 text run at (1,1) width 56: "THEAD"
 RenderTableSection {TFOOT} at (3,557) size 63x24
@@ -37,8 +37,8 @@
 RenderTableCell {TD} at (2,2) size 59x20 [r=0 c=0 rs=1 cs=1]
   RenderText {#text} at (1,1) size 53x18
 text run at (1,1) width 53: "TFOOT"
-RenderTableSection {TBODY} at (3,27) size 63x530
-  RenderTableRow {TR} at (0,2) size 63x526
-RenderTableCell {TD} at (2,255) size 59x20 [r=0 c=0 rs=1 cs=1]
+RenderTableSection {TBODY} at (3,533) size 63x24
+  RenderTableRow {TR} at (0,2) size 63x20
+RenderTableCell {TD} at (2,2) size 59x20 [r=0 c=0 rs=1 cs=1]
   RenderText {#text} at (1,1) size 57x18
 text run at (1,1) width 57: "TBODY"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111336] trunk/LayoutTests

2012-03-19 Thread slewis

Title: [111336] trunk/LayoutTests








Revision 111336
Author sle...@apple.com
Date 2012-03-19 20:12:09 -0700 (Mon, 19 Mar 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=81615 
fast/parser/nested-fragment-parser-crash.html is failing on the lion bots

Unreviewed.

Check in new expected (failing?) results.

* platform/mac/fast/parser/nested-fragment-parser-crash-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac/fast/parser/nested-fragment-parser-crash-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (111335 => 111336)

--- trunk/LayoutTests/ChangeLog	2012-03-20 03:10:45 UTC (rev 111335)
+++ trunk/LayoutTests/ChangeLog	2012-03-20 03:12:09 UTC (rev 111336)
@@ -1,5 +1,16 @@
 2012-03-19  Stephanie Lewis  
 
+https://bugs.webkit.org/show_bug.cgi?id=81615 
+fast/parser/nested-fragment-parser-crash.html is failing on the lion bots
+
+Unreviewed.
+
+Check in new expected (failing?) results.
+
+* platform/mac/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
+
+2012-03-19  Stephanie Lewis  
+
 https://bugs.webkit.org/show_bug.cgi?id=81617 fast/repaint/canvas-putImageData.html fails on the Lion bots
 
 Unreviewed.


Added: trunk/LayoutTests/platform/mac/fast/parser/nested-fragment-parser-crash-expected.txt (0 => 111336)

--- trunk/LayoutTests/platform/mac/fast/parser/nested-fragment-parser-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/parser/nested-fragment-parser-crash-expected.txt	2012-03-20 03:12:09 UTC (rev 111336)
@@ -0,0 +1,2 @@
+x
+x This test passes if it doesn't crash.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111334] trunk/LayoutTests

2012-03-19 Thread slewis

Title: [111334] trunk/LayoutTests








Revision 111334
Author sle...@apple.com
Date 2012-03-19 20:09:08 -0700 (Mon, 19 Mar 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=81617 fast/repaint/canvas-putImageData.html fails on the Lion bots

Unreviewed.

Check in new expected (failing?) results.

* platform/mac/fast/repaint/canvas-putImageData-expected.txt: Added.
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
trunk/LayoutTests/platform/mac/transforms/3d/general/perspective-non-layer-expected.txt


Added Paths

trunk/LayoutTests/platform/mac/fast/repaint/canvas-putImageData-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (111333 => 111334)

--- trunk/LayoutTests/ChangeLog	2012-03-20 03:08:21 UTC (rev 111333)
+++ trunk/LayoutTests/ChangeLog	2012-03-20 03:09:08 UTC (rev 111334)
@@ -1,3 +1,15 @@
+2012-03-19  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=81617 fast/repaint/canvas-putImageData.html fails on the Lion bots
+
+Unreviewed.
+
+Check in new expected (failing?) results.
+
+* platform/mac/fast/repaint/canvas-putImageData-expected.txt: Added.
+* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
+* platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
+
 2012-03-19  Keishi Hattori  
 
 [chromium] Rebaselining float-in-float-hit-testing and 056 in response


Added: trunk/LayoutTests/platform/mac/fast/repaint/canvas-putImageData-expected.txt (0 => 111334)

--- trunk/LayoutTests/platform/mac/fast/repaint/canvas-putImageData-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/repaint/canvas-putImageData-expected.txt	2012-03-20 03:09:08 UTC (rev 111334)
@@ -0,0 +1,9 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+  RenderText {#text} at (0,0) size 0x0
+  RenderText {#text} at (0,0) size 0x0
+layer at (8,8) size 100x100
+  RenderHTMLCanvas {CANVAS} at (0,0) size 100x100


Modified: trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt (111333 => 111334)

--- trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt	2012-03-20 03:08:21 UTC (rev 111333)
+++ trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt	2012-03-20 03:09:08 UTC (rev 111334)
@@ -143,6 +143,7 @@
   RenderText {#text} at (0,42) size 70x18
 text run at (0,42) width 70: "Comment: "
   RenderTextControl {INPUT} at (72,42) size 125x19 [color=#00] [bgcolor=#FF] [border: (2px inset #00)]
+RenderBlock {DIV} at (3,3) size 119x13
 RenderText {#text} at (199,42) size 4x18
   text run at (199,42) width 4: " "
 RenderButton {INPUT} at (205,43) size 54x18 [color=#00] [bgcolor=#C0C0C0]
@@ -173,5 +174,3 @@
 RenderBlock {P} at (21,1269) size 460x20 [border: (1px dotted #00)]
   RenderText {#text} at (1,1) size 170x18
 text run at (1,1) width 170: "Last updated in June 1999."
-layer at (356,1193) size 119x13
-  RenderBlock {DIV} at (3,3) size 119x13


Modified: trunk/LayoutTests/platform/mac/transforms/3d/general/perspective-non-layer-expected.txt (111333 => 111334)

--- trunk/LayoutTests/platform/mac/transforms/3d/general/perspective-non-layer-expected.txt	2012-03-20 03:08:21 UTC (rev 111333)
+++ trunk/LayoutTests/platform/mac/transforms/3d/general/perspective-non-layer-expected.txt	2012-03-20 03:09:08 UTC (rev 111334)
@@ -7,10 +7,9 @@
 RenderInline {SPAN} at (0,0) size 129x18
   RenderText {#text} at (0,0) size 0x0
   RenderTextControl {INPUT} at (2,2) size 125x19 [bgcolor=#FF] [border: (2px inset #00)]
+RenderBlock {DIV} at (3,3) size 119x13
   RenderText {#text} at (0,0) size 0x0
   RenderBlock (anonymous) at (0,23) size 784x0
 RenderBlock {DIV} at (0,0) size 784x0
   RenderBlock (anonymous) at (0,23) size 784x0
 RenderInline {SPAN} at (0,0) size 0x0
-layer at (13,13) size 119x13
-  RenderBlock {DIV} at (3,3) size 119x13






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [111326] trunk/LayoutTests

2012-03-19 Thread slewis

Title: [111326] trunk/LayoutTests








Revision 111326
Author sle...@apple.com
Date 2012-03-19 19:47:11 -0700 (Mon, 19 Mar 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=81610 fast/regions fail on Lion bots

Unreviewed.

Check in new expected (failing?) results.

* platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt
trunk/LayoutTests/platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt
trunk/LayoutTests/platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (111325 => 111326)

--- trunk/LayoutTests/ChangeLog	2012-03-20 02:47:03 UTC (rev 111325)
+++ trunk/LayoutTests/ChangeLog	2012-03-20 02:47:11 UTC (rev 111326)
@@ -1,5 +1,17 @@
 2012-03-19  Stephanie Lewis  
 
+https://bugs.webkit.org/show_bug.cgi?id=81610 fast/regions fail on Lion bots
+
+Unreviewed.
+
+Check in new expected (failing?) results.
+
+* platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
+* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
+* platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
+
+2012-03-19  Stephanie Lewis  
+
 https://bugs.webkit.org/show_bug.cgi?id=81608 fast/multicol/span/span-as-immediate… fail on Lion bots
 
 Unreviewed.


Modified: trunk/LayoutTests/platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt (111325 => 111326)

--- trunk/LayoutTests/platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt	2012-03-20 02:47:03 UTC (rev 111325)
+++ trunk/LayoutTests/platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt	2012-03-20 02:47:11 UTC (rev 111326)
@@ -19,15 +19,15 @@
   RenderBlock {DIV} at (5,5) size 390x222 [border: (1px solid #FF)]
 RenderBlock (floating) {DIV} at (6,6) size 50x50 [bgcolor=#00FF00]
 RenderBlock (floating) {DIV} at (334,6) size 50x50 [bgcolor=#00FF00]
-layer at (11,11) size 378x210 clip at (12,12) size 376x208
-  RenderBlock {DIV} at (6,6) size 378x210 [border: (1px solid #008000)]
-RenderBlock {P} at (1,17) size 376x72
+layer at (11,11) size 278x210 clip at (12,12) size 276x208 scrollWidth 376
+  RenderBlock {DIV} at (6,6) size 278x210 [border: (1px solid #008000)]
+RenderBlock {P} at (1,17) size 276x72
   RenderText {#text} at (50,0) size 276x72
 text run at (50,0) width 276: "These lines will not spill out of the regions."
 text run at (50,18) width 276: "These lines will not spill out of the regions."
 text run at (50,36) width 276: "These lines will not spill out of the regions."
 text run at (50,54) width 271: "These lines will not spill out of the regions."
-RenderBlock {P} at (1,105) size 376x88
+RenderBlock {P} at (1,105) size 276x88
   RenderText {#text} at (50,0) size 376x88
 text run at (50,0) width 276: "These lines will not spill out of the regions."
 text run at (0,34) width 276: "These lines will not spill out of the regions. "


Modified: trunk/LayoutTests/platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt (111325 => 111326)

--- trunk/LayoutTests/platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt	2012-03-20 02:47:03 UTC (rev 111325)
+++ trunk/LayoutTests/platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt	2012-03-20 02:47:11 UTC (rev 111326)
@@ -38,11 +38,7 @@
 text run at (0,72) width 216: "regions. These lines will not spill"
 text run at (-23,92) width 81: "out of the"
 text run at (-23,110) width 50: "regions."
-layer at (42,7) size 500x18 backgroundClip at (42,7) size 216x345 clip at (42,7) size 216x345 outlineClip at (42,7) size 216x345
-  RenderBlock {DIV} at (1,1) size 500x18
-RenderText {#text} at (-13,0) size 286x18
-  text run at (-13,0) width 286: "Clipped line of text that should not be visible."
-layer at (42,334) size 500x18 backgroundClip at (42,7) size 216x345 clip at (42,7) size 216x345 outlineClip at (42,7) size 216x345
+layer at (42,334) size 500x18 backgroundClip at (51,76) size 216x345 clip at (51,76) size 216x345 outlineClip at (51,76) size 216x345
   RenderBlock (positioned) {DIV} at (1,328) size 500x18
 RenderText {#text} at (-23,0) size 286x18
   text run at (-23,0) width 286: "Clipped line of text that should not be visible."


Modified: trunk/Layo

[webkit-changes] [103002] trunk/Tools

2011-12-15 Thread slewis

Title: [103002] trunk/Tools








Revision 103002
Author sle...@apple.com
Date 2011-12-15 17:08:25 -0800 (Thu, 15 Dec 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=74469
Escape paths to svn commands so our tools can handle filenames with @ symbols.

Reviewed by Adam Roben.

* Scripts/VCSUtils.pm:
(scmMoveOrRenameFile):
(scmAddExecutableBit):
(scmRemoveExecutableBit):
(determineSVNRoot):
(svnRevisionForDirectory):
(pathRelativeToSVNRepositoryRootForPath):
(svnStatus):
(escapeSubversionPath):
* Scripts/parse-malloc-history:
(main):
* Scripts/prepare-ChangeLog:
(diffCommand):
(statusCommand):
(findOriginalFileFromSvn):
(determinePropertyChanges):
* Scripts/resolve-ChangeLogs:
(conflictFiles):
(resolveConflict):
(showStatus):
* Scripts/svn-apply:
(patch):
(scmCopy):
(scmAdd):
(scmRemove):
* Scripts/svn-create-patch:
(findBaseUrl):
(findMimeType):
(findSourceFileAndRevision):
(generateDiff):
(generateFileList):
(manufacturePatchForAdditionWithHistory):
* Scripts/svn-unapply:
(patch):
(revertDirectories):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/VCSUtils.pm
trunk/Tools/Scripts/prepare-ChangeLog
trunk/Tools/Scripts/resolve-ChangeLogs
trunk/Tools/Scripts/svn-apply
trunk/Tools/Scripts/svn-create-patch
trunk/Tools/Scripts/svn-unapply




Diff

Modified: trunk/Tools/ChangeLog (103001 => 103002)

--- trunk/Tools/ChangeLog	2011-12-16 00:59:39 UTC (rev 103001)
+++ trunk/Tools/ChangeLog	2011-12-16 01:08:25 UTC (rev 103002)
@@ -1,3 +1,46 @@
+2011-12-15  Stephanie Lewis  
+
+https://bugs.webkit.org/show_bug.cgi?id=74469
+Escape paths to svn commands so our tools can handle filenames with @ symbols.
+
+Reviewed by Adam Roben.
+
+* Scripts/VCSUtils.pm:
+(scmMoveOrRenameFile):
+(scmAddExecutableBit):
+(scmRemoveExecutableBit):
+(determineSVNRoot):
+(svnRevisionForDirectory):
+(pathRelativeToSVNRepositoryRootForPath):
+(svnStatus):
+(escapeSubversionPath):
+* Scripts/parse-malloc-history:
+(main):
+* Scripts/prepare-ChangeLog:
+(diffCommand):
+(statusCommand):
+(findOriginalFileFromSvn):
+(determinePropertyChanges):
+* Scripts/resolve-ChangeLogs:
+(conflictFiles):
+(resolveConflict):
+(showStatus):
+* Scripts/svn-apply:
+(patch):
+(scmCopy):
+(scmAdd):
+(scmRemove):
+* Scripts/svn-create-patch:
+(findBaseUrl):
+(findMimeType):
+(findSourceFileAndRevision):
+(generateDiff):
+(generateFileList):
+(manufacturePatchForAdditionWithHistory):
+* Scripts/svn-unapply:
+(patch):
+(revertDirectories):
+
 2011-12-15  Michael Bruning  
 
 [qt][wk2] MiniBrowser: Add pressed state for viewport info button.


Modified: trunk/Tools/Scripts/VCSUtils.pm (103001 => 103002)

--- trunk/Tools/Scripts/VCSUtils.pm	2011-12-16 00:59:39 UTC (rev 103001)
+++ trunk/Tools/Scripts/VCSUtils.pm	2011-12-16 01:08:25 UTC (rev 103002)
@@ -55,6 +55,7 @@
 &decodeGitBinaryPatch
 &determineSVNRoot
 &determineVCSRoot
+&escapeSubversionPath
 &exitStatus
 &fixChangeLogPatch
 &gitBranch
@@ -153,7 +154,9 @@
 my ($source, $destination) = @_;
 return if ! -e $source;
 if (isSVN()) {
-system("svn", "move", $source, $destination);
+my $escapedDestination = escapeSubversionPath($destination);
+my $escapedSource = escapeSubversionPath($source);
+system("svn", "move", $escapedSource, $escapedDestination);
 } elsif (isGit()) {
 system("git", "mv", $source, $destination);
 }
@@ -176,7 +179,8 @@
 my ($path) = @_;
 
 if (isSVN()) {
-system("svn", "propset", "svn:executable", "on", $path) == 0 or die "Failed to run 'svn propset svn:executable on $path'.";
+my $escapedPath = escapeSubversionPath($path);
+system("svn", "propset", "svn:executable", "on", $escapedPath) == 0 or die "Failed to run 'svn propset svn:executable on $escapedPath'.";
 } elsif (isGit()) {
 chmod(0755, $path);
 }
@@ -187,7 +191,8 @@
 my ($path) = @_;
 
 if (isSVN()) {
-system("svn", "propdel", "svn:executable", $path) == 0 or die "Failed to run 'svn propdel svn:executable $path'.";
+my $escapedPath = escapeSubversionPath($path);
+system("svn", "propdel", "svn:executable", $escapedPath) == 0 or die "Failed to run 'svn propdel svn:executable $escapedPath'.";
 } elsif (isGit()) {
 chmod(0664, $path);
 }
@@ -304,8 +309,9 @@
 while (1) {
 my $thisRoot;
 my $thisUUID;
+my $escapedPath = escapeSubversionPath($path);
 # Ignore error messages in case we've run past the root of the checkout.
-open INFO, "svn info '$path' 2> " . File::Spec->devnull() . " |" or die;
+open INFO, "svn info '$escapedPath' 2> " . File::Spec->devnull

[webkit-changes] [92160] trunk/Tools

2011-08-01 Thread slewis

Title: [92160] trunk/Tools








Revision 92160
Author sle...@apple.com
Date 2011-08-01 18:16:43 -0700 (Mon, 01 Aug 2011)


Log Message
Finish reconfiguration started by Lucas Forschler
Reconfigured slaves:
Removed Leopard Intel Release (Build)
Removed Leopard Intel Release (Tests)
Remove apple-pixel-1
Added Lion slaves from disabled Leopard slaves

Added builders:
Lion Intel Release (Build)
Lion Intel Debug (Build)
Lion Intel Release (Tests)
Lion Intel Release WK2 (Tests)
Lion Intel Debug (Tests)
Lion Intel Debug WK2 (Tests)

Added triggers:
lion-intel-debug-tests
lion-intel-debug-test-wk2
lion-intel-release-tests
lion-intel-release-tests-wk2

Removed trigger:
leopard-intel-release-tests

Added PlatformSpecificScheduler:
mac-lion

Added "mac-lion" to build.py and build_unitttest.py

Reviewed by Mark Rowe.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* Scripts/webkitpy/common/config/build.py:
* Scripts/webkitpy/common/config/build_unittest.py:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/build.py
trunk/Tools/Scripts/webkitpy/common/config/build_unittest.py




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (92159 => 92160)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2011-08-02 00:59:31 UTC (rev 92159)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2011-08-02 01:16:43 UTC (rev 92160)
@@ -2,27 +2,26 @@
 "slaves": [ { "name": "test-slave", "platform": "*" },
 
 { "name": "apple-xserve-1", "platform": "mac-leopard" },
-{ "name": "apple-xserve-2", "platform": "mac-leopard" },
-{ "name": "apple-xserve-3", "platform": "mac-leopard" },
-
+{ "name": "apple-macpro-7", "platform": "mac-leopard" },	
+  
 { "name": "apple-xserve-4", "platform": "mac-snowleopard" },
 { "name": "apple-xserve-5", "platform": "mac-snowleopard" },
 { "name": "apple-xserve-6", "platform": "mac-snowleopard" },
 { "name": "apple-xserve-7", "platform": "mac-snowleopard" },
 { "name": "apple-xserve-8", "platform": "mac-snowleopard" },	
 { "name": "apple-xserve-9", "platform": "mac-snowleopard" },	
-
-{ "name": "apple-pixel-1", "platform": "mac-leopard" },
-
 { "name": "apple-macpro-1", "platform": "mac-snowleopard" },
 { "name": "apple-macpro-2", "platform": "mac-snowleopard" },
 { "name": "apple-macpro-3", "platform": "mac-snowleopard" },
-{ "name": "apple-macpro-4", "platform": "mac-leopard" },
-{ "name": "apple-macpro-5", "platform": "mac-leopard" },	
-{ "name": "apple-macpro-6", "platform": "mac-leopard" },
-{ "name": "apple-macpro-7", "platform": "mac-leopard" },	
-	
 
+{ "name": "apple-macpro-4", "platform": "mac-lion" },
+{ "name": "apple-macpro-5", "platform": "mac-lion" },	
+{ "name": "apple-macpro-6", "platform": "mac-lion" },
+{ "name": "apple-macpro-8", "platform": "mac-lion" },	
+{ "name": "apple-xserve-2", "platform": "mac-lion" },
+{ "name": "apple-xserve-3", "platform": "mac-lion" },
+{ "name": "apple-xserve-10", "platform": "mac-lion" },
+
 { "name": "apple-windows-1", "platform": "win"},
 { "name": "apple-windows-2", "platform": "win"},
 { "name": "apple-windows-3", "platform": "win"},
@@ -72,24 +71,14 @@
 { "name": "hfreyther-mipsel-linux1", "platform": "qt"}
   ],
 
-"builders":   [ { "name": "Leopard Intel Release (Build)", "type": "Build", "builddir": "leopard-intel-release",
-  "platform": "mac-leopard", "configuration": "release", "architectures": ["i386"],
-  "triggers": ["leopard-intel-release-tests"],
-  "slavenames": ["apple-xserve-1", "apple-xserve-2", "test-slave"]
-},
-{ "name": "Leopard Intel Release (Tests)", "type": "Test", "builddir": "leopard-intel-release-tests",
-  "platform": "mac-leopard", "configuration": "release", "architectures": ["i386"],
-  "slavenames": ["apple-macpro-4", "apple-pixel-1", "test-slave", "apple-macpro-7"]
-},
-
-{ "name": "Leopard Intel Debug (Build)", "type": "Build", "builddir": "leopard-intel-debug",
+"builders":   [ { "name": "Leopard Intel Debug (Build)", "type": "Build", "builddir": "leopard-intel-debug",
   "platform":

[webkit-changes] [91869] trunk/Source/JavaScriptCore

2011-07-27 Thread slewis

Title: [91869] trunk/Source/_javascript_Core








Revision 91869
Author sle...@apple.com
Date 2011-07-27 14:44:49 -0700 (Wed, 27 Jul 2011)


Log Message
Revert http://trac.webkit.org/changeset/90415.
Caused a 5% sunspider regression in-browser.

Unreviewed rollout.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
* heap/MarkStack.h:
(JSC::MarkStack::MarkStack):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::releaseExecutableMemory):
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::invalidateCode):
* runtime/RegExp.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/MarkStack.h
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/RegExp.cpp
trunk/Source/_javascript_Core/runtime/RegExp.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (91868 => 91869)

--- trunk/Source/_javascript_Core/ChangeLog	2011-07-27 21:20:57 UTC (rev 91868)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-07-27 21:44:49 UTC (rev 91869)
@@ -1,3 +1,23 @@
+2011-07-27  Stephanie Lewis  
+
+Revert http://trac.webkit.org/changeset/90415.
+Caused a 5% sunspider regression in-browser.
+
+Unreviewed rollout.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::visitAggregate):
+* heap/Heap.cpp:
+(JSC::Heap::collectAllGarbage):
+* heap/MarkStack.h:
+(JSC::MarkStack::MarkStack):
+* runtime/JSGlobalData.cpp:
+(JSC::JSGlobalData::releaseExecutableMemory):
+* runtime/RegExp.cpp:
+(JSC::RegExp::compile):
+(JSC::RegExp::invalidateCode):
+* runtime/RegExp.h:
+
 2011-07-27  Shinya Kawanaka  
 
 Added an interface to take IsWhiteSpaceFunctionPtr.


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (91868 => 91869)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-07-27 21:20:57 UTC (rev 91868)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-07-27 21:44:49 UTC (rev 91869)
@@ -1546,8 +1546,6 @@
 for (size_t i = 0; i < m_functionDecls.size(); ++i)
 visitor.append(&m_functionDecls[i]);
 #if ENABLE(JIT)
-if (visitor.shouldUnlinkCalls())
-unlinkCalls();
 for (unsigned i = 0; i < numberOfCallLinkInfos(); ++i)
 if (callLinkInfo(i).isLinked())
 visitor.append(&callLinkInfo(i).callee);


Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (91868 => 91869)

--- trunk/Source/_javascript_Core/heap/Heap.cpp	2011-07-27 21:20:57 UTC (rev 91868)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp	2011-07-27 21:44:49 UTC (rev 91869)
@@ -539,9 +539,10 @@
 {
 if (!m_isSafeToCollect)
 return;
-m_slotVisitor.setShouldUnlinkCalls(true);
+if (!m_globalData->dynamicGlobalObject)
+m_globalData->recompileAllJSFunctions();
+
 collect(DoSweep);
-m_slotVisitor.setShouldUnlinkCalls(false);
 }
 
 void Heap::collect(SweepToggle sweepToggle)


Modified: trunk/Source/_javascript_Core/heap/MarkStack.h (91868 => 91869)

--- trunk/Source/_javascript_Core/heap/MarkStack.h	2011-07-27 21:20:57 UTC (rev 91868)
+++ trunk/Source/_javascript_Core/heap/MarkStack.h	2011-07-27 21:44:49 UTC (rev 91869)
@@ -97,9 +97,6 @@
 
 void reset();
 
-bool shouldUnlinkCalls() const { return m_shouldUnlinkCalls; }
-void setShouldUnlinkCalls(bool shouldUnlinkCalls) { m_shouldUnlinkCalls = shouldUnlinkCalls; }
-
 protected:
 #if ENABLE(GC_VALIDATION)
 static void validateSet(JSValue*, size_t);
@@ -123,9 +120,6 @@
 bool m_isCheckingForDefaultMarkViolation;
 bool m_isDraining;
 #endif
-
-private:
-bool m_shouldUnlinkCalls;
 };
 
 inline MarkStack::MarkStack(void* jsArrayVPtr)
@@ -134,7 +128,6 @@
 , m_isCheckingForDefaultMarkViolation(false)
 , m_isDraining(false)
 #endif
-, m_shouldUnlinkCalls(false)
 {
 }
 


Modified: trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp (91868 => 91869)

--- trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp	2011-07-27 21:20:57 UTC (rev 91868)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp	2011-07-27 21:44:49 UTC (rev 91869)
@@ -497,9 +497,7 @@
 
 }
 heap.forEachCell(recompiler);
-} else
-recompileAllJSFunctions();
-
+}
 m_regExpCache->invalidateCode();
 heap.collectAllGarbage();
 }


Modified: trunk/Source/_javascript_Core/runtime/RegExp.cpp (91868 => 91869)

--- trunk/Source/_javascript_Core/runtime/RegExp.cpp	2011-07-27 21:20:57 UTC (rev 91868)
+++ trunk/Source/_javascript_Core/runtime/RegExp.cpp	2011-07-27 21:44:49 UTC (rev 91869)
@@ -113,7 +113,6 @@
 {
 ASSERT(m_state == NotCompiled);
 m_representation = adoptPtr(new RegExpRepresentation);
-m_state = Compiling;
 Yarr::YarrPattern patte

[webkit-changes] [89637] trunk/Source/JavaScriptCore

2011-06-23 Thread slewis

Title: [89637] trunk/Source/_javascript_Core








Revision 89637
Author sle...@apple.com
Date 2011-06-23 17:16:47 -0700 (Thu, 23 Jun 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=63298
Replace Malloc with FastMalloc to match the rest of wtf.

Reviewed by Darin Adler.

* wtf/BlockStack.h:
(WTF~BlockStack):
(WTFgrow):
(WTFshrink):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/BlockStack.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (89636 => 89637)

--- trunk/Source/_javascript_Core/ChangeLog	2011-06-24 00:15:26 UTC (rev 89636)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-06-24 00:16:47 UTC (rev 89637)
@@ -1,3 +1,15 @@
+2011-06-23  Stephanie Lewis  
+
+Reviewed by Darin Adler.
+
+https://bugs.webkit.org/show_bug.cgi?id=63298
+Replace Malloc with FastMalloc to match the rest of wtf.
+
+* wtf/BlockStack.h:
+(WTF~BlockStack):
+(WTFgrow):
+(WTFshrink):
+
 2011-06-23  Oliver Hunt  
 
 Reviewed by Gavin Barraclough.


Modified: trunk/Source/_javascript_Core/wtf/BlockStack.h (89636 => 89637)

--- trunk/Source/_javascript_Core/wtf/BlockStack.h	2011-06-24 00:15:26 UTC (rev 89636)
+++ trunk/Source/_javascript_Core/wtf/BlockStack.h	2011-06-24 00:16:47 UTC (rev 89637)
@@ -27,6 +27,7 @@
 #define BlockStack_h
 
 #include 
+#include 
 #include 
 
 namespace WTF {
@@ -57,9 +58,9 @@
 template  BlockStack::~BlockStack()
 {
 if (m_spareBlock)
-free(m_spareBlock);
+fastFree(m_spareBlock);
 for (size_t i = 0; i < m_blocks.size(); ++i)
-free(m_blocks[i]);
+fastFree(m_blocks[i]);
 }
 
 template  inline const Vector& BlockStack::blocks()
@@ -69,7 +70,7 @@
 
 template  T* BlockStack::grow()
 {
-T* block = m_spareBlock ? m_spareBlock : static_cast(malloc(blockSize));
+T* block = m_spareBlock ? m_spareBlock : static_cast(fastMalloc(blockSize));
 m_spareBlock = 0;
 
 m_blocks.append(block);
@@ -83,7 +84,7 @@
 m_blocks.removeLast();
 
 while (m_blocks.last() + blockLength != newEnd) {
-free(m_blocks.last());
+fastFree(m_blocks.last());
 m_blocks.removeLast();
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88607] trunk/Source/WebKit2

2011-06-11 Thread slewis

Title: [88607] trunk/Source/WebKit2








Revision 88607
Author sle...@apple.com
Date 2011-06-11 13:28:54 -0700 (Sat, 11 Jun 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=62480
part of 
Add API to launch the WebProcess.  Launching it earlier can save time 
when loading the first page.

Reviewed by Sam Weinig.

* UIProcess/API/C/WKContext.cpp:
(WKContextWarmInitialProcess):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::warmInitialProcess):
* UIProcess/WebContext.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (88606 => 88607)

--- trunk/Source/WebKit2/ChangeLog	2011-06-11 20:21:55 UTC (rev 88606)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-11 20:28:54 UTC (rev 88607)
@@ -1,3 +1,19 @@
+2011-06-11  Stephanie Lewis  
+
+Reviewed by Sam Weinig.
+
+https://bugs.webkit.org/show_bug.cgi?id=62480
+part of 
+Add API to launch the WebProcess.  Launching it earlier can save time 
+when loading the first page.
+
+* UIProcess/API/C/WKContext.cpp:
+(WKContextWarmInitialProcess):
+* UIProcess/API/C/WKContextPrivate.h:
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::warmInitialProcess):
+* UIProcess/WebContext.h:
+
 2011-06-09  Jer Noble  
 
 Reviewed by Darin Adler.


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (88606 => 88607)

--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp	2011-06-11 20:21:55 UTC (rev 88606)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp	2011-06-11 20:28:54 UTC (rev 88607)
@@ -232,3 +232,9 @@
 {
 toImpl(contextRef)->setHTTPPipeliningEnabled(enabled);
 }
+
+void WKContextWarmInitialProcess(WKContextRef contextRef)
+{
+toImpl(contextRef)->warmInitialProcess();
+}
+


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h (88606 => 88607)

--- trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h	2011-06-11 20:21:55 UTC (rev 88606)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h	2011-06-11 20:28:54 UTC (rev 88607)
@@ -67,6 +67,8 @@
 WK_EXPORT void WKContextEnableProcessTermination(WKContextRef context);
 
 WK_EXPORT void _WKContextSetHTTPPipeliningEnabled(WKContextRef context, bool enabled);
+
+WK_EXPORT void WKContextWarmInitialProcess(WKContextRef context);
 
 #ifdef __cplusplus
 }


Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (88606 => 88607)

--- trunk/Source/WebKit2/UIProcess/WebContext.cpp	2011-06-11 20:21:55 UTC (rev 88606)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp	2011-06-11 20:28:54 UTC (rev 88607)
@@ -260,6 +260,11 @@
 m_pendingMessagesToPostToInjectedBundle.clear();
 }
 
+void WebContext::warmInitialProcess()  
+{
+ensureWebProcess();
+}
+
 void WebContext::enableProcessTermination()
 {
 m_processTerminationEnabled = true;


Modified: trunk/Source/WebKit2/UIProcess/WebContext.h (88606 => 88607)

--- trunk/Source/WebKit2/UIProcess/WebContext.h	2011-06-11 20:21:55 UTC (rev 88606)
+++ trunk/Source/WebKit2/UIProcess/WebContext.h	2011-06-11 20:28:54 UTC (rev 88607)
@@ -165,6 +165,7 @@
 void setLocalStorageDirectory(const String& dir) { m_overrideLocalStorageDirectory = dir; }
 
 void ensureWebProcess();
+void warmInitialProcess();
 
 bool shouldTerminate(WebProcessProxy*);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87580] trunk/Source

2011-05-27 Thread slewis

Title: [87580] trunk/Source








Revision 87580
Author sle...@apple.com
Date 2011-05-27 15:57:53 -0700 (Fri, 27 May 2011)


Log Message
Unreviewed.

Fix a typo in the order_file flag.

Source/_javascript_Core: 

* Configurations/Base.xcconfig:

Source/WebCore: 

* Configurations/Base.xcconfig:

Source/WebKit/mac: 

* Configurations/Base.xcconfig:

Source/WebKit2: 

* Configurations/Base.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/Base.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/Base.xcconfig
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/Base.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/Base.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (87579 => 87580)

--- trunk/Source/_javascript_Core/ChangeLog	2011-05-27 22:32:01 UTC (rev 87579)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-27 22:57:53 UTC (rev 87580)
@@ -1,3 +1,11 @@
+2011-05-27  Stephanie Lewis  
+
+Unreviewed.
+
+Fix a typo in the order_file flag.
+
+* Configurations/Base.xcconfig:
+
 2011-05-27  Patrick Gansterer  
 
 Unreviewed. Build fix for !ENABLE(ASSEMBLER) after r87527.


Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (87579 => 87580)

--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2011-05-27 22:32:01 UTC (rev 87579)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2011-05-27 22:57:53 UTC (rev 87580)
@@ -102,7 +102,7 @@
 DEAD_CODE_STRIPPING_normal = YES;
 DEAD_CODE_STRIPPING = $(DEAD_CODE_STRIPPING_$(CURRENT_VARIANT));
 
-SECTORDER_FLAGS = -W1,-order_file,_javascript_Core.order;
+SECTORDER_FLAGS = -Wl,-order_file,_javascript_Core.order;
 
 // FIXME: Disable C++ exceptions in the LLVM Compiler once it supports enabling Obj-C exceptions without C++ exceptions.
 GCC_ENABLE_CPP_EXCEPTIONS = $(GCC_ENABLE_CPP_EXCEPTIONS_$(TARGET_GCC_VERSION));


Modified: trunk/Source/WebCore/ChangeLog (87579 => 87580)

--- trunk/Source/WebCore/ChangeLog	2011-05-27 22:32:01 UTC (rev 87579)
+++ trunk/Source/WebCore/ChangeLog	2011-05-27 22:57:53 UTC (rev 87580)
@@ -1,3 +1,11 @@
+2011-05-27  Stephanie Lewis  
+
+Unreviewed.
+
+Fix a typo in the order_file flag.
+
+* Configurations/Base.xcconfig:
+
 2011-05-27  Anders Carlsson  
 
 Reviewed by Sam Weinig.


Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (87579 => 87580)

--- trunk/Source/WebCore/Configurations/Base.xcconfig	2011-05-27 22:32:01 UTC (rev 87579)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig	2011-05-27 22:57:53 UTC (rev 87580)
@@ -92,7 +92,7 @@
 DEAD_CODE_STRIPPING_normal = YES;
 DEAD_CODE_STRIPPING = $(DEAD_CODE_STRIPPING_$(CURRENT_VARIANT));
 
-SECTORDER_FLAGS = -W1,-order_file,WebCore.order;
+SECTORDER_FLAGS = -Wl,-order_file,WebCore.order;
 
 WEBCORE_SQLITE3_HEADER_SEARCH_PATHS = $(NEXT_ROOT)/usr/local/include/WebCoreSQLite3;
 SQLITE3_HEADER_SEARCH_PATHS = $(SQLITE3_HEADER_SEARCH_PATHS_$(REAL_PLATFORM_NAME));


Modified: trunk/Source/WebKit/mac/ChangeLog (87579 => 87580)

--- trunk/Source/WebKit/mac/ChangeLog	2011-05-27 22:32:01 UTC (rev 87579)
+++ trunk/Source/WebKit/mac/ChangeLog	2011-05-27 22:57:53 UTC (rev 87580)
@@ -1,5 +1,13 @@
 2011-05-27  Stephanie Lewis  
 
+Unreviewed.
+
+Fix a typo in the order_file flag.
+
+* Configurations/Base.xcconfig:
+
+2011-05-27  Stephanie Lewis  
+
 Rubber Stamped by Adam Roben.
 
 Update Order Files.  Use -order_file flag since it can order more of the binary.


Modified: trunk/Source/WebKit/mac/Configurations/Base.xcconfig (87579 => 87580)

--- trunk/Source/WebKit/mac/Configurations/Base.xcconfig	2011-05-27 22:32:01 UTC (rev 87579)
+++ trunk/Source/WebKit/mac/Configurations/Base.xcconfig	2011-05-27 22:57:53 UTC (rev 87580)
@@ -88,7 +88,7 @@
 // building the MiG bindings for WebKitPluginClient even when the functions that the bindings wrap are not built.
 DEAD_CODE_STRIPPING = YES;
 
-SECTORDER_FLAGS = -W1,-order_file,mac/WebKit.order;
+SECTORDER_FLAGS = -Wl,-order_file,mac/WebKit.order;
 
 // FIXME: Disable C++ exceptions in the LLVM Compiler once it supports enabling Obj-C exceptions without C++ exceptions.
 GCC_ENABLE_CPP_EXCEPTIONS = $(GCC_ENABLE_CPP_EXCEPTIONS_$(TARGET_GCC_VERSION));


Modified: trunk/Source/WebKit2/ChangeLog (87579 => 87580)

--- trunk/Source/WebKit2/ChangeLog	2011-05-27 22:32:01 UTC (rev 87579)
+++ trunk/Source/WebKit2/ChangeLog	2011-05-27 22:57:53 UTC (rev 87580)
@@ -1,3 +1,11 @@
+2011-05-27  Stephanie Lewis  
+
+Unreviewed.
+
+Fix a typo in the order_file flag.
+
+* Configurations/Base.xcconfig:
+
 2011-05-27  Jeff Miller  
 
 Rubber-stamped by Steve Falkenburg.


Modified: trunk/Source/WebKit2/Configurations/Base.xcconfig (87579 => 87580)

--- trunk/Source/WebKit2/Configurations/Base.xcconfig	2011-05-27 22:32:01 UTC (rev 87579)
+++ trunk/Source/Web

[webkit-changes] [87460] trunk/Source/WebCore

2011-05-26 Thread slewis

Title: [87460] trunk/Source/WebCore








Revision 87460
Author sle...@apple.com
Date 2011-05-26 18:36:54 -0700 (Thu, 26 May 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=61345
part of 
Roll back in now that the Crashes are fixed.  ResourceResponseBase and ResourceResponse had two different definitions
for m_isNull.  ResourceResponse treats m_isNull as meaning there isn't any platform ResourceResponse. 
ResourceResponseBase treats m_isNull as meaning no fields have been initialized.  Consolidate calls into ResourceResponseBase meaning. 

Reviewed by Geoff Garen.

Don't initialize ResourceResponse.m_suggestedFilename until we want to use it.  Initializing it requires reading in and parsing a plist.  
Add new initialization state CommonAndUncommonFields to ResourceResponse.  This will be for all the header fields.
Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it. 
Add "Content-Type" to common headers since it is looked for by every CSS sheet load.

No new functionality so no new tests.

* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):
* platform/network/ResourceResponseBase.h:
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp
trunk/Source/WebCore/platform/network/ResourceResponseBase.h
trunk/Source/WebCore/platform/network/cf/ResourceResponse.h
trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp
trunk/Source/WebCore/platform/network/mac/ResourceResponseMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (87459 => 87460)

--- trunk/Source/WebCore/ChangeLog	2011-05-27 01:16:57 UTC (rev 87459)
+++ trunk/Source/WebCore/ChangeLog	2011-05-27 01:36:54 UTC (rev 87460)
@@ -1,3 +1,48 @@
+2011-05-26  Stephanie Lewis  
+
+Reviewed by Geoff Garen.
+
+https://bugs.webkit.org/show_bug.cgi?id=61345
+part of 
+Roll back in now that the Crashes are fixed.  ResourceResponseBase and ResourceResponse had two different definitions
+for m_isNull.  ResourceResponse treats m_isNull as meaning there isn't any platform ResourceResponse. 
+ResourceResponseBase treats m_isNull as meaning no fields have been initialized.  Consolidate calls into ResourceResponseBase meaning. 
+
+Don't initialize ResourceResponse.m_suggestedFilename until we want to use it.  Initializing it requires reading in and parsing a plist.  
+Add new initialization state CommonAndUncommonFields to ResourceResponse.  This will be for all the header fields.
+Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it. 
+Add "Content-Type" to common headers since it is looked for by every CSS sheet load.
+
+No new functionality so no new tests.
+
+* platform/network/ResourceResponseBase.cpp:
+(WebCore::ResourceResponseBase::adopt):
+(WebCore::ResourceResponseBase::suggestedFilename):
+(WebCore::ResourceResponseBase::setSuggestedFilename):
+(WebCore::ResourceResponseBase::httpStatusText):
+(WebCore::ResourceResponseBase::setHTTPStatusText):
+(WebCore::ResourceResponseBase::httpHeaderField):
+(WebCore::ResourceResponseBase::setHTTPHeaderField):
+(WebCore::ResourceResponseBase::httpHeaderFields):
+(WebCore::ResourceResponseBase::isAttachment):
+(WebCore::ResourceResponseBase::setLastModifiedDate):
+(WebCore::ResourceResponseBase::lastModifiedDate):
+(WebCore::ResourceResponseBase::wasCached):
+(WebCore::ResourceResponseBase::connectionReused):
+(WebCore::ResourceResponseBase::setConnectionReused):
+(WebCore::ResourceResponseBase::connectionID):
+(Web

[webkit-changes] [87329] trunk/Source

2011-05-25 Thread slewis

Title: [87329] trunk/Source








Revision 87329
Author sle...@apple.com
Date 2011-05-25 16:00:45 -0700 (Wed, 25 May 2011)


Log Message
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=61407
part of 
Move Quicklook quirk down into WebCore so it can be caculated when the user
starts a reload.  Restructure the conditions so it only called when absolutely 
necessary.
  
Reviewed by Brady Eidson.

No change in functionality so no new tests.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* platform/network/cf/ResourceRequest.h:
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::initQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):

Source/WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=61407
part of 
Remove Quicklook pref.  Moving it enirely down into WebCore so it can
be calculated only on reloads.

Reviewed by Brady Eidson.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/platform/network/cf/ResourceRequest.h
trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (87328 => 87329)

--- trunk/Source/WebCore/ChangeLog	2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/ChangeLog	2011-05-25 23:00:45 UTC (rev 87329)
@@ -1,3 +1,25 @@
+2011-05-25  Stephanie Lewis  
+
+Reviewed by Brady Eidson.
+
+https://bugs.webkit.org/show_bug.cgi?id=61407
+part of 
+Move Quicklook quirk down into WebCore so it can be caculated when the user
+starts a reload.  Restructure the conditions so it only called when absolutely 
+necessary.
+  
+No change in functionality so no new tests.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::subresourceCachePolicy):
+* page/Settings.cpp:
+(WebCore::Settings::Settings):
+* page/Settings.h:
+* platform/network/cf/ResourceRequest.h:
+* platform/network/mac/ResourceRequestMac.mm:
+(WebCore::initQuickLookResourceCachingQuirks):
+(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
+
 2011-05-24  Jer Noble  
 
 Reviewed by Darin Adler.


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (87328 => 87329)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2011-05-25 23:00:45 UTC (rev 87329)
@@ -2407,15 +2407,16 @@
 if (parentCachePolicy != CachePolicyVerify)
 return parentCachePolicy;
 }
+
+if (m_loadType == FrameLoadTypeReload)
+return CachePolicyRevalidate;
 
 const ResourceRequest& request(documentLoader()->request());
-Settings* settings = m_frame->settings();
-if (settings && settings->useQuickLookResourceCachingQuirks() && request.cachePolicy() == ReloadIgnoringCacheData && !equalIgnoringCase(request.httpMethod(), "post"))
+#if PLATFORM(MAC)
+if (request.cachePolicy() == ReloadIgnoringCacheData && !equalIgnoringCase(request.httpMethod(), "post") && ResourceRequest::useQuickLookResourceCachingQuirks())
 return CachePolicyRevalidate;
+#endif
 
-if (m_loadType == FrameLoadTypeReload)
-return CachePolicyRevalidate;
-
 if (request.cachePolicy() == ReturnCacheDataElseLoad)
 return CachePolicyHistoryBuffer;
 


Modified: trunk/Source/WebCore/page/Settings.cpp (87328 => 87329)

--- trunk/Source/WebCore/page/Settings.cpp	2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/page/Settings.cpp	2011-05-25 23:00:45 UTC (rev 87329)
@@ -177,7 +177,6 @@
 , m_usePreHTML5ParserQuirks(false)
 , m_hyperlinkAuditingEnabled(false)
 , m_crossOriginCheckInGetMatchedCSSRulesDisabled(false)
-, m_useQuickLookResourceCachingQuirks(false)
 , m_forceCompositingMode(false)
 , m_shouldInjectUserScriptsInInitialEmptyDocument(false)
 , m_allowDisplayOfInsecureContent(true)


Modified: trunk/Source/WebCore/page/Settings.h (87328 => 87329)

--- trunk/Source/WebCore/page/Settings.h	2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/page/Settings.h	2011-05-25 23:00:45 UTC (rev 87329)
@@ -394,9 +394,6 @@
 void setCrossOriginCheckInGetMatchedCSSRulesDisabled(bool flag) { m_crossOriginCheckInGetMatchedCSSRulesDisabled = flag; }
 bool crossOriginCheckInGetMatchedCSSRu

[webkit-changes] [87229] trunk/Source/WebCore

2011-05-24 Thread slewis

Title: [87229] trunk/Source/WebCore








Revision 87229
Author sle...@apple.com
Date 2011-05-24 16:46:14 -0700 (Tue, 24 May 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=61345
part of 
Don't initialize ResourceResponse.m_suggestedFilename until we want to use it.  Initializing it requires reading in and parsing a plist.  
Add new initialization state CommonAndUncommonFields to ResourceResponse.  This will be for all the header fields.
Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it. 
Add "Content-Type" to common headers since it is looked for by every CSS sheet load.

Reviewed by Geoff Garen.

No new tests because functionality has not changed.

* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):
* platform/network/ResourceResponseBase.h:
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp
trunk/Source/WebCore/platform/network/ResourceResponseBase.h
trunk/Source/WebCore/platform/network/cf/ResourceResponse.h
trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp
trunk/Source/WebCore/platform/network/mac/ResourceResponseMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (87228 => 87229)

--- trunk/Source/WebCore/ChangeLog	2011-05-24 23:43:15 UTC (rev 87228)
+++ trunk/Source/WebCore/ChangeLog	2011-05-24 23:46:14 UTC (rev 87229)
@@ -1,3 +1,45 @@
+2011-05-24  Stephanie Lewis  
+
+Reviewed by Geoff Garen.
+
+https://bugs.webkit.org/show_bug.cgi?id=61345
+part of 
+Don't initialize ResourceResponse.m_suggestedFilename until we want to use it.  Initializing it requires reading in and parsing a plist.  
+Add new initialization state CommonAndUncommonFields to ResourceResponse.  This will be for all the header fields.
+Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it. 
+Add "Content-Type" to common headers since it is looked for by every CSS sheet load.
+
+No new tests because functionality has not changed.
+
+* platform/network/ResourceResponseBase.cpp:
+(WebCore::ResourceResponseBase::adopt):
+(WebCore::ResourceResponseBase::suggestedFilename):
+(WebCore::ResourceResponseBase::setSuggestedFilename):
+(WebCore::ResourceResponseBase::httpStatusText):
+(WebCore::ResourceResponseBase::setHTTPStatusText):
+(WebCore::ResourceResponseBase::httpHeaderField):
+(WebCore::ResourceResponseBase::setHTTPHeaderField):
+(WebCore::ResourceResponseBase::httpHeaderFields):
+(WebCore::ResourceResponseBase::isAttachment):
+(WebCore::ResourceResponseBase::setLastModifiedDate):
+(WebCore::ResourceResponseBase::lastModifiedDate):
+(WebCore::ResourceResponseBase::wasCached):
+(WebCore::ResourceResponseBase::connectionReused):
+(WebCore::ResourceResponseBase::setConnectionReused):
+(WebCore::ResourceResponseBase::connectionID):
+(WebCore::ResourceResponseBase::setConnectionID):
+(WebCore::ResourceResponseBase::resourceLoadTiming):
+(WebCore::ResourceResponseBase::setResourceLoadTiming):
+(WebCore::ResourceResponseBase::resourceLoadInfo):
+(WebCore::ResourceResponseBase::setResourceLoadInfo):
+* platform/network/ResourceResponseBase.h:
+* platform/network/cf/ResourceResponse.h:
+(WebCore::ResourceResponse::ResourceResponse):
+* platform/network/cf/ResourceResponseCFNet.cpp:
+(WebCore::ResourceResponse::platformLazyInit):
+* platform/network/mac/ResourceResponseMac.mm:
+(WebCore::ResourceResponse::platfor

90 matches

Mail list logo