[webkit-changes] [120825] trunk/Tools
Title: [120825] trunk/Tools Revision 120825 Author t...@codeaurora.org Date 2012-06-20 09:06:02 -0700 (Wed, 20 Jun 2012) Log Message Unreviewed: Back out accidentally checked in debug print which broke a test * Scripts/webkitpy/performance_tests/perftest.py: (PerfTest.parse_output): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py Diff Modified: trunk/Tools/ChangeLog (120824 => 120825) --- trunk/Tools/ChangeLog 2012-06-20 15:41:57 UTC (rev 120824) +++ trunk/Tools/ChangeLog 2012-06-20 16:06:02 UTC (rev 120825) @@ -1,5 +1,12 @@ 2012-06-20 Tom Zakrajsek +Unreviewed: Back out accidentally checked in debug print which broke a test + +* Scripts/webkitpy/performance_tests/perftest.py: +(PerfTest.parse_output): + +2012-06-20 Tom Zakrajsek + Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests https://bugs.webkit.org/show_bug.cgi?id=78789 Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py (120824 => 120825) --- trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py 2012-06-20 15:41:57 UTC (rev 120824) +++ trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py 2012-06-20 16:06:02 UTC (rev 120825) @@ -135,7 +135,7 @@ if not self._should_ignore_line_in_parser_test_result(line): test_failed = True -_log.error("PerfTest can't parse line [" + line + "]") +_log.error(line) if test_failed or set(self._statistics_keys) != set(results.keys()): return None ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120823] trunk
Title: [120823] trunk Revision 120823 Author t...@codeaurora.org Date 2012-06-20 08:09:19 -0700 (Wed, 20 Jun 2012) Log Message Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests https://bugs.webkit.org/show_bug.cgi?id=78789 Reviewed by Ryosuke Niwa. PerformanceTests: Added PerfTestRunner fixture around it. * Animation/balls.html: Added. Tools: Updated parser to include fps as a valid unit. * Scripts/webkitpy/performance_tests/perftest.py: (PerfTest): (PerfTest.parse_output): Modified Paths trunk/PerformanceTests/ChangeLog trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py Added Paths trunk/PerformanceTests/Animation/ trunk/PerformanceTests/Animation/balls.html Diff Added: trunk/PerformanceTests/Animation/balls.html (0 => 120823) --- trunk/PerformanceTests/Animation/balls.html (rev 0) +++ trunk/PerformanceTests/Animation/balls.html 2012-06-20 15:09:19 UTC (rev 120823) @@ -0,0 +1,273 @@ + + + + + + + +Benchmark - HTML & _javascript_ + + + + + + + + + + +html { +height: 100%; +} + +body { +width: 100%; +height: 100%; +overflow: hidden; +margin: 0; +padding: 0; +} + +span { +position: absolute; +width: 12px; +height: 12px; +overflow: hidden; +-webkit-border-radius: 6px; +-moz-border-radius: 6px; +border-radius: 6px; +background-color: #00; +} + +.shadows span { +-webkit-box-shadow: 4px 4px 3px rgba(0,0,0,0.33); +-moz-box-shadow: 4px 4px 3px rgba(0,0,0,0.33); +box-shadow: 4px 4px 3px rgba(0,0,0,0.33); +} + +#frameRate { +position: absolute; +right: 10px; +bottom: 10px; +z-index: 100; +font-size: 25px; +font-family: Arial, Helvetica, sans-serif; +} + + + + + +var FRAMES_PER_TIMER_READING = 10; +var MAX_ITERATIONS = 110; +var MAX_RUNS = 1; +var MAX_PARTICLES = 2500; +var MAX_VELOCITY = 50; +var PARTICLE_RADIUS = 6; +var STAGE_WIDTH = 600; +var STAGE_HEIGHT = 600; +var COLORS = ["#cc", "#ffcc00", "#aaff00", "#0099cc", "#194c99", "#661999"]; + +var frameTimes = []; +var iteration = 0; +var run = 0; +var animateIntervalId = 0; +var statistics = []; +var frameRates = []; +var particles = []; + +window._onload_ = init; + +function init() +{ +PerfTestRunner.resetRandomSeed(); + +var location = window.location.href; +frameRates = []; +frameTimes = []; +iteration = 0; +animateIntervalId = 0; +particles = []; + +// Create the particles +for (var i = 0; i < MAX_PARTICLES; i++) +particles.push(new Particle()); + +// Start the animation +animateIntervalId = setInterval(animate, 1); +} + +function animate() +{ +var currTime = new Date().getTime(); +var timeDelta = currTime - frameTimes[frameTimes.length - 1]; + +if (isNaN(timeDelta)) +timeDelta = 0; + +// Draw each particle +for (var particle in particles) +particles[particle].draw(timeDelta); + +if ((iteration++ % FRAMES_PER_TIMER_READING) == 0) { +// Limit the frame time array to the last 30 frames +if (frameTimes.length > 30) +frameTimes.splice(0, 1); + +frameTimes.push(currTime); + +// Calculate the framerate based upon the difference between the absolute times of the oldest and newest frames, subdivided by how many frames were drawn inbetween +var frameRate = document.getElementById("frameRate"); +var frameRateVal = FRAMES_PER_TIMER_READING * 1000 / ((currTime - frameTimes[0]) / (frameTimes.length - 1)); + +if (!isNaN(frameRateVal)) { +frameRates.push(frameRateVal); +var frameRateText = frameRateVal + ""; +frameRateText = frameRateText.replace(/(^[^.]+\...).*/, "$1"); +frameRateText += " fps"; +frameRate.innerHTML = frameRateText; +} +} + +if (iteration > MAX_ITERATIONS) { +clearInterval(animateIntervalId); +onCompletedRun(); +} +} + +function Particle() +{ +var angle = Math.PI * 2 * PerfTestRunner.random(); +var velocity = MAX_VELOCITY / 8 * 7 * PerfTestRunner.random() + MAX_VELOCITY / 8; +var x = STAGE_WIDTH / 2 - PARTICLE_RADIUS; +var y = STAGE_HEIGHT / 2 - PARTICLE_RADIUS; + +// Create visual element for the particle +var domNode = document.createElement('span'); +document.body.appendChild(domNode); + +// Set initial position to middle of screen +domNode.style.left = x + "px"; +domNode.style.top = y + "px"; + +
[webkit-changes] [116784] trunk/LayoutTests
Title: [116784] trunk/LayoutTests Revision 116784 Author t...@codeaurora.org Date 2012-05-11 10:28:21 -0700 (Fri, 11 May 2012) Log Message [Qt]ietestcenter/css3/flexbox tests fail on 32 bit https://bugs.webkit.org/show_bug.cgi?id=85596 Patch by Dave Tharp on 2012-05-11 Reviewed by Csaba Osztrogonác. Reference tests originally assumed "background: green" was identical to the green used in the pngs used by the feature tests. On local builds of QT, GTK, and chromium, this assumption seemed to hold up. On the Mac and QT bots however, it became clear this was an invalid assumption. I've re-written the reference tests to use the original pngs as appropriate. I have reproduced the failures on a Mac & Qt32 and verified that the newly re-written reference tests behave properly now. * ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm: * ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm: * ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm: * ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm: * ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm: * ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm: * ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm: * ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm: * ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm: * ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm: * ietestcenter/css3/flexbox/flexbox-layout-001-expected.htm: * ietestcenter/css3/flexbox/flexbox-layout-003-expected.htm: * ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.htm: * ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.htm: * ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.htm: * platform/chromium/test_expectations.txt: * platform/efl/test_expectations.txt: * platform/gtk/test_expectations.txt: * platform/mac/Skipped: * platform/mac/test_expectations.txt: * platform/qt/Skipped: * platform/qt/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-layout-001-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-layout-003-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.htm trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.htm trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/efl/test_expectations.txt trunk/LayoutTests/platform/gtk/test_expectations.txt trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/mac/test_expectations.txt trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/qt/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (116783 => 116784) --- trunk/LayoutTests/ChangeLog 2012-05-11 17:09:28 UTC (rev 116783) +++ trunk/LayoutTests/ChangeLog 2012-05-11 17:28:21 UTC (rev 116784) @@ -1,3 +1,41 @@ +2012-05-11 Dave Tharp + +[Qt]ietestcenter/css3/flexbox tests fail on 32 bit +https://bugs.webkit.org/show_bug.cgi?id=85596 + +Reviewed by Csaba Osztrogonác. + +Reference tests originally assumed "background: green" was identical +to the green used in the pngs used by the feature tests. On local builds +of QT, GTK, and chromium, this assumption seemed to hold up. On the Mac +and QT bots however, it became clear this was an invalid assumption. I've +re-written the reference tests to use the original pngs as appropriate. +I have reproduced the failures on a Mac & Qt32 and verified that the newly +re-written reference tests behave properly now. + +* ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm: +* ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm: +* ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm: +* ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm: +* ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm: +* ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm: +* ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm: +* ietestcenter/css3/flexbo
[webkit-changes] [116658] trunk/LayoutTests
Title: [116658] trunk/LayoutTests Revision 116658 Author t...@codeaurora.org Date 2012-05-10 10:26:32 -0700 (Thu, 10 May 2012) Log Message Integrate IETC CSS : values and units tests https://bugs.webkit.org/show_bug.cgi?id=85307 Patch by Dave Tharp on 2012-05-10 Reviewed by Adam Barth. Added the IETC values and unit tests and associated reference tests. Also removed two "file not found" test entries in the mac test_expectations.txt file that were causing a style check failure. * ietestcenter/css3/valuesandunits/units-000-expected.htm: Added. * ietestcenter/css3/valuesandunits/units-000.htm: Added. * ietestcenter/css3/valuesandunits/units-010-expected.htm: Added. * ietestcenter/css3/valuesandunits/units-010.htm: Added. * ietestcenter/css3/valuesandunits/units-020-expected.htm: Added. * ietestcenter/css3/valuesandunits/units-020.htm: Added. * platform/chromium/test_expectations.txt: * platform/efl/test_expectations.txt: * platform/gtk/test_expectations.txt: * platform/mac/test_expectations.txt: * platform/qt/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/efl/test_expectations.txt trunk/LayoutTests/platform/gtk/test_expectations.txt trunk/LayoutTests/platform/mac/test_expectations.txt trunk/LayoutTests/platform/qt/test_expectations.txt Added Paths trunk/LayoutTests/ietestcenter/css3/valuesandunits/ trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000-expected.htm trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000.htm trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-010-expected.htm trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-010.htm trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-020-expected.htm trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-020.htm Diff Modified: trunk/LayoutTests/ChangeLog (116657 => 116658) --- trunk/LayoutTests/ChangeLog 2012-05-10 17:15:55 UTC (rev 116657) +++ trunk/LayoutTests/ChangeLog 2012-05-10 17:26:32 UTC (rev 116658) @@ -1,3 +1,27 @@ +2012-05-10 Dave Tharp + +Integrate IETC CSS : values and units tests +https://bugs.webkit.org/show_bug.cgi?id=85307 + +Reviewed by Adam Barth. + +Added the IETC values and unit tests and associated reference tests. + +Also removed two "file not found" test entries in the mac test_expectations.txt +file that were causing a style check failure. + +* ietestcenter/css3/valuesandunits/units-000-expected.htm: Added. +* ietestcenter/css3/valuesandunits/units-000.htm: Added. +* ietestcenter/css3/valuesandunits/units-010-expected.htm: Added. +* ietestcenter/css3/valuesandunits/units-010.htm: Added. +* ietestcenter/css3/valuesandunits/units-020-expected.htm: Added. +* ietestcenter/css3/valuesandunits/units-020.htm: Added. +* platform/chromium/test_expectations.txt: +* platform/efl/test_expectations.txt: +* platform/gtk/test_expectations.txt: +* platform/mac/test_expectations.txt: +* platform/qt/test_expectations.txt: + 2012-05-10 Dominik Röttsches [EFL][DRT] ewk_view_paint_contents may trigger assertion failure Added: trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000-expected.htm (0 => 116658) --- trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000-expected.htm (rev 0) +++ trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000-expected.htm 2012-05-10 17:26:32 UTC (rev 116658) @@ -0,0 +1,22 @@ + + + +CSS Test: All unit and function values - Reference + + + +#parent +{ +height: 272px; +width: 1in; +background: green; +position: relative; +} + + + +Test passes if there is no red visible on the page. + + + + Added: trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000.htm (0 => 116658) --- trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000.htm (rev 0) +++ trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000.htm 2012-05-10 17:26:32 UTC (rev 116658) @@ -0,0 +1,182 @@ + + + + +CSS Test: All unit and function values + + + + + +body div +{ +font: 16px/1em ahem; +color: green; +height: 16px; +} +#parent +{ +height: 272px; +} +#parent +{ +background: red; +position: relative; +overflow: hidden; +width: 1in; +} +#div1:before +{ +color: green; +counter-increment: div1 123456; +content: counter(div1); +
[webkit-changes] [116572] trunk/Tools
Title: [116572] trunk/Tools Revision 116572 Author t...@codeaurora.org Date 2012-05-09 16:22:04 -0700 (Wed, 09 May 2012) Log Message Fix overzealous re-opened since blocked by... message https://bugs.webkit.org/show_bug.cgi?id=86020 Reviewed by Adam Barth. Changed CreateBug behavior to only re-open a blocked bug if it was RESOLVED. Also had to update the test infrastructure slightly to allow for distinct mock commit revisions, so one could point to a RESOLVED bug for testing while another pointed to an OPEN bug. Also moved default created mock bug to be 60001 instead of 50004 which already exists as a reference mock bug. * Scripts/webkitpy/common/checkout/checkout_mock.py: (MockCheckout.__init__): (MockCheckout.commit_info_for_revision): * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: (MockBugzilla.create_bug): * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: * Scripts/webkitpy/tool/commands/download_unittest.py: (test_create_rollout_resolved): * Scripts/webkitpy/tool/commands/queries_unittest.py: (FailureReasonTest.test_blame_line_for_revision): * Scripts/webkitpy/tool/steps/createbug.py: (CreateBug.run): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py trunk/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py trunk/Tools/Scripts/webkitpy/tool/steps/createbug.py Diff Modified: trunk/Tools/ChangeLog (116571 => 116572) --- trunk/Tools/ChangeLog 2012-05-09 23:10:21 UTC (rev 116571) +++ trunk/Tools/ChangeLog 2012-05-09 23:22:04 UTC (rev 116572) @@ -1,3 +1,31 @@ +2012-05-09 Tom Zakrajsek + +Fix overzealous re-opened since blocked by... message +https://bugs.webkit.org/show_bug.cgi?id=86020 + +Reviewed by Adam Barth. + +Changed CreateBug behavior to only re-open a blocked bug if it +was RESOLVED. Also had to update the test infrastructure slightly +to allow for distinct mock commit revisions, so one could point +to a RESOLVED bug for testing while another pointed to an OPEN bug. + +Also moved default created mock bug to be 60001 instead of 50004 +which already exists as a reference mock bug. + +* Scripts/webkitpy/common/checkout/checkout_mock.py: +(MockCheckout.__init__): +(MockCheckout.commit_info_for_revision): +* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: +(MockBugzilla.create_bug): +* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: +* Scripts/webkitpy/tool/commands/download_unittest.py: +(test_create_rollout_resolved): +* Scripts/webkitpy/tool/commands/queries_unittest.py: +(FailureReasonTest.test_blame_line_for_revision): +* Scripts/webkitpy/tool/steps/createbug.py: +(CreateBug.run): + 2012-05-09 Hugo Parente Lima Use suitable viewport values on XHTML-MP pages. Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py (116571 => 116572) --- trunk/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py 2012-05-09 23:10:21 UTC (rev 116571) +++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py 2012-05-09 23:22:04 UTC (rev 116572) @@ -40,32 +40,52 @@ return "This is a fake commit message that is at least 50 characters." +committer_list = CommitterList() + +mock_revisions = { +1: CommitInfo(852, "e...@webkit.org", { +"bug_id": 5, +"author_name": "Adam Barth", +"author_email": "aba...@webkit.org", +"author": committer_list.contributor_by_email("aba...@webkit.org"), +"reviewer_text": "Darin Adler", +"reviewer": committer_list.committer_by_name("Darin Adler"), +"changed_files": [ +"path/to/file", +"another/file", +], +}), +3001: CommitInfo(3001, "t...@codeaurora.org", { +"bug_id": 50004, +"author_name": "Tom Zakrajsek", +"author_email": "t...@codeaurora.org", +"author": committer_list.contributor_by_email("t...@codeaurora.org"), +"reviewer_text": "Darin Adler", +"reviewer": committer_list.committer_by_name("Darin Adler"), +"changed_files": [ +"path/to/file", +"another/file", +], +}) +} + class MockCheckout(object): def __init__(self): # FIXME: It's unclear if a MockCheckout is very useful. A normal Checkout # with a MockSCM/MockFileSystem/MockExecutive is probably better. self._filesystem = MockFileSystem() -# FIXME: This should move onto the Host object, and we should use a MockCommitterList for tests. -_committer_list = CommitterList() - def commit_info_for_revision(self, svn_revision): -# The real Checkout would probably throw a
[webkit-changes] [116245] trunk/Tools
Title: [116245] trunk/Tools Revision 116245 Author t...@codeaurora.org Date 2012-05-06 15:33:19 -0700 (Sun, 06 May 2012) Log Message sheriffbot isn't reopening patches after it lands rollouts https://bugs.webkit.org/show_bug.cgi?id=64418 Reviewed by Adam Barth. * Scripts/webkitpy/tool/commands/download_unittest.py: * Scripts/webkitpy/tool/steps/createbug.py: (CreateBug.run): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py trunk/Tools/Scripts/webkitpy/tool/steps/createbug.py Diff Modified: trunk/Tools/ChangeLog (116244 => 116245) --- trunk/Tools/ChangeLog 2012-05-06 22:19:45 UTC (rev 116244) +++ trunk/Tools/ChangeLog 2012-05-06 22:33:19 UTC (rev 116245) @@ -1,3 +1,14 @@ +2012-05-06 Tom Zakrajsek + +sheriffbot isn't reopening patches after it lands rollouts +https://bugs.webkit.org/show_bug.cgi?id=64418 + +Reviewed by Adam Barth. + +* Scripts/webkitpy/tool/commands/download_unittest.py: +* Scripts/webkitpy/tool/steps/createbug.py: +(CreateBug.run): + 2012-05-04 Raphael Kubo da Costa webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT. Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (116244 => 116245) --- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2012-05-06 22:19:45 UTC (rev 116244) +++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2012-05-06 22:33:19 UTC (rev 116245) @@ -261,6 +261,7 @@ component: MOCK component cc: MOCK cc blocked: 5 +MOCK reopen_bug 5 with comment 'Re-opened since this is blocked by 50004' MOCK add_patch_to_bug: bug_id=50004, description=ROLLOUT of r852, mark_for_review=False, mark_for_commit_queue=True, mark_for_landing=False -- Begin comment -- Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. Modified: trunk/Tools/Scripts/webkitpy/tool/steps/createbug.py (116244 => 116245) --- trunk/Tools/Scripts/webkitpy/tool/steps/createbug.py 2012-05-06 22:19:45 UTC (rev 116244) +++ trunk/Tools/Scripts/webkitpy/tool/steps/createbug.py 2012-05-06 22:33:19 UTC (rev 116245) @@ -50,3 +50,5 @@ if not blocks: blocks = state.get("bug_blocked") state["bug_id"] = self._tool.bugs.create_bug(state["bug_title"], state["bug_description"], blocked=blocks, component=self._options.component, cc=cc) +if blocks: +self._tool.bugs.reopen_bug(blocks, "Re-opened since this is blocked by %s" % state["bug_id"]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [116037] trunk/LayoutTests
Title: [116037] trunk/LayoutTests Revision 116037 Author t...@codeaurora.org Date 2012-05-03 16:10:26 -0700 (Thu, 03 May 2012) Log Message Unreviewed gardening * platform/chromium/test_expectations.txt: * platform/efl/test_expectations.txt: * platform/gtk/test_expectations.txt: * platform/mac/test_expectations.txt: * platform/qt/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/efl/test_expectations.txt trunk/LayoutTests/platform/gtk/test_expectations.txt trunk/LayoutTests/platform/mac/test_expectations.txt trunk/LayoutTests/platform/qt/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (116036 => 116037) --- trunk/LayoutTests/ChangeLog 2012-05-03 23:09:41 UTC (rev 116036) +++ trunk/LayoutTests/ChangeLog 2012-05-03 23:10:26 UTC (rev 116037) @@ -1,3 +1,13 @@ +2012-05-03 Tom Zakrajsek + +Unreviewed gardening + +* platform/chromium/test_expectations.txt: +* platform/efl/test_expectations.txt: +* platform/gtk/test_expectations.txt: +* platform/mac/test_expectations.txt: +* platform/qt/test_expectations.txt: + 2012-05-03 Zhenyao Mo Unreviewed, rebaseline. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (116036 => 116037) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-05-03 23:09:41 UTC (rev 116036) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-05-03 23:10:26 UTC (rev 116037) @@ -3882,4 +3882,4 @@ // IETC flexbox failures BUGWK85211 : ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm = IMAGE BUGWK85212 : ietestcenter/css3/flexbox/flexbox-layout-002.htm = IMAGE -BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = IMAGE +BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE Modified: trunk/LayoutTests/platform/efl/test_expectations.txt (116036 => 116037) --- trunk/LayoutTests/platform/efl/test_expectations.txt 2012-05-03 23:09:41 UTC (rev 116036) +++ trunk/LayoutTests/platform/efl/test_expectations.txt 2012-05-03 23:10:26 UTC (rev 116037) @@ -265,4 +265,4 @@ // IETC flexbox failures BUGWK85211 : ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm = IMAGE BUGWK85212 : ietestcenter/css3/flexbox/flexbox-layout-002.htm = IMAGE -BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = IMAGE +BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (116036 => 116037) --- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-05-03 23:09:41 UTC (rev 116036) +++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-05-03 23:10:26 UTC (rev 116037) @@ -296,7 +296,7 @@ // IETC flexbox failures BUGWK85211 : ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm = IMAGE BUGWK85212 : ietestcenter/css3/flexbox/flexbox-layout-002.htm = IMAGE -BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = IMAGE +BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE // // End of Expected failures Modified: trunk/LayoutTests/platform/mac/test_expectations.txt (116036 => 116037) --- trunk/LayoutTests/platform/mac/test_expectations.txt 2012-05-03 23:09:41 UTC (rev 116036) +++ trunk/LayoutTests/platform/mac/test_expectations.txt 2012-05-03 23:10:26 UTC (rev 116037) @@ -202,4 +202,4 @@ // IETC flexbox failures BUGWK85211 : ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm = IMAGE BUGWK85212 : ietestcenter/css3/flexbox/flexbox-layout-002.htm = IMAGE -BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = IMAGE +BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE Modified: trunk/LayoutTests/platform/qt/test_expectations.txt (116036 => 116037) --- trunk/LayoutTests/platform/qt/test_expectations.txt 2012-05-03 23:09:41 UTC (rev 116036) +++ trunk/LayoutTests/platform/qt/test_expectations.txt 2012-05-03 23:10:26 UTC (rev 116037) @@ -63,4 +63,4 @@ // IETC flexbox failures BUGWK85211 : ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm = IMAGE BUGWK85212 : ietestcenter/css3/flexbox/flexbox-layout-002.htm = IMAGE -BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = IMAGE +BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115942] trunk
Title: [115942] trunk Revision 115942 Author t...@codeaurora.org Date 2012-05-02 23:43:58 -0700 (Wed, 02 May 2012) Log Message Need tests for PerfTestRunner.computeStatistics https://bugs.webkit.org/show_bug.cgi?id=85410 Reviewed by Ryosuke Niwa. PerformanceTests: * resources/runner.js: LayoutTests: * fast/harness/perftests/perf-runner-compute-statistics-expected.txt: Added. * fast/harness/perftests/perf-runner-compute-statistics.html: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/resources/runner.js Added Paths trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics-expected.txt trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics.html Diff Modified: trunk/LayoutTests/ChangeLog (115941 => 115942) --- trunk/LayoutTests/ChangeLog 2012-05-03 06:40:50 UTC (rev 115941) +++ trunk/LayoutTests/ChangeLog 2012-05-03 06:43:58 UTC (rev 115942) @@ -1,3 +1,14 @@ +2012-05-02 Tom Zakrajsek + +Need tests for PerfTestRunner.computeStatistics +https://bugs.webkit.org/show_bug.cgi?id=85410 + +Reviewed by Ryosuke Niwa. + +* fast/harness/perftests/perf-runner-compute-statistics-expected.txt: Added. +* fast/harness/perftests/perf-runner-compute-statistics.html: Added. +* platform/chromium/test_expectations.txt: + 2012-05-02 Csaba Osztrogonác [Qt] Unreviewed morning gardening. Added: trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics-expected.txt (0 => 115942) --- trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics-expected.txt (rev 0) +++ trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics-expected.txt 2012-05-03 06:43:58 UTC (rev 115942) @@ -0,0 +1,68 @@ +This test verifies PerfTestRunner.computeStatistics(), including: min, max, median, mean, sum, variance, and stdev. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + +Ensure no latent divide by 0's for an odd number of elements. +data = "" +PASS stats.min is 0 +PASS stats.max is 0 +PASS stats.median is 0 +PASS stats.mean is 0 +PASS stats.sum is 0 +PASS stats.variance is 0 +PASS stats.stdev is 0 + +This test will catch if any order dependencies in the data, such as +needing to be numerically sorted, are not resolved by the algorithm. +This variant covers an odd number of elements. +data = "" +PASS stats.min is 1 +PASS stats.max is 20 +PASS stats.median is 5 +PASS stats.mean is 7.6 +PASS stats.sum is 38 +PASS stats.min is 1 +PASS stats.max is 20 +PASS stats.median is 5 +PASS stats.mean is 7.6 +PASS stats.sum is 38 +PASS stats.variance is within 0.0001 of 48.235 +PASS stats.stdev is within 0.0001 of 6.945502141674135 + +This test will catch if any order dependencies in the data, such as +needing to be numerically sorted, are not resolved by the algorithm. +This variant covers an odd number of elements, and negative values. +data = "" +PASS stats.min is -20 +PASS stats.max is -1 +PASS stats.median is -5 +PASS stats.mean is -7.6 +PASS stats.sum is -38 +PASS stats.min is -20 +PASS stats.max is -1 +PASS stats.median is -5 +PASS stats.mean is -7.6 +PASS stats.sum is -38 +PASS stats.variance is within 0.0001 of 48.235 +PASS stats.stdev is within 0.0001 of 6.945502141674135 + +Ensure no latent divide by 0's for an even number of elements. +data = "" +PASS stats.median is 0 + +This test verifies that median is handled correctly for +an even number of elements. +data = "" +PASS stats.median is 5.5 +PASS stats.median is 5.5 + +This test verifies that median is handled correctly for +an even number of elements, including negative numbers. +data = "" +PASS stats.median is -5.5 +PASS stats.median is -5.5 + +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics.html (0 => 115942) --- trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics.html (rev 0) +++ trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics.html 2012-05-03 06:43:58 UTC (rev 115942) @@ -0,0 +1,153 @@ + + + + +var alternateComputeStatistics = { +min: function(array) { +return Math.min.apply(Math, array); +}, +max: function(array) { +return Math.max.apply(Math, array); +}, +median: function(originalData) { +// don't want side effects on the input array, so... +var array = originalData.slice(0); +array.sort(function(a,b) { return a - b; }); +var mid = Math.floor(array.length / 2); +if (array.length % 2) +return array[mid]; +else +return (array[mid-1] + array[mid]) / 2; +}, +mean: function(array) { +return alternateComputeStatistics.sum(array)/
[webkit-changes] [115905] trunk
Title: [115905] trunk Revision 115905 Author t...@codeaurora.org Date 2012-05-02 16:08:48 -0700 (Wed, 02 May 2012) Log Message Need tests for PerfTestRunner.computeStatistics https://bugs.webkit.org/show_bug.cgi?id=85410 Reviewed by Ryosuke Niwa. PerformanceTests: * resources/runner.js: LayoutTests: * fast/harness/perftests/perf-runner-compute-statistics-expected.txt: Added. * fast/harness/perftests/perf-runner-compute-statistics.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/resources/runner.js Added Paths trunk/LayoutTests/fast/harness/perftests/ trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics-expected.txt trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics.html Diff Modified: trunk/LayoutTests/ChangeLog (115904 => 115905) --- trunk/LayoutTests/ChangeLog 2012-05-02 23:08:10 UTC (rev 115904) +++ trunk/LayoutTests/ChangeLog 2012-05-02 23:08:48 UTC (rev 115905) @@ -1,3 +1,13 @@ +2012-05-02 Tom Zakrajsek + +Need tests for PerfTestRunner.computeStatistics +https://bugs.webkit.org/show_bug.cgi?id=85410 + +Reviewed by Ryosuke Niwa. + +* fast/harness/perftests/perf-runner-compute-statistics-expected.txt: Added. +* fast/harness/perftests/perf-runner-compute-statistics.html: Added. + 2012-05-02 Joshua Bell IndexedDB: Handle generated keys up to 2^53 Added: trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics-expected.txt (0 => 115905) --- trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics-expected.txt (rev 0) +++ trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics-expected.txt 2012-05-02 23:08:48 UTC (rev 115905) @@ -0,0 +1,68 @@ +This test verifies PerfTestRunner.computeStatistics(), including: min, max, median, mean, sum, variance, and stdev. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + +Ensure no latent divide by 0's for an odd number of elements. +data = "" +PASS stats.min is 0 +PASS stats.max is 0 +PASS stats.median is 0 +PASS stats.mean is 0 +PASS stats.sum is 0 +PASS stats.variance is 0 +PASS stats.stdev is 0 + +This test will catch if any order dependencies in the data, such as +needing to be numerically sorted, are not resolved by the algorithm. +This variant covers an odd number of elements. +data = "" +PASS stats.min is 1 +PASS stats.max is 20 +PASS stats.median is 5 +PASS stats.mean is 7.6 +PASS stats.sum is 38 +PASS stats.min is 1 +PASS stats.max is 20 +PASS stats.median is 5 +PASS stats.mean is 7.6 +PASS stats.sum is 38 +PASS stats.variance is within 0.0001 of 48.235 +PASS stats.stdev is within 0.0001 of 6.945502141674135 + +This test will catch if any order dependencies in the data, such as +needing to be numerically sorted, are not resolved by the algorithm. +This variant covers an odd number of elements, and negative values. +data = "" +PASS stats.min is -20 +PASS stats.max is -1 +PASS stats.median is -5 +PASS stats.mean is -7.6 +PASS stats.sum is -38 +PASS stats.min is -20 +PASS stats.max is -1 +PASS stats.median is -5 +PASS stats.mean is -7.6 +PASS stats.sum is -38 +PASS stats.variance is within 0.0001 of 48.235 +PASS stats.stdev is within 0.0001 of 6.945502141674135 + +Ensure no latent divide by 0's for an even number of elements. +data = "" +PASS stats.median is 0 + +This test verifies that median is handled correctly for +an even number of elements. +data = "" +PASS stats.median is 5.5 +PASS stats.median is 5.5 + +This test verifies that median is handled correctly for +an even number of elements, including negative numbers. +data = "" +PASS stats.median is -5.5 +PASS stats.median is -5.5 + +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics.html (0 => 115905) --- trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics.html (rev 0) +++ trunk/LayoutTests/fast/harness/perftests/perf-runner-compute-statistics.html 2012-05-02 23:08:48 UTC (rev 115905) @@ -0,0 +1,153 @@ + + + + +var alternateComputeStatistics = { +min: function(array) { +return Math.min.apply(Math, array); +}, +max: function(array) { +return Math.max.apply(Math, array); +}, +median: function(originalData) { +// don't want side effects on the input array, so... +var array = originalData.slice(0); +array.sort(function(a,b) { return a - b; }); +var mid = Math.floor(array.length / 2); +if (array.length % 2) +return array[mid]; +else +return (array[mid-1] + array[mid]) / 2; +}, +mean: function(array) { +return alternateComputeStatistics.sum(array)/array.length; +}, +sum: function(array) { +var total = 0; +for (var index in array)
[webkit-changes] [115683] trunk/LayoutTests
Title: [115683] trunk/LayoutTests Revision 115683 Author t...@codeaurora.org Date 2012-04-30 15:46:32 -0700 (Mon, 30 Apr 2012) Log Message Unreviewed gardening * platform/qt/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115682 => 115683) --- trunk/LayoutTests/ChangeLog 2012-04-30 22:44:17 UTC (rev 115682) +++ trunk/LayoutTests/ChangeLog 2012-04-30 22:46:32 UTC (rev 115683) @@ -1,3 +1,9 @@ +2012-04-30 Tom Zakrajsek + +Unreviewed gardening + +* platform/qt/test_expectations.txt: + 2012-04-30 Sadrul Habib Chowdhury [chromium] Disable battery-status API support. Modified: trunk/LayoutTests/platform/qt/test_expectations.txt (115682 => 115683) --- trunk/LayoutTests/platform/qt/test_expectations.txt 2012-04-30 22:44:17 UTC (rev 115682) +++ trunk/LayoutTests/platform/qt/test_expectations.txt 2012-04-30 22:46:32 UTC (rev 115683) @@ -54,11 +54,8 @@ BUGWK84778 : ietestcenter/css3/multicolumn/column-width-negative-001.htm = IMAGE // Following failing because of DRT not rendering monospace font for QT -// This may be a local setup issue, will remove if the qt bots render monospace correctly -// (which will cause unexpected passes). IF the bots do not render monospace correctly, -// I'll file a bug and change the designators. -BUGDTHARP : ietestcenter/css3/multicolumn/column-width-applies-to-005.htm = IMAGE -BUGDTHARP : ietestcenter/css3/multicolumn/column-width-applies-to-006.htm = IMAGE -BUGDTHARP : ietestcenter/css3/multicolumn/column-width-applies-to-008.htm = IMAGE -BUGDTHARP : ietestcenter/css3/multicolumn/column-width-percentage-001.htm = IMAGE -BUGDTHARP : ietestcenter/css3/multicolumn/column-containing-block-003.htm = IMAGE +BUGWK85203 : ietestcenter/css3/multicolumn/column-width-applies-to-005.htm = IMAGE +BUGWK85203 : ietestcenter/css3/multicolumn/column-width-applies-to-006.htm = IMAGE +BUGWK85203 : ietestcenter/css3/multicolumn/column-width-applies-to-008.htm = IMAGE +BUGWK85203 : ietestcenter/css3/multicolumn/column-width-percentage-001.htm = IMAGE +BUGWK85203 : ietestcenter/css3/multicolumn/column-containing-block-003.htm = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115598] trunk/PerformanceTests
Title: [115598] trunk/PerformanceTests Revision 115598 Author t...@codeaurora.org Date 2012-04-29 11:22:22 -0700 (Sun, 29 Apr 2012) Log Message PerfTestRunner.computeStatistics incorrectly calculates min, max and median https://bugs.webkit.org/show_bug.cgi?id=85111 Reviewed by Ryosuke Niwa. The sort of the data input was being done alphabetically. So I provided a numeric compare function. * resources/runner.js: Modified Paths trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/resources/runner.js Diff Modified: trunk/PerformanceTests/ChangeLog (115597 => 115598) --- trunk/PerformanceTests/ChangeLog 2012-04-29 15:25:13 UTC (rev 115597) +++ trunk/PerformanceTests/ChangeLog 2012-04-29 18:22:22 UTC (rev 115598) @@ -1,3 +1,15 @@ +2012-04-29 Tom Zakrajsek + +PerfTestRunner.computeStatistics incorrectly calculates min, max and median +https://bugs.webkit.org/show_bug.cgi?id=85111 + +Reviewed by Ryosuke Niwa. + +The sort of the data input was being done alphabetically. +So I provided a numeric compare function. + +* resources/runner.js: + 2012-04-17 Ilya Tikhonovsky Web Inspector: the fix for test after massive rename in r114271. Modified: trunk/PerformanceTests/resources/runner.js (115597 => 115598) --- trunk/PerformanceTests/resources/runner.js 2012-04-29 15:25:13 UTC (rev 115597) +++ trunk/PerformanceTests/resources/runner.js 2012-04-29 18:22:22 UTC (rev 115598) @@ -52,7 +52,7 @@ var data = "" // Add values from the smallest to the largest to avoid the loss of significance -data.sort(); +data.sort(function(a,b){return a-b;}); var middle = Math.floor(data.length / 2); var result = { ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115382] trunk/LayoutTests
Title: [115382] trunk/LayoutTests Revision 115382 Author t...@codeaurora.org Date 2012-04-26 15:42:48 -0700 (Thu, 26 Apr 2012) Log Message Unreviewed gardening * platform/qt/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (115381 => 115382) --- trunk/LayoutTests/ChangeLog 2012-04-26 22:36:34 UTC (rev 115381) +++ trunk/LayoutTests/ChangeLog 2012-04-26 22:42:48 UTC (rev 115382) @@ -1,3 +1,9 @@ +2012-04-26 Tom Zakrajsek + +Unreviewed gardening + +* platform/qt/test_expectations.txt: + 2012-04-26 Aaron Colwell Updating MediaSource layout test to verify that webkitSourceState is always Modified: trunk/LayoutTests/platform/qt/test_expectations.txt (115381 => 115382) --- trunk/LayoutTests/platform/qt/test_expectations.txt 2012-04-26 22:36:34 UTC (rev 115381) +++ trunk/LayoutTests/platform/qt/test_expectations.txt 2012-04-26 22:42:48 UTC (rev 115382) @@ -61,3 +61,4 @@ BUGDTHARP : ietestcenter/css3/multicolumn/column-width-applies-to-006.htm = IMAGE BUGDTHARP : ietestcenter/css3/multicolumn/column-width-applies-to-008.htm = IMAGE BUGDTHARP : ietestcenter/css3/multicolumn/column-width-percentage-001.htm = IMAGE +BUGDTHARP : ietestcenter/css3/multicolumn/column-containing-block-003.htm = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114531] trunk
Title: [114531] trunk Revision 114531 Author t...@codeaurora.org Date 2012-04-18 11:01:17 -0700 (Wed, 18 Apr 2012) Log Message Unreviewed, rolling out r114506. http://trac.webkit.org/changeset/114506 https://bugs.webkit.org/show_bug.cgi?id=84254 Seems to be making gtk's DumpRenderTree crash occasionally (Requested by tomz on #webkit). Patch by Sheriff Bot on 2012-04-18 Source/WebKit/gtk: * webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): * webkit/webkitwebsettingsprivate.h: * webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify): Tools: * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): LayoutTests: * platform/gtk/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/test_expectations.txt trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp trunk/Source/WebKit/gtk/webkit/webkitwebsettingsprivate.h trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp Diff Modified: trunk/LayoutTests/ChangeLog (114530 => 114531) --- trunk/LayoutTests/ChangeLog 2012-04-18 17:44:46 UTC (rev 114530) +++ trunk/LayoutTests/ChangeLog 2012-04-18 18:01:17 UTC (rev 114531) @@ -1,3 +1,14 @@ +2012-04-18 Sheriff Bot + +Unreviewed, rolling out r114506. +http://trac.webkit.org/changeset/114506 +https://bugs.webkit.org/show_bug.cgi?id=84254 + +Seems to be making gtk's DumpRenderTree crash occasionally +(Requested by tomz on #webkit). + +* platform/gtk/test_expectations.txt: + 2012-04-18 Simon Fraser ASSERT when a layer with a foreground layer is in 'paint into ancestor' mode Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (114530 => 114531) --- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-18 17:44:46 UTC (rev 114530) +++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-18 18:01:17 UTC (rev 114531) @@ -1549,6 +1549,11 @@ BUGWK69933 : fast/borders/inline-mask-overlay-image-outset-vertical-rl.html = FAIL BUGWK69933 : fast/borders/inline-mask-overlay-image-outset.html = FAIL +// Running those two make other media tests flaky, so skip until +// proper investigation can be made. +BUGWK83874 SKIP : media/video-load-require-user-gesture.html = FAIL +BUGWK83874 SKIP : media/video-play-require-user-gesture.html = FAIL + BUGWK84025 : media/sources-fallback-codecs.html = FAIL BUGWK83906 : ietestcenter/css3/grid/grid-column-001.htm = IMAGE Modified: trunk/Source/WebKit/gtk/ChangeLog (114530 => 114531) --- trunk/Source/WebKit/gtk/ChangeLog 2012-04-18 17:44:46 UTC (rev 114530) +++ trunk/Source/WebKit/gtk/ChangeLog 2012-04-18 18:01:17 UTC (rev 114531) @@ -1,3 +1,21 @@ +2012-04-18 Sheriff Bot + +Unreviewed, rolling out r114506. +http://trac.webkit.org/changeset/114506 +https://bugs.webkit.org/show_bug.cgi?id=84254 + +Seems to be making gtk's DumpRenderTree crash occasionally +(Requested by tomz on #webkit). + +* webkit/webkitwebsettings.cpp: +(webkit_web_settings_class_init): +(webkit_web_settings_set_property): +(webkit_web_settings_get_property): +* webkit/webkitwebsettingsprivate.h: +* webkit/webkitwebview.cpp: +(webkit_web_view_update_settings): +(webkit_web_view_settings_notify): + 2012-04-18 Simon Pena [GTK] r114021 triggered media flakyness Modified: trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp (114530 => 114531) --- trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp 2012-04-18 17:44:46 UTC (rev 114530) +++ trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp 2012-04-18 18:01:17 UTC (rev 114531) @@ -121,8 +121,7 @@ PROP_ENABLE_WEBGL, PROP_ENABLE_WEB_AUDIO, PROP_ENABLE_ACCELERATED_COMPOSITING, -PROP_ENABLE_SMOOTH_SCROLLING, -PROP_MEDIA_PLAYBACK_REQUIRES_USER_GESTURE +PROP_ENABLE_SMOOTH_SCROLLING }; // Create a default user agent string @@ -973,24 +972,6 @@ _("Whether to enable smooth scrolling"), FALSE, flags)); - -/** -* WebKitWebSettings:media-playback-requires-user-gesture -* -* Whether an user gesture would be required to start media playback or load -* media. This is off by default, so media playback could start -* automatically. Setting it on requires a gesture by the user to start -* playback, or to load the media. -* -* Since: 1.10.0 -*/ -g_object_class_install_property(gobject_class, -PROP_MEDIA_PLAYBACK_REQUIRES_USER_GESTURE, -
[webkit-changes] [113785] trunk/LayoutTests
Title: [113785] trunk/LayoutTests Revision 113785 Author t...@codeaurora.org Date 2012-04-10 15:52:42 -0700 (Tue, 10 Apr 2012) Log Message Unreviewed update to test expectations * platform/efl/test_expectations.txt: * platform/gtk/test_expectations.txt: * platform/mac/test_expectations.txt: * platform/qt/test_expectations.txt: * platform/win/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/test_expectations.txt trunk/LayoutTests/platform/gtk/test_expectations.txt trunk/LayoutTests/platform/mac/test_expectations.txt trunk/LayoutTests/platform/qt/test_expectations.txt trunk/LayoutTests/platform/win/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (113784 => 113785) --- trunk/LayoutTests/ChangeLog 2012-04-10 22:41:33 UTC (rev 113784) +++ trunk/LayoutTests/ChangeLog 2012-04-10 22:52:42 UTC (rev 113785) @@ -1,3 +1,13 @@ +2012-04-10 Tom Zakrajsek + +Unreviewed update to test expectations + +* platform/efl/test_expectations.txt: +* platform/gtk/test_expectations.txt: +* platform/mac/test_expectations.txt: +* platform/qt/test_expectations.txt: +* platform/win/test_expectations.txt: + 2012-04-10 James Simonsen [Chromium] Fix test_expectations.txt from r113776. Modified: trunk/LayoutTests/platform/efl/test_expectations.txt (113784 => 113785) --- trunk/LayoutTests/platform/efl/test_expectations.txt 2012-04-10 22:41:33 UTC (rev 113784) +++ trunk/LayoutTests/platform/efl/test_expectations.txt 2012-04-10 22:52:42 UTC (rev 113785) @@ -216,3 +216,6 @@ BUGWK83277 : editing/input/caret-at-the-edge-of-contenteditable.html = FAIL MISSING BUGWK83277 : editing/input/reveal-caret-of-multiline-contenteditable.html = FAIL MISSING BUGWK83277 : editing/input/reveal-caret-of-multiline-input.html = FAIL MISSING + +// Temp: need to rebaseline. +BUGWK58511 : fast/text/text-shadow-no-default-color.html = FAIL MISSING Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (113784 => 113785) --- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-10 22:41:33 UTC (rev 113784) +++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-10 22:52:42 UTC (rev 113785) @@ -180,3 +180,6 @@ BUGWK82734 : ietestcenter/css3/bordersbackgrounds/color-behind-images.htm = FAIL MISSING BUGWK82734 : ietestcenter/css3/bordersbackgrounds/none-as-image-layer.htm = FAIL MISSING BUGWK82734 : ietestcenter/css3/bordersbackgrounds/order-of-images.htm = FAIL MISSING + +// Temp: need to rebaseline. +BUGWK58511 : fast/text/text-shadow-no-default-color.html = FAIL MISSING Modified: trunk/LayoutTests/platform/mac/test_expectations.txt (113784 => 113785) --- trunk/LayoutTests/platform/mac/test_expectations.txt 2012-04-10 22:41:33 UTC (rev 113784) +++ trunk/LayoutTests/platform/mac/test_expectations.txt 2012-04-10 22:52:42 UTC (rev 113785) @@ -410,3 +410,6 @@ BUGWK82734 : ietestcenter/css3/bordersbackgrounds/order-of-images.htm = FAIL MISSING BUGWK83124 : http/tests/websocket/tests/hybi/workers/worker-reload.html = PASS FAIL + +// Temp: need to rebaseline. +BUGWK58511 : fast/text/text-shadow-no-default-color.html = FAIL MISSING Modified: trunk/LayoutTests/platform/qt/test_expectations.txt (113784 => 113785) --- trunk/LayoutTests/platform/qt/test_expectations.txt 2012-04-10 22:41:33 UTC (rev 113784) +++ trunk/LayoutTests/platform/qt/test_expectations.txt 2012-04-10 22:52:42 UTC (rev 113785) @@ -103,3 +103,6 @@ BUGWK82734 : ietestcenter/css3/bordersbackgrounds/color-behind-images.htm = FAIL MISSING BUGWK82734 : ietestcenter/css3/bordersbackgrounds/none-as-image-layer.htm = FAIL MISSING BUGWK82734 : ietestcenter/css3/bordersbackgrounds/order-of-images.htm = FAIL MISSING + +// Temp: need to rebaseline. +BUGWK58511 : fast/text/text-shadow-no-default-color.html = FAIL MISSING Modified: trunk/LayoutTests/platform/win/test_expectations.txt (113784 => 113785) --- trunk/LayoutTests/platform/win/test_expectations.txt 2012-04-10 22:41:33 UTC (rev 113784) +++ trunk/LayoutTests/platform/win/test_expectations.txt 2012-04-10 22:52:42 UTC (rev 113785) @@ -1,62 +1,2 @@ // This file is intentionally left blank. Until the Apple win port supports new-run-webkit-tests (https://bugs.webkit.org/show_bug.cgi?id=38756) // this file does nothing. - -// Temporary: generate platform specific IETestCenter results, then -// remove when bots produce reference. -BUGWK82734 : ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm = FAIL MISSING -BUGWK82734 : ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element.htm = FAIL MISSING -BUGWK82734 : ietestcenter/css3/bordersbackgrounds/background-color-border-box.htm = FAIL MISSING -BUGWK82734 : ietestcenter/css3/bordersbackgrounds/background_color_padding_box.htm = FAIL MISSING -BUGWK82734 : ietestcenter/css3/bordersbackgrounds/background_position_three_four_values.htm = FAIL MISSING -BUGWK82734 : ietestce