[webkit-changes] [139744] trunk/Tools
Title: [139744] trunk/Tools
Revision 139744
Author vic...@rosedu.org
Date 2013-01-15 08:35:41 -0800 (Tue, 15 Jan 2013)
Log Message
Unreviewed. Update my email addresses.
* Scripts/webkitpy/common/config/committers.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/ChangeLog (139743 => 139744)
--- trunk/Tools/ChangeLog 2013-01-15 16:03:37 UTC (rev 139743)
+++ trunk/Tools/ChangeLog 2013-01-15 16:35:41 UTC (rev 139744)
@@ -1,3 +1,9 @@
+2013-01-15 Victor Carbune
+
+Unreviewed. Update my email addresses.
+
+* Scripts/webkitpy/common/config/committers.py:
+
2013-01-15 Zan Dobersek
[GTK] Waiting on the gdb process will lead to deadlock
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (139743 => 139744)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2013-01-15 16:03:37 UTC (rev 139743)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2013-01-15 16:35:41 UTC (rev 139744)
@@ -417,7 +417,7 @@
Committer("Tristan O'Tierney", ["tris...@otierney.net", "tris...@apple.com"]),
Committer("Vangelis Kokkevis", "vange...@chromium.org", "vangelis"),
Committer("Viatcheslav Ostapenko", ["osta...@gmail.com", "v.ostape...@samsung.com", "v.ostape...@sisa.samsung.com"], "ostap"),
-Committer("Victor Carbune", "vic...@rosedu.org", "vcarbune"),
+Committer("Victor Carbune", ["vcarb...@chromium.org", "vic...@rosedu.org"], "vcarbune"),
Committer("Victor Wang", "vict...@chromium.org", "victorw"),
Committer("Victoria Kirst", ["v...@chromium.org", "v...@google.com"], "vrk"),
Committer("Vincent Scheib", "sch...@chromium.org", "scheib"),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [139547] trunk
Title: [139547] trunk
Revision 139547
Author vic...@rosedu.org
Date 2013-01-12 04:04:56 -0800 (Sat, 12 Jan 2013)
Log Message
CC Button doesn't always show up
https://bugs.webkit.org/show_bug.cgi?id=106653
Reviewed by Eric Carlson.
Source/WebCore:
Added extra checks to existing test.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::closedCaptionTracksChanged):
Enforced visibility of captions button whenever the track list changes.
(WebCore):
* html/shadow/MediaControls.h:
(MediaControls):
LayoutTests:
* media/video-controls-captions-expected.txt: Updated.
* media/video-controls-captions.html: Added extra checks that fail
without the code changes.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-controls-captions-expected.txt
trunk/LayoutTests/media/video-controls-captions.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/MediaControls.cpp
trunk/Source/WebCore/html/shadow/MediaControls.h
Diff
Modified: trunk/LayoutTests/ChangeLog (139546 => 139547)
--- trunk/LayoutTests/ChangeLog 2013-01-12 09:33:01 UTC (rev 139546)
+++ trunk/LayoutTests/ChangeLog 2013-01-12 12:04:56 UTC (rev 139547)
@@ -1,3 +1,14 @@
+2013-01-12 Victor Carbune
+
+CC Button doesn't always show up
+https://bugs.webkit.org/show_bug.cgi?id=106653
+
+Reviewed by Eric Carlson.
+
+* media/video-controls-captions-expected.txt: Updated.
+* media/video-controls-captions.html: Added extra checks that fail
+without the code changes.
+
2013-01-11 Noel Gordon
[chromium] Update platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling.html on win
Modified: trunk/LayoutTests/media/video-controls-captions-expected.txt (139546 => 139547)
--- trunk/LayoutTests/media/video-controls-captions-expected.txt 2013-01-12 09:33:01 UTC (rev 139546)
+++ trunk/LayoutTests/media/video-controls-captions-expected.txt 2013-01-12 12:04:56 UTC (rev 139547)
@@ -21,5 +21,18 @@
** Captions should not be visible after button is clicked again **
*** Click the CC button.
No text track cue with display id '-webkit-media-text-track-display' is currently visible
+
+** Remove DOM node representing the track element **
+
+** Caption button should not be visible as there are no caption tracks.
+EXPECTED (captionsButtonCoordinates[0] <= '0') OK
+EXPECTED (captionsButtonCoordinates[1] <= '0') OK
+
+** Add a text track through JS to the video element **
+
+** Caption button should be visible and enabled because we have a captions track.
+EXPECTED (captionsButtonCoordinates[0] > '0') OK
+EXPECTED (captionsButtonCoordinates[1] > '0') OK
+EXPECTED (captionsButtonElement.disabled == 'false') OK
END OF TEST
Modified: trunk/LayoutTests/media/video-controls-captions.html (139546 => 139547)
--- trunk/LayoutTests/media/video-controls-captions.html 2013-01-12 09:33:01 UTC (rev 139546)
+++ trunk/LayoutTests/media/video-controls-captions.html 2013-01-12 12:04:56 UTC (rev 139547)
@@ -10,28 +10,57 @@
var captionsButtonElement;
var captionsButtonCoordinates;
-function startTest()
+function addTextTrackThroughJS()
{
-if (!window.eventSender) {
-consoleWrite("No eventSender found.");
-failTest();
-}
+consoleWrite("");
+consoleWrite("** Add a text track through JS to the video element **");
+var t = video.addTextTrack('captions', 'English', 'en');
+t.addCue(new TextTrackCue(0.0, 10.0, 'Some random caption text'));
+}
+function removeHTMLTrackElement()
+{
+consoleWrite("");
+consoleWrite("** Remove DOM node representing the track element **");
+var htmlTrack = video.children[0];
+video.removeChild(htmlTrack);
+}
+
+function testClosedCaptionsButtonVisibility(expected)
+{
try {
captionsButtonElement = mediaControlsElement(internals.shadowRoot(video).firstChild, "-webkit-media-controls-toggle-closed-captions-button");
captionsButtonCoordinates = mediaControlsButtonCoordinates(video, "toggle-closed-captions-button");
} catch (exception) {
consoleWrite("Failed to find a closed captions button or its coordinates: " + exception);
-failTest();
+if (expected)
+failTest();
return;
}
consoleWrite("");
-consoleWrite("** Caption button should be visible and enabled because we have a captions track.");
-testExpected("captionsButtonCoordinates[0]", 0, ">");
-
[webkit-changes] [139326] trunk
Title: [139326] trunk
Revision 139326
Author vic...@rosedu.org
Date 2013-01-10 09:45:41 -0800 (Thu, 10 Jan 2013)
Log Message
media/video-controls-captions.html fails after fixing https://bugs.webkit.org/show_bug.cgi?id=105536
https://bugs.webkit.org/show_bug.cgi?id=106230
Reviewed by Eric Carlson.
Source/WebCore:
Until Chromium has proper controls for lists of text tracks, the caption button
needs to preserve its functionality.
Updated TestExpectations to reactivate test.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Added explicit call to updateTextTrackDisplay.
This enables hiding the tracks immediately.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Added extra check before rendering
that captions should actually be displayed.
LayoutTests:
* platform/chromium/TestExpectations: Reactivated test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/shadow/MediaControlElements.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (139325 => 139326)
--- trunk/LayoutTests/ChangeLog 2013-01-10 17:44:05 UTC (rev 139325)
+++ trunk/LayoutTests/ChangeLog 2013-01-10 17:45:41 UTC (rev 139326)
@@ -1,3 +1,12 @@
+2013-01-10 Victor Carbune
+
+media/video-controls-captions.html fails after fixing https://bugs.webkit.org/show_bug.cgi?id=105536
+https://bugs.webkit.org/show_bug.cgi?id=106230
+
+Reviewed by Eric Carlson.
+
+* platform/chromium/TestExpectations: Reactivated test.
+
2013-01-10 Alexander Pavlov
The "outline-offset" property is not found in the computed style property list
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139325 => 139326)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-10 17:44:05 UTC (rev 139325)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-10 17:45:41 UTC (rev 139326)
@@ -3039,9 +3039,6 @@
webkit.org/b/103926 media/track/opera/track/webvtt/rendering/adhoc/cue_font_size_transition.html [ Skip ]
webkit.org/b/103926 media/track/opera/track/webvtt/rendering/adhoc/voice_with_evil_timestamp.html [ Skip ]
-# Started failing upon fixing webkit.org/b/105536
-webkit.org/b/106230 media/video-controls-captions.html [ Failure ]
-
webkit.org/b/72271 [ SnowLeopard Debug ] fast/dom/node-iterator-reference-node-moved-crash.html [ Crash Pass ]
webkit.org/b/72376 [ Win ] fast/forms/file/input-file-label.html [ Failure Pass ]
Modified: trunk/Source/WebCore/ChangeLog (139325 => 139326)
--- trunk/Source/WebCore/ChangeLog 2013-01-10 17:44:05 UTC (rev 139325)
+++ trunk/Source/WebCore/ChangeLog 2013-01-10 17:45:41 UTC (rev 139326)
@@ -1,3 +1,22 @@
+2013-01-10 Victor Carbune
+
+media/video-controls-captions.html fails after fixing https://bugs.webkit.org/show_bug.cgi?id=105536
+https://bugs.webkit.org/show_bug.cgi?id=106230
+
+Reviewed by Eric Carlson.
+
+Until Chromium has proper controls for lists of text tracks, the caption button
+needs to preserve its functionality.
+
+Updated TestExpectations to reactivate test.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Added explicit call to updateTextTrackDisplay.
+This enables hiding the tracks immediately.
+* html/shadow/MediaControlElements.cpp:
+(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Added extra check before rendering
+that captions should actually be displayed.
+
2013-01-10 Hajime Morrita
ComposedShadowTreeWalker shouldn't be exposed to non-ShadowDOM classes
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (139325 => 139326)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2013-01-10 17:44:05 UTC (rev 139325)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2013-01-10 17:45:41 UTC (rev 139326)
@@ -4136,6 +4136,7 @@
m_disableCaptions = !m_closedCaptionsVisible;
markCaptionAndSubtitleTracksAsUnconfigured();
+mediaControls()->updateTextTrackDisplay();
}
#else
if (hasMediaControls())
Modified: trunk/Source/WebCore/html/shadow/MediaControlElements.cpp (139325 => 139326)
--- trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2013-01-10 17:44:05 UTC (rev 139325)
+++ trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2013-01-10 17:45:41 UTC (rev 139326)
@@ -1247,12 +1247,16 @@
void MediaControlTextTrackContainerElement::updateDisplay()
{
+if (!mediaController()->closedCaptionsVisible()) {
+m_cueContainer->removeChildren();
+return;
+}
+
HTMLMediaElement* mediaElement = toParentMediaElement(this);
-
// 1. If the media element is an audio element, or is another playback
//
[webkit-changes] [138966] trunk
Title: [138966] trunk
Revision 138966
Author vic...@rosedu.org
Date 2013-01-07 11:21:07 -0800 (Mon, 07 Jan 2013)
Log Message
[Track] Rendering crash
https://bugs.webkit.org/show_bug.cgi?id=106199
Reviewed by Eric Carlson.
Source/WebCore:
The browser is crashing if a text track is added through _javascript_,
due to the fact that the containing block is not marked as inline at
the time RenderTextTrackCue::layout() is called. The fix consists
of ensuring that the pseudo id is set, even if the track isn't
yet visible.
Test: media/track/track-cue-inline-assertion-crash.html
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::updateDisplayTree): The pseudo-id should
be set when the display tree is generated.
(WebCore::TextTrackCue::getDisplayTree): Added extra check to not
do unneccessary logic if the track will never be displayed.
LayoutTests:
* media/track/track-cue-inline-assertion-crash-expected.txt: Added.
* media/track/track-cue-inline-assertion-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/TextTrackCue.cpp
Added Paths
trunk/LayoutTests/media/track/track-cue-inline-assertion-crash-expected.txt
trunk/LayoutTests/media/track/track-cue-inline-assertion-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138965 => 138966)
--- trunk/LayoutTests/ChangeLog 2013-01-07 19:04:56 UTC (rev 138965)
+++ trunk/LayoutTests/ChangeLog 2013-01-07 19:21:07 UTC (rev 138966)
@@ -1,3 +1,13 @@
+2013-01-07 Victor Carbune
+
+[Track] Rendering crash
+https://bugs.webkit.org/show_bug.cgi?id=106199
+
+Reviewed by Eric Carlson.
+
+* media/track/track-cue-inline-assertion-crash-expected.txt: Added.
+* media/track/track-cue-inline-assertion-crash.html: Added.
+
2013-01-07 Michael Pruett
[JSC] Copy non-index properties of arrays in SerializedScriptValue
Added: trunk/LayoutTests/media/track/track-cue-inline-assertion-crash-expected.txt (0 => 138966)
--- trunk/LayoutTests/media/track/track-cue-inline-assertion-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/media/track/track-cue-inline-assertion-crash-expected.txt 2013-01-07 19:21:07 UTC (rev 138966)
@@ -0,0 +1,10 @@
+Tests that adding a track and changing its mode through JS doesn't crash the browser.
+
+** Add a text track through JS to the video element **
+** Add cue to the text track **
+** Set the track mode to showing **
+
+No crash. PASS.
+
+END OF TEST
+
Added: trunk/LayoutTests/media/track/track-cue-inline-assertion-crash.html (0 => 138966)
--- trunk/LayoutTests/media/track/track-cue-inline-assertion-crash.html (rev 0)
+++ trunk/LayoutTests/media/track/track-cue-inline-assertion-crash.html 2013-01-07 19:21:07 UTC (rev 138966)
@@ -0,0 +1,40 @@
+
+
+
+
+
+
+function startTest()
+{
+findMediaElement();
+
+consoleWrite("** Add a text track through JS to the video element **");
+var t = video.addTextTrack('captions', 'English', 'en');
+
+consoleWrite("** Add cue to the text track **");
+t.addCue(new TextTrackCue(0.0, 10.0, 'wow wow'));
+
+consoleWrite("** Set the track mode to showing **");
+t.mode = "showing";
+
+consoleWrite("");
+consoleWrite("No crash. PASS.");
+consoleWrite("");
+
+endTest();
+}
+
+
+
+
+Tests that adding a track and changing its mode through JS doesn't crash the browser.
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (138965 => 138966)
--- trunk/Source/WebCore/ChangeLog 2013-01-07 19:04:56 UTC (rev 138965)
+++ trunk/Source/WebCore/ChangeLog 2013-01-07 19:21:07 UTC (rev 138966)
@@ -1,3 +1,24 @@
+2013-01-07 Victor Carbune
+
+[Track] Rendering crash
+https://bugs.webkit.org/show_bug.cgi?id=106199
+
+Reviewed by Eric Carlson.
+
+The browser is crashing if a text track is added through _javascript_,
+due to the fact that the containing block is not marked as inline at
+the time RenderTextTrackCue::layout() is called. The fix consists
+of ensuring that the pseudo id is set, even if the track isn't
+yet visible.
+
+Test: media/track/track-cue-inline-assertion-crash.html
+
+* html/track/TextTrackCue.cpp:
+(WebCore::TextTrackCue::updateDisplayTree): The pseudo-id should
+be set when the display tree is generated.
+(WebCore::TextTrackCue::getDisplayTree): Added extra check to not
+do unneccessary logic if the track will never be displayed.
+
2013-01-07 Michael Pruett
[JSC] Copy non-index properties of arrays
[webkit-changes] [127176] trunk
Title: [127176] trunk Revision 127176 Author vic...@rosedu.org Date 2012-08-30 13:06:22 -0700 (Thu, 30 Aug 2012) Log Message [Chromium] Layout Test media/track/track-cue-rendering-snap-to-lines-not-set.html is flaky https://bugs.webkit.org/show_bug.cgi?id=89167 Reviewed by Eric Carlson. Source/WebCore: Fix for rendering tracks when snap-to-lines not set. No new tests. Removed from TestExpectations existing test. * html/track/TextTrackCue.cpp: (WebCore::TextTrackCue::TextTrackCue): (WebCore::TextTrackCue::calculateDisplayParameters): Updated the place where m_computedLinePosition is determined. LayoutTests: Removed possible flaky test from TestExceptations. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/track/TextTrackCue.cpp Diff Modified: trunk/LayoutTests/ChangeLog (127175 => 127176) --- trunk/LayoutTests/ChangeLog 2012-08-30 20:02:02 UTC (rev 127175) +++ trunk/LayoutTests/ChangeLog 2012-08-30 20:06:22 UTC (rev 127176) @@ -1,3 +1,14 @@ +2012-08-30 Victor Carbune + +[Chromium] Layout Test media/track/track-cue-rendering-snap-to-lines-not-set.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=89167 + +Reviewed by Eric Carlson. + +Removed possible flaky test from TestExceptations. + +* platform/chromium/TestExpectations: + 2012-08-30 Alexandru Chiculita [CSS Shaders] Update css3/filters/custom/effect-custom-transform-parameters.html to remove anti-aliasing issues Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127175 => 127176) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-30 20:02:02 UTC (rev 127175) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-30 20:06:22 UTC (rev 127176) @@ -3301,9 +3301,6 @@ BUGCR132898 : http/tests/websocket/tests/hybi/workers/close.html = PASS TEXT -// Flaky -BUGWK89167 : media/track/track-cue-rendering-snap-to-lines-not-set.html = TEXT PASS - // Timing out on some Windows bots BUGWK89510 WIN : gamepad/gamepad-polling-access.html = PASS TIMEOUT Modified: trunk/Source/WebCore/ChangeLog (127175 => 127176) --- trunk/Source/WebCore/ChangeLog 2012-08-30 20:02:02 UTC (rev 127175) +++ trunk/Source/WebCore/ChangeLog 2012-08-30 20:06:22 UTC (rev 127176) @@ -1,3 +1,19 @@ +2012-08-30 Victor Carbune + +[Chromium] Layout Test media/track/track-cue-rendering-snap-to-lines-not-set.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=89167 + +Reviewed by Eric Carlson. + +Fix for rendering tracks when snap-to-lines not set. + +No new tests. Removed from TestExpectations existing test. + +* html/track/TextTrackCue.cpp: +(WebCore::TextTrackCue::TextTrackCue): +(WebCore::TextTrackCue::calculateDisplayParameters): Updated the place +where m_computedLinePosition is determined. + 2012-08-27 James Robinson [chromium] Add CompositorSupport interface for constructing compositor classes Modified: trunk/Source/WebCore/html/track/TextTrackCue.cpp (127175 => 127176) --- trunk/Source/WebCore/html/track/TextTrackCue.cpp 2012-08-30 20:02:02 UTC (rev 127175) +++ trunk/Source/WebCore/html/track/TextTrackCue.cpp 2012-08-30 20:06:22 UTC (rev 127176) @@ -212,10 +212,6 @@ m_displayWritingModeMap[Horizontal] = CSSValueHorizontalTb; m_displayWritingModeMap[VerticalGrowingLeft] = CSSValueVerticalRl; m_displayWritingModeMap[VerticalGrowingRight] = CSSValueVerticalLr; - -// A text track cue has a text track cue computed line position whose value -// is defined in terms of the other aspects of the cue. -m_computedLinePosition = calculateComputedLinePosition(); } TextTrackCue::~TextTrackCue() @@ -644,6 +640,10 @@ if (!m_snapToLines && (m_writingDirection == VerticalGrowingLeft || m_writingDirection == VerticalGrowingRight)) m_displayPosition.first = m_computedLinePosition; + +// A text track cue has a text track cue computed line position whose value +// is defined in terms of the other aspects of the cue. +m_computedLinePosition = calculateComputedLinePosition(); } void TextTrackCue::updateDisplayTree(float movieTime) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127168] trunk
Title: [127168] trunk
Revision 127168
Author vic...@rosedu.org
Date 2012-08-30 11:53:02 -0700 (Thu, 30 Aug 2012)
Log Message
[Chromium] The CC button is not painted
https://bugs.webkit.org/show_bug.cgi?id=95395
Reviewed by Eric Carlson.
Source/WebCore:
The actual Chromium resource for the CC button was not used by the Chromium theme.
Existing track rendering tests will be rebaselined and contain the new CC button.
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaClosedCaptionsButton): Added for proper painting of the resource.
(WebCore):
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
Changed to call paintMediaClosedCaptionsButton when the control is the CC button.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintMediaToggleClosedCaptionsButton):
Implemented proper behaviour.
(WebCore):
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
LayoutTests:
No new tests, the existing ones will need to be rebaselined and include the CC button.
* platform/chromium/TestExpectations: Marked tests failing accordingly for rebaselining.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderMediaControlsChromium.cpp
trunk/Source/WebCore/rendering/RenderThemeChromiumSkia.cpp
trunk/Source/WebCore/rendering/RenderThemeChromiumSkia.h
Diff
Modified: trunk/LayoutTests/ChangeLog (127167 => 127168)
--- trunk/LayoutTests/ChangeLog 2012-08-30 18:45:03 UTC (rev 127167)
+++ trunk/LayoutTests/ChangeLog 2012-08-30 18:53:02 UTC (rev 127168)
@@ -1,3 +1,14 @@
+2012-08-30 Victor Carbune
+
+[Chromium] The CC button is not painted
+https://bugs.webkit.org/show_bug.cgi?id=95395
+
+Reviewed by Eric Carlson.
+
+No new tests, the existing ones will need to be rebaselined and include the CC button.
+
+* platform/chromium/TestExpectations: Marked tests failing accordingly for rebaselining.
+
2012-08-30 Jessie Berlin
Assertion failure in MessagePort::contextDestroyed in
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127167 => 127168)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-30 18:45:03 UTC (rev 127167)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-30 18:53:02 UTC (rev 127168)
@@ -3612,6 +3612,10 @@
BUGWK95101 SNOWLEOPARD : fast/text/atsui-bidi-control.html = PASS TIMEOUT
+// These need new baselines: both new tests and new CC button has just been added.
+BUGWK95395 : media/track/track-cue-rendering-horizontal.html = IMAGE+TEXT
+BUGWK95395 : media/track/track-cue-rendering-vertical.html = IMAGE+TEXT
+
// Failing due to sub-pixel layout.
BUGWK95136 : fast/css/sticky/sticky-left-percentage.html = IMAGE
BUGWK95136 WIN LINUX : fast/css/sticky/sticky-writing-mode-vertical-lr.html = IMAGE
Modified: trunk/Source/WebCore/ChangeLog (127167 => 127168)
--- trunk/Source/WebCore/ChangeLog 2012-08-30 18:45:03 UTC (rev 127167)
+++ trunk/Source/WebCore/ChangeLog 2012-08-30 18:53:02 UTC (rev 127168)
@@ -1,3 +1,26 @@
+2012-08-30 Victor Carbune
+
+[Chromium] The CC button is not painted
+https://bugs.webkit.org/show_bug.cgi?id=95395
+
+Reviewed by Eric Carlson.
+
+The actual Chromium resource for the CC button was not used by the Chromium theme.
+
+Existing track rendering tests will be rebaselined and contain the new CC button.
+
+* rendering/RenderMediaControlsChromium.cpp:
+(WebCore::paintMediaClosedCaptionsButton): Added for proper painting of the resource.
+(WebCore):
+(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
+Changed to call paintMediaClosedCaptionsButton when the control is the CC button.
+* rendering/RenderThemeChromiumSkia.cpp:
+(WebCore::RenderThemeChromiumSkia::paintMediaToggleClosedCaptionsButton):
+Implemented proper behaviour.
+(WebCore):
+* rendering/RenderThemeChromiumSkia.h:
+(RenderThemeChromiumSkia):
+
2012-08-30 Tommy Widenflycht
MediaStream API: Introduce MediaConstraints
Modified: trunk/Source/WebCore/rendering/RenderMediaControlsChromium.cpp (127167 => 127168)
--- trunk/Source/WebCore/rendering/RenderMediaControlsChromium.cpp 2012-08-30 18:45:03 UTC (rev 127167)
+++ trunk/Source/WebCore/rendering/RenderMediaControlsChromium.cpp 2012-08-30 18:53:02 UTC (rev 127168)
@@ -327,6 +327,17 @@
return paintMediaButton(paintInfo.context, rect, mediaFullscreenButton);
}
+static bool paintMediaClosedCaptionsButton(RenderObject* object, const PaintInfo& paintInfo, const IntRect& rect)
+{
+HTMLMediaElement* mediaElement = toParentMediaElement(object);
+if (!mediaElement)
+return false;
+
+static Image* mediaClosedCaptionButton = platformResource("mediaplayerClosedCaption");
+return pain
[webkit-changes] [126776] trunk
Title: [126776] trunk
Revision 126776
Author vic...@rosedu.org
Date 2012-08-27 11:05:44 -0700 (Mon, 27 Aug 2012)
Log Message
Crash when trying to render empty cues
https://bugs.webkit.org/show_bug.cgi?id=94776
Reviewed by Eric Carlson.
Added extra safety checks.
Source/WebCore:
Test: media/track/track-cue-rendering-empty-cue-crash.html
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getCueAsHTML):
(WebCore::TextTrackCue::updateDisplayTree):
LayoutTests:
* media/track/track-cue-rendering-empty-cue-crash-expected.txt: Added.
* media/track/track-cue-rendering-empty-cue-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/TextTrackCue.cpp
Added Paths
trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash-expected.txt
trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (126775 => 126776)
--- trunk/LayoutTests/ChangeLog 2012-08-27 17:56:10 UTC (rev 126775)
+++ trunk/LayoutTests/ChangeLog 2012-08-27 18:05:44 UTC (rev 126776)
@@ -1,3 +1,15 @@
+2012-08-27 Victor Carbune
+
+Crash when trying to render empty cues
+https://bugs.webkit.org/show_bug.cgi?id=94776
+
+Reviewed by Eric Carlson.
+
+Added extra safety checks.
+
+* media/track/track-cue-rendering-empty-cue-crash-expected.txt: Added.
+* media/track/track-cue-rendering-empty-cue-crash.html: Added.
+
2012-08-27 Julien Chaffraix
Unreviewed Chromium gardening.
Added: trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash-expected.txt (0 => 126776)
--- trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash-expected.txt 2012-08-27 18:05:44 UTC (rev 126776)
@@ -0,0 +1,10 @@
+Tests that having empty cues does not crash the browser.
+
+** Add a text track to the video element **
+** Add an empty cue to the track **
+** Play the video and render the cue **
+
+No crash. PASS.
+
+END OF TEST
+
Added: trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash.html (0 => 126776)
--- trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash.html (rev 0)
+++ trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash.html 2012-08-27 18:05:44 UTC (rev 126776)
@@ -0,0 +1,36 @@
+
+
+
+
+
+
+function startTest()
+{
+findMediaElement();
+video.src = "" '../content/test');
+
+consoleWrite("** Add a text track to the video element **");
+video.addTextTrack("captions", "regular captions track", "en");
+
+consoleWrite("** Add an empty cue to the track **");
+video.textTracks[0].addCue(new TextTrackCue(0.00, 4.00, ""));
+
+consoleWrite("** Play the video and render the cue **");
+video.play();
+
+consoleWrite("");
+consoleWrite("No crash. PASS.");
+consoleWrite("");
+
+endTest();
+ }
+
+
+
+
+Tests that having empty cues does not crash the browser.
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (126775 => 126776)
--- trunk/Source/WebCore/ChangeLog 2012-08-27 17:56:10 UTC (rev 126775)
+++ trunk/Source/WebCore/ChangeLog 2012-08-27 18:05:44 UTC (rev 126776)
@@ -1,3 +1,18 @@
+2012-08-27 Victor Carbune
+
+Crash when trying to render empty cues
+https://bugs.webkit.org/show_bug.cgi?id=94776
+
+Reviewed by Eric Carlson.
+
+Added extra safety checks.
+
+Test: media/track/track-cue-rendering-empty-cue-crash.html
+
+* html/track/TextTrackCue.cpp:
+(WebCore::TextTrackCue::getCueAsHTML):
+(WebCore::TextTrackCue::updateDisplayTree):
+
2012-08-24 Simon Fraser
Implement sticky positioning
Modified: trunk/Source/WebCore/html/track/TextTrackCue.cpp (126775 => 126776)
--- trunk/Source/WebCore/html/track/TextTrackCue.cpp 2012-08-27 17:56:10 UTC (rev 126775)
+++ trunk/Source/WebCore/html/track/TextTrackCue.cpp 2012-08-27 18:05:44 UTC (rev 126776)
@@ -473,6 +473,9 @@
m_hasInnerTimestamps = false;
m_documentFragment = WebVTTParser::create(0, m_scriptExecutionContext)->createDocumentFragmentFromCueText(m_content);
+if (!m_documentFragment)
+ return 0;
+
for (Node *child = m_documentFragment->firstChild(); !m_hasInnerTimestamps && child; child = child->nextSibling()) {
if (child->nodeName() == "timestamp")
m_hasInnerTimestamps = true;
@@ -652,6 +655,9 @@
DEFINE_STATIC_LOCAL(const AtomicString, trackPastNodesShadowPseudoId, ("
[webkit-changes] [126368] trunk/Tools
Title: [126368] trunk/Tools
Revision 126368
Author vic...@rosedu.org
Date 2012-08-22 17:13:53 -0700 (Wed, 22 Aug 2012)
Log Message
2012-08-23 Victor Carbune
Add myself to the committer list
https://bugs.webkit.org/show_bug.cgi?id=94659
Reviewed by James Robinson.
Added my email and IRC handle.
* Scripts/webkitpy/common/config/committers.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/ChangeLog (126367 => 126368)
--- trunk/Tools/ChangeLog 2012-08-23 00:08:18 UTC (rev 126367)
+++ trunk/Tools/ChangeLog 2012-08-23 00:13:53 UTC (rev 126368)
@@ -1,3 +1,14 @@
+2012-08-23 Victor Carbune
+
+Add myself to the committer list
+https://bugs.webkit.org/show_bug.cgi?id=94659
+
+Reviewed by James Robinson.
+
+Added my email and IRC handle.
+
+* Scripts/webkitpy/common/config/committers.py:
+
2012-08-22 Scott Graham
Don't unconditionally define NOMINMAX on Windows
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (126367 => 126368)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-08-23 00:08:18 UTC (rev 126367)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-08-23 00:13:53 UTC (rev 126368)
@@ -384,6 +384,7 @@
Committer("Tristan O'Tierney", ["tris...@otierney.net", "tris...@apple.com"]),
Committer("Vangelis Kokkevis", "vange...@chromium.org", "vangelis"),
Committer("Viatcheslav Ostapenko", "ostapenko.viatches...@nokia.com", "ostap"),
+Committer("Victor Carbune", "vic...@rosedu.org", "vcarbune"),
Committer("Victor Wang", "vict...@chromium.org", "victorw"),
Committer("Victoria Kirst", ["v...@chromium.org", "v...@google.com"], "vrk"),
Committer("Vincent Scheib", "sch...@chromium.org", "scheib"),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
