[webkit-changes] [WebKit/WebKit] ad1736: [JSC][32bit] Enable wasm signaling memory
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad17368e4bdbc6099f02e6c3871b05926893bcea https://github.com/WebKit/WebKit/commit/ad17368e4bdbc6099f02e6c3871b05926893bcea Author: Xan Lopez Date: 2023-02-17 (Fri, 17 Feb 2023) Changed paths: M JSTests/wasm/stress/shared-memory-errors.js M JSTests/wasm/stress/shared-wasm-memory-buffer.js M Source/JavaScriptCore/runtime/BufferMemoryHandle.cpp M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/wasm/WasmMemory.cpp M Source/WTF/wtf/PlatformEnable.h Log Message: --- [JSC][32bit] Enable wasm signaling memory https://bugs.webkit.org/show_bug.cgi?id=244843 Reviewed by Yusuke Suzuki. Enable wasm signaling memory on 32bit architectures. The only thing we need to do is to limit the "fast mapped memory" size to 2GB, that way we can fit that plus the redzone pages inside a 32bit pointer. This is OK because our memory limit was already 2GB anyway (MAX_ARRAY_BUFFER_SIZE). * JSTests/wasm.yaml: unskip shared memory tests on arm. * JSTests/wasm/stress/shared-memory-errors.js: ditto. * JSTests/wasm/stress/shared-wasm-memory-buffer.js: ditto. * Source/JavaScriptCore/wasm/WasmMemory.cpp: use a fast memory mapped * size of 2GB for 32bit architectures. * (JSC::Wasm::Memory::fastMappedBytes): * Source/WTF/wtf/PlatformEnable.h: enable wasm memory signaling on * 32bit. * Source/JavaScriptCore/runtime/BufferMemoryHandle.cpp: (JSC::BufferMemoryHandle::fastMappedRedzoneBytes): * Source/JavaScriptCore/runtime/Options.cpp: (JSC::Options::notifyOptionsChanged): Canonical link: https://commits.webkit.org/260483@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [148665] trunk/Source/WebKit2
Title: [148665] trunk/Source/WebKit2 Revision 148665 Author x...@webkit.org Date 2013-04-18 03:35:37 -0700 (Thu, 18 Apr 2013) Log Message [GTK] When the WebProcess crashes, a signal should be emitted https://bugs.webkit.org/show_bug.cgi?id=105180 Reviewed Carlos Garcia Campos. Emit a "web-process-crashed" signal when the WebProcess crashes. This is useful, for example, to show an error page in a web browser like Chrome does. * UIProcess/API/gtk/WebKitLoaderClient.cpp: (processDidCrash): (attachLoaderClientToView): * UIProcess/API/gtk/WebKitWebContextPrivate.h: * UIProcess/API/gtk/WebKitWebView.cpp: (webkit_web_view_class_init): (webkitWebViewWebProcessCrashed): * UIProcess/API/gtk/tests/TestWebExtensions.cpp: (testWebExtensionGetTitle): (webProcessCrashedCallback): (testWebKitWebViewProcessCrashed): (beforeAll): * UIProcess/API/gtk/tests/WebExtensionTest.cpp: (methodCallCallback): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (148664 => 148665) --- trunk/Source/WebKit2/ChangeLog 2013-04-18 10:27:08 UTC (rev 148664) +++ trunk/Source/WebKit2/ChangeLog 2013-04-18 10:35:37 UTC (rev 148665) @@ -1,3 +1,29 @@ +2013-04-18 Xan Lopez + +[GTK] When the WebProcess crashes, a signal should be emitted +https://bugs.webkit.org/show_bug.cgi?id=105180 + +Emit a "web-process-crashed" signal when the WebProcess crashes. This +is useful, for example, to show an error page in a web browser +like Chrome does. + +Reviewed Carlos Garcia Campos. + +* UIProcess/API/gtk/WebKitLoaderClient.cpp: +(processDidCrash): +(attachLoaderClientToView): +* UIProcess/API/gtk/WebKitWebContextPrivate.h: +* UIProcess/API/gtk/WebKitWebView.cpp: +(webkit_web_view_class_init): +(webkitWebViewWebProcessCrashed): +* UIProcess/API/gtk/tests/TestWebExtensions.cpp: +(testWebExtensionGetTitle): +(webProcessCrashedCallback): +(testWebKitWebViewProcessCrashed): +(beforeAll): +* UIProcess/API/gtk/tests/WebExtensionTest.cpp: +(methodCallCallback): + 2013-04-18 Kenneth Rohde Christiansen [EFL][WK2] Add tooltip API to the WKView client Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp (148664 => 148665) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp 2013-04-18 10:27:08 UTC (rev 148664) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp 2013-04-18 10:35:37 UTC (rev 148665) @@ -133,6 +133,11 @@ webkitWebViewHandleAuthenticationChallenge(WEBKIT_WEB_VIEW(clientInfo), toImpl(authenticationChallenge)); } +static void processDidCrash(WKPageRef page, const void* clientInfo) +{ +webkitWebViewWebProcessCrashed(WEBKIT_WEB_VIEW(clientInfo)); +} + void attachLoaderClientToView(WebKitWebView* webView) { WKPageLoaderClient wkLoaderClient = { @@ -159,7 +164,7 @@ didChangeProgress, // didFinishProgress 0, // didBecomeUnresponsive 0, // didBecomeResponsive -0, // processDidCrash +processDidCrash, didChangeBackForwardList, 0, // shouldGoToBackForwardListItem 0, // didFailToInitializePlugin Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (148664 => 148665) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2013-04-18 10:27:08 UTC (rev 148664) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2013-04-18 10:35:37 UTC (rev 148665) @@ -117,6 +117,8 @@ INSECURE_CONTENT_DETECTED, +WEB_PROCESS_CRASHED, + LAST_SIGNAL }; @@ -1298,6 +1300,25 @@ g_cclosure_marshal_VOID__ENUM, G_TYPE_NONE, 1, WEBKIT_TYPE_INSECURE_CONTENT_EVENT); + +/** + * WebKitWebView::web-process-crashed: + * @web_view: the #WebKitWebView + * + * This signal is emitted when the web process crashes. + * + * Returns: %TRUE to stop other handlers from being invoked for the event. + *%FALSE to propagate the event further. + */ +signals[WEB_PROCESS_CRASHED] = g_signal_new( +"web-process-crashed", +G_TYPE_FROM_CLASS(webViewClass), +G_SIGNAL_RUN_LAST, +G_STRUCT_OFFSET(WebKitWebViewClass, web_process_crashed), +g_signal_accumulator_true_handled, +0, +webkit_marshal_BOOLEAN__VOID, +G_TYPE_BOOLEAN, 0); } static void webkitWebViewSetIsLoading(WebKitWebView* webView, bool isLoading) @@ -3027,3 +3048,10 @@ ret
[webkit-changes] [137025] trunk/Source/WebCore
Title: [137025] trunk/Source/WebCore Revision 137025 Author x...@webkit.org Date 2012-12-08 02:44:27 -0800 (Sat, 08 Dec 2012) Log Message Build fix after r137003. Wrap Microdata only sections with ENABLE(MICRODATA). * dom/NodeRareData.h: (NodeRareData): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/NodeRareData.h Diff Modified: trunk/Source/WebCore/ChangeLog (137024 => 137025) --- trunk/Source/WebCore/ChangeLog 2012-12-08 10:37:03 UTC (rev 137024) +++ trunk/Source/WebCore/ChangeLog 2012-12-08 10:44:27 UTC (rev 137025) @@ -1,3 +1,10 @@ +2012-12-08 Xan Lopez + +Build fix after r137003. Wrap Microdata only sections with ENABLE(MICRODATA). + +* dom/NodeRareData.h: +(NodeRareData): + 2012-12-08 Ryosuke Niwa Build fix after r137003. Wrap NodeMutationObserverData with ENABLE(MUTATION_OBSERVERS). Modified: trunk/Source/WebCore/dom/NodeRareData.h (137024 => 137025) --- trunk/Source/WebCore/dom/NodeRareData.h 2012-12-08 10:37:03 UTC (rev 137024) +++ trunk/Source/WebCore/dom/NodeRareData.h 2012-12-08 10:44:27 UTC (rev 137025) @@ -235,6 +235,7 @@ }; #endif +#if ENABLE(MICRODATA) struct NodeMicroDataTokenLists { RefPtr m_itemProp; RefPtr m_itemRef; @@ -242,6 +243,7 @@ static PassOwnPtr create() { return adoptPtr(new NodeMicroDataTokenLists); } }; +#endif public: NodeRareData(Document* document) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136440] trunk/LayoutTests
Title: [136440] trunk/LayoutTests Revision 136440 Author x...@webkit.org Date 2012-12-03 14:48:39 -0800 (Mon, 03 Dec 2012) Log Message 2012-12-03 Xan Lopez Unreviewed gardening. Update grid layout tests with proper expected results for cosmetic debug() changes I did in the previous patch. * fast/css-grid-layout/grid-columns-rows-get-set-expected.txt: * fast/css-grid-layout/resources/grid-columns-rows-get-set.js: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt trunk/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js Diff Modified: trunk/LayoutTests/ChangeLog (136439 => 136440) --- trunk/LayoutTests/ChangeLog 2012-12-03 22:20:47 UTC (rev 136439) +++ trunk/LayoutTests/ChangeLog 2012-12-03 22:48:39 UTC (rev 136440) @@ -1,3 +1,13 @@ +2012-12-03 Xan Lopez + +Unreviewed gardening. + +Update grid layout tests with proper expected results for cosmetic +debug() changes I did in the previous patch. + +* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt: +* fast/css-grid-layout/resources/grid-columns-rows-get-set.js: + 2012-12-03 Stephen White [Chromium] Unreviewed gardening. Modified: trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt (136439 => 136440) --- trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt 2012-12-03 22:20:47 UTC (rev 136439) +++ trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt 2012-12-03 22:48:39 UTC (rev 136440) @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -Test getting |display| set through CSS +Test getting -webkit-grid-columns and -webkit-grid-rows set through CSS PASS getComputedStyle(gridWithNoneElement, '').getPropertyValue('-webkit-grid-columns') is 'none' PASS getComputedStyle(gridWithNoneElement, '').getPropertyValue('-webkit-grid-rows') is 'none' PASS getComputedStyle(gridWithFixedElement, '').getPropertyValue('-webkit-grid-columns') is '10px' @@ -16,6 +16,7 @@ PASS getComputedStyle(gridWithEMElement, '').getPropertyValue('-webkit-grid-rows') is '150px' PASS getComputedStyle(gridWithViewPortPercentageElement, '').getPropertyValue('-webkit-grid-columns') is '64px' PASS getComputedStyle(gridWithViewPortPercentageElement, '').getPropertyValue('-webkit-grid-rows') is '60px' +Test getting wrong values for -webkit-grid-columns and -webkit-grid-rows through CSS (they should resolve to the default: 'none') PASS getComputedStyle(gridWithFitContentElement, '').getPropertyValue('-webkit-grid-columns') is 'none' PASS getComputedStyle(gridWithFitContentElement, '').getPropertyValue('-webkit-grid-rows') is 'none' PASS getComputedStyle(gridWithFitAvailableElement, '').getPropertyValue('-webkit-grid-columns') is 'none' @@ -25,7 +26,7 @@ PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-columns') is 'none' PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-rows') is 'none' -Test getting and setting display through JS +Test getting and setting -webkit-grid-columns and -webkit-grid-rows through JS PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-columns') is '18px' PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-rows') is '66px' PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-columns') is '55%' Modified: trunk/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js (136439 => 136440) --- trunk/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js 2012-12-03 22:20:47 UTC (rev 136439) +++ trunk/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js 2012-12-03 22:48:39 UTC (rev 136440) @@ -25,7 +25,7 @@ shouldBe("getComputedStyle(gridWithViewPortPercentageElement, '').getPropertyValue('-webkit-grid-columns')", "'64px'"); shouldBe("getComputedStyle(gridWithViewPortPercentageElement, '').getPropertyValue('-webkit-grid-rows')", "'60px'"); -debug("Test getting wrong values for -webkit-grid-columns and -webkit-grid-rows through CSS (they should resolve to the default: 'none'."); +debug("Test getting wrong values for -webkit-grid-columns and -webkit-grid-rows through CSS (they should resolve to the default:
[webkit-changes] [136432] trunk
Title: [136432] trunk Revision 136432 Author x...@webkit.org Date 2012-12-03 13:07:53 -0800 (Mon, 03 Dec 2012) Log Message 2012-12-03 Xan Lopez [CSS Grid Layout] Support and viewport-relative breadth sizes https://bugs.webkit.org/show_bug.cgi?id=103335 Reviewed by Julien Chaffraix. Test: fast/css-grid-layout/breadth-size-resolution-grid.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForGridTrackBreadth): Support the new types. (WebCore::valueForGridTrackMinMax): Modify the call to previous method, since the signature has changed. (WebCore::valueForGridTrackGroup): Ditto. (WebCore::valueForGridTrackList): Ditto. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto. * rendering/RenderGrid.cpp: (WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Suport percent and viewport relative types, calc() will be supported in a follow up (see bug #103761) 2012-12-03 Xan Lopez [CSS Grid Layout] Support and viewport-relative breadth sizes https://bugs.webkit.org/show_bug.cgi?id=103335 Reviewed by Julien Chaffraix. * fast/css-grid-layout/breadth-size-resolution-grid-expected.txt: Added. * fast/css-grid-layout/breadth-size-resolution-grid.html: Added. * fast/css-grid-layout/grid-columns-rows-get-set-expected.txt: * fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt: * fast/css-grid-layout/grid-columns-rows-get-set-multiple.html: * fast/css-grid-layout/grid-columns-rows-get-set.html: * fast/css-grid-layout/percent-grid-item-in-percent-grid-track-expected.txt: * fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid-expected.txt: * fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js: * fast/css-grid-layout/resources/grid-columns-rows-get-set.js: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple.html trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set.html trunk/LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-expected.txt trunk/LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid-expected.txt trunk/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js trunk/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/rendering/RenderGrid.cpp Added Paths trunk/LayoutTests/fast/css-grid-layout/breadth-size-resolution-grid-expected.txt trunk/LayoutTests/fast/css-grid-layout/breadth-size-resolution-grid.html Diff Modified: trunk/LayoutTests/ChangeLog (136431 => 136432) --- trunk/LayoutTests/ChangeLog 2012-12-03 21:05:27 UTC (rev 136431) +++ trunk/LayoutTests/ChangeLog 2012-12-03 21:07:53 UTC (rev 136432) @@ -1,3 +1,21 @@ +2012-12-03 Xan Lopez + +[CSS Grid Layout] Support and viewport-relative breadth sizes +https://bugs.webkit.org/show_bug.cgi?id=103335 + +Reviewed by Julien Chaffraix. + +* fast/css-grid-layout/breadth-size-resolution-grid-expected.txt: Added. +* fast/css-grid-layout/breadth-size-resolution-grid.html: Added. +* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt: +* fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt: +* fast/css-grid-layout/grid-columns-rows-get-set-multiple.html: +* fast/css-grid-layout/grid-columns-rows-get-set.html: +* fast/css-grid-layout/percent-grid-item-in-percent-grid-track-expected.txt: +* fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid-expected.txt: +* fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js: +* fast/css-grid-layout/resources/grid-columns-rows-get-set.js: + 2012-12-03 Max Vujovic [CSS Shaders] Do not clamp indirect array indices during CSS Shaders ANGLE validation pass Added: trunk/LayoutTests/fast/css-grid-layout/breadth-size-resolution-grid-expected.txt (0 => 136432) --- trunk/LayoutTests/fast/css-grid-layout/breadth-size-resolution-grid-expected.txt (rev 0) +++ trunk/LayoutTests/fast/css-grid-layout/breadth-size-resolution-grid-expected.txt 2012-12-03 21:07:53 UTC (rev 136432) @@ -0,0 +1,5 @@ +Test that specifying the track breadth sizes works properly with all the allowed length types and in different writing modes. + +PASS +PASS +PASS Added: trunk/LayoutTests/fast/css-grid-layout/breadth-size-resolution-grid.html (0 => 136432) --- trunk/LayoutTests/fast
[webkit-changes] [134075] trunk/Source/WebCore
Title: [134075] trunk/Source/WebCore Revision 134075 Author x...@webkit.org Date 2012-11-09 09:09:06 -0800 (Fri, 09 Nov 2012) Log Message 2012-11-09 Xan Lopez [GTK] Do not use 'ls' to list IDL files in EXTRA_DIST https://bugs.webkit.org/show_bug.cgi?id=101581 Reviewed by Martin Robinson. Use normal GNU Make wildcards instead of 'ls' to list files in EXTRA_DIST, it's safer and more straightforward. * GNUmakefile.am: ditto. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am Diff Modified: trunk/Source/WebCore/ChangeLog (134074 => 134075) --- trunk/Source/WebCore/ChangeLog 2012-11-09 16:55:33 UTC (rev 134074) +++ trunk/Source/WebCore/ChangeLog 2012-11-09 17:09:06 UTC (rev 134075) @@ -1,3 +1,15 @@ +2012-11-09 Xan Lopez + +[GTK] Do not use 'ls' to list IDL files in EXTRA_DIST +https://bugs.webkit.org/show_bug.cgi?id=101581 + +Reviewed by Martin Robinson. + +Use normal GNU Make wildcards instead of 'ls' to list files in +EXTRA_DIST, it's safer and more straightforward. + +* GNUmakefile.am: ditto. + 2012-11-09 Charles Wei Need to clear exception in JSDictionary that might have been caused by previous operation. Modified: trunk/Source/WebCore/GNUmakefile.am (134074 => 134075) --- trunk/Source/WebCore/GNUmakefile.am 2012-11-09 16:55:33 UTC (rev 134074) +++ trunk/Source/WebCore/GNUmakefile.am 2012-11-09 17:09:06 UTC (rev 134075) @@ -718,35 +718,34 @@ $(XT_CFLAGS) EXTRA_DIST += \ - $(shell ls $(srcdir)/Source/WebCore/Modules/filesystem/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/Modules/gamepad/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/Modules/geolocation/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/Modules/indexeddb/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/Modules/mediasource/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/Modules/mediastream/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/Modules/navigatorcontentutils/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/Modules/notifications/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/Modules/quota/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/Modules/webaudio/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/Modules/webdatabase/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/Modules/websockets/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/css/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/dom/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/editing/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/fileapi/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/html/canvas/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/html/shadow/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/html/track/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/html/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/inspector/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/loader/appcache/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/page/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/plugins/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/storage/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/svg/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/testing/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/workers/*.idl) \ - $(shell ls $(srcdir)/Source/WebCore/xml/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/filesystem/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/gamepad/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/geolocation/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/indexeddb/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/mediasource/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/mediastream/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/navigatorcontentutils/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/notifications/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/quota/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/webaudio/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/webdatabase/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/Modules/websockets/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/css/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/dom/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/fileapi/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/html/canvas/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/html/shadow/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/html/track/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/html/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/inspector/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/loader/appcache/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/page/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/plugins/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/storage/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/svg/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/testing/*.idl) \ + $(wildcard $(srcdir)/Source/WebCore/workers/*.idl) \ + $
[webkit-changes] [114564] releases/WebKitGTK/webkit-1.8
Title: [114564] releases/WebKitGTK/webkit-1.8 Revision 114564 Author x...@webkit.org Date 2012-04-18 14:34:51 -0700 (Wed, 18 Apr 2012) Log Message [Soup] DNS prefetching spams resolver, shoots self in the foot https://bugs.webkit.org/show_bug.cgi?id=41630 Reviewed by Martin Robinson. .: Bump libsoup and glib dependencies. * Source/cmake/OptionsEfl.cmake: * configure.ac: Source/WebCore: Added generic DNSResolveQueue class to throttle DNS prefetches. It's an abstract refactoring of CFNET's DNSResolveQueue. Platform specific methods implemented for soup and CFNET backends. No new tests required as we're just refactoring existing code to be used by two different ports. * CMakeLists.txt: added new file. * GNUmakefile.list.am: ditto. * WebCore.vcproj/WebCore.vcproj: ditto. * WebCore.xcodeproj/project.pbxproj: ditto. * platform/network/DNSResolveQueue.cpp: Added. (WebCore): (WebCore::DNSResolveQueue::add): adds a new host to be prefetched. (WebCore::DNSResolveQueue::fired): by using a delay we coalesce several prefetch requests and try to resolve them all here. * platform/network/DNSResolveQueue.h: Added. (WebCore): (DNSResolveQueue): class that implements DNS prefetch throttling using a template pattern. (WebCore::DNSResolveQueue::shared): (WebCore::DNSResolveQueue::decrementRequestCount): * platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences): (WebCore::DNSResolveQueue::platformResolve): * platform/network/soup/DNSSoup.cpp: (WebCore): (WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences): (WebCore::resolvedCallback): (WebCore::DNSResolveQueue::platformResolve): (WebCore::prefetchDNS): Tools: Bump libsoup and glib dependencies. * efl/jhbuild.modules: * gtk/jhbuild.modules: Conflicts: Tools/efl/jhbuild.modules Modified Paths releases/WebKitGTK/webkit-1.8/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebCore/CMakeLists.txt releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebCore/GNUmakefile.list.am releases/WebKitGTK/webkit-1.8/Source/WebCore/WebCore.vcproj/WebCore.vcproj releases/WebKitGTK/webkit-1.8/Source/WebCore/WebCore.xcodeproj/project.pbxproj releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/cf/DNSCFNet.cpp releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/soup/DNSSoup.cpp releases/WebKitGTK/webkit-1.8/Source/cmake/OptionsEfl.cmake releases/WebKitGTK/webkit-1.8/Tools/ChangeLog releases/WebKitGTK/webkit-1.8/Tools/gtk/jhbuild.modules releases/WebKitGTK/webkit-1.8/configure.ac Added Paths releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/DNSResolveQueue.cpp releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/DNSResolveQueue.h Diff Modified: releases/WebKitGTK/webkit-1.8/ChangeLog (114563 => 114564) --- releases/WebKitGTK/webkit-1.8/ChangeLog 2012-04-18 21:34:25 UTC (rev 114563) +++ releases/WebKitGTK/webkit-1.8/ChangeLog 2012-04-18 21:34:51 UTC (rev 114564) @@ -1,3 +1,15 @@ +2012-03-28 Sergio Villar Senin + +[Soup] DNS prefetching spams resolver, shoots self in the foot +https://bugs.webkit.org/show_bug.cgi?id=41630 + +Reviewed by Martin Robinson. + +Bump libsoup and glib dependencies. + +* Source/cmake/OptionsEfl.cmake: +* configure.ac: + 2012-04-09 Martin Robinson [soup] Crash while loading http://www.jusco.cn Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/CMakeLists.txt (114563 => 114564) --- releases/WebKitGTK/webkit-1.8/Source/WebCore/CMakeLists.txt 2012-04-18 21:34:25 UTC (rev 114563) +++ releases/WebKitGTK/webkit-1.8/Source/WebCore/CMakeLists.txt 2012-04-18 21:34:51 UTC (rev 114564) @@ -1199,6 +1199,7 @@ platform/network/CredentialStorage.cpp platform/network/ContentTypeParser.cpp platform/network/DataURL.cpp +platform/network/DNSResolveQueue.cpp platform/network/FormDataBuilder.cpp platform/network/FormData.cpp platform/network/HTTPHeaderMap.cpp Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (114563 => 114564) --- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-18 21:34:25 UTC (rev 114563) +++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-18 21:34:51 UTC (rev 114564) @@ -1,3 +1,43 @@ +2012-03-28 Sergio Villar Senin + +[Soup] DNS prefetching spams resolver, shoots self in the foot +https://bugs.webkit.org/show_bug.cgi?id=41630 + +Reviewed by Martin Robinson. + +Added generic DNSResolveQueue class to throttle DNS +prefetches. It's an abstract refactoring of CFNET's +DNSResolveQueue. Platform specific methods implemented for soup +and CFNET backends. + +No new tests required as we're just refactoring existing code to +be used by two different ports. + +* CMakeLists.txt: added new file. +* GNUmakefile.list.am: ditto. +* WebCore.vcproj/WebCore.vcproj: ditto. +
[webkit-changes] [114563] releases/WebKitGTK/webkit-1.8/Source/WebCore
Title: [114563] releases/WebKitGTK/webkit-1.8/Source/WebCore Revision 114563 Author x...@webkit.org Date 2012-04-18 14:34:25 -0700 (Wed, 18 Apr 2012) Log Message Build error: DNSSoup.cpp:30: fatal error: CString.h: No such file or directory https://bugs.webkit.org/show_bug.cgi?id=81093 Patch by Sudarsana Nagineni on 2012-03-14 Reviewed by Philippe Normand. Fix build error introduced by r110669. * platform/network/soup/DNSSoup.cpp: Modified Paths releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/soup/DNSSoup.cpp Diff Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (114562 => 114563) --- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-18 21:34:11 UTC (rev 114562) +++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-18 21:34:25 UTC (rev 114563) @@ -1,3 +1,15 @@ +2012-03-14 Sudarsana Nagineni + +Build error: DNSSoup.cpp:30: fatal error: CString.h: No such file or +directory +https://bugs.webkit.org/show_bug.cgi?id=81093 + +Reviewed by Philippe Normand. + +Fix build error introduced by r110669. + +* platform/network/soup/DNSSoup.cpp: + 2012-03-13 Sergio Villar Senin [GTK] Use the same DNS prefetching path than the other ports. Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/soup/DNSSoup.cpp (114562 => 114563) --- releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/soup/DNSSoup.cpp 2012-04-18 21:34:11 UTC (rev 114562) +++ releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/soup/DNSSoup.cpp 2012-04-18 21:34:25 UTC (rev 114563) @@ -27,9 +27,9 @@ #include "config.h" #include "DNS.h" -#include "CString.h" #include "GOwnPtrSoup.h" #include "ResourceHandle.h" +#include namespace WebCore { ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114562] releases/WebKitGTK/webkit-1.8/Source/WebCore
Title: [114562] releases/WebKitGTK/webkit-1.8/Source/WebCore Revision 114562 Author x...@webkit.org Date 2012-04-18 14:34:11 -0700 (Wed, 18 Apr 2012) Log Message [GTK] Use the same DNS prefetching path than the other ports. https://bugs.webkit.org/show_bug.cgi?id=80997 Reviewed by Martin Robinson. This patch basically reverts r56128. There is no need to add an special code path for GTK+ DNS pre-fetching because the main reason to do that (some potential changes in libsoup) is not going to happen. It also reduces the amount of DNS queries by adding a NULL hostname check. No need for new tests as this just moves code around. * GNUmakefile.list.am: * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseAttribute): * html/HTMLLinkElement.cpp: * loader/LinkLoader.cpp: (WebCore::LinkLoader::loadLink): * page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement): * platform/network/DNS.h: (WebCore): * platform/network/ResourceHandle.cpp: * platform/network/ResourceHandle.h: (ResourceHandle): * platform/network/chromium/DNSChromium.cpp: * platform/network/soup/DNSSoup.cpp: restored. (WebCore): (WebCore::prefetchDNS): * platform/network/soup/ResourceHandleSoup.cpp: Modified Paths releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebCore/GNUmakefile.list.am releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLAnchorElement.cpp releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLLinkElement.cpp releases/WebKitGTK/webkit-1.8/Source/WebCore/loader/LinkLoader.cpp releases/WebKitGTK/webkit-1.8/Source/WebCore/page/Chrome.cpp releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/DNS.h releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/ResourceHandle.cpp releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/ResourceHandle.h releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/chromium/DNSChromium.cpp releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp Added Paths releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/soup/DNSSoup.cpp Diff Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (114561 => 114562) --- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-18 21:26:35 UTC (rev 114561) +++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-18 21:34:11 UTC (rev 114562) @@ -1,3 +1,37 @@ +2012-03-13 Sergio Villar Senin + +[GTK] Use the same DNS prefetching path than the other ports. +https://bugs.webkit.org/show_bug.cgi?id=80997 + +Reviewed by Martin Robinson. + +This patch basically reverts r56128. There is no need to add an +special code path for GTK+ DNS pre-fetching because the main +reason to do that (some potential changes in libsoup) is not +going to happen. It also reduces the amount of DNS queries by +adding a NULL hostname check. + +No need for new tests as this just moves code around. + +* GNUmakefile.list.am: +* html/HTMLAnchorElement.cpp: +(WebCore::HTMLAnchorElement::parseAttribute): +* html/HTMLLinkElement.cpp: +* loader/LinkLoader.cpp: +(WebCore::LinkLoader::loadLink): +* page/Chrome.cpp: +(WebCore::Chrome::mouseDidMoveOverElement): +* platform/network/DNS.h: +(WebCore): +* platform/network/ResourceHandle.cpp: +* platform/network/ResourceHandle.h: +(ResourceHandle): +* platform/network/chromium/DNSChromium.cpp: +* platform/network/soup/DNSSoup.cpp: restored. +(WebCore): +(WebCore::prefetchDNS): +* platform/network/soup/ResourceHandleSoup.cpp: + 2012-04-09 Martin Robinson [soup] Crash while loading http://www.jusco.cn Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/GNUmakefile.list.am (114561 => 114562) --- releases/WebKitGTK/webkit-1.8/Source/WebCore/GNUmakefile.list.am 2012-04-18 21:26:35 UTC (rev 114561) +++ releases/WebKitGTK/webkit-1.8/Source/WebCore/GNUmakefile.list.am 2012-04-18 21:34:11 UTC (rev 114562) @@ -3232,6 +3232,7 @@ Source/WebCore/platform/network/soup/CookieJarSoup.cpp \ Source/WebCore/platform/network/soup/CookieJarSoup.h \ Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp \ + Source/WebCore/platform/network/soup/DNSSoup.cpp \ Source/WebCore/platform/network/soup/GOwnPtrSoup.cpp \ Source/WebCore/platform/network/soup/GOwnPtrSoup.h \ Source/WebCore/platform/network/soup/ProxyServerSoup.cpp \ Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLAnchorElement.cpp (114561 => 114562) --- releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLAnchorElement.cpp 2012-04-18 21:26:35 UTC (rev 114561) +++ releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLAnchorElement.cpp 2012-04-18 21:34:11 UTC (rev 114562) @@ -25,6 +25,7 @@ #include "HTMLAnchorElement.h" #include "Attribute.h" +#include "DNS.h" #include "EventNames.h"
[webkit-changes] [114528] releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
Title: [114528] releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk Revision 114528 Author x...@webkit.org Date 2012-04-18 10:23:15 -0700 (Wed, 18 Apr 2012) Log Message [GTK] Enable back double buffering on WebKitWebView to fix flickering https://bugs.webkit.org/show_bug.cgi?id=84149 Patch by Carlos Garnacho on 2012-04-17 Reviewed by Martin Robinson. Despite having WebKitWebView its own backing buffer, calling gtk_widget_set_double_buffered(...,FALSE) may still pose side effects, such as ensuring that all drawing operations are flushed to the X server before rendering a non-double buffered widget, which may translate into flickering of the parent GdkWindow before the WebKitWebView itself is rendered. Enabling back double buffering solves this as all contents are first composited together before getting to the front buffer, but effectively acts as 3rd buffer. This is sort of unavoidable unless GTK+ gains a "let me take ownership of the backing buffer for this widget", which currently lacks. * webkit/webkitwebview.cpp: (webkit_web_view_init): Remove call to gtk_widget_set_double_buffered(..., FALSE) Modified Paths releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/webkit/webkitwebview.cpp Diff Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog (114527 => 114528) --- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog 2012-04-18 17:23:03 UTC (rev 114527) +++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog 2012-04-18 17:23:15 UTC (rev 114528) @@ -1,3 +1,26 @@ +2012-04-17 Carlos Garnacho + +[GTK] Enable back double buffering on WebKitWebView to fix flickering +https://bugs.webkit.org/show_bug.cgi?id=84149 + +Reviewed by Martin Robinson. + +Despite having WebKitWebView its own backing buffer, calling +gtk_widget_set_double_buffered(...,FALSE) may still pose side +effects, such as ensuring that all drawing operations are +flushed to the X server before rendering a non-double buffered +widget, which may translate into flickering of the parent +GdkWindow before the WebKitWebView itself is rendered. + +Enabling back double buffering solves this as all contents are +first composited together before getting to the front buffer, +but effectively acts as 3rd buffer. This is sort of unavoidable +unless GTK+ gains a "let me take ownership of the backing buffer +for this widget", which currently lacks. + +* webkit/webkitwebview.cpp: +(webkit_web_view_init): Remove call to gtk_widget_set_double_buffered(..., FALSE) + 2012-04-05 Martin Robinson [GTK] Scrolling some iframes that are partially out of the viewport leads to repaint errors Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/webkit/webkitwebview.cpp (114527 => 114528) --- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/webkit/webkitwebview.cpp 2012-04-18 17:23:03 UTC (rev 114527) +++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/webkit/webkitwebview.cpp 2012-04-18 17:23:15 UTC (rev 114528) @@ -3460,7 +3460,6 @@ priv->viewportAttributes->priv->webView = webView; gtk_widget_set_can_focus(GTK_WIDGET(webView), TRUE); -gtk_widget_set_double_buffered(GTK_WIDGET(webView), FALSE); priv->mainFrame = WEBKIT_WEB_FRAME(webkit_web_frame_new(webView)); priv->lastPopupXPosition = priv->lastPopupYPosition = -1; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114527] releases/WebKitGTK/webkit-1.8
Title: [114527] releases/WebKitGTK/webkit-1.8 Revision 114527 Author x...@webkit.org Date 2012-04-18 10:23:03 -0700 (Wed, 18 Apr 2012) Log Message [soup] Crash while loading http://www.jusco.cn https://bugs.webkit.org/show_bug.cgi?id=68238 Patch by Martin Robinson on 2012-04-09 Reviewed by Philippe Normand. .: * configure.ac: Bumped the libsoup dependency to 2.37.90. Source/WebCore: Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html When running synchronous XMLHttpRequests, push a new inner thread default context, so that other sources from timers and network activity do not run. This will make synchronous requests truly synchronous with the rest of WebCore. * platform/network/soup/ResourceHandleSoup.cpp: (WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline. (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default context to prevent other sources from running. (WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context. (WebCore::closeCallback): If the client is synchronous call didFinishLoading now. (WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous. (WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session respects the inner thread context. LayoutTests: * http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added. * http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added. Modified Paths releases/WebKitGTK/webkit-1.8/ChangeLog releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp Added Paths releases/WebKitGTK/webkit-1.8/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt releases/WebKitGTK/webkit-1.8/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html Diff Modified: releases/WebKitGTK/webkit-1.8/ChangeLog (114526 => 114527) --- releases/WebKitGTK/webkit-1.8/ChangeLog 2012-04-18 17:22:44 UTC (rev 114526) +++ releases/WebKitGTK/webkit-1.8/ChangeLog 2012-04-18 17:23:03 UTC (rev 114527) @@ -1,3 +1,12 @@ +2012-04-09 Martin Robinson + +[soup] Crash while loading http://www.jusco.cn +https://bugs.webkit.org/show_bug.cgi?id=68238 + +Reviewed by Philippe Normand. + +* configure.ac: Bumped the libsoup dependency to 2.37.90. + 2012-03-28 Xan Lopez [GTK] Respect NOCONFIGURE option in autogen.sh Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (114526 => 114527) --- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-04-18 17:22:44 UTC (rev 114526) +++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-04-18 17:23:03 UTC (rev 114527) @@ -1,5 +1,15 @@ 2012-04-09 Martin Robinson +[soup] Crash while loading http://www.jusco.cn +https://bugs.webkit.org/show_bug.cgi?id=68238 + +Reviewed by Philippe Normand. + +* http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added. +* http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added. + +2012-04-09 Martin Robinson + [GTK] Toggle buttons do not size appropriately in some themes https://bugs.webkit.org/show_bug.cgi?id=82833 Added: releases/WebKitGTK/webkit-1.8/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt (0 => 114527) --- releases/WebKitGTK/webkit-1.8/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt (rev 0) +++ releases/WebKitGTK/webkit-1.8/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt 2012-04-18 17:23:03 UTC (rev 114527) @@ -0,0 +1,4 @@ +Test for: bug 68238: [soup] Crash while loading http://www.jusco.cn This test verifies that WebCore timers do not fire during synchronous XMLHttpRequests. + +PASS + Added: releases/WebKitGTK/webkit-1.8/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html (0 => 114527) --- releases/WebKitGTK/webkit-1.8/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html (rev 0) +++ releases/WebKitGTK/webkit-1.8/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html 2012-04-18 17:23:03 UTC (rev 114527) @@ -0,0 +1,32 @@ + + + Test for: : [soup] Crash while loading http://www.jusco.cn This test verifies that WebCore timers do not fire during synchronous XMLHttpRequests. + + + +if (window.layoutTestController) +layoutTestController.dumpAsText(); + +function log(message) +{ +document.getElementById("log").innerHTML += message + "\n"; +} + +var timerEverFired = false; +var intervalId = setInterval(function() { +timerEverFired = true; +}, 10); + +try { +var req = new XMLHttpRequest(); +
[webkit-changes] [114526] releases/WebKitGTK/webkit-1.8
Title: [114526] releases/WebKitGTK/webkit-1.8 Revision 114526 Author x...@webkit.org Date 2012-04-18 10:22:44 -0700 (Wed, 18 Apr 2012) Log Message [GTK] Toggle buttons do not size appropriately in some themes https://bugs.webkit.org/show_bug.cgi?id=82833 Patch by Martin Robinson on 2012-04-09 Reviewed by Gustavo Noronha Silva. Source/WebCore: Test: platform/gtk/fast/forms/large-toggle-elements.html Instead of drawing a toggle button across the entire rectangle of the WebCore control, draw a default-sized one cenetered in the rectangle. * platform/gtk/RenderThemeGtk3.cpp: (WebCore::paintToggle): Draw default-sized toggles. LayoutTests: Add a test for this issue. * platform/gtk/fast/forms/large-toggle-elements-expected.png: Added. * platform/gtk/fast/forms/large-toggle-elements-expected.txt: Added. * platform/gtk/fast/forms/large-toggle-elements.html: Added. Modified Paths releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/gtk/RenderThemeGtk3.cpp Added Paths releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/fast/forms/large-toggle-elements-expected.png releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/fast/forms/large-toggle-elements-expected.txt releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/fast/forms/large-toggle-elements.html Diff Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (114525 => 114526) --- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-04-18 17:22:25 UTC (rev 114525) +++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-04-18 17:22:44 UTC (rev 114526) @@ -1,3 +1,16 @@ +2012-04-09 Martin Robinson + +[GTK] Toggle buttons do not size appropriately in some themes +https://bugs.webkit.org/show_bug.cgi?id=82833 + +Reviewed by Gustavo Noronha Silva. + +Add a test for this issue. + +* platform/gtk/fast/forms/large-toggle-elements-expected.png: Added. +* platform/gtk/fast/forms/large-toggle-elements-expected.txt: Added. +* platform/gtk/fast/forms/large-toggle-elements.html: Added. + 2012-04-05 Martin Robinson [GTK] Scrolling some iframes that are partially out of the viewport leads to repaint errors Added: releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/fast/forms/large-toggle-elements-expected.png (0 => 114526) --- releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/fast/forms/large-toggle-elements-expected.png (rev 0) +++ releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/fast/forms/large-toggle-elements-expected.png 2012-04-18 17:22:44 UTC (rev 114526) @@ -0,0 +1,27 @@ +\x89PNG + + +IHDR X ' )tEXtchecksum 0d12092179a4c917dca2dd7a2ef75fdc\xDBgM\x8E bKGD \xFF \xFF \xFF\xA0\xBD\xA7\x93 IDATx\x9C\xED\xDDw\x94\x95\xF5\x9D\xF8\xF1g \xBAi\x86j\x82mV@\\xC1\x82\xBBFDE\xC5\xD8"ģ\xBB\xEA\x89\xEDxւI־\x8A5 +\xB3\xB1W"jL\xC0\x82XPbV\x8F\xD2눀F@\xDA\xC0\xDC\xDF\xF7\xB7\xF7\xDC\xDC6\x97\xE1\xA8y\xBD\xFE\xF0\xDCyx\xCA\xF7)\xF7\x99\xF7̽w\xACH\xA5R q\xEC\xEC |\xD7, \x80` \x98\xC0 &\xB0 \x82 , \x80` \x98\xC0 &\xB0 \x825\xAA\xDFb˗/\xAF\xA9\xA9iٲ宻\xEE;\xA0o\xA0\x90\x9D\xFD\xE2\x8B/֭[רQ\xA3v\xED\xDA\x8EmG +م\xEF\xC0q(ӗ_~\xF9\xF5\xD7_7lذ}\xFB\xF6;{,\xF5\xF4\x8D:Yߐ{Β%K\x92$iݺu\xB3f\xCDv\xE20 +*6\xB6U\xABV\xAD_\xBF\xBEiӦ\xBB\xEF\xBE\xFBNZ);\xF2\xCC~\x93O_\x9D\xBE\xB7\x944EkҤI\xB3g\xCF.\xF8Oܸq\xE3رc\x87z뭷\xE6\xFC\xEB\x8B/\xBE8o1c\xC6Թ\xED\xF2\xE7ܹf͚Ulg\xCB7\xFE\xFC\xDBn\xBB\xED\xCD7\xDF\\xB0`A\xDC\xD0v\xA8\x90]\xF8\x872-Z\xB4\xE8\xF6\xDBo\x9F2e\xCAg\x9F}\xB6\xB3\xC7RO\xDB~\xB2>\xFE\xF8㧞zjٲeM\x9B6\xEDҥ˰a\xC3:v\xECX\xBFU\x85< +\xB7\xD6\xF4\xE9\xD3+++\xFF\xF9\x9F\xFF9\xF3xΜ9\xE7\x9Cs\xCE=\xF7\xDCs\xD6Yg\xED\xB0a\x94\xE9\xCD7\xDF,8\xB6\xB9s\xE7\xFE\xC7\xFCGUU\xD5\xD3O?\x9D\xB3\xC8\xBE gόyf\x8B\xA2)s\xCC]\xFB\xD0C͙3g\xF3\xE6\xCD?\xFC\xE1O=\xF5\xD4L\xF8\xE0\x83N8\xE1w\xBF\xFBݶ\xAC\xC4\xD30\xE7\xE4F\x9D\xEB\x93N:iٲe9\x8Fw\xDF}\xF7\xDF\xFC\xE67!\xEBWll?\xF9\xC9O\x8E?\xFE\xF8\xFC\xE9\xF97\xE1\xED\xFA4\xC9>\x9Eٶ\xF6\xBB-v\xFA\xE9\xCB\xF3?\xFC\xF0G?\xFA\xD1\xECٳ\xAB\xAB\xAB\xAF\xBC\xF2ʎ;\xAE\\xB92g\x9Ee\xDERF\x8F}衇~\xF1\xC5+V\xAC\xE8߿\xFF\xE8ѣ\xD3\xD3{\xF6\xEC9}\xFA\xF4+V<\xFF\xFC\xF3͚5\x9B0aB\xE9\xF9{\xF7\xEE\xFD\xFA믯\\xB9\xF2\xD5W_mݺ\xF5w\xDCQz:9\x8A\xBE\xABS\xA7N\x83\xEEׯ_\xEF7nܺu\xEB\xBE}\xFBz衣F\x8Djذa\x89b\xFB\xF5\xAF\xFD\xE1\x87\x96\xD3v\xE5\xCFY\x8E'\x9F|r\xFC\xF8\xF1QK\xD5om۾li7n\\xBF~\xFD\xF6C\xB1\xF5\x97\xBF\xDDo\xAC\xEDwR\xBEc\xD4M7\xDD4f̘\xC3?\xBC\xAA\xAA\xEA\x80\xB8\xE2\x8A+\x9A4i\xB2\xE69c\x8Eڅ5k֬Y\xB3&\xFDrL\xF6\xE3$I\xD2?\xDF\xD7\xCF\xF6~6m\xD5\xD8rn\xC2\xE1O\x93\xEC\x9D\xCD9\x86;\xD1N9}\x993Ǽe˖]t\xD1^{\xEDծ]\xBBk\xAE\xB9f\xE9ҥ\xCF>\xFBlz\xE6m\xF9\xE6XSS\xF3\xDB\xDF\xFE\xF6\xCC3\xCF\xFC\xDE\xF7\xBEWUUu\xEE\xB9\xE7\xFE\xF6\xB7\xBFݴiS\x92$g\x9DuV\xFF\xFE\xFD\xAB\xAA\xAA\x86r\xDCq\xC7\xFD\xE2\xBF(=\xFF\x8F\xFC\xE3
[webkit-changes] [114524] releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore
Title: [114524] releases/WebKitGTK/webkit-1.8/Source/_javascript_Core Revision 114524 Author x...@webkit.org Date 2012-04-18 10:17:24 -0700 (Wed, 18 Apr 2012) Log Message SIGILL in _javascript_Core on a Geode processor https://bugs.webkit.org/show_bug.cgi?id=82496 Reviewed by Gavin Barraclough. Don't attempt to use the DFG when SSE2 is not available. * dfg/DFGCapabilities.cpp: (JSC::DFG::canCompileOpcodes): Modified Paths releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/dfg/DFGCapabilities.cpp Diff Modified: releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog (114523 => 114524) --- releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog 2012-04-18 17:16:57 UTC (rev 114523) +++ releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog 2012-04-18 17:17:24 UTC (rev 114524) @@ -1,3 +1,15 @@ +2012-04-05 Oliver Hunt + +SIGILL in _javascript_Core on a Geode processor +https://bugs.webkit.org/show_bug.cgi?id=82496 + +Reviewed by Gavin Barraclough. + +Don't attempt to use the DFG when SSE2 is not available. + +* dfg/DFGCapabilities.cpp: +(JSC::DFG::canCompileOpcodes): + 2012-03-23 Gavin Barraclough REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN Modified: releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/dfg/DFGCapabilities.cpp (114523 => 114524) --- releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/dfg/DFGCapabilities.cpp 2012-04-18 17:16:57 UTC (rev 114523) +++ releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/dfg/DFGCapabilities.cpp 2012-04-18 17:17:24 UTC (rev 114524) @@ -61,6 +61,8 @@ bool canCompileOpcodes(CodeBlock* codeBlock) { +if (!MacroAssembler::supportsFloatingPoint()) +return false; return canHandleOpcodes(codeBlock); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114522] releases/WebKitGTK/webkit-1.8
Title: [114522] releases/WebKitGTK/webkit-1.8 Revision 114522 Author x...@webkit.org Date 2012-04-18 10:15:20 -0700 (Wed, 18 Apr 2012) Log Message [GTK] Respect NOCONFIGURE option in autogen.sh https://bugs.webkit.org/show_bug.cgi?id=82447 Reviewed by Philippe Normand. Make autogen.sh follow the new build-api for GNOME, see http://people.gnome.org/~walters/docs/build-api.txt * autogen.sh: respect the NOCONFIGURE environment flag, per the new GNOME build-api. Modified Paths releases/WebKitGTK/webkit-1.8/ChangeLog releases/WebKitGTK/webkit-1.8/autogen.sh Diff Modified: releases/WebKitGTK/webkit-1.8/ChangeLog (114521 => 114522) --- releases/WebKitGTK/webkit-1.8/ChangeLog 2012-04-18 17:07:23 UTC (rev 114521) +++ releases/WebKitGTK/webkit-1.8/ChangeLog 2012-04-18 17:15:20 UTC (rev 114522) @@ -1,3 +1,16 @@ +2012-03-28 Xan Lopez + +[GTK] Respect NOCONFIGURE option in autogen.sh +https://bugs.webkit.org/show_bug.cgi?id=82447 + +Reviewed by Philippe Normand. + +Make autogen.sh follow the new build-api for GNOME, see +http://people.gnome.org/~walters/docs/build-api.txt + +* autogen.sh: respect the NOCONFIGURE environment flag, per the +new GNOME build-api. + 2012-03-27 Martin Robinson Update the NEWS and version for the impending 1.8.0 release. Modified: releases/WebKitGTK/webkit-1.8/autogen.sh (114521 => 114522) --- releases/WebKitGTK/webkit-1.8/autogen.sh 2012-04-18 17:07:23 UTC (rev 114521) +++ releases/WebKitGTK/webkit-1.8/autogen.sh 2012-04-18 17:15:20 UTC (rev 114522) @@ -20,4 +20,7 @@ cd $ORIGDIR || exit 1 -$srcdir/configure $AUTOGEN_CONFIGURE_ARGS "$@" || exit $? +if test -z "$NOCONFIGURE"; then +$srcdir/configure $AUTOGEN_CONFIGURE_ARGS "$@" || exit $? +fi + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [112393] trunk
Title: [112393] trunk Revision 112393 Author x...@webkit.org Date 2012-03-28 07:19:14 -0700 (Wed, 28 Mar 2012) Log Message [GTK] Respect NOCONFIGURE option in autogen.sh https://bugs.webkit.org/show_bug.cgi?id=82447 Reviewed by Philippe Normand. Make autogen.sh follow the new build-api for GNOME, see http://people.gnome.org/~walters/docs/build-api.txt * autogen.sh: respect the NOCONFIGURE environment flag, per the new GNOME build-api. Modified Paths trunk/ChangeLog trunk/autogen.sh Diff Modified: trunk/ChangeLog (112392 => 112393) --- trunk/ChangeLog 2012-03-28 14:11:49 UTC (rev 112392) +++ trunk/ChangeLog 2012-03-28 14:19:14 UTC (rev 112393) @@ -1,3 +1,16 @@ +2012-03-28 Xan Lopez + +[GTK] Respect NOCONFIGURE option in autogen.sh +https://bugs.webkit.org/show_bug.cgi?id=82447 + +Reviewed by Philippe Normand. + +Make autogen.sh follow the new build-api for GNOME, see +http://people.gnome.org/~walters/docs/build-api.txt + +* autogen.sh: respect the NOCONFIGURE environment flag, per the +new GNOME build-api. + 2012-03-27 Ryosuke Niwa Perf-o-matic build fix. Modified: trunk/autogen.sh (112392 => 112393) --- trunk/autogen.sh 2012-03-28 14:11:49 UTC (rev 112392) +++ trunk/autogen.sh 2012-03-28 14:19:14 UTC (rev 112393) @@ -20,4 +20,7 @@ cd $ORIGDIR || exit 1 -$srcdir/configure $AUTOGEN_CONFIGURE_ARGS "$@" || exit $? +if test -z "$NOCONFIGURE"; then +$srcdir/configure $AUTOGEN_CONFIGURE_ARGS "$@" || exit $? +fi + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101954] trunk/Tools
Title: [101954] trunk/Tools Revision 101954 Author x...@webkit.org Date 2011-12-04 04:42:55 -0800 (Sun, 04 Dec 2011) Log Message 2011-12-04 Xan Lopez Fix compiler warning in LayoutTestController Reviewed by Philippe Normand. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): fix warning. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/LayoutTestController.cpp Diff Modified: trunk/Tools/ChangeLog (101953 => 101954) --- trunk/Tools/ChangeLog 2011-12-04 11:56:22 UTC (rev 101953) +++ trunk/Tools/ChangeLog 2011-12-04 12:42:55 UTC (rev 101954) @@ -1,3 +1,12 @@ +2011-12-04 Xan Lopez + +Fix compiler warning in LayoutTestController + +Reviewed by Philippe Normand. + +* DumpRenderTree/LayoutTestController.cpp: +(LayoutTestController::LayoutTestController): fix warning. + 2011-12-04 Alexandre Mazari Add missing methods used by fast/notifications tests to LayoutTestController Modified: trunk/Tools/DumpRenderTree/LayoutTestController.cpp (101953 => 101954) --- trunk/Tools/DumpRenderTree/LayoutTestController.cpp 2011-12-04 11:56:22 UTC (rev 101953) +++ trunk/Tools/DumpRenderTree/LayoutTestController.cpp 2011-12-04 12:42:55 UTC (rev 101954) @@ -90,9 +90,9 @@ , m_deferMainResourceDataLoad(true) , m_shouldPaintBrokenImage(true) , m_shouldStayOnPageAfterHandlingBeforeUnload(false) +, m_areDesktopNotificationPermissionRequestsIgnored(false) , m_testPathOrURL(testPathOrURL) , m_expectedPixelHash(expectedPixelHash) -, m_areDesktopNotificationPermissionRequestsIgnored(false) { } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96093] trunk/Source/WebCore
Title: [96093] trunk/Source/WebCore Revision 96093 Author x...@webkit.org Date 2011-09-27 03:28:00 -0700 (Tue, 27 Sep 2011) Log Message [GTK] Add compatibility methods for DOM bindings https://bugs.webkit.org/show_bug.cgi?id=68884 Reviewed by Philippe Normand. Add compatibility methods for our DOM bindings. * bindings/gobject/WebKitDOMCustom.cpp: (webkit_dom_blob_slice): alias to the new method name. (webkit_dom_html_form_element_dispatch_form_change): this was removed from WebCore, so just print a warning about it. (webkit_dom_html_form_element_dispatch_form_input): ditto. * bindings/gobject/WebKitDOMCustom.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h Diff Modified: trunk/Source/WebCore/ChangeLog (96092 => 96093) --- trunk/Source/WebCore/ChangeLog 2011-09-27 10:22:19 UTC (rev 96092) +++ trunk/Source/WebCore/ChangeLog 2011-09-27 10:28:00 UTC (rev 96093) @@ -1,3 +1,19 @@ +2011-09-27 Xan Lopez + +[GTK] Add compatibility methods for DOM bindings +https://bugs.webkit.org/show_bug.cgi?id=68884 + +Reviewed by Philippe Normand. + +Add compatibility methods for our DOM bindings. + +* bindings/gobject/WebKitDOMCustom.cpp: +(webkit_dom_blob_slice): alias to the new method name. +(webkit_dom_html_form_element_dispatch_form_change): this was +removed from WebCore, so just print a warning about it. +(webkit_dom_html_form_element_dispatch_form_input): ditto. +* bindings/gobject/WebKitDOMCustom.h: + 2011-09-27 Ryosuke Niwa Encapsulate m_firstNodeInserted and m_lastLeafInserted in node insertion logic Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp (96092 => 96093) --- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp 2011-09-27 10:22:19 UTC (rev 96092) +++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp 2011-09-27 10:28:00 UTC (rev 96093) @@ -19,6 +19,8 @@ #include "config.h" #include "WebKitDOMCustom.h" +#include "WebKitDOMBlob.h" +#include "WebKitDOMHTMLFormElement.h" #include "WebKitDOMHTMLInputElement.h" #include "WebKitDOMHTMLInputElementPrivate.h" #include "WebKitDOMHTMLTextAreaElement.h" @@ -40,3 +42,23 @@ return core(input)->lastChangeWasUserEdit(); } +/* Compatibility */ +WebKitDOMBlob* +webkit_dom_blob_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type) +{ +return webkit_dom_blob_webkit_slice(self, start, end, content_type); +} + +void +webkit_dom_html_form_element_dispatch_form_change(WebKitDOMHTMLFormElement* self) +{ +g_warning("The onformchange functionality has been removed from the DOM spec, this function does nothing."); +} + +void +webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement* self) +{ +g_warning("The onforminput functionality has been removed from the DOM spec, this function does nothing."); +} + + Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h (96092 => 96093) --- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h 2011-09-27 10:22:19 UTC (rev 96092) +++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h 2011-09-27 10:28:00 UTC (rev 96093) @@ -28,6 +28,11 @@ WEBKIT_API gboolean webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement*); WEBKIT_API gboolean webkit_dom_html_input_element_is_edited(WebKitDOMHTMLInputElement*); +/* Compatibility */ +WEBKIT_API WebKitDOMBlob* webkit_dom_blob_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type); +WEBKIT_API void webkit_dom_html_form_element_dispatch_form_change(WebKitDOMHTMLFormElement* self); +WEBKIT_API void webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement* self); + G_END_DECLS #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96009] trunk/Source/WebCore
Title: [96009] trunk/Source/WebCore Revision 96009 Author x...@webkit.org Date 2011-09-26 15:28:31 -0700 (Mon, 26 Sep 2011) Log Message [GTK] Do not ignore 'Replaceable' attributes in the DOM bindings https://bugs.webkit.org/show_bug.cgi?id=68837 Reviewed by Martin Robinson. * bindings/scripts/CodeGeneratorGObject.pm: add getters (but not setters) for 'Replaceable' attributes. Punt for the future actually making them settable, since it seems non trivial. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm Diff Modified: trunk/Source/WebCore/ChangeLog (96008 => 96009) --- trunk/Source/WebCore/ChangeLog 2011-09-26 22:27:19 UTC (rev 96008) +++ trunk/Source/WebCore/ChangeLog 2011-09-26 22:28:31 UTC (rev 96009) @@ -1,3 +1,14 @@ +2011-09-26 Xan Lopez + +[GTK] Do not ignore 'Replaceable' attributes in the DOM bindings +https://bugs.webkit.org/show_bug.cgi?id=68837 + +Reviewed by Martin Robinson. + +* bindings/scripts/CodeGeneratorGObject.pm: add getters (but not +setters) for 'Replaceable' attributes. Punt for the future +actually making them settable, since it seems non trivial. + 2011-09-26 Ryosuke Niwa Leopard build fix. Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (96008 => 96009) --- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2011-09-26 22:27:19 UTC (rev 96008) +++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2011-09-26 22:28:31 UTC (rev 96009) @@ -155,11 +155,10 @@ my $attribute = shift; if ($attribute->signature->extendedAttributes->{"CustomGetter"} || -$attribute->signature->extendedAttributes->{"CustomSetter"} || -$attribute->signature->extendedAttributes->{"Replaceable"}) { +$attribute->signature->extendedAttributes->{"CustomSetter"}) { return 1; } - + my $propType = $attribute->signature->type; if ($propType =~ /Constructor$/) { return 1; @@ -307,7 +306,10 @@ $gtype eq "uint64" || $gtype eq "ulong" || $gtype eq "long" || $gtype eq "uint" || $gtype eq "ushort" || $gtype eq "uchar" || $gtype eq "char" || $gtype eq "string"); -if ($writeable && $hasGtypeSignature) { +# FIXME: We are not generating setters for 'Replaceable' +# attributes now, but we should somehow. +my $replaceable = $property->signature->extendedAttributes->{"Replaceable"}; +if ($writeable && $hasGtypeSignature && !$replaceable) { push(@result, $property); } } @@ -1039,8 +1041,11 @@ $function->signature($attribute->signature); $function->raisesExceptions($attribute->getterExceptions); $object->GenerateFunction($interfaceName, $function, "get_"); - -if ($attribute->type =~ /^readonly/) { + +# FIXME: We are not generating setters for 'Replaceable' +# attributes now, but we should somehow. +if ($attribute->type =~ /^readonly/ || +$attribute->signature->extendedAttributes->{"Replaceable"}) { next TOP; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95809] trunk/LayoutTests
Title: [95809] trunk/LayoutTests Revision 95809 Author x...@webkit.org Date 2011-09-23 09:10:58 -0700 (Fri, 23 Sep 2011) Log Message 2011-09-23 Xan Lopez [GTK] Skip crashing test fast/workers/storage/interrupt-database.html https://bugs.webkit.org/show_bug.cgi?id=68700 Unreviewed. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (95808 => 95809) --- trunk/LayoutTests/ChangeLog 2011-09-23 16:09:36 UTC (rev 95808) +++ trunk/LayoutTests/ChangeLog 2011-09-23 16:10:58 UTC (rev 95809) @@ -1,3 +1,12 @@ +2011-09-23 Xan Lopez + +[GTK] Skip crashing test fast/workers/storage/interrupt-database.html +https://bugs.webkit.org/show_bug.cgi?id=68700 + +Unreviewed. + +* platform/gtk/Skipped: + 2011-09-23 Vsevolod Vlasov Web Inspector: InspectorStyleSheet should use stylesheet's original url, not final one. Modified: trunk/LayoutTests/platform/gtk/Skipped (95808 => 95809) --- trunk/LayoutTests/platform/gtk/Skipped 2011-09-23 16:09:36 UTC (rev 95808) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-09-23 16:10:58 UTC (rev 95809) @@ -259,6 +259,9 @@ # https://bugs.webkit.org/show_bug.cgi?id=68686 editing/pasteboard/drag-drop-input-in-svg.svg +# https://bugs.webkit.org/show_bug.cgi?id=68700 +fast/workers/storage/interrupt-database.html + ### # EXPECTED FAILURES ### ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95796] trunk/LayoutTests
Title: [95796] trunk/LayoutTests Revision 95796 Author x...@webkit.org Date 2011-09-23 06:04:46 -0700 (Fri, 23 Sep 2011) Log Message 2011-09-23 Xan Lopez [GTK] Rebaseline following r95745, r95725 Unreviewed rebaseline. * platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (95795 => 95796) --- trunk/LayoutTests/ChangeLog 2011-09-23 12:43:31 UTC (rev 95795) +++ trunk/LayoutTests/ChangeLog 2011-09-23 13:04:46 UTC (rev 95796) @@ -1,3 +1,11 @@ +2011-09-23 Xan Lopez + +[GTK] Rebaseline following r95745, r95725 + +Unreviewed rebaseline. + +* platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt: + 2011-09-23 Marcus Bulach [chromium] Rebaseline following r95745, r95725 Modified: trunk/LayoutTests/platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt (95795 => 95796) --- trunk/LayoutTests/platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt 2011-09-23 12:43:31 UTC (rev 95795) +++ trunk/LayoutTests/platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt 2011-09-23 13:04:46 UTC (rev 95796) @@ -12,8 +12,9 @@ RenderBlock {DIV} at (0,0) size 784x19 RenderText {#text} at (0,0) size 21x19 text run at (0,0) width 21: "foo" - RenderText {#text} at (21,0) size 20x19 -text run at (21,0) width 20: "bar" + RenderInline {SPAN} at (0,0) size 24x15 +RenderText {#text} at (21,4) size 24x15 + text run at (21,4) width 24: "bar" RenderBlock {PRE} at (0,32) size 784x15 RenderText {#text} at (0,0) size 24x15 text run at (0,0) width 24: "baz" ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95789] trunk/LayoutTests
Title: [95789] trunk/LayoutTests Revision 95789 Author x...@webkit.org Date 2011-09-23 03:35:28 -0700 (Fri, 23 Sep 2011) Log Message 2011-09-23 Xan Lopez Crash on editing/pasteboard/drag-drop-input-in-svg.svg https://bugs.webkit.org/show_bug.cgi?id=68686 Unreviewed, skip crashing test. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (95788 => 95789) --- trunk/LayoutTests/ChangeLog 2011-09-23 09:19:32 UTC (rev 95788) +++ trunk/LayoutTests/ChangeLog 2011-09-23 10:35:28 UTC (rev 95789) @@ -1,3 +1,12 @@ +2011-09-23 Xan Lopez + +Crash on editing/pasteboard/drag-drop-input-in-svg.svg +https://bugs.webkit.org/show_bug.cgi?id=68686 + +Unreviewed, skip crashing test. + +* platform/gtk/Skipped: + 2011-09-23 Balazs Kelemen plugins/mouse-click-iframe-to-plugin.html should not use flash plugin Modified: trunk/LayoutTests/platform/gtk/Skipped (95788 => 95789) --- trunk/LayoutTests/platform/gtk/Skipped 2011-09-23 09:19:32 UTC (rev 95788) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-09-23 10:35:28 UTC (rev 95789) @@ -256,6 +256,9 @@ # https://bugs.webkit.org/show_bug.cgi?id=65702 editing/undo/replace-text-in-node-preserving-markers-crash.html +# https://bugs.webkit.org/show_bug.cgi?id=68686 +editing/pasteboard/drag-drop-input-in-svg.svg + ### # EXPECTED FAILURES ### ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94285] trunk/Source/WebKit2
Title: [94285] trunk/Source/WebKit2 Revision 94285 Author x...@webkit.org Date 2011-09-01 04:18:43 -0700 (Thu, 01 Sep 2011) Log Message 2011-09-01 Xan Lopez [GTK] Add XRender lib dependencies explicitly Reviewed by Philippe Normand. This is needed when using the GNU/Gold linker, since we use XRender directly. * GNUmakefile.am: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am Diff Modified: trunk/Source/WebKit2/ChangeLog (94284 => 94285) --- trunk/Source/WebKit2/ChangeLog 2011-09-01 10:24:09 UTC (rev 94284) +++ trunk/Source/WebKit2/ChangeLog 2011-09-01 11:18:43 UTC (rev 94285) @@ -1,3 +1,14 @@ +2011-09-01 Xan Lopez + +[GTK] Add XRender lib dependencies explicitly + +Reviewed by Philippe Normand. + +This is needed when using the GNU/Gold linker, since we use +XRender directly. + +* GNUmakefile.am: + 2011-08-31 Anders Carlsson Jagged text shown in find-in-page highlight Modified: trunk/Source/WebKit2/GNUmakefile.am (94284 => 94285) --- trunk/Source/WebKit2/GNUmakefile.am 2011-09-01 10:24:09 UTC (rev 94284) +++ trunk/Source/WebKit2/GNUmakefile.am 2011-09-01 11:18:43 UTC (rev 94285) @@ -908,6 +908,7 @@ $(PNG_LIBS) \ $(SQLITE3_LIBS) \ $(UNICODE_LIBS) \ + $(XRENDER_LIBS) \ $(XT_LIBS) # WebKit2 specific variables ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92854] trunk/Source/WebKit/gtk/po
Title: [92854] trunk/Source/WebKit/gtk/po Revision 92854 Author x...@webkit.org Date 2011-08-11 08:57:00 -0700 (Thu, 11 Aug 2011) Log Message [GTK] create pot files in builddir, not (read only) srcdir https://bugs.webkit.org/show_bug.cgi?id=66059 Reviewed by Gustavo Noronha Silva. * GNUmakefile.am: write and read pot files from the build dir. Modified Paths trunk/Source/WebKit/gtk/po/ChangeLog trunk/Source/WebKit/gtk/po/GNUmakefile.am Diff Modified: trunk/Source/WebKit/gtk/po/ChangeLog (92853 => 92854) --- trunk/Source/WebKit/gtk/po/ChangeLog 2011-08-11 15:53:27 UTC (rev 92853) +++ trunk/Source/WebKit/gtk/po/ChangeLog 2011-08-11 15:57:00 UTC (rev 92854) @@ -1,3 +1,12 @@ +2011-08-11 Xan Lopez + +[GTK] create pot files in builddir, not (read only) srcdir +https://bugs.webkit.org/show_bug.cgi?id=66059 + +Reviewed by Gustavo Noronha Silva. + +* GNUmakefile.am: write and read pot files from the build dir. + 2011-07-11 Yuri Chornoivan Ukrainian translation for WebKitGTK+ Modified: trunk/Source/WebKit/gtk/po/GNUmakefile.am (92853 => 92854) --- trunk/Source/WebKit/gtk/po/GNUmakefile.am 2011-08-11 15:53:27 UTC (rev 92853) +++ trunk/Source/WebKit/gtk/po/GNUmakefile.am 2011-08-11 15:57:00 UTC (rev 92854) @@ -48,10 +48,10 @@ # if updating the $(CATALOGS) would always touch them; however, the rule for # $(POFILES) has been designed to not touch files that don't need to be # changed. -stamp-po: $(srcdir)/Source/WebKit/gtk/po/$(DOMAIN).pot $(MOFILES) - test ! -f $(srcdir)/Source/WebKit/gtk/po/$(DOMAIN).pot || \ +stamp-po: $(top_builddir)/Source/WebKit/gtk/po/$(DOMAIN).pot $(MOFILES) + test ! -f $(top_builddir)/Source/WebKit/gtk/po/$(DOMAIN).pot || \ test -z "$(MOFILES)" || $(MAKE) $(MOFILES) - @test ! -f $(srcdir)/Source/WebKit/gtk/po/$(DOMAIN).pot || { \ + @test ! -f $(top_builddir)/Source/WebKit/gtk/po/$(DOMAIN).pot || { \ echo "touch stamp-po" && \ echo timestamp > stamp-poT && \ mv stamp-poT stamp-po; \ @@ -73,7 +73,7 @@ --files-from=$(srcdir)/Source/WebKit/gtk/po/POTFILES \ --copyright-holder='$(COPYRIGHT_HOLDER)' \ --msgid-bugs-address="$$msgid_bugs_address" \ - --keyword=_ --keyword=N_ -o $(srcdir)/Source/WebKit/gtk/po/$(DOMAIN).pot \ + --keyword=_ --keyword=N_ -o $(top_builddir)/Source/WebKit/gtk/po/$(DOMAIN).pot \ ;; \ *) \ $(XGETTEXT) --default-domain=$(DOMAIN) --directory=$(srcdir) \ @@ -83,19 +83,19 @@ --package-name="$${package_gnu}@PACKAGE@" \ --package-version='@VERSION@' \ --msgid-bugs-address="$$msgid_bugs_address" \ - --keyword=_ --keyword=N_ -o $(srcdir)/Source/WebKit/gtk/po/$(DOMAIN).pot \ + --keyword=_ --keyword=N_ -o $(top_builddir)/Source/WebKit/gtk/po/$(DOMAIN).pot \ ;; \ esac # This rule has no dependencies: we don't need to update $(DOMAIN).pot at # every "make" invocation, only create it when it is missing. # Only "make $(DOMAIN).pot-update" or "make dist" will force an update. -$(srcdir)/Source/WebKit/gtk/po/$(DOMAIN).pot: +$(top_builddir)/Source/WebKit/gtk/po/$(DOMAIN).pot: $(MAKE) $(DOMAIN).pot-update # This target rebuilds a PO file if $(DOMAIN).pot has changed. # Note that a PO file is not touched if it doesn't need to be changed. -update-po-files: $(srcdir)/Source/WebKit/gtk/po/$(DOMAIN).pot +update-po-files: $(top_builddir)/Source/WebKit/gtk/po/$(DOMAIN).pot @for pofile in $(POFILES); do \ lang=`echo $$pofile | sed -e 's,.*/,,' -e 's/\.po$$//'`; \ if test -f "$(srcdir)/Source/WebKit/gtk/po/$${lang}.po"; then \ @@ -123,10 +123,12 @@ $(top_builddir)/stamp-po MAINTAINERCLEANFILES += \ - $(MOFILES) + $(MOFILES) \ + $(top_builddir)/Source/WebKit/gtk/po/$(DOMAIN).pot DISTCLEANFILES += \ - $(MOFILES) + $(MOFILES) \ + $(top_builddir)/Source/WebKit/gtk/po/$(DOMAIN).pot po-install-data-local: all $(mkdir_p) $(DESTDIR)$(datadir) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92852] trunk
Title: [92852] trunk Revision 92852 Author x...@webkit.org Date 2011-08-11 08:46:45 -0700 (Thu, 11 Aug 2011) Log Message 2011-08-11 Xan Lopez [GTK] Update NEWS and configure.ac for 1.5.2 release Reviewed by Gustavo Noronha. * configure.ac: update for release. Source/WebKit/gtk: 2011-08-11 Xan Lopez [GTK] Update NEWS and configure.ac for 1.5.2 release Reviewed by Gustavo Noronha. * NEWS: update for release. Modified Paths trunk/ChangeLog trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/NEWS trunk/configure.ac Diff Modified: trunk/ChangeLog (92851 => 92852) --- trunk/ChangeLog 2011-08-11 15:33:25 UTC (rev 92851) +++ trunk/ChangeLog 2011-08-11 15:46:45 UTC (rev 92852) @@ -1,3 +1,11 @@ +2011-08-11 Xan Lopez + +[GTK] Update NEWS and configure.ac for 1.5.2 release + +Reviewed by Gustavo Noronha. + +* configure.ac: update for release. + 2011-08-10 Varun Jain WebViewImpl::selectionRange should return false if there is no selection Modified: trunk/Source/WebKit/gtk/ChangeLog (92851 => 92852) --- trunk/Source/WebKit/gtk/ChangeLog 2011-08-11 15:33:25 UTC (rev 92851) +++ trunk/Source/WebKit/gtk/ChangeLog 2011-08-11 15:46:45 UTC (rev 92852) @@ -1,3 +1,11 @@ +2011-08-11 Xan Lopez + +[GTK] Update NEWS and configure.ac for 1.5.2 release + +Reviewed by Gustavo Noronha. + +* NEWS: update for release. + 2011-08-10 Gustavo Noronha Silva [GTK] wrong annotation for the return value of webkit_web_view_get_hit_test_results() Modified: trunk/Source/WebKit/gtk/NEWS (92851 => 92852) --- trunk/Source/WebKit/gtk/NEWS 2011-08-11 15:33:25 UTC (rev 92851) +++ trunk/Source/WebKit/gtk/NEWS 2011-08-11 15:46:45 UTC (rev 92852) @@ -1,4 +1,19 @@ +WebKitGTK+ 1.5.2 + + +What's new in WebKitGTK+ 1.5.2? + + - Remove G_CONST_RETURN usage througout WebKit, it's deprecated in +glib. + - Add plugin process support in WebKit2. Now (GTK+2) plugins can +work again with a GTK+3 build. + - Add API to set local storage database path. + - Further UA spoofing for Google Calendar, since it assumes +Linux+WebKit means mobile (ugh). + - Lots of bugfixes. + + WebKitGTK+ 1.5.1 Modified: trunk/configure.ac (92851 => 92852) --- trunk/configure.ac 2011-08-11 15:33:25 UTC (rev 92851) +++ trunk/configure.ac 2011-08-11 15:46:45 UTC (rev 92852) @@ -2,7 +2,7 @@ m4_define([webkit_major_version], [1]) m4_define([webkit_minor_version], [5]) -m4_define([webkit_micro_version], [1]) +m4_define([webkit_micro_version], [2]) # This is the version we'll be using as part of our User-Agent string # e.g., AppleWebKit/$(webkit_user_agent_version) ... @@ -35,7 +35,7 @@ dnl # Libtool library version, not to confuse with API version dnl # see http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html -LIBWEBKITGTK_VERSION=8:0:8 +LIBWEBKITGTK_VERSION=9:0:9 AC_SUBST([LIBWEBKITGTK_VERSION]) AM_INIT_AUTOMAKE([foreign subdir-objects tar-ustar]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92848] trunk/Source/WebCore
Title: [92848] trunk/Source/WebCore Revision 92848 Author x...@webkit.org Date 2011-08-11 07:43:59 -0700 (Thu, 11 Aug 2011) Log Message 2011-08-11 Xan Lopez [GTK] Add another missing file to GNUmakefile Reviewed by Gustavo Noronha. * GNUmakefile.list.am: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am Diff Modified: trunk/Source/WebCore/ChangeLog (92847 => 92848) --- trunk/Source/WebCore/ChangeLog 2011-08-11 14:40:29 UTC (rev 92847) +++ trunk/Source/WebCore/ChangeLog 2011-08-11 14:43:59 UTC (rev 92848) @@ -1,5 +1,13 @@ 2011-08-11 Xan Lopez +[GTK] Add another missing file to GNUmakefile + +Reviewed by Gustavo Noronha. + +* GNUmakefile.list.am: + +2011-08-11 Xan Lopez + [GTK] Add missing files to GNUMakefile Reviewed by Gustavo Noronha. Modified: trunk/Source/WebCore/GNUmakefile.list.am (92847 => 92848) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-08-11 14:40:29 UTC (rev 92847) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-08-11 14:43:59 UTC (rev 92848) @@ -2748,6 +2748,7 @@ Source/WebCore/platform/PlatformScreen.h \ Source/WebCore/platform/PlatformWheelEvent.h \ Source/WebCore/platform/PODArena.h \ + Source/WebCore/platform/PODInterval.h \ Source/WebCore/platform/PODIntervalTree.h \ Source/WebCore/platform/PODRedBlackTree.h \ Source/WebCore/platform/PopupMenuClient.h \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92846] trunk/Source/WebCore
Title: [92846] trunk/Source/WebCore Revision 92846 Author x...@webkit.org Date 2011-08-11 07:34:34 -0700 (Thu, 11 Aug 2011) Log Message 2011-08-11 Xan Lopez [GTK] Add missing files to GNUMakefile Reviewed by Gustavo Noronha. * GNUmakefile.am: * GNUmakefile.list.am: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebCore/GNUmakefile.list.am Diff Modified: trunk/Source/WebCore/ChangeLog (92845 => 92846) --- trunk/Source/WebCore/ChangeLog 2011-08-11 14:15:04 UTC (rev 92845) +++ trunk/Source/WebCore/ChangeLog 2011-08-11 14:34:34 UTC (rev 92846) @@ -1,3 +1,12 @@ +2011-08-11 Xan Lopez + +[GTK] Add missing files to GNUMakefile + +Reviewed by Gustavo Noronha. + +* GNUmakefile.am: +* GNUmakefile.list.am: + 2011-08-11 Yuta Kitamura WebSocket: Use PassRefPtr<> in function arguments in WorkerThreadableWebSocketChannel.cpp Modified: trunk/Source/WebCore/GNUmakefile.am (92845 => 92846) --- trunk/Source/WebCore/GNUmakefile.am 2011-08-11 14:15:04 UTC (rev 92845) +++ trunk/Source/WebCore/GNUmakefile.am 2011-08-11 14:34:34 UTC (rev 92846) @@ -855,6 +855,7 @@ $(shell ls $(srcdir)/Source/WebCore/inspector/*.idl) \ $(shell ls $(srcdir)/Source/WebCore/loader/appcache/*.idl) \ $(shell ls $(srcdir)/Source/WebCore/notifications/*.idl) \ + $(shell ls $(srcdir)/Source/WebCore/p2p/*.idl) \ $(shell ls $(srcdir)/Source/WebCore/page/*.idl) \ $(shell ls $(srcdir)/Source/WebCore/plugins/*.idl) \ $(shell ls $(srcdir)/Source/WebCore/storage/*.idl) \ @@ -885,6 +886,7 @@ Source/WebCore/css/CSSPropertyNames.in \ Source/WebCore/css/CSSValueKeywords.in \ Source/WebCore/css/fullscreen.css \ + Source/WebCore/css/fullscreenQuickTime.css \ Source/WebCore/css/html.css \ Source/WebCore/css/make-css-file-arrays.pl \ Source/WebCore/css/makegrammar.pl \ Modified: trunk/Source/WebCore/GNUmakefile.list.am (92845 => 92846) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-08-11 14:15:04 UTC (rev 92845) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-08-11 14:34:34 UTC (rev 92846) @@ -2363,6 +2363,8 @@ Source/WebCore/platform/AsyncFileSystem.cpp \ Source/WebCore/platform/AsyncFileSystem.h \ Source/WebCore/platform/AutodrainedPool.h \ + Source/WebCore/platform/ColorChooser.cpp \ + Source/WebCore/platform/ColorChooser.h \ Source/WebCore/platform/ContentType.cpp \ Source/WebCore/platform/ContentType.h \ Source/WebCore/platform/ContextMenu.h \ @@ -2745,6 +2747,9 @@ Source/WebCore/platform/PlatformMouseEvent.h \ Source/WebCore/platform/PlatformScreen.h \ Source/WebCore/platform/PlatformWheelEvent.h \ + Source/WebCore/platform/PODArena.h \ + Source/WebCore/platform/PODIntervalTree.h \ + Source/WebCore/platform/PODRedBlackTree.h \ Source/WebCore/platform/PopupMenuClient.h \ Source/WebCore/platform/PopupMenu.h \ Source/WebCore/platform/PopupMenuStyle.h \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92077] trunk/Tools
Title: [92077] trunk/Tools Revision 92077 Author x...@webkit.org Date 2011-07-31 00:16:01 -0700 (Sun, 31 Jul 2011) Log Message 2011-07-31 Xan Lopez Group dependencies CFLAGS together. * GNUmakefile.am: ditto. Modified Paths trunk/Tools/ChangeLog trunk/Tools/GNUmakefile.am Diff Modified: trunk/Tools/ChangeLog (92076 => 92077) --- trunk/Tools/ChangeLog 2011-07-31 07:04:53 UTC (rev 92076) +++ trunk/Tools/ChangeLog 2011-07-31 07:16:01 UTC (rev 92077) @@ -1,3 +1,9 @@ +2011-07-31 Xan Lopez + +Group dependencies CFLAGS together. + +* GNUmakefile.am: ditto. + 2011-07-31 Daniel Bates Attempt to fix the GTK build after Modified: trunk/Tools/GNUmakefile.am (92076 => 92077) --- trunk/Tools/GNUmakefile.am 2011-07-31 07:04:53 UTC (rev 92076) +++ trunk/Tools/GNUmakefile.am 2011-07-31 07:16:01 UTC (rev 92077) @@ -103,6 +103,7 @@ $(webcoregtk_cppflags) \ $(_javascript_core_cppflags) \ $(CAIRO_CFLAGS) \ + $(LIBSOUP_CFLAGS) \ -I$(top_builddir)/DerivedSources \ -I$(top_builddir)/DerivedSources/WebCore @@ -112,8 +113,7 @@ libWebCoreInternals_la_CFLAGS = \ -fno-strict-aliasing \ - $(_javascript_core_cflags) \ -$(LIBSOUP_CFLAGS) + $(_javascript_core_cflags) # DumpRenderTree Programs_DumpRenderTree_CPPFLAGS = \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91275] trunk/Source/JavaScriptCore
Title: [91275] trunk/Source/_javascript_Core Revision 91275 Author x...@webkit.org Date 2011-07-19 11:33:49 -0700 (Tue, 19 Jul 2011) Log Message ARMv7 backend broken, lacks 3 parameter rshift32 method https://bugs.webkit.org/show_bug.cgi?id=64571 Reviewed by Zoltan Herczeg. * assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::rshift32): add missing rshift32 method. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (91274 => 91275) --- trunk/Source/_javascript_Core/ChangeLog 2011-07-19 18:33:33 UTC (rev 91274) +++ trunk/Source/_javascript_Core/ChangeLog 2011-07-19 18:33:49 UTC (rev 91275) @@ -1,3 +1,13 @@ +2011-07-19 Xan Lopez + +ARMv7 backend broken, lacks 3 parameter rshift32 method +https://bugs.webkit.org/show_bug.cgi?id=64571 + +Reviewed by Zoltan Herczeg. + +* assembler/MacroAssemblerARMv7.h: +(JSC::MacroAssemblerARMv7::rshift32): add missing rshift32 method. + 2011-07-18 Filip Pizlo DFG JIT does not optimize strict equality as effectively as the old JIT does. Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (91274 => 91275) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2011-07-19 18:33:33 UTC (rev 91274) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2011-07-19 18:33:49 UTC (rev 91275) @@ -296,8 +296,13 @@ void rshift32(TrustedImm32 imm, RegisterID dest) { -m_assembler.asr(dest, dest, imm.m_value & 0x1f); +rshift32(dest, imm, dest); } + +void rshift32(RegisterID src, TrustedImm32 imm, RegisterID dest) +{ +m_assembler.asr(dest, src, imm.m_value & 0x1f); +} void urshift32(RegisterID shift_amount, RegisterID dest) { ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90998] trunk/LayoutTests
Title: [90998] trunk/LayoutTests Revision 90998 Author x...@webkit.org Date 2011-07-14 07:04:34 -0700 (Thu, 14 Jul 2011) Log Message 2011-07-14 Xan Lopez [GTK] Skip one crashing test in GTK+/debug bots. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90997 => 90998) --- trunk/LayoutTests/ChangeLog 2011-07-14 13:56:32 UTC (rev 90997) +++ trunk/LayoutTests/ChangeLog 2011-07-14 14:04:34 UTC (rev 90998) @@ -4,6 +4,12 @@ * platform/gtk/Skipped: +2011-07-14 Xan Lopez + +[GTK] Skip one crashing test in GTK+/debug bots. + +* platform/gtk/Skipped: + 2011-07-14 Csaba Osztrogonác [Qt]svg/animations/svgtransform-animation-1.html asserts intermittently Modified: trunk/LayoutTests/platform/gtk/Skipped (90997 => 90998) --- trunk/LayoutTests/platform/gtk/Skipped 2011-07-14 13:56:32 UTC (rev 90997) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-07-14 14:04:34 UTC (rev 90998) @@ -249,6 +249,9 @@ editing/undo/undo-smart-delete-reversed-selection.html editing/selection/directionality-after-undo-replace.html +# https://bugs.webkit.org/show_bug.cgi?id=64530 +editing/selection/editable-html-element.html + ### # EXPECTED FAILURES ### ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90997] trunk/LayoutTests
Title: [90997] trunk/LayoutTests Revision 90997 Author x...@webkit.org Date 2011-07-14 06:56:32 -0700 (Thu, 14 Jul 2011) Log Message 2011-07-14 Xan Lopez [GTK] Skip one crashing test in GTK+/debug bots. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90996 => 90997) --- trunk/LayoutTests/ChangeLog 2011-07-14 13:36:29 UTC (rev 90996) +++ trunk/LayoutTests/ChangeLog 2011-07-14 13:56:32 UTC (rev 90997) @@ -1,3 +1,9 @@ +2011-07-14 Xan Lopez + +[GTK] Skip one crashing test in GTK+/debug bots. + +* platform/gtk/Skipped: + 2011-07-14 Csaba Osztrogonác [Qt]svg/animations/svgtransform-animation-1.html asserts intermittently Modified: trunk/LayoutTests/platform/gtk/Skipped (90996 => 90997) --- trunk/LayoutTests/platform/gtk/Skipped 2011-07-14 13:36:29 UTC (rev 90996) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-07-14 13:56:32 UTC (rev 90997) @@ -247,6 +247,7 @@ editing/pasteboard/interchange-newline-2.html editing/pasteboard/paste-text-008.html editing/undo/undo-smart-delete-reversed-selection.html +editing/selection/directionality-after-undo-replace.html ### # EXPECTED FAILURES ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90953] trunk
Title: [90953] trunk Revision 90953 Author x...@webkit.org Date 2011-07-13 14:55:27 -0700 (Wed, 13 Jul 2011) Log Message Tools: 2011-07-13 Xan Lopez [GTK] Fix distcheck Reviewed by Martin Robinson. * WebKitTestRunner/GNUmakefile.am: mark built sources as nodist. WebCore: 2011-07-13 Xan Lopez [GTK] Fix distcheck. Reviewed by Martin Robinson. * GNUmakefile.list.am: add missing files. _javascript_Core: 2011-07-13 Xan Lopez [GTK] Fix distcheck Reviewed by Martin Robinson. * GNUmakefile.list.am: add missing files. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/GNUmakefile.am Diff Modified: trunk/Source/_javascript_Core/ChangeLog (90952 => 90953) --- trunk/Source/_javascript_Core/ChangeLog 2011-07-13 21:51:14 UTC (rev 90952) +++ trunk/Source/_javascript_Core/ChangeLog 2011-07-13 21:55:27 UTC (rev 90953) @@ -1,3 +1,11 @@ +2011-07-13 Xan Lopez + +[GTK] Fix distcheck + +Reviewed by Martin Robinson. + +* GNUmakefile.list.am: add missing files. + 2011-07-13 Filip Pizlo DFG JIT does not implement prototype chain or list caching for get_by_id. Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (90952 => 90953) --- trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-07-13 21:51:14 UTC (rev 90952) +++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-07-13 21:55:27 UTC (rev 90953) @@ -219,6 +219,7 @@ Source/_javascript_Core/jit/JITStubCall.h \ Source/_javascript_Core/jit/JITStubs.cpp \ Source/_javascript_Core/jit/JITStubs.h \ + Source/_javascript_Core/jit/JITWriteBarrier.h \ Source/_javascript_Core/jit/JSInterfaceJIT.h \ Source/_javascript_Core/jit/SpecializedThunkJIT.h \ Source/_javascript_Core/jit/ThunkGenerators.cpp \ @@ -263,6 +264,7 @@ Source/_javascript_Core/runtime/ArrayPrototype.cpp \ Source/_javascript_Core/runtime/ArrayPrototype.h \ Source/_javascript_Core/runtime/BatchedTransitionOptimizer.h \ + Source/_javascript_Core/runtime/BigInteger.h \ Source/_javascript_Core/runtime/BooleanConstructor.cpp \ Source/_javascript_Core/runtime/BooleanConstructor.h \ Source/_javascript_Core/runtime/BooleanObject.cpp \ @@ -431,6 +433,7 @@ Source/_javascript_Core/runtime/TimeoutChecker.cpp \ Source/_javascript_Core/runtime/TimeoutChecker.h \ Source/_javascript_Core/runtime/Tracing.h \ + Source/_javascript_Core/runtime/Uint16WithFraction.h \ Source/_javascript_Core/runtime/UString.cpp \ Source/_javascript_Core/runtime/UString.h \ Source/_javascript_Core/runtime/UStringBuilder.h \ Modified: trunk/Source/WebCore/ChangeLog (90952 => 90953) --- trunk/Source/WebCore/ChangeLog 2011-07-13 21:51:14 UTC (rev 90952) +++ trunk/Source/WebCore/ChangeLog 2011-07-13 21:55:27 UTC (rev 90953) @@ -1,3 +1,11 @@ +2011-07-13 Xan Lopez + +[GTK] Fix distcheck. + +Reviewed by Martin Robinson. + +* GNUmakefile.list.am: add missing files. + 2011-07-13 James Robinson [chromium] No implementation defined for WTF::monotonicallyIncreasingTime Modified: trunk/Source/WebCore/GNUmakefile.list.am (90952 => 90953) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-07-13 21:51:14 UTC (rev 90952) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-07-13 21:55:27 UTC (rev 90953) @@ -1002,6 +1002,8 @@ Source/WebCore/css/CSSStyleSheet.h \ Source/WebCore/css/CSSTimingFunctionValue.cpp \ Source/WebCore/css/CSSTimingFunctionValue.h \ + Source/WebCore/css/CSSWrapShapes.cpp \ + Source/WebCore/css/CSSWrapShapes.h \ Source/WebCore/css/CSSUnicodeRangeValue.cpp \ Source/WebCore/css/CSSUnicodeRangeValue.h \ Source/WebCore/css/CSSUnknownRule.h \ @@ -2590,6 +2592,7 @@ Source/WebCore/platform/graphics/UnitBezier.h \ Source/WebCore/platform/graphics/WidthIterator.cpp \ Source/WebCore/platform/graphics/WidthIterator.h \ + Source/WebCore/platform/graphics/WindRule.h \ Source/WebCore/platform/graphics/WOFFFileFormat.cpp \ Source/WebCore/platform/graphics/WOFFFileFormat.h \ Source/WebCore/platform/gtk/KURLGtk.cpp \ @@ -2712,7 +2715,6 @@ Source/WebCore/platform/network/soup/CookieJarSoup.cpp \ Source/WebCore/platform/network/soup/CookieJarSoup.h \ Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp \ - Source/WebCore/platform/network/soup/CredentialStorageSoup.h \ Source/WebCore/platform/network/soup/GOwnPtrSoup.cpp \ Source/WebCore/platform/network/soup/GOwnPtrSoup.h \ Source/WebCore/platform/network/soup/ProxyServerSoup.cpp \ @@ -3794,6 +3796,8 @@ Source/WebCore/workers/WorkerScriptLoader.h \ Source/WebCore/workers/WorkerThread.cpp \ Source/WebCore/workers/WorkerThread.h \ + Source/WebCore/xml/parser/NewXMLDocumentParser.cpp \ + Source/WebCore/xml/parser/NewXMLDocumentParser.h \ Source
[webkit-changes] [90918] trunk/Tools
Title: [90918] trunk/Tools Revision 90918 Author x...@webkit.org Date 2011-07-13 07:52:07 -0700 (Wed, 13 Jul 2011) Log Message 2011-07-13 Xan Lopez [GTK] Do not grab focus too early in DRT. Reviewed by Gustavo Noronha. It causes a layout to happen and a progress signal to be emitted since r90900, but at this point we don't have a LayoutTestController object and we'll eventually crash. Since we already grab focus at the beginning of runTest() this is redundant, so get rid of it to fix the crash. * DumpRenderTree/gtk/DumpRenderTree.cpp: (main): remove call to grab_focus Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp Diff Modified: trunk/Tools/ChangeLog (90917 => 90918) --- trunk/Tools/ChangeLog 2011-07-13 14:31:45 UTC (rev 90917) +++ trunk/Tools/ChangeLog 2011-07-13 14:52:07 UTC (rev 90918) @@ -1,3 +1,18 @@ +2011-07-13 Xan Lopez + +[GTK] Do not grab focus too early in DRT. + +Reviewed by Gustavo Noronha. + +It causes a layout to happen and a progress signal to be emitted +since r90900, but at this point we don't have a +LayoutTestController object and we'll eventually crash. Since we +already grab focus at the beginning of runTest() this is +redundant, so get rid of it to fix the crash. + +* DumpRenderTree/gtk/DumpRenderTree.cpp: +(main): remove call to grab_focus + 2011-07-13 Sheriff Bot Unreviewed, rolling out r90893 and r90894. Modified: trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (90917 => 90918) --- trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2011-07-13 14:31:45 UTC (rev 90917) +++ trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2011-07-13 14:52:07 UTC (rev 90918) @@ -1172,7 +1172,6 @@ gtk_container_add(GTK_CONTAINER(container), GTK_WIDGET(webView)); gtk_widget_realize(GTK_WIDGET(webView)); gtk_widget_show_all(container); -gtk_widget_grab_focus(GTK_WIDGET(webView)); mainFrame = webkit_web_view_get_main_frame(webView); setDefaultsToConsistentStateValuesForTesting(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90841] trunk/Source/WebCore
Title: [90841] trunk/Source/WebCore Revision 90841 Author x...@webkit.org Date 2011-07-12 12:41:24 -0700 (Tue, 12 Jul 2011) Log Message 2011-07-12 Arno Renevier [GTK] DOM bindings do not have gir annotations https://bugs.webkit.org/show_bug.cgi?id=45395 Reviewed by Xan Lopez. * bindings/scripts/CodeGeneratorGObject.pm: generate introspection annotations. * bindings/scripts/test/GObject/WebKitDOMTestCallback.h: update for new output. * bindings/scripts/test/GObject/WebKitDOMTestObj.h: ditto. * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: ditto. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.h trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h Diff Modified: trunk/Source/WebCore/ChangeLog (90840 => 90841) --- trunk/Source/WebCore/ChangeLog 2011-07-12 19:20:56 UTC (rev 90840) +++ trunk/Source/WebCore/ChangeLog 2011-07-12 19:41:24 UTC (rev 90841) @@ -1,3 +1,15 @@ +2011-07-12 Arno Renevier + +[GTK] DOM bindings do not have gir annotations +https://bugs.webkit.org/show_bug.cgi?id=45395 + +Reviewed by Xan Lopez. + +* bindings/scripts/CodeGeneratorGObject.pm: generate introspection annotations. +* bindings/scripts/test/GObject/WebKitDOMTestCallback.h: update for new output. +* bindings/scripts/test/GObject/WebKitDOMTestObj.h: ditto. +* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: ditto. + 2011-07-12 Chris Rogers webkitAudioContext does not do proper sanity checking on its arguments. Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (90840 => 90841) --- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2011-07-12 19:20:56 UTC (rev 90840) +++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2011-07-12 19:41:24 UTC (rev 90841) @@ -784,6 +784,30 @@ $functionSig .= ", GError **error"; } +# Insert introspection annotations +push(@hBody, "/**\n"); +push(@hBody, " * ${functionName}:\n"); +push(@hBody, " * \@self: A #${className}\n"); + +foreach my $param (@{$function->parameters}) { +my $paramType = GetGlibTypeName($param->type); +# $paramType can have a trailing * in some cases +$paramType =~ s/\*$//; +my $paramName = decamelize($param->name); +push(@hBody, " * \@${paramName}: A #${paramType}\n"); +} +if(@{$function->raisesExceptions}) { +push(@hBody, " * \@error: #GError\n"); +} +push(@hBody, " *\n"); +if (IsGDOMClassType($function->signature->type)) { +push(@hBody, " * Returns: (transfer none):\n"); +} else { +push(@hBody, " * Returns:\n"); +} +push(@hBody, " *\n"); +push(@hBody, "**/\n"); + push(@hBody, "WEBKIT_API $returnType\n$functionName($functionSig);\n"); push(@hBody, "\n"); Modified: trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.h (90840 => 90841) --- trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.h 2011-07-12 19:20:56 UTC (rev 90840) +++ trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.h 2011-07-12 19:41:24 UTC (rev 90841) @@ -46,18 +46,58 @@ WEBKIT_API GType webkit_dom_test_callback_get_type (void); +/** + * webkit_dom_test_callback_callback_with_no_param: + * @self: A #WebKitDOMTestCallback + * + * Returns: + * +**/ WEBKIT_API gboolean webkit_dom_test_callback_callback_with_no_param(WebKitDOMTestCallback* self); +/** + * webkit_dom_test_callback_callback_with_class1param: + * @self: A #WebKitDOMTestCallback + * @class1param: A #WebKitDOMClass1 + * + * Returns: + * +**/ WEBKIT_API gboolean webkit_dom_test_callback_callback_with_class1param(WebKitDOMTestCallback* self, WebKitDOMClass1* class1param); +/** + * webkit_dom_test_callback_callback_with_class2param: + * @self: A #WebKitDOMTestCallback + * @class2param: A #WebKitDOMClass2 + * @str_arg: A #gchar + * + * Returns: + * +**/ WEBKIT_API gboolean webkit_dom_test_callback_callback_with_class2param(WebKitDOMTestCallback* self, WebKitDOMClass2* class2param, const gchar* str_arg); +/** + * webkit_dom_test_callback_callback_with_non_bool_return_type: + * @self: A #WebKitDOMTestCallback + * @class3param: A #WebKitDOMClass3 + * + * Returns: + * +**/ WEBKIT_API glong webkit_dom_test_callback_callback_with_non_bool_return_type(WebKitDOMTestCallback* self, WebKitDOMClass3* class3param); +/** + * webkit_dom_test_call
[webkit-changes] [90559] trunk/LayoutTests
Title: [90559] trunk/LayoutTests Revision 90559 Author x...@webkit.org Date 2011-07-07 06:47:24 -0700 (Thu, 07 Jul 2011) Log Message 2011-07-07 Xan Lopez Unreviewed. Enable inspector tests again (they should work now), and skip test that is timing out in all GTK+ bots. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90558 => 90559) --- trunk/LayoutTests/ChangeLog 2011-07-07 13:44:55 UTC (rev 90558) +++ trunk/LayoutTests/ChangeLog 2011-07-07 13:47:24 UTC (rev 90559) @@ -1,3 +1,12 @@ +2011-07-07 Xan Lopez + +Unreviewed. + +Enable inspector tests again (they should work now), and skip test +that is timing out in all GTK+ bots. + +* platform/gtk/Skipped: + 2011-07-07 Vsevolod Vlasov Web Inspector: Move resetting NetworkResourcesData out of tests unrelated to replacement testing. Modified: trunk/LayoutTests/platform/gtk/Skipped (90558 => 90559) --- trunk/LayoutTests/platform/gtk/Skipped 2011-07-07 13:44:55 UTC (rev 90558) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-07-07 13:47:24 UTC (rev 90559) @@ -1546,9 +1546,5 @@ # access to file:// uris should be restricted in some cases. media/media-blocked-by-willsendrequest.html -# NWRT. Skip inspector/ and http/tests/inspector while we figure out -# what happens to them in the bots - -http/tests/inspector -http/tests/inspector-enabled -inspector/ +# https://bugs.webkit.org/show_bug.cgi?id=64085 +http/tests/misc/iframe-reparenting-id-collision.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90491] trunk/Tools
Title: [90491] trunk/Tools Revision 90491 Author x...@webkit.org Date 2011-07-06 13:50:46 -0700 (Wed, 06 Jul 2011) Log Message 2011-07-06 Xan Lopez [GTK] Only set env. variables in start when strictly needed https://bugs.webkit.org/show_bug.cgi?id=64026 Reviewed by Eric Seidel. * Scripts/webkitpy/layout_tests/port/gtk.py: add a setup_environ_for_server method in GtkPort and set as many env. variables as possible there. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py Diff Modified: trunk/Tools/ChangeLog (90490 => 90491) --- trunk/Tools/ChangeLog 2011-07-06 20:49:21 UTC (rev 90490) +++ trunk/Tools/ChangeLog 2011-07-06 20:50:46 UTC (rev 90491) @@ -1,3 +1,14 @@ +2011-07-06 Xan Lopez + +[GTK] Only set env. variables in start when strictly needed +https://bugs.webkit.org/show_bug.cgi?id=64026 + +Reviewed by Eric Seidel. + +* Scripts/webkitpy/layout_tests/port/gtk.py: add a +setup_environ_for_server method in GtkPort and set as many +env. variables as possible there. + 2011-07-06 Adam Roben Teach TestFailures how to load, parse, and interpret NRWT test results Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (90490 => 90491) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-06 20:49:21 UTC (rev 90490) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-06 20:50:46 UTC (rev 90491) @@ -44,10 +44,8 @@ run_xvfb = ["Xvfb", ":%d" % (display_id), "-screen", "0", "800x600x24", "-nolisten", "tcp"] self._xvfb_process = subprocess.Popen(run_xvfb) environment = self._port.setup_environ_for_server() +# We must do this here because the DISPLAY number depends on _worker_number environment['DISPLAY'] = ":%d" % (display_id) -environment['GTK_MODULES'] = 'gail' -environment['LIBOVERLAY_SCROLLBAR'] = '0' -environment['WEBKIT_INSPECTOR_PATH'] = self._port._build_path('Programs/resources/inspector') self._server_process = server_process.ServerProcess(self._port, self._port.driver_name(), self.cmd_line(), environment) @@ -63,6 +61,14 @@ def create_driver(self, worker_number): return GtkDriver(self, worker_number) +def setup_environ_for_server(self): +environment = webkit.WebKitPort.setup_environ_for_server(self) +environment['GTK_MODULES'] = 'gail' +environment['LIBOVERLAY_SCROLLBAR'] = '0' +environment['WEBKIT_INSPECTOR_PATH'] = self._build_path('Programs/resources/inspector') + +return environment + def _path_to_apache_config_file(self): # FIXME: This needs to detect the distribution and change config files. return self._filesystem.join(self.layout_tests_dir(), 'http', 'conf', 'apache2-debian-httpd.conf') ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90474] trunk/Tools
Title: [90474] trunk/Tools Revision 90474 Author x...@webkit.org Date 2011-07-06 11:31:37 -0700 (Wed, 06 Jul 2011) Log Message 2011-07-06 Xan Lopez Reviewed by Gustavo Noronha. * Scripts/webkitpy/layout_tests/port/gtk.py: use Popen correctly. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py Diff Modified: trunk/Tools/ChangeLog (90473 => 90474) --- trunk/Tools/ChangeLog 2011-07-06 18:26:35 UTC (rev 90473) +++ trunk/Tools/ChangeLog 2011-07-06 18:31:37 UTC (rev 90474) @@ -1,3 +1,9 @@ +2011-07-06 Xan Lopez + +Reviewed by Gustavo Noronha. + +* Scripts/webkitpy/layout_tests/port/gtk.py: use Popen correctly. + 2011-07-06 Eric Seidel webkit-patch failure-reason does not understand NRWT results Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (90473 => 90474) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-06 18:26:35 UTC (rev 90473) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-06 18:31:37 UTC (rev 90474) @@ -41,7 +41,7 @@ class GtkDriver(webkit.WebKitDriver): def start(self): display_id = self._worker_number + 1 -run_xvfb = ["Xvfb", ":%d -screen 0 800x600x24 -nolisten tcp" % (display_id)] +run_xvfb = ["Xvfb", ":%d" % (display_id), "-screen", "0", "800x600x24", "-nolisten", "tcp"] self._xvfb_process = subprocess.Popen(run_xvfb) environment = self._port.setup_environ_for_server() environment['DISPLAY'] = ":%d" % (display_id) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90469] trunk/Tools
Title: [90469] trunk/Tools Revision 90469 Author x...@webkit.org Date 2011-07-06 10:11:13 -0700 (Wed, 06 Jul 2011) Log Message 2011-07-06 Xan Lopez [GTK] Add missing environment variables in NWRT https://bugs.webkit.org/show_bug.cgi?id=64004 Reviewed by Gustavo Noronha Silva. Add missing environment variables needed by the GTK+ port. * Scripts/webkitpy/layout_tests/port/gtk.py: ditto. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py Diff Modified: trunk/Tools/ChangeLog (90468 => 90469) --- trunk/Tools/ChangeLog 2011-07-06 17:04:44 UTC (rev 90468) +++ trunk/Tools/ChangeLog 2011-07-06 17:11:13 UTC (rev 90469) @@ -1,3 +1,14 @@ +2011-07-06 Xan Lopez + +[GTK] Add missing environment variables in NWRT +https://bugs.webkit.org/show_bug.cgi?id=64004 + +Reviewed by Gustavo Noronha Silva. + +Add missing environment variables needed by the GTK+ port. + +* Scripts/webkitpy/layout_tests/port/gtk.py: ditto. + 2011-07-06 Adam Roben Make run-api-tests output intelligible on the bots Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (90468 => 90469) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-06 17:04:44 UTC (rev 90468) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-06 17:11:13 UTC (rev 90469) @@ -45,6 +45,9 @@ self._xvfb_process = subprocess.Popen(run_xvfb) environment = self._port.setup_environ_for_server() environment['DISPLAY'] = ":%d" % (display_id) +environment['GTK_MODULES'] = 'gail' +environment['LIBOVERLAY_SCROLLBAR'] = '0' +environment['WEBKIT_INSPECTOR_PATH'] = self._port._build_path('Programs/resources/inspector') self._server_process = server_process.ServerProcess(self._port, self._port.driver_name(), self.cmd_line(), environment) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90459] trunk/Tools
Title: [90459] trunk/Tools Revision 90459 Author x...@webkit.org Date 2011-07-06 08:25:27 -0700 (Wed, 06 Jul 2011) Log Message 2011-07-06 Xan Lopez Reviewed by Gustavo Noronha. Launch Xvfb (mostly) the same way we were launching it in the bots, for maximum compatibility. * Scripts/webkitpy/layout_tests/port/gtk.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py Diff Modified: trunk/Tools/ChangeLog (90458 => 90459) --- trunk/Tools/ChangeLog 2011-07-06 15:22:45 UTC (rev 90458) +++ trunk/Tools/ChangeLog 2011-07-06 15:25:27 UTC (rev 90459) @@ -1,3 +1,12 @@ +2011-07-06 Xan Lopez + +Reviewed by Gustavo Noronha. + +Launch Xvfb (mostly) the same way we were launching it in the +bots, for maximum compatibility. + +* Scripts/webkitpy/layout_tests/port/gtk.py: + 2011-07-06 Andreas Kling [Qt][WK2] Split Qt API into two different web views (touch and desktop) Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (90458 => 90459) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-06 15:22:45 UTC (rev 90458) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-06 15:25:27 UTC (rev 90459) @@ -41,7 +41,7 @@ class GtkDriver(webkit.WebKitDriver): def start(self): display_id = self._worker_number + 1 -run_xvfb = ["Xvfb", ":%d" % (display_id)] +run_xvfb = ["Xvfb", ":%d -screen 0 800x600x24 -nolisten tcp" % (display_id)] self._xvfb_process = subprocess.Popen(run_xvfb) environment = self._port.setup_environ_for_server() environment['DISPLAY'] = ":%d" % (display_id) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90453] trunk/LayoutTests
Title: [90453] trunk/LayoutTests Revision 90453 Author x...@webkit.org Date 2011-07-06 05:18:15 -0700 (Wed, 06 Jul 2011) Log Message 2011-07-06 Xan Lopez Unreviewed. Remove non-existing test from Skipped. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90452 => 90453) --- trunk/LayoutTests/ChangeLog 2011-07-06 12:13:57 UTC (rev 90452) +++ trunk/LayoutTests/ChangeLog 2011-07-06 12:18:15 UTC (rev 90453) @@ -2,6 +2,14 @@ Unreviewed. +Remove non-existing test from Skipped. + +* platform/gtk/Skipped: + +2011-07-06 Xan Lopez + +Unreviewed. + Missed these inspector tests before. * platform/gtk/Skipped: Modified: trunk/LayoutTests/platform/gtk/Skipped (90452 => 90453) --- trunk/LayoutTests/platform/gtk/Skipped 2011-07-06 12:13:57 UTC (rev 90452) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-07-06 12:18:15 UTC (rev 90453) @@ -523,7 +523,6 @@ # These tests call dumpAsText, but still perform normal render tree dumps. # https://bugs.webkit.org/show_bug.cgi?id=53955 -fast/dom/object-embed-plugin-scripting.html fast/dynamic/paused-event-dispatch.html # Scrollbar issues. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90452] trunk/LayoutTests
Title: [90452] trunk/LayoutTests Revision 90452 Author x...@webkit.org Date 2011-07-06 05:13:57 -0700 (Wed, 06 Jul 2011) Log Message 2011-07-06 Xan Lopez Unreviewed. Missed these inspector tests before. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90451 => 90452) --- trunk/LayoutTests/ChangeLog 2011-07-06 11:34:48 UTC (rev 90451) +++ trunk/LayoutTests/ChangeLog 2011-07-06 12:13:57 UTC (rev 90452) @@ -2,6 +2,14 @@ Unreviewed. +Missed these inspector tests before. + +* platform/gtk/Skipped: + +2011-07-06 Xan Lopez + +Unreviewed. + Skip inspector tests while we figure why they fail in the NWRT/debug bots. Modified: trunk/LayoutTests/platform/gtk/Skipped (90451 => 90452) --- trunk/LayoutTests/platform/gtk/Skipped 2011-07-06 11:34:48 UTC (rev 90451) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-07-06 12:13:57 UTC (rev 90452) @@ -1554,4 +1554,5 @@ # what happens to them in the bots http/tests/inspector +http/tests/inspector-enabled inspector/ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90451] trunk/LayoutTests
Title: [90451] trunk/LayoutTests Revision 90451 Author x...@webkit.org Date 2011-07-06 04:34:48 -0700 (Wed, 06 Jul 2011) Log Message 2011-07-06 Xan Lopez Unreviewed. Skip inspector tests while we figure why they fail in the NWRT/debug bots. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90450 => 90451) --- trunk/LayoutTests/ChangeLog 2011-07-06 11:15:57 UTC (rev 90450) +++ trunk/LayoutTests/ChangeLog 2011-07-06 11:34:48 UTC (rev 90451) @@ -1,3 +1,12 @@ +2011-07-06 Xan Lopez + +Unreviewed. + +Skip inspector tests while we figure why they fail in the +NWRT/debug bots. + +* platform/gtk/Skipped: + 2011-07-05 Yuta Kitamura WebSocket: Move current WebSocket tests to a new directory Modified: trunk/LayoutTests/platform/gtk/Skipped (90450 => 90451) --- trunk/LayoutTests/platform/gtk/Skipped 2011-07-06 11:15:57 UTC (rev 90450) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-07-06 11:34:48 UTC (rev 90451) @@ -1549,3 +1549,9 @@ # https://bugs.webkit.org/show_bug.cgi?id=63699 # access to file:// uris should be restricted in some cases. media/media-blocked-by-willsendrequest.html + +# NWRT. Skip inspector/ and http/tests/inspector while we figure out +# what happens to them in the bots + +http/tests/inspector +inspector/ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90447] trunk/Tools
Title: [90447] trunk/Tools Revision 90447 Author x...@webkit.org Date 2011-07-06 03:13:02 -0700 (Wed, 06 Jul 2011) Log Message 2011-07-06 Xan Lopez Unreviewed. NWRT actually seems to work locally, so it should work in the bots as long as we take care of the TIMEOUT issue (which is being fixed as I write this). Let's give this another shot and fix whatever breaks. * Scripts/run-webkit-tests: (useNewRunWebKitTests): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-webkit-tests Diff Modified: trunk/Tools/ChangeLog (90446 => 90447) --- trunk/Tools/ChangeLog 2011-07-06 09:14:08 UTC (rev 90446) +++ trunk/Tools/ChangeLog 2011-07-06 10:13:02 UTC (rev 90447) @@ -2,6 +2,18 @@ Unreviewed. +NWRT actually seems to work locally, so it should work in the bots +as long as we take care of the TIMEOUT issue (which is being fixed +as I write this). Let's give this another shot and fix whatever +breaks. + +* Scripts/run-webkit-tests: +(useNewRunWebKitTests): + +2011-07-06 Xan Lopez + +Unreviewed. + Disable NWRT on GTK. At the very least it needs an updated exected results file since NWRT is more sensitive to timeouts, not sure what the exact problem is. Modified: trunk/Tools/Scripts/run-webkit-tests (90446 => 90447) --- trunk/Tools/Scripts/run-webkit-tests 2011-07-06 09:14:08 UTC (rev 90446) +++ trunk/Tools/Scripts/run-webkit-tests 2011-07-06 10:13:02 UTC (rev 90447) @@ -70,7 +70,7 @@ # Example: return runningOnBuildBot() && isLeopard(); # would enable new-run-webkit-tests on only the leopard buildbots. # NRWT Windows support still needs work: https://bugs.webkit.org/show_bug.cgi?id=38756 -return (!isGtk() and !isAnyWindows() and !usingWebKit2()); +return (!isAnyWindows() and !usingWebKit2()); } my $harnessName = "old-run-webkit-tests"; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90446] trunk/Tools
Title: [90446] trunk/Tools Revision 90446 Author x...@webkit.org Date 2011-07-06 02:14:08 -0700 (Wed, 06 Jul 2011) Log Message 2011-07-06 Xan Lopez Unreviewed. Disable NWRT on GTK. At the very least it needs an updated exected results file since NWRT is more sensitive to timeouts, not sure what the exact problem is. * Scripts/run-webkit-tests: (useNewRunWebKitTests): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-webkit-tests Diff Modified: trunk/Tools/ChangeLog (90445 => 90446) --- trunk/Tools/ChangeLog 2011-07-06 08:06:46 UTC (rev 90445) +++ trunk/Tools/ChangeLog 2011-07-06 09:14:08 UTC (rev 90446) @@ -1,3 +1,14 @@ +2011-07-06 Xan Lopez + +Unreviewed. + +Disable NWRT on GTK. At the very least it needs an updated exected +results file since NWRT is more sensitive to timeouts, not sure +what the exact problem is. + +* Scripts/run-webkit-tests: +(useNewRunWebKitTests): + 2011-07-06 Adam Barth Fix global variable leak detected by noglobals. Modified: trunk/Tools/Scripts/run-webkit-tests (90445 => 90446) --- trunk/Tools/Scripts/run-webkit-tests 2011-07-06 08:06:46 UTC (rev 90445) +++ trunk/Tools/Scripts/run-webkit-tests 2011-07-06 09:14:08 UTC (rev 90446) @@ -70,7 +70,7 @@ # Example: return runningOnBuildBot() && isLeopard(); # would enable new-run-webkit-tests on only the leopard buildbots. # NRWT Windows support still needs work: https://bugs.webkit.org/show_bug.cgi?id=38756 -return (!isAnyWindows() and !usingWebKit2()); +return (!isGtk() and !isAnyWindows() and !usingWebKit2()); } my $harnessName = "old-run-webkit-tests"; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90036] trunk/Tools
Title: [90036] trunk/Tools Revision 90036 Author x...@webkit.org Date 2011-06-29 12:47:04 -0700 (Wed, 29 Jun 2011) Log Message 2011-06-29 Xan Lopez Reviewed by Adam Barth. [GTK] overlapping drag&drop tests fail on NRWT https://bugs.webkit.org/show_bug.cgi?id=57640 Make a GTK test driver that spawns one Xvfb instance per thread. This avoids bad interactions in DnD tests between threads. * Scripts/webkitpy/layout_tests/port/gtk.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py Diff Modified: trunk/Tools/ChangeLog (90035 => 90036) --- trunk/Tools/ChangeLog 2011-06-29 19:46:28 UTC (rev 90035) +++ trunk/Tools/ChangeLog 2011-06-29 19:47:04 UTC (rev 90036) @@ -1,3 +1,15 @@ +2011-06-29 Xan Lopez + +Reviewed by Adam Barth. + +[GTK] overlapping drag&drop tests fail on NRWT +https://bugs.webkit.org/show_bug.cgi?id=57640 + +Make a GTK test driver that spawns one Xvfb instance per +thread. This avoids bad interactions in DnD tests between threads. + +* Scripts/webkitpy/layout_tests/port/gtk.py: + 2011-06-29 Sheriff Bot Unreviewed, rolling out r89888. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (90035 => 90036) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-06-29 19:46:28 UTC (rev 90035) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-06-29 19:47:04 UTC (rev 90036) @@ -29,19 +29,43 @@ """WebKit Gtk implementation of the Port interface.""" import logging +import os +import signal +import subprocess -from webkitpy.layout_tests.port.webkit import WebKitPort +from webkitpy.layout_tests.port import base, builders, server_process, webkit _log = logging.getLogger("webkitpy.layout_tests.port.gtk") -class GtkPort(WebKitPort): +class GtkDriver(webkit.WebKitDriver): +"""WebKit Gtk implementation of the Driver class.""" + +def start(self): +display_id = self._worker_number + 1 +run_xvfb = ["Xvfb", ":%d" % (display_id)] +self._xvfb_process = subprocess.Popen(run_xvfb) +environment = self._port.setup_environ_for_server() +environment['DISPLAY'] = ":%d" % (display_id) +self._server_process = server_process.ServerProcess(self._port, +self._port.driver_name(), self.cmd_line(), environment) + +def stop(self): +webkit.WebKitDriver.stop(self) +os.kill(self._xvfb_process.pid, signal.SIGTERM) +self._xvfb_process.wait() + + +class GtkPort(webkit.WebKitPort): """WebKit Gtk implementation of the Port class.""" def __init__(self, **kwargs): kwargs.setdefault('port_name', 'gtk') -WebKitPort.__init__(self, **kwargs) +webkit.WebKitPort.__init__(self, **kwargs) +def create_driver(self, worker_number): +return GtkDriver(self, worker_number) + def _path_to_apache_config_file(self): # FIXME: This needs to detect the distribution and change config files. return self._filesystem.join(self.layout_tests_dir(), 'http', 'conf', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88872] trunk/Source/WebKit/gtk
Title: [88872] trunk/Source/WebKit/gtk Revision 88872 Author x...@webkit.org Date 2011-06-14 16:35:43 -0700 (Tue, 14 Jun 2011) Log Message 2011-06-14 Xan Lopez Reviewed by Martin Robinson. [GTK] Remove G_CONST_RETURN usage https://bugs.webkit.org/show_bug.cgi?id=62673 Change G_CONST_RETURN for a simple "const" throughout the codebase, since G_CONST_RETURN is deprecated now. This should be totally equivalent since for all practical purposes the macro is always expanded to const. * webkit/webkitapplicationcache.cpp: (webkit_application_cache_get_database_directory_path): use const instead of G_CONST_RETURN. * webkit/webkitapplicationcache.h: * webkit/webkiticondatabase.cpp: (webkit_icon_database_get_path): ditto. * webkit/webkiticondatabase.h: * webkit/webkitnetworkrequest.cpp: (webkit_network_request_get_uri): ditto. * webkit/webkitnetworkrequest.h: * webkit/webkitnetworkresponse.cpp: (webkit_network_response_get_uri): ditto. * webkit/webkitnetworkresponse.h: * webkit/webkitsecurityorigin.cpp: (webkit_security_origin_get_protocol): ditto. (webkit_security_origin_get_host): ditto. * webkit/webkitsecurityorigin.h: * webkit/webkitwebdatabase.cpp: (webkit_web_database_get_name): ditto. (webkit_web_database_get_display_name): ditto. (webkit_web_database_get_filename): ditto. (webkit_get_web_database_directory_path): ditto. * webkit/webkitwebdatabase.h: * webkit/webkitwebdatasource.cpp: (webkit_web_data_source_get_encoding): ditto. (webkit_web_data_source_get_unreachable_uri): ditto. * webkit/webkitwebdatasource.h: * webkit/webkitwebframe.cpp: (webkit_web_frame_get_title): ditto. (webkit_web_frame_get_uri): ditto. (webkit_web_frame_get_name): ditto. * webkit/webkitwebframe.h: * webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_get_title): ditto. (webkit_web_history_item_get_alternate_title): ditto. (webkit_web_history_item_get_uri): ditto. (webkit_web_history_item_get_original_uri): ditto. (webkit_web_history_item_get_target): ditto. * webkit/webkitwebhistoryitem.h: * webkit/webkitwebhistoryitemprivate.h: * webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_target_frame): ditto. * webkit/webkitwebnavigationaction.h: * webkit/webkitwebresource.cpp: (webkit_web_resource_get_uri): ditto. (webkit_web_resource_get_mime_type): ditto. (webkit_web_resource_get_encoding): ditto. (webkit_web_resource_get_frame_name): ditto. * webkit/webkitwebresource.h: * webkit/webkitwebsettings.cpp: (webkit_web_settings_get_user_agent): ditto. * webkit/webkitwebsettings.h: * webkit/webkitwebview.cpp: (webkit_web_view_get_title): ditto. (webkit_web_view_get_uri): ditto. (webkit_web_view_get_icon_uri): ditto. * webkit/webkitwebview.h: * webkit/webkitwebviewcommon.h: Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/webkit/webkitapplicationcache.cpp trunk/Source/WebKit/gtk/webkit/webkitapplicationcache.h trunk/Source/WebKit/gtk/webkit/webkiticondatabase.cpp trunk/Source/WebKit/gtk/webkit/webkiticondatabase.h trunk/Source/WebKit/gtk/webkit/webkitnetworkrequest.cpp trunk/Source/WebKit/gtk/webkit/webkitnetworkrequest.h trunk/Source/WebKit/gtk/webkit/webkitnetworkresponse.cpp trunk/Source/WebKit/gtk/webkit/webkitnetworkresponse.h trunk/Source/WebKit/gtk/webkit/webkitsecurityorigin.cpp trunk/Source/WebKit/gtk/webkit/webkitsecurityorigin.h trunk/Source/WebKit/gtk/webkit/webkitwebdatabase.cpp trunk/Source/WebKit/gtk/webkit/webkitwebdatabase.h trunk/Source/WebKit/gtk/webkit/webkitwebdatasource.cpp trunk/Source/WebKit/gtk/webkit/webkitwebdatasource.h trunk/Source/WebKit/gtk/webkit/webkitwebframe.cpp trunk/Source/WebKit/gtk/webkit/webkitwebframe.h trunk/Source/WebKit/gtk/webkit/webkitwebhistoryitem.cpp trunk/Source/WebKit/gtk/webkit/webkitwebhistoryitem.h trunk/Source/WebKit/gtk/webkit/webkitwebhistoryitemprivate.h trunk/Source/WebKit/gtk/webkit/webkitwebnavigationaction.cpp trunk/Source/WebKit/gtk/webkit/webkitwebnavigationaction.h trunk/Source/WebKit/gtk/webkit/webkitwebresource.cpp trunk/Source/WebKit/gtk/webkit/webkitwebresource.h trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp trunk/Source/WebKit/gtk/webkit/webkitwebsettings.h trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp trunk/Source/WebKit/gtk/webkit/webkitwebview.h trunk/Source/WebKit/gtk/webkit/webkitwebviewcommon.h Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (88871 => 88872) --- trunk/Source/WebKit/gtk/ChangeLog 2011-06-14 23:29:51 UTC (rev 88871) +++ trunk/Source/WebKit/gtk/C
[webkit-changes] [88696] trunk/Source/WebCore
Title: [88696] trunk/Source/WebCore Revision 88696 Author x...@webkit.org Date 2011-06-13 14:23:29 -0700 (Mon, 13 Jun 2011) Log Message 2011-06-13 Xan Lopez Unreviewed build fix. Touch this to try to fix the build... * platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (88695 => 88696) --- trunk/Source/WebCore/ChangeLog 2011-06-13 21:22:05 UTC (rev 88695) +++ trunk/Source/WebCore/ChangeLog 2011-06-13 21:23:29 UTC (rev 88696) @@ -1,5 +1,14 @@ 2011-06-13 Xan Lopez +Unreviewed build fix. + +Touch this to try to fix the build... + +* platform/gtk/WidgetGtk.cpp: +(WebCore::Widget::~Widget): + +2011-06-13 Xan Lopez + Try to fix GTK+ build. * GNUmakefile.list.am: remove CredentialStorage.cpp Modified: trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp (88695 => 88696) --- trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp 2011-06-13 21:22:05 UTC (rev 88695) +++ trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp 2011-06-13 21:23:29 UTC (rev 88696) @@ -52,6 +52,7 @@ Widget::~Widget() { ASSERT(!parent()); + releasePlatformWidget(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88693] trunk/Source/WebCore
Title: [88693] trunk/Source/WebCore Revision 88693 Author x...@webkit.org Date 2011-06-13 14:14:49 -0700 (Mon, 13 Jun 2011) Log Message 2011-06-13 Xan Lopez Try to fix GTK+ build. * GNUmakefile.list.am: remove CredentialStorage.cpp Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am Diff Modified: trunk/Source/WebCore/ChangeLog (88692 => 88693) --- trunk/Source/WebCore/ChangeLog 2011-06-13 21:10:35 UTC (rev 88692) +++ trunk/Source/WebCore/ChangeLog 2011-06-13 21:14:49 UTC (rev 88693) @@ -1,3 +1,9 @@ +2011-06-13 Xan Lopez + +Try to fix GTK+ build. + +* GNUmakefile.list.am: remove CredentialStorage.cpp + 2011-06-13 Stephen White Reviewed by James Robinson. Modified: trunk/Source/WebCore/GNUmakefile.list.am (88692 => 88693) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-06-13 21:10:35 UTC (rev 88692) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-06-13 21:14:49 UTC (rev 88693) @@ -2593,7 +2593,6 @@ Source/WebCore/platform/network/CookieStorage.h \ Source/WebCore/platform/network/Credential.cpp \ Source/WebCore/platform/network/Credential.h \ - Source/WebCore/platform/network/CredentialStorage.cpp \ Source/WebCore/platform/network/CredentialStorage.h \ Source/WebCore/platform/network/DNS.h \ Source/WebCore/platform/network/FormDataBuilder.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88681] trunk/Source/WebKit/gtk
Title: [88681] trunk/Source/WebKit/gtk Revision 88681 Author x...@webkit.org Date 2011-06-13 13:25:41 -0700 (Mon, 13 Jun 2011) Log Message 2011-06-13 Xan Lopez Reviewed by Martin Robinson. Update NEWS for 1.5.1 release. * NEWS: update. Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/NEWS Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (88680 => 88681) --- trunk/Source/WebKit/gtk/ChangeLog 2011-06-13 20:20:05 UTC (rev 88680) +++ trunk/Source/WebKit/gtk/ChangeLog 2011-06-13 20:25:41 UTC (rev 88681) @@ -2,6 +2,14 @@ Reviewed by Martin Robinson. +Update NEWS for 1.5.1 release. + +* NEWS: update. + +2011-06-13 Xan Lopez + +Reviewed by Martin Robinson. + Distcheck fixes. * GNUmakefile.am: Modified: trunk/Source/WebKit/gtk/NEWS (88680 => 88681) --- trunk/Source/WebKit/gtk/NEWS 2011-06-13 20:20:05 UTC (rev 88680) +++ trunk/Source/WebKit/gtk/NEWS 2011-06-13 20:25:41 UTC (rev 88681) @@ -1,3 +1,18 @@ + +WebKitGTK+ 1.5.1 + + +What's new in WebKitGTK+ 1.5.1? + + - The JSC library is now available independently. It's called +"libjavascriptcoregtk", and it comes with its own pkg-config file. + - New spellchecking APIs, useful to implement spellchecking features +in the UAs. + - New DOM methods to check if editable areas have been modified by +the user (webkit_dom_html_{input,text_area}_is_edited). + - Lots of improvements in the WebKit2GTK+ port. + - Lots of bugfixes. + = WebKitGTK+ 1.3.13 = ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88674] trunk/Source
Title: [88674] trunk/Source Revision 88674 Author x...@webkit.org Date 2011-06-13 12:47:09 -0700 (Mon, 13 Jun 2011) Log Message Source/WebCore: 2011-06-13 Xan Lopez Reviewed by Martin Robinson. Distcheck fixes. * GNUmakefile.am: * GNUmakefile.list.am: Source/WebKit/gtk: 2011-06-13 Xan Lopez Reviewed by Martin Robinson. Distcheck fixes. * GNUmakefile.am: Source/_javascript_Core: 2011-06-13 Xan Lopez Reviewed by Martin Robinson. Distcheck fixes. * GNUmakefile.am: * GNUmakefile.list.am: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.am trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/GNUmakefile.am Diff Modified: trunk/Source/_javascript_Core/ChangeLog (88673 => 88674) --- trunk/Source/_javascript_Core/ChangeLog 2011-06-13 19:37:49 UTC (rev 88673) +++ trunk/Source/_javascript_Core/ChangeLog 2011-06-13 19:47:09 UTC (rev 88674) @@ -1,3 +1,12 @@ +2011-06-13 Xan Lopez + +Reviewed by Martin Robinson. + +Distcheck fixes. + +* GNUmakefile.am: +* GNUmakefile.list.am: + 2011-06-13 Oliver Hunt Reviewed by Simon Fraser. Modified: trunk/Source/_javascript_Core/GNUmakefile.am (88673 => 88674) --- trunk/Source/_javascript_Core/GNUmakefile.am 2011-06-13 19:37:49 UTC (rev 88673) +++ trunk/Source/_javascript_Core/GNUmakefile.am 2011-06-13 19:47:09 UTC (rev 88674) @@ -145,6 +145,7 @@ Source/_javascript_Core/create_regex_tables \ Source/_javascript_Core/icu/LICENSE \ Source/_javascript_Core/icu/README \ + Source/_javascript_Core/KeywordLookupGenerator.py \ Source/_javascript_Core/parser/Keywords.table \ Source/_javascript_Core/THANKS Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (88673 => 88674) --- trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-06-13 19:37:49 UTC (rev 88673) +++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-06-13 19:47:09 UTC (rev 88674) @@ -98,6 +98,29 @@ Source/_javascript_Core/bytecompiler/LabelScope.h \ Source/_javascript_Core/bytecompiler/NodesCodegen.cpp \ Source/_javascript_Core/bytecompiler/RegisterID.h \ + Source/_javascript_Core/dfg/DFGAliasTracker.h \ + Source/_javascript_Core/dfg/DFGByteCodeParser.cpp \ + Source/_javascript_Core/dfg/DFGByteCodeParser.h \ + Source/_javascript_Core/dfg/DFGFPRInfo.h \ + Source/_javascript_Core/dfg/DFGGenerationInfo.h \ + Source/_javascript_Core/dfg/DFGGPRInfo.h \ + Source/_javascript_Core/dfg/DFGGraph.cpp \ + Source/_javascript_Core/dfg/DFGGraph.h \ + Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp \ + Source/_javascript_Core/dfg/DFGJITCodeGenerator.h \ + Source/_javascript_Core/dfg/DFGJITCompiler.cpp \ + Source/_javascript_Core/dfg/DFGJITCompiler.h \ + Source/_javascript_Core/dfg/DFGNode.h \ + Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp \ + Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.h \ + Source/_javascript_Core/dfg/DFGOperations.cpp \ + Source/_javascript_Core/dfg/DFGOperations.h \ + Source/_javascript_Core/dfg/DFGRegisterBank.h \ + Source/_javascript_Core/dfg/DFGRepatch.cpp \ + Source/_javascript_Core/dfg/DFGRepatch.h \ + Source/_javascript_Core/dfg/DFGScoreBoard.h \ + Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp \ + Source/_javascript_Core/dfg/DFGSpeculativeJIT.h \ Source/_javascript_Core/heap/ConservativeRoots.cpp \ Source/_javascript_Core/heap/ConservativeRoots.h \ Source/_javascript_Core/heap/Handle.h \ @@ -413,6 +436,7 @@ Source/_javascript_Core/runtime/WeakGCMap.h \ Source/_javascript_Core/runtime/WeakRandom.h \ Source/_javascript_Core/runtime/WriteBarrier.h \ + Source/_javascript_Core/wtf/Alignment.h \ Source/_javascript_Core/wtf/AlwaysInline.h \ Source/_javascript_Core/wtf/ASCIICType.h \ Source/_javascript_Core/wtf/Assertions.cpp \ Modified: trunk/Source/WebCore/ChangeLog (88673 => 88674) --- trunk/Source/WebCore/ChangeLog 2011-06-13 19:37:49 UTC (rev 88673) +++ trunk/Source/WebCore/ChangeLog 2011-06-13 19:47:09 UTC (rev 88674) @@ -1,3 +1,12 @@ +2011-06-13 Xan Lopez + +Reviewed by Martin Robinson. + +Distcheck fixes. + +* GNUmakefile.am: +* GNUmakefile.list.am: + 2011-06-13 Dirk Schulze Reviewed build fix of mac. Modified: trunk/Source/WebCore/GNUmakefile.am (88673 => 88674) --- trunk/Source/WebCore/GNUmakefile.am 2011-06-13 19:37:49 UTC (rev 88673) +++ trunk/Source/WebCore/GNUmakefile.am 2011-06-13 19:47:09 UTC (rev 88674) @@ -793,7 +793,7 @@ Source/WebCore/bindings/scripts/IDLStructure.pm \ Source/WebCore/bindings/scripts/InFilesParser.pm \ Source/WebCore/bindings/scripts/generate-bindings.pl \ - Source/WebCore/bindings/scripts/preprocessor.pm + Source/WebCore/bindings/scripts/preprocesso
[webkit-changes] [88645] trunk/Source/WebCore
Title: [88645] trunk/Source/WebCore Revision 88645 Author x...@webkit.org Date 2011-06-13 10:12:36 -0700 (Mon, 13 Jun 2011) Log Message 2011-06-13 Xan Lopez Reviewed by Martin Robinson. Some distcheck fixes. Still broken, but this is moves us closer to the target. * GNUmakefile.am: fix vpath syntax and add missing files to EXTRA_DIST. * GNUmakefile.list.am: add missing files and remove dead files. * bindings/gobject/GNUmakefile.am: fix comment. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/bindings/gobject/GNUmakefile.am Diff Modified: trunk/Source/WebCore/ChangeLog (88644 => 88645) --- trunk/Source/WebCore/ChangeLog 2011-06-13 16:54:54 UTC (rev 88644) +++ trunk/Source/WebCore/ChangeLog 2011-06-13 17:12:36 UTC (rev 88645) @@ -1,3 +1,15 @@ +2011-06-13 Xan Lopez + +Reviewed by Martin Robinson. + +Some distcheck fixes. Still broken, but this is moves us closer to +the target. + +* GNUmakefile.am: fix vpath syntax and add missing files to +EXTRA_DIST. +* GNUmakefile.list.am: add missing files and remove dead files. +* bindings/gobject/GNUmakefile.am: fix comment. + 2011-06-13 Noam Rosenthal Reviewed by Kenneth Rohde Christiansen. Modified: trunk/Source/WebCore/GNUmakefile.am (88644 => 88645) --- trunk/Source/WebCore/GNUmakefile.am 2011-06-13 16:54:54 UTC (rev 88644) +++ trunk/Source/WebCore/GNUmakefile.am 2011-06-13 17:12:36 UTC (rev 88645) @@ -715,7 +715,7 @@ $(WebCore)/workers \ $(WebCore)/xml -vpath %.idl = $(IDL_PATH) +vpath %.idl $(IDL_PATH) # This does not appear to work correctly with gnumake unless # it includes an empty command list (the semicolon). @@ -788,6 +788,12 @@ $(shell ls $(srcdir)/Source/WebCore/websockets/*.idl) \ $(shell ls $(srcdir)/Source/WebCore/workers/*.idl) \ $(shell ls $(srcdir)/Source/WebCore/xml/*.idl) \ + Source/WebCore/bindings/scripts/CodeGenerator.pm \ + Source/WebCore/bindings/scripts/IDLParser.pm \ + Source/WebCore/bindings/scripts/IDLStructure.pm \ + Source/WebCore/bindings/scripts/InFilesParser.pm \ + Source/WebCore/bindings/scripts/generate-bindings.pl \ + Source/WebCore/bindings/scripts/preprocessor.pm Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm \ Source/WebCore/bindings/scripts/CodeGeneratorJS.pm \ Source/WebCore/bindings/scripts/CodeGenerator.pm \ Modified: trunk/Source/WebCore/GNUmakefile.list.am (88644 => 88645) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-06-13 16:54:54 UTC (rev 88644) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-06-13 17:12:36 UTC (rev 88645) @@ -1274,8 +1274,6 @@ Source/WebCore/dom/StaticNodeList.h \ Source/WebCore/dom/Stream.cpp \ Source/WebCore/dom/Stream.h \ - Source/WebCore/dom/StreamEvent.cpp \ - Source/WebCore/dom/Streamevent.h \ Source/WebCore/dom/StyledElement.cpp \ Source/WebCore/dom/StyledElement.h \ Source/WebCore/dom/StyleElement.cpp \ @@ -1861,7 +1859,6 @@ Source/WebCore/html/shadow/MeterShadowElement.h \ Source/WebCore/html/shadow/ProgressShadowElement.cpp \ Source/WebCore/html/shadow/ProgressShadowElement.h \ - Source/WebCore/html/shadow/ShadowContentElement.h \ Source/WebCore/html/shadow/SliderThumbElement.cpp \ Source/WebCore/html/shadow/SliderThumbElement.h \ Source/WebCore/html/shadow/TextControlInnerElements.cpp \ @@ -3735,7 +3732,7 @@ Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp \ Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h \ Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp \ - Source/WebCore/platform/graphics/cairo/ImageBufferData.h \ + Source/WebCore/platform/graphics/cairo/ImageBufferDataCairo.h \ Source/WebCore/platform/graphics/cairo/ImageCairo.cpp \ Source/WebCore/platform/graphics/cairo/OwnPtrCairo.cpp \ Source/WebCore/platform/graphics/cairo/OwnPtrCairo.h \ Modified: trunk/Source/WebCore/bindings/gobject/GNUmakefile.am (88644 => 88645) --- trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2011-06-13 16:54:54 UTC (rev 88644) +++ trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2011-06-13 17:12:36 UTC (rev 88645) @@ -434,8 +434,8 @@ $(top_builddir)/DerivedSources/webkit/WebKitDOMCustom.h: $(WebCore)/bindings/gobject/WebKitDOMCustom.h $(AM_V_GEN)cp -f $< $@ -# Filter out SVG for now +# Filter out SVG and IndexedDB for now gdom_feature_defines := $(filter-out ENABLE_INDEXED_DATABASE=1, $(filter-out ENABLE_SVG%, $(FEATURE_DEFINES))) -DerivedSources/webkit/WebKitDOM%.cpp DerivedSources/webkit/WebKitDOM%.h DerivedSources/webkit/WebKitDOM%Private.h:: %.idl $(SCRIPTS_BINDINGS) $(WebCore)/bindings/scripts/CodeGeneratorGObject.pm $(WebCore)/bindings/gobject/GNUmakefile.am +DerivedSources/webkit/WebKitDOM%.cpp DerivedSources/webkit/WebKitDOM%.h DerivedSources/webkit/WebKitDOM%Private.h: %.idl $(S
[webkit-changes] [88621] trunk/Source/WebKit/gtk
Title: [88621] trunk/Source/WebKit/gtk Revision 88621 Author x...@webkit.org Date 2011-06-12 16:34:10 -0700 (Sun, 12 Jun 2011) Log Message 2011-06-12 Xan Lopez Reviewed by Martin Robinson. [GTK] Remove webkit_web_view_get_selected_text https://bugs.webkit.org/show_bug.cgi?id=62512 It's no longer used and it's a private method, so it can be removed. * webkit/webkitwebview.cpp: kill it. * webkit/webkitwebviewprivate.h: ditto. Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp trunk/Source/WebKit/gtk/webkit/webkitwebviewprivate.h Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (88620 => 88621) --- trunk/Source/WebKit/gtk/ChangeLog 2011-06-12 21:24:09 UTC (rev 88620) +++ trunk/Source/WebKit/gtk/ChangeLog 2011-06-12 23:34:10 UTC (rev 88621) @@ -1,3 +1,16 @@ +2011-06-12 Xan Lopez + +Reviewed by Martin Robinson. + +[GTK] Remove webkit_web_view_get_selected_text +https://bugs.webkit.org/show_bug.cgi?id=62512 + +It's no longer used and it's a private method, so it can be +removed. + +* webkit/webkitwebview.cpp: kill it. +* webkit/webkitwebviewprivate.h: ditto. + 2011-06-12 Adam Barth Reviewed by Alexey Proskuryakov. Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (88620 => 88621) --- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2011-06-12 21:24:09 UTC (rev 88620) +++ trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2011-06-12 23:34:10 UTC (rev 88621) @@ -4216,22 +4216,6 @@ } /** - * webkit_web_view_get_selected_text: - * @webView: a #WebKitWebView - * - * Retrieves the selected text if any. - * - * Return value: a newly allocated string with the selection or %NULL - */ -gchar* webkit_web_view_get_selected_text(WebKitWebView* webView) -{ -g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), 0); - -Frame* frame = core(webView)->focusController()->focusedOrMainFrame(); -return g_strdup(frame->editor()->selectedText().utf8().data()); -} - -/** * webkit_web_view_select_all: * @webView: a #WebKitWebView * Modified: trunk/Source/WebKit/gtk/webkit/webkitwebviewprivate.h (88620 => 88621) --- trunk/Source/WebKit/gtk/webkit/webkitwebviewprivate.h 2011-06-12 21:24:09 UTC (rev 88620) +++ trunk/Source/WebKit/gtk/webkit/webkitwebviewprivate.h 2011-06-12 23:34:10 UTC (rev 88621) @@ -119,8 +119,6 @@ void webkit_web_view_set_tooltip_text(WebKitWebView*, const char*); GtkMenu* webkit_web_view_get_context_menu(WebKitWebView*); -WEBKIT_API gchar* webkit_web_view_get_selected_text(WebKitWebView*); - void webViewEnterFullscreen(WebKitWebView* webView, WebCore::Node*); void webViewExitFullscreen(WebKitWebView* webView); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88240] trunk/Source/WebKit/gtk
Title: [88240] trunk/Source/WebKit/gtk Revision 88240 Author x...@webkit.org Date 2011-06-07 08:33:41 -0700 (Tue, 07 Jun 2011) Log Message 2011-06-07 Xan Lopez Reviewed by Martin Robinson. [GTK] "webkithittestresult.h" is malformed https://bugs.webkit.org/show_bug.cgi?id=62117 * webkit/webkithittestresult.h: fix typo in GET_CLASS macro. Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/webkit/webkithittestresult.h Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (88239 => 88240) --- trunk/Source/WebKit/gtk/ChangeLog 2011-06-07 15:33:34 UTC (rev 88239) +++ trunk/Source/WebKit/gtk/ChangeLog 2011-06-07 15:33:41 UTC (rev 88240) @@ -1,3 +1,12 @@ +2011-06-07 Xan Lopez + +Reviewed by Martin Robinson. + +[GTK] "webkithittestresult.h" is malformed +https://bugs.webkit.org/show_bug.cgi?id=62117 + +* webkit/webkithittestresult.h: fix typo in GET_CLASS macro. + 2011-05-31 Martin Robinson Reviewed by Ryosuke Niwa. Modified: trunk/Source/WebKit/gtk/webkit/webkithittestresult.h (88239 => 88240) --- trunk/Source/WebKit/gtk/webkit/webkithittestresult.h 2011-06-07 15:33:34 UTC (rev 88239) +++ trunk/Source/WebKit/gtk/webkit/webkithittestresult.h 2011-06-07 15:33:41 UTC (rev 88240) @@ -32,7 +32,7 @@ #define WEBKIT_HIT_TEST_RESULT_CLASS(klass)(G_TYPE_CHECK_CLASS_CAST((klass), WEBKIT_TYPE_HIT_TEST_RESULT, WebKitHitTestResultClass)) #define WEBKIT_IS_HIT_TEST_RESULT(obj) (G_TYPE_CHECK_INSTANCE_TYPE((obj), WEBKIT_TYPE_HIT_TEST_RESULT)) #define WEBKIT_IS_HIT_TEST_RESULT_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE((klass), WEBKIT_TYPE_HIT_TEST_RESULT)) -#define WEBKIT_HIT_TEST_RESULT_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS((obj), WEBKIT_TYPE_WEB_HIT_TEST_RESULT, WebKitHitTestResultClass)) +#define WEBKIT_HIT_TEST_RESULT_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS((obj), WEBKIT_TYPE_HIT_TEST_RESULT, WebKitHitTestResultClass)) typedef struct _WebKitHitTestResultPrivate WebKitHitTestResultPrivate; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88177] trunk/Tools
Title: [88177] trunk/Tools Revision 88177 Author x...@webkit.org Date 2011-06-06 11:51:32 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Xan Lopez Reviewed by Martin Robinson. [GTK] Enable feature/symbol detection in NWRT/GTK https://bugs.webkit.org/show_bug.cgi?id=62136 Disable feature detection through DRT, since we don't support it, and set the libwebcore patch correctly so that symbol detection through 'nm' works. * Scripts/webkitpy/layout_tests/port/gtk.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py Diff Modified: trunk/Tools/ChangeLog (88176 => 88177) --- trunk/Tools/ChangeLog 2011-06-06 18:43:40 UTC (rev 88176) +++ trunk/Tools/ChangeLog 2011-06-06 18:51:32 UTC (rev 88177) @@ -1,3 +1,16 @@ +2011-06-06 Xan Lopez + +Reviewed by Martin Robinson. + +[GTK] Enable feature/symbol detection in NWRT/GTK +https://bugs.webkit.org/show_bug.cgi?id=62136 + +Disable feature detection through DRT, since we don't support it, +and set the libwebcore patch correctly so that symbol detection +through 'nm' works. + +* Scripts/webkitpy/layout_tests/port/gtk.py: + 2011-06-06 Shishir Agrawal Reviewed by Tony Gentilcore. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (88176 => 88177) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-06-06 18:43:40 UTC (rev 88176) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-06-06 18:51:32 UTC (rev 88177) @@ -103,3 +103,20 @@ def _is_redhat_based(self): return self._filesystem.exists(self._filesystem.join('/etc', 'redhat-release')) + +def _path_to_webcore_library(self): +gtk_library_names = [ +"libwebkitgtk-1.0.so", +"libwebkitgtk-3.0.so", +"libwebkit2gtk-1.0.so", +] + +for library in gtk_library_names: +full_library = self._build_path(".libs", library) +if os.path.isfile(full_library): +return full_library + +return None + +def _runtime_feature_list(self): +return None ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87830] trunk/Source/WebKit/gtk
Title: [87830] trunk/Source/WebKit/gtk Revision 87830 Author x...@webkit.org Date 2011-06-01 11:38:35 -0700 (Wed, 01 Jun 2011) Log Message 2011-06-01 Xan Lopez Reviewed by Martin Robinson. Explictly request the size of a pointer in malloc. Otherwise this explodes in 64bit architectures, at least. * webkit/webkitwebplugin.cpp: (webkit_web_plugin_get_mimetypes): ditto. Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/webkit/webkitwebplugin.cpp Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (87829 => 87830) --- trunk/Source/WebKit/gtk/ChangeLog 2011-06-01 18:36:13 UTC (rev 87829) +++ trunk/Source/WebKit/gtk/ChangeLog 2011-06-01 18:38:35 UTC (rev 87830) @@ -2,6 +2,16 @@ Reviewed by Martin Robinson. +Explictly request the size of a pointer in malloc. Otherwise this +explodes in 64bit architectures, at least. + +* webkit/webkitwebplugin.cpp: +(webkit_web_plugin_get_mimetypes): ditto. + +2011-06-01 Xan Lopez + +Reviewed by Martin Robinson. + [GTK] Utility methods for UA spellchecking https://bugs.webkit.org/show_bug.cgi?id=61788 Modified: trunk/Source/WebKit/gtk/webkit/webkitwebplugin.cpp (87829 => 87830) --- trunk/Source/WebKit/gtk/webkit/webkitwebplugin.cpp 2011-06-01 18:36:13 UTC (rev 87829) +++ trunk/Source/WebKit/gtk/webkit/webkitwebplugin.cpp 2011-06-01 18:38:35 UTC (rev 87830) @@ -241,7 +241,7 @@ mimeType->description = g_strdup(it->second.utf8().data()); Vector extensions = priv->corePlugin->mimeToExtensions().get(it->first); -mimeType->extensions = static_cast(g_malloc0(extensions.size() + 1)); +mimeType->extensions = static_cast(g_malloc0(sizeof(char*) * (extensions.size() + 1))); for (unsigned i = 0; i < extensions.size(); i++) mimeType->extensions[i] = g_strdup(extensions[i].utf8().data()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87823] trunk/Source/WebKit/gtk
Title: [87823] trunk/Source/WebKit/gtk Revision 87823 Author x...@webkit.org Date 2011-06-01 10:41:25 -0700 (Wed, 01 Jun 2011) Log Message 2011-06-01 Xan Lopez Reviewed by Martin Robinson. [GTK] Utility methods for UA spellchecking https://bugs.webkit.org/show_bug.cgi?id=61788 Adds a couple of utility methods needed to implement some aspects of spell checking support in a browser. * webkit/webkitwebframe.cpp: (webkit_web_frame_replace_selection): method to replace the current selection with a string of text. (webkit_web_frame_get_range_for_word_around_caret): returns the DOM range for the word where the caret/selection currently is. * webkit/webkitwebframe.h: declare new methods. Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/webkit/webkitwebframe.cpp trunk/Source/WebKit/gtk/webkit/webkitwebframe.h Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (87822 => 87823) --- trunk/Source/WebKit/gtk/ChangeLog 2011-06-01 17:36:56 UTC (rev 87822) +++ trunk/Source/WebKit/gtk/ChangeLog 2011-06-01 17:41:25 UTC (rev 87823) @@ -1,3 +1,20 @@ +2011-06-01 Xan Lopez + +Reviewed by Martin Robinson. + +[GTK] Utility methods for UA spellchecking +https://bugs.webkit.org/show_bug.cgi?id=61788 + +Adds a couple of utility methods needed to implement some aspects +of spell checking support in a browser. + +* webkit/webkitwebframe.cpp: +(webkit_web_frame_replace_selection): method to replace the current +selection with a string of text. +(webkit_web_frame_get_range_for_word_around_caret): returns the DOM +range for the word where the caret/selection currently is. +* webkit/webkitwebframe.h: declare new methods. + 2011-05-31 Martin Robinson Reviewed by Gustavo Noronha Silva. Modified: trunk/Source/WebKit/gtk/webkit/webkitwebframe.cpp (87822 => 87823) --- trunk/Source/WebKit/gtk/webkit/webkitwebframe.cpp 2011-06-01 17:36:56 UTC (rev 87822) +++ trunk/Source/WebKit/gtk/webkit/webkitwebframe.cpp 2011-06-01 17:41:25 UTC (rev 87823) @@ -31,10 +31,12 @@ #include "AccessibilityObjectWrapperAtk.h" #include "AnimationController.h" #include "DOMObjectCache.h" +#include "DocumentFragment.h" #include "DocumentLoader.h" #include "DocumentLoaderGtk.h" #include "FrameLoader.h" #include "FrameLoaderClientGtk.h" +#include "FrameSelection.h" #include "FrameTree.h" #include "FrameView.h" #include "GCController.h" @@ -49,8 +51,12 @@ #include "RenderListItem.h" #include "RenderTreeAsText.h" #include "RenderView.h" +#include "ReplaceSelectionCommand.h" #include "ScriptController.h" #include "SubstituteData.h" +#include "TextIterator.h" +#include "markup.h" +#include "webkit/WebKitDOMRangePrivate.h" #include "webkitenumtypes.h" #include "webkitglobalsprivate.h" #include "webkitmarshal.h" @@ -974,6 +980,51 @@ return kitNew(loader->response()); } +/** + * webkit_web_frame_replace_selection: + * @frame: a #WebKitWeFrame + * @text: the text to insert in place of the current selection + * + * Replaces the current selection in @frame, if any, with @text. + * + * Since: 1.5.1 + **/ +void webkit_web_frame_replace_selection(WebKitWebFrame* frame, const char* text) +{ +Frame* coreFrame = core(frame); +RefPtr fragment = createFragmentFromText( +coreFrame->selection()->toNormalizedRange().get(), text); +applyCommand(ReplaceSelectionCommand::create(coreFrame->document(), fragment.get(), + ReplaceSelectionCommand::SmartReplace | ReplaceSelectionCommand::MatchStyle | ReplaceSelectionCommand::PreventNesting)); +} + +/** + * webkit_web_frame_get_range_for_word_around_caret: + * @frame: a #WebKitWebFrame + * + * Returns a #WebKitDOMRange for the word where the caret is currently + * positioned. + * + * Returns: a #WebKitDOMRange spanning the word where the caret + * currently is positioned. If there is no caret %NULL will be + * returned. + * + * Since: 1.5.1. + **/ +WebKitDOMRange* webkit_web_frame_get_range_for_word_around_caret(WebKitWebFrame* frame) +{ +g_return_val_if_fail(WEBKIT_IS_WEB_FRAME(frame), 0); + +Frame* coreFrame = core(frame); +FrameSelection* selection = coreFrame->selection(); +if (selection->isNone() || selection->isRange()) +return 0; +VisibleSelection visibleSelection(selection->selection().visibleStart()); +visibleSelection.expandUsingGranularity(WordGranularity); + +return kit(visibleSelection.firstRange().get()); +} + namespace WebKit { WebKitWebView* getViewFromFrame(WebKitWebFrame* frame) Modified:
[webkit-changes] [87742] trunk
Title: [87742] trunk Revision 87742 Author x...@webkit.org Date 2011-05-31 11:14:24 -0700 (Tue, 31 May 2011) Log Message 2011-05-31 Xan Lopez Reviewed by Martin Robinson. Bump version to 1.5.1. * configure.ac: Modified Paths trunk/ChangeLog trunk/configure.ac Diff Modified: trunk/ChangeLog (87741 => 87742) --- trunk/ChangeLog 2011-05-31 18:10:12 UTC (rev 87741) +++ trunk/ChangeLog 2011-05-31 18:14:24 UTC (rev 87742) @@ -1,3 +1,11 @@ +2011-05-31 Xan Lopez + +Reviewed by Martin Robinson. + +Bump version to 1.5.1. + +* configure.ac: + 2011-05-25 Gregg Tavares Reviewed by Kenneth Russell. Modified: trunk/configure.ac (87741 => 87742) --- trunk/configure.ac 2011-05-31 18:10:12 UTC (rev 87741) +++ trunk/configure.ac 2011-05-31 18:14:24 UTC (rev 87742) @@ -2,7 +2,7 @@ m4_define([webkit_major_version], [1]) m4_define([webkit_minor_version], [5]) -m4_define([webkit_micro_version], [0]) +m4_define([webkit_micro_version], [1]) # This is the version we'll be using as part of our User-Agent string # e.g., AppleWebKit/$(webkit_user_agent_version) ... @@ -35,7 +35,7 @@ dnl # Libtool library version, not to confuse with API version dnl # see http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html -LIBWEBKITGTK_VERSION=6:0:6 +LIBWEBKITGTK_VERSION=8:0:8 AC_SUBST([LIBWEBKITGTK_VERSION]) AM_INIT_AUTOMAKE([foreign subdir-objects tar-ustar]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87741] trunk/Source
Title: [87741] trunk/Source Revision 87741 Author x...@webkit.org Date 2011-05-31 11:10:12 -0700 (Tue, 31 May 2011) Log Message 2011-05-31 Xan Lopez Reviewed by Martin Robinson. [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited https://bugs.webkit.org/show_bug.cgi?id=61791 * bindings/gobject/GNUmakefile.am: add new files. * bindings/gobject/WebKitDOMCustom.cpp: Added. (webkit_dom_html_text_area_element_is_edited): (webkit_dom_html_input_element_is_edited): * bindings/gobject/WebKitDOMCustom.h: Added. 2011-05-31 Xan Lopez Reviewed by Martin Robinson. [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited https://bugs.webkit.org/show_bug.cgi?id=61791 * GNUmakefile.am: add new files. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/gobject/GNUmakefile.am trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/GNUmakefile.am Added Paths trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h Diff Modified: trunk/Source/WebCore/ChangeLog (87740 => 87741) --- trunk/Source/WebCore/ChangeLog 2011-05-31 17:55:20 UTC (rev 87740) +++ trunk/Source/WebCore/ChangeLog 2011-05-31 18:10:12 UTC (rev 87741) @@ -1,3 +1,16 @@ +2011-05-31 Xan Lopez + +Reviewed by Martin Robinson. + +[GTK] Provide custom DOM bindings methods to check if input/textareas have been edited +https://bugs.webkit.org/show_bug.cgi?id=61791 + +* bindings/gobject/GNUmakefile.am: add new files. +* bindings/gobject/WebKitDOMCustom.cpp: Added. +(webkit_dom_html_text_area_element_is_edited): +(webkit_dom_html_input_element_is_edited): +* bindings/gobject/WebKitDOMCustom.h: Added. + 2011-05-31 Noam Rosenthal Unreviewed build fix for Symbian. Modified: trunk/Source/WebCore/bindings/gobject/GNUmakefile.am (87740 => 87741) --- trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2011-05-31 17:55:20 UTC (rev 87740) +++ trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2011-05-31 18:10:12 UTC (rev 87741) @@ -365,6 +365,7 @@ DerivedSources/webkit/WebKitDOMDOMApplicationCache.h \ DerivedSources/webkit/WebKitDOMBarInfo.h \ DerivedSources/webkit/WebKitDOMConsole.h \ + DerivedSources/webkit/WebKitDOMCustom.h \ DerivedSources/webkit/WebKitDOMDOMWindow.h \ DerivedSources/webkit/WebKitDOMDOMSelection.h \ DerivedSources/webkit/WebKitDOMEventTarget.h \ @@ -409,7 +410,7 @@ endif gdom_class_list := $(subst WebKitDOM,, $(filter-out %Private, $(basename $(notdir $(webkitgtk_gdom_built_sources) -gdom_class_list += Object EventTarget +gdom_class_list += Custom EventTarget Object DerivedSources/webkit/webkitdom.h: $(WebCore)/bindings/scripts/gobject-generate-headers.pl $(WebCore)/bindings/gobject/GNUmakefile.am $(AM_V_GEN)echo $(gdom_class_list) | $(PERL) $< gdom > $@ @@ -430,6 +431,9 @@ $(top_builddir)/DerivedSources/webkit/WebKitDOMEventTargetPrivate.h: $(WebCore)/bindings/gobject/WebKitDOMEventTargetPrivate.h $(AM_V_GEN)cp -f $< $@ +$(top_builddir)/DerivedSources/webkit/WebKitDOMCustom.h: $(WebCore)/bindings/gobject/WebKitDOMCustom.h + $(AM_V_GEN)cp -f $< $@ + # Filter out SVG for now gdom_feature_defines := $(filter-out ENABLE_INDEXED_DATABASE=1, $(filter-out ENABLE_SVG%, $(FEATURE_DEFINES))) DerivedSources/webkit/WebKitDOM%.cpp DerivedSources/webkit/WebKitDOM%.h DerivedSources/webkit/WebKitDOM%Private.h:: %.idl $(SCRIPTS_BINDINGS) $(WebCore)/bindings/scripts/CodeGeneratorGObject.pm $(WebCore)/bindings/gobject/GNUmakefile.am Added: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp (0 => 87741) --- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp (rev 0) +++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp 2011-05-31 18:10:12 UTC (rev 87741) @@ -0,0 +1,42 @@ +/* + * Copyright (C) 2011 Igalia S.L. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include "config.h" +#include "WebKitDOMCustom.h" + +#include "WebKitDOMHTMLInputElement.h" +#inc
[webkit-changes] [86957] trunk/Source/JavaScriptCore
Title: [86957] trunk/Source/_javascript_Core Revision 86957 Author x...@webkit.org Date 2011-05-20 08:55:16 -0700 (Fri, 20 May 2011) Log Message 2011-05-20 Xan Lopez Reviewed by Oliver Hunt. JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap? https://bugs.webkit.org/show_bug.cgi?id=42756 Use the MAP_NORESERVE flag for mmap on Linux to skip the kernel check of the available memory. This should give us an overcommit-like behavior in most systems, which is what we want. * wtf/OSAllocatorPosix.cpp: (WTF::OSAllocator::reserveAndCommit): pass MAP_NORSERVE to mmap. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/OSAllocatorPosix.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (86956 => 86957) --- trunk/Source/_javascript_Core/ChangeLog 2011-05-20 15:50:55 UTC (rev 86956) +++ trunk/Source/_javascript_Core/ChangeLog 2011-05-20 15:55:16 UTC (rev 86957) @@ -1,3 +1,17 @@ +2011-05-20 Xan Lopez + +Reviewed by Oliver Hunt. + +JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap? +https://bugs.webkit.org/show_bug.cgi?id=42756 + +Use the MAP_NORESERVE flag for mmap on Linux to skip the kernel +check of the available memory. This should give us an +overcommit-like behavior in most systems, which is what we want. + +* wtf/OSAllocatorPosix.cpp: +(WTF::OSAllocator::reserveAndCommit): pass MAP_NORSERVE to mmap. + 2011-05-19 Gabor Loki Fix ARM build after r86919 Modified: trunk/Source/_javascript_Core/wtf/OSAllocatorPosix.cpp (86956 => 86957) --- trunk/Source/_javascript_Core/wtf/OSAllocatorPosix.cpp 2011-05-20 15:50:55 UTC (rev 86956) +++ trunk/Source/_javascript_Core/wtf/OSAllocatorPosix.cpp 2011-05-20 15:55:16 UTC (rev 86957) @@ -55,6 +55,18 @@ int flags = MAP_PRIVATE | MAP_ANON; +#if OS(LINUX) +// Linux distros usually do not allow overcommit by default, so +// JSC's strategy of mmaping a large amount of memory upfront +// won't work very well on some systems. Fortunately there's a +// flag we can pass to mmap to disable the overcommit check for +// this particular call, so we can get away with it as long as the +// overcommit flag value in /proc/sys/vm/overcommit_memory is 0 +// ('heuristic') and not 2 (always check). 0 is the usual default +// value, so this should work well in general. +flags |= MAP_NORESERVE; +#endif + #if OS(DARWIN) int fd = usage; #else ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes