[webkit-changes] [120265] trunk/Source/WebCore
Title: [120265] trunk/Source/WebCore
Revision 120265
Author yael.aha...@nokia.com
Date 2012-06-13 19:03:56 -0700 (Wed, 13 Jun 2012)
Log Message
Remove redundant code from RenderView and RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=89019
Reviewed by Abhishek Arya.
As pointed out in https://bugs.webkit.org/show_bug.cgi?id=83981#c7 , RenderView::insertFixedPositionedObject()
is redundant and should be removed.
No new tests.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
* rendering/RenderView.cpp:
(WebCore):
* rendering/RenderView.h:
(RenderView):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (120264 => 120265)
--- trunk/Source/WebCore/ChangeLog 2012-06-14 00:40:40 UTC (rev 120264)
+++ trunk/Source/WebCore/ChangeLog 2012-06-14 02:03:56 UTC (rev 120265)
@@ -1,3 +1,22 @@
+2012-06-13 Yael Aharon yael.aha...@nokia.com
+
+Remove redundant code from RenderView and RenderBlock
+https://bugs.webkit.org/show_bug.cgi?id=89019
+
+Reviewed by Abhishek Arya.
+
+As pointed out in https://bugs.webkit.org/show_bug.cgi?id=83981#c7 , RenderView::insertFixedPositionedObject()
+is redundant and should be removed.
+No new tests.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::insertPositionedObject):
+(WebCore::RenderBlock::removePositionedObject):
+* rendering/RenderView.cpp:
+(WebCore):
+* rendering/RenderView.h:
+(RenderView):
+
2012-06-13 Dana Jansens dan...@chromium.org
[chromium] Create a CCStreamVideoDrawQuad used for StreamTexture video output
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (120264 => 120265)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2012-06-14 00:40:40 UTC (rev 120264)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2012-06-14 02:03:56 UTC (rev 120265)
@@ -3509,18 +3509,12 @@
m_positionedObjects = adoptPtr(new PositionedObjectsListHashSet);
m_positionedObjects-add(o);
-
-if (o-style()-position() == FixedPosition view())
-view()-insertFixedPositionedObject(o);
}
void RenderBlock::removePositionedObject(RenderBox* o)
{
if (m_positionedObjects)
m_positionedObjects-remove(o);
-
-if (view())
-view()-removeFixedPositionedObject(o);
}
void RenderBlock::removePositionedObjects(RenderBlock* o)
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (120264 => 120265)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2012-06-14 00:40:40 UTC (rev 120264)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2012-06-14 02:03:56 UTC (rev 120265)
@@ -945,20 +945,4 @@
}
}
-void RenderView::insertFixedPositionedObject(RenderBox* object)
-{
-if (!m_positionedObjects)
-m_positionedObjects = adoptPtr(new PositionedObjectsListHashSet);
-
-m_positionedObjects-add(object);
-}
-
-void RenderView::removeFixedPositionedObject(RenderBox* object)
-{
-if (!m_positionedObjects)
-return;
-
-m_positionedObjects-remove(object);
-}
-
} // namespace WebCore
Modified: trunk/Source/WebCore/rendering/RenderView.h (120264 => 120265)
--- trunk/Source/WebCore/rendering/RenderView.h 2012-06-14 00:40:40 UTC (rev 120264)
+++ trunk/Source/WebCore/rendering/RenderView.h 2012-06-14 02:03:56 UTC (rev 120265)
@@ -183,8 +183,6 @@
IntSize viewportSize() const { return document()-viewportSize(); }
void setFixedPositionedObjectsNeedLayout();
-void insertFixedPositionedObject(RenderBox*);
-void removeFixedPositionedObject(RenderBox*);
protected:
virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool useTransforms, bool fixed, TransformState, ApplyContainerFlipOrNot = ApplyContainerFlip, bool* wasFixed = 0) const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118398] trunk
Title: [118398] trunk
Revision 118398
Author yael.aha...@nokia.com
Date 2012-05-24 11:54:16 -0700 (Thu, 24 May 2012)
Log Message
[Qt] Stop using the flag FIXED_POSITION_CREATES_STACKING_CONTEXT
https://bugs.webkit.org/show_bug.cgi?id=87392
Reviewed by Antonio Gomes.
Source/WebCore:
Remove our dependency on a build flag and use the new setting.
No new tests.
* css/StyleResolver.cpp:
Source/WebKit2:
Turn on the setting setFixedPositionCreatesStackingContext.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
LayoutTests:
Update test expectations, since now don't turn on the setting when running layout tests.
* platform/qt/fast/block/positioning/016-expected.txt:
* platform/qt/fast/block/positioning/025-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/qt/fast/block/positioning/025-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (118397 => 118398)
--- trunk/LayoutTests/ChangeLog 2012-05-24 18:42:58 UTC (rev 118397)
+++ trunk/LayoutTests/ChangeLog 2012-05-24 18:54:16 UTC (rev 118398)
@@ -1,3 +1,15 @@
+2012-05-24 Yael Aharon yael.aha...@nokia.com
+
+[Qt] Stop using the flag FIXED_POSITION_CREATES_STACKING_CONTEXT
+https://bugs.webkit.org/show_bug.cgi?id=87392
+
+Reviewed by Antonio Gomes.
+
+Update test expectations, since now don't turn on the setting when running layout tests.
+
+* platform/qt/fast/block/positioning/016-expected.txt:
+* platform/qt/fast/block/positioning/025-expected.txt:
+
2012-05-24 Robert Hogan rob...@webkit.org
Negative margin block doesn't properly clear a float enclosed by a previous sibling
Modified: trunk/LayoutTests/platform/qt/fast/block/positioning/016-expected.txt (118397 => 118398)
--- trunk/LayoutTests/platform/qt/fast/block/positioning/016-expected.txt 2012-05-24 18:42:58 UTC (rev 118397)
+++ trunk/LayoutTests/platform/qt/fast/block/positioning/016-expected.txt 2012-05-24 18:54:16 UTC (rev 118398)
@@ -8,6 +8,6 @@
layer at (0,0) size 100x100
RenderBlock (positioned) zI: 1 {DIV} at (0,0) size 100x100 [bgcolor=#FF]
layer at (0,0) size 100x100
+ RenderBlock (positioned) zI: 1 {DIV} at (0,0) size 100x100 [bgcolor=#FF]
+layer at (0,0) size 100x100
RenderBlock (positioned) zI: 2 {DIV} at (0,0) size 100x100 [bgcolor=#008000]
-layer at (0,0) size 100x100
- RenderBlock (positioned) zI: 1 {DIV} at (0,0) size 100x100 [bgcolor=#FF]
Modified: trunk/LayoutTests/platform/qt/fast/block/positioning/025-expected.txt (118397 => 118398)
--- trunk/LayoutTests/platform/qt/fast/block/positioning/025-expected.txt 2012-05-24 18:42:58 UTC (rev 118397)
+++ trunk/LayoutTests/platform/qt/fast/block/positioning/025-expected.txt 2012-05-24 18:54:16 UTC (rev 118398)
@@ -1,10 +1,10 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x8
+layer at (0,0) size 800x8 layerType: background only
+layer at (0,0) size 100x100
+ RenderBlock (positioned) zI: -1 {DIV} at (0,0) size 100x100 [bgcolor=#FF]
+layer at (0,0) size 800x8 layerType: foreground only
RenderBlock {HTML} at (0,0) size 800x8
RenderBody {BODY} at (8,8) size 784x0
-layer at (0,0) size 100x100 layerType: background only
layer at (0,0) size 100x100
- RenderBlock (positioned) zI: -1 {DIV} at (0,0) size 100x100 [bgcolor=#FF]
-layer at (0,0) size 100x100 layerType: foreground only
RenderBlock (positioned) {DIV} at (0,0) size 100x100 [bgcolor=#008000]
Modified: trunk/Source/WebCore/ChangeLog (118397 => 118398)
--- trunk/Source/WebCore/ChangeLog 2012-05-24 18:42:58 UTC (rev 118397)
+++ trunk/Source/WebCore/ChangeLog 2012-05-24 18:54:16 UTC (rev 118398)
@@ -1,3 +1,16 @@
+2012-05-24 Yael Aharon yael.aha...@nokia.com
+
+[Qt] Stop using the flag FIXED_POSITION_CREATES_STACKING_CONTEXT
+https://bugs.webkit.org/show_bug.cgi?id=87392
+
+Reviewed by Antonio Gomes.
+
+Remove our dependency on a build flag and use the new setting.
+
+No new tests.
+
+* css/StyleResolver.cpp:
+
2012-05-24 Alexey Proskuryakov a...@apple.com
[WK2] Let the client give local files universal access on a case by case basis
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (118397 => 118398)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2012-05-24 18:42:58 UTC (rev 118397)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-05-24 18:54:16 UTC (rev 118398)
@@ -150,7 +150,7 @@
#include StyleCachedImageSet.h
#endif
-#if PLATFORM(QT) || PLATFORM(BLACKBERRY)
+#if PLATFORM(BLACKBERRY)
#define FIXED_POSITION_CREATES_STACKING_CONTEXT 1
#endif
Modified: trunk/Source/WebKit2/ChangeLog (118397 => 118398)
--- tr
[webkit-changes] [115696] trunk/Source/WebKit2
Title: [115696] trunk/Source/WebKit2 Revision 115696 Author yael.aha...@nokia.com Date 2012-04-30 18:10:35 -0700 (Mon, 30 Apr 2012) Log Message [Qt][WK2] Fixed layers are shaking when zoom level is not 1.0 due to a rounding error. https://bugs.webkit.org/show_bug.cgi?id=84306 Reviewed by Noam Rosenthal. When zooming, we need to be careful about how to convert the visible rect from float to int. Using toAlignedRect can produce inconsistent width and height when we are scrolling. This patch carefully modifies each piece of the visible rect, to avoid such rounding errors. In addition, the TransformationMatrix we use for painting, needs to be adjusted for the same rounding error. * UIProcess/API/qt/qquickwebview.cpp: (QQuickWebViewPrivate::visibleContentsRect): (QQuickWebViewFlickablePrivate::_q_contentViewportChanged): * UIProcess/DrawingAreaProxy.h: (WebCore): (WebKit::DrawingAreaProxy::setVisibleContentsRect): * UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::setVisibleContentsRect): * UIProcess/DrawingAreaProxyImpl.h: (DrawingAreaProxyImpl): * UIProcess/LayerTreeHostProxy.cpp: (WebKit::LayerTreeHostProxy::setVisibleContentsRect): * UIProcess/LayerTreeHostProxy.h: (LayerTreeHostProxy): * UIProcess/WebLayerTreeRenderer.cpp: (WebKit::WebLayerTreeRenderer::paintToCurrentGLContext): (WebKit::WebLayerTreeRenderer::setVisibleContentsRect): * UIProcess/WebLayerTreeRenderer.h: (WebLayerTreeRenderer): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.h trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.h Diff Modified: trunk/Source/WebKit2/ChangeLog (115695 => 115696) --- trunk/Source/WebKit2/ChangeLog 2012-05-01 00:52:01 UTC (rev 115695) +++ trunk/Source/WebKit2/ChangeLog 2012-05-01 01:10:35 UTC (rev 115696) @@ -1,3 +1,35 @@ +2012-04-30 Yael Aharon yael.aha...@nokia.com + +[Qt][WK2] Fixed layers are shaking when zoom level is not 1.0 due to a rounding error. +https://bugs.webkit.org/show_bug.cgi?id=84306 + +Reviewed by Noam Rosenthal. + +When zooming, we need to be careful about how to convert the visible rect from float to int. +Using toAlignedRect can produce inconsistent width and height when we are scrolling. +This patch carefully modifies each piece of the visible rect, to avoid such rounding errors. +In addition, the TransformationMatrix we use for painting, needs to be adjusted for the same rounding error. + +* UIProcess/API/qt/qquickwebview.cpp: +(QQuickWebViewPrivate::visibleContentsRect): +(QQuickWebViewFlickablePrivate::_q_contentViewportChanged): +* UIProcess/DrawingAreaProxy.h: +(WebCore): +(WebKit::DrawingAreaProxy::setVisibleContentsRect): +* UIProcess/DrawingAreaProxyImpl.cpp: +(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect): +* UIProcess/DrawingAreaProxyImpl.h: +(DrawingAreaProxyImpl): +* UIProcess/LayerTreeHostProxy.cpp: +(WebKit::LayerTreeHostProxy::setVisibleContentsRect): +* UIProcess/LayerTreeHostProxy.h: +(LayerTreeHostProxy): +* UIProcess/WebLayerTreeRenderer.cpp: +(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext): +(WebKit::WebLayerTreeRenderer::setVisibleContentsRect): +* UIProcess/WebLayerTreeRenderer.h: +(WebLayerTreeRenderer): + 2012-04-30 Anders Carlsson ander...@apple.com ScrollingCoordinator::requestScrollPositionUpdate should not update the main frame scroll position Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (115695 => 115696) --- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-05-01 00:52:01 UTC (rev 115695) +++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-05-01 01:10:35 UTC (rev 115696) @@ -545,7 +545,9 @@ Q_Q(const QQuickWebView); const QRectF visibleRect(q-boundingRect().intersected(pageView-boundingRect())); -return q-mapRectToWebContent(visibleRect).toAlignedRect(); +// We avoid using toAlignedRect() because it produces inconsistent width and height. +QRectF mappedRect(q-mapRectToWebContent(visibleRect)); +return QRect(floor(mappedRect.x()), floor(mappedRect.y()), floor(mappedRect.width()), floor(mappedRect.height())); } WebCore::IntSize QQuickWebViewPrivate::viewSize() const @@ -780,7 +782,9 @@ const QRect visibleRect(visibleContentsRect()); float scale = pageView-contentsScale(); -drawingArea-setVisibleContentsRect(visibleRect, scale, trajectoryVector); +QRectF accurateVisibleRect(q-boundi
[webkit-changes] [115426] trunk/Source/WebKit2
Title: [115426] trunk/Source/WebKit2
Revision 115426
Author yael.aha...@nokia.com
Date 2012-04-27 07:12:51 -0700 (Fri, 27 Apr 2012)
Log Message
[Qt][WK2] setVisibleContentsRect is not thread safe
https://bugs.webkit.org/show_bug.cgi?id=85060
Reviewed by Noam Rosenthal.
Don't call WebLayerTreeRenderer::setVisibleContentsRect directly. Use bind() instead.
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::setVisibleContentsRect):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (115425 => 115426)
--- trunk/Source/WebKit2/ChangeLog 2012-04-27 14:10:59 UTC (rev 115425)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-27 14:12:51 UTC (rev 115426)
@@ -1,3 +1,15 @@
+2012-04-27 Yael Aharon yael.aha...@nokia.com
+
+[Qt][WK2] setVisibleContentsRect is not thread safe
+https://bugs.webkit.org/show_bug.cgi?id=85060
+
+Reviewed by Noam Rosenthal.
+
+Don't call WebLayerTreeRenderer::setVisibleContentsRect directly. Use bind() instead.
+
+* UIProcess/LayerTreeHostProxy.cpp:
+(WebKit::LayerTreeHostProxy::setVisibleContentsRect):
+
2012-04-26 Carlos Garcia Campos cgar...@igalia.com
[SOUP] Add a way to register custom uri schemes in WebKit2
Modified: trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp (115425 => 115426)
--- trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp 2012-04-27 14:10:59 UTC (rev 115425)
+++ trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp 2012-04-27 14:12:51 UTC (rev 115426)
@@ -129,7 +129,7 @@
void LayerTreeHostProxy::setVisibleContentsRect(const IntRect rect, float scale, const FloatPoint trajectoryVector)
{
-m_renderer-setVisibleContentsRect(rect, scale);
+dispatchUpdate(bind(WebLayerTreeRenderer::setVisibleContentsRect, m_renderer.get(), rect, scale));
m_drawingAreaProxy-page()-process()-send(Messages::LayerTreeHost::SetVisibleContentsRect(rect, scale, trajectoryVector), m_drawingAreaProxy-page()-pageID());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115515] trunk/Source/WebKit2
Title: [115515] trunk/Source/WebKit2 Revision 115515 Author yael.aha...@nokia.com Date 2012-04-27 16:48:57 -0700 (Fri, 27 Apr 2012) Log Message [Qt][WK2] Don't call syncRemoteContents from WebLayerTreeRenderer::paintToCurrentGLContext https://bugs.webkit.org/show_bug.cgi?id=85088 Reviewed by Noam Rosenthal. Remove the call to syncRemoteContents from WebLayerTreeRenderer::paintToCurrentGLContext, since it was moved to QQuickWebPage::updatePaintNode. To make sure that we always sync before painting, this patch also calls page-update() when the viewport changes. * UIProcess/API/qt/qquickwebview.cpp: (QQuickWebViewFlickablePrivate::_q_contentViewportChanged): * UIProcess/WebLayerTreeRenderer.cpp: (WebKit::WebLayerTreeRenderer::paintToCurrentGLContext): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (115514 => 115515) --- trunk/Source/WebKit2/ChangeLog 2012-04-27 23:31:58 UTC (rev 115514) +++ trunk/Source/WebKit2/ChangeLog 2012-04-27 23:48:57 UTC (rev 115515) @@ -1,3 +1,20 @@ +2012-04-27 Yael Aharon yael.aha...@nokia.com + +[Qt][WK2] Don't call syncRemoteContents from WebLayerTreeRenderer::paintToCurrentGLContext +https://bugs.webkit.org/show_bug.cgi?id=85088 + +Reviewed by Noam Rosenthal. + +Remove the call to syncRemoteContents from WebLayerTreeRenderer::paintToCurrentGLContext, +since it was moved to QQuickWebPage::updatePaintNode. +To make sure that we always sync before painting, this patch also calls page-update() +when the viewport changes. + +* UIProcess/API/qt/qquickwebview.cpp: +(QQuickWebViewFlickablePrivate::_q_contentViewportChanged): +* UIProcess/WebLayerTreeRenderer.cpp: +(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext): + 2012-04-27 Gavin Peters gav...@chromium.org Add new ENABLE_LINK_PRERENDER define to control the Prerendering API Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (115514 => 115515) --- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-04-27 23:31:58 UTC (rev 115514) +++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-04-27 23:48:57 UTC (rev 115515) @@ -781,6 +781,9 @@ float scale = pageView-contentsScale(); drawingArea-setVisibleContentsRect(visibleRect, scale, trajectoryVector); + +// Ensure that updatePaintNode is always called before painting. +pageView-update(); } void QQuickWebViewFlickablePrivate::_q_suspend() Modified: trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp (115514 => 115515) --- trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp 2012-04-27 23:31:58 UTC (rev 115514) +++ trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp 2012-04-27 23:48:57 UTC (rev 115515) @@ -109,7 +109,6 @@ m_textureMapper = TextureMapper::create(TextureMapper::OpenGLMode); ASSERT(m_textureMapper-accelerationMode() == TextureMapper::OpenGLMode); -syncRemoteContent(); adjustPositionForFixedLayers(); GraphicsLayer* currentRootLayer = rootLayer(); if (!currentRootLayer) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115011] trunk/Source
Title: [115011] trunk/Source
Revision 115011
Author yael.aha...@nokia.com
Date 2012-04-24 01:35:44 -0700 (Tue, 24 Apr 2012)
Log Message
[Qt] Move notification icon download out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=80700
Reviewed by Simon Hausmann.
Source/WebCore:
Remove the code that downloads the notification's icon out of WebCore.
Other ports let the client decide if to download the icon or not.
No new tests. This patch is only removing code.
* notifications/Notification.cpp:
(WebCore::Notification::~Notification):
(WebCore::Notification::show):
(WebCore::Notification::close):
(WebCore::Notification::contextDestroyed):
* notifications/Notification.h:
(Notification):
Source/WebKit/qt:
Remove the code that handles the notification's icon and use the icon url instead.
The display event has to be asynchronous, so a timer was added to achieve that.
The platform plugin API and example were updated to reflect this change.
This change does not address the recent changes in web notifications spec.
* Api/qwebkitplatformplugin.h:
(QWebNotificationData):
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationWrapper::sendDisplayEvent):
(WebCore):
(WebCore::NotificationWrapper::iconUrl):
(WebCore::NotificationPresenterClientQt::show):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::sendDisplayEvent):
* WebCoreSupport/NotificationPresenterClientQt.h:
(NotificationWrapper):
(NotificationPresenterClientQt):
* examples/platformplugin/WebNotificationPresenter.cpp:
(WebNotificationWidget::showNotification):
* examples/platformplugin/qwebkitplatformplugin.h:
(QWebNotificationData):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/notifications/Notification.cpp
trunk/Source/WebCore/notifications/Notification.h
trunk/Source/WebKit/qt/Api/qwebkitplatformplugin.h
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h
trunk/Source/WebKit/qt/examples/platformplugin/WebNotificationPresenter.cpp
trunk/Source/WebKit/qt/examples/platformplugin/qwebkitplatformplugin.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (115010 => 115011)
--- trunk/Source/WebCore/ChangeLog 2012-04-24 08:34:25 UTC (rev 115010)
+++ trunk/Source/WebCore/ChangeLog 2012-04-24 08:35:44 UTC (rev 115011)
@@ -1,3 +1,22 @@
+2012-04-24 Yael Aharon yael.aha...@nokia.com
+
+[Qt] Move notification icon download out of WebCore
+https://bugs.webkit.org/show_bug.cgi?id=80700
+
+Reviewed by Simon Hausmann.
+
+Remove the code that downloads the notification's icon out of WebCore.
+Other ports let the client decide if to download the icon or not.
+No new tests. This patch is only removing code.
+
+* notifications/Notification.cpp:
+(WebCore::Notification::~Notification):
+(WebCore::Notification::show):
+(WebCore::Notification::close):
+(WebCore::Notification::contextDestroyed):
+* notifications/Notification.h:
+(Notification):
+
2012-04-24 Rakesh KN rakesh...@motorola.com
RadioNodeList support in HTMLFormElement::elements
Modified: trunk/Source/WebCore/notifications/Notification.cpp (115010 => 115011)
--- trunk/Source/WebCore/notifications/Notification.cpp 2012-04-24 08:34:25 UTC (rev 115010)
+++ trunk/Source/WebCore/notifications/Notification.cpp 2012-04-24 08:35:44 UTC (rev 115011)
@@ -116,10 +116,6 @@
Notification::~Notification()
{
-if (m_state == LoadingIcon) {
-ASSERT_NOT_REACHED();
-close();
-}
}
#if ENABLE(LEGACY_NOTIFICATIONS)
@@ -171,26 +167,11 @@
void Notification::show()
{
-#if PLATFORM(QT)
-if (iconURL().isEmpty()) {
-// Set the state before actually showing, because
-// handling of ondisplay may rely on that.
-if (m_state == Idle) {
-m_state = Showing;
-if (m_notificationCenter-client()) {
-m_notificationCenter-client()-show(this);
-setPendingActivity(this);
-}
-}
-} else
-startLoadingIcon();
-#else
// prevent double-showing
if (m_state == Idle m_notificationCenter-client() m_notificationCenter-client()-show(this)) {
m_state = Showing;
setPendingActivity(this);
}
-#endif
}
void Notification::close()
@@ -198,15 +179,10 @@
switch (m_state) {
case Idle:
break;
-case LoadingIcon:
-m_state = CancelledIcon;
-stopLoadingIcon();
-break;
case Showing:
if (m_notificationCenter-client())
m_notificationCenter-client()-cancel(this);
break;
-case CancelledIcon:
case Closed:
break;
}
@@ -229,66 +205,6 @@
m_notificationCenter-
[webkit-changes] [115134] trunk
Title: [115134] trunk
Revision 115134
Author yael.aha...@nokia.com
Date 2012-04-24 16:43:46 -0700 (Tue, 24 Apr 2012)
Log Message
Fixed background is scrolling in http://www.nieuwecode.nl/ in Qt webkit2
https://bugs.webkit.org/show_bug.cgi?id=83980
Reviewed by Simon Fraser.
.:
* ManualTests/fixed-position-no-z-index.html: Added.
Source/WebCore:
When a fixed position element does not have z-index explicitly specified, it does not create a
stacking context. This results in fixed elements scrolling with the content layer.
This patch creates a stacking context for fixed positioned elements for the Qt port, by enabling
the flag ENABLE_FIXED_POSITION_CREATES_STACKING_CONTEXT.
Added a manual test because this patch takes effect only during scrolling.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Added Paths
trunk/ManualTests/fixed-position-no-z-index.html
Diff
Modified: trunk/ChangeLog (115133 => 115134)
--- trunk/ChangeLog 2012-04-24 23:43:13 UTC (rev 115133)
+++ trunk/ChangeLog 2012-04-24 23:43:46 UTC (rev 115134)
@@ -1,3 +1,12 @@
+2012-04-24 Yael Aharon yael.aha...@nokia.com
+
+Fixed background is scrolling in http://www.nieuwecode.nl/ in Qt webkit2
+https://bugs.webkit.org/show_bug.cgi?id=83980
+
+Reviewed by Simon Fraser.
+
+* ManualTests/fixed-position-no-z-index.html: Added.
+
2012-04-24 Carlos Garcia Campos cgar...@igalia.com
[GTK] Build and run TestWebKitAPI unit tests
Added: trunk/ManualTests/fixed-position-no-z-index.html (0 => 115134)
--- trunk/ManualTests/fixed-position-no-z-index.html (rev 0)
+++ trunk/ManualTests/fixed-position-no-z-index.html 2012-04-24 23:43:46 UTC (rev 115134)
@@ -0,0 +1,25 @@
+html
+head
+style
+.back { z-index: -1; position: absolute; width:1000px; height:1000px;}
+.d1 { position:fixed; top:0; left:0; width:1000px; height:1000px;}
+.d2 { margin: 30px 40% 20px 20%; position: relative; z-index: 5;}
+body { margin: 0px; }
+/style
+/head
+body
+div class=d1img class=back src=""
+/div
+div class=d2
+Lorem ipsum dolor sit amet, consectetuer adipiscing elit. In ornare risus. Aliquam nonummy libero et risus. Vestibulum sit amet massa nec mauris interdum luctus. Nam ut dolor ut nunc malesuada varius. Duis risus. Mauris vel nulla ut odio porta vestibulum. Mauris ac sapien. In a dolor at urna malesuada suscipit. Aenean nisl erat, nonummy quis, blandit in, sagittis et, ligula. Maecenas consequat. Donec nonummy rutrum nibh. Praesent tincidunt cursus mi. Donec adipiscing. Nulla at ipsum. Aenean fermentum.br
+Lorem ipsum dolor sit amet, consectetuer adipiscing elit. In ornare risus. Aliquam nonummy libero et risus. Vestibulum sit amet massa nec mauris interdum luctus. Nam ut dolor ut nunc malesuada varius. Duis risus. Mauris vel nulla ut odio porta vestibulum. Mauris ac sapien. In a dolor at urna malesuada suscipit. Aenean nisl erat, nonummy quis, blandit in, sagittis et, ligula. Maecenas consequat. Donec nonummy rutrum nibh. Praesent tincidunt cursus mi. Donec adipiscing. Nulla at ipsum. Aenean fermentum.br
+Lorem ipsum dolor sit amet, consectetuer adipiscing elit. In ornare risus. Aliquam nonummy libero et risus. Vestibulum sit amet massa nec mauris interdum luctus. Nam ut dolor ut nunc malesuada varius. Duis risus. Mauris vel nulla ut odio porta vestibulum. Mauris ac sapien. In a dolor at urna malesuada suscipit. Aenean nisl erat, nonummy quis, blandit in, sagittis et, ligula. Maecenas consequat. Donec nonummy rutrum nibh. Praesent tincidunt cursus mi. Donec adipiscing. Nulla at ipsum. Aenean fermentum.br
+Lorem ipsum dolor sit amet, consectetuer adipiscing elit. In ornare risus. Aliquam nonummy libero et risus. Vestibulum sit amet massa nec mauris interdum luctus. Nam ut dolor ut nunc malesuada varius. Duis risus. Mauris vel nulla ut odio porta vestibulum. Mauris ac sapien. In a dolor at urna malesuada suscipit. Aenean nisl erat, nonummy quis, blandit in, sagittis et, ligula. Maecenas consequat. Donec nonummy rutrum nibh. Praesent tincidunt cursus mi. Donec adipiscing. Nulla at ipsum. Aenean fermentum.br
+Lorem ipsum dolor sit amet, consectetuer adipiscing elit. In ornare risus. Aliquam nonummy libero et risus. Vestibulum sit amet massa nec mauris interdum luctus. Nam ut dolor ut nunc malesuada varius. Duis risus. Mauris vel nulla ut odio porta vestibulum. Mauris ac sapien. In a dolor at urna malesuada suscipit. Aenean nisl erat, nonummy quis, blandit in, sagittis et, ligula. Maecenas consequat. Donec nonummy rutrum nibh. Praesent tincidunt cursus mi. Donec adipiscing. Nulla at ipsum. Aenean fermentum.br
+Lorem ipsum dolor sit amet, consectetuer adipiscing elit. In ornare risus. Aliquam nonummy libero et risus. Vestibulum sit amet massa nec mauris interdum luctus. Nam ut dolor ut nunc malesuada varius. Duis risus. Mauris v
[webkit-changes] [115150] trunk/LayoutTests
Title: [115150] trunk/LayoutTests
Revision 115150
Author yael.aha...@nokia.com
Date 2012-04-24 17:49:05 -0700 (Tue, 24 Apr 2012)
Log Message
Unreviewed rebaseline after r115134.
* platform/qt/fast/block/positioning/016-expected.txt:
* platform/qt/fast/block/positioning/025-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/qt/fast/block/positioning/025-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (115149 => 115150)
--- trunk/LayoutTests/ChangeLog 2012-04-25 00:47:16 UTC (rev 115149)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 00:49:05 UTC (rev 115150)
@@ -1,3 +1,10 @@
+2012-04-24 Yael Aharon yael.aha...@nokia.com
+
+Unreviewed rebaseline after r115134.
+
+* platform/qt/fast/block/positioning/016-expected.txt:
+* platform/qt/fast/block/positioning/025-expected.txt:
+
2012-04-24 Jeffrey Pfau jp...@apple.com
Prevent drag and drop from setting file URLs
Modified: trunk/LayoutTests/platform/qt/fast/block/positioning/016-expected.txt (115149 => 115150)
--- trunk/LayoutTests/platform/qt/fast/block/positioning/016-expected.txt 2012-04-25 00:47:16 UTC (rev 115149)
+++ trunk/LayoutTests/platform/qt/fast/block/positioning/016-expected.txt 2012-04-25 00:49:05 UTC (rev 115150)
@@ -8,6 +8,6 @@
layer at (0,0) size 100x100
RenderBlock (positioned) zI: 1 {DIV} at (0,0) size 100x100 [bgcolor=#FF]
layer at (0,0) size 100x100
+ RenderBlock (positioned) zI: 2 {DIV} at (0,0) size 100x100 [bgcolor=#008000]
+layer at (0,0) size 100x100
RenderBlock (positioned) zI: 1 {DIV} at (0,0) size 100x100 [bgcolor=#FF]
-layer at (0,0) size 100x100
- RenderBlock (positioned) zI: 2 {DIV} at (0,0) size 100x100 [bgcolor=#008000]
Modified: trunk/LayoutTests/platform/qt/fast/block/positioning/025-expected.txt (115149 => 115150)
--- trunk/LayoutTests/platform/qt/fast/block/positioning/025-expected.txt 2012-04-25 00:47:16 UTC (rev 115149)
+++ trunk/LayoutTests/platform/qt/fast/block/positioning/025-expected.txt 2012-04-25 00:49:05 UTC (rev 115150)
@@ -1,10 +1,10 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x8 layerType: background only
-layer at (0,0) size 100x100
- RenderBlock (positioned) zI: -1 {DIV} at (0,0) size 100x100 [bgcolor=#FF]
-layer at (0,0) size 800x8 layerType: foreground only
+layer at (0,0) size 800x8
RenderBlock {HTML} at (0,0) size 800x8
RenderBody {BODY} at (8,8) size 784x0
+layer at (0,0) size 100x100 layerType: background only
layer at (0,0) size 100x100
+ RenderBlock (positioned) zI: -1 {DIV} at (0,0) size 100x100 [bgcolor=#FF]
+layer at (0,0) size 100x100 layerType: foreground only
RenderBlock (positioned) {DIV} at (0,0) size 100x100 [bgcolor=#008000]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [115153] trunk/LayoutTests
Title: [115153] trunk/LayoutTests Revision 115153 Author yael.aha...@nokia.com Date 2012-04-24 18:10:09 -0700 (Tue, 24 Apr 2012) Log Message [Qt] Move notification icon download out of WebCore https://bugs.webkit.org/show_bug.cgi?id=80700 Reviewed by Jian Li. Remove http/tests/notifications after the code the tests were testing has been removed. * http/tests/notifications: Removed. * http/tests/notifications/icon-does-not-exist-expected.txt: Removed. * http/tests/notifications/icon-does-not-exist.html: Removed. * http/tests/notifications/icon-exists-cancel-expected.txt: Removed. * http/tests/notifications/icon-exists-cancel.html: Removed. * http/tests/notifications/icon-exists-expected.txt: Removed. * http/tests/notifications/icon-exists-show-alert-during-load-expected.txt: Removed. * http/tests/notifications/icon-exists-show-alert-during-load.html: Removed. * http/tests/notifications/icon-exists.html: Removed. * http/tests/notifications/icon-requires-auth-expected.txt: Removed. * http/tests/notifications/icon-requires-auth.html: Removed. * http/tests/notifications/resources: Removed. * http/tests/notifications/resources/icon-exists.png: Removed. * http/tests/notifications/resources/icon-requires-auth.php: Removed. * platform/chromium/test_expectations.txt: * platform/efl/Skipped: * platform/gtk/test_expectations.txt: * platform/mac/Skipped: * platform/qt-5.0-wk2/Skipped: * platform/qt/Skipped: * platform/win/Skipped: * platform/wincairo/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/efl/Skipped trunk/LayoutTests/platform/gtk/test_expectations.txt trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/qt-5.0-wk2/Skipped trunk/LayoutTests/platform/win/Skipped trunk/LayoutTests/platform/wincairo/Skipped Removed Paths trunk/LayoutTests/http/tests/notifications/icon-does-not-exist-expected.txt trunk/LayoutTests/http/tests/notifications/icon-does-not-exist.html trunk/LayoutTests/http/tests/notifications/icon-exists-cancel-expected.txt trunk/LayoutTests/http/tests/notifications/icon-exists-cancel.html trunk/LayoutTests/http/tests/notifications/icon-exists-expected.txt trunk/LayoutTests/http/tests/notifications/icon-exists-show-alert-during-load-expected.txt trunk/LayoutTests/http/tests/notifications/icon-exists-show-alert-during-load.html trunk/LayoutTests/http/tests/notifications/icon-exists.html trunk/LayoutTests/http/tests/notifications/icon-requires-auth-expected.txt trunk/LayoutTests/http/tests/notifications/icon-requires-auth.html trunk/LayoutTests/http/tests/notifications/resources/icon-exists.png trunk/LayoutTests/http/tests/notifications/resources/icon-requires-auth.php Diff Modified: trunk/LayoutTests/ChangeLog (115152 => 115153) --- trunk/LayoutTests/ChangeLog 2012-04-25 01:02:47 UTC (rev 115152) +++ trunk/LayoutTests/ChangeLog 2012-04-25 01:10:09 UTC (rev 115153) @@ -1,5 +1,37 @@ 2012-04-24 Yael Aharon yael.aha...@nokia.com +[Qt] Move notification icon download out of WebCore +https://bugs.webkit.org/show_bug.cgi?id=80700 + +Reviewed by Jian Li. + +Remove http/tests/notifications after the code the tests were testing has been removed. + +* http/tests/notifications: Removed. +* http/tests/notifications/icon-does-not-exist-expected.txt: Removed. +* http/tests/notifications/icon-does-not-exist.html: Removed. +* http/tests/notifications/icon-exists-cancel-expected.txt: Removed. +* http/tests/notifications/icon-exists-cancel.html: Removed. +* http/tests/notifications/icon-exists-expected.txt: Removed. +* http/tests/notifications/icon-exists-show-alert-during-load-expected.txt: Removed. +* http/tests/notifications/icon-exists-show-alert-during-load.html: Removed. +* http/tests/notifications/icon-exists.html: Removed. +* http/tests/notifications/icon-requires-auth-expected.txt: Removed. +* http/tests/notifications/icon-requires-auth.html: Removed. +* http/tests/notifications/resources: Removed. +* http/tests/notifications/resources/icon-exists.png: Removed. +* http/tests/notifications/resources/icon-requires-auth.php: Removed. +* platform/chromium/test_expectations.txt: +* platform/efl/Skipped: +* platform/gtk/test_expectations.txt: +* platform/mac/Skipped: +* platform/qt-5.0-wk2/Skipped: +* platform/qt/Skipped: +* platform/win/Skipped: +* platform/wincairo/Skipped: + +2012-04-24 Yael Aharon yael.aha...@nokia.com + Unreviewed rebaseline after r115134. * platform/qt/fast/block/positioning/016-expected.txt: Deleted: trunk/LayoutTests/http/tests/notifications/icon-does-not-exist-expected.txt (115152 => 115153) --- trunk/LayoutTests/http/tests/notifications/icon-does-not-exist-expected.txt 2012-04-25 01:02:
[webkit-changes] [114249] trunk
Title: [114249] trunk
Revision 114249
Author yael.aha...@nokia.com
Date 2012-04-16 07:05:42 -0700 (Mon, 16 Apr 2012)
Log Message
[Qt][WK2] Fixed elements position is wrong after zooming.
https://bugs.webkit.org/show_bug.cgi?id=83981
Reviewed by Kenneth Rohde Christiansen.
.:
* ManualTests/remove-add-fixed-position.html: Added.
Source/WebCore:
When setFixedVisibleContentRect is called we mark all fixed elements in the frame for layout.
In order to find these elements, RenderView maintains a list of fixed elements.
They are added and removed at the same time that they are added and removed from their parent RenderBlock.
The idea is taken from the iOS5.1 branch, at opensource.apple.com.
Added a manual test that allows removing and adding fixed elements at will.
* page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
* rendering/RenderView.cpp:
(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
(WebCore):
(WebCore::RenderView::insertFixedPositionedObject):
(WebCore::RenderView::removeFixedPositionedObject):
* rendering/RenderView.h:
(RenderView):
Source/WebKit2:
Turn on the flag setFixedElementsLayoutRelativeToFrame. This causes fixed elements position to be calculated based on
visibleWidth and visibleHeight. When zoom level grows, the visibleWidth and visibleHeight become smaller.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Added Paths
trunk/ManualTests/remove-add-fixed-position.html
Diff
Modified: trunk/ChangeLog (114248 => 114249)
--- trunk/ChangeLog 2012-04-16 13:59:12 UTC (rev 114248)
+++ trunk/ChangeLog 2012-04-16 14:05:42 UTC (rev 114249)
@@ -1,3 +1,12 @@
+2012-04-16 Yael Aharon yael.aha...@nokia.com
+
+[Qt][WK2] Fixed elements position is wrong after zooming.
+https://bugs.webkit.org/show_bug.cgi?id=83981
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* ManualTests/remove-add-fixed-position.html: Added.
+
2012-04-13 Jason Liu jason@torchmobile.com.cn
[BlackBerry] Sign in cookie for ESPN.com does not retain login account (for fantasy sports).
Added: trunk/ManualTests/remove-add-fixed-position.html (0 => 114249)
--- trunk/ManualTests/remove-add-fixed-position.html (rev 0)
+++ trunk/ManualTests/remove-add-fixed-position.html 2012-04-16 14:05:42 UTC (rev 114249)
@@ -0,0 +1,93 @@
+htmlhead
+meta name=viewport content=width=device-width
+style
+.d1 {position:fixed; top:5; right:5; z-index:2; overflow:hidden;}
+.o {background:green; height:40px; width:200px;}
+.t { width:2000px; height:198px; background-color: lightgray; border: 1px solid blue;}
+body { margin: 0px; }
+/style
+script
+
+var fixed;
+
+function remove_child()
+{
+ fixed = document.getElementById(d1);
+ fixed.parentElement.removeChild(fixed);
+}
+
+function add_child()
+{
+ document.body.appendChild(fixed);
+}
+
+/script
+/head
+body
+div class=d1 id=d1div class=oThis is a test/div/div
+div class=t
+000
+/div
+div class=t
+200br
+button _onclick_=remove_child();remove fixed/button
+/div
+div class=t
+400br
+button _onclick_=add_child();add fixed/button
+/div
+div class=t
+600br
+/div
+div class=t
+800
+/div
+div class=t
+1000
+/div
+div class=t
+1200
+/div
+div class=t
+1400
+/div
+div class=t
+1600
+/div
+div class=t
+1800
+/div
+div class=t
+2000
+/div
+div class=t
+2200
+/div
+div class=t
+2400
+/div
+div class=t
+2600
+/div
+div class=t
+2800
+/div
+div class=t
+3000
+/div
+div class=t
+3200
+/div
+div class=t
+3400
+/div
+div class=t
+3600
+/div
+div class=t
+3800
+/div
+div class=t
+4000
+/div
+/body/html
Modified: trunk/Source/WebCore/ChangeLog (114248 => 114249)
--- trunk/Source/WebCore/ChangeLog 2012-04-16 13:59:12 UTC (rev 114248)
+++ trunk/Source/WebCore/ChangeLog 2012-04-16 14:05:42 UTC (rev 114249)
@@ -1,3 +1,29 @@
+2012-04-16 Yael Aharon yael.aha...@nokia.com
+
+[Qt][WK2] Fixed elements position is wrong after zooming.
+https://bugs.webkit.org/show_bug.cgi?id=83981
+
+Reviewed by Kenneth Rohde Christiansen.
+
+When setFixedVisibleContentRect is called we mark all fixed elements in the frame for layout.
+In order to find these elements, RenderView maintains a list of fixed elements.
+They are added and removed at the same time that they are added and removed from their parent RenderBlock.
+The idea is taken from the iOS5.1 branch, at opensource.apple.com.
+Added a manual test that allows removing and adding fixed
[webkit-changes] [113983] trunk
Title: [113983] trunk
Revision 113983
Author yael.aha...@nokia.com
Date 2012-04-12 08:35:13 -0700 (Thu, 12 Apr 2012)
Log Message
[Qt][WK2] Nested fixed elements scroll too fast
https://bugs.webkit.org/show_bug.cgi?id=83720
Reviewed by Noam Rosenthal.
.:
* ManualTests/nested-fixed-position.html: Added.
Source/WebCore:
Before setting the scrollPositionDelta to a fixed layer, check if it has an ancestor which also has fixed position.
If it does, do not set scrollPositionDelta.
Added a flag to TextureMapperLayer and GraphicsLayerTextureMapper indicating if it is a fixed position layer.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::setFixedToViewport):
(WebCore::GraphicsLayerTextureMapper::fixedToViewport):
(GraphicsLayerTextureMapper):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
(WebCore::TextureMapperLayer::isAncestorFixedToViewport):
(WebCore):
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
* platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
(WebCore::TextureMapperLayer::setFixedToViewport):
Source/WebKit2:
Set the fixedToViewport flag on the fixed position layers and adjust to
the new function name for setting scrollPositionDelta.
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::WebLayerTreeRenderer::setLayerState):
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp
Added Paths
trunk/ManualTests/nested-fixed-position.html
Diff
Modified: trunk/ChangeLog (113982 => 113983)
--- trunk/ChangeLog 2012-04-12 15:32:21 UTC (rev 113982)
+++ trunk/ChangeLog 2012-04-12 15:35:13 UTC (rev 113983)
@@ -1,3 +1,12 @@
+2012-04-12 Yael Aharon yael.aha...@nokia.com
+
+[Qt][WK2] Nested fixed elements scroll too fast
+https://bugs.webkit.org/show_bug.cgi?id=83720
+
+Reviewed by Noam Rosenthal.
+
+* ManualTests/nested-fixed-position.html: Added.
+
2012-03-15 Martin Robinson mrobin...@igalia.com
[CAIRO] Make GLContextGLX a subclass of GLContext
Added: trunk/ManualTests/nested-fixed-position.html (0 => 113983)
--- trunk/ManualTests/nested-fixed-position.html (rev 0)
+++ trunk/ManualTests/nested-fixed-position.html 2012-04-12 15:35:13 UTC (rev 113983)
@@ -0,0 +1,93 @@
+htmlhead
+
+meta content=text/html; charset=windows-1251 http-equiv=Content-Type
+style
+.d1{position:fixed;top:50%;right:50%;z-index:2;overflow:hidden;}
+.d2{position:fixed;bottom:0;left:0;z-index:2;width:100%;background-color:darkgray;}
+.o {background:green;height:40px;width:200px;}
+.t { width:2000px; height:198px;background-color: lightgray; border: 1px solid blue;}
+body { margin: 0px; }
+/style
+script
+function remove_fixed()
+{
+ document.getElementById(d2).style.position = static;
+}
+
+function add_fixed()
+{
+ document.getElementById(d2).style.position = fixed;
+}
+
+/script
+/head
+body
+div class=d2 id=d2This is the parent div.
+div class=d1 id=d1div class=oThis is the nested div./div/div
+/div
+div class=t
+000
+/div
+div class=t
+200
+/div
+div class=t
+400br
+button _onclick_=remove_fixed();remove fixed/button
+/div
+div class=t
+600br
+button _onclick_=add_fixed();add fixed/button
+/div
+div class=t
+800
+/div
+div class=t
+1000
+/div
+div class=t
+1200
+/div
+div class=t
+1400
+/div
+div class=t
+1600
+/div
+div class=t
+1800
+/div
+div class=t
+2000
+/div
+div class=t
+2200
+/div
+div class=t
+2400
+/div
+div class=t
+2600
+/div
+div class=t
+2800
+/div
+div class=t
+3000
+/div
+div class=t
+3200
+/div
+div class=t
+3400
+/div
+div class=t
+3600
+/div
+div class=t
+3800
+/div
+div class=t
+4000
+/div
+/body/html
Modified: trunk/Source/WebCore/ChangeLog (113982 => 113983)
--- trunk/Source/WebCore/ChangeLog 2012-04-12 15:32:21 UTC (rev 113982)
+++ trunk/Source/WebCore/ChangeLog 2012-04-12 15:35:13 UTC (rev 113983)
@@ -1,3 +1,29 @@
+2012-04-12 Yael Aharon yael.aha...@nokia.com
+
+[Qt][WK2] Nested fixed elements scroll too fast
+https://bugs.webkit.org/show_bug.cgi?id=83720
+
+Reviewed by Noam Rosenthal.
+
+Before setting the scrollPositionDelta to a fixed layer, check if it has an ancestor which also has fixed position.
+If it does, do not set scrollPositionDelta.
+Added a flag to TextureMapperLayer and GraphicsLayerTextureMapper indicating if it is a fixed posit
[webkit-changes] [113791] trunk
Title: [113791] trunk Revision 113791 Author yael.aha...@nokia.com Date 2012-04-10 16:40:51 -0700 (Tue, 10 Apr 2012) Log Message Initial support for fixed position elements in Qt WebKit2 https://bugs.webkit.org/show_bug.cgi?id=81786 Reviewed by Noam Rosenthal. .: * ManualTests/fixed-position.html: Added. Source/WebCore: When the setting acceleratedCompositingForFixedPositionEnabled is true, we update the position of fixed layers, and send updates to the UI process as we scroll. Before painting, TextureMapperLayer receives a delta of the scroll positions between the UI and the web processes, and adjusts its transform position accordingly. * page/FrameView.cpp: (WebCore::FrameView::setFixedVisibleContentRect): * platform/graphics/texmap/TextureMapperLayer.cpp: (WebCore::TextureMapperLayer::setScrollPositionDelta): (WebCore): * platform/graphics/texmap/TextureMapperLayer.h: (TextureMapperLayer): Source/WebKit2: Turn on the flag acceleratedCompositingForFixedPositionEnabled when using fixed layout. As we scroll, we keep track of the delta in scroll position between the UI and web processes, and adjust the position of all the fixed layers by that delta. When WebLayerTreeRenderer receives a new scroll position from the web process, it keeps it as pending, and commit the new scroll position in flushLayerChanges. This patch does not address scrolling overshoot and it does not fix the wrong positioning that occurs when we zoom. These issues will be addressed in future patches. * Shared/WebLayerTreeInfo.h: * UIProcess/API/qt/qquickwebpage.cpp: (QQuickWebPagePrivate::updateSize): * UIProcess/LayerTreeHostProxy.cpp: (WebKit::LayerTreeHostProxy::setContentsSize): (WebKit): (WebKit::LayerTreeHostProxy::renderNextFrame): (WebKit::LayerTreeHostProxy::didChangeScrollPosition): * UIProcess/LayerTreeHostProxy.h: (LayerTreeHostProxy): * UIProcess/LayerTreeHostProxy.messages.in: * UIProcess/WebLayerTreeRenderer.cpp: (WebKit::boundedScrollPosition): (WebKit): (WebKit::WebLayerTreeRenderer::paintToCurrentGLContext): (WebKit::WebLayerTreeRenderer::setContentsSize): (WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers): (WebKit::WebLayerTreeRenderer::didChangeScrollPosition): (WebKit::WebLayerTreeRenderer::syncLayerParameters): (WebKit::WebLayerTreeRenderer::deleteLayer): (WebKit::WebLayerTreeRenderer::flushLayerChanges): * UIProcess/WebLayerTreeRenderer.h: (WebLayerTreeRenderer): * WebProcess/WebCoreSupport/WebGraphicsLayer.cpp: (WebCore::WebGraphicsLayer::WebGraphicsLayer): (WebCore::WebGraphicsLayer::syncCompositingState): (WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly): * WebProcess/WebCoreSupport/WebGraphicsLayer.h: (WebGraphicsLayerClient): (WebCore::WebGraphicsLayer::fixedToViewport): (WebCore::WebGraphicsLayer::setFixedToViewport): (WebGraphicsLayer): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setResizesToContentsUsingLayoutSize): * WebProcess/WebPage/qt/LayerTreeHostQt.cpp: (WebKit::LayerTreeHostQt::LayerTreeHostQt): (WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer): (WebKit::updateOffsetFromViewportForSelf): (WebKit): (WebKit::updateOffsetFromViewportForLayer): (WebKit::LayerTreeHostQt::syncFixedLayers): (WebKit::LayerTreeHostQt::setVisibleContentsRect): * WebProcess/WebPage/qt/LayerTreeHostQt.h: (LayerTreeHostQt): Modified Paths trunk/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebLayerTreeInfo.h trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.h trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.messages.in trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.h trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.h Added Paths trunk/ManualTests/fixed-position.html Diff Modified: trunk/ChangeLog (113790 => 113791) --- trunk/ChangeLog 2012-04-10 23:34:52 UTC (rev 113790) +++ trunk/ChangeLog 2012-04-10 23:40:51 UTC (rev 113791) @@ -1,3 +1,12 @@ +2012-04-10 Yael Aharon yael.aha...@nokia.com + +Initial support for fixed position elements in Qt WebKit2 +https://bugs.webkit.org/show_bug.cgi?id=81786 + +Reviewed by Noam Rosenthal. + +* ManualTests/fixed-position.html: Added. + 2012-04-10 Raphael Kubo da Costa rak...@webkit.org [CMake] Do not pass -P to the preprocessor when running make_names.pl. Added: trunk/ManualTests/fixed-position.html (0 =>
[webkit-changes] [113135] trunk/Source
Title: [113135] trunk/Source
Revision 113135
Author yael.aha...@nokia.com
Date 2012-04-03 21:21:15 -0700 (Tue, 03 Apr 2012)
Log Message
[Qt][WK2] Assert on startup after r113090
https://bugs.webkit.org/show_bug.cgi?id=83111
Reviewed by Noam Rosenthal.
Source/WebCore:
Add willBeDestroyed to to GraphicsLayerTextureMapper.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::~GraphicsLayerTextureMapper):
(WebCore):
(WebCore::WebGraphicsLayer::willBeDestroyed):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
Source/WebKit2:
Add willBeDestroyed to to WebGraphicsLayer.
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore):
(WebCore::WebGraphicsLayer::willBeDestroyed):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (113134 => 113135)
--- trunk/Source/WebCore/ChangeLog 2012-04-04 03:52:07 UTC (rev 113134)
+++ trunk/Source/WebCore/ChangeLog 2012-04-04 04:21:15 UTC (rev 113135)
@@ -1,3 +1,19 @@
+2012-04-03 Yael Aharon yael.aha...@nokia.com
+
+[Qt][WK2] Assert on startup after r113090
+https://bugs.webkit.org/show_bug.cgi?id=83111
+
+Reviewed by Noam Rosenthal.
+
+Add willBeDestroyed to to GraphicsLayerTextureMapper.
+
+* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
+(WebCore::GraphicsLayerTextureMapper::~GraphicsLayerTextureMapper):
+(WebCore):
+(WebCore::WebGraphicsLayer::willBeDestroyed):
+* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
+(GraphicsLayerTextureMapper):
+
2012-04-03 Kenichi Ishibashi ba...@chromium.org
[Chromium] Out-of-process font loading garbles text
Modified: trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp (113134 => 113135)
--- trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp 2012-04-04 03:52:07 UTC (rev 113134)
+++ trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp 2012-04-04 04:21:15 UTC (rev 113135)
@@ -57,8 +57,14 @@
GraphicsLayerTextureMapper::~GraphicsLayerTextureMapper()
{
+willBeDestroyed();
}
+void GraphicsLayerTextureMapper::willBeDestroyed()
+{
+GraphicsLayer::willBeDestroyed();
+}
+
/* \reimp (GraphicsLayer.h): The current size might change, thus we need to update the whole display.
*/
void GraphicsLayerTextureMapper::setNeedsDisplay()
Modified: trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h (113134 => 113135)
--- trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h 2012-04-04 03:52:07 UTC (rev 113134)
+++ trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h 2012-04-04 04:21:15 UTC (rev 113135)
@@ -95,6 +95,8 @@
#endif
private:
+virtual void willBeDestroyed();
+
OwnPtrTextureMapperLayer m_layer;
RefPtrTextureMapperBackingStore m_compositedImage;
RefPtrImage m_image;
Modified: trunk/Source/WebKit2/ChangeLog (113134 => 113135)
--- trunk/Source/WebKit2/ChangeLog 2012-04-04 03:52:07 UTC (rev 113134)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-04 04:21:15 UTC (rev 113135)
@@ -1,3 +1,19 @@
+2012-04-03 Yael Aharon yael.aha...@nokia.com
+
+[Qt][WK2] Assert on startup after r113090
+https://bugs.webkit.org/show_bug.cgi?id=83111
+
+Reviewed by Noam Rosenthal.
+
+Add willBeDestroyed to to WebGraphicsLayer.
+
+* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
+(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
+(WebCore):
+(WebCore::WebGraphicsLayer::willBeDestroyed):
+* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
+(WebGraphicsLayer):
+
2012-04-03 Sam Weinig s...@webkit.org
Allow the old WebKit2 drawing model to host layers in the window server
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp (113134 => 113135)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp 2012-04-04 03:52:07 UTC (rev 113134)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp 2012-04-04 04:21:15 UTC (rev 113135)
@@ -103,8 +103,14 @@
purgeBackingStores();
m_webGraphicsLayerClient-detachLayer(this);
}
+willBeDestroyed();
}
+void WebGraphicsLayer::willBeDestroyed()
+{
+GraphicsLayer::willBeDestroyed();
+}
+
bool WebGraphicsLayer::setChildren(const VectorGraphicsLayer* children)
{
bool ok = GraphicsLayer::setCh
[webkit-changes] [112265] trunk/Source/WebKit2
Title: [112265] trunk/Source/WebKit2
Revision 112265
Author yael.aha...@nokia.com
Date 2012-03-27 07:42:47 -0700 (Tue, 27 Mar 2012)
Log Message
[Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=82289
Reviewed by Kenneth Rohde Christiansen.
As we scroll, we constantly send 2 messages. Those 2 messages can be merged into one.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
* UIProcess/WebPageProxy.cpp:
(WebKit):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setVisibleContentsRect):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (112264 => 112265)
--- trunk/Source/WebKit2/ChangeLog 2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/ChangeLog 2012-03-27 14:42:47 UTC (rev 112265)
@@ -1,3 +1,22 @@
+2012-03-27 Yael Aharon yael.aha...@nokia.com
+
+[Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect
+https://bugs.webkit.org/show_bug.cgi?id=82289
+
+Reviewed by Kenneth Rohde Christiansen.
+
+As we scroll, we constantly send 2 messages. Those 2 messages can be merged into one.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
+* UIProcess/WebPageProxy.cpp:
+(WebKit):
+* UIProcess/WebPageProxy.h:
+(WebPageProxy):
+* WebProcess/WebPage/WebPage.messages.in:
+* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
+(WebKit::LayerTreeHostQt::setVisibleContentsRect):
+
2012-03-27 Carlos Garcia Campos cgar...@igalia.com
[SOUP] Implement missing methods in CookieJarSoup
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (112264 => 112265)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-03-27 14:42:47 UTC (rev 112265)
@@ -642,7 +642,6 @@
float scale = pageView-contentsScale();
drawingArea-setVisibleContentsRect(visibleRect, scale, trajectoryVector);
-webPageProxy-setFixedVisibleContentRect(visibleRect);
}
void QQuickWebViewFlickablePrivate::_q_suspend()
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (112264 => 112265)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-03-27 14:42:47 UTC (rev 112265)
@@ -844,14 +844,6 @@
}
#if USE(TILED_BACKING_STORE)
-void WebPageProxy::setFixedVisibleContentRect(const IntRect rect)
-{
-if (!isValid())
-return;
-
-process()-send(Messages::WebPage::SetFixedVisibleContentRect(rect), m_pageID);
-}
-
void WebPageProxy::setViewportSize(const IntSize size)
{
if (!isValid())
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (112264 => 112265)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2012-03-27 14:42:47 UTC (rev 112265)
@@ -378,7 +378,6 @@
PlatformWidget viewWidget();
#endif
#if USE(TILED_BACKING_STORE)
-void setFixedVisibleContentRect(const WebCore::IntRect);
void setViewportSize(const WebCore::IntSize);
#endif
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in (112264 => 112265)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in 2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in 2012-03-27 14:42:47 UTC (rev 112265)
@@ -105,7 +105,6 @@
ResumeActiveDOMObjectsAndAnimations()
#if USE(TILED_BACKING_STORE)
-SetFixedVisibleContentRect(WebCore::IntRect rect)
SetViewportSize(WebCore::IntSize size)
#endif
Modified: trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp (112264 => 112265)
--- trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp 2012-03-27 14:32:49 UTC (rev 112264)
+++ trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp 2012-03-27 14:42:47 UTC (rev 112265)
@@ -443,6 +443,8 @@
}
scheduleLayerFlush();
+if (m_webPage-useFixedLayout())
+m_webPage-setFixedVisibleContentRect(rect);
}
void LayerTreeHostQt::renderNextFrame()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111106] trunk/Source/WebCore
Title: [06] trunk/Source/WebCore Revision 06 Author yael.aha...@nokia.com Date 2012-03-16 19:16:40 -0700 (Fri, 16 Mar 2012) Log Message Unreviewed build fix after r111075. Correct the path of WebKitBlobBuilder.idl. * DerivedSources.pri: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.pri Diff Modified: trunk/Source/WebCore/ChangeLog (05 => 06) --- trunk/Source/WebCore/ChangeLog 2012-03-17 02:01:26 UTC (rev 05) +++ trunk/Source/WebCore/ChangeLog 2012-03-17 02:16:40 UTC (rev 06) @@ -1,3 +1,10 @@ +2012-03-16 Yael Aharon yael.aha...@nokia.com + +Unreviewed build fix after r111075. +Correct the path of WebKitBlobBuilder.idl. + +* DerivedSources.pri: + 2012-03-16 David Levin le...@chromium.org Fix for test runs for non-chromium platforms. Modified: trunk/Source/WebCore/DerivedSources.pri (05 => 06) --- trunk/Source/WebCore/DerivedSources.pri 2012-03-17 02:01:26 UTC (rev 05) +++ trunk/Source/WebCore/DerivedSources.pri 2012-03-17 02:16:40 UTC (rev 06) @@ -108,7 +108,6 @@ $$PWD/Modules/filesystem/FileWriterCallback.idl \ $$PWD/Modules/filesystem/Metadata.idl \ $$PWD/Modules/filesystem/MetadataCallback.idl \ -$$PWD/Modules/filesystem/WebKitBlobBuilder.idl \ $$PWD/Modules/filesystem/WorkerContextFileSystem.idl \ $$PWD/Modules/geolocation/Geolocation.idl \ $$PWD/Modules/geolocation/Geoposition.idl \ @@ -247,6 +246,7 @@ $$PWD/fileapi/FileReader.idl \ $$PWD/fileapi/FileReaderSync.idl \ $$PWD/fileapi/OperationNotAllowedException.idl \ +$$PWD/fileapi/WebKitBlobBuilder.idl \ $$PWD/html/canvas/ArrayBufferView.idl \ $$PWD/html/canvas/ArrayBuffer.idl \ $$PWD/html/canvas/DataView.idl \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108810] trunk/Source/WebCore
Title: [108810] trunk/Source/WebCore
Revision 108810
Author yael.aha...@nokia.com
Date 2012-02-24 09:02:46 -0800 (Fri, 24 Feb 2012)
Log Message
[Texmap] Consolidate the common parts of TextureMapperGL::drawTexture
https://bugs.webkit.org/show_bug.cgi?id=79143
Reviewed by Noam Rosenthal.
Combine the two drawTexture methods into one, and extract the part that
could not be combined into its own method.
No new tests. Refactoring only.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore):
(WebCore::TextureMapperGL::drawTexture):
* platform/graphics/texmap/TextureMapperGL.h:
(WebCore):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::id):
(WebCore::BitmapTextureGL::relativeSize):
(WebCore::BitmapTextureGL::setTextureMapper):
(WebCore::BitmapTextureGL::BitmapTextureGL):
* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
(WebCore):
(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore):
(WebCore::TextureMapperShaderProgram::prepare):
(WebCore::TextureMapperShaderProgram::matrixVariable):
(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
(WebCore::TextureMapperShaderProgram::opacityVariable):
(TextureMapperShaderProgram):
(TextureMapperShaderProgramSimple):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.h
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (108809 => 108810)
--- trunk/Source/WebCore/ChangeLog 2012-02-24 16:50:55 UTC (rev 108809)
+++ trunk/Source/WebCore/ChangeLog 2012-02-24 17:02:46 UTC (rev 108810)
@@ -1,3 +1,42 @@
+2012-02-24 Yael Aharon yael.aha...@nokia.com
+
+[Texmap] Consolidate the common parts of TextureMapperGL::drawTexture
+https://bugs.webkit.org/show_bug.cgi?id=79143
+
+Reviewed by Noam Rosenthal.
+
+Combine the two drawTexture methods into one, and extract the part that
+could not be combined into its own method.
+No new tests. Refactoring only.
+
+* platform/graphics/texmap/TextureMapperGL.cpp:
+(WebCore):
+(WebCore::TextureMapperGL::drawTexture):
+* platform/graphics/texmap/TextureMapperGL.h:
+(WebCore):
+(BitmapTextureGL):
+(WebCore::BitmapTextureGL::~BitmapTextureGL):
+(WebCore::BitmapTextureGL::id):
+(WebCore::BitmapTextureGL::relativeSize):
+(WebCore::BitmapTextureGL::setTextureMapper):
+(WebCore::BitmapTextureGL::BitmapTextureGL):
+* platform/graphics/texmap/TextureMapperShaderManager.cpp:
+(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
+(WebCore):
+(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):
+* platform/graphics/texmap/TextureMapperShaderManager.h:
+(WebCore):
+(WebCore::TextureMapperShaderProgram::prepare):
+(WebCore::TextureMapperShaderProgram::matrixVariable):
+(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
+(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
+(WebCore::TextureMapperShaderProgram::opacityVariable):
+(TextureMapperShaderProgram):
+(TextureMapperShaderProgramSimple):
+(TextureMapperShaderProgramOpacityAndMask):
+(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
+(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
+
2012-02-24 Daniel Bates dba...@webkit.org
style element and link element for CSS stylesheet should emit load/error event when sheet loads/fails to load
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (108809 => 108810)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2012-02-24 16:50:55 UTC (rev 108809)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2012-02-24 17:02:46 UTC (rev 108810)
@@ -223,42 +223,6 @@
RefPtrBitmapTexture currentSurface;
};
-class BitmapTextureGL : public BitmapTexture {
-public:
-virtual void destroy();
-virtual IntSize size() const;
-virtual bool isValid() const;
-virtual void didReset();
-void bind();
-void initializeStencil();
-~BitmapTextureGL() { destroy(); }
-virtual uint32_t id() const { return m_id; }
-inline FloatSize relativeSize() const { return m_relati
[webkit-changes] [108882] trunk/Source/WebCore
Title: [108882] trunk/Source/WebCore
Revision 108882
Author yael.aha...@nokia.com
Date 2012-02-24 18:41:41 -0800 (Fri, 24 Feb 2012)
Log Message
[Texmap] Add const-ness to TextureMapperShaderManager
https://bugs.webkit.org/show_bug.cgi?id=79545
Reviewed by Noam Rosenthal.
Add const to new methods.
No new tests.
* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderProgramSimple::vertexShaderSource):
(WebCore::TextureMapperShaderProgramSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::vertexShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore::TextureMapperShaderProgram::matrixVariable):
(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
(WebCore::TextureMapperShaderProgram::opacityVariable):
(TextureMapperShaderProgram):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
(TextureMapperShaderProgramOpacityAndMask):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (108881 => 108882)
--- trunk/Source/WebCore/ChangeLog 2012-02-25 02:39:10 UTC (rev 108881)
+++ trunk/Source/WebCore/ChangeLog 2012-02-25 02:41:41 UTC (rev 108882)
@@ -1,3 +1,29 @@
+2012-02-24 Yael Aharon yael.aha...@nokia.com
+
+[Texmap] Add const-ness to TextureMapperShaderManager
+https://bugs.webkit.org/show_bug.cgi?id=79545
+
+Reviewed by Noam Rosenthal.
+
+Add const to new methods.
+No new tests.
+
+* platform/graphics/texmap/TextureMapperShaderManager.cpp:
+(WebCore::TextureMapperShaderProgramSimple::vertexShaderSource):
+(WebCore::TextureMapperShaderProgramSimple::fragmentShaderSource):
+(WebCore::TextureMapperShaderProgramOpacityAndMask::vertexShaderSource):
+(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
+* platform/graphics/texmap/TextureMapperShaderManager.h:
+(WebCore::TextureMapperShaderProgram::matrixVariable):
+(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
+(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
+(WebCore::TextureMapperShaderProgram::opacityVariable):
+(TextureMapperShaderProgram):
+(TextureMapperShaderProgramSimple):
+(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
+(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
+(TextureMapperShaderProgramOpacityAndMask):
+
2012-02-24 Tom Sepez tse...@chromium.org
XSS Auditor targeting legitimate frames as false positives.
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp (108881 => 108882)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp 2012-02-25 02:39:10 UTC (rev 108881)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp 2012-02-25 02:41:41 UTC (rev 108882)
@@ -146,12 +146,12 @@
getUniformLocation(m_opacityVariable, Opacity);
}
-const char* TextureMapperShaderProgramSimple::vertexShaderSource()
+const char* TextureMapperShaderProgramSimple::vertexShaderSource() const
{
return vertexShaderSourceSimple;
}
-const char* TextureMapperShaderProgramSimple::fragmentShaderSource()
+const char* TextureMapperShaderProgramSimple::fragmentShaderSource() const
{
return fragmentShaderSourceSimple;
}
@@ -177,12 +177,12 @@
getUniformLocation(m_opacityVariable, Opacity);
}
-const char* TextureMapperShaderProgramOpacityAndMask::vertexShaderSource()
+const char* TextureMapperShaderProgramOpacityAndMask::vertexShaderSource() const
{
return vertexShaderSourceOpacityAndMask;
}
-const char* TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource()
+const char* TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource() const
{
return fragmentShaderSourceOpacityAndMask;
}
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h (108881 => 108882)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h 2012-02-25 02:39:10 UTC (rev 108881)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h 2012-02-25 02:41:41 UTC (rev 108882)
@@ -53,16 +53,16 @@
}
virtual void prepare(float opacity, const BitmapTexture*) { }
-GLint matrixVariable() { return m_matrixVariable; }
-GLint sourceMatrixVariable() { return m_sourceMatrixVariable; }
-GLint sourceTextureVariable()
[webkit-changes] [108416] trunk/Source/WebCore
Title: [108416] trunk/Source/WebCore Revision 108416 Author yael.aha...@nokia.com Date 2012-02-21 16:38:06 -0800 (Tue, 21 Feb 2012) Log Message Unreviewed build fix. No new tests. * platform/graphics/opengl/TextureMapperGL.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (108415 => 108416) --- trunk/Source/WebCore/ChangeLog 2012-02-22 00:34:19 UTC (rev 108415) +++ trunk/Source/WebCore/ChangeLog 2012-02-22 00:38:06 UTC (rev 108416) @@ -1,3 +1,11 @@ +2012-02-21 Yael Aharon yael.aha...@nokia.com + +Unreviewed build fix. + +No new tests. + +* platform/graphics/opengl/TextureMapperGL.cpp: + 2012-02-21 Adam Klein ad...@chromium.org ContainerNode::childrenChanged must be called immediately after removing children Modified: trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp (108415 => 108416) --- trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp 2012-02-22 00:34:19 UTC (rev 108415) +++ trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp 2012-02-22 00:38:06 UTC (rev 108416) @@ -33,7 +33,6 @@ #if PLATFORM(QT) #if QT_VERSION = QT_VERSION_CHECK(5, 0, 0) #include QPlatformPixmap -#include qopenglfunctions.h #endif #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [108276] trunk/Source/WebCore
Title: [108276] trunk/Source/WebCore
Revision 108276
Author yael.aha...@nokia.com
Date 2012-02-20 17:33:41 -0800 (Mon, 20 Feb 2012)
Log Message
Regression (108135) isOpaque() returns uninitialized variable.
https://bugs.webkit.org/show_bug.cgi?id=79049
Reviewed by Noam Rosenthal.
isOpaque() should use the new m_flags instead of the old m_isOpaque.
No new tests. No new functionality.
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::isOpaque):
(BitmapTexture):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (108275 => 108276)
--- trunk/Source/WebCore/ChangeLog 2012-02-21 01:27:27 UTC (rev 108275)
+++ trunk/Source/WebCore/ChangeLog 2012-02-21 01:33:41 UTC (rev 108276)
@@ -1,3 +1,18 @@
+2012-02-20 Yael Aharon yael.aha...@nokia.com
+
+Regression (108135) isOpaque() returns uninitialized variable.
+https://bugs.webkit.org/show_bug.cgi?id=79049
+
+Reviewed by Noam Rosenthal.
+
+isOpaque() should use the new m_flags instead of the old m_isOpaque.
+No new tests. No new functionality.
+
+* platform/graphics/texmap/TextureMapper.h:
+(WebCore::BitmapTexture::reset):
+(WebCore::BitmapTexture::isOpaque):
+(BitmapTexture):
+
2012-02-20 Kentaro Hara hara...@chromium.org
Unreviewed. Rebaselined run-bindings-tests results.
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h (108275 => 108276)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h 2012-02-21 01:27:27 UTC (rev 108275)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h 2012-02-21 01:33:41 UTC (rev 108276)
@@ -70,7 +70,7 @@
virtual int bpp() const { return 32; }
virtual void didReset() { }
-void reset(const IntSize size, Flags flags = 0)
+void reset(const IntSize size, Flags flags)
{
m_flags = flags;
m_contentSize = size;
@@ -79,7 +79,7 @@
inline IntSize contentSize() const { return m_contentSize; }
inline int numberOfBytes() const { return size().width() * size().height() * bpp() 3; }
-inline bool isOpaque() const { return m_isOpaque; }
+inline bool isOpaque() const { return !(m_flags SupportsAlpha); }
#if ENABLE(CSS_FILTERS)
virtual void applyFilters(const BitmapTexture contentTexture, const FilterOperations) { }
@@ -87,7 +87,6 @@
protected:
IntSize m_contentSize;
-bool m_isOpaque;
private:
Flags m_flags;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107068] trunk/Source/WebKit2
Title: [107068] trunk/Source/WebKit2
Revision 107068
Author yael.aha...@nokia.com
Date 2012-02-08 04:13:50 -0800 (Wed, 08 Feb 2012)
Log Message
[WK2] Text notifications should have an iconURL
https://bugs.webkit.org/show_bug.cgi?id=77968
Reviewed by Simon Hausmann.
Per http://www.w3.org/TR/notifications simple text notifications should have an iconURL.
Add an iconURL to WebNotification and add a public API to access it.
* UIProcess/API/C/WKNotification.cpp:
(WKNotificationCopyiconURL):
* UIProcess/API/C/WKNotification.h:
* UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
* UIProcess/Notifications/WebNotification.h:
(WebKit::WebNotification::create):
(WebKit::WebNotification::iconURL):
(WebNotification):
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
* UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKNotification.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKNotification.h
trunk/Source/WebKit2/UIProcess/Notifications/WebNotification.cpp
trunk/Source/WebKit2/UIProcess/Notifications/WebNotification.h
trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp
trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/WebProcess/Notifications/WebNotificationManager.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (107067 => 107068)
--- trunk/Source/WebKit2/ChangeLog 2012-02-08 12:12:31 UTC (rev 107067)
+++ trunk/Source/WebKit2/ChangeLog 2012-02-08 12:13:50 UTC (rev 107068)
@@ -1,3 +1,34 @@
+2012-02-08 Yael Aharon yael.aha...@nokia.com
+
+[WK2] Text notifications should have an iconURL
+https://bugs.webkit.org/show_bug.cgi?id=77968
+
+Reviewed by Simon Hausmann.
+
+Per http://www.w3.org/TR/notifications simple text notifications should have an iconURL.
+Add an iconURL to WebNotification and add a public API to access it.
+
+* UIProcess/API/C/WKNotification.cpp:
+(WKNotificationCopyiconURL):
+* UIProcess/API/C/WKNotification.h:
+* UIProcess/Notifications/WebNotification.cpp:
+(WebKit::WebNotification::WebNotification):
+* UIProcess/Notifications/WebNotification.h:
+(WebKit::WebNotification::create):
+(WebKit::WebNotification::iconURL):
+(WebNotification):
+* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
+(WebKit::WebNotificationManagerProxy::show):
+* UIProcess/Notifications/WebNotificationManagerProxy.h:
+(WebNotificationManagerProxy):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::showNotification):
+* UIProcess/WebPageProxy.h:
+(WebPageProxy):
+* UIProcess/WebPageProxy.messages.in:
+* WebProcess/Notifications/WebNotificationManager.cpp:
+(WebKit::WebNotificationManager::show):
+
2012-02-08 Philippe Normand pnorm...@igalia.com
[GTK][WK2] enable-webaudio WebSetting
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKNotification.cpp (107067 => 107068)
--- trunk/Source/WebKit2/UIProcess/API/C/WKNotification.cpp 2012-02-08 12:12:31 UTC (rev 107067)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKNotification.cpp 2012-02-08 12:13:50 UTC (rev 107068)
@@ -47,6 +47,11 @@
return toCopiedAPI(toImpl(notification)-body());
}
+WKStringRef WKNotificationCopyIconURL(WKNotificationRef notification)
+{
+return toCopiedAPI(toImpl(notification)-iconURL());
+}
+
WKSecurityOriginRef WKNotificationGetSecurityOrigin(WKNotificationRef notification)
{
return toAPI(toImpl(notification)-origin());
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKNotification.h (107067 => 107068)
--- trunk/Source/WebKit2/UIProcess/API/C/WKNotification.h 2012-02-08 12:12:31 UTC (rev 107067)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKNotification.h 2012-02-08 12:13:50 UTC (rev 107068)
@@ -36,6 +36,7 @@
WK_EXPORT WKStringRef WKNotificationCopyTitle(WKNotificationRef notification);
WK_EXPORT WKStringRef WKNotificationCopyBody(WKNotificationRef notification);
+WK_EXPORT WKStringRef WKNotificationCopyIconURL(WKNotificationRef notification);
WK_EXPORT WKSecurityOriginRef WKNotificationGetSecurityOrigin(WKNotificationRef notification);
WK_EXPORT uint64_t WKNotificationGetID(WKNotificationRef notification);
Modified: trunk/Source/WebKit2/UIProcess/Notifications/WebNotification.cpp (107067 => 107068
[webkit-changes] [105881] trunk/Source
Title: [105881] trunk/Source
Revision 105881
Author yael.aha...@nokia.com
Date 2012-01-25 09:09:51 -0800 (Wed, 25 Jan 2012)
Log Message
[Qt] Build fix when using force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=76832
Reviewed by Simon Hausmann.
Source/WebCore:
Add a dependency on QtWidgets, when compiling against Qt5.
No new tests. This is a build fix.
* Target.pri:
Source/WebKit2:
Add a dependency on QtWidgets.
* Target.pri:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri
Diff
Modified: trunk/Source/WebCore/ChangeLog (105880 => 105881)
--- trunk/Source/WebCore/ChangeLog 2012-01-25 16:19:35 UTC (rev 105880)
+++ trunk/Source/WebCore/ChangeLog 2012-01-25 17:09:51 UTC (rev 105881)
@@ -1,3 +1,16 @@
+2012-01-25 Yael Aharon yael.aha...@nokia.com
+
+[Qt] Build fix when using force_static_libs_as_shared
+https://bugs.webkit.org/show_bug.cgi?id=76832
+
+Reviewed by Simon Hausmann.
+
+Add a dependency on QtWidgets, when compiling against Qt5.
+
+No new tests. This is a build fix.
+
+* Target.pri:
+
2012-01-25 Sami Kyostila skyos...@chromium.org
Clipping of render layer boundaries does not take page scale into account
Modified: trunk/Source/WebCore/Target.pri (105880 => 105881)
--- trunk/Source/WebCore/Target.pri 2012-01-25 16:19:35 UTC (rev 105880)
+++ trunk/Source/WebCore/Target.pri 2012-01-25 17:09:51 UTC (rev 105881)
@@ -19,7 +19,7 @@
haveQt(5) {
# Add a QtScript dependency for the time being, in order to pull in the include
# path for QtScript when it's built as a standalone module
-QT += script
+QT += script widgets
} else {
INCLUDEPATH += $$PWD/../_javascript_Core/wtf/qt/compat
}
Modified: trunk/Source/WebKit2/ChangeLog (105880 => 105881)
--- trunk/Source/WebKit2/ChangeLog 2012-01-25 16:19:35 UTC (rev 105880)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-25 17:09:51 UTC (rev 105881)
@@ -1,3 +1,14 @@
+2012-01-25 Yael Aharon yael.aha...@nokia.com
+
+[Qt] Build fix when using force_static_libs_as_shared
+https://bugs.webkit.org/show_bug.cgi?id=76832
+
+Reviewed by Simon Hausmann.
+
+Add a dependency on QtWidgets.
+
+* Target.pri:
+
2012-01-24 Sergio Villar Senin svil...@igalia.com
[WK2] FindController should not assume that ports do not want to highlight text matches
Modified: trunk/Source/WebKit2/Target.pri (105880 => 105881)
--- trunk/Source/WebKit2/Target.pri 2012-01-25 16:19:35 UTC (rev 105880)
+++ trunk/Source/WebKit2/Target.pri 2012-01-25 17:09:51 UTC (rev 105881)
@@ -12,7 +12,7 @@
include(WebKit2.pri)
WEBKIT += wtf _javascript_core webcore
-QT += declarative
+QT += declarative widgets
CONFIG += staticlib
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [103303] trunk
Title: [103303] trunk
Revision 103303
Author yael.aha...@nokia.com
Date 2011-12-19 21:26:56 -0800 (Mon, 19 Dec 2011)
Log Message
Update dropzone implementation per spec update
https://bugs.webkit.org/show_bug.cgi?id=74834
Reviewed by Tony Chang.
Source/WebCore:
Update support for dropzone attribute to use file: and string: instead of f: and s:.
http://www.whatwg.org/specs/web-apps/current-work/#the-dropzone-attribute
No new tests. Existing tests cover this and were updated.
* dom/Clipboard.cpp:
(WebCore::Clipboard::hasDropZoneType):
LayoutTests:
Update the tests per spec change.
* fast/events/dropzone-001.html:
* fast/events/dropzone-002.html:
* fast/events/dropzone-003.html:
* fast/events/dropzone-004.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/dropzone-001.html
trunk/LayoutTests/fast/events/dropzone-002.html
trunk/LayoutTests/fast/events/dropzone-003.html
trunk/LayoutTests/fast/events/dropzone-004.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Clipboard.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (103302 => 103303)
--- trunk/LayoutTests/ChangeLog 2011-12-20 05:10:02 UTC (rev 103302)
+++ trunk/LayoutTests/ChangeLog 2011-12-20 05:26:56 UTC (rev 103303)
@@ -1,3 +1,17 @@
+2011-12-19 Yael Aharon yael.aha...@nokia.com
+
+Update dropzone implementation per spec update
+https://bugs.webkit.org/show_bug.cgi?id=74834
+
+Reviewed by Tony Chang.
+
+Update the tests per spec change.
+
+* fast/events/dropzone-001.html:
+* fast/events/dropzone-002.html:
+* fast/events/dropzone-003.html:
+* fast/events/dropzone-004.html:
+
2011-12-16 Gavin Barraclough barraclo...@apple.com
https://bugs.webkit.org/show_bug.cgi?id=74903
Modified: trunk/LayoutTests/fast/events/dropzone-001.html (103302 => 103303)
--- trunk/LayoutTests/fast/events/dropzone-001.html 2011-12-20 05:10:02 UTC (rev 103302)
+++ trunk/LayoutTests/fast/events/dropzone-001.html 2011-12-20 05:26:56 UTC (rev 103303)
@@ -34,7 +34,7 @@
function changeDropZone()
{
-dropTarget.setAttribute(webkitdropzone, dropEffectElem.options[dropEffectElem.selectedIndex].value + s:text/plain);
+dropTarget.setAttribute(webkitdropzone, dropEffectElem.options[dropEffectElem.selectedIndex].value + string:text/plain);
}
function dragStart(e)
Modified: trunk/LayoutTests/fast/events/dropzone-002.html (103302 => 103303)
--- trunk/LayoutTests/fast/events/dropzone-002.html 2011-12-20 05:10:02 UTC (rev 103302)
+++ trunk/LayoutTests/fast/events/dropzone-002.html 2011-12-20 05:26:56 UTC (rev 103303)
@@ -32,7 +32,7 @@
function changeDropZone()
{
-dropTarget.setAttribute(webkitdropzone, S:text/plain s:url + dropEffectElem.options[dropEffectElem.selectedIndex].value);
+dropTarget.setAttribute(webkitdropzone, StRinG:text/plain sTrING:url + dropEffectElem.options[dropEffectElem.selectedIndex].value);
}
function printDropEvent(e)
Modified: trunk/LayoutTests/fast/events/dropzone-003.html (103302 => 103303)
--- trunk/LayoutTests/fast/events/dropzone-003.html 2011-12-20 05:10:02 UTC (rev 103302)
+++ trunk/LayoutTests/fast/events/dropzone-003.html 2011-12-20 05:26:56 UTC (rev 103303)
@@ -32,7 +32,7 @@
function changeDropZone()
{
-dropTarget.setAttribute(webkitdropzone, dropEffectElem.options[dropEffectElem.selectedIndex].value + s:text/plain s:any/type);
+dropTarget.setAttribute(webkitdropzone, dropEffectElem.options[dropEffectElem.selectedIndex].value + string:text/plain string:any/type);
}
function printDropEvent(e)
Modified: trunk/LayoutTests/fast/events/dropzone-004.html (103302 => 103303)
--- trunk/LayoutTests/fast/events/dropzone-004.html 2011-12-20 05:10:02 UTC (rev 103302)
+++ trunk/LayoutTests/fast/events/dropzone-004.html 2011-12-20 05:26:56 UTC (rev 103303)
@@ -29,7 +29,7 @@
function changeDropZone()
{
-dropTarget.setAttribute(webkitdropzone, dropEffectElem.options[dropEffectElem.selectedIndex].value + f:text/html);
+dropTarget.setAttribute(webkitdropzone, dropEffectElem.options[dropEffectElem.selectedIndex].value + file:text/html);
}
function printDropEvent(e)
Modified: trunk/Source/WebCore/ChangeLog (103302 => 103303)
--- trunk/Source/WebCore/ChangeLog 2011-12-20 05:10:02 UTC (rev 103302)
+++ trunk/Source/WebCore/ChangeLog 2011-12-20 05:26:56 UTC (rev 103303)
@@ -1,3 +1,18 @@
+2011-12-19 Yael Aharon yael.aha...@nokia.com
+
+Update dropzone implementation per spec update
+https://bugs.webkit.org/show_bug.cgi?id=74834
+
+Reviewed by Tony Chang.
+
+Update support for dropzone attribute to use file: and string: instead of f: and s:.
+http://www.whatwg.org/specs/web-apps/current-work/#the-dropzone-attribute
+
+No new tests. Existing tests cover this and were updated.
+
+* dom/Clipboard.cpp:
+(WebCore::Clipboard::hasDropZoneType):
+
2011-12-19 Sam Weinig s...@webkit.
[webkit-changes] [103098] trunk
Title: [103098] trunk
Revision 103098
Author yael.aha...@nokia.com
Date 2011-12-16 13:03:05 -0800 (Fri, 16 Dec 2011)
Log Message
Audio file in video element has a size of 0x0 .
https://bugs.webkit.org/show_bug.cgi?id=74738
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
When the source of a video element has audio only, the intrinsic size of the video should
not be 0x0. Instead, it should be the same as as no media was loaded.
No new tests. An existing test is covering this case and was modified to reflect this change.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::calculateIntrinsicSize):
LayoutTests:
Changed the expected result to reflect this change.
* media/audio-only-video-intrinsic-size-expected.txt:
* media/audio-only-video-intrinsic-size.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/audio-only-video-intrinsic-size-expected.txt
trunk/LayoutTests/media/audio-only-video-intrinsic-size.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderVideo.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (103097 => 103098)
--- trunk/LayoutTests/ChangeLog 2011-12-16 20:55:10 UTC (rev 103097)
+++ trunk/LayoutTests/ChangeLog 2011-12-16 21:03:05 UTC (rev 103098)
@@ -1,3 +1,15 @@
+2011-12-16 Yael Aharon yael.aha...@nokia.com
+
+Audio file in video element has a size of 0x0 .
+https://bugs.webkit.org/show_bug.cgi?id=74738
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Changed the expected result to reflect this change.
+
+* media/audio-only-video-intrinsic-size-expected.txt:
+* media/audio-only-video-intrinsic-size.html:
+
2011-12-16 Alexis Menard alexis.men...@openbossa.org
getComputedStyle for border-width is not implemented.
Modified: trunk/LayoutTests/media/audio-only-video-intrinsic-size-expected.txt (103097 => 103098)
--- trunk/LayoutTests/media/audio-only-video-intrinsic-size-expected.txt 2011-12-16 20:55:10 UTC (rev 103097)
+++ trunk/LayoutTests/media/audio-only-video-intrinsic-size-expected.txt 2011-12-16 21:03:05 UTC (rev 103098)
@@ -1,5 +1,5 @@
-This tests the intrinsic size of a video element is the default 300×150 before metadata is loaded, and 0×0 after metadata is loaded for an audio-only file.
+This tests the intrinsic size of a video element is the default 300×150 before metadata is loaded, and also after metadata is loaded for an audio-only file.
Initial dimensions: 300×150
-Dimensions after metadata loaded: 0×0
+Dimensions after metadata loaded: 300×150
Modified: trunk/LayoutTests/media/audio-only-video-intrinsic-size.html (103097 => 103098)
--- trunk/LayoutTests/media/audio-only-video-intrinsic-size.html 2011-12-16 20:55:10 UTC (rev 103097)
+++ trunk/LayoutTests/media/audio-only-video-intrinsic-size.html 2011-12-16 21:03:05 UTC (rev 103098)
@@ -1,7 +1,7 @@
video id=vid src="" _onloadedmetadata_=loadedMetadata()/video
p
This tests the intrinsic size of a video element is the default 300#xd7;150 before metadata is
-loaded, and 0#xd7;0 after metadata is loaded for an audio-only file.
+loaded, and also after metadata is loaded for an audio-only file.
/p
pre id=console/pre
script
Modified: trunk/Source/WebCore/ChangeLog (103097 => 103098)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 20:55:10 UTC (rev 103097)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 21:03:05 UTC (rev 103098)
@@ -1,3 +1,18 @@
+2011-12-16 Yael Aharon yael.aha...@nokia.com
+
+Audio file in video element has a size of 0x0 .
+https://bugs.webkit.org/show_bug.cgi?id=74738
+
+Reviewed by Kenneth Rohde Christiansen.
+
+When the source of a video element has audio only, the intrinsic size of the video should
+not be 0x0. Instead, it should be the same as as no media was loaded.
+
+No new tests. An existing test is covering this case and was modified to reflect this change.
+
+* rendering/RenderVideo.cpp:
+(WebCore::RenderVideo::calculateIntrinsicSize):
+
2011-12-16 Alexis Menard alexis.men...@openbossa.org
getComputedStyle for border-width is not implemented.
Modified: trunk/Source/WebCore/rendering/RenderVideo.cpp (103097 => 103098)
--- trunk/Source/WebCore/rendering/RenderVideo.cpp 2011-12-16 20:55:10 UTC (rev 103097)
+++ trunk/Source/WebCore/rendering/RenderVideo.cpp 2011-12-16 21:03:05 UTC (rev 103098)
@@ -113,8 +113,11 @@
// of the video resource, if that is available; otherwise it is the intrinsic
// height of the poster frame, if that is available; otherwise it is 150 CSS pixels.
MediaPlayer* player = mediaElement()-player();
-if (player video-readyState() = HTMLVideoElement::HAVE_METADATA)
-return player-naturalSize();
+if (player video-readyState() = HTMLVideoElement::HAVE_METADATA) {
+IntSize size = player-naturalSize();
+if (!size.isEmpty())
+return size;
+}
if (video
[webkit-changes] [95822] trunk/LayoutTests
Title: [95822] trunk/LayoutTests
Revision 95822
Author yael.aha...@nokia.com
Date 2011-09-23 09:47:26 -0700 (Fri, 23 Sep 2011)
Log Message
Fix typo in file name from http://trac.webkit.org/changeset/95813.
Unreviewed.
* platform/gtk/media/video-playing-and-pause-actual.txt: Removed.
* platform/gtk/media/video-playing-and-pause-expected.txt: Copied from LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/gtk/media/video-playing-and-pause-expected.txt
Removed Paths
trunk/LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (95821 => 95822)
--- trunk/LayoutTests/ChangeLog 2011-09-23 16:45:34 UTC (rev 95821)
+++ trunk/LayoutTests/ChangeLog 2011-09-23 16:47:26 UTC (rev 95822)
@@ -1,5 +1,14 @@
2011-09-23 Yael Aharon yael.aha...@nokia.com
+Fix typo in file name from http://trac.webkit.org/changeset/95813.
+
+Unreviewed.
+
+* platform/gtk/media/video-playing-and-pause-actual.txt: Removed.
+* platform/gtk/media/video-playing-and-pause-expected.txt: Copied from LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt.
+
+2011-09-23 Yael Aharon yael.aha...@nokia.com
+
Rebaseline after http://trac.webkit.org/changeset/95799
Unreviewed.
Deleted: trunk/LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt (95821 => 95822)
--- trunk/LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt 2011-09-23 16:45:34 UTC (rev 95821)
+++ trunk/LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt 2011-09-23 16:47:26 UTC (rev 95822)
@@ -1,34 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x322
- RenderBlock {HTML} at (0,0) size 800x322
-RenderBody {BODY} at (8,16) size 784x298
- RenderBlock {P} at (0,0) size 784x38
-RenderText {#text} at (0,0) size 766x38
- text run at (0,0) width 766: Test that pausing the media element in \playing\ event handler pauses the media immediately. The video should show the
- text run at (0,19) width 68: first frame.
- RenderBlock (anonymous) at (0,54) size 784x244
-RenderText {#text} at (0,0) size 0x0
-layer at (8,70) size 320x240
- RenderVideo {VIDEO} at (0,0) size 320x240
-layer at (8,70) size 320x240
- RenderBlock (relative positioned) {DIV} at (0,0) size 320x240
-layer at (8,70) size 320x240 scrollHeight 251
- RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,0) size 320x240
-RenderButton {INPUT} at (0,220) size 20x20
-RenderDeprecatedFlexibleBox {DIV} at (20,220) size 220x20 [border: (1px solid #FF33) none (1px solid #FF33)]
- RenderBlock (anonymous) at (1,0) size 65x31
-RenderDeprecatedFlexibleBox {DIV} at (0,1) size 65x30
- RenderBlock (anonymous) at (5,5) size 55x20
-RenderText {#text} at (0,0) size 55x12
- text run at (0,0) width 55: 00:00 / 00:06
- RenderSlider {INPUT} at (66,0) size 153x20
-RenderDeprecatedFlexibleBox {DIV} at (2,0) size 149x20
- RenderBlock {DIV} at (0,4) size 137x12
- RenderBlock {DIV} at (137,4) size 12x12
-RenderButton {INPUT} at (240,220) size 20x20
-RenderButton {INPUT} at (260,220) size 20x20
-RenderButton {INPUT} at (280,220) size 20x20
-RenderButton {INPUT} at (300,220) size 20x20
-layer at (104,294) size 12x12
- RenderBlock (relative positioned) {DIV} at (0,0) size 12x12
Copied: trunk/LayoutTests/platform/gtk/media/video-playing-and-pause-expected.txt (from rev 95815, trunk/LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt) (0 => 95822)
--- trunk/LayoutTests/platform/gtk/media/video-playing-and-pause-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/media/video-playing-and-pause-expected.txt 2011-09-23 16:47:26 UTC (rev 95822)
@@ -0,0 +1,34 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x322
+ RenderBlock {HTML} at (0,0) size 800x322
+RenderBody {BODY} at (8,16) size 784x298
+ RenderBlock {P} at (0,0) size 784x38
+RenderText {#text} at (0,0) size 766x38
+ text run at (0,0) width 766: Test that pausing the media element in \playing\ event handler pauses the media immediately. The video should show the
+ text run at (0,19) width 68: first frame.
+ RenderBlock (anonymous) at (0,54) size 784x244
+RenderText {#text} at (0,0) size 0x0
+layer at (8,70) size 320x240
+ RenderVideo {VIDEO} at (0,0) size 320x240
+layer at (8,70) size 320x240
+ RenderBlock (relative positioned) {DIV} at (0,0) size 320x240
+layer at (8,70) size 320x240 scrollHeight 251
+ RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,0) size 320x240
+RenderButton {INPUT} at (0,220) size 20x20
+RenderDeprecatedFlexibleBox {DIV} at (20,220) size 220x20 [bor
[webkit-changes] [92480] trunk
Title: [92480] trunk
Revision 92480
Author yael.aha...@nokia.com
Date 2011-08-05 07:36:33 -0700 (Fri, 05 Aug 2011)
Log Message
dir=auto needs to work on value of input and textarea elements
https://bugs.webkit.org/show_bug.cgi?id=65428
Reviewed by Darin Adler.
Source/WebCore:
Changed the directionality algorithm to evaluate the value of input elements and textarea elements when
they have the attribute dir-auto Set.
Also skip these elements when evaluating the directionality of their ancestors.
HTMLTextAreaElement::childrenChanged is not called when a user types into the textarea, so call
calculateAndAdjustDirectionality() explicitly from HTMLTextAreaElement::subtreeHasChanged().
HTMLInputElement::childrenChanged is not called when a user types into the textarea, so call
calculateAndAdjustDirectionality() explicitly from HTMLTextAreaElement::subtreeHasChanged().
Tests: fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control.html
fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html
fast/dom/HTMLElement/attr-dir-auto-text-form-control.html
* html/HTMLElement.cpp:
(WebCore::HTMLElement::directionality):
* html/HTMLElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::subtreeHasChanged):
LayoutTests:
* fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control-expected.txt: Added.
* fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control.html: Added.
* fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt: Added.
* fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html: Added.
* fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt: Added.
* fast/dom/HTMLElement/attr-dir-auto-text-form-control.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/html/HTMLElement.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLTextAreaElement.cpp
Added Paths
trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-text-form-control-expected.txt
trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-text-form-control.html
trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt
trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html
trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt
trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-text-form-control.html
Diff
Modified: trunk/LayoutTests/ChangeLog (92479 => 92480)
--- trunk/LayoutTests/ChangeLog 2011-08-05 14:17:23 UTC (rev 92479)
+++ trunk/LayoutTests/ChangeLog 2011-08-05 14:36:33 UTC (rev 92480)
@@ -1,3 +1,17 @@
+2011-08-05 Yael Aharon yael.aha...@nokia.com
+
+dir=auto needs to work on value of input and textarea elements
+https://bugs.webkit.org/show_bug.cgi?id=65428
+
+Reviewed by Darin Adler.
+
+* fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control-expected.txt: Added.
+* fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control.html: Added.
+* fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt: Added.
+* fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html: Added.
+* fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt: Added.
+* fast/dom/HTMLElement/attr-dir-auto-text-form-control.html: Added.
+
2011-08-05 Vsevolod Vlasov vse...@chromium.org
[Qt]Web Inspector: REGRESSION(r91928): It made 2 tests fail
Added: trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-text-form-control-expected.txt (0 => 92480)
--- trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-text-form-control-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-text-form-control-expected.txt 2011-08-05 14:36:33 UTC (rev 92480)
@@ -0,0 +1,21 @@
+Test that directionality is re-evaluated when dir attribute changes.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+
+
+
+
+PASS document.defaultView.getComputedStyle(el, null).getPropertyValue('border-right-color') is 'rgb(0, 128, 0)'
+PASS document.defaultView.getComputedStyle(el, null).getPropertyValue('border-right-color') is 'rgb(255, 0, 0)'
+PASS document.defaultView.getComputedStyle(el, null).getPropertyValue('border-right-color') is 'rgb(0, 128, 0)'
+PASS document.defaultView.getComputedStyle(el, null).getPropertyValue('border-right-color') is 'rgb(255, 0, 0)'
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+
+
+
Added: trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-text-form-control.html (0 => 92480)
--- trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-text-form-control.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-text-form-control.html 2011-08-05 14:36:33
[webkit-changes] [92416] trunk/LayoutTests
Title: [92416] trunk/LayoutTests Revision 92416 Author yael.aha...@nokia.com Date 2011-08-04 14:50:51 -0700 (Thu, 04 Aug 2011) Log Message [Qt] 69 tests failing after http://trac.webkit.org/changeset/92375 https://bugs.webkit.org/show_bug.cgi?id=65721 Unreviewed. Skipping tests until rebaseline. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92415 => 92416) --- trunk/LayoutTests/ChangeLog 2011-08-04 21:50:03 UTC (rev 92415) +++ trunk/LayoutTests/ChangeLog 2011-08-04 21:50:51 UTC (rev 92416) @@ -1,3 +1,14 @@ +2011-08-04 Yael Aharon yael.aha...@nokia.com + +[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375 +https://bugs.webkit.org/show_bug.cgi?id=65721 + +Unreviewed. + +Skipping tests until rebaseline. + +* platform/qt/Skipped: + 2011-08-04 Sergey Glazunov serg.glazu...@gmail.com Fix integer overflow in custom bindings for WebGLRenderingContext Modified: trunk/LayoutTests/platform/qt/Skipped (92415 => 92416) --- trunk/LayoutTests/platform/qt/Skipped 2011-08-04 21:50:03 UTC (rev 92415) +++ trunk/LayoutTests/platform/qt/Skipped 2011-08-04 21:50:51 UTC (rev 92416) @@ -2250,3 +2250,76 @@ # This test tickles another crasher on Qt. fast/loader/reload-zero-byte-plugin.html + +# Failing after http://trac.webkit.org/changeset/92375 +# https://bugs.webkit.org/show_bug.cgi?id=65721 +http/tests/navigation/_javascript_link-frames.html +tables/mozilla/bugs/bug28928.html +fast/forms/button-sizes.html +fast/forms/control-restrict-line-height.html +fast/forms/select-baseline.html +tables/mozilla/bugs/bug2479-3.html +tables/mozilla/bugs/bug1318.html +fast/replaced/table-percent-height.html +tables/mozilla/bugs/bug26178.html +svg/custom/inline-svg-in-xhtml.xml +fast/forms/button-text-transform.html +fast/forms/button-style-color.html +tables/mozilla/bugs/bug46368-2.html +editing/selection/4397952.html +editing/selection/3690719.html +fast/replaced/replaced-breaking.html +fast/block/positioning/inline-block-relposition.html +fast/forms/formmove3.html +fast/html/details-replace-text.html +fast/forms/basic-buttons.html +fast/forms/input-button-sizes.html +fast/forms/button-cannot-be-nested.html +tables/mozilla/bugs/bug51037.html +fast/forms/control-clip-overflow.html +tables/mozilla/bugs/bug39209.html +fast/css/margin-top-bottom-dynamic.html +tables/mozilla_expected_failures/bugs/bug58402-2.html +fast/forms/button-table-styles.html +tables/mozilla/bugs/bug1188.html +tables/mozilla_expected_failures/bugs/bug1725.html +tables/mozilla/collapsing_borders/bug41262-4.html +fast/html/details-replace-summary-child.html +svg/custom/foreign-object-skew.svg +tables/mozilla/bugs/bug68912.html +fast/text/textIteratorNilRenderer.html +tables/mozilla/bugs/bug138725.html +fast/forms/targeted-frame-submission.html +editing/selection/3690703-2.html +fast/block/float/float-avoidance.html +fast/forms/button-generated-content.html +tables/mozilla/bugs/bug44505.html +tables/mozilla/bugs/bug92647-2.html +tables/mozilla/bugs/bug60749.html +fast/dom/HTMLTableColElement/resize-table-using-col-width.html +tables/mozilla/other/move_row.html +fast/replaced/width100percent-button.html +fast/table/remove-td-display-none.html +tables/mozilla/bugs/bug33855.html +tables/mozilla/bugs/bug7342.html +fast/dynamic/positioned-movement-with-positioned-children.html +fast/selectors/064.html +fast/forms/button-inner-block-reuse.html +tables/mozilla_expected_failures/collapsing_borders/bug41262-5.html +fast/forms/blankbuttons.html +tables/mozilla/dom/tableDom.html +fast/forms/button-positioned.html +editing/selection/3690703.html +fast/forms/button-align.html +tables/mozilla/bugs/bug51727.html +tables/mozilla/bugs/bug52506.html +fast/table/append-cells2.html +platform/qt/fast/forms/button-line-break.html +editing/selection/5240265.html +fast/css/continuationCrash.html +tables/mozilla/bugs/bug18359.html +tables/mozilla/bugs/bug46368-1.html +tables/mozilla/bugs/bug4429.html +tables/mozilla/bugs/bug52505.html +tables/mozilla_expected_failures/collapsing_borders/bug41262-6.html + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91463] trunk/Source/WebKit2
Title: [91463] trunk/Source/WebKit2
Revision 91463
Author yael.aha...@nokia.com
Date 2011-07-21 06:39:34 -0700 (Thu, 21 Jul 2011)
Log Message
[Qt][WK2] Code cleanup for drag-and-drop
https://bugs.webkit.org/show_bug.cgi?id=64916
Reviewed by Andreas Kling.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::startDrag):
Allow receiving a NULL bitmap from the web process.
* UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::handleEvent):
Fix typo introduced in http://trac.webkit.org/changeset/90458.
All DnD related events should be GraphicsScene events.
* WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
(WebKit::convertQPixmapToShareableBitmap):
Remove hack that creates a 1x1 bitmap.
It is no longer needed after http://trac.webkit.org/changeset/91016.
(WebKit::WebDragClient::startDrag):
Allow sending a NULL bitmap to the UI process.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (91462 => 91463)
--- trunk/Source/WebKit2/ChangeLog 2011-07-21 13:28:12 UTC (rev 91462)
+++ trunk/Source/WebKit2/ChangeLog 2011-07-21 13:39:34 UTC (rev 91463)
@@ -1,3 +1,27 @@
+2011-07-21 Yael Aharon yael.aha...@nokia.com
+
+[Qt][WK2] Code cleanup for drag-and-drop
+https://bugs.webkit.org/show_bug.cgi?id=64916
+
+Reviewed by Andreas Kling.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::startDrag):
+Allow receiving a NULL bitmap from the web process.
+
+* UIProcess/qt/qdesktopwebpageproxy.cpp:
+(QDesktopWebPageProxy::handleEvent):
+Fix typo introduced in http://trac.webkit.org/changeset/90458.
+All DnD related events should be GraphicsScene events.
+
+* WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
+(WebKit::convertQPixmapToShareableBitmap):
+Remove hack that creates a 1x1 bitmap.
+It is no longer needed after http://trac.webkit.org/changeset/91016.
+
+(WebKit::WebDragClient::startDrag):
+Allow sending a NULL bitmap to the UI process.
+
2011-07-20 Tim Horton timothy_hor...@apple.com
Scrollbar color heuristic needs to be hooked up in WebKit1
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (91462 => 91463)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-07-21 13:28:12 UTC (rev 91462)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-07-21 13:39:34 UTC (rev 91463)
@@ -892,9 +892,12 @@
#if PLATFORM(QT)
void WebPageProxy::startDrag(const DragData dragData, const ShareableBitmap::Handle dragImageHandle)
{
-RefPtrShareableBitmap dragImage = ShareableBitmap::create(dragImageHandle);
-if (!dragImage)
-return;
+RefPtrShareableBitmap dragImage = 0;
+if (!dragImageHandle.isNull()) {
+dragImage = ShareableBitmap::create(dragImageHandle);
+if (!dragImage)
+return;
+}
m_pageClient-startDrag(dragData, dragImage.release());
}
Modified: trunk/Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.cpp (91462 => 91463)
--- trunk/Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.cpp 2011-07-21 13:28:12 UTC (rev 91462)
+++ trunk/Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.cpp 2011-07-21 13:39:34 UTC (rev 91463)
@@ -93,13 +93,13 @@
return handleWheelEvent(reinterpret_castQGraphicsSceneWheelEvent*(ev));
case QEvent::GraphicsSceneHoverMove:
return handleHoverMoveEvent(reinterpret_castQGraphicsSceneHoverEvent*(ev));
-case QEvent::DragEnter:
+case QEvent::GraphicsSceneDragEnter:
return handleDragEnterEvent(reinterpret_castQGraphicsSceneDragDropEvent*(ev));
-case QEvent::DragLeave:
+case QEvent::GraphicsSceneDragLeave:
return handleDragLeaveEvent(reinterpret_castQGraphicsSceneDragDropEvent*(ev));
-case QEvent::DragMove:
+case QEvent::GraphicsSceneDragMove:
return handleDragMoveEvent(reinterpret_castQGraphicsSceneDragDropEvent*(ev));
-case QEvent::Drop:
+case QEvent::GraphicsSceneDrop:
return handleDropEvent(reinterpret_castQGraphicsSceneDragDropEvent*(ev));
}
return QtWebPageProxy::handleEvent(ev);
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp (91462 => 91463)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp 2011-07-21 13:28:12 UTC (rev 91462)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp 2011-07-21 13:39:34 UTC (rev 91463)
@@ -40,15 +40,13 @@
static PassRefPtrShareableBitmap convertQPixmapToShareableBitmap(QPixmap* pixmap)
{
-// FIXME: We need this hack until https://bugs.webkit.org/show_bug.cgi?id=60621 is fixed.
-// We cannot pass a null handle so create a pixmap size 1x1 and send that instead.
-QPixmap
[webkit-changes] [90741] trunk/LayoutTests
Title: [90741] trunk/LayoutTests
Revision 90741
Author yael.aha...@nokia.com
Date 2011-07-11 06:54:21 -0700 (Mon, 11 Jul 2011)
Log Message
[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
https://bugs.webkit.org/show_bug.cgi?id=63255
Reviewed by Csaba Osztrogonác.
Modify the tests to wait until the icon loading is finished.
* fast/notifications/notifications-double-show.html:
* fast/notifications/notifications-with-permission.html:
* platform/qt/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/notifications/notifications-double-show.html
trunk/LayoutTests/fast/notifications/notifications-with-permission.html
trunk/LayoutTests/platform/qt/Skipped
Diff
Modified: trunk/LayoutTests/ChangeLog (90740 => 90741)
--- trunk/LayoutTests/ChangeLog 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/ChangeLog 2011-07-11 13:54:21 UTC (rev 90741)
@@ -1,3 +1,16 @@
+2011-07-11 Yael Aharon yael.aha...@nokia.com
+
+[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
+https://bugs.webkit.org/show_bug.cgi?id=63255
+
+Reviewed by Csaba Osztrogonác.
+
+Modify the tests to wait until the icon loading is finished.
+
+* fast/notifications/notifications-double-show.html:
+* fast/notifications/notifications-with-permission.html:
+* platform/qt/Skipped:
+
2011-07-11 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed gardening.
Modified: trunk/LayoutTests/fast/notifications/notifications-double-show.html (90740 => 90741)
--- trunk/LayoutTests/fast/notifications/notifications-double-show.html 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/fast/notifications/notifications-double-show.html 2011-07-11 13:54:21 UTC (rev 90741)
@@ -12,6 +12,7 @@
if (window.layoutTestController) {
layoutTestController.grantDesktopNotificationPermission(file://);
layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
}
if (!window.webkitNotifications) {
@@ -19,6 +20,7 @@
}
var N = window.webkitNotifications.createNotification(http://localhost/my_icon.png, New E-mail, Meet me tonight at 8!);
+N._ondisplay_ = function() { layoutTestController.notifyDone(); }
N.show();
N.show();
}
Modified: trunk/LayoutTests/fast/notifications/notifications-with-permission.html (90740 => 90741)
--- trunk/LayoutTests/fast/notifications/notifications-with-permission.html 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/fast/notifications/notifications-with-permission.html 2011-07-11 13:54:21 UTC (rev 90741)
@@ -12,6 +12,7 @@
if (window.layoutTestController) {
layoutTestController.grantDesktopNotificationPermission(file://);
layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
}
if (!window.webkitNotifications) {
@@ -22,6 +23,7 @@
N.show();
var M = window.webkitNotifications.createNotification(http://localhost/my_icon.png, New E-mail, Meet me tonight at 8!);
+M._ondisplay_ = function() { layoutTestController.notifyDone(); }
M.show();
}
/script
Modified: trunk/LayoutTests/platform/qt/Skipped (90740 => 90741)
--- trunk/LayoutTests/platform/qt/Skipped 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-07-11 13:54:21 UTC (rev 90741)
@@ -2156,13 +2156,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=53868
fast/notifications/notifications-document-close-crash.html
-# [Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
-# https://bugs.webkit.org/show_bug.cgi?id=63255
-fast/notifications/notifications-no-icon.html
-fast/notifications/notifications-double-show.html
-fast/notifications/notifications-with-permission.html
-fast/notifications/notifications-without-permission.html
-
# [Qt]REGRESSION(r78846): editing/selection/mixed-editability-10.html
# https://bugs.webkit.org/show_bug.cgi?id=54725
editing/selection/mixed-editability-10.html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89516] trunk/Source
Title: [89516] trunk/Source
Revision 89516
Author yael.aha...@nokia.com
Date 2011-06-22 18:36:42 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Yael Aharon yael.aha...@nokia.com
Reviewed by Andreas Kling.
[Qt] Add a build flag for building with libxml2 and libxslt.
https://bugs.webkit.org/show_bug.cgi?id=63113
* wtf/Platform.h:
2011-06-22 Yael Aharon yael.aha...@nokia.com
Reviewed by Andreas Kling.
[Qt] Add a build flag for building with libxml2 and libxslt.
https://bugs.webkit.org/show_bug.cgi?id=63113
No new tests. If this new flag was set by default, we could unskip
existing xmlviewer tests.
* CodeGenerators.pri:
* WebCore.pri:
* WebCore.pro:
* features.pri:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/CodeGenerators.pri
trunk/Source/WebCore/WebCore.pri
trunk/Source/WebCore/WebCore.pro
trunk/Source/WebCore/features.pri
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (89515 => 89516)
--- trunk/Source/_javascript_Core/ChangeLog 2011-06-23 01:34:11 UTC (rev 89515)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-06-23 01:36:42 UTC (rev 89516)
@@ -1,3 +1,12 @@
+2011-06-22 Yael Aharon yael.aha...@nokia.com
+
+Reviewed by Andreas Kling.
+
+[Qt] Add a build flag for building with libxml2 and libxslt.
+https://bugs.webkit.org/show_bug.cgi?id=63113
+
+* wtf/Platform.h:
+
2011-06-22 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r89489.
Modified: trunk/Source/_javascript_Core/wtf/Platform.h (89515 => 89516)
--- trunk/Source/_javascript_Core/wtf/Platform.h 2011-06-23 01:34:11 UTC (rev 89515)
+++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-06-23 01:36:42 UTC (rev 89516)
@@ -1117,9 +1117,11 @@
/* Use the QXmlStreamReader implementation for XMLDocumentParser */
/* Use the QXmlQuery implementation for XSLTProcessor */
#if PLATFORM(QT)
+#if !USE(LIBXML2)
#define WTF_USE_QXMLSTREAM 1
#define WTF_USE_QXMLQUERY 1
#endif
+#endif
#if PLATFORM(MAC)
/* Complex text framework */
Modified: trunk/Source/WebCore/ChangeLog (89515 => 89516)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 01:34:11 UTC (rev 89515)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 01:36:42 UTC (rev 89516)
@@ -1,3 +1,18 @@
+2011-06-22 Yael Aharon yael.aha...@nokia.com
+
+Reviewed by Andreas Kling.
+
+[Qt] Add a build flag for building with libxml2 and libxslt.
+https://bugs.webkit.org/show_bug.cgi?id=63113
+
+No new tests. If this new flag was set by default, we could unskip
+existing xmlviewer tests.
+
+* CodeGenerators.pri:
+* WebCore.pri:
+* WebCore.pro:
+* features.pri:
+
2011-06-22 Ryosuke Niwa rn...@webkit.org
Yet another build fix after r89472.
Modified: trunk/Source/WebCore/CodeGenerators.pri (89515 => 89516)
--- trunk/Source/WebCore/CodeGenerators.pri 2011-06-23 01:34:11 UTC (rev 89515)
+++ trunk/Source/WebCore/CodeGenerators.pri 2011-06-23 01:36:42 UTC (rev 89516)
@@ -22,6 +22,13 @@
CSSBISON = $$PWD/css/CSSGrammar.y
+contains(DEFINES, ENABLE_XSLT=1) {
+contains(DEFINES, WTF_USE_LIBXML2=1) {
+XMLVIEWER_CSS = $$PWD/xml/XMLViewer.css
+XMLVIEWER_JS = $$PWD/xml/XMLViewer.js
+}
+}
+
HTML_NAMES = $$PWD/html/HTMLTagNames.in
XML_NAMES = $$PWD/xml/xmlattrs.in
@@ -777,6 +784,30 @@
colordata.depends = $$PWD/make-hash-tools.pl
addExtraCompiler(colordata)
+contains(DEFINES, ENABLE_XSLT=1) {
+contains(DEFINES, WTF_USE_LIBXML2=1) {
+# GENERATOR 8-D:
+xmlviewercss.output = $${WC_GENERATED_SOURCES_DIR}/XMLViewerCSS.h
+xmlviewercss.input = XMLVIEWER_CSS
+xmlviewercss.wkScript = $$PWD/inspector/xxd.pl
+xmlviewercss.commands = perl $$xmlviewercss.wkScript XMLViewer_css $$XMLVIEWER_CSS $${WC_GENERATED_SOURCES_DIR}/XMLViewerCSS.h
+xmlviewercss.clean = ${QMAKE_FILE_OUT}
+xmlviewercss.depends = $$PWD/inspector/xxd.pl
+xmlviewercss.wkAddOutputToSources = false
+addExtraCompiler(xmlviewercss)
+
+# GENERATOR 8-E:
+xmlviewerjs.output = $${WC_GENERATED_SOURCES_DIR}/XMLViewerJS.h
+xmlviewerjs.input = XMLVIEWER_JS
+xmlviewerjs.wkScript = $$PWD/inspector/xxd.pl
+xmlviewerjs.commands = perl $$xmlviewerjs.wkScript XMLViewer_js $$XMLVIEWER_JS $${WC_GENERATED_SOURCES_DIR}/XMLViewerJS.h
+xmlviewerjs.clean = ${QMAKE_FILE_OUT}
+xmlviewerjs.depends = $$PWD/inspector/xxd.pl
+xmlviewerjs.wkAddOutputToSources = false
+addExtraCompiler(xmlviewerjs)
+}
+}
+
# GENERATOR 9:
stylesheets.wkScript = $$PWD/css/make-css-file-arrays.pl
stylesheets.output = $${WC_GENERATED_SOURCES_DIR}/UserAgentStyleSheetsData.cpp
Modified: trunk/Source/WebCore/WebCore.pri (89515 => 89516)
--- trunk/Source/WebCore/WebCore.pri 2011-06-23 01:34:11 UTC (rev 89515)
+++ trunk/Source/WebCore/WebCore.pri 2011-06-23 01:36:42 UTC (rev 89516)
@@
[webkit-changes] [89524] trunk/Source/WebCore
Title: [89524] trunk/Source/WebCore
Revision 89524
Author yael.aha...@nokia.com
Date 2011-06-22 20:26:53 -0700 (Wed, 22 Jun 2011)
Log Message
Unreviewed build fix after r89472.
No new tests, just a build fix.
* rendering/InlineBox.cpp:
* rendering/RenderCounter.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineBox.cpp
trunk/Source/WebCore/rendering/RenderCounter.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89523 => 89524)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 03:07:58 UTC (rev 89523)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 03:26:53 UTC (rev 89524)
@@ -1,3 +1,12 @@
+2011-06-22 Yael Aharon yael.aha...@nokia.com
+
+Unreviewed build fix after r89472.
+
+No new tests, just a build fix.
+
+* rendering/InlineBox.cpp:
+* rendering/RenderCounter.cpp:
+
2011-06-22 Dimitri Glazkov dglaz...@chromium.org
Reviewed by Kent Tamura.
Modified: trunk/Source/WebCore/rendering/InlineBox.cpp (89523 => 89524)
--- trunk/Source/WebCore/rendering/InlineBox.cpp 2011-06-23 03:07:58 UTC (rev 89523)
+++ trunk/Source/WebCore/rendering/InlineBox.cpp 2011-06-23 03:26:53 UTC (rev 89524)
@@ -27,6 +27,10 @@
#include RenderBlock.h
#include RootInlineBox.h
+#ifndef NDEBUG
+#include stdio.h
+#endif
+
using namespace std;
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/RenderCounter.cpp (89523 => 89524)
--- trunk/Source/WebCore/rendering/RenderCounter.cpp 2011-06-23 03:07:58 UTC (rev 89523)
+++ trunk/Source/WebCore/rendering/RenderCounter.cpp 2011-06-23 03:26:53 UTC (rev 89524)
@@ -32,6 +32,10 @@
#include RenderStyle.h
#include wtf/StdLibExtras.h
+#ifndef NDEBUG
+#include stdio.h
+#endif
+
namespace WebCore {
using namespace HTMLNames;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89525] trunk/Source/WebCore
Title: [89525] trunk/Source/WebCore
Revision 89525
Author yael.aha...@nokia.com
Date 2011-06-22 20:49:06 -0700 (Wed, 22 Jun 2011)
Log Message
Another unreviewed build fix after r89472.
No new tests, just a build fix.
* rendering/svg/SVGResources.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGResources.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89524 => 89525)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 03:26:53 UTC (rev 89524)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 03:49:06 UTC (rev 89525)
@@ -1,5 +1,13 @@
2011-06-22 Yael Aharon yael.aha...@nokia.com
+Another unreviewed build fix after r89472.
+
+No new tests, just a build fix.
+
+* rendering/svg/SVGResources.cpp:
+
+2011-06-22 Yael Aharon yael.aha...@nokia.com
+
Unreviewed build fix after r89472.
No new tests, just a build fix.
Modified: trunk/Source/WebCore/rendering/svg/SVGResources.cpp (89524 => 89525)
--- trunk/Source/WebCore/rendering/svg/SVGResources.cpp 2011-06-23 03:26:53 UTC (rev 89524)
+++ trunk/Source/WebCore/rendering/svg/SVGResources.cpp 2011-06-23 03:49:06 UTC (rev 89525)
@@ -33,6 +33,10 @@
#include SVGRenderStyle.h
#include SVGURIReference.h
+#ifndef NDEBUG
+#include stdio.h
+#endif
+
namespace WebCore {
SVGResources::SVGResources()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89369] trunk/Source/WebKit/qt
Title: [89369] trunk/Source/WebKit/qt
Revision 89369
Author yael.aha...@nokia.com
Date 2011-06-21 12:18:11 -0700 (Tue, 21 Jun 2011)
Log Message
2011-06-21 Yael Aharon yael.aha...@nokia.com
Reviewed by Andreas Kling.
[Qt] Regression(60942) wrong default action for drag-and-drop.
https://bugs.webkit.org/show_bug.cgi?id=63004
Added special handling for the case that dragOperation is not initialized.
Save the last dropOperation and pass it to the dropEvent, so that it can
be accepted by QDrag.
Call event-accepted() and not event-acceptProposedAction(), because the
later ignores the dropAction specified in _javascript_.
Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401
and did not see any issue.
Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html
and they all pass.
* Api/qwebpage.cpp:
(dropActionToDragOp):
(QWebPagePrivate::dragMoveEvent):
(QWebPagePrivate::dropEvent):
Modified Paths
trunk/Source/WebKit/qt/Api/qwebpage.cpp
trunk/Source/WebKit/qt/ChangeLog
Diff
Modified: trunk/Source/WebKit/qt/Api/qwebpage.cpp (89368 => 89369)
--- trunk/Source/WebKit/qt/Api/qwebpage.cpp 2011-06-21 18:16:35 UTC (rev 89368)
+++ trunk/Source/WebKit/qt/Api/qwebpage.cpp 2011-06-21 19:18:11 UTC (rev 89369)
@@ -269,6 +269,8 @@
result |= (DragOperationMove | DragOperationGeneric);
if (actions Qt::LinkAction)
result |= DragOperationLink;
+if (result == (DragOperationCopy | DragOperationMove | DragOperationGeneric | DragOperationLink))
+result = DragOperationEvery;
return (DragOperation)result;
}
@@ -315,6 +317,7 @@
, inspectorFrontend(0)
, inspector(0)
, inspectorIsInternalOnly(false)
+, m_lastDropAction(Qt::IgnoreAction)
{
WebCore::InitializeLoggingChannelsIfNecessary();
ScriptController::initializeThreading();
@@ -1015,10 +1018,10 @@
#ifndef QT_NO_DRAGANDDROP
DragData dragData(ev-mimeData(), QPointF(ev-pos()).toPoint(),
QCursor::pos(), dropActionToDragOp(ev-possibleActions()));
-Qt::DropAction action = ""
-ev-setDropAction(action);
-if (action != Qt::IgnoreAction)
-ev-acceptProposedAction();
+m_lastDropAction = dragOpToDropAction(page-dragController()-dragUpdated(dragData));
+ev-setDropAction(m_lastDropAction);
+if (m_lastDropAction != Qt::IgnoreAction)
+ev-accept();
#endif
}
@@ -1028,8 +1031,10 @@
#ifndef QT_NO_DRAGANDDROP
DragData dragData(ev-mimeData(), QPointF(ev-pos()).toPoint(),
QCursor::pos(), dropActionToDragOp(ev-possibleActions()));
-if (page-dragController()-performDrag(dragData))
-ev-acceptProposedAction();
+if (page-dragController()-performDrag(dragData)) {
+ev-setDropAction(m_lastDropAction);
+ev-accept();
+}
#endif
}
Modified: trunk/Source/WebKit/qt/ChangeLog (89368 => 89369)
--- trunk/Source/WebKit/qt/ChangeLog 2011-06-21 18:16:35 UTC (rev 89368)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-06-21 19:18:11 UTC (rev 89369)
@@ -1,3 +1,26 @@
+2011-06-21 Yael Aharon yael.aha...@nokia.com
+
+Reviewed by Andreas Kling.
+
+[Qt] Regression(60942) wrong default action for drag-and-drop.
+https://bugs.webkit.org/show_bug.cgi?id=63004
+
+Added special handling for the case that dragOperation is not initialized.
+Save the last dropOperation and pass it to the dropEvent, so that it can
+be accepted by QDrag.
+Call event-accepted() and not event-acceptProposedAction(), because the
+later ignores the dropAction specified in _javascript_.
+
+Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401
+and did not see any issue.
+Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html
+and they all pass.
+
+* Api/qwebpage.cpp:
+(dropActionToDragOp):
+(QWebPagePrivate::dragMoveEvent):
+(QWebPagePrivate::dropEvent):
+
2011-06-20 Pavel Feldman pfeld...@chromium.org
Reviewed by Yury Semikhatsky.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89384] trunk/Source/WebKit2
Title: [89384] trunk/Source/WebKit2
Revision 89384
Author yael.aha...@nokia.com
Date 2011-06-21 14:31:56 -0700 (Tue, 21 Jun 2011)
Log Message
[Qt] Add an internal API for accessing the QGraphicsView.
https://bugs.webkit.org/show_bug.cgi?id=63095
Reviewed by Kenneth Rohde Christiansen.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::ownerWidget):
* UIProcess/API/qt/qwkpage_p.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qwkpage.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qwkpage_p.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (89383 => 89384)
--- trunk/Source/WebKit2/ChangeLog 2011-06-21 21:20:15 UTC (rev 89383)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-21 21:31:56 UTC (rev 89384)
@@ -1,3 +1,14 @@
+2011-06-21 Yael Aharon yael.aha...@nokia.com
+
+Reviewed by Kenneth Rohde Christiansen.
+
+[Qt] Add an internal API for accessing the QGraphicsView.
+https://bugs.webkit.org/show_bug.cgi?id=63095
+
+* UIProcess/API/qt/qwkpage.cpp:
+(QWKPagePrivate::ownerWidget):
+* UIProcess/API/qt/qwkpage_p.h:
+
2011-06-21 Lukasz Slachciak l.slachc...@samsung.com
Reviewed by Sam Weinig.
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qwkpage.cpp (89383 => 89384)
--- trunk/Source/WebKit2/UIProcess/API/qt/qwkpage.cpp 2011-06-21 21:20:15 UTC (rev 89383)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qwkpage.cpp 2011-06-21 21:31:56 UTC (rev 89384)
@@ -306,6 +306,18 @@
notImplemented();
}
+QWidget* QWKPagePrivate::ownerWidget()
+{
+if (!view || !view-scene() || view-scene()-views().isEmpty())
+return 0;
+
+QListQGraphicsView* views = view-scene()-views();
+if (views.size() 1)
+qWarning(Cannot support multiple views);
+
+return views.at(0);
+}
+
void QWKPagePrivate::paint(QPainter* painter, QRect area)
{
if (page-isValid() page-drawingArea()) {
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qwkpage_p.h (89383 => 89384)
--- trunk/Source/WebKit2/UIProcess/API/qt/qwkpage_p.h 2011-06-21 21:20:15 UTC (rev 89383)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qwkpage_p.h 2011-06-21 21:31:56 UTC (rev 89384)
@@ -116,6 +116,8 @@
void updateNavigationActions();
void updateEditorActions();
+QWidget* ownerWidget();
+
void _q_webActionTriggered(bool checked);
void touchEvent(QTouchEvent*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88801] trunk/LayoutTests
Title: [88801] trunk/LayoutTests Revision 88801 Author yael.aha...@nokia.com Date 2011-06-14 07:38:30 -0700 (Tue, 14 Jun 2011) Log Message Unreviewed. progress should support :indeterminate pseudo-class https://bugs.webkit.org/show_bug.cgi?id=62430 Skip new tests since Windows port does not support the progress element. * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (88800 => 88801) --- trunk/LayoutTests/ChangeLog 2011-06-14 14:36:50 UTC (rev 88800) +++ trunk/LayoutTests/ChangeLog 2011-06-14 14:38:30 UTC (rev 88801) @@ -1,5 +1,16 @@ 2011-06-14 Yael Aharon yael.aha...@nokia.com +Unreviewed. + +progress should support :indeterminate pseudo-class +https://bugs.webkit.org/show_bug.cgi?id=62430 + +Skip new tests since Windows port does not support the progress element. + +* platform/win/Skipped: + +2011-06-14 Yael Aharon yael.aha...@nokia.com + Reviewed by Kent Tamura. progress should support :indeterminate pseudo-class Modified: trunk/LayoutTests/platform/win/Skipped (88800 => 88801) --- trunk/LayoutTests/platform/win/Skipped 2011-06-14 14:36:50 UTC (rev 88800) +++ trunk/LayoutTests/platform/win/Skipped 2011-06-14 14:38:30 UTC (rev 88801) @@ -940,6 +940,8 @@ fast/dom/HTMLProgressElement/progress-writing-mode.html fast/forms/form-attribute.html fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html +fast/dom/HTMLProgressElement/indeterminate-progress-001.html +fast/dom/HTMLProgressElement/indeterminate-progress-002.html # view mode media feature fast/media/view-mode-media-feature.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88175] trunk
Title: [88175] trunk
Revision 88175
Author yael.aha...@nokia.com
Date 2011-06-06 11:32:54 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Yael Aharon yael.aha...@nokia.com
Reviewed by Eric Seidel.
Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459
* fast/inline/inline-wrap-with-parent-padding.html: Added.
* platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
* platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
2011-06-06 Yael Aharon yael.aha...@nokia.com
Reviewed by Eric Seidel.
Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459
When an inline element has a right border/margin/padding and it has more than one descendant with no siblings,
the width of the right border/margin/padding should be included in line breaking calculation only once,
and not for each descendant.
Test: fast/inline/inline-wrap-with-parent-padding.html
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Added Paths
trunk/LayoutTests/fast/inline/inline-wrap-with-parent-padding.html
trunk/LayoutTests/platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png
trunk/LayoutTests/platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (88174 => 88175)
--- trunk/LayoutTests/ChangeLog 2011-06-06 18:03:05 UTC (rev 88174)
+++ trunk/LayoutTests/ChangeLog 2011-06-06 18:32:54 UTC (rev 88175)
@@ -1,3 +1,14 @@
+2011-06-06 Yael Aharon yael.aha...@nokia.com
+
+Reviewed by Eric Seidel.
+
+Inline elements are wrapped prematurely with non-zero border, margin or padding.
+https://bugs.webkit.org/show_bug.cgi?id=60459
+
+* fast/inline/inline-wrap-with-parent-padding.html: Added.
+* platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
+* platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
+
2011-06-06 Shishir Agrawal shis...@chromium.org
Reviewed by Tony Gentilcore.
Added: trunk/LayoutTests/fast/inline/inline-wrap-with-parent-padding.html (0 => 88175)
--- trunk/LayoutTests/fast/inline/inline-wrap-with-parent-padding.html (rev 0)
+++ trunk/LayoutTests/fast/inline/inline-wrap-with-parent-padding.html 2011-06-06 18:32:54 UTC (rev 88175)
@@ -0,0 +1,13 @@
+!DOCTYPE html
+html
+head
+style
+div { width: 320px; }
+/style
+/head
+body
+div style=border: 1px solid red
+span style=border: 1px solid green; padding-right: 15px-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span--/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span
+/div
+/body
+/html
\ No newline at end of file
Added: trunk/LayoutTests/platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png (0 => 88175)
--- trunk/LayoutTests/platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png 2011-06-06 18:32:54 UTC (rev 88175)
@@ -0,0 +1,11 @@
+\x89PNG
+
+
+IHDR X \x9Av\x82p )tEXtchecksum 7c887338f071fa5651edec9073daa043K\xB1\xDAl \xEEiCCPICC Profile x\x85T\xCFkA\xFE6n\xA9\xD0Zk\xB2x\x90IY\xABhE\xD46\xFDbk \xDB \xB6E\x90d3I\xD6n6\xEB\xEE\xB5\xA5\x88\xE4\xE2\xD1*\xDEE\xED\xA1\xFF\x80 z\xF0d/J\x85ZE(ޫ(b\xA1-\xF1\xCDnL\xB6\xA5\xEA\xC0\xCE~\xF3\xDE7\xEF}ov\xDF
+r\xD24\xF5\x80\xE4
+\xC7R\xA2il|Bj\xFC\x88 \x8E\xA2 A4%U\xDB\xECN$A\x83s\xF9{\xE7\xD8z\x81[V\xC3{\xFBw\xB2w\xAD\x9AҶ\x9A\x84\xFD@\xE0G\x9A\xD9*\xB0\xEFq
+Y\x88ߡ)\xC7t\xDF\xE3\xD8\xF2\xEC\x8F9Nyx\xC1\xB5+=\xC4Y|@5-\xCEM\xB8S\xCD%\xD3@\x83H8\x94\xF5qR\x9C\x94\xD7 inf\xC6\xC8\xBDO\x90\xA6\xBB\xCC\xEE\xABb\xA1\x9CN\xF6\x90\xBD\x9D\xF4~N\xB3\xDE\xC2!\xC2 \xAD?F\xB8\x8D\x9E\xF5\x8C\xD5?\xE2a\xE1\xA4\xE6Ć= 5\xF4\xF8`\xB7\xA9\xF85\xC2_M'\xA2Tq\xD9.
+\xF1\x98\xAE\xFDV\xF2J\x82p\x908\xCAda\x80sZHO\xD7Ln\xF8\xBA\x87}\xD7\xAF\xE2wVQ\xE1y\x8Fg\xDE\xD4\xDD\xEFE\xDA\xAF0 \x9A
+HPEa\x98\xB0P@\x8614\xB2r?#\xAB\x93{2u$j\xBBtbD\xB1A{6\xDC=\xB7Q\xA4\xDD\xFE(q\x94C\xB5\x92\xFCA\xFE*\xAF\xC9O\xE5y\xF9\xCB\\xB0\xD8V\x{1D4B5B}\x9A\xBA\xF2\xE0;\xC5噹 \xD7\xD3\xC8\xE3sM^|\x95\xD4v\x93WG\x96\xACyz\xBC\x9A\xEC?\xECW\x971\xE6\x825\x8F\xC4s\xB0\xFB\xF1-_\x95̗)\x8C\xC5\xE3U\xF3\xEAK\x84uZ17ߟl;=\xE2.\xCF.\xB5\xD6s\xAD\x89\x8B7V\x9B\x97g\xFDjH\xFB\x93\xE6U\xF9O^\xF5\xF1
[webkit-changes] [87499] trunk
Title: [87499] trunk Revision 87499 Author yael.aha...@nokia.com Date 2011-05-27 05:37:48 -0700 (Fri, 27 May 2011) Log Message webkit should implement the dropzone attribute https://bugs.webkit.org/show_bug.cgi?id=58210 Reviewed by Tony Chang. Source/WebCore: Add support for dropzone attribute. http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-dropzone-attribute If a drag event was not canceled by _javascript_, look for an element with a dropzone attribute. If there is such an element, and it matches the drag data store, set the action defined by that element and continue processing the drag and drop operation. Tests: fast/events/dropzone-001.html fast/events/dropzone-002.html fast/events/dropzone-003.html fast/events/dropzone-004.html * dom/Clipboard.cpp: (WebCore::Clipboard::hasFileOfType): (WebCore::Clipboard::hasStringOfType): (WebCore::convertDropZoneOperationToDragOperation): (WebCore::convertDragOperationToDropZoneOperation): (WebCore::Clipboard::processDropZoneKeyword): * dom/Clipboard.h: * html/HTMLAttributeNames.in: * html/HTMLElement.idl: * page/EventHandler.cpp: (WebCore::EventHandler::findDropZone): (WebCore::EventHandler::updateDragAndDrop): * page/EventHandler.h: LayoutTests: * fast/events/dropzone-001-expected.txt: Added. * fast/events/dropzone-001.html: Added. * fast/events/dropzone-002-expected.txt: Added. * fast/events/dropzone-002.html: Added. * fast/events/dropzone-003-expected.txt: Added. * fast/events/dropzone-003.html: Added. * fast/events/dropzone-004-expected.txt: Added. * fast/events/dropzone-004.html: Added. * fast/events/resources/dropzone.js: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Clipboard.cpp trunk/Source/WebCore/dom/Clipboard.h trunk/Source/WebCore/html/HTMLAttributeNames.in trunk/Source/WebCore/html/HTMLElement.idl trunk/Source/WebCore/page/EventHandler.cpp Added Paths trunk/LayoutTests/fast/events/dropzone-001-expected.txt trunk/LayoutTests/fast/events/dropzone-001.html trunk/LayoutTests/fast/events/dropzone-002-expected.txt trunk/LayoutTests/fast/events/dropzone-002.html trunk/LayoutTests/fast/events/dropzone-003-expected.txt trunk/LayoutTests/fast/events/dropzone-003.html trunk/LayoutTests/fast/events/dropzone-004-expected.txt trunk/LayoutTests/fast/events/dropzone-004.html trunk/LayoutTests/fast/events/resources/dropzone.js Diff Modified: trunk/LayoutTests/ChangeLog (87498 => 87499) --- trunk/LayoutTests/ChangeLog 2011-05-27 12:20:46 UTC (rev 87498) +++ trunk/LayoutTests/ChangeLog 2011-05-27 12:37:48 UTC (rev 87499) @@ -1,3 +1,20 @@ +2011-05-26 Yael Aharon yael.aha...@nokia.com + +Reviewed by Tony Chang. + +webkit should implement the dropzone attribute +https://bugs.webkit.org/show_bug.cgi?id=58210 + +* fast/events/dropzone-001-expected.txt: Added. +* fast/events/dropzone-001.html: Added. +* fast/events/dropzone-002-expected.txt: Added. +* fast/events/dropzone-002.html: Added. +* fast/events/dropzone-003-expected.txt: Added. +* fast/events/dropzone-003.html: Added. +* fast/events/dropzone-004-expected.txt: Added. +* fast/events/dropzone-004.html: Added. +* fast/events/resources/dropzone.js: Added. + 2011-05-27 Csaba Osztrogonác o...@webkit.org [Qt]http/tests/security/xss-DENIED-xsl-document.xml fails with Qt 4.8 Added: trunk/LayoutTests/fast/events/dropzone-001-expected.txt (0 => 87499) --- trunk/LayoutTests/fast/events/dropzone-001-expected.txt (rev 0) +++ trunk/LayoutTests/fast/events/dropzone-001-expected.txt 2011-05-27 12:37:48 UTC (rev 87499) @@ -0,0 +1,77 @@ +This test checks that drag-and-drop support works and conforms to the HTML 5 specification. +For each effectAllowed, iterates through the possible dropEffects: none, copy, move, link, dummy. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + + +When effectAllowed == uninitialized + +Received drop event for allowedEffect uninitialized and chosenDropEffect none +Received drop event for allowedEffect uninitialized and chosenDropEffect copy +Received drop event for allowedEffect uninitialized and chosenDropEffect move +Received drop event for allowedEffect uninitialized and chosenDropEffect link +Received drop event for allowedEffect uninitialized and chosenDropEffect dummy + +When effectAllowed == undefined + +Received drop event for allowedEffect undefined and chosenDropEffect none +Received drop event for allowedEffect undefined and chosenDropEffect copy +Received drop event for allowedEffect undefined and chosenDropEffect move +Received drop event for allowedEffect undefined and chosenDropEffect link +Received drop event for allowedEffect undefined and chosenDropEffect dummy + +When effectAllowed == none + + +When effectAllowed == all + +Received drop event for allowedEffe
[webkit-changes] [87503] trunk/LayoutTests
Title: [87503] trunk/LayoutTests Revision 87503 Author yael.aha...@nokia.com Date 2011-05-27 05:48:21 -0700 (Fri, 27 May 2011) Log Message Unreviewed. Skip new dropzone tests. Qt's DRT does not support drag 'n drop. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (87502 => 87503) --- trunk/LayoutTests/ChangeLog 2011-05-27 12:46:35 UTC (rev 87502) +++ trunk/LayoutTests/ChangeLog 2011-05-27 12:48:21 UTC (rev 87503) @@ -1,3 +1,11 @@ +2011-05-27 Yael Aharon yael.aha...@nokia.com + +Unreviewed. + +Skip new dropzone tests. Qt's DRT does not support drag 'n drop. + +* platform/qt/Skipped: + 2011-05-27 Csaba Osztrogonác o...@webkit.org [WK2] Skip new failing tests because of missing SVG animation pause API. Modified: trunk/LayoutTests/platform/qt/Skipped (87502 => 87503) --- trunk/LayoutTests/platform/qt/Skipped 2011-05-27 12:46:35 UTC (rev 87502) +++ trunk/LayoutTests/platform/qt/Skipped 2011-05-27 12:48:21 UTC (rev 87503) @@ -179,6 +179,11 @@ fast/events/drag-and-drop-dataTransfer-types-nocrash.html fast/events/drag-and-drop-fire-drag-dragover.html fast/events/ondrop-text-html.html +fast/events/dropzone-001.html +fast/events/dropzone-002.html +fast/events/dropzone-003.html +fast/events/dropzone-004.html + # caused by: http://trac.webkit.org/changeset/52192 http/tests/misc/drag-over-iframe-invalid-source-crash.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87504] trunk/LayoutTests
Title: [87504] trunk/LayoutTests Revision 87504 Author yael.aha...@nokia.com Date 2011-05-27 05:59:03 -0700 (Fri, 27 May 2011) Log Message Unreviewed. Skip test that is failing on the bot, until investigated. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (87503 => 87504) --- trunk/LayoutTests/ChangeLog 2011-05-27 12:48:21 UTC (rev 87503) +++ trunk/LayoutTests/ChangeLog 2011-05-27 12:59:03 UTC (rev 87504) @@ -2,6 +2,14 @@ Unreviewed. +Skip test that is failing on the bot, until investigated. + +* platform/chromium/test_expectations.txt: + +2011-05-27 Yael Aharon yael.aha...@nokia.com + +Unreviewed. + Skip new dropzone tests. Qt's DRT does not support drag 'n drop. * platform/qt/Skipped: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87503 => 87504) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-05-27 12:48:21 UTC (rev 87503) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-05-27 12:59:03 UTC (rev 87504) @@ -4024,5 +4024,7 @@ BUGWK61613 WIN : http/tests/local/formdata/send-form-data.html = CRASH BUGWK61613 WIN : http/tests/local/formdata/upload-events.html = CRASH +BUGWK61625 : fast/events/dropzone-002.html = TEXT + BUGWK61624 WIN : editing/pasteboard/smart-paste-003.html = TEXT BUGWK61624 WIN : editing/pasteboard/smart-paste-004.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
