[webkit-changes] [295388] trunk/Tools/Scripts
Title: [295388] trunk/Tools/Scripts
Revision 295388
Author zhifei_f...@apple.com
Date 2022-06-08 11:13:57 -0700 (Wed, 08 Jun 2022)
Log Message
Add git-webkit squash and refactory mock git
https://bugs.webkit.org/show_bug.cgi?id=237664
rdar://90040109
This change will make the mock git support commits without setting any identifier.
mock git now will assume branch in git-repo.json will have a base commit for each branch.
Reviewed by Jonathan Bedard.
* Tools/Scripts/hooks/prepare-commit-msg: Add new env val to support adding message content
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/git-repo.json: Add a new branch for testing squash.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Make the mock more like real git, add rev-list which will resolve commits follow two dots and triple dots syntax.
(Git):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:
(BitBucket):
(BitBucket.resolve_all_commits):
(BitBucket.commit):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:
(GitHub):
(GitHub.resolve_all_commits):
(GitHub.commit):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/squash.py: Added.
(Squash):
(Squash.parser):
(Squash.get_commits_hashes):
(Squash.undo_reset):
(Squash.squash_commit):
(Squash.main):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_branches):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:
(repository): Make sure all branch have a base commit.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/squash_unittest.py: Added.
(TestSquash):
(TestSquash.setUp):
(TestSquash.test_github_with_previous_history):
(TestSquash.test_github_without_previous_history):
(TestSquash.test_github_two_step):
(TestSquash.test_modified):
Canonical link: https://commits.webkit.org/251394@main
Modified Paths
trunk/Tools/Scripts/hooks/prepare-commit-msg
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/git-repo.json
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py
Added Paths
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/squash.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/squash_unittest.py
Diff
Modified: trunk/Tools/Scripts/hooks/prepare-commit-msg (295387 => 295388)
--- trunk/Tools/Scripts/hooks/prepare-commit-msg 2022-06-08 18:03:58 UTC (rev 295387)
+++ trunk/Tools/Scripts/hooks/prepare-commit-msg 2022-06-08 18:13:57 UTC (rev 295388)
@@ -67,7 +67,7 @@
'''.format(
title=os.environ.get('COMMIT_MESSAGE_TITLE', '') or 'Need a short description (OOPS!).',
bugs=os.environ.get('COMMIT_MESSAGE_BUG', '') or 'Need the bug URL (OOPS!).',
-content='\n'.join(commit_message),
+content='\n'.join(commit_message) + os.environ.get('COMMIT_MESSAGE_CONTENT', ''),
)
except subprocess.CalledProcessError:
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (295387 => 295388)
--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-06-08 18:03:58 UTC (rev 295387)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2022-06-08 18:13:57 UTC (rev 295388)
@@ -29,7 +29,7 @@
setup(
name='webkitscmpy',
-version='4.15.4',
+version='5.0.0',
description='Library designed to interact with git and svn repositories.',
long_description=readme(),
classifiers=[
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (295387 => 295388)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-06-08 18:03:58 UTC (rev 295387)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2022-06-08 18:13:57 UTC (rev 295388)
@@ -46,7 +46,7 @@
"Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
)
-version = Version(4, 15, 4)
+version = Version(5, 0, 0)
AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
AutoInstall.register(Package('jinja2', Version(2, 11, 3)))
[webkit-changes] [293175] trunk
rtEqual(local.Git(self.path).remote().pull_requests.get(1).draft, False)
+
+self.assertEqual(
+captured.stdout.getvalue(),
+"Created the local development branch 'eng/pr-branch'\n"
+"Created 'PR 1 | Revert \"Patch Series\"'!\n"
+"https://github.example.com/WebKit/WebKit/pull/1\n",
+)
+self.assertEqual(captured.stderr.getvalue(), '')
+log = captured.root.log.getvalue().splitlines()
+self.assertEqual(
+[line for line in log if 'Mock process' not in line], [
+"Creating the local development branch 'eng/pr-branch'...",
+'Found 1 commit...',
+'Reverted d8bce26fa65c6fc8f39c17927abb77f69fab82fc',
+"Rebasing 'eng/pr-branch' on 'main'...",
+"Rebased 'eng/pr-branch' on 'main!'",
+"Found 1 commit...",
+"Pushing 'eng/pr-branch' to 'fork'...",
+"Syncing 'main' to remote 'fork'",
+"Creating pull-request for 'eng/pr-branch'...",
+'Adding comment for reverted commits...'
+],
+)
+
+def test_modified(self):
+with OutputCapture(level=logging.INFO) as captured, mocks.remote.GitHub() as remote, \
+mocks.local.Git(self.path, remote='https://{}'.format(remote.remote)) as repo, mocks.local.Svn():
+
+repo.modified = {
+'a.py': """diff --git a/a.py b/a.py
+index 05e8751..0bf3c85 100644
+--- a/test
b/test
+@@ -1,3 +1,4 @@
++
+
+
+
+"""
+}
+result = program.main(
+args=('revert', 'd8bce26fa65c6fc8f39c17927abb77f69fab82fc', '-i', 'pr-branch', '-v'),
+path=self.path,
+)
+self.assertEqual(1, result)
+
+self.assertEqual(captured.stderr.getvalue(), 'Please commit your changes or stash them before you revert commit: d8bce26fa65c6fc8f39c17927abb77f69fab82fc')
+
+def test_update(self):
+with OutputCapture(level=logging.INFO) as captured, mocks.remote.GitHub() as remote, \
+mocks.local.Git(self.path, remote='https://{}'.format(remote.remote)) as repo, mocks.local.Svn():
+
+result = program.main(
+args=('revert', 'd8bce26fa65c6fc8f39c17927abb77f69fab82fc', '-i', 'pr-branch', '-v'),
+path=self.path,
+)
+self.assertEqual(0, result)
+result = program.main(
+args=('pull-request', '-v', '--no-history'),
+path=self.path,
+)
+self.assertEqual(0, result)
+
+self.assertEqual(
+captured.stdout.getvalue(),
+"Created the local development branch 'eng/pr-branch'\n"
+"Created 'PR 1 | Revert \"Patch Series\"'!\n"
+"https://github.example.com/WebKit/WebKit/pull/1\n"
+"Updated 'PR 1 | Revert \"Patch Series\"'!\n"
+"https://github.example.com/WebKit/WebKit/pull/1\n",
+)
+self.assertEqual(captured.stderr.getvalue(), '')
+log = captured.root.log.getvalue().splitlines()
+self.assertEqual(
+[line for line in log if 'Mock process' not in line], [
+"Creating the local development branch 'eng/pr-branch'...",
+'Found 1 commit...',
+'Reverted d8bce26fa65c6fc8f39c17927abb77f69fab82fc',
+"Rebasing 'eng/pr-branch' on 'main'...",
+"Rebased 'eng/pr-branch' on 'main!'",
+"Found 1 commit...",
+"Pushing 'eng/pr-branch' to 'fork'...",
+"Syncing 'main' to remote 'fork'",
+"Creating 'eng/pr-branch-1' as a reference branch",
+"Creating pull-request for 'eng/pr-branch'...",
+'Adding comment for reverted commits...',
+'Found 1 commit...',
+'Using committed changes...',
+"Rebasing 'eng/pr-branch' on 'main'...",
+"Rebased 'eng/pr-branch' on 'main!'",
+'Found 1 commit...',
+"Checking PR labels for 'merging-blocked'...",
+"Pushing 'eng/pr-branch' to 'fork'...",
+"Syncing 'main' to remote 'fork'",
+"Updating pull-request for 'eng/pr-branch'..."
+],
+)
Modified: trunk/metadata/contributors.json (293174 => 293175)
--- trunk/metadata/contributors.json 2022-04-21 17:10:24 UTC (rev 293174)
+++ trunk/metadata/contributors.json 2022-04-21 17:16:37 UTC (rev 293175)
@@ -7103,6 +7103,7 @@
"zhifei_f...@apple.com",
"facetothef...@gmail.com"
],
+ "github" : "facetothefate",
"name" : "Zhifei Fang",
"nicks" : [
"zhifei_fang",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292247] trunk
Title: [292247] trunk
Revision 292247
Author zhifei_f...@apple.com
Date 2022-04-01 17:46:01 -0700 (Fri, 01 Apr 2022)
Log Message
Fix 'Error: too many values to unpack (expected 2)'
https://bugs.webkit.org/show_bug.cgi?id=238682
Reviewed by Jonathan Bedard.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description_unittest.py: Added.
(MockCommit):
(MockCommit.__init__):
(MockCommitContext):
(MockCommitContext.__init__):
(MockCommitContext.find_commits_by_uuid):
(MockCommitContext.url):
(TestBugDescription):
(TestBugDescription.setUp):
(TestBugDescription.test_single_row_and_single_test_failure):
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bugzilla.py:
(WebKitBugzilla.create_bug):
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/run-tests:
Canonical link: https://commits.webkit.org/249145@main
Modified Paths
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bugzilla.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/run-tests
trunk/metadata/contributors.json
Added Paths
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description_unittest.py
Diff
Added: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description_unittest.py (0 => 292247)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description_unittest.py (rev 0)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description_unittest.py 2022-04-02 00:46:01 UTC (rev 292247)
@@ -0,0 +1,161 @@
+import unittest
+import bisect
+from .bug_description import translate_selected_dots_to_bug_title_and_description
+from .bugzilla import WebKitBugzilla
+
+MOCK_COMMITS = {
+'webkit': {
+'main': [
+{
+'author': {
+'emails': ['simon.fra...@apple.com'],
+'name': 'simon.fra...@apple.com'
+},
+'branch': 'main',
+'bugUrls': ['https://bugs.webkit.org/show_bug.cgi?id=236671'],
+'hash': None,
+'identifier': '247341@main',
+'message': 'some msg',
+'order': 0,
+'radarUrls': None,
+'repository_id': 'webkit',
+'revision': 289911,
+'timestamp': 1645036552,
+'uuid': 164880465000
+}, {
+'author': {
+'emails': ['pvol...@apple.com'],
+'name': 'pvol...@apple.com'
+},
+'branch': 'main',
+'bugUrls': ['https://bugs.webkit.org/show_bug.cgi?id=236653'],
+'hash': None,
+'identifier': '247345@main',
+'message': 'some msg',
+'order': 0,
+'radarUrls': ['rdar://88787266'],
+'repository_id': "webkit",
+'revision': 289926,
+'timestamp': 1645041304,
+'uuid': 164881488600
+}, {
+'author': {
+'emails': ['pvol...@apple.com'],
+'name': 'pvol...@apple.com'
+},
+'branch': 'main',
+'bugUrls': ['https://bugs.webkit.org/show_bug.cgi?id=236653'],
+'hash': None,
+'identifier': '247348@main',
+'message': 'some msg',
+'order': 0,
+'radarUrls': ['rdar://88787266'],
+'repository_id': "webkit",
+'revision': 289926,
+'timestamp': 1645041304,
+'uuid': 164882229900
+}
+]
+}
+}
+
+
+class MockCommit(object):
+
+def __init__(self, commit_data):
+for k, v in commit_data.items():
+setattr(self, k, v)
+
+
+class MockCommitContext(object):
+
+def __init__(self, mock_commits) -> None:
+self._mock_commits = mock_commits
+
+def find_commits_by_uuid(self, repository_id, branch, uuid):
+commits = self._mock_commits[repository_id][branch]
+commit_data_index = bisect.bisect_left(list(map(lambda commit_data: commit_data['uuid'], commits)), uuid)
+if commit_data_index == len(commits):
+commit_data_index -= 1
+commit_data = commits[commit_data_index]
+return [MockCommit(commit_data)]
+
+def url(self, commit):
+if commit.repository_id == 'webkit':
+return 'https://trac.webkit.org/changeset/{}/webkit'.format(commit.revision)
+elif commit.repository_id == 'safari':
+return 'https://stashweb.sd.apple.com/projects/SAFARI/repos/safari/commits/{}'.format(commit.hash)
+
+
+class TestBugDescription(unittest.TestCase):
+
+def setUp(self):
+self.bugzilla = WebKitBugzilla()
+self.bugzilla.set_commit_context(MockCommitContext(MOCK_COMMITS))
+return super().setUp()
+
+def
[webkit-changes] [291887] trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/ bug_trackers/bug_description.py
Title: [291887] trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py
Revision 291887
Author zhifei_f...@apple.com
Date 2022-03-25 14:02:20 -0700 (Fri, 25 Mar 2022)
Log Message
[results-safari] filter out None in automatically generated bug title
https://bugs.webkit.org/show_bug.cgi?id=238360
rdar://90809419
Reviewed by Dewei Zhu and Jonathan Bedard.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py:
(translate_selected_dots_to_bug_title_and_description):
Canonical link: https://commits.webkit.org/248886@main
Modified Paths
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py
Diff
Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py (291886 => 291887)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py 2022-03-25 20:54:28 UTC (rev 291886)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py 2022-03-25 21:02:20 UTC (rev 291887)
@@ -51,7 +51,11 @@
for failed_scope in failed_scopes:
result, init_failure_type, init_failure_number, last_sucess, config = failed_scope
version_name = config['version_name'] if 'version_name' in config else Configuration.integer_to_version(config['version'])
-title_components.add('{} on {}({})'.format(init_failure_type, version_name, config['model']))
+if version_name and config['model']:
+title_components.add('{} on {}({})'.format(init_failure_type, version_name, config['model']))
+else:
+title_components.add('{} on {}'.format(init_failure_type, (version_name if version_name else config['model'])))
+
if init_failure_number is not None:
description_components.append('{} {}'.format(init_failure_number, init_failure_type))
description_components.append('Hardware: \t{}'.format(config['model']))
@@ -85,4 +89,4 @@
map(lambda commit: '{}: {}'.format(commit.identifier, commit_context.url(commit)),
last_sucess_commits)
)
-return title_components, description_components
+return title_components, description_components
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291766] trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy
Title: [291766] trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy
Revision 291766
Author zhifei_f...@apple.com
Date 2022-03-23 14:21:59 -0700 (Wed, 23 Mar 2022)
Log Message
[results.webkit.org] Add file bugzilla button
https://bugs.webkit.org/show_bug.cgi?id=237802
Reviewed by Jonathan Bedard.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/__init__.py: Added.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py: Added.
(translate_selected_dots_to_bug_title_and_description):
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bugzilla.py: Added.
(Bugzilla):
(Bugzilla.__init__):
(Bugzilla.create_bug):
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/api_routes.py:
(APIRoutes.__init__):
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(TimelineFromEndpoint.prototype._renderSelectedDotsButtonGroup):
(TimelineFromEndpoint):
Canonical link: https://commits.webkit.org/248796@main
Modified Paths
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/api_routes.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js
Added Paths
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/__init__.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bugzilla.py
Diff
Added: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/__init__.py (0 => 291766)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/__init__.py (rev 0)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/__init__.py 2022-03-23 21:21:59 UTC (rev 291766)
@@ -0,0 +1 @@
+# DO NOTHING
Added: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py (0 => 291766)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py (rev 0)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/bug_trackers/bug_description.py 2022-03-23 21:21:59 UTC (rev 291766)
@@ -0,0 +1,88 @@
+# Copyright (C) 2022 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS "AS IS" AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+from functools import reduce
+
+from resultsdbpy.model.test_context import Expectations
+from resultsdbpy.controller.configuration import Configuration
+
+
+def translate_selected_dots_to_bug_title_and_description(commit_context, selected_rows, test, suite, repositories, will_filter_expected):
+
+failed_scopes = []
+for selected_row in selected_rows:
+config = selected_row['config']
+results = selected_row['results']
+init_failure_type, init_failure_number = Expectations.get_test_result_status(results[0], will_filter_expected)
+if not init_failure_type:
+continue
+sucess_results = list(filter(lambda result: not Expectations.get_test_result_status(result, will_filter_expected)[0], results))
+if len(sucess_results):
+last_sucess = sucess_results[0]
+else:
+last_sucess = None
+failed_scopes.append((results[0], init_failure_type, init_failure_number, last_sucess, config))
+
+if len(failed_scopes) == 0:
+raise ValueError('No failures dectected')
+
+title_components = set()
+description_components = []
+
+for failed_scope in failed_scopes:
+result, init_failure_type, init_failure_number, last_sucess, config = failed_scope
+version_name = config['version_name'] if 'version_name' in config else
[webkit-changes] [291063] trunk/Tools
Title: [291063] trunk/Tools
Revision 291063
Author zhifei_f...@apple.com
Date 2022-03-09 13:05:03 -0800 (Wed, 09 Mar 2022)
Log Message
[results.webkit.org]Add selection box for results database.
https://bugs.webkit.org/show_bug.cgi?id=233958
Reviewed by Jonathan Bedard.
Allow user can drag a selection box to select multiple dots.
Allow user to use cmd + click to select multiple dots.
Allow user to use shift + click to select a row of dots.
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(TimelineFromEndpoint):
(TimelineFromEndpoint.prototype.update):
(TimelineFromEndpoint.prototype.getTestResultStatus):
(TimelineFromEndpoint.prototype.getTestResultUrl):
(TimelineFromEndpoint.prototype.render):
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(pointRectCollisionDetect): Detact if a point and a rect have a insertion.
(rectRectCollisionDetect): Detact if two rects have a insertion.
(XScrollableCanvasProvider): Add selection box.
(xScrollStreamRenderFactory):
(Timeline.CanvasSeriesComponent): Add selection box , cmd + click and shift + click.
(prototype.ExpandableSeriesComponent):
(prototype.Timeline.CanvasContainer):
Canonical link: https://commits.webkit.org/248236@main
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/api_routes.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/test_context.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/css/tooltip.css
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/tooltip.js
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
Added Paths
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/bug_tracker_controller.py
Diff
Modified: trunk/Tools/ChangeLog (291062 => 291063)
--- trunk/Tools/ChangeLog 2022-03-09 20:59:08 UTC (rev 291062)
+++ trunk/Tools/ChangeLog 2022-03-09 21:05:03 UTC (rev 291063)
@@ -1,3 +1,30 @@
+2021-12-07 Zhifei Fang
+
+[results.webkit.org]Add selection box for results database.
+https://bugs.webkit.org/show_bug.cgi?id=233958
+
+Reviewed by Jonathan Bedard.
+
+Allow user can drag a selection box to select multiple dots.
+Allow user to use cmd + click to select multiple dots.
+Allow user to use shift + click to select a row of dots.
+
+* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+(TimelineFromEndpoint):
+(TimelineFromEndpoint.prototype.update):
+(TimelineFromEndpoint.prototype.getTestResultStatus):
+(TimelineFromEndpoint.prototype.getTestResultUrl):
+(TimelineFromEndpoint.prototype.render):
+* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
+* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+(pointRectCollisionDetect): Detact if a point and a rect have a insertion.
+(rectRectCollisionDetect): Detact if two rects have a insertion.
+(XScrollableCanvasProvider): Add selection box.
+(xScrollStreamRenderFactory):
+(Timeline.CanvasSeriesComponent): Add selection box , cmd + click and shift + click.
+(prototype.ExpandableSeriesComponent):
+(prototype.Timeline.CanvasContainer):
+
2022-03-01 Jonathan Bedard
[EWS] Support concept of 'blocked' pull requests
Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/api_routes.py (291062 => 291063)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/api_routes.py 2022-03-09 20:59:08 UTC (rev 291062)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/api_routes.py 2022-03-09 21:05:03 UTC (rev 291063)
@@ -20,6 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+from crypt import methods
import traceback
from flask import abort, jsonify
@@ -30,12 +31,13 @@
from resultsdbpy.controller.suite_controller import SuiteController
from resultsdbpy.controller.test_controller import TestController
from resultsdbpy.controller.upload_controller import UploadController
+from resultsdbpy.controller.bug_tracker_controller import BugTrackerController
from webkitflaskpy import AuthedBlueprint
from werkzeug.exceptions import HTTPException
class APIRoutes(AuthedBlueprint):
-def __init__(self, model, import_name=__name__, auth_decorator=None):
+def __init__(self, model, import_name=__name__, auth_decorator=None, bug_tracker_configs=[]):
super(APIRoutes, self).__init__('controller', import_name, url_prefix='/api',
[webkit-changes] [285875] trunk/Tools
Title: [285875] trunk/Tools
Revision 285875
Author zhifei_f...@apple.com
Date 2021-11-16 11:31:42 -0800 (Tue, 16 Nov 2021)
Log Message
Make run-_javascript_-core-test and run-jsc-stress-tests support a customized identity file
https://bugs.webkit.org/show_bug.cgi?id=232453
Reviewed by Ryan Haddad.
* Scripts/run-_javascript_core-tests: Add idFilePath field for remote config.
* Scripts/run-jsc-stress-tests: Add idFilePath field for remote config.
* Scripts/webkitdirs.pm:
(determineNativeArchitecture): Provide -i option to ssh
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
trunk/Tools/Scripts/run-jsc-stress-tests
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (285874 => 285875)
--- trunk/Tools/ChangeLog 2021-11-16 19:26:36 UTC (rev 285874)
+++ trunk/Tools/ChangeLog 2021-11-16 19:31:42 UTC (rev 285875)
@@ -1,3 +1,15 @@
+2021-11-16 Zhifei Fang
+
+Make run-_javascript_-core-test and run-jsc-stress-tests support a customized identity file
+https://bugs.webkit.org/show_bug.cgi?id=232453
+
+Reviewed by Ryan Haddad.
+
+* Scripts/run-_javascript_core-tests: Add idFilePath field for remote config.
+* Scripts/run-jsc-stress-tests: Add idFilePath field for remote config.
+* Scripts/webkitdirs.pm:
+(determineNativeArchitecture): Provide -i option to ssh
+
2021-11-16 Chris Dumez
[iOS] Do not require the web browser entitlement to opt into captive portal mode
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (285874 => 285875)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2021-11-16 19:26:36 UTC (rev 285874)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2021-11-16 19:31:42 UTC (rev 285875)
@@ -524,12 +524,14 @@
$remotes = $remoteConfig->{"remotes"};
} elsif (defined $remoteConfig->{"remote"}) {
my @split = split(':', $remoteConfig->{"remote"});
-$remotes = [
-{
-"name" => "synthesized",
-"address" => $remoteConfig->{"remote"}
-}
- ];
+my $remote = {
+"name" => "synthesized",
+"address" => $remoteConfig->{"remote"}
+};
+if (exists $remoteConfig->{"idFilePath"}) {
+$remote->{'idFilePath'} = $remoteConfig->{'idFilePath'};
+}
+$remotes = [$remote];
}
}
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (285874 => 285875)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2021-11-16 19:26:36 UTC (rev 285874)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2021-11-16 19:31:42 UTC (rev 285875)
@@ -51,7 +51,7 @@
puts(Thread.current.backtrace)
}
-RemoteHost = Struct.new(:name, :user, :host, :port, :remoteDirectory)
+RemoteHost = Struct.new(:name, :user, :host, :port, :remoteDirectory, :identity_file_path)
THIS_SCRIPT_PATH = Pathname.new(__FILE__).realpath
SCRIPTS_PATH = THIS_SCRIPT_PATH.dirname
@@ -325,6 +325,9 @@
if config['remoteDirectory']
$remoteHosts[0].remoteDirectory = config['remoteDirectory']
end
+if config['idFilePath']
+$remoteHosts[0].identity_file_path = config['idFilePath']
+end
end
# we can combine --remote and a new style config
@@ -340,6 +343,10 @@
if remote['remoteDirectory']
host.remoteDirectory = remote['remoteDirectory']
end
+if remote['idFilePath']
+host.identity_file_path = remote['idFilePath']
+print('Using identity file: ' + host.identity_file_path + "\r")
+end
host
}
end
@@ -2118,7 +2125,7 @@
raise unless $remote
result = ""
-IO.popen("ssh -o NoHostAuthenticationForLocalhost=yes -p #{remoteHost.port} #{remoteHost.user}@#{remoteHost.host} '#{cmd}'", "r") {
+IO.popen("ssh -o NoHostAuthenticationForLocalhost=yes -p #{remoteHost.port}" + (remoteHost.identity_file_path ? " -i #{remoteHost.identity_file_path}" : "") + " #{remoteHost.user}@#{remoteHost.host} '#{cmd}'", "r") {
| inp |
inp.each_line {
| line |
@@ -2256,8 +2263,8 @@
end
def copyBundleToRemote(remoteHost)
-mysys(["ssh", "-o", "NoHostAuthenticationForLocalhost=yes", "-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", "mkdir -p #{remoteHost.remoteDirectory}"])
-mysys(["scp", "-o", "NoHostAuthenticationForLocalhost=yes", "-P", remoteHost.port.to_s, ($outputDir.dirname + $tarFileName).to_s, "#{remoteHost.user}@#{remoteHost.host}:#{remoteHost.remoteDirectory}"])
+mysys(["ssh", "-o", "NoHostAuthenticationForLocalhost=yes"] + (remoteHost.identity_file_path ? ["-i", remoteHost.identity_file_path] : []) + ["-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", "mkdir -p #{remoteHost.remoteDirectory}"])
+mysys(["scp", "-o", "NoHostAuthenticationForLocalhost=yes"] + (remoteHost.identity_file_path ? ["-i",
[webkit-changes] [279421] trunk/Tools
Title: [279421] trunk/Tools
Revision 279421
Author zhifei_f...@apple.com
Date 2021-06-30 10:45:06 -0700 (Wed, 30 Jun 2021)
Log Message
[webkit.css] make the active tab more obvious
https://bugs.webkit.org/show_bug.cgi?id=227515
Reviewed by Jonathan Bedard.
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
(.tabs .tab.active .link):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css
Diff
Modified: trunk/Tools/ChangeLog (279420 => 279421)
--- trunk/Tools/ChangeLog 2021-06-30 17:09:59 UTC (rev 279420)
+++ trunk/Tools/ChangeLog 2021-06-30 17:45:06 UTC (rev 279421)
@@ -1,3 +1,13 @@
+2021-06-30 Zhifei Fang
+
+[webkit.css] make the active tab more obvious
+https://bugs.webkit.org/show_bug.cgi?id=227515
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
+(.tabs .tab.active .link):
+
2021-06-29 Zhifei Fang
Add new argument of device os version for reporting _javascript_Core test result
Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css (279420 => 279421)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2021-06-30 17:09:59 UTC (rev 279420)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2021-06-30 17:45:06 UTC (rev 279421)
@@ -1696,7 +1696,8 @@
}
.tabs .tab.active .link {
- border-bottom: 1px solid var(--greyDarker);
+ border-bottom: 1px solid var(--linkColor);
+ color: var(--linkColor);
}
.tabs .tab .link {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279394] trunk/Tools
Title: [279394] trunk/Tools
Revision 279394
Author zhifei_f...@apple.com
Date 2021-06-29 16:49:28 -0700 (Tue, 29 Jun 2021)
Log Message
Add new argument of device os version for reporting _javascript_Core test result
https://bugs.webkit.org/show_bug.cgi?id=227363
Reviewed by Dewei Zhu.
* Scripts/run-_javascript_core-tests:
(configurationForUpload):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
Diff
Modified: trunk/Tools/ChangeLog (279393 => 279394)
--- trunk/Tools/ChangeLog 2021-06-29 23:48:45 UTC (rev 279393)
+++ trunk/Tools/ChangeLog 2021-06-29 23:49:28 UTC (rev 279394)
@@ -1,3 +1,13 @@
+2021-06-29 Zhifei Fang
+
+Add new argument of device os version for reporting _javascript_Core test result
+https://bugs.webkit.org/show_bug.cgi?id=227363
+
+Reviewed by Dewei Zhu.
+
+* Scripts/run-_javascript_core-tests:
+(configurationForUpload):
+
2021-06-29 Jonathan Bedard
[webkitcorepy] Add NestedFuzzyDict
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (279393 => 279394)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2021-06-29 23:48:45 UTC (rev 279393)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2021-06-29 23:49:28 UTC (rev 279394)
@@ -111,6 +111,7 @@
my $version;
my $versionName;
my $sdk;
+my $deviceOS;
my $failFast = 1;
my $coverage = 0;
my $coverageDir;
@@ -266,6 +267,7 @@
--version Specify the version number of the device running tests.
--version-nameSpecify the version name of the hardware running tests.
--sdk Specific SDK or OS version of the form ##*###
+ --device-os Speicifc OS version for the remote device
--extra-tests=Path to a file containing extra tests
--child-processes=Specify the number of child processes.
--shell-runnerUses the shell-based test runner instead of the default make-based runner.
@@ -340,6 +342,7 @@
'version=s' => \$version,
'version-name=s' => \$versionName,
'sdk=s' => \$sdk,
+'device-os=s' => \$deviceOS,
'remote-config-file=s' => \$remoteConfigFile,
'child-processes=s' => \$childProcesses,
'shell-runner' => \$shellRunner,
@@ -473,6 +476,9 @@
if ($sdk) {
$result->{sdk} = $sdk;
}
+if ($deviceOS) {
+$result->{sdk} = $deviceOS;
+}
return $result;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [278234] trunk/Tools
Title: [278234] trunk/Tools
Revision 278234
Author zhifei_f...@apple.com
Date 2021-05-28 21:34:13 -0700 (Fri, 28 May 2021)
Log Message
[JSC] Escape $ only when run with SSH
https://bugs.webkit.org/show_bug.cgi?id=226385
Reviewed by Alexey Proskuryakov.
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Tools/ChangeLog (278233 => 278234)
--- trunk/Tools/ChangeLog 2021-05-29 01:28:12 UTC (rev 278233)
+++ trunk/Tools/ChangeLog 2021-05-29 04:34:13 UTC (rev 278234)
@@ -1,3 +1,12 @@
+2021-05-28 Zhifei Fang
+
+[JSC] Escape $ only when run with SSH
+https://bugs.webkit.org/show_bug.cgi?id=226385
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/run-jsc-stress-tests:
+
2021-05-28 Matt Gilligan
Prevent resetting scroll position in unnecessary cases during page load
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (278233 => 278234)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2021-05-29 01:28:12 UTC (rev 278233)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2021-05-29 04:34:13 UTC (rev 278234)
@@ -2197,9 +2197,14 @@
mysys(["scp", "-o", "NoHostAuthenticationForLocalhost=yes", "-P", remoteHost.port.to_s, ($outputDir.dirname + $tarFileName).to_s, "#{remoteHost.user}@#{remoteHost.host}:#{remoteHost.remoteDirectory}"])
end
-def exportBaseEnvironmentVariables
-dyldFrameworkPath = "\\$(cd #{$testingFrameworkPath.dirname}; pwd)"
-ldLibraryPath = "\\$(cd #{$testingFrameworkPath.dirname}/..; pwd)/#{$jscPath.dirname}"
+def exportBaseEnvironmentVariables(escape)
+if escape
+dyldFrameworkPath = "\\$(cd #{$testingFrameworkPath.dirname}; pwd)"
+ldLibraryPath = "\\$(cd #{$testingFrameworkPath.dirname}/..; pwd)/#{$jscPath.dirname}"
+else
+dyldFrameworkPath = "\$(cd #{$testingFrameworkPath.dirname}; pwd)"
+ldLibraryPath = "\$(cd #{$testingFrameworkPath.dirname}/..; pwd)/#{$jscPath.dirname}"
+end
[
"export DYLD_FRAMEWORK_PATH=#{dyldFrameworkPath} && ",
"export LD_LIBRARY_PATH=#{ldLibraryPath} &&",
@@ -2220,7 +2225,7 @@
remoteScript += "rm -rf #{$outputDir.basename} && "
remoteScript += "tar xzf #{$tarFileName} && "
remoteScript += "cd #{$outputDir.basename}/.runner && "
-remoteScript += exportBaseEnvironmentVariables
+remoteScript += exportBaseEnvironmentVariables(true)
$envVars.each { |var| remoteScript += "export " << var << "\n" }
remoteScript += "#{testRunnerCommand(remoteIndex)}\""
runAndMonitorTestRunnerCommand(["ssh", "-o", "NoHostAuthenticationForLocalhost=yes", "-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", remoteScript])
@@ -2632,7 +2637,7 @@
"--timeout", timeout.to_s,
"-a", inputs,
"if test -e #{$outputDir.basename}/.runner; then cd #{$outputDir.basename}/.runner; else echo #{PARALLEL_REMOTE_STATE_LOST_MARKER}; false; fi && " +
-exportBaseEnvironmentVariables +
+exportBaseEnvironmentVariables(false) +
$envVars.collect { |var | "export #{var} &&"}.join("") +
"sh "
]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [278218] trunk/Tools
Title: [278218] trunk/Tools
Revision 278218
Author zhifei_f...@apple.com
Date 2021-05-28 12:40:28 -0700 (Fri, 28 May 2021)
Log Message
[JSC] Fix run-jsc-stress-tests missing escape $
https://bugs.webkit.org/show_bug.cgi?id=226385
Reviewed by Alexey Proskuryakov.
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Tools/ChangeLog (278217 => 278218)
--- trunk/Tools/ChangeLog 2021-05-28 18:54:27 UTC (rev 278217)
+++ trunk/Tools/ChangeLog 2021-05-28 19:40:28 UTC (rev 278218)
@@ -1,3 +1,12 @@
+2021-05-28 Zhifei Fang
+
+[JSC] Fix run-jsc-stress-tests missing escape $
+https://bugs.webkit.org/show_bug.cgi?id=226385
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/run-jsc-stress-tests:
+
2021-05-27 Devin Rousso
Sampled Page Top Color: allow snapshotting of elements with CSS animations/transitions if they're paused
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (278217 => 278218)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2021-05-28 18:54:27 UTC (rev 278217)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2021-05-28 19:40:28 UTC (rev 278218)
@@ -2198,8 +2198,8 @@
end
def exportBaseEnvironmentVariables
-dyldFrameworkPath = "\$(cd #{$testingFrameworkPath.dirname}; pwd)"
-ldLibraryPath = "\$(cd #{$testingFrameworkPath.dirname}/..; pwd)/#{$jscPath.dirname}"
+dyldFrameworkPath = "\\$(cd #{$testingFrameworkPath.dirname}; pwd)"
+ldLibraryPath = "\\$(cd #{$testingFrameworkPath.dirname}/..; pwd)/#{$jscPath.dirname}"
[
"export DYLD_FRAMEWORK_PATH=#{dyldFrameworkPath} && ",
"export LD_LIBRARY_PATH=#{ldLibraryPath} &&",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [277826] trunk/Websites/perf.webkit.org
Title: [277826] trunk/Websites/perf.webkit.org Revision 277826 Author zhifei_f...@apple.com Date 2021-05-20 14:46:44 -0700 (Thu, 20 May 2021) Log Message Need to use default git pull to remove the fake svn commit when syncing with SVN https://bugs.webkit.org/show_bug.cgi?id=226039 Reviewed by Jonathan Bedard. * tools/sync-commits.py: (GitRepository._fetch_remote): Modified Paths trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/tools/sync-commits.py Diff Modified: trunk/Websites/perf.webkit.org/ChangeLog (277825 => 277826) --- trunk/Websites/perf.webkit.org/ChangeLog 2021-05-20 21:28:20 UTC (rev 277825) +++ trunk/Websites/perf.webkit.org/ChangeLog 2021-05-20 21:46:44 UTC (rev 277826) @@ -1,3 +1,13 @@ +2021-05-20 Zhifei Fang + +Need to use default git pull to remove the fake svn commit when syncing with SVN +https://bugs.webkit.org/show_bug.cgi?id=226039 + +Reviewed by Jonathan Bedard. + +* tools/sync-commits.py: +(GitRepository._fetch_remote): + 2021-05-18 Zhifei Fang Clean up git svn mapping when git pull Modified: trunk/Websites/perf.webkit.org/tools/sync-commits.py (277825 => 277826) --- trunk/Websites/perf.webkit.org/tools/sync-commits.py 2021-05-20 21:28:20 UTC (rev 277825) +++ trunk/Websites/perf.webkit.org/tools/sync-commits.py 2021-05-20 21:46:44 UTC (rev 277826) @@ -286,10 +286,12 @@ return None def _fetch_remote(self): -self._run_git_command(['pull', self._git_url]) if self._report_svn_revision: +self._run_git_command(['pull']) subprocess.check_call(['rm', '-rf', os.path.join(self._git_checkout, '.git/svn')]) self._run_git_command(['svn', 'fetch']) +else: +self._run_git_command(['pull', self._git_url]) def _fetch_all_hashes(self): self._fetch_remote() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [277679] trunk/Websites/perf.webkit.org
Title: [277679] trunk/Websites/perf.webkit.org Revision 277679 Author zhifei_f...@apple.com Date 2021-05-18 14:25:44 -0700 (Tue, 18 May 2021) Log Message Clean up git svn mapping when git pull https://bugs.webkit.org/show_bug.cgi?id=225934 Reviewed by Ryosuke Niwa. * tools/sync-commits.py: (GitRepository._fetch_remote): Modified Paths trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/tools/sync-commits.py Diff Modified: trunk/Websites/perf.webkit.org/ChangeLog (277678 => 277679) --- trunk/Websites/perf.webkit.org/ChangeLog 2021-05-18 21:23:40 UTC (rev 277678) +++ trunk/Websites/perf.webkit.org/ChangeLog 2021-05-18 21:25:44 UTC (rev 277679) @@ -1,5 +1,15 @@ 2021-05-18 Zhifei Fang +Clean up git svn mapping when git pull +https://bugs.webkit.org/show_bug.cgi?id=225934 + +Reviewed by Ryosuke Niwa. + +* tools/sync-commits.py: +(GitRepository._fetch_remote): + +2021-05-18 Zhifei Fang + Commits updater should ignore null revision identifier https://bugs.webkit.org/show_bug.cgi?id=225911 Modified: trunk/Websites/perf.webkit.org/tools/sync-commits.py (277678 => 277679) --- trunk/Websites/perf.webkit.org/tools/sync-commits.py 2021-05-18 21:23:40 UTC (rev 277678) +++ trunk/Websites/perf.webkit.org/tools/sync-commits.py 2021-05-18 21:25:44 UTC (rev 277679) @@ -288,6 +288,7 @@ def _fetch_remote(self): self._run_git_command(['pull', self._git_url]) if self._report_svn_revision: +subprocess.check_call(['rm', '-rf', os.path.join(self._git_checkout, '.git/svn')]) self._run_git_command(['svn', 'fetch']) def _fetch_all_hashes(self): ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [277671] trunk/Websites/perf.webkit.org
Title: [277671] trunk/Websites/perf.webkit.org
Revision 277671
Author zhifei_f...@apple.com
Date 2021-05-18 12:56:03 -0700 (Tue, 18 May 2021)
Log Message
Commits updater should ignore null revision identifier
https://bugs.webkit.org/show_bug.cgi?id=225911
Reviewed by Ryosuke Niwa.
* public/include/commit-updater.php:
* server-tests/api-report-commits-tests.js:
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/include/commit-updater.php
trunk/Websites/perf.webkit.org/server-tests/api-report-commits-tests.js
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (277670 => 277671)
--- trunk/Websites/perf.webkit.org/ChangeLog 2021-05-18 19:52:05 UTC (rev 277670)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2021-05-18 19:56:03 UTC (rev 277671)
@@ -1,3 +1,13 @@
+2021-05-18 Zhifei Fang
+
+Commits updater should ignore null revision identifier
+https://bugs.webkit.org/show_bug.cgi?id=225911
+
+Reviewed by Ryosuke Niwa.
+
+* public/include/commit-updater.php:
+* server-tests/api-report-commits-tests.js:
+
2021-05-07 Zhifei Fang
Add support for syncing repo with commit revision label.
Modified: trunk/Websites/perf.webkit.org/public/include/commit-updater.php (277670 => 277671)
--- trunk/Websites/perf.webkit.org/public/include/commit-updater.php 2021-05-18 19:52:05 UTC (rev 277670)
+++ trunk/Websites/perf.webkit.org/public/include/commit-updater.php 2021-05-18 19:56:03 UTC (rev 277671)
@@ -81,7 +81,7 @@
$has_update = count($commit_data) > 1;
$update = array('commit' => &$commit_data, 'repository' => &$commit_info['repository']);
-if (array_key_exists('revisionIdentifier', $commit_info)) {
+if (array_key_exists('revisionIdentifier', $commit_info) && isset($commit_info['revisionIdentifier'])) {
if (array_key_exists($commit_info['revisionIdentifier'], $commit_revision_identifiers))
$this->exit_with_error('DuplicatedRevisionIdentifier', array('commit' => $commit_info));
$commit_revision_identifiers[$commit_info['revisionIdentifier']] = true;
@@ -169,7 +169,7 @@
exit_with_error('InvalidAuthorFormat', array('commit' => $commit_info));
if (array_key_exists('previousCommit', $commit_info))
require_format('Revision', $commit_info['previousCommit'], '/^[A-Za-z0-9 \.]+$/');
-if (array_key_exists('revisionIdentifier', $commit_info))
+if (array_key_exists('revisionIdentifier', $commit_info) && isset($commit_info['revisionIdentifier']))
require_format('RevisionIdentifier', $commit_info['revisionIdentifier'], '/^\d+@[\w\.\-]+$/');
}
Modified: trunk/Websites/perf.webkit.org/server-tests/api-report-commits-tests.js (277670 => 277671)
--- trunk/Websites/perf.webkit.org/server-tests/api-report-commits-tests.js 2021-05-18 19:52:05 UTC (rev 277670)
+++ trunk/Websites/perf.webkit.org/server-tests/api-report-commits-tests.js 2021-05-18 19:56:03 UTC (rev 277671)
@@ -113,6 +113,93 @@
]
}
+const emptyRevisionIdentifierCommits = {
+"workerName": "someWorker",
+"workerPassword": "somePassword",
+"commits": [
+{
+"repository": "WebKit",
+"revision": "210948",
+"revisionIdentifier": null,
+"time": "2017-01-20T02:52:34.577Z",
+"author": {"name": "Zalan Bujtas", "account": "za...@apple.com"},
+"message": "a message",
+},
+{
+"repository": "WebKit",
+"revision": "210949",
+"previousCommit": "210948",
+"revisionIdentifier": null,
+"time": "2017-01-20T03:23:50.645Z",
+"author": {"name": "Chris Dumez", "account": "cdu...@apple.com"},
+"message": "some message",
+},
+]
+}
+
+const emptyRevisionIdentifierAndValidRevisionIdentifierCommits = {
+"workerName": "someWorker",
+"workerPassword": "somePassword",
+"commits": [
+{
+"repository": "WebKit",
+"revision": "210948",
+"revisionIdentifier": null,
+"time": "2017-01-20T02:52:34.577Z",
+"author": {"name": "Zalan Bujtas", "account": "za...@apple.com"},
+"message": "a message",
+},
+{
+"repository": "WebKit",
+"revision": "210949",
+"previousCommit": "210948",
+"revisionIdentifier": "184276@main",
+"time": "2017-01-20T03:23:50.645Z",
+"author": {"name": "Chris Dumez", "account": "cdu...@apple.com"},
+"message": "some message",
+},
+]
+}
+
+const
[webkit-changes] [277220] trunk/Websites/perf.webkit.org
Title: [277220] trunk/Websites/perf.webkit.org
Revision 277220
Author zhifei_f...@apple.com
Date 2021-05-07 18:08:08 -0700 (Fri, 07 May 2021)
Log Message
Add support for syncing repo with commit revision label.
https://bugs.webkit.org/show_bug.cgi?id=221982
Reviewed by Ryosuke Niwa.
Add new syncing option reportRevisionIdentifier, which will let the script try to sync the commit revision identifier from the commit message.
Add new syncing option reportSVNRevision, which will let the script try to report SVN revision from a git-svn repo.
* tools/sync-commits.py:
(main):
(load_repository):
(GitRepository.__init__):
(GitRepository.fetch_next_commit):
(GitRepository._git_hash_to_svn_revision):
(GitRepository._svn_revision_to_git_hash):
(GitRepository._revision_from_tokens):
(GitRepository._fetch_all_hashes):
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/tools/sync-commits.py
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (277219 => 277220)
--- trunk/Websites/perf.webkit.org/ChangeLog 2021-05-08 01:05:02 UTC (rev 277219)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2021-05-08 01:08:08 UTC (rev 277220)
@@ -1,3 +1,23 @@
+2021-05-07 Zhifei Fang
+
+Add support for syncing repo with commit revision label.
+https://bugs.webkit.org/show_bug.cgi?id=221982
+
+Reviewed by Ryosuke Niwa.
+
+Add new syncing option reportRevisionIdentifier, which will let the script try to sync the commit revision identifier from the commit message.
+Add new syncing option reportSVNRevision, which will let the script try to report SVN revision from a git-svn repo.
+
+* tools/sync-commits.py:
+(main):
+(load_repository):
+(GitRepository.__init__):
+(GitRepository.fetch_next_commit):
+(GitRepository._git_hash_to_svn_revision):
+(GitRepository._svn_revision_to_git_hash):
+(GitRepository._revision_from_tokens):
+(GitRepository._fetch_all_hashes):
+
2021-04-14 Zhifei Fang
Support Commit revision identifier in the Chart
Modified: trunk/Websites/perf.webkit.org/tools/sync-commits.py (277219 => 277220)
--- trunk/Websites/perf.webkit.org/tools/sync-commits.py 2021-05-08 01:05:02 UTC (rev 277219)
+++ trunk/Websites/perf.webkit.org/tools/sync-commits.py 2021-05-08 01:08:08 UTC (rev 277220)
@@ -16,6 +16,9 @@
from util import submit_commits
from util import text_content
+# There are some buggy commit messages:
+# Canonical link: https://commits.webkit.org/https://commits.webkit.org/232477@main
+REVISION_IDENTIFIER_RE = re.compile(r'Canonical link: (https\://commits\.webkit\.org/)+(?P\d+@[\w\.\-]+)\n')
def main(argv):
parser = argparse.ArgumentParser()
@@ -43,7 +46,10 @@
def load_repository(repository):
if 'gitCheckout' in repository:
-return GitRepository(name=repository['name'], git_url=repository['url'], git_checkout=repository['gitCheckout'], git_branch=repository.get('branch'))
+return GitRepository(
+name=repository['name'], git_url=repository['url'], git_checkout=repository['gitCheckout'],
+git_branch=repository.get('branch'), report_revision_identifier_in_commit_msg=repository.get('reportRevisionIdentifier'),
+report_svn_revison=repository.get('reportSVNRevision'))
return SVNRepository(name=repository['name'], svn_url=repository['url'], should_trust_certificate=repository.get('trustCertificate', False),
use_server_auth=repository.get('useServerAuth', False), account_name_script_path=repository.get('accountNameFinderScript'))
@@ -192,7 +198,7 @@
class GitRepository(Repository):
-def __init__(self, name, git_checkout, git_url, git_branch=None):
+def __init__(self, name, git_checkout, git_url, git_branch=None, report_revision_identifier_in_commit_msg=False, report_svn_revison=False):
assert(os.path.isdir(git_checkout))
super(GitRepository, self).__init__(name)
self._git_checkout = git_checkout
@@ -199,6 +205,8 @@
self._git_url = git_url
self._git_branch = git_branch
self._tokenized_hashes = []
+self._report_revision_identifier_in_commit_msg = report_revision_identifier_in_commit_msg
+self._report_svn_revision = report_svn_revison
def fetch_next_commit(self, server_config, last_fetched):
if not last_fetched:
@@ -205,6 +213,14 @@
self._fetch_all_hashes()
tokens = self._tokenized_hashes[0]
else:
+if self._report_svn_revision:
+last_fetched_git_hash = self._git_hash_from_svn_revision(last_fetched)
+if not last_fetched_git_hash:
+self._fetch_remote()
+last_fetched_git_hash = self._git_hash_from_svn_revision(last_fetched)
+if not last_fetched_git_hash:
+raise ValueError('Cannot find the git hash for the
[webkit-changes] [275993] trunk/Websites/perf.webkit.org
Title: [275993] trunk/Websites/perf.webkit.org
Revision 275993
Author zhifei_f...@apple.com
Date 2021-04-14 20:06:39 -0700 (Wed, 14 Apr 2021)
Log Message
Support Commit revision identifier in the Chart
https://bugs.webkit.org/show_bug.cgi?id=224496
Reviewed by Dewei Zhu.
In the measurement-set, we include the commit info but not the commit revision identifier column.
Make the API return the commit revision identifier as part of the commit data.
* browser-tests/customizable-test-group-form-tests.js: Fix flaky tests.
* browser-tests/index.html: Add commit revision identifier info.
* browser-tests/time-series-chart-tests.js: Fix flaky tests.
* public/api/measurement-set.php: Make this API provide commit revision identifier info.
* public/include/build-requests-fetcher.php: Ditto.
* public/v3/models/commit-set.js: Make the commit model can be constructed with the API respose format.
* server-tests/api-measurement-set-tests.js: Adding test for commit revision identifier.
* server-tests/api-build-requests-tests.js: Ditto.
* unit-tests/analysis-task-tests.js: Ditto.
(measurementCluster):
* unit-tests/commit-set-tests.js: Ditto.
* unit-tests/measurement-adaptor-tests.js: Ditto.
* unit-tests/measurement-set-tests.js: Ditto.
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js
trunk/Websites/perf.webkit.org/browser-tests/index.html
trunk/Websites/perf.webkit.org/browser-tests/time-series-chart-tests.js
trunk/Websites/perf.webkit.org/public/api/measurement-set.php
trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php
trunk/Websites/perf.webkit.org/public/v3/models/commit-set.js
trunk/Websites/perf.webkit.org/server-tests/api-build-requests-tests.js
trunk/Websites/perf.webkit.org/server-tests/api-measurement-set-tests.js
trunk/Websites/perf.webkit.org/server-tests/resources/mock-data.js
trunk/Websites/perf.webkit.org/unit-tests/analysis-task-tests.js
trunk/Websites/perf.webkit.org/unit-tests/commit-set-tests.js
trunk/Websites/perf.webkit.org/unit-tests/measurement-adaptor-tests.js
trunk/Websites/perf.webkit.org/unit-tests/measurement-set-tests.js
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (275992 => 275993)
--- trunk/Websites/perf.webkit.org/ChangeLog 2021-04-15 02:42:09 UTC (rev 275992)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2021-04-15 03:06:39 UTC (rev 275993)
@@ -1,3 +1,27 @@
+2021-04-14 Zhifei Fang
+
+Support Commit revision identifier in the Chart
+https://bugs.webkit.org/show_bug.cgi?id=224496
+
+Reviewed by Dewei Zhu.
+
+In the measurement-set, we include the commit info but not the commit revision identifier column.
+Make the API return the commit revision identifier as part of the commit data.
+
+* browser-tests/customizable-test-group-form-tests.js: Fix flaky tests.
+* browser-tests/index.html: Add commit revision identifier info.
+* browser-tests/time-series-chart-tests.js: Fix flaky tests.
+* public/api/measurement-set.php: Make this API provide commit revision identifier info.
+* public/include/build-requests-fetcher.php: Ditto.
+* public/v3/models/commit-set.js: Make the commit model can be constructed with the API respose format.
+* server-tests/api-measurement-set-tests.js: Adding test for commit revision identifier.
+* server-tests/api-build-requests-tests.js: Ditto.
+* unit-tests/analysis-task-tests.js: Ditto.
+(measurementCluster):
+* unit-tests/commit-set-tests.js: Ditto.
+* unit-tests/measurement-adaptor-tests.js: Ditto.
+* unit-tests/measurement-set-tests.js: Ditto.
+
2021-03-31 Zhifei Fang
Add commit revision label support
Modified: trunk/Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js (275992 => 275993)
--- trunk/Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js 2021-04-15 02:42:09 UTC (rev 275992)
+++ trunk/Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js 2021-04-15 03:06:39 UTC (rev 275993)
@@ -79,6 +79,9 @@
requests[0].resolve({commits: [commitObjectA]});
requests[1].resolve({commits: [commitObjectB]});
+await requests[0].promise;
+await requests[1].promise;
+
await waitForComponentsToRender(context);
const radioButton = customizableTestGroupForm.content('custom-table').querySelector('input[type="radio"][name="A-1-radio"]:not(:checked)');
@@ -89,6 +92,10 @@
expect(revisionEditors.length).to.be(2);
let revisionEditor = revisionEditors[0];
expect(revisionEditor.value).to.be('210949');
+
+await waitForComponentsToRender(context);
+revisionEditors = customizableTestGroupForm.content('custom-table').querySelectorAll('input:not([type="radio"])');
+revisionEditor = revisionEditors[0];
[webkit-changes] [275329] trunk/Websites/perf.webkit.org
Title: [275329] trunk/Websites/perf.webkit.org
Revision 275329
Author zhifei_f...@apple.com
Date 2021-03-31 17:50:11 -0700 (Wed, 31 Mar 2021)
Log Message
Add commit revision label support
https://bugs.webkit.org/show_bug.cgi?id=222897
Reviewed by Ryosuke Niwa.
Add new column revision label.
Make all commit api also can work with revision label.
Change the commit label display with commit revision label.
* browser-tests/commit-log-viewer-tests.js: Fix a failed test case, while requesting the remote api,
we should wait for those promises resolved and then wait for commponent to render.
* init-database.sql: Add new column revision_identifier.
* migrate-database.sql: Add new column revision_identifier.
* public/include/commit-log-fetcher.php: Make api that works with revision should work with revision label.
* public/include/commit-updater.php: Ditto.
* public/include/report-processor.php: Make the processor can also insert revision label.
* public/v3/models/commit-log.js:
(CommitLog.prototype.updateSingleton):
(CommitLog.prototype.revisionIdentifier):
(CommitLog.prototype.label): Make the label include revision label and revision.
(CommitLog.prototype.diff): Make the diff label include revision label and revision.
* server-tests/api-commits-tests.js:
* server-tests/api-report-commits-tests.js:
* server-tests/api-report-tests.js:
(reportWithRevisionIdentifierCommit):
* unit-tests/commit-log-tests.js:
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/browser-tests/commit-log-viewer-tests.js
trunk/Websites/perf.webkit.org/init-database.sql
trunk/Websites/perf.webkit.org/migrate-database.sql
trunk/Websites/perf.webkit.org/public/include/commit-log-fetcher.php
trunk/Websites/perf.webkit.org/public/include/commit-updater.php
trunk/Websites/perf.webkit.org/public/include/report-processor.php
trunk/Websites/perf.webkit.org/public/v3/models/commit-log.js
trunk/Websites/perf.webkit.org/server-tests/api-commits-tests.js
trunk/Websites/perf.webkit.org/server-tests/api-report-commits-tests.js
trunk/Websites/perf.webkit.org/server-tests/api-report-tests.js
trunk/Websites/perf.webkit.org/unit-tests/commit-log-tests.js
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (275328 => 275329)
--- trunk/Websites/perf.webkit.org/ChangeLog 2021-04-01 00:47:35 UTC (rev 275328)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2021-04-01 00:50:11 UTC (rev 275329)
@@ -1,3 +1,32 @@
+2021-03-31 Zhifei Fang
+
+Add commit revision label support
+https://bugs.webkit.org/show_bug.cgi?id=222897
+
+Reviewed by Ryosuke Niwa.
+
+Add new column revision label.
+Make all commit api also can work with revision label.
+Change the commit label display with commit revision label.
+
+* browser-tests/commit-log-viewer-tests.js: Fix a failed test case, while requesting the remote api,
+we should wait for those promises resolved and then wait for commponent to render.
+* init-database.sql: Add new column revision_identifier.
+* migrate-database.sql: Add new column revision_identifier.
+* public/include/commit-log-fetcher.php: Make api that works with revision should work with revision label.
+* public/include/commit-updater.php: Ditto.
+* public/include/report-processor.php: Make the processor can also insert revision label.
+* public/v3/models/commit-log.js:
+(CommitLog.prototype.updateSingleton):
+(CommitLog.prototype.revisionIdentifier):
+(CommitLog.prototype.label): Make the label include revision label and revision.
+(CommitLog.prototype.diff): Make the diff label include revision label and revision.
+* server-tests/api-commits-tests.js:
+* server-tests/api-report-commits-tests.js:
+* server-tests/api-report-tests.js:
+(reportWithRevisionIdentifierCommit):
+* unit-tests/commit-log-tests.js:
+
2021-03-22 Dewei Zhu
[perf dashboard] Remove v1 and v2 code.
Modified: trunk/Websites/perf.webkit.org/browser-tests/commit-log-viewer-tests.js (275328 => 275329)
--- trunk/Websites/perf.webkit.org/browser-tests/commit-log-viewer-tests.js 2021-04-01 00:47:35 UTC (rev 275328)
+++ trunk/Websites/perf.webkit.org/browser-tests/commit-log-viewer-tests.js 2021-04-01 00:50:11 UTC (rev 275329)
@@ -55,6 +55,19 @@
"message": "another message",
};
+const webkitCommit210950WithRevisionIdentifier = {
+"id": "185338",
+"revision": "210950",
+"revisionIdentifier": "184278@main",
+"repository": 1,
+"previousCommit": null,
+"ownsCommits": false,
+"time": +new Date("2017-01-20T03:49:37.887Z"),
+"authorName": "Commit Queue",
+"authorEmail": "commit-qu...@webkit.org",
+"message": "another message",
+};
+
it('should initially be empty with no spinner', () => {
const context = new BrowsingContext();
[webkit-changes] [266937] trunk/Tools
Title: [266937] trunk/Tools
Revision 266937
Author zhifei_f...@apple.com
Date 2020-09-11 14:14:36 -0700 (Fri, 11 Sep 2020)
Log Message
Strip Quotes for run-jsc-stress-tests --model arg
https://bugs.webkit.org/show_bug.cgi?id=216417
Reviewed by Jonathan Bedard.
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Tools/ChangeLog (266936 => 266937)
--- trunk/Tools/ChangeLog 2020-09-11 20:27:38 UTC (rev 266936)
+++ trunk/Tools/ChangeLog 2020-09-11 21:14:36 UTC (rev 266937)
@@ -1,3 +1,12 @@
+2020-09-11 Zhifei Fang
+
+Strip Quotes for run-jsc-stress-tests --model arg
+https://bugs.webkit.org/show_bug.cgi?id=216417
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/run-jsc-stress-tests:
+
2020-09-11 Sihui Liu
REGRESSION(r266634): WKThumbnailViewResetsViewStateWhenUnparented is flaky
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (266936 => 266937)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2020-09-11 20:27:38 UTC (rev 266936)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2020-09-11 21:14:36 UTC (rev 266937)
@@ -266,7 +266,7 @@
when '--os'
$hostOS = arg
when '--model'
-$model = arg
+$model = arg.gsub(/\A['"]+|['"]+\Z/, '')
when '--env-vars'
$envVars = arg.gsub(/\s+/, ' ').split(' ')
when '--quick'
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [265204] trunk/Tools
Title: [265204] trunk/Tools
Revision 265204
Author zhifei_f...@apple.com
Date 2020-08-03 10:30:53 -0700 (Mon, 03 Aug 2020)
Log Message
run-jsc-stress-test: Set DYLD_FRAMEWORK_PATH to "$(cd ../.vm; pwd)" because it escape shell words
https://bugs.webkit.org/show_bug.cgi?id=215077
Reviewed by Alexey Proskuryakov.
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Tools/ChangeLog (265203 => 265204)
--- trunk/Tools/ChangeLog 2020-08-03 17:27:52 UTC (rev 265203)
+++ trunk/Tools/ChangeLog 2020-08-03 17:30:53 UTC (rev 265204)
@@ -1,3 +1,12 @@
+2020-08-03 Zhifei Fang
+
+run-jsc-stress-test: Set DYLD_FRAMEWORK_PATH to "$(cd ../.vm; pwd)" because it escape shell words
+https://bugs.webkit.org/show_bug.cgi?id=215077
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/run-jsc-stress-tests:
+
2020-08-03 Brian Burg
REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite flags in safaripy
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (265203 => 265204)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2020-08-03 17:27:52 UTC (rev 265203)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2020-08-03 17:30:53 UTC (rev 265204)
@@ -2114,11 +2114,11 @@
end
def exportBaseEnvironmentVariables
-dyldFrameworkPath = "$(cd #{$testingFrameworkPath.dirname}; pwd)"
-ldLibraryPath = "$(pwd)/#{$outputDir.basename}/#{$jscPath.dirname}"
+dyldFrameworkPath = "\\$(cd #{$testingFrameworkPath.dirname}; pwd)"
+ldLibraryPath = "\\$(pwd)/#{$outputDir.basename}/#{$jscPath.dirname}"
[
-"export DYLD_FRAMEWORK_PATH=#{Shellwords.shellescape(dyldFrameworkPath)} && ",
-"export LD_LIBRARY_PATH=#{Shellwords.shellescape(ldLibraryPath)} &&",
+"export DYLD_FRAMEWORK_PATH=#{dyldFrameworkPath} && ",
+"export LD_LIBRARY_PATH=#{ldLibraryPath} &&",
"export JSCTEST_timeout=#{Shellwords.shellescape(ENV['JSCTEST_timeout'])} && ",
"export JSCTEST_hardTimeout=#{Shellwords.shellescape(ENV['JSCTEST_hardTimeout'])} && ",
"export JSCTEST_memoryLimit=#{Shellwords.shellescape(ENV['JSCTEST_memoryLimit'])} && ",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [263976] trunk/Tools
Title: [263976] trunk/Tools
Revision 263976
Author zhifei_f...@apple.com
Date 2020-07-06 11:09:28 -0700 (Mon, 06 Jul 2020)
Log Message
[result database] Empty search will return too many tests to display
https://bugs.webkit.org/show_bug.cgi?id=213898
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/js/search.js: Trim the search string before fetching the tests, ingore empty string on paste event
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/search.js
Diff
Modified: trunk/Tools/ChangeLog (263975 => 263976)
--- trunk/Tools/ChangeLog 2020-07-06 17:44:31 UTC (rev 263975)
+++ trunk/Tools/ChangeLog 2020-07-06 18:09:28 UTC (rev 263976)
@@ -1,3 +1,12 @@
+2020-07-06 Zhifei Fang
+
+[result database] Empty search will return too many tests to display
+https://bugs.webkit.org/show_bug.cgi?id=213898
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/js/search.js: Trim the search string before fetching the tests, ingore empty string on paste event
+
2020-07-06 Geoffrey Garen
RunLoop::dispatch should only call wakeUp when needed
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/search.js (263975 => 263976)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/search.js 2020-07-06 17:44:31 UTC (rev 263975)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/search.js 2020-07-06 18:09:28 UTC (rev 263976)
@@ -149,12 +149,14 @@
if (event.keyCode == 0x28 /* DOM_VK_DOWN */ || event.keyCode == 0x26 /* DOM_VK_UP */)
return;
+const inputValue = element.value.trimStart().trimEnd();
+if (!inputValue)
+return;
let myDispatch = Date.now();
-
candidates = {};
suites.forEach(suite => {
inFlight += 1;
-fetch(`api/${suite}/tests?limit=${LIMIT}=${element.value}`).then(response => {
+fetch(`api/${suite}/tests?limit=${LIMIT}=${inputValue}`).then(response => {
inFlight -= 1;
if (myDispatch < currentDispatch) {
candidatesRef.setState({});
@@ -215,7 +217,8 @@
ignoring = false;
return;
}
-tests.add(str);
+if (str)
+tests.add(str);
});
tests = [...tests];
if (tests.length <= 1)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [262807] trunk/Tools
Title: [262807] trunk/Tools
Revision 262807
Author zhifei_f...@apple.com
Date 2020-06-09 13:52:57 -0700 (Tue, 09 Jun 2020)
Log Message
Add a timeout monitor for JSC stress test
https://bugs.webkit.org/show_bug.cgi?id=211978
Reviewed by Jonathan Bedard.
* Scripts/webkitruby/jsc-stress-test-writer-default.rb: Add timeout monitor inside the jsc stress test runner, it will kill the process in case of jsc timeout handler not working
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb
Diff
Modified: trunk/Tools/ChangeLog (262806 => 262807)
--- trunk/Tools/ChangeLog 2020-06-09 20:44:14 UTC (rev 262806)
+++ trunk/Tools/ChangeLog 2020-06-09 20:52:57 UTC (rev 262807)
@@ -1,3 +1,12 @@
+2020-06-09 Zhifei Fang
+
+Add a timeout monitor for JSC stress test
+https://bugs.webkit.org/show_bug.cgi?id=211978
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/webkitruby/jsc-stress-test-writer-default.rb: Add timeout monitor inside the jsc stress test runner, it will kill the process in case of jsc timeout handler not working
+
2020-06-09 Tim Horton
WebKit.ShrinkToFit is failing on some bots
Modified: trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb (262806 => 262807)
--- trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb 2020-06-09 20:44:14 UTC (rev 262806)
+++ trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb 2020-06-09 20:52:57 UTC (rev 262807)
@@ -232,7 +232,40 @@
end
@additionalEnv = []
end
-
+
+def timeoutMonitorAddon
+# In case the JSC timeout handler is not working, add a timeout monitor in the script
+interval = 30 # Seconds
+timeout = ENV['JSCTEST_timeout'].to_i + 10 # Let jsc timeout handler trigger first
+if !timeout
+timeout = interval
+end
+if timeout < interval
+interval = timeout
+end
+script = %Q[
+(
+((count_down = #{timeout}))
+while ((count_down > 0)); do
+if [ "$count_down" -gt #{interval} ]
+then
+sleep #{interval}
+else
+sleep count_down
+fi
+pgrep -P $$ 1>/dev/null || exit 0
+((count_down -= #{interval}))
+done
+echo "#{Shellwords.shellescape(@name)} has timed out, killing with timeout monitor"
+kill -s SIGTERM $$
+sleep 5
+pgrep -P 1>/dev/null $$ && kill -s SIGKILL $$
+echo FAIL: #{Shellwords.shellescape(@name)} ; touch #{failFile} ;
+) &
+]
+return script
+end
+
def shellCommand
# It's important to remember that the test is actually run in a subshell, so if we change directory
# in the subshell when we return we will be in our original directory. This is nice because we don't
@@ -288,7 +321,8 @@
outp.puts "START_TIME=$SECONDS"
end
outp.puts "echo Running #{Shellwords.shellescape(@name)}"
-cmd = "(" + shellCommand + " || (echo $? > #{failFile})) 2>&1 "
+cmd = timeoutMonitorAddon
+cmd += "(" + shellCommand + " || (echo $? > #{failFile})) 2>&1 "
cmd += @outputHandler.call(@name)
if $verbosity >= 3
outp.puts "echo #{Shellwords.shellescape(cmd)}"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [260786] trunk/Tools
Title: [260786] trunk/Tools
Revision 260786
Author zhifei_f...@apple.com
Date 2020-04-27 14:37:58 -0700 (Mon, 27 Apr 2020)
Log Message
Add some debug output for run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=210999
This will help to address where the script get stucked
Reviewed by Jonathan Bedard.
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Tools/ChangeLog (260785 => 260786)
--- trunk/Tools/ChangeLog 2020-04-27 21:32:50 UTC (rev 260785)
+++ trunk/Tools/ChangeLog 2020-04-27 21:37:58 UTC (rev 260786)
@@ -1,3 +1,15 @@
+2020-04-27 Zhifei Fang
+
+Add some debug output for run-jsc-stress-tests
+https://bugs.webkit.org/show_bug.cgi?id=210999
+
+
+This will help to address where the script get stucked
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/run-jsc-stress-tests:
+
2020-04-27 Wenson Hsieh
Text manipulation should not aggregate text from different navigation anchor elements
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (260785 => 260786)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2020-04-27 21:32:50 UTC (rev 260785)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2020-04-27 21:37:58 UTC (rev 260786)
@@ -2085,9 +2085,9 @@
def detectFailures
raise if $bundle
-
+puts "Detecting Failures..."
failures = []
-
+start_time = Time.now
if $remote
$remoteHosts.each_with_index {
| host, remoteIndex |
@@ -2115,6 +2115,7 @@
}
familyMap = {}
+puts "#{Time.now}: Writing to #{$outputDir + "results, pass, failed"}"
$runlist.each_with_index {
| plan, index |
unless familyMap[plan.family]
@@ -2131,6 +2132,7 @@
appendPass(plan)
}
+puts "#{Time.now}: Writing to #{$outputDir + "resultsByFamily"}"
File.open($outputDir + "resultsByFamily", "w") {
| outp |
first = true
@@ -2165,6 +2167,7 @@
end
}
}
+puts "Detacted failures in #{Time.now - start_time}"
end
def compressBundle
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259214] trunk/Tools
Title: [259214] trunk/Tools
Revision 259214
Author zhifei_f...@apple.com
Date 2020-03-30 11:47:17 -0700 (Mon, 30 Mar 2020)
Log Message
[results.webkit.org: Timeline]: Left side of the timeline scale is usually bigger than the right
https://bugs.webkit.org/show_bug.cgi?id=209569
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
Diff
Modified: trunk/Tools/ChangeLog (259213 => 259214)
--- trunk/Tools/ChangeLog 2020-03-30 18:30:01 UTC (rev 259213)
+++ trunk/Tools/ChangeLog 2020-03-30 18:47:17 UTC (rev 259214)
@@ -1,3 +1,13 @@
+2020-03-30 Zhifei Fang
+
+[results.webkit.org: Timeline]: Left side of the timeline scale is usually bigger than the right
+
+https://bugs.webkit.org/show_bug.cgi?id=209569
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+
2020-03-30 Frank Yang
Update my name in contributors.json
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (259213 => 259214)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-30 18:30:01 UTC (rev 259213)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-30 18:47:17 UTC (rev 259214)
@@ -604,7 +604,7 @@
Timeline.CanvasXAxisComponent = (scales, option = {}) => {
// Get configuration
const getScaleKey = typeof option.getScaleFunc === "function" ? option.getScaleFunc : (a) => a;
-const comp = typeof option.compareFunc === "function" ? option.compareFunc : (a, b) => a - b;
+const comp = typeof option.compareFunc === "function" ? option.compareFunc : (a, b) => b - a;
const _onScaleClick_ = typeof option._onScaleClick_ === "function" ? option.onScaleClick : null;
const _onScaleEnter_ = typeof option._onScaleEnter_ === "function" ? option.onScaleEnter : null;
const _onScaleLeave_ = typeof option._onScaleLeave_ === "function" ? option.onScaleLeave : null;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259019] trunk/Tools
Title: [259019] trunk/Tools
Revision 259019
Author zhifei_f...@apple.com
Date 2020-03-25 16:19:32 -0700 (Wed, 25 Mar 2020)
Log Message
[Timeline] A better default get label function, which fit the assumpation the label is always a string
https://bugs.webkit.org/show_bug.cgi?id=209567
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
Diff
Modified: trunk/Tools/ChangeLog (259018 => 259019)
--- trunk/Tools/ChangeLog 2020-03-25 23:19:01 UTC (rev 259018)
+++ trunk/Tools/ChangeLog 2020-03-25 23:19:32 UTC (rev 259019)
@@ -1,5 +1,14 @@
2020-03-25 Zhifei Fang
+[Timeline] A better default get label function, which fit the assumpation the label is always a string
+https://bugs.webkit.org/show_bug.cgi?id=209567
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+
+2020-03-25 Zhifei Fang
+
[Timeline] Fix the out of bound dot index
https://bugs.webkit.org/show_bug.cgi?id=209492
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (259018 => 259019)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-25 23:19:01 UTC (rev 259018)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-25 23:19:32 UTC (rev 259019)
@@ -609,7 +609,7 @@
const _onScaleEnter_ = typeof option._onScaleEnter_ === "function" ? option.onScaleEnter : null;
const _onScaleLeave_ = typeof option._onScaleLeave_ === "function" ? option.onScaleLeave : null;
const sortData = option.sortData === true ? option.sortData : false;
-const getLabel = typeof option.getLabelFunc === "function" ? option.getLabelFunc : (a) => a;
+const getLabel = typeof option.getLabelFunc === "function" ? option.getLabelFunc : (a) => `${a}`;
const isTop = typeof option.isTop === "boolean" ? option.isTop : false;
// Get the css value, this component assume to use with webkit.css
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259017] trunk/Tools
Title: [259017] trunk/Tools
Revision 259017
Author zhifei_f...@apple.com
Date 2020-03-25 16:05:41 -0700 (Wed, 25 Mar 2020)
Log Message
[Timeline] Fix the out of bound dot index
https://bugs.webkit.org/show_bug.cgi?id=209492
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(Timeline.CanvasSeriesComponent):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
Diff
Modified: trunk/Tools/ChangeLog (259016 => 259017)
--- trunk/Tools/ChangeLog 2020-03-25 22:53:10 UTC (rev 259016)
+++ trunk/Tools/ChangeLog 2020-03-25 23:05:41 UTC (rev 259017)
@@ -1,3 +1,13 @@
+2020-03-25 Zhifei Fang
+
+[Timeline] Fix the out of bound dot index
+https://bugs.webkit.org/show_bug.cgi?id=209492
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+(Timeline.CanvasSeriesComponent):
+
2020-03-25 Daniel Bates
Element context character rects may be in wrong coordinate system
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (259016 => 259017)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-25 22:53:10 UTC (rev 259016)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-25 23:05:41 UTC (rev 259017)
@@ -385,10 +385,8 @@
let endScalesIndex = startScalesIndex + Math.ceil((renderWidth) / dotWidth);
if (endScalesIndex >= scales.length)
endScalesIndex = scales.length - 1;
-let currentDotIndex = startScalesIndex - (scales.length - dots.length);
-if (currentDotIndex < 0)
-currentDotIndex = 0;
-for (let i = currentDotIndex; i <= startScalesIndex; i++) {
+let currentDotIndex = 0;
+for (let i = currentDotIndex; i <= startScalesIndex && currentDotIndex < dots.length; i++) {
const compResult = comp(scales[startScalesIndex], getScale(dots[currentDotIndex]));
if (!reversed) {
if (compResult > 0)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257895] trunk/Websites/perf.webkit.org
Title: [257895] trunk/Websites/perf.webkit.org
Revision 257895
Author zhifei_f...@apple.com
Date 2020-03-04 19:14:47 -0800 (Wed, 04 Mar 2020)
Log Message
Test-freshness page table heaer misplaced
Some platform name is too long
https://bugs.webkit.org/show_bug.cgi?id=208617
Reviewed by Ryosuke Niwa.
* public/v3/pages/test-freshness-page.js:
(TestFreshnessPage.cssTemplate):
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (257894 => 257895)
--- trunk/Websites/perf.webkit.org/ChangeLog 2020-03-05 02:35:06 UTC (rev 257894)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2020-03-05 03:14:47 UTC (rev 257895)
@@ -1,3 +1,14 @@
+2020-03-04 Zhifei Fang
+
+Test-freshness page table heaer misplaced
+Some platform name is too long
+https://bugs.webkit.org/show_bug.cgi?id=208617
+
+Reviewed by Ryosuke Niwa.
+
+* public/v3/pages/test-freshness-page.js:
+(TestFreshnessPage.cssTemplate):
+
2019-12-15 Zhifei Fang
Add power metric to perf dashboard
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js (257894 => 257895)
--- trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2020-03-05 02:35:06 UTC (rev 257894)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2020-03-05 03:14:47 UTC (rev 257895)
@@ -431,7 +431,7 @@
vertical-align: bottom;
}
#test-health .row-head {
-min-width: 15.5rem;
+min-width: 18.5rem;
}
#test-health th {
text-align: left;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256807] trunk/Tools
Title: [256807] trunk/Tools Revision 256807 Author zhifei_f...@apple.com Date 2020-02-17 19:04:58 -0800 (Mon, 17 Feb 2020) Log Message [Webkit.css] Adding popover style element This help to prevent us reinventing the wheel ever again https://bugs.webkit.org/show_bug.cgi?id=207787 Reviewed by Dean Jackson. * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: * resultsdbpy/resultsdbpy/view/static/library/css/index.html: * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: (.popover): (.popover>.content): (.popover.display): (.popover .arrow): (.popover .arrow.point-top): (.popover .arrow.point-bottom): (.popover .arrow.point-left): (.popover .arrow.point-right): (@media (prefers-color-scheme: dark) .popover>.content): (@media (prefers-color-scheme: dark) .popover.display): (@media (prefers-color-scheme: dark) .popover .arrow): (.popover>.content>.section): Deleted. (.popover:focus>.content, .popover:hover>.content): Deleted. (.popover.right>.content): Deleted. (.popover.right :focus>.content, .popover.right:hover>.content): Deleted. (.popover.left>.content): Deleted. (.popover.left :focus>.content, .popover.left:hover>.content): Deleted. (.popover.bottom>.content): Deleted. (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted. Modified Paths trunk/Tools/ChangeLog trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/index.html trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css Diff Modified: trunk/Tools/ChangeLog (256806 => 256807) --- trunk/Tools/ChangeLog 2020-02-18 02:51:26 UTC (rev 256806) +++ trunk/Tools/ChangeLog 2020-02-18 03:04:58 UTC (rev 256807) @@ -1,3 +1,34 @@ +2020-02-17 Zhifei Fang + +[Webkit.css] Adding popover style element +This help to prevent us reinventing the wheel ever again +https://bugs.webkit.org/show_bug.cgi?id=207787 + +Reviewed by Dean Jackson. + +* resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: +* resultsdbpy/resultsdbpy/view/static/library/css/index.html: +* resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: +(.popover): +(.popover>.content): +(.popover.display): +(.popover .arrow): +(.popover .arrow.point-top): +(.popover .arrow.point-bottom): +(.popover .arrow.point-left): +(.popover .arrow.point-right): +(@media (prefers-color-scheme: dark) .popover>.content): +(@media (prefers-color-scheme: dark) .popover.display): +(@media (prefers-color-scheme: dark) .popover .arrow): +(.popover>.content>.section): Deleted. +(.popover:focus>.content, .popover:hover>.content): Deleted. +(.popover.right>.content): Deleted. +(.popover.right :focus>.content, .popover.right:hover>.content): Deleted. +(.popover.left>.content): Deleted. +(.popover.left :focus>.content, .popover.left:hover>.content): Deleted. +(.popover.bottom>.content): Deleted. +(.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted. + 2020-02-17 Brent Fulgham Update WebKit Tools to issue mach extensions as needed Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml (256806 => 256807) --- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml 2020-02-18 02:51:26 UTC (rev 256806) +++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml 2020-02-18 03:04:58 UTC (rev 256807) @@ -1463,3 +1463,50 @@ Tests have error +- +title: Popover +examples: +- +description: ~ +html: |- + + + + +This is popover; + + + +Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. + + + + + + +This is a popover + + + +Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor
[webkit-changes] [253542] trunk
Title: [253542] trunk
Revision 253542
Author zhifei_f...@apple.com
Date 2019-12-15 14:12:34 -0800 (Sun, 15 Dec 2019)
Log Message
Add power metric to perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=205227
Reviewed by Ryosuke Niwa.
* public/v3/models/metric.js:
(Metric):
Modified Paths
trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/js/helper-classes.js
trunk/Websites/perf.webkit.org/public/v2/data.js
trunk/Websites/perf.webkit.org/public/v3/models/metric.js
Diff
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py (253541 => 253542)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py 2019-12-15 21:50:30 UTC (rev 253541)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py 2019-12-15 22:12:34 UTC (rev 253542)
@@ -44,6 +44,7 @@
'Heap': 'B',
'Allocations': 'B',
'Score': 'pt',
+'Power': 'W',
}
SI_prefixes = ['n', 'u', 'm', '', 'K', 'M', 'G', 'T', 'P', 'E']
Modified: trunk/Websites/perf.webkit.org/ChangeLog (253541 => 253542)
--- trunk/Websites/perf.webkit.org/ChangeLog 2019-12-15 21:50:30 UTC (rev 253541)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2019-12-15 22:12:34 UTC (rev 253542)
@@ -1,3 +1,13 @@
+2019-12-15 Zhifei Fang
+
+Add power metric to perf dashboard
+https://bugs.webkit.org/show_bug.cgi?id=205227
+
+Reviewed by Ryosuke Niwa.
+
+* public/v3/models/metric.js:
+(Metric):
+
2019-12-05 Dewei Zhu
Custom analysis task page should allow schedule any triggerable accepted tests.
Modified: trunk/Websites/perf.webkit.org/public/js/helper-classes.js (253541 => 253542)
--- trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2019-12-15 21:50:30 UTC (rev 253541)
+++ trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2019-12-15 22:12:34 UTC (rev 253542)
@@ -164,7 +164,9 @@
'Heap': 'B',
'Allocations': 'B',
'Size': 'B',
-'Score': 'pt'}[suffix];
+'Score': 'pt',
+'Power': 'W'
+}[suffix];
// We can't do this in PerfTestResult because all results for each metric need to share the same unit and the same scaling factor.
function computeScalingFactorIfNeeded() {
Modified: trunk/Websites/perf.webkit.org/public/v2/data.js (253541 => 253542)
--- trunk/Websites/perf.webkit.org/public/v2/data.js 2019-12-15 21:50:30 UTC (rev 253541)
+++ trunk/Websites/perf.webkit.org/public/v2/data.js 2019-12-15 22:12:34 UTC (rev 253542)
@@ -412,6 +412,7 @@
'Allocations': 'B',
'Size': 'B',
'Score': 'pt',
+'Power': 'W'
}[suffix];
return unit;
}
Modified: trunk/Websites/perf.webkit.org/public/v3/models/metric.js (253541 => 253542)
--- trunk/Websites/perf.webkit.org/public/v3/models/metric.js 2019-12-15 21:50:30 UTC (rev 253541)
+++ trunk/Websites/perf.webkit.org/public/v3/models/metric.js 2019-12-15 22:12:34 UTC (rev 253542)
@@ -20,6 +20,7 @@
'Allocations': 'B',
'Size': 'B',
'Score': 'pt',
+'Power': 'W',
}[suffix];
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [251575] trunk/LayoutTests
Title: [251575] trunk/LayoutTests
Revision 251575
Author zhifei_f...@apple.com
Date 2019-10-24 17:27:00 -0700 (Thu, 24 Oct 2019)
Log Message
[jsc test] Skip intl-numberformat.js test
https://bugs.webkit.org/show_bug.cgi?id=203279
Reviewed by Yusuke Suzuki.
* js/script-tests/intl-numberformat.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/script-tests/intl-numberformat.js
Diff
Modified: trunk/LayoutTests/ChangeLog (251574 => 251575)
--- trunk/LayoutTests/ChangeLog 2019-10-25 00:08:13 UTC (rev 251574)
+++ trunk/LayoutTests/ChangeLog 2019-10-25 00:27:00 UTC (rev 251575)
@@ -1,3 +1,12 @@
+2019-10-24 Zhifei Fang
+
+[jsc test] Skip intl-numberformat.js test
+https://bugs.webkit.org/show_bug.cgi?id=203279
+
+Reviewed by Yusuke Suzuki.
+
+* js/script-tests/intl-numberformat.js:
+
2019-10-24 Russell Epstein
Unreviewed, rolling out r251536.
Modified: trunk/LayoutTests/js/script-tests/intl-numberformat.js (251574 => 251575)
--- trunk/LayoutTests/js/script-tests/intl-numberformat.js 2019-10-25 00:08:13 UTC (rev 251574)
+++ trunk/LayoutTests/js/script-tests/intl-numberformat.js 2019-10-25 00:27:00 UTC (rev 251575)
@@ -1,3 +1,4 @@
+//@ skip if true # added by mark-jsc-stress-test.py
//@ skip if $hostOS == "windows"
description("This test checks the behavior of Intl.NumberFormat as described in the ECMAScript Internationalization API Specification (ECMA-402 2.0).");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [251410] trunk/Tools
Title: [251410] trunk/Tools Revision 251410 Author zhifei_f...@apple.com Date 2019-10-21 18:48:40 -0700 (Mon, 21 Oct 2019) Log Message [results.webkit.org] Change dot and lengend dot use same mechanism to center text and image https://bugs.webkit.org/show_bug.cgi?id=203216 Reviewed by Jonathan Bedard. * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: * resultsdbpy/resultsdbpy/view/static/library/css/index.html: * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: (.dot *): (.dot img, .dot .text): (.dot>img, .dot>.text): (.dot.small img, .dot.small .text): (.dot.small>img, .dot.small>.text): (.dot.medium img, .dot.medium .text): (.dot.medium>img, .dot.medium>.text): (.dot.large img, .dot.large .text): (.dot.large>img, .dot.large>.text): (.lengend>.item .dot): (.lengend>.item .dot img, .lengend>.item .dot .text): (.lengend>.item .dot>img, .lengend>.item .dot>.text): (.dot.small *): Deleted. (.dot img, .dot.small img): Deleted. (.dot.medium *): Deleted. (.dot.medium img): Deleted. (.dot.large *): Deleted. (.dot.large img): Deleted. (.lengend>.item .dot .text): Deleted. (.lengend>.item .dot img): Deleted. Modified Paths trunk/Tools/ChangeLog trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/index.html trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css Diff Modified: trunk/Tools/ChangeLog (251409 => 251410) --- trunk/Tools/ChangeLog 2019-10-22 01:34:39 UTC (rev 251409) +++ trunk/Tools/ChangeLog 2019-10-22 01:48:40 UTC (rev 251410) @@ -1,3 +1,34 @@ +2019-10-21 Zhifei Fang + +[results.webkit.org] Change dot and lengend dot use same mechanism to center text and image +https://bugs.webkit.org/show_bug.cgi?id=203216 + +Reviewed by Jonathan Bedard. + +* resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: +* resultsdbpy/resultsdbpy/view/static/library/css/index.html: +* resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: +(.dot *): +(.dot img, .dot .text): +(.dot>img, .dot>.text): +(.dot.small img, .dot.small .text): +(.dot.small>img, .dot.small>.text): +(.dot.medium img, .dot.medium .text): +(.dot.medium>img, .dot.medium>.text): +(.dot.large img, .dot.large .text): +(.dot.large>img, .dot.large>.text): +(.lengend>.item .dot): +(.lengend>.item .dot img, .lengend>.item .dot .text): +(.lengend>.item .dot>img, .lengend>.item .dot>.text): +(.dot.small *): Deleted. +(.dot img, .dot.small img): Deleted. +(.dot.medium *): Deleted. +(.dot.medium img): Deleted. +(.dot.large *): Deleted. +(.dot.large img): Deleted. +(.lengend>.item .dot .text): Deleted. +(.lengend>.item .dot img): Deleted. + 2019-10-21 youenn fablet Move service worker registration matching for navigation loads to network process Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml (251409 => 251410) --- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml 2019-10-22 01:34:39 UTC (rev 251409) +++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml 2019-10-22 01:48:40 UTC (rev 251410) @@ -754,24 +754,30 @@ With string inside html: |- - + - + -! +! - + - + -! +! - +description: With image inside +html: |- + + +- description: Blink html: |- @@ -1415,7 +1421,7 @@ Tests Failed - + Tests have error @@ -1434,7 +1440,7 @@ Tests Failed - + Tests have error @@ -1453,7 +1459,7 @@
[webkit-changes] [251161] trunk/Tools
Title: [251161] trunk/Tools
Revision 251161
Author zhifei_f...@apple.com
Date 2019-10-15 15:24:04 -0700 (Tue, 15 Oct 2019)
Log Message
Tool to mark jsc test skip/enable
https://bugs.webkit.org/show_bug.cgi?id=202063
Reviewed by Keith Miller.
* Scripts/run-_javascript_core-tests:
(runJSCStressTests):
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
trunk/Tools/Scripts/run-jsc-stress-tests
Added Paths
trunk/Tools/Scripts/mark-jsc-stress-test
Diff
Modified: trunk/Tools/ChangeLog (251160 => 251161)
--- trunk/Tools/ChangeLog 2019-10-15 22:06:23 UTC (rev 251160)
+++ trunk/Tools/ChangeLog 2019-10-15 22:24:04 UTC (rev 251161)
@@ -1,3 +1,14 @@
+2019-10-15 Zhifei Fang
+
+Tool to mark jsc test skip/enable
+https://bugs.webkit.org/show_bug.cgi?id=202063
+
+Reviewed by Keith Miller.
+
+* Scripts/run-_javascript_core-tests:
+(runJSCStressTests):
+* Scripts/run-jsc-stress-tests:
+
2019-10-15 Peng Liu
[Picture-in-Picture Web API] Implement HTMLVideoElement.requestPictureInPicture() / Document.exitPictureInPicture()
Added: trunk/Tools/Scripts/mark-jsc-stress-test (0 => 251161)
--- trunk/Tools/Scripts/mark-jsc-stress-test (rev 0)
+++ trunk/Tools/Scripts/mark-jsc-stress-test 2019-10-15 22:24:04 UTC (rev 251161)
@@ -0,0 +1,171 @@
+#!/usr/bin/env python -u
+import os
+import sys
+import getopt
+import argparse
+import re
+import logging
+import json
+
+logger = logging.getLogger()
+handler = logging.StreamHandler(sys.stdout)
+formatter = logging.Formatter('%(asctime)s - %(levelname)s - %(message)s')
+handler.setFormatter(formatter)
+logger.setLevel(logging.INFO)
+logger.addHandler(handler)
+
+def iter_dir_recusive(path, callback):
+if os.path.isfile(path) and os.path.splitext(path)[1] == '.js':
+logger.info("Processing {} ...".format(path))
+callback(path)
+else:
+for root, dirs, files in os.walk(path):
+for name in files:
+iter_dir_recusive(os.path.join(root, name), callback)
+logger.info("Done.")
+
+
+class JSCTestModifier(object):
+variables = [
+"$hostOs", "$model", "$architecture"
+]
+def __init__(self, test_pathes, conditions={}, match="all"):
+self._conditions = conditions
+self._test_pathes = test_pathes
+self._match = match
+self._skip_line_postfix = "# added by mark-jsc-stress-test.py"
+
+def skip(self):
+for path in self._test_pathes:
+logger.info("Mark {} skip".format(path))
+iter_dir_recusive(path, lambda file_path: self._skip_test_file(file_path))
+
+def enable(self):
+for path in self._test_pathes:
+logger.info("Mark {} enable".format(path))
+iter_dir_recusive(path, lambda file_path: self._enable_test_file(file_path))
+
+def _generate_condition_op(self, value):
+op = "=="
+if ("!" == value[0]):
+op = "!="
+value = value[1:]
+return op, value
+
+# Condition grammer is like !A or B or C and D
+# Translate it to ruby: $hostOs != A or $hostOs == B or $hostOs == C and $hostOs == D
+def _parse_condition(self, variable, condition):
+res = []
+values = []
+for word in re.split(r'\s+', condition):
+if word == "or" or word == "and":
+value = " ".join(values).strip()
+values = []
+res.append('{} {} "{}"'.format(variable, *self._generate_condition_op(value)))
+res.append(word)
+else:
+values.append(word)
+if values:
+value = " ".join(values).strip()
+res.append('{} {} "{}"'.format(variable, *self._generate_condition_op(value)))
+return " ".join(res)
+
+def _generate_skip_annotation_line(self):
+skip_line_prefix = "//@ skip if"
+skip_conditions = []
+skip_line = "{} {} {}"
+supported_variables = filter(lambda variable: variable in self._conditions, JSCTestModifier.variables)
+condition_template = "{}" if len(supported_variables) == 1 else "({})"
+for variable in supported_variables:
+skip_conditions.append(condition_template.format(self._parse_condition(variable, self._conditions[variable])))
+if not skip_conditions:
+# No conditions, always skip
+skip_conditions = ["true"]
+if self._match == "any":
+skip_line = skip_line.format(skip_line_prefix, " or ".join(skip_conditions), self._skip_line_postfix)
+elif self._match == "all":
+skip_line = skip_line.format(skip_line_prefix, " and ".join(skip_conditions), self._skip_line_postfix)
+return skip_line
+
+# This can only remove the skip annotation generated by this script
+def _enable_test_file(self, test_file):
+
[webkit-changes] [251114] trunk/Tools
Title: [251114] trunk/Tools
Revision 251114
Author zhifei_f...@apple.com
Date 2019-10-14 17:47:56 -0700 (Mon, 14 Oct 2019)
Log Message
results.webkit.org: TypeError when evaluating empty commits
https://bugs.webkit.org/show_bug.cgi?id=202936
Reviewed by Jonathan Bedard.
*resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Draw empty line when invaild scales or dots state pass in
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
Diff
Modified: trunk/Tools/ChangeLog (251113 => 251114)
--- trunk/Tools/ChangeLog 2019-10-15 00:34:03 UTC (rev 251113)
+++ trunk/Tools/ChangeLog 2019-10-15 00:47:56 UTC (rev 251114)
@@ -1,3 +1,12 @@
+2019-10-14 Zhifei FANG
+
+results.webkit.org: TypeError when evaluating empty commits
+https://bugs.webkit.org/show_bug.cgi?id=202936
+
+Reviewed by Jonathan Bedard.
+
+*resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Draw empty line when invaild scales or dots state pass in
+
2019-10-14 Jonathan Bedard
Python 3: Add support in webkitpy.common.net.bugzilla
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (251113 => 251114)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-10-15 00:34:03 UTC (rev 251113)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-10-15 00:47:56 UTC (rev 251114)
@@ -373,7 +373,10 @@
context.moveTo(startX, radius);
context.lineTo(startX + renderWidth, radius);
});
-
+if (!scales || !dots || !scales.length || !dots.length) {
+colorBatchRender.batchRender(context);
+return;
+}
// Draw the dots
// First, Calculate the render range:
let startScalesIndex = Math.floor((scrollLeft + startX) / dotWidth);
@@ -732,6 +735,23 @@
const usedLineColor = computedStyle.getPropertyValue('--borderColorInlineElement');
const baseLineY = isTop ? canvasHeight - scaleBroadLineHeight : scaleBroadLineHeight;
const context = element.getContext("2d", { alpha: false });
+// Clear pervious batch render
+colorBatchRender.clear();
+colorBatchRender.lazyCreateColorSeqs(usedLineColor, (context) => {
+context.beginPath();
+}, (context, color) => {
+context.lineWidth = 1;
+context.strokeStyle = color;
+context.stroke();
+});
+colorBatchRender.addSeq(usedLineColor, (context) => {
+context.moveTo(0, baseLineY);
+context.lineTo(element.logicWidth, baseLineY);
+});
+if (!scales || !scales.length) {
+colorBatchRender.batchRender(context);
+return;
+}
let currentStartScaleIndex = Math.floor(scrollLeft / scaleWidth);
if (currentStartScaleIndex < 0)
currentStartScaleIndex = 0;
@@ -745,19 +765,7 @@
console.error(currentEndScaleKey);
}
let now = currentStartNode;
-// Clear pervious batch render
-colorBatchRender.clear();
-colorBatchRender.lazyCreateColorSeqs(usedLineColor, (context) => {
-context.beginPath();
-}, (context, color) => {
-context.lineWidth = 1;
-context.strokeStyle = color;
-context.stroke();
-});
-colorBatchRender.addSeq(usedLineColor, (context) => {
-context.moveTo(0, baseLineY);
-context.lineTo(element.logicWidth, baseLineY);
-});
+
_onScreenScales_ = [];
while (now != currentEndNode.next) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250760] trunk/Websites/perf.webkit.org
Title: [250760] trunk/Websites/perf.webkit.org
Revision 250760
Author zhifei_f...@apple.com
Date 2019-10-04 18:16:58 -0700 (Fri, 04 Oct 2019)
Log Message
[perf dashboard] Test fressness popover sometimes point to wrong place
https://bugs.webkit.org/show_bug.cgi?id=202606
Reviewed by Ryosuke Niwa.
* public/v3/pages/test-freshness-page.js: Use a invisable tooltip anchor to cacluate tooltip position. It also helps to get rid of caculation for determine the tooltip table position.
(TestFreshnessPage.prototype._renderTooltip):
(TestFreshnessPage.cssTemplate):
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (250759 => 250760)
--- trunk/Websites/perf.webkit.org/ChangeLog 2019-10-05 00:53:59 UTC (rev 250759)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2019-10-05 01:16:58 UTC (rev 250760)
@@ -1,5 +1,16 @@
2019-10-04 Zhifei Fang
+[perf dashboard] Test fressness popover sometimes point to wrong place
+https://bugs.webkit.org/show_bug.cgi?id=202606
+
+Reviewed by Ryosuke Niwa.
+
+* public/v3/pages/test-freshness-page.js: Use a invisable tooltip anchor to cacluate tooltip position. It also helps to get rid of caculation for determine the tooltip table position.
+(TestFreshnessPage.prototype._renderTooltip):
+(TestFreshnessPage.cssTemplate):
+
+2019-10-04 Zhifei Fang
+
[perf dashboard] Make test fressness head and indicator perfect centered
https://bugs.webkit.org/show_bug.cgi?id=202602
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js (250759 => 250760)
--- trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2019-10-05 00:53:59 UTC (rev 250759)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2019-10-05 01:16:58 UTC (rev 250760)
@@ -152,7 +152,7 @@
_renderTooltip(indicator, hoveringTooltip, buildSummary, build, commitSet)
{
if (!indicator || !buildSummary) {
-this.content('tooltip-table').style.display = hoveringTooltip ? null : 'none';
+this.content('tooltip-anchor').style.display = hoveringTooltip ? null : 'none';
return;
}
const element = ComponentBase.createElement;
@@ -159,17 +159,11 @@
const link = ComponentBase.createLink;
const rect = indicator.element().getBoundingClientRect();
-const tooltipTable = this.content('tooltip-table');
-tooltipTable.style.display = null;
+const tooltipAnchor = this.content('tooltip-anchor');
+tooltipAnchor.style.display = null;
+tooltipAnchor.style.top = rect.top + 'px';
+tooltipAnchor.style.left = rect.left + rect.width / 2 + 'px';
-const tooltipContainerComputedStyle = getComputedStyle(tooltipTable);
-const containerMarginTop = parseFloat(tooltipContainerComputedStyle.paddingTop);
-const containerMarginLeft = parseFloat(tooltipContainerComputedStyle.marginLeft);
-
-tooltipTable.style.position = 'absolute';
-tooltipTable.style.top = rect.top - (tooltipTable.offsetHeight + containerMarginTop) + 'px';
-tooltipTable.style.left = rect.left + rect.width / 2 - tooltipTable.offsetWidth / 2 + containerMarginLeft + 'px';
-
let tableContent = [element('tr', element('td', {colspan: 2}, buildSummary))];
if (commitSet) {
@@ -196,7 +190,7 @@
]));
}
-this.renderReplace(tooltipTable, tableContent);
+this.renderReplace(this.content("tooltip-table"), tableContent);
}
_renderTable(platforms, metrics)
@@ -248,7 +242,12 @@
static htmlTemplate()
{
-return ``;
+return `
+
+
+
+
+`;
}
static cssTemplate()
@@ -342,7 +341,13 @@
border-right: calc(1.6rem - 1px) solid #F9F9F9;
border-top: calc(1.6rem - 1px) solid transparent;
}
+#tooltip-anchor {
+width: 0;
+height: 0;
+position: absolute;
+}
#tooltip-table {
+position: absolute;
width: 22rem;
background-color: #34495E;
opacity: 0.9;
@@ -353,6 +358,8 @@
text-align: center;
display: inline-table;
color: white;
+bottom: 0;
+left: -11.3rem;
}
#tooltip-table td {
overflow: hidden;
@@ -364,8 +371,8 @@
position: absolute;
top: 100%;
left: 50%;
-margin-left: -1rem;
-border-width: 0.2rem;
+margin-left: -0.3rem;
+border-width: 0.3rem;
border-style: solid;
[webkit-changes] [250749] trunk/Websites/perf.webkit.org
Title: [250749] trunk/Websites/perf.webkit.org
Revision 250749
Author zhifei_f...@apple.com
Date 2019-10-04 15:07:15 -0700 (Fri, 04 Oct 2019)
Log Message
[perf dashboard] Make test fressness head and indicator perfect centered
https://bugs.webkit.org/show_bug.cgi?id=202602
Reviewed by Ryosuke Niwa.
* public/v3/components/freshness-indicator.js: make indicator margin auto, it will then horizontally centered in the container
(FreshnessIndicator.cssTemplate):
(FreshnessIndicator):
* public/v3/pages/test-freshness-page.js: make the table head transform based on the center left
(TestFreshnessPage.cssTemplate):
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/components/freshness-indicator.js
trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (250748 => 250749)
--- trunk/Websites/perf.webkit.org/ChangeLog 2019-10-04 22:00:27 UTC (rev 250748)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2019-10-04 22:07:15 UTC (rev 250749)
@@ -1,3 +1,16 @@
+2019-10-04 Zhifei Fang
+
+[perf dashboard] Make test fressness head and indicator perfect centered
+https://bugs.webkit.org/show_bug.cgi?id=202602
+
+Reviewed by Ryosuke Niwa.
+
+* public/v3/components/freshness-indicator.js: make indicator margin auto, it will then horizontally centered in the container
+(FreshnessIndicator.cssTemplate):
+(FreshnessIndicator):
+* public/v3/pages/test-freshness-page.js: make the table head transform based on the center left
+(TestFreshnessPage.cssTemplate):
+
2019-10-02 Dewei Zhu
Fix a bug that warning icon causes infinite rendering when it has warning message.
Modified: trunk/Websites/perf.webkit.org/public/v3/components/freshness-indicator.js (250748 => 250749)
--- trunk/Websites/perf.webkit.org/public/v3/components/freshness-indicator.js 2019-10-04 22:00:27 UTC (rev 250748)
+++ trunk/Websites/perf.webkit.org/public/v3/components/freshness-indicator.js 2019-10-04 22:07:15 UTC (rev 250749)
@@ -61,7 +61,7 @@
{
return `
div {
-margin-left: 0;
+margin: auto;
height: 1.8rem;
width: 1.8rem;
}
@@ -86,4 +86,4 @@
}
-ComponentBase.defineElement('freshness-indicator', FreshnessIndicator);
\ No newline at end of file
+ComponentBase.defineElement('freshness-indicator', FreshnessIndicator);
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js (250748 => 250749)
--- trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2019-10-04 22:00:27 UTC (rev 250748)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2019-10-04 22:07:15 UTC (rev 250749)
@@ -280,11 +280,14 @@
#test-health th.diagonal-head {
white-space: nowrap;
height: 16rem;
+width: 2.2rem;
border-bottom: 0rem;
+padding: 0;
}
#test-health th.diagonal-head > div {
-transform: translate(1rem, 7rem) rotate(315deg);
-width: 2rem;
+transform: translate(1.1rem, 7.5rem) rotate(315deg);
+transform-origin: center left;
+width: 2.2rem;
border: 0rem;
}
#test-health tbody {
@@ -312,7 +315,7 @@
background-color: #F9F9F9;
height: 1.6rem;
width: 1.6rem;
-margin: 0.1rem;
+margin: auto;
padding: 0;
position: relative;
overflow: hidden;
@@ -374,4 +377,4 @@
}
routeName() { return 'test-freshness'; }
-}
\ No newline at end of file
+}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [250523] trunk/Tools
Title: [250523] trunk/Tools
Revision 250523
Author zhifei_f...@apple.com
Date 2019-09-30 12:36:26 -0700 (Mon, 30 Sep 2019)
Log Message
[results.webkit.org Timeline] New axis style
https://bugs.webkit.org/show_bug.cgi?id=202292
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
Diff
Modified: trunk/Tools/ChangeLog (250522 => 250523)
--- trunk/Tools/ChangeLog 2019-09-30 19:10:57 UTC (rev 250522)
+++ trunk/Tools/ChangeLog 2019-09-30 19:36:26 UTC (rev 250523)
@@ -1,3 +1,12 @@
+2019-09-30 Zhifei Fang
+
+[results.webkit.org Timeline] New axis style
+https://bugs.webkit.org/show_bug.cgi?id=202292
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+
2019-09-30 Alex Christensen
Move DownloadMonitor test speed multiplier from WebProcessPool to WebsiteDataStoreConfiguration
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (250522 => 250523)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-09-30 19:10:57 UTC (rev 250522)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-09-30 19:36:26 UTC (rev 250523)
@@ -623,6 +623,8 @@
const scaleWidth = parseInt(computedStyle.getPropertyValue('--smallSize')) + parseInt(computedStyle.getPropertyValue('--tinySize'));
const scaleTagLineHeight = parseInt(computedStyle.getPropertyValue('--smallSize'));
const scaleTagLinePadding = 10;
+const scaleGroupTagLinePadding = 3;
+const scaleGroupMargin = fontSizeNumber / 2;
const scaleBroadLineHeight = parseInt(computedStyle.getPropertyValue('--tinySize')) / 2;
const maxinumTextHeight = scaleWidth * 4.5;
const canvasHeight = typeof option.height === "number" ? option.height : parseInt(computedStyle.getPropertyValue('--smallSize')) * 5;
@@ -637,6 +639,7 @@
const baseLineY = isTop ? y + canvasHeight - scaleBroadLineHeight : y + scaleBroadLineHeight;
const middlePointX = x + totalWidth / 2;
if (group > 1) {
+const groupBaselineY = isTop ? baseLineY - scaleBroadLineHeight : baseLineY + scaleBroadLineHeight;
colorBatchRender.lazyCreateColorSeqs(usedGroupColor, (context) => {
context.beginPath();
}, (context, color) => {
@@ -645,20 +648,20 @@
context.stroke();
});
colorBatchRender.addSeq(usedGroupColor, (context) => {
-context.moveTo(x + context.lineWidth, isTop ? canvasHeight : y);
-context.lineTo(x + context.lineWidth, baseLineY);
-context.moveTo(x, baseLineY);
-context.lineTo(x + totalWidth, baseLineY);
-context.moveTo(x + totalWidth, isTop ? canvasHeight : y);
-context.lineTo(x + totalWidth, baseLineY);
-context.moveTo(middlePointX, baseLineY);
+context.moveTo(x + scaleGroupMargin, groupBaselineY);
+context.lineTo(x + scaleGroupMargin, baseLineY);
+context.moveTo(x + scaleGroupMargin, groupBaselineY);
+context.lineTo(x + totalWidth - scaleGroupMargin, groupBaselineY);
+context.moveTo(x + totalWidth - scaleGroupMargin, groupBaselineY);
+context.lineTo(x + totalWidth - scaleGroupMargin, baseLineY);
+context.moveTo(middlePointX, groupBaselineY);
if (!isTop)
-context.lineTo(middlePointX, baseLineY + scaleTagLineHeight - scaleTagLinePadding);
+context.lineTo(middlePointX, groupBaselineY + scaleTagLineHeight - scaleTagLinePadding - scaleGroupTagLinePadding);
else
-context.lineTo(middlePointX, baseLineY - scaleTagLineHeight + scaleTagLinePadding);
+context.lineTo(middlePointX, groupBaselineY - scaleTagLineHeight + scaleTagLinePadding + scaleGroupTagLinePadding);
});
} else {
-colorBatchRender.lazyCreateColorSeqs(usedLineColor, (context) => {
+colorBatchRender.lazyCreateColorSeqs(usedGroupColor, (context) => {
context.beginPath();
}, (context, color) => {
context.lineWidth = 1;
@@ -665,7 +668,7 @@
context.strokeStyle = color;
context.stroke();
});
-colorBatchRender.addSeq(usedLineColor, (context) => {
+colorBatchRender.addSeq(usedGroupColor, (context) => {
context.moveTo(middlePointX, baseLineY);
if (!isTop)
context.lineTo(middlePointX, baseLineY + scaleTagLineHeight -
[webkit-changes] [250399] trunk/Tools
Title: [250399] trunk/Tools
Revision 250399
Author zhifei_f...@apple.com
Date 2019-09-26 14:51:35 -0700 (Thu, 26 Sep 2019)
Log Message
[results.webkit.org] Timeline support Image inner label
https://bugs.webkit.org/show_bug.cgi?id=202180
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/js/expectations.js:
* resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
(.lengend>.item .dot img): support img symbol for lengend and dot
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(Timeline.CanvasSeriesComponent): Support user pass a Image object or a image url as inner label
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/expectations.js
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
Added Paths
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/icons/
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/icons/clock.svg
Diff
Modified: trunk/Tools/ChangeLog (250398 => 250399)
--- trunk/Tools/ChangeLog 2019-09-26 21:37:38 UTC (rev 250398)
+++ trunk/Tools/ChangeLog 2019-09-26 21:51:35 UTC (rev 250399)
@@ -1,3 +1,16 @@
+2019-09-26 Zhifei Fang
+
+[results.webkit.org] Timeline support Image inner label
+https://bugs.webkit.org/show_bug.cgi?id=202180
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/js/expectations.js:
+* resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
+(.lengend>.item .dot img): support img symbol for lengend and dot
+* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+(Timeline.CanvasSeriesComponent): Support user pass a Image object or a image url as inner label
+
2019-09-26 Chris Dumez
Stop using testRunner.overridePreference() to turn on Page Cache
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/expectations.js (250398 => 250399)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/expectations.js 2019-09-26 21:37:38 UTC (rev 250398)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/expectations.js 2019-09-26 21:51:35 UTC (rev 250399)
@@ -93,10 +93,15 @@
timedout: 'TIMEOUT',
crashed: 'CRASH',
}
+const timeoutImage = new Image();
+timeoutImage.src = '';
+timeoutImage.toString = function () {
+return this.outerHTML;
+}
Expectations.symbolMap = {
success: '✓',
failed: '햷',
-timedout: '⎋',
+timedout: timeoutImage,
crashed: '!',
}
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css (250398 => 250399)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2019-09-26 21:37:38 UTC (rev 250398)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2019-09-26 21:51:35 UTC (rev 250399)
@@ -592,6 +592,7 @@
padding: 0;
margin: 0 8px;
background-color: var(--greyDark);
+ position: relative;
}
.dot.blink {
@@ -629,6 +630,16 @@
margin-top: 1px;
}
+.dot img, .dot.small img {
+width: var(--tinySize);
+height: var(--tinySize);
+position: absolute;
+top: calc((var(--smallSize) - var(--tinySize)) / 2);
+left: calc((var(--smallSize) - var(--tinySize)) / 2);
+padding: 0;
+margin: 0;
+}
+
.dot.medium {
font-size: var(--smallSize)
width: var(--mediumSize);
@@ -640,6 +651,16 @@
padding-top: 3px;
}
+.dot.medium img {
+width: var(--smallSize);
+height: var(--smallSize);
+position: absolute;
+top: calc((var(--mediumSize) - var(--smallSize)) / 2);
+left: calc((var(--mediumSize) - var(--smallSize)) / 2);
+padding: 0;
+margin: 0;
+}
+
.dot.large {
font-size: var(--mediumSize);
width: var(--largeSize);
@@ -651,6 +672,16 @@
padding-top: 4px;
}
+.dot.large img {
+width: var(--mediumSize);
+height: var(--mediumSize);
+position: absolute;
+top: calc((var(--largeSize) - var(--mediumSize)) / 2);
+left: calc((var(--largeSize) - var(--mediumSize)) / 2);
+padding: 0;
+margin: 0;
+}
+
.dot.success {
background-color: var(--greenLight);
}
@@ -2167,6 +2198,15 @@
user-select: none;
cursor: default;
}
+.lengend>.item .dot img {
+width: var(--tinySize);
+height: var(--tinySize);
+position: absolute;
+top: calc((var(--smallSize) - var(--tinySize)) / 2);
+left: calc((var(--smallSize) - var(--tinySize)) / 2);
+padding: 0;
+margin: 0;
+}
.timeline.lengend>.item .dot::before{
left: calc(0px - var(--tinySize));
width: var(--tinySize);
Added: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/icons/clock.svg (0 => 250399)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/icons/clock.svg (rev 0)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/icons/clock.svg 2019-09-26 21:51:35 UTC (rev 250399)
@@ -0,0
[webkit-changes] [250307] trunk/Tools
Title: [250307] trunk/Tools Revision 250307 Author zhifei_f...@apple.com Date 2019-09-24 10:48:20 -0700 (Tue, 24 Sep 2019) Log Message Add tests for Ref.js. https://bugs.webkit.org/show_bug.cgi?id=201778. Reviewed by Jonathan Bedard. * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: (applyStateDiff): null, 0, false are all valid state (Ref.prototype.setState): We should do nothing for undefined stateDiff * resultsdbpy/resultsdbpy/view/static/library/js/Test.js: Added. (AssertFailedError): (Expect): Perform assertions during unit tests. (Expect.prototype.isType): (Expect.prototype.equalToValue): (Expect.prototype.equalToHtmlWithoutRef): (Expect.prototype.notEqualToValue): (Expect.prototype.greaterThan): (Expect.prototype.greaterThanOrEqualTo): (Expect.prototype.lessThan): (Expect.prototype.lessThanOrEqualTo): (TestSuite): Common TestSuite class for user to extend. (TestSuite.prototype.expect): (TestSuite.prototype.sleep): Test will sleep for certain ms (TestSuite.prototype.waitForSignal): Wait until we receive a certain signal with timeout (TestSuite.prototype.waitForRefMounted): Wait until we receive ref object's onElementMount signal with timeout (TestSuite.prototype.waitForRefUnmounted): Wait until we receive ref object's onElementUnmount signal with timeout (TestSuite.prototype.waitForStateUpdated):Wait until we receive ref object's onStateUpdate signal with timeout (TestSuite.prototype.async.setup): Common interface for setup a test suite (TestSuite.prototype.async.clearUp): Common interface for clear up a test suite (getTestFucntionNames): Collect all the test method of a test instance. (TestResult): (TestResult.prototype.catchException): (async.getTestResult): Run the test and generate a TestResult object (TestController): (TestController.prototype.addResultHandler): Test controller will send notification of a test result to result handler (TestController.prototype.addSetupArgs): This gives some additional args for the common setup method for each test class, it is the best place to setup something like a root element, a fake data source, etc (TestController.prototype.collect): This method used for collect the test classes. (TestController.prototype.async.collectFile): It will import the file as a module dynamicly and collect all the test classes that module export (TestController.prototype.async.runTest): It will run a test method of a test class (TestController.prototype.async.run): It will run all test or a test class or a test method * resultsdbpy/resultsdbpy/view/static/library/js/components/TestComponents.js: components for test app. * resultsdbpy/resultsdbpy/view/static/library/js/test/RefTest.js: Ref.js test cases. * resultsdbpy/resultsdbpy/view/static/library/js/test/index.html: Test app entry. Modified Paths trunk/Tools/ChangeLog trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/Ref.js Added Paths trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/Test.js trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TestComponents.js trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/test/ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/test/RefTest.js trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/test/index.html Diff Modified: trunk/Tools/ChangeLog (250306 => 250307) --- trunk/Tools/ChangeLog 2019-09-24 17:25:05 UTC (rev 250306) +++ trunk/Tools/ChangeLog 2019-09-24 17:48:20 UTC (rev 250307) @@ -1,3 +1,49 @@ +2019-09-24 Zhifei Fang + +Add tests for Ref.js. +https://bugs.webkit.org/show_bug.cgi?id=201778. + +Reviewed by Jonathan Bedard. + +* resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: +(applyStateDiff): null, 0, false are all valid state +(Ref.prototype.setState): We should do nothing for undefined stateDiff +* resultsdbpy/resultsdbpy/view/static/library/js/Test.js: Added. +(AssertFailedError): +(Expect): Perform assertions during unit tests. +(Expect.prototype.isType): +(Expect.prototype.equalToValue): +(Expect.prototype.equalToHtmlWithoutRef): +(Expect.prototype.notEqualToValue): +(Expect.prototype.greaterThan): +(Expect.prototype.greaterThanOrEqualTo): +(Expect.prototype.lessThan): +(Expect.prototype.lessThanOrEqualTo): +(TestSuite): Common TestSuite class for user to extend. +(TestSuite.prototype.expect): +(TestSuite.prototype.sleep): Test will sleep for certain ms +(TestSuite.prototype.waitForSignal): Wait until we receive a certain signal with timeout +(TestSuite.prototype.waitForRefMounted): Wait until we receive ref object's onElementMount signal with timeout +(TestSuite.prototype.waitForRefUnmounted): Wait until we receive ref object's onElementUnmount signal with timeout +(TestSuite.prototype.waitForStateUpdated):Wait until we receive ref object's onStateUpdate signal with timeout +
[webkit-changes] [250071] trunk/Tools
Title: [250071] trunk/Tools
Revision 250071
Author zhifei_f...@apple.com
Date 2019-09-18 17:23:20 -0700 (Wed, 18 Sep 2019)
Log Message
[results.webkit.org] fix missing col classes
https://bugs.webkit.org/show_bug.cgi?id=201949
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
(@media screen and (min-width: 768px)):
(.row):
(.col-1):
(.col-2):
(.col-3):
(.col-4):
(.col-5):
(.col-6):
(.col-7):
(.col-8):
(.col-9):
(.col-10):
(.col-11):
(.col-12):
(@media screen and (min-width: 600px)):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css
Diff
Modified: trunk/Tools/ChangeLog (250070 => 250071)
--- trunk/Tools/ChangeLog 2019-09-19 00:07:48 UTC (rev 250070)
+++ trunk/Tools/ChangeLog 2019-09-19 00:23:20 UTC (rev 250071)
@@ -1,3 +1,27 @@
+2019-09-18 Zhifei Fang
+
+[results.webkit.org] fix missing col classes
+https://bugs.webkit.org/show_bug.cgi?id=201949
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
+(@media screen and (min-width: 768px)):
+(.row):
+(.col-1):
+(.col-2):
+(.col-3):
+(.col-4):
+(.col-5):
+(.col-6):
+(.col-7):
+(.col-8):
+(.col-9):
+(.col-10):
+(.col-11):
+(.col-12):
+(@media screen and (min-width: 600px)):
+
2019-09-18 Ryan Haddad
Update flakiness dashboard configuration for iOS 13 queues
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css (250070 => 250071)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2019-09-19 00:07:48 UTC (rev 250070)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2019-09-19 00:23:20 UTC (rev 250071)
@@ -330,12 +330,13 @@
display: flex;
flex-direction: column;
}
-
+/* size xs */
[class*="col-"] {
width: 100%;
padding: var(--colPaddingSize) 0;
}
+/* size s */
@media screen and (min-width: 600px) {
.row {
display: flex;
@@ -391,6 +392,62 @@
}
}
+/* size m */
+@media screen and (min-width: 768px) {
+ .row {
+display: flex;
+flex-direction: row;
+ }
+
+ .col-1 {
+width: 8.33%;
+ }
+
+ .col-2 {
+width: 16.66%;
+ }
+
+ .col-3 {
+width: 25%;
+ }
+
+ .col-4 {
+width: 33.33%;
+ }
+
+ .col-5 {
+width: 41.66%;
+ }
+
+ .col-6 {
+width: 50%;
+ }
+
+ .col-7 {
+width: 58.33%;
+ }
+
+ .col-8 {
+width: 66.66%;
+ }
+
+ .col-9 {
+width: 75%;
+ }
+
+ .col-10 {
+width: 83.33%;
+ }
+
+ .col-11 {
+width: 91.66%;
+ }
+
+ .col-12 {
+width: 100%;
+ }
+}
+
.hide-for-xs {
display: none;
}
@@ -2567,4 +2624,3 @@
display: none;
}
}
-
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [249358] trunk/Tools
Title: [249358] trunk/Tools
Revision 249358
Author zhifei_f...@apple.com
Date 2019-08-30 21:11:21 -0700 (Fri, 30 Aug 2019)
Log Message
[results.webkit.org Timeline] Add notify rerender API for timeline
https://bugs.webkit.org/show_bug.cgi?id=201363
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/js/timeline.js: Export notifyRerender API to timeline class
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(XScrollableCanvasProvider): Add an event stream to receive notification that it will need to render
(prototype.ExpandableSeriesComponent): Notify the rerender when expanded, because this may change the layout.
(prototype.Timeline.CanvasContainer):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js
trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
trunk/Tools/resultsdbpy/resultsdbpy/view/templates/search.html
trunk/Tools/resultsdbpy/resultsdbpy/view/templates/suite_results.html
Diff
Modified: trunk/Tools/ChangeLog (249357 => 249358)
--- trunk/Tools/ChangeLog 2019-08-31 04:03:54 UTC (rev 249357)
+++ trunk/Tools/ChangeLog 2019-08-31 04:11:21 UTC (rev 249358)
@@ -1,3 +1,16 @@
+2019-08-30 Zhifei Fang
+
+[results.webkit.org Timeline] Add notify rerender API for timeline
+https://bugs.webkit.org/show_bug.cgi?id=201363
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/js/timeline.js: Export notifyRerender API to timeline class
+* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+(XScrollableCanvasProvider): Add an event stream to receive notification that it will need to render
+(prototype.ExpandableSeriesComponent): Notify the rerender when expanded, because this may change the layout.
+(prototype.Timeline.CanvasContainer):
+
2019-08-30 Aakash Jain
[ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js (249357 => 249358)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js 2019-08-31 04:03:54 UTC (rev 249357)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js 2019-08-31 04:11:21 UTC (rev 249358)
@@ -36,7 +36,7 @@
setEnableRecursive(node, state);
}
-function Drawer(controls = []) {
+function Drawer(controls = [], onCollapseChange) {
const HIDDEN = false;
const VISIBLE = true;
let drawerState = VISIBLE;
@@ -62,6 +62,9 @@
if (node.classList.contains("list"))
setEnableRecursive(node, state);
}
+
+if (onCollapseChange)
+onCollapseChange();
},
onElementMount: (element) => {
let candidates = document.getElementsByClassName("main");
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js (249357 => 249358)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js 2019-08-31 04:03:54 UTC (rev 249357)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js 2019-08-31 04:11:21 UTC (rev 249358)
@@ -764,7 +764,7 @@
top = false;
});
-const composer = FP.composer((updateTimeline) => {
+const composer = FP.composer(FP.currying((updateTimeline, notifiyRerender) => {
self.timelineUpdate = (xAxises) => {
children.splice(0, 1);
if (self.repositories.length > 1)
@@ -780,7 +780,8 @@
});
updateTimeline(children);
};
-});
+self.notifiyRerender = notifiyRerender;
+}));
return Timeline.CanvasContainer(composer, ...children);
}
}
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (249357 => 249358)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-08-31 04:03:54 UTC (rev 249357)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-08-31 04:11:21 UTC (rev 249358)
@@ -118,19 +118,26 @@
presenterRef.setState({resize:true});
});
const resizeContainerWidth = width => {containerRef.setState({width: width})};
+const getScrollableBoundingClientRect = () => scrollRef.element.getBoundingClientRect();
const presenterRef = REF.createRef({
state: {scrollLeft: 0},
onElementMount: (element) => {
-element.style.width = `${element.parentElement.parentElement.offsetWidth}px`;
-resizeEventStream.add(element.offsetWidth);
+const scrollableWidth = getScrollableBoundingClientRect().width;
+element.style.width = `${scrollableWidth}px`;
+
[webkit-changes] [249161] trunk/Tools
Title: [249161] trunk/Tools Revision 249161 Author zhifei_f...@apple.com Date 2019-08-27 12:32:53 -0700 (Tue, 27 Aug 2019) Log Message [results.webkit.org Webkit.css] Center the legend symbols https://bugs.webkit.org/show_bug.cgi?id=201187 Reviewed by Jonathan Bedard. * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: (.lengend>.item .dot .text): center the dot symbol vertically Modified Paths trunk/Tools/ChangeLog trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css Diff Modified: trunk/Tools/ChangeLog (249160 => 249161) --- trunk/Tools/ChangeLog 2019-08-27 19:29:53 UTC (rev 249160) +++ trunk/Tools/ChangeLog 2019-08-27 19:32:53 UTC (rev 249161) @@ -1,3 +1,13 @@ +2019-08-27 Zhifei Fang + +[results.webkit.org Webkit.css] Center the legend symbols +https://bugs.webkit.org/show_bug.cgi?id=201187 + +Reviewed by Jonathan Bedard. + +* resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: +(.lengend>.item .dot .text): center the dot symbol vertically + 2019-08-27 Jonathan Bedard run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix) Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css (249160 => 249161) --- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2019-08-27 19:29:53 UTC (rev 249160) +++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2019-08-27 19:32:53 UTC (rev 249161) @@ -2150,6 +2150,9 @@ text-align: center; width: var(--smallSize); height: var(--smallSize); + line-height: var(--smallSize); + padding: 0; + margin: 0; display: inline-block; -webkit-touch-callout: none; -webkit-user-select: none; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [249124] trunk/Tools
Title: [249124] trunk/Tools
Revision 249124
Author zhifei_f...@apple.com
Date 2019-08-26 16:36:50 -0700 (Mon, 26 Aug 2019)
Log Message
[results.webkit.org Timline] Add symbols to the timeline dot
https://bugs.webkit.org/show_bug.cgi?id=201105
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/js/timeline.js:
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(Timeline.CanvasSeriesComponent): Modify the drawDot api to provide user ability to add symbol to the dots, it supports unicode symbol
* resultsdbpy/resultsdbpy/view/templates/base.html: Add the encoding UTF-8 for the page, so that we can add unicode symbol to the dots
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/index.html
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
trunk/Tools/resultsdbpy/resultsdbpy/view/templates/base.html
Diff
Modified: trunk/Tools/ChangeLog (249123 => 249124)
--- trunk/Tools/ChangeLog 2019-08-26 23:20:45 UTC (rev 249123)
+++ trunk/Tools/ChangeLog 2019-08-26 23:36:50 UTC (rev 249124)
@@ -1,3 +1,15 @@
+2019-08-26 Zhifei Fang
+
+[results.webkit.org Timline] Add symbols to the timeline dot
+https://bugs.webkit.org/show_bug.cgi?id=201105
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+(Timeline.CanvasSeriesComponent): Modify the drawDot api to provide user ability to add symbol to the dots, it supports unicode symbol
+* resultsdbpy/resultsdbpy/view/templates/base.html: Add the encoding UTF-8 for the page, so that we can add unicode symbol to the dots
+
2019-08-26 Yusuke Suzuki
Unreviewed, remove useMaximalFlushInsertionPhase use
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js (249123 => 249124)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js 2019-08-26 23:20:45 UTC (rev 249123)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js 2019-08-26 23:36:50 UTC (rev 249124)
@@ -43,6 +43,13 @@
PASS: 0x40,
};
+const TestResultsSymbolMap = {
+success: '✓',
+failed: '햷',
+timedout: '⎋',
+crashed: '!',
+}
+
class Expectations
{
static stringToStateId(string) {
@@ -543,6 +550,7 @@
let tag = null;
let color = colorMap.success;
+let symbol = TestResultsSymbolMap.success;
if (data.stats) {
tag = data.stats[`tests${willFilterExpected ? '_unexpected_' : '_'}failed`];
@@ -555,8 +563,10 @@
}
failureTypeOrder.forEach(type => {
-if (data.stats[`tests${willFilterExpected ? '_unexpected_' : '_'}${type}`] > 0)
+if (data.stats[`tests${willFilterExpected ? '_unexpected_' : '_'}${type}`] > 0) {
color = colorMap[type];
+symbol = TestResultsSymbolMap[type];
+}
});
} else {
let resultId = Expectations.stringToStateId(data.actual);
@@ -563,12 +573,14 @@
if (willFilterExpected)
resultId = Expectations.stringToStateId(Expectations.unexpectedResults(data.actual, data.expected));
failureTypeOrder.forEach(type => {
-if (Expectations.stringToStateId(failureTypeMapping[type]) >= resultId)
+if (Expectations.stringToStateId(failureTypeMapping[type]) >= resultId) {
color = colorMap[type];
+symbol = TestResultsSymbolMap[type];
+}
});
}
-return drawDot(context, x, y, false, tag ? tag : null, false, color);
+return drawDot(context, x, y, false, tag ? tag : null, symbol, false, color);
},
};
@@ -790,7 +802,7 @@
let result = `
-
+${TestResultsSymbolMap.success}
${LegendLabel(
updateLabelEvents,
plural ? 'No unexpected results' : 'Result expected',
@@ -798,7 +810,7 @@
)}
-
+${TestResultsSymbolMap.failed}
${LegendLabel(
updateLabelEvents,
plural ? 'Some tests unexpectedly failed' :
[webkit-changes] [249021] trunk/Tools
Title: [249021] trunk/Tools Revision 249021 Author zhifei_f...@apple.com Date 2019-08-22 11:50:01 -0700 (Thu, 22 Aug 2019) Log Message [results.webkit.org Webkit.css] Change input's disable style The disable input style will always show the label like it has a value https://bugs.webkit.org/show_bug.cgi?id=200998 Reviewed by Jonathan Bedard. * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already has a value *resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: * resultsdbpy/resultsdbpy/view/static/library/css/index.html: * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: (.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disabling a text input element even without a value, the style should match the style of a text input element with a value (.input>input[type="text"][required][disabled]~label, .input>input[type="number"][required][disabled]~label,): (@media (prefers-color-scheme: dark)): Modified Paths trunk/Tools/ChangeLog trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/index.html trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css Diff Modified: trunk/Tools/ChangeLog (249020 => 249021) --- trunk/Tools/ChangeLog 2019-08-22 18:18:04 UTC (rev 249020) +++ trunk/Tools/ChangeLog 2019-08-22 18:50:01 UTC (rev 249021) @@ -1,3 +1,19 @@ +2019-08-22 Zhifei Fang + +[results.webkit.org Webkit.css] Change input's disable style +The disable input style will always show the label like it has a value +https://bugs.webkit.org/show_bug.cgi?id=200998 + +Reviewed by Jonathan Bedard. + +* resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already has a value +*resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: +* resultsdbpy/resultsdbpy/view/static/library/css/index.html: +* resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: +(.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disabling a text input element even without a value, the style should match the style of a text input element with a value +(.input>input[type="text"][required][disabled]~label, .input>input[type="number"][required][disabled]~label,): +(@media (prefers-color-scheme: dark)): + 2019-08-17 Darin Adler Use makeString and multi-argument StringBuilder::append instead of less efficient multiple appends Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml (249020 => 249021) --- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml 2019-08-22 18:18:04 UTC (rev 249020) +++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml 2019-08-22 18:50:01 UTC (rev 249021) @@ -663,6 +663,10 @@ Disabled + +Disabled with existing value + + Invalid Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs (249020 => 249021) --- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs 2019-08-22 18:18:04 UTC (rev 249020) +++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs 2019-08-22 18:50:01 UTC (rev 249021) @@ -1,3 +1,4 @@ +#!/usr/bin/python # Copyright (C) 2019 Apple Inc. All rights reserved. # # Redistribution and use in source and binary forms, with or without @@ -20,7 +21,6 @@ # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -#!/usr/bin/python from argparse import ArgumentParser import jinja2 import yaml Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/index.html (249020 => 249021) --- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/index.html 2019-08-22 18:18:04 UTC (rev 249020) +++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/index.html 2019-08-22 18:50:01 UTC (rev 249021) @@ -1566,6 +1566,10 @@ Disabled + +Disabled with existing value + + Invalid @@ -1581,6 +1585,10 @@ Disabled + +Disabled with existing value + + Invalid Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css (249020 => 249021) --- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2019-08-22 18:18:04 UTC (rev 249020) +++
[webkit-changes] [248926] trunk/Tools
Title: [248926] trunk/Tools
Revision 248926
Author zhifei_f...@apple.com
Date 2019-08-20 17:26:52 -0700 (Tue, 20 Aug 2019)
Log Message
[results.webkit.org Webkit.css] Add right sidebar
https://bugs.webkit.org/show_bug.cgi?id=200946
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
(@media screen and (min-width: 600px) and (orientation: landscape)):
(.main.left):
(@media screen and (min-width: 768px) and (orientation: landscape)):
(.sidebar.right):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css
Diff
Modified: trunk/Tools/ChangeLog (248925 => 248926)
--- trunk/Tools/ChangeLog 2019-08-21 00:24:27 UTC (rev 248925)
+++ trunk/Tools/ChangeLog 2019-08-21 00:26:52 UTC (rev 248926)
@@ -1,3 +1,16 @@
+2019-08-20 Zhifei Fang
+
+[results.webkit.org Webkit.css] Add right sidebar
+https://bugs.webkit.org/show_bug.cgi?id=200946
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
+(@media screen and (min-width: 600px) and (orientation: landscape)):
+(.main.left):
+(@media screen and (min-width: 768px) and (orientation: landscape)):
+(.sidebar.right):
+
2019-08-20 Jonathan Bedard
results.webkit.org: Add ToolTips
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css (248925 => 248926)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2019-08-21 00:24:27 UTC (rev 248925)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css 2019-08-21 00:26:52 UTC (rev 248926)
@@ -962,6 +962,12 @@
margin-left: 299px;
width: calc(100% - 299px);
}
+
+ .main.left {
+margin-left: 0px;
+margin-right: 299px;
+ }
+
.main.under-topbar-with-actions {
margin-top: calc(12px * 2 + var(--largeSize) * 1.3);
}
@@ -981,6 +987,12 @@
margin-left: 310px;
width: calc(100% - 310px);
}
+
+ .main.left {
+margin-left: 0px;
+margin-right: 310px;
+ }
+
.main.under-topbar-with-actions {
margin-top: calc(12px * 2 + var(--largeSize) * 1.3);
}
@@ -989,6 +1001,7 @@
.sidebar.right {
border-right: 0px;
border-left: 1px;
+ right: 0;
}
.sidebar>.list {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [248859] trunk/Tools
Title: [248859] trunk/Tools
Revision 248859
Author zhifei_f...@apple.com
Date 2019-08-19 11:09:37 -0700 (Mon, 19 Aug 2019)
Log Message
[results.webkit.org Timeline] Disable back gesture
https://bugs.webkit.org/show_bug.cgi?id=200839
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
* resultsdbpy/resultsdbpy/view/templates/base.html:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js
trunk/Tools/resultsdbpy/resultsdbpy/view/templates/base.html
Diff
Modified: trunk/Tools/ChangeLog (248858 => 248859)
--- trunk/Tools/ChangeLog 2019-08-19 17:51:47 UTC (rev 248858)
+++ trunk/Tools/ChangeLog 2019-08-19 18:09:37 UTC (rev 248859)
@@ -1,3 +1,13 @@
+2019-08-19 Zhifei Fang
+
+[results.webkit.org Timeline] Disable back gesture
+https://bugs.webkit.org/show_bug.cgi?id=200839
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
+* resultsdbpy/resultsdbpy/view/templates/base.html:
+
2019-08-19 Jonathan Bedard
results-webkit.org: Add timeout to Redis locks
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js (248858 => 248859)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js 2019-08-19 17:51:47 UTC (rev 248858)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js 2019-08-19 18:09:37 UTC (rev 248859)
@@ -82,4 +82,16 @@
});
}
-export {timeDifference, isDarkMode, Cookie, createInsertionObservers};
+function disableBackGesture() {
+window.addEventListener('mousewheel', e => {
+const target = e.target;
+for (let parent = target.parentElement; parent; parent = parent.parentElement ) {
+if (parent.scrollLeft !== 0 && e.deltaX < 0)
+return;
+}
+if (e.deltaX < 0)
+e.preventDefault();
+});
+}
+
+export {timeDifference, isDarkMode, Cookie, createInsertionObservers, disableBackGesture};
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/templates/base.html (248858 => 248859)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/templates/base.html 2019-08-19 17:51:47 UTC (rev 248858)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/templates/base.html 2019-08-19 18:09:37 UTC (rev 248859)
@@ -50,5 +50,9 @@
{% block content %}{% endblock %}
+
+import {disableBackGesture} from '/library/js/Utils.js';
+disableBackGesture();
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [248649] trunk/Tools
Title: [248649] trunk/Tools
Revision 248649
Author zhifei_f...@apple.com
Date 2019-08-13 18:03:08 -0700 (Tue, 13 Aug 2019)
Log Message
[results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
https://bugs.webkit.org/show_bug.cgi?id=200456
Reviewed by Jonathan Bedard.
This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
* resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(pointPolygonCollisionDetect): Detact
(pointRightRayLineSegmentCollisionDetect):
(ColorBatchRender):
(ColorBatchRender.prototype.lazyCreateColorSeqs):
(ColorBatchRender.prototype.addSeq):
(ColorBatchRender.prototype.batchRender):
(ColorBatchRender.prototype.clear):
(xScrollStreamRenderFactory):
(Timeline.CanvasSeriesComponent):
(offscreenCachedRenderFactory): Deleted.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
Diff
Modified: trunk/Tools/ChangeLog (248648 => 248649)
--- trunk/Tools/ChangeLog 2019-08-14 00:31:49 UTC (rev 248648)
+++ trunk/Tools/ChangeLog 2019-08-14 01:03:08 UTC (rev 248649)
@@ -1,3 +1,27 @@
+2019-08-13 Zhifei Fang
+
+[results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
+https://bugs.webkit.org/show_bug.cgi?id=200456
+
+Reviewed by Jonathan Bedard.
+
+This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
+
+This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
+
+* resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
+* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+(pointPolygonCollisionDetect): Detact
+(pointRightRayLineSegmentCollisionDetect):
+(ColorBatchRender):
+(ColorBatchRender.prototype.lazyCreateColorSeqs):
+(ColorBatchRender.prototype.addSeq):
+(ColorBatchRender.prototype.batchRender):
+(ColorBatchRender.prototype.clear):
+(xScrollStreamRenderFactory):
+(Timeline.CanvasSeriesComponent):
+(offscreenCachedRenderFactory): Deleted.
+
2019-08-13 John Wilander
Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js (248648 => 248649)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js 2019-08-14 00:31:49 UTC (rev 248648)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js 2019-08-14 01:03:08 UTC (rev 248649)
@@ -70,7 +70,7 @@
function createInsertionObservers(element, callback=()=>{}, startThreshold=0.0, endTreshold=1.0, step=0.1, option={}) {
const useOption = {};
useOption.root = option.root instanceof HTMLElement ? option.root : null;
-useOption.rootMargin = option.rootMargin ? option.rootMargin : "0";
+useOption.rootMargin = option.rootMargin ? option.rootMargin : "0%";
const thresholdArray = [];
for (let i = startThreshold; i <= endTreshold; i+= step) {
thresholdArray.push(i);
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (248648 => 248649)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-08-14 00:31:49 UTC (rev 248648)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-08-14 01:03:08 UTC (rev 248649)
@@ -38,6 +38,39 @@
return diffX <= rect.width && diffY <= rect.height && diffX >= 0 && diffY >= 0;
}
+function pointPolygonCollisionDetect(point, polygon) {
+let res = false;
+for (let i = 0, j = 1; i < polygon.length; i++, j = i + 1) {
+if (j === polygon.length )
+j = 0;
+if (pointRightRayLineSegmentCollisionDetect(point, polygon[i], polygon[j]))
+res = !res;
+}
+return res;
+}
+
+/*
+* Detact if point right ray have a collision with a line segment
+**
+* /
+**---> /
+* /
+**
+*/
+function pointRightRayLineSegmentCollisionDetect(point, lineStart, lineEnd) {
+const maxX = Math.max(lineStart.x, lineEnd.x);
+const minX = Math.min(lineStart.x, lineEnd.x);
+const maxY = Math.max(lineStart.y, lineEnd.y);
+const minY = Math.min(lineStart.y, lineEnd.y);
+if ((point.x <= maxX
[webkit-changes] [248636] trunk/Tools
Title: [248636] trunk/Tools
Revision 248636
Author zhifei_f...@apple.com
Date 2019-08-13 15:13:36 -0700 (Tue, 13 Aug 2019)
Log Message
Update my status in contributors.json to committer.
Reviewed by Unreviewed
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (248635 => 248636)
--- trunk/Tools/ChangeLog 2019-08-13 22:12:19 UTC (rev 248635)
+++ trunk/Tools/ChangeLog 2019-08-13 22:13:36 UTC (rev 248636)
@@ -1,3 +1,11 @@
+2019-08-13 Zhifei Fang
+
+Update my status in contributors.json to committer.
+
+Reviewed by Unreviewed
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2019-08-12 Jiewen Tan
Adds WebAuthn and AppSSO into watchlist
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (248635 => 248636)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2019-08-13 22:12:19 UTC (rev 248635)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2019-08-13 22:13:36 UTC (rev 248636)
@@ -5754,6 +5754,16 @@
"zhenyao"
]
},
+ "Zhifei Fang" : {
+ "emails" : [
+ "zhifei_f...@apple.com"
+ ],
+ "nicks" : [
+ "zhifei_fang",
+ "z.f"
+ ],
+ "status" : "committer"
+ },
"Zoltan Arvai" : {
"emails" : [
"zar...@inf.u-szeged.hu"
@@ -5808,4 +5818,4 @@
],
"status" : "reviewer"
}
-}
\ No newline at end of file
+}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
