Title: [100448] trunk/Source/WebKit/qt
Revision
100448
Author
commit-qu...@webkit.org
Date
2011-11-16 07:12:30 -0800 (Wed, 16 Nov 2011)

Log Message

[Qt] FrameLoaderClientQt::canShowMIMEType should always return true
https://bugs.webkit.org/show_bug.cgi?id=72169

Patch by Jesus Sanchez-Palencia <jesus.palen...@openbossa.org> on 2011-11-16
Reviewed by Simon Hausmann.

Currently FrameLoaderClientQt::canShowMIMEType is called after
dispatchDecidePolicyForResponse. If decidePolicyForResponse returns
PolicyUse and canShowMIMEType returns false, then we have a bug.
Therefore, FrameLoaderClientQt::canShowMIMEType now will always
return true, following the implemenation of WebKit2.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::canShowMIMEType):

Modified Paths

Diff

Modified: trunk/Source/WebKit/qt/ChangeLog (100447 => 100448)


--- trunk/Source/WebKit/qt/ChangeLog	2011-11-16 15:04:58 UTC (rev 100447)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-11-16 15:12:30 UTC (rev 100448)
@@ -1,3 +1,19 @@
+2011-11-16  Jesus Sanchez-Palencia  <jesus.palen...@openbossa.org>
+
+        [Qt] FrameLoaderClientQt::canShowMIMEType should always return true
+        https://bugs.webkit.org/show_bug.cgi?id=72169
+
+        Reviewed by Simon Hausmann.
+
+        Currently FrameLoaderClientQt::canShowMIMEType is called after
+        dispatchDecidePolicyForResponse. If decidePolicyForResponse returns
+        PolicyUse and canShowMIMEType returns false, then we have a bug.
+        Therefore, FrameLoaderClientQt::canShowMIMEType now will always
+        return true, following the implemenation of WebKit2.
+
+        * WebCoreSupport/FrameLoaderClientQt.cpp:
+        (WebCore::FrameLoaderClientQt::canShowMIMEType):
+
 2011-11-15  Huang Dongsung  <luxte...@company100.net>
 
         [TexMap][Qt] Start PageClientQ[Graphics]Widget::syncTimer only when the syncTimer

Modified: trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp (100447 => 100448)


--- trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp	2011-11-16 15:04:58 UTC (rev 100447)
+++ trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp	2011-11-16 15:12:30 UTC (rev 100448)
@@ -650,25 +650,10 @@
     notImplemented();
     return false;
 }
-    
+
 bool FrameLoaderClientQt::canShowMIMEType(const String& MIMEType) const
 {
-    String type = MIMEType;
-    type.makeLower();
-    if (MIMETypeRegistry::isSupportedImageMIMEType(type))
-        return true;
-
-    if (MIMETypeRegistry::isSupportedNonImageMIMEType(type))
-        return true;
-
-    if (MIMETypeRegistry::isSupportedMediaMIMEType(type))
-        return true;
-
-    if (m_frame && m_frame->settings()  && m_frame->settings()->arePluginsEnabled()
-        && PluginDatabase::installedPlugins()->isMIMETypeRegistered(type))
-        return true;
-
-    return false;
+    return true;
 }
 
 bool FrameLoaderClientQt::representationExistsForURLScheme(const String&) const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to