Title: [100983] trunk/Source/WebKit2
Revision
100983
Author
commit-qu...@webkit.org
Date
2011-11-22 01:32:08 -0800 (Tue, 22 Nov 2011)

Log Message

[WK2] Modify EFL port's WebEventFactory to use EflKeyboardUtilities's
keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName().
https://bugs.webkit.org/show_bug.cgi?id=72850

Patch by Eunmi Lee <eunmi15....@samsung.com> on 2011-11-22
Reviewed by Anders Carlsson.

The EflKeyboardUtilities has been added, so we can use keyIdentifierForEvasKeyName() and
windowsKeyCodeForEvasKeyName() for EFL port's WebEventFactory.

* Shared/efl/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebKeyboardEvent):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (100982 => 100983)


--- trunk/Source/WebKit2/ChangeLog	2011-11-22 09:19:17 UTC (rev 100982)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-22 09:32:08 UTC (rev 100983)
@@ -1,3 +1,17 @@
+2011-11-22  Eunmi Lee  <eunmi15....@samsung.com>
+
+        [WK2] Modify EFL port's WebEventFactory to use EflKeyboardUtilities's
+        keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName().
+        https://bugs.webkit.org/show_bug.cgi?id=72850
+
+        Reviewed by Anders Carlsson.
+
+        The EflKeyboardUtilities has been added, so we can use keyIdentifierForEvasKeyName() and
+        windowsKeyCodeForEvasKeyName() for EFL port's WebEventFactory.
+
+        * Shared/efl/WebEventFactory.cpp:
+        (WebKit::WebEventFactory::createWebKeyboardEvent):
+
 2011-11-21  Alexis Menard  <alexis.men...@openbossa.org>
 
         [Qt][WK2] REGRESSION(100483): It made 2 API tests fail

Modified: trunk/Source/WebKit2/Shared/efl/WebEventFactory.cpp (100982 => 100983)


--- trunk/Source/WebKit2/Shared/efl/WebEventFactory.cpp	2011-11-22 09:19:17 UTC (rev 100982)
+++ trunk/Source/WebKit2/Shared/efl/WebEventFactory.cpp	2011-11-22 09:32:08 UTC (rev 100983)
@@ -26,8 +26,7 @@
 #include "config.h"
 #include "WebEventFactory.h"
 
-#include <WebCore/NotImplemented.h>
-#include <WebCore/PlatformKeyboardEvent.h>
+#include "EflKeyboardUtilities.h"
 #include <WebCore/Scrollbar.h>
 
 using namespace WebCore;
@@ -163,8 +162,8 @@
     return WebKeyboardEvent(WebEvent::KeyDown,
                             String::fromUTF8(event->string),
                             String::fromUTF8(event->string),
-                            PlatformKeyboardEvent::keyIdentifierForEvasKeyName(keyName),
-                            PlatformKeyboardEvent::windowsKeyCodeForEvasKeyName(keyName),
+                            keyIdentifierForEvasKeyName(keyName),
+                            windowsKeyCodeForEvasKeyName(keyName),
                             0 /* FIXME: nativeVirtualKeyCode */,
                             0 /* macCharCode */,
                             false /* FIXME: isAutoRepeat */,
@@ -180,8 +179,8 @@
     return WebKeyboardEvent(WebEvent::KeyUp,
                             String::fromUTF8(event->string),
                             String::fromUTF8(event->string),
-                            PlatformKeyboardEvent::keyIdentifierForEvasKeyName(keyName),
-                            PlatformKeyboardEvent::windowsKeyCodeForEvasKeyName(keyName),
+                            keyIdentifierForEvasKeyName(keyName),
+                            windowsKeyCodeForEvasKeyName(keyName),
                             0 /* FIXME: nativeVirtualKeyCode */,
                             0 /* macCharCode */,
                             false /* FIXME: isAutoRepeat */,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to