Title: [101365] trunk/Source/WebCore
- Revision
- 101365
- Author
- hausm...@webkit.org
- Date
- 2011-11-29 06:36:39 -0800 (Tue, 29 Nov 2011)
Log Message
[Qt][V8] Add missing ExceptionCode.h include for SVG bindings
https://bugs.webkit.org/show_bug.cgi?id=73314
Reviewed by Kenneth Rohde Christiansen.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter): Similarly to other places where we use DOM
exceptions, make sure we include ExceptionCode.h here. It appears to be
an implicit inclusion in the Chromium build, but it should be explicit
like in the rest of the bindings.
(GenerateFunctionCallback): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (101364 => 101365)
--- trunk/Source/WebCore/ChangeLog 2011-11-29 13:39:15 UTC (rev 101364)
+++ trunk/Source/WebCore/ChangeLog 2011-11-29 14:36:39 UTC (rev 101365)
@@ -1,3 +1,17 @@
+2011-11-29 Simon Hausmann <simon.hausm...@nokia.com>
+
+ [Qt][V8] Add missing ExceptionCode.h include for SVG bindings
+ https://bugs.webkit.org/show_bug.cgi?id=73314
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateNormalAttrSetter): Similarly to other places where we use DOM
+ exceptions, make sure we include ExceptionCode.h here. It appears to be
+ an implicit inclusion in the Chromium build, but it should be explicit
+ like in the rest of the bindings.
+ (GenerateFunctionCallback): Ditto.
+
2011-11-29 Andrey Kosyakov <ca...@chromium.org>
Web Inspector: remove usage of innerHTML from inspector front-end
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (101364 => 101365)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-29 13:39:15 UTC (rev 101364)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-29 14:36:39 UTC (rev 101365)
@@ -1021,6 +1021,7 @@
$svgNativeType* imp = V8${implClassName}::toNative(info.Holder());
END
} else {
+ AddToImplIncludes("ExceptionCode.h");
push(@implContentDecls, " $svgNativeType* wrapper = V8${implClassName}::toNative(info.Holder());\n");
push(@implContentDecls, " if (wrapper->role() == AnimValRole) {\n");
push(@implContentDecls, " V8Proxy::setDOMException(NO_MODIFICATION_ALLOWED_ERR);\n");
@@ -1324,6 +1325,7 @@
if ($implClassName =~ /List$/) {
push(@implContentDecls, " $nativeClassName imp = V8${implClassName}::toNative(args.Holder());\n");
} else {
+ AddToImplIncludes("ExceptionCode.h");
push(@implContentDecls, " $nativeClassName wrapper = V8${implClassName}::toNative(args.Holder());\n");
push(@implContentDecls, " if (wrapper->role() == AnimValRole) {\n");
push(@implContentDecls, " V8Proxy::setDOMException(NO_MODIFICATION_ALLOWED_ERR);\n");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
