Title: [107115] trunk/Source/WebKit/chromium
- Revision
- 107115
- Author
- commit-qu...@webkit.org
- Date
- 2012-02-08 12:16:21 -0800 (Wed, 08 Feb 2012)
Log Message
[Chromium] Don't add selection from password fields to context menu.
https://bugs.webkit.org/show_bug.cgi?id=77733
Patch by Bernhard Bauer <bau...@google.com> on 2012-02-08
Reviewed by Adam Barth.
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (107114 => 107115)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-02-08 20:11:28 UTC (rev 107114)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-02-08 20:16:21 UTC (rev 107115)
@@ -1,3 +1,13 @@
+2012-02-08 Bernhard Bauer <bau...@google.com>
+
+ [Chromium] Don't add selection from password fields to context menu.
+ https://bugs.webkit.org/show_bug.cgi?id=77733
+
+ Reviewed by Adam Barth.
+
+ * src/ContextMenuClientImpl.cpp:
+ (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+
2012-02-08 Nico Weber <nicolaswe...@gmx.de>
[chromium] Let -Wglobal-constructors hack in shared build metastasize to mac
Modified: trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp (107114 => 107115)
--- trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp 2012-02-08 20:11:28 UTC (rev 107114)
+++ trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp 2012-02-08 20:16:21 UTC (rev 107115)
@@ -259,8 +259,10 @@
data.frameHistoryItem = WebHistoryItem(historyItem);
}
- if (r.isSelected())
- data.selectedText = selectedFrame->editor()->selectedText().stripWhiteSpace();
+ if (r.isSelected()) {
+ if (!r.innerNonSharedNode()->hasTagName(HTMLNames::inputTag) || !static_cast<HTMLInputElement*>(r.innerNonSharedNode())->isPasswordField())
+ data.selectedText = selectedFrame->editor()->selectedText().stripWhiteSpace();
+ }
if (r.isContentEditable()) {
data.isEditable = true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
