Title: [107121] trunk/Source/WebCore
- Revision
- 107121
- Author
- jam...@google.com
- Date
- 2012-02-08 12:39:37 -0800 (Wed, 08 Feb 2012)
Log Message
Make WebGL context current early to check validity
https://bugs.webkit.org/show_bug.cgi?id=78141
Patch by Antoine Labour <pi...@chromium.org> on 2012-02-08
Reviewed by James Robinson.
Covered by existing tests
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (107120 => 107121)
--- trunk/Source/WebCore/ChangeLog 2012-02-08 20:35:06 UTC (rev 107120)
+++ trunk/Source/WebCore/ChangeLog 2012-02-08 20:39:37 UTC (rev 107121)
@@ -1,3 +1,16 @@
+2012-02-08 Antoine Labour <pi...@chromium.org>
+
+ Make WebGL context current early to check validity
+ https://bugs.webkit.org/show_bug.cgi?id=78141
+
+ Reviewed by James Robinson.
+
+ Covered by existing tests
+
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore):
+ (WebCore::WebGLRenderingContext::create):
+
2012-02-08 Jonathan Backer <bac...@chromium.org>
[chromium] Disable root layer clears on release builds.
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (107120 => 107121)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2012-02-08 20:35:06 UTC (rev 107120)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2012-02-08 20:39:37 UTC (rev 107121)
@@ -405,7 +405,7 @@
RefPtr<GraphicsContext3D> context(GraphicsContext3D::create(attributes, hostWindow));
- if (!context) {
+ if (!context || !context->makeContextCurrent()) {
canvas->dispatchEvent(WebGLContextEvent::create(eventNames().webglcontextcreationerrorEvent, false, true, "Could not create a WebGL context."));
return nullptr;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
