Title: [108966] trunk/Source/WebCore
- Revision
- 108966
- Author
- pfeld...@chromium.org
- Date
- 2012-02-27 00:51:14 -0800 (Mon, 27 Feb 2012)
Log Message
Web Inspector: Close TabbedPanes on middle click of tab handle
https://bugs.webkit.org/show_bug.cgi?id=79518
Patch by Dan Beam <db...@chromium.org> on 2012-02-27
Reviewed by Pavel Feldman.
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (108965 => 108966)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 08:42:23 UTC (rev 108965)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 08:51:14 UTC (rev 108966)
@@ -1,3 +1,14 @@
+2012-02-27 Dan Beam <db...@chromium.org>
+
+ Web Inspector: Close TabbedPanes on middle click of tab handle
+ https://bugs.webkit.org/show_bug.cgi?id=79518
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/TabbedPane.js:
+ (WebInspector.TabbedPaneTab.prototype._createTabElement):
+ (WebInspector.TabbedPaneTab.prototype._tabClicked):
+
2012-02-26 Yury Semikhatsky <yu...@chromium.org>
Web Inspector: crash in fake workers
Modified: trunk/Source/WebCore/inspector/front-end/TabbedPane.js (108965 => 108966)
--- trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2012-02-27 08:42:23 UTC (rev 108965)
+++ trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2012-02-27 08:51:14 UTC (rev 108966)
@@ -596,9 +596,7 @@
tabElement.addStyleClass("measuring");
else {
this._tabElement = tabElement;
- tabElement.addEventListener("click", this._tabSelected.bind(this), false);
- if (this._closeable)
- closeButtonSpan.addEventListener("click", this._tabClosed.bind(this), false);
+ tabElement.addEventListener("click", this._tabClicked.bind(this), false);
}
return tabElement;
@@ -612,13 +610,14 @@
this._measureElement.removeChild(measuringTabElement);
},
- _tabSelected: function()
+ /**
+ * @param {Event} event
+ */
+ _tabClicked: function(event)
{
- this._tabbedPane.selectTab(this.id, true);
- },
-
- _tabClosed: function()
- {
- this._tabbedPane.closeTab(this.id, true);
+ if (this._closeable && (event.button === 1 || event.target.hasStyleClass("tabbed-pane-header-tab-close-button")))
+ this._tabbedPane.closeTab(this.id, true);
+ else
+ this._tabbedPane.selectTab(this.id, true);
}
-}
\ No newline at end of file
+}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
