Title: [111687] trunk/Source
- Revision
- 111687
- Author
- noam.rosent...@nokia.com
- Date
- 2012-03-22 07:07:23 -0700 (Thu, 22 Mar 2012)
Log Message
[Qt][WK2] The background appears to have one extra pixel from the contents
https://bugs.webkit.org/show_bug.cgi?id=81830
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
TextureMapperGL applied a 1-offset that was covering for another bug,
which was already fixed.
No new tests, this would be tested once we test GL rendering results.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::scissorClip):
Source/WebKit2:
The clip-polygon from the scenegraph uses floats, not integers.
This could cause 1-offset clipping problems in some cases.
* UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::clipRect):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (111686 => 111687)
--- trunk/Source/WebCore/ChangeLog 2012-03-22 14:03:06 UTC (rev 111686)
+++ trunk/Source/WebCore/ChangeLog 2012-03-22 14:07:23 UTC (rev 111687)
@@ -1,3 +1,18 @@
+2012-03-22 No'am Rosenthal <noam.rosent...@nokia.com>
+
+ [Qt][WK2] The background appears to have one extra pixel from the contents
+ https://bugs.webkit.org/show_bug.cgi?id=81830
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ TextureMapperGL applied a 1-offset that was covering for another bug,
+ which was already fixed.
+
+ No new tests, this would be tested once we test GL rendering results.
+
+ * platform/graphics/texmap/TextureMapperGL.cpp:
+ (WebCore::TextureMapperGLData::SharedGLData::scissorClip):
+
2012-03-22 W. James MacLean <wjmacl...@chromium.org>
Rename touchpad fling curve, add curve parameters to constructor.
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (111686 => 111687)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2012-03-22 14:03:06 UTC (rev 111686)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2012-03-22 14:07:23 UTC (rev 111687)
@@ -160,7 +160,7 @@
GLint viewport[4];
GL_CMD(glGetIntegerv(GL_VIEWPORT, viewport))
- GL_CMD(glScissor(rect.x(), viewport[3] - rect.maxY() + 1, rect.width() - 1, rect.height() - 1))
+ GL_CMD(glScissor(rect.x(), viewport[3] - rect.maxY(), rect.width(), rect.height()))
}
void applyCurrentClip()
Modified: trunk/Source/WebKit2/ChangeLog (111686 => 111687)
--- trunk/Source/WebKit2/ChangeLog 2012-03-22 14:03:06 UTC (rev 111686)
+++ trunk/Source/WebKit2/ChangeLog 2012-03-22 14:07:23 UTC (rev 111687)
@@ -1,3 +1,16 @@
+2012-03-22 No'am Rosenthal <noam.rosent...@nokia.com>
+
+ [Qt][WK2] The background appears to have one extra pixel from the contents
+ https://bugs.webkit.org/show_bug.cgi?id=81830
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ The clip-polygon from the scenegraph uses floats, not integers.
+ This could cause 1-offset clipping problems in some cases.
+
+ * UIProcess/qt/QtWebPageSGNode.cpp:
+ (WebKit::ContentsSGNode::clipRect):
+
2012-03-21 Alexander Færøy <alexander.fae...@nokia.com>
[Qt][WK2] Add QML API for handling database quotas
Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp (111686 => 111687)
--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp 2012-03-22 14:03:06 UTC (rev 111686)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp 2012-03-22 14:07:23 UTC (rev 111687)
@@ -81,7 +81,7 @@
QPolygonF polygon;
for (int i = 0; i < geometry->vertexCount(); i++)
- polygon.append(clipMatrix.map(QPoint(geometryPoints[i].x, geometryPoints[i].y)));
+ polygon.append(clipMatrix.map(QPointF(geometryPoints[i].x, geometryPoints[i].y)));
currentClip = polygon.boundingRect();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes