Title: [111703] trunk/Source/WebKit/efl
Revision
111703
Author
commit-qu...@webkit.org
Date
2012-03-22 08:17:57 -0700 (Thu, 22 Mar 2012)

Log Message

[EFL] Change returned view mode in case of NULL of ewkView.
https://bugs.webkit.org/show_bug.cgi?id=81636

Patch by Krzysztof Czech <k.cz...@samsung.com> on 2012-03-22
Reviewed by Eric Seidel.

Function ewk_view_mode_get returns wrong view mode in case of NULL of ewkView.

* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_mode_get):

Modified Paths

Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (111702 => 111703)


--- trunk/Source/WebKit/efl/ChangeLog	2012-03-22 15:15:52 UTC (rev 111702)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-03-22 15:17:57 UTC (rev 111703)
@@ -1,3 +1,16 @@
+2012-03-22  Krzysztof Czech  <k.cz...@samsung.com>
+
+        [EFL] Change returned view mode in case of NULL of ewkView.
+        https://bugs.webkit.org/show_bug.cgi?id=81636
+
+        Reviewed by Eric Seidel.
+
+        Function ewk_view_mode_get returns wrong view mode in case of NULL of ewkView.
+
+        * ewk/ewk_view.cpp:
+        (_Ewk_View_Private_Data):
+        (ewk_view_mode_get):
+
 2012-03-22  Hyowon Kim  <hw1008....@samsung.com>
 
         [EFL] Add PageClientEfl to WebCoreSupport.

Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (111702 => 111703)


--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2012-03-22 15:15:52 UTC (rev 111702)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2012-03-22 15:17:57 UTC (rev 111703)
@@ -3793,8 +3793,8 @@
 
 Ewk_View_Mode ewk_view_mode_get(const Evas_Object* ewkView)
 {
-    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EWK_VIEW_MODE_WINDOWED);
-    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EWK_VIEW_MODE_WINDOWED);
+    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EWK_VIEW_MODE_INVALID);
+    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EWK_VIEW_MODE_INVALID);
 
     return static_cast<Ewk_View_Mode>(priv->page->viewMode());
 }

Modified: trunk/Source/WebKit/efl/ewk/ewk_view.h (111702 => 111703)


--- trunk/Source/WebKit/efl/ewk/ewk_view.h	2012-03-22 15:15:52 UTC (rev 111702)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.h	2012-03-22 15:17:57 UTC (rev 111703)
@@ -2239,7 +2239,8 @@
  *
  * @param o view object to get the view mode
  *
- * @return enum value of @a Ewk_View_Mode that indicates current view mode
+ * @return enum value of @a Ewk_View_Mode that indicates current view mode on success or
+ *         EWK_VIEW_MODE_INVALID otherwise
  *
  * @see ewk_view_mode_set()
  */
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to