Title: [111753] trunk
- Revision
- 111753
- Author
- commit-qu...@webkit.org
- Date
- 2012-03-22 13:43:12 -0700 (Thu, 22 Mar 2012)
Log Message
[EFL] Enable view mode media feature layout tests
https://bugs.webkit.org/show_bug.cgi?id=81205
Tools:
Adding missing implementation setViewModeMediaFeature to EFL's
LayoutTestController so that we can unskip view mode
media feature layout tests.
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setViewModeMediaFeature): Implemented.
LayoutTests:
Unskip tests connected with setViewModeMediaFeature.
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (111752 => 111753)
--- trunk/LayoutTests/ChangeLog 2012-03-22 20:42:38 UTC (rev 111752)
+++ trunk/LayoutTests/ChangeLog 2012-03-22 20:43:12 UTC (rev 111753)
@@ -1,3 +1,14 @@
+2012-03-22 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
+ [EFL] Enable view mode media feature layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=81205
+
+ Unskip tests connected with setViewModeMediaFeature.
+
+ Reviewed by Antonio Gomes.
+
+ * platform/efl/Skipped:
+
2012-03-22 Dan Bernstein <m...@apple.com>
Added all tests that failed on the Lion WebKit2 Debug bot in r111739 to the Mac WebKit2
Modified: trunk/LayoutTests/platform/efl/Skipped (111752 => 111753)
--- trunk/LayoutTests/platform/efl/Skipped 2012-03-22 20:42:38 UTC (rev 111752)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-03-22 20:43:12 UTC (rev 111753)
@@ -429,15 +429,6 @@
svg/custom/manually-parsed-svg-disallowed-in-dashboard.html
svg/custom/svg-disallowed-in-dashboard-object.html
-# EFL's LayoutTestController does not implement setViewModeMediaFeature
-fast/media/media-query-list-02.html
-fast/media/media-query-list-03.html
-fast/media/media-query-list-04.html
-fast/media/media-query-list-05.html
-fast/media/media-query-list-06.html
-fast/media/media-query-list-07.html
-fast/media/view-mode-media-feature.html
-
# EFL's LayoutTestController does not implement enableAutoResizeMode
fast/autoresize
Modified: trunk/Tools/ChangeLog (111752 => 111753)
--- trunk/Tools/ChangeLog 2012-03-22 20:42:38 UTC (rev 111752)
+++ trunk/Tools/ChangeLog 2012-03-22 20:43:12 UTC (rev 111753)
@@ -1,3 +1,17 @@
+2012-03-22 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
+ [EFL] Enable view mode media feature layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=81205
+
+ Adding missing implementation setViewModeMediaFeature to EFL's
+ LayoutTestController so that we can unskip view mode
+ media feature layout tests.
+
+ Reviewed by Antonio Gomes.
+
+ * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+ (LayoutTestController::setViewModeMediaFeature): Implemented.
+
2012-03-22 Dirk Pranke <dpra...@chromium.org>
nrwt: crash while stopping layout test helper on apple mac lion
Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (111752 => 111753)
--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-03-22 20:42:38 UTC (rev 111752)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-03-22 20:43:12 UTC (rev 111753)
@@ -263,9 +263,22 @@
DumpRenderTreeSupportEfl::setValueForUser(context, nodeObject, value);
}
-void LayoutTestController::setViewModeMediaFeature(JSStringRef)
+void LayoutTestController::setViewModeMediaFeature(JSStringRef mode)
{
- notImplemented();
+ Evas_Object* view = browser->mainView();
+ if (!view)
+ return;
+
+ if (equals(mode, "windowed"))
+ ewk_view_mode_set(view, EWK_VIEW_MODE_WINDOWED);
+ else if (equals(mode, "floating"))
+ ewk_view_mode_set(view, EWK_VIEW_MODE_FLOATING);
+ else if (equals(mode, "fullscreen"))
+ ewk_view_mode_set(view, EWK_VIEW_MODE_FULLSCREEN);
+ else if (equals(mode, "maximized"))
+ ewk_view_mode_set(view, EWK_VIEW_MODE_MAXIMIZED);
+ else if (equals(mode, "minimized"))
+ ewk_view_mode_set(view, EWK_VIEW_MODE_MINIMIZED);
}
void LayoutTestController::setWindowIsKey(bool)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
