Title: [111757] trunk/Source/WebKit/blackberry
- Revision
- 111757
- Author
- mifen...@rim.com
- Date
- 2012-03-22 13:58:15 -0700 (Thu, 22 Mar 2012)
Log Message
[BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
https://bugs.webkit.org/show_bug.cgi?id=81929
Reviewed by Rob Buis.
Make suggested style clean up and move int offset = 0 directly
above is actual usage.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isPositionInNode):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (111756 => 111757)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-03-22 20:51:48 UTC (rev 111756)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-03-22 20:58:15 UTC (rev 111757)
@@ -5,6 +5,19 @@
Reviewed by Rob Buis.
+ Make suggested style clean up and move int offset = 0 directly
+ above is actual usage.
+
+ * WebKitSupport/DOMSupport.cpp:
+ (BlackBerry::WebKit::DOMSupport::isPositionInNode):
+
+2012-03-22 Mike Fenton <mifen...@rim.com>
+
+ [BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
+ https://bugs.webkit.org/show_bug.cgi?id=81929
+
+ Reviewed by Rob Buis.
+
Add early returns in isPositionInNode when either
node or the position node is null.
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp (111756 => 111757)
--- trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-03-22 20:51:48 UTC (rev 111756)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-03-22 20:58:15 UTC (rev 111757)
@@ -296,11 +296,11 @@
if (!node)
return false;
- int offset = 0;
Node* domNodeAtPos = DOMContainerNodeForPosition(position);
if (!domNodeAtPos)
return false;
+ int offset = 0;
if (domNodeAtPos == position.containerNode())
offset = position.computeOffsetInContainerNode();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
