Title: [112341] trunk/Source/WebCore
Revision
112341
Author
alexis.men...@openbossa.org
Date
2012-03-27 17:27:27 -0700 (Tue, 27 Mar 2012)

Log Message

Simplify CSSPropertyBorderSpacing parsing.
https://bugs.webkit.org/show_bug.cgi?id=82397

Reviewed by Benjamin Poulain.

Remove the local array of longhand properties as it doesn't really
bring much in this simple parsing algorithm.

No new tests, no functionality change intended.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (112340 => 112341)


--- trunk/Source/WebCore/ChangeLog	2012-03-28 00:21:13 UTC (rev 112340)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 00:27:27 UTC (rev 112341)
@@ -1,3 +1,18 @@
+2012-03-27  Alexis Menard  <alexis.men...@openbossa.org>
+
+        Simplify CSSPropertyBorderSpacing parsing.
+        https://bugs.webkit.org/show_bug.cgi?id=82397
+
+        Reviewed by Benjamin Poulain.
+
+        Remove the local array of longhand properties as it doesn't really
+        bring much in this simple parsing algorithm.
+
+        No new tests, no functionality change intended.
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseValue):
+
 2012-03-27  Anders Carlsson  <ander...@apple.com>
 
         Fix race condition when initializing the scrolling thread

Modified: trunk/Source/WebCore/css/CSSParser.cpp (112340 => 112341)


--- trunk/Source/WebCore/css/CSSParser.cpp	2012-03-28 00:21:13 UTC (rev 112340)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-03-28 00:27:27 UTC (rev 112341)
@@ -1538,19 +1538,17 @@
         return parseFontWeight(important);
 
     case CSSPropertyBorderSpacing: {
-        const int properties[2] = { CSSPropertyWebkitBorderHorizontalSpacing,
-                                    CSSPropertyWebkitBorderVerticalSpacing };
         if (num == 1) {
             ShorthandScope scope(this, CSSPropertyBorderSpacing);
-            if (!parseValue(properties[0], important))
+            if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important))
                 return false;
             CSSValue* value = m_parsedProperties.last().value();
-            addProperty(properties[1], value, important);
+            addProperty(CSSPropertyWebkitBorderVerticalSpacing, value, important);
             return true;
         }
         else if (num == 2) {
             ShorthandScope scope(this, CSSPropertyBorderSpacing);
-            if (!parseValue(properties[0], important) || !parseValue(properties[1], important))
+            if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important) || !parseValue(CSSPropertyWebkitBorderVerticalSpacing, important))
                 return false;
             return true;
         }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to