Title: [116703] trunk/Tools
- Revision
- 116703
- Author
- dpra...@chromium.org
- Date
- 2012-05-10 16:48:11 -0700 (Thu, 10 May 2012)
Log Message
[chromium] Set Valgrind environment variables for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=86156
Patch by Lei Zhang <thes...@chromium.org> on 2012-05-10
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.setup_environ_for_server):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (116702 => 116703)
--- trunk/Tools/ChangeLog 2012-05-10 23:38:02 UTC (rev 116702)
+++ trunk/Tools/ChangeLog 2012-05-10 23:48:11 UTC (rev 116703)
@@ -1,3 +1,13 @@
+2012-05-10 Lei Zhang <thes...@chromium.org>
+
+ [chromium] Set Valgrind environment variables for layout tests.
+ https://bugs.webkit.org/show_bug.cgi?id=86156
+
+ Reviewed by Dirk Pranke.
+
+ * Scripts/webkitpy/layout_tests/port/chromium.py:
+ (ChromiumPort.setup_environ_for_server):
+
2012-05-10 Raphael Kubo da Costa <rak...@webkit.org>
[webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (116702 => 116703)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-05-10 23:38:02 UTC (rev 116702)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-05-10 23:48:11 UTC (rev 116703)
@@ -235,6 +235,13 @@
def path_to_test_expectations_file(self):
return self.path_from_webkit_base('LayoutTests', 'platform', 'chromium', 'test_expectations.txt')
+ def setup_environ_for_server(self, server_name=None):
+ clean_env = super(ChromiumPort, self).setup_environ_for_server(server_name)
+ # Webkit Linux (valgrind layout) bot needs these envvars.
+ self._copy_value_from_environ_if_set(clean_env, 'VALGRIND_LIB')
+ self._copy_value_from_environ_if_set(clean_env, 'VALGRIND_LIB_INNER')
+ return clean_env
+
def default_results_directory(self):
try:
return self.path_from_chromium_base('webkit', self.get_option('configuration'), 'layout-test-results')
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
