Title: [121263] trunk/Tools
Revision
121263
Author
o...@webkit.org
Date
2012-06-26 08:00:43 -0700 (Tue, 26 Jun 2012)

Log Message

master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
https://bugs.webkit.org/show_bug.cgi?id=89215

We need it because it is deprecated and will be dropped in buildbot 0.8.7

Reviewed by Tony Chang.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CheckOutSource.__init__):
(Factory.__init__):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (121262 => 121263)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-06-26 14:39:59 UTC (rev 121262)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-06-26 15:00:43 UTC (rev 121263)
@@ -114,10 +114,14 @@
 class CheckOutSource(source.SVN):
     baseURL = "http://svn.webkit.org/repository/webkit/"
     mode = "update"
-    def __init__(self, *args, **kwargs):
-        source.SVN.__init__(self, baseURL=self.baseURL, defaultBranch="trunk", mode=self.mode, *args, **kwargs)
+    def __init__(self, **kwargs):
+        kwargs['baseURL'] = self.baseURL
+        kwargs['defaultBranch'] = "trunk"
+        kwargs['mode'] = self.mode
+        source.SVN.__init__(self, **kwargs)
 
 
+
 class InstallWin32Dependencies(shell.Compile):
     description = ["installing dependencies"]
     descriptionDone = ["installed dependencies"]
@@ -663,7 +667,7 @@
     def __init__(self, platform, configuration, architectures, buildOnly):
         factory.BuildFactory.__init__(self)
         self.addStep(ConfigureBuild, platform=platform, configuration=configuration, architecture=" ".join(architectures), buildOnly=buildOnly)
-        self.addStep(CheckOutSource)
+        self.addStep(CheckOutSource())
         # There are multiple Qt slaves running on same machines, so buildslaves shouldn't kill the processes of other slaves.
         if not platform.startswith("qt"):
             self.addStep(KillOldProcesses)

Modified: trunk/Tools/ChangeLog (121262 => 121263)


--- trunk/Tools/ChangeLog	2012-06-26 14:39:59 UTC (rev 121262)
+++ trunk/Tools/ChangeLog	2012-06-26 15:00:43 UTC (rev 121263)
@@ -1,3 +1,16 @@
+2012-06-26  Csaba Osztrogonác  <o...@webkit.org>
+
+        master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
+        https://bugs.webkit.org/show_bug.cgi?id=89215
+
+        We need it because it is deprecated and will be dropped in buildbot 0.8.7
+
+        Reviewed by Tony Chang.
+
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+        (CheckOutSource.__init__):
+        (Factory.__init__):
+
 2012-06-26  Simon Hausmann  <simon.hausm...@nokia.com>
 
         [Qt][Win] Symbols are not exported in QtWebKit5.dll
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to