Title: [121294] trunk/Tools
- Revision
- 121294
- Author
- o...@chromium.org
- Date
- 2012-06-26 16:00:43 -0700 (Tue, 26 Jun 2012)
Log Message
Fix failing garden-o-matic unittests
https://bugs.webkit.org/show_bug.cgi?id=90021
Reviewed by Adam Barth.
These had all just fallen out of date.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js (121293 => 121294)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js 2012-06-26 23:00:04 UTC (rev 121293)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js 2012-06-26 23:00:43 UTC (rev 121294)
@@ -56,7 +56,7 @@
});
});
-test("rebaseline", 4, function() {
+test("rebaseline", 3, function() {
var simulator = new NetworkSimulator();
var requests = [];
@@ -67,8 +67,8 @@
};
simulator.ajax = function(options)
{
- if (options.url.indexOf('/ping') != -1)
- ok(false, 'Recieved non-ping ajax request.');
+ if (options.url.indexOf('/ping') == -1)
+ ok(false, 'Received non-ping ajax request: ' + options.url);
simulator.scheduleCallback(options.success);
};
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (121293 => 121294)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2012-06-26 23:00:04 UTC (rev 121293)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2012-06-26 23:00:43 UTC (rev 121294)
@@ -326,8 +326,8 @@
'<div class="what">' +
'<div class="problem">Disasterifying:' +
'<ul class="effects">' +
- '<li class="builder"><a class="failing-builder" target="_blank" href="" class="version">lucid</span><span class="architecture">64-bit</span></a></li>' +
- '<li class="builder"><a class="failing-builder" target="_blank" href="" class="version">win7</span></a></li>' +
+ '<li class="builder"><a class="failing-builder" target="_blank" href="" class="version">lucid</span><span class="architecture">64-bit</span><span class="failures"> compile</span></a></li>' +
+ '<li class="builder"><a class="failing-builder" target="_blank" href="" class="version">win7</span><span class="failures"> webkit_tests, update</span></a></li>' +
'</ul>' +
'</div>' +
'<ul class="causes"></ul>' +
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js (121293 => 121294)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js 2012-06-26 23:00:04 UTC (rev 121293)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js 2012-06-26 23:00:43 UTC (rev 121294)
@@ -54,7 +54,7 @@
_onebar_ = new ui.onebar();
onebar.attach();
equal(onebar.innerHTML,
- '<div><select id="platform-picker"><option>Apple</option><option>Chromium</option></select></div>' +
+ '<div><select id="platform-picker"><option>Apple</option><option>Chromium</option><option>GTK</option></select></div>' +
'<ul class="ui-tabs-nav ui-helper-reset ui-helper-clearfix ui-widget-header ui-corner-all">' +
'<li class="ui-state-default ui-corner-top ui-tabs-selected ui-state-active"><a href="" Failures</a></li>' +
'<li class="ui-state-default ui-corner-top"><a href="" Failures</a></li>' +
Modified: trunk/Tools/ChangeLog (121293 => 121294)
--- trunk/Tools/ChangeLog 2012-06-26 23:00:04 UTC (rev 121293)
+++ trunk/Tools/ChangeLog 2012-06-26 23:00:43 UTC (rev 121294)
@@ -1,5 +1,18 @@
2012-06-26 Ojan Vafai <o...@chromium.org>
+ Fix failing garden-o-matic unittests
+ https://bugs.webkit.org/show_bug.cgi?id=90021
+
+ Reviewed by Adam Barth.
+
+ These had all just fallen out of date.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
+
+2012-06-26 Ojan Vafai <o...@chromium.org>
+
Fix platform picker change handler in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90010
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
