Title: [121374] trunk/Source/_javascript_Core
- Revision
- 121374
- Author
- fpi...@apple.com
- Date
- 2012-06-27 14:45:08 -0700 (Wed, 27 Jun 2012)
Log Message
x86 disassembler confuses immediates with addresses
https://bugs.webkit.org/show_bug.cgi?id=90099
Reviewed by Mark Hahnenberg.
Prepend "$" to immediates to disambiguate between immediates and addresses. This is in
accordance with the gas and AT&T syntax.
* disassembler/udis86/udis86_syn-att.c:
(gen_operand):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (121373 => 121374)
--- trunk/Source/_javascript_Core/ChangeLog 2012-06-27 21:25:33 UTC (rev 121373)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-06-27 21:45:08 UTC (rev 121374)
@@ -1,5 +1,18 @@
2012-06-27 Filip Pizlo <fpi...@apple.com>
+ x86 disassembler confuses immediates with addresses
+ https://bugs.webkit.org/show_bug.cgi?id=90099
+
+ Reviewed by Mark Hahnenberg.
+
+ Prepend "$" to immediates to disambiguate between immediates and addresses. This is in
+ accordance with the gas and AT&T syntax.
+
+ * disassembler/udis86/udis86_syn-att.c:
+ (gen_operand):
+
+2012-06-27 Filip Pizlo <fpi...@apple.com>
+
Add a comment clarifying Options::showDisassembly versus Options::showDFGDisassembly.
Rubber stamped by Mark Hahnenberg.
Modified: trunk/Source/_javascript_Core/disassembler/udis86/udis86_syn-att.c (121373 => 121374)
--- trunk/Source/_javascript_Core/disassembler/udis86/udis86_syn-att.c 2012-06-27 21:25:33 UTC (rev 121373)
+++ trunk/Source/_javascript_Core/disassembler/udis86/udis86_syn-att.c 2012-06-27 21:45:08 UTC (rev 121374)
@@ -109,7 +109,7 @@
}
if ( sext_size < 64 )
sext_mask = ( 1ull << sext_size ) - 1;
- mkasm( u, "0x" FMT64 "x", imm & sext_mask );
+ mkasm( u, "$0x" FMT64 "x", imm & sext_mask );
break;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
