Title: [121837] trunk/Tools
- Revision
- 121837
- Author
- ser...@webkit.org
- Date
- 2012-07-04 01:05:18 -0700 (Wed, 04 Jul 2012)
Log Message
[GTK] WebKit2 testing bot unable to find the build directory
https://bugs.webkit.org/show_bug.cgi?id=90523
Reviewed by Carlos Garcia Campos.
The presence of GNUmakefile was used to determine whether a given
directory was a valid build directory or not. That's not correct for
testing bots as we export only the minimum required stuff to run the
tests.
* gtk/common.py:
(get_build_path.is_valid_build_directory): added an extra check.:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (121836 => 121837)
--- trunk/Tools/ChangeLog 2012-07-04 07:53:20 UTC (rev 121836)
+++ trunk/Tools/ChangeLog 2012-07-04 08:05:18 UTC (rev 121837)
@@ -1,3 +1,18 @@
+2012-07-04 Sergio Villar Senin <svil...@igalia.com>
+
+ [GTK] WebKit2 testing bot unable to find the build directory
+ https://bugs.webkit.org/show_bug.cgi?id=90523
+
+ Reviewed by Carlos Garcia Campos.
+
+ The presence of GNUmakefile was used to determine whether a given
+ directory was a valid build directory or not. That's not correct for
+ testing bots as we export only the minimum required stuff to run the
+ tests.
+
+ * gtk/common.py:
+ (get_build_path.is_valid_build_directory): added an extra check.:
+
2012-07-04 Joe Thomas <joetho...@motorola.com>
Adding myself to committers list.
Modified: trunk/Tools/gtk/common.py (121836 => 121837)
--- trunk/Tools/gtk/common.py 2012-07-04 07:53:20 UTC (rev 121836)
+++ trunk/Tools/gtk/common.py 2012-07-04 08:05:18 UTC (rev 121837)
@@ -40,7 +40,8 @@
return build_dir
def is_valid_build_directory(path):
- return os.path.exists(os.path.join(path, 'GNUmakefile'))
+ return os.path.exists(os.path.join(path, 'GNUmakefile')) or \
+ os.path.exists(os.path.join(path, 'Programs', 'DumpRenderTree'))
if len(sys.argv[1:]) > 1 and os.path.exists(sys.argv[-1]) and is_valid_build_directory(sys.argv[-1]):
return sys.argv[-1]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
