- Revision
- 121898
- Author
- commit-qu...@webkit.org
- Date
- 2012-07-05 03:54:01 -0700 (Thu, 05 Jul 2012)
Log Message
[EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl.
https://bugs.webkit.org/show_bug.cgi?id=90542
Patch by Kihong Kwon <kihong.k...@samsung.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit:
NotificationClientEfl.cpp is changed to NotificationPresenterClientEfl.cpp
to be in line with other ports(qt, chromium, gtk).
* PlatformEfl.cmake:
Source/WebKit/efl:
Change class name from NotificationClientEfl to NotificationPresenterClientEfl
to be in line with other ports.(qt, chromium, blackberry)
* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/NotificationPresenterClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp.
(WebCore):
(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::~NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::show):
(WebCore::NotificationPresenterClientEfl::cancel):
(WebCore::NotificationPresenterClientEfl::notificationObjectDestroyed):
(WebCore::NotificationPresenterClientEfl::notificationControllerDestroyed):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):
* WebCoreSupport/NotificationPresenterClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.h.
(WebCore):
(NotificationPresenterClientEfl):
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (121897 => 121898)
--- trunk/Source/WebKit/ChangeLog 2012-07-05 10:52:48 UTC (rev 121897)
+++ trunk/Source/WebKit/ChangeLog 2012-07-05 10:54:01 UTC (rev 121898)
@@ -1,3 +1,15 @@
+2012-07-05 Kihong Kwon <kihong.k...@samsung.com>
+
+ [EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl.
+ https://bugs.webkit.org/show_bug.cgi?id=90542
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ NotificationClientEfl.cpp is changed to NotificationPresenterClientEfl.cpp
+ to be in line with other ports(qt, chromium, gtk).
+
+ * PlatformEfl.cmake:
+
2012-07-04 Tor Arne Vestbø <tor.arne.ves...@nokia.com>
[Qt] Remove a few un-needed load(features) after r121777
Modified: trunk/Source/WebKit/PlatformEfl.cmake (121897 => 121898)
--- trunk/Source/WebKit/PlatformEfl.cmake 2012-07-05 10:52:48 UTC (rev 121897)
+++ trunk/Source/WebKit/PlatformEfl.cmake 2012-07-05 10:54:01 UTC (rev 121898)
@@ -103,7 +103,7 @@
efl/WebCoreSupport/IconDatabaseClientEfl.cpp
efl/WebCoreSupport/StorageTrackerClientEfl.cpp
efl/WebCoreSupport/InspectorClientEfl.cpp
- efl/WebCoreSupport/NotificationClientEfl.cpp
+ efl/WebCoreSupport/NotificationPresenterClientEfl.cpp
efl/WebCoreSupport/PageClientEfl.cpp
efl/WebCoreSupport/PlatformStrategiesEfl.cpp
Modified: trunk/Source/WebKit/efl/ChangeLog (121897 => 121898)
--- trunk/Source/WebKit/efl/ChangeLog 2012-07-05 10:52:48 UTC (rev 121897)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-07-05 10:54:01 UTC (rev 121898)
@@ -1,3 +1,29 @@
+2012-07-05 Kihong Kwon <kihong.k...@samsung.com>
+
+ [EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl.
+ https://bugs.webkit.org/show_bug.cgi?id=90542
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Change class name from NotificationClientEfl to NotificationPresenterClientEfl
+ to be in line with other ports.(qt, chromium, blackberry)
+
+ * WebCoreSupport/ChromeClientEfl.cpp:
+ * WebCoreSupport/NotificationPresenterClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp.
+ (WebCore):
+ (WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
+ (WebCore::NotificationPresenterClientEfl::~NotificationPresenterClientEfl):
+ (WebCore::NotificationPresenterClientEfl::show):
+ (WebCore::NotificationPresenterClientEfl::cancel):
+ (WebCore::NotificationPresenterClientEfl::notificationObjectDestroyed):
+ (WebCore::NotificationPresenterClientEfl::notificationControllerDestroyed):
+ (WebCore::NotificationPresenterClientEfl::requestPermission):
+ (WebCore::NotificationPresenterClientEfl::checkPermission):
+ (WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):
+ * WebCoreSupport/NotificationPresenterClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.h.
+ (WebCore):
+ (NotificationPresenterClientEfl):
+
2012-07-02 Benjamin Poulain <bpoul...@apple.com>
Do not do any logging initialization when logging is disabled
Modified: trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp (121897 => 121898)
--- trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2012-07-05 10:52:48 UTC (rev 121897)
+++ trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2012-07-05 10:54:01 UTC (rev 121898)
@@ -62,7 +62,7 @@
#include <wtf/text/CString.h>
#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
-#include "NotificationClientEfl.h"
+#include "NotificationPresenterClientEfl.h"
#endif
#if ENABLE(SQL_DATABASE)
Deleted: trunk/Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp (121897 => 121898)
--- trunk/Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp 2012-07-05 10:52:48 UTC (rev 121897)
+++ trunk/Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp 2012-07-05 10:54:01 UTC (rev 121898)
@@ -1,74 +0,0 @@
-/*
- * Copyright (C) 2011 Samsung Electronics
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB. If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- */
-
-#include "config.h"
-#include "NotificationClientEfl.h"
-
-#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
-#include "NotImplemented.h"
-
-namespace WebCore {
-
-NotificationClientEfl::NotificationClientEfl()
-{
-}
-
-NotificationClientEfl::~NotificationClientEfl()
-{
-}
-
-bool NotificationClientEfl::show(Notification* notification)
-{
- notImplemented();
- return false;
-}
-
-void NotificationClientEfl::cancel(Notification* notification)
-{
- notImplemented();
-}
-
-void NotificationClientEfl::notificationObjectDestroyed(Notification* notification)
-{
- notImplemented();
-}
-
-void NotificationClientEfl::notificationControllerDestroyed()
-{
- notImplemented();
-}
-
-void NotificationClientEfl::requestPermission(ScriptExecutionContext* context, PassRefPtr<VoidCallback> callback)
-{
- notImplemented();
-}
-
-NotificationClient::Permission NotificationClientEfl::checkPermission(ScriptExecutionContext* context)
-{
- notImplemented();
- return PermissionDenied;
-}
-
-void NotificationClientEfl::cancelRequestsForPermission(ScriptExecutionContext* context)
-{
- notImplemented();
-}
-
-}
-#endif
Deleted: trunk/Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.h (121897 => 121898)
--- trunk/Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.h 2012-07-05 10:52:48 UTC (rev 121897)
+++ trunk/Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.h 2012-07-05 10:54:01 UTC (rev 121898)
@@ -1,46 +0,0 @@
-/*
- * Copyright (C) 2011 Samsung Electronics
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB. If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- */
-
-#ifndef NotificationClientEfl_h
-#define NotificationClientEfl_h
-
-#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
-#include "Notification.h"
-#include "NotificationClient.h"
-
-namespace WebCore {
-
-class NotificationClientEfl : public NotificationClient {
-
-public:
- NotificationClientEfl();
- ~NotificationClientEfl();
-
- virtual bool show(Notification*);
- virtual void cancel(Notification*);
- virtual void notificationObjectDestroyed(Notification*);
- virtual void notificationControllerDestroyed();
- virtual void requestPermission(ScriptExecutionContext*, PassRefPtr<VoidCallback>);
- virtual NotificationClient::Permission checkPermission(ScriptExecutionContext*);
- virtual void cancelRequestsForPermission(ScriptExecutionContext*);
-};
-
-}
-#endif
-#endif // NotificationClientEfl_h
Copied: trunk/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp (from rev 121896, trunk/Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp) (0 => 121898)
--- trunk/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp (rev 0)
+++ trunk/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp 2012-07-05 10:54:01 UTC (rev 121898)
@@ -0,0 +1,74 @@
+/*
+ * Copyright (C) 2011 Samsung Electronics
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public License
+ * along with this library; see the file COPYING.LIB. If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include "config.h"
+#include "NotificationPresenterClientEfl.h"
+
+#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
+#include "NotImplemented.h"
+
+namespace WebCore {
+
+NotificationPresenterClientEfl::NotificationPresenterClientEfl()
+{
+}
+
+NotificationPresenterClientEfl::~NotificationPresenterClientEfl()
+{
+}
+
+bool NotificationPresenterClientEfl::show(Notification* notification)
+{
+ notImplemented();
+ return false;
+}
+
+void NotificationPresenterClientEfl::cancel(Notification* notification)
+{
+ notImplemented();
+}
+
+void NotificationPresenterClientEfl::notificationObjectDestroyed(Notification* notification)
+{
+ notImplemented();
+}
+
+void NotificationPresenterClientEfl::notificationControllerDestroyed()
+{
+ notImplemented();
+}
+
+void NotificationPresenterClientEfl::requestPermission(ScriptExecutionContext* context, PassRefPtr<VoidCallback> callback)
+{
+ notImplemented();
+}
+
+NotificationClient::Permission NotificationPresenterClientEfl::checkPermission(ScriptExecutionContext* context)
+{
+ notImplemented();
+ return PermissionDenied;
+}
+
+void NotificationPresenterClientEfl::cancelRequestsForPermission(ScriptExecutionContext* context)
+{
+ notImplemented();
+}
+
+}
+#endif
Copied: trunk/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h (from rev 121896, trunk/Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.h) (0 => 121898)
--- trunk/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h (rev 0)
+++ trunk/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h 2012-07-05 10:54:01 UTC (rev 121898)
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2011 Samsung Electronics
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public License
+ * along with this library; see the file COPYING.LIB. If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#ifndef NotificationPresenterClientEfl_h
+#define NotificationPresenterClientEfl_h
+
+#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
+#include "Notification.h"
+#include "NotificationClient.h"
+
+namespace WebCore {
+
+class NotificationPresenterClientEfl : public NotificationClient {
+
+public:
+ NotificationPresenterClientEfl();
+ ~NotificationPresenterClientEfl();
+
+ virtual bool show(Notification*);
+ virtual void cancel(Notification*);
+ virtual void notificationObjectDestroyed(Notification*);
+ virtual void notificationControllerDestroyed();
+ virtual void requestPermission(ScriptExecutionContext*, PassRefPtr<VoidCallback>);
+ virtual NotificationClient::Permission checkPermission(ScriptExecutionContext*);
+ virtual void cancelRequestsForPermission(ScriptExecutionContext*);
+};
+
+}
+#endif
+#endif // NotificationPresenterClientEfl_h
