Title: [121906] trunk/Source/WebCore
- Revision
- 121906
- Author
- ca...@chromium.org
- Date
- 2012-07-05 08:27:26 -0700 (Thu, 05 Jul 2012)
Log Message
Web Inspector: timeline events in the vicinity of event dividers some times are tricky to expand
https://bugs.webkit.org/show_bug.cgi?id=90572
Reviewed by Pavel Feldman.
- do not use resources-event-divider-padding;
- make dividers larger and use border-color to visualize them;
- move resources-<color>-divider to timelinePanel.css, as they're not used outside of timeline;
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.createEventDivider):
* inspector/front-end/inspectorCommon.css:
* inspector/front-end/timelinePanel.css:
(.timeline .resources-event-divider):
(.resources-red-divider):
(.resources-blue-divider):
(.resources-orange-divider):
(.resources-divider.last):
(.timeline .resources-event-divider.timeline-frame-divider):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (121905 => 121906)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 15:17:43 UTC (rev 121905)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 15:27:26 UTC (rev 121906)
@@ -1,5 +1,27 @@
2012-07-04 Andrey Kosyakov <ca...@chromium.org>
+ Web Inspector: timeline events in the vicinity of event dividers some times are tricky to expand
+ https://bugs.webkit.org/show_bug.cgi?id=90572
+
+ Reviewed by Pavel Feldman.
+
+ - do not use resources-event-divider-padding;
+ - make dividers larger and use border-color to visualize them;
+ - move resources-<color>-divider to timelinePanel.css, as they're not used outside of timeline;
+
+ * inspector/front-end/TimelinePresentationModel.js:
+ (WebInspector.TimelinePresentationModel.createEventDivider):
+ * inspector/front-end/inspectorCommon.css:
+ * inspector/front-end/timelinePanel.css:
+ (.timeline .resources-event-divider):
+ (.resources-red-divider):
+ (.resources-blue-divider):
+ (.resources-orange-divider):
+ (.resources-divider.last):
+ (.timeline .resources-event-divider.timeline-frame-divider):
+
+2012-07-04 Andrey Kosyakov <ca...@chromium.org>
+
Web Inspector: incorrect height of main timeline pane after switching to memory mode
https://bugs.webkit.org/show_bug.cgi?id=90387
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js (121905 => 121906)
--- trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js 2012-07-05 15:17:43 UTC (rev 121905)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js 2012-07-05 15:27:26 UTC (rev 121906)
@@ -147,9 +147,6 @@
eventDivider.className = "resources-event-divider";
var recordTypes = WebInspector.TimelineModel.RecordType;
- var eventDividerPadding = document.createElement("div");
- eventDividerPadding.className = "resources-event-divider-padding";
-
if (recordType === recordTypes.MarkDOMContent)
eventDivider.className += " resources-blue-divider";
else if (recordType === recordTypes.MarkLoad)
@@ -160,10 +157,9 @@
eventDivider.className += " timeline-frame-divider";
if (title)
- eventDividerPadding.title = title;
+ eventDivider.title = title;
- eventDividerPadding.appendChild(eventDivider);
- return eventDividerPadding;
+ return eventDivider;
}
WebInspector.TimelinePresentationModel.prototype = {
Modified: trunk/Source/WebCore/inspector/front-end/inspectorCommon.css (121905 => 121906)
--- trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2012-07-05 15:17:43 UTC (rev 121905)
+++ trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2012-07-05 15:27:26 UTC (rev 121906)
@@ -115,22 +115,6 @@
z-index: 300;
}
-.resources-red-divider {
- background-color: rgba(255, 0, 0, 0.5);
-}
-
-.resources-blue-divider {
- background-color: rgba(0, 0, 255, 0.5);
-}
-
-.resources-orange-divider {
- background-color: rgba(255, 178, 23, 0.5);
-}
-
-.resources-divider.last {
- background-color: transparent;
-}
-
.resources-divider-label {
position: absolute;
top: 4px;
Modified: trunk/Source/WebCore/inspector/front-end/timelinePanel.css (121905 => 121906)
--- trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2012-07-05 15:17:43 UTC (rev 121905)
+++ trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2012-07-05 15:27:26 UTC (rev 121906)
@@ -572,9 +572,29 @@
.timeline .resources-event-divider {
height: 19px;
+ width: 8px;
+ border-left-width: 2px;
+ border-left-style: solid;
bottom: auto;
+ pointer-events: auto;
}
+.resources-red-divider {
+ border-color: rgba(255, 0, 0, 0.5);
+}
+
+.resources-blue-divider {
+ border-color: rgba(0, 0, 255, 0.5);
+}
+
+.resources-orange-divider {
+ border-color: rgba(255, 178, 23, 0.5);
+}
+
+.resources-divider.last {
+ border-color: transparent;
+}
+
.timeline.timeline-frame-overview .resources-divider {
height: 19px;
bottom: auto;
@@ -582,6 +602,7 @@
.timeline .resources-event-divider.timeline-frame-divider {
background-color: rgba(180, 180, 180, 0.8);
+ border-style: none;
width: 1px;
height: 100%;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
