Skip to site navigation (Press enter)

[webkit-changes] [124047] trunk/LayoutTests

commit-queue Mon, 30 Jul 2012 10:41:40 -0700

Title: [124047] trunk/LayoutTests

Revision: 124047
Author: commit-qu...@webkit.org
Date: 2012-07-30 10:41:47 -0700 (Mon, 30 Jul 2012)

Log Message

REGRESSION: Focused TR element draws its focus outline in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=85348


Patch by Pravin D <pravind....@gmail.com> on 2012-07-30
Reviewed by Julien Chaffraix.

The focus ring used to be drawn around the first row of the table section irrespective of the row in focus.
The issue was fixed by the bug http://www.webkit.org/b/92389 .
Adding a regression test case.

* fast/table/table-row-focus-ring-paint-expected.txt: Added.
* fast/table/table-row-focus-ring-paint.html: Added.
* platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Added.
* platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog

Added Paths

trunk/LayoutTests/fast/table/table-row-focus-ring-paint-expected.txt
trunk/LayoutTests/fast/table/table-row-focus-ring-paint.html
trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png
trunk/LayoutTests/platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png

Diff

Modified: trunk/LayoutTests/ChangeLog (124046 => 124047)


--- trunk/LayoutTests/ChangeLog	2012-07-30 17:40:49 UTC (rev 124046)
+++ trunk/LayoutTests/ChangeLog	2012-07-30 17:41:47 UTC (rev 124047)
@@ -1,3 +1,19 @@
+2012-07-30  Pravin D  <pravind....@gmail.com>
+
+        REGRESSION: Focused TR element draws its focus outline in the wrong place
+        https://bugs.webkit.org/show_bug.cgi?id=85348
+
+        Reviewed by Julien Chaffraix.
+
+        The focus ring used to be drawn around the first row of the table section irrespective of the row in focus.
+        The issue was fixed by the bug http://www.webkit.org/b/92389 .
+        Adding a regression test case. 
+
+        * fast/table/table-row-focus-ring-paint-expected.txt: Added.
+        * fast/table/table-row-focus-ring-paint.html: Added.
+        * platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Added.
+        * platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Added.
+
 2012-07-30  Julien Chaffraix  <jchaffr...@webkit.org>
 
         ASSERTION FAILED: !rect.isEmpty()  : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect &)

Added: trunk/LayoutTests/fast/table/table-row-focus-ring-paint-expected.txt (0 => 124047)


--- trunk/LayoutTests/fast/table/table-row-focus-ring-paint-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/table/table-row-focus-ring-paint-expected.txt	2012-07-30 17:41:47 UTC (rev 124047)
@@ -0,0 +1 @@
+

Added: trunk/LayoutTests/fast/table/table-row-focus-ring-paint.html (0 => 124047)


--- trunk/LayoutTests/fast/table/table-row-focus-ring-paint.html	                        (rev 0)
+++ trunk/LayoutTests/fast/table/table-row-focus-ring-paint.html	2012-07-30 17:41:47 UTC (rev 124047)
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html>
+<head>
+<title> Testcase for bug https://bugs.webkit.org/show_bug.cgi?id=85348 </title>
+<!-- 
+Issue: The focus ring used be drawn around the first row irrespective of the current focused row. The issue was fixed by the bug 
+       http://www.webkit.org/b/92389 .
+Description: The test case checks if the focus ring is drawn around currently focused table row.
+Expectation: Focus ring must be drawn around the green box and not around the yellow boxes.
+ -->
+<script>
+if(window.testRunner)
+    testRunner.dumpAsText(true);
+</script>
+</head>
+<body>
+<style>
+td {
+    width: 50px;
+    height: 50px;
+    background:yellow;
+ }
+</style>
+<table>
+  <tr>
+    <td></td>
+  </tr>
+  <tr id="row2" tabindex=0>
+    <td style="background:green"></td>
+  </tr>
+  <tr tabindex=0>
+    <td></td>
+  </tr>
+</table>
+<script>
+  document.getElementById('row2').focus();
+</script>
+</body>
+</html>

Added: trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png (0 => 124047)


--- trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png	2012-07-30 17:41:47 UTC (rev 124047)
@@ -0,0 +1,7 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksume1d161da93b04cd8216f865f58169454\xCFdgIDATx\x9C\xED\xDC1N\xDB`\x86a\E\xCAP\x89\x84kй\xE9\x95zj\xB8X\xC3\xD7 \xC8\xE6\xC9\xDD\xDA"\xD1+\xA1\xE7\xED\xF8\xC6W\xAC\xF3<_\xD0\xF9r\xEE\x9F\x8D\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\xD8\xEA\xB5\xC3+N\xE4?\xE8\x80\x8F\xC8
+@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@l\xF5ځy\x89\x9Fȋ\x815=\xED\xA6\xFDn\xB9!'Yo\xB6\xEB\xAB\xED\xB9W<3\xCC\xF3\x91;\xAA\xE9iwxכ\xEFw\xF7w\xCBoz\xA3\x9B\xEF7\xD3\xFE\xFE\xF2z\xD4X\xC0\x87r<\xB0\xE3\xC5\xC5|\xF9\xEDv\xB8\x9F\xF4V\xF3\xAF\xF9\xEF\xCEso\xF8\xC7G\xEE1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X\xB1\xD5ѧ\xEB\xCD\xF6\xF08Ɵ_\xDE\xF3\x87\x87q\xDA\xEF.\xAF\xC7sxf\x98\xE7\xF9\xE8\x8B\xE9i7\xED/\xBC\xE6\xBD֛\xEB\xAB\xED\xB9W<\xF3b`p\x9A\xE3?\xFEgXbŉ\xA4!\xF0\xF9\xC8 &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b &\xB0b \xB6z\xED\xC0\xBC\xC4
+\x80O\xC4
+@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@\xECt\xDFE\x9E`FS7IEND\xAEB`\x82
\ No newline at end of file

Added: trunk/LayoutTests/platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png (0 => 124047)


--- trunk/LayoutTests/platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png	                        (rev 0)
+++ trunk/LayoutTests/platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png	2012-07-30 17:41:47 UTC (rev 124047)
@@ -0,0 +1,6 @@
+\x89PNG
+
+
+IHDR X\x9Av\x82psBIT|d\x88	pHYs\xC4\xC4\x95+)tEXtchecksumb53ade2da02df4ea75bd3dae8a72a6d4\xACX\xF1
+aIDATx\x9C\xED\xDD\xC1j;EѮ\x90\xFF\xCE\xF3\x97+\x93/1q\xC0ڂh\xADQA\xD7@5\xF3\xA6N\xB7\x9F\xB5\xD6z\xBE\x9C>pd\x90 @F\x80d\x90 @F\x80\x99\xAF\xBF\xF5\xD9w\x8A#\xFCx\xA8yd\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @\xE6C\xF2<o\xAF\xD7k\xBD^\xAF\xF5z\x9E\xFF\xFE\x91\xEB\xCFT\x9E\xB5\xD6\xFA\xED\xCF\xDBk\xADo\xF5y\x8E\xB9\xEDy\xE0\x84w\xE4\x97ߞ\xDDgI\xADozl\xE0\xBD;\xC12O>ۻr\xDBIp\xC0~~k\xDC\p\x82	\x901\xC1\x82\xF63\xC1\xB7\x9C`\x82dL\xB0\x86\xE0\x80\xFDL\xB0\xC6m\xC1'\x98`\xAC!\xB8`?\xACq[p\xC0	&X@\xC6k.\xD8\xCFk\xDC\p\x82	\x901\xC1\x82\xF63\xC1\xB7\x9C`\x82dL\xB0\x86\xE0\x80\xFDL\xB0\xC6m\xC1'\x98`\xAC!\xB8`?\xACq[p\xC0	&X@\xC6k.\xD8\xCFk\xDC\p\x82	\x901\xC1\x82\xF63\xC1\xB7\x9C`\x82dL\xB0\x86\xE0\x80\xFDL\xB0\xC6m\xC1'\x98`\xAC!\xB8`?\xACq[p\xC0	&X@\xC6k.\xD8\xCFk\xDC\p\x82	\x901\xC1\x82\xF63\xC1\xB7\x9C`\x82dL\xB0\x86\xE0\x80\xFDL\xB0\xC6m\xC1'\x98`\xAC!\xB8`?\xACq[p\xC0	&X@\xC6k.\xD8\xCFk\xDC\p³\xD6Z\xBF\xFD\xE0y\xF3G9\xF0\xA9\xDE
+\x80\xCF\xF6\xC7	\xD6\xCF\xEFF<s\xFD\xFCC\xD7\xFFF`\xA7\xBFx\xF2\xEC=I΋\xA8\xF9:\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @F\x80d\x90 @\xE6\xEB\xC7o]\xFBN\\xC1 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 #@\x80\x8C2\xC8 \xF3\xA6\xC8zs\xC2\xE4\xE5IEND\xAEB`\x82
\ No newline at end of file

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes