Title: [126318] trunk/Source/WebKit2
Revision
126318
Author
jer.no...@apple.com
Date
2012-08-22 10:50:22 -0700 (Wed, 22 Aug 2012)

Log Message

Browser menu visible when calling webkitRequestFullscreen after user manually enters full screen mode
https://bugs.webkit.org/show_bug.cgi?id=93892

Reviewed by Eric Carlson.

Allow the full screen window to "Join All Spaces", so that once it's original full screen space is destroyed,
it can join the new one.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (126317 => 126318)


--- trunk/Source/WebKit2/ChangeLog	2012-08-22 17:41:40 UTC (rev 126317)
+++ trunk/Source/WebKit2/ChangeLog	2012-08-22 17:50:22 UTC (rev 126318)
@@ -1,3 +1,16 @@
+2012-08-22  Jer Noble  <jer.no...@apple.com>
+
+        Browser menu visible when calling webkitRequestFullscreen after user manually enters full screen mode
+        https://bugs.webkit.org/show_bug.cgi?id=93892
+
+        Reviewed by Eric Carlson.
+
+        Allow the full screen window to "Join All Spaces", so that once it's original full screen space is destroyed,
+        it can join the new one.
+
+        * UIProcess/mac/WKFullScreenWindowController.mm:
+        (-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
+
 2012-08-22  Alexey Proskuryakov  <a...@apple.com>
 
         [WK2] Support posting injected bundle messages to a page

Modified: trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (126317 => 126318)


--- trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm	2012-08-22 17:41:40 UTC (rev 126317)
+++ trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm	2012-08-22 17:50:22 UTC (rev 126318)
@@ -552,8 +552,13 @@
     finalBounds.origin = [[self window] convertScreenToBase:finalBounds.origin];
     WKWindowSetClipRect([self window], finalBounds);
 
-    [[self window] makeKeyAndOrderFront:self];
+    NSWindow* window = [self window];
+    NSWindowCollectionBehavior behavior = [window collectionBehavior];
+    [window setCollectionBehavior:(behavior | NSWindowCollectionBehaviorCanJoinAllSpaces)];
+    [window makeKeyAndOrderFront:self];
+    [window setCollectionBehavior:behavior];
 
+
     if (!_backgroundWindow)
         _backgroundWindow = createBackgroundFullscreenWindow(screenFrame);
     else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to