Modified: trunk/Tools/ChangeLog (128320 => 128321)
--- trunk/Tools/ChangeLog 2012-09-12 16:03:22 UTC (rev 128320)
+++ trunk/Tools/ChangeLog 2012-09-12 16:06:55 UTC (rev 128321)
@@ -1,3 +1,17 @@
+2012-09-12 Zan Dobersek <zandober...@gmail.com>
+
+ Flakiness dashboard doesn't recognize new Chromium Android test builder
+ https://bugs.webkit.org/show_bug.cgi?id=96523
+
+ Reviewed by Ojan Vafai.
+
+ Properly return 'ANDROID' as the Chromium platform for Android builders.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+ (chromiumPlatform):
+ * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+ (test):
+
2012-09-12 Simon Hausmann <simon.hausm...@nokia.com>
[Qt] Build on Windows requires bison/flex in PATH
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (128320 => 128321)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-09-12 16:03:22 UTC (rev 128320)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-09-12 16:06:55 UTC (rev 128321)
@@ -40,7 +40,7 @@
// FIXME: These platform names should probably be changed to match the directories in LayoutTests/platform
// instead of matching the values we use in the TestExpectations file.
-var PLATFORMS = ['LION', 'SNOWLEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID', 'APPLE_LION', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX', 'EFL'];
+var PLATFORMS = ['LION', 'SNOWLEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID', 'ANDROID', 'APPLE_LION', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX', 'EFL'];
var PLATFORM_UNIONS = {
'MAC': ['SNOWLEOPARD', 'LION'],
'WIN': ['XP', 'WIN7'],
@@ -285,6 +285,8 @@
return 'XP';
if (stringContains(builderNameUpperCase, 'LINUX'))
return 'LUCID';
+ if (stringContains(builderNameUpperCase, 'ANDROID'))
+ return 'ANDROID';
// The interactive bot is XP, but doesn't have an OS in it's name.
if (stringContains(builderNameUpperCase, 'INTERACTIVE'))
return 'XP';
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (128320 => 128321)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-09-12 16:03:22 UTC (rev 128320)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-09-12 16:06:55 UTC (rev 128321)
@@ -190,7 +190,7 @@
equal(realModifiers('BUGFOO'), '');
});
-test('allTestsWithSamePlatformAndBuildType', 13, function() {
+test('allTestsWithSamePlatformAndBuildType', 14, function() {
// FIXME: test that allTestsWithSamePlatformAndBuildType actually returns the right set of tests.
for (var i = 0; i < PLATFORMS.length; i++)
ok(g_allTestsByPlatformAndBuildType[PLATFORMS[i]]);
