Title: [128348] trunk
Revision
128348
Author
commit-qu...@webkit.org
Date
2012-09-12 12:23:37 -0700 (Wed, 12 Sep 2012)

Log Message

[chromium] Add a virtual test suite for fast/hidpi
https://bugs.webkit.org/show_bug.cgi?id=90192

Patch by Alex Sakhartchouk <ale...@chromium.org> on 2012-09-12
Reviewed by Dirk Pranke.

Tools:

Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
on the hardware accelerated path as the software path.

* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):

LayoutTests:

Making sure the new virtual tests have matching expectations to non-gpu ones

* platform/chromium/TestExpectations:
* platform/chromium/virtual/gpu/fast/hidpi/README.txt: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (128347 => 128348)


--- trunk/LayoutTests/ChangeLog	2012-09-12 19:21:41 UTC (rev 128347)
+++ trunk/LayoutTests/ChangeLog	2012-09-12 19:23:37 UTC (rev 128348)
@@ -1,3 +1,15 @@
+2012-09-12  Alex Sakhartchouk  <ale...@chromium.org>
+
+        [chromium] Add a virtual test suite for fast/hidpi
+        https://bugs.webkit.org/show_bug.cgi?id=90192
+
+        Reviewed by Dirk Pranke.
+
+        Making sure the new virtual tests have matching expectations to non-gpu ones 
+
+        * platform/chromium/TestExpectations:
+        * platform/chromium/virtual/gpu/fast/hidpi/README.txt: Added.
+
 2012-09-12  Sami Kyostila  <skyos...@google.com>
 
         Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128347 => 128348)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-12 19:21:41 UTC (rev 128347)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-12 19:23:37 UTC (rev 128348)
@@ -2653,6 +2653,8 @@
 // Swidth DRT to high DPI output mode, which temporarily breaks IMAGE
 BUGCR146756 LINUX WIN ANDROID MAC : fast/hidpi/broken-image-icon-hidpi.html = IMAGE
 BUGCR146756 LINUX WIN ANDROID MAC : fast/hidpi/broken-image-with-size-hidpi.html = IMAGE
+BUGCR146756 LINUX WIN ANDROID MAC : platform/chromium/virtual/gpu/fast/hidpi/broken-image-icon-hidpi.html = IMAGE
+BUGCR146756 LINUX WIN ANDROID MAC : platform/chromium/virtual/gpu/fast/hidpi/broken-image-with-size-hidpi.html = IMAGE
 
 // Flaky tests from ~r97647
 BUGWK70298 MAC : fast/table/border-collapsing/cached-69296.html = IMAGE
@@ -3618,6 +3620,7 @@
 BUGWK95813 : fast/innerHTML/innerHTML-iframe.html = TEXT PASS
 
 BUGWK96441 WIN DEBUG : fast/hidpi/gradient-with-scaled-ancestor.html = IMAGE
+BUGWK96441 : platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor.html = IMAGE
 
 BUGWK96041 LINUX : http/tests/cache/cancel-during-revalidation-succeeded.html = PASS TEXT
 

Added: trunk/LayoutTests/platform/chromium/virtual/gpu/fast/hidpi/README.txt (0 => 128348)


--- trunk/LayoutTests/platform/chromium/virtual/gpu/fast/hidpi/README.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium/virtual/gpu/fast/hidpi/README.txt	2012-09-12 19:23:37 UTC (rev 128348)
@@ -0,0 +1,2 @@
+# This suite runs the tests in LayoutTests/fast/hidpi with --force-compositing-mode
+# See the virtual_test_suites() method in Tools/Scripts/webkitpy/layout_tests/port/chromium.py.

Modified: trunk/Tools/ChangeLog (128347 => 128348)


--- trunk/Tools/ChangeLog	2012-09-12 19:21:41 UTC (rev 128347)
+++ trunk/Tools/ChangeLog	2012-09-12 19:23:37 UTC (rev 128348)
@@ -1,3 +1,18 @@
+2012-09-12  Alex Sakhartchouk  <ale...@chromium.org>
+
+        [chromium] Add a virtual test suite for fast/hidpi
+        https://bugs.webkit.org/show_bug.cgi?id=90192
+
+        Reviewed by Dirk Pranke.
+
+        Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
+        on the hardware accelerated path as the software path.
+
+        * DumpRenderTree/chromium/WebPreferences.cpp:
+        (WebPreferences::applyTo):
+        * Scripts/webkitpy/layout_tests/port/chromium.py:
+        (ChromiumPort.virtual_test_suites):
+
 2012-09-12  Adam Klein  <ad...@chromium.org>
 
         [chromium] Add content_browsertests to the flakiness dashboard

Modified: trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp (128347 => 128348)


--- trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp	2012-09-12 19:21:41 UTC (rev 128347)
+++ trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp	2012-09-12 19:23:37 UTC (rev 128348)
@@ -226,6 +226,7 @@
     settings->setAcceleratedPaintingEnabled(acceleratedPaintingEnabled);
     settings->setMediaPlaybackRequiresUserGesture(mediaPlaybackRequiresUserGesture);
     settings->setMockScrollbarsEnabled(mockScrollbarsEnabled);
+    settings->setApplyDefaultDeviceScaleFactorInCompositor(forceCompositingMode);
 
     // Fixed values.
     settings->setTextDirectionSubmenuInclusionBehaviorNeverIncluded();

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (128347 => 128348)


--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-09-12 19:21:41 UTC (rev 128347)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-09-12 19:23:37 UTC (rev 128348)
@@ -370,6 +370,9 @@
             VirtualTestSuite('platform/chromium/virtual/threaded/compositing/webgl',
                              'compositing/webgl',
                              ['--enable-threaded-compositing']),
+            VirtualTestSuite('platform/chromium/virtual/gpu/fast/hidpi',
+                             'fast/hidpi',
+                             ['--force-compositing-mode']),
         ]
 
     #
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to