Title: [128358] trunk/Source/WebKit/chromium
- Revision
- 128358
- Author
- e...@google.com
- Date
- 2012-09-12 14:04:13 -0700 (Wed, 12 Sep 2012)
Log Message
[chromium] Fix search tickmarks not disappearing when compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=96536
Reviewed by James Robinson.
view->invalidateRect() on the root frame just invalidates the
contents, since WebViewImpl doesn't know anything about scrollbar
layers. This causes an "InvalidateAll" to not actually invalidate the
scrollbars.
To fix this, make WebFrameImpl explicitly invalidate the
scrollbars when required.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::invalidateArea):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (128357 => 128358)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-12 20:57:25 UTC (rev 128357)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-12 21:04:13 UTC (rev 128358)
@@ -1,3 +1,21 @@
+2012-09-12 Adrienne Walker <e...@google.com>
+
+ [chromium] Fix search tickmarks not disappearing when compositing is enabled
+ https://bugs.webkit.org/show_bug.cgi?id=96536
+
+ Reviewed by James Robinson.
+
+ view->invalidateRect() on the root frame just invalidates the
+ contents, since WebViewImpl doesn't know anything about scrollbar
+ layers. This causes an "InvalidateAll" to not actually invalidate the
+ scrollbars.
+
+ To fix this, make WebFrameImpl explicitly invalidate the
+ scrollbars when required.
+
+ * src/WebFrameImpl.cpp:
+ (WebKit::WebFrameImpl::invalidateArea):
+
2012-09-12 Leandro Gracia Gil <leandrogra...@chromium.org>
[Chromium] Fix cases where find-in-page doesn't send a final update
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (128357 => 128358)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-12 20:57:25 UTC (rev 128357)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-12 21:04:13 UTC (rev 128358)
@@ -2573,13 +2573,13 @@
contentArea.move(-frameRect.x(), -frameRect.y());
view->invalidateRect(contentArea);
}
+ }
- if ((area & InvalidateScrollbar) == InvalidateScrollbar) {
- // Invalidate the vertical scroll bar region for the view.
- Scrollbar* scrollbar = view->verticalScrollbar();
- if (scrollbar)
- scrollbar->invalidate();
- }
+ if ((area & InvalidateScrollbar) == InvalidateScrollbar) {
+ // Invalidate the vertical scroll bar region for the view.
+ Scrollbar* scrollbar = view->verticalScrollbar();
+ if (scrollbar)
+ scrollbar->invalidate();
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
