Title: [128581] trunk/Tools
- Revision
- 128581
- Author
- pe...@chromium.org
- Date
- 2012-09-14 03:58:24 -0700 (Fri, 14 Sep 2012)
Log Message
The runtime/unsigned category should be valid in the cpp style-checker.
https://bugs.webkit.org/show_bug.cgi?id=96748
Reviewed by Csaba Osztrogonác.
This is causing the webkitpy tests to fail because it's not listed in the
category array. Furthermore, change an "int" to "long" because it's
throwing a double error in one of the earlier asserts.
* Scripts/webkitpy/style/checkers/cpp.py:
(CppChecker):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_names):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (128580 => 128581)
--- trunk/Tools/ChangeLog 2012-09-14 10:41:35 UTC (rev 128580)
+++ trunk/Tools/ChangeLog 2012-09-14 10:58:24 UTC (rev 128581)
@@ -1,3 +1,19 @@
+2012-09-14 Peter Beverloo <pe...@chromium.org>
+
+ The runtime/unsigned category should be valid in the cpp style-checker.
+ https://bugs.webkit.org/show_bug.cgi?id=96748
+
+ Reviewed by Csaba Osztrogonác.
+
+ This is causing the webkitpy tests to fail because it's not listed in the
+ category array. Furthermore, change an "int" to "long" because it's
+ throwing a double error in one of the earlier asserts.
+
+ * Scripts/webkitpy/style/checkers/cpp.py:
+ (CppChecker):
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+ (WebKitStyleTest.test_names):
+
2012-09-13 Kenneth Rohde Christiansen <kenn...@webkit.org>
Evas_Object* is a ref'ed structure, so tread it as such
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (128580 => 128581)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2012-09-14 10:41:35 UTC (rev 128580)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2012-09-14 10:58:24 UTC (rev 128581)
@@ -3600,6 +3600,7 @@
'runtime/sizeof',
'runtime/string',
'runtime/threadsafe_fn',
+ 'runtime/unsigned',
'runtime/virtual',
'whitespace/blank_line',
'whitespace/braces',
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (128580 => 128581)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2012-09-14 10:41:35 UTC (rev 128580)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2012-09-14 10:58:24 UTC (rev 128581)
@@ -4457,7 +4457,7 @@
'length_' + name_underscore_error_message)
self.assert_lint('unsigned _length;',
'_length' + name_underscore_error_message)
- self.assert_lint('unsigned int _length;',
+ self.assert_lint('unsigned long _length;',
'_length' + name_underscore_error_message)
self.assert_lint('unsigned long long _length;',
'_length' + name_underscore_error_message)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
