Title: [129753] trunk
Revision
129753
Author
vse...@chromium.org
Date
2012-09-27 04:39:58 -0700 (Thu, 27 Sep 2012)

Log Message

Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
https://bugs.webkit.org/show_bug.cgi?id=97768

Reviewed by Pavel Feldman.

Source/WebCore:

Open resource dialog now assumes implicit wildcard in the beginning of the query.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):

LayoutTests:

* inspector/filtered-item-selection-dialog-filtering-expected.txt:
* inspector/filtered-item-selection-dialog-filtering.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (129752 => 129753)


--- trunk/LayoutTests/ChangeLog	2012-09-27 11:22:49 UTC (rev 129752)
+++ trunk/LayoutTests/ChangeLog	2012-09-27 11:39:58 UTC (rev 129753)
@@ -1,3 +1,13 @@
+2012-09-27  Vsevolod Vlasov  <vse...@chromium.org>
+
+        Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
+        https://bugs.webkit.org/show_bug.cgi?id=97768
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/filtered-item-selection-dialog-filtering-expected.txt:
+        * inspector/filtered-item-selection-dialog-filtering.html:
+
 2012-09-27  Tommy Widenflycht  <tom...@google.com>
 
         MediaStream API: Update getUserMedia to match the latest specification

Modified: trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt (129752 => 129753)


--- trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt	2012-09-27 11:22:49 UTC (rev 129752)
+++ trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt	2012-09-27 11:39:58 UTC (rev 129753)
@@ -26,7 +26,7 @@
 }
 {
     input : "["abab","abaa","caab","baac","fooaab"]"
-    output : "[]"
+    output : "["caab","fooaab"]"
     query : "aab"
     title : "Duplicate symbols in query"
 }
@@ -37,9 +37,9 @@
     title : "Star in query"
 }
 {
-    input : "["abab","abaa","caab","baac","fooaab"]"
-    output : "["caab"]"
-    query : "?aab"
+    input : "["abab","abaa","caab","aqb","fooaab"]"
+    output : "["caab","aqb","fooaab"]"
+    query : "a?b"
     title : "Question in query"
 }
 {
@@ -50,7 +50,7 @@
 }
 {
     input : "["fooBarBaz","FooBarBaz","Foo_Bar_Baz","foo_bar_baz","foobarbaz","foobarBaz","afooBarBaz","aFooBarBaz","a fooBarBaz","fooBorBaz","fooBorCaz"]"
-    output : "["fooBarBaz"]"
+    output : "["fooBarBaz","afooBarBaz","a fooBarBaz"]"
     query : "fBaB"
     title : "Camel case matching"
 }

Modified: trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html (129752 => 129753)


--- trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html	2012-09-27 11:22:49 UTC (rev 129752)
+++ trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html	2012-09-27 11:39:58 UTC (rev 129753)
@@ -32,7 +32,7 @@
     checkQuery("Spaces in the input", "d.v ", ["div .visible", "div . visible "]);
     checkQuery("Duplicate symbols in query", "aab", ["abab", "abaa", "caab", "baac", "fooaab"]);
     checkQuery("Star in query", "*aab", ["abab", "abaa", "caab", "baac", "fooaab"]);
-    checkQuery("Question in query", "?aab", ["abab", "abaa", "caab", "baac", "fooaab"]);
+    checkQuery("Question in query", "a?b", ["abab", "abaa", "caab", "aqb", "fooaab"]);
     checkQuery("Dangerous input escaping", "^[]{}()\\.$*+?|", ["^[]{}()\\.$*+?|", "0123456789abcdef"]);
     checkQuery("Camel case matching", "fBaB", ["fooBarBaz", "FooBarBaz", "Foo_Bar_Baz", "foo_bar_baz", "foobarbaz", "foobarBaz", "afooBarBaz", "aFooBarBaz", "a fooBarBaz", "fooBorBaz", "fooBorCaz"]);
     checkQuery("Underscore matching", "fO_ba_b", ["foOBarBaz", "FoOBarBaz", "FoO_Bar_Baz", "foO_bar_baz", "foObarbaz", "foObarBaz", "afoOBarBaz", "aFoOBarBaz", "a foOBarBaz", "foOBorBaz", "foOBorCaz"]);

Modified: trunk/Source/WebCore/ChangeLog (129752 => 129753)


--- trunk/Source/WebCore/ChangeLog	2012-09-27 11:22:49 UTC (rev 129752)
+++ trunk/Source/WebCore/ChangeLog	2012-09-27 11:39:58 UTC (rev 129753)
@@ -1,3 +1,15 @@
+2012-09-27  Vsevolod Vlasov  <vse...@chromium.org>
+
+        Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
+        https://bugs.webkit.org/show_bug.cgi?id=97768
+
+        Reviewed by Pavel Feldman.
+
+        Open resource dialog now assumes implicit wildcard in the beginning of the query.
+
+        * inspector/front-end/FilteredItemSelectionDialog.js:
+        (WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):
+
 2012-09-27  Pavel Feldman  <pfeld...@chromium.org>
 
         Web Inspector: do not use InspectorInstrumentation::hasFrontends() check when collecting stacks

Modified: trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js (129752 => 129753)


--- trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js	2012-09-27 11:22:49 UTC (rev 129752)
+++ trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js	2012-09-27 11:39:58 UTC (rev 129753)
@@ -202,7 +202,7 @@
             regExpString = regExpString.replace(/(?!^)(\\\.|[_:-])/g, "[^._:-]*$1");
         else
             regExpString = regExpString.replace(/(?!^)(\\\.|[A-Z_:-])/g, "[^.A-Z_:-]*$1");
-        regExpString = "^" + "[^a-zA-Z0-9]*" + regExpString;
+        regExpString = regExpString;
         return new RegExp(regExpString, (ignoreCase ? "i" : "") + (isGlobal ? "g" : ""));
     },
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to