Title: [129798] trunk/Source/WebCore
- Revision
- 129798
- Author
- a...@chromium.org
- Date
- 2012-09-27 14:03:47 -0700 (Thu, 27 Sep 2012)
Log Message
Fix issue with ClassList which was hitting an assert in debug mode
https://bugs.webkit.org/show_bug.cgi?id=97820
Reviewed by Ojan Vafai.
http://trac.webkit.org/changeset/129779 hit asserts in debug mode when trying to use fastGetAttribute on an SVG element.
No new tests. No change in behavior.
* bindings/v8/V8Binding.h:
(WebCore::toNativeArguments):
* html/ClassList.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (129797 => 129798)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 20:59:57 UTC (rev 129797)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 21:03:47 UTC (rev 129798)
@@ -1,3 +1,18 @@
+2012-09-27 Erik Arvidsson <a...@chromium.org>
+
+ Fix issue with ClassList which was hitting an assert in debug mode
+ https://bugs.webkit.org/show_bug.cgi?id=97820
+
+ Reviewed by Ojan Vafai.
+
+ http://trac.webkit.org/changeset/129779 hit asserts in debug mode when trying to use fastGetAttribute on an SVG element.
+
+ No new tests. No change in behavior.
+
+ * bindings/v8/V8Binding.h:
+ (WebCore::toNativeArguments):
+ * html/ClassList.h:
+
2012-09-27 Philip Rogers <p...@google.com>
Rewrite multithreaded filter job dispatching
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (129797 => 129798)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-09-27 20:59:57 UTC (rev 129797)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-09-27 21:03:47 UTC (rev 129798)
@@ -222,13 +222,13 @@
}
template <class T>
- Vector<T> toNativeArguments(const v8::Arguments& args, size_t startIndex)
+ Vector<T> toNativeArguments(const v8::Arguments& args, int startIndex)
{
ASSERT(startIndex <= static_cast<size_t>(args.Length()));
Vector<T> result;
typedef NativeValueTraits<T> TraitsType;
- size_t length = args.Length();
- for (size_t i = startIndex; i < length; ++i)
+ int length = args.Length();
+ for (int i = startIndex; i < length; ++i)
result.append(TraitsType::nativeValue(args[i]));
return result;
}
Modified: trunk/Source/WebCore/html/ClassList.h (129797 => 129798)
--- trunk/Source/WebCore/html/ClassList.h 2012-09-27 20:59:57 UTC (rev 129797)
+++ trunk/Source/WebCore/html/ClassList.h 2012-09-27 21:03:47 UTC (rev 129798)
@@ -65,7 +65,7 @@
const SpaceSplitString& classNames() const;
- virtual AtomicString value() const OVERRIDE { return m_element->fastGetAttribute(classAttr); }
+ virtual AtomicString value() const OVERRIDE { return m_element->getAttribute(classAttr); }
virtual void setValue(const AtomicString& value) OVERRIDE { m_element->setAttribute(classAttr, value); }
Element* m_element;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
