Title: [138182] trunk/Source/WebCore
- Revision
- 138182
- Author
- roger_f...@apple.com
- Date
- 2012-12-19 11:24:37 -0800 (Wed, 19 Dec 2012)
Log Message
Popup menu on Windows should fade in instead of sliding in.
https://bugs.webkit.org/show_bug.cgi?id=105358
<rdar://problem/7611211>
Reviewed by Timothy Horton.
Changing popup menu display animation to match what most other Windows applications do.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::show):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (138181 => 138182)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 19:22:12 UTC (rev 138181)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 19:24:37 UTC (rev 138182)
@@ -1,3 +1,16 @@
+2012-12-18 Roger Fong <roger_f...@apple.com>
+
+ Popup menu on Windows should fade in instead of sliding in.
+ https://bugs.webkit.org/show_bug.cgi?id=105358
+ <rdar://problem/7611211>
+
+ Reviewed by Timothy Horton.
+
+ Changing popup menu display animation to match what most other Windows applications do.
+
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenuWin::show):
+
2012-12-19 Levi Weintraub <le...@chromium.org>
Correct missing touch event handler de-registration for nested Documents and DOMWindows
Modified: trunk/Source/WebCore/platform/win/PopupMenuWin.cpp (138181 => 138182)
--- trunk/Source/WebCore/platform/win/PopupMenuWin.cpp 2012-12-19 19:22:12 UTC (rev 138181)
+++ trunk/Source/WebCore/platform/win/PopupMenuWin.cpp 2012-12-19 19:24:37 UTC (rev 138182)
@@ -168,14 +168,8 @@
if (shouldAnimate) {
RECT viewRect = {0};
::GetWindowRect(hostWindow, &viewRect);
-
- if (!::IsRectEmpty(&viewRect)) {
- // Popups should slide into view away from the <select> box
- // NOTE: This may have to change for Vista
- DWORD slideDirection = (m_windowRect.y() < viewRect.top + view->contentsToWindow(r.location()).y()) ? AW_VER_NEGATIVE : AW_VER_POSITIVE;
-
- ::AnimateWindow(m_popup, defaultAnimationDuration, AW_SLIDE | slideDirection);
- }
+ if (!::IsRectEmpty(&viewRect))
+ ::AnimateWindow(m_popup, defaultAnimationDuration, AW_BLEND);
} else
#endif
::ShowWindow(m_popup, SW_SHOWNOACTIVATE);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
