Title: [138215] trunk/Source/WebKit/chromium
Revision
138215
Author
pilg...@chromium.org
Date
2012-12-19 21:23:07 -0800 (Wed, 19 Dec 2012)

Log Message

[Chromium] Remove all references to sharedWorkerRepository()
https://bugs.webkit.org/show_bug.cgi?id=104704

Reviewed by Darin Fisher.

Now that Chromium calls setSharedWorkerRepository upon
initializing WebKit (
https://codereview.chromium.org/10990121/ and
https://codereview.chromium.org/11576028/ ) and no longer
tries to override sharedWorkerRepository, it is safe to remove
all references to this function.

* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):
* src/SharedWorkerRepository.cpp:
(WebKit::sharedWorkerRepository):
(WebCore::SharedWorkerRepository::isAvailable):

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (138214 => 138215)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-20 04:07:42 UTC (rev 138214)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-20 05:23:07 UTC (rev 138215)
@@ -1,3 +1,24 @@
+2012-12-19  Mark Pilgrim  <pilg...@chromium.org>
+
+        [Chromium] Remove all references to sharedWorkerRepository()
+        https://bugs.webkit.org/show_bug.cgi?id=104704
+
+        Reviewed by Darin Fisher.
+
+        Now that Chromium calls setSharedWorkerRepository upon
+        initializing WebKit (
+        https://codereview.chromium.org/10990121/ and
+        https://codereview.chromium.org/11576028/ ) and no longer
+        tries to override sharedWorkerRepository, it is safe to remove
+        all references to this function.
+
+        * public/platform/WebKitPlatformSupport.h:
+        (WebKit):
+        (WebKit::WebKitPlatformSupport::idbFactory):
+        * src/SharedWorkerRepository.cpp:
+        (WebKit::sharedWorkerRepository):
+        (WebCore::SharedWorkerRepository::isAvailable):
+
 2012-12-19  Alexis Menard  <ale...@webkit.org>
 
         Implement CSS parsing for CSS transitions unprefixed.

Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (138214 => 138215)


--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2012-12-20 04:07:42 UTC (rev 138214)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2012-12-20 05:23:07 UTC (rev 138215)
@@ -36,7 +36,6 @@
 namespace WebKit {
 
 class WebIDBFactory; // FIXME: Does this belong in platform?
-class WebSharedWorkerRepository; // FIXME: Does this belong in platform?
 
 // FIXME: Eventually all these API will need to move to WebKit::Platform.
 class WebKitPlatformSupport : public Platform {
@@ -45,11 +44,6 @@
 
     virtual WebIDBFactory* idbFactory() { return 0; }
 
-
-    // Shared Workers ------------------------------------------------------
-
-    virtual WebSharedWorkerRepository* sharedWorkerRepository() { return 0; }
-
 protected:
     ~WebKitPlatformSupport() { }
 };

Modified: trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp (138214 => 138215)


--- trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2012-12-20 04:07:42 UTC (rev 138214)
+++ trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp	2012-12-20 05:23:07 UTC (rev 138215)
@@ -69,15 +69,8 @@
 
 static WebSharedWorkerRepository* sharedWorkerRepository()
 {
-    WebSharedWorkerRepository* repository;
-
-    repository = s_sharedWorkerRepository;
-    if (!repository) {
-        repository = webKitPlatformSupport()->sharedWorkerRepository();
-        setSharedWorkerRepository(repository);
-    }
-
-    return repository;
+    // Will only be non-zero if the embedder has set the shared worker repository upon initialization. Nothing in WebKit sets this.
+    return s_sharedWorkerRepository;
 }
 
 }
@@ -218,8 +211,6 @@
 
 bool SharedWorkerRepository::isAvailable()
 {
-    // Allow the WebKitPlatformSupport to determine if SharedWorkers
-    // are available.
     return WebKit::sharedWorkerRepository();
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to